{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3857","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3857/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3857/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3857/events","html_url":"https://github.com/codice/ddf/pull/3857","id":367003975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNTQzNjE5","number":3857,"title":"DDF-4163: Improve SynchronizedInstaller bundle error logging","user":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-04T23:13:01Z","updated_at":"2018-10-05T10:38:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3857","html_url":"https://github.com/codice/ddf/pull/3857","diff_url":"https://github.com/codice/ddf/pull/3857.diff","patch_url":"https://github.com/codice/ddf/pull/3857.patch"},"body":"#### What does this PR do?\r\n - Changing logging to print a diagnosis of the bundle instead of the headers & imports\r\n - Added an option to the wait-for-ready command to specify time to wait\r\n\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@troymohl \r\n@paouelle \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@coyotesqrl \r\n@figliold  \r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\nRun the wait for ready command on bundles in the failed/graceperiod state and ensure the logs look as expected.\r\n \r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets?\r\n[](https://codice.atlassian.net/browse/)\r\n\r\n#### Screenshots\r\n```\r\nadmin@root()> wait-for-ready -wt 100\r\n15:30:20,873 | INFO  | or-ready -wt 100 | installer.impl.SynchronizedInstallerImpl  444 | sync-installer-impl  | Printing unsatisfied bundle requirements:\r\n---------------------------------------------------------------\r\nBundle Name: DDF :: Admin Console :: Query :: Security :: LDAP\r\nStatus: Failure\r\nDiagnosis:\r\nBlueprint\r\n10/4/18 1:54 PM\r\nException:\r\nnull\r\njava.util.concurrent.TimeoutException\r\n\tat org.apache.aries.blueprint.container.BlueprintContainerImpl$1.run(BlueprintContainerImpl.java:373)\r\n\tat org.apache.aries.blueprint.utils.threading.impl.DiscardableRunnable.run(DiscardableRunnable.java:45)\r\n\tat java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n\tat java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)\r\n\tat java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\r\n\tat java.lang.Thread.run(Thread.java:748)\r\n\r\nMissing dependencies:\r\n(objectClass=org.codice.ddf.internal.admin.configurator.actions.ConfiguratorSuite)\r\nDeclarative Services\r\n\r\n\r\n---------------------------------------------------------------\r\nBundle Name: DDF :: Admin :: Configurator :: Transactional Implementation\r\nStatus: Resolved\r\nDiagnosis:\r\nDeclarative Services\r\n\r\n\r\n15:30:20,874 | ERROR | nsole user admin | org.apache.karaf.shell.support.ShellUtil  149 | che.karaf.shell.core | Exception caught while executing command\r\norg.codice.ddf.sync.installer.api.SynchronizedInstallerException: Bundles failed to start [admin-query-ldap, admin-configurator-impl]\r\n\tat org.codice.ddf.sync.installer.impl.SynchronizedInstallerImpl.areBundlesReady(SynchronizedInstallerImpl.java:491) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.SynchronizedInstallerImpl.lambda$waitForBundles$4(SynchronizedInstallerImpl.java:391) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.SynchronizedInstallerImpl.wait(SynchronizedInstallerImpl.java:421) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.SynchronizedInstallerImpl.waitForBundles(SynchronizedInstallerImpl.java:394) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.SynchronizedInstallerImpl.waitForBootFinish(SynchronizedInstallerImpl.java:114) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.WaitForReadyCommand.lambda$execute$0(WaitForReadyCommand.java:69) ~[?:?]\r\n\tat java.security.AccessController.doPrivileged(Native Method) ~[?:?]\r\n\tat org.codice.ddf.sync.installer.impl.WaitForReadyCommand.execute(WaitForReadyCommand.java:60) ~[?:?]\r\n\tat org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84) ~[?:?]\r\n\tat org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68) ~[?:?]\r\n\tat org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:571) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:497) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Closure.execute(Closure.java:386) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) ~[?:?]\r\n\tat org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) ~[?:?]\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[?:?]\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[?:?]\r\n\tat java.lang.Thread.run(Thread.java:748) [?:?]\r\nError executing command: Bundles failed to start [admin-query-ldap, admin-configurator-impl]\r\n```\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/427320712","html_url":"https://github.com/codice/ddf/pull/3857#issuecomment-427320712","issue_url":"https://api.github.com/repos/codice/ddf/issues/3857","id":427320712,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzMyMDcxMg==","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T10:38:53Z","updated_at":"2018-10-05T10:38:53Z","author_association":"NONE","body":"\n![Codacy](https://app.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nIssues\n======\n- Added 3\n           \n\nComplexity decreasing per file\n==============================\n+ platform/sync-installer/sync-installer-impl/src/main/java/org/codice/ddf/sync/installer/impl/SynchronizedInstallerImpl.java  -1\n         \n```\n\n\nSee the complete overview on [Codacy](https://app.codacy.com/app/Codice/ddf/pullRequest?prid=2307531&bid=9083739)\n        "}}
{"actor":{"display_login":"codacy-bot"}}