{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/169370575","pull_request_review_id":97885763,"id":169370575,"diff_hunk":"@@ -66,6 +66,13 @@ module Socket = struct\n   type t = Unix of string | Port of int\n   module Unix = struct\n     let path x = \"unix:\" ^ x\n+    let rm   x =\n+      let dbg = debug \"error cleaning unix socket %s: %s\" x in\n+      try Unix.unlink x\n+      with\n+      | Unix.Unix_error (Unix.ENOENT, _, _) -> ()\n+      | Unix.Unix_error (e, _, _)           -> dbg (Unix.error_message e)\n+      | e                                   -> dbg (Printexc.to_string e)","path":"xc/device.ml","position":10,"original_position":10,"commit_id":"cc46f34363fa2521ae489f3beb57a6908f03dad5","original_commit_id":"cc46f34363fa2521ae489f3beb57a6908f03dad5","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"This should never happen when using a function in the `Unix` module","created_at":"2018-02-20T16:10:50Z","updated_at":"2018-02-20T16:10:51Z","html_url":"https://github.com/xapi-project/xenopsd/pull/456#discussion_r169370575","pull_request_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/169370575"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/456#discussion_r169370575"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456","id":170023790,"html_url":"https://github.com/xapi-project/xenopsd/pull/456","diff_url":"https://github.com/xapi-project/xenopsd/pull/456.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/456.patch","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/456","number":456,"state":"open","locked":false,"title":"CP-25681: Prevent leakage of QEMU runtime files","user":{"login":"mg12","id":590521,"avatar_url":"https://avatars0.githubusercontent.com/u/590521?v=4","gravatar_id":"","url":"https://api.github.com/users/mg12","html_url":"https://github.com/mg12","followers_url":"https://api.github.com/users/mg12/followers","following_url":"https://api.github.com/users/mg12/following{/other_user}","gists_url":"https://api.github.com/users/mg12/gists{/gist_id}","starred_url":"https://api.github.com/users/mg12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg12/subscriptions","organizations_url":"https://api.github.com/users/mg12/orgs","repos_url":"https://api.github.com/users/mg12/repos","events_url":"https://api.github.com/users/mg12/events{/privacy}","received_events_url":"https://api.github.com/users/mg12/received_events","type":"User","site_admin":false},"body":"The original idea of this patch was to prevent files /var/run/xen/vnc-* accumulating between host reboots (contents in /var/run are cleaned up between reboots).\r\nWhile testing the initial commit, I noticed that also /var/run/xen/qemu-event-<domid> and /var/run/xen/qemu-libxl-<domid> were also accumulating, and added corresponding commits for them.\r\n\r\nTested while rebooting VMs and the host, and files are removed after being used. QMP events and commands seem to be working fine when paying with the VM and observing the logs.\r\n","created_at":"2018-02-19T18:00:59Z","updated_at":"2018-02-20T16:10:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5850974ebe9b5db26fc82796c08a4c4dee9cb07a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/456/comments","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/cc46f34363fa2521ae489f3beb57a6908f03dad5","head":{"label":"mg12:cp-25681","ref":"cp-25681","sha":"cc46f34363fa2521ae489f3beb57a6908f03dad5","user":{"login":"mg12","id":590521,"avatar_url":"https://avatars0.githubusercontent.com/u/590521?v=4","gravatar_id":"","url":"https://api.github.com/users/mg12","html_url":"https://github.com/mg12","followers_url":"https://api.github.com/users/mg12/followers","following_url":"https://api.github.com/users/mg12/following{/other_user}","gists_url":"https://api.github.com/users/mg12/gists{/gist_id}","starred_url":"https://api.github.com/users/mg12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg12/subscriptions","organizations_url":"https://api.github.com/users/mg12/orgs","repos_url":"https://api.github.com/users/mg12/repos","events_url":"https://api.github.com/users/mg12/events{/privacy}","received_events_url":"https://api.github.com/users/mg12/received_events","type":"User","site_admin":false},"repo":{"id":39200778,"name":"xenopsd","full_name":"mg12/xenopsd","owner":{"login":"mg12","id":590521,"avatar_url":"https://avatars0.githubusercontent.com/u/590521?v=4","gravatar_id":"","url":"https://api.github.com/users/mg12","html_url":"https://github.com/mg12","followers_url":"https://api.github.com/users/mg12/followers","following_url":"https://api.github.com/users/mg12/following{/other_user}","gists_url":"https://api.github.com/users/mg12/gists{/gist_id}","starred_url":"https://api.github.com/users/mg12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg12/subscriptions","organizations_url":"https://api.github.com/users/mg12/orgs","repos_url":"https://api.github.com/users/mg12/repos","events_url":"https://api.github.com/users/mg12/events{/privacy}","received_events_url":"https://api.github.com/users/mg12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mg12/xenopsd","description":"XCP toolstack domain manager","fork":true,"url":"https://api.github.com/repos/mg12/xenopsd","forks_url":"https://api.github.com/repos/mg12/xenopsd/forks","keys_url":"https://api.github.com/repos/mg12/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mg12/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mg12/xenopsd/teams","hooks_url":"https://api.github.com/repos/mg12/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/mg12/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/mg12/xenopsd/events","assignees_url":"https://api.github.com/repos/mg12/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/mg12/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/mg12/xenopsd/tags","blobs_url":"https://api.github.com/repos/mg12/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mg12/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mg12/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mg12/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mg12/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/mg12/xenopsd/languages","stargazers_url":"https://api.github.com/repos/mg12/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/mg12/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/mg12/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/mg12/xenopsd/subscription","commits_url":"https://api.github.com/repos/mg12/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mg12/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mg12/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mg12/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mg12/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/mg12/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mg12/xenopsd/merges","archive_url":"https://api.github.com/repos/mg12/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mg12/xenopsd/downloads","issues_url":"https://api.github.com/repos/mg12/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/mg12/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/mg12/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/mg12/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mg12/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/mg12/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/mg12/xenopsd/deployments","created_at":"2015-07-16T14:14:01Z","updated_at":"2016-02-03T16:27:19Z","pushed_at":"2018-02-20T15:25:18Z","git_url":"git://github.com/mg12/xenopsd.git","ssh_url":"git@github.com:mg12/xenopsd.git","clone_url":"https://github.com/mg12/xenopsd.git","svn_url":"https://github.com/mg12/xenopsd","homepage":null,"size":32770,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:qemu-upstream","ref":"qemu-upstream","sha":"5ac3045fb230f6068bcbce859d6662063c5f9cfb","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":7563740,"name":"xenopsd","full_name":"xapi-project/xenopsd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xenopsd","description":"XCP toolstack domain manager","fork":false,"url":"https://api.github.com/repos/xapi-project/xenopsd","forks_url":"https://api.github.com/repos/xapi-project/xenopsd/forks","keys_url":"https://api.github.com/repos/xapi-project/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xenopsd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xenopsd/events","assignees_url":"https://api.github.com/repos/xapi-project/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xenopsd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xenopsd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xenopsd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xenopsd/merges","archive_url":"https://api.github.com/repos/xapi-project/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xenopsd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xenopsd/deployments","created_at":"2013-01-11T17:19:31Z","updated_at":"2017-12-30T01:48:39Z","pushed_at":"2018-02-20T15:25:20Z","git_url":"git://github.com/xapi-project/xenopsd.git","ssh_url":"git@github.com:xapi-project/xenopsd.git","clone_url":"https://github.com/xapi-project/xenopsd.git","svn_url":"https://github.com/xapi-project/xenopsd","homepage":null,"size":32980,"stargazers_count":7,"watchers_count":7,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":54,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/456"},"issue":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/456"},"comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xenopsd/statuses/cc46f34363fa2521ae489f3beb57a6908f03dad5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mseri"}}