{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/170027075","pull_request_review_id":98649018,"id":170027075,"diff_hunk":"@@ -1,19 +1,57 @@\n #!/usr/bin/env node\n \n+const cp = require(\"child_process\");\n+const inquirer = require(\"inquirer\");\n+\n+function runCommand(command) {\n+\tcp.exec(command, (error, stdout, stderr) => {\n+\t\tif(!error) {\n+\t\t\tconsole.log(\"webpack-cli installed successfully\");\n+\t\t\treturn true;","path":"bin/webpack.js","position":10,"original_position":10,"commit_id":"ee4df5049018ee79490549d6ea26a04d2f2e44ca","original_commit_id":"ee4df5049018ee79490549d6ea26a04d2f2e44ca","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"body":"returning a value doesn't make sense here. It's an async function.\r\n\r\nMaybe you want to wrap this in a Promise:\r\n\r\n``` js\r\nreturn new Promise((resolve, reject) => {\r\n  ...\r\n  resolve(true);\r\n  ...\r\n});","created_at":"2018-02-22T17:04:51Z","updated_at":"2018-02-22T17:09:13Z","html_url":"https://github.com/webpack/webpack/pull/6467#discussion_r170027075","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/6467","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/170027075"},"html":{"href":"https://github.com/webpack/webpack/pull/6467#discussion_r170027075"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6467"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/6467","id":168287512,"html_url":"https://github.com/webpack/webpack/pull/6467","diff_url":"https://github.com/webpack/webpack/pull/6467.diff","patch_url":"https://github.com/webpack/webpack/pull/6467.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/6467","number":6467,"state":"open","locked":false,"title":"Prompt install cli","user":{"login":"PlayMa256","id":831308,"avatar_url":"https://avatars0.githubusercontent.com/u/831308?v=4","gravatar_id":"","url":"https://api.github.com/users/PlayMa256","html_url":"https://github.com/PlayMa256","followers_url":"https://api.github.com/users/PlayMa256/followers","following_url":"https://api.github.com/users/PlayMa256/following{/other_user}","gists_url":"https://api.github.com/users/PlayMa256/gists{/gist_id}","starred_url":"https://api.github.com/users/PlayMa256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlayMa256/subscriptions","organizations_url":"https://api.github.com/users/PlayMa256/orgs","repos_url":"https://api.github.com/users/PlayMa256/repos","events_url":"https://api.github.com/users/PlayMa256/events{/privacy}","received_events_url":"https://api.github.com/users/PlayMa256/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce?**\r\nFeature\r\n\r\n**Did you add tests for your changes?**\r\n`BinTestCases.test.js` aparrently were removed on next branch, should it be created again? I can update the PR if needed.\r\n\r\n**Summary**\r\nThis fixes #6157 \r\n\r\n**Does this PR introduce a breaking change?**\r\nNo.","created_at":"2018-02-09T16:42:07Z","updated_at":"2018-02-22T17:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2989bb021f7c35e26e9f8d8c2aab0a912367eaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":572712741,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":572817412,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20review-outdated","name":"PR: review-outdated","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/6467/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/6467/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/6467/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/ee4df5049018ee79490549d6ea26a04d2f2e44ca","head":{"label":"PlayMa256:prompt_install_cli","ref":"prompt_install_cli","sha":"ee4df5049018ee79490549d6ea26a04d2f2e44ca","user":{"login":"PlayMa256","id":831308,"avatar_url":"https://avatars0.githubusercontent.com/u/831308?v=4","gravatar_id":"","url":"https://api.github.com/users/PlayMa256","html_url":"https://github.com/PlayMa256","followers_url":"https://api.github.com/users/PlayMa256/followers","following_url":"https://api.github.com/users/PlayMa256/following{/other_user}","gists_url":"https://api.github.com/users/PlayMa256/gists{/gist_id}","starred_url":"https://api.github.com/users/PlayMa256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlayMa256/subscriptions","organizations_url":"https://api.github.com/users/PlayMa256/orgs","repos_url":"https://api.github.com/users/PlayMa256/repos","events_url":"https://api.github.com/users/PlayMa256/events{/privacy}","received_events_url":"https://api.github.com/users/PlayMa256/received_events","type":"User","site_admin":false},"repo":{"id":120640994,"name":"webpack","full_name":"PlayMa256/webpack","owner":{"login":"PlayMa256","id":831308,"avatar_url":"https://avatars0.githubusercontent.com/u/831308?v=4","gravatar_id":"","url":"https://api.github.com/users/PlayMa256","html_url":"https://github.com/PlayMa256","followers_url":"https://api.github.com/users/PlayMa256/followers","following_url":"https://api.github.com/users/PlayMa256/following{/other_user}","gists_url":"https://api.github.com/users/PlayMa256/gists{/gist_id}","starred_url":"https://api.github.com/users/PlayMa256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlayMa256/subscriptions","organizations_url":"https://api.github.com/users/PlayMa256/orgs","repos_url":"https://api.github.com/users/PlayMa256/repos","events_url":"https://api.github.com/users/PlayMa256/events{/privacy}","received_events_url":"https://api.github.com/users/PlayMa256/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PlayMa256/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":true,"url":"https://api.github.com/repos/PlayMa256/webpack","forks_url":"https://api.github.com/repos/PlayMa256/webpack/forks","keys_url":"https://api.github.com/repos/PlayMa256/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PlayMa256/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PlayMa256/webpack/teams","hooks_url":"https://api.github.com/repos/PlayMa256/webpack/hooks","issue_events_url":"https://api.github.com/repos/PlayMa256/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/PlayMa256/webpack/events","assignees_url":"https://api.github.com/repos/PlayMa256/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/PlayMa256/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/PlayMa256/webpack/tags","blobs_url":"https://api.github.com/repos/PlayMa256/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PlayMa256/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PlayMa256/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/PlayMa256/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PlayMa256/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/PlayMa256/webpack/languages","stargazers_url":"https://api.github.com/repos/PlayMa256/webpack/stargazers","contributors_url":"https://api.github.com/repos/PlayMa256/webpack/contributors","subscribers_url":"https://api.github.com/repos/PlayMa256/webpack/subscribers","subscription_url":"https://api.github.com/repos/PlayMa256/webpack/subscription","commits_url":"https://api.github.com/repos/PlayMa256/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/PlayMa256/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/PlayMa256/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/PlayMa256/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/PlayMa256/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/PlayMa256/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PlayMa256/webpack/merges","archive_url":"https://api.github.com/repos/PlayMa256/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PlayMa256/webpack/downloads","issues_url":"https://api.github.com/repos/PlayMa256/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/PlayMa256/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/PlayMa256/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/PlayMa256/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PlayMa256/webpack/labels{/name}","releases_url":"https://api.github.com/repos/PlayMa256/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/PlayMa256/webpack/deployments","created_at":"2018-02-07T16:30:38Z","updated_at":"2018-02-07T16:30:46Z","pushed_at":"2018-02-21T21:15:53Z","git_url":"git://github.com/PlayMa256/webpack.git","ssh_url":"git@github.com:PlayMa256/webpack.git","clone_url":"https://github.com/PlayMa256/webpack.git","svn_url":"https://github.com/PlayMa256/webpack","homepage":"https://webpack.js.org","size":12001,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"798eaa834af59835eedbd01ea9e2f4a6175ae9a1","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-02-22T16:37:16Z","pushed_at":"2018-02-22T16:55:28Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":11988,"stargazers_count":37294,"watchers_count":37294,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4688,"mirror_url":null,"archived":false,"open_issues_count":499,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4688,"open_issues":499,"watchers":37294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6467"},"html":{"href":"https://github.com/webpack/webpack/pull/6467"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/6467"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/6467/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6467/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6467/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/ee4df5049018ee79490549d6ea26a04d2f2e44ca"}},"author_association":"NONE"}}
{"actor":{"display_login":"sokra"}}