{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/comments/242907382","pull_request_review_id":186533000,"id":242907382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjkwNzM4Mg==","diff_hunk":"@@ -24,8 +24,9 @@ const authHeaderProvider = new BearerAuthHeaderProvider({\n });\n \n const clientsFactory = {\n-  createServiceMappingClient: (url) => new ServiceMappingClient(url, authHeaderProvider, skipSslValidation),\n-  createProvisioningClient: (url) => new ProvisioningClient(url, authHeaderProvider, skipSslValidation)\n+  createServiceMappingClient: (url) => new ServiceMappingClient(url, { authHeaderProvider, skipSslValidation }),\n+  createProvisioningClient: (url) =>\n+    new ProvisioningClient(url, { authHeaderProvider, skipSslValidation }, RequestStrategy.direct())","path":"lib/cf/broker/src/index.js","position":17,"original_position":17,"commit_id":"416bdb045932285d3a69dfa99a65dbb4360df317","original_commit_id":"416bdb045932285d3a69dfa99a65dbb4360df317","user":{"login":"martin-d-aleksandrov","id":16863871,"node_id":"MDQ6VXNlcjE2ODYzODcx","avatar_url":"https://avatars2.githubusercontent.com/u/16863871?v=4","gravatar_id":"","url":"https://api.github.com/users/martin-d-aleksandrov","html_url":"https://github.com/martin-d-aleksandrov","followers_url":"https://api.github.com/users/martin-d-aleksandrov/followers","following_url":"https://api.github.com/users/martin-d-aleksandrov/following{/other_user}","gists_url":"https://api.github.com/users/martin-d-aleksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-d-aleksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-d-aleksandrov/subscriptions","organizations_url":"https://api.github.com/users/martin-d-aleksandrov/orgs","repos_url":"https://api.github.com/users/martin-d-aleksandrov/repos","events_url":"https://api.github.com/users/martin-d-aleksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/martin-d-aleksandrov/received_events","type":"User","site_admin":false},"body":"Yes, we could. However I don't want to have this \"feature\" implemented within this particular change as it's purpose was other (moreover the change is already big enough).\r\nWe could enhance this as well some other things (like returning 422 instead of 400 in some cases) in the future.","created_at":"2018-12-19T13:02:28Z","updated_at":"2018-12-19T13:02:28Z","html_url":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136#discussion_r242907382","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/comments/242907382"},"html":{"href":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136#discussion_r242907382"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136"}},"in_reply_to_id":242830456},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136","id":236158794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTU4Nzk0","html_url":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136","diff_url":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136.diff","patch_url":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/1136","number":1136,"state":"open","locked":false,"title":"Collector 500","user":{"login":"martin-d-aleksandrov","id":16863871,"node_id":"MDQ6VXNlcjE2ODYzODcx","avatar_url":"https://avatars2.githubusercontent.com/u/16863871?v=4","gravatar_id":"","url":"https://api.github.com/users/martin-d-aleksandrov","html_url":"https://github.com/martin-d-aleksandrov","followers_url":"https://api.github.com/users/martin-d-aleksandrov/followers","following_url":"https://api.github.com/users/martin-d-aleksandrov/following{/other_user}","gists_url":"https://api.github.com/users/martin-d-aleksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-d-aleksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-d-aleksandrov/subscriptions","organizations_url":"https://api.github.com/users/martin-d-aleksandrov/orgs","repos_url":"https://api.github.com/users/martin-d-aleksandrov/repos","events_url":"https://api.github.com/users/martin-d-aleksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/martin-d-aleksandrov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-05T12:37:49Z","updated_at":"2018-12-19T13:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a46832b3487e976476f1ef48e5999486b2b296e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"HristoDobchev","id":18211864,"node_id":"MDQ6VXNlcjE4MjExODY0","avatar_url":"https://avatars0.githubusercontent.com/u/18211864?v=4","gravatar_id":"","url":"https://api.github.com/users/HristoDobchev","html_url":"https://github.com/HristoDobchev","followers_url":"https://api.github.com/users/HristoDobchev/followers","following_url":"https://api.github.com/users/HristoDobchev/following{/other_user}","gists_url":"https://api.github.com/users/HristoDobchev/gists{/gist_id}","starred_url":"https://api.github.com/users/HristoDobchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HristoDobchev/subscriptions","organizations_url":"https://api.github.com/users/HristoDobchev/orgs","repos_url":"https://api.github.com/users/HristoDobchev/repos","events_url":"https://api.github.com/users/HristoDobchev/events{/privacy}","received_events_url":"https://api.github.com/users/HristoDobchev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":371027411,"node_id":"MDU6TGFiZWwzNzEwMjc0MTE=","url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/1136/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/statuses/416bdb045932285d3a69dfa99a65dbb4360df317","head":{"label":"SAP:collector_500","ref":"collector_500","sha":"416bdb045932285d3a69dfa99a65dbb4360df317","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":78433781,"node_id":"MDEwOlJlcG9zaXRvcnk3ODQzMzc4MQ==","name":"cf-abacus","full_name":"SAP/cf-abacus","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cf-abacus","description":"CF usage metering and aggregation","fork":true,"url":"https://api.github.com/repos/SAP/cf-abacus","forks_url":"https://api.github.com/repos/SAP/cf-abacus/forks","keys_url":"https://api.github.com/repos/SAP/cf-abacus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cf-abacus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cf-abacus/teams","hooks_url":"https://api.github.com/repos/SAP/cf-abacus/hooks","issue_events_url":"https://api.github.com/repos/SAP/cf-abacus/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cf-abacus/events","assignees_url":"https://api.github.com/repos/SAP/cf-abacus/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cf-abacus/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cf-abacus/tags","blobs_url":"https://api.github.com/repos/SAP/cf-abacus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cf-abacus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cf-abacus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cf-abacus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cf-abacus/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cf-abacus/languages","stargazers_url":"https://api.github.com/repos/SAP/cf-abacus/stargazers","contributors_url":"https://api.github.com/repos/SAP/cf-abacus/contributors","subscribers_url":"https://api.github.com/repos/SAP/cf-abacus/subscribers","subscription_url":"https://api.github.com/repos/SAP/cf-abacus/subscription","commits_url":"https://api.github.com/repos/SAP/cf-abacus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cf-abacus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cf-abacus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cf-abacus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cf-abacus/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cf-abacus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cf-abacus/merges","archive_url":"https://api.github.com/repos/SAP/cf-abacus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cf-abacus/downloads","issues_url":"https://api.github.com/repos/SAP/cf-abacus/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cf-abacus/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cf-abacus/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cf-abacus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cf-abacus/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cf-abacus/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cf-abacus/deployments","created_at":"2017-01-09T14:00:03Z","updated_at":"2018-12-19T09:01:23Z","pushed_at":"2018-12-19T09:01:21Z","git_url":"git://github.com/SAP/cf-abacus.git","ssh_url":"git@github.com:SAP/cf-abacus.git","clone_url":"https://github.com/SAP/cf-abacus.git","svn_url":"https://github.com/SAP/cf-abacus","homepage":"","size":21265,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"cloudfoundry-incubator:master","ref":"master","sha":"cf49fa1ef78a39d6ccde40907335ea8b60e42dd1","user":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":39099954,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA5OTk1NA==","name":"cf-abacus","full_name":"cloudfoundry-incubator/cf-abacus","private":false,"owner":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry-incubator/cf-abacus","description":"CF usage metering and aggregation","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/deployments","created_at":"2015-07-14T20:58:02Z","updated_at":"2018-12-18T11:10:02Z","pushed_at":"2018-12-18T13:52:27Z","git_url":"git://github.com/cloudfoundry-incubator/cf-abacus.git","ssh_url":"git@github.com:cloudfoundry-incubator/cf-abacus.git","clone_url":"https://github.com/cloudfoundry-incubator/cf-abacus.git","svn_url":"https://github.com/cloudfoundry-incubator/cf-abacus","homepage":"","size":18791,"stargazers_count":85,"watchers_count":85,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":86,"open_issues":56,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136"},"html":{"href":"https://github.com/cloudfoundry-incubator/cf-abacus/pull/1136"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/1136"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/issues/1136/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/pulls/1136/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/cf-abacus/statuses/416bdb045932285d3a69dfa99a65dbb4360df317"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martin-d-aleksandrov"}}