{"action":"closed","number":2131,"pull_request":{"url":"https://api.github.com/repos/adempiere/adempiere/pulls/2131","id":229405105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDA1MTA1","html_url":"https://github.com/adempiere/adempiere/pull/2131","diff_url":"https://github.com/adempiere/adempiere/pull/2131.diff","patch_url":"https://github.com/adempiere/adempiere/pull/2131.patch","issue_url":"https://api.github.com/repos/adempiere/adempiere/issues/2131","number":2131,"state":"closed","locked":false,"title":"#2130 Enhanced validation for active employee","user":{"login":"yamelsenih","id":2333092,"node_id":"MDQ6VXNlcjIzMzMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2333092?v=4","gravatar_id":"","url":"https://api.github.com/users/yamelsenih","html_url":"https://github.com/yamelsenih","followers_url":"https://api.github.com/users/yamelsenih/followers","following_url":"https://api.github.com/users/yamelsenih/following{/other_user}","gists_url":"https://api.github.com/users/yamelsenih/gists{/gist_id}","starred_url":"https://api.github.com/users/yamelsenih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamelsenih/subscriptions","organizations_url":"https://api.github.com/users/yamelsenih/orgs","repos_url":"https://api.github.com/users/yamelsenih/repos","events_url":"https://api.github.com/users/yamelsenih/events{/privacy}","received_events_url":"https://api.github.com/users/yamelsenih/received_events","type":"User","site_admin":false},"body":"Fixes: #2130\r\nHi everyone, here a pull request for validate active employee for payroll, a example:\r\n\r\nI have two employees:\r\n - Garden Admin\r\n - Joe Block\r\n\r\nJoe Block also is a customer, currently if Joe Block is not from payroll then I must change flag **IsActive** to **N**, it is not good if we need use Joe Block as a customer.\r\n\r\nThis change just make a validation from **Employee Status** (if it is setted) and sort by **Start Date** field instead **HR_Employee_ID**\r\n\r\n![screenshot_20181108_112718](https://user-images.githubusercontent.com/2333092/48208582-83e8f400-e349-11e8-8c56-ba022bcc08f5.png)\r\n\r\n","created_at":"2018-11-08T15:29:26Z","updated_at":"2018-11-09T17:21:37Z","closed_at":"2018-11-09T17:21:37Z","merged_at":"2018-11-09T17:21:36Z","merge_commit_sha":"114b2f28383a89cf6db9a429ad3b608efeeb53ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"e-Evolution","id":786968,"node_id":"MDQ6VXNlcjc4Njk2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/786968?v=4","gravatar_id":"","url":"https://api.github.com/users/e-Evolution","html_url":"https://github.com/e-Evolution","followers_url":"https://api.github.com/users/e-Evolution/followers","following_url":"https://api.github.com/users/e-Evolution/following{/other_user}","gists_url":"https://api.github.com/users/e-Evolution/gists{/gist_id}","starred_url":"https://api.github.com/users/e-Evolution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-Evolution/subscriptions","organizations_url":"https://api.github.com/users/e-Evolution/orgs","repos_url":"https://api.github.com/users/e-Evolution/repos","events_url":"https://api.github.com/users/e-Evolution/events{/privacy}","received_events_url":"https://api.github.com/users/e-Evolution/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":410939433,"node_id":"MDU6TGFiZWw0MTA5Mzk0MzM=","url":"https://api.github.com/repos/adempiere/adempiere/labels/(HRM)%20Human%20Resource%20and%20Payroll%20Management","name":"(HRM) Human Resource and Payroll Management","color":"c2e0c6","default":false},{"id":164038685,"node_id":"MDU6TGFiZWwxNjQwMzg2ODU=","url":"https://api.github.com/repos/adempiere/adempiere/labels/01%20enhancement","name":"01 enhancement","color":"84b6eb","default":false},{"id":572336391,"node_id":"MDU6TGFiZWw1NzIzMzYzOTE=","url":"https://api.github.com/repos/adempiere/adempiere/labels/10%20Reviewed%20by%20Peer","name":"10 Reviewed by Peer","color":"df9cf4","default":false}],"milestone":{"url":"https://api.github.com/repos/adempiere/adempiere/milestones/2","html_url":"https://github.com/adempiere/adempiere/milestone/2","labels_url":"https://api.github.com/repos/adempiere/adempiere/milestones/2/labels","id":1434523,"node_id":"MDk6TWlsZXN0b25lMTQzNDUyMw==","number":2,"title":"3.9.1","description":"ADempiere Release 3.9.1 , celebrating the 12th anniversary of ADempiere!!!","creator":{"login":"mckayERP","id":5507616,"node_id":"MDQ6VXNlcjU1MDc2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5507616?v=4","gravatar_id":"","url":"https://api.github.com/users/mckayERP","html_url":"https://github.com/mckayERP","followers_url":"https://api.github.com/users/mckayERP/followers","following_url":"https://api.github.com/users/mckayERP/following{/other_user}","gists_url":"https://api.github.com/users/mckayERP/gists{/gist_id}","starred_url":"https://api.github.com/users/mckayERP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckayERP/subscriptions","organizations_url":"https://api.github.com/users/mckayERP/orgs","repos_url":"https://api.github.com/users/mckayERP/repos","events_url":"https://api.github.com/users/mckayERP/events{/privacy}","received_events_url":"https://api.github.com/users/mckayERP/received_events","type":"User","site_admin":false},"open_issues":210,"closed_issues":297,"state":"open","created_at":"2015-11-30T06:32:58Z","updated_at":"2018-11-09T17:21:37Z","due_on":"2018-09-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/adempiere/adempiere/pulls/2131/commits","review_comments_url":"https://api.github.com/repos/adempiere/adempiere/pulls/2131/comments","review_comment_url":"https://api.github.com/repos/adempiere/adempiere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adempiere/adempiere/issues/2131/comments","statuses_url":"https://api.github.com/repos/adempiere/adempiere/statuses/cfffe90a95f2dd3e399da7dcba06d33df3999edd","head":{"label":"erpcya:bugfix/#2130-Validation-For-Active-Employee","ref":"bugfix/#2130-Validation-For-Active-Employee","sha":"cfffe90a95f2dd3e399da7dcba06d33df3999edd","user":{"login":"erpcya","id":9543723,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9543723?v=4","gravatar_id":"","url":"https://api.github.com/users/erpcya","html_url":"https://github.com/erpcya","followers_url":"https://api.github.com/users/erpcya/followers","following_url":"https://api.github.com/users/erpcya/following{/other_user}","gists_url":"https://api.github.com/users/erpcya/gists{/gist_id}","starred_url":"https://api.github.com/users/erpcya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erpcya/subscriptions","organizations_url":"https://api.github.com/users/erpcya/orgs","repos_url":"https://api.github.com/users/erpcya/repos","events_url":"https://api.github.com/users/erpcya/events{/privacy}","received_events_url":"https://api.github.com/users/erpcya/received_events","type":"Organization","site_admin":false},"repo":{"id":122522532,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MjI1MzI=","name":"adempiere","full_name":"erpcya/adempiere","private":false,"owner":{"login":"erpcya","id":9543723,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9543723?v=4","gravatar_id":"","url":"https://api.github.com/users/erpcya","html_url":"https://github.com/erpcya","followers_url":"https://api.github.com/users/erpcya/followers","following_url":"https://api.github.com/users/erpcya/following{/other_user}","gists_url":"https://api.github.com/users/erpcya/gists{/gist_id}","starred_url":"https://api.github.com/users/erpcya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erpcya/subscriptions","organizations_url":"https://api.github.com/users/erpcya/orgs","repos_url":"https://api.github.com/users/erpcya/repos","events_url":"https://api.github.com/users/erpcya/events{/privacy}","received_events_url":"https://api.github.com/users/erpcya/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/erpcya/adempiere","description":"ADempiere Business Suite ERP/CRM/MFG/SCM/POS done the Bazaar way in an open and unabated fashion. Focus is on the Community that includes Subject Matter Specialists, Implementors and End-Users.","fork":true,"url":"https://api.github.com/repos/erpcya/adempiere","forks_url":"https://api.github.com/repos/erpcya/adempiere/forks","keys_url":"https://api.github.com/repos/erpcya/adempiere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erpcya/adempiere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erpcya/adempiere/teams","hooks_url":"https://api.github.com/repos/erpcya/adempiere/hooks","issue_events_url":"https://api.github.com/repos/erpcya/adempiere/issues/events{/number}","events_url":"https://api.github.com/repos/erpcya/adempiere/events","assignees_url":"https://api.github.com/repos/erpcya/adempiere/assignees{/user}","branches_url":"https://api.github.com/repos/erpcya/adempiere/branches{/branch}","tags_url":"https://api.github.com/repos/erpcya/adempiere/tags","blobs_url":"https://api.github.com/repos/erpcya/adempiere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erpcya/adempiere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erpcya/adempiere/git/refs{/sha}","trees_url":"https://api.github.com/repos/erpcya/adempiere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erpcya/adempiere/statuses/{sha}","languages_url":"https://api.github.com/repos/erpcya/adempiere/languages","stargazers_url":"https://api.github.com/repos/erpcya/adempiere/stargazers","contributors_url":"https://api.github.com/repos/erpcya/adempiere/contributors","subscribers_url":"https://api.github.com/repos/erpcya/adempiere/subscribers","subscription_url":"https://api.github.com/repos/erpcya/adempiere/subscription","commits_url":"https://api.github.com/repos/erpcya/adempiere/commits{/sha}","git_commits_url":"https://api.github.com/repos/erpcya/adempiere/git/commits{/sha}","comments_url":"https://api.github.com/repos/erpcya/adempiere/comments{/number}","issue_comment_url":"https://api.github.com/repos/erpcya/adempiere/issues/comments{/number}","contents_url":"https://api.github.com/repos/erpcya/adempiere/contents/{+path}","compare_url":"https://api.github.com/repos/erpcya/adempiere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erpcya/adempiere/merges","archive_url":"https://api.github.com/repos/erpcya/adempiere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erpcya/adempiere/downloads","issues_url":"https://api.github.com/repos/erpcya/adempiere/issues{/number}","pulls_url":"https://api.github.com/repos/erpcya/adempiere/pulls{/number}","milestones_url":"https://api.github.com/repos/erpcya/adempiere/milestones{/number}","notifications_url":"https://api.github.com/repos/erpcya/adempiere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erpcya/adempiere/labels{/name}","releases_url":"https://api.github.com/repos/erpcya/adempiere/releases{/id}","deployments_url":"https://api.github.com/repos/erpcya/adempiere/deployments","created_at":"2018-02-22T19:07:36Z","updated_at":"2018-11-08T13:14:33Z","pushed_at":"2018-11-08T23:08:52Z","git_url":"git://github.com/erpcya/adempiere.git","ssh_url":"git@github.com:erpcya/adempiere.git","clone_url":"https://github.com/erpcya/adempiere.git","svn_url":"https://github.com/erpcya/adempiere","homepage":"www.adempiere.net","size":1040892,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"adempiere:develop","ref":"develop","sha":"dfd0d6c6b3a8ac495a93cfc3660c11cbe4d31705","user":{"login":"adempiere","id":1263359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjMzNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1263359?v=4","gravatar_id":"","url":"https://api.github.com/users/adempiere","html_url":"https://github.com/adempiere","followers_url":"https://api.github.com/users/adempiere/followers","following_url":"https://api.github.com/users/adempiere/following{/other_user}","gists_url":"https://api.github.com/users/adempiere/gists{/gist_id}","starred_url":"https://api.github.com/users/adempiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adempiere/subscriptions","organizations_url":"https://api.github.com/users/adempiere/orgs","repos_url":"https://api.github.com/users/adempiere/repos","events_url":"https://api.github.com/users/adempiere/events{/privacy}","received_events_url":"https://api.github.com/users/adempiere/received_events","type":"Organization","site_admin":false},"repo":{"id":28942332,"node_id":"MDEwOlJlcG9zaXRvcnkyODk0MjMzMg==","name":"adempiere","full_name":"adempiere/adempiere","private":false,"owner":{"login":"adempiere","id":1263359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjMzNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1263359?v=4","gravatar_id":"","url":"https://api.github.com/users/adempiere","html_url":"https://github.com/adempiere","followers_url":"https://api.github.com/users/adempiere/followers","following_url":"https://api.github.com/users/adempiere/following{/other_user}","gists_url":"https://api.github.com/users/adempiere/gists{/gist_id}","starred_url":"https://api.github.com/users/adempiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adempiere/subscriptions","organizations_url":"https://api.github.com/users/adempiere/orgs","repos_url":"https://api.github.com/users/adempiere/repos","events_url":"https://api.github.com/users/adempiere/events{/privacy}","received_events_url":"https://api.github.com/users/adempiere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adempiere/adempiere","description":"ADempiere Business Suite ERP/CRM/MFG/SCM/POS done the Bazaar way in an open and unabated fashion. Focus is on the Community that includes Subject Matter Specialists, Implementors and End-Users.","fork":false,"url":"https://api.github.com/repos/adempiere/adempiere","forks_url":"https://api.github.com/repos/adempiere/adempiere/forks","keys_url":"https://api.github.com/repos/adempiere/adempiere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adempiere/adempiere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adempiere/adempiere/teams","hooks_url":"https://api.github.com/repos/adempiere/adempiere/hooks","issue_events_url":"https://api.github.com/repos/adempiere/adempiere/issues/events{/number}","events_url":"https://api.github.com/repos/adempiere/adempiere/events","assignees_url":"https://api.github.com/repos/adempiere/adempiere/assignees{/user}","branches_url":"https://api.github.com/repos/adempiere/adempiere/branches{/branch}","tags_url":"https://api.github.com/repos/adempiere/adempiere/tags","blobs_url":"https://api.github.com/repos/adempiere/adempiere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adempiere/adempiere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adempiere/adempiere/git/refs{/sha}","trees_url":"https://api.github.com/repos/adempiere/adempiere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adempiere/adempiere/statuses/{sha}","languages_url":"https://api.github.com/repos/adempiere/adempiere/languages","stargazers_url":"https://api.github.com/repos/adempiere/adempiere/stargazers","contributors_url":"https://api.github.com/repos/adempiere/adempiere/contributors","subscribers_url":"https://api.github.com/repos/adempiere/adempiere/subscribers","subscription_url":"https://api.github.com/repos/adempiere/adempiere/subscription","commits_url":"https://api.github.com/repos/adempiere/adempiere/commits{/sha}","git_commits_url":"https://api.github.com/repos/adempiere/adempiere/git/commits{/sha}","comments_url":"https://api.github.com/repos/adempiere/adempiere/comments{/number}","issue_comment_url":"https://api.github.com/repos/adempiere/adempiere/issues/comments{/number}","contents_url":"https://api.github.com/repos/adempiere/adempiere/contents/{+path}","compare_url":"https://api.github.com/repos/adempiere/adempiere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adempiere/adempiere/merges","archive_url":"https://api.github.com/repos/adempiere/adempiere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adempiere/adempiere/downloads","issues_url":"https://api.github.com/repos/adempiere/adempiere/issues{/number}","pulls_url":"https://api.github.com/repos/adempiere/adempiere/pulls{/number}","milestones_url":"https://api.github.com/repos/adempiere/adempiere/milestones{/number}","notifications_url":"https://api.github.com/repos/adempiere/adempiere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adempiere/adempiere/labels{/name}","releases_url":"https://api.github.com/repos/adempiere/adempiere/releases{/id}","deployments_url":"https://api.github.com/repos/adempiere/adempiere/deployments","created_at":"2015-01-08T01:15:53Z","updated_at":"2018-11-08T00:27:12Z","pushed_at":"2018-11-09T17:21:36Z","git_url":"git://github.com/adempiere/adempiere.git","ssh_url":"git@github.com:adempiere/adempiere.git","clone_url":"https://github.com/adempiere/adempiere.git","svn_url":"https://github.com/adempiere/adempiere","homepage":"www.adempiere.net","size":1031111,"stargazers_count":284,"watchers_count":284,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":473,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":458,"open_issues":473,"watchers":284,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/adempiere/adempiere/pulls/2131"},"html":{"href":"https://github.com/adempiere/adempiere/pull/2131"},"issue":{"href":"https://api.github.com/repos/adempiere/adempiere/issues/2131"},"comments":{"href":"https://api.github.com/repos/adempiere/adempiere/issues/2131/comments"},"review_comments":{"href":"https://api.github.com/repos/adempiere/adempiere/pulls/2131/comments"},"review_comment":{"href":"https://api.github.com/repos/adempiere/adempiere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adempiere/adempiere/pulls/2131/commits"},"statuses":{"href":"https://api.github.com/repos/adempiere/adempiere/statuses/cfffe90a95f2dd3e399da7dcba06d33df3999edd"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"marcalwestf","id":1789408,"node_id":"MDQ6VXNlcjE3ODk0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1789408?v=4","gravatar_id":"","url":"https://api.github.com/users/marcalwestf","html_url":"https://github.com/marcalwestf","followers_url":"https://api.github.com/users/marcalwestf/followers","following_url":"https://api.github.com/users/marcalwestf/following{/other_user}","gists_url":"https://api.github.com/users/marcalwestf/gists{/gist_id}","starred_url":"https://api.github.com/users/marcalwestf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcalwestf/subscriptions","organizations_url":"https://api.github.com/users/marcalwestf/orgs","repos_url":"https://api.github.com/users/marcalwestf/repos","events_url":"https://api.github.com/users/marcalwestf/events{/privacy}","received_events_url":"https://api.github.com/users/marcalwestf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":13,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"marcalwestf"}}