{"action":"created","issue":{"url":"https://api.github.com/repos/QISKit/qiskit-core/issues/602","repository_url":"https://api.github.com/repos/QISKit/qiskit-core","labels_url":"https://api.github.com/repos/QISKit/qiskit-core/issues/602/labels{/name}","comments_url":"https://api.github.com/repos/QISKit/qiskit-core/issues/602/comments","events_url":"https://api.github.com/repos/QISKit/qiskit-core/issues/602/events","html_url":"https://github.com/QISKit/qiskit-core/pull/602","id":336720130,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTA2Mzgx","number":602,"title":"[WIP] enable registration of add-on providers","user":{"login":"ewinston","id":25756217,"node_id":"MDQ6VXNlcjI1NzU2MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/25756217?v=4","gravatar_id":"","url":"https://api.github.com/users/ewinston","html_url":"https://github.com/ewinston","followers_url":"https://api.github.com/users/ewinston/followers","following_url":"https://api.github.com/users/ewinston/following{/other_user}","gists_url":"https://api.github.com/users/ewinston/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinston/subscriptions","organizations_url":"https://api.github.com/users/ewinston/orgs","repos_url":"https://api.github.com/users/ewinston/repos","events_url":"https://api.github.com/users/ewinston/events{/privacy}","received_events_url":"https://api.github.com/users/ewinston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-28T17:54:53Z","updated_at":"2018-06-29T06:05:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/QISKit/qiskit-core/pulls/602","html_url":"https://github.com/QISKit/qiskit-core/pull/602","diff_url":"https://github.com/QISKit/qiskit-core/pull/602.diff","patch_url":"https://github.com/QISKit/qiskit-core/pull/602.patch"},"body":"<!--\r\n⚠️ If you do not respect this template, your pull request will be closed.\r\n⚠️ Your pull request title should be short detailed and understandable for all.\r\n⚠️ Also, please add it in the CHANGELOG file under Unreleased section.\r\n⚠️ If your pull request fixes an open issue, please link to the issue.\r\n\r\n I have added the tests to cover my changes.\r\n✅ I have updated the documentation accordingly.\r\n✅ I have read the CONTRIBUTING document.\r\n-->\r\n\r\n### Summary\r\n\r\n\r\n\r\n### Details and comments\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/QISKit/qiskit-core/issues/comments/401256826","html_url":"https://github.com/QISKit/qiskit-core/pull/602#issuecomment-401256826","issue_url":"https://api.github.com/repos/QISKit/qiskit-core/issues/602","id":401256826,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTI1NjgyNg==","user":{"login":"ajavadia","id":8622381,"node_id":"MDQ6VXNlcjg2MjIzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8622381?v=4","gravatar_id":"","url":"https://api.github.com/users/ajavadia","html_url":"https://github.com/ajavadia","followers_url":"https://api.github.com/users/ajavadia/followers","following_url":"https://api.github.com/users/ajavadia/following{/other_user}","gists_url":"https://api.github.com/users/ajavadia/gists{/gist_id}","starred_url":"https://api.github.com/users/ajavadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajavadia/subscriptions","organizations_url":"https://api.github.com/users/ajavadia/orgs","repos_url":"https://api.github.com/users/ajavadia/repos","events_url":"https://api.github.com/users/ajavadia/events{/privacy}","received_events_url":"https://api.github.com/users/ajavadia/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T06:05:29Z","updated_at":"2018-06-29T06:05:29Z","author_association":"MEMBER","body":"All but 2 tests pass. @diego-plan9, can you please take a look? I tried to keep the original intent of your wrapper tests but was not sure about 2 cases:\r\n\r\n1. `test_register_backend_name_conflicts`: i think the tests you have written here make a lot of sense. I tried to do this using two accounts (perhaps private/public), and show that the second provider does get registered (but the `available_backends()` belong to the first one). However I don't know how to do this registration using 2 tokens. Can we mock or something?\r\n\r\n2. `test_register_bad_credentials`: do we want a QISKitError raised when the provider fails to initialize for whatever reason? If so, this should presumably go as a try-except in `wrapper.register()`. But I don't know how to avoid catching a broad except, because the failure could be for many reasons."}}
{"actor":{"display_login":"ajavadia"}}