{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8942","repository_url":"https://api.github.com/repos/mattermost/mattermost-server","labels_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8942/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8942/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8942/events","html_url":"https://github.com/mattermost/mattermost-server/issues/8942","id":331649223,"node_id":"MDU6SXNzdWUzMzE2NDkyMjM=","number":8942,"title":"[Help Wanted] [MM-10867] Clean up and add thorough tests to app/notification.go","user":{"login":"esethna","id":14333569,"node_id":"MDQ6VXNlcjE0MzMzNTY5","avatar_url":"https://avatars3.githubusercontent.com/u/14333569?v=4","gravatar_id":"","url":"https://api.github.com/users/esethna","html_url":"https://github.com/esethna","followers_url":"https://api.github.com/users/esethna/followers","following_url":"https://api.github.com/users/esethna/following{/other_user}","gists_url":"https://api.github.com/users/esethna/gists{/gist_id}","starred_url":"https://api.github.com/users/esethna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esethna/subscriptions","organizations_url":"https://api.github.com/users/esethna/orgs","repos_url":"https://api.github.com/users/esethna/repos","events_url":"https://api.github.com/users/esethna/events{/privacy}","received_events_url":"https://api.github.com/users/esethna/received_events","type":"User","site_admin":false},"labels":[{"id":486848485,"node_id":"MDU6TGFiZWw0ODY4NDg0ODU=","url":"https://api.github.com/repos/mattermost/mattermost-server/labels/Go","name":"Go","color":"0e8a16","default":false},{"id":667027853,"node_id":"MDU6TGFiZWw2NjcwMjc4NTM=","url":"https://api.github.com/repos/mattermost/mattermost-server/labels/Up%20For%20Grabs","name":"Up For Grabs","color":"8B4500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-12T15:51:27Z","updated_at":"2018-12-27T18:54:56Z","closed_at":null,"author_association":"MEMBER","body":"If you're interested please comment here and come [join our \"Contributors\" community channel](https://pre-release.mattermost.com/core/channels/tickets) on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please  [join our \"Developers\" community channel](https://pre-release.mattermost.com/core/channels/developers).\n\nNew contributors please see our [Developer's Guide](https://docs.mattermost.com/guides/developer.html), specifically for [machine setup](https://docs.mattermost.com/developer/developer-setup.html) and for [developer workflow](https://docs.mattermost.com/developer/developer-flow.html).\n\n----\n\n**Notes**: [Jira ticket](https://mattermost.atlassian.net/browse/MM-10867)\n\n\nClean/split up the `sendNotification` and other large functions in app/notification.go into smaller, more testable functions. Then add tests for these functions to throughly test as many cases as possible.\r\n\r\nGoal here is to reduce the chances of a bug being introduced into the complex and critical notification code paths by reducing complexity and thoroughly testing with unit tests."},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/comments/450209810","html_url":"https://github.com/mattermost/mattermost-server/issues/8942#issuecomment-450209810","issue_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8942","id":450209810,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIwOTgxMA==","user":{"login":"nitishm","id":1494003,"node_id":"MDQ6VXNlcjE0OTQwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494003?v=4","gravatar_id":"","url":"https://api.github.com/users/nitishm","html_url":"https://github.com/nitishm","followers_url":"https://api.github.com/users/nitishm/followers","following_url":"https://api.github.com/users/nitishm/following{/other_user}","gists_url":"https://api.github.com/users/nitishm/gists{/gist_id}","starred_url":"https://api.github.com/users/nitishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitishm/subscriptions","organizations_url":"https://api.github.com/users/nitishm/orgs","repos_url":"https://api.github.com/users/nitishm/repos","events_url":"https://api.github.com/users/nitishm/events{/privacy}","received_events_url":"https://api.github.com/users/nitishm/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T18:54:56Z","updated_at":"2018-12-27T18:54:56Z","author_association":"NONE","body":"@henzai Is this something a beginner to mattermost could tackle ? I haven't spent too much time in the codebase but am pretty well versed in Go. \r\n\r\nIf so I would like to take this on, as a way to get familiar with the server code. "}}
{"actor":{"display_login":"nitishm"}}