{"action":"opened","number":8264,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264","id":212288211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjg4MjEx","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8264","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8264.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8264.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8264","number":8264,"state":"open","locked":false,"title":"Feature/activity log coroutines","user":{"login":"planarvoid","id":1079756,"node_id":"MDQ6VXNlcjEwNzk3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1079756?v=4","gravatar_id":"","url":"https://api.github.com/users/planarvoid","html_url":"https://github.com/planarvoid","followers_url":"https://api.github.com/users/planarvoid/followers","following_url":"https://api.github.com/users/planarvoid/following{/other_user}","gists_url":"https://api.github.com/users/planarvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/planarvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planarvoid/subscriptions","organizations_url":"https://api.github.com/users/planarvoid/orgs","repos_url":"https://api.github.com/users/planarvoid/repos","events_url":"https://api.github.com/users/planarvoid/events{/privacy}","received_events_url":"https://api.github.com/users/planarvoid/received_events","type":"User","site_admin":false},"body":"This PR adds coroutines to Activity log. Most of the changes to the production code are relatively simple. The main change is going from \r\n```\r\ndispatcher.dispatch(FetchAction(FetchPayload()))\r\n@Subscribe\r\nfun onFetched(event: OnFetch){}\r\n```\r\nto the coroutine simplification\r\n```\r\nlaunch {\r\nval onFetch = store.fetchAction(FetchPayload())\r\nonFetched(onFetch)\r\n}\r\n```\r\nThis inlines the async call and makes the code more readable.\r\nTo test:\r\n- go to activity log\r\n- load next page\r\n- go to a detail\r\n- go back\r\n- click on rewind on an activity\r\n- you see a rewind item on the first position\r\n- rewind ends successfuly\r\n","created_at":"2018-08-31T06:41:27Z","updated_at":"2018-08-31T06:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":941907617,"node_id":"MDU6TGFiZWw5NDE5MDc2MTc=","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Activity%20Log","name":"Activity Log","color":"4ed34c","default":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/129","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestone/129","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/129/labels","id":3541454,"node_id":"MDk6TWlsZXN0b25lMzU0MTQ1NA==","number":129,"title":"10.9","description":"Code freeze: Sep 10th, 2018 App Store submission: Sep 24th, 2018 Release: Sep 24th, 2018","creator":{"login":"loremattei","id":4836764,"node_id":"MDQ6VXNlcjQ4MzY3NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4836764?v=4","gravatar_id":"","url":"https://api.github.com/users/loremattei","html_url":"https://github.com/loremattei","followers_url":"https://api.github.com/users/loremattei/followers","following_url":"https://api.github.com/users/loremattei/following{/other_user}","gists_url":"https://api.github.com/users/loremattei/gists{/gist_id}","starred_url":"https://api.github.com/users/loremattei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loremattei/subscriptions","organizations_url":"https://api.github.com/users/loremattei/orgs","repos_url":"https://api.github.com/users/loremattei/repos","events_url":"https://api.github.com/users/loremattei/events{/privacy}","received_events_url":"https://api.github.com/users/loremattei/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":16,"state":"open","created_at":"2018-08-02T09:07:32Z","updated_at":"2018-08-31T06:41:28Z","due_on":"2018-09-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8264/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/15cf1953a1296b2aedba068308f521586d0b596c","head":{"label":"wordpress-mobile:feature/activity_log_coroutines","ref":"feature/activity_log_coroutines","sha":"15cf1953a1296b2aedba068308f521586d0b596c","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA2NTY4","name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2018-08-31T02:13:26Z","pushed_at":"2018-08-31T06:35:45Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":202079,"stargazers_count":1824,"watchers_count":1824,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":949,"mirror_url":null,"archived":false,"open_issues_count":467,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":949,"open_issues":467,"watchers":1824,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"68239022164fa01ec4ac340ac47fe37da92bb2df","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA2NTY4","name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2018-08-31T02:13:26Z","pushed_at":"2018-08-31T06:35:45Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":202079,"stargazers_count":1824,"watchers_count":1824,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":949,"mirror_url":null,"archived":false,"open_issues_count":467,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":949,"open_issues":467,"watchers":1824,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/8264"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8264"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8264/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8264/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/15cf1953a1296b2aedba068308f521586d0b596c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":168,"deletions":187,"changed_files":7}}
{"actor":{"display_login":"planarvoid"}}