{"action":"created","issue":{"url":"https://api.github.com/repos/Fish-Git/hyperion/issues/74","repository_url":"https://api.github.com/repos/Fish-Git/hyperion","labels_url":"https://api.github.com/repos/Fish-Git/hyperion/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/Fish-Git/hyperion/issues/74/comments","events_url":"https://api.github.com/repos/Fish-Git/hyperion/issues/74/events","html_url":"https://github.com/Fish-Git/hyperion/issues/74","id":280760056,"number":74,"title":"Why do we have z/Arch facilities enabled for ESA/390?!","user":{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars1.githubusercontent.com/u/1486786?v=4","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false},"labels":[{"id":486903336,"url":"https://api.github.com/repos/Fish-Git/hyperion/labels/BUG","name":"BUG","color":"ee0701","default":false}],"state":"closed","locked":false,"assignee":{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars1.githubusercontent.com/u/1486786?v=4","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars1.githubusercontent.com/u/1486786?v=4","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-12-09T22:14:29Z","updated_at":"2018-04-05T15:37:39Z","closed_at":"2018-04-04T08:17:27Z","author_association":"OWNER","body":"I've been working on [overhauling Hercules's facilities support](https://github.com/Fish-Git/hyperion/issues/71) and I noticed something that doesn't seem right to me.\r\n\r\nIn source file `feat390.h` there are more than a few z/Architecture facilities being enabled that, _technically_ (if I'm reading the [SA22-7201-08 (June 2003) ESA/390 Principles of Operation](https://www-05.ibm.com/e-business/linkweb/publications/servlet/pbi.wss?PAG=C11&SSN=17LHE0006164548724&TRL=TXT&WRD=&PBL=sa22-7201-08&LST=ALL&RPP=10&submit=Start+search) manual correctly), should _not_ be enabled.\r\n\r\nPage 10-91 describes the behavior of the `STFL` _(Store Facility List)_ instruction and only documents facility bits _0-5_ and _16-20_.  It further states:\r\n\r\n>   _\"Bits 6-15 and 21-31 are reserved for indication\r\n>    of new facilities.  The bits are currently stored\r\n>    as zeros but may be stored as ones in the future.\"_\r\n\r\nYet, in header `feat390.h`, I'm seeing the following facilities being enabled:\r\n\r\n```\r\n   FEATURE_ETF2_ENHANCEMENT_FACILITY\r\n   FEATURE_ETF3_ENHANCEMENT_FACILITY\r\n   FEATURE_EXTENDED_TRANSLATION_FACILITY_3\r\n   FEATURE_FPS_ENHANCEMENT\r\n   FEATURE_FPS_EXTENSIONS\r\n   INTERLOCKED_ACCESS_FACILITY_2\r\n   FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_3\r\n   FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_4\r\n   FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY\r\n```\r\n\r\nwhich correspond to facility list bits 24, 30, 22, 41, 37, 52, 76, 77 and 7, respectively.\r\n\r\n_The enabling of the FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY facility (bit 7) is especially puzzling (highly questionable IMHO)._\r\n\r\nThe [ESA/390 Principles of Operation](https://www-05.ibm.com/e-business/linkweb/publications/servlet/pbi.wss?PAG=C11&SSN=17LHE0006164548724&TRL=TXT&WRD=&PBL=sa22-7201-08&LST=ALL&RPP=10&submit=Start+search) doesn't even list the `STFLE` _(Store Facility List Extended)_ instruction as being a valid instruction for the architecture (and as demonstrated doesn't consider facility list bit 7 to be valid either).\r\n\r\n**_Can someone please explain to me why these facilities are being enabled for ESA/390 when there's every indication that, according to available documentation, they *shouldn't* be?_**\r\n\r\nIs there something I'm missing or not understanding correctly about Hercules that for some reason may require them to be enabled?\r\n\r\nWould 390 guests suddenly stop working correctly if they were to be suddenly removed?\r\n\r\nInquiring minds would sure like to know! &nbsp; `:)`\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/Fish-Git/hyperion/issues/comments/378979292","html_url":"https://github.com/Fish-Git/hyperion/issues/74#issuecomment-378979292","issue_url":"https://api.github.com/repos/Fish-Git/hyperion/issues/74","id":378979292,"user":{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars1.githubusercontent.com/u/1486786?v=4","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T15:37:39Z","updated_at":"2018-04-05T15:37:39Z","author_association":"OWNER","body":"> STFLE should be available in ESA/390 mode if z/Architecture is installed\r\n\r\nWhy do you say that? STFLE is _not_ an N3 instruction, it is a _z/Architecture_ instruction, and thus should _not_ logically be available in ESA/390 mode (_regardless_ of whether z/Architecture happens to be installed or not).\r\n\r\nYou need to do a SIGP to switch to z/Architecture mode first (if STFL bit 1 is on) before you can execute the STFLE instruction. In ESA/390 mode, only STFL is available, and only provides information about ESA/390 facilities, but not about any z/Architecture facilities.\r\n\r\nIn order for the program to learn about z/Architecture facilities, it needs to first switch to z/Architecture (if STFL bit 1 is on) and then execute the z/Architecture STFLE instruction.\r\n\r\nAt least that's my understanding.\r\n"}}
{"actor":{"display_login":"Fish-Git"}}