{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/236842699","pull_request_review_id":178963506,"id":236842699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjg0MjY5OQ==","diff_hunk":"@@ -17,9 +17,9 @@ class QueryObject:\n     def __init__(\n             self,\n             granularity: str,\n-            groupby: List[str],\n-            metrics: List[Metric],\n-            filters: List[str],\n+            groupby: List[str] = None,","path":"superset/common/query_object.py","position":22,"original_position":22,"commit_id":"4e1682dc97efdfe8e61c920fcf07b63f1adea060","original_commit_id":"4e1682dc97efdfe8e61c920fcf07b63f1adea060","user":{"login":"williaster","id":4496521,"node_id":"MDQ6VXNlcjQ0OTY1MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4496521?v=4","gravatar_id":"","url":"https://api.github.com/users/williaster","html_url":"https://github.com/williaster","followers_url":"https://api.github.com/users/williaster/followers","following_url":"https://api.github.com/users/williaster/following{/other_user}","gists_url":"https://api.github.com/users/williaster/gists{/gist_id}","starred_url":"https://api.github.com/users/williaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williaster/subscriptions","organizations_url":"https://api.github.com/users/williaster/orgs","repos_url":"https://api.github.com/users/williaster/repos","events_url":"https://api.github.com/users/williaster/events{/privacy}","received_events_url":"https://api.github.com/users/williaster/received_events","type":"User","site_admin":false},"body":"any reason to not just default these to `[]` instead of `None` since we do below anyway?","created_at":"2018-11-27T20:56:46Z","updated_at":"2018-11-27T20:57:28Z","html_url":"https://github.com/apache/incubator-superset/pull/6423#discussion_r236842699","pull_request_url":"https://api.github.com/repos/apache/incubator-superset/pulls/6423","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/236842699"},"html":{"href":"https://github.com/apache/incubator-superset/pull/6423#discussion_r236842699"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6423"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/6423","id":232849623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODQ5NjIz","html_url":"https://github.com/apache/incubator-superset/pull/6423","diff_url":"https://github.com/apache/incubator-superset/pull/6423.diff","patch_url":"https://github.com/apache/incubator-superset/pull/6423.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/6423","number":6423,"state":"open","locked":false,"title":"[SIP-5] Build metrics in query_object in the client","user":{"login":"xtinec","id":1521435,"node_id":"MDQ6VXNlcjE1MjE0MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1521435?v=4","gravatar_id":"","url":"https://api.github.com/users/xtinec","html_url":"https://github.com/xtinec","followers_url":"https://api.github.com/users/xtinec/followers","following_url":"https://api.github.com/users/xtinec/following{/other_user}","gists_url":"https://api.github.com/users/xtinec/gists{/gist_id}","starred_url":"https://api.github.com/users/xtinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtinec/subscriptions","organizations_url":"https://api.github.com/users/xtinec/orgs","repos_url":"https://api.github.com/users/xtinec/repos","events_url":"https://api.github.com/users/xtinec/events{/privacy}","received_events_url":"https://api.github.com/users/xtinec/received_events","type":"User","site_admin":false},"body":"- Unify the metric interface (absorb the current plain string metric for built-in metric keys into the format used by adhoc metric)\r\n- Port the logic in adhocMetric on the client and process_metrics in the backend to the new typed Metrics class\r\n- Omit hasCustomLabel and formFromData properties from the new metric interface as their value can be inferred from label and optionName\r\n- Expose from the Metrics class both metrics and their labels as public methods to match the all_metrics and metric_labels fields in the backend code\r\n- Provide defaut values for filters, metrics and groupby in the backend\r\n@kristw @williaster @conglei  ","created_at":"2018-11-22T03:24:04Z","updated_at":"2018-11-27T20:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3469844791c581e12b0017e5d837e04cfcb79638","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/6423/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/6423/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/6423/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/4e1682dc97efdfe8e61c920fcf07b63f1adea060","head":{"label":"lyft:query-object-metrics","ref":"query-object-metrics","sha":"4e1682dc97efdfe8e61c920fcf07b63f1adea060","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":108907301,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg5MDczMDE=","name":"incubator-superset","full_name":"lyft/incubator-superset","private":false,"owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lyft/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":true,"url":"https://api.github.com/repos/lyft/incubator-superset","forks_url":"https://api.github.com/repos/lyft/incubator-superset/forks","keys_url":"https://api.github.com/repos/lyft/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/incubator-superset/teams","hooks_url":"https://api.github.com/repos/lyft/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/lyft/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/incubator-superset/events","assignees_url":"https://api.github.com/repos/lyft/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/incubator-superset/tags","blobs_url":"https://api.github.com/repos/lyft/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/lyft/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/lyft/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/lyft/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/lyft/incubator-superset/subscription","commits_url":"https://api.github.com/repos/lyft/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/incubator-superset/merges","archive_url":"https://api.github.com/repos/lyft/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/incubator-superset/downloads","issues_url":"https://api.github.com/repos/lyft/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/lyft/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/incubator-superset/deployments","created_at":"2017-10-30T20:53:33Z","updated_at":"2018-11-19T18:19:41Z","pushed_at":"2018-11-26T23:42:11Z","git_url":"git://github.com/lyft/incubator-superset.git","ssh_url":"git@github.com:lyft/incubator-superset.git","clone_url":"https://github.com/lyft/incubator-superset.git","svn_url":"https://github.com/lyft/incubator-superset","homepage":"","size":98940,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":5,"watchers":4,"default_branch":"lyft-master"}},"base":{"label":"apache:master","ref":"master","sha":"2916c4856721c0ec33c91ede2403a5ec90e2658a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2NDAxOA==","name":"incubator-superset","full_name":"apache/incubator-superset","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2018-11-27T20:50:23Z","pushed_at":"2018-11-27T20:03:53Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":95971,"stargazers_count":22043,"watchers_count":22043,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3964,"mirror_url":null,"archived":false,"open_issues_count":1082,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3964,"open_issues":1082,"watchers":22043,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6423"},"html":{"href":"https://github.com/apache/incubator-superset/pull/6423"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/6423"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/6423/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6423/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6423/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/4e1682dc97efdfe8e61c920fcf07b63f1adea060"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"williaster"}}