{"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments/237719964","pull_request_review_id":180090748,"id":237719964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzcxOTk2NA==","diff_hunk":"@@ -0,0 +1,53 @@\n+/****************************************************************************\n+ * Copyright 2018, Optimizely, Inc. and contributors                        *\n+ *                                                                          *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");          *\n+ * you may not use this file except in compliance with the License.         *\n+ * You may obtain a copy of the License at                                  *\n+ *                                                                          *\n+ *    http://www.apache.org/licenses/LICENSE-2.0                            *\n+ *                                                                          *\n+ * Unless required by applicable law or agreed to in writing, software      *\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,        *\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *\n+ * See the License for the specific language governing permissions and      *\n+ * limitations under the License.                                           *\n+ ***************************************************************************/\n+\n+#import <Foundation/Foundation.h>\n+\n+NS_ASSUME_NONNULL_BEGIN\n+\n+@interface NSObject (Validation)\n+\n+/**\n+ * Determines if object is a valid string type.","path":"OptimizelySDKCore/OptimizelySDKCore/OPTLYNSObject+Validation.h","position":24,"original_position":24,"commit_id":"4039a072e95521b56466651c8b884e4df65a2239","original_commit_id":"4039a072e95521b56466651c8b884e4df65a2239","user":{"login":"jaeopt","id":45045038,"node_id":"MDQ6VXNlcjQ1MDQ1MDM4","avatar_url":"https://avatars2.githubusercontent.com/u/45045038?v=4","gravatar_id":"","url":"https://api.github.com/users/jaeopt","html_url":"https://github.com/jaeopt","followers_url":"https://api.github.com/users/jaeopt/followers","following_url":"https://api.github.com/users/jaeopt/following{/other_user}","gists_url":"https://api.github.com/users/jaeopt/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeopt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeopt/subscriptions","organizations_url":"https://api.github.com/users/jaeopt/orgs","repos_url":"https://api.github.com/users/jaeopt/repos","events_url":"https://api.github.com/users/jaeopt/events{/privacy}","received_events_url":"https://api.github.com/users/jaeopt/received_events","type":"User","site_admin":false},"body":"clarify comment to [valid \"non-empty\" string type]","created_at":"2018-11-30T01:30:30Z","updated_at":"2018-11-30T01:37:31Z","html_url":"https://github.com/optimizely/objective-c-sdk/pull/335#discussion_r237719964","pull_request_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments/237719964"},"html":{"href":"https://github.com/optimizely/objective-c-sdk/pull/335#discussion_r237719964"},"pull_request":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335","id":231315577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzE1NTc3","html_url":"https://github.com/optimizely/objective-c-sdk/pull/335","diff_url":"https://github.com/optimizely/objective-c-sdk/pull/335.diff","patch_url":"https://github.com/optimizely/objective-c-sdk/pull/335.patch","issue_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/335","number":335,"state":"open","locked":false,"title":"fix(nullattributes): Accepting null attributes and eventTags","user":{"login":"msohailhussain","id":3163521,"node_id":"MDQ6VXNlcjMxNjM1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3163521?v=4","gravatar_id":"","url":"https://api.github.com/users/msohailhussain","html_url":"https://github.com/msohailhussain","followers_url":"https://api.github.com/users/msohailhussain/followers","following_url":"https://api.github.com/users/msohailhussain/following{/other_user}","gists_url":"https://api.github.com/users/msohailhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/msohailhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msohailhussain/subscriptions","organizations_url":"https://api.github.com/users/msohailhussain/orgs","repos_url":"https://api.github.com/users/msohailhussain/repos","events_url":"https://api.github.com/users/msohailhussain/events{/privacy}","received_events_url":"https://api.github.com/users/msohailhussain/received_events","type":"User","site_admin":false},"body":"Refactored code, added categories for validArray, validString, emptryString. \r\nNotificationListener should return those attributes what is sent by the end-user. It was returning empty dictionary if nil was sent. ","created_at":"2018-11-15T19:56:27Z","updated_at":"2018-11-30T01:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11c7d07f50f6977d60cecf77c4e27f0f2c825282","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},{"login":"thomaszurkan-optimizely","id":28317449,"node_id":"MDQ6VXNlcjI4MzE3NDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/28317449?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaszurkan-optimizely","html_url":"https://github.com/thomaszurkan-optimizely","followers_url":"https://api.github.com/users/thomaszurkan-optimizely/followers","following_url":"https://api.github.com/users/thomaszurkan-optimizely/following{/other_user}","gists_url":"https://api.github.com/users/thomaszurkan-optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaszurkan-optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaszurkan-optimizely/subscriptions","organizations_url":"https://api.github.com/users/thomaszurkan-optimizely/orgs","repos_url":"https://api.github.com/users/thomaszurkan-optimizely/repos","events_url":"https://api.github.com/users/thomaszurkan-optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/thomaszurkan-optimizely/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335/commits","review_comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335/comments","review_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/335/comments","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/4039a072e95521b56466651c8b884e4df65a2239","head":{"label":"optimizely:sohail/null-attribute-synced","ref":"sohail/null-attribute-synced","sha":"4039a072e95521b56466651c8b884e4df65a2239","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":69407259,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwNzI1OQ==","name":"objective-c-sdk","full_name":"optimizely/objective-c-sdk","private":false,"owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/optimizely/objective-c-sdk","description":"Optimizely X Objective-C SDK for iOS and tvOS","fork":false,"url":"https://api.github.com/repos/optimizely/objective-c-sdk","forks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/objective-c-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/objective-c-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/objective-c-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/objective-c-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/objective-c-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/objective-c-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/objective-c-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/objective-c-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/objective-c-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/objective-c-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/objective-c-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/objective-c-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/objective-c-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/deployments","created_at":"2016-09-27T23:32:27Z","updated_at":"2018-11-20T18:59:01Z","pushed_at":"2018-11-29T21:24:30Z","git_url":"git://github.com/optimizely/objective-c-sdk.git","ssh_url":"git@github.com:optimizely/objective-c-sdk.git","clone_url":"https://github.com/optimizely/objective-c-sdk.git","svn_url":"https://github.com/optimizely/objective-c-sdk","homepage":"","size":305350,"stargazers_count":13,"watchers_count":13,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":10,"watchers":13,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"792775038dc27c3a9099ad7828ab387ac65188fa","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":69407259,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwNzI1OQ==","name":"objective-c-sdk","full_name":"optimizely/objective-c-sdk","private":false,"owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/optimizely/objective-c-sdk","description":"Optimizely X Objective-C SDK for iOS and tvOS","fork":false,"url":"https://api.github.com/repos/optimizely/objective-c-sdk","forks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/objective-c-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/objective-c-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/objective-c-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/objective-c-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/objective-c-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/objective-c-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/objective-c-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/objective-c-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/objective-c-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/objective-c-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/objective-c-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/objective-c-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/objective-c-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/deployments","created_at":"2016-09-27T23:32:27Z","updated_at":"2018-11-20T18:59:01Z","pushed_at":"2018-11-29T21:24:30Z","git_url":"git://github.com/optimizely/objective-c-sdk.git","ssh_url":"git@github.com:optimizely/objective-c-sdk.git","clone_url":"https://github.com/optimizely/objective-c-sdk.git","svn_url":"https://github.com/optimizely/objective-c-sdk","homepage":"","size":305350,"stargazers_count":13,"watchers_count":13,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335"},"html":{"href":"https://github.com/optimizely/objective-c-sdk/pull/335"},"issue":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/335"},"comments":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/4039a072e95521b56466651c8b884e4df65a2239"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaeopt"}}