{"action":"created","comment":{"url":"https://api.github.com/repos/atlassian/smith/pulls/comments/229939205","pull_request_review_id":170556572,"id":229939205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTkzOTIwNQ==","diff_hunk":"@@ -497,6 +479,20 @@ func (st *resourceSyncTask) evalSpec(res *smith_v1.Resource, actual runtime.Obje\n \t}\n \tobj.SetOwnerReferences(refs)\n \n+\t// Object GroupKind-specific munging\n+\tswitch obj.GroupVersionKind().GroupKind() {\n+\tcase schema.GroupKind{Group: sc_v1b1.GroupName, Kind: \"ServiceInstance\"}:\n+\t\tobj, err = st.processServiceInstance(obj, actual, st.bundle.Namespace)","path":"pkg/controller/bundlec/resource_sync_task.go","position":48,"original_position":48,"commit_id":"29b8b3113e7d31c1a6c3a68e710deb4ccf36e8f1","original_commit_id":"29b8b3113e7d31c1a6c3a68e710deb4ccf36e8f1","user":{"login":"nilebox","id":6176360,"node_id":"MDQ6VXNlcjYxNzYzNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6176360?v=4","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"body":"Could just return there (and for deployment as well). Fine if you prefer to explicitly check error.","created_at":"2018-11-01T04:51:02Z","updated_at":"2018-11-01T04:51:02Z","html_url":"https://github.com/atlassian/smith/pull/360#discussion_r229939205","pull_request_url":"https://api.github.com/repos/atlassian/smith/pulls/360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/atlassian/smith/pulls/comments/229939205"},"html":{"href":"https://github.com/atlassian/smith/pull/360#discussion_r229939205"},"pull_request":{"href":"https://api.github.com/repos/atlassian/smith/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/atlassian/smith/pulls/360","id":227512087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTEyMDg3","html_url":"https://github.com/atlassian/smith/pull/360","diff_url":"https://github.com/atlassian/smith/pull/360.diff","patch_url":"https://github.com/atlassian/smith/pull/360.patch","issue_url":"https://api.github.com/repos/atlassian/smith/issues/360","number":360,"state":"open","locked":false,"title":"Simplify object spec pre-processing","user":{"login":"ash2k","id":126021,"node_id":"MDQ6VXNlcjEyNjAyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/126021?v=4","gravatar_id":"","url":"https://api.github.com/users/ash2k","html_url":"https://github.com/ash2k","followers_url":"https://api.github.com/users/ash2k/followers","following_url":"https://api.github.com/users/ash2k/following{/other_user}","gists_url":"https://api.github.com/users/ash2k/gists{/gist_id}","starred_url":"https://api.github.com/users/ash2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash2k/subscriptions","organizations_url":"https://api.github.com/users/ash2k/orgs","repos_url":"https://api.github.com/users/ash2k/repos","events_url":"https://api.github.com/users/ash2k/events{/privacy}","received_events_url":"https://api.github.com/users/ash2k/received_events","type":"User","site_admin":false},"body":"No functional changes.","created_at":"2018-11-01T04:44:29Z","updated_at":"2018-11-01T04:51:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e80773848cf502a9aba518d8889a1a4d92b4ae62","assignee":{"login":"ash2k","id":126021,"node_id":"MDQ6VXNlcjEyNjAyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/126021?v=4","gravatar_id":"","url":"https://api.github.com/users/ash2k","html_url":"https://github.com/ash2k","followers_url":"https://api.github.com/users/ash2k/followers","following_url":"https://api.github.com/users/ash2k/following{/other_user}","gists_url":"https://api.github.com/users/ash2k/gists{/gist_id}","starred_url":"https://api.github.com/users/ash2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash2k/subscriptions","organizations_url":"https://api.github.com/users/ash2k/orgs","repos_url":"https://api.github.com/users/ash2k/repos","events_url":"https://api.github.com/users/ash2k/events{/privacy}","received_events_url":"https://api.github.com/users/ash2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"ash2k","id":126021,"node_id":"MDQ6VXNlcjEyNjAyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/126021?v=4","gravatar_id":"","url":"https://api.github.com/users/ash2k","html_url":"https://github.com/ash2k","followers_url":"https://api.github.com/users/ash2k/followers","following_url":"https://api.github.com/users/ash2k/following{/other_user}","gists_url":"https://api.github.com/users/ash2k/gists{/gist_id}","starred_url":"https://api.github.com/users/ash2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash2k/subscriptions","organizations_url":"https://api.github.com/users/ash2k/orgs","repos_url":"https://api.github.com/users/ash2k/repos","events_url":"https://api.github.com/users/ash2k/events{/privacy}","received_events_url":"https://api.github.com/users/ash2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":800114130,"node_id":"MDU6TGFiZWw4MDAxMTQxMzA=","url":"https://api.github.com/repos/atlassian/smith/labels/cleanup","name":"cleanup","color":"fcb8de","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/atlassian/smith/pulls/360/commits","review_comments_url":"https://api.github.com/repos/atlassian/smith/pulls/360/comments","review_comment_url":"https://api.github.com/repos/atlassian/smith/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atlassian/smith/issues/360/comments","statuses_url":"https://api.github.com/repos/atlassian/smith/statuses/29b8b3113e7d31c1a6c3a68e710deb4ccf36e8f1","head":{"label":"atlassian:move-things","ref":"move-things","sha":"29b8b3113e7d31c1a6c3a68e710deb4ccf36e8f1","user":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":70860542,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg2MDU0Mg==","name":"smith","full_name":"atlassian/smith","private":false,"owner":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atlassian/smith","description":"Smith is a Kubernetes workflow engine / resource manager","fork":false,"url":"https://api.github.com/repos/atlassian/smith","forks_url":"https://api.github.com/repos/atlassian/smith/forks","keys_url":"https://api.github.com/repos/atlassian/smith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/smith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/smith/teams","hooks_url":"https://api.github.com/repos/atlassian/smith/hooks","issue_events_url":"https://api.github.com/repos/atlassian/smith/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/smith/events","assignees_url":"https://api.github.com/repos/atlassian/smith/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/smith/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/smith/tags","blobs_url":"https://api.github.com/repos/atlassian/smith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/smith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/smith/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/smith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/smith/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/smith/languages","stargazers_url":"https://api.github.com/repos/atlassian/smith/stargazers","contributors_url":"https://api.github.com/repos/atlassian/smith/contributors","subscribers_url":"https://api.github.com/repos/atlassian/smith/subscribers","subscription_url":"https://api.github.com/repos/atlassian/smith/subscription","commits_url":"https://api.github.com/repos/atlassian/smith/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/smith/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/smith/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/smith/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/smith/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/smith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/smith/merges","archive_url":"https://api.github.com/repos/atlassian/smith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/smith/downloads","issues_url":"https://api.github.com/repos/atlassian/smith/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/smith/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/smith/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/smith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/smith/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/smith/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/smith/deployments","created_at":"2016-10-14T00:54:42Z","updated_at":"2018-10-31T05:31:48Z","pushed_at":"2018-11-01T04:44:29Z","git_url":"git://github.com/atlassian/smith.git","ssh_url":"git@github.com:atlassian/smith.git","clone_url":"https://github.com/atlassian/smith.git","svn_url":"https://github.com/atlassian/smith","homepage":"","size":2560,"stargazers_count":201,"watchers_count":201,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":23,"watchers":201,"default_branch":"master"}},"base":{"label":"atlassian:master","ref":"master","sha":"f712297ae673b08d2cf5450842050dbb6bd6f884","user":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":70860542,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg2MDU0Mg==","name":"smith","full_name":"atlassian/smith","private":false,"owner":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atlassian/smith","description":"Smith is a Kubernetes workflow engine / resource manager","fork":false,"url":"https://api.github.com/repos/atlassian/smith","forks_url":"https://api.github.com/repos/atlassian/smith/forks","keys_url":"https://api.github.com/repos/atlassian/smith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/smith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/smith/teams","hooks_url":"https://api.github.com/repos/atlassian/smith/hooks","issue_events_url":"https://api.github.com/repos/atlassian/smith/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/smith/events","assignees_url":"https://api.github.com/repos/atlassian/smith/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/smith/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/smith/tags","blobs_url":"https://api.github.com/repos/atlassian/smith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/smith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/smith/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/smith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/smith/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/smith/languages","stargazers_url":"https://api.github.com/repos/atlassian/smith/stargazers","contributors_url":"https://api.github.com/repos/atlassian/smith/contributors","subscribers_url":"https://api.github.com/repos/atlassian/smith/subscribers","subscription_url":"https://api.github.com/repos/atlassian/smith/subscription","commits_url":"https://api.github.com/repos/atlassian/smith/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/smith/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/smith/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/smith/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/smith/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/smith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/smith/merges","archive_url":"https://api.github.com/repos/atlassian/smith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/smith/downloads","issues_url":"https://api.github.com/repos/atlassian/smith/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/smith/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/smith/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/smith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/smith/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/smith/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/smith/deployments","created_at":"2016-10-14T00:54:42Z","updated_at":"2018-10-31T05:31:48Z","pushed_at":"2018-11-01T04:44:29Z","git_url":"git://github.com/atlassian/smith.git","ssh_url":"git@github.com:atlassian/smith.git","clone_url":"https://github.com/atlassian/smith.git","svn_url":"https://github.com/atlassian/smith","homepage":"","size":2560,"stargazers_count":201,"watchers_count":201,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":23,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atlassian/smith/pulls/360"},"html":{"href":"https://github.com/atlassian/smith/pull/360"},"issue":{"href":"https://api.github.com/repos/atlassian/smith/issues/360"},"comments":{"href":"https://api.github.com/repos/atlassian/smith/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/atlassian/smith/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/atlassian/smith/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atlassian/smith/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/atlassian/smith/statuses/29b8b3113e7d31c1a6c3a68e710deb4ccf36e8f1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nilebox"}}