{"action":"created","comment":{"url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/comments/201477221","pull_request_review_id":135988680,"id":201477221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ3NzIyMQ==","diff_hunk":"@@ -73,14 +73,17 @@ contract WeiTopDownSplitter is SplitterBase, IWeiReceiver {\n \t\tif(!_isOpen()){\n \t\t\treturn 0;\n \t\t}\n-\n-\t\tuint total = 0;\n-\t\tfor(uint i=0; i<childrenCount; ++i){\n+\t\tuint out = 0;\n+\t\tfor(uint j=0; j<childrenCount; ++j){\n+\t\t\tuint i = childrenCount - j - 1;","path":"contracts/moneyflow/ether/WeiSplitter.sol","position":18,"original_position":18,"commit_id":"3f0ba21cee14c66221b9b105395e02d6f1f7b3cd","original_commit_id":"3f0ba21cee14c66221b9b105395e02d6f1f7b3cd","user":{"login":"enkogu","id":26708829,"node_id":"MDQ6VXNlcjI2NzA4ODI5","avatar_url":"https://avatars1.githubusercontent.com/u/26708829?v=4","gravatar_id":"","url":"https://api.github.com/users/enkogu","html_url":"https://github.com/enkogu","followers_url":"https://api.github.com/users/enkogu/followers","following_url":"https://api.github.com/users/enkogu/following{/other_user}","gists_url":"https://api.github.com/users/enkogu/gists{/gist_id}","starred_url":"https://api.github.com/users/enkogu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkogu/subscriptions","organizations_url":"https://api.github.com/users/enkogu/orgs","repos_url":"https://api.github.com/users/enkogu/repos","events_url":"https://api.github.com/users/enkogu/events{/privacy}","received_events_url":"https://api.github.com/users/enkogu/received_events","type":"User","site_admin":false},"body":"Ну, я сперва так сделал, но так как в солидити нет отрицательных чисел, мы не можем сравнивать как \"больше или равно нулю\", потому что все и всегда \"больше или равно нулю\". Значит, нужно смещать диапазон чисел цикла и что-то вычитать потом, а это будет не более очевидно","created_at":"2018-07-10T20:09:57Z","updated_at":"2018-07-10T20:09:57Z","html_url":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167#discussion_r201477221","pull_request_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/comments/201477221"},"html":{"href":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167#discussion_r201477221"},"pull_request":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167"}},"in_reply_to_id":201461350},"pull_request":{"url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167","id":200359602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzU5NjAy","html_url":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167","diff_url":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167.diff","patch_url":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167.patch","issue_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/167","number":167,"state":"open","locked":false,"title":"Dev second milestone","user":{"login":"enkogu","id":26708829,"node_id":"MDQ6VXNlcjI2NzA4ODI5","avatar_url":"https://avatars1.githubusercontent.com/u/26708829?v=4","gravatar_id":"","url":"https://api.github.com/users/enkogu","html_url":"https://github.com/enkogu","followers_url":"https://api.github.com/users/enkogu/followers","following_url":"https://api.github.com/users/enkogu/following{/other_user}","gists_url":"https://api.github.com/users/enkogu/gists{/gist_id}","starred_url":"https://api.github.com/users/enkogu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkogu/subscriptions","organizations_url":"https://api.github.com/users/enkogu/orgs","repos_url":"https://api.github.com/users/enkogu/repos","events_url":"https://api.github.com/users/enkogu/events{/privacy}","received_events_url":"https://api.github.com/users/enkogu/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-10T11:06:25Z","updated_at":"2018-07-10T20:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5af594ec1b3ff4d7490f10d668820b970eaece57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167/commits","review_comments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167/comments","review_comment_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/167/comments","statuses_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/statuses/3f0ba21cee14c66221b9b105395e02d6f1f7b3cd","head":{"label":"Thetta:devSecondMilestone","ref":"devSecondMilestone","sha":"3f0ba21cee14c66221b9b105395e02d6f1f7b3cd","user":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"repo":{"id":110002038,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMDIwMzg=","name":"Thetta-DAO-Framework","full_name":"Thetta/Thetta-DAO-Framework","owner":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thetta/Thetta-DAO-Framework","description":"Thetta - an open-source framework to help you build the DAO of your dreams","fork":false,"url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework","forks_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/forks","keys_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/teams","hooks_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/hooks","issue_events_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/events","assignees_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/tags","blobs_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/languages","stargazers_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/stargazers","contributors_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/contributors","subscribers_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/subscribers","subscription_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/subscription","commits_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/merges","archive_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/downloads","issues_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/labels{/name}","releases_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/deployments","created_at":"2017-11-08T16:35:17Z","updated_at":"2018-07-10T10:13:03Z","pushed_at":"2018-07-10T18:57:18Z","git_url":"git://github.com/Thetta/Thetta-DAO-Framework.git","ssh_url":"git@github.com:Thetta/Thetta-DAO-Framework.git","clone_url":"https://github.com/Thetta/Thetta-DAO-Framework.git","svn_url":"https://github.com/Thetta/Thetta-DAO-Framework","homepage":"https://web.thetta.io","size":848,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":46,"watchers":43,"default_branch":"master"}},"base":{"label":"Thetta:dev2","ref":"dev2","sha":"a25a557c0f4ef2f742dbee14f16176aaa36e606c","user":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"repo":{"id":110002038,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMDIwMzg=","name":"Thetta-DAO-Framework","full_name":"Thetta/Thetta-DAO-Framework","owner":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thetta/Thetta-DAO-Framework","description":"Thetta - an open-source framework to help you build the DAO of your dreams","fork":false,"url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework","forks_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/forks","keys_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/teams","hooks_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/hooks","issue_events_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/events","assignees_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/tags","blobs_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/languages","stargazers_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/stargazers","contributors_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/contributors","subscribers_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/subscribers","subscription_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/subscription","commits_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/merges","archive_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/downloads","issues_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/labels{/name}","releases_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/deployments","created_at":"2017-11-08T16:35:17Z","updated_at":"2018-07-10T10:13:03Z","pushed_at":"2018-07-10T18:57:18Z","git_url":"git://github.com/Thetta/Thetta-DAO-Framework.git","ssh_url":"git@github.com:Thetta/Thetta-DAO-Framework.git","clone_url":"https://github.com/Thetta/Thetta-DAO-Framework.git","svn_url":"https://github.com/Thetta/Thetta-DAO-Framework","homepage":"https://web.thetta.io","size":848,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":46,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167"},"html":{"href":"https://github.com/Thetta/Thetta-DAO-Framework/pull/167"},"issue":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/167"},"comments":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/Thetta/Thetta-DAO-Framework/statuses/3f0ba21cee14c66221b9b105395e02d6f1f7b3cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"enkogu"}}