{"action":"opened","number":2316,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316","id":206477729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDc3NzI5","html_url":"https://github.com/apache/incubator-pulsar/pull/2316","diff_url":"https://github.com/apache/incubator-pulsar/pull/2316.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/2316.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/2316","number":2316,"state":"open","locked":false,"title":"Fixed refcounting when processing entries from sql","user":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"body":"### Motivation\r\n\r\nThere were 2 issues with ref-count when parsing entries from SQL connector: \r\n\r\n 1. `entry.getData().length` is actually releasing the buffer after the invocation, so `entry.getDataBuffer()` was getting invalid buffer.\r\n 2. `uncompressedPayload.release()` needs to be only invoked once, in the `finally` block","created_at":"2018-08-06T18:18:10Z","updated_at":"2018-08-06T18:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"assignees":[{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":399568949,"node_id":"MDU6TGFiZWwzOTk1Njg5NDk=","url":"https://api.github.com/repos/apache/incubator-pulsar/labels/type/bug","name":"type/bug","color":"ee0701","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/16","html_url":"https://github.com/apache/incubator-pulsar/milestone/16","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/16/labels","id":3433482,"node_id":"MDk6TWlsZXN0b25lMzQzMzQ4Mg==","number":16,"title":"2.2.0-incubating","description":"","creator":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":82,"state":"open","created_at":"2018-06-18T20:11:19Z","updated_at":"2018-08-06T18:18:10Z","due_on":"2018-08-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/2316/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/5d87b1beff5d8c9a510477d8c57be150f418fca6","head":{"label":"merlimat:sql","ref":"sql","sha":"5d87b1beff5d8c9a510477d8c57be150f418fca6","user":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"repo":{"id":67633583,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzMzU4Mw==","name":"pulsar","full_name":"merlimat/pulsar","owner":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/merlimat/pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/merlimat/pulsar","forks_url":"https://api.github.com/repos/merlimat/pulsar/forks","keys_url":"https://api.github.com/repos/merlimat/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merlimat/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merlimat/pulsar/teams","hooks_url":"https://api.github.com/repos/merlimat/pulsar/hooks","issue_events_url":"https://api.github.com/repos/merlimat/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/merlimat/pulsar/events","assignees_url":"https://api.github.com/repos/merlimat/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/merlimat/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/merlimat/pulsar/tags","blobs_url":"https://api.github.com/repos/merlimat/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merlimat/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merlimat/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/merlimat/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merlimat/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/merlimat/pulsar/languages","stargazers_url":"https://api.github.com/repos/merlimat/pulsar/stargazers","contributors_url":"https://api.github.com/repos/merlimat/pulsar/contributors","subscribers_url":"https://api.github.com/repos/merlimat/pulsar/subscribers","subscription_url":"https://api.github.com/repos/merlimat/pulsar/subscription","commits_url":"https://api.github.com/repos/merlimat/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/merlimat/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/merlimat/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/merlimat/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/merlimat/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/merlimat/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merlimat/pulsar/merges","archive_url":"https://api.github.com/repos/merlimat/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merlimat/pulsar/downloads","issues_url":"https://api.github.com/repos/merlimat/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/merlimat/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/merlimat/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/merlimat/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merlimat/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/merlimat/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/merlimat/pulsar/deployments","created_at":"2016-09-07T18:37:15Z","updated_at":"2018-07-23T21:09:18Z","pushed_at":"2018-08-06T18:15:28Z","git_url":"git://github.com/merlimat/pulsar.git","ssh_url":"git@github.com:merlimat/pulsar.git","clone_url":"https://github.com/merlimat/pulsar.git","svn_url":"https://github.com/merlimat/pulsar","homepage":"","size":40053,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"461647a2b7943787883760a810f7cecda88128ec","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxMg==","name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-08-06T17:29:35Z","pushed_at":"2018-08-06T18:13:37Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":51735,"stargazers_count":1885,"watchers_count":1885,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":390,"open_issues":170,"watchers":1885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/2316"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/2316"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/2316/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2316/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/5d87b1beff5d8c9a510477d8c57be150f418fca6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"merlimat"}}