{"action":"created","issue":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/2426","repository_url":"https://api.github.com/repos/toggl/mobileapp","labels_url":"https://api.github.com/repos/toggl/mobileapp/issues/2426/labels{/name}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/2426/comments","events_url":"https://api.github.com/repos/toggl/mobileapp/issues/2426/events","html_url":"https://github.com/toggl/mobileapp/pull/2426","id":330838732,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzQ5OTg0","number":2426,"title":"Improve Start te analytics event to send more data","user":{"login":"daividssilverio","id":2173493,"node_id":"MDQ6VXNlcjIxNzM0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2173493?v=4","gravatar_id":"","url":"https://api.github.com/users/daividssilverio","html_url":"https://github.com/daividssilverio","followers_url":"https://api.github.com/users/daividssilverio/followers","following_url":"https://api.github.com/users/daividssilverio/following{/other_user}","gists_url":"https://api.github.com/users/daividssilverio/gists{/gist_id}","starred_url":"https://api.github.com/users/daividssilverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daividssilverio/subscriptions","organizations_url":"https://api.github.com/users/daividssilverio/orgs","repos_url":"https://api.github.com/users/daividssilverio/repos","events_url":"https://api.github.com/users/daividssilverio/events{/privacy}","received_events_url":"https://api.github.com/users/daividssilverio/received_events","type":"User","site_admin":false},"labels":[{"id":951691488,"node_id":"MDU6TGFiZWw5NTE2OTE0ODg=","url":"https://api.github.com/repos/toggl/mobileapp/labels/metrics","name":"metrics","color":"ea5699","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-09T00:48:44Z","updated_at":"2018-06-11T00:17:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/2426","html_url":"https://github.com/toggl/mobileapp/pull/2426","diff_url":"https://github.com/toggl/mobileapp/pull/2426.diff","patch_url":"https://github.com/toggl/mobileapp/pull/2426.patch"},"body":"Closes #1919 \r\n\r\nI tried creating a Non type safe version, but didn't like the result because it felt weird and the IDE wasn't really helpful when using it, and it felt really error prone and not dev friendly.\r\n\r\nI've created a wip for that, if you want to compare: #2425"},"comment":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/comments/396093703","html_url":"https://github.com/toggl/mobileapp/pull/2426#issuecomment-396093703","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/2426","id":396093703,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA5MzcwMw==","user":{"login":"daividssilverio","id":2173493,"node_id":"MDQ6VXNlcjIxNzM0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2173493?v=4","gravatar_id":"","url":"https://api.github.com/users/daividssilverio","html_url":"https://github.com/daividssilverio","followers_url":"https://api.github.com/users/daividssilverio/followers","following_url":"https://api.github.com/users/daividssilverio/following{/other_user}","gists_url":"https://api.github.com/users/daividssilverio/gists{/gist_id}","starred_url":"https://api.github.com/users/daividssilverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daividssilverio/subscriptions","organizations_url":"https://api.github.com/users/daividssilverio/orgs","repos_url":"https://api.github.com/users/daividssilverio/repos","events_url":"https://api.github.com/users/daividssilverio/events{/privacy}","received_events_url":"https://api.github.com/users/daividssilverio/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T00:17:42Z","updated_at":"2018-06-11T00:17:42Z","author_association":"CONTRIBUTOR","body":"@kornelijepetak, This branch is updated with develop. This PR does use the old tracking way. There was one small discussion whether to use multiple events or the old tracking way in cases like this here #1915. \r\n\r\nI wasn't sure which way to go, it seemed bad to have the event divided into multiple smaller events because it would take more work to synthesize the tracked data, so I've tried creating a not type-safe version of the new tracking way here: #2425 for cases like this with many parameters to track. But it seemed bad to use and quite error prone, then I've used the old way in this PR. Would you rather add the `IAnalyticsEvent<T1, T2, T3, T4, T5, T6, T7>` interface to track this event with all its parameters using the new `Track(...)` way?"}}
{"actor":{"display_login":"daividssilverio"}}