{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/211242105","pull_request_review_id":147610361,"id":211242105,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTI0MjEwNQ==","diff_hunk":"@@ -74,8 +82,10 @@ impl<T, C> FromJSValConvertible for MozMap<T>\n                 ConversionResult::Failure(message) => return Ok(ConversionResult::Failure(message)),\n             };\n \n-            let key = jsid_to_string(cx, id.handle()).unwrap();\n-            map.insert(key, property);\n+            // TODO: Is this guaranteed to succeed?","path":"components/script/dom/bindings/mozmap.rs","position":34,"original_position":34,"commit_id":"a0528694130ae4cbda96cda77cff7ead0e4ca03e","original_commit_id":"a0528694130ae4cbda96cda77cff7ead0e4ca03e","user":{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"body":"Can we make this a follow-up issue?","created_at":"2018-08-20T12:23:53Z","updated_at":"2018-08-20T12:40:28Z","html_url":"https://github.com/servo/servo/pull/21029#discussion_r211242105","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/21029","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/211242105"},"html":{"href":"https://github.com/servo/servo/pull/21029#discussion_r211242105"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/21029"}},"in_reply_to_id":211225546},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21029","id":193703383,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzAzMzgz","html_url":"https://github.com/servo/servo/pull/21029","diff_url":"https://github.com/servo/servo/pull/21029.diff","patch_url":"https://github.com/servo/servo/pull/21029.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/21029","number":21029,"state":"open","locked":false,"title":"Upgrade to SM 60","user":{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nThis is the mozjs_sys smup PR. Depends on https://github.com/servo/mozjs/pull/138 and https://github.com/servo/rust-mozjs/pull/430.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #20585 \r\n<!-- Either: -->\r\n- [X] These changes do not require tests because the existing tests will ensure SM is still working\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21029)\n<!-- Reviewable:end -->\n","created_at":"2018-06-08T19:28:12Z","updated_at":"2018-08-20T12:40:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d30c3f6545120298011d76dc12d527a9e4fc3cae","assignee":{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":84750486,"node_id":"MDU6TGFiZWw4NDc1MDQ4Ng==","url":"https://api.github.com/repos/servo/servo/labels/A-content/script","name":"A-content/script","color":"d7e102","default":false},{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false},{"id":152310441,"node_id":"MDU6TGFiZWwxNTIzMTA0NDE=","url":"https://api.github.com/repos/servo/servo/labels/S-blocked-on-external","name":"S-blocked-on-external","color":"d4c5f9","default":false},{"id":152311003,"node_id":"MDU6TGFiZWwxNTIzMTEwMDM=","url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9","default":false},{"id":152310165,"node_id":"MDU6TGFiZWwxNTIzMTAxNjU=","url":"https://api.github.com/repos/servo/servo/labels/S-needs-squash","name":"S-needs-squash","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/21029/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/21029/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/21029/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/a0528694130ae4cbda96cda77cff7ead0e4ca03e","head":{"label":"asajeffrey:smup","ref":"smup","sha":"a0528694130ae4cbda96cda77cff7ead0e4ca03e","user":{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"repo":{"id":44559130,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU1OTEzMA==","name":"servo","full_name":"asajeffrey/servo","owner":{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asajeffrey/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/asajeffrey/servo","forks_url":"https://api.github.com/repos/asajeffrey/servo/forks","keys_url":"https://api.github.com/repos/asajeffrey/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asajeffrey/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asajeffrey/servo/teams","hooks_url":"https://api.github.com/repos/asajeffrey/servo/hooks","issue_events_url":"https://api.github.com/repos/asajeffrey/servo/issues/events{/number}","events_url":"https://api.github.com/repos/asajeffrey/servo/events","assignees_url":"https://api.github.com/repos/asajeffrey/servo/assignees{/user}","branches_url":"https://api.github.com/repos/asajeffrey/servo/branches{/branch}","tags_url":"https://api.github.com/repos/asajeffrey/servo/tags","blobs_url":"https://api.github.com/repos/asajeffrey/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asajeffrey/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asajeffrey/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/asajeffrey/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asajeffrey/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/asajeffrey/servo/languages","stargazers_url":"https://api.github.com/repos/asajeffrey/servo/stargazers","contributors_url":"https://api.github.com/repos/asajeffrey/servo/contributors","subscribers_url":"https://api.github.com/repos/asajeffrey/servo/subscribers","subscription_url":"https://api.github.com/repos/asajeffrey/servo/subscription","commits_url":"https://api.github.com/repos/asajeffrey/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/asajeffrey/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/asajeffrey/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/asajeffrey/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/asajeffrey/servo/contents/{+path}","compare_url":"https://api.github.com/repos/asajeffrey/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asajeffrey/servo/merges","archive_url":"https://api.github.com/repos/asajeffrey/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asajeffrey/servo/downloads","issues_url":"https://api.github.com/repos/asajeffrey/servo/issues{/number}","pulls_url":"https://api.github.com/repos/asajeffrey/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/asajeffrey/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/asajeffrey/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asajeffrey/servo/labels{/name}","releases_url":"https://api.github.com/repos/asajeffrey/servo/releases{/id}","deployments_url":"https://api.github.com/repos/asajeffrey/servo/deployments","created_at":"2015-10-19T19:40:43Z","updated_at":"2018-07-26T18:59:29Z","pushed_at":"2018-08-20T10:35:48Z","git_url":"git://github.com/asajeffrey/servo.git","ssh_url":"git@github.com:asajeffrey/servo.git","clone_url":"https://github.com/asajeffrey/servo.git","svn_url":"https://github.com/asajeffrey/servo","homepage":"","size":418096,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"d34403047e806fa6c8c2468946f64429622ec434","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-08-20T11:55:18Z","pushed_at":"2018-08-20T10:36:42Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":563854,"stargazers_count":12204,"watchers_count":12204,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1942,"mirror_url":null,"archived":false,"open_issues_count":2358,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1942,"open_issues":2358,"watchers":12204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/21029"},"html":{"href":"https://github.com/servo/servo/pull/21029"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/21029"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/21029/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/21029/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/21029/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/a0528694130ae4cbda96cda77cff7ead0e4ca03e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asajeffrey"}}