{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/212012121","pull_request_review_id":148553460,"id":212012121,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjAxMjEyMQ==","diff_hunk":"@@ -0,0 +1,24 @@\n+[tox]\n+minversion = 2.0\n+basepython = py27\n+envlist = unit, flake8\n+\n+[testenv]\n+platform = linux2|darwin\n+deps =\n+    datadog-checks-base","path":"coredns/tox.ini","position":9,"original_position":9,"commit_id":"740d2d6a6fdf32a73b4674f1c5b3495c12d81cbd","original_commit_id":"740d2d6a6fdf32a73b4674f1c5b3495c12d81cbd","user":{"login":"gmmeyer","id":3253673,"node_id":"MDQ6VXNlcjMyNTM2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3253673?v=4","gravatar_id":"","url":"https://api.github.com/users/gmmeyer","html_url":"https://github.com/gmmeyer","followers_url":"https://api.github.com/users/gmmeyer/followers","following_url":"https://api.github.com/users/gmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/gmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/gmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmmeyer/subscriptions","organizations_url":"https://api.github.com/users/gmmeyer/orgs","repos_url":"https://api.github.com/users/gmmeyer/repos","events_url":"https://api.github.com/users/gmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/gmmeyer/received_events","type":"User","site_admin":false},"body":"can you change this to `-e../datadog_checks_base[deps]`? That will, I believe, make the test work.","created_at":"2018-08-22T16:00:01Z","updated_at":"2018-08-22T16:08:00Z","html_url":"https://github.com/DataDog/integrations-core/pull/2091#discussion_r212012121","pull_request_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/212012121"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2091#discussion_r212012121"},"pull_request":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091","id":210018165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDE4MTY1","html_url":"https://github.com/DataDog/integrations-core/pull/2091","diff_url":"https://github.com/DataDog/integrations-core/pull/2091.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/2091.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2091","number":2091,"state":"open","locked":false,"title":"Adding CoreDNS integration to Datadog","user":{"login":"shraykay","id":8689924,"node_id":"MDQ6VXNlcjg2ODk5MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8689924?v=4","gravatar_id":"","url":"https://api.github.com/users/shraykay","html_url":"https://github.com/shraykay","followers_url":"https://api.github.com/users/shraykay/followers","following_url":"https://api.github.com/users/shraykay/following{/other_user}","gists_url":"https://api.github.com/users/shraykay/gists{/gist_id}","starred_url":"https://api.github.com/users/shraykay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shraykay/subscriptions","organizations_url":"https://api.github.com/users/shraykay/orgs","repos_url":"https://api.github.com/users/shraykay/repos","events_url":"https://api.github.com/users/shraykay/events{/privacy}","received_events_url":"https://api.github.com/users/shraykay/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAdding an integration for CoreDNS -- CoreDNS emits metrics via Prometheus.\r\nSee sample events from plugins: [here](http://coredns.io/plugins/metrics), [here](https://coredns.io/plugins/cache/), and [here](https://coredns.io/plugins/proxy/).\r\n\r\n### Motivation\r\n\r\nKubernetes is moving from KubeDNS -> CoreDNS starting v1.11\r\n\r\n### Review checklist\r\n\r\n- [x] PR has a [meaningful title](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title) or PR has the `no-changelog` label attached\r\n- [x] Feature or bugfix has tests\r\n- [x] Git history is clean\r\n- [x] If PR impacts documentation, docs team has been notified or an issue has been opened on the [documentation repo](https://github.com/DataDog/documentation/issues/new)\r\n\r\n### Additional Notes\r\n\r\nFirst time making a contribution! Please let me know what I may have missed, I borrowed heavily from KubeDNS's integration.\r\n","created_at":"2018-08-22T04:37:47Z","updated_at":"2018-08-22T16:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d0e48b775b86fdd47c9ecb4a46258a96b01c0c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2091/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/740d2d6a6fdf32a73b4674f1c5b3495c12d81cbd","head":{"label":"shraykay:coredns","ref":"coredns","sha":"740d2d6a6fdf32a73b4674f1c5b3495c12d81cbd","user":{"login":"shraykay","id":8689924,"node_id":"MDQ6VXNlcjg2ODk5MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8689924?v=4","gravatar_id":"","url":"https://api.github.com/users/shraykay","html_url":"https://github.com/shraykay","followers_url":"https://api.github.com/users/shraykay/followers","following_url":"https://api.github.com/users/shraykay/following{/other_user}","gists_url":"https://api.github.com/users/shraykay/gists{/gist_id}","starred_url":"https://api.github.com/users/shraykay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shraykay/subscriptions","organizations_url":"https://api.github.com/users/shraykay/orgs","repos_url":"https://api.github.com/users/shraykay/repos","events_url":"https://api.github.com/users/shraykay/events{/privacy}","received_events_url":"https://api.github.com/users/shraykay/received_events","type":"User","site_admin":false},"repo":{"id":144810890,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MTA4OTA=","name":"integrations-core","full_name":"shraykay/integrations-core","owner":{"login":"shraykay","id":8689924,"node_id":"MDQ6VXNlcjg2ODk5MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8689924?v=4","gravatar_id":"","url":"https://api.github.com/users/shraykay","html_url":"https://github.com/shraykay","followers_url":"https://api.github.com/users/shraykay/followers","following_url":"https://api.github.com/users/shraykay/following{/other_user}","gists_url":"https://api.github.com/users/shraykay/gists{/gist_id}","starred_url":"https://api.github.com/users/shraykay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shraykay/subscriptions","organizations_url":"https://api.github.com/users/shraykay/orgs","repos_url":"https://api.github.com/users/shraykay/repos","events_url":"https://api.github.com/users/shraykay/events{/privacy}","received_events_url":"https://api.github.com/users/shraykay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shraykay/integrations-core","description":"Core integrations of the datadog agent","fork":true,"url":"https://api.github.com/repos/shraykay/integrations-core","forks_url":"https://api.github.com/repos/shraykay/integrations-core/forks","keys_url":"https://api.github.com/repos/shraykay/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shraykay/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shraykay/integrations-core/teams","hooks_url":"https://api.github.com/repos/shraykay/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/shraykay/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/shraykay/integrations-core/events","assignees_url":"https://api.github.com/repos/shraykay/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/shraykay/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/shraykay/integrations-core/tags","blobs_url":"https://api.github.com/repos/shraykay/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shraykay/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shraykay/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/shraykay/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shraykay/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/shraykay/integrations-core/languages","stargazers_url":"https://api.github.com/repos/shraykay/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/shraykay/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/shraykay/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/shraykay/integrations-core/subscription","commits_url":"https://api.github.com/repos/shraykay/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/shraykay/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/shraykay/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/shraykay/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/shraykay/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/shraykay/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shraykay/integrations-core/merges","archive_url":"https://api.github.com/repos/shraykay/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shraykay/integrations-core/downloads","issues_url":"https://api.github.com/repos/shraykay/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/shraykay/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/shraykay/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/shraykay/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shraykay/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/shraykay/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/shraykay/integrations-core/deployments","created_at":"2018-08-15T05:45:42Z","updated_at":"2018-08-15T05:45:48Z","pushed_at":"2018-08-22T04:37:17Z","git_url":"git://github.com/shraykay/integrations-core.git","ssh_url":"git@github.com:shraykay/integrations-core.git","clone_url":"https://github.com/shraykay/integrations-core.git","svn_url":"https://github.com/shraykay/integrations-core","homepage":null,"size":27841,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"ed95bd8ff377e6bb406610fb89911275121dc6b0","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-08-22T15:41:40Z","pushed_at":"2018-08-22T15:44:50Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":28093,"stargazers_count":139,"watchers_count":139,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":301,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":301,"open_issues":64,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2091"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2091"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2091/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2091/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/740d2d6a6fdf32a73b4674f1c5b3495c12d81cbd"}},"author_association":"NONE"}}
{"actor":{"display_login":"gmmeyer"}}