{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-go/pulls/54","id":188182990,"html_url":"https://github.com/dcos/dcos-go/pull/54","diff_url":"https://github.com/dcos/dcos-go/pull/54.diff","patch_url":"https://github.com/dcos/dcos-go/pull/54.patch","issue_url":"https://api.github.com/repos/dcos/dcos-go/issues/54","number":54,"state":"closed","locked":false,"title":"Add missing DC/OS internal constants","user":{"login":"timaa2k","id":3110475,"avatar_url":"https://avatars0.githubusercontent.com/u/3110475?v=4","gravatar_id":"","url":"https://api.github.com/users/timaa2k","html_url":"https://github.com/timaa2k","followers_url":"https://api.github.com/users/timaa2k/followers","following_url":"https://api.github.com/users/timaa2k/following{/other_user}","gists_url":"https://api.github.com/users/timaa2k/gists{/gist_id}","starred_url":"https://api.github.com/users/timaa2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timaa2k/subscriptions","organizations_url":"https://api.github.com/users/timaa2k/orgs","repos_url":"https://api.github.com/users/timaa2k/repos","events_url":"https://api.github.com/users/timaa2k/events{/privacy}","received_events_url":"https://api.github.com/users/timaa2k/received_events","type":"User","site_admin":false},"body":"# Add missing DC/OS internal port constants\r\n## Checklist\r\n- [] ~80% unit test coverage?\r\n- [] Updated [README.md](README.md)?\r\n- [x] Completed sections of this PR template?\r\n- [x] Edited all sections [IN BRACKETS]\r\n\r\n## Overview of Change\r\nMultiple DC/OS checks access the DC/OS internal HTTP servers on those pre-defined ports.\r\nAlso having multiple projects using those ports, they should not be re-defined in every repository.\r\nHaving a single location for the port constants makes it easier to maintain them.\r\n\r\n## Affected Usage\r\nThis should be the default location that DC/OS ports are referenced from so that in case of a change\r\nit only needs to be changed in one location.\r\n","created_at":"2018-05-15T16:17:51Z","updated_at":"2018-05-16T11:12:23Z","closed_at":"2018-05-16T11:12:23Z","merged_at":"2018-05-16T11:12:23Z","merge_commit_sha":"9de6a3050a54a771e2493c82a91cfe40a05d3415","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-go/pulls/54/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-go/pulls/54/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-go/issues/54/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-go/statuses/26a86f6f23d0e2f0d80bab2096338c19f2625ddb","head":{"label":"timaa2k:tweidner/add-more-dcos-ports","ref":"tweidner/add-more-dcos-ports","sha":"26a86f6f23d0e2f0d80bab2096338c19f2625ddb","user":{"login":"timaa2k","id":3110475,"avatar_url":"https://avatars0.githubusercontent.com/u/3110475?v=4","gravatar_id":"","url":"https://api.github.com/users/timaa2k","html_url":"https://github.com/timaa2k","followers_url":"https://api.github.com/users/timaa2k/followers","following_url":"https://api.github.com/users/timaa2k/following{/other_user}","gists_url":"https://api.github.com/users/timaa2k/gists{/gist_id}","starred_url":"https://api.github.com/users/timaa2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timaa2k/subscriptions","organizations_url":"https://api.github.com/users/timaa2k/orgs","repos_url":"https://api.github.com/users/timaa2k/repos","events_url":"https://api.github.com/users/timaa2k/events{/privacy}","received_events_url":"https://api.github.com/users/timaa2k/received_events","type":"User","site_admin":false},"repo":{"id":114362121,"name":"dcos-go","full_name":"timaa2k/dcos-go","owner":{"login":"timaa2k","id":3110475,"avatar_url":"https://avatars0.githubusercontent.com/u/3110475?v=4","gravatar_id":"","url":"https://api.github.com/users/timaa2k","html_url":"https://github.com/timaa2k","followers_url":"https://api.github.com/users/timaa2k/followers","following_url":"https://api.github.com/users/timaa2k/following{/other_user}","gists_url":"https://api.github.com/users/timaa2k/gists{/gist_id}","starred_url":"https://api.github.com/users/timaa2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timaa2k/subscriptions","organizations_url":"https://api.github.com/users/timaa2k/orgs","repos_url":"https://api.github.com/users/timaa2k/repos","events_url":"https://api.github.com/users/timaa2k/events{/privacy}","received_events_url":"https://api.github.com/users/timaa2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timaa2k/dcos-go","description":"DC/OS golang shared libraries","fork":true,"url":"https://api.github.com/repos/timaa2k/dcos-go","forks_url":"https://api.github.com/repos/timaa2k/dcos-go/forks","keys_url":"https://api.github.com/repos/timaa2k/dcos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timaa2k/dcos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timaa2k/dcos-go/teams","hooks_url":"https://api.github.com/repos/timaa2k/dcos-go/hooks","issue_events_url":"https://api.github.com/repos/timaa2k/dcos-go/issues/events{/number}","events_url":"https://api.github.com/repos/timaa2k/dcos-go/events","assignees_url":"https://api.github.com/repos/timaa2k/dcos-go/assignees{/user}","branches_url":"https://api.github.com/repos/timaa2k/dcos-go/branches{/branch}","tags_url":"https://api.github.com/repos/timaa2k/dcos-go/tags","blobs_url":"https://api.github.com/repos/timaa2k/dcos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timaa2k/dcos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timaa2k/dcos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/timaa2k/dcos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timaa2k/dcos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/timaa2k/dcos-go/languages","stargazers_url":"https://api.github.com/repos/timaa2k/dcos-go/stargazers","contributors_url":"https://api.github.com/repos/timaa2k/dcos-go/contributors","subscribers_url":"https://api.github.com/repos/timaa2k/dcos-go/subscribers","subscription_url":"https://api.github.com/repos/timaa2k/dcos-go/subscription","commits_url":"https://api.github.com/repos/timaa2k/dcos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/timaa2k/dcos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/timaa2k/dcos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/timaa2k/dcos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/timaa2k/dcos-go/contents/{+path}","compare_url":"https://api.github.com/repos/timaa2k/dcos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timaa2k/dcos-go/merges","archive_url":"https://api.github.com/repos/timaa2k/dcos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timaa2k/dcos-go/downloads","issues_url":"https://api.github.com/repos/timaa2k/dcos-go/issues{/number}","pulls_url":"https://api.github.com/repos/timaa2k/dcos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/timaa2k/dcos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/timaa2k/dcos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timaa2k/dcos-go/labels{/name}","releases_url":"https://api.github.com/repos/timaa2k/dcos-go/releases{/id}","deployments_url":"https://api.github.com/repos/timaa2k/dcos-go/deployments","created_at":"2017-12-15T11:11:20Z","updated_at":"2017-12-15T11:11:22Z","pushed_at":"2018-05-16T09:16:35Z","git_url":"git://github.com/timaa2k/dcos-go.git","ssh_url":"git@github.com:timaa2k/dcos-go.git","clone_url":"https://github.com/timaa2k/dcos-go.git","svn_url":"https://github.com/timaa2k/dcos-go","homepage":"","size":3846,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"95000f9090913360b907002f4a38f30ab077c5ee","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":69291251,"name":"dcos-go","full_name":"dcos/dcos-go","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-go","description":"DC/OS golang shared libraries","fork":false,"url":"https://api.github.com/repos/dcos/dcos-go","forks_url":"https://api.github.com/repos/dcos/dcos-go/forks","keys_url":"https://api.github.com/repos/dcos/dcos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-go/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-go/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-go/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-go/events","assignees_url":"https://api.github.com/repos/dcos/dcos-go/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-go/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-go/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-go/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-go/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-go/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-go/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-go/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-go/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-go/merges","archive_url":"https://api.github.com/repos/dcos/dcos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-go/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-go/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-go/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-go/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-go/deployments","created_at":"2016-09-26T20:45:14Z","updated_at":"2018-05-12T14:06:03Z","pushed_at":"2018-05-16T11:12:23Z","git_url":"git://github.com/dcos/dcos-go.git","ssh_url":"git@github.com:dcos/dcos-go.git","clone_url":"https://github.com/dcos/dcos-go.git","svn_url":"https://github.com/dcos/dcos-go","homepage":"","size":10438,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/54"},"html":{"href":"https://github.com/dcos/dcos-go/pull/54"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-go/issues/54"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-go/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-go/statuses/26a86f6f23d0e2f0d80bab2096338c19f2625ddb"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gpaul","id":442,"avatar_url":"https://avatars1.githubusercontent.com/u/442?v=4","gravatar_id":"","url":"https://api.github.com/users/gpaul","html_url":"https://github.com/gpaul","followers_url":"https://api.github.com/users/gpaul/followers","following_url":"https://api.github.com/users/gpaul/following{/other_user}","gists_url":"https://api.github.com/users/gpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/gpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpaul/subscriptions","organizations_url":"https://api.github.com/users/gpaul/orgs","repos_url":"https://api.github.com/users/gpaul/repos","events_url":"https://api.github.com/users/gpaul/events{/privacy}","received_events_url":"https://api.github.com/users/gpaul/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":38,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"gpaul"}}