{"action":"created","comment":{"url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/comments/241710672","pull_request_review_id":185051923,"id":241710672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTcxMDY3Mg==","diff_hunk":"@@ -42,9 +43,12 @@ def listener(thissession, flush_context, instances):\n                     obj.registreringtil = func.sysdate()\n                     thissession.add(obj)\n \n-    def hent_punkt(self, id) -> Punkt:\n+    def hent_punkt(self, id: str) -> Punkt:\n         return self.session.query(Punkt).filter(Punkt.id == id).first()\n \n+    def hent_geometri_objekt(self, id: str) -> GeometriObjekt:","path":"fireapi/firedb.py","position":24,"original_position":24,"commit_id":"3e6845427703b7d838e07d4669175dc5556215a5","original_commit_id":"3e6845427703b7d838e07d4669175dc5556215a5","user":{"login":"bjornharrtell","id":141030,"node_id":"MDQ6VXNlcjE0MTAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/141030?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornharrtell","html_url":"https://github.com/bjornharrtell","followers_url":"https://api.github.com/users/bjornharrtell/followers","following_url":"https://api.github.com/users/bjornharrtell/following{/other_user}","gists_url":"https://api.github.com/users/bjornharrtell/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornharrtell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornharrtell/subscriptions","organizations_url":"https://api.github.com/users/bjornharrtell/orgs","repos_url":"https://api.github.com/users/bjornharrtell/repos","events_url":"https://api.github.com/users/bjornharrtell/events{/privacy}","received_events_url":"https://api.github.com/users/bjornharrtell/received_events","type":"User","site_admin":false},"body":"Well, it depends if the historic versions has meaning/use or not. In the case of `GeometriObjekt` I'm not aware of any use case of the historic versions and perhaps it's only for \"archival\" purposes - in which case I think I would rather have the historic rows in a separate table...","created_at":"2018-12-14T10:36:33Z","updated_at":"2018-12-14T10:36:34Z","html_url":"https://github.com/Septima/fikspunktsregister/pull/53#discussion_r241710672","pull_request_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/comments/241710672"},"html":{"href":"https://github.com/Septima/fikspunktsregister/pull/53#discussion_r241710672"},"pull_request":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53"}},"in_reply_to_id":241389754},"pull_request":{"url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53","id":237707938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzA3OTM4","html_url":"https://github.com/Septima/fikspunktsregister/pull/53","diff_url":"https://github.com/Septima/fikspunktsregister/pull/53.diff","patch_url":"https://github.com/Septima/fikspunktsregister/pull/53.patch","issue_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/53","number":53,"state":"closed","locked":false,"title":"Implement hent_observationer_naer_*","user":{"login":"bjornharrtell","id":141030,"node_id":"MDQ6VXNlcjE0MTAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/141030?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornharrtell","html_url":"https://github.com/bjornharrtell","followers_url":"https://api.github.com/users/bjornharrtell/followers","following_url":"https://api.github.com/users/bjornharrtell/following{/other_user}","gists_url":"https://api.github.com/users/bjornharrtell/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornharrtell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornharrtell/subscriptions","organizations_url":"https://api.github.com/users/bjornharrtell/orgs","repos_url":"https://api.github.com/users/bjornharrtell/repos","events_url":"https://api.github.com/users/bjornharrtell/events{/privacy}","received_events_url":"https://api.github.com/users/bjornharrtell/received_events","type":"User","site_admin":false},"body":"Also includes WIP indset methods.","created_at":"2018-12-11T14:52:30Z","updated_at":"2018-12-14T10:36:34Z","closed_at":"2018-12-13T15:38:40Z","merged_at":"2018-12-13T15:38:40Z","merge_commit_sha":"a9f161cf9e6670e701327c5ea1fd33e1454afef5","assignee":{"login":"bjornharrtell","id":141030,"node_id":"MDQ6VXNlcjE0MTAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/141030?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornharrtell","html_url":"https://github.com/bjornharrtell","followers_url":"https://api.github.com/users/bjornharrtell/followers","following_url":"https://api.github.com/users/bjornharrtell/following{/other_user}","gists_url":"https://api.github.com/users/bjornharrtell/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornharrtell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornharrtell/subscriptions","organizations_url":"https://api.github.com/users/bjornharrtell/orgs","repos_url":"https://api.github.com/users/bjornharrtell/repos","events_url":"https://api.github.com/users/bjornharrtell/events{/privacy}","received_events_url":"https://api.github.com/users/bjornharrtell/received_events","type":"User","site_admin":false},"assignees":[{"login":"bjornharrtell","id":141030,"node_id":"MDQ6VXNlcjE0MTAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/141030?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornharrtell","html_url":"https://github.com/bjornharrtell","followers_url":"https://api.github.com/users/bjornharrtell/followers","following_url":"https://api.github.com/users/bjornharrtell/following{/other_user}","gists_url":"https://api.github.com/users/bjornharrtell/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornharrtell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornharrtell/subscriptions","organizations_url":"https://api.github.com/users/bjornharrtell/orgs","repos_url":"https://api.github.com/users/bjornharrtell/repos","events_url":"https://api.github.com/users/bjornharrtell/events{/privacy}","received_events_url":"https://api.github.com/users/bjornharrtell/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53/commits","review_comments_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53/comments","review_comment_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/53/comments","statuses_url":"https://api.github.com/repos/Septima/fikspunktsregister/statuses/3e6845427703b7d838e07d4669175dc5556215a5","head":{"label":"Septima:more-api","ref":"more-api","sha":"3e6845427703b7d838e07d4669175dc5556215a5","user":{"login":"Septima","id":3597292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTcyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3597292?v=4","gravatar_id":"","url":"https://api.github.com/users/Septima","html_url":"https://github.com/Septima","followers_url":"https://api.github.com/users/Septima/followers","following_url":"https://api.github.com/users/Septima/following{/other_user}","gists_url":"https://api.github.com/users/Septima/gists{/gist_id}","starred_url":"https://api.github.com/users/Septima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Septima/subscriptions","organizations_url":"https://api.github.com/users/Septima/orgs","repos_url":"https://api.github.com/users/Septima/repos","events_url":"https://api.github.com/users/Septima/events{/privacy}","received_events_url":"https://api.github.com/users/Septima/received_events","type":"Organization","site_admin":false},"repo":{"id":156532554,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1MzI1NTQ=","name":"fikspunktsregister","full_name":"Septima/fikspunktsregister","private":false,"owner":{"login":"Septima","id":3597292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTcyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3597292?v=4","gravatar_id":"","url":"https://api.github.com/users/Septima","html_url":"https://github.com/Septima","followers_url":"https://api.github.com/users/Septima/followers","following_url":"https://api.github.com/users/Septima/following{/other_user}","gists_url":"https://api.github.com/users/Septima/gists{/gist_id}","starred_url":"https://api.github.com/users/Septima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Septima/subscriptions","organizations_url":"https://api.github.com/users/Septima/orgs","repos_url":"https://api.github.com/users/Septima/repos","events_url":"https://api.github.com/users/Septima/events{/privacy}","received_events_url":"https://api.github.com/users/Septima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Septima/fikspunktsregister","description":null,"fork":false,"url":"https://api.github.com/repos/Septima/fikspunktsregister","forks_url":"https://api.github.com/repos/Septima/fikspunktsregister/forks","keys_url":"https://api.github.com/repos/Septima/fikspunktsregister/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Septima/fikspunktsregister/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Septima/fikspunktsregister/teams","hooks_url":"https://api.github.com/repos/Septima/fikspunktsregister/hooks","issue_events_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/events{/number}","events_url":"https://api.github.com/repos/Septima/fikspunktsregister/events","assignees_url":"https://api.github.com/repos/Septima/fikspunktsregister/assignees{/user}","branches_url":"https://api.github.com/repos/Septima/fikspunktsregister/branches{/branch}","tags_url":"https://api.github.com/repos/Septima/fikspunktsregister/tags","blobs_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/refs{/sha}","trees_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Septima/fikspunktsregister/statuses/{sha}","languages_url":"https://api.github.com/repos/Septima/fikspunktsregister/languages","stargazers_url":"https://api.github.com/repos/Septima/fikspunktsregister/stargazers","contributors_url":"https://api.github.com/repos/Septima/fikspunktsregister/contributors","subscribers_url":"https://api.github.com/repos/Septima/fikspunktsregister/subscribers","subscription_url":"https://api.github.com/repos/Septima/fikspunktsregister/subscription","commits_url":"https://api.github.com/repos/Septima/fikspunktsregister/commits{/sha}","git_commits_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/commits{/sha}","comments_url":"https://api.github.com/repos/Septima/fikspunktsregister/comments{/number}","issue_comment_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/comments{/number}","contents_url":"https://api.github.com/repos/Septima/fikspunktsregister/contents/{+path}","compare_url":"https://api.github.com/repos/Septima/fikspunktsregister/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Septima/fikspunktsregister/merges","archive_url":"https://api.github.com/repos/Septima/fikspunktsregister/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Septima/fikspunktsregister/downloads","issues_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues{/number}","pulls_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls{/number}","milestones_url":"https://api.github.com/repos/Septima/fikspunktsregister/milestones{/number}","notifications_url":"https://api.github.com/repos/Septima/fikspunktsregister/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Septima/fikspunktsregister/labels{/name}","releases_url":"https://api.github.com/repos/Septima/fikspunktsregister/releases{/id}","deployments_url":"https://api.github.com/repos/Septima/fikspunktsregister/deployments","created_at":"2018-11-07T10:54:03Z","updated_at":"2018-12-13T15:38:42Z","pushed_at":"2018-12-13T15:38:43Z","git_url":"git://github.com/Septima/fikspunktsregister.git","ssh_url":"git@github.com:Septima/fikspunktsregister.git","clone_url":"https://github.com/Septima/fikspunktsregister.git","svn_url":"https://github.com/Septima/fikspunktsregister","homepage":null,"size":473,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Septima:master","ref":"master","sha":"fc5875d4c219668f64d30d1ebb12e8c28bb9dc9d","user":{"login":"Septima","id":3597292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTcyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3597292?v=4","gravatar_id":"","url":"https://api.github.com/users/Septima","html_url":"https://github.com/Septima","followers_url":"https://api.github.com/users/Septima/followers","following_url":"https://api.github.com/users/Septima/following{/other_user}","gists_url":"https://api.github.com/users/Septima/gists{/gist_id}","starred_url":"https://api.github.com/users/Septima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Septima/subscriptions","organizations_url":"https://api.github.com/users/Septima/orgs","repos_url":"https://api.github.com/users/Septima/repos","events_url":"https://api.github.com/users/Septima/events{/privacy}","received_events_url":"https://api.github.com/users/Septima/received_events","type":"Organization","site_admin":false},"repo":{"id":156532554,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1MzI1NTQ=","name":"fikspunktsregister","full_name":"Septima/fikspunktsregister","private":false,"owner":{"login":"Septima","id":3597292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTcyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3597292?v=4","gravatar_id":"","url":"https://api.github.com/users/Septima","html_url":"https://github.com/Septima","followers_url":"https://api.github.com/users/Septima/followers","following_url":"https://api.github.com/users/Septima/following{/other_user}","gists_url":"https://api.github.com/users/Septima/gists{/gist_id}","starred_url":"https://api.github.com/users/Septima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Septima/subscriptions","organizations_url":"https://api.github.com/users/Septima/orgs","repos_url":"https://api.github.com/users/Septima/repos","events_url":"https://api.github.com/users/Septima/events{/privacy}","received_events_url":"https://api.github.com/users/Septima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Septima/fikspunktsregister","description":null,"fork":false,"url":"https://api.github.com/repos/Septima/fikspunktsregister","forks_url":"https://api.github.com/repos/Septima/fikspunktsregister/forks","keys_url":"https://api.github.com/repos/Septima/fikspunktsregister/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Septima/fikspunktsregister/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Septima/fikspunktsregister/teams","hooks_url":"https://api.github.com/repos/Septima/fikspunktsregister/hooks","issue_events_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/events{/number}","events_url":"https://api.github.com/repos/Septima/fikspunktsregister/events","assignees_url":"https://api.github.com/repos/Septima/fikspunktsregister/assignees{/user}","branches_url":"https://api.github.com/repos/Septima/fikspunktsregister/branches{/branch}","tags_url":"https://api.github.com/repos/Septima/fikspunktsregister/tags","blobs_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/refs{/sha}","trees_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Septima/fikspunktsregister/statuses/{sha}","languages_url":"https://api.github.com/repos/Septima/fikspunktsregister/languages","stargazers_url":"https://api.github.com/repos/Septima/fikspunktsregister/stargazers","contributors_url":"https://api.github.com/repos/Septima/fikspunktsregister/contributors","subscribers_url":"https://api.github.com/repos/Septima/fikspunktsregister/subscribers","subscription_url":"https://api.github.com/repos/Septima/fikspunktsregister/subscription","commits_url":"https://api.github.com/repos/Septima/fikspunktsregister/commits{/sha}","git_commits_url":"https://api.github.com/repos/Septima/fikspunktsregister/git/commits{/sha}","comments_url":"https://api.github.com/repos/Septima/fikspunktsregister/comments{/number}","issue_comment_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues/comments{/number}","contents_url":"https://api.github.com/repos/Septima/fikspunktsregister/contents/{+path}","compare_url":"https://api.github.com/repos/Septima/fikspunktsregister/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Septima/fikspunktsregister/merges","archive_url":"https://api.github.com/repos/Septima/fikspunktsregister/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Septima/fikspunktsregister/downloads","issues_url":"https://api.github.com/repos/Septima/fikspunktsregister/issues{/number}","pulls_url":"https://api.github.com/repos/Septima/fikspunktsregister/pulls{/number}","milestones_url":"https://api.github.com/repos/Septima/fikspunktsregister/milestones{/number}","notifications_url":"https://api.github.com/repos/Septima/fikspunktsregister/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Septima/fikspunktsregister/labels{/name}","releases_url":"https://api.github.com/repos/Septima/fikspunktsregister/releases{/id}","deployments_url":"https://api.github.com/repos/Septima/fikspunktsregister/deployments","created_at":"2018-11-07T10:54:03Z","updated_at":"2018-12-13T15:38:42Z","pushed_at":"2018-12-13T15:38:43Z","git_url":"git://github.com/Septima/fikspunktsregister.git","ssh_url":"git@github.com:Septima/fikspunktsregister.git","clone_url":"https://github.com/Septima/fikspunktsregister.git","svn_url":"https://github.com/Septima/fikspunktsregister","homepage":null,"size":473,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53"},"html":{"href":"https://github.com/Septima/fikspunktsregister/pull/53"},"issue":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/issues/53"},"comments":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/Septima/fikspunktsregister/statuses/3e6845427703b7d838e07d4669175dc5556215a5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bjornharrtell"}}