{"action":"closed","issue":{"url":"https://api.github.com/repos/cakephp/cakephp/issues/12168","repository_url":"https://api.github.com/repos/cakephp/cakephp","labels_url":"https://api.github.com/repos/cakephp/cakephp/issues/12168/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/12168/comments","events_url":"https://api.github.com/repos/cakephp/cakephp/issues/12168/events","html_url":"https://github.com/cakephp/cakephp/issues/12168","id":328680341,"node_id":"MDU6SXNzdWUzMjg2ODAzNDE=","number":12168,"title":"Http\\Client\\Adapter\\Stream not restoring error handler if wrapper throws exception","user":{"login":"snelg","id":5741887,"node_id":"MDQ6VXNlcjU3NDE4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/5741887?v=4","gravatar_id":"","url":"https://api.github.com/users/snelg","html_url":"https://github.com/snelg","followers_url":"https://api.github.com/users/snelg/followers","following_url":"https://api.github.com/users/snelg/following{/other_user}","gists_url":"https://api.github.com/users/snelg/gists{/gist_id}","starred_url":"https://api.github.com/users/snelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snelg/subscriptions","organizations_url":"https://api.github.com/users/snelg/orgs","repos_url":"https://api.github.com/users/snelg/repos","events_url":"https://api.github.com/users/snelg/events{/privacy}","received_events_url":"https://api.github.com/users/snelg/received_events","type":"User","site_admin":false},"labels":[{"id":60504544,"node_id":"MDU6TGFiZWw2MDUwNDU0NA==","url":"https://api.github.com/repos/cakephp/cakephp/labels/Defect","name":"Defect","color":"f7c6c7","default":false},{"id":60505665,"node_id":"MDU6TGFiZWw2MDUwNTY2NQ==","url":"https://api.github.com/repos/cakephp/cakephp/labels/errorhandler","name":"errorhandler","color":"FFFFFF","default":false},{"id":366710687,"node_id":"MDU6TGFiZWwzNjY3MTA2ODc=","url":"https://api.github.com/repos/cakephp/cakephp/labels/http","name":"http","color":"ffffff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/172","html_url":"https://github.com/cakephp/cakephp/milestone/172","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/172/labels","id":3360005,"node_id":"MDk6TWlsZXN0b25lMzM2MDAwNQ==","number":172,"title":"3.6.5","description":"Bugfixes for 3.6.x","creator":{"login":"markstory","id":24086,"node_id":"MDQ6VXNlcjI0MDg2","avatar_url":"https://avatars3.githubusercontent.com/u/24086?v=4","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":32,"state":"open","created_at":"2018-05-21T02:30:44Z","updated_at":"2018-06-02T01:02:56Z","due_on":"2018-06-09T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-06-01T22:37:01Z","updated_at":"2018-06-02T01:02:56Z","closed_at":"2018-06-02T01:02:56Z","author_association":"NONE","body":"This is a (multiple allowed):\r\n\r\n* [x] bug\r\n* [ ] enhancement\r\n* [ ] feature-discussion (RFC)\r\n\r\n* CakePHP Version: 3.6.4\r\n* Platform and Target: phpunit\r\n\r\n### What you did\r\nRan some unit tests that use php-vcr\r\n\r\n### What happened\r\nI noticed that some error messages were disappearing. Figured out that ConsoleErrorHandler wasn't handling errors.\r\nTracked down the culprit to Cake\\Http\\Client\\Adapter\\Stream.php:\r\n`restore_error_handler` on line 310 not being called when `fopen` on line 309 throws an exception, leaving the little error handling closure on line 306 handling all subsequent errors for the whole process. \r\n\r\n### What you expected to happen\r\nI expected to see error messages :)\r\n\r\nI have a pull request ready to go, just submitting this issue first."}}
{"actor":{"display_login":"markstory"}}