{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/arcade/issues/1204","repository_url":"https://api.github.com/repos/dotnet/arcade","labels_url":"https://api.github.com/repos/dotnet/arcade/issues/1204/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/1204/comments","events_url":"https://api.github.com/repos/dotnet/arcade/issues/1204/events","html_url":"https://github.com/dotnet/arcade/issues/1204","id":375156509,"node_id":"MDU6SXNzdWUzNzUxNTY1MDk=","number":1204,"title":"Add support for resigning binaries in SignTool ","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false},"assignees":[{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-10-29T18:28:38Z","updated_at":"2018-11-07T21:57:04Z","closed_at":null,"author_association":"MEMBER","body":"There are a number of times where we need to re-sign a strong named binary. For example for libraries where we have the full public/private key (i.e. open key) that we need to rewrite them after compile which causes any full signing the compiler did to become invalid. CoreFx has a number of cases like the GenFacades tool that has this issue. Another example would be adding optimization data to the binary after the fact and we need to resign the binary.\r\n\r\nFor keys like the Open key we cannot have the signing service strong name sign the binary because it is not a protected key with a protected certificate so the normal signing service will not sign it for us. We need to use either sn directly like we did in BuildTools (https://github.com/dotnet/buildtools/blob/master/src/Microsoft.DotNet.Build.Tasks/PackageFiles/sign.targets#L78) or add support for this in the SignTool itself. I'd much prefer the later as it keeps this signing logic centralized.\r\n\r\ncc @JohnTortugo @tmat \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/arcade/issues/comments/436792411","html_url":"https://github.com/dotnet/arcade/issues/1204#issuecomment-436792411","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/1204","id":436792411,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjc5MjQxMQ==","user":{"login":"jcagme","id":28021475,"node_id":"MDQ6VXNlcjI4MDIxNDc1","avatar_url":"https://avatars1.githubusercontent.com/u/28021475?v=4","gravatar_id":"","url":"https://api.github.com/users/jcagme","html_url":"https://github.com/jcagme","followers_url":"https://api.github.com/users/jcagme/followers","following_url":"https://api.github.com/users/jcagme/following{/other_user}","gists_url":"https://api.github.com/users/jcagme/gists{/gist_id}","starred_url":"https://api.github.com/users/jcagme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcagme/subscriptions","organizations_url":"https://api.github.com/users/jcagme/orgs","repos_url":"https://api.github.com/users/jcagme/repos","events_url":"https://api.github.com/users/jcagme/events{/privacy}","received_events_url":"https://api.github.com/users/jcagme/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T21:57:04Z","updated_at":"2018-11-07T21:57:04Z","author_association":"CONTRIBUTOR","body":"Is this currently breaking corefx? If so this should be fixed prior 12/4 (?)"}}
{"actor":{"display_login":"jcagme"}}