{"comment":{"url":"https://api.github.com/repos/dotnet/reactive/comments/31813092","html_url":"https://github.com/dotnet/reactive/commit/4054bcec72f4d143994966958fab2f7f00016be7#commitcomment-31813092","id":31813092,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMTgxMzA5Mg==","user":{"login":"bartdesmet","id":7324746,"node_id":"MDQ6VXNlcjczMjQ3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7324746?v=4","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"4054bcec72f4d143994966958fab2f7f00016be7","created_at":"2019-01-01T17:35:03Z","updated_at":"2019-01-01T17:35:03Z","author_association":"COLLABORATOR","body":"We can, but I have a series of commits pending that #if check for C# 8 to try using await foreach and async iterators. We'll need both pieces of code for a while as we figure out the perf impact of using these while the features are still evolving for cancellation support. Right now, iterators will be enumerators with enumerable wrappers (so no lazy cloning) so we can get a hold of the cancellation token. Same for await foreach usage where we need ConfigureAwait decorators on sources to influence this behavior and to pass in a cancellation token.\r\n\r\nI'm hoping we can and will use the new C# features to get rid of a ton of complexity with hand-rolled state machines, some of which aren't entirely correct with regards to cleanup order etc. But to get there, I'd like to be able to switch back and forth between different build options. Fine if we can achieve this with /p flags passed to the build as well of course, without needing new build configs."}}
{"actor":{"display_login":"bartdesmet"}}