{"action":"created","comment":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/comments/216224255","pull_request_review_id":153655197,"id":216224255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIyNDI1NQ==","diff_hunk":"@@ -0,0 +1,23 @@\n+/*\n+ * This file is part of the SDWebImage package.\n+ * (c) Olivier Poitrey <rs@dailymotion.com>\n+ * (c) Florent Vilmart\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+#import <MapKit/MapKit.h>\n+\n+//! Project version number for WebImage.\n+FOUNDATION_EXPORT double MapKitWebImageVersionNumber;\n+\n+//! Project version string for WebImage.\n+FOUNDATION_EXPORT const unsigned char MapKitWebImageVersionString[];\n+\n+// In this header, you should import all the public headers of your framework using statements like #import <MapKitWebImage/PublicHeader.h>\n+\n+// MapKit\n+#if __has_include(<SDWebImage/MKAnnotationView+WebCache.h>)\n+#import <SDMapKitWebImage/MKAnnotationView+WebCache.h>","path":"WebImage/SDMapKitWebImage.h","position":22,"original_position":22,"commit_id":"410a92397ceecc7bfaca54a60f28ca20dbb4104a","original_commit_id":"410a92397ceecc7bfaca54a60f28ca20dbb4104a","user":{"login":"dreampiggy","id":6919743,"node_id":"MDQ6VXNlcjY5MTk3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"body":"Emm...This import seems contains issue. Maybe we should use `#if __has_include(< SDMapKitWebImage/MKAnnotationView+WebCache.h>)`\r\n\r\nAny, I still suggest to use `SDWebImageMapKit` for generated framework naming. Using the suffix one seems a little strange compared to other frameworks. ","created_at":"2018-09-10T07:42:56Z","updated_at":"2018-09-10T07:43:01Z","html_url":"https://github.com/rs/SDWebImage/pull/2476#discussion_r216224255","pull_request_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2476","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/comments/216224255"},"html":{"href":"https://github.com/rs/SDWebImage/pull/2476#discussion_r216224255"},"pull_request":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2476"}}},"pull_request":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/2476","id":213956025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTU2MDI1","html_url":"https://github.com/rs/SDWebImage/pull/2476","diff_url":"https://github.com/rs/SDWebImage/pull/2476.diff","patch_url":"https://github.com/rs/SDWebImage/pull/2476.patch","issue_url":"https://api.github.com/repos/rs/SDWebImage/issues/2476","number":2476,"state":"open","locked":false,"title":"Merged targets + MapKit dedicated target for Carthage installs","user":{"login":"bpoplauschi","id":154913,"node_id":"MDQ6VXNlcjE1NDkxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/154913?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoplauschi","html_url":"https://github.com/bpoplauschi","followers_url":"https://api.github.com/users/bpoplauschi/followers","following_url":"https://api.github.com/users/bpoplauschi/following{/other_user}","gists_url":"https://api.github.com/users/bpoplauschi/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoplauschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoplauschi/subscriptions","organizations_url":"https://api.github.com/users/bpoplauschi/orgs","repos_url":"https://api.github.com/users/bpoplauschi/repos","events_url":"https://api.github.com/users/bpoplauschi/events{/privacy}","received_events_url":"https://api.github.com/users/bpoplauschi/received_events","type":"User","site_admin":false},"body":"### New Pull Request Checklist\r\n\r\n* [X] I have read and understood the [CONTRIBUTING guide](https://github.com/rs/SDWebImage/blob/master/.github/CONTRIBUTING.md)\r\n* [X] I have read the [Documentation](http://cocoadocs.org/docsets/SDWebImage/)\r\n* [X] I have searched for a similar pull request in the [project](https://github.com/rs/SDWebImage/pulls) and found none\r\n\r\n* [X] I have updated this branch with the latest 5.x to avoid conflicts (via rebase)\r\n* [X] I have updated the documentation (if necessary)\r\n* [X] I have run the tests and they pass\r\n* [X] I have run the lint and it passes (`pod lib lint`)\r\n\r\nThis pull request replaces #2078 \r\n\r\n### Pull Request Description\r\n\r\n- Merged `SDWebImage iOS` + `SDWebImage OSX` + `SDWebImage tvOS` + `SDWebImage watchOS` targets into `SDWebImage` target (supports all platforms)\r\n- Merged `SDWebImage iOS static` + `SDWebImage watchOS static` targets into `SDWebImage static` target (supports all platforms)\r\n- Created dedicated `SDMapKitWebImage` target similar to the way Moya or ReactiveCocoa solved this.\r\n- updated README\r\n\r\nAll this is done for:\r\n- ability to install via Carthage without MapKit dependency - now we generate `SDWebImage.framework` and `SDMapKitWebImage.framework` so the users can choose one or both\r\n- simpler management of targets (no need to duplicate effort).","created_at":"2018-09-07T15:02:05Z","updated_at":"2018-09-10T07:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546abbab2b82eec86c5de6ef1b4813bc7fa54dd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/rs/SDWebImage/milestones/15","html_url":"https://github.com/rs/SDWebImage/milestone/15","labels_url":"https://api.github.com/repos/rs/SDWebImage/milestones/15/labels","id":2676459,"node_id":"MDk6TWlsZXN0b25lMjY3NjQ1OQ==","number":15,"title":"5.0.0","description":"5.0.0 beta release","creator":{"login":"bpoplauschi","id":154913,"node_id":"MDQ6VXNlcjE1NDkxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/154913?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoplauschi","html_url":"https://github.com/bpoplauschi","followers_url":"https://api.github.com/users/bpoplauschi/followers","following_url":"https://api.github.com/users/bpoplauschi/following{/other_user}","gists_url":"https://api.github.com/users/bpoplauschi/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoplauschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoplauschi/subscriptions","organizations_url":"https://api.github.com/users/bpoplauschi/orgs","repos_url":"https://api.github.com/users/bpoplauschi/repos","events_url":"https://api.github.com/users/bpoplauschi/events{/privacy}","received_events_url":"https://api.github.com/users/bpoplauschi/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":73,"state":"open","created_at":"2017-08-02T12:24:08Z","updated_at":"2018-09-08T17:10:17Z","due_on":"2018-08-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2476/commits","review_comments_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2476/comments","review_comment_url":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rs/SDWebImage/issues/2476/comments","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/410a92397ceecc7bfaca54a60f28ca20dbb4104a","head":{"label":"rs:MapKit_target","ref":"MapKit_target","sha":"410a92397ceecc7bfaca54a60f28ca20dbb4104a","user":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"repo":{"id":313419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM0MTk=","name":"SDWebImage","full_name":"rs/SDWebImage","owner":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":false,"url":"https://api.github.com/repos/rs/SDWebImage","forks_url":"https://api.github.com/repos/rs/SDWebImage/forks","keys_url":"https://api.github.com/repos/rs/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs/SDWebImage/teams","hooks_url":"https://api.github.com/repos/rs/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/rs/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/rs/SDWebImage/events","assignees_url":"https://api.github.com/repos/rs/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/rs/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/rs/SDWebImage/tags","blobs_url":"https://api.github.com/repos/rs/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/rs/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/rs/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/rs/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/rs/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/rs/SDWebImage/subscription","commits_url":"https://api.github.com/repos/rs/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/rs/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs/SDWebImage/merges","archive_url":"https://api.github.com/repos/rs/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs/SDWebImage/downloads","issues_url":"https://api.github.com/repos/rs/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/rs/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/rs/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/rs/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/rs/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/rs/SDWebImage/deployments","created_at":"2009-09-21T17:39:19Z","updated_at":"2018-09-10T07:25:16Z","pushed_at":"2018-09-10T07:10:40Z","git_url":"git://github.com/rs/SDWebImage.git","ssh_url":"git@github.com:rs/SDWebImage.git","clone_url":"https://github.com/rs/SDWebImage.git","svn_url":"https://github.com/rs/SDWebImage","homepage":"http://cocoadocs.org/docsets/SDWebImage","size":10459,"stargazers_count":20439,"watchers_count":20439,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5264,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5264,"open_issues":17,"watchers":20439,"default_branch":"master"}},"base":{"label":"rs:5.x","ref":"5.x","sha":"bb7adaca376722301cd4f2830252205e1f6df12a","user":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"repo":{"id":313419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM0MTk=","name":"SDWebImage","full_name":"rs/SDWebImage","owner":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":false,"url":"https://api.github.com/repos/rs/SDWebImage","forks_url":"https://api.github.com/repos/rs/SDWebImage/forks","keys_url":"https://api.github.com/repos/rs/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs/SDWebImage/teams","hooks_url":"https://api.github.com/repos/rs/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/rs/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/rs/SDWebImage/events","assignees_url":"https://api.github.com/repos/rs/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/rs/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/rs/SDWebImage/tags","blobs_url":"https://api.github.com/repos/rs/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/rs/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/rs/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/rs/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/rs/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/rs/SDWebImage/subscription","commits_url":"https://api.github.com/repos/rs/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/rs/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs/SDWebImage/merges","archive_url":"https://api.github.com/repos/rs/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs/SDWebImage/downloads","issues_url":"https://api.github.com/repos/rs/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/rs/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/rs/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/rs/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/rs/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/rs/SDWebImage/deployments","created_at":"2009-09-21T17:39:19Z","updated_at":"2018-09-10T07:25:16Z","pushed_at":"2018-09-10T07:10:40Z","git_url":"git://github.com/rs/SDWebImage.git","ssh_url":"git@github.com:rs/SDWebImage.git","clone_url":"https://github.com/rs/SDWebImage.git","svn_url":"https://github.com/rs/SDWebImage","homepage":"http://cocoadocs.org/docsets/SDWebImage","size":10459,"stargazers_count":20439,"watchers_count":20439,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5264,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5264,"open_issues":17,"watchers":20439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2476"},"html":{"href":"https://github.com/rs/SDWebImage/pull/2476"},"issue":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/2476"},"comments":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/2476/comments"},"review_comments":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2476/comments"},"review_comment":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2476/commits"},"statuses":{"href":"https://api.github.com/repos/rs/SDWebImage/statuses/410a92397ceecc7bfaca54a60f28ca20dbb4104a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dreampiggy"}}