{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/48913","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/48913/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48913/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/48913/events","html_url":"https://github.com/rust-lang/rust/pull/48913","id":304073346,"number":48913,"title":"Add tests to rustbuild","user":{"login":"Mark-Simulacrum","id":5047365,"avatar_url":"https://avatars0.githubusercontent.com/u/5047365?v=4","gravatar_id":"","url":"https://api.github.com/users/Mark-Simulacrum","html_url":"https://github.com/Mark-Simulacrum","followers_url":"https://api.github.com/users/Mark-Simulacrum/followers","following_url":"https://api.github.com/users/Mark-Simulacrum/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Simulacrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Simulacrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Simulacrum/subscriptions","organizations_url":"https://api.github.com/users/Mark-Simulacrum/orgs","repos_url":"https://api.github.com/users/Mark-Simulacrum/repos","events_url":"https://api.github.com/users/Mark-Simulacrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Simulacrum/received_events","type":"User","site_admin":false},"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-03-10T14:08:32Z","updated_at":"2018-03-23T16:27:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48913","html_url":"https://github.com/rust-lang/rust/pull/48913","diff_url":"https://github.com/rust-lang/rust/pull/48913.diff","patch_url":"https://github.com/rust-lang/rust/pull/48913.patch"},"body":"In order to run tests, we cfg out various parts of rustbuild. Generally\r\nspeaking, these are filesystem and process-spawning operations. Then, rustbuild\r\nis run \"as normal\" and the various steps that where run are retrieved from the\r\ncache and checked against the expected results.\r\n\r\nNote that this means that the current implementation primarily tests \"what\" we\r\nbuild, but doesn't actually test that what we build *will* build. In other\r\nwords, it doesn't do any form of dependency verification for any crate. This is\r\npossible to implement, but is considered future work.\r\n\r\nThis implementation strives to cfg out as little code as possible; it also does\r\nnot currently test anywhere near all of rustbuild. The current tests are also\r\nnot checked for \"correctness,\" rather, they simply represent what we do as of\r\nthis commit, which may be wrong.\r\n\r\nTest cases are drawn from the old implementation of rustbuild, though the\r\nexpected results may vary.\r\n\r\nr? @alexcrichton "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/375722608","html_url":"https://github.com/rust-lang/rust/pull/48913#issuecomment-375722608","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48913","id":375722608,"user":{"login":"shepmaster","id":174509,"avatar_url":"https://avatars0.githubusercontent.com/u/174509?v=4","gravatar_id":"","url":"https://api.github.com/users/shepmaster","html_url":"https://github.com/shepmaster","followers_url":"https://api.github.com/users/shepmaster/followers","following_url":"https://api.github.com/users/shepmaster/following{/other_user}","gists_url":"https://api.github.com/users/shepmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/shepmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shepmaster/subscriptions","organizations_url":"https://api.github.com/users/shepmaster/orgs","repos_url":"https://api.github.com/users/shepmaster/repos","events_url":"https://api.github.com/users/shepmaster/events{/privacy}","received_events_url":"https://api.github.com/users/shepmaster/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T16:27:21Z","updated_at":"2018-03-23T16:27:21Z","author_association":"MEMBER","body":"Ping from triage, @alexcrichton — will you have time to continue your review soon?"}}
{"actor":{"display_login":"shepmaster"}}