{"action":"created","comment":{"url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments/228110503","pull_request_review_id":168293789,"id":228110503,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODExMDUwMw==","diff_hunk":"@@ -25,11 +25,24 @@ contract ColonyNetworkAuction is ColonyNetworkStorage {\n   event AuctionCreated(address auction, address token, uint256 quantity);\n \n   function startTokenAuction(address _token) public stoppable {\n+    require(_token != 0x0, \"colony-auction-invalid-token\");\n+\n     uint lastAuctionTimestamp = recentAuctions[_token];\n     require(lastAuctionTimestamp == 0 || now - lastAuctionTimestamp >= 30 days, \"colony-auction-start-too-soon\");\n+\n     address clny = IColony(metaColony).getToken();\n-    DutchAuction auction = new DutchAuction(clny, _token, metaColony);\n+    require(clny != 0x0, \"colony-auction-invalid-token\");\n+\n     uint availableTokens = ERC20Extended(_token).balanceOf(this);\n+\n+    if (_token==clny) {\n+      // We don't auction CLNY. We just burn it instead.\n+      // Note we can do this more often than every 30 days.\n+      ERC20Extended(clny).burn(availableTokens);","path":"contracts/ColonyNetworkAuction.sol","position":18,"original_position":18,"commit_id":"0b44878276ca8749e43734f92e94038eaf792059","original_commit_id":"0b44878276ca8749e43734f92e94038eaf792059","user":{"login":"elenadimitrova","id":703848,"node_id":"MDQ6VXNlcjcwMzg0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/703848?v=4","gravatar_id":"","url":"https://api.github.com/users/elenadimitrova","html_url":"https://github.com/elenadimitrova","followers_url":"https://api.github.com/users/elenadimitrova/followers","following_url":"https://api.github.com/users/elenadimitrova/following{/other_user}","gists_url":"https://api.github.com/users/elenadimitrova/gists{/gist_id}","starred_url":"https://api.github.com/users/elenadimitrova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenadimitrova/subscriptions","organizations_url":"https://api.github.com/users/elenadimitrova/orgs","repos_url":"https://api.github.com/users/elenadimitrova/repos","events_url":"https://api.github.com/users/elenadimitrova/events{/privacy}","received_events_url":"https://api.github.com/users/elenadimitrova/received_events","type":"User","site_admin":false},"body":"ColonyNetwork will receive CLNY from:\r\n- MetaColony task payout fees\r\n- MetaColony rewards payout fees\r\n(no longer auctions since this PR)\r\n\r\nThe above will be burned here so wanted to make sure we're okay with that.","created_at":"2018-10-25T10:00:59Z","updated_at":"2018-10-25T10:10:30Z","html_url":"https://github.com/JoinColony/colonyNetwork/pull/395#discussion_r228110503","pull_request_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments/228110503"},"html":{"href":"https://github.com/JoinColony/colonyNetwork/pull/395#discussion_r228110503"},"pull_request":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395","id":225311863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzExODYz","html_url":"https://github.com/JoinColony/colonyNetwork/pull/395","diff_url":"https://github.com/JoinColony/colonyNetwork/pull/395.diff","patch_url":"https://github.com/JoinColony/colonyNetwork/pull/395.patch","issue_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/395","number":395,"state":"open","locked":false,"title":"Economic tweaks","user":{"login":"area","id":311812,"node_id":"MDQ6VXNlcjMxMTgxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false},"body":"Closes #353\r\n\r\n* CLNY used in auctions is burned, not sent to MetaColony\r\n* If an auction of CLNY is attempted to be started, all CLNY held by ColonyNetwork is burned\r\n* Rewards have the network fee applied to them, same as task payouts\r\n\r\nMy notes are unclear as to whether 'fees being the same on all tokens, including native ones' applies to `claimColonyFunds`, so I have left that unchanged for now but should check with Jack.","created_at":"2018-10-24T08:36:44Z","updated_at":"2018-10-25T10:10:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a71d7d1aa3895d53ae69a1fa7164ad9b68448aa","assignee":{"login":"area","id":311812,"node_id":"MDQ6VXNlcjMxMTgxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false},"assignees":[{"login":"area","id":311812,"node_id":"MDQ6VXNlcjMxMTgxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":961063666,"node_id":"MDU6TGFiZWw5NjEwNjM2NjY=","url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels/under-review","name":"under-review","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395/commits","review_comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395/comments","review_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/395/comments","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/0b44878276ca8749e43734f92e94038eaf792059","head":{"label":"JoinColony:maintenance/353-burn-and-fees","ref":"maintenance/353-burn-and-fees","sha":"0b44878276ca8749e43734f92e94038eaf792059","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":89702863,"node_id":"MDEwOlJlcG9zaXRvcnk4OTcwMjg2Mw==","name":"colonyNetwork","full_name":"JoinColony/colonyNetwork","private":false,"owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JoinColony/colonyNetwork","description":"Colony Network smart contracts","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyNetwork","forks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyNetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyNetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyNetwork/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyNetwork/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyNetwork/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyNetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyNetwork/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyNetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyNetwork/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyNetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyNetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyNetwork/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/deployments","created_at":"2017-04-28T12:11:32Z","updated_at":"2018-10-23T09:15:09Z","pushed_at":"2018-10-24T16:36:22Z","git_url":"git://github.com/JoinColony/colonyNetwork.git","ssh_url":"git@github.com:JoinColony/colonyNetwork.git","clone_url":"https://github.com/JoinColony/colonyNetwork.git","svn_url":"https://github.com/JoinColony/colonyNetwork","homepage":"https://colony.io/","size":3886,"stargazers_count":264,"watchers_count":264,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":43,"open_issues":80,"watchers":264,"default_branch":"develop"}},"base":{"label":"JoinColony:develop","ref":"develop","sha":"ffc531a40c5c8fdad5fecb017d06e87fb5fe2309","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":89702863,"node_id":"MDEwOlJlcG9zaXRvcnk4OTcwMjg2Mw==","name":"colonyNetwork","full_name":"JoinColony/colonyNetwork","private":false,"owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JoinColony/colonyNetwork","description":"Colony Network smart contracts","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyNetwork","forks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyNetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyNetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyNetwork/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyNetwork/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyNetwork/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyNetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyNetwork/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyNetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyNetwork/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyNetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyNetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyNetwork/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/deployments","created_at":"2017-04-28T12:11:32Z","updated_at":"2018-10-23T09:15:09Z","pushed_at":"2018-10-24T16:36:22Z","git_url":"git://github.com/JoinColony/colonyNetwork.git","ssh_url":"git@github.com:JoinColony/colonyNetwork.git","clone_url":"https://github.com/JoinColony/colonyNetwork.git","svn_url":"https://github.com/JoinColony/colonyNetwork","homepage":"https://colony.io/","size":3886,"stargazers_count":264,"watchers_count":264,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":43,"open_issues":80,"watchers":264,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395"},"html":{"href":"https://github.com/JoinColony/colonyNetwork/pull/395"},"issue":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/395"},"comments":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/0b44878276ca8749e43734f92e94038eaf792059"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elenadimitrova"}}