{"action":"closed","number":225,"pull_request":{"url":"https://api.github.com/repos/Semmle/ql/pulls/225","id":217742649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzQyNjQ5","html_url":"https://github.com/Semmle/ql/pull/225","diff_url":"https://github.com/Semmle/ql/pull/225.diff","patch_url":"https://github.com/Semmle/ql/pull/225.patch","issue_url":"https://api.github.com/repos/Semmle/ql/issues/225","number":225,"state":"closed","locked":false,"title":"Allow void* pointer arithmetic with sizeof","user":{"login":"sauyon","id":2347889,"node_id":"MDQ6VXNlcjIzNDc4ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2347889?v=4","gravatar_id":"","url":"https://api.github.com/users/sauyon","html_url":"https://github.com/sauyon","followers_url":"https://api.github.com/users/sauyon/followers","following_url":"https://api.github.com/users/sauyon/following{/other_user}","gists_url":"https://api.github.com/users/sauyon/gists{/gist_id}","starred_url":"https://api.github.com/users/sauyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauyon/subscriptions","organizations_url":"https://api.github.com/users/sauyon/orgs","repos_url":"https://api.github.com/users/sauyon/repos","events_url":"https://api.github.com/users/sauyon/events{/privacy}","received_events_url":"https://api.github.com/users/sauyon/received_events","type":"User","site_admin":false},"body":"Since `void` is generally considered a 1-byte type when doing pointer arithmetic, these results are usually false positives.\r\n\r\nTechnically this isn't allowed by the C spec, but it's been seen in the wild:\r\nsee https://lgtm.com/projects/g/libcsp/libcsp/snapshot/3763c7b3380f95c81636de5c95156fd3ef151a21/files/src/csp_buffer.c\\#x1d04047d2bb68c21:1.\r\n\r\n@geoffw0 ","created_at":"2018-09-24T18:13:12Z","updated_at":"2018-09-25T21:53:08Z","closed_at":"2018-09-25T21:53:08Z","merged_at":"2018-09-25T21:53:08Z","merge_commit_sha":"9c219b958c252a693c6a0670894b691d1b5b077c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1013984560,"node_id":"MDU6TGFiZWwxMDEzOTg0NTYw","url":"https://api.github.com/repos/Semmle/ql/labels/C++","name":"C++","color":"6add92","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Semmle/ql/pulls/225/commits","review_comments_url":"https://api.github.com/repos/Semmle/ql/pulls/225/comments","review_comment_url":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Semmle/ql/issues/225/comments","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/614a8ef09158e558cc4dd874fcbcd6835ecc28b8","head":{"label":"sauyon:sizeofcheck","ref":"sizeofcheck","sha":"614a8ef09158e558cc4dd874fcbcd6835ecc28b8","user":{"login":"sauyon","id":2347889,"node_id":"MDQ6VXNlcjIzNDc4ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2347889?v=4","gravatar_id":"","url":"https://api.github.com/users/sauyon","html_url":"https://github.com/sauyon","followers_url":"https://api.github.com/users/sauyon/followers","following_url":"https://api.github.com/users/sauyon/following{/other_user}","gists_url":"https://api.github.com/users/sauyon/gists{/gist_id}","starred_url":"https://api.github.com/users/sauyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauyon/subscriptions","organizations_url":"https://api.github.com/users/sauyon/orgs","repos_url":"https://api.github.com/users/sauyon/repos","events_url":"https://api.github.com/users/sauyon/events{/privacy}","received_events_url":"https://api.github.com/users/sauyon/received_events","type":"User","site_admin":false},"repo":{"id":150146162,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNDYxNjI=","name":"ql","full_name":"sauyon/ql","private":false,"owner":{"login":"sauyon","id":2347889,"node_id":"MDQ6VXNlcjIzNDc4ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2347889?v=4","gravatar_id":"","url":"https://api.github.com/users/sauyon","html_url":"https://github.com/sauyon","followers_url":"https://api.github.com/users/sauyon/followers","following_url":"https://api.github.com/users/sauyon/following{/other_user}","gists_url":"https://api.github.com/users/sauyon/gists{/gist_id}","starred_url":"https://api.github.com/users/sauyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauyon/subscriptions","organizations_url":"https://api.github.com/users/sauyon/orgs","repos_url":"https://api.github.com/users/sauyon/repos","events_url":"https://api.github.com/users/sauyon/events{/privacy}","received_events_url":"https://api.github.com/users/sauyon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sauyon/ql","description":"The standard QL libraries and queries that power LGTM.com and other Semmle Products","fork":true,"url":"https://api.github.com/repos/sauyon/ql","forks_url":"https://api.github.com/repos/sauyon/ql/forks","keys_url":"https://api.github.com/repos/sauyon/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sauyon/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sauyon/ql/teams","hooks_url":"https://api.github.com/repos/sauyon/ql/hooks","issue_events_url":"https://api.github.com/repos/sauyon/ql/issues/events{/number}","events_url":"https://api.github.com/repos/sauyon/ql/events","assignees_url":"https://api.github.com/repos/sauyon/ql/assignees{/user}","branches_url":"https://api.github.com/repos/sauyon/ql/branches{/branch}","tags_url":"https://api.github.com/repos/sauyon/ql/tags","blobs_url":"https://api.github.com/repos/sauyon/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sauyon/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sauyon/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/sauyon/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sauyon/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/sauyon/ql/languages","stargazers_url":"https://api.github.com/repos/sauyon/ql/stargazers","contributors_url":"https://api.github.com/repos/sauyon/ql/contributors","subscribers_url":"https://api.github.com/repos/sauyon/ql/subscribers","subscription_url":"https://api.github.com/repos/sauyon/ql/subscription","commits_url":"https://api.github.com/repos/sauyon/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/sauyon/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/sauyon/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/sauyon/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/sauyon/ql/contents/{+path}","compare_url":"https://api.github.com/repos/sauyon/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sauyon/ql/merges","archive_url":"https://api.github.com/repos/sauyon/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sauyon/ql/downloads","issues_url":"https://api.github.com/repos/sauyon/ql/issues{/number}","pulls_url":"https://api.github.com/repos/sauyon/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/sauyon/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/sauyon/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sauyon/ql/labels{/name}","releases_url":"https://api.github.com/repos/sauyon/ql/releases{/id}","deployments_url":"https://api.github.com/repos/sauyon/ql/deployments","created_at":"2018-09-24T18:04:03Z","updated_at":"2018-09-24T18:04:18Z","pushed_at":"2018-09-24T18:05:46Z","git_url":"git://github.com/sauyon/ql.git","ssh_url":"git@github.com:sauyon/ql.git","clone_url":"https://github.com/sauyon/ql.git","svn_url":"https://github.com/sauyon/ql","homepage":"https://semmle.com/ql","size":7831,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Semmle:master","ref":"master","sha":"473252632c06ab71029f34262e88e40044d219ea","user":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"repo":{"id":143040428,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDA0Mjg=","name":"ql","full_name":"Semmle/ql","private":false,"owner":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semmle/ql","description":"The standard QL libraries and queries that power LGTM.com and other Semmle Products","fork":false,"url":"https://api.github.com/repos/Semmle/ql","forks_url":"https://api.github.com/repos/Semmle/ql/forks","keys_url":"https://api.github.com/repos/Semmle/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semmle/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semmle/ql/teams","hooks_url":"https://api.github.com/repos/Semmle/ql/hooks","issue_events_url":"https://api.github.com/repos/Semmle/ql/issues/events{/number}","events_url":"https://api.github.com/repos/Semmle/ql/events","assignees_url":"https://api.github.com/repos/Semmle/ql/assignees{/user}","branches_url":"https://api.github.com/repos/Semmle/ql/branches{/branch}","tags_url":"https://api.github.com/repos/Semmle/ql/tags","blobs_url":"https://api.github.com/repos/Semmle/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semmle/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semmle/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semmle/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/Semmle/ql/languages","stargazers_url":"https://api.github.com/repos/Semmle/ql/stargazers","contributors_url":"https://api.github.com/repos/Semmle/ql/contributors","subscribers_url":"https://api.github.com/repos/Semmle/ql/subscribers","subscription_url":"https://api.github.com/repos/Semmle/ql/subscription","commits_url":"https://api.github.com/repos/Semmle/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semmle/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semmle/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semmle/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semmle/ql/contents/{+path}","compare_url":"https://api.github.com/repos/Semmle/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semmle/ql/merges","archive_url":"https://api.github.com/repos/Semmle/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semmle/ql/downloads","issues_url":"https://api.github.com/repos/Semmle/ql/issues{/number}","pulls_url":"https://api.github.com/repos/Semmle/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/Semmle/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/Semmle/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semmle/ql/labels{/name}","releases_url":"https://api.github.com/repos/Semmle/ql/releases{/id}","deployments_url":"https://api.github.com/repos/Semmle/ql/deployments","created_at":"2018-07-31T16:35:51Z","updated_at":"2018-09-25T07:01:41Z","pushed_at":"2018-09-25T21:53:08Z","git_url":"git://github.com/Semmle/ql.git","ssh_url":"git@github.com:Semmle/ql.git","clone_url":"https://github.com/Semmle/ql.git","svn_url":"https://github.com/Semmle/ql","homepage":"https://semmle.com/ql","size":7844,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":23,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Semmle/ql/pulls/225"},"html":{"href":"https://github.com/Semmle/ql/pull/225"},"issue":{"href":"https://api.github.com/repos/Semmle/ql/issues/225"},"comments":{"href":"https://api.github.com/repos/Semmle/ql/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/Semmle/ql/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Semmle/ql/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/Semmle/ql/statuses/614a8ef09158e558cc4dd874fcbcd6835ecc28b8"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"geoffw0","id":40627776,"node_id":"MDQ6VXNlcjQwNjI3Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/40627776?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffw0","html_url":"https://github.com/geoffw0","followers_url":"https://api.github.com/users/geoffw0/followers","following_url":"https://api.github.com/users/geoffw0/following{/other_user}","gists_url":"https://api.github.com/users/geoffw0/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffw0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffw0/subscriptions","organizations_url":"https://api.github.com/users/geoffw0/orgs","repos_url":"https://api.github.com/users/geoffw0/repos","events_url":"https://api.github.com/users/geoffw0/events{/privacy}","received_events_url":"https://api.github.com/users/geoffw0/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"geoffw0"}}