{"action":"created","issue":{"url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/416","repository_url":"https://api.github.com/repos/open-watcom/open-watcom-v2","labels_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/416/comments","events_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/416/events","html_url":"https://github.com/open-watcom/open-watcom-v2/issues/416","id":308725939,"number":416,"title":"Ndisasm and posix_write","user":{"login":"rdos314","id":5267589,"avatar_url":"https://avatars0.githubusercontent.com/u/5267589?v=4","gravatar_id":"","url":"https://api.github.com/users/rdos314","html_url":"https://github.com/rdos314","followers_url":"https://api.github.com/users/rdos314/followers","following_url":"https://api.github.com/users/rdos314/following{/other_user}","gists_url":"https://api.github.com/users/rdos314/gists{/gist_id}","starred_url":"https://api.github.com/users/rdos314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdos314/subscriptions","organizations_url":"https://api.github.com/users/rdos314/orgs","repos_url":"https://api.github.com/users/rdos314/repos","events_url":"https://api.github.com/users/rdos314/events{/privacy}","received_events_url":"https://api.github.com/users/rdos314/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-26T20:36:53Z","updated_at":"2018-03-27T08:59:26Z","closed_at":null,"author_association":"MEMBER","body":"It seems like wdis doesn't replace LF with CR LF when outputting results for RDOS. It does seem to work on Win32. It uses posix_write to output results, which is mapped to the write function. Is it really correct that the write function should replace LF with CR LF?  I thought it was supposed to output its data as binary?\r\n\r\nAlso, there is no such problem for the compiler tools or the linker.\r\n"},"comment":{"url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/comments/376449375","html_url":"https://github.com/open-watcom/open-watcom-v2/issues/416#issuecomment-376449375","issue_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/416","id":376449375,"user":{"login":"jmalak","id":2017260,"avatar_url":"https://avatars0.githubusercontent.com/u/2017260?v=4","gravatar_id":"","url":"https://api.github.com/users/jmalak","html_url":"https://github.com/jmalak","followers_url":"https://api.github.com/users/jmalak/followers","following_url":"https://api.github.com/users/jmalak/following{/other_user}","gists_url":"https://api.github.com/users/jmalak/gists{/gist_id}","starred_url":"https://api.github.com/users/jmalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmalak/subscriptions","organizations_url":"https://api.github.com/users/jmalak/orgs","repos_url":"https://api.github.com/users/jmalak/repos","events_url":"https://api.github.com/users/jmalak/events{/privacy}","received_events_url":"https://api.github.com/users/jmalak/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T08:59:26Z","updated_at":"2018-03-27T08:59:26Z","author_association":"OWNER","body":"I don't think that use of \"\\r\\n\" is current in OW code. Mostly I remove it, if possible.\r\nIt is used mainly in Windows specific code where file is open as Binary file and hold text or for clipboard etc.\r\nAnyway bootstrap tools are using \"\\n\" as line end to be portable.\r\n\r\nISO C/C++ define character as 8-bit minimum.\r\n7-bit can be used only with pure ASCII character set (0-127), it is little bit archaic nowdays.\r\nUTF-8 is standard 8-bit characters stream, that no problem with it. \r\nIt doesn't presume anything about LF/CRLF it is OS dependent.\r\n"}}
{"actor":{"display_login":"jmalak"}}