{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/173168188","pull_request_review_id":102310869,"id":173168188,"diff_hunk":"@@ -271,7 +270,8 @@ DROP TABLE IF EXISTS index_by_id_height_asset;\n       auto storage_ptr = std::move(mutableStorage);  // get ownership of storage\n       auto storage = static_cast<MutableStorageImpl *>(storage_ptr.get());\n       for (const auto &block : storage->block_store_) {\n-        auto old_block = *std::unique_ptr<model::Block>(block.second->makeOldModel());\n+        auto old_block =\n+            *std::unique_ptr<model::Block>(block.second->makeOldModel());\n         block_store_->add(block.first,","path":"irohad/ametsuchi/impl/storage_impl.cpp","position":49,"original_position":49,"commit_id":"76d7c4f13dcad4670e6b750724262e15f7dffc8d","original_commit_id":"76d7c4f13dcad4670e6b750724262e15f7dffc8d","user":{"login":"nickaleks","id":14168731,"avatar_url":"https://avatars0.githubusercontent.com/u/14168731?v=4","gravatar_id":"","url":"https://api.github.com/users/nickaleks","html_url":"https://github.com/nickaleks","followers_url":"https://api.github.com/users/nickaleks/followers","following_url":"https://api.github.com/users/nickaleks/following{/other_user}","gists_url":"https://api.github.com/users/nickaleks/gists{/gist_id}","starred_url":"https://api.github.com/users/nickaleks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickaleks/subscriptions","organizations_url":"https://api.github.com/users/nickaleks/orgs","repos_url":"https://api.github.com/users/nickaleks/repos","events_url":"https://api.github.com/users/nickaleks/events{/privacy}","received_events_url":"https://api.github.com/users/nickaleks/received_events","type":"User","site_admin":false},"body":"AFAIK they work on protobuf objects, and not on abstract classes","created_at":"2018-03-08T14:12:58Z","updated_at":"2018-03-08T14:12:59Z","html_url":"https://github.com/hyperledger/iroha/pull/1046#discussion_r173168188","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1046","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/173168188"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1046#discussion_r173168188"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1046"}},"in_reply_to_id":172751987},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1046","id":173251048,"html_url":"https://github.com/hyperledger/iroha/pull/1046","diff_url":"https://github.com/hyperledger/iroha/pull/1046.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1046.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1046","number":1046,"state":"open","locked":false,"title":"Storage to shared model","user":{"login":"nickaleks","id":14168731,"avatar_url":"https://avatars0.githubusercontent.com/u/14168731?v=4","gravatar_id":"","url":"https://api.github.com/users/nickaleks","html_url":"https://github.com/nickaleks","followers_url":"https://api.github.com/users/nickaleks/followers","following_url":"https://api.github.com/users/nickaleks/following{/other_user}","gists_url":"https://api.github.com/users/nickaleks/gists{/gist_id}","starred_url":"https://api.github.com/users/nickaleks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickaleks/subscriptions","organizations_url":"https://api.github.com/users/nickaleks/orgs","repos_url":"https://api.github.com/users/nickaleks/repos","events_url":"https://api.github.com/users/nickaleks/events{/privacy}","received_events_url":"https://api.github.com/users/nickaleks/received_events","type":"User","site_admin":false},"body":"\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\n\r\nThis PR changes storage to shared_model\r\n<!-- We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. -->\r\n<!-- Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. -->\r\n\r\n### Benefits\r\n\r\nContinue migration to shared_model\r\n<!-- What benefits will be realized by the code change? -->\r\n\r\n### Possible Drawbacks \r\nNone\r\n<!-- What are the possible side-effects or negative impacts of the code change? -->\r\n<!-- If no drawbacks, explicitly mention this (write None) -->\r\n","created_at":"2018-03-06T19:01:46Z","updated_at":"2018-03-08T14:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"848c38a27eb5ce56c82a2784bf9fe53896b1dcdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":853992875,"url":"https://api.github.com/repos/hyperledger/iroha/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1046/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/76d7c4f13dcad4670e6b750724262e15f7dffc8d","head":{"label":"hyperledger:feature/shared_model_storage_refactor","ref":"feature/shared_model_storage_refactor","sha":"76d7c4f13dcad4670e6b750724262e15f7dffc8d","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-03-08T02:28:20Z","pushed_at":"2018-03-08T13:44:58Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45596,"stargazers_count":647,"watchers_count":647,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":211,"open_issues":48,"watchers":647,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"164ec3e4e2281801cb89219b312ba4f2d2bb218b","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-03-08T02:28:20Z","pushed_at":"2018-03-08T13:44:58Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45596,"stargazers_count":647,"watchers_count":647,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":211,"open_issues":48,"watchers":647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1046"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1046"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1046"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/76d7c4f13dcad4670e6b750724262e15f7dffc8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nickaleks"}}