{"action":"created","issue":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1133","repository_url":"https://api.github.com/repos/sxs-collaboration/spectre","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1133/labels{/name}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1133/comments","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1133/events","html_url":"https://github.com/sxs-collaboration/spectre/pull/1133","id":376204484,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDc3MDA1","number":1133,"title":"Move kerr_horizon_radius out of a test helper into its own function.","user":{"login":"markscheel","id":865400,"node_id":"MDQ6VXNlcjg2NTQwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/865400?v=4","gravatar_id":"","url":"https://api.github.com/users/markscheel","html_url":"https://github.com/markscheel","followers_url":"https://api.github.com/users/markscheel/followers","following_url":"https://api.github.com/users/markscheel/following{/other_user}","gists_url":"https://api.github.com/users/markscheel/gists{/gist_id}","starred_url":"https://api.github.com/users/markscheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markscheel/subscriptions","organizations_url":"https://api.github.com/users/markscheel/orgs","repos_url":"https://api.github.com/users/markscheel/repos","events_url":"https://api.github.com/users/markscheel/events{/privacy}","received_events_url":"https://api.github.com/users/markscheel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-01T00:02:32Z","updated_at":"2018-11-02T17:18:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1133","html_url":"https://github.com/sxs-collaboration/spectre/pull/1133","diff_url":"https://github.com/sxs-collaboration/spectre/pull/1133.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/1133.patch"},"body":"Moves kerr_horizon_radius out of a test helper, and makes it accessible outside tests.\r\n\r\nI want to use it for making a Strahlkorper corresponding to a Kerr\r\nhorizon.\r\n\r\n### Types of changes:\r\n\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments/435449844","html_url":"https://github.com/sxs-collaboration/spectre/pull/1133#issuecomment-435449844","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1133","id":435449844,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQ0OTg0NA==","user":{"login":"markscheel","id":865400,"node_id":"MDQ6VXNlcjg2NTQwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/865400?v=4","gravatar_id":"","url":"https://api.github.com/users/markscheel","html_url":"https://github.com/markscheel","followers_url":"https://api.github.com/users/markscheel/followers","following_url":"https://api.github.com/users/markscheel/following{/other_user}","gists_url":"https://api.github.com/users/markscheel/gists{/gist_id}","starred_url":"https://api.github.com/users/markscheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markscheel/subscriptions","organizations_url":"https://api.github.com/users/markscheel/orgs","repos_url":"https://api.github.com/users/markscheel/repos","events_url":"https://api.github.com/users/markscheel/events{/privacy}","received_events_url":"https://api.github.com/users/markscheel/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T17:18:46Z","updated_at":"2018-11-02T17:18:46Z","author_association":"CONTRIBUTOR","body":"About a test: Not sure the best way to test this.  But it is already used in other tests that pass, so in that sense it has a test."}}
{"actor":{"display_login":"markscheel"}}