{"action":"opened","number":1248,"pull_request":{"url":"https://api.github.com/repos/pingcap/pd/pulls/1248","id":215470589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDcwNTg5","html_url":"https://github.com/pingcap/pd/pull/1248","diff_url":"https://github.com/pingcap/pd/pull/1248.diff","patch_url":"https://github.com/pingcap/pd/pull/1248.patch","issue_url":"https://api.github.com/repos/pingcap/pd/issues/1248","number":1248,"state":"open","locked":false,"title":"simulator: make some parameters configurable","user":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"body":"### What problem does this PR solve? <!--add the issue link with summary if it exists-->\r\nThe current simulator has some parameters hard-coded. It is not friendly enough.\r\n\r\n### What is changed and how it works?\r\nThis PR is going to make some parameters of the simulator configurable and also renames some variables to make it more clear.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Manual test","created_at":"2018-09-14T03:17:58Z","updated_at":"2018-09-14T03:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/pd/pulls/1248/commits","review_comments_url":"https://api.github.com/repos/pingcap/pd/pulls/1248/comments","review_comment_url":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/pd/issues/1248/comments","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/bc41ddbb519e106187a7bf4b1310d8c04ebd9ee1","head":{"label":"rleungx:configurable","ref":"configurable","sha":"bc41ddbb519e106187a7bf4b1310d8c04ebd9ee1","user":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"repo":{"id":140550848,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NTA4NDg=","name":"pd","full_name":"rleungx/pd","owner":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rleungx/pd","description":"Placement driver for TiKV","fork":true,"url":"https://api.github.com/repos/rleungx/pd","forks_url":"https://api.github.com/repos/rleungx/pd/forks","keys_url":"https://api.github.com/repos/rleungx/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rleungx/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rleungx/pd/teams","hooks_url":"https://api.github.com/repos/rleungx/pd/hooks","issue_events_url":"https://api.github.com/repos/rleungx/pd/issues/events{/number}","events_url":"https://api.github.com/repos/rleungx/pd/events","assignees_url":"https://api.github.com/repos/rleungx/pd/assignees{/user}","branches_url":"https://api.github.com/repos/rleungx/pd/branches{/branch}","tags_url":"https://api.github.com/repos/rleungx/pd/tags","blobs_url":"https://api.github.com/repos/rleungx/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rleungx/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rleungx/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rleungx/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rleungx/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/rleungx/pd/languages","stargazers_url":"https://api.github.com/repos/rleungx/pd/stargazers","contributors_url":"https://api.github.com/repos/rleungx/pd/contributors","subscribers_url":"https://api.github.com/repos/rleungx/pd/subscribers","subscription_url":"https://api.github.com/repos/rleungx/pd/subscription","commits_url":"https://api.github.com/repos/rleungx/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rleungx/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rleungx/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rleungx/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rleungx/pd/contents/{+path}","compare_url":"https://api.github.com/repos/rleungx/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rleungx/pd/merges","archive_url":"https://api.github.com/repos/rleungx/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rleungx/pd/downloads","issues_url":"https://api.github.com/repos/rleungx/pd/issues{/number}","pulls_url":"https://api.github.com/repos/rleungx/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/rleungx/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/rleungx/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rleungx/pd/labels{/name}","releases_url":"https://api.github.com/repos/rleungx/pd/releases{/id}","deployments_url":"https://api.github.com/repos/rleungx/pd/deployments","created_at":"2018-07-11T09:14:04Z","updated_at":"2018-09-10T09:47:33Z","pushed_at":"2018-09-14T03:16:43Z","git_url":"git://github.com/rleungx/pd.git","ssh_url":"git@github.com:rleungx/pd.git","clone_url":"https://github.com/rleungx/pd.git","svn_url":"https://github.com/rleungx/pd","homepage":"","size":12204,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"4a874031746f2c94fbe455a8c933c83ce1d7005e","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53311716,"node_id":"MDEwOlJlcG9zaXRvcnk1MzMxMTcxNg==","name":"pd","full_name":"pingcap/pd","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/pd","description":"Placement driver for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/pd","forks_url":"https://api.github.com/repos/pingcap/pd/forks","keys_url":"https://api.github.com/repos/pingcap/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/pd/teams","hooks_url":"https://api.github.com/repos/pingcap/pd/hooks","issue_events_url":"https://api.github.com/repos/pingcap/pd/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/pd/events","assignees_url":"https://api.github.com/repos/pingcap/pd/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/pd/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/pd/tags","blobs_url":"https://api.github.com/repos/pingcap/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/pd/languages","stargazers_url":"https://api.github.com/repos/pingcap/pd/stargazers","contributors_url":"https://api.github.com/repos/pingcap/pd/contributors","subscribers_url":"https://api.github.com/repos/pingcap/pd/subscribers","subscription_url":"https://api.github.com/repos/pingcap/pd/subscription","commits_url":"https://api.github.com/repos/pingcap/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/pd/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/pd/merges","archive_url":"https://api.github.com/repos/pingcap/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/pd/downloads","issues_url":"https://api.github.com/repos/pingcap/pd/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/pd/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/pd/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/pd/deployments","created_at":"2016-03-07T09:13:06Z","updated_at":"2018-09-13T02:29:34Z","pushed_at":"2018-09-13T08:04:34Z","git_url":"git://github.com/pingcap/pd.git","ssh_url":"git@github.com:pingcap/pd.git","clone_url":"https://github.com/pingcap/pd.git","svn_url":"https://github.com/pingcap/pd","homepage":"","size":12228,"stargazers_count":243,"watchers_count":243,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":154,"open_issues":42,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1248"},"html":{"href":"https://github.com/pingcap/pd/pull/1248"},"issue":{"href":"https://api.github.com/repos/pingcap/pd/issues/1248"},"comments":{"href":"https://api.github.com/repos/pingcap/pd/issues/1248/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1248/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1248/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/pd/statuses/bc41ddbb519e106187a7bf4b1310d8c04ebd9ee1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":236,"deletions":132,"changed_files":18}}
{"actor":{"display_login":"rleungx"}}