{"action":"created","comment":{"url":"https://api.github.com/repos/nventive/Uno/pulls/comments/220923788","pull_request_review_id":159446455,"id":220923788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDkyMzc4OA==","diff_hunk":"@@ -13,46 +13,62 @@ namespace Uno.UI.Tests.ControlTests\n \tpublic partial class Given_Control\n \t{\n \t\t[TestMethod]\n-\t\tpublic void When_ManualyApplyTemplate()\n+\t\tpublic void When_ImplicitlyApplyTemplate()\n \t\t{\n-\t\t\tvar templatedRoot = default(UIElement);\n-\t\t\tvar sut = new MyControl\n+\t\t\ttry\n \t\t\t{\n-\t\t\t\tTemplate = new ControlTemplate(() => templatedRoot = new Grid())\n-\t\t\t};\n-\n-\t\t\tAssert.IsNull(sut.TemplatedRoot);\n-\t\t\tAssert.IsNull(templatedRoot);\n-\n-\t\t\tnew Grid().Children.Add(sut); // This kind-of simulate that the control is in the visual tree.\n+\t\t\t\tFeatureConfiguration.Control.UseLegacyLazyApplyTemplate = true;\n+\t\t\t\tvar templatedRoot = default(UIElement);\n+\t\t\t\tvar sut = new MyControl\n+\t\t\t\t{\n+\t\t\t\t\tTemplate = new ControlTemplate(() => templatedRoot = new Grid())\n+\t\t\t\t};\n \n-\t\t\tAssert.IsNull(sut.TemplatedRoot);\n-\t\t\tAssert.IsNull(templatedRoot);\n+\t\t\t\tAssert.IsNull(sut.TemplatedRoot);\n+\t\t\t\tAssert.IsNull(templatedRoot);\n \n-\t\t\tvar applied = sut.ApplyTemplate();\n+\t\t\t\tnew Grid().Children.Add(sut); // This kind-of simulate that the control is in the visual tree.\n \n-\t\t\tAssert.IsTrue(applied);\n-\t\t\tAssert.IsNotNull(sut.TemplatedRoot);\n-\t\t\tAssert.AreSame(templatedRoot, sut.TemplatedRoot);\n+\t\t\t\tAssert.IsNull(sut.TemplatedRoot);\n+\t\t\t\tAssert.IsNull(templatedRoot);\n+\t\t\t\t\n+\t\t\t\tsut.Visibility = Visibility.Collapsed;","path":"src/Uno.UI.Tests/ControlTests/Given_Control.cs","position":null,"original_position":39,"commit_id":"648cbb502ec6a344d3a64519e91b4b68f905a675","original_commit_id":"f418b1575b330dd765f962f266d96715b60be78a","user":{"login":"davidjohnoliver","id":8270914,"node_id":"MDQ6VXNlcjgyNzA5MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8270914?v=4","gravatar_id":"","url":"https://api.github.com/users/davidjohnoliver","html_url":"https://github.com/davidjohnoliver","followers_url":"https://api.github.com/users/davidjohnoliver/followers","following_url":"https://api.github.com/users/davidjohnoliver/following{/other_user}","gists_url":"https://api.github.com/users/davidjohnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjohnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjohnoliver/subscriptions","organizations_url":"https://api.github.com/users/davidjohnoliver/orgs","repos_url":"https://api.github.com/users/davidjohnoliver/repos","events_url":"https://api.github.com/users/davidjohnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/davidjohnoliver/received_events","type":"User","site_admin":false},"body":"@dr1rrb How about now?","created_at":"2018-09-27T13:32:47Z","updated_at":"2018-09-27T13:32:48Z","html_url":"https://github.com/nventive/Uno/pull/220#discussion_r220923788","pull_request_url":"https://api.github.com/repos/nventive/Uno/pulls/220","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nventive/Uno/pulls/comments/220923788"},"html":{"href":"https://github.com/nventive/Uno/pull/220#discussion_r220923788"},"pull_request":{"href":"https://api.github.com/repos/nventive/Uno/pulls/220"}},"in_reply_to_id":220773871},"pull_request":{"url":"https://api.github.com/repos/nventive/Uno/pulls/220","id":218501019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTAxMDE5","html_url":"https://github.com/nventive/Uno/pull/220","diff_url":"https://github.com/nventive/Uno/pull/220.diff","patch_url":"https://github.com/nventive/Uno/pull/220.patch","issue_url":"https://api.github.com/repos/nventive/Uno/issues/220","number":220,"state":"open","locked":false,"title":"Control - fix ApplyTemplate()","user":{"login":"davidjohnoliver","id":8270914,"node_id":"MDQ6VXNlcjgyNzA5MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8270914?v=4","gravatar_id":"","url":"https://api.github.com/users/davidjohnoliver","html_url":"https://github.com/davidjohnoliver","followers_url":"https://api.github.com/users/davidjohnoliver/followers","following_url":"https://api.github.com/users/davidjohnoliver/following{/other_user}","gists_url":"https://api.github.com/users/davidjohnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjohnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjohnoliver/subscriptions","organizations_url":"https://api.github.com/users/davidjohnoliver/orgs","repos_url":"https://api.github.com/users/davidjohnoliver/repos","events_url":"https://api.github.com/users/davidjohnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/davidjohnoliver/received_events","type":"User","site_admin":false},"body":"Fix bug where Control.ApplyTemplate() would only work when view was attached to the visual tree. UWP only requires that Template be non-null.\r\n\r\nRestore correct behaviour of Control.CanCreateTemplateWithoutParent.\r\n\r\nIssue: #133790\r\n<!-- Link to relevant issue. All PRs should be asociated with an issue -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please uncomment one ore more that apply to this PR -->\r\n\r\n<!-- - Bugfix -->\r\n<!-- - Feature -->\r\n<!-- - Code style update (formatting) -->\r\n<!-- - Refactoring (no functional changes, no api changes) -->\r\n<!-- - Build or CI related changes -->\r\n<!-- - Documentation content changes -->\r\n<!-- - Other... Please describe: -->\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] Tested code with current [supported SDKs](../README.md#supported)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/nventive/Uno/blob/master/doc/.feature-template.md). (for bug fixes / features)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] Contains **NO** breaking changes\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n     Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-09-27T01:45:59Z","updated_at":"2018-09-27T13:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfe18629cc5af4b86b684f60c28ba990314fb704","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeremiethibeault","id":5444226,"node_id":"MDQ6VXNlcjU0NDQyMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/5444226?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiethibeault","html_url":"https://github.com/jeremiethibeault","followers_url":"https://api.github.com/users/jeremiethibeault/followers","following_url":"https://api.github.com/users/jeremiethibeault/following{/other_user}","gists_url":"https://api.github.com/users/jeremiethibeault/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiethibeault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiethibeault/subscriptions","organizations_url":"https://api.github.com/users/jeremiethibeault/orgs","repos_url":"https://api.github.com/users/jeremiethibeault/repos","events_url":"https://api.github.com/users/jeremiethibeault/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiethibeault/received_events","type":"User","site_admin":false},{"login":"jeromelaban","id":5839577,"node_id":"MDQ6VXNlcjU4Mzk1Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5839577?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromelaban","html_url":"https://github.com/jeromelaban","followers_url":"https://api.github.com/users/jeromelaban/followers","following_url":"https://api.github.com/users/jeromelaban/following{/other_user}","gists_url":"https://api.github.com/users/jeromelaban/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromelaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromelaban/subscriptions","organizations_url":"https://api.github.com/users/jeromelaban/orgs","repos_url":"https://api.github.com/users/jeromelaban/repos","events_url":"https://api.github.com/users/jeromelaban/events{/privacy}","received_events_url":"https://api.github.com/users/jeromelaban/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nventive/Uno/pulls/220/commits","review_comments_url":"https://api.github.com/repos/nventive/Uno/pulls/220/comments","review_comment_url":"https://api.github.com/repos/nventive/Uno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nventive/Uno/issues/220/comments","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/648cbb502ec6a344d3a64519e91b4b68f905a675","head":{"label":"nventive:dev/djo/applytemplate-fix","ref":"dev/djo/applytemplate-fix","sha":"648cbb502ec6a344d3a64519e91b4b68f905a675","user":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"Uno","full_name":"nventive/Uno","private":false,"owner":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nventive/Uno","description":"The Uno Platform, the UWP bridge for iOS, Android, and WebAssembly","fork":false,"url":"https://api.github.com/repos/nventive/Uno","forks_url":"https://api.github.com/repos/nventive/Uno/forks","keys_url":"https://api.github.com/repos/nventive/Uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nventive/Uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nventive/Uno/teams","hooks_url":"https://api.github.com/repos/nventive/Uno/hooks","issue_events_url":"https://api.github.com/repos/nventive/Uno/issues/events{/number}","events_url":"https://api.github.com/repos/nventive/Uno/events","assignees_url":"https://api.github.com/repos/nventive/Uno/assignees{/user}","branches_url":"https://api.github.com/repos/nventive/Uno/branches{/branch}","tags_url":"https://api.github.com/repos/nventive/Uno/tags","blobs_url":"https://api.github.com/repos/nventive/Uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nventive/Uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nventive/Uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/nventive/Uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/{sha}","languages_url":"https://api.github.com/repos/nventive/Uno/languages","stargazers_url":"https://api.github.com/repos/nventive/Uno/stargazers","contributors_url":"https://api.github.com/repos/nventive/Uno/contributors","subscribers_url":"https://api.github.com/repos/nventive/Uno/subscribers","subscription_url":"https://api.github.com/repos/nventive/Uno/subscription","commits_url":"https://api.github.com/repos/nventive/Uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/nventive/Uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/nventive/Uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/nventive/Uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/nventive/Uno/contents/{+path}","compare_url":"https://api.github.com/repos/nventive/Uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nventive/Uno/merges","archive_url":"https://api.github.com/repos/nventive/Uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nventive/Uno/downloads","issues_url":"https://api.github.com/repos/nventive/Uno/issues{/number}","pulls_url":"https://api.github.com/repos/nventive/Uno/pulls{/number}","milestones_url":"https://api.github.com/repos/nventive/Uno/milestones{/number}","notifications_url":"https://api.github.com/repos/nventive/Uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nventive/Uno/labels{/name}","releases_url":"https://api.github.com/repos/nventive/Uno/releases{/id}","deployments_url":"https://api.github.com/repos/nventive/Uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2018-09-27T11:50:15Z","pushed_at":"2018-09-27T13:27:49Z","git_url":"git://github.com/nventive/Uno.git","ssh_url":"git@github.com:nventive/Uno.git","clone_url":"https://github.com/nventive/Uno.git","svn_url":"https://github.com/nventive/Uno","homepage":"http://platform.uno/","size":14768,"stargazers_count":554,"watchers_count":554,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":103,"watchers":554,"default_branch":"master"}},"base":{"label":"nventive:master","ref":"master","sha":"8e6367b1311ca33597db4a7756445c2c35917b78","user":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"Uno","full_name":"nventive/Uno","private":false,"owner":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nventive/Uno","description":"The Uno Platform, the UWP bridge for iOS, Android, and WebAssembly","fork":false,"url":"https://api.github.com/repos/nventive/Uno","forks_url":"https://api.github.com/repos/nventive/Uno/forks","keys_url":"https://api.github.com/repos/nventive/Uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nventive/Uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nventive/Uno/teams","hooks_url":"https://api.github.com/repos/nventive/Uno/hooks","issue_events_url":"https://api.github.com/repos/nventive/Uno/issues/events{/number}","events_url":"https://api.github.com/repos/nventive/Uno/events","assignees_url":"https://api.github.com/repos/nventive/Uno/assignees{/user}","branches_url":"https://api.github.com/repos/nventive/Uno/branches{/branch}","tags_url":"https://api.github.com/repos/nventive/Uno/tags","blobs_url":"https://api.github.com/repos/nventive/Uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nventive/Uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nventive/Uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/nventive/Uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/{sha}","languages_url":"https://api.github.com/repos/nventive/Uno/languages","stargazers_url":"https://api.github.com/repos/nventive/Uno/stargazers","contributors_url":"https://api.github.com/repos/nventive/Uno/contributors","subscribers_url":"https://api.github.com/repos/nventive/Uno/subscribers","subscription_url":"https://api.github.com/repos/nventive/Uno/subscription","commits_url":"https://api.github.com/repos/nventive/Uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/nventive/Uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/nventive/Uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/nventive/Uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/nventive/Uno/contents/{+path}","compare_url":"https://api.github.com/repos/nventive/Uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nventive/Uno/merges","archive_url":"https://api.github.com/repos/nventive/Uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nventive/Uno/downloads","issues_url":"https://api.github.com/repos/nventive/Uno/issues{/number}","pulls_url":"https://api.github.com/repos/nventive/Uno/pulls{/number}","milestones_url":"https://api.github.com/repos/nventive/Uno/milestones{/number}","notifications_url":"https://api.github.com/repos/nventive/Uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nventive/Uno/labels{/name}","releases_url":"https://api.github.com/repos/nventive/Uno/releases{/id}","deployments_url":"https://api.github.com/repos/nventive/Uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2018-09-27T11:50:15Z","pushed_at":"2018-09-27T13:27:49Z","git_url":"git://github.com/nventive/Uno.git","ssh_url":"git@github.com:nventive/Uno.git","clone_url":"https://github.com/nventive/Uno.git","svn_url":"https://github.com/nventive/Uno","homepage":"http://platform.uno/","size":14768,"stargazers_count":554,"watchers_count":554,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":103,"watchers":554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nventive/Uno/pulls/220"},"html":{"href":"https://github.com/nventive/Uno/pull/220"},"issue":{"href":"https://api.github.com/repos/nventive/Uno/issues/220"},"comments":{"href":"https://api.github.com/repos/nventive/Uno/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/nventive/Uno/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/nventive/Uno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nventive/Uno/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/nventive/Uno/statuses/648cbb502ec6a344d3a64519e91b4b68f905a675"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidjohnoliver"}}