{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4376","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4376/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4376/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4376/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4376","id":345717776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzczNzU2","number":4376,"title":"[WIP] [RFE] Allow to upload and display a custom brand image on login/header","user":{"login":"skateman","id":649130,"node_id":"MDQ6VXNlcjY0OTEzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"labels":[{"id":512227375,"node_id":"MDU6TGFiZWw1MTIyMjczNzU=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/pending%20core","name":"pending core","color":"fbca04","default":false},{"id":505531653,"node_id":"MDU6TGFiZWw1MDU1MzE2NTM=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-30T11:26:45Z","updated_at":"2018-07-31T16:32:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4376","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4376","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4376.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4376.patch"},"body":"This would allow to set upload a custom brand image that is being displayed on the login screen and the main header. The code in the area was awful, so I also did a little refactoring. \r\n\r\n@miq-bot add_reviewer @epwinchell \r\n@miq-bot add_reviewer @martinpovolny \r\n@miq-bot add_label pending core\r\n\r\nDepends on: https://github.com/ManageIQ/manageiq/pull/17773\r\nRFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1471301"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/409284743","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4376#issuecomment-409284743","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4376","id":409284743,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI4NDc0Mw==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T16:32:52Z","updated_at":"2018-07-31T16:32:52Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/skateman/manageiq-ui-classic/compare/df408c544771b360ff2b805848821344c460f768~...130c2babfbb7fc4106ddee2618be1be0136dc7dd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n6 files checked, 2 offenses detected\n\n**\\*\\***\n- [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Haml - Linter::Haml STDERR:\n```\nwarning: parser/current is loading parser/ruby23, which recognizes\nwarning: 2.3.6-compliant syntax, but you are running 2.3.3.\nwarning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.\n\n```\n\n**app/controllers/ops_controller/settings/common.rb**\n- [ ] :exclamation: - [Line 9](https://github.com/skateman/manageiq-ui-classic/blob/130c2babfbb7fc4106ddee2618be1be0136dc7dd/app/controllers/ops_controller/settings/common.rb#L9), Col 3 - [Style/ClassVars](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/ClassVars) - Replace class var @@login_brand_file with a class instance var.\n"}}
{"actor":{"display_login":"miq-bot"}}