{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10253","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10253/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10253/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10253/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/10253","id":373960467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzY5NTEy","number":10253,"title":"sys: add riot_hdr module","user":{"login":"kYc0o","id":5419775,"node_id":"MDQ6VXNlcjU0MTk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5419775?v=4","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false},"labels":[{"id":214816571,"node_id":"MDU6TGFiZWwyMTQ4MTY1NzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/CI:%20ready%20for%20build","name":"CI: ready for build","color":"66ffcc","default":false},{"id":97458574,"node_id":"MDU6TGFiZWw5NzQ1ODU3NA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Type:%20new%20feature","name":"Type: new feature","color":"ffff66","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-25T13:55:36Z","updated_at":"2018-10-25T14:05:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10253","html_url":"https://github.com/RIOT-OS/RIOT/pull/10253","diff_url":"https://github.com/RIOT-OS/RIOT/pull/10253.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/10253.patch"},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\nThis PR adds a module called riot_hdr which is mainly used to identify \"partitions\" on flash. Sections on flash can be identified by parsing a header.\r\n\r\nThe header contains\r\n```c\r\n/**\r\n * @brief Structure to store image header - All members are little endian\r\n * @{\r\n */\r\ntypedef struct {\r\n    uint32_t magic_number;     /**< header magic_number (always \"RIOT\")              */\r\n    uint32_t version;          /**< Integer representing the partition version       */\r\n    uint32_t start_addr;       /**< Address after the allocated space for the header */\r\n    uint32_t chksum;           /**< checksum of riot_hdr                             */\r\n} riot_hdr_t;\r\n/** @} */\r\n```\r\n\r\nThis is a split of #10065, since that PR is too complex to be reviewed as is.\r\n\r\n### Testing procedure\r\n\r\n<!--\r\nDetails steps to test your contribution:\r\n- which test/example to compile for which board and is there a 'test' command\r\n- how to know that it was not working/available in master\r\n- the expected success test output\r\n-->\r\n`BOARD=samr21-xpro make -C tests/riot_hdr/ flash test`\r\n\r\n### Issues/PRs references\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->\r\n#10065 "},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/433064578","html_url":"https://github.com/RIOT-OS/RIOT/pull/10253#issuecomment-433064578","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10253","id":433064578,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzA2NDU3OA==","user":{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T14:05:32Z","updated_at":"2018-10-25T14:05:32Z","author_association":"MEMBER","body":"Is this code also supposed to work on big endian systems? If not could you place a compile time warning/error in the file? Something similar to the one in `sys/crypto/chacha.c`."}}
{"actor":{"display_login":"bergzand"}}