{"action":"created","comment":{"url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/comments/217599451","pull_request_review_id":155351000,"id":217599451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU5OTQ1MQ==","diff_hunk":"@@ -331,7 +331,7 @@ def _get_kernel_from_markov_model(self, model):\n             factor = factors_dict[var]\n             scope = set(factor.scope())\n             for tup in itertools.product(*[range(card) for card in other_cards]):\n-                states = [State(var, s) for var, s in zip(other_vars, tup) if var in scope]\n+                states = [State(first_var, s) for first_var, s in zip(other_vars, tup) if first_var in scope]","path":"pgmpy/sampling/Sampling.py","position":5,"original_position":5,"commit_id":"08e3a5a7df85241376a5812cea3c5ad28f0d603f","original_commit_id":"08e3a5a7df85241376a5812cea3c5ad28f0d603f","user":{"login":"khalibartan","id":8940456,"node_id":"MDQ6VXNlcjg5NDA0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8940456?v=4","gravatar_id":"","url":"https://api.github.com/users/khalibartan","html_url":"https://github.com/khalibartan","followers_url":"https://api.github.com/users/khalibartan/followers","following_url":"https://api.github.com/users/khalibartan/following{/other_user}","gists_url":"https://api.github.com/users/khalibartan/gists{/gist_id}","starred_url":"https://api.github.com/users/khalibartan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalibartan/subscriptions","organizations_url":"https://api.github.com/users/khalibartan/orgs","repos_url":"https://api.github.com/users/khalibartan/repos","events_url":"https://api.github.com/users/khalibartan/events{/privacy}","received_events_url":"https://api.github.com/users/khalibartan/received_events","type":"User","site_admin":false},"body":"@fabriziov Can you change this name to `v`? `first_var` doesn't seem a good name.","created_at":"2018-09-14T04:41:44Z","updated_at":"2018-09-14T04:41:55Z","html_url":"https://github.com/pgmpy/pgmpy/pull/1019#discussion_r217599451","pull_request_url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/comments/217599451"},"html":{"href":"https://github.com/pgmpy/pgmpy/pull/1019#discussion_r217599451"},"pull_request":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019"}}},"pull_request":{"url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019","id":202301060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzAxMDYw","html_url":"https://github.com/pgmpy/pgmpy/pull/1019","diff_url":"https://github.com/pgmpy/pgmpy/pull/1019.diff","patch_url":"https://github.com/pgmpy/pgmpy/pull/1019.patch","issue_url":"https://api.github.com/repos/pgmpy/pgmpy/issues/1019","number":1019,"state":"open","locked":false,"title":"variable name clash in states array creation","user":{"login":"fabriziov","id":81928,"node_id":"MDQ6VXNlcjgxOTI4","avatar_url":"https://avatars1.githubusercontent.com/u/81928?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziov","html_url":"https://github.com/fabriziov","followers_url":"https://api.github.com/users/fabriziov/followers","following_url":"https://api.github.com/users/fabriziov/following{/other_user}","gists_url":"https://api.github.com/users/fabriziov/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziov/subscriptions","organizations_url":"https://api.github.com/users/fabriziov/orgs","repos_url":"https://api.github.com/users/fabriziov/repos","events_url":"https://api.github.com/users/fabriziov/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziov/received_events","type":"User","site_admin":false},"body":"In _get_kernel_from_markov_model method of the class GibbsSampling (Sampling module), the variable name \"var\" used to create the array \"states\" clashes with the variable name \"var\" used in the outer for loop.\r\n\r\n#### Changes\r\nPlease list the proposed changes in this pull request.\r\n- Changed variable name \"var\" into \"first_var\" for the variable used to create the \"states\" array in _get_kernel_from_markov_model of the class GibbsSampling (Sampling module).\r\n\r\nThank you!\r\n","created_at":"2018-07-18T15:53:54Z","updated_at":"2018-09-14T04:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a17dd5db39e339bea6c3a92fe45311e4abc8127","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/pgmpy/pgmpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pgmpy/pgmpy/issues/1019/comments","statuses_url":"https://api.github.com/repos/pgmpy/pgmpy/statuses/08e3a5a7df85241376a5812cea3c5ad28f0d603f","head":{"label":"fabriziov:hotfix/bug_on_get_kernel_from_markov_model","ref":"hotfix/bug_on_get_kernel_from_markov_model","sha":"08e3a5a7df85241376a5812cea3c5ad28f0d603f","user":{"login":"fabriziov","id":81928,"node_id":"MDQ6VXNlcjgxOTI4","avatar_url":"https://avatars1.githubusercontent.com/u/81928?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziov","html_url":"https://github.com/fabriziov","followers_url":"https://api.github.com/users/fabriziov/followers","following_url":"https://api.github.com/users/fabriziov/following{/other_user}","gists_url":"https://api.github.com/users/fabriziov/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziov/subscriptions","organizations_url":"https://api.github.com/users/fabriziov/orgs","repos_url":"https://api.github.com/users/fabriziov/repos","events_url":"https://api.github.com/users/fabriziov/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziov/received_events","type":"User","site_admin":false},"repo":{"id":141454156,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NTQxNTY=","name":"pgmpy","full_name":"fabriziov/pgmpy","owner":{"login":"fabriziov","id":81928,"node_id":"MDQ6VXNlcjgxOTI4","avatar_url":"https://avatars1.githubusercontent.com/u/81928?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziov","html_url":"https://github.com/fabriziov","followers_url":"https://api.github.com/users/fabriziov/followers","following_url":"https://api.github.com/users/fabriziov/following{/other_user}","gists_url":"https://api.github.com/users/fabriziov/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziov/subscriptions","organizations_url":"https://api.github.com/users/fabriziov/orgs","repos_url":"https://api.github.com/users/fabriziov/repos","events_url":"https://api.github.com/users/fabriziov/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabriziov/pgmpy","description":"Python Library for Probabilistic Graphical Models","fork":true,"url":"https://api.github.com/repos/fabriziov/pgmpy","forks_url":"https://api.github.com/repos/fabriziov/pgmpy/forks","keys_url":"https://api.github.com/repos/fabriziov/pgmpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabriziov/pgmpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabriziov/pgmpy/teams","hooks_url":"https://api.github.com/repos/fabriziov/pgmpy/hooks","issue_events_url":"https://api.github.com/repos/fabriziov/pgmpy/issues/events{/number}","events_url":"https://api.github.com/repos/fabriziov/pgmpy/events","assignees_url":"https://api.github.com/repos/fabriziov/pgmpy/assignees{/user}","branches_url":"https://api.github.com/repos/fabriziov/pgmpy/branches{/branch}","tags_url":"https://api.github.com/repos/fabriziov/pgmpy/tags","blobs_url":"https://api.github.com/repos/fabriziov/pgmpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabriziov/pgmpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabriziov/pgmpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabriziov/pgmpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabriziov/pgmpy/statuses/{sha}","languages_url":"https://api.github.com/repos/fabriziov/pgmpy/languages","stargazers_url":"https://api.github.com/repos/fabriziov/pgmpy/stargazers","contributors_url":"https://api.github.com/repos/fabriziov/pgmpy/contributors","subscribers_url":"https://api.github.com/repos/fabriziov/pgmpy/subscribers","subscription_url":"https://api.github.com/repos/fabriziov/pgmpy/subscription","commits_url":"https://api.github.com/repos/fabriziov/pgmpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabriziov/pgmpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabriziov/pgmpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabriziov/pgmpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabriziov/pgmpy/contents/{+path}","compare_url":"https://api.github.com/repos/fabriziov/pgmpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabriziov/pgmpy/merges","archive_url":"https://api.github.com/repos/fabriziov/pgmpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabriziov/pgmpy/downloads","issues_url":"https://api.github.com/repos/fabriziov/pgmpy/issues{/number}","pulls_url":"https://api.github.com/repos/fabriziov/pgmpy/pulls{/number}","milestones_url":"https://api.github.com/repos/fabriziov/pgmpy/milestones{/number}","notifications_url":"https://api.github.com/repos/fabriziov/pgmpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabriziov/pgmpy/labels{/name}","releases_url":"https://api.github.com/repos/fabriziov/pgmpy/releases{/id}","deployments_url":"https://api.github.com/repos/fabriziov/pgmpy/deployments","created_at":"2018-07-18T15:28:50Z","updated_at":"2018-07-18T15:28:52Z","pushed_at":"2018-07-18T15:38:55Z","git_url":"git://github.com/fabriziov/pgmpy.git","ssh_url":"git@github.com:fabriziov/pgmpy.git","clone_url":"https://github.com/fabriziov/pgmpy.git","svn_url":"https://github.com/fabriziov/pgmpy","homepage":null,"size":5665,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"pgmpy:dev","ref":"dev","sha":"ebc280c95507625bf4361764e5a4f03ed321897e","user":{"login":"pgmpy","id":5500131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAxMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5500131?v=4","gravatar_id":"","url":"https://api.github.com/users/pgmpy","html_url":"https://github.com/pgmpy","followers_url":"https://api.github.com/users/pgmpy/followers","following_url":"https://api.github.com/users/pgmpy/following{/other_user}","gists_url":"https://api.github.com/users/pgmpy/gists{/gist_id}","starred_url":"https://api.github.com/users/pgmpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgmpy/subscriptions","organizations_url":"https://api.github.com/users/pgmpy/orgs","repos_url":"https://api.github.com/users/pgmpy/repos","events_url":"https://api.github.com/users/pgmpy/events{/privacy}","received_events_url":"https://api.github.com/users/pgmpy/received_events","type":"Organization","site_admin":false},"repo":{"id":12968651,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2ODY1MQ==","name":"pgmpy","full_name":"pgmpy/pgmpy","owner":{"login":"pgmpy","id":5500131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAxMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5500131?v=4","gravatar_id":"","url":"https://api.github.com/users/pgmpy","html_url":"https://github.com/pgmpy","followers_url":"https://api.github.com/users/pgmpy/followers","following_url":"https://api.github.com/users/pgmpy/following{/other_user}","gists_url":"https://api.github.com/users/pgmpy/gists{/gist_id}","starred_url":"https://api.github.com/users/pgmpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgmpy/subscriptions","organizations_url":"https://api.github.com/users/pgmpy/orgs","repos_url":"https://api.github.com/users/pgmpy/repos","events_url":"https://api.github.com/users/pgmpy/events{/privacy}","received_events_url":"https://api.github.com/users/pgmpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pgmpy/pgmpy","description":"Python Library for Probabilistic Graphical Models","fork":false,"url":"https://api.github.com/repos/pgmpy/pgmpy","forks_url":"https://api.github.com/repos/pgmpy/pgmpy/forks","keys_url":"https://api.github.com/repos/pgmpy/pgmpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgmpy/pgmpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgmpy/pgmpy/teams","hooks_url":"https://api.github.com/repos/pgmpy/pgmpy/hooks","issue_events_url":"https://api.github.com/repos/pgmpy/pgmpy/issues/events{/number}","events_url":"https://api.github.com/repos/pgmpy/pgmpy/events","assignees_url":"https://api.github.com/repos/pgmpy/pgmpy/assignees{/user}","branches_url":"https://api.github.com/repos/pgmpy/pgmpy/branches{/branch}","tags_url":"https://api.github.com/repos/pgmpy/pgmpy/tags","blobs_url":"https://api.github.com/repos/pgmpy/pgmpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgmpy/pgmpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgmpy/pgmpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgmpy/pgmpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgmpy/pgmpy/statuses/{sha}","languages_url":"https://api.github.com/repos/pgmpy/pgmpy/languages","stargazers_url":"https://api.github.com/repos/pgmpy/pgmpy/stargazers","contributors_url":"https://api.github.com/repos/pgmpy/pgmpy/contributors","subscribers_url":"https://api.github.com/repos/pgmpy/pgmpy/subscribers","subscription_url":"https://api.github.com/repos/pgmpy/pgmpy/subscription","commits_url":"https://api.github.com/repos/pgmpy/pgmpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgmpy/pgmpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgmpy/pgmpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgmpy/pgmpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgmpy/pgmpy/contents/{+path}","compare_url":"https://api.github.com/repos/pgmpy/pgmpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgmpy/pgmpy/merges","archive_url":"https://api.github.com/repos/pgmpy/pgmpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgmpy/pgmpy/downloads","issues_url":"https://api.github.com/repos/pgmpy/pgmpy/issues{/number}","pulls_url":"https://api.github.com/repos/pgmpy/pgmpy/pulls{/number}","milestones_url":"https://api.github.com/repos/pgmpy/pgmpy/milestones{/number}","notifications_url":"https://api.github.com/repos/pgmpy/pgmpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgmpy/pgmpy/labels{/name}","releases_url":"https://api.github.com/repos/pgmpy/pgmpy/releases{/id}","deployments_url":"https://api.github.com/repos/pgmpy/pgmpy/deployments","created_at":"2013-09-20T08:18:58Z","updated_at":"2018-09-11T14:05:03Z","pushed_at":"2018-09-11T14:11:12Z","git_url":"git://github.com/pgmpy/pgmpy.git","ssh_url":"git@github.com:pgmpy/pgmpy.git","clone_url":"https://github.com/pgmpy/pgmpy.git","svn_url":"https://github.com/pgmpy/pgmpy","homepage":null,"size":6347,"stargazers_count":845,"watchers_count":845,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":335,"open_issues":192,"watchers":845,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019"},"html":{"href":"https://github.com/pgmpy/pgmpy/pull/1019"},"issue":{"href":"https://api.github.com/repos/pgmpy/pgmpy/issues/1019"},"comments":{"href":"https://api.github.com/repos/pgmpy/pgmpy/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pgmpy/pgmpy/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/pgmpy/pgmpy/statuses/08e3a5a7df85241376a5812cea3c5ad28f0d603f"}},"author_association":"NONE"}}
{"actor":{"display_login":"khalibartan"}}