{"action":"created","issue":{"url":"https://api.github.com/repos/apache/tomee/issues/262","repository_url":"https://api.github.com/repos/apache/tomee","labels_url":"https://api.github.com/repos/apache/tomee/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/apache/tomee/issues/262/comments","events_url":"https://api.github.com/repos/apache/tomee/issues/262/events","html_url":"https://github.com/apache/tomee/pull/262","id":388819067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTk3NjQ1","number":262,"title":"TOMEE-2337 - Code cleanup openejb container loader","user":{"login":"cicekhayri","id":143997,"node_id":"MDQ6VXNlcjE0Mzk5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/143997?v=4","gravatar_id":"","url":"https://api.github.com/users/cicekhayri","html_url":"https://github.com/cicekhayri","followers_url":"https://api.github.com/users/cicekhayri/followers","following_url":"https://api.github.com/users/cicekhayri/following{/other_user}","gists_url":"https://api.github.com/users/cicekhayri/gists{/gist_id}","starred_url":"https://api.github.com/users/cicekhayri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cicekhayri/subscriptions","organizations_url":"https://api.github.com/users/cicekhayri/orgs","repos_url":"https://api.github.com/users/cicekhayri/repos","events_url":"https://api.github.com/users/cicekhayri/events{/privacy}","received_events_url":"https://api.github.com/users/cicekhayri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-12-07T21:24:16Z","updated_at":"2018-12-27T08:12:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/tomee/pulls/262","html_url":"https://github.com/apache/tomee/pull/262","diff_url":"https://github.com/apache/tomee/pull/262.diff","patch_url":"https://github.com/apache/tomee/pull/262.patch"},"body":"Added JavaDoc's, use diamond operator, isEmpty method, Switch case statement and added @Override "},"comment":{"url":"https://api.github.com/repos/apache/tomee/issues/comments/450100365","html_url":"https://github.com/apache/tomee/pull/262#issuecomment-450100365","issue_url":"https://api.github.com/repos/apache/tomee/issues/262","id":450100365,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDEwMDM2NQ==","user":{"login":"jeanouii","id":1233474,"node_id":"MDQ6VXNlcjEyMzM0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1233474?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanouii","html_url":"https://github.com/jeanouii","followers_url":"https://api.github.com/users/jeanouii/followers","following_url":"https://api.github.com/users/jeanouii/following{/other_user}","gists_url":"https://api.github.com/users/jeanouii/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanouii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanouii/subscriptions","organizations_url":"https://api.github.com/users/jeanouii/orgs","repos_url":"https://api.github.com/users/jeanouii/repos","events_url":"https://api.github.com/users/jeanouii/events{/privacy}","received_events_url":"https://api.github.com/users/jeanouii/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T08:12:22Z","updated_at":"2018-12-27T08:12:22Z","author_association":"CONTRIBUTOR","body":"I am overall ok with the PR but the javadoc part is more the one to discuss.\r\n\r\nI agree with @pzygielo. If JavaDoc does not bring anything more than you can read with the code itself, then I just remove it.\r\n\r\nJavaDoc listing the attributes and the throws are useless to me because I can read it on the code itself. Remember that the best documentation is the code. So if the code is not meaningful, the javadoc won't make it clear. So I'm tempted to address the root cause first and fix the code.\r\n\r\nThan being said, @cicekhayri can you look at @pzygielo comments and take them into account so I can merge this PR before it grows and conflicts start appearing?"}}
{"actor":{"display_login":"jeanouii"}}