{"action":"created","comment":{"url":"https://api.github.com/repos/spiffe/spire/pulls/comments/236473767","pull_request_review_id":178555993,"id":236473767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjQ3Mzc2Nw==","diff_hunk":"@@ -131,5 +140,20 @@ func (ca *serverCA) SignJWTSVID(ctx context.Context, jsr *node.JSR) (string, err\n \tif err != nil {\n \t\treturn \"\", fmt.Errorf(\"unable to sign JWT-SVID: %v\", err)\n \t}\n+\n+\tlabels := []telemetry.Label{\n+\t\t{\n+\t\t\tName:  \"spiffe_id\",\n+\t\t\tValue: jsr.SpiffeId,\n+\t\t},\n+\t}\n+\tfor _, audience := range jsr.Audience {\n+\t\tlabels = append(labels, telemetry.Label{\n+\t\t\tName:  \"audience\",","path":"pkg/server/ca/ca.go","position":45,"original_position":45,"commit_id":"ce29e684ea13d971f127f559ebe93d8f39f88bb3","original_commit_id":"c41b35a4b401506e0ff690096004bfe25067ee80","user":{"login":"evan2645","id":1944142,"node_id":"MDQ6VXNlcjE5NDQxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1944142?v=4","gravatar_id":"","url":"https://api.github.com/users/evan2645","html_url":"https://github.com/evan2645","followers_url":"https://api.github.com/users/evan2645/followers","following_url":"https://api.github.com/users/evan2645/following{/other_user}","gists_url":"https://api.github.com/users/evan2645/gists{/gist_id}","starred_url":"https://api.github.com/users/evan2645/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evan2645/subscriptions","organizations_url":"https://api.github.com/users/evan2645/orgs","repos_url":"https://api.github.com/users/evan2645/repos","events_url":"https://api.github.com/users/evan2645/events{/privacy}","received_events_url":"https://api.github.com/users/evan2645/received_events","type":"User","site_admin":false},"body":"Ok. suggest we test this stuff out with datadog or something similar before cutting a release with it","created_at":"2018-11-26T23:53:56Z","updated_at":"2018-11-26T23:54:33Z","html_url":"https://github.com/spiffe/spire/pull/640#discussion_r236473767","pull_request_url":"https://api.github.com/repos/spiffe/spire/pulls/640","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spiffe/spire/pulls/comments/236473767"},"html":{"href":"https://github.com/spiffe/spire/pull/640#discussion_r236473767"},"pull_request":{"href":"https://api.github.com/repos/spiffe/spire/pulls/640"}},"in_reply_to_id":236437165},"pull_request":{"url":"https://api.github.com/repos/spiffe/spire/pulls/640","id":232470892,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDcwODky","html_url":"https://github.com/spiffe/spire/pull/640","diff_url":"https://github.com/spiffe/spire/pull/640.diff","patch_url":"https://github.com/spiffe/spire/pull/640.patch","issue_url":"https://api.github.com/repos/spiffe/spire/issues/640","number":640,"state":"open","locked":false,"title":"improve agent/server telemetry","user":{"login":"azdagron","id":7400314,"node_id":"MDQ6VXNlcjc0MDAzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7400314?v=4","gravatar_id":"","url":"https://api.github.com/users/azdagron","html_url":"https://github.com/azdagron","followers_url":"https://api.github.com/users/azdagron/followers","following_url":"https://api.github.com/users/azdagron/following{/other_user}","gists_url":"https://api.github.com/users/azdagron/gists{/gist_id}","starred_url":"https://api.github.com/users/azdagron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azdagron/subscriptions","organizations_url":"https://api.github.com/users/azdagron/orgs","repos_url":"https://api.github.com/users/azdagron/repos","events_url":"https://api.github.com/users/azdagron/events{/privacy}","received_events_url":"https://api.github.com/users/azdagron/received_events","type":"User","site_admin":false},"body":"- added additional telemetry to agent\r\n- introduced and added telemetry to server\r\n\r\n","created_at":"2018-11-20T21:52:46Z","updated_at":"2018-11-26T23:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"473588ed135b7b01d106d3f6e73026fa288bdda5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarcosDY","id":3899789,"node_id":"MDQ6VXNlcjM4OTk3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3899789?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcosDY","html_url":"https://github.com/MarcosDY","followers_url":"https://api.github.com/users/MarcosDY/followers","following_url":"https://api.github.com/users/MarcosDY/following{/other_user}","gists_url":"https://api.github.com/users/MarcosDY/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcosDY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcosDY/subscriptions","organizations_url":"https://api.github.com/users/MarcosDY/orgs","repos_url":"https://api.github.com/users/MarcosDY/repos","events_url":"https://api.github.com/users/MarcosDY/events{/privacy}","received_events_url":"https://api.github.com/users/MarcosDY/received_events","type":"User","site_admin":false},{"login":"martincapello","id":5520828,"node_id":"MDQ6VXNlcjU1MjA4Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5520828?v=4","gravatar_id":"","url":"https://api.github.com/users/martincapello","html_url":"https://github.com/martincapello","followers_url":"https://api.github.com/users/martincapello/followers","following_url":"https://api.github.com/users/martincapello/following{/other_user}","gists_url":"https://api.github.com/users/martincapello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincapello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincapello/subscriptions","organizations_url":"https://api.github.com/users/martincapello/orgs","repos_url":"https://api.github.com/users/martincapello/repos","events_url":"https://api.github.com/users/martincapello/events{/privacy}","received_events_url":"https://api.github.com/users/martincapello/received_events","type":"User","site_admin":false},{"login":"walmav","id":23508970,"node_id":"MDQ6VXNlcjIzNTA4OTcw","avatar_url":"https://avatars0.githubusercontent.com/u/23508970?v=4","gravatar_id":"","url":"https://api.github.com/users/walmav","html_url":"https://github.com/walmav","followers_url":"https://api.github.com/users/walmav/followers","following_url":"https://api.github.com/users/walmav/following{/other_user}","gists_url":"https://api.github.com/users/walmav/gists{/gist_id}","starred_url":"https://api.github.com/users/walmav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmav/subscriptions","organizations_url":"https://api.github.com/users/walmav/orgs","repos_url":"https://api.github.com/users/walmav/repos","events_url":"https://api.github.com/users/walmav/events{/privacy}","received_events_url":"https://api.github.com/users/walmav/received_events","type":"User","site_admin":false},{"login":"amartinezfayo","id":26970586,"node_id":"MDQ6VXNlcjI2OTcwNTg2","avatar_url":"https://avatars1.githubusercontent.com/u/26970586?v=4","gravatar_id":"","url":"https://api.github.com/users/amartinezfayo","html_url":"https://github.com/amartinezfayo","followers_url":"https://api.github.com/users/amartinezfayo/followers","following_url":"https://api.github.com/users/amartinezfayo/following{/other_user}","gists_url":"https://api.github.com/users/amartinezfayo/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinezfayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinezfayo/subscriptions","organizations_url":"https://api.github.com/users/amartinezfayo/orgs","repos_url":"https://api.github.com/users/amartinezfayo/repos","events_url":"https://api.github.com/users/amartinezfayo/events{/privacy}","received_events_url":"https://api.github.com/users/amartinezfayo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spiffe/spire/pulls/640/commits","review_comments_url":"https://api.github.com/repos/spiffe/spire/pulls/640/comments","review_comment_url":"https://api.github.com/repos/spiffe/spire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spiffe/spire/issues/640/comments","statuses_url":"https://api.github.com/repos/spiffe/spire/statuses/ce29e684ea13d971f127f559ebe93d8f39f88bb3","head":{"label":"azdagron:improve-telemetry","ref":"improve-telemetry","sha":"ce29e684ea13d971f127f559ebe93d8f39f88bb3","user":{"login":"azdagron","id":7400314,"node_id":"MDQ6VXNlcjc0MDAzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7400314?v=4","gravatar_id":"","url":"https://api.github.com/users/azdagron","html_url":"https://github.com/azdagron","followers_url":"https://api.github.com/users/azdagron/followers","following_url":"https://api.github.com/users/azdagron/following{/other_user}","gists_url":"https://api.github.com/users/azdagron/gists{/gist_id}","starred_url":"https://api.github.com/users/azdagron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azdagron/subscriptions","organizations_url":"https://api.github.com/users/azdagron/orgs","repos_url":"https://api.github.com/users/azdagron/repos","events_url":"https://api.github.com/users/azdagron/events{/privacy}","received_events_url":"https://api.github.com/users/azdagron/received_events","type":"User","site_admin":false},"repo":{"id":134327807,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzMjc4MDc=","name":"spire","full_name":"azdagron/spire","private":false,"owner":{"login":"azdagron","id":7400314,"node_id":"MDQ6VXNlcjc0MDAzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7400314?v=4","gravatar_id":"","url":"https://api.github.com/users/azdagron","html_url":"https://github.com/azdagron","followers_url":"https://api.github.com/users/azdagron/followers","following_url":"https://api.github.com/users/azdagron/following{/other_user}","gists_url":"https://api.github.com/users/azdagron/gists{/gist_id}","starred_url":"https://api.github.com/users/azdagron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azdagron/subscriptions","organizations_url":"https://api.github.com/users/azdagron/orgs","repos_url":"https://api.github.com/users/azdagron/repos","events_url":"https://api.github.com/users/azdagron/events{/privacy}","received_events_url":"https://api.github.com/users/azdagron/received_events","type":"User","site_admin":false},"html_url":"https://github.com/azdagron/spire","description":"The SPIFFE Runtime Environment","fork":true,"url":"https://api.github.com/repos/azdagron/spire","forks_url":"https://api.github.com/repos/azdagron/spire/forks","keys_url":"https://api.github.com/repos/azdagron/spire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azdagron/spire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azdagron/spire/teams","hooks_url":"https://api.github.com/repos/azdagron/spire/hooks","issue_events_url":"https://api.github.com/repos/azdagron/spire/issues/events{/number}","events_url":"https://api.github.com/repos/azdagron/spire/events","assignees_url":"https://api.github.com/repos/azdagron/spire/assignees{/user}","branches_url":"https://api.github.com/repos/azdagron/spire/branches{/branch}","tags_url":"https://api.github.com/repos/azdagron/spire/tags","blobs_url":"https://api.github.com/repos/azdagron/spire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azdagron/spire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azdagron/spire/git/refs{/sha}","trees_url":"https://api.github.com/repos/azdagron/spire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azdagron/spire/statuses/{sha}","languages_url":"https://api.github.com/repos/azdagron/spire/languages","stargazers_url":"https://api.github.com/repos/azdagron/spire/stargazers","contributors_url":"https://api.github.com/repos/azdagron/spire/contributors","subscribers_url":"https://api.github.com/repos/azdagron/spire/subscribers","subscription_url":"https://api.github.com/repos/azdagron/spire/subscription","commits_url":"https://api.github.com/repos/azdagron/spire/commits{/sha}","git_commits_url":"https://api.github.com/repos/azdagron/spire/git/commits{/sha}","comments_url":"https://api.github.com/repos/azdagron/spire/comments{/number}","issue_comment_url":"https://api.github.com/repos/azdagron/spire/issues/comments{/number}","contents_url":"https://api.github.com/repos/azdagron/spire/contents/{+path}","compare_url":"https://api.github.com/repos/azdagron/spire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azdagron/spire/merges","archive_url":"https://api.github.com/repos/azdagron/spire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azdagron/spire/downloads","issues_url":"https://api.github.com/repos/azdagron/spire/issues{/number}","pulls_url":"https://api.github.com/repos/azdagron/spire/pulls{/number}","milestones_url":"https://api.github.com/repos/azdagron/spire/milestones{/number}","notifications_url":"https://api.github.com/repos/azdagron/spire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azdagron/spire/labels{/name}","releases_url":"https://api.github.com/repos/azdagron/spire/releases{/id}","deployments_url":"https://api.github.com/repos/azdagron/spire/deployments","created_at":"2018-05-21T21:36:19Z","updated_at":"2018-07-24T15:21:13Z","pushed_at":"2018-11-26T23:38:47Z","git_url":"git://github.com/azdagron/spire.git","ssh_url":"git@github.com:azdagron/spire.git","clone_url":"https://github.com/azdagron/spire.git","svn_url":"https://github.com/azdagron/spire","homepage":"https://spiffe.io","size":4095,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spiffe:master","ref":"master","sha":"14919ca9ee5c19b96043bd45ce1773116277312c","user":{"login":"spiffe","id":19497462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDk3NDYy","avatar_url":"https://avatars0.githubusercontent.com/u/19497462?v=4","gravatar_id":"","url":"https://api.github.com/users/spiffe","html_url":"https://github.com/spiffe","followers_url":"https://api.github.com/users/spiffe/followers","following_url":"https://api.github.com/users/spiffe/following{/other_user}","gists_url":"https://api.github.com/users/spiffe/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffe/subscriptions","organizations_url":"https://api.github.com/users/spiffe/orgs","repos_url":"https://api.github.com/users/spiffe/repos","events_url":"https://api.github.com/users/spiffe/events{/privacy}","received_events_url":"https://api.github.com/users/spiffe/received_events","type":"Organization","site_admin":false},"repo":{"id":100061496,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjE0OTY=","name":"spire","full_name":"spiffe/spire","private":false,"owner":{"login":"spiffe","id":19497462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDk3NDYy","avatar_url":"https://avatars0.githubusercontent.com/u/19497462?v=4","gravatar_id":"","url":"https://api.github.com/users/spiffe","html_url":"https://github.com/spiffe","followers_url":"https://api.github.com/users/spiffe/followers","following_url":"https://api.github.com/users/spiffe/following{/other_user}","gists_url":"https://api.github.com/users/spiffe/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffe/subscriptions","organizations_url":"https://api.github.com/users/spiffe/orgs","repos_url":"https://api.github.com/users/spiffe/repos","events_url":"https://api.github.com/users/spiffe/events{/privacy}","received_events_url":"https://api.github.com/users/spiffe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spiffe/spire","description":"The SPIFFE Runtime Environment","fork":false,"url":"https://api.github.com/repos/spiffe/spire","forks_url":"https://api.github.com/repos/spiffe/spire/forks","keys_url":"https://api.github.com/repos/spiffe/spire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiffe/spire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiffe/spire/teams","hooks_url":"https://api.github.com/repos/spiffe/spire/hooks","issue_events_url":"https://api.github.com/repos/spiffe/spire/issues/events{/number}","events_url":"https://api.github.com/repos/spiffe/spire/events","assignees_url":"https://api.github.com/repos/spiffe/spire/assignees{/user}","branches_url":"https://api.github.com/repos/spiffe/spire/branches{/branch}","tags_url":"https://api.github.com/repos/spiffe/spire/tags","blobs_url":"https://api.github.com/repos/spiffe/spire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiffe/spire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiffe/spire/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiffe/spire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiffe/spire/statuses/{sha}","languages_url":"https://api.github.com/repos/spiffe/spire/languages","stargazers_url":"https://api.github.com/repos/spiffe/spire/stargazers","contributors_url":"https://api.github.com/repos/spiffe/spire/contributors","subscribers_url":"https://api.github.com/repos/spiffe/spire/subscribers","subscription_url":"https://api.github.com/repos/spiffe/spire/subscription","commits_url":"https://api.github.com/repos/spiffe/spire/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiffe/spire/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiffe/spire/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiffe/spire/issues/comments{/number}","contents_url":"https://api.github.com/repos/spiffe/spire/contents/{+path}","compare_url":"https://api.github.com/repos/spiffe/spire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiffe/spire/merges","archive_url":"https://api.github.com/repos/spiffe/spire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiffe/spire/downloads","issues_url":"https://api.github.com/repos/spiffe/spire/issues{/number}","pulls_url":"https://api.github.com/repos/spiffe/spire/pulls{/number}","milestones_url":"https://api.github.com/repos/spiffe/spire/milestones{/number}","notifications_url":"https://api.github.com/repos/spiffe/spire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiffe/spire/labels{/name}","releases_url":"https://api.github.com/repos/spiffe/spire/releases{/id}","deployments_url":"https://api.github.com/repos/spiffe/spire/deployments","created_at":"2017-08-11T18:46:51Z","updated_at":"2018-11-26T09:46:12Z","pushed_at":"2018-11-26T23:38:48Z","git_url":"git://github.com/spiffe/spire.git","ssh_url":"git@github.com:spiffe/spire.git","clone_url":"https://github.com/spiffe/spire.git","svn_url":"https://github.com/spiffe/spire","homepage":"https://spiffe.io","size":4146,"stargazers_count":297,"watchers_count":297,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":45,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spiffe/spire/pulls/640"},"html":{"href":"https://github.com/spiffe/spire/pull/640"},"issue":{"href":"https://api.github.com/repos/spiffe/spire/issues/640"},"comments":{"href":"https://api.github.com/repos/spiffe/spire/issues/640/comments"},"review_comments":{"href":"https://api.github.com/repos/spiffe/spire/pulls/640/comments"},"review_comment":{"href":"https://api.github.com/repos/spiffe/spire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spiffe/spire/pulls/640/commits"},"statuses":{"href":"https://api.github.com/repos/spiffe/spire/statuses/ce29e684ea13d971f127f559ebe93d8f39f88bb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"evan2645"}}