{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments/200576520","pull_request_review_id":134915126,"id":200576520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU3NjUyMA==","diff_hunk":"@@ -0,0 +1,89 @@\n+<?php","path":"civihr_employee_portal/views/views_export/views_mydetails_contactdetails.inc","position":1,"original_position":1,"commit_id":"f6a275c3699741e326885bc9afe91b1771180f94","original_commit_id":"f6a275c3699741e326885bc9afe91b1771180f94","user":{"login":"hitesh-jain","id":2689257,"node_id":"MDQ6VXNlcjI2ODkyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2689257?v=4","gravatar_id":"","url":"https://api.github.com/users/hitesh-jain","html_url":"https://github.com/hitesh-jain","followers_url":"https://api.github.com/users/hitesh-jain/followers","following_url":"https://api.github.com/users/hitesh-jain/following{/other_user}","gists_url":"https://api.github.com/users/hitesh-jain/gists{/gist_id}","starred_url":"https://api.github.com/users/hitesh-jain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hitesh-jain/subscriptions","organizations_url":"https://api.github.com/users/hitesh-jain/orgs","repos_url":"https://api.github.com/users/hitesh-jain/repos","events_url":"https://api.github.com/users/hitesh-jain/events{/privacy}","received_events_url":"https://api.github.com/users/hitesh-jain/received_events","type":"User","site_admin":false},"body":"@powdevel why we are not using feature for this ?","created_at":"2018-07-06T07:57:40Z","updated_at":"2018-07-06T08:01:02Z","html_url":"https://github.com/compucorp/civihr-employee-portal/pull/504#discussion_r200576520","pull_request_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments/200576520"},"html":{"href":"https://github.com/compucorp/civihr-employee-portal/pull/504#discussion_r200576520"},"pull_request":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504","id":198029275,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDI5Mjc1","html_url":"https://github.com/compucorp/civihr-employee-portal/pull/504","diff_url":"https://github.com/compucorp/civihr-employee-portal/pull/504.diff","patch_url":"https://github.com/compucorp/civihr-employee-portal/pull/504.patch","issue_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504","number":504,"state":"open","locked":false,"title":"PCHR-3817: Create Views for My Details Page","user":{"login":"powdevel","id":3916979,"node_id":"MDQ6VXNlcjM5MTY5Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3916979?v=4","gravatar_id":"","url":"https://api.github.com/users/powdevel","html_url":"https://github.com/powdevel","followers_url":"https://api.github.com/users/powdevel/followers","following_url":"https://api.github.com/users/powdevel/following{/other_user}","gists_url":"https://api.github.com/users/powdevel/gists{/gist_id}","starred_url":"https://api.github.com/users/powdevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powdevel/subscriptions","organizations_url":"https://api.github.com/users/powdevel/orgs","repos_url":"https://api.github.com/users/powdevel/repos","events_url":"https://api.github.com/users/powdevel/events{/privacy}","received_events_url":"https://api.github.com/users/powdevel/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n- Defines views to use in My Details page\r\n- Creates a panel page for My Details page\r\n- Creates a new input filter to output HTML without any filter, mainly for view headers and footers.\r\n- Creates webform for editing information in My Details page.\r\n\r\nNOTE: To get the previews a branch with the same name in the themes repo must also be active\r\n\r\n## Before\r\n![image](https://user-images.githubusercontent.com/3916979/42036829-52a39568-7aac-11e8-90c1-d94f21c4862b.png)\r\n\r\n## After\r\n![fireshot capture 119 - my details i civi8 - http___civi8_hr-details](https://user-images.githubusercontent.com/3916979/42036868-69233366-7aac-11e8-98f0-886c19490c8f.png)\r\n![fireshot capture 118 - my details i civi8 - http___civi8_hr-details](https://user-images.githubusercontent.com/3916979/42036869-6940e60e-7aac-11e8-80de-67e00c8a87b5.png)\r\n\r\n### Webforms created\r\nMy personal Details\r\n![image](https://user-images.githubusercontent.com/3916979/42146241-337e6c66-7d8c-11e8-9f9d-472e4e50cdaf.png)\r\n\r\nMy Payroll\r\n![image](https://user-images.githubusercontent.com/3916979/42146252-3d5eeed6-7d8c-11e8-9abb-9566049f3ce6.png)\r\n\r\nMy Contact Details\r\n![image](https://user-images.githubusercontent.com/3916979/42146256-430ae056-7d8c-11e8-836f-1b88e418d72c.png)\r\n\r\n\r\n## Technical Details\r\nSome work was done to unify HTML structures from panels and views, to integrate them seamlessly with the design. A new generic template is invoked from `views-view--default.tpl.php` for specific views in My Details page. The goal was to \"hide\" views markup, although technically the panel block markup was set to not output any HTML and the view template `_views-view--generic-display-output.tpl.php` will mimic a panels block structure.\r\n\"My Details\" page is now a panel page, which would become the preferred structure for pages over custom templates, view pages or any other implementation.\r\n\r\n\r\n### civihr_employee_portal_views_date_fields_to_timestamp\r\nA function which alters a view to allow use filters for dates, in this case job role start date and job role end date, achieving the same functionality but also allowing to use the views UI as expected.\r\nCould be use to other views which have the same problem to allow views ui filters work correctly on fields with dates stored in Y-m-d format.\r\n\r\n#### Before\r\n![image](https://user-images.githubusercontent.com/3916979/41698268-f59b28dc-74e2-11e8-8df1-9d9e30e2e9f3.png)\r\n\r\n#### After\r\n![image](https://user-images.githubusercontent.com/3916979/41698270-fba72a64-74e2-11e8-978e-040f5d6ed282.png)\r\n\r\n#### civihr_employee_portal_features_filter_default_formats\r\nA format filter to output HTML without any post-processing or pre-processing. It is useful when HTML needs to be appended to views headers or footers, or even in blocks because it does not add any extra `p` or `br` tags.\r\nA format filter can be used programmatically or through the Drupal UI, for this filter it does not make sense to use it programmatically as it is the same as printing directly HTML code, but it is useful use it through the UI to print HTML code without changes.\r\n\r\n\r\n","created_at":"2018-06-28T13:25:14Z","updated_at":"2018-07-06T08:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1de9dcc95d7f438a31b8e4ea0faa4ec2da3727ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/commits","review_comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/comments","review_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504/comments","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/f6a275c3699741e326885bc9afe91b1771180f94","head":{"label":"compucorp:PCHR-3817-create-views-for-my-details-page","ref":"PCHR-3817-create-views-for-my-details-page","sha":"f6a275c3699741e326885bc9afe91b1771180f94","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":25817866,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgxNzg2Ng==","name":"civihr-employee-portal","full_name":"compucorp/civihr-employee-portal","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-employee-portal","description":"CiviHR employee portal custom Drupal modules","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-employee-portal","forks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/deployments","created_at":"2014-10-27T12:26:29Z","updated_at":"2018-07-02T13:28:36Z","pushed_at":"2018-07-05T16:27:12Z","git_url":"git://github.com/compucorp/civihr-employee-portal.git","ssh_url":"git@github.com:compucorp/civihr-employee-portal.git","clone_url":"https://github.com/compucorp/civihr-employee-portal.git","svn_url":"https://github.com/compucorp/civihr-employee-portal","homepage":null,"size":6420,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4,"open_issues":6,"watchers":5,"default_branch":"staging"}},"base":{"label":"compucorp:PCHR-3744-ssp-redesign-epic","ref":"PCHR-3744-ssp-redesign-epic","sha":"09c6d87a697c9549bd13402b869538428f6de93f","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":25817866,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgxNzg2Ng==","name":"civihr-employee-portal","full_name":"compucorp/civihr-employee-portal","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-employee-portal","description":"CiviHR employee portal custom Drupal modules","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-employee-portal","forks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/deployments","created_at":"2014-10-27T12:26:29Z","updated_at":"2018-07-02T13:28:36Z","pushed_at":"2018-07-05T16:27:12Z","git_url":"git://github.com/compucorp/civihr-employee-portal.git","ssh_url":"git@github.com:compucorp/civihr-employee-portal.git","clone_url":"https://github.com/compucorp/civihr-employee-portal.git","svn_url":"https://github.com/compucorp/civihr-employee-portal","homepage":null,"size":6420,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4,"open_issues":6,"watchers":5,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504"},"html":{"href":"https://github.com/compucorp/civihr-employee-portal/pull/504"},"issue":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504"},"comments":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/f6a275c3699741e326885bc9afe91b1771180f94"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hitesh-jain"}}