{"action":"created","issue":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/1281","repository_url":"https://api.github.com/repos/apache/bookkeeper","labels_url":"https://api.github.com/repos/apache/bookkeeper/issues/1281/labels{/name}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1281/comments","events_url":"https://api.github.com/repos/apache/bookkeeper/issues/1281/events","html_url":"https://github.com/apache/bookkeeper/pull/1281","id":307411838,"number":1281,"title":"Issue #570: Introducing EntryLogManager.","user":{"login":"reddycharan","id":13989266,"avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-21T20:46:54Z","updated_at":"2018-03-28T00:52:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1281","html_url":"https://github.com/apache/bookkeeper/pull/1281","diff_url":"https://github.com/apache/bookkeeper/pull/1281.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1281.patch"},"body":"Descriptions of the changes in this PR:\r\n\r\nIntroducing EntryLogManager interface, which abstracts out current activeLogChannel,\r\nrotatedLogChannels and corresponding lock for activeLogChannel. The current logic of\r\nhandling logs is moved to EntryLogManagerForSingleEntryLog class, in the\r\nnext sub-task EntryLogManagerForEntryLogPerLedger will be introduced. Also there\r\nare minor changes to createNewLog logic and leastUnflushedLogId logic.\r\n\r\nThis is < sub-task5  > of Issue #570\r\n\r\nMaster Issue: #570 \r\n"},"comment":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/comments/376723194","html_url":"https://github.com/apache/bookkeeper/pull/1281#issuecomment-376723194","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1281","id":376723194,"user":{"login":"reddycharan","id":13989266,"avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T00:52:48Z","updated_at":"2018-03-28T00:52:48Z","author_association":"NONE","body":"Thanks @ivankelly for taking the effort to consider ways to refactor the code. But this class is in deep down in the stack and I'm hesitant to make big code churn. With my changes in this sub-task and subsequent sub-tasks I would like to abstract out the code/logic pertaining to singleentrylog/entrylogperledger and move it to the implementations of EntryLogManager, but leave the rest of the code as it is to have minimal code churn and more focus. Once things are in place, I can consider the refactoring aspect of these classes."}}
{"actor":{"display_login":"reddycharan"}}