{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/245481697","pull_request_review_id":189601095,"id":245481697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4MTY5Nw==","diff_hunk":"@@ -49,6 +49,13 @@\n #include <iostream>\n #include <boost/none.hpp>\n \n+///\n+/// TODO: Remove this helper when Qt is fully removed\n+///\n+static auto toQString(const std::string &s) {","path":"openstudiocore/src/bimserver/BIMserverConnection.cpp","position":7,"original_position":7,"commit_id":"2826cae983249bc1bac54a8227821c426326f1f2","original_commit_id":"2826cae983249bc1bac54a8227821c426326f1f2","user":{"login":"macumber","id":1327850,"node_id":"MDQ6VXNlcjEzMjc4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327850?v=4","gravatar_id":"","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false},"body":"@lefticus I didn't mention but bimserver project is not being de-qt-ized.  It is going with the other graphical components.  I'll change this to use the \"../model_editor/Utilities.hpp\" file","created_at":"2019-01-05T16:21:17Z","updated_at":"2019-01-05T16:21:17Z","html_url":"https://github.com/NREL/OpenStudio/pull/3397#discussion_r245481697","pull_request_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/245481697"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/3397#discussion_r245481697"},"pull_request":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397","id":242411246,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDExMjQ2","html_url":"https://github.com/NREL/OpenStudio/pull/3397","diff_url":"https://github.com/NREL/OpenStudio/pull/3397.diff","patch_url":"https://github.com/NREL/OpenStudio/pull/3397.patch","issue_url":"https://api.github.com/repos/NREL/OpenStudio/issues/3397","number":3397,"state":"open","locked":false,"title":"Remove more qstring","user":{"login":"lefticus","id":234279,"node_id":"MDQ6VXNlcjIzNDI3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/234279?v=4","gravatar_id":"","url":"https://api.github.com/users/lefticus","html_url":"https://github.com/lefticus","followers_url":"https://api.github.com/users/lefticus/followers","following_url":"https://api.github.com/users/lefticus/following{/other_user}","gists_url":"https://api.github.com/users/lefticus/gists{/gist_id}","starred_url":"https://api.github.com/users/lefticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefticus/subscriptions","organizations_url":"https://api.github.com/users/lefticus/orgs","repos_url":"https://api.github.com/users/lefticus/repos","events_url":"https://api.github.com/users/lefticus/events{/privacy}","received_events_url":"https://api.github.com/users/lefticus/received_events","type":"User","site_admin":false},"body":"## Remove More QString\r\n\r\nThis removes QString from utilities/core, which includes String.* and Path.* files.\r\n\r\nIt would potentially have lots of impact on the parts of OpenStudio that is using QDomDocument, so highly localized helper functions were added to prevent too much merge conflict impact for those working on it.\r\n","created_at":"2019-01-05T01:30:49Z","updated_at":"2019-01-05T16:21:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e33a5db3606daeb1fe40512892f976f5f49ca483","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397/commits","review_comments_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397/comments","review_comment_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/issues/3397/comments","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/2826cae983249bc1bac54a8227821c426326f1f2","head":{"label":"NREL:remove_more_qstring","ref":"remove_more_qstring","sha":"2826cae983249bc1bac54a8227821c426326f1f2","user":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1OTU1Mg==","name":"OpenStudio","full_name":"NREL/OpenStudio","private":false,"owner":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/OpenStudio/deployments","created_at":"2013-07-03T19:34:37Z","updated_at":"2019-01-03T17:49:31Z","pushed_at":"2019-01-05T01:30:50Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":322601,"stargazers_count":226,"watchers_count":226,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":546,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":117,"open_issues":546,"watchers":226,"default_branch":"develop"}},"base":{"label":"NREL:develop3","ref":"develop3","sha":"a720fd6576b6be5889e5ca82f999dea4a3632ef8","user":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1OTU1Mg==","name":"OpenStudio","full_name":"NREL/OpenStudio","private":false,"owner":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/OpenStudio/deployments","created_at":"2013-07-03T19:34:37Z","updated_at":"2019-01-03T17:49:31Z","pushed_at":"2019-01-05T01:30:50Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":322601,"stargazers_count":226,"watchers_count":226,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":546,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":117,"open_issues":546,"watchers":226,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/3397"},"issue":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/3397"},"comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/3397/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3397/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/OpenStudio/statuses/2826cae983249bc1bac54a8227821c426326f1f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"macumber"}}