{"action":"created","comment":{"url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/comments/229989223","pull_request_review_id":170617680,"id":229989223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTk4OTIyMw==","diff_hunk":"@@ -226,14 +232,54 @@\n \n     /**\n      * <p>\n-     * returns row of codelist table.\n+     * Returns a codelist as map for the {@link org.springframework.context.i18n.LocaleContextHolder}'s locale.\n+     * </p>\n+     * @see org.terasoluna.gfw.common.codelist.CodeList#asMap()\n+     */\n+    @Override\n+    public Map<String, String> asMap() {\n+        return asMap(LocaleContextHolder.getLocale());\n+    }\n+\n+    /**\n+     * <p>\n+     * returns row of codelist table.<br>\n+     * if there is no codelist for the locale, throws an {@link IllegalStateException}.\n      * </p>\n      * @see org.terasoluna.gfw.common.codelist.i18n.I18nCodeList#asMap(java.util.Locale)\n      */\n     @Override\n     public Map<String, String> asMap(Locale locale) {\n         Assert.notNull(locale, \"locale is null\");\n-        return codeListTable.row(locale);\n+\n+        if (codeListTable.containsRow(locale)) {\n+            if (logger.isDebugEnabled()) {\n+                logger.debug(\"Found codelist for specified locale '{}'.\",\n+                        locale);\n+            }\n+            return codeListTable.row(locale);\n+        }","path":"terasoluna-gfw-common-libraries/terasoluna-gfw-common/src/main/java/org/terasoluna/gfw/common/codelist/i18n/SimpleI18nCodeList.java","position":52,"original_position":52,"commit_id":"d419ee4780b0ebb5ea0639a217745b5d220325ce","original_commit_id":"d419ee4780b0ebb5ea0639a217745b5d220325ce","user":{"login":"btkitsunedukam","id":11750925,"node_id":"MDQ6VXNlcjExNzUwOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/11750925?v=4","gravatar_id":"","url":"https://api.github.com/users/btkitsunedukam","html_url":"https://github.com/btkitsunedukam","followers_url":"https://api.github.com/users/btkitsunedukam/followers","following_url":"https://api.github.com/users/btkitsunedukam/following{/other_user}","gists_url":"https://api.github.com/users/btkitsunedukam/gists{/gist_id}","starred_url":"https://api.github.com/users/btkitsunedukam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btkitsunedukam/subscriptions","organizations_url":"https://api.github.com/users/btkitsunedukam/orgs","repos_url":"https://api.github.com/users/btkitsunedukam/repos","events_url":"https://api.github.com/users/btkitsunedukam/events{/privacy}","received_events_url":"https://api.github.com/users/btkitsunedukam/received_events","type":"User","site_admin":false},"body":"Previously I separated, but finally I mergerd.\r\nI forgot that reason, so I will reconsider it.","created_at":"2018-11-01T09:53:05Z","updated_at":"2018-11-01T09:53:05Z","html_url":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840#discussion_r229989223","pull_request_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/comments/229989223"},"html":{"href":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840#discussion_r229989223"},"pull_request":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840"}},"in_reply_to_id":229147962},"pull_request":{"url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840","id":224918366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTE4MzY2","html_url":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840","diff_url":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840.diff","patch_url":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840.patch","issue_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/840","number":840,"state":"open","locked":false,"title":"Improve i18nCodeList locale resolution. #363 #803","user":{"login":"btkitsunedukam","id":11750925,"node_id":"MDQ6VXNlcjExNzUwOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/11750925?v=4","gravatar_id":"","url":"https://api.github.com/users/btkitsunedukam","html_url":"https://github.com/btkitsunedukam","followers_url":"https://api.github.com/users/btkitsunedukam/followers","following_url":"https://api.github.com/users/btkitsunedukam/following{/other_user}","gists_url":"https://api.github.com/users/btkitsunedukam/gists{/gist_id}","starred_url":"https://api.github.com/users/btkitsunedukam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btkitsunedukam/subscriptions","organizations_url":"https://api.github.com/users/btkitsunedukam/orgs","repos_url":"https://api.github.com/users/btkitsunedukam/repos","events_url":"https://api.github.com/users/btkitsunedukam/events{/privacy}","received_events_url":"https://api.github.com/users/btkitsunedukam/received_events","type":"User","site_admin":false},"body":"Please review #363, #803.\r\n\r\n_I do not maintained JUnit test code because those test code never maintained correctly before ever. I modified existing method but the test for that method is not exist. I talked to @hirakuriy about this issue and he said you do not need to maintain JUnit test code._","created_at":"2018-10-23T07:02:02Z","updated_at":"2018-11-01T09:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"889b5b13672e25bae140cecc401d1f3bb4ffee8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hirakuriy","id":27995689,"node_id":"MDQ6VXNlcjI3OTk1Njg5","avatar_url":"https://avatars3.githubusercontent.com/u/27995689?v=4","gravatar_id":"","url":"https://api.github.com/users/hirakuriy","html_url":"https://github.com/hirakuriy","followers_url":"https://api.github.com/users/hirakuriy/followers","following_url":"https://api.github.com/users/hirakuriy/following{/other_user}","gists_url":"https://api.github.com/users/hirakuriy/gists{/gist_id}","starred_url":"https://api.github.com/users/hirakuriy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hirakuriy/subscriptions","organizations_url":"https://api.github.com/users/hirakuriy/orgs","repos_url":"https://api.github.com/users/hirakuriy/repos","events_url":"https://api.github.com/users/hirakuriy/events{/privacy}","received_events_url":"https://api.github.com/users/hirakuriy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":326245596,"node_id":"MDU6TGFiZWwzMjYyNDU1OTY=","url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/labels/status:%20in-progress","name":"status: in-progress","color":"EDEDED","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840/commits","review_comments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840/comments","review_comment_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/840/comments","statuses_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/statuses/d419ee4780b0ebb5ea0639a217745b5d220325ce","head":{"label":"terasolunaorg:issues/363_803_improve_locale_resolution_i18n_codelist","ref":"issues/363_803_improve_locale_resolution_i18n_codelist","sha":"d419ee4780b0ebb5ea0639a217745b5d220325ce","user":{"login":"terasolunaorg","id":2259156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2259156?v=4","gravatar_id":"","url":"https://api.github.com/users/terasolunaorg","html_url":"https://github.com/terasolunaorg","followers_url":"https://api.github.com/users/terasolunaorg/followers","following_url":"https://api.github.com/users/terasolunaorg/following{/other_user}","gists_url":"https://api.github.com/users/terasolunaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/terasolunaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terasolunaorg/subscriptions","organizations_url":"https://api.github.com/users/terasolunaorg/orgs","repos_url":"https://api.github.com/users/terasolunaorg/repos","events_url":"https://api.github.com/users/terasolunaorg/events{/privacy}","received_events_url":"https://api.github.com/users/terasolunaorg/received_events","type":"Organization","site_admin":false},"repo":{"id":13322751,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMjc1MQ==","name":"terasoluna-gfw","full_name":"terasolunaorg/terasoluna-gfw","private":false,"owner":{"login":"terasolunaorg","id":2259156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2259156?v=4","gravatar_id":"","url":"https://api.github.com/users/terasolunaorg","html_url":"https://github.com/terasolunaorg","followers_url":"https://api.github.com/users/terasolunaorg/followers","following_url":"https://api.github.com/users/terasolunaorg/following{/other_user}","gists_url":"https://api.github.com/users/terasolunaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/terasolunaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terasolunaorg/subscriptions","organizations_url":"https://api.github.com/users/terasolunaorg/orgs","repos_url":"https://api.github.com/users/terasolunaorg/repos","events_url":"https://api.github.com/users/terasolunaorg/events{/privacy}","received_events_url":"https://api.github.com/users/terasolunaorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terasolunaorg/terasoluna-gfw","description":"Common libraries for TERASOLUNA Server Framework for Java (5.x)","fork":false,"url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw","forks_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/forks","keys_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/teams","hooks_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/hooks","issue_events_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/events{/number}","events_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/events","assignees_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/assignees{/user}","branches_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/branches{/branch}","tags_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/tags","blobs_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/refs{/sha}","trees_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/statuses/{sha}","languages_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/languages","stargazers_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/stargazers","contributors_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/contributors","subscribers_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/subscribers","subscription_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/subscription","commits_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/commits{/sha}","git_commits_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/commits{/sha}","comments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/comments{/number}","issue_comment_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/comments{/number}","contents_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/contents/{+path}","compare_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/merges","archive_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/downloads","issues_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues{/number}","pulls_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls{/number}","milestones_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/milestones{/number}","notifications_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/labels{/name}","releases_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/releases{/id}","deployments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/deployments","created_at":"2013-10-04T11:35:34Z","updated_at":"2018-10-30T05:20:45Z","pushed_at":"2018-10-30T06:12:03Z","git_url":"git://github.com/terasolunaorg/terasoluna-gfw.git","ssh_url":"git@github.com:terasolunaorg/terasoluna-gfw.git","clone_url":"https://github.com/terasolunaorg/terasoluna-gfw.git","svn_url":"https://github.com/terasolunaorg/terasoluna-gfw","homepage":"","size":3603,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":59,"license":null,"forks":37,"open_issues":59,"watchers":55,"default_branch":"master"}},"base":{"label":"terasolunaorg:master","ref":"master","sha":"54094f2d70a24119fc085f924acd0372bf7ec3a1","user":{"login":"terasolunaorg","id":2259156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2259156?v=4","gravatar_id":"","url":"https://api.github.com/users/terasolunaorg","html_url":"https://github.com/terasolunaorg","followers_url":"https://api.github.com/users/terasolunaorg/followers","following_url":"https://api.github.com/users/terasolunaorg/following{/other_user}","gists_url":"https://api.github.com/users/terasolunaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/terasolunaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terasolunaorg/subscriptions","organizations_url":"https://api.github.com/users/terasolunaorg/orgs","repos_url":"https://api.github.com/users/terasolunaorg/repos","events_url":"https://api.github.com/users/terasolunaorg/events{/privacy}","received_events_url":"https://api.github.com/users/terasolunaorg/received_events","type":"Organization","site_admin":false},"repo":{"id":13322751,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMjc1MQ==","name":"terasoluna-gfw","full_name":"terasolunaorg/terasoluna-gfw","private":false,"owner":{"login":"terasolunaorg","id":2259156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2259156?v=4","gravatar_id":"","url":"https://api.github.com/users/terasolunaorg","html_url":"https://github.com/terasolunaorg","followers_url":"https://api.github.com/users/terasolunaorg/followers","following_url":"https://api.github.com/users/terasolunaorg/following{/other_user}","gists_url":"https://api.github.com/users/terasolunaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/terasolunaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terasolunaorg/subscriptions","organizations_url":"https://api.github.com/users/terasolunaorg/orgs","repos_url":"https://api.github.com/users/terasolunaorg/repos","events_url":"https://api.github.com/users/terasolunaorg/events{/privacy}","received_events_url":"https://api.github.com/users/terasolunaorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terasolunaorg/terasoluna-gfw","description":"Common libraries for TERASOLUNA Server Framework for Java (5.x)","fork":false,"url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw","forks_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/forks","keys_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/teams","hooks_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/hooks","issue_events_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/events{/number}","events_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/events","assignees_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/assignees{/user}","branches_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/branches{/branch}","tags_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/tags","blobs_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/refs{/sha}","trees_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/statuses/{sha}","languages_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/languages","stargazers_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/stargazers","contributors_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/contributors","subscribers_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/subscribers","subscription_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/subscription","commits_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/commits{/sha}","git_commits_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/git/commits{/sha}","comments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/comments{/number}","issue_comment_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/comments{/number}","contents_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/contents/{+path}","compare_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/merges","archive_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/downloads","issues_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues{/number}","pulls_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls{/number}","milestones_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/milestones{/number}","notifications_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/labels{/name}","releases_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/releases{/id}","deployments_url":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/deployments","created_at":"2013-10-04T11:35:34Z","updated_at":"2018-10-30T05:20:45Z","pushed_at":"2018-10-30T06:12:03Z","git_url":"git://github.com/terasolunaorg/terasoluna-gfw.git","ssh_url":"git@github.com:terasolunaorg/terasoluna-gfw.git","clone_url":"https://github.com/terasolunaorg/terasoluna-gfw.git","svn_url":"https://github.com/terasolunaorg/terasoluna-gfw","homepage":"","size":3603,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":59,"license":null,"forks":37,"open_issues":59,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840"},"html":{"href":"https://github.com/terasolunaorg/terasoluna-gfw/pull/840"},"issue":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/840"},"comments":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/terasolunaorg/terasoluna-gfw/statuses/d419ee4780b0ebb5ea0639a217745b5d220325ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"btkitsunedukam"}}