{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/953","repository_url":"https://api.github.com/repos/opencontainers/runtime-spec","labels_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/953/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/953/comments","events_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/953/events","html_url":"https://github.com/opencontainers/runtime-spec/pull/953","id":302235565,"number":953,"title":"config: Clarify execution environment for hooks","user":{"login":"alban","id":27575,"avatar_url":"https://avatars2.githubusercontent.com/u/27575?v=4","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-05T09:59:01Z","updated_at":"2018-03-05T15:10:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/953","html_url":"https://github.com/opencontainers/runtime-spec/pull/953","diff_url":"https://github.com/opencontainers/runtime-spec/pull/953.diff","patch_url":"https://github.com/opencontainers/runtime-spec/pull/953.patch"},"body":"The spec didn't say whether the hooks are executed in the container\r\nenvironment or not (in Linux namespaces, with cgroups and rlimits\r\napplied).\r\n\r\nIn rkt, hooks are executed in the container environment. In runc, hooks\r\nare executed outside of the container environment.\r\n\r\nThe example with setting up the network namespace in \"prestart\" suggests\r\nthat the command is generic and does not have to exist in the container\r\nrootfs. So I assume the spec was meant to say hooks are executed outside\r\nof the container environment.\r\n\r\nSigned-off-by: Alban Crequy <alban@kinvolk.io>"},"comment":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/comments/370449658","html_url":"https://github.com/opencontainers/runtime-spec/pull/953#issuecomment-370449658","issue_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/953","id":370449658,"user":{"login":"alban","id":27575,"avatar_url":"https://avatars2.githubusercontent.com/u/27575?v=4","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T15:10:42Z","updated_at":"2018-03-05T15:10:42Z","author_association":"NONE","body":"I updated my commitmsg with the DCO."}}
{"actor":{"display_login":"alban"}}