{"action":"created","comment":{"url":"https://api.github.com/repos/khartec/waltz/pulls/comments/210369479","pull_request_review_id":146570332,"id":210369479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDM2OTQ3OQ==","diff_hunk":"@@ -26,14 +26,19 @@ export function store($http, BaseApiUrl) {\n         .get(`${BASE}/id/${id}`)\n         .then(result => result.data);\n \n-    const findAll = (ids) => $http\n-        .get(`${BASE}/all`)\n+    const findAll = () => $http\n+        .get(`${BASE}`)","path":"waltz-ng/client/assessments/services/assessment-definition-store.js","position":7,"original_position":7,"commit_id":"3a70619bbbcb1e7b0ef52da09bf177b23d3ea90e","original_commit_id":"3a70619bbbcb1e7b0ef52da09bf177b23d3ea90e","user":{"login":"davidwatkins73","id":576829,"node_id":"MDQ6VXNlcjU3NjgyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/576829?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwatkins73","html_url":"https://github.com/davidwatkins73","followers_url":"https://api.github.com/users/davidwatkins73/followers","following_url":"https://api.github.com/users/davidwatkins73/following{/other_user}","gists_url":"https://api.github.com/users/davidwatkins73/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwatkins73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwatkins73/subscriptions","organizations_url":"https://api.github.com/users/davidwatkins73/orgs","repos_url":"https://api.github.com/users/davidwatkins73/repos","events_url":"https://api.github.com/users/davidwatkins73/events{/privacy}","received_events_url":"https://api.github.com/users/davidwatkins73/received_events","type":"User","site_admin":false},"body":"I think this may be unnecessary  interpolation ?   `get(BASE)`  instead....","created_at":"2018-08-15T18:46:34Z","updated_at":"2018-08-15T18:46:34Z","html_url":"https://github.com/khartec/waltz/pull/3323#discussion_r210369479","pull_request_url":"https://api.github.com/repos/khartec/waltz/pulls/3323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/khartec/waltz/pulls/comments/210369479"},"html":{"href":"https://github.com/khartec/waltz/pull/3323#discussion_r210369479"},"pull_request":{"href":"https://api.github.com/repos/khartec/waltz/pulls/3323"}}},"pull_request":{"url":"https://api.github.com/repos/khartec/waltz/pulls/3323","id":208609179,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjA5MTc5","html_url":"https://github.com/khartec/waltz/pull/3323","diff_url":"https://github.com/khartec/waltz/pull/3323.diff","patch_url":"https://github.com/khartec/waltz/pull/3323.patch","issue_url":"https://api.github.com/repos/khartec/waltz/issues/3323","number":3323,"state":"open","locked":false,"title":"assessments display panel","user":{"login":"kamransaleem","id":3029467,"node_id":"MDQ6VXNlcjMwMjk0Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3029467?v=4","gravatar_id":"","url":"https://api.github.com/users/kamransaleem","html_url":"https://github.com/kamransaleem","followers_url":"https://api.github.com/users/kamransaleem/followers","following_url":"https://api.github.com/users/kamransaleem/following{/other_user}","gists_url":"https://api.github.com/users/kamransaleem/gists{/gist_id}","starred_url":"https://api.github.com/users/kamransaleem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamransaleem/subscriptions","organizations_url":"https://api.github.com/users/kamransaleem/orgs","repos_url":"https://api.github.com/users/kamransaleem/repos","events_url":"https://api.github.com/users/kamransaleem/events{/privacy}","received_events_url":"https://api.github.com/users/kamransaleem/received_events","type":"User","site_admin":false},"body":"#3321\r\n\r\nLooks like the below:\r\n\r\n<img width=\"541\" alt=\"waltz__invest_in_customer_structures\" src=\"https://user-images.githubusercontent.com/3029467/44159019-29bff600-a0ae-11e8-8a21-b306c6fe9822.png\">\r\n\r\n<img width=\"387\" alt=\"waltz__invest_in_customer_structures\" src=\"https://user-images.githubusercontent.com/3029467/44159128-65f35680-a0ae-11e8-873e-12a2778e96e1.png\">\r\n\r\n<img width=\"457\" alt=\"waltz__invest_in_customer_structures\" src=\"https://user-images.githubusercontent.com/3029467/44159149-75729f80-a0ae-11e8-9f1e-102ebd8e2f91.png\">\r\n","created_at":"2018-08-15T16:13:21Z","updated_at":"2018-08-15T18:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd0638d1972cac8a95898e7a1c937aec33fa21d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/khartec/waltz/pulls/3323/commits","review_comments_url":"https://api.github.com/repos/khartec/waltz/pulls/3323/comments","review_comment_url":"https://api.github.com/repos/khartec/waltz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/khartec/waltz/issues/3323/comments","statuses_url":"https://api.github.com/repos/khartec/waltz/statuses/3a70619bbbcb1e7b0ef52da09bf177b23d3ea90e","head":{"label":"kamransaleem:waltz-3321-assessments-display-panel","ref":"waltz-3321-assessments-display-panel","sha":"3a70619bbbcb1e7b0ef52da09bf177b23d3ea90e","user":{"login":"kamransaleem","id":3029467,"node_id":"MDQ6VXNlcjMwMjk0Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3029467?v=4","gravatar_id":"","url":"https://api.github.com/users/kamransaleem","html_url":"https://github.com/kamransaleem","followers_url":"https://api.github.com/users/kamransaleem/followers","following_url":"https://api.github.com/users/kamransaleem/following{/other_user}","gists_url":"https://api.github.com/users/kamransaleem/gists{/gist_id}","starred_url":"https://api.github.com/users/kamransaleem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamransaleem/subscriptions","organizations_url":"https://api.github.com/users/kamransaleem/orgs","repos_url":"https://api.github.com/users/kamransaleem/repos","events_url":"https://api.github.com/users/kamransaleem/events{/privacy}","received_events_url":"https://api.github.com/users/kamransaleem/received_events","type":"User","site_admin":false},"repo":{"id":61117590,"node_id":"MDEwOlJlcG9zaXRvcnk2MTExNzU5MA==","name":"waltz","full_name":"kamransaleem/waltz","owner":{"login":"kamransaleem","id":3029467,"node_id":"MDQ6VXNlcjMwMjk0Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3029467?v=4","gravatar_id":"","url":"https://api.github.com/users/kamransaleem","html_url":"https://github.com/kamransaleem","followers_url":"https://api.github.com/users/kamransaleem/followers","following_url":"https://api.github.com/users/kamransaleem/following{/other_user}","gists_url":"https://api.github.com/users/kamransaleem/gists{/gist_id}","starred_url":"https://api.github.com/users/kamransaleem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamransaleem/subscriptions","organizations_url":"https://api.github.com/users/kamransaleem/orgs","repos_url":"https://api.github.com/users/kamransaleem/repos","events_url":"https://api.github.com/users/kamransaleem/events{/privacy}","received_events_url":"https://api.github.com/users/kamransaleem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamransaleem/waltz","description":"Architecture on the Wire","fork":true,"url":"https://api.github.com/repos/kamransaleem/waltz","forks_url":"https://api.github.com/repos/kamransaleem/waltz/forks","keys_url":"https://api.github.com/repos/kamransaleem/waltz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamransaleem/waltz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamransaleem/waltz/teams","hooks_url":"https://api.github.com/repos/kamransaleem/waltz/hooks","issue_events_url":"https://api.github.com/repos/kamransaleem/waltz/issues/events{/number}","events_url":"https://api.github.com/repos/kamransaleem/waltz/events","assignees_url":"https://api.github.com/repos/kamransaleem/waltz/assignees{/user}","branches_url":"https://api.github.com/repos/kamransaleem/waltz/branches{/branch}","tags_url":"https://api.github.com/repos/kamransaleem/waltz/tags","blobs_url":"https://api.github.com/repos/kamransaleem/waltz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamransaleem/waltz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamransaleem/waltz/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamransaleem/waltz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamransaleem/waltz/statuses/{sha}","languages_url":"https://api.github.com/repos/kamransaleem/waltz/languages","stargazers_url":"https://api.github.com/repos/kamransaleem/waltz/stargazers","contributors_url":"https://api.github.com/repos/kamransaleem/waltz/contributors","subscribers_url":"https://api.github.com/repos/kamransaleem/waltz/subscribers","subscription_url":"https://api.github.com/repos/kamransaleem/waltz/subscription","commits_url":"https://api.github.com/repos/kamransaleem/waltz/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamransaleem/waltz/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamransaleem/waltz/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamransaleem/waltz/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamransaleem/waltz/contents/{+path}","compare_url":"https://api.github.com/repos/kamransaleem/waltz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamransaleem/waltz/merges","archive_url":"https://api.github.com/repos/kamransaleem/waltz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamransaleem/waltz/downloads","issues_url":"https://api.github.com/repos/kamransaleem/waltz/issues{/number}","pulls_url":"https://api.github.com/repos/kamransaleem/waltz/pulls{/number}","milestones_url":"https://api.github.com/repos/kamransaleem/waltz/milestones{/number}","notifications_url":"https://api.github.com/repos/kamransaleem/waltz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamransaleem/waltz/labels{/name}","releases_url":"https://api.github.com/repos/kamransaleem/waltz/releases{/id}","deployments_url":"https://api.github.com/repos/kamransaleem/waltz/deployments","created_at":"2016-06-14T11:32:40Z","updated_at":"2018-08-08T08:14:02Z","pushed_at":"2018-08-15T16:07:33Z","git_url":"git://github.com/kamransaleem/waltz.git","ssh_url":"git@github.com:kamransaleem/waltz.git","clone_url":"https://github.com/kamransaleem/waltz.git","svn_url":"https://github.com/kamransaleem/waltz","homepage":null,"size":14898,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"khartec:waltz-feature-3319-assessment-ratings","ref":"waltz-feature-3319-assessment-ratings","sha":"4799b9a7c9208bc9053d390fe2a9302cb04bd8b8","user":{"login":"khartec","id":16178732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTc4NzMy","avatar_url":"https://avatars2.githubusercontent.com/u/16178732?v=4","gravatar_id":"","url":"https://api.github.com/users/khartec","html_url":"https://github.com/khartec","followers_url":"https://api.github.com/users/khartec/followers","following_url":"https://api.github.com/users/khartec/following{/other_user}","gists_url":"https://api.github.com/users/khartec/gists{/gist_id}","starred_url":"https://api.github.com/users/khartec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khartec/subscriptions","organizations_url":"https://api.github.com/users/khartec/orgs","repos_url":"https://api.github.com/users/khartec/repos","events_url":"https://api.github.com/users/khartec/events{/privacy}","received_events_url":"https://api.github.com/users/khartec/received_events","type":"Organization","site_admin":false},"repo":{"id":47506301,"node_id":"MDEwOlJlcG9zaXRvcnk0NzUwNjMwMQ==","name":"waltz","full_name":"khartec/waltz","owner":{"login":"khartec","id":16178732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTc4NzMy","avatar_url":"https://avatars2.githubusercontent.com/u/16178732?v=4","gravatar_id":"","url":"https://api.github.com/users/khartec","html_url":"https://github.com/khartec","followers_url":"https://api.github.com/users/khartec/followers","following_url":"https://api.github.com/users/khartec/following{/other_user}","gists_url":"https://api.github.com/users/khartec/gists{/gist_id}","starred_url":"https://api.github.com/users/khartec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khartec/subscriptions","organizations_url":"https://api.github.com/users/khartec/orgs","repos_url":"https://api.github.com/users/khartec/repos","events_url":"https://api.github.com/users/khartec/events{/privacy}","received_events_url":"https://api.github.com/users/khartec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/khartec/waltz","description":"Enterprise Architecture ","fork":false,"url":"https://api.github.com/repos/khartec/waltz","forks_url":"https://api.github.com/repos/khartec/waltz/forks","keys_url":"https://api.github.com/repos/khartec/waltz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khartec/waltz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khartec/waltz/teams","hooks_url":"https://api.github.com/repos/khartec/waltz/hooks","issue_events_url":"https://api.github.com/repos/khartec/waltz/issues/events{/number}","events_url":"https://api.github.com/repos/khartec/waltz/events","assignees_url":"https://api.github.com/repos/khartec/waltz/assignees{/user}","branches_url":"https://api.github.com/repos/khartec/waltz/branches{/branch}","tags_url":"https://api.github.com/repos/khartec/waltz/tags","blobs_url":"https://api.github.com/repos/khartec/waltz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khartec/waltz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khartec/waltz/git/refs{/sha}","trees_url":"https://api.github.com/repos/khartec/waltz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khartec/waltz/statuses/{sha}","languages_url":"https://api.github.com/repos/khartec/waltz/languages","stargazers_url":"https://api.github.com/repos/khartec/waltz/stargazers","contributors_url":"https://api.github.com/repos/khartec/waltz/contributors","subscribers_url":"https://api.github.com/repos/khartec/waltz/subscribers","subscription_url":"https://api.github.com/repos/khartec/waltz/subscription","commits_url":"https://api.github.com/repos/khartec/waltz/commits{/sha}","git_commits_url":"https://api.github.com/repos/khartec/waltz/git/commits{/sha}","comments_url":"https://api.github.com/repos/khartec/waltz/comments{/number}","issue_comment_url":"https://api.github.com/repos/khartec/waltz/issues/comments{/number}","contents_url":"https://api.github.com/repos/khartec/waltz/contents/{+path}","compare_url":"https://api.github.com/repos/khartec/waltz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khartec/waltz/merges","archive_url":"https://api.github.com/repos/khartec/waltz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khartec/waltz/downloads","issues_url":"https://api.github.com/repos/khartec/waltz/issues{/number}","pulls_url":"https://api.github.com/repos/khartec/waltz/pulls{/number}","milestones_url":"https://api.github.com/repos/khartec/waltz/milestones{/number}","notifications_url":"https://api.github.com/repos/khartec/waltz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khartec/waltz/labels{/name}","releases_url":"https://api.github.com/repos/khartec/waltz/releases{/id}","deployments_url":"https://api.github.com/repos/khartec/waltz/deployments","created_at":"2015-12-06T17:26:44Z","updated_at":"2018-08-06T17:31:04Z","pushed_at":"2018-08-15T16:13:21Z","git_url":"git://github.com/khartec/waltz.git","ssh_url":"git@github.com:khartec/waltz.git","clone_url":"https://github.com/khartec/waltz.git","svn_url":"https://github.com/khartec/waltz","homepage":"https://khartec.github.io","size":14848,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":21,"open_issues":178,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/khartec/waltz/pulls/3323"},"html":{"href":"https://github.com/khartec/waltz/pull/3323"},"issue":{"href":"https://api.github.com/repos/khartec/waltz/issues/3323"},"comments":{"href":"https://api.github.com/repos/khartec/waltz/issues/3323/comments"},"review_comments":{"href":"https://api.github.com/repos/khartec/waltz/pulls/3323/comments"},"review_comment":{"href":"https://api.github.com/repos/khartec/waltz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/khartec/waltz/pulls/3323/commits"},"statuses":{"href":"https://api.github.com/repos/khartec/waltz/statuses/3a70619bbbcb1e7b0ef52da09bf177b23d3ea90e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"davidwatkins73"}}