{"action":"created","comment":{"url":"https://api.github.com/repos/aionnetwork/aion/pulls/comments/190067648","pull_request_review_id":122370342,"id":190067648,"diff_hunk":"@@ -71,34 +69,41 @@ public static void main(String args[]) throws InterruptedException {\n          * if in the config.xml id is set as default [NODE-ID-PLACEHOLDER]\n          * return true which means should save back to xml config\n          */\n-        if(cfg.fromXML())\n-            cfg.toXML(new String[]{ \"--id=\" + cfg.getId() });\n+        if (cfg.fromXML()) cfg.toXML(new String[] {\"--id=\" + cfg.getId()});\n \n-        \n         try {\n             ServiceLoader.load(AionLoggerFactory.class);\n         } catch (Exception e) {\n             System.out.println(\"load AionLoggerFactory service fail!\" + e.toString());\n             throw e;\n         }\n \n-\n-        // If commit this out, the config setting will be ignore. all log module been set to \"INFO\" Level\n-        AionLoggerFactory.init(cfg.getLog().getModules());\n+        // If commit this out, the config setting will be ignore. all log module been set to \"INFO\"\n+        // Level\n+        /** Changed INITIALIZE signature to include LOGFILE and LOGPATH */\n+        AionLoggerFactory.init(\n+                cfg.getLog().getModules(), cfg.getLog().getLogFile(), cfg.getLog().getLogPath());\n         Logger LOG = AionLoggerFactory.getLogger(LogEnum.GEN.toString());\n \n-        System.out.println(                \n-                        \"                     _____                  \\n\" +\n-                        \"      .'.       |  .~     ~.  |..          |\\n\" +\n-                        \"    .'   `.     | |         | |  ``..      |\\n\" +\n-                        \"  .''''''''`.   | |         | |      ``..  |\\n\" +\n-                        \".'           `. |  `._____.'  |          ``|\\n\\n\" +\n-                        \"                    NETWORK  v\" + KERNEL_VERSION +\n-                                \"\\n\\n\"\n-                );\n+        /** Outputs message to console depending on logPath validity */\n+        if (cfg.getLog().isValidInput()) {","path":"modBoot/src/org/aion/Aion.java","position":72,"original_position":72,"commit_id":"a636001912000e1bafdfaf02fc451dceecf95202","original_commit_id":"a636001912000e1bafdfaf02fc451dceecf95202","user":{"login":"qoire","id":4521292,"avatar_url":"https://avatars0.githubusercontent.com/u/4521292?v=4","gravatar_id":"","url":"https://api.github.com/users/qoire","html_url":"https://github.com/qoire","followers_url":"https://api.github.com/users/qoire/followers","following_url":"https://api.github.com/users/qoire/following{/other_user}","gists_url":"https://api.github.com/users/qoire/gists{/gist_id}","starred_url":"https://api.github.com/users/qoire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qoire/subscriptions","organizations_url":"https://api.github.com/users/qoire/orgs","repos_url":"https://api.github.com/users/qoire/repos","events_url":"https://api.github.com/users/qoire/events{/privacy}","received_events_url":"https://api.github.com/users/qoire/received_events","type":"User","site_admin":false},"body":"Should not be outputting content above ``AION`` logo","created_at":"2018-05-22T22:03:43Z","updated_at":"2018-05-22T22:03:43Z","html_url":"https://github.com/aionnetwork/aion/pull/496#discussion_r190067648","pull_request_url":"https://api.github.com/repos/aionnetwork/aion/pulls/496","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/comments/190067648"},"html":{"href":"https://github.com/aionnetwork/aion/pull/496#discussion_r190067648"},"pull_request":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/aionnetwork/aion/pulls/496","id":189064784,"html_url":"https://github.com/aionnetwork/aion/pull/496","diff_url":"https://github.com/aionnetwork/aion/pull/496.diff","patch_url":"https://github.com/aionnetwork/aion/pull/496.patch","issue_url":"https://api.github.com/repos/aionnetwork/aion/issues/496","number":496,"state":"open","locked":false,"title":"Added logger feature","user":{"login":"aionJoey","id":39343036,"avatar_url":"https://avatars3.githubusercontent.com/u/39343036?v=4","gravatar_id":"","url":"https://api.github.com/users/aionJoey","html_url":"https://github.com/aionJoey","followers_url":"https://api.github.com/users/aionJoey/followers","following_url":"https://api.github.com/users/aionJoey/following{/other_user}","gists_url":"https://api.github.com/users/aionJoey/gists{/gist_id}","starred_url":"https://api.github.com/users/aionJoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionJoey/subscriptions","organizations_url":"https://api.github.com/users/aionJoey/orgs","repos_url":"https://api.github.com/users/aionJoey/repos","events_url":"https://api.github.com/users/aionJoey/events{/privacy}","received_events_url":"https://api.github.com/users/aionJoey/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n- Allows log files of the kernel to be generated (logback)\r\n- Archives the log files by size (100MB) and by time (Per Day)\r\n- Allows user to toggle the logger ON and OFF\r\n\r\n## Type of change\r\n\r\nInsert **x** into the following checkboxes to confirm (eg. [x]):\r\n- [ ] Bug fix.\r\n- [x] New feature.\r\n- [ ] Breaking change (a fix or feature that causes existing functionality to not work as expected).\r\n- [x] Requires documentation update.\r\n\r\n## Testing\r\n\r\nPlease describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.\r\n\r\n- Verified log file rollover conditions (size and time)\r\n- Verified toggle feature in config.xml file\r\n\r\n## Verification\r\n\r\nInsert **x** into the following checkboxes to confirm (eg. [x]):\r\n- [x] I have self-reviewed my own code and conformed to the style guidelines of this project.\r\n- [x] New and existing tests pass locally with my changes.\r\n- [ ] I have added tests for my fix or feature.\r\n- [ ] I have made appropriate changes to the corresponding documentation.\r\n- [x] My code generates no new warnings.\r\n- [x] Any dependent changes have been made.\r\n","created_at":"2018-05-18T15:43:33Z","updated_at":"2018-05-22T22:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fc20f9275bba2b0149f05faa85eef5bf890cf65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlexandraRoatis","id":31413007,"avatar_url":"https://avatars2.githubusercontent.com/u/31413007?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexandraRoatis","html_url":"https://github.com/AlexandraRoatis","followers_url":"https://api.github.com/users/AlexandraRoatis/followers","following_url":"https://api.github.com/users/AlexandraRoatis/following{/other_user}","gists_url":"https://api.github.com/users/AlexandraRoatis/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandraRoatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandraRoatis/subscriptions","organizations_url":"https://api.github.com/users/AlexandraRoatis/orgs","repos_url":"https://api.github.com/users/AlexandraRoatis/repos","events_url":"https://api.github.com/users/AlexandraRoatis/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandraRoatis/received_events","type":"User","site_admin":false},{"login":"aion-sridevi","id":38107831,"avatar_url":"https://avatars3.githubusercontent.com/u/38107831?v=4","gravatar_id":"","url":"https://api.github.com/users/aion-sridevi","html_url":"https://github.com/aion-sridevi","followers_url":"https://api.github.com/users/aion-sridevi/followers","following_url":"https://api.github.com/users/aion-sridevi/following{/other_user}","gists_url":"https://api.github.com/users/aion-sridevi/gists{/gist_id}","starred_url":"https://api.github.com/users/aion-sridevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aion-sridevi/subscriptions","organizations_url":"https://api.github.com/users/aion-sridevi/orgs","repos_url":"https://api.github.com/users/aion-sridevi/repos","events_url":"https://api.github.com/users/aion-sridevi/events{/privacy}","received_events_url":"https://api.github.com/users/aion-sridevi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":812772739,"url":"https://api.github.com/repos/aionnetwork/aion/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/aionnetwork/aion/milestones/3","html_url":"https://github.com/aionnetwork/aion/milestone/3","labels_url":"https://api.github.com/repos/aionnetwork/aion/milestones/3/labels","id":3333371,"number":3,"title":"v0.2.8 - University Peak","description":"","creator":{"login":"AionJayT","id":36162090,"avatar_url":"https://avatars2.githubusercontent.com/u/36162090?v=4","gravatar_id":"","url":"https://api.github.com/users/AionJayT","html_url":"https://github.com/AionJayT","followers_url":"https://api.github.com/users/AionJayT/followers","following_url":"https://api.github.com/users/AionJayT/following{/other_user}","gists_url":"https://api.github.com/users/AionJayT/gists{/gist_id}","starred_url":"https://api.github.com/users/AionJayT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AionJayT/subscriptions","organizations_url":"https://api.github.com/users/AionJayT/orgs","repos_url":"https://api.github.com/users/AionJayT/repos","events_url":"https://api.github.com/users/AionJayT/events{/privacy}","received_events_url":"https://api.github.com/users/AionJayT/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2018-05-09T14:35:44Z","updated_at":"2018-05-22T21:53:11Z","due_on":"2018-06-06T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/aionnetwork/aion/pulls/496/commits","review_comments_url":"https://api.github.com/repos/aionnetwork/aion/pulls/496/comments","review_comment_url":"https://api.github.com/repos/aionnetwork/aion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aionnetwork/aion/issues/496/comments","statuses_url":"https://api.github.com/repos/aionnetwork/aion/statuses/a636001912000e1bafdfaf02fc451dceecf95202","head":{"label":"aionJoey:toggle_logger","ref":"toggle_logger","sha":"a636001912000e1bafdfaf02fc451dceecf95202","user":{"login":"aionJoey","id":39343036,"avatar_url":"https://avatars3.githubusercontent.com/u/39343036?v=4","gravatar_id":"","url":"https://api.github.com/users/aionJoey","html_url":"https://github.com/aionJoey","followers_url":"https://api.github.com/users/aionJoey/followers","following_url":"https://api.github.com/users/aionJoey/following{/other_user}","gists_url":"https://api.github.com/users/aionJoey/gists{/gist_id}","starred_url":"https://api.github.com/users/aionJoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionJoey/subscriptions","organizations_url":"https://api.github.com/users/aionJoey/orgs","repos_url":"https://api.github.com/users/aionJoey/repos","events_url":"https://api.github.com/users/aionJoey/events{/privacy}","received_events_url":"https://api.github.com/users/aionJoey/received_events","type":"User","site_admin":false},"repo":{"id":133837405,"name":"aion","full_name":"aionJoey/aion","owner":{"login":"aionJoey","id":39343036,"avatar_url":"https://avatars3.githubusercontent.com/u/39343036?v=4","gravatar_id":"","url":"https://api.github.com/users/aionJoey","html_url":"https://github.com/aionJoey","followers_url":"https://api.github.com/users/aionJoey/followers","following_url":"https://api.github.com/users/aionJoey/following{/other_user}","gists_url":"https://api.github.com/users/aionJoey/gists{/gist_id}","starred_url":"https://api.github.com/users/aionJoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionJoey/subscriptions","organizations_url":"https://api.github.com/users/aionJoey/orgs","repos_url":"https://api.github.com/users/aionJoey/repos","events_url":"https://api.github.com/users/aionJoey/events{/privacy}","received_events_url":"https://api.github.com/users/aionJoey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aionJoey/aion","description":"aion network","fork":true,"url":"https://api.github.com/repos/aionJoey/aion","forks_url":"https://api.github.com/repos/aionJoey/aion/forks","keys_url":"https://api.github.com/repos/aionJoey/aion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionJoey/aion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionJoey/aion/teams","hooks_url":"https://api.github.com/repos/aionJoey/aion/hooks","issue_events_url":"https://api.github.com/repos/aionJoey/aion/issues/events{/number}","events_url":"https://api.github.com/repos/aionJoey/aion/events","assignees_url":"https://api.github.com/repos/aionJoey/aion/assignees{/user}","branches_url":"https://api.github.com/repos/aionJoey/aion/branches{/branch}","tags_url":"https://api.github.com/repos/aionJoey/aion/tags","blobs_url":"https://api.github.com/repos/aionJoey/aion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionJoey/aion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionJoey/aion/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionJoey/aion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionJoey/aion/statuses/{sha}","languages_url":"https://api.github.com/repos/aionJoey/aion/languages","stargazers_url":"https://api.github.com/repos/aionJoey/aion/stargazers","contributors_url":"https://api.github.com/repos/aionJoey/aion/contributors","subscribers_url":"https://api.github.com/repos/aionJoey/aion/subscribers","subscription_url":"https://api.github.com/repos/aionJoey/aion/subscription","commits_url":"https://api.github.com/repos/aionJoey/aion/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionJoey/aion/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionJoey/aion/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionJoey/aion/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionJoey/aion/contents/{+path}","compare_url":"https://api.github.com/repos/aionJoey/aion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionJoey/aion/merges","archive_url":"https://api.github.com/repos/aionJoey/aion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionJoey/aion/downloads","issues_url":"https://api.github.com/repos/aionJoey/aion/issues{/number}","pulls_url":"https://api.github.com/repos/aionJoey/aion/pulls{/number}","milestones_url":"https://api.github.com/repos/aionJoey/aion/milestones{/number}","notifications_url":"https://api.github.com/repos/aionJoey/aion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionJoey/aion/labels{/name}","releases_url":"https://api.github.com/repos/aionJoey/aion/releases{/id}","deployments_url":"https://api.github.com/repos/aionJoey/aion/deployments","created_at":"2018-05-17T15:59:30Z","updated_at":"2018-05-17T15:59:34Z","pushed_at":"2018-05-22T19:54:53Z","git_url":"git://github.com/aionJoey/aion.git","ssh_url":"git@github.com:aionJoey/aion.git","clone_url":"https://github.com/aionJoey/aion.git","svn_url":"https://github.com/aionJoey/aion","homepage":"https://aion.network/","size":79353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aionnetwork:master-pre-merge","ref":"master-pre-merge","sha":"ba88ae94101de56f436224d246f193031f6a063c","user":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":118477931,"name":"aion","full_name":"aionnetwork/aion","owner":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aionnetwork/aion","description":"aion network","fork":false,"url":"https://api.github.com/repos/aionnetwork/aion","forks_url":"https://api.github.com/repos/aionnetwork/aion/forks","keys_url":"https://api.github.com/repos/aionnetwork/aion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionnetwork/aion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionnetwork/aion/teams","hooks_url":"https://api.github.com/repos/aionnetwork/aion/hooks","issue_events_url":"https://api.github.com/repos/aionnetwork/aion/issues/events{/number}","events_url":"https://api.github.com/repos/aionnetwork/aion/events","assignees_url":"https://api.github.com/repos/aionnetwork/aion/assignees{/user}","branches_url":"https://api.github.com/repos/aionnetwork/aion/branches{/branch}","tags_url":"https://api.github.com/repos/aionnetwork/aion/tags","blobs_url":"https://api.github.com/repos/aionnetwork/aion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionnetwork/aion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionnetwork/aion/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionnetwork/aion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionnetwork/aion/statuses/{sha}","languages_url":"https://api.github.com/repos/aionnetwork/aion/languages","stargazers_url":"https://api.github.com/repos/aionnetwork/aion/stargazers","contributors_url":"https://api.github.com/repos/aionnetwork/aion/contributors","subscribers_url":"https://api.github.com/repos/aionnetwork/aion/subscribers","subscription_url":"https://api.github.com/repos/aionnetwork/aion/subscription","commits_url":"https://api.github.com/repos/aionnetwork/aion/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionnetwork/aion/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionnetwork/aion/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionnetwork/aion/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionnetwork/aion/contents/{+path}","compare_url":"https://api.github.com/repos/aionnetwork/aion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionnetwork/aion/merges","archive_url":"https://api.github.com/repos/aionnetwork/aion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionnetwork/aion/downloads","issues_url":"https://api.github.com/repos/aionnetwork/aion/issues{/number}","pulls_url":"https://api.github.com/repos/aionnetwork/aion/pulls{/number}","milestones_url":"https://api.github.com/repos/aionnetwork/aion/milestones{/number}","notifications_url":"https://api.github.com/repos/aionnetwork/aion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionnetwork/aion/labels{/name}","releases_url":"https://api.github.com/repos/aionnetwork/aion/releases{/id}","deployments_url":"https://api.github.com/repos/aionnetwork/aion/deployments","created_at":"2018-01-22T15:46:23Z","updated_at":"2018-05-22T16:30:11Z","pushed_at":"2018-05-22T21:28:26Z","git_url":"git://github.com/aionnetwork/aion.git","ssh_url":"git@github.com:aionnetwork/aion.git","clone_url":"https://github.com/aionnetwork/aion.git","svn_url":"https://github.com/aionnetwork/aion","homepage":"https://aion.network/","size":79512,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":58,"open_issues":32,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/496"},"html":{"href":"https://github.com/aionnetwork/aion/pull/496"},"issue":{"href":"https://api.github.com/repos/aionnetwork/aion/issues/496"},"comments":{"href":"https://api.github.com/repos/aionnetwork/aion/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/aionnetwork/aion/statuses/a636001912000e1bafdfaf02fc451dceecf95202"}},"author_association":"NONE"}}
{"actor":{"display_login":"qoire"}}