{"action":"created","issue":{"url":"https://api.github.com/repos/rll/rllab/issues/215","repository_url":"https://api.github.com/repos/rll/rllab","labels_url":"https://api.github.com/repos/rll/rllab/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/rll/rllab/issues/215/comments","events_url":"https://api.github.com/repos/rll/rllab/issues/215/events","html_url":"https://github.com/rll/rllab/pull/215","id":297293411,"number":215,"title":"Enable more than one MjViewer instance at a time","user":{"login":"ryanjulian","id":1376219,"avatar_url":"https://avatars3.githubusercontent.com/u/1376219?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjulian","html_url":"https://github.com/ryanjulian","followers_url":"https://api.github.com/users/ryanjulian/followers","following_url":"https://api.github.com/users/ryanjulian/following{/other_user}","gists_url":"https://api.github.com/users/ryanjulian/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjulian/subscriptions","organizations_url":"https://api.github.com/users/ryanjulian/orgs","repos_url":"https://api.github.com/users/ryanjulian/repos","events_url":"https://api.github.com/users/ryanjulian/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjulian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-15T00:26:15Z","updated_at":"2018-02-27T23:58:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rll/rllab/pulls/215","html_url":"https://github.com/rll/rllab/pull/215","diff_url":"https://github.com/rll/rllab/pull/215.diff","patch_url":"https://github.com/rll/rllab/pull/215.patch"},"body":"This PR contains a feature and a bug fix which allow an rllab user to open more than one MjViewer window at a time.\r\n\r\n**Bug fix**\r\nMjViewer assumes that, once set during MjViewer.start(), the glfw context never changes. This is not true for multiple windows, which share a global glfw context. Each window needs to switch the glfw context to its own window during rendering.\r\n\r\n**Feature**\r\nAdd a kwarg to MjViewer which allows the user to change the window title (useful if you're opening more than one).\r\n\r\nBoth of these could be solved by upgrading mujoco-py to 1.0+, a project I may take on later. For now, these fixes suffice."},"comment":{"url":"https://api.github.com/repos/rll/rllab/issues/comments/369070848","html_url":"https://github.com/rll/rllab/pull/215#issuecomment-369070848","issue_url":"https://api.github.com/repos/rll/rllab/issues/215","id":369070848,"user":{"login":"ryanjulian","id":1376219,"avatar_url":"https://avatars3.githubusercontent.com/u/1376219?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjulian","html_url":"https://github.com/ryanjulian","followers_url":"https://api.github.com/users/ryanjulian/followers","following_url":"https://api.github.com/users/ryanjulian/following{/other_user}","gists_url":"https://api.github.com/users/ryanjulian/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjulian/subscriptions","organizations_url":"https://api.github.com/users/ryanjulian/orgs","repos_url":"https://api.github.com/users/ryanjulian/repos","events_url":"https://api.github.com/users/ryanjulian/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjulian/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T23:58:18Z","updated_at":"2018-02-27T23:58:18Z","author_association":"NONE","body":"Closing this to move the commits to a different branch. Will reopen."}}
{"actor":{"display_login":"ryanjulian"}}