{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/193727470","pull_request_review_id":126756407,"id":193727470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzcyNzQ3MA==","diff_hunk":"@@ -67,7 +70,14 @@ export function makePreparePostIdsForPostList() {\n \n                 // Only add the new messages line if a lastViewedAt time is set\n                 const postIsUnread = post.create_at > lastViewedAt && post.user_id !== currentUser.id;\n-                if (lastViewedAt !== null && !addedNewMessagesIndicator && postIsUnread && indicateNewMessages) {\n+\n+                if (\n+                    !isSystemMessage(post) &&","path":"app/selectors/post_list.js","position":null,"original_position":19,"commit_id":"19ed1feb3aa0f32b595db7b20547a9c6c1c07656","original_commit_id":"e9af56431142a41d4799431d099d833a4c27229a","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"Oh right, I forgot that there are also other system messages.\r\n\r\nI've updated this PR setting post as unread when lastViewedAt is `0` (which usually means new user of a channel) and the post type is `system_combined_user_activity`.","created_at":"2018-06-07T12:28:27Z","updated_at":"2018-06-07T12:28:27Z","html_url":"https://github.com/mattermost/mattermost-mobile/pull/1710#discussion_r193727470","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/193727470"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/1710#discussion_r193727470"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710"}},"in_reply_to_id":193403941},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710","id":190955288,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTU1Mjg4","html_url":"https://github.com/mattermost/mattermost-mobile/pull/1710","diff_url":"https://github.com/mattermost/mattermost-mobile/pull/1710.diff","patch_url":"https://github.com/mattermost/mattermost-mobile/pull/1710.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1710","number":1710,"state":"open","locked":false,"title":"MM-10340 Fix \"More New Messages Above\" that appears on top of the channel after joining","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n~~Replace \"More New Messages Above\" with \"New Messages\" that appears on top of the channel after joining.~~\r\n\r\nUpdate: The behavior is similar to webapp where there is no \"New Messages\" separator whenever a user created/joined/added to a channel.\r\n\r\nNote:\r\n- will rebase to latest once https://github.com/mattermost/mattermost-mobile/pull/1708 is merged.\r\n- attempted to add test but looks complicated at the moment. We might need to break large components (like `PostList`) into smaller and testable components.\r\n\r\n#### Ticket Link\r\nJira ticket: [MM-10340](https://mattermost.atlassian.net/browse/MM-10340)\r\n\r\n#### Device Information\r\nThis PR was tested on: [iOS simulator and Android emulator] \r\n\r\n#### Screenshots\r\n![screen shot 2018-05-28 at 11 08 50 pm](https://user-images.githubusercontent.com/5334504/40620905-2c47534c-62cd-11e8-8088-3a6f5f9f0609.png)\r\n\r\n","created_at":"2018-05-28T15:21:09Z","updated_at":"2018-06-07T12:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3663cff0ae0fd65232a146fbef6f7bdf21d63be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":460355330,"node_id":"MDU6TGFiZWw0NjAzNTUzMzA=","url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/9","html_url":"https://github.com/mattermost/mattermost-mobile/milestone/9","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/9/labels","id":3280750,"node_id":"MDk6TWlsZXN0b25lMzI4MDc1MA==","number":9,"title":"1.9","description":"","creator":{"login":"enahum","id":6757047,"node_id":"MDQ6VXNlcjY3NTcwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":43,"state":"open","created_at":"2018-04-19T11:07:00Z","updated_at":"2018-06-06T20:57:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1710/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/19ed1feb3aa0f32b595db7b20547a9c6c1c07656","head":{"label":"saturninoabril:MM-10340","ref":"MM-10340","sha":"19ed1feb3aa0f32b595db7b20547a9c6c1c07656","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"repo":{"id":82983247,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk4MzI0Nw==","name":"mattermost-mobile","full_name":"saturninoabril/mattermost-mobile","owner":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saturninoabril/mattermost-mobile","description":null,"fork":true,"url":"https://api.github.com/repos/saturninoabril/mattermost-mobile","forks_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/deployments","created_at":"2017-02-23T23:59:11Z","updated_at":"2018-06-07T01:08:58Z","pushed_at":"2018-06-07T12:22:44Z","git_url":"git://github.com/saturninoabril/mattermost-mobile.git","ssh_url":"git@github.com:saturninoabril/mattermost-mobile.git","clone_url":"https://github.com/saturninoabril/mattermost-mobile.git","svn_url":"https://github.com/saturninoabril/mattermost-mobile","homepage":null,"size":17044,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:release-1.9","ref":"release-1.9","sha":"b3f643d3153ca91d124b7497590f2d3791a67d9c","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"node_id":"MDEwOlJlcG9zaXRvcnk3MDI2NTcyNA==","name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2018-06-06T19:36:55Z","pushed_at":"2018-06-07T12:22:46Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":18090,"stargazers_count":430,"watchers_count":430,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":183,"open_issues":24,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/1710"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1710"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1710/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1710/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/19ed1feb3aa0f32b595db7b20547a9c6c1c07656"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"saturninoabril"}}