{"push_id":2479794626,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"70b33f195b0d76e140921db40c0bea5a7c9abc42","before":"436411b1c6cb93541fd502321cf5470fe0392b91","commits":[{"sha":"70b33f195b0d76e140921db40c0bea5a7c9abc42","author":{"name":"Pedro Alves","email":"c495fe4dba026c81f120733ccce155c132d5c6ba@redhat.com"},"message":"Fix Solaris build\n\nThis commit fixes a bit of rot in procfs.c caused by recent changes.\n\nSpecifically, the target_ops::to_detach change to pass down 'inferior\n*' missed updating a forward declation, and the change to use\nscoped_fd in more places missed removing one do_cleanups call.\n\n  src/gdb/procfs.c: In function ‘target_ops* procfs_target()’:\n  src/gdb/procfs.c:167:16: error: invalid conversion from ‘void (*)(target_ops*, const char*, int)’ to ‘void (*)(target_ops*, inferior*, int)’ [-fpermissive]\n     t->to_detach = procfs_detach;\n\t\t  ^\n  src/gdb/procfs.c: In function ‘ssd* proc_get_LDT_entry(procinfo*, int)’:\n  src/gdb/procfs.c:1624:17: error: ‘old_chain’ was not declared in this scope\n      do_cleanups (old_chain);\n\t\t   ^\n  src/gdb/procfs.c: At global scope:\n  src/gdb/procfs.c:90:13: error: ‘void procfs_detach(target_ops*, const char*, int)’ declared ‘static’ but never defined [-Werror=unused-function]\n   static void procfs_detach (struct target_ops *, const char *, int);\n\t       ^\n  src/gdb/procfs.c:1923:1: error: ‘void procfs_detach(target_ops*, inferior*, int)’ defined but not used [-Werror=unused-function]\n   procfs_detach (struct target_ops *ops, inferior *inf, int from_tty)\n   ^\n\ngdb/ChangeLog:\n2018-04-12  Pedro Alves  <palves@redhat.com>\n\n\t* procfs.c (procfs_detach): Make forward declaration's prototype\n\tmatch definition's protototype.\n\t(proc_get_LDT_entry): Remove stale do_cleanups call.","distinct":true,"url":"https://api.github.com/repos/wallento/binutils-gdb/commits/70b33f195b0d76e140921db40c0bea5a7c9abc42"}]}
{"actor":{"display_login":"wallento"}}