{"action":"closed","issue":{"url":"https://api.github.com/repos/JamesHeinrich/phpThumb/issues/122","repository_url":"https://api.github.com/repos/JamesHeinrich/phpThumb","labels_url":"https://api.github.com/repos/JamesHeinrich/phpThumb/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/JamesHeinrich/phpThumb/issues/122/comments","events_url":"https://api.github.com/repos/JamesHeinrich/phpThumb/issues/122/events","html_url":"https://github.com/JamesHeinrich/phpThumb/issues/122","id":339728212,"node_id":"MDU6SXNzdWUzMzk3MjgyMTI=","number":122,"title":"Old Safari bug with $_SERVER['QUERY_STRING']","user":{"login":"badbadmonkey","id":40988021,"node_id":"MDQ6VXNlcjQwOTg4MDIx","avatar_url":"https://avatars3.githubusercontent.com/u/40988021?v=4","gravatar_id":"","url":"https://api.github.com/users/badbadmonkey","html_url":"https://github.com/badbadmonkey","followers_url":"https://api.github.com/users/badbadmonkey/followers","following_url":"https://api.github.com/users/badbadmonkey/following{/other_user}","gists_url":"https://api.github.com/users/badbadmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/badbadmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badbadmonkey/subscriptions","organizations_url":"https://api.github.com/users/badbadmonkey/orgs","repos_url":"https://api.github.com/users/badbadmonkey/repos","events_url":"https://api.github.com/users/badbadmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/badbadmonkey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-10T07:42:37Z","updated_at":"2018-07-10T18:11:06Z","closed_at":"2018-07-10T18:11:06Z","author_association":"NONE","body":"Current version phpThumb.php line 200\r\n\r\n`elseif ($_GET['hash'] != md5(str_replace($phpThumb->config_high_security_url_separator.'hash='.$_GET['hash'], '', $_SERVER['QUERY_STRING']).$phpThumb->config_high_security_password))`\r\n\r\nYears ago I had hacked this to urldecode() QUERY_STRING ...\r\n\r\n`elseif ($_GET['hash'] != md5(str_replace($phpThumb->config_high_security_url_separator.'hash='.$_GET['hash'], '', urldecode($_SERVER['QUERY_STRING'])).$phpThumb->config_high_security_password))`\r\n\r\n... because of a weird bug I was seeing on Safari at the time to do with the provided value of QUERY_STRING from the browser. It's probably not a bug in newer versions but is there any harm in leaving it in?\r\n\r\nEdit: The above breaks current version with an error that seems to relate to invalid hash, but I'll leave this here as a query in case the old Safari versions are still affected."}}
{"actor":{"display_login":"JamesHeinrich"}}