{"action":"created","issue":{"url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/125","repository_url":"https://api.github.com/repos/patrick-steele-idem/morphdom","labels_url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/125/comments","events_url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/125/events","html_url":"https://github.com/patrick-steele-idem/morphdom/pull/125","id":315598935,"number":125,"title":"fixed namespaced attributes not updating","user":{"login":"AndyOGo","id":914443,"avatar_url":"https://avatars1.githubusercontent.com/u/914443?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyOGo","html_url":"https://github.com/AndyOGo","followers_url":"https://api.github.com/users/AndyOGo/followers","following_url":"https://api.github.com/users/AndyOGo/following{/other_user}","gists_url":"https://api.github.com/users/AndyOGo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyOGo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyOGo/subscriptions","organizations_url":"https://api.github.com/users/AndyOGo/orgs","repos_url":"https://api.github.com/users/AndyOGo/repos","events_url":"https://api.github.com/users/AndyOGo/events{/privacy}","received_events_url":"https://api.github.com/users/AndyOGo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-18T18:48:09Z","updated_at":"2018-04-20T12:33:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/patrick-steele-idem/morphdom/pulls/125","html_url":"https://github.com/patrick-steele-idem/morphdom/pull/125","diff_url":"https://github.com/patrick-steele-idem/morphdom/pull/125.diff","patch_url":"https://github.com/patrick-steele-idem/morphdom/pull/125.patch"},"body":"fixes #124 \r\n\r\nUsing SVG sprites with `<use xlink:href=\"\" />` will not update the icon.\r\n\r\nThe reason is that `getAttributeNS` and `setAttributeNS` DOM APIs are inconsistent in it's arguments.\r\nE.g.: lets say 'foo:bar' ('foo' being the namespace and 'bar' the local attribute name):\r\n- `getAttributeNS` only needs the `localName`, i.e. `getAttributeNS('https://www.w3.org/1999/foo', 'bar');`\r\n   > [`getAttributeNS(namespace, localName)`](https://dom.spec.whatwg.org/#dom-element-getattributens)\r\n   > https://www.w3.org/TR/DOM-Level-2-Core/glossary.html#dt-localname\r\n   > A local name is the local part of a qualified name. This is called the local part in Namespaces in XML [Namespaces].\r\n- **BUT** `setAttributeNS` expects it's fully qualified name, i.e. `setAttributeNS('https://www.w3.org/1999/foo', 'foo:bar');`\r\n   > [`setAttributeNS(namespace, qualifiedName, value)`](https://dom.spec.whatwg.org/#dom-element-setattributens)\r\n   > https://www.w3.org/TR/DOM-Level-2-Core/glossary.html#dt-qualifiedname\r\n   > A qualified name is the name of an element or attribute defined as the concatenation of a local name (as defined in this specification), optionally preceded by a namespace prefix and colon character. See Qualified Names in Namespaces in XML [Namespaces]."},"comment":{"url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/comments/383081356","html_url":"https://github.com/patrick-steele-idem/morphdom/pull/125#issuecomment-383081356","issue_url":"https://api.github.com/repos/patrick-steele-idem/morphdom/issues/125","id":383081356,"user":{"login":"AutoSponge","id":654530,"avatar_url":"https://avatars0.githubusercontent.com/u/654530?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoSponge","html_url":"https://github.com/AutoSponge","followers_url":"https://api.github.com/users/AutoSponge/followers","following_url":"https://api.github.com/users/AutoSponge/following{/other_user}","gists_url":"https://api.github.com/users/AutoSponge/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoSponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoSponge/subscriptions","organizations_url":"https://api.github.com/users/AutoSponge/orgs","repos_url":"https://api.github.com/users/AutoSponge/repos","events_url":"https://api.github.com/users/AutoSponge/events{/privacy}","received_events_url":"https://api.github.com/users/AutoSponge/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T12:33:16Z","updated_at":"2018-04-20T12:33:16Z","author_association":"COLLABORATOR","body":"@AndyOGo is it possible to demonstrate this with a test (one that fails under current version but passes under proposed)?\r\n\r\nI know @patrick-steele-idem changed jobs recently, so he may not have the time to look into this."}}
{"actor":{"display_login":"AutoSponge"}}