{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/181590526","pull_request_review_id":112245233,"id":181590526,"diff_hunk":"@@ -7,50 +7,75 @@ import { inject, injectable } from 'inversify';\n import { Uri } from 'vscode';\n import { IPlatformService } from '../../common/platform/types';\n import { IServiceContainer } from '../../ioc/types';\n-import { DebugOptions } from '../Common/Contracts';\n+import { AttachRequestArguments, DebugOptions, LaunchRequestArguments } from '../Common/Contracts';\n import { BaseConfigurationProvider, PythonAttachDebugConfiguration, PythonLaunchDebugConfiguration } from './baseProvider';\n \n @injectable()\n-export class PythonV2DebugConfigurationProvider extends BaseConfigurationProvider {\n+export class PythonV2DebugConfigurationProvider extends BaseConfigurationProvider<LaunchRequestArguments, AttachRequestArguments> {\n     constructor(@inject(IServiceContainer) serviceContainer: IServiceContainer) {\n         super('pythonExperimental', serviceContainer);\n     }\n-    protected provideLaunchDefaults(workspaceFolder: Uri, debugConfiguration: PythonLaunchDebugConfiguration): void {\n+    protected provideLaunchDefaults(workspaceFolder: Uri, debugConfiguration: PythonLaunchDebugConfiguration<LaunchRequestArguments>): void {\n         super.provideLaunchDefaults(workspaceFolder, debugConfiguration);\n-\n-        debugConfiguration.stopOnEntry = false;\n-        debugConfiguration.debugOptions = Array.isArray(debugConfiguration.debugOptions) ? debugConfiguration.debugOptions : [];\n-\n-        // Add PTVSD specific flags.\n+        const debugOptions = debugConfiguration.debugOptions!;\n+        if (debugConfiguration.debugStdLib) {\n+            debugOptions.push(DebugOptions.DebugStdLib);\n+        }\n+        if (debugConfiguration.django) {\n+            debugOptions.push(DebugOptions.Django);\n+        }\n+        if (debugConfiguration.jinja) {\n+            debugOptions.push(DebugOptions.Jinja);\n+        }\n+        if (debugConfiguration.redirectOutput) {\n+            debugOptions.push(DebugOptions.RedirectOutput);\n+        }\n+        if (debugConfiguration.sudo) {\n+            debugOptions.push(DebugOptions.Sudo);\n+        }\n         if (this.serviceContainer.get<IPlatformService>(IPlatformService).isWindows) {\n-            debugConfiguration.debugOptions.push(DebugOptions.FixFilePathCase);\n+            debugOptions.push(DebugOptions.FixFilePathCase);\n         }\n         if (debugConfiguration.module && debugConfiguration.module.toUpperCase() === 'FLASK'\n-            && debugConfiguration.debugOptions.indexOf(DebugOptions.Jinja) === -1) {\n-            debugConfiguration.debugOptions.push(DebugOptions.Jinja);\n+            && debugOptions.indexOf(DebugOptions.Jinja) === -1\n+            && debugConfiguration.jinja !== false) {\n+            debugOptions.push(DebugOptions.Jinja);","path":"src/client/debugger/configProviders/pythonV2Provider.ts","position":47,"original_position":47,"commit_id":"b4913384c051932b79ae147428d0aad4436f0aa0","original_commit_id":"b4913384c051932b79ae147428d0aad4436f0aa0","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"OK to push twice?","created_at":"2018-04-15T17:26:30Z","updated_at":"2018-04-15T17:26:30Z","html_url":"https://github.com/Microsoft/vscode-python/pull/1395#discussion_r181590526","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/181590526"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/1395#discussion_r181590526"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395","id":181550224,"html_url":"https://github.com/Microsoft/vscode-python/pull/1395","diff_url":"https://github.com/Microsoft/vscode-python/pull/1395.diff","patch_url":"https://github.com/Microsoft/vscode-python/pull/1395.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/1395","number":1395,"state":"open","locked":false,"title":"WIP - Change how debug options are captured in launch.json","user":{"login":"DonJayamanne","id":1948812,"avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"body":"Fixes #1326\r\n\r\nThis pull request:\r\n- [ ] Has a title summarizes what is changing\r\n- [ ] Includes a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)\r\n- [ ] Has unit tests & [code coverage](https://codecov.io/gh/Microsoft/vscode-python) is not adversely affected (within reason)\r\n- [ ] Works on all [actively maintained versions of Python](https://devguide.python.org/#status-of-python-branches) (e.g. Python 2.7 & the latest Python 3 release)\r\n- [ ] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)\r\n","created_at":"2018-04-13T17:28:33Z","updated_at":"2018-04-15T17:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e668663a7a1d05ac2b9c5dcffe20d929ea2f1f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/1395/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/b4913384c051932b79ae147428d0aad4436f0aa0","head":{"label":"DonJayamanne:issue1326DebugOptions","ref":"issue1326DebugOptions","sha":"b4913384c051932b79ae147428d0aad4436f0aa0","user":{"login":"DonJayamanne","id":1948812,"avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"repo":{"id":49946255,"name":"pythonVSCode","full_name":"DonJayamanne/pythonVSCode","owner":{"login":"DonJayamanne","id":1948812,"avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DonJayamanne/pythonVSCode","description":"This extension is now maintained in the Microsoft fork.","fork":false,"url":"https://api.github.com/repos/DonJayamanne/pythonVSCode","forks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/forks","keys_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/teams","hooks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/hooks","issue_events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/events{/number}","events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/events","assignees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/assignees{/user}","branches_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/branches{/branch}","tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/tags","blobs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/statuses/{sha}","languages_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/languages","stargazers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/stargazers","contributors_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contributors","subscribers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscribers","subscription_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscription","commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contents/{+path}","compare_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/merges","archive_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/downloads","issues_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues{/number}","pulls_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/pulls{/number}","milestones_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/milestones{/number}","notifications_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/labels{/name}","releases_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/releases{/id}","deployments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/deployments","created_at":"2016-01-19T10:50:01Z","updated_at":"2018-04-14T07:01:31Z","pushed_at":"2018-04-13T20:05:19Z","git_url":"git://github.com/DonJayamanne/pythonVSCode.git","ssh_url":"git@github.com:DonJayamanne/pythonVSCode.git","clone_url":"https://github.com/DonJayamanne/pythonVSCode.git","svn_url":"https://github.com/DonJayamanne/pythonVSCode","homepage":"https://github.com/Microsoft/vscode-python","size":59358,"stargazers_count":1797,"watchers_count":1797,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":304,"open_issues":10,"watchers":1797,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7cd5095401f2226430125b7ffd9bc882fe9d7802","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"name":"vscode-python","full_name":"Microsoft/vscode-python","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2018-04-15T08:59:13Z","pushed_at":"2018-04-14T00:52:33Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":56761,"stargazers_count":508,"watchers_count":508,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":79,"open_issues":344,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/1395"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/1395"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/1395/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/1395/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-python/statuses/b4913384c051932b79ae147428d0aad4436f0aa0"}},"author_association":"NONE"}}
{"actor":{"display_login":"MikhailArkhipov"}}