{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/223","repository_url":"https://api.github.com/repos/kubevirt/containerized-data-importer","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/223/comments","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/223/events","html_url":"https://github.com/kubevirt/containerized-data-importer/issues/223","id":335859708,"node_id":"MDU6SXNzdWUzMzU4NTk3MDg=","number":223,"title":"Provide a jinja2 template for the cdi manifest","user":{"login":"dcritch","id":7536000,"node_id":"MDQ6VXNlcjc1MzYwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7536000?v=4","gravatar_id":"","url":"https://api.github.com/users/dcritch","html_url":"https://github.com/dcritch","followers_url":"https://api.github.com/users/dcritch/followers","following_url":"https://api.github.com/users/dcritch/following{/other_user}","gists_url":"https://api.github.com/users/dcritch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcritch/subscriptions","organizations_url":"https://api.github.com/users/dcritch/orgs","repos_url":"https://api.github.com/users/dcritch/repos","events_url":"https://api.github.com/users/dcritch/events{/privacy}","received_events_url":"https://api.github.com/users/dcritch/received_events","type":"User","site_admin":false},"labels":[{"id":806957634,"node_id":"MDU6TGFiZWw4MDY5NTc2MzQ=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-26T14:54:53Z","updated_at":"2018-06-27T19:52:21Z","closed_at":null,"author_association":"NONE","body":"Similar to the request for a j2 version of the kubevirt manifest [0], it would be sweet if we could also get a jinja2 template for the cdi manifest. The work being done to create one for kubevirt [1] likely can be re-used for cdi.\r\n\r\n[0] https://github.com/kubevirt/kubevirt/issues/966\r\n[1] https://github.com/kubevirt/kubevirt/pull/1116\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/comments/400808031","html_url":"https://github.com/kubevirt/containerized-data-importer/issues/223#issuecomment-400808031","issue_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/223","id":400808031,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDgwODAzMQ==","user":{"login":"dcritch","id":7536000,"node_id":"MDQ6VXNlcjc1MzYwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7536000?v=4","gravatar_id":"","url":"https://api.github.com/users/dcritch","html_url":"https://github.com/dcritch","followers_url":"https://api.github.com/users/dcritch/followers","following_url":"https://api.github.com/users/dcritch/following{/other_user}","gists_url":"https://api.github.com/users/dcritch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcritch/subscriptions","organizations_url":"https://api.github.com/users/dcritch/orgs","repos_url":"https://api.github.com/users/dcritch/repos","events_url":"https://api.github.com/users/dcritch/events{/privacy}","received_events_url":"https://api.github.com/users/dcritch/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T19:52:21Z","updated_at":"2018-06-27T19:52:21Z","author_association":"NONE","body":"That's originally what kubevirt-ansible was doing with kubevirt. While technically possible, it ends up being a messy hack with a bunch of sed's. \r\n\r\nI played around with a go to jinja2 converter and it seemed to work okay, but the issue was more about when to/what triggers that conversion. We'd have to track kubevirt (and cdi) to check for a new release so the j2 could be built.\r\n\r\n@rmohr has a great extension to kubevirt's go template builder script that takes care of jinja2. How are the go templates in cdi being built now? Could a similar set of commands be bolted on to it? I dug around the cdi repo and couldn't immediately see it. I'd be happy to help if pointed to the right spot."}}
{"actor":{"display_login":"dcritch"}}