{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/210061017","pull_request_review_id":146199037,"id":210061017,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA2MTAxNw==","diff_hunk":"@@ -28,12 +32,16 @@ stdenv.mkDerivation rec {\n     \"--disable-fma\"\n     \"--disable-fma4\"\n   ];\n-  doCheck = true;\n+\n+  # needed for darwin\n+  doInstallCheck = true;\n+  installCheckTarget = \"check\";","path":"pkgs/development/libraries/givaro/default.nix","position":21,"original_position":21,"commit_id":"d22d9aa62bde0073f0bb4865ea0b5da5b3490093","original_commit_id":"d22d9aa62bde0073f0bb4865ea0b5da5b3490093","user":{"login":"mpickering","id":1216657,"node_id":"MDQ6VXNlcjEyMTY2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"body":"What do these do out of interest that makes it work?","created_at":"2018-08-14T18:41:01Z","updated_at":"2018-08-14T18:41:02Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45001#discussion_r210061017","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/210061017"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45001#discussion_r210061017"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001","id":208137641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTM3NjQx","html_url":"https://github.com/NixOS/nixpkgs/pull/45001","diff_url":"https://github.com/NixOS/nixpkgs/pull/45001.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45001.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45001","number":45001,"state":"open","locked":false,"title":"givaro: Add darwin support","user":{"login":"jbaum98","id":5283991,"node_id":"MDQ6VXNlcjUyODM5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5283991?v=4","gravatar_id":"","url":"https://api.github.com/users/jbaum98","html_url":"https://github.com/jbaum98","followers_url":"https://api.github.com/users/jbaum98/followers","following_url":"https://api.github.com/users/jbaum98/following{/other_user}","gists_url":"https://api.github.com/users/jbaum98/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaum98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaum98/subscriptions","organizations_url":"https://api.github.com/users/jbaum98/orgs","repos_url":"https://api.github.com/users/jbaum98/repos","events_url":"https://api.github.com/users/jbaum98/events{/privacy}","received_events_url":"https://api.github.com/users/jbaum98/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-14T00:15:07Z","updated_at":"2018-08-14T18:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4c761d287e832da29564101b6eb7186dd375226","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":90308187,"node_id":"MDU6TGFiZWw5MDMwODE4Nw==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20darwin","name":"6.topic: darwin","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45001/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d22d9aa62bde0073f0bb4865ea0b5da5b3490093","head":{"label":"jbaum98:givaro-darwin","ref":"givaro-darwin","sha":"d22d9aa62bde0073f0bb4865ea0b5da5b3490093","user":{"login":"jbaum98","id":5283991,"node_id":"MDQ6VXNlcjUyODM5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5283991?v=4","gravatar_id":"","url":"https://api.github.com/users/jbaum98","html_url":"https://github.com/jbaum98","followers_url":"https://api.github.com/users/jbaum98/followers","following_url":"https://api.github.com/users/jbaum98/following{/other_user}","gists_url":"https://api.github.com/users/jbaum98/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaum98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaum98/subscriptions","organizations_url":"https://api.github.com/users/jbaum98/orgs","repos_url":"https://api.github.com/users/jbaum98/repos","events_url":"https://api.github.com/users/jbaum98/events{/privacy}","received_events_url":"https://api.github.com/users/jbaum98/received_events","type":"User","site_admin":false},"repo":{"id":79291010,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI5MTAxMA==","name":"nixpkgs","full_name":"jbaum98/nixpkgs","owner":{"login":"jbaum98","id":5283991,"node_id":"MDQ6VXNlcjUyODM5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5283991?v=4","gravatar_id":"","url":"https://api.github.com/users/jbaum98","html_url":"https://github.com/jbaum98","followers_url":"https://api.github.com/users/jbaum98/followers","following_url":"https://api.github.com/users/jbaum98/following{/other_user}","gists_url":"https://api.github.com/users/jbaum98/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaum98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaum98/subscriptions","organizations_url":"https://api.github.com/users/jbaum98/orgs","repos_url":"https://api.github.com/users/jbaum98/repos","events_url":"https://api.github.com/users/jbaum98/events{/privacy}","received_events_url":"https://api.github.com/users/jbaum98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbaum98/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/jbaum98/nixpkgs","forks_url":"https://api.github.com/repos/jbaum98/nixpkgs/forks","keys_url":"https://api.github.com/repos/jbaum98/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbaum98/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbaum98/nixpkgs/teams","hooks_url":"https://api.github.com/repos/jbaum98/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/jbaum98/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/jbaum98/nixpkgs/events","assignees_url":"https://api.github.com/repos/jbaum98/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/jbaum98/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/jbaum98/nixpkgs/tags","blobs_url":"https://api.github.com/repos/jbaum98/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbaum98/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbaum98/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbaum98/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbaum98/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/jbaum98/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/jbaum98/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/jbaum98/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/jbaum98/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/jbaum98/nixpkgs/subscription","commits_url":"https://api.github.com/repos/jbaum98/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbaum98/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbaum98/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbaum98/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbaum98/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/jbaum98/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbaum98/nixpkgs/merges","archive_url":"https://api.github.com/repos/jbaum98/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbaum98/nixpkgs/downloads","issues_url":"https://api.github.com/repos/jbaum98/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/jbaum98/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/jbaum98/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/jbaum98/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbaum98/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/jbaum98/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/jbaum98/nixpkgs/deployments","created_at":"2017-01-18T01:33:09Z","updated_at":"2018-08-09T23:23:38Z","pushed_at":"2018-08-14T15:35:01Z","git_url":"git://github.com/jbaum98/nixpkgs.git","ssh_url":"git@github.com:jbaum98/nixpkgs.git","clone_url":"https://github.com/jbaum98/nixpkgs.git","svn_url":"https://github.com/jbaum98/nixpkgs","homepage":null,"size":743666,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2d1316ec41d4e57fc52c9f5a0cf486dd502c751c","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-14T18:14:13Z","pushed_at":"2018-08-14T18:24:36Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":835541,"stargazers_count":2662,"watchers_count":2662,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2946,"mirror_url":null,"archived":false,"open_issues_count":3112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2946,"open_issues":3112,"watchers":2662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45001"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45001"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45001/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45001/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d22d9aa62bde0073f0bb4865ea0b5da5b3490093"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpickering"}}