{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/181785744","pull_request_review_id":112470498,"id":181785744,"diff_hunk":"@@ -647,6 +647,32 @@ int _odp_fdserver_init_global(void)\n \t}\n \n \tif (server_pid == 0) { /*child */\n+\t\tsigset_t sigset;\n+\t\tstruct sigaction action;","path":"platform/linux-generic/odp_fdserver.c","position":5,"original_position":5,"commit_id":"93c9d3b8059e255ef555c4bec78e8e3d2851c7d8","original_commit_id":"93c9d3b8059e255ef555c4bec78e8e3d2851c7d8","user":{"login":"JannePeltonen","id":29461179,"avatar_url":"https://avatars1.githubusercontent.com/u/29461179?v=4","gravatar_id":"","url":"https://api.github.com/users/JannePeltonen","html_url":"https://github.com/JannePeltonen","followers_url":"https://api.github.com/users/JannePeltonen/followers","following_url":"https://api.github.com/users/JannePeltonen/following{/other_user}","gists_url":"https://api.github.com/users/JannePeltonen/gists{/gist_id}","starred_url":"https://api.github.com/users/JannePeltonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JannePeltonen/subscriptions","organizations_url":"https://api.github.com/users/JannePeltonen/orgs","repos_url":"https://api.github.com/users/JannePeltonen/repos","events_url":"https://api.github.com/users/JannePeltonen/events{/privacy}","received_events_url":"https://api.github.com/users/JannePeltonen/received_events","type":"User","site_admin":false},"body":"Parts of this struct may be left uninitialized. I would suggest memset(&action, 0, sizeof(action)) at some point before the sigaction call.","created_at":"2018-04-16T15:34:30Z","updated_at":"2018-04-16T15:34:30Z","html_url":"https://github.com/Linaro/odp/pull/562#discussion_r181785744","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/562","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/181785744"},"html":{"href":"https://github.com/Linaro/odp/pull/562#discussion_r181785744"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/562"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/562","id":181844591,"html_url":"https://github.com/Linaro/odp/pull/562","diff_url":"https://github.com/Linaro/odp/pull/562.diff","patch_url":"https://github.com/Linaro/odp/pull/562.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/562","number":562,"state":"open","locked":false,"title":"fdserver: prevent process from handling some signals","user":{"login":"joseppc","id":137580,"avatar_url":"https://avatars3.githubusercontent.com/u/137580?v=4","gravatar_id":"","url":"https://api.github.com/users/joseppc","html_url":"https://github.com/joseppc","followers_url":"https://api.github.com/users/joseppc/followers","following_url":"https://api.github.com/users/joseppc/following{/other_user}","gists_url":"https://api.github.com/users/joseppc/gists{/gist_id}","starred_url":"https://api.github.com/users/joseppc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseppc/subscriptions","organizations_url":"https://api.github.com/users/joseppc/orgs","repos_url":"https://api.github.com/users/joseppc/repos","events_url":"https://api.github.com/users/joseppc/events{/privacy}","received_events_url":"https://api.github.com/users/joseppc/received_events","type":"User","site_admin":false},"body":"Make fdserver block all signals, so it won't receive signals sent to the\r\nprocess group, which may interfere with the normal operation of the\r\napplication.\r\nAll signals are blocked except those that we want to handle (SIGTERM),\r\nor those that can't be blocked, or those for which ignoring them results\r\nin undefined behavior.\r\n\r\nThis patch fixes: https://bugs.linaro.org/show_bug.cgi?id=3690\r\n\r\nSigned-off-by: Josep Puigdemont <josep.puigdemont@linaro.org>","created_at":"2018-04-16T12:29:11Z","updated_at":"2018-04-16T15:34:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37e010c85a6417172a3459c3c2fb47d6c83bd234","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/562/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/562/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/562/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/93c9d3b8059e255ef555c4bec78e8e3d2851c7d8","head":{"label":"joseppc:fix/fdserver_maskall","ref":"fix/fdserver_maskall","sha":"93c9d3b8059e255ef555c4bec78e8e3d2851c7d8","user":{"login":"joseppc","id":137580,"avatar_url":"https://avatars3.githubusercontent.com/u/137580?v=4","gravatar_id":"","url":"https://api.github.com/users/joseppc","html_url":"https://github.com/joseppc","followers_url":"https://api.github.com/users/joseppc/followers","following_url":"https://api.github.com/users/joseppc/following{/other_user}","gists_url":"https://api.github.com/users/joseppc/gists{/gist_id}","starred_url":"https://api.github.com/users/joseppc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseppc/subscriptions","organizations_url":"https://api.github.com/users/joseppc/orgs","repos_url":"https://api.github.com/users/joseppc/repos","events_url":"https://api.github.com/users/joseppc/events{/privacy}","received_events_url":"https://api.github.com/users/joseppc/received_events","type":"User","site_admin":false},"repo":{"id":85831543,"name":"odp","full_name":"joseppc/odp","owner":{"login":"joseppc","id":137580,"avatar_url":"https://avatars3.githubusercontent.com/u/137580?v=4","gravatar_id":"","url":"https://api.github.com/users/joseppc","html_url":"https://github.com/joseppc","followers_url":"https://api.github.com/users/joseppc/followers","following_url":"https://api.github.com/users/joseppc/following{/other_user}","gists_url":"https://api.github.com/users/joseppc/gists{/gist_id}","starred_url":"https://api.github.com/users/joseppc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseppc/subscriptions","organizations_url":"https://api.github.com/users/joseppc/orgs","repos_url":"https://api.github.com/users/joseppc/repos","events_url":"https://api.github.com/users/joseppc/events{/privacy}","received_events_url":"https://api.github.com/users/joseppc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joseppc/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/joseppc/odp","forks_url":"https://api.github.com/repos/joseppc/odp/forks","keys_url":"https://api.github.com/repos/joseppc/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joseppc/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joseppc/odp/teams","hooks_url":"https://api.github.com/repos/joseppc/odp/hooks","issue_events_url":"https://api.github.com/repos/joseppc/odp/issues/events{/number}","events_url":"https://api.github.com/repos/joseppc/odp/events","assignees_url":"https://api.github.com/repos/joseppc/odp/assignees{/user}","branches_url":"https://api.github.com/repos/joseppc/odp/branches{/branch}","tags_url":"https://api.github.com/repos/joseppc/odp/tags","blobs_url":"https://api.github.com/repos/joseppc/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joseppc/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joseppc/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/joseppc/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joseppc/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/joseppc/odp/languages","stargazers_url":"https://api.github.com/repos/joseppc/odp/stargazers","contributors_url":"https://api.github.com/repos/joseppc/odp/contributors","subscribers_url":"https://api.github.com/repos/joseppc/odp/subscribers","subscription_url":"https://api.github.com/repos/joseppc/odp/subscription","commits_url":"https://api.github.com/repos/joseppc/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/joseppc/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/joseppc/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/joseppc/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/joseppc/odp/contents/{+path}","compare_url":"https://api.github.com/repos/joseppc/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joseppc/odp/merges","archive_url":"https://api.github.com/repos/joseppc/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joseppc/odp/downloads","issues_url":"https://api.github.com/repos/joseppc/odp/issues{/number}","pulls_url":"https://api.github.com/repos/joseppc/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/joseppc/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/joseppc/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joseppc/odp/labels{/name}","releases_url":"https://api.github.com/repos/joseppc/odp/releases{/id}","deployments_url":"https://api.github.com/repos/joseppc/odp/deployments","created_at":"2017-03-22T13:34:18Z","updated_at":"2018-04-16T11:23:48Z","pushed_at":"2018-04-16T12:26:54Z","git_url":"git://github.com/joseppc/odp.git","ssh_url":"git@github.com:joseppc/odp.git","clone_url":"https://github.com/joseppc/odp.git","svn_url":"https://github.com/joseppc/odp","homepage":"http://www.opendataplane.org/","size":10376,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"813cd2df67ae0591b0f792eff82854c5c9c642ca","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-04-13T14:20:03Z","pushed_at":"2018-04-16T13:28:32Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":11021,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":50,"open_issues":20,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/562"},"html":{"href":"https://github.com/Linaro/odp/pull/562"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/562"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/93c9d3b8059e255ef555c4bec78e8e3d2851c7d8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"JannePeltonen"}}