{"action":"created","issue":{"url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/1116","repository_url":"https://api.github.com/repos/Dart-Code/Dart-Code","labels_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/1116/labels{/name}","comments_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/1116/comments","events_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/1116/events","html_url":"https://github.com/Dart-Code/Dart-Code/issues/1116","id":343995985,"node_id":"MDU6SXNzdWUzNDM5OTU5ODU=","number":1116,"title":"Clicking on a test inside a group does not open the test code","user":{"login":"bergwerf","id":4458965,"node_id":"MDQ6VXNlcjQ0NTg5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4458965?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwerf","html_url":"https://github.com/bergwerf","followers_url":"https://api.github.com/users/bergwerf/followers","following_url":"https://api.github.com/users/bergwerf/following{/other_user}","gists_url":"https://api.github.com/users/bergwerf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwerf/subscriptions","organizations_url":"https://api.github.com/users/bergwerf/orgs","repos_url":"https://api.github.com/users/bergwerf/repos","events_url":"https://api.github.com/users/bergwerf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwerf/received_events","type":"User","site_admin":false},"labels":[{"id":427909356,"node_id":"MDU6TGFiZWw0Mjc5MDkzNTY=","url":"https://api.github.com/repos/Dart-Code/Dart-Code/labels/blocked%20by%20dart%20/%20flutter","name":"blocked by dart / flutter","color":"660000","default":false},{"id":858116579,"node_id":"MDU6TGFiZWw4NTgxMTY1Nzk=","url":"https://api.github.com/repos/Dart-Code/Dart-Code/labels/in%20testing","name":"in testing","color":"0e8a16","default":false},{"id":416693368,"node_id":"MDU6TGFiZWw0MTY2OTMzNjg=","url":"https://api.github.com/repos/Dart-Code/Dart-Code/labels/is%20bug","name":"is bug","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Dart-Code/Dart-Code/milestones/56","html_url":"https://github.com/Dart-Code/Dart-Code/milestone/56","labels_url":"https://api.github.com/repos/Dart-Code/Dart-Code/milestones/56/labels","id":3075537,"node_id":"MDk6TWlsZXN0b25lMzA3NTUzNw==","number":56,"title":"On Deck","description":"","creator":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":0,"state":"open","created_at":"2018-01-30T17:06:57Z","updated_at":"2018-10-25T13:32:38Z","due_on":"2019-01-01T08:00:00Z","closed_at":null},"comments":9,"created_at":"2018-07-24T11:27:26Z","updated_at":"2018-10-25T13:42:04Z","closed_at":null,"author_association":"NONE","body":"I suspect the intended behaviour is that clicking on a test inside a group in the pubtest debugging tree brings you to the test code. Clicking on the group name works but not clicking on the test."},"comment":{"url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/comments/433055723","html_url":"https://github.com/Dart-Code/Dart-Code/issues/1116#issuecomment-433055723","issue_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/1116","id":433055723,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzA1NTcyMw==","user":{"login":"jakemac53","id":984921,"node_id":"MDQ6VXNlcjk4NDkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/984921?v=4","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T13:42:04Z","updated_at":"2018-10-25T13:42:04Z","author_association":"NONE","body":"> @jakemac53 any ideas? I think probably what we want is \"the highest stack frame that is in the users project\" rather than \"that matches the suite that was run\". I guess `test` knows where the project root is, so maybe it's possible?\r\n\r\nI actually don't think this is what you want most of the time, I think the current behavior is the best strategy. It is pretty common to have testing utilities inside of a package, that really just wrap up a call to `test` with some other logic. We don't want to link to those utilities, we want to link to the line in the original test file that called into that utility (generally).\r\n\r\nI don't know that we can ever get anything perfect here but I think what we currently have is probably the best thing.\r\n\r\n@bergwerf Now that Dart has an actual test runner I would recommend using that instead of the previous pattern of creating the test_all.dart file which calls the `main` from all your tests."}}
{"actor":{"display_login":"jakemac53"}}