{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/198647673","pull_request_review_id":132616667,"id":198647673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODY0NzY3Mw==","diff_hunk":"@@ -93,40 +91,19 @@ def setUp(self):\n         self.useFixture(temp_cwd_fixture)\n         self.path = temp_cwd_fixture.path\n \n-        self.useFixture(fixtures.EnvironmentVariable(\n-            'XDG_CONFIG_HOME', os.path.join(self.path, '.config')))\n-        self.useFixture(fixtures.EnvironmentVariable(\n-            'XDG_DATA_HOME', os.path.join(self.path, 'data')))\n+        # Use a separate path for XDG dirs, or changes there may be detected as\n+        # source changes.","path":"tests/integration/__init__.py","position":25,"original_position":25,"commit_id":"d64fe6253990583246500a4aa21f21ed444b59a4","original_commit_id":"d64fe6253990583246500a4aa21f21ed444b59a4","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"kudos on the code comment, makes sense","created_at":"2018-06-27T21:31:02Z","updated_at":"2018-06-27T21:31:02Z","html_url":"https://github.com/snapcore/snapcraft/pull/2167#discussion_r198647673","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/198647673"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2167#discussion_r198647673"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167","id":196872328,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODcyMzI4","html_url":"https://github.com/snapcore/snapcraft/pull/2167","diff_url":"https://github.com/snapcore/snapcraft/pull/2167.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2167.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2167","number":2167,"state":"open","locked":false,"title":"many: detect local source changes","user":{"login":"kyrofa","id":946674,"node_id":"MDQ6VXNlcjk0NjY3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946674?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh unit`?\r\n\r\n-----\r\n\r\nThe snapcraft CLI doesn't notice changes to local sources once the parts have been pulled: one must clean and re-pull in order to take them into account. This PR resolves  [LP: #1583718](https://bugs.launchpad.net/snapcraft/+bug/1583718) by comparing local source timestamps to the pull state timestamp, and updating the pull (and all subsequent) steps as necessary.","created_at":"2018-06-23T01:02:57Z","updated_at":"2018-06-27T21:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab02a8d1a3c5dec2c24d833cd15ce045f98c1f29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2167/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/d64fe6253990583246500a4aa21f21ed444b59a4","head":{"label":"kyrofa:feature/1583718/detect_source_changes","ref":"feature/1583718/detect_source_changes","sha":"d64fe6253990583246500a4aa21f21ed444b59a4","user":{"login":"kyrofa","id":946674,"node_id":"MDQ6VXNlcjk0NjY3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946674?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"repo":{"id":46729716,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcyOTcxNg==","name":"snapcraft","full_name":"kyrofa/snapcraft","owner":{"login":"kyrofa","id":946674,"node_id":"MDQ6VXNlcjk0NjY3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946674?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyrofa/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/kyrofa/snapcraft","forks_url":"https://api.github.com/repos/kyrofa/snapcraft/forks","keys_url":"https://api.github.com/repos/kyrofa/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyrofa/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyrofa/snapcraft/teams","hooks_url":"https://api.github.com/repos/kyrofa/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/kyrofa/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/kyrofa/snapcraft/events","assignees_url":"https://api.github.com/repos/kyrofa/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/kyrofa/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/kyrofa/snapcraft/tags","blobs_url":"https://api.github.com/repos/kyrofa/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyrofa/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyrofa/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyrofa/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyrofa/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/kyrofa/snapcraft/languages","stargazers_url":"https://api.github.com/repos/kyrofa/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/kyrofa/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/kyrofa/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/kyrofa/snapcraft/subscription","commits_url":"https://api.github.com/repos/kyrofa/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyrofa/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyrofa/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyrofa/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyrofa/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/kyrofa/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyrofa/snapcraft/merges","archive_url":"https://api.github.com/repos/kyrofa/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyrofa/snapcraft/downloads","issues_url":"https://api.github.com/repos/kyrofa/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/kyrofa/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/kyrofa/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/kyrofa/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyrofa/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/kyrofa/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/kyrofa/snapcraft/deployments","created_at":"2015-11-23T15:35:14Z","updated_at":"2018-06-07T21:49:28Z","pushed_at":"2018-06-27T17:52:17Z","git_url":"git://github.com/kyrofa/snapcraft.git","ssh_url":"git@github.com:kyrofa/snapcraft.git","clone_url":"https://github.com/kyrofa/snapcraft.git","svn_url":"https://github.com/kyrofa/snapcraft","homepage":null,"size":10515,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"4f80a10517a4b81623bee63f2cd236d574af93ac","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE5OTEzNg==","name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2018-06-27T16:49:10Z","pushed_at":"2018-06-27T17:52:18Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":"","size":9861,"stargazers_count":611,"watchers_count":611,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":255,"open_issues":63,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2167"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2167"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/d64fe6253990583246500a4aa21f21ed444b59a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sergiusens"}}