{"action":"created","comment":{"url":"https://api.github.com/repos/sot/skare3/pulls/comments/201705783","pull_request_review_id":136259062,"id":201705783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTcwNTc4Mw==","diff_hunk":"@@ -0,0 +1,79 @@\n+#!%{PREFIX}%/bin/python -E\n+\n+\"\"\"\n+Print to stdout the appropriate shell commands to initialize the standalone\n+Ska environment.\n+\n+Usage::\n+\n+  usage: flt_envs [-h] [--shell SHELL]\n+\n+  Set flight environment vars\n+\n+  optional arguments:\n+    --shell SHELL  Shell name (csh|tcsh|bash|sh|ksh) default=bash\n+\"\"\"\n+\n+import os\n+from os.path import dirname, abspath\n+import sys\n+\n+\n+SHELL = 'bash'\n+for idx, arg in enumerate(sys.argv):\n+    if arg == '-shell':\n+        SHELL = sys.argv[idx + 1]\n+if SHELL not in ['csh', 'tcsh', 'bash', 'sh', 'ksh']:\n+    raise ValueError(\"shell '%s; not supported\" % SHELL)\n+\n+\n+# Use the convention that flt_envs must be in $SKA/bin to derive SKA and\n+# OVERRIDE any existing value.\n+ska = dirname(dirname(abspath(__file__)))  # from $SKA/bin/flt_envs to $SKA\n+\n+# Set environment vars\n+envs = dict(('SKA_' + suffix.upper(), os.path.join(ska, suffix))\n+        for suffix in ('arch', 'data', 'lib', 'share', 'bin', 'idl'))","path":"ska_conda/pkg_defs/ska3-template/bin/flt_envs","position":36,"original_position":36,"commit_id":"277f24ddf75e2b351a070822c892b88f544c13e8","original_commit_id":"277f24ddf75e2b351a070822c892b88f544c13e8","user":{"login":"jeanconn","id":791508,"node_id":"MDQ6VXNlcjc5MTUwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/791508?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanconn","html_url":"https://github.com/jeanconn","followers_url":"https://api.github.com/users/jeanconn/followers","following_url":"https://api.github.com/users/jeanconn/following{/other_user}","gists_url":"https://api.github.com/users/jeanconn/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanconn/subscriptions","organizations_url":"https://api.github.com/users/jeanconn/orgs","repos_url":"https://api.github.com/users/jeanconn/repos","events_url":"https://api.github.com/users/jeanconn/events{/privacy}","received_events_url":"https://api.github.com/users/jeanconn/received_events","type":"User","site_admin":false},"body":"Is it though?  Did pretty well on the pass through ska_testr tests without it and *not* setting it here might be a good way to flush out other implicit dependencies.","created_at":"2018-07-11T14:15:09Z","updated_at":"2018-07-11T14:15:09Z","html_url":"https://github.com/sot/skare3/pull/19#discussion_r201705783","pull_request_url":"https://api.github.com/repos/sot/skare3/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sot/skare3/pulls/comments/201705783"},"html":{"href":"https://github.com/sot/skare3/pull/19#discussion_r201705783"},"pull_request":{"href":"https://api.github.com/repos/sot/skare3/pulls/19"}},"in_reply_to_id":201690791},"pull_request":{"url":"https://api.github.com/repos/sot/skare3/pulls/19","id":200382205,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzgyMjA1","html_url":"https://github.com/sot/skare3/pull/19","diff_url":"https://github.com/sot/skare3/pull/19.diff","patch_url":"https://github.com/sot/skare3/pull/19.patch","issue_url":"https://api.github.com/repos/sot/skare3/issues/19","number":19,"state":"open","locked":false,"title":"One more pass through the recipes, plus work toward the metapackages","user":{"login":"jeanconn","id":791508,"node_id":"MDQ6VXNlcjc5MTUwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/791508?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanconn","html_url":"https://github.com/jeanconn","followers_url":"https://api.github.com/users/jeanconn/followers","following_url":"https://api.github.com/users/jeanconn/following{/other_user}","gists_url":"https://api.github.com/users/jeanconn/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanconn/subscriptions","organizations_url":"https://api.github.com/users/jeanconn/orgs","repos_url":"https://api.github.com/users/jeanconn/repos","events_url":"https://api.github.com/users/jeanconn/events{/privacy}","received_events_url":"https://api.github.com/users/jeanconn/received_events","type":"User","site_admin":false},"body":"One more pass through the recipes, plus work toward the metapackages .\r\n\r\nOK so a lot of things are working but there are still some todo items here:\r\n\r\n - [x] ska3-dev needs to be filled out with all of the ska packages (it just has the default channel ones to start)\r\n - [ ] my thought was that we'd keep ska3-pinned for use with ska3-dev, but maybe that's just confusing.   This will need more work due to the issue that we can't really pin conda in a generic way with ska3-pinned anyway, as it looks like you can't install conda into non-root envs\r\n - [x] Looks like we'll need something for ska_version (or to decide that we don't need it for ska_testr) (I just used a new string in get_version_id for now).\r\n - [ ] Not sure what to do with default ska data at this point.  My ska3-template flt_envs sets SKA to conda root which looks incompatible with https://github.com/sot/skare3/wiki/Ska3-runtime-environment-for-users#ska-data-to-be-revised .","created_at":"2018-07-10T12:40:07Z","updated_at":"2018-07-11T14:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da5b1c80238e6301862158f55c633b6a2e6a17e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sot/skare3/pulls/19/commits","review_comments_url":"https://api.github.com/repos/sot/skare3/pulls/19/comments","review_comment_url":"https://api.github.com/repos/sot/skare3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sot/skare3/issues/19/comments","statuses_url":"https://api.github.com/repos/sot/skare3/statuses/277f24ddf75e2b351a070822c892b88f544c13e8","head":{"label":"sot:first_home_stretch","ref":"first_home_stretch","sha":"277f24ddf75e2b351a070822c892b88f544c13e8","user":{"login":"sot","id":781587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/781587?v=4","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"repo":{"id":94629738,"node_id":"MDEwOlJlcG9zaXRvcnk5NDYyOTczOA==","name":"skare3","full_name":"sot/skare3","owner":{"login":"sot","id":781587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/781587?v=4","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sot/skare3","description":"Conda recipes for ska environment packages","fork":false,"url":"https://api.github.com/repos/sot/skare3","forks_url":"https://api.github.com/repos/sot/skare3/forks","keys_url":"https://api.github.com/repos/sot/skare3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sot/skare3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sot/skare3/teams","hooks_url":"https://api.github.com/repos/sot/skare3/hooks","issue_events_url":"https://api.github.com/repos/sot/skare3/issues/events{/number}","events_url":"https://api.github.com/repos/sot/skare3/events","assignees_url":"https://api.github.com/repos/sot/skare3/assignees{/user}","branches_url":"https://api.github.com/repos/sot/skare3/branches{/branch}","tags_url":"https://api.github.com/repos/sot/skare3/tags","blobs_url":"https://api.github.com/repos/sot/skare3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sot/skare3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sot/skare3/git/refs{/sha}","trees_url":"https://api.github.com/repos/sot/skare3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sot/skare3/statuses/{sha}","languages_url":"https://api.github.com/repos/sot/skare3/languages","stargazers_url":"https://api.github.com/repos/sot/skare3/stargazers","contributors_url":"https://api.github.com/repos/sot/skare3/contributors","subscribers_url":"https://api.github.com/repos/sot/skare3/subscribers","subscription_url":"https://api.github.com/repos/sot/skare3/subscription","commits_url":"https://api.github.com/repos/sot/skare3/commits{/sha}","git_commits_url":"https://api.github.com/repos/sot/skare3/git/commits{/sha}","comments_url":"https://api.github.com/repos/sot/skare3/comments{/number}","issue_comment_url":"https://api.github.com/repos/sot/skare3/issues/comments{/number}","contents_url":"https://api.github.com/repos/sot/skare3/contents/{+path}","compare_url":"https://api.github.com/repos/sot/skare3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sot/skare3/merges","archive_url":"https://api.github.com/repos/sot/skare3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sot/skare3/downloads","issues_url":"https://api.github.com/repos/sot/skare3/issues{/number}","pulls_url":"https://api.github.com/repos/sot/skare3/pulls{/number}","milestones_url":"https://api.github.com/repos/sot/skare3/milestones{/number}","notifications_url":"https://api.github.com/repos/sot/skare3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sot/skare3/labels{/name}","releases_url":"https://api.github.com/repos/sot/skare3/releases{/id}","deployments_url":"https://api.github.com/repos/sot/skare3/deployments","created_at":"2017-06-17T14:45:10Z","updated_at":"2018-07-03T00:34:42Z","pushed_at":"2018-07-11T12:40:22Z","git_url":"git://github.com/sot/skare3.git","ssh_url":"git@github.com:sot/skare3.git","clone_url":"https://github.com/sot/skare3.git","svn_url":"https://github.com/sot/skare3","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"sot:master","ref":"master","sha":"e2f6421d00fc79fa4d4701a96a7305f9cd190888","user":{"login":"sot","id":781587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/781587?v=4","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"repo":{"id":94629738,"node_id":"MDEwOlJlcG9zaXRvcnk5NDYyOTczOA==","name":"skare3","full_name":"sot/skare3","owner":{"login":"sot","id":781587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/781587?v=4","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sot/skare3","description":"Conda recipes for ska environment packages","fork":false,"url":"https://api.github.com/repos/sot/skare3","forks_url":"https://api.github.com/repos/sot/skare3/forks","keys_url":"https://api.github.com/repos/sot/skare3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sot/skare3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sot/skare3/teams","hooks_url":"https://api.github.com/repos/sot/skare3/hooks","issue_events_url":"https://api.github.com/repos/sot/skare3/issues/events{/number}","events_url":"https://api.github.com/repos/sot/skare3/events","assignees_url":"https://api.github.com/repos/sot/skare3/assignees{/user}","branches_url":"https://api.github.com/repos/sot/skare3/branches{/branch}","tags_url":"https://api.github.com/repos/sot/skare3/tags","blobs_url":"https://api.github.com/repos/sot/skare3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sot/skare3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sot/skare3/git/refs{/sha}","trees_url":"https://api.github.com/repos/sot/skare3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sot/skare3/statuses/{sha}","languages_url":"https://api.github.com/repos/sot/skare3/languages","stargazers_url":"https://api.github.com/repos/sot/skare3/stargazers","contributors_url":"https://api.github.com/repos/sot/skare3/contributors","subscribers_url":"https://api.github.com/repos/sot/skare3/subscribers","subscription_url":"https://api.github.com/repos/sot/skare3/subscription","commits_url":"https://api.github.com/repos/sot/skare3/commits{/sha}","git_commits_url":"https://api.github.com/repos/sot/skare3/git/commits{/sha}","comments_url":"https://api.github.com/repos/sot/skare3/comments{/number}","issue_comment_url":"https://api.github.com/repos/sot/skare3/issues/comments{/number}","contents_url":"https://api.github.com/repos/sot/skare3/contents/{+path}","compare_url":"https://api.github.com/repos/sot/skare3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sot/skare3/merges","archive_url":"https://api.github.com/repos/sot/skare3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sot/skare3/downloads","issues_url":"https://api.github.com/repos/sot/skare3/issues{/number}","pulls_url":"https://api.github.com/repos/sot/skare3/pulls{/number}","milestones_url":"https://api.github.com/repos/sot/skare3/milestones{/number}","notifications_url":"https://api.github.com/repos/sot/skare3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sot/skare3/labels{/name}","releases_url":"https://api.github.com/repos/sot/skare3/releases{/id}","deployments_url":"https://api.github.com/repos/sot/skare3/deployments","created_at":"2017-06-17T14:45:10Z","updated_at":"2018-07-03T00:34:42Z","pushed_at":"2018-07-11T12:40:22Z","git_url":"git://github.com/sot/skare3.git","ssh_url":"git@github.com:sot/skare3.git","clone_url":"https://github.com/sot/skare3.git","svn_url":"https://github.com/sot/skare3","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sot/skare3/pulls/19"},"html":{"href":"https://github.com/sot/skare3/pull/19"},"issue":{"href":"https://api.github.com/repos/sot/skare3/issues/19"},"comments":{"href":"https://api.github.com/repos/sot/skare3/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/sot/skare3/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/sot/skare3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sot/skare3/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/sot/skare3/statuses/277f24ddf75e2b351a070822c892b88f544c13e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeanconn"}}