{"action":"created","comment":{"url":"https://api.github.com/repos/open-prevo/openprevo/pulls/comments/203415892","pull_request_review_id":138299913,"id":203415892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQxNTg5Mg==","diff_hunk":"@@ -58,7 +62,7 @@ public void sendCommencementNotificationToPreviousRetirementFund() throws Except\n \n                 .andExpect(status().isOk())\n                 .andExpect(content().contentType(contentType))\n-                .andExpect(jsonPath(\"$.name\", is(\"BKB_Test_Bank\")))\n-                .andExpect(jsonPath(\"$.iban\", is(\"CH53 0077 0016 02222 3334 4\")));\n+                .andExpect(jsonPath(\"$.encryptedDataBase64\", notNullValue(String.class)))","path":"node/src/test/java/ch/prevo/open/node/api/MatchNotificationControllerTest.java","position":63,"original_position":63,"commit_id":"2d0969de55f6e6d6f57e2fceb937bcb4618be917","original_commit_id":"de8d814318eecb5070e75fbbfab7c80c4dc84652","user":{"login":"mikaelkalt","id":4425489,"node_id":"MDQ6VXNlcjQ0MjU0ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/4425489?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelkalt","html_url":"https://github.com/mikaelkalt","followers_url":"https://api.github.com/users/mikaelkalt/followers","following_url":"https://api.github.com/users/mikaelkalt/following{/other_user}","gists_url":"https://api.github.com/users/mikaelkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelkalt/subscriptions","organizations_url":"https://api.github.com/users/mikaelkalt/orgs","repos_url":"https://api.github.com/users/mikaelkalt/repos","events_url":"https://api.github.com/users/mikaelkalt/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelkalt/received_events","type":"User","site_admin":false},"body":"as discussed, this is what spring would call an integration test. by hard-coding the keys it would be possible to verify the encryption as well.","created_at":"2018-07-18T15:06:02Z","updated_at":"2018-07-18T15:06:02Z","html_url":"https://github.com/open-prevo/openprevo/pull/119#discussion_r203415892","pull_request_url":"https://api.github.com/repos/open-prevo/openprevo/pulls/119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/comments/203415892"},"html":{"href":"https://github.com/open-prevo/openprevo/pull/119#discussion_r203415892"},"pull_request":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/119"}},"in_reply_to_id":203349815},"pull_request":{"url":"https://api.github.com/repos/open-prevo/openprevo/pulls/119","id":202214563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjE0NTYz","html_url":"https://github.com/open-prevo/openprevo/pull/119","diff_url":"https://github.com/open-prevo/openprevo/pull/119.diff","patch_url":"https://github.com/open-prevo/openprevo/pull/119.patch","issue_url":"https://api.github.com/repos/open-prevo/openprevo/issues/119","number":119,"state":"open","locked":false,"title":"Features/70 encrypt payment infos","user":{"login":"lennartx","id":2229746,"node_id":"MDQ6VXNlcjIyMjk3NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2229746?v=4","gravatar_id":"","url":"https://api.github.com/users/lennartx","html_url":"https://github.com/lennartx","followers_url":"https://api.github.com/users/lennartx/followers","following_url":"https://api.github.com/users/lennartx/following{/other_user}","gists_url":"https://api.github.com/users/lennartx/gists{/gist_id}","starred_url":"https://api.github.com/users/lennartx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennartx/subscriptions","organizations_url":"https://api.github.com/users/lennartx/orgs","repos_url":"https://api.github.com/users/lennartx/repos","events_url":"https://api.github.com/users/lennartx/events{/privacy}","received_events_url":"https://api.github.com/users/lennartx/received_events","type":"User","site_admin":false},"body":"Some adjustments will still be necessary, but the current state is stable ","created_at":"2018-07-18T10:58:15Z","updated_at":"2018-07-18T15:06:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d541846b8ab0448efbc7f6f13d84d730eb45c10b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-prevo/openprevo/pulls/119/commits","review_comments_url":"https://api.github.com/repos/open-prevo/openprevo/pulls/119/comments","review_comment_url":"https://api.github.com/repos/open-prevo/openprevo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-prevo/openprevo/issues/119/comments","statuses_url":"https://api.github.com/repos/open-prevo/openprevo/statuses/2d0969de55f6e6d6f57e2fceb937bcb4618be917","head":{"label":"open-prevo:features/70_encrypt_payment_infos","ref":"features/70_encrypt_payment_infos","sha":"2d0969de55f6e6d6f57e2fceb937bcb4618be917","user":{"login":"open-prevo","id":39703843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzAzODQz","avatar_url":"https://avatars2.githubusercontent.com/u/39703843?v=4","gravatar_id":"","url":"https://api.github.com/users/open-prevo","html_url":"https://github.com/open-prevo","followers_url":"https://api.github.com/users/open-prevo/followers","following_url":"https://api.github.com/users/open-prevo/following{/other_user}","gists_url":"https://api.github.com/users/open-prevo/gists{/gist_id}","starred_url":"https://api.github.com/users/open-prevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-prevo/subscriptions","organizations_url":"https://api.github.com/users/open-prevo/orgs","repos_url":"https://api.github.com/users/open-prevo/repos","events_url":"https://api.github.com/users/open-prevo/events{/privacy}","received_events_url":"https://api.github.com/users/open-prevo/received_events","type":"Organization","site_admin":false},"repo":{"id":135175172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNzUxNzI=","name":"openprevo","full_name":"open-prevo/openprevo","owner":{"login":"open-prevo","id":39703843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzAzODQz","avatar_url":"https://avatars2.githubusercontent.com/u/39703843?v=4","gravatar_id":"","url":"https://api.github.com/users/open-prevo","html_url":"https://github.com/open-prevo","followers_url":"https://api.github.com/users/open-prevo/followers","following_url":"https://api.github.com/users/open-prevo/following{/other_user}","gists_url":"https://api.github.com/users/open-prevo/gists{/gist_id}","starred_url":"https://api.github.com/users/open-prevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-prevo/subscriptions","organizations_url":"https://api.github.com/users/open-prevo/orgs","repos_url":"https://api.github.com/users/open-prevo/repos","events_url":"https://api.github.com/users/open-prevo/events{/privacy}","received_events_url":"https://api.github.com/users/open-prevo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-prevo/openprevo","description":"OpenPrevo","fork":false,"url":"https://api.github.com/repos/open-prevo/openprevo","forks_url":"https://api.github.com/repos/open-prevo/openprevo/forks","keys_url":"https://api.github.com/repos/open-prevo/openprevo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-prevo/openprevo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-prevo/openprevo/teams","hooks_url":"https://api.github.com/repos/open-prevo/openprevo/hooks","issue_events_url":"https://api.github.com/repos/open-prevo/openprevo/issues/events{/number}","events_url":"https://api.github.com/repos/open-prevo/openprevo/events","assignees_url":"https://api.github.com/repos/open-prevo/openprevo/assignees{/user}","branches_url":"https://api.github.com/repos/open-prevo/openprevo/branches{/branch}","tags_url":"https://api.github.com/repos/open-prevo/openprevo/tags","blobs_url":"https://api.github.com/repos/open-prevo/openprevo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-prevo/openprevo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-prevo/openprevo/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-prevo/openprevo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-prevo/openprevo/statuses/{sha}","languages_url":"https://api.github.com/repos/open-prevo/openprevo/languages","stargazers_url":"https://api.github.com/repos/open-prevo/openprevo/stargazers","contributors_url":"https://api.github.com/repos/open-prevo/openprevo/contributors","subscribers_url":"https://api.github.com/repos/open-prevo/openprevo/subscribers","subscription_url":"https://api.github.com/repos/open-prevo/openprevo/subscription","commits_url":"https://api.github.com/repos/open-prevo/openprevo/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-prevo/openprevo/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-prevo/openprevo/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-prevo/openprevo/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-prevo/openprevo/contents/{+path}","compare_url":"https://api.github.com/repos/open-prevo/openprevo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-prevo/openprevo/merges","archive_url":"https://api.github.com/repos/open-prevo/openprevo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-prevo/openprevo/downloads","issues_url":"https://api.github.com/repos/open-prevo/openprevo/issues{/number}","pulls_url":"https://api.github.com/repos/open-prevo/openprevo/pulls{/number}","milestones_url":"https://api.github.com/repos/open-prevo/openprevo/milestones{/number}","notifications_url":"https://api.github.com/repos/open-prevo/openprevo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-prevo/openprevo/labels{/name}","releases_url":"https://api.github.com/repos/open-prevo/openprevo/releases{/id}","deployments_url":"https://api.github.com/repos/open-prevo/openprevo/deployments","created_at":"2018-05-28T14:55:02Z","updated_at":"2018-07-18T10:33:06Z","pushed_at":"2018-07-18T14:58:41Z","git_url":"git://github.com/open-prevo/openprevo.git","ssh_url":"git@github.com:open-prevo/openprevo.git","clone_url":"https://github.com/open-prevo/openprevo.git","svn_url":"https://github.com/open-prevo/openprevo","homepage":null,"size":1746,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":1,"open_issues":37,"watchers":1,"default_branch":"master"}},"base":{"label":"open-prevo:master","ref":"master","sha":"0be9ca83e2e44e40c40a62bf6441460fb6eb4e5a","user":{"login":"open-prevo","id":39703843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzAzODQz","avatar_url":"https://avatars2.githubusercontent.com/u/39703843?v=4","gravatar_id":"","url":"https://api.github.com/users/open-prevo","html_url":"https://github.com/open-prevo","followers_url":"https://api.github.com/users/open-prevo/followers","following_url":"https://api.github.com/users/open-prevo/following{/other_user}","gists_url":"https://api.github.com/users/open-prevo/gists{/gist_id}","starred_url":"https://api.github.com/users/open-prevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-prevo/subscriptions","organizations_url":"https://api.github.com/users/open-prevo/orgs","repos_url":"https://api.github.com/users/open-prevo/repos","events_url":"https://api.github.com/users/open-prevo/events{/privacy}","received_events_url":"https://api.github.com/users/open-prevo/received_events","type":"Organization","site_admin":false},"repo":{"id":135175172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNzUxNzI=","name":"openprevo","full_name":"open-prevo/openprevo","owner":{"login":"open-prevo","id":39703843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzAzODQz","avatar_url":"https://avatars2.githubusercontent.com/u/39703843?v=4","gravatar_id":"","url":"https://api.github.com/users/open-prevo","html_url":"https://github.com/open-prevo","followers_url":"https://api.github.com/users/open-prevo/followers","following_url":"https://api.github.com/users/open-prevo/following{/other_user}","gists_url":"https://api.github.com/users/open-prevo/gists{/gist_id}","starred_url":"https://api.github.com/users/open-prevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-prevo/subscriptions","organizations_url":"https://api.github.com/users/open-prevo/orgs","repos_url":"https://api.github.com/users/open-prevo/repos","events_url":"https://api.github.com/users/open-prevo/events{/privacy}","received_events_url":"https://api.github.com/users/open-prevo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-prevo/openprevo","description":"OpenPrevo","fork":false,"url":"https://api.github.com/repos/open-prevo/openprevo","forks_url":"https://api.github.com/repos/open-prevo/openprevo/forks","keys_url":"https://api.github.com/repos/open-prevo/openprevo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-prevo/openprevo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-prevo/openprevo/teams","hooks_url":"https://api.github.com/repos/open-prevo/openprevo/hooks","issue_events_url":"https://api.github.com/repos/open-prevo/openprevo/issues/events{/number}","events_url":"https://api.github.com/repos/open-prevo/openprevo/events","assignees_url":"https://api.github.com/repos/open-prevo/openprevo/assignees{/user}","branches_url":"https://api.github.com/repos/open-prevo/openprevo/branches{/branch}","tags_url":"https://api.github.com/repos/open-prevo/openprevo/tags","blobs_url":"https://api.github.com/repos/open-prevo/openprevo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-prevo/openprevo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-prevo/openprevo/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-prevo/openprevo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-prevo/openprevo/statuses/{sha}","languages_url":"https://api.github.com/repos/open-prevo/openprevo/languages","stargazers_url":"https://api.github.com/repos/open-prevo/openprevo/stargazers","contributors_url":"https://api.github.com/repos/open-prevo/openprevo/contributors","subscribers_url":"https://api.github.com/repos/open-prevo/openprevo/subscribers","subscription_url":"https://api.github.com/repos/open-prevo/openprevo/subscription","commits_url":"https://api.github.com/repos/open-prevo/openprevo/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-prevo/openprevo/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-prevo/openprevo/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-prevo/openprevo/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-prevo/openprevo/contents/{+path}","compare_url":"https://api.github.com/repos/open-prevo/openprevo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-prevo/openprevo/merges","archive_url":"https://api.github.com/repos/open-prevo/openprevo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-prevo/openprevo/downloads","issues_url":"https://api.github.com/repos/open-prevo/openprevo/issues{/number}","pulls_url":"https://api.github.com/repos/open-prevo/openprevo/pulls{/number}","milestones_url":"https://api.github.com/repos/open-prevo/openprevo/milestones{/number}","notifications_url":"https://api.github.com/repos/open-prevo/openprevo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-prevo/openprevo/labels{/name}","releases_url":"https://api.github.com/repos/open-prevo/openprevo/releases{/id}","deployments_url":"https://api.github.com/repos/open-prevo/openprevo/deployments","created_at":"2018-05-28T14:55:02Z","updated_at":"2018-07-18T10:33:06Z","pushed_at":"2018-07-18T14:58:41Z","git_url":"git://github.com/open-prevo/openprevo.git","ssh_url":"git@github.com:open-prevo/openprevo.git","clone_url":"https://github.com/open-prevo/openprevo.git","svn_url":"https://github.com/open-prevo/openprevo","homepage":null,"size":1746,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":1,"open_issues":37,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/119"},"html":{"href":"https://github.com/open-prevo/openprevo/pull/119"},"issue":{"href":"https://api.github.com/repos/open-prevo/openprevo/issues/119"},"comments":{"href":"https://api.github.com/repos/open-prevo/openprevo/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-prevo/openprevo/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/open-prevo/openprevo/statuses/2d0969de55f6e6d6f57e2fceb937bcb4618be917"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikaelkalt"}}