{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/comments/180652755","pull_request_review_id":111107411,"id":180652755,"diff_hunk":"@@ -0,0 +1,117 @@\n+= EAP7-979 WFCORE-3568 Allow CLI output scrolling\n+:author:            Marek Marusic\n+:email:             mmarusic@redhat.com\n+:toc:               left\n+:icons:             font\n+:keywords:          cli,output,scrolling\n+:idprefix:\n+:idseparator:       -\n+\n+== Overview\n+\n+Since https://issues.jboss.org/browse/WFCORE-426[WFCORE-426] and https://issues.jboss.org/browse/EAP7-735[EAP7-735]\n+mouse scrolling is forbidden to large CLI out and user has to press Down or Enter to navigate.\n+After pressing Down or Enter to display more output, user can not go up by pressing Up.\n+Therefore, it would be convenient to allow CLI output scrolling by mouse and by Up/Down and PgUp/PgDown keys.\n+\n+== Issue Metadata\n+\n+=== Issue\n+\n+* https://issues.jboss.org/browse/EAP7-979[EAP7-979]\n+\n+=== Related Issues\n+\n+* https://issues.jboss.org/browse/WFCORE-3568[WFCORE-3568]\n+\n+=== Dev Contacts\n+\n+* mailto:{email}[{author}]\n+* mailto:jdenise@redhat.com[Jean-François Denise]\n+\n+=== QE Contacts\n+\n+* mailto:eduda@redhat.com[Erich Duda]\n+\n+=== Affected Projects or Components\n+\n+* CLI\n+\n+=== Other Interested Projects\n+\n+== Requirements\n+\n+=== Hard Requirements\n+* Fast scrolling using PgUp / PgDn. (ATM there is possibility to use space for fast scroll down)\n+* Scrolling by mouse\n+* Ability to scroll up\n+* Since as mentioned in https://developer.jboss.org/wiki/CLI-PagingLongCLIOutput#comment-16541\n+  the \"less\" behaviour would result in buffer alternation and therefore after\n+  exiting the reading of output the output wouldn't be visible any more in the main buffer of the CLI.\n+  This is not convenient since users may want to see at least part of the output\n+  in the main buffer.\n+  Therefore I would propose to print a part of the output from start to the last scrolled position\n+  into the main buffer of the CLI\n+  when exiting the more/less reading.\n+\n+\n+==== List of keys and actions:\n+Composed keys are unstable during the testing\n+(this is tracked in https://issues.jboss.org/browse/WFCORE-3545[WFCORE-3545])\n+Therefore I propose to use for every action a noncomposed key as well.\n+This will enable us to create a stable tests.\n+\n+* PGDOWN / SPACE : scroll one page down\n+* PGUP / BACKSLASH : scroll one page up\n+* UP / SEMI_COLON: scroll one line up\n+* DOWN / ENTER / CTRL_M : scroll one line down\n+* Mouse scroll up : scroll up\n+* Mouse scroll down : scroll down\n+* ESC / 'q' / CTRL_C : quit\n+* HOME : go to start of the document\n+* END : go to end of the document\n+\n+=== Nice-to-Have Requirements\n+\n+Support for searching of patterns. Similar as it is done by less command.","path":"cli/EAP7-979_Allow_CLI_output_scrolling.adoc","position":76,"original_position":76,"commit_id":"e27f8cb609102a39cc1cc6806f5429ac921e5cc1","original_commit_id":"e27f8cb609102a39cc1cc6806f5429ac921e5cc1","user":{"login":"MMarus","id":11910469,"avatar_url":"https://avatars1.githubusercontent.com/u/11910469?v=4","gravatar_id":"","url":"https://api.github.com/users/MMarus","html_url":"https://github.com/MMarus","followers_url":"https://api.github.com/users/MMarus/followers","following_url":"https://api.github.com/users/MMarus/following{/other_user}","gists_url":"https://api.github.com/users/MMarus/gists{/gist_id}","starred_url":"https://api.github.com/users/MMarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMarus/subscriptions","organizations_url":"https://api.github.com/users/MMarus/orgs","repos_url":"https://api.github.com/users/MMarus/repos","events_url":"https://api.github.com/users/MMarus/events{/privacy}","received_events_url":"https://api.github.com/users/MMarus/received_events","type":"User","site_admin":false},"body":"I have done an analysis for the search functionality as requested in the review.\r\n\r\nHowever, the original issue [2] did not mention a possibility to search patterns and I think it would require a bigger changes.\r\nTherefore, it could be better to create a separate \"less\" command for the search part and track that in separate Feature Request / Issue. The \"less\" implemented as a command would give user the possibility to choose whether he wants to use the auto \"more\" functionality or whether he wants to use the \"less\" command.\r\nThe \"less\" command could be used for operations like \":read-resource()\" through a pipe e.g. \":read-resource() | less\".\r\n\r\n@jfdenise @dudaerich  what do you think about this ?","created_at":"2018-04-11T07:02:54Z","updated_at":"2018-04-11T07:02:54Z","html_url":"https://github.com/wildfly/wildfly-proposals/pull/48#discussion_r180652755","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/comments/180652755"},"html":{"href":"https://github.com/wildfly/wildfly-proposals/pull/48#discussion_r180652755"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48","id":180512342,"html_url":"https://github.com/wildfly/wildfly-proposals/pull/48","diff_url":"https://github.com/wildfly/wildfly-proposals/pull/48.diff","patch_url":"https://github.com/wildfly/wildfly-proposals/pull/48.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/48","number":48,"state":"open","locked":false,"title":"EAP7-979 WFCORE-3568 Allow CLI output scrolling","user":{"login":"MMarus","id":11910469,"avatar_url":"https://avatars1.githubusercontent.com/u/11910469?v=4","gravatar_id":"","url":"https://api.github.com/users/MMarus","html_url":"https://github.com/MMarus","followers_url":"https://api.github.com/users/MMarus/followers","following_url":"https://api.github.com/users/MMarus/following{/other_user}","gists_url":"https://api.github.com/users/MMarus/gists{/gist_id}","starred_url":"https://api.github.com/users/MMarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMarus/subscriptions","organizations_url":"https://api.github.com/users/MMarus/orgs","repos_url":"https://api.github.com/users/MMarus/repos","events_url":"https://api.github.com/users/MMarus/events{/privacy}","received_events_url":"https://api.github.com/users/MMarus/received_events","type":"User","site_admin":false},"body":"WFCORE: https://issues.jboss.org/browse/WFCORE-3568\r\nEAP7: https://issues.jboss.org/browse/EAP7-979 ","created_at":"2018-04-10T07:29:52Z","updated_at":"2018-04-11T07:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b0b7b2e9b5daadec24b4d56848367e7d8f02b3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/48/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-proposals/statuses/e27f8cb609102a39cc1cc6806f5429ac921e5cc1","head":{"label":"MMarus:cli-EAP7-979-Allow-CLI-output-scrolling","ref":"cli-EAP7-979-Allow-CLI-output-scrolling","sha":"e27f8cb609102a39cc1cc6806f5429ac921e5cc1","user":{"login":"MMarus","id":11910469,"avatar_url":"https://avatars1.githubusercontent.com/u/11910469?v=4","gravatar_id":"","url":"https://api.github.com/users/MMarus","html_url":"https://github.com/MMarus","followers_url":"https://api.github.com/users/MMarus/followers","following_url":"https://api.github.com/users/MMarus/following{/other_user}","gists_url":"https://api.github.com/users/MMarus/gists{/gist_id}","starred_url":"https://api.github.com/users/MMarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMarus/subscriptions","organizations_url":"https://api.github.com/users/MMarus/orgs","repos_url":"https://api.github.com/users/MMarus/repos","events_url":"https://api.github.com/users/MMarus/events{/privacy}","received_events_url":"https://api.github.com/users/MMarus/received_events","type":"User","site_admin":false},"repo":{"id":128167131,"name":"wildfly-proposals","full_name":"MMarus/wildfly-proposals","owner":{"login":"MMarus","id":11910469,"avatar_url":"https://avatars1.githubusercontent.com/u/11910469?v=4","gravatar_id":"","url":"https://api.github.com/users/MMarus","html_url":"https://github.com/MMarus","followers_url":"https://api.github.com/users/MMarus/followers","following_url":"https://api.github.com/users/MMarus/following{/other_user}","gists_url":"https://api.github.com/users/MMarus/gists{/gist_id}","starred_url":"https://api.github.com/users/MMarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMarus/subscriptions","organizations_url":"https://api.github.com/users/MMarus/orgs","repos_url":"https://api.github.com/users/MMarus/repos","events_url":"https://api.github.com/users/MMarus/events{/privacy}","received_events_url":"https://api.github.com/users/MMarus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MMarus/wildfly-proposals","description":"A central location for analysis and design documents of new features and capabilities in the WildFly project universe","fork":true,"url":"https://api.github.com/repos/MMarus/wildfly-proposals","forks_url":"https://api.github.com/repos/MMarus/wildfly-proposals/forks","keys_url":"https://api.github.com/repos/MMarus/wildfly-proposals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MMarus/wildfly-proposals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MMarus/wildfly-proposals/teams","hooks_url":"https://api.github.com/repos/MMarus/wildfly-proposals/hooks","issue_events_url":"https://api.github.com/repos/MMarus/wildfly-proposals/issues/events{/number}","events_url":"https://api.github.com/repos/MMarus/wildfly-proposals/events","assignees_url":"https://api.github.com/repos/MMarus/wildfly-proposals/assignees{/user}","branches_url":"https://api.github.com/repos/MMarus/wildfly-proposals/branches{/branch}","tags_url":"https://api.github.com/repos/MMarus/wildfly-proposals/tags","blobs_url":"https://api.github.com/repos/MMarus/wildfly-proposals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MMarus/wildfly-proposals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MMarus/wildfly-proposals/git/refs{/sha}","trees_url":"https://api.github.com/repos/MMarus/wildfly-proposals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MMarus/wildfly-proposals/statuses/{sha}","languages_url":"https://api.github.com/repos/MMarus/wildfly-proposals/languages","stargazers_url":"https://api.github.com/repos/MMarus/wildfly-proposals/stargazers","contributors_url":"https://api.github.com/repos/MMarus/wildfly-proposals/contributors","subscribers_url":"https://api.github.com/repos/MMarus/wildfly-proposals/subscribers","subscription_url":"https://api.github.com/repos/MMarus/wildfly-proposals/subscription","commits_url":"https://api.github.com/repos/MMarus/wildfly-proposals/commits{/sha}","git_commits_url":"https://api.github.com/repos/MMarus/wildfly-proposals/git/commits{/sha}","comments_url":"https://api.github.com/repos/MMarus/wildfly-proposals/comments{/number}","issue_comment_url":"https://api.github.com/repos/MMarus/wildfly-proposals/issues/comments{/number}","contents_url":"https://api.github.com/repos/MMarus/wildfly-proposals/contents/{+path}","compare_url":"https://api.github.com/repos/MMarus/wildfly-proposals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MMarus/wildfly-proposals/merges","archive_url":"https://api.github.com/repos/MMarus/wildfly-proposals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MMarus/wildfly-proposals/downloads","issues_url":"https://api.github.com/repos/MMarus/wildfly-proposals/issues{/number}","pulls_url":"https://api.github.com/repos/MMarus/wildfly-proposals/pulls{/number}","milestones_url":"https://api.github.com/repos/MMarus/wildfly-proposals/milestones{/number}","notifications_url":"https://api.github.com/repos/MMarus/wildfly-proposals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MMarus/wildfly-proposals/labels{/name}","releases_url":"https://api.github.com/repos/MMarus/wildfly-proposals/releases{/id}","deployments_url":"https://api.github.com/repos/MMarus/wildfly-proposals/deployments","created_at":"2018-04-05T06:24:02Z","updated_at":"2018-04-05T06:24:04Z","pushed_at":"2018-04-11T06:59:19Z","git_url":"git://github.com/MMarus/wildfly-proposals.git","ssh_url":"git@github.com:MMarus/wildfly-proposals.git","clone_url":"https://github.com/MMarus/wildfly-proposals.git","svn_url":"https://github.com/MMarus/wildfly-proposals","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"ae6840ded84a1aa6673da1b6660c3f8c7f4ab796","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":114395029,"name":"wildfly-proposals","full_name":"wildfly/wildfly-proposals","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-proposals","description":"A central location for analysis and design documents of new features and capabilities in the WildFly project universe","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-proposals","forks_url":"https://api.github.com/repos/wildfly/wildfly-proposals/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-proposals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-proposals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-proposals/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-proposals/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-proposals/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-proposals/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-proposals/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-proposals/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-proposals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-proposals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-proposals/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-proposals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-proposals/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-proposals/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-proposals/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-proposals/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-proposals/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-proposals/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-proposals/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-proposals/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-proposals/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-proposals/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-proposals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-proposals/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-proposals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-proposals/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-proposals/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-proposals/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-proposals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-proposals/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-proposals/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-proposals/deployments","created_at":"2017-12-15T17:21:12Z","updated_at":"2018-04-03T16:11:00Z","pushed_at":"2018-04-11T06:59:20Z","git_url":"git://github.com/wildfly/wildfly-proposals.git","ssh_url":"git@github.com:wildfly/wildfly-proposals.git","clone_url":"https://github.com/wildfly/wildfly-proposals.git","svn_url":"https://github.com/wildfly/wildfly-proposals","homepage":null,"size":46,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":26,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48"},"html":{"href":"https://github.com/wildfly/wildfly-proposals/pull/48"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/48"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-proposals/statuses/e27f8cb609102a39cc1cc6806f5429ac921e5cc1"}},"author_association":"NONE"}}
{"actor":{"display_login":"MMarus"}}