{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/224047710","pull_request_review_id":163319438,"id":224047710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDA0NzcxMA==","diff_hunk":"@@ -1669,7 +1669,7 @@ UniValue converttopsbt(const JSONRPCRequest& request)\n \n     // Remove all scriptSigs and scriptWitnesses from inputs\n     for (CTxIn& input : tx.vin) {\n-        if ((!input.scriptSig.empty() || !input.scriptWitness.IsNull()) && (request.params[1].isNull() || (!request.params[1].isNull() && request.params[1].get_bool()))) {\n+        if ((!input.scriptSig.empty() || !input.scriptWitness.IsNull()) && !permitsigdata) {","path":"src/rpc/rawtransaction.cpp","position":5,"original_position":5,"commit_id":"88a79cb436b30b39d37d139da723f5a31e9d161b","original_commit_id":"88a79cb436b30b39d37d139da723f5a31e9d161b","user":{"login":"promag","id":3534524,"node_id":"MDQ6VXNlcjM1MzQ1MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"body":"Why? `permitsigdata` is enough?","created_at":"2018-10-10T12:07:06Z","updated_at":"2018-10-10T12:07:07Z","html_url":"https://github.com/bitcoin/bitcoin/pull/14356#discussion_r224047710","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/224047710"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14356#discussion_r224047710"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356"}},"in_reply_to_id":221774107},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356","id":219179522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTc5NTIy","html_url":"https://github.com/bitcoin/bitcoin/pull/14356","diff_url":"https://github.com/bitcoin/bitcoin/pull/14356.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14356.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14356","number":14356,"state":"open","locked":false,"title":"fix converttopsbt permitsigdata arg, add basic test","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"body":"The final check for extraneous sigdata has a flipped boolean, resulting in incorrect behavior.\r\n\r\nResolves https://github.com/bitcoin/bitcoin/issues/14355","created_at":"2018-09-30T02:10:56Z","updated_at":"2018-10-10T12:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3058242d6d74dd61309f3eb67cdc837d726596e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":294841739,"node_id":"MDU6TGFiZWwyOTQ4NDE3Mzk=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Needs%20backport","name":"Needs backport","color":"ff8200","default":false},{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/39","html_url":"https://github.com/bitcoin/bitcoin/milestone/39","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/39/labels","id":3563443,"node_id":"MDk6TWlsZXN0b25lMzU2MzQ0Mw==","number":39,"title":"0.17.1","description":"","creator":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":2,"state":"open","created_at":"2018-08-12T23:47:01Z","updated_at":"2018-10-10T04:26:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14356/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/88a79cb436b30b39d37d139da723f5a31e9d161b","head":{"label":"instagibbs:converttopsbt_strip","ref":"converttopsbt_strip","sha":"88a79cb436b30b39d37d139da723f5a31e9d161b","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"repo":{"id":13910191,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxMDE5MQ==","name":"bitcoin","full_name":"instagibbs/bitcoin","private":false,"owner":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/instagibbs/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/instagibbs/bitcoin","forks_url":"https://api.github.com/repos/instagibbs/bitcoin/forks","keys_url":"https://api.github.com/repos/instagibbs/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instagibbs/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instagibbs/bitcoin/teams","hooks_url":"https://api.github.com/repos/instagibbs/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/instagibbs/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/instagibbs/bitcoin/events","assignees_url":"https://api.github.com/repos/instagibbs/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/instagibbs/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/instagibbs/bitcoin/tags","blobs_url":"https://api.github.com/repos/instagibbs/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instagibbs/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instagibbs/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/instagibbs/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instagibbs/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/instagibbs/bitcoin/languages","stargazers_url":"https://api.github.com/repos/instagibbs/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/instagibbs/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/instagibbs/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/instagibbs/bitcoin/subscription","commits_url":"https://api.github.com/repos/instagibbs/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/instagibbs/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/instagibbs/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/instagibbs/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/instagibbs/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/instagibbs/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instagibbs/bitcoin/merges","archive_url":"https://api.github.com/repos/instagibbs/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instagibbs/bitcoin/downloads","issues_url":"https://api.github.com/repos/instagibbs/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/instagibbs/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/instagibbs/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/instagibbs/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instagibbs/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/instagibbs/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/instagibbs/bitcoin/deployments","created_at":"2013-10-27T20:56:53Z","updated_at":"2018-08-21T18:58:40Z","pushed_at":"2018-10-08T07:24:45Z","git_url":"git://github.com/instagibbs/bitcoin.git","ssh_url":"git@github.com:instagibbs/bitcoin.git","clone_url":"https://github.com/instagibbs/bitcoin.git","svn_url":"https://github.com/instagibbs/bitcoin","homepage":"http://www.bitcoin.org","size":108818,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c9327306b580bb161d1732c0a0260b46c0df015c","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-10-10T11:50:59Z","pushed_at":"2018-10-10T10:38:20Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":114361,"stargazers_count":35224,"watchers_count":35224,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21302,"mirror_url":null,"archived":false,"open_issues_count":881,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21302,"open_issues":881,"watchers":35224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14356"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14356"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14356/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14356/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/88a79cb436b30b39d37d139da723f5a31e9d161b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"promag"}}