{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/173379390","pull_request_review_id":102560739,"id":173379390,"diff_hunk":"@@ -17,7 +18,7 @@\n \n     private String validName = \"validName\";\n     private String validId = \"validId\";\n-    private String validTimeZone = \"validTimeZone\";\n+    private ZoneId validTimeZone = ZoneId.of(\"UTC\");","path":"src/test/java/teammates/test/cases/datatransfer/CourseAttributesTest.java","position":13,"original_position":13,"commit_id":"3caaae6f6cf1d64b59d29c9ec9426fec692873bf","original_commit_id":"3caaae6f6cf1d64b59d29c9ec9426fec692873bf","user":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"body":"This is a test. It should explicitly states what timezone it's using","created_at":"2018-03-09T07:17:14Z","updated_at":"2018-03-09T07:17:15Z","html_url":"https://github.com/TEAMMATES/teammates/pull/8613#discussion_r173379390","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/173379390"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8613#discussion_r173379390"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613"}},"in_reply_to_id":173376693},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613","id":173737797,"html_url":"https://github.com/TEAMMATES/teammates/pull/8613","diff_url":"https://github.com/TEAMMATES/teammates/pull/8613.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8613.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8613","number":8613,"state":"open","locked":false,"title":"Change `CourseAttributes.timeZone` from  `String` to `ZoneId` #8362","user":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"body":"<!-- Fixes #8362 -->\r\nPart of #8362\r\n\r\nThis PR changes the `timeZone` field in`CourseAttributes` to `ZoneId` so that other classes that need time zone information can use it directly. Since `CourseAttributes` now always contains valid time zone, validation of the user supplied time zone field is done in `CourseLogic`. This comes after the Action level so usage of `CourseAttributes` in the Action level is removed.\r\n","created_at":"2018-03-08T13:38:49Z","updated_at":"2018-03-09T07:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5736e1699a6addbc0a1278375c7634102fce3fd","assignee":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"assignees":[{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars0.githubusercontent.com/u/6811428?v=4","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":98049565,"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.ToReview","name":"s.ToReview","color":"47B74E","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8613/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/3caaae6f6cf1d64b59d29c9ec9426fec692873bf","head":{"label":"tran-tien-dat:course-timezone","ref":"course-timezone","sha":"3caaae6f6cf1d64b59d29c9ec9426fec692873bf","user":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"repo":{"id":117534256,"name":"teammates","full_name":"tran-tien-dat/teammates","owner":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tran-tien-dat/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/tran-tien-dat/teammates","forks_url":"https://api.github.com/repos/tran-tien-dat/teammates/forks","keys_url":"https://api.github.com/repos/tran-tien-dat/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tran-tien-dat/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tran-tien-dat/teammates/teams","hooks_url":"https://api.github.com/repos/tran-tien-dat/teammates/hooks","issue_events_url":"https://api.github.com/repos/tran-tien-dat/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/tran-tien-dat/teammates/events","assignees_url":"https://api.github.com/repos/tran-tien-dat/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/tran-tien-dat/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/tran-tien-dat/teammates/tags","blobs_url":"https://api.github.com/repos/tran-tien-dat/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tran-tien-dat/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tran-tien-dat/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/tran-tien-dat/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tran-tien-dat/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/tran-tien-dat/teammates/languages","stargazers_url":"https://api.github.com/repos/tran-tien-dat/teammates/stargazers","contributors_url":"https://api.github.com/repos/tran-tien-dat/teammates/contributors","subscribers_url":"https://api.github.com/repos/tran-tien-dat/teammates/subscribers","subscription_url":"https://api.github.com/repos/tran-tien-dat/teammates/subscription","commits_url":"https://api.github.com/repos/tran-tien-dat/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/tran-tien-dat/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/tran-tien-dat/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/tran-tien-dat/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/tran-tien-dat/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/tran-tien-dat/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tran-tien-dat/teammates/merges","archive_url":"https://api.github.com/repos/tran-tien-dat/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tran-tien-dat/teammates/downloads","issues_url":"https://api.github.com/repos/tran-tien-dat/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/tran-tien-dat/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/tran-tien-dat/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/tran-tien-dat/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tran-tien-dat/teammates/labels{/name}","releases_url":"https://api.github.com/repos/tran-tien-dat/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/tran-tien-dat/teammates/deployments","created_at":"2018-01-15T10:58:57Z","updated_at":"2018-01-15T10:59:07Z","pushed_at":"2018-03-08T14:06:30Z","git_url":"git://github.com/tran-tien-dat/teammates.git","ssh_url":"git@github.com:tran-tien-dat/teammates.git","clone_url":"https://github.com/tran-tien-dat/teammates.git","svn_url":"https://github.com/tran-tien-dat/teammates","homepage":"https://teammatesv4.appspot.com/","size":192598,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:java-time-migration","ref":"java-time-migration","sha":"130096a74e38935812743e0513a233244d8fc2e5","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2018-03-08T13:45:26Z","pushed_at":"2018-03-08T14:06:31Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":195557,"stargazers_count":560,"watchers_count":560,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1320,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1320,"open_issues":284,"watchers":560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8613"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8613"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8613/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8613/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/3caaae6f6cf1d64b59d29c9ec9426fec692873bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tran-tien-dat"}}