{"action":"created","issue":{"url":"https://api.github.com/repos/rugk/offline-qr-code/issues/68","repository_url":"https://api.github.com/repos/rugk/offline-qr-code","labels_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/68/comments","events_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/68/events","html_url":"https://github.com/rugk/offline-qr-code/issues/68","id":321663472,"number":68,"title":"Use CSS variables","user":{"login":"rugk","id":11966684,"avatar_url":"https://avatars3.githubusercontent.com/u/11966684?v=4","gravatar_id":"","url":"https://api.github.com/users/rugk","html_url":"https://github.com/rugk","followers_url":"https://api.github.com/users/rugk/followers","following_url":"https://api.github.com/users/rugk/following{/other_user}","gists_url":"https://api.github.com/users/rugk/gists{/gist_id}","starred_url":"https://api.github.com/users/rugk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rugk/subscriptions","organizations_url":"https://api.github.com/users/rugk/orgs","repos_url":"https://api.github.com/users/rugk/repos","events_url":"https://api.github.com/users/rugk/events{/privacy}","received_events_url":"https://api.github.com/users/rugk/received_events","type":"User","site_admin":false},"labels":[{"id":906468340,"url":"https://api.github.com/repos/rugk/offline-qr-code/labels/code%20quality","name":"code quality","color":"cbe876","default":false},{"id":898703723,"url":"https://api.github.com/repos/rugk/offline-qr-code/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-09T17:44:45Z","updated_at":"2018-05-14T13:29:51Z","closed_at":null,"author_association":"OWNER","body":"We do have really too many hardcoded CSS values… (especially colors and stuff, which has assigned names in the Photon design guide)\r\n\r\nSo this needs to be changed.\r\n\r\nSee:\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables\r\n\r\nIMHO all variables can be created in the `common.css` to have them in one place even if we might not use them in all cases."},"comment":{"url":"https://api.github.com/repos/rugk/offline-qr-code/issues/comments/388816658","html_url":"https://github.com/rugk/offline-qr-code/issues/68#issuecomment-388816658","issue_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/68","id":388816658,"user":{"login":"rugk","id":11966684,"avatar_url":"https://avatars3.githubusercontent.com/u/11966684?v=4","gravatar_id":"","url":"https://api.github.com/users/rugk","html_url":"https://github.com/rugk","followers_url":"https://api.github.com/users/rugk/followers","following_url":"https://api.github.com/users/rugk/following{/other_user}","gists_url":"https://api.github.com/users/rugk/gists{/gist_id}","starred_url":"https://api.github.com/users/rugk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rugk/subscriptions","organizations_url":"https://api.github.com/users/rugk/orgs","repos_url":"https://api.github.com/users/rugk/repos","events_url":"https://api.github.com/users/rugk/events{/privacy}","received_events_url":"https://api.github.com/users/rugk/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T13:29:51Z","updated_at":"2018-05-14T13:29:51Z","author_association":"OWNER","body":"Hi @anirudh-modi,\r\nthanks for your interest in contributing to this project! :tada: :+1: \r\nI hope you'll like this project and can enjoy hacking on it… :smiley:\r\n\r\n> Kindly let me know if these are the variables naming conventions which needs to be followed?\r\n\r\nJust use the style, the Firefox photon guide uses. So we don't need any conversion of the variable names here, that makes copy and past easier. :wink: \r\n\r\n> And should I make the desired changes in common.css for declaration of variables and then go on to change color in files mentioned below\r\n\r\nIndeed, that's what I imagine. :+1: \r\n\r\n> Shall there be css variable for font size also??\r\n\r\nGood question, but I don't think so. Firstly currently I use some custom sizes, which just match the text size the Firefox add-on settings page uses, so it may not actually be covered in that guide.\r\nSecondly, the Photon guide says it is different from OS and then you have all these variants (weight and stuff…), so i think it is not worth it currently."}}
{"actor":{"display_login":"rugk"}}