{"action":"created","comment":{"url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/comments/168959833","pull_request_review_id":97410806,"id":168959833,"diff_hunk":"@@ -133,15 +130,15 @@ public void move(double speed) {\n \t\t\treturn;\n \t\t}\n \n-\t\tdouble currentHeight = getHeightFeet();\n-\t\tfor (Stops stop : Stops.values()) {\n-\t\t\tif ((previousHeight < stop.height && currentHeight >= stop.height)\n-\t\t\t\t\t|| (previousHeight > stop.height && currentHeight <= stop.height)) {\n-\t\t\t\tDriverStation.getInstance().getNavRumbler().rumble(200, 0.8);\n-\t\t\t}\n-\t\t}\n+\t\tdouble currentHeight = getHeightInches();\n+\t\t//\t\tfor (Stops stop : Stops.values()) {\n+\t\t//\t\t\tif ((previousHeight < stop.height && currentHeight >= stop.height)\n+\t\t//\t\t\t\t\t|| (previousHeight > stop.height && currentHeight <= stop.height)) {\n+\t\t//\t\t\t\tDriverStation.getInstance().getNavRumbler().rumble(200, 0.8);\n+\t\t//\t\t\t}\n+\t\t//\t\t}\n \n-\t\tLOGGER.debug(\"Height prev=\" + previousHeight + \" current=\" + currentHeight);\n+\t\t//LOGGER.debug(\"Height prev=\" + previousHeight + \" current=\" + currentHeight);","path":"src/org/usfirst/frc/team467/robot/Elevator.java","position":null,"original_position":152,"commit_id":"4a12cbefdd712db9f88991d16ed891035caf26d8","original_commit_id":"ac01ff66dd9b26b17fff1d13ef907978698176f1","user":{"login":"john-petrangelo","id":9003948,"avatar_url":"https://avatars1.githubusercontent.com/u/9003948?v=4","gravatar_id":"","url":"https://api.github.com/users/john-petrangelo","html_url":"https://github.com/john-petrangelo","followers_url":"https://api.github.com/users/john-petrangelo/followers","following_url":"https://api.github.com/users/john-petrangelo/following{/other_user}","gists_url":"https://api.github.com/users/john-petrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/john-petrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-petrangelo/subscriptions","organizations_url":"https://api.github.com/users/john-petrangelo/orgs","repos_url":"https://api.github.com/users/john-petrangelo/repos","events_url":"https://api.github.com/users/john-petrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/john-petrangelo/received_events","type":"User","site_admin":false},"body":"Remove this comment.","created_at":"2018-02-18T17:57:38Z","updated_at":"2018-02-18T18:03:37Z","html_url":"https://github.com/team467/Robot2018-Competition/pull/35#discussion_r168959833","pull_request_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/comments/168959833"},"html":{"href":"https://github.com/team467/Robot2018-Competition/pull/35#discussion_r168959833"},"pull_request":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35","id":169841223,"html_url":"https://github.com/team467/Robot2018-Competition/pull/35","diff_url":"https://github.com/team467/Robot2018-Competition/pull/35.diff","patch_url":"https://github.com/team467/Robot2018-Competition/pull/35.patch","issue_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/35","number":35,"state":"open","locked":false,"title":"Elevator sensor","user":{"login":"npetrangelo","id":10442710,"avatar_url":"https://avatars3.githubusercontent.com/u/10442710?v=4","gravatar_id":"","url":"https://api.github.com/users/npetrangelo","html_url":"https://github.com/npetrangelo","followers_url":"https://api.github.com/users/npetrangelo/followers","following_url":"https://api.github.com/users/npetrangelo/following{/other_user}","gists_url":"https://api.github.com/users/npetrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/npetrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npetrangelo/subscriptions","organizations_url":"https://api.github.com/users/npetrangelo/orgs","repos_url":"https://api.github.com/users/npetrangelo/repos","events_url":"https://api.github.com/users/npetrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/npetrangelo/received_events","type":"User","site_admin":false},"body":"Tuning for the elevator presets","created_at":"2018-02-18T17:45:25Z","updated_at":"2018-02-18T18:03:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"113d20b66bd1063fa9b56c425d48fd004a79b179","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35/commits","review_comments_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35/comments","review_comment_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/35/comments","statuses_url":"https://api.github.com/repos/team467/Robot2018-Competition/statuses/4a12cbefdd712db9f88991d16ed891035caf26d8","head":{"label":"team467:elevatorSensor","ref":"elevatorSensor","sha":"4a12cbefdd712db9f88991d16ed891035caf26d8","user":{"login":"team467","id":1207525,"avatar_url":"https://avatars3.githubusercontent.com/u/1207525?v=4","gravatar_id":"","url":"https://api.github.com/users/team467","html_url":"https://github.com/team467","followers_url":"https://api.github.com/users/team467/followers","following_url":"https://api.github.com/users/team467/following{/other_user}","gists_url":"https://api.github.com/users/team467/gists{/gist_id}","starred_url":"https://api.github.com/users/team467/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team467/subscriptions","organizations_url":"https://api.github.com/users/team467/orgs","repos_url":"https://api.github.com/users/team467/repos","events_url":"https://api.github.com/users/team467/events{/privacy}","received_events_url":"https://api.github.com/users/team467/received_events","type":"Organization","site_admin":false},"repo":{"id":116311688,"name":"Robot2018-Competition","full_name":"team467/Robot2018-Competition","owner":{"login":"team467","id":1207525,"avatar_url":"https://avatars3.githubusercontent.com/u/1207525?v=4","gravatar_id":"","url":"https://api.github.com/users/team467","html_url":"https://github.com/team467","followers_url":"https://api.github.com/users/team467/followers","following_url":"https://api.github.com/users/team467/following{/other_user}","gists_url":"https://api.github.com/users/team467/gists{/gist_id}","starred_url":"https://api.github.com/users/team467/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team467/subscriptions","organizations_url":"https://api.github.com/users/team467/orgs","repos_url":"https://api.github.com/users/team467/repos","events_url":"https://api.github.com/users/team467/events{/privacy}","received_events_url":"https://api.github.com/users/team467/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/team467/Robot2018-Competition","description":null,"fork":false,"url":"https://api.github.com/repos/team467/Robot2018-Competition","forks_url":"https://api.github.com/repos/team467/Robot2018-Competition/forks","keys_url":"https://api.github.com/repos/team467/Robot2018-Competition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/team467/Robot2018-Competition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/team467/Robot2018-Competition/teams","hooks_url":"https://api.github.com/repos/team467/Robot2018-Competition/hooks","issue_events_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/events{/number}","events_url":"https://api.github.com/repos/team467/Robot2018-Competition/events","assignees_url":"https://api.github.com/repos/team467/Robot2018-Competition/assignees{/user}","branches_url":"https://api.github.com/repos/team467/Robot2018-Competition/branches{/branch}","tags_url":"https://api.github.com/repos/team467/Robot2018-Competition/tags","blobs_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/refs{/sha}","trees_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/team467/Robot2018-Competition/statuses/{sha}","languages_url":"https://api.github.com/repos/team467/Robot2018-Competition/languages","stargazers_url":"https://api.github.com/repos/team467/Robot2018-Competition/stargazers","contributors_url":"https://api.github.com/repos/team467/Robot2018-Competition/contributors","subscribers_url":"https://api.github.com/repos/team467/Robot2018-Competition/subscribers","subscription_url":"https://api.github.com/repos/team467/Robot2018-Competition/subscription","commits_url":"https://api.github.com/repos/team467/Robot2018-Competition/commits{/sha}","git_commits_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/commits{/sha}","comments_url":"https://api.github.com/repos/team467/Robot2018-Competition/comments{/number}","issue_comment_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/comments{/number}","contents_url":"https://api.github.com/repos/team467/Robot2018-Competition/contents/{+path}","compare_url":"https://api.github.com/repos/team467/Robot2018-Competition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/team467/Robot2018-Competition/merges","archive_url":"https://api.github.com/repos/team467/Robot2018-Competition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/team467/Robot2018-Competition/downloads","issues_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues{/number}","pulls_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls{/number}","milestones_url":"https://api.github.com/repos/team467/Robot2018-Competition/milestones{/number}","notifications_url":"https://api.github.com/repos/team467/Robot2018-Competition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/team467/Robot2018-Competition/labels{/name}","releases_url":"https://api.github.com/repos/team467/Robot2018-Competition/releases{/id}","deployments_url":"https://api.github.com/repos/team467/Robot2018-Competition/deployments","created_at":"2018-01-04T21:57:36Z","updated_at":"2018-01-13T22:15:03Z","pushed_at":"2018-02-18T18:01:47Z","git_url":"git://github.com/team467/Robot2018-Competition.git","ssh_url":"git@github.com:team467/Robot2018-Competition.git","clone_url":"https://github.com/team467/Robot2018-Competition.git","svn_url":"https://github.com/team467/Robot2018-Competition","homepage":null,"size":3114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"team467:master","ref":"master","sha":"40fb25cf0c178dbe9b455571814ec6587b1c87d6","user":{"login":"team467","id":1207525,"avatar_url":"https://avatars3.githubusercontent.com/u/1207525?v=4","gravatar_id":"","url":"https://api.github.com/users/team467","html_url":"https://github.com/team467","followers_url":"https://api.github.com/users/team467/followers","following_url":"https://api.github.com/users/team467/following{/other_user}","gists_url":"https://api.github.com/users/team467/gists{/gist_id}","starred_url":"https://api.github.com/users/team467/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team467/subscriptions","organizations_url":"https://api.github.com/users/team467/orgs","repos_url":"https://api.github.com/users/team467/repos","events_url":"https://api.github.com/users/team467/events{/privacy}","received_events_url":"https://api.github.com/users/team467/received_events","type":"Organization","site_admin":false},"repo":{"id":116311688,"name":"Robot2018-Competition","full_name":"team467/Robot2018-Competition","owner":{"login":"team467","id":1207525,"avatar_url":"https://avatars3.githubusercontent.com/u/1207525?v=4","gravatar_id":"","url":"https://api.github.com/users/team467","html_url":"https://github.com/team467","followers_url":"https://api.github.com/users/team467/followers","following_url":"https://api.github.com/users/team467/following{/other_user}","gists_url":"https://api.github.com/users/team467/gists{/gist_id}","starred_url":"https://api.github.com/users/team467/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team467/subscriptions","organizations_url":"https://api.github.com/users/team467/orgs","repos_url":"https://api.github.com/users/team467/repos","events_url":"https://api.github.com/users/team467/events{/privacy}","received_events_url":"https://api.github.com/users/team467/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/team467/Robot2018-Competition","description":null,"fork":false,"url":"https://api.github.com/repos/team467/Robot2018-Competition","forks_url":"https://api.github.com/repos/team467/Robot2018-Competition/forks","keys_url":"https://api.github.com/repos/team467/Robot2018-Competition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/team467/Robot2018-Competition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/team467/Robot2018-Competition/teams","hooks_url":"https://api.github.com/repos/team467/Robot2018-Competition/hooks","issue_events_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/events{/number}","events_url":"https://api.github.com/repos/team467/Robot2018-Competition/events","assignees_url":"https://api.github.com/repos/team467/Robot2018-Competition/assignees{/user}","branches_url":"https://api.github.com/repos/team467/Robot2018-Competition/branches{/branch}","tags_url":"https://api.github.com/repos/team467/Robot2018-Competition/tags","blobs_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/refs{/sha}","trees_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/team467/Robot2018-Competition/statuses/{sha}","languages_url":"https://api.github.com/repos/team467/Robot2018-Competition/languages","stargazers_url":"https://api.github.com/repos/team467/Robot2018-Competition/stargazers","contributors_url":"https://api.github.com/repos/team467/Robot2018-Competition/contributors","subscribers_url":"https://api.github.com/repos/team467/Robot2018-Competition/subscribers","subscription_url":"https://api.github.com/repos/team467/Robot2018-Competition/subscription","commits_url":"https://api.github.com/repos/team467/Robot2018-Competition/commits{/sha}","git_commits_url":"https://api.github.com/repos/team467/Robot2018-Competition/git/commits{/sha}","comments_url":"https://api.github.com/repos/team467/Robot2018-Competition/comments{/number}","issue_comment_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues/comments{/number}","contents_url":"https://api.github.com/repos/team467/Robot2018-Competition/contents/{+path}","compare_url":"https://api.github.com/repos/team467/Robot2018-Competition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/team467/Robot2018-Competition/merges","archive_url":"https://api.github.com/repos/team467/Robot2018-Competition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/team467/Robot2018-Competition/downloads","issues_url":"https://api.github.com/repos/team467/Robot2018-Competition/issues{/number}","pulls_url":"https://api.github.com/repos/team467/Robot2018-Competition/pulls{/number}","milestones_url":"https://api.github.com/repos/team467/Robot2018-Competition/milestones{/number}","notifications_url":"https://api.github.com/repos/team467/Robot2018-Competition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/team467/Robot2018-Competition/labels{/name}","releases_url":"https://api.github.com/repos/team467/Robot2018-Competition/releases{/id}","deployments_url":"https://api.github.com/repos/team467/Robot2018-Competition/deployments","created_at":"2018-01-04T21:57:36Z","updated_at":"2018-01-13T22:15:03Z","pushed_at":"2018-02-18T18:01:47Z","git_url":"git://github.com/team467/Robot2018-Competition.git","ssh_url":"git@github.com:team467/Robot2018-Competition.git","clone_url":"https://github.com/team467/Robot2018-Competition.git","svn_url":"https://github.com/team467/Robot2018-Competition","homepage":null,"size":3114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35"},"html":{"href":"https://github.com/team467/Robot2018-Competition/pull/35"},"issue":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/issues/35"},"comments":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/team467/Robot2018-Competition/statuses/4a12cbefdd712db9f88991d16ed891035caf26d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"john-petrangelo"}}