{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/11997","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/11997/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/11997/comments","events_url":"https://api.github.com/repos/angular/material2/issues/11997/events","html_url":"https://github.com/angular/material2/pull/11997","id":337210094,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDczODQ0","number":11997,"title":"fix(ripple): don't launch ripple for fake mouse events","user":{"login":"crisbeto","id":4450522,"node_id":"MDQ6VXNlcjQ0NTA1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"labels":[{"id":308798701,"node_id":"MDU6TGFiZWwzMDg3OTg3MDE=","url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":311422716,"node_id":"MDU6TGFiZWwzMTE0MjI3MTY=","url":"https://api.github.com/repos/angular/material2/labels/pr:%20lgtm","name":"pr: lgtm","color":"009800","default":false},{"id":408329699,"node_id":"MDU6TGFiZWw0MDgzMjk2OTk=","url":"https://api.github.com/repos/angular/material2/labels/pr:%20merge%20ready","name":"pr: merge ready","color":"a3f579","default":false},{"id":770558890,"node_id":"MDU6TGFiZWw3NzA1NTg4OTA=","url":"https://api.github.com/repos/angular/material2/labels/target:%20patch","name":"target: patch","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":{"login":"jelbourn","id":838736,"node_id":"MDQ6VXNlcjgzODczNg==","avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"node_id":"MDQ6VXNlcjgzODczNg==","avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},{"login":"DevVersion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-06-30T12:06:16Z","updated_at":"2018-08-29T13:52:29Z","closed_at":"2018-08-27T17:04:13Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/11997","html_url":"https://github.com/angular/material2/pull/11997","diff_url":"https://github.com/angular/material2/pull/11997.diff","patch_url":"https://github.com/angular/material2/pull/11997.patch"},"body":"When using a screen reader the ripples can get fake mouse events when pressing space or enter. With the following changes we skip launching the ripples in these cases, in order to align the experience with the non-screen-reader.\r\n\r\nFor reference:\r\n![demo](https://user-images.githubusercontent.com/4450522/42125013-b6fbe024-7c6e-11e8-89b7-672a3eb09b6e.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/416961556","html_url":"https://github.com/angular/material2/pull/11997#issuecomment-416961556","issue_url":"https://api.github.com/repos/angular/material2/issues/11997","id":416961556,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjk2MTU1Ng==","user":{"login":"mik01aj","id":3027415,"node_id":"MDQ6VXNlcjMwMjc0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3027415?v=4","gravatar_id":"","url":"https://api.github.com/users/mik01aj","html_url":"https://github.com/mik01aj","followers_url":"https://api.github.com/users/mik01aj/followers","following_url":"https://api.github.com/users/mik01aj/following{/other_user}","gists_url":"https://api.github.com/users/mik01aj/gists{/gist_id}","starred_url":"https://api.github.com/users/mik01aj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mik01aj/subscriptions","organizations_url":"https://api.github.com/users/mik01aj/orgs","repos_url":"https://api.github.com/users/mik01aj/repos","events_url":"https://api.github.com/users/mik01aj/events{/privacy}","received_events_url":"https://api.github.com/users/mik01aj/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T13:52:29Z","updated_at":"2018-08-29T13:52:29Z","author_association":"NONE","body":"Hi @crisbeto & @jelbourn,\r\nI was implementing a keyboard shortcuts service recently and thought it would be nice to also show the user the element they are triggering. I ended up dispatching fake events (mousedown, mouseup, click) on the button to trigger both the button action and ripples. I was able to also make it work after this PR, but it made me wonder - should I do this at all? I think the visual feedback makes it clearer for the user what is happening, but on the other hand I haven't seen apps doing this so I'm not sure."}}
{"actor":{"display_login":"mik01aj"}}