{"action":"created","comment":{"url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments/209266636","pull_request_review_id":145250420,"id":209266636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI2NjYzNg==","diff_hunk":"@@ -508,6 +508,9 @@ template <typename MatrixType, typename MatrixData>\n inline void read_impl(MatrixType *mtx, const MatrixData &data)\n {\n     auto tmp = MatrixType::create(mtx->get_executor()->get_master(), data.size);\n+    if (mtx->get_executor() != mtx->get_executor()->get_master()) {\n+        MatrixType::create(mtx->get_executor(), data.size);","path":"core/matrix/dense.cpp","position":5,"original_position":5,"commit_id":"b7668f7ab16eb8084b721dd22b97f364fead9218","original_commit_id":"b7668f7ab16eb8084b721dd22b97f364fead9218","user":{"login":"yhmtsai","id":19565938,"node_id":"MDQ6VXNlcjE5NTY1OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/19565938?v=4","gravatar_id":"","url":"https://api.github.com/users/yhmtsai","html_url":"https://github.com/yhmtsai","followers_url":"https://api.github.com/users/yhmtsai/followers","following_url":"https://api.github.com/users/yhmtsai/following{/other_user}","gists_url":"https://api.github.com/users/yhmtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhmtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhmtsai/subscriptions","organizations_url":"https://api.github.com/users/yhmtsai/orgs","repos_url":"https://api.github.com/users/yhmtsai/repos","events_url":"https://api.github.com/users/yhmtsai/events{/privacy}","received_events_url":"https://api.github.com/users/yhmtsai/received_events","type":"User","site_admin":false},"body":"It only works on the cuda executor.\r\nIt tries to create the matrix on the cuda device before setting value.\r\nWhen using try-catch outside, it stops earlier and doesn't crash by OOM.\r\nIt can avoid the malloc problem when the matrix is on cuda.\r\n(Assume that cpu memory is always larger than cuda memory.\r\n\r\nthe commit disabling OOM command needs the admin permission, so I still face the OOM problem during testing.\r\n","created_at":"2018-08-10T13:53:59Z","updated_at":"2018-08-10T13:53:59Z","html_url":"https://github.com/ginkgo-project/ginkgo/pull/103#discussion_r209266636","pull_request_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments/209266636"},"html":{"href":"https://github.com/ginkgo-project/ginkgo/pull/103#discussion_r209266636"},"pull_request":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103"}},"in_reply_to_id":209262597},"pull_request":{"url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103","id":207341005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzQxMDA1","html_url":"https://github.com/ginkgo-project/ginkgo/pull/103","diff_url":"https://github.com/ginkgo-project/ginkgo/pull/103.diff","patch_url":"https://github.com/ginkgo-project/ginkgo/pull/103.patch","issue_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/103","number":103,"state":"open","locked":false,"title":"Simple spmv","user":{"login":"yhmtsai","id":19565938,"node_id":"MDQ6VXNlcjE5NTY1OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/19565938?v=4","gravatar_id":"","url":"https://api.github.com/users/yhmtsai","html_url":"https://github.com/yhmtsai","followers_url":"https://api.github.com/users/yhmtsai/followers","following_url":"https://api.github.com/users/yhmtsai/following{/other_user}","gists_url":"https://api.github.com/users/yhmtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhmtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhmtsai/subscriptions","organizations_url":"https://api.github.com/users/yhmtsai/orgs","repos_url":"https://api.github.com/users/yhmtsai/repos","events_url":"https://api.github.com/users/yhmtsai/events{/privacy}","received_events_url":"https://api.github.com/users/yhmtsai/received_events","type":"User","site_admin":false},"body":"add simple_spmv with some CUDA existing matrix format spmv.\r\n\r\nThe available format:\r\nGinkgo's implementation: Coo, Ell, Sellp, Hybrid, Hybrid20, Hybrid40, Hybrid60, Hybrid80 (Hybrid20 uses imbalance_limit strategy with 20%)\r\nCusparse implementation: CuspCoo, CuspCsr, CuspCsrex, CuspCsrmp, CuspEll, CuspHybrid.\r\nNote. Cusparse does not implement Coo and Ell directly, so I use the CuspHybrid to implement them.\r\n\r\nUsage: ./simple_spmv [device_id] matlab [source_folder] [matrix_list] format_1 format_2 ....\r\n","created_at":"2018-08-09T14:43:13Z","updated_at":"2018-08-10T13:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e491d7fac31ad95143e869d08d467f50d40ccee5","assignee":{"login":"gflegar","id":1261711,"node_id":"MDQ6VXNlcjEyNjE3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1261711?v=4","gravatar_id":"","url":"https://api.github.com/users/gflegar","html_url":"https://github.com/gflegar","followers_url":"https://api.github.com/users/gflegar/followers","following_url":"https://api.github.com/users/gflegar/following{/other_user}","gists_url":"https://api.github.com/users/gflegar/gists{/gist_id}","starred_url":"https://api.github.com/users/gflegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflegar/subscriptions","organizations_url":"https://api.github.com/users/gflegar/orgs","repos_url":"https://api.github.com/users/gflegar/repos","events_url":"https://api.github.com/users/gflegar/events{/privacy}","received_events_url":"https://api.github.com/users/gflegar/received_events","type":"User","site_admin":false},"assignees":[{"login":"gflegar","id":1261711,"node_id":"MDQ6VXNlcjEyNjE3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1261711?v=4","gravatar_id":"","url":"https://api.github.com/users/gflegar","html_url":"https://github.com/gflegar","followers_url":"https://api.github.com/users/gflegar/followers","following_url":"https://api.github.com/users/gflegar/following{/other_user}","gists_url":"https://api.github.com/users/gflegar/gists{/gist_id}","starred_url":"https://api.github.com/users/gflegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflegar/subscriptions","organizations_url":"https://api.github.com/users/gflegar/orgs","repos_url":"https://api.github.com/users/gflegar/repos","events_url":"https://api.github.com/users/gflegar/events{/privacy}","received_events_url":"https://api.github.com/users/gflegar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103/commits","review_comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103/comments","review_comment_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/103/comments","statuses_url":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/b7668f7ab16eb8084b721dd22b97f364fead9218","head":{"label":"yhmtsai:simple_spmv","ref":"simple_spmv","sha":"b7668f7ab16eb8084b721dd22b97f364fead9218","user":{"login":"yhmtsai","id":19565938,"node_id":"MDQ6VXNlcjE5NTY1OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/19565938?v=4","gravatar_id":"","url":"https://api.github.com/users/yhmtsai","html_url":"https://github.com/yhmtsai","followers_url":"https://api.github.com/users/yhmtsai/followers","following_url":"https://api.github.com/users/yhmtsai/following{/other_user}","gists_url":"https://api.github.com/users/yhmtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhmtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhmtsai/subscriptions","organizations_url":"https://api.github.com/users/yhmtsai/orgs","repos_url":"https://api.github.com/users/yhmtsai/repos","events_url":"https://api.github.com/users/yhmtsai/events{/privacy}","received_events_url":"https://api.github.com/users/yhmtsai/received_events","type":"User","site_admin":false},"repo":{"id":118732442,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg3MzI0NDI=","name":"ginkgo","full_name":"yhmtsai/ginkgo","owner":{"login":"yhmtsai","id":19565938,"node_id":"MDQ6VXNlcjE5NTY1OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/19565938?v=4","gravatar_id":"","url":"https://api.github.com/users/yhmtsai","html_url":"https://github.com/yhmtsai","followers_url":"https://api.github.com/users/yhmtsai/followers","following_url":"https://api.github.com/users/yhmtsai/following{/other_user}","gists_url":"https://api.github.com/users/yhmtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhmtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhmtsai/subscriptions","organizations_url":"https://api.github.com/users/yhmtsai/orgs","repos_url":"https://api.github.com/users/yhmtsai/repos","events_url":"https://api.github.com/users/yhmtsai/events{/privacy}","received_events_url":"https://api.github.com/users/yhmtsai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yhmtsai/ginkgo","description":"Numerical linear algebra software package","fork":true,"url":"https://api.github.com/repos/yhmtsai/ginkgo","forks_url":"https://api.github.com/repos/yhmtsai/ginkgo/forks","keys_url":"https://api.github.com/repos/yhmtsai/ginkgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yhmtsai/ginkgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yhmtsai/ginkgo/teams","hooks_url":"https://api.github.com/repos/yhmtsai/ginkgo/hooks","issue_events_url":"https://api.github.com/repos/yhmtsai/ginkgo/issues/events{/number}","events_url":"https://api.github.com/repos/yhmtsai/ginkgo/events","assignees_url":"https://api.github.com/repos/yhmtsai/ginkgo/assignees{/user}","branches_url":"https://api.github.com/repos/yhmtsai/ginkgo/branches{/branch}","tags_url":"https://api.github.com/repos/yhmtsai/ginkgo/tags","blobs_url":"https://api.github.com/repos/yhmtsai/ginkgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yhmtsai/ginkgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yhmtsai/ginkgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/yhmtsai/ginkgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yhmtsai/ginkgo/statuses/{sha}","languages_url":"https://api.github.com/repos/yhmtsai/ginkgo/languages","stargazers_url":"https://api.github.com/repos/yhmtsai/ginkgo/stargazers","contributors_url":"https://api.github.com/repos/yhmtsai/ginkgo/contributors","subscribers_url":"https://api.github.com/repos/yhmtsai/ginkgo/subscribers","subscription_url":"https://api.github.com/repos/yhmtsai/ginkgo/subscription","commits_url":"https://api.github.com/repos/yhmtsai/ginkgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/yhmtsai/ginkgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/yhmtsai/ginkgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/yhmtsai/ginkgo/issues/comments{/number}","contents_url":"https://api.github.com/repos/yhmtsai/ginkgo/contents/{+path}","compare_url":"https://api.github.com/repos/yhmtsai/ginkgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yhmtsai/ginkgo/merges","archive_url":"https://api.github.com/repos/yhmtsai/ginkgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yhmtsai/ginkgo/downloads","issues_url":"https://api.github.com/repos/yhmtsai/ginkgo/issues{/number}","pulls_url":"https://api.github.com/repos/yhmtsai/ginkgo/pulls{/number}","milestones_url":"https://api.github.com/repos/yhmtsai/ginkgo/milestones{/number}","notifications_url":"https://api.github.com/repos/yhmtsai/ginkgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yhmtsai/ginkgo/labels{/name}","releases_url":"https://api.github.com/repos/yhmtsai/ginkgo/releases{/id}","deployments_url":"https://api.github.com/repos/yhmtsai/ginkgo/deployments","created_at":"2018-01-24T07:58:11Z","updated_at":"2018-07-19T13:47:00Z","pushed_at":"2018-08-10T12:29:07Z","git_url":"git://github.com/yhmtsai/ginkgo.git","ssh_url":"git@github.com:yhmtsai/ginkgo.git","clone_url":"https://github.com/yhmtsai/ginkgo.git","svn_url":"https://github.com/yhmtsai/ginkgo","homepage":null,"size":2594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ginkgo-project:develop","ref":"develop","sha":"e517d94762769a30601e540cf4a9f91f828a5ae7","user":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":117122510,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMjI1MTA=","name":"ginkgo","full_name":"ginkgo-project/ginkgo","owner":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ginkgo-project/ginkgo","description":"Numerical linear algebra software package","fork":false,"url":"https://api.github.com/repos/ginkgo-project/ginkgo","forks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/forks","keys_url":"https://api.github.com/repos/ginkgo-project/ginkgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginkgo-project/ginkgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginkgo-project/ginkgo/teams","hooks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/hooks","issue_events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/events{/number}","events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/events","assignees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/assignees{/user}","branches_url":"https://api.github.com/repos/ginkgo-project/ginkgo/branches{/branch}","tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/tags","blobs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/{sha}","languages_url":"https://api.github.com/repos/ginkgo-project/ginkgo/languages","stargazers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/stargazers","contributors_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contributors","subscribers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscribers","subscription_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscription","commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contents/{+path}","compare_url":"https://api.github.com/repos/ginkgo-project/ginkgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginkgo-project/ginkgo/merges","archive_url":"https://api.github.com/repos/ginkgo-project/ginkgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginkgo-project/ginkgo/downloads","issues_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues{/number}","pulls_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls{/number}","milestones_url":"https://api.github.com/repos/ginkgo-project/ginkgo/milestones{/number}","notifications_url":"https://api.github.com/repos/ginkgo-project/ginkgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginkgo-project/ginkgo/labels{/name}","releases_url":"https://api.github.com/repos/ginkgo-project/ginkgo/releases{/id}","deployments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/deployments","created_at":"2018-01-11T16:14:21Z","updated_at":"2018-08-09T16:34:38Z","pushed_at":"2018-08-10T12:29:08Z","git_url":"git://github.com/ginkgo-project/ginkgo.git","ssh_url":"git@github.com:ginkgo-project/ginkgo.git","clone_url":"https://github.com/ginkgo-project/ginkgo.git","svn_url":"https://github.com/ginkgo-project/ginkgo","homepage":null,"size":3549,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":27,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103"},"html":{"href":"https://github.com/ginkgo-project/ginkgo/pull/103"},"issue":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/103"},"comments":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/b7668f7ab16eb8084b721dd22b97f364fead9218"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yhmtsai"}}