{"action":"created","issue":{"url":"https://api.github.com/repos/das-labor/neopg/issues/87","repository_url":"https://api.github.com/repos/das-labor/neopg","labels_url":"https://api.github.com/repos/das-labor/neopg/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/das-labor/neopg/issues/87/comments","events_url":"https://api.github.com/repos/das-labor/neopg/issues/87/events","html_url":"https://github.com/das-labor/neopg/pull/87","id":337651803,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzgxMTAz","number":87,"title":"Remove --disable-signers-uid and all support for signer's uid.","user":{"login":"lambdafu","id":1138455,"node_id":"MDQ6VXNlcjExMzg0NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1138455?v=4","gravatar_id":"","url":"https://api.github.com/users/lambdafu","html_url":"https://github.com/lambdafu","followers_url":"https://api.github.com/users/lambdafu/followers","following_url":"https://api.github.com/users/lambdafu/following{/other_user}","gists_url":"https://api.github.com/users/lambdafu/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdafu/subscriptions","organizations_url":"https://api.github.com/users/lambdafu/orgs","repos_url":"https://api.github.com/users/lambdafu/repos","events_url":"https://api.github.com/users/lambdafu/events{/privacy}","received_events_url":"https://api.github.com/users/lambdafu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-02T20:27:25Z","updated_at":"2018-07-02T21:36:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/das-labor/neopg/pulls/87","html_url":"https://github.com/das-labor/neopg/pull/87","diff_url":"https://github.com/das-labor/neopg/pull/87.diff","patch_url":"https://github.com/das-labor/neopg/pull/87.patch"},"body":"\"Signer's UID\" is a signature subpacket that is supposed to be able to indicate to the verifier of a signature which user id was used to create the signature, for example if the same signature key is used privately and for work, indicating a role under which the signature was made. Here is the relevant text from RFC4880:\r\n\r\n> This subpacket allows a keyholder to state which User ID is\r\n> responsible for the signing.  Many keyholders use a single key for\r\n> different purposes, such as business communications as well as\r\n> personal communications.  This subpacket allows such a keyholder to\r\n> state which of their roles is making a signature.\r\n>\r\n> This subpacket is not appropriate to use to refer to a User Attribute\r\n> packet.\r\n\r\nThis feature is poorly designed and implemented. It's basically a free text field that is passed on to applications, but as there is no verification on it (except that it is included in the signature hash), actually using it in applications could be very dangerous. In fact, GnuPG does not even make sure that it contains an actual user id, instead using whatever uid was used to locate the key.\r\n\r\nAs there is no valid use case, this patch removes all support for it.\r\n"},"comment":{"url":"https://api.github.com/repos/das-labor/neopg/issues/comments/401945160","html_url":"https://github.com/das-labor/neopg/pull/87#issuecomment-401945160","issue_url":"https://api.github.com/repos/das-labor/neopg/issues/87","id":401945160,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTk0NTE2MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-02T21:36:18Z","updated_at":"2018-07-02T21:36:18Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/das-labor/neopg/pull/87?src=pr&el=h1) Report\n> Merging [#87](https://codecov.io/gh/das-labor/neopg/pull/87?src=pr&el=desc) into [master](https://codecov.io/gh/das-labor/neopg/commit/1fe50460abe01febb118641e37aa50bc429a1786?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n```diff\n@@            Coverage Diff             @@\n##           master      #87      +/-   ##\n==========================================\n+ Coverage   20.53%   20.53%   +<.01%     \n==========================================\n  Files         294      294              \n  Lines       32769    32769              \n==========================================\n+ Hits         6729     6730       +1     \n+ Misses      26040    26039       -1\n```\n"}}
{"actor":{"display_login":"codecov"}}