{"action":"closed","number":1119,"pull_request":{"url":"https://api.github.com/repos/keymanapp/keyman/pulls/1119","id":209701099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzAxMDk5","html_url":"https://github.com/keymanapp/keyman/pull/1119","diff_url":"https://github.com/keymanapp/keyman/pull/1119.diff","patch_url":"https://github.com/keymanapp/keyman/pull/1119.patch","issue_url":"https://api.github.com/repos/keymanapp/keyman/issues/1119","number":1119,"state":"closed","locked":false,"title":"[Android] Ensure keyboards list has an entry","user":{"login":"darcywong00","id":7358010,"node_id":"MDQ6VXNlcjczNTgwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7358010?v=4","gravatar_id":"","url":"https://api.github.com/users/darcywong00","html_url":"https://github.com/darcywong00","followers_url":"https://api.github.com/users/darcywong00/followers","following_url":"https://api.github.com/users/darcywong00/following{/other_user}","gists_url":"https://api.github.com/users/darcywong00/gists{/gist_id}","starred_url":"https://api.github.com/users/darcywong00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcywong00/subscriptions","organizations_url":"https://api.github.com/users/darcywong00/orgs","repos_url":"https://api.github.com/users/darcywong00/repos","events_url":"https://api.github.com/users/darcywong00/events{/privacy}","received_events_url":"https://api.github.com/users/darcywong00/received_events","type":"User","site_admin":false},"body":"There are some crash reports coming from `KeyboardPickerActivity.java` because the keyboards list is null (file access error). When the app tries to display the installed keyboards list, this results in the crash.\r\n\r\n`getKeyboardsList()` already checks the existence of the `keyboards_list.dat` file, so some of that code is also redundant.\r\n\r\nWith this PR, if `keyboardsList` is null, we'll populate the list with the default keyboard.\r\natm, I'm deciding not to overwrite the `keyboards_list.dat` file so we don't lose the info of previously installed keyboards.","created_at":"2018-08-21T03:48:41Z","updated_at":"2018-08-22T13:54:09Z","closed_at":"2018-08-22T13:54:09Z","merged_at":"2018-08-22T13:54:09Z","merge_commit_sha":"a5ae987ffe0adbe9f1e4e834ecad0e6e2055eaf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":648605709,"node_id":"MDU6TGFiZWw2NDg2MDU3MDk=","url":"https://api.github.com/repos/keymanapp/keyman/labels/android","name":"android","color":"A4C639","default":false},{"id":143763452,"node_id":"MDU6TGFiZWwxNDM3NjM0NTI=","url":"https://api.github.com/repos/keymanapp/keyman/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/keymanapp/keyman/milestones/34","html_url":"https://github.com/keymanapp/keyman/milestone/34","labels_url":"https://api.github.com/repos/keymanapp/keyman/milestones/34/labels","id":3566723,"node_id":"MDk6TWlsZXN0b25lMzU2NjcyMw==","number":34,"title":"P4S4","description":"","creator":{"login":"tombogle","id":4229598,"node_id":"MDQ6VXNlcjQyMjk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4229598?v=4","gravatar_id":"","url":"https://api.github.com/users/tombogle","html_url":"https://github.com/tombogle","followers_url":"https://api.github.com/users/tombogle/followers","following_url":"https://api.github.com/users/tombogle/following{/other_user}","gists_url":"https://api.github.com/users/tombogle/gists{/gist_id}","starred_url":"https://api.github.com/users/tombogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombogle/subscriptions","organizations_url":"https://api.github.com/users/tombogle/orgs","repos_url":"https://api.github.com/users/tombogle/repos","events_url":"https://api.github.com/users/tombogle/events{/privacy}","received_events_url":"https://api.github.com/users/tombogle/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":10,"state":"open","created_at":"2018-08-13T19:03:22Z","updated_at":"2018-08-22T13:54:09Z","due_on":"2018-08-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/keymanapp/keyman/pulls/1119/commits","review_comments_url":"https://api.github.com/repos/keymanapp/keyman/pulls/1119/comments","review_comment_url":"https://api.github.com/repos/keymanapp/keyman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keymanapp/keyman/issues/1119/comments","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/3b9871cb8e1906b6230b090e19ef6349bbd29d5e","head":{"label":"keymanapp:android-fix-null-keyboardlist","ref":"android-fix-null-keyboardlist","sha":"3b9871cb8e1906b6230b090e19ef6349bbd29d5e","user":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"repo":{"id":26063183,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA2MzE4Mw==","name":"keyman","full_name":"keymanapp/keyman","owner":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keymanapp/keyman","description":"Keyman cross platform input methods","fork":false,"url":"https://api.github.com/repos/keymanapp/keyman","forks_url":"https://api.github.com/repos/keymanapp/keyman/forks","keys_url":"https://api.github.com/repos/keymanapp/keyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keymanapp/keyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keymanapp/keyman/teams","hooks_url":"https://api.github.com/repos/keymanapp/keyman/hooks","issue_events_url":"https://api.github.com/repos/keymanapp/keyman/issues/events{/number}","events_url":"https://api.github.com/repos/keymanapp/keyman/events","assignees_url":"https://api.github.com/repos/keymanapp/keyman/assignees{/user}","branches_url":"https://api.github.com/repos/keymanapp/keyman/branches{/branch}","tags_url":"https://api.github.com/repos/keymanapp/keyman/tags","blobs_url":"https://api.github.com/repos/keymanapp/keyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keymanapp/keyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keymanapp/keyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/keymanapp/keyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/{sha}","languages_url":"https://api.github.com/repos/keymanapp/keyman/languages","stargazers_url":"https://api.github.com/repos/keymanapp/keyman/stargazers","contributors_url":"https://api.github.com/repos/keymanapp/keyman/contributors","subscribers_url":"https://api.github.com/repos/keymanapp/keyman/subscribers","subscription_url":"https://api.github.com/repos/keymanapp/keyman/subscription","commits_url":"https://api.github.com/repos/keymanapp/keyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/keymanapp/keyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/keymanapp/keyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/keymanapp/keyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/keymanapp/keyman/contents/{+path}","compare_url":"https://api.github.com/repos/keymanapp/keyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keymanapp/keyman/merges","archive_url":"https://api.github.com/repos/keymanapp/keyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keymanapp/keyman/downloads","issues_url":"https://api.github.com/repos/keymanapp/keyman/issues{/number}","pulls_url":"https://api.github.com/repos/keymanapp/keyman/pulls{/number}","milestones_url":"https://api.github.com/repos/keymanapp/keyman/milestones{/number}","notifications_url":"https://api.github.com/repos/keymanapp/keyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keymanapp/keyman/labels{/name}","releases_url":"https://api.github.com/repos/keymanapp/keyman/releases{/id}","deployments_url":"https://api.github.com/repos/keymanapp/keyman/deployments","created_at":"2014-11-01T21:01:44Z","updated_at":"2018-08-22T13:36:17Z","pushed_at":"2018-08-22T13:54:09Z","git_url":"git://github.com/keymanapp/keyman.git","ssh_url":"git@github.com:keymanapp/keyman.git","clone_url":"https://github.com/keymanapp/keyman.git","svn_url":"https://github.com/keymanapp/keyman","homepage":"https://keyman.com/","size":177521,"stargazers_count":58,"watchers_count":58,"language":"Pascal","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":226,"license":null,"forks":23,"open_issues":226,"watchers":58,"default_branch":"master"}},"base":{"label":"keymanapp:stable-10.0","ref":"stable-10.0","sha":"9820247639dcff75786aeb48e4a22551db48d9a6","user":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"repo":{"id":26063183,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA2MzE4Mw==","name":"keyman","full_name":"keymanapp/keyman","owner":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keymanapp/keyman","description":"Keyman cross platform input methods","fork":false,"url":"https://api.github.com/repos/keymanapp/keyman","forks_url":"https://api.github.com/repos/keymanapp/keyman/forks","keys_url":"https://api.github.com/repos/keymanapp/keyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keymanapp/keyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keymanapp/keyman/teams","hooks_url":"https://api.github.com/repos/keymanapp/keyman/hooks","issue_events_url":"https://api.github.com/repos/keymanapp/keyman/issues/events{/number}","events_url":"https://api.github.com/repos/keymanapp/keyman/events","assignees_url":"https://api.github.com/repos/keymanapp/keyman/assignees{/user}","branches_url":"https://api.github.com/repos/keymanapp/keyman/branches{/branch}","tags_url":"https://api.github.com/repos/keymanapp/keyman/tags","blobs_url":"https://api.github.com/repos/keymanapp/keyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keymanapp/keyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keymanapp/keyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/keymanapp/keyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/{sha}","languages_url":"https://api.github.com/repos/keymanapp/keyman/languages","stargazers_url":"https://api.github.com/repos/keymanapp/keyman/stargazers","contributors_url":"https://api.github.com/repos/keymanapp/keyman/contributors","subscribers_url":"https://api.github.com/repos/keymanapp/keyman/subscribers","subscription_url":"https://api.github.com/repos/keymanapp/keyman/subscription","commits_url":"https://api.github.com/repos/keymanapp/keyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/keymanapp/keyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/keymanapp/keyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/keymanapp/keyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/keymanapp/keyman/contents/{+path}","compare_url":"https://api.github.com/repos/keymanapp/keyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keymanapp/keyman/merges","archive_url":"https://api.github.com/repos/keymanapp/keyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keymanapp/keyman/downloads","issues_url":"https://api.github.com/repos/keymanapp/keyman/issues{/number}","pulls_url":"https://api.github.com/repos/keymanapp/keyman/pulls{/number}","milestones_url":"https://api.github.com/repos/keymanapp/keyman/milestones{/number}","notifications_url":"https://api.github.com/repos/keymanapp/keyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keymanapp/keyman/labels{/name}","releases_url":"https://api.github.com/repos/keymanapp/keyman/releases{/id}","deployments_url":"https://api.github.com/repos/keymanapp/keyman/deployments","created_at":"2014-11-01T21:01:44Z","updated_at":"2018-08-22T13:36:17Z","pushed_at":"2018-08-22T13:54:09Z","git_url":"git://github.com/keymanapp/keyman.git","ssh_url":"git@github.com:keymanapp/keyman.git","clone_url":"https://github.com/keymanapp/keyman.git","svn_url":"https://github.com/keymanapp/keyman","homepage":"https://keyman.com/","size":177521,"stargazers_count":58,"watchers_count":58,"language":"Pascal","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":226,"license":null,"forks":23,"open_issues":226,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1119"},"html":{"href":"https://github.com/keymanapp/keyman/pull/1119"},"issue":{"href":"https://api.github.com/repos/keymanapp/keyman/issues/1119"},"comments":{"href":"https://api.github.com/repos/keymanapp/keyman/issues/1119/comments"},"review_comments":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1119/comments"},"review_comment":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1119/commits"},"statuses":{"href":"https://api.github.com/repos/keymanapp/keyman/statuses/3b9871cb8e1906b6230b090e19ef6349bbd29d5e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"darcywong00","id":7358010,"node_id":"MDQ6VXNlcjczNTgwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7358010?v=4","gravatar_id":"","url":"https://api.github.com/users/darcywong00","html_url":"https://github.com/darcywong00","followers_url":"https://api.github.com/users/darcywong00/followers","following_url":"https://api.github.com/users/darcywong00/following{/other_user}","gists_url":"https://api.github.com/users/darcywong00/gists{/gist_id}","starred_url":"https://api.github.com/users/darcywong00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcywong00/subscriptions","organizations_url":"https://api.github.com/users/darcywong00/orgs","repos_url":"https://api.github.com/users/darcywong00/repos","events_url":"https://api.github.com/users/darcywong00/events{/privacy}","received_events_url":"https://api.github.com/users/darcywong00/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":11,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"darcywong00"}}