{"action":"created","issue":{"url":"https://api.github.com/repos/plotly/react-chart-editor/issues/808","repository_url":"https://api.github.com/repos/plotly/react-chart-editor","labels_url":"https://api.github.com/repos/plotly/react-chart-editor/issues/808/labels{/name}","comments_url":"https://api.github.com/repos/plotly/react-chart-editor/issues/808/comments","events_url":"https://api.github.com/repos/plotly/react-chart-editor/issues/808/events","html_url":"https://github.com/plotly/react-chart-editor/pull/808","id":390384983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTYzMzEx","number":808,"title":"WIP Pre143","user":{"login":"nicolaskruchten","id":203523,"node_id":"MDQ6VXNlcjIwMzUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/203523?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaskruchten","html_url":"https://github.com/nicolaskruchten","followers_url":"https://api.github.com/users/nicolaskruchten/followers","following_url":"https://api.github.com/users/nicolaskruchten/following{/other_user}","gists_url":"https://api.github.com/users/nicolaskruchten/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaskruchten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaskruchten/subscriptions","organizations_url":"https://api.github.com/users/nicolaskruchten/orgs","repos_url":"https://api.github.com/users/nicolaskruchten/repos","events_url":"https://api.github.com/users/nicolaskruchten/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaskruchten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-12-12T19:57:07Z","updated_at":"2018-12-17T16:44:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/plotly/react-chart-editor/pulls/808","html_url":"https://github.com/plotly/react-chart-editor/pull/808","diff_url":"https://github.com/plotly/react-chart-editor/pull/808.diff","patch_url":"https://github.com/plotly/react-chart-editor/pull/808.patch"},"body":"Known RCE issues:\r\n\r\n- [x] text editor reads container[attr] and doesn't work if attr contains dots\r\n- [x] colorscale horizontal alignment\r\n- [x] `is2D` and array adjustments in `DataSelector`\r\n- [x] hide hovertemplate when empty\r\n- [ ] wait for plotly.js to stop writebacks of colorscale to marker so that the layout.colorscales actually control things\r\n"},"comment":{"url":"https://api.github.com/repos/plotly/react-chart-editor/issues/comments/447912910","html_url":"https://github.com/plotly/react-chart-editor/pull/808#issuecomment-447912910","issue_url":"https://api.github.com/repos/plotly/react-chart-editor/issues/808","id":447912910,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzkxMjkxMA==","user":{"login":"nicolaskruchten","id":203523,"node_id":"MDQ6VXNlcjIwMzUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/203523?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaskruchten","html_url":"https://github.com/nicolaskruchten","followers_url":"https://api.github.com/users/nicolaskruchten/followers","following_url":"https://api.github.com/users/nicolaskruchten/following{/other_user}","gists_url":"https://api.github.com/users/nicolaskruchten/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaskruchten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaskruchten/subscriptions","organizations_url":"https://api.github.com/users/nicolaskruchten/orgs","repos_url":"https://api.github.com/users/nicolaskruchten/repos","events_url":"https://api.github.com/users/nicolaskruchten/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaskruchten/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T16:44:07Z","updated_at":"2018-12-17T16:44:07Z","author_association":"MEMBER","body":"The logo was updated to match our current branding a couple of versions ago I think, and yeah, the color is punchier and no longer matches the modebar buttons so it's more visible. I think we'll keep it for now.\r\n\r\nThe watermark feature is much more invasive: when turned on, the logo is always there/doesn't fade away with the modebar. We'll likely turn it on for Community-plan embeds only.\r\n\r\nRe colorscale pickers, I agree that the dropdown feels a bit redundant here, but people do like using sequential scales instead of categoricals even though they really shouldn't etc, so let's just keep them for now :)\r\n"}}
{"actor":{"display_login":"nicolaskruchten"}}