{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/224141546","pull_request_review_id":163437811,"id":224141546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE0MTU0Ng==","diff_hunk":"@@ -37,8 +37,16 @@ class SkipStageHandler(\n ) : OrcaMessageHandler<SkipStage> {\n   override fun handle(message: SkipStage) {\n     message.withStage { stage ->\n-      if (stage.status in setOf(RUNNING, NOT_STARTED)) {\n+      if (stage.status in setOf(RUNNING, NOT_STARTED) || stage.isManuallySkipped()) {\n         stage.status = SKIPPED\n+        if (stage.isManuallySkipped()) {\n+          stage.recursiveSyntheticStages().forEach {\n+            if (it.status !in setOf(SUCCEEDED, TERMINAL, FAILED_CONTINUE)) {\n+              it.status = SKIPPED\n+              repository.storeStage(it)","path":"orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/handler/SkipStageHandler.kt","position":25,"original_position":25,"commit_id":"608d86cef8c8e9b0ea01dafa8182dcccaa63b790","original_commit_id":"608d86cef8c8e9b0ea01dafa8182dcccaa63b790","user":{"login":"danielpeach","id":13868700,"node_id":"MDQ6VXNlcjEzODY4NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/13868700?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"body":"I'm not totally seeing why - any synthetic stage's tasks will have been completed as `SKIPPED` at this point, so there's nothing else to do but mark the stages as `SKIPPED`. Would it be more natural to bubble the `SkipStage` messages up - each synthetic stage marks itself as `SKIPPED`, then pushes a `SkipStage` message onto the queue with its parent as the next stage to be skipped?","created_at":"2018-10-10T16:02:26Z","updated_at":"2018-10-10T16:02:27Z","html_url":"https://github.com/spinnaker/orca/pull/2445#discussion_r224141546","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/2445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/224141546"},"html":{"href":"https://github.com/spinnaker/orca/pull/2445#discussion_r224141546"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2445"}},"in_reply_to_id":223140094},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/2445","id":220780490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzgwNDkw","html_url":"https://github.com/spinnaker/orca/pull/2445","diff_url":"https://github.com/spinnaker/orca/pull/2445.diff","patch_url":"https://github.com/spinnaker/orca/pull/2445.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/2445","number":2445,"state":"open","locked":false,"title":"feat(core): manually skip a stage","user":{"login":"danielpeach","id":13868700,"node_id":"MDQ6VXNlcjEzODY4NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/13868700?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-10-05T18:03:18Z","updated_at":"2018-10-10T16:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"500e40c92e23b92647720a3d0451ded2a4b18c2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/2445/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/2445/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/2445/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/608d86cef8c8e9b0ea01dafa8182dcccaa63b790","head":{"label":"danielpeach:manual-skip-stage","ref":"manual-skip-stage","sha":"608d86cef8c8e9b0ea01dafa8182dcccaa63b790","user":{"login":"danielpeach","id":13868700,"node_id":"MDQ6VXNlcjEzODY4NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/13868700?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"repo":{"id":59502377,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUwMjM3Nw==","name":"orca","full_name":"danielpeach/orca","private":false,"owner":{"login":"danielpeach","id":13868700,"node_id":"MDQ6VXNlcjEzODY4NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/13868700?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielpeach/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/danielpeach/orca","forks_url":"https://api.github.com/repos/danielpeach/orca/forks","keys_url":"https://api.github.com/repos/danielpeach/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpeach/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpeach/orca/teams","hooks_url":"https://api.github.com/repos/danielpeach/orca/hooks","issue_events_url":"https://api.github.com/repos/danielpeach/orca/issues/events{/number}","events_url":"https://api.github.com/repos/danielpeach/orca/events","assignees_url":"https://api.github.com/repos/danielpeach/orca/assignees{/user}","branches_url":"https://api.github.com/repos/danielpeach/orca/branches{/branch}","tags_url":"https://api.github.com/repos/danielpeach/orca/tags","blobs_url":"https://api.github.com/repos/danielpeach/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpeach/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpeach/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpeach/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpeach/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpeach/orca/languages","stargazers_url":"https://api.github.com/repos/danielpeach/orca/stargazers","contributors_url":"https://api.github.com/repos/danielpeach/orca/contributors","subscribers_url":"https://api.github.com/repos/danielpeach/orca/subscribers","subscription_url":"https://api.github.com/repos/danielpeach/orca/subscription","commits_url":"https://api.github.com/repos/danielpeach/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpeach/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpeach/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpeach/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpeach/orca/contents/{+path}","compare_url":"https://api.github.com/repos/danielpeach/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpeach/orca/merges","archive_url":"https://api.github.com/repos/danielpeach/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpeach/orca/downloads","issues_url":"https://api.github.com/repos/danielpeach/orca/issues{/number}","pulls_url":"https://api.github.com/repos/danielpeach/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpeach/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpeach/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpeach/orca/labels{/name}","releases_url":"https://api.github.com/repos/danielpeach/orca/releases{/id}","deployments_url":"https://api.github.com/repos/danielpeach/orca/deployments","created_at":"2016-05-23T17:06:28Z","updated_at":"2016-05-23T17:06:34Z","pushed_at":"2018-10-05T18:21:42Z","git_url":"git://github.com/danielpeach/orca.git","ssh_url":"git@github.com:danielpeach/orca.git","clone_url":"https://github.com/danielpeach/orca.git","svn_url":"https://github.com/danielpeach/orca","homepage":"","size":13179,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"226cc7f10c0ad4dfcef88ce8c93e6ce0097ed343","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgzNDMxNA==","name":"orca","full_name":"spinnaker/orca","private":false,"owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2018-10-09T21:23:57Z","pushed_at":"2018-10-09T21:24:14Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":13055,"stargazers_count":104,"watchers_count":104,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":321,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":321,"open_issues":49,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2445"},"html":{"href":"https://github.com/spinnaker/orca/pull/2445"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/2445"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/2445/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2445/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2445/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/608d86cef8c8e9b0ea01dafa8182dcccaa63b790"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielpeach"}}