{"action":"created","issue":{"url":"https://api.github.com/repos/WizardMac/ReadStat/issues/161","repository_url":"https://api.github.com/repos/WizardMac/ReadStat","labels_url":"https://api.github.com/repos/WizardMac/ReadStat/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/WizardMac/ReadStat/issues/161/comments","events_url":"https://api.github.com/repos/WizardMac/ReadStat/issues/161/events","html_url":"https://github.com/WizardMac/ReadStat/issues/161","id":392198639,"node_id":"MDU6SXNzdWUzOTIxOTg2Mzk=","number":161,"title":"sas7bdat user defined missing values 64 bit","user":{"login":"ofajardo","id":17498727,"node_id":"MDQ6VXNlcjE3NDk4NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/17498727?v=4","gravatar_id":"","url":"https://api.github.com/users/ofajardo","html_url":"https://github.com/ofajardo","followers_url":"https://api.github.com/users/ofajardo/followers","following_url":"https://api.github.com/users/ofajardo/following{/other_user}","gists_url":"https://api.github.com/users/ofajardo/gists{/gist_id}","starred_url":"https://api.github.com/users/ofajardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofajardo/subscriptions","organizations_url":"https://api.github.com/users/ofajardo/orgs","repos_url":"https://api.github.com/users/ofajardo/repos","events_url":"https://api.github.com/users/ofajardo/events{/privacy}","received_events_url":"https://api.github.com/users/ofajardo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-18T15:08:17Z","updated_at":"2018-12-18T17:13:42Z","closed_at":null,"author_association":"NONE","body":"This is coming from #159:\r\n\r\nwhen a sas7bdat file produced on 64 bit linux is read, readstat_value_is_tagged_missing returns False for those missing values. It should return True and then readstat_value_tag should return a valid char, from A to Z and _\r\n\r\nAttached a sample file with 9 columns and 1 single row.\r\n\r\ncols 1 to 6: A, B, C, X, Y, Z\r\ncol 7: _ (underscore)\r\ncol 8: . (system missing, here readstat_value_is_system_missing should return true)\r\ncol 9: 1 (not missing, just a double value).\r\n[missing_test.zip](https://github.com/WizardMac/ReadStat/files/2691045/missing_test.zip)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/WizardMac/ReadStat/issues/comments/448297533","html_url":"https://github.com/WizardMac/ReadStat/issues/161#issuecomment-448297533","issue_url":"https://api.github.com/repos/WizardMac/ReadStat/issues/161","id":448297533,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODI5NzUzMw==","user":{"login":"evanmiller","id":134711,"node_id":"MDQ6VXNlcjEzNDcxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/134711?v=4","gravatar_id":"","url":"https://api.github.com/users/evanmiller","html_url":"https://github.com/evanmiller","followers_url":"https://api.github.com/users/evanmiller/followers","following_url":"https://api.github.com/users/evanmiller/following{/other_user}","gists_url":"https://api.github.com/users/evanmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/evanmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanmiller/subscriptions","organizations_url":"https://api.github.com/users/evanmiller/orgs","repos_url":"https://api.github.com/users/evanmiller/repos","events_url":"https://api.github.com/users/evanmiller/events{/privacy}","received_events_url":"https://api.github.com/users/evanmiller/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T17:13:42Z","updated_at":"2018-12-18T17:13:42Z","author_association":"CONTRIBUTOR","body":"Thanks for the sample file.\r\n\r\nSome notes for myself:\r\n\r\nIt looks like these files encode the tag as:\r\n\r\n```\r\nA - 2 + ~((value >> 40) & 0xFF)\r\n```\r\n\r\nE.g. `0xFD` = A, `0xFC` = B, `0xFB` = C, `0xE4` = Z\r\n\r\nOlder versions encode the tag as\r\n\r\n```\r\n~((value >> 40) & 0xFF)\r\n```\r\n\r\nThese schemes would be compatible, except for the tagged underscore case. This is encoded as `0xFF` in the new files, but the old files used `0xFF` as the system-missing value. The new files used `0xFE` as system-missing.\r\n\r\nIdeally, we would figure out what triggers the new scheme. Is it a difference between 64-bit and 32-bit versions of SAS? Is there a separate flag within the file somewhere? Does it only apply when width = 3?"}}
{"actor":{"display_login":"evanmiller"}}