{"action":"created","issue":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/681","repository_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/681/labels{/name}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/681/comments","events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/681/events","html_url":"https://github.com/DistrictDataLabs/yellowbrick/issues/681","id":395133450,"node_id":"MDU6SXNzdWUzOTUxMzM0NTA=","number":681,"title":"Dataset loader requires y variable, unsuited for unsupervised datasets","user":{"login":"bbengfort","id":745966,"node_id":"MDQ6VXNlcjc0NTk2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/745966?v=4","gravatar_id":"","url":"https://api.github.com/users/bbengfort","html_url":"https://github.com/bbengfort","followers_url":"https://api.github.com/users/bbengfort/followers","following_url":"https://api.github.com/users/bbengfort/following{/other_user}","gists_url":"https://api.github.com/users/bbengfort/gists{/gist_id}","starred_url":"https://api.github.com/users/bbengfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbengfort/subscriptions","organizations_url":"https://api.github.com/users/bbengfort/orgs","repos_url":"https://api.github.com/users/bbengfort/repos","events_url":"https://api.github.com/users/bbengfort/events{/privacy}","received_events_url":"https://api.github.com/users/bbengfort/received_events","type":"User","site_admin":false},"labels":[{"id":378474407,"node_id":"MDU6TGFiZWwzNzg0NzQ0MDc=","url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels/type:%20bug","name":"type: bug","color":"e99695","default":false},{"id":378519098,"node_id":"MDU6TGFiZWwzNzg1MTkwOTg=","url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels/type:%20technical%20debt","name":"type: technical debt","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-02T02:03:09Z","updated_at":"2019-01-02T02:03:35Z","closed_at":null,"author_association":"MEMBER","body":"The `Dataset.to_numpy` and `Dataset.to_pandas` methods both return `X` and `y` data for use in machine learning. Currently, all of our datasets are supervised (e.g. they have `y` data; however if we would like to include unsupervised data then these methods will have to be updated to return `None` for `y`. This will not work out of the box for the following reasons:\r\n\r\n- the `to_numpy` method expects `y` to exist in the .npz file; we'll either have to store `None` in the .npz file or perform a check in the meta.json to see if a target exists. \r\n- the `to_pandas` method uses the meta.json and will need to gracefully handle the case where `target= nil`. \r\n\r\nNote that for dataset validation, `\"target\" in Dataset.meta` must be `True`, so the `meta.json` must have `\"target\": nil` rather than omit the `\"target\"` key."},"comment":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/comments/450774269","html_url":"https://github.com/DistrictDataLabs/yellowbrick/issues/681#issuecomment-450774269","issue_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/681","id":450774269,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDc3NDI2OQ==","user":{"login":"bbengfort","id":745966,"node_id":"MDQ6VXNlcjc0NTk2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/745966?v=4","gravatar_id":"","url":"https://api.github.com/users/bbengfort","html_url":"https://github.com/bbengfort","followers_url":"https://api.github.com/users/bbengfort/followers","following_url":"https://api.github.com/users/bbengfort/following{/other_user}","gists_url":"https://api.github.com/users/bbengfort/gists{/gist_id}","starred_url":"https://api.github.com/users/bbengfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbengfort/subscriptions","organizations_url":"https://api.github.com/users/bbengfort/orgs","repos_url":"https://api.github.com/users/bbengfort/repos","events_url":"https://api.github.com/users/bbengfort/events{/privacy}","received_events_url":"https://api.github.com/users/bbengfort/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T02:03:35Z","updated_at":"2019-01-02T02:03:35Z","author_association":"MEMBER","body":"Related to #535 (this bug was introduced with our knowledge in this PR)"}}
{"actor":{"display_login":"bbengfort"}}