{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/6682","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/6682/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/6682/comments","events_url":"https://api.github.com/repos/minio/minio/issues/6682/events","html_url":"https://github.com/minio/minio/pull/6682","id":372698473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODEyOTg2","number":6682,"title":"Fix goroutine test fatalf","user":{"login":"leitzler","id":3111805,"node_id":"MDQ6VXNlcjMxMTE4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3111805?v=4","gravatar_id":"","url":"https://api.github.com/users/leitzler","html_url":"https://github.com/leitzler","followers_url":"https://api.github.com/users/leitzler/followers","following_url":"https://api.github.com/users/leitzler/following{/other_user}","gists_url":"https://api.github.com/users/leitzler/gists{/gist_id}","starred_url":"https://api.github.com/users/leitzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leitzler/subscriptions","organizations_url":"https://api.github.com/users/leitzler/orgs","repos_url":"https://api.github.com/users/leitzler/repos","events_url":"https://api.github.com/users/leitzler/events{/privacy}","received_events_url":"https://api.github.com/users/leitzler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-22T21:01:14Z","updated_at":"2018-10-23T06:35:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6682","html_url":"https://github.com/minio/minio/pull/6682","diff_url":"https://github.com/minio/minio/pull/6682.diff","patch_url":"https://github.com/minio/minio/pull/6682.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis PR replaces `t.Fatal` and `t.Fatalf` with `t.Error` and `t.Errorf` when called from within a goroutine.\r\n\r\n## Motivation and Context\r\n`t.Fatal` and `t.Fatalf` must be called from the same goroutine running the Test function, see https://godoc.org/testing#T.\r\n\r\n## How Has This Been Tested?\r\n`make test`\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/432112572","html_url":"https://github.com/minio/minio/pull/6682#issuecomment-432112572","issue_url":"https://api.github.com/repos/minio/minio/issues/6682","id":432112572,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjExMjU3Mg==","user":{"login":"balamurugana","id":629407,"node_id":"MDQ6VXNlcjYyOTQwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/629407?v=4","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T06:35:41Z","updated_at":"2018-10-23T06:35:41Z","author_association":"MEMBER","body":"@leitzler What will happen on failure?"}}
{"actor":{"display_login":"balamurugana"}}