{"action":"created","comment":{"url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/comments/209386153","pull_request_review_id":145400031,"id":209386153,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM4NjE1Mw==","diff_hunk":"@@ -21,73 +22,280 @@ info:\n   description: A model variant service demonstarting CanDIG API best practices\n   title: A barebones service for variant calls\n   version: 1.0.0\n+# should add this for versioning\n+# basePath: /v1\n produces:","path":"variant-service/api/swagger.yml","position":14,"original_position":14,"commit_id":"9b6906022c06127d7682ddf2b3ae9f9bb9e51b84","original_commit_id":"15a8bbae702739d5163459cc434a509af3236a14","user":{"login":"ljdursi","id":1783579,"node_id":"MDQ6VXNlcjE3ODM1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1783579?v=4","gravatar_id":"","url":"https://api.github.com/users/ljdursi","html_url":"https://github.com/ljdursi","followers_url":"https://api.github.com/users/ljdursi/followers","following_url":"https://api.github.com/users/ljdursi/following{/other_user}","gists_url":"https://api.github.com/users/ljdursi/gists{/gist_id}","starred_url":"https://api.github.com/users/ljdursi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljdursi/subscriptions","organizations_url":"https://api.github.com/users/ljdursi/orgs","repos_url":"https://api.github.com/users/ljdursi/repos","events_url":"https://api.github.com/users/ljdursi/events{/privacy}","received_events_url":"https://api.github.com/users/ljdursi/received_events","type":"User","site_admin":false},"body":"Note: basePath should be versioned","created_at":"2018-08-10T21:13:00Z","updated_at":"2018-08-10T21:13:00Z","html_url":"https://github.com/CanDIG/go-model-service/pull/26#discussion_r209386153","pull_request_url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/comments/209386153"},"html":{"href":"https://github.com/CanDIG/go-model-service/pull/26#discussion_r209386153"},"pull_request":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26","id":207723571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzIzNTcx","html_url":"https://github.com/CanDIG/go-model-service/pull/26","diff_url":"https://github.com/CanDIG/go-model-service/pull/26.diff","patch_url":"https://github.com/CanDIG/go-model-service/pull/26.patch","issue_url":"https://api.github.com/repos/CanDIG/go-model-service/issues/26","number":26,"state":"open","locked":false,"title":"Initial dredd testing","user":{"login":"ljdursi","id":1783579,"node_id":"MDQ6VXNlcjE3ODM1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1783579?v=4","gravatar_id":"","url":"https://api.github.com/users/ljdursi","html_url":"https://github.com/ljdursi","followers_url":"https://api.github.com/users/ljdursi/followers","following_url":"https://api.github.com/users/ljdursi/following{/other_user}","gists_url":"https://api.github.com/users/ljdursi/gists{/gist_id}","starred_url":"https://api.github.com/users/ljdursi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljdursi/subscriptions","organizations_url":"https://api.github.com/users/ljdursi/orgs","repos_url":"https://api.github.com/users/ljdursi/repos","events_url":"https://api.github.com/users/ljdursi/events{/privacy}","received_events_url":"https://api.github.com/users/ljdursi/received_events","type":"User","site_admin":false},"body":"Rearranges the Swagger file to make some testing easier, and adds some examples.\r\n\r\nAdds the dredd config file and hooks for python.  Not sure where the best place to put the Dredd stuff is; if it moves, paths in the dredd config file will have to change as well.  Only test success paths for now.\r\n\r\nNote that the calls tests fail; the Variant and Individual IDs are UUIDs, but the references to variants and individuals in the swagger files are int64s.","created_at":"2018-08-10T21:12:35Z","updated_at":"2018-08-10T21:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbf13d8a4efb9c8216bb833d964b5f5d9c32f61e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26/commits","review_comments_url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26/comments","review_comment_url":"https://api.github.com/repos/CanDIG/go-model-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanDIG/go-model-service/issues/26/comments","statuses_url":"https://api.github.com/repos/CanDIG/go-model-service/statuses/9b6906022c06127d7682ddf2b3ae9f9bb9e51b84","head":{"label":"ljdursi:25_dredd","ref":"25_dredd","sha":"9b6906022c06127d7682ddf2b3ae9f9bb9e51b84","user":{"login":"ljdursi","id":1783579,"node_id":"MDQ6VXNlcjE3ODM1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1783579?v=4","gravatar_id":"","url":"https://api.github.com/users/ljdursi","html_url":"https://github.com/ljdursi","followers_url":"https://api.github.com/users/ljdursi/followers","following_url":"https://api.github.com/users/ljdursi/following{/other_user}","gists_url":"https://api.github.com/users/ljdursi/gists{/gist_id}","starred_url":"https://api.github.com/users/ljdursi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljdursi/subscriptions","organizations_url":"https://api.github.com/users/ljdursi/orgs","repos_url":"https://api.github.com/users/ljdursi/repos","events_url":"https://api.github.com/users/ljdursi/events{/privacy}","received_events_url":"https://api.github.com/users/ljdursi/received_events","type":"User","site_admin":false},"repo":{"id":144330277,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzMzAyNzc=","name":"go-model-service","full_name":"ljdursi/go-model-service","owner":{"login":"ljdursi","id":1783579,"node_id":"MDQ6VXNlcjE3ODM1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1783579?v=4","gravatar_id":"","url":"https://api.github.com/users/ljdursi","html_url":"https://github.com/ljdursi","followers_url":"https://api.github.com/users/ljdursi/followers","following_url":"https://api.github.com/users/ljdursi/following{/other_user}","gists_url":"https://api.github.com/users/ljdursi/gists{/gist_id}","starred_url":"https://api.github.com/users/ljdursi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljdursi/subscriptions","organizations_url":"https://api.github.com/users/ljdursi/orgs","repos_url":"https://api.github.com/users/ljdursi/repos","events_url":"https://api.github.com/users/ljdursi/events{/privacy}","received_events_url":"https://api.github.com/users/ljdursi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljdursi/go-model-service","description":"A model variant service demonstarting CanDIG API best practices and stack/tooling.","fork":true,"url":"https://api.github.com/repos/ljdursi/go-model-service","forks_url":"https://api.github.com/repos/ljdursi/go-model-service/forks","keys_url":"https://api.github.com/repos/ljdursi/go-model-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljdursi/go-model-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljdursi/go-model-service/teams","hooks_url":"https://api.github.com/repos/ljdursi/go-model-service/hooks","issue_events_url":"https://api.github.com/repos/ljdursi/go-model-service/issues/events{/number}","events_url":"https://api.github.com/repos/ljdursi/go-model-service/events","assignees_url":"https://api.github.com/repos/ljdursi/go-model-service/assignees{/user}","branches_url":"https://api.github.com/repos/ljdursi/go-model-service/branches{/branch}","tags_url":"https://api.github.com/repos/ljdursi/go-model-service/tags","blobs_url":"https://api.github.com/repos/ljdursi/go-model-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljdursi/go-model-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljdursi/go-model-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljdursi/go-model-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljdursi/go-model-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ljdursi/go-model-service/languages","stargazers_url":"https://api.github.com/repos/ljdursi/go-model-service/stargazers","contributors_url":"https://api.github.com/repos/ljdursi/go-model-service/contributors","subscribers_url":"https://api.github.com/repos/ljdursi/go-model-service/subscribers","subscription_url":"https://api.github.com/repos/ljdursi/go-model-service/subscription","commits_url":"https://api.github.com/repos/ljdursi/go-model-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljdursi/go-model-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljdursi/go-model-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljdursi/go-model-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljdursi/go-model-service/contents/{+path}","compare_url":"https://api.github.com/repos/ljdursi/go-model-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljdursi/go-model-service/merges","archive_url":"https://api.github.com/repos/ljdursi/go-model-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljdursi/go-model-service/downloads","issues_url":"https://api.github.com/repos/ljdursi/go-model-service/issues{/number}","pulls_url":"https://api.github.com/repos/ljdursi/go-model-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ljdursi/go-model-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ljdursi/go-model-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljdursi/go-model-service/labels{/name}","releases_url":"https://api.github.com/repos/ljdursi/go-model-service/releases{/id}","deployments_url":"https://api.github.com/repos/ljdursi/go-model-service/deployments","created_at":"2018-08-10T20:40:31Z","updated_at":"2018-08-10T20:40:33Z","pushed_at":"2018-08-10T21:08:27Z","git_url":"git://github.com/ljdursi/go-model-service.git","ssh_url":"git@github.com:ljdursi/go-model-service.git","clone_url":"https://github.com/ljdursi/go-model-service.git","svn_url":"https://github.com/ljdursi/go-model-service","homepage":"","size":39617,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanDIG:master","ref":"master","sha":"ae2d9147821faef35469315eb7aed283d405aff9","user":{"login":"CanDIG","id":22987682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTg3Njgy","avatar_url":"https://avatars2.githubusercontent.com/u/22987682?v=4","gravatar_id":"","url":"https://api.github.com/users/CanDIG","html_url":"https://github.com/CanDIG","followers_url":"https://api.github.com/users/CanDIG/followers","following_url":"https://api.github.com/users/CanDIG/following{/other_user}","gists_url":"https://api.github.com/users/CanDIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CanDIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanDIG/subscriptions","organizations_url":"https://api.github.com/users/CanDIG/orgs","repos_url":"https://api.github.com/users/CanDIG/repos","events_url":"https://api.github.com/users/CanDIG/events{/privacy}","received_events_url":"https://api.github.com/users/CanDIG/received_events","type":"Organization","site_admin":false},"repo":{"id":142079734,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNzk3MzQ=","name":"go-model-service","full_name":"CanDIG/go-model-service","owner":{"login":"CanDIG","id":22987682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTg3Njgy","avatar_url":"https://avatars2.githubusercontent.com/u/22987682?v=4","gravatar_id":"","url":"https://api.github.com/users/CanDIG","html_url":"https://github.com/CanDIG","followers_url":"https://api.github.com/users/CanDIG/followers","following_url":"https://api.github.com/users/CanDIG/following{/other_user}","gists_url":"https://api.github.com/users/CanDIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CanDIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanDIG/subscriptions","organizations_url":"https://api.github.com/users/CanDIG/orgs","repos_url":"https://api.github.com/users/CanDIG/repos","events_url":"https://api.github.com/users/CanDIG/events{/privacy}","received_events_url":"https://api.github.com/users/CanDIG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanDIG/go-model-service","description":"A model variant service demonstarting CanDIG API best practices and stack/tooling.","fork":false,"url":"https://api.github.com/repos/CanDIG/go-model-service","forks_url":"https://api.github.com/repos/CanDIG/go-model-service/forks","keys_url":"https://api.github.com/repos/CanDIG/go-model-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanDIG/go-model-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanDIG/go-model-service/teams","hooks_url":"https://api.github.com/repos/CanDIG/go-model-service/hooks","issue_events_url":"https://api.github.com/repos/CanDIG/go-model-service/issues/events{/number}","events_url":"https://api.github.com/repos/CanDIG/go-model-service/events","assignees_url":"https://api.github.com/repos/CanDIG/go-model-service/assignees{/user}","branches_url":"https://api.github.com/repos/CanDIG/go-model-service/branches{/branch}","tags_url":"https://api.github.com/repos/CanDIG/go-model-service/tags","blobs_url":"https://api.github.com/repos/CanDIG/go-model-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanDIG/go-model-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanDIG/go-model-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanDIG/go-model-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanDIG/go-model-service/statuses/{sha}","languages_url":"https://api.github.com/repos/CanDIG/go-model-service/languages","stargazers_url":"https://api.github.com/repos/CanDIG/go-model-service/stargazers","contributors_url":"https://api.github.com/repos/CanDIG/go-model-service/contributors","subscribers_url":"https://api.github.com/repos/CanDIG/go-model-service/subscribers","subscription_url":"https://api.github.com/repos/CanDIG/go-model-service/subscription","commits_url":"https://api.github.com/repos/CanDIG/go-model-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanDIG/go-model-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanDIG/go-model-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanDIG/go-model-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanDIG/go-model-service/contents/{+path}","compare_url":"https://api.github.com/repos/CanDIG/go-model-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanDIG/go-model-service/merges","archive_url":"https://api.github.com/repos/CanDIG/go-model-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanDIG/go-model-service/downloads","issues_url":"https://api.github.com/repos/CanDIG/go-model-service/issues{/number}","pulls_url":"https://api.github.com/repos/CanDIG/go-model-service/pulls{/number}","milestones_url":"https://api.github.com/repos/CanDIG/go-model-service/milestones{/number}","notifications_url":"https://api.github.com/repos/CanDIG/go-model-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanDIG/go-model-service/labels{/name}","releases_url":"https://api.github.com/repos/CanDIG/go-model-service/releases{/id}","deployments_url":"https://api.github.com/repos/CanDIG/go-model-service/deployments","created_at":"2018-07-23T23:27:18Z","updated_at":"2018-08-03T02:01:20Z","pushed_at":"2018-08-10T21:12:35Z","git_url":"git://github.com/CanDIG/go-model-service.git","ssh_url":"git@github.com:CanDIG/go-model-service.git","clone_url":"https://github.com/CanDIG/go-model-service.git","svn_url":"https://github.com/CanDIG/go-model-service","homepage":"","size":39632,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26"},"html":{"href":"https://github.com/CanDIG/go-model-service/pull/26"},"issue":{"href":"https://api.github.com/repos/CanDIG/go-model-service/issues/26"},"comments":{"href":"https://api.github.com/repos/CanDIG/go-model-service/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanDIG/go-model-service/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/CanDIG/go-model-service/statuses/9b6906022c06127d7682ddf2b3ae9f9bb9e51b84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ljdursi"}}