{"action":"created","comment":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/comments/210393314","pull_request_review_id":146600540,"id":210393314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDM5MzMxNA==","diff_hunk":"@@ -0,0 +1,16 @@\n+import React from 'react'\n+import { Menu } from '@stardust-ui/react'\n+\n+const items = [\n+  { key: 'home', icon: 'home' },\n+  { key: 'users', icon: 'users' },\n+  { key: 'search', icon: 'search' },\n+]\n+\n+class MenuExampleIconsOnlyShorthand extends React.Component {\n+  render() {\n+    return <Menu icons defaultActiveIndex={0} items={items} />\n+  }\n+}","path":"docs/src/examples/components/Menu/Variations/MenuExampleIconsOnly.shorthand.tsx","position":14,"original_position":14,"commit_id":"3affab957c23d3067016321e14e6ee451062f805","original_commit_id":"3affab957c23d3067016321e14e6ee451062f805","user":{"login":"levithomason","id":5067638,"node_id":"MDQ6VXNlcjUwNjc2Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/5067638?v=4","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},"body":"This could be stateless for brevity.","created_at":"2018-08-15T20:12:21Z","updated_at":"2018-08-15T20:12:21Z","html_url":"https://github.com/stardust-ui/react/pull/73#discussion_r210393314","pull_request_url":"https://api.github.com/repos/stardust-ui/react/pulls/73","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments/210393314"},"html":{"href":"https://github.com/stardust-ui/react/pull/73#discussion_r210393314"},"pull_request":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/73","id":207322116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzIyMTE2","html_url":"https://github.com/stardust-ui/react/pull/73","diff_url":"https://github.com/stardust-ui/react/pull/73.diff","patch_url":"https://github.com/stardust-ui/react/pull/73.patch","issue_url":"https://api.github.com/repos/stardust-ui/react/issues/73","number":73,"state":"open","locked":false,"title":"feat(menu): Icons","user":{"login":"miroslavstastny","id":9615899,"node_id":"MDQ6VXNlcjk2MTU4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9615899?v=4","gravatar_id":"","url":"https://api.github.com/users/miroslavstastny","html_url":"https://github.com/miroslavstastny","followers_url":"https://api.github.com/users/miroslavstastny/followers","following_url":"https://api.github.com/users/miroslavstastny/following{/other_user}","gists_url":"https://api.github.com/users/miroslavstastny/gists{/gist_id}","starred_url":"https://api.github.com/users/miroslavstastny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miroslavstastny/subscriptions","organizations_url":"https://api.github.com/users/miroslavstastny/orgs","repos_url":"https://api.github.com/users/miroslavstastny/repos","events_url":"https://api.github.com/users/miroslavstastny/events{/privacy}","received_events_url":"https://api.github.com/users/miroslavstastny/received_events","type":"User","site_admin":false},"body":"<!-----------------------------------------------------------------------------\r\n\r\n  HEADS UP!\r\n\r\n  1. Text in [brackets] is for example only. Replace it with your information.\r\n\r\n  2. This template includes only one prop as an example (circular). If your\r\n     PR requires more, list them separately in similar fashion. \r\n\r\n------------------------------------------------------------------------------>\r\n# API Proposal\r\n\r\nstardust-ui/react-old#121\r\n\r\n## Menu Items with icons\r\n\r\nMenuItems can now contain icons:\r\n\r\n![image](https://user-images.githubusercontent.com/9615899/43902258-dfd884d0-9be9-11e8-8c45-705731791f42.png)\r\n![image](https://user-images.githubusercontent.com/9615899/43902270-e97958d4-9be9-11e8-815a-af92bb26cb3c.png)\r\n\r\n```jsx\r\nconst items = [\r\n  { key: 'home', content: 'Home', icon: { name: 'home', size: 'big' } },\r\n  { key: 'users', content: 'Users', icon: 'users' },\r\n  { key: 'search', icon: 'search' },\r\n]\r\n\r\nclass MenuExampleWithIconsShorthand extends React.Component {\r\n  render() {\r\n    return <Menu defaultActiveIndex={0} items={items} />\r\n  }\r\n}\r\n```\r\n\r\nMenu can also consist of Icons only (no text):\r\n![image](https://user-images.githubusercontent.com/9615899/43902312-06614c9a-9bea-11e8-9f15-f2d9332632f0.png)\r\n![image](https://user-images.githubusercontent.com/9615899/43902325-14e497e0-9bea-11e8-9eca-b4ea1133eb68.png)\r\n\r\n```jsx\r\nconst items = [\r\n  { key: 'home', icon: {name: 'home', size: 'big'} },\r\n  { key: 'users', icon: 'users' },\r\n  { key: 'search', icon: 'search' },\r\n]\r\n\r\nclass MenuExampleIconsOnlyShorthand extends React.Component {\r\n  render() {\r\n    return <Menu icons defaultActiveIndex={0} items={items} />\r\n  }\r\n}\r\n```\r\n\r\nIcons only menu intentionally has no spacing between items. In Teams, the free space around the icons is part of the SVG icons. If there is spacing required, it can be achived using `IMenuVariables.iconsMenuItemSpacing`\r\n\r\n### Problems\r\n\r\n- At the moment, it is not possible to create Menu with icons using Children API. We agreed that (for now) only Shorthand API will be supported for Menu. \r\n- Icons only menu hover and active states do not match spec as there is no support for hover icons in stardust yet.\r\n\r\n### TODO\r\n\r\n- [x] Conformance test\r\n- [x] Minimal doc site example\r\n- [ ] Stardust base theme\r\n- [x] Teams Light theme\r\n- [ ] Teams Dark theme\r\n- [ ] Teams Contrast theme\r\n- [ ] Confirm RTL usage\r\n- [ ] [W3 accessibility](https://www.w3.org/standards/webdesign/accessibility) check\r\n- [ ] [Stardust accessibility](https://github.com/stardust-ui/accessibility) check\r\n- [ ] Update glossary props table\r\n- [ ] Update the CHANGELOG.md","created_at":"2018-08-09T13:46:39Z","updated_at":"2018-08-15T20:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b2857523b563dc57d729af46e931e03c5b17a65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davezuko","id":6439050,"node_id":"MDQ6VXNlcjY0MzkwNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6439050?v=4","gravatar_id":"","url":"https://api.github.com/users/davezuko","html_url":"https://github.com/davezuko","followers_url":"https://api.github.com/users/davezuko/followers","following_url":"https://api.github.com/users/davezuko/following{/other_user}","gists_url":"https://api.github.com/users/davezuko/gists{/gist_id}","starred_url":"https://api.github.com/users/davezuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezuko/subscriptions","organizations_url":"https://api.github.com/users/davezuko/orgs","repos_url":"https://api.github.com/users/davezuko/repos","events_url":"https://api.github.com/users/davezuko/events{/privacy}","received_events_url":"https://api.github.com/users/davezuko/received_events","type":"User","site_admin":false},{"login":"kuzhelov","id":9024564,"node_id":"MDQ6VXNlcjkwMjQ1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9024564?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzhelov","html_url":"https://github.com/kuzhelov","followers_url":"https://api.github.com/users/kuzhelov/followers","following_url":"https://api.github.com/users/kuzhelov/following{/other_user}","gists_url":"https://api.github.com/users/kuzhelov/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzhelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzhelov/subscriptions","organizations_url":"https://api.github.com/users/kuzhelov/orgs","repos_url":"https://api.github.com/users/kuzhelov/repos","events_url":"https://api.github.com/users/kuzhelov/events{/privacy}","received_events_url":"https://api.github.com/users/kuzhelov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1025396700,"node_id":"MDU6TGFiZWwxMDI1Mzk2NzAw","url":"https://api.github.com/repos/stardust-ui/react/labels/ready%20for%20review","name":"ready for review","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stardust-ui/react/pulls/73/commits","review_comments_url":"https://api.github.com/repos/stardust-ui/react/pulls/73/comments","review_comment_url":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stardust-ui/react/issues/73/comments","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/3affab957c23d3067016321e14e6ee451062f805","head":{"label":"stardust-ui:feat/menu-icons","ref":"feat/menu-icons","sha":"3affab957c23d3067016321e14e6ee451062f805","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-08-15T18:27:12Z","pushed_at":"2018-08-15T19:36:09Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":16622,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":35,"watchers":12,"default_branch":"master"}},"base":{"label":"stardust-ui:master","ref":"master","sha":"de2cff1de88d9688a6689c1115d71e17edc0e205","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-08-15T18:27:12Z","pushed_at":"2018-08-15T19:36:09Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":16622,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":35,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/73"},"html":{"href":"https://github.com/stardust-ui/react/pull/73"},"issue":{"href":"https://api.github.com/repos/stardust-ui/react/issues/73"},"comments":{"href":"https://api.github.com/repos/stardust-ui/react/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/stardust-ui/react/statuses/3affab957c23d3067016321e14e6ee451062f805"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"levithomason"}}