{"action":"created","issue":{"url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/5","repository_url":"https://api.github.com/repos/mdab121/vapor-fcm","labels_url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/5/comments","events_url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/5/events","html_url":"https://github.com/mdab121/vapor-fcm/pull/5","id":335440509,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTM4NDQ0","number":5,"title":"Differentiate between multicast and topic response","user":{"login":"cweinberger","id":668808,"node_id":"MDQ6VXNlcjY2ODgwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/668808?v=4","gravatar_id":"","url":"https://api.github.com/users/cweinberger","html_url":"https://github.com/cweinberger","followers_url":"https://api.github.com/users/cweinberger/followers","following_url":"https://api.github.com/users/cweinberger/following{/other_user}","gists_url":"https://api.github.com/users/cweinberger/gists{/gist_id}","starred_url":"https://api.github.com/users/cweinberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweinberger/subscriptions","organizations_url":"https://api.github.com/users/cweinberger/orgs","repos_url":"https://api.github.com/users/cweinberger/repos","events_url":"https://api.github.com/users/cweinberger/events{/privacy}","received_events_url":"https://api.github.com/users/cweinberger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-25T14:48:58Z","updated_at":"2018-07-15T13:33:10Z","closed_at":"2018-07-15T13:33:10Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mdab121/vapor-fcm/pulls/5","html_url":"https://github.com/mdab121/vapor-fcm/pull/5","diff_url":"https://github.com/mdab121/vapor-fcm/pull/5.diff","patch_url":"https://github.com/mdab121/vapor-fcm/pull/5.patch"},"body":"`FirebaseResponse` always returned `success`: `false`.\r\n\r\nTwo reasons:\r\n\r\n1.) When using topics, the result (message_id) will not be wrapped into `results`. Instead it's inserted directly on root-level:\r\n\r\n```\r\n//Success example:\r\n{\r\n  \"message_id\": \"1023456\"\r\n}\r\n\r\n//failure example:\r\n{\r\n  \"error\": \"TopicsMessageRateExceeded\"\r\n}\r\n```\r\n\r\n2.) The type of `message_id` within `dict` is not `String` but `Uint`, which resulted in the downcast to fail. I have removed that strict casting.\r\n\r\nSee: https://firebase.google.com/docs/cloud-messaging/send-message"},"comment":{"url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/comments/405092395","html_url":"https://github.com/mdab121/vapor-fcm/pull/5#issuecomment-405092395","issue_url":"https://api.github.com/repos/mdab121/vapor-fcm/issues/5","id":405092395,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTA5MjM5NQ==","user":{"login":"mdab121","id":1230922,"node_id":"MDQ6VXNlcjEyMzA5MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1230922?v=4","gravatar_id":"","url":"https://api.github.com/users/mdab121","html_url":"https://github.com/mdab121","followers_url":"https://api.github.com/users/mdab121/followers","following_url":"https://api.github.com/users/mdab121/following{/other_user}","gists_url":"https://api.github.com/users/mdab121/gists{/gist_id}","starred_url":"https://api.github.com/users/mdab121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdab121/subscriptions","organizations_url":"https://api.github.com/users/mdab121/orgs","repos_url":"https://api.github.com/users/mdab121/repos","events_url":"https://api.github.com/users/mdab121/events{/privacy}","received_events_url":"https://api.github.com/users/mdab121/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T13:33:10Z","updated_at":"2018-07-15T13:33:10Z","author_association":"OWNER","body":"Hey. I've finally had a chance to review this. It doesn't work for me – I don't like and try to avoid `Any` whenever possible. Please see #6. "}}
{"actor":{"display_login":"mdab121"}}