{"push_id":2407535494,"size":28,"distinct_size":1,"ref":"refs/heads/jk/read-tree-content-merge-wip","head":"812a3d0a55318814032737986076d1b2c7894fb5","before":"120588ba7dc7d00304e17585ca0a1fc2d0ca5de4","commits":[{"sha":"b6049542b97e7b135e0e82bf996084d461224d32","author":{"name":"Nathan Payre","email":"398634445845a71066e74baf246da3dcd8d28d42@etu.univ-lyon1.fr"},"message":"send-email: extract email-parsing code into a subroutine\n\nThe existing code mixes parsing of email header with regular\nexpression and actual code. Extract the parsing code into a new\nsubroutine \"parse_header_line()\". This improves the code readability\nand make parse_header_line reusable in other place.\n\n\"parsed_header_line()\" and \"filter_body()\" could be used for\nrefactoring the part of code which parses the header to prepare the\nemail and send it.\n\nIn contrast to the previous version it doesn't keep the header order\nand strip duplicate headers.\n\nSigned-off-by: Nathan Payre <nathan.payre@etu.univ-lyon1.fr>\nSigned-off-by: Matthieu Moy <matthieu.moy@univ-lyon1.fr>\nSigned-off-by: Timothee Albertin <timothee.albertin@etu.univ-lyon1.fr>\nSigned-off-by: Daniel Bensoussan <daniel.bensoussan--bohm@etu.univ-lyon1.fr>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nHelped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nReviewed-by: Matthieu Moy <matthieu.moy@univ-lyon1.fr>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/b6049542b97e7b135e0e82bf996084d461224d32"},{"sha":"ca2a4f4a7ee1616b593ee7606139e10c77764006","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: *.pm files should not have the executable bit\n\nThe Git::Mail::Address file added in bd869f67b9 (\"send-email: add and\nuse a local copy of Mail::Address\", 2018-01-05) had the executable bit\nset. That bit should not be set for *.pm files. It breaks nothing but\nit is redundant and confusing as none of the other files have it and\nthese files are never executed as stand-alone programs.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/ca2a4f4a7ee1616b593ee7606139e10c77764006"},{"sha":"872ba001f8caaeb496ad79c55fe587a5e31b54f2","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"Git.pm: remove redundant \"use strict\" from sub-package\n\nIn Perl the \"use strict/warnings\" pragmas are lexical, thus there's no\nreason to do:\n\n    package Foo;\n    use strict;\n    package Bar;\n    use strict;\n    $x = 5;\n\nTo satisfy the desire that the undeclared $x variable will be spotted\nat compile-time. It's enough to include the first \"use strict\".\n\nThis functionally changes nothing, but makes a subsequent change where\n\"use warnings\" will be added to Git.pm less confusing and less\nverbose, since as with \"strict\" we'll only need to do that at the top\nof the file.\n\nChanges code initially added in a6065b548f (\"Git.pm: Try to support\nActiveState output pipe\", 2006-06-25).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/872ba001f8caaeb496ad79c55fe587a5e31b54f2"},{"sha":"f0e19cb7ced7b640d363b61d7ce17b83901777da","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"Git.pm: add the \"use warnings\" pragma\n\nAmend Git.pm to load the \"warnings\" pragma like the rest of the code\nin perl/ in addition to the existing \"strict\" pragma. This is\nconsidered the bare minimum best practice in Perl.\n\nEver since this code was introduced in b1edc53d06 (\"Introduce\nGit.pm (v4)\", 2006-06-24) it's only been using \"strict\", not\n\"warnings\".\n\nThis leaves contrib/buildsystems/Generators/{QMake,VCproj}.pm and\ncontrib/mw-to-git/Git/Mediawiki.pm without \"use warnings\". Amending\nthose would be a sensible follow-up change, but I don't have an easy\nway to test those so I'm not changing them.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/f0e19cb7ced7b640d363b61d7ce17b83901777da"},{"sha":"7d5b30e09fc705b84bba57ac655263ab6d8f71a6","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"gitweb: hard-depend on the Digest::MD5 5.8 module\n\nSince my d48b284183 (\"perl: bump the required Perl version to 5.8 from\n5.6.[21]\", 2010-09-24), we've depended on 5.8, so there's no reason to\nconditionally require Digest::MD5 anymore. It was released with perl\nv5.7.3[1]\n\nThe initial introduction of the dependency in\ne9fdd74e53 (\"gitweb: (gr)avatar support\", 2009-06-30) says as much,\nthis also undoes part of the later 2e9c8789b7 (\"gitweb: Mention\noptional Perl modules in INSTALL\", 2011-02-04) since gitweb will\nalways be run on at least 5.8, so there's no need to mention\nDigest::MD5 as a required module in the documentation, let's instead\nsay that we require perl 5.8.\n\n1. $ corelist Digest::MD5\n   Data for 2015-02-14\n   Digest::MD5 was first released with perl v5.7.3\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/7d5b30e09fc705b84bba57ac655263ab6d8f71a6"},{"sha":"29118b37eb8510dc42dd94e127f7c92d05963d1d","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"Git.pm: hard-depend on the File::{Temp,Spec} modules\n\nSince my d48b284183 (\"perl: bump the required Perl version to 5.8 from\n5.6.[21]\", 2010-09-24), we've depended on 5.8, so there's no reason to\nconditionally require File::Temp and File::Spec anymore. They were\nfirst released with perl versions v5.6.1 and 5.00405, respectively.\n\nThis code was originally added in c14c8ceb13 (\"Git.pm: Make File::Spec\nand File::Temp requirement lazy\", 2008-08-15), presumably to make\nGit.pm work on 5.6.0.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/29118b37eb8510dc42dd94e127f7c92d05963d1d"},{"sha":"1046c118d8116496dc4737b9229bdf7339202ba6","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"git-send-email: unconditionally use Net::{SMTP,Domain}\n\nThe Net::SMTP and Net::Domain were both first released with perl\nv5.7.3[1], since my d48b284183 (\"perl: bump the required Perl version\nto 5.8 from 5.6.[21]\", 2010-09-24) we've depended on 5.8, so there's\nno reason to conditionally require them anymore.\n\nThis conditional loading was initially added in\n87840620fd (\"send-email: only 'require' instead of 'use' Net::SMTP\",\n2006-06-01) for Net::SMTP and 134550fe21 (\"git-send-email.perl - try\nto give real name of the calling host to HELO/EHLO\", 2010-03-14) for\nNet::Domain, both of which predate the hard dependency on 5.8.\n\nSince they're guaranteed to be installed now let's \"use\" them\ninstead. The cost of loading them both is trivial given what\ngit-send-email does (~15ms on my system), and it's better to not defer\nany potential loading errors until runtime.\n\nThis patch is better viewed with -w, which shows that the only change\nin the last two hunks is removing the \"if eval\" wrapper block.\n\n1. $ parallel 'corelist {}' ::: Net::{SMTP,Domain}\n   Data for 2015-02-14\n   Net::SMTP was first released with perl v5.7.3\n\n   Data for 2015-02-14\n   Net::Domain was first released with perl v5.7.3\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/1046c118d8116496dc4737b9229bdf7339202ba6"},{"sha":"e5741c3627a9b50ba1f87a33d1ee2c3410486cac","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: update our ancient copy of Error.pm\n\nThe Error.pm shipped with Git as a fallback if there was no Error.pm\non the system was released in April 2006. There's been dozens of\nreleases since then, the latest at August 7, 2017. Let's update to\nthat.\n\nI don't know of anything we need from this new release or which this\nfixes. This change is simply a matter of keeping up with\nupstream. Before this users who'd install git via their package system\nwould get an up-to-date Error.pm, but if it's installed from source\nthey'd get one more than a decade old.\n\nThis undoes a local hack we'd accumulated in 96bc4de85c (\"Eliminate\nScalar::Util usage from private-Error.pm\", 2006-07-26), it's been\nredundant since my d48b284183 (\"perl: bump the required Perl version\nto 5.8 from 5.6.[21]\", 2010-09-24).\n\nThis also undoes 3a51467b94 (\"Typo fix: replacing it's -> its\",\n2013-04-13). This is the Nth time I find that some upstream code of\nours (in contrib/, in sha1dc/ and now in perl/ ...) has diverged from\nupstream because of some tree-wide typo fixing. Let's not do those\nfixes against upstream projects, it's more valuable that we have a 1=1\nmapping to upstream than to fix typos in docs we never even generate\nfrom this code. If someone wants to fix typos in them fine, but they\nshould do it with a patch to upstream which git.git can then\nincorporate.\n\nThe upstream code doesn't cleanly pass a --check, so I'm adding a\n.gitattributes file for similar reasons as done for sha1dc in\n5d184f468e (\"sha1dc: ignore indent-with-non-tab whitespace\nviolations\", 2017-06-06).\n\nThe updated source was retrieved from\nhttps://fastapi.metacpan.org/source/SHLOMIF/Error-0.17025/lib/Error.pm\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/e5741c3627a9b50ba1f87a33d1ee2c3410486cac"},{"sha":"10cf3b076da31320108ad16bc3695a5e6a4600b0","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: update our copy of Mail::Address\n\nUpdate our copy of Mail::Address from 2.19 (Aug 22, 2017) to 2.20 (Jan\n23, 2018). Like the preceding Error.pm update this is done simply to\nkeep up-to-date with upstream, and as can be shown from the diff\nthere's no functional changes.\n\nThe updated source was retrieved from\nhttps://fastapi.metacpan.org/source/MARKOV/MailTools-2.20/lib/Mail/Address.pm\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/10cf3b076da31320108ad16bc3695a5e6a4600b0"},{"sha":"28654678cff4c7b78f87a6768a896d76a1784d45","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: move CPAN loader wrappers to another namespace\n\nMove the Git::Error and Git::Mail::Address wrappers to the\nGit::LoadCPAN::Loader::* namespace, e.g. Git::LoadCPAN::Error. That\nmodule will then either load Error from CPAN (if installed on the OS),\nor use Git::FromCPAN::Error.\n\nWhen I added the Error wrapper in 20d2a30f8f (\"Makefile: replace\nperl/Makefile.PL with simple make rules\", 2017-12-10) I didn't think\nabout how confusing it would be to have these modules sitting in the\nsame tree as our normal modules. Let's put these all into\nGit::{Load,From}CPAN::* to clearly distinguish them from the rest.\n\nThis also makes things a bit less confusing since there was already a\nGit::Error namespace ever since 8b9150e3e3 (\"Git.pm: Handle failed\ncommands' output\", 2006-06-24).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/28654678cff4c7b78f87a6768a896d76a1784d45"},{"sha":"edfb7b92a1dbd70858ea5c5356cdb6dc14ec8d3a","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: generalize the Git::LoadCPAN facility\n\nChange the two wrappers that load from CPAN (local OS) or our own copy\nto do so via the same codepath.\n\nI added the Error.pm wrapper in 20d2a30f8f (\"Makefile: replace\nperl/Makefile.PL with simple make rules\", 2017-12-10), and shortly\nafterwards Matthieu Moy added a wrapper for Mail::Address in\nbd869f67b9 (\"send-email: add and use a local copy of Mail::Address\",\n2018-01-05).\n\nHis loader was simpler since Mail::Address doesn't have an \"import\"\nmethod, but didn't do the same sanity checking; For example, a missing\nFromCPAN directory (which OS packages are likely not to have) wouldn't\nbe explicitly warned about as a \"BUG: ...\".\n\nUpdate both to use a common implementation based on the previous\nError.pm loader. Which has been amended to take the module to load as\nparameter, as well as whether or not that module has an import\nmethod.\n\nThis loader should be generic enough to handle almost all CPAN modules\nout there, some use some crazy loading magic and wouldn't like being\nwrapped like this, but that would be immediately obvious, and we'd\nfind out right away since the module wouldn't work at all.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/edfb7b92a1dbd70858ea5c5356cdb6dc14ec8d3a"},{"sha":"382029fc003d400147339573ab5448a88c336f55","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl: move the perl/Git/FromCPAN tree to perl/FromCPAN\n\nMove the CPAN modules that have lived under perl/Git/FromCPAN since my\n20d2a30f8f (\"Makefile: replace perl/Makefile.PL with simple make\nrules\", 2017-12-10) to perl/FromCPAN.\n\nA subsequent change will teach the Makefile to only install these\ncopies of CPAN modules if a flag that distro packagers would like to\nset isn't set. Due to how the wildcard globbing is being done it's\nmuch easier to accomplish that if they're moved to their own\ndirectory.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/382029fc003d400147339573ab5448a88c336f55"},{"sha":"075321c0075b1ef86b98facc88bcaeefeb9584d1","author":{"name":"Todd Zullinger","email":"eda1a53aeee0e35b250c1ad5efd9d7ee63926d0e@pobox.com"},"message":"Makefile: add NO_PERL_CPAN_FALLBACKS knob\n\nWe include some perl modules which are not part of the core perl\ninstall, as a convenience.  This allows us to rely on those modules in\nour perl-based tools and scripts without requiring users to install the\nmodules from CPAN or their operating system packages.\n\nUsers whose operating system provides these modules and packagers of Git\noften don't want to ship or use these bundled modules.  Allow these\nusers to set NO_PERL_CPAN_FALLBACKS to avoid installing the bundled\nmodules.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/075321c0075b1ef86b98facc88bcaeefeb9584d1"},{"sha":"1aca69c0195bd4ac671e7a36cf9b967d2bcbe200","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"perl Git::LoadCPAN: emit better errors under NO_PERL_CPAN_FALLBACKS\n\nBefore my 20d2a30f8f (\"Makefile: replace perl/Makefile.PL with simple\nmake rules\", 2017-12-10) on an OS package that removed the\nprivate-Error.pm copy we carried around manually removing the OS's\nError.pm would yield:\n\n    $ git add -p\n    Can't locate Error.pm in @INC (you may need to install the Error module) [...]\n\nNow, before this change we'll instead emit this more cryptic error:\n\n    $ git add -p\n    BUG: '/usr/share/perl5/Git/FromCPAN' should be a directory! at /usr/share/perl5/Git/Error.pm line 36.\n\nThis is a confusing error. Now if the new NO_PERL_CPAN_FALLBACKS\noption is specified and we can't find the module we'll instead emit:\n\n    $ /tmp/git/bin/git add -p\n    BUG: The 'Error' module is not here, but NO_PERL_CPAN_FALLBACKS was set!\n\n    [...]\n\nWhere [...] is the lengthy explanation seen in the change below, which\nexplains what the potential breakage is, and how to fix it.\n\nThe reason for checking @@NO_PERL_CPAN_FALLBACKS@@] against the empty\nstring in Perl is as opposed to checking for a boolean value is that\nthat's (as far as I can tell) make's idea of a string that's set, and\ne.g. NO_PERL_CPAN_FALLBACKS=0 is enough to set NO_PERL_CPAN_FALLBACKS.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/1aca69c0195bd4ac671e7a36cf9b967d2bcbe200"},{"sha":"15dc3b9161dad12e37d74863d0ab5d94b661a936","author":{"name":"Christian Ludwig","email":"4f412300f9db1243b5124829198f54aa91a2d210@gmail.com"},"message":"send-email: rename variable for clarity\n\nThe SMTP protocol has both, the 'Reply-To' and the 'In-Reply-To' header\nfields. We only use the latter. To avoid confusion, rename the variable\nfor it.\n\nSigned-off-by: Christian Ludwig <chrissicool@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/15dc3b9161dad12e37d74863d0ab5d94b661a936"},{"sha":"d11c943c7824ed91ec396c8726d18ce687848d34","author":{"name":"Christian Ludwig","email":"4f412300f9db1243b5124829198f54aa91a2d210@gmail.com"},"message":"send-email: support separate Reply-To address\n\nIn some projects contributions from groups are only accepted from a\ncommon group email address. But every individual may want to receive\nreplies to her own personal address. That's what we have 'Reply-To'\nheaders for in SMTP. So introduce an optional '--reply-to' command\nline option.\n\nThis patch re-uses the $reply_to variable. This could break\nout-of-tree patches!\n\nSigned-off-by: Christian Ludwig <chrissicool@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/d11c943c7824ed91ec396c8726d18ce687848d34"},{"sha":"a12cec99f8b64a0b99ae6f8a7e4724039406aea3","author":{"name":"Thomas Levesque","email":"5a68f0c7b951bd8f264f7717980d953c221e4f86@gmail.com"},"message":"userdiff.c: add C# async keyword in diff pattern\n\nCurrently C# async methods are not shown in diff hunk headers. I just\nadded the async keyword to the csharp method pattern so that they are\nproperly detected.\n\nSigned-off-by: Thomas Levesque <thomas.levesque@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/a12cec99f8b64a0b99ae6f8a7e4724039406aea3"},{"sha":"2caa7b8d27e7ee97d70929be143da293ede69cde","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"git manpage: note git-security@googlegroups.com\n\nAdd a mention of the security mailing list to the \"Reporting Bugs\"\nsection. There's a mention of this list at\nhttps://git-scm.com/community but none in git.git itself.\n\nThe copy is pasted from the git-scm.com website. Let's use the same\nwording in both places.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/2caa7b8d27e7ee97d70929be143da293ede69cde"},{"sha":"54ce2e9be987e4b0aea354e2db708c94f1708f85","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'\n\nThe test 'cvs update (-p)' redirects and checks 'test_cmp's stdout and\neven its stderr.  The commit introducing this test in 6e8937a084\n(cvsserver: Add test for update -p, 2008-03-27) doesn't discuss why,\nin fact its log message only consists of that subject line.  Anyway,\nweird as it is, it kind of made sense due to the way that test was\nstructured:\n\nAfter a bit of preparation, this test updates four files via CVS and\nchecks their contents using 'test_cmp', but it does so in a for loop\niterating over the names of those four files.  Now, the exit status of\na for loop is the exit status of the last command executed in the\nloop, meaning that the test can't simply rely on the exit code of\n'test_cmp' in the loop's body.  Instead, the test works it around by\nrelying on the stdout of 'test_cmp' being silent on success and\nshowing the diff on failure, as it appends the stdout of all four\n'test_cmp' invocations to a single file and checks that file's\nemptiness after the loop (with 'test -z \"$(cat ...)\"', no less; there\nwas no 'test_must_be_empty' back then).  Furthermore, the test\nredirects the stderr of those 'test_cmp' invocations to this file,\ntoo: while 'test_cmp' itself doesn't output anything to stderr, the\ninvoked 'diff' or 'cmp' commands do send their error messages there,\ne.g. if they can't open a file because its name was misspelled.\n\nThis also makes this test fail when the test script is run with '-x'\ntracing (and using a shell other than a Bash version supporting\nBASH_XTRACEFD), because 'test_cmp's stderr contains the trace of the\n'diff' command executed inside the helper function, throwing off the\nsubsequent emptiness check.\n\nStop relying on 'test_cmp's output and instead run 'test_cmp a b ||\nreturn 1' in the for loop in order to make 'test_cmp's error code fail\nthe test.  Furthermore, add the missing && after the cvs command to\ncreate a && chain in the loop's body.\n\nAfter this change t9400 passes with '-x', even when running with\n/bin/sh.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/54ce2e9be987e4b0aea354e2db708c94f1708f85"},{"sha":"c20bf94abcf49323fdbd398c412a6cf6af3f3a61","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t9402-git-cvsserver-refs: don't check the stderr of a subshell\n\nFour 'cvs diff' related tests in 't9402-git-cvsserver-refs.sh' fail\nwhen the test script is run with '-x' tracing (and using a shell other\nthan a Bash version supporting BASH_XTRACEFD).  The reason for those\nfailures is that the tests check the emptiness of a subshell's stderr,\nwhich includes the trace of commands executed in that subshell as\nwell, throwing off the emptiness check.\n\nSave the stdout and stderr of the invoked 'cvs' command instead of the\nwhole subshell, so the latter remains free from tracing output.  (Note\nthat changing how stdout is saved is only done for the sake of\nconsistency, it's not necessary for correctness.)\n\nAfter this change t9402 passes with '-x', even when running with\n/bin/sh.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/c20bf94abcf49323fdbd398c412a6cf6af3f3a61"}]}
{"actor":{"display_login":"peff"}}