{"action":"created","comment":{"url":"https://api.github.com/repos/obsproject/obs-studio/pulls/comments/197600214","pull_request_review_id":131382205,"id":197600214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYwMDIxNA==","diff_hunk":"@@ -0,0 +1,69 @@\n+#include \"DecklinkOutputUI.h\"\n+#include <obs-module.h>\n+#include <util/platform.h>\n+#include \"decklink-ui-main.h\"\n+\n+DecklinkOutputUI::DecklinkOutputUI(QWidget *parent)\n+\t\t: QDialog(parent),\n+\t\t  ui(new Ui_Output) {\n+\tui->setupUi(this);\n+\n+\tpropertiesView = nullptr;\n+\n+\tconnect( ui->startOutput, SIGNAL( released() ), this, SLOT(StartOutput()) );\n+\tconnect( ui->stopOutput, SIGNAL( released() ), this, SLOT(StopOutput()) );\n+}\n+\n+void DecklinkOutputUI::ShowHideDialog() {\n+\tSetupPropertiesView();\n+\n+\tif (!isVisible()) {","path":"UI/frontend-plugins/decklink-output-ui/DecklinkOutputUI.cpp","position":20,"original_position":20,"commit_id":"b1a62e0aee2e4df2ffa1e93a16904a1b65d0563a","original_commit_id":"bd09b395cd4ada0c0040490ac1b1f9ad91a1b4f0","user":{"login":"RytoEX","id":624931,"node_id":"MDQ6VXNlcjYyNDkzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/624931?v=4","gravatar_id":"","url":"https://api.github.com/users/RytoEX","html_url":"https://github.com/RytoEX","followers_url":"https://api.github.com/users/RytoEX/followers","following_url":"https://api.github.com/users/RytoEX/following{/other_user}","gists_url":"https://api.github.com/users/RytoEX/gists{/gist_id}","starred_url":"https://api.github.com/users/RytoEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RytoEX/subscriptions","organizations_url":"https://api.github.com/users/RytoEX/orgs","repos_url":"https://api.github.com/users/RytoEX/repos","events_url":"https://api.github.com/users/RytoEX/events{/privacy}","received_events_url":"https://api.github.com/users/RytoEX/received_events","type":"User","site_admin":false},"body":"Style:  This `if` statement does not need curly braces.  Remove them.\r\n\r\nIs there a particular reason to use `!isVisible()` instead of the _slightly_ shorter `isVisible()`?","created_at":"2018-06-23T02:49:49Z","updated_at":"2018-06-23T03:01:50Z","html_url":"https://github.com/obsproject/obs-studio/pull/1043#discussion_r197600214","pull_request_url":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/comments/197600214"},"html":{"href":"https://github.com/obsproject/obs-studio/pull/1043#discussion_r197600214"},"pull_request":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043"}}},"pull_request":{"url":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043","id":145363370,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ1MzYzMzcw","html_url":"https://github.com/obsproject/obs-studio/pull/1043","diff_url":"https://github.com/obsproject/obs-studio/pull/1043.diff","patch_url":"https://github.com/obsproject/obs-studio/pull/1043.patch","issue_url":"https://api.github.com/repos/obsproject/obs-studio/issues/1043","number":1043,"state":"open","locked":false,"title":"Decklink: Add decklink output","user":{"login":"DDRBoxman","id":207897,"node_id":"MDQ6VXNlcjIwNzg5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/207897?v=4","gravatar_id":"","url":"https://api.github.com/users/DDRBoxman","html_url":"https://github.com/DDRBoxman","followers_url":"https://api.github.com/users/DDRBoxman/followers","following_url":"https://api.github.com/users/DDRBoxman/following{/other_user}","gists_url":"https://api.github.com/users/DDRBoxman/gists{/gist_id}","starred_url":"https://api.github.com/users/DDRBoxman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDRBoxman/subscriptions","organizations_url":"https://api.github.com/users/DDRBoxman/orgs","repos_url":"https://api.github.com/users/DDRBoxman/repos","events_url":"https://api.github.com/users/DDRBoxman/events{/privacy}","received_events_url":"https://api.github.com/users/DDRBoxman/received_events","type":"User","site_admin":false},"body":"- [x] Verify that looping back output to and input works withing OBS\r\n- [x] Configuration interface\r\n- [x] Better error handling in the decklink plugin in general\r\n- [x] A way to filter which output plugins are shown in the plugin output settings\r\n- [x] Save settings per plugin output type\r\n- [x] Audio Support\r\n- [ ] Investigate performance issue","created_at":"2017-10-09T01:22:19Z","updated_at":"2018-06-23T03:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a50aba4dad15b94bcff80fbe73b9abd0443750cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043/commits","review_comments_url":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043/comments","review_comment_url":"https://api.github.com/repos/obsproject/obs-studio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obsproject/obs-studio/issues/1043/comments","statuses_url":"https://api.github.com/repos/obsproject/obs-studio/statuses/b1a62e0aee2e4df2ffa1e93a16904a1b65d0563a","head":{"label":"DDRBoxman:decklinkout","ref":"decklinkout","sha":"b1a62e0aee2e4df2ffa1e93a16904a1b65d0563a","user":{"login":"DDRBoxman","id":207897,"node_id":"MDQ6VXNlcjIwNzg5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/207897?v=4","gravatar_id":"","url":"https://api.github.com/users/DDRBoxman","html_url":"https://github.com/DDRBoxman","followers_url":"https://api.github.com/users/DDRBoxman/followers","following_url":"https://api.github.com/users/DDRBoxman/following{/other_user}","gists_url":"https://api.github.com/users/DDRBoxman/gists{/gist_id}","starred_url":"https://api.github.com/users/DDRBoxman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDRBoxman/subscriptions","organizations_url":"https://api.github.com/users/DDRBoxman/orgs","repos_url":"https://api.github.com/users/DDRBoxman/repos","events_url":"https://api.github.com/users/DDRBoxman/events{/privacy}","received_events_url":"https://api.github.com/users/DDRBoxman/received_events","type":"User","site_admin":false},"repo":{"id":65592387,"node_id":"MDEwOlJlcG9zaXRvcnk2NTU5MjM4Nw==","name":"obs-studio","full_name":"DDRBoxman/obs-studio","owner":{"login":"DDRBoxman","id":207897,"node_id":"MDQ6VXNlcjIwNzg5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/207897?v=4","gravatar_id":"","url":"https://api.github.com/users/DDRBoxman","html_url":"https://github.com/DDRBoxman","followers_url":"https://api.github.com/users/DDRBoxman/followers","following_url":"https://api.github.com/users/DDRBoxman/following{/other_user}","gists_url":"https://api.github.com/users/DDRBoxman/gists{/gist_id}","starred_url":"https://api.github.com/users/DDRBoxman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDRBoxman/subscriptions","organizations_url":"https://api.github.com/users/DDRBoxman/orgs","repos_url":"https://api.github.com/users/DDRBoxman/repos","events_url":"https://api.github.com/users/DDRBoxman/events{/privacy}","received_events_url":"https://api.github.com/users/DDRBoxman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DDRBoxman/obs-studio","description":"OBS","fork":true,"url":"https://api.github.com/repos/DDRBoxman/obs-studio","forks_url":"https://api.github.com/repos/DDRBoxman/obs-studio/forks","keys_url":"https://api.github.com/repos/DDRBoxman/obs-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DDRBoxman/obs-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DDRBoxman/obs-studio/teams","hooks_url":"https://api.github.com/repos/DDRBoxman/obs-studio/hooks","issue_events_url":"https://api.github.com/repos/DDRBoxman/obs-studio/issues/events{/number}","events_url":"https://api.github.com/repos/DDRBoxman/obs-studio/events","assignees_url":"https://api.github.com/repos/DDRBoxman/obs-studio/assignees{/user}","branches_url":"https://api.github.com/repos/DDRBoxman/obs-studio/branches{/branch}","tags_url":"https://api.github.com/repos/DDRBoxman/obs-studio/tags","blobs_url":"https://api.github.com/repos/DDRBoxman/obs-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DDRBoxman/obs-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DDRBoxman/obs-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/DDRBoxman/obs-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DDRBoxman/obs-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/DDRBoxman/obs-studio/languages","stargazers_url":"https://api.github.com/repos/DDRBoxman/obs-studio/stargazers","contributors_url":"https://api.github.com/repos/DDRBoxman/obs-studio/contributors","subscribers_url":"https://api.github.com/repos/DDRBoxman/obs-studio/subscribers","subscription_url":"https://api.github.com/repos/DDRBoxman/obs-studio/subscription","commits_url":"https://api.github.com/repos/DDRBoxman/obs-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/DDRBoxman/obs-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/DDRBoxman/obs-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/DDRBoxman/obs-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/DDRBoxman/obs-studio/contents/{+path}","compare_url":"https://api.github.com/repos/DDRBoxman/obs-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DDRBoxman/obs-studio/merges","archive_url":"https://api.github.com/repos/DDRBoxman/obs-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DDRBoxman/obs-studio/downloads","issues_url":"https://api.github.com/repos/DDRBoxman/obs-studio/issues{/number}","pulls_url":"https://api.github.com/repos/DDRBoxman/obs-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/DDRBoxman/obs-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/DDRBoxman/obs-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DDRBoxman/obs-studio/labels{/name}","releases_url":"https://api.github.com/repos/DDRBoxman/obs-studio/releases{/id}","deployments_url":"https://api.github.com/repos/DDRBoxman/obs-studio/deployments","created_at":"2016-08-13T01:10:11Z","updated_at":"2018-05-01T14:57:48Z","pushed_at":"2018-06-23T02:53:48Z","git_url":"git://github.com/DDRBoxman/obs-studio.git","ssh_url":"git@github.com:DDRBoxman/obs-studio.git","clone_url":"https://github.com/DDRBoxman/obs-studio.git","svn_url":"https://github.com/DDRBoxman/obs-studio","homepage":"https://obsproject.com/mantis/","size":25621,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"obsproject:master","ref":"master","sha":"b760b24ff00e844c34be0d26222976ee99281472","user":{"login":"obsproject","id":7725691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3MjU2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7725691?v=4","gravatar_id":"","url":"https://api.github.com/users/obsproject","html_url":"https://github.com/obsproject","followers_url":"https://api.github.com/users/obsproject/followers","following_url":"https://api.github.com/users/obsproject/following{/other_user}","gists_url":"https://api.github.com/users/obsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/obsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsproject/subscriptions","organizations_url":"https://api.github.com/users/obsproject/orgs","repos_url":"https://api.github.com/users/obsproject/repos","events_url":"https://api.github.com/users/obsproject/events{/privacy}","received_events_url":"https://api.github.com/users/obsproject/received_events","type":"Organization","site_admin":false},"repo":{"id":13233158,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIzMzE1OA==","name":"obs-studio","full_name":"obsproject/obs-studio","owner":{"login":"obsproject","id":7725691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3MjU2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7725691?v=4","gravatar_id":"","url":"https://api.github.com/users/obsproject","html_url":"https://github.com/obsproject","followers_url":"https://api.github.com/users/obsproject/followers","following_url":"https://api.github.com/users/obsproject/following{/other_user}","gists_url":"https://api.github.com/users/obsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/obsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsproject/subscriptions","organizations_url":"https://api.github.com/users/obsproject/orgs","repos_url":"https://api.github.com/users/obsproject/repos","events_url":"https://api.github.com/users/obsproject/events{/privacy}","received_events_url":"https://api.github.com/users/obsproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obsproject/obs-studio","description":"OBS Studio - Free and open source software for live streaming and screen recording","fork":false,"url":"https://api.github.com/repos/obsproject/obs-studio","forks_url":"https://api.github.com/repos/obsproject/obs-studio/forks","keys_url":"https://api.github.com/repos/obsproject/obs-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obsproject/obs-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obsproject/obs-studio/teams","hooks_url":"https://api.github.com/repos/obsproject/obs-studio/hooks","issue_events_url":"https://api.github.com/repos/obsproject/obs-studio/issues/events{/number}","events_url":"https://api.github.com/repos/obsproject/obs-studio/events","assignees_url":"https://api.github.com/repos/obsproject/obs-studio/assignees{/user}","branches_url":"https://api.github.com/repos/obsproject/obs-studio/branches{/branch}","tags_url":"https://api.github.com/repos/obsproject/obs-studio/tags","blobs_url":"https://api.github.com/repos/obsproject/obs-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obsproject/obs-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obsproject/obs-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/obsproject/obs-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obsproject/obs-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/obsproject/obs-studio/languages","stargazers_url":"https://api.github.com/repos/obsproject/obs-studio/stargazers","contributors_url":"https://api.github.com/repos/obsproject/obs-studio/contributors","subscribers_url":"https://api.github.com/repos/obsproject/obs-studio/subscribers","subscription_url":"https://api.github.com/repos/obsproject/obs-studio/subscription","commits_url":"https://api.github.com/repos/obsproject/obs-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/obsproject/obs-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/obsproject/obs-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/obsproject/obs-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/obsproject/obs-studio/contents/{+path}","compare_url":"https://api.github.com/repos/obsproject/obs-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obsproject/obs-studio/merges","archive_url":"https://api.github.com/repos/obsproject/obs-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obsproject/obs-studio/downloads","issues_url":"https://api.github.com/repos/obsproject/obs-studio/issues{/number}","pulls_url":"https://api.github.com/repos/obsproject/obs-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/obsproject/obs-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/obsproject/obs-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obsproject/obs-studio/labels{/name}","releases_url":"https://api.github.com/repos/obsproject/obs-studio/releases{/id}","deployments_url":"https://api.github.com/repos/obsproject/obs-studio/deployments","created_at":"2013-10-01T02:40:31Z","updated_at":"2018-06-23T02:59:44Z","pushed_at":"2018-06-23T02:53:49Z","git_url":"git://github.com/obsproject/obs-studio.git","ssh_url":"git@github.com:obsproject/obs-studio.git","clone_url":"https://github.com/obsproject/obs-studio.git","svn_url":"https://github.com/obsproject/obs-studio","homepage":"https://obsproject.com/","size":25637,"stargazers_count":9702,"watchers_count":9702,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2199,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2199,"open_issues":61,"watchers":9702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043"},"html":{"href":"https://github.com/obsproject/obs-studio/pull/1043"},"issue":{"href":"https://api.github.com/repos/obsproject/obs-studio/issues/1043"},"comments":{"href":"https://api.github.com/repos/obsproject/obs-studio/issues/1043/comments"},"review_comments":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043/comments"},"review_comment":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obsproject/obs-studio/pulls/1043/commits"},"statuses":{"href":"https://api.github.com/repos/obsproject/obs-studio/statuses/b1a62e0aee2e4df2ffa1e93a16904a1b65d0563a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RytoEX"}}