{"action":"closed","number":493,"pull_request":{"url":"https://api.github.com/repos/guardian/identity-frontend/pulls/493","id":232318788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzE4Nzg4","html_url":"https://github.com/guardian/identity-frontend/pull/493","diff_url":"https://github.com/guardian/identity-frontend/pull/493.diff","patch_url":"https://github.com/guardian/identity-frontend/pull/493.patch","issue_url":"https://api.github.com/repos/guardian/identity-frontend/issues/493","number":493,"state":"closed","locked":false,"title":"Remove signin email on login and logout","user":{"login":"Calum-Campbell","id":14179210,"node_id":"MDQ6VXNlcjE0MTc5MjEw","avatar_url":"https://avatars1.githubusercontent.com/u/14179210?v=4","gravatar_id":"","url":"https://api.github.com/users/Calum-Campbell","html_url":"https://github.com/Calum-Campbell","followers_url":"https://api.github.com/users/Calum-Campbell/followers","following_url":"https://api.github.com/users/Calum-Campbell/following{/other_user}","gists_url":"https://api.github.com/users/Calum-Campbell/gists{/gist_id}","starred_url":"https://api.github.com/users/Calum-Campbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calum-Campbell/subscriptions","organizations_url":"https://api.github.com/users/Calum-Campbell/orgs","repos_url":"https://api.github.com/users/Calum-Campbell/repos","events_url":"https://api.github.com/users/Calum-Campbell/events{/privacy}","received_events_url":"https://api.github.com/users/Calum-Campbell/received_events","type":"User","site_admin":false},"body":"- Remove GU_SIGNIN_EMAIL cookie after successful login\r\n- Remove GU_SIGNIN_EMAIL on successful logout\r\n- Also start to remove SC_GU_LA on logout (should have been doing this anyway)\r\nNB:\r\nDecided to leave the signin_email as a session cookie, this way it will still be around if the user navigates away from profile then back to it later. I don't think it is necessary to enforce it's deletion after a certain time.","created_at":"2018-11-20T13:34:11Z","updated_at":"2018-11-20T14:59:37Z","closed_at":"2018-11-20T14:59:37Z","merged_at":null,"merge_commit_sha":"391361e2e42b6466419de49c42f95cdfcdfebaaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/493/commits","review_comments_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/493/comments","review_comment_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/issues/493/comments","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/cf93d1f59f9c281e06cb02f0a79496e8902a1f53","head":{"label":"guardian:cc-remove-email-signin-cookie","ref":"cc-remove-email-signin-cookie","sha":"cf93d1f59f9c281e06cb02f0a79496e8902a1f53","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkyNzg2OA==","name":"identity-frontend","full_name":"guardian/identity-frontend","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-frontend/deployments","created_at":"2015-11-10T17:19:02Z","updated_at":"2018-11-20T12:35:22Z","pushed_at":"2018-11-20T14:55:52Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"https://profile.theguardian.com/signin","size":6893,"stargazers_count":29,"watchers_count":29,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":29,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"00e16c6dabfc5e314cfa5eab265e40e5a89eca8b","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkyNzg2OA==","name":"identity-frontend","full_name":"guardian/identity-frontend","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-frontend/deployments","created_at":"2015-11-10T17:19:02Z","updated_at":"2018-11-20T12:35:22Z","pushed_at":"2018-11-20T14:55:52Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"https://profile.theguardian.com/signin","size":6893,"stargazers_count":29,"watchers_count":29,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/493"},"html":{"href":"https://github.com/guardian/identity-frontend/pull/493"},"issue":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/493"},"comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/identity-frontend/statuses/cf93d1f59f9c281e06cb02f0a79496e8902a1f53"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":24,"deletions":10,"changed_files":5}}
{"actor":{"display_login":"Calum-Campbell"}}