{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8658","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8658/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8658/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8658/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/8658","id":377947172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzY4MTQz","number":8658,"title":"Update SAML21J18A target to Mbed OS 5.10","user":{"login":"janjongboom","id":816856,"node_id":"MDQ6VXNlcjgxNjg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/816856?v=4","gravatar_id":"","url":"https://api.github.com/users/janjongboom","html_url":"https://github.com/janjongboom","followers_url":"https://api.github.com/users/janjongboom/followers","following_url":"https://api.github.com/users/janjongboom/following{/other_user}","gists_url":"https://api.github.com/users/janjongboom/gists{/gist_id}","starred_url":"https://api.github.com/users/janjongboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjongboom/subscriptions","organizations_url":"https://api.github.com/users/janjongboom/orgs","repos_url":"https://api.github.com/users/janjongboom/repos","events_url":"https://api.github.com/users/janjongboom/events{/privacy}","received_events_url":"https://api.github.com/users/janjongboom/received_events","type":"User","site_admin":false},"labels":[{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false},{"id":450730565,"node_id":"MDU6TGFiZWw0NTA3MzA1NjU=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/scope:%20new-target","name":"scope: new-target","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-06T17:10:23Z","updated_at":"2018-11-29T16:52:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8658","html_url":"https://github.com/ARMmbed/mbed-os/pull/8658","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8658.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8658.patch"},"body":"### Description\r\n\r\n<!-- \r\n    Required\r\n    Add here detailed changes summary, testing results, dependencies \r\n    Good example: https://os.mbed.com/docs/latest/reference/workflow.html (Pull request template)\r\n-->\r\n\r\nCo-authored by @martinichka, follow up from https://github.com/ARMmbed/mbed-os/pull/7276.\r\n\r\nThis PR adds Mbed OS 5.10 (incl. RTOS) support for the SAML21J18A target. It also updates to the latest available device pack from MDK (to Keil.SAM-L_DFP.1.2.1). There are a few issues left to figure out, mostly timer related (see #8656). Tested on: SAML21 XPLAINED PRO development board (already landed in https://github.com/ARMmbed/mbed-ls/pull/390) with GCC ARM 6.\r\n\r\nNote that you need the latest interface firmware from the XPLAINED PRO board (automatically pops up when connecting in Atmel Studio).\r\n\r\nThere are issues with flashing binaries in succession via the USB drag-n-drop interface, which makes the automated testing process very painful (running into SYNC_FAILED often, restarting board solves this). Are there any ways to cut power to a board between GT tests?\r\n\r\n#### Todo\r\n\r\n* Need to fix #8656.\r\n* Update IAR and ARMCC linker scripts, only verified against GCC ARM.\r\n* Investigate other failing tests.\r\n* Enable LoRaWAN unit tests, not sure how to do that (@AnttiKauppila @hasnainvirk ?) - verified that the device can join the network and send messages, but would be good to test this.\r\n\r\n#### Test results\r\n\r\n```\r\nmbed-os-features-frameworks-utest-tests-unit_tests-basic_test                               OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-basic_test_default                       OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_control_async                       OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_control_repeat                      OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_selection                           OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_setup_failure                       OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_teardown_failure                    OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-minimal_async_scheduler                  OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-minimal_scheduler                        OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup        OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-test_setup_case_selection_failure        OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-test_setup_failure                       OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-test_skip                                OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-control_type                             OK\r\nmbed-os-features-frameworks-utest-tests-unit_tests-case_async_validate                      FAIL (https://github.com/ARMmbed/mbed-os/issues/8656)\r\nmbed-os-features-storage-tests-blockdevice-buffered_block_device                            OK\r\nmbed-os-features-storage-tests-blockdevice-flashsim_block_device                            OK\r\nmbed-os-features-storage-tests-blockdevice-heap_block_device                                OK\r\nmbed-os-features-storage-tests-blockdevice-mbr_block_device                                 OK\r\nmbed-os-features-storage-tests-blockdevice-util_block_device                                OK\r\nmbed-os-tests-integration-basic                                                             OK\r\nmbed-os-tests-mbed_drivers-c_strings                                                        OK\r\nmbed-os-tests-mbed_drivers-crc                                                              FAIL (Test thread safety)\r\nmbed-os-tests-mbed_drivers-dev_null                                                         OK\r\nmbed-os-tests-mbed_drivers-echo                                                             OK\r\nmbed-os-tests-mbed_drivers-generic_tests                                                    OK\r\nmbed-os-tests-mbed_drivers-sleep_lock                                                       OK\r\nmbed-os-tests-mbed_drivers-stl_features                                                     OK\r\nmbed-os-tests-mbed_functional-callback                                                      OK\r\nmbed-os-tests-mbed_functional-callback_big                                                  OK\r\nmbed-os-tests-mbed_functional-callback_small                                                OK\r\nmbed-os-tests-mbed_functional-functionpointer                                               OK\r\nmbed-os-tests-mbed_hal-critical_section                                                     OK\r\nmbed-os-tests-mbed_hal-rtc                                                                  FAIL (RTC - persist)\r\nmbed-os-tests-mbed_hal-rtc_reset                                                            FAIL\r\nmbed-os-tests-mbed_hal-rtc_time                                                             OK\r\nmbed-os-tests-mbed_hal-rtc_time_conv                                                        OK\r\nmbed-os-tests-mbed_hal-sleep                                                                FAIL (sleep - source of wake-up - us ticker)\r\nmbed-os-tests-mbed_hal-sleep_manager                                                        OK\r\nmbed-os-tests-mbed_hal-ticker                                                               FAIL (test_frequencies_and_masks)\r\nmbed-os-tests-mbed_platform-circularbuffer                                                  OK\r\nmbed-os-tests-mbed_platform-critical_section                                                FAIL (Test critical section C API)\r\nmbed-os-tests-mbed_platform-error_handling                                                  OK\r\nmbed-os-tests-mbed_platform-filehandle                                                      OK\r\nmbed-os-tests-mbed_platform-sharedptr                                                       OK\r\nmbed-os-tests-mbed_platform-singletonptr                                                    OK\r\nmbed-os-tests-mbed_platform-stats_heap                                                      OK\r\nmbed-os-tests-mbed_platform-system_reset                                                    OK\r\nmbed-os-tests-mbed_platform-transaction                                                     OK\r\nmbed-os-tests-mbedmicro-mbed-attributes                                                     OK\r\nmbed-os-tests-mbedmicro-mbed-call_before_main                                               OK\r\nmbed-os-tests-mbedmicro-mbed-cpp                                                            OK\r\nmbed-os-tests-mbedmicro-mbed-div                                                            OK\r\nmbed-os-tests-mbedmicro-mbed-static_assert                                                  OK\r\nmbed-os-tests-mbedmicro-rtos-mbed-kernel_tick_count                                         OK\r\nmbed-os-tests-mbedmicro-rtos-mbed-memorypool                                                OK\r\nmbed-os-tests-mbedtls-multi                                                                 OK\r\nmbed-os-tests-mbedtls-selftest                                                              FAIL (mbedtls_sha512_self_test)\r\n```\r\n\r\n[Full test log](https://gist.github.com/janjongboom/e17b3ee7db846b32646d2c471dda08a4)\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [X] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/442908754","html_url":"https://github.com/ARMmbed/mbed-os/pull/8658#issuecomment-442908754","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8658","id":442908754,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjkwODc1NA==","user":{"login":"cmonr","id":260086,"node_id":"MDQ6VXNlcjI2MDA4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/260086?v=4","gravatar_id":"","url":"https://api.github.com/users/cmonr","html_url":"https://github.com/cmonr","followers_url":"https://api.github.com/users/cmonr/followers","following_url":"https://api.github.com/users/cmonr/following{/other_user}","gists_url":"https://api.github.com/users/cmonr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonr/subscriptions","organizations_url":"https://api.github.com/users/cmonr/orgs","repos_url":"https://api.github.com/users/cmonr/repos","events_url":"https://api.github.com/users/cmonr/events{/privacy}","received_events_url":"https://api.github.com/users/cmonr/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T16:52:53Z","updated_at":"2018-11-29T16:52:53Z","author_association":"CONTRIBUTOR","body":"@janjongboom This'll need a rebase to pull the targets.json updates.\r\n\r\n@mbed-os-hal @ashok-rao @ARMmbed/mbed-os-maintainers @maclobdell Please review when able."}}
{"actor":{"display_login":"cmonr"}}