{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments/213330609","pull_request_review_id":150058530,"id":213330609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzMzMDYwOQ==","diff_hunk":"@@ -11,9 +11,9 @@ documentation = \"https://paritytech.github.io/jsonrpc/json_ipc_server/index.html\n [dependencies]\n log = \"0.4\"\n tokio-service = \"0.1\"\n-jsonrpc-core = { version = \"8.0\", path = \"../core\" }\n-jsonrpc-server-utils = { version = \"8.0\", path = \"../server-utils\" }\n-parity-tokio-ipc = { git = \"https://github.com/nikvolf/parity-tokio-ipc\", branch = \"stable\" }\n+jsonrpc-core = { version = \"9.0\", path = \"../core\" }\n+jsonrpc-server-utils = { version = \"9.0\", path = \"../server-utils\" }\n+parity-tokio-ipc = { git = \"https://github.com/poanetwork/parity-tokio-ipc\" }","path":"ipc/Cargo.toml","position":18,"original_position":18,"commit_id":"68c1faa0bfed53bf9d5eeb5acdd594251724dd18","original_commit_id":"68c1faa0bfed53bf9d5eeb5acdd594251724dd18","user":{"login":"tomusdrw","id":581548,"node_id":"MDQ6VXNlcjU4MTU0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/581548?v=4","gravatar_id":"","url":"https://api.github.com/users/tomusdrw","html_url":"https://github.com/tomusdrw","followers_url":"https://api.github.com/users/tomusdrw/followers","following_url":"https://api.github.com/users/tomusdrw/following{/other_user}","gists_url":"https://api.github.com/users/tomusdrw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomusdrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomusdrw/subscriptions","organizations_url":"https://api.github.com/users/tomusdrw/orgs","repos_url":"https://api.github.com/users/tomusdrw/repos","events_url":"https://api.github.com/users/tomusdrw/events{/privacy}","received_events_url":"https://api.github.com/users/tomusdrw/received_events","type":"User","site_admin":false},"body":"We need to switch to mainstream libs before merging.","created_at":"2018-08-28T14:13:36Z","updated_at":"2018-08-28T14:18:17Z","html_url":"https://github.com/paritytech/jsonrpc/pull/303#discussion_r213330609","pull_request_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments/213330609"},"html":{"href":"https://github.com/paritytech/jsonrpc/pull/303#discussion_r213330609"},"pull_request":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303","id":211194701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTk0NzAx","html_url":"https://github.com/paritytech/jsonrpc/pull/303","diff_url":"https://github.com/paritytech/jsonrpc/pull/303.diff","patch_url":"https://github.com/paritytech/jsonrpc/pull/303.patch","issue_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/303","number":303,"state":"open","locked":false,"title":"Update hyper to version 0.12.","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"body":"* Replace `tokio_core` with `tokio`.\r\n\r\n* `server_utils::reactor::Remote` has been renamed to `Executor`.\r\n  The `Shared` variant now contains a `tokio::runtime::TaskExecutor`.\r\n  This may need to be changed to a trait object (of\r\n  `tokio::executor::Executor`) or be otherwise abstracted to conceal the\r\n  type in the public API.\r\n\r\n* Bump crate versions to 0.9\r\n\r\nI've finally returned from conferences and had time to wrap this up. Please hit me with any nitpicks, suggestions, or anything else that needs to be changed.\r\n\r\nAlso, this PR uses forked versions of [parity-tokio-ipc](https://github.com/poanetwork/parity-tokio-ipc) and [tokio-named-pipes](https://github.com/poanetwork/tokio-named-pipes). I'll change the dependencies back to NikVolfs versions when he merges my updates (in a future PR).\r\n\r\nNext, I'll be updating Parity to use these new changes and to remove `tokio_core` etc. You *may* want to consider holding off on merging until I'm done, to ensure everything works properly. I don't have an estimate on when that will be.\r\n\r\nCloses https://github.com/paritytech/jsonrpc/issues/298","created_at":"2018-08-27T18:43:18Z","updated_at":"2018-08-28T14:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5536db736385f10e1acaf0bd7cc1b0ba93a02872","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303/commits","review_comments_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303/comments","review_comment_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/303/comments","statuses_url":"https://api.github.com/repos/paritytech/jsonrpc/statuses/68c1faa0bfed53bf9d5eeb5acdd594251724dd18","head":{"label":"c0gent:c0gent-hyper","ref":"c0gent-hyper","sha":"68c1faa0bfed53bf9d5eeb5acdd594251724dd18","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"repo":{"id":143908749,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MDg3NDk=","name":"jsonrpc","full_name":"c0gent/jsonrpc","owner":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c0gent/jsonrpc","description":"Rust JSON-RPC implementation","fork":true,"url":"https://api.github.com/repos/c0gent/jsonrpc","forks_url":"https://api.github.com/repos/c0gent/jsonrpc/forks","keys_url":"https://api.github.com/repos/c0gent/jsonrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c0gent/jsonrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c0gent/jsonrpc/teams","hooks_url":"https://api.github.com/repos/c0gent/jsonrpc/hooks","issue_events_url":"https://api.github.com/repos/c0gent/jsonrpc/issues/events{/number}","events_url":"https://api.github.com/repos/c0gent/jsonrpc/events","assignees_url":"https://api.github.com/repos/c0gent/jsonrpc/assignees{/user}","branches_url":"https://api.github.com/repos/c0gent/jsonrpc/branches{/branch}","tags_url":"https://api.github.com/repos/c0gent/jsonrpc/tags","blobs_url":"https://api.github.com/repos/c0gent/jsonrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c0gent/jsonrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c0gent/jsonrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/c0gent/jsonrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c0gent/jsonrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/c0gent/jsonrpc/languages","stargazers_url":"https://api.github.com/repos/c0gent/jsonrpc/stargazers","contributors_url":"https://api.github.com/repos/c0gent/jsonrpc/contributors","subscribers_url":"https://api.github.com/repos/c0gent/jsonrpc/subscribers","subscription_url":"https://api.github.com/repos/c0gent/jsonrpc/subscription","commits_url":"https://api.github.com/repos/c0gent/jsonrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/c0gent/jsonrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/c0gent/jsonrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/c0gent/jsonrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/c0gent/jsonrpc/contents/{+path}","compare_url":"https://api.github.com/repos/c0gent/jsonrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c0gent/jsonrpc/merges","archive_url":"https://api.github.com/repos/c0gent/jsonrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c0gent/jsonrpc/downloads","issues_url":"https://api.github.com/repos/c0gent/jsonrpc/issues{/number}","pulls_url":"https://api.github.com/repos/c0gent/jsonrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/c0gent/jsonrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/c0gent/jsonrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c0gent/jsonrpc/labels{/name}","releases_url":"https://api.github.com/repos/c0gent/jsonrpc/releases{/id}","deployments_url":"https://api.github.com/repos/c0gent/jsonrpc/deployments","created_at":"2018-08-07T17:54:51Z","updated_at":"2018-08-28T12:25:23Z","pushed_at":"2018-08-28T13:13:51Z","git_url":"git://github.com/c0gent/jsonrpc.git","ssh_url":"git@github.com:c0gent/jsonrpc.git","clone_url":"https://github.com/c0gent/jsonrpc.git","svn_url":"https://github.com/c0gent/jsonrpc","homepage":"","size":2440,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"4b6060bfd0399fa32bc8e177077952a8a6336db2","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":74377848,"node_id":"MDEwOlJlcG9zaXRvcnk3NDM3Nzg0OA==","name":"jsonrpc","full_name":"paritytech/jsonrpc","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/jsonrpc","description":"Rust JSON-RPC implementation","fork":false,"url":"https://api.github.com/repos/paritytech/jsonrpc","forks_url":"https://api.github.com/repos/paritytech/jsonrpc/forks","keys_url":"https://api.github.com/repos/paritytech/jsonrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/jsonrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/jsonrpc/teams","hooks_url":"https://api.github.com/repos/paritytech/jsonrpc/hooks","issue_events_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/jsonrpc/events","assignees_url":"https://api.github.com/repos/paritytech/jsonrpc/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/jsonrpc/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/jsonrpc/tags","blobs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/jsonrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/jsonrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/jsonrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/jsonrpc/languages","stargazers_url":"https://api.github.com/repos/paritytech/jsonrpc/stargazers","contributors_url":"https://api.github.com/repos/paritytech/jsonrpc/contributors","subscribers_url":"https://api.github.com/repos/paritytech/jsonrpc/subscribers","subscription_url":"https://api.github.com/repos/paritytech/jsonrpc/subscription","commits_url":"https://api.github.com/repos/paritytech/jsonrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/jsonrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/jsonrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/jsonrpc/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/jsonrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/jsonrpc/merges","archive_url":"https://api.github.com/repos/paritytech/jsonrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/jsonrpc/downloads","issues_url":"https://api.github.com/repos/paritytech/jsonrpc/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/jsonrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/jsonrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/jsonrpc/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/jsonrpc/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/jsonrpc/deployments","created_at":"2016-11-21T15:32:15Z","updated_at":"2018-08-28T10:34:33Z","pushed_at":"2018-08-28T13:13:53Z","git_url":"git://github.com/paritytech/jsonrpc.git","ssh_url":"git@github.com:paritytech/jsonrpc.git","clone_url":"https://github.com/paritytech/jsonrpc.git","svn_url":"https://github.com/paritytech/jsonrpc","homepage":"","size":2412,"stargazers_count":147,"watchers_count":147,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":42,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303"},"html":{"href":"https://github.com/paritytech/jsonrpc/pull/303"},"issue":{"href":"https://api.github.com/repos/paritytech/jsonrpc/issues/303"},"comments":{"href":"https://api.github.com/repos/paritytech/jsonrpc/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/jsonrpc/statuses/68c1faa0bfed53bf9d5eeb5acdd594251724dd18"}},"author_association":"NONE"}}
{"actor":{"display_login":"tomusdrw"}}