{"action":"closed","number":22914,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22914","id":216097793,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDk3Nzkz","html_url":"https://github.com/nodejs/node/pull/22914","diff_url":"https://github.com/nodejs/node/pull/22914.diff","patch_url":"https://github.com/nodejs/node/pull/22914.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22914","number":22914,"state":"closed","locked":false,"title":" deps: backport 958b761 from upstream V8","user":{"login":"mmarchini","id":4048656,"node_id":"MDQ6VXNlcjQwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4048656?v=4","gravatar_id":"","url":"https://api.github.com/users/mmarchini","html_url":"https://github.com/mmarchini","followers_url":"https://api.github.com/users/mmarchini/followers","following_url":"https://api.github.com/users/mmarchini/following{/other_user}","gists_url":"https://api.github.com/users/mmarchini/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarchini/subscriptions","organizations_url":"https://api.github.com/users/mmarchini/orgs","repos_url":"https://api.github.com/users/mmarchini/repos","events_url":"https://api.github.com/users/mmarchini/events{/privacy}","received_events_url":"https://api.github.com/users/mmarchini/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nOriginal commit message:\r\n\r\n    [postmortem] add postmortem metadata for symbols\r\n\r\n    As discussed in nodejs/llnode#156, we need\r\n    postmortem metadata for Symbols to properly print Symbol property names\r\n    in postmortem debugging tools. Patch suggested by Ben Noordhuis\r\n    (nodejs/llnode#156 (comment)).\r\n\r\n    R=bmeurer@google.com, yangguo@google.com\r\n\r\n    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118\r\n    Reviewed-on: chromium-review.googlesource.com/1205052\r\n    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>\r\n    Reviewed-by: Yang Guo <yangguo@chromium.org>\r\n    Commit-Queue: Yang Guo <yangguo@chromium.org>\r\n    Cr-Commit-Position: refs/heads/master@{#55632}\r\n\r\nRefs: v8/v8@958b761\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-09-17T20:01:55Z","updated_at":"2018-10-06T12:16:31Z","closed_at":"2018-10-06T12:16:31Z","merged_at":null,"merge_commit_sha":"a34f4a16d77d27f590d965f913cf3de43e38c5d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176191361,"node_id":"MDU6TGFiZWwxNzYxOTEzNjE=","url":"https://api.github.com/repos/nodejs/node/labels/V8%20Engine","name":"V8 Engine","color":"0052cc","default":false},{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":264338741,"node_id":"MDU6TGFiZWwyNjQzMzg3NDE=","url":"https://api.github.com/repos/nodejs/node/labels/post-mortem","name":"post-mortem","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22914/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22914/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22914/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/d12c5eb1ea8d249ea5c8e1d911c6b4a0a96bacc6","head":{"label":"mmarchini:v8-float-c725af6","ref":"v8-float-c725af6","sha":"d12c5eb1ea8d249ea5c8e1d911c6b4a0a96bacc6","user":{"login":"mmarchini","id":4048656,"node_id":"MDQ6VXNlcjQwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4048656?v=4","gravatar_id":"","url":"https://api.github.com/users/mmarchini","html_url":"https://github.com/mmarchini","followers_url":"https://api.github.com/users/mmarchini/followers","following_url":"https://api.github.com/users/mmarchini/following{/other_user}","gists_url":"https://api.github.com/users/mmarchini/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarchini/subscriptions","organizations_url":"https://api.github.com/users/mmarchini/orgs","repos_url":"https://api.github.com/users/mmarchini/repos","events_url":"https://api.github.com/users/mmarchini/events{/privacy}","received_events_url":"https://api.github.com/users/mmarchini/received_events","type":"User","site_admin":false},"repo":{"id":100410007,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0MTAwMDc=","name":"node","full_name":"mmarchini/node","private":false,"owner":{"login":"mmarchini","id":4048656,"node_id":"MDQ6VXNlcjQwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4048656?v=4","gravatar_id":"","url":"https://api.github.com/users/mmarchini","html_url":"https://github.com/mmarchini","followers_url":"https://api.github.com/users/mmarchini/followers","following_url":"https://api.github.com/users/mmarchini/following{/other_user}","gists_url":"https://api.github.com/users/mmarchini/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarchini/subscriptions","organizations_url":"https://api.github.com/users/mmarchini/orgs","repos_url":"https://api.github.com/users/mmarchini/repos","events_url":"https://api.github.com/users/mmarchini/events{/privacy}","received_events_url":"https://api.github.com/users/mmarchini/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmarchini/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/mmarchini/node","forks_url":"https://api.github.com/repos/mmarchini/node/forks","keys_url":"https://api.github.com/repos/mmarchini/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmarchini/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmarchini/node/teams","hooks_url":"https://api.github.com/repos/mmarchini/node/hooks","issue_events_url":"https://api.github.com/repos/mmarchini/node/issues/events{/number}","events_url":"https://api.github.com/repos/mmarchini/node/events","assignees_url":"https://api.github.com/repos/mmarchini/node/assignees{/user}","branches_url":"https://api.github.com/repos/mmarchini/node/branches{/branch}","tags_url":"https://api.github.com/repos/mmarchini/node/tags","blobs_url":"https://api.github.com/repos/mmarchini/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmarchini/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmarchini/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmarchini/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmarchini/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mmarchini/node/languages","stargazers_url":"https://api.github.com/repos/mmarchini/node/stargazers","contributors_url":"https://api.github.com/repos/mmarchini/node/contributors","subscribers_url":"https://api.github.com/repos/mmarchini/node/subscribers","subscription_url":"https://api.github.com/repos/mmarchini/node/subscription","commits_url":"https://api.github.com/repos/mmarchini/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmarchini/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmarchini/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmarchini/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmarchini/node/contents/{+path}","compare_url":"https://api.github.com/repos/mmarchini/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmarchini/node/merges","archive_url":"https://api.github.com/repos/mmarchini/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmarchini/node/downloads","issues_url":"https://api.github.com/repos/mmarchini/node/issues{/number}","pulls_url":"https://api.github.com/repos/mmarchini/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mmarchini/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mmarchini/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmarchini/node/labels{/name}","releases_url":"https://api.github.com/repos/mmarchini/node/releases{/id}","deployments_url":"https://api.github.com/repos/mmarchini/node/deployments","created_at":"2017-08-15T19:10:14Z","updated_at":"2017-08-15T19:10:50Z","pushed_at":"2018-09-26T14:34:36Z","git_url":"git://github.com/mmarchini/node.git","ssh_url":"git@github.com:mmarchini/node.git","clone_url":"https://github.com/mmarchini/node.git","svn_url":"https://github.com/mmarchini/node","homepage":"https://nodejs.org","size":409787,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"50944f34fea03c52e533f1b1e20ebc0de2365a72","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-10-06T12:10:48Z","pushed_at":"2018-10-06T12:16:17Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":421115,"stargazers_count":54061,"watchers_count":54061,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11505,"mirror_url":null,"archived":false,"open_issues_count":904,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11505,"open_issues":904,"watchers":54061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22914"},"html":{"href":"https://github.com/nodejs/node/pull/22914"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22914"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22914/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22914/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22914/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/d12c5eb1ea8d249ea5c8e1d911c6b4a0a96bacc6"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":7,"changed_files":4}}
{"actor":{"display_login":"mmarchini"}}