{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/TonY/pulls/comments/234779939","pull_request_review_id":176495691,"id":234779939,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc3OTkzOQ==","diff_hunk":"@@ -38,13 +39,14 @@ public Result index() {\n     }\n \n     List<JobMetadata> listOfMetadata = new ArrayList<>();\n-    String tonyHistoryFolder = config.getString(\"tony.historyFolder\");\n+    Path tonyHistoryFolder = new Path(config.getString(\"tony.historyFolder\"));","path":"tony-history-server/app/controllers/JobsMetadataPageController.java","position":24,"original_position":22,"commit_id":"36b86c52d01649b3d5d6145ac1750febd053f789","original_commit_id":"491b2c98964c6eb9c2ac7f3b9539d808dbac55ff","user":{"login":"erwa","id":544734,"node_id":"MDQ6VXNlcjU0NDczNA==","avatar_url":"https://avatars1.githubusercontent.com/u/544734?v=4","gravatar_id":"","url":"https://api.github.com/users/erwa","html_url":"https://github.com/erwa","followers_url":"https://api.github.com/users/erwa/followers","following_url":"https://api.github.com/users/erwa/following{/other_user}","gists_url":"https://api.github.com/users/erwa/gists{/gist_id}","starred_url":"https://api.github.com/users/erwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwa/subscriptions","organizations_url":"https://api.github.com/users/erwa/orgs","repos_url":"https://api.github.com/users/erwa/repos","events_url":"https://api.github.com/users/erwa/events{/privacy}","received_events_url":"https://api.github.com/users/erwa/received_events","type":"User","site_admin":false},"body":"A few clarifications:\r\n\r\n> make Tony AM read from tony-site.xml\r\n\r\nTonYClient would read from `tony-site.xml`, apply passed in args, and then write out `tony-final.xml`, which is what the AM uses (no changes in AM).\r\n\r\n> write some intermediate script to extract the location from tony-site.xml and inject it into application.conf\r\n\r\n`startTHS.sh` can do this and set `-Dprop1=val1` Java system properties that will override what's in `application.conf`. For inspiration, take a look at what Dr. Elephant does here: https://github.com/linkedin/dr-elephant/blob/master/scripts/start.sh\r\n\r\n> I don't think that would make the project more maintainable as we're introducing an extra script to maintain, and the location of the job history folder doesn't (and shouldn't) change once we deploy this to prod, so the benefit of having a single source of truth (tony-site.xml) is also very minimal.\r\n\r\nRight now, it's just one variable, but in the future, there might be more variables that we need to be consistent between client and server. We should code using best practices from the beginning to save us technical debt in the future.","created_at":"2018-11-19T21:01:21Z","updated_at":"2018-11-19T21:01:21Z","html_url":"https://github.com/linkedin/TonY/pull/81#discussion_r234779939","pull_request_url":"https://api.github.com/repos/linkedin/TonY/pulls/81","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/comments/234779939"},"html":{"href":"https://github.com/linkedin/TonY/pull/81#discussion_r234779939"},"pull_request":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/81"}},"in_reply_to_id":234392784},"pull_request":{"url":"https://api.github.com/repos/linkedin/TonY/pulls/81","id":230681833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjgxODMz","html_url":"https://github.com/linkedin/TonY/pull/81","diff_url":"https://github.com/linkedin/TonY/pull/81.diff","patch_url":"https://github.com/linkedin/TonY/pull/81.patch","issue_url":"https://api.github.com/repos/linkedin/TonY/issues/81","number":81,"state":"open","locked":false,"title":"New feature: Added support for traversing nested folders","user":{"login":"pdtran3k6","id":13684483,"node_id":"MDQ6VXNlcjEzNjg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/13684483?v=4","gravatar_id":"","url":"https://api.github.com/users/pdtran3k6","html_url":"https://github.com/pdtran3k6","followers_url":"https://api.github.com/users/pdtran3k6/followers","following_url":"https://api.github.com/users/pdtran3k6/following{/other_user}","gists_url":"https://api.github.com/users/pdtran3k6/gists{/gist_id}","starred_url":"https://api.github.com/users/pdtran3k6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdtran3k6/subscriptions","organizations_url":"https://api.github.com/users/pdtran3k6/orgs","repos_url":"https://api.github.com/users/pdtran3k6/repos","events_url":"https://api.github.com/users/pdtran3k6/events{/privacy}","received_events_url":"https://api.github.com/users/pdtran3k6/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-14T01:32:28Z","updated_at":"2018-11-19T21:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae53e665f2791a0b4fb45c87b3a21e462c3bffde","assignee":{"login":"pdtran3k6","id":13684483,"node_id":"MDQ6VXNlcjEzNjg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/13684483?v=4","gravatar_id":"","url":"https://api.github.com/users/pdtran3k6","html_url":"https://github.com/pdtran3k6","followers_url":"https://api.github.com/users/pdtran3k6/followers","following_url":"https://api.github.com/users/pdtran3k6/following{/other_user}","gists_url":"https://api.github.com/users/pdtran3k6/gists{/gist_id}","starred_url":"https://api.github.com/users/pdtran3k6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdtran3k6/subscriptions","organizations_url":"https://api.github.com/users/pdtran3k6/orgs","repos_url":"https://api.github.com/users/pdtran3k6/repos","events_url":"https://api.github.com/users/pdtran3k6/events{/privacy}","received_events_url":"https://api.github.com/users/pdtran3k6/received_events","type":"User","site_admin":false},"assignees":[{"login":"pdtran3k6","id":13684483,"node_id":"MDQ6VXNlcjEzNjg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/13684483?v=4","gravatar_id":"","url":"https://api.github.com/users/pdtran3k6","html_url":"https://github.com/pdtran3k6","followers_url":"https://api.github.com/users/pdtran3k6/followers","following_url":"https://api.github.com/users/pdtran3k6/following{/other_user}","gists_url":"https://api.github.com/users/pdtran3k6/gists{/gist_id}","starred_url":"https://api.github.com/users/pdtran3k6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdtran3k6/subscriptions","organizations_url":"https://api.github.com/users/pdtran3k6/orgs","repos_url":"https://api.github.com/users/pdtran3k6/repos","events_url":"https://api.github.com/users/pdtran3k6/events{/privacy}","received_events_url":"https://api.github.com/users/pdtran3k6/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"oliverhu","id":1659910,"node_id":"MDQ6VXNlcjE2NTk5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1659910?v=4","gravatar_id":"","url":"https://api.github.com/users/oliverhu","html_url":"https://github.com/oliverhu","followers_url":"https://api.github.com/users/oliverhu/followers","following_url":"https://api.github.com/users/oliverhu/following{/other_user}","gists_url":"https://api.github.com/users/oliverhu/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverhu/subscriptions","organizations_url":"https://api.github.com/users/oliverhu/orgs","repos_url":"https://api.github.com/users/oliverhu/repos","events_url":"https://api.github.com/users/oliverhu/events{/privacy}","received_events_url":"https://api.github.com/users/oliverhu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/TonY/pulls/81/commits","review_comments_url":"https://api.github.com/repos/linkedin/TonY/pulls/81/comments","review_comment_url":"https://api.github.com/repos/linkedin/TonY/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/TonY/issues/81/comments","statuses_url":"https://api.github.com/repos/linkedin/TonY/statuses/36b86c52d01649b3d5d6145ac1750febd053f789","head":{"label":"pdtran3k6:phattran_supportNestedJobDir","ref":"phattran_supportNestedJobDir","sha":"36b86c52d01649b3d5d6145ac1750febd053f789","user":{"login":"pdtran3k6","id":13684483,"node_id":"MDQ6VXNlcjEzNjg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/13684483?v=4","gravatar_id":"","url":"https://api.github.com/users/pdtran3k6","html_url":"https://github.com/pdtran3k6","followers_url":"https://api.github.com/users/pdtran3k6/followers","following_url":"https://api.github.com/users/pdtran3k6/following{/other_user}","gists_url":"https://api.github.com/users/pdtran3k6/gists{/gist_id}","starred_url":"https://api.github.com/users/pdtran3k6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdtran3k6/subscriptions","organizations_url":"https://api.github.com/users/pdtran3k6/orgs","repos_url":"https://api.github.com/users/pdtran3k6/repos","events_url":"https://api.github.com/users/pdtran3k6/events{/privacy}","received_events_url":"https://api.github.com/users/pdtran3k6/received_events","type":"User","site_admin":false},"repo":{"id":149202246,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkyMDIyNDY=","name":"TonY","full_name":"pdtran3k6/TonY","private":false,"owner":{"login":"pdtran3k6","id":13684483,"node_id":"MDQ6VXNlcjEzNjg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/13684483?v=4","gravatar_id":"","url":"https://api.github.com/users/pdtran3k6","html_url":"https://github.com/pdtran3k6","followers_url":"https://api.github.com/users/pdtran3k6/followers","following_url":"https://api.github.com/users/pdtran3k6/following{/other_user}","gists_url":"https://api.github.com/users/pdtran3k6/gists{/gist_id}","starred_url":"https://api.github.com/users/pdtran3k6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdtran3k6/subscriptions","organizations_url":"https://api.github.com/users/pdtran3k6/orgs","repos_url":"https://api.github.com/users/pdtran3k6/repos","events_url":"https://api.github.com/users/pdtran3k6/events{/privacy}","received_events_url":"https://api.github.com/users/pdtran3k6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pdtran3k6/TonY","description":"TensorFlow on YARN (TonY) is a framework to natively run TensorFlow on Apache Hadoop.","fork":true,"url":"https://api.github.com/repos/pdtran3k6/TonY","forks_url":"https://api.github.com/repos/pdtran3k6/TonY/forks","keys_url":"https://api.github.com/repos/pdtran3k6/TonY/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdtran3k6/TonY/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdtran3k6/TonY/teams","hooks_url":"https://api.github.com/repos/pdtran3k6/TonY/hooks","issue_events_url":"https://api.github.com/repos/pdtran3k6/TonY/issues/events{/number}","events_url":"https://api.github.com/repos/pdtran3k6/TonY/events","assignees_url":"https://api.github.com/repos/pdtran3k6/TonY/assignees{/user}","branches_url":"https://api.github.com/repos/pdtran3k6/TonY/branches{/branch}","tags_url":"https://api.github.com/repos/pdtran3k6/TonY/tags","blobs_url":"https://api.github.com/repos/pdtran3k6/TonY/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdtran3k6/TonY/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdtran3k6/TonY/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdtran3k6/TonY/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdtran3k6/TonY/statuses/{sha}","languages_url":"https://api.github.com/repos/pdtran3k6/TonY/languages","stargazers_url":"https://api.github.com/repos/pdtran3k6/TonY/stargazers","contributors_url":"https://api.github.com/repos/pdtran3k6/TonY/contributors","subscribers_url":"https://api.github.com/repos/pdtran3k6/TonY/subscribers","subscription_url":"https://api.github.com/repos/pdtran3k6/TonY/subscription","commits_url":"https://api.github.com/repos/pdtran3k6/TonY/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdtran3k6/TonY/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdtran3k6/TonY/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdtran3k6/TonY/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdtran3k6/TonY/contents/{+path}","compare_url":"https://api.github.com/repos/pdtran3k6/TonY/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdtran3k6/TonY/merges","archive_url":"https://api.github.com/repos/pdtran3k6/TonY/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdtran3k6/TonY/downloads","issues_url":"https://api.github.com/repos/pdtran3k6/TonY/issues{/number}","pulls_url":"https://api.github.com/repos/pdtran3k6/TonY/pulls{/number}","milestones_url":"https://api.github.com/repos/pdtran3k6/TonY/milestones{/number}","notifications_url":"https://api.github.com/repos/pdtran3k6/TonY/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdtran3k6/TonY/labels{/name}","releases_url":"https://api.github.com/repos/pdtran3k6/TonY/releases{/id}","deployments_url":"https://api.github.com/repos/pdtran3k6/TonY/deployments","created_at":"2018-09-17T23:46:57Z","updated_at":"2018-11-18T08:47:11Z","pushed_at":"2018-11-19T19:51:15Z","git_url":"git://github.com/pdtran3k6/TonY.git","ssh_url":"git@github.com:pdtran3k6/TonY.git","clone_url":"https://github.com/pdtran3k6/TonY.git","svn_url":"https://github.com/pdtran3k6/TonY","homepage":null,"size":1247,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"8efc3bae9e149eaa26b5c09b05d3cf0873904a2b","user":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":148223447,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMjM0NDc=","name":"TonY","full_name":"linkedin/TonY","private":false,"owner":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkedin/TonY","description":"TonY is a framework to natively run deep learning frameworks on Apache Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/TonY","forks_url":"https://api.github.com/repos/linkedin/TonY/forks","keys_url":"https://api.github.com/repos/linkedin/TonY/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/TonY/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/TonY/teams","hooks_url":"https://api.github.com/repos/linkedin/TonY/hooks","issue_events_url":"https://api.github.com/repos/linkedin/TonY/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/TonY/events","assignees_url":"https://api.github.com/repos/linkedin/TonY/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/TonY/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/TonY/tags","blobs_url":"https://api.github.com/repos/linkedin/TonY/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/TonY/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/TonY/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/TonY/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/TonY/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/TonY/languages","stargazers_url":"https://api.github.com/repos/linkedin/TonY/stargazers","contributors_url":"https://api.github.com/repos/linkedin/TonY/contributors","subscribers_url":"https://api.github.com/repos/linkedin/TonY/subscribers","subscription_url":"https://api.github.com/repos/linkedin/TonY/subscription","commits_url":"https://api.github.com/repos/linkedin/TonY/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/TonY/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/TonY/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/TonY/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/TonY/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/TonY/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/TonY/merges","archive_url":"https://api.github.com/repos/linkedin/TonY/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/TonY/downloads","issues_url":"https://api.github.com/repos/linkedin/TonY/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/TonY/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/TonY/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/TonY/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/TonY/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/TonY/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/TonY/deployments","created_at":"2018-09-10T21:49:17Z","updated_at":"2018-11-19T18:46:38Z","pushed_at":"2018-11-19T19:51:17Z","git_url":"git://github.com/linkedin/TonY.git","ssh_url":"git@github.com:linkedin/TonY.git","clone_url":"https://github.com/linkedin/TonY.git","svn_url":"https://github.com/linkedin/TonY","homepage":"","size":1235,"stargazers_count":345,"watchers_count":345,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":61,"open_issues":18,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/81"},"html":{"href":"https://github.com/linkedin/TonY/pull/81"},"issue":{"href":"https://api.github.com/repos/linkedin/TonY/issues/81"},"comments":{"href":"https://api.github.com/repos/linkedin/TonY/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/TonY/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/TonY/statuses/36b86c52d01649b3d5d6145ac1750febd053f789"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"erwa"}}