{"action":"closed","number":47387,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47387","id":184790386,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NzkwMzg2","html_url":"https://github.com/saltstack/salt/pull/47387","diff_url":"https://github.com/saltstack/salt/pull/47387.diff","patch_url":"https://github.com/saltstack/salt/pull/47387.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47387","number":47387,"state":"closed","locked":false,"title":"Adds a warning to the file.managed state to indicate 'file_mode' is ignored","user":{"login":"jalandis","id":3974911,"node_id":"MDQ6VXNlcjM5NzQ5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3974911?v=4","gravatar_id":"","url":"https://api.github.com/users/jalandis","html_url":"https://github.com/jalandis","followers_url":"https://api.github.com/users/jalandis/followers","following_url":"https://api.github.com/users/jalandis/following{/other_user}","gists_url":"https://api.github.com/users/jalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalandis/subscriptions","organizations_url":"https://api.github.com/users/jalandis/orgs","repos_url":"https://api.github.com/users/jalandis/repos","events_url":"https://api.github.com/users/jalandis/events{/privacy}","received_events_url":"https://api.github.com/users/jalandis/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nDisplays a warning when an ignored **file_mode** argument is found with the file.managed state.  Hopefully this helps developers troubleshoot issues  quicker.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\nThis resolves #47386.\r\n\r\n### Previous Behavior\r\n\r\nThe file.managed salt state ignored setting file permissions when the incorrect argument was used without any user feedback.\r\n\r\n### New Behavior\r\n\r\nThe following warning will be displayed for improperly configured file.managed states.\r\n\r\n```\r\n Warnings: The 'file_mode' argument will be ignored.  Please use 'mode'\r\n              instead to set file permissions.\r\n```\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nYes\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n","created_at":"2018-04-28T15:04:26Z","updated_at":"2018-06-01T13:54:06Z","closed_at":"2018-06-01T13:54:06Z","merged_at":"2018-06-01T13:54:06Z","merge_commit_sha":"e48839fd985cc6278670e0ee97dc816b2e242f08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47387/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47387/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47387/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/ec1e6311edbe5c57487fbf66ed589fcb5da3fcfc","head":{"label":"jalandis:file-managed-warning-on-ignore-file-mode","ref":"file-managed-warning-on-ignore-file-mode","sha":"ec1e6311edbe5c57487fbf66ed589fcb5da3fcfc","user":{"login":"jalandis","id":3974911,"node_id":"MDQ6VXNlcjM5NzQ5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3974911?v=4","gravatar_id":"","url":"https://api.github.com/users/jalandis","html_url":"https://github.com/jalandis","followers_url":"https://api.github.com/users/jalandis/followers","following_url":"https://api.github.com/users/jalandis/following{/other_user}","gists_url":"https://api.github.com/users/jalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalandis/subscriptions","organizations_url":"https://api.github.com/users/jalandis/orgs","repos_url":"https://api.github.com/users/jalandis/repos","events_url":"https://api.github.com/users/jalandis/events{/privacy}","received_events_url":"https://api.github.com/users/jalandis/received_events","type":"User","site_admin":false},"repo":{"id":126668838,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY2Njg4Mzg=","name":"salt","full_name":"jalandis/salt","owner":{"login":"jalandis","id":3974911,"node_id":"MDQ6VXNlcjM5NzQ5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3974911?v=4","gravatar_id":"","url":"https://api.github.com/users/jalandis","html_url":"https://github.com/jalandis","followers_url":"https://api.github.com/users/jalandis/followers","following_url":"https://api.github.com/users/jalandis/following{/other_user}","gists_url":"https://api.github.com/users/jalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalandis/subscriptions","organizations_url":"https://api.github.com/users/jalandis/orgs","repos_url":"https://api.github.com/users/jalandis/repos","events_url":"https://api.github.com/users/jalandis/events{/privacy}","received_events_url":"https://api.github.com/users/jalandis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jalandis/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/jalandis/salt","forks_url":"https://api.github.com/repos/jalandis/salt/forks","keys_url":"https://api.github.com/repos/jalandis/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalandis/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalandis/salt/teams","hooks_url":"https://api.github.com/repos/jalandis/salt/hooks","issue_events_url":"https://api.github.com/repos/jalandis/salt/issues/events{/number}","events_url":"https://api.github.com/repos/jalandis/salt/events","assignees_url":"https://api.github.com/repos/jalandis/salt/assignees{/user}","branches_url":"https://api.github.com/repos/jalandis/salt/branches{/branch}","tags_url":"https://api.github.com/repos/jalandis/salt/tags","blobs_url":"https://api.github.com/repos/jalandis/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalandis/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalandis/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalandis/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalandis/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/jalandis/salt/languages","stargazers_url":"https://api.github.com/repos/jalandis/salt/stargazers","contributors_url":"https://api.github.com/repos/jalandis/salt/contributors","subscribers_url":"https://api.github.com/repos/jalandis/salt/subscribers","subscription_url":"https://api.github.com/repos/jalandis/salt/subscription","commits_url":"https://api.github.com/repos/jalandis/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalandis/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalandis/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalandis/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalandis/salt/contents/{+path}","compare_url":"https://api.github.com/repos/jalandis/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalandis/salt/merges","archive_url":"https://api.github.com/repos/jalandis/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalandis/salt/downloads","issues_url":"https://api.github.com/repos/jalandis/salt/issues{/number}","pulls_url":"https://api.github.com/repos/jalandis/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/jalandis/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/jalandis/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalandis/salt/labels{/name}","releases_url":"https://api.github.com/repos/jalandis/salt/releases{/id}","deployments_url":"https://api.github.com/repos/jalandis/salt/deployments","created_at":"2018-03-25T05:53:00Z","updated_at":"2018-04-28T14:34:41Z","pushed_at":"2018-05-31T18:55:54Z","git_url":"git://github.com/jalandis/salt.git","ssh_url":"git@github.com:jalandis/salt.git","clone_url":"https://github.com/jalandis/salt.git","svn_url":"https://github.com/jalandis/salt","homepage":"https://repo.saltstack.com/","size":403297,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"dc5e2b4705c046d545b780967a8d05bb19411844","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-06-01T13:53:59Z","pushed_at":"2018-06-01T13:54:06Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":403884,"stargazers_count":8894,"watchers_count":8894,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4175,"mirror_url":null,"archived":false,"open_issues_count":3330,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4175,"open_issues":3330,"watchers":8894,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47387"},"html":{"href":"https://github.com/saltstack/salt/pull/47387"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47387"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47387/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47387/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47387/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/ec1e6311edbe5c57487fbf66ed589fcb5da3fcfc"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rallytime","id":6547906,"node_id":"MDQ6VXNlcjY1NDc5MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6547906?v=4","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":6,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"rallytime"}}