{"action":"created","issue":{"url":"https://api.github.com/repos/mlpack/mlpack/issues/1509","repository_url":"https://api.github.com/repos/mlpack/mlpack","labels_url":"https://api.github.com/repos/mlpack/mlpack/issues/1509/labels{/name}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/1509/comments","events_url":"https://api.github.com/repos/mlpack/mlpack/issues/1509/events","html_url":"https://github.com/mlpack/mlpack/pull/1509","id":361097644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTU1NTUy","number":1509,"title":"LMNN optimization: use bounds from previous iterations in tree-based kNN search","user":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-18T01:03:48Z","updated_at":"2018-09-18T20:17:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/1509","html_url":"https://github.com/mlpack/mlpack/pull/1509","diff_url":"https://github.com/mlpack/mlpack/pull/1509.diff","patch_url":"https://github.com/mlpack/mlpack/pull/1509.patch"},"body":"This PR is to solve #1445 and #1446.  It implements the following:\r\n\r\n * Reuse trees from previous calls to `Impostors()`.\r\n * Use bounded values of impostors from previous calls to set bounds for this iteration's call to `Impostors()`.\r\n * Prune points based on impostor bounds from #1448 so they are not recomputed with the tree-based search.\r\n * Allow rebuilding of trees when the transformation is different enough from the one when the trees were built.\r\n\r\nIt took me a long time of playing with this to get it to work reasonably.  I'll add benchmarking times in the next little while.  I don't yet know if rebuilding the trees is helpful, but I think I have seen reasonable speedup (think 20-30% or more) from the tree optimizations overall."},"comment":{"url":"https://api.github.com/repos/mlpack/mlpack/issues/comments/422537049","html_url":"https://github.com/mlpack/mlpack/pull/1509#issuecomment-422537049","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/1509","id":422537049,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjUzNzA0OQ==","user":{"login":"manish7294","id":17105412,"node_id":"MDQ6VXNlcjE3MTA1NDEy","avatar_url":"https://avatars0.githubusercontent.com/u/17105412?v=4","gravatar_id":"","url":"https://api.github.com/users/manish7294","html_url":"https://github.com/manish7294","followers_url":"https://api.github.com/users/manish7294/followers","following_url":"https://api.github.com/users/manish7294/following{/other_user}","gists_url":"https://api.github.com/users/manish7294/gists{/gist_id}","starred_url":"https://api.github.com/users/manish7294/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manish7294/subscriptions","organizations_url":"https://api.github.com/users/manish7294/orgs","repos_url":"https://api.github.com/users/manish7294/repos","events_url":"https://api.github.com/users/manish7294/events{/privacy}","received_events_url":"https://api.github.com/users/manish7294/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T20:17:04Z","updated_at":"2018-09-18T20:17:04Z","author_association":"MEMBER","body":"Hi Ryan, Thanks for working over it, It's good to see all this work. I am extremely sorry for delay from my side, just few more days and my mid-semester exams will be over."}}
{"actor":{"display_login":"manish7294"}}