{"action":"created","issue":{"url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/654","repository_url":"https://api.github.com/repos/EvictionLab/eviction-maps","labels_url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/654/labels{/name}","comments_url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/654/comments","events_url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/654/events","html_url":"https://github.com/EvictionLab/eviction-maps/pull/654","id":298387920,"number":654,"title":"Finish up iframe embed feature","user":{"login":"pjsier","id":8291663,"avatar_url":"https://avatars1.githubusercontent.com/u/8291663?v=4","gravatar_id":"","url":"https://api.github.com/users/pjsier","html_url":"https://github.com/pjsier","followers_url":"https://api.github.com/users/pjsier/followers","following_url":"https://api.github.com/users/pjsier/following{/other_user}","gists_url":"https://api.github.com/users/pjsier/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsier/subscriptions","organizations_url":"https://api.github.com/users/pjsier/orgs","repos_url":"https://api.github.com/users/pjsier/repos","events_url":"https://api.github.com/users/pjsier/events{/privacy}","received_events_url":"https://api.github.com/users/pjsier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-19T20:04:11Z","updated_at":"2018-02-19T22:22:26Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/EvictionLab/eviction-maps/pulls/654","html_url":"https://github.com/EvictionLab/eviction-maps/pull/654","diff_url":"https://github.com/EvictionLab/eviction-maps/pull/654.diff","patch_url":"https://github.com/EvictionLab/eviction-maps/pull/654.patch"},"body":"Closes #509, since the rest of the functionality is in #568 and #651. Getting pym.js set up was a bit of a pain initially since it sets up query parameters that are swallowed by our hash routing, but after swapping those back in it looks like this will be a lot easier than trying to create an iframe with the right set of parameters"},"comment":{"url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/comments/366816521","html_url":"https://github.com/EvictionLab/eviction-maps/pull/654#issuecomment-366816521","issue_url":"https://api.github.com/repos/EvictionLab/eviction-maps/issues/654","id":366816521,"user":{"login":"pjsier","id":8291663,"avatar_url":"https://avatars1.githubusercontent.com/u/8291663?v=4","gravatar_id":"","url":"https://api.github.com/users/pjsier","html_url":"https://github.com/pjsier","followers_url":"https://api.github.com/users/pjsier/followers","following_url":"https://api.github.com/users/pjsier/following{/other_user}","gists_url":"https://api.github.com/users/pjsier/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsier/subscriptions","organizations_url":"https://api.github.com/users/pjsier/orgs","repos_url":"https://api.github.com/users/pjsier/repos","events_url":"https://api.github.com/users/pjsier/events{/privacy}","received_events_url":"https://api.github.com/users/pjsier/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T22:22:26Z","updated_at":"2018-02-19T22:22:26Z","author_association":"OWNER","body":"That was actually going to be my question, moving it out of `app.component.scss` definitely makes sense since I set that up when I was trying to get it to work, but do the styles in `map.component.scss` still work?\r\n\r\nAnd `embedded`/`not-embedded` are both added by pym.js, they're not any of our host-bindings, but `not-embedded` was only there from testing. It's only applied when activate the pym child, but I'll remove it anyway since we don't need it"}}
{"actor":{"display_login":"pjsier"}}