{"action":"created","comment":{"url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/comments/209304300","pull_request_review_id":145297948,"id":209304300,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTMwNDMwMA==","diff_hunk":"@@ -0,0 +1,15 @@\n+package org.ohdsi.webapi.model;","path":"src/main/java/org/ohdsi/webapi/model/ConceptSetExpressionPageRequest.java","position":1,"original_position":1,"commit_id":"7d2718134d7f4a241850b6116757918bc344aa67","original_commit_id":"7d2718134d7f4a241850b6116757918bc344aa67","user":{"login":"chrisknoll","id":6818777,"node_id":"MDQ6VXNlcjY4MTg3Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6818777?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisknoll","html_url":"https://github.com/chrisknoll","followers_url":"https://api.github.com/users/chrisknoll/followers","following_url":"https://api.github.com/users/chrisknoll/following{/other_user}","gists_url":"https://api.github.com/users/chrisknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisknoll/subscriptions","organizations_url":"https://api.github.com/users/chrisknoll/orgs","repos_url":"https://api.github.com/users/chrisknoll/repos","events_url":"https://api.github.com/users/chrisknoll/events{/privacy}","received_events_url":"https://api.github.com/users/chrisknoll/received_events","type":"User","site_admin":false},"body":"Don't use the 'model' namespace. Every class belongs to some feature (in this case, probably 'paging' if we're talking about server side paging.  the 'model'  namespace was introduced 4 years ago, and right now, contains classes related to cohort analysis results, and those shoudl probably be moved over to 'cohortresults' namespace. But if we pile every model we have in WebAPI into the 'model' namespace, it will be a mess.\r\n\r\nSo, please identify either an existing namespace or create a new namespace for these classes (you could call it 'paging') and I will open a separate issue to refactor the classes 'model' namespace over to their appropraite namespaces.\r\n","created_at":"2018-08-10T15:48:38Z","updated_at":"2018-08-10T15:48:38Z","html_url":"https://github.com/OHDSI/WebAPI/pull/521#discussion_r209304300","pull_request_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/comments/209304300"},"html":{"href":"https://github.com/OHDSI/WebAPI/pull/521#discussion_r209304300"},"pull_request":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521"}}},"pull_request":{"url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521","id":203565846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTY1ODQ2","html_url":"https://github.com/OHDSI/WebAPI/pull/521","diff_url":"https://github.com/OHDSI/WebAPI/pull/521.diff","patch_url":"https://github.com/OHDSI/WebAPI/pull/521.patch","issue_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/521","number":521,"state":"open","locked":false,"title":"Added lazy loading and pagination of Included concepts in Concept Set","user":{"login":"wivern","id":1109753,"node_id":"MDQ6VXNlcjExMDk3NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1109753?v=4","gravatar_id":"","url":"https://api.github.com/users/wivern","html_url":"https://github.com/wivern","followers_url":"https://api.github.com/users/wivern/followers","following_url":"https://api.github.com/users/wivern/following{/other_user}","gists_url":"https://api.github.com/users/wivern/gists{/gist_id}","starred_url":"https://api.github.com/users/wivern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wivern/subscriptions","organizations_url":"https://api.github.com/users/wivern/orgs","repos_url":"https://api.github.com/users/wivern/repos","events_url":"https://api.github.com/users/wivern/events{/privacy}","received_events_url":"https://api.github.com/users/wivern/received_events","type":"User","site_admin":false},"body":"closes #497 ","created_at":"2018-07-24T15:24:23Z","updated_at":"2018-08-10T15:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1ff027d1b67cab51871d65796748424b4c197da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521/commits","review_comments_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521/comments","review_comment_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/521/comments","statuses_url":"https://api.github.com/repos/OHDSI/WebAPI/statuses/7d2718134d7f4a241850b6116757918bc344aa67","head":{"label":"OHDSI:conceptset_lazy_loading","ref":"conceptset_lazy_loading","sha":"7d2718134d7f4a241850b6116757918bc344aa67","user":{"login":"OHDSI","id":6570077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAwNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6570077?v=4","gravatar_id":"","url":"https://api.github.com/users/OHDSI","html_url":"https://github.com/OHDSI","followers_url":"https://api.github.com/users/OHDSI/followers","following_url":"https://api.github.com/users/OHDSI/following{/other_user}","gists_url":"https://api.github.com/users/OHDSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OHDSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHDSI/subscriptions","organizations_url":"https://api.github.com/users/OHDSI/orgs","repos_url":"https://api.github.com/users/OHDSI/repos","events_url":"https://api.github.com/users/OHDSI/events{/privacy}","received_events_url":"https://api.github.com/users/OHDSI/received_events","type":"Organization","site_admin":false},"repo":{"id":27504653,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUwNDY1Mw==","name":"WebAPI","full_name":"OHDSI/WebAPI","owner":{"login":"OHDSI","id":6570077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAwNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6570077?v=4","gravatar_id":"","url":"https://api.github.com/users/OHDSI","html_url":"https://github.com/OHDSI","followers_url":"https://api.github.com/users/OHDSI/followers","following_url":"https://api.github.com/users/OHDSI/following{/other_user}","gists_url":"https://api.github.com/users/OHDSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OHDSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHDSI/subscriptions","organizations_url":"https://api.github.com/users/OHDSI/orgs","repos_url":"https://api.github.com/users/OHDSI/repos","events_url":"https://api.github.com/users/OHDSI/events{/privacy}","received_events_url":"https://api.github.com/users/OHDSI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OHDSI/WebAPI","description":"[Under development] OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications","fork":false,"url":"https://api.github.com/repos/OHDSI/WebAPI","forks_url":"https://api.github.com/repos/OHDSI/WebAPI/forks","keys_url":"https://api.github.com/repos/OHDSI/WebAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OHDSI/WebAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OHDSI/WebAPI/teams","hooks_url":"https://api.github.com/repos/OHDSI/WebAPI/hooks","issue_events_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/events{/number}","events_url":"https://api.github.com/repos/OHDSI/WebAPI/events","assignees_url":"https://api.github.com/repos/OHDSI/WebAPI/assignees{/user}","branches_url":"https://api.github.com/repos/OHDSI/WebAPI/branches{/branch}","tags_url":"https://api.github.com/repos/OHDSI/WebAPI/tags","blobs_url":"https://api.github.com/repos/OHDSI/WebAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OHDSI/WebAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OHDSI/WebAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/OHDSI/WebAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OHDSI/WebAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/OHDSI/WebAPI/languages","stargazers_url":"https://api.github.com/repos/OHDSI/WebAPI/stargazers","contributors_url":"https://api.github.com/repos/OHDSI/WebAPI/contributors","subscribers_url":"https://api.github.com/repos/OHDSI/WebAPI/subscribers","subscription_url":"https://api.github.com/repos/OHDSI/WebAPI/subscription","commits_url":"https://api.github.com/repos/OHDSI/WebAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/OHDSI/WebAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/OHDSI/WebAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/OHDSI/WebAPI/contents/{+path}","compare_url":"https://api.github.com/repos/OHDSI/WebAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OHDSI/WebAPI/merges","archive_url":"https://api.github.com/repos/OHDSI/WebAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OHDSI/WebAPI/downloads","issues_url":"https://api.github.com/repos/OHDSI/WebAPI/issues{/number}","pulls_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/OHDSI/WebAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/OHDSI/WebAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OHDSI/WebAPI/labels{/name}","releases_url":"https://api.github.com/repos/OHDSI/WebAPI/releases{/id}","deployments_url":"https://api.github.com/repos/OHDSI/WebAPI/deployments","created_at":"2014-12-03T19:49:51Z","updated_at":"2018-08-09T21:52:32Z","pushed_at":"2018-08-10T11:31:03Z","git_url":"git://github.com/OHDSI/WebAPI.git","ssh_url":"git@github.com:OHDSI/WebAPI.git","clone_url":"https://github.com/OHDSI/WebAPI.git","svn_url":"https://github.com/OHDSI/WebAPI","homepage":"","size":3885,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":115,"watchers":38,"default_branch":"master"}},"base":{"label":"OHDSI:master","ref":"master","sha":"4adf4c106972e762df050a8cc7da1b707193809a","user":{"login":"OHDSI","id":6570077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAwNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6570077?v=4","gravatar_id":"","url":"https://api.github.com/users/OHDSI","html_url":"https://github.com/OHDSI","followers_url":"https://api.github.com/users/OHDSI/followers","following_url":"https://api.github.com/users/OHDSI/following{/other_user}","gists_url":"https://api.github.com/users/OHDSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OHDSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHDSI/subscriptions","organizations_url":"https://api.github.com/users/OHDSI/orgs","repos_url":"https://api.github.com/users/OHDSI/repos","events_url":"https://api.github.com/users/OHDSI/events{/privacy}","received_events_url":"https://api.github.com/users/OHDSI/received_events","type":"Organization","site_admin":false},"repo":{"id":27504653,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUwNDY1Mw==","name":"WebAPI","full_name":"OHDSI/WebAPI","owner":{"login":"OHDSI","id":6570077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAwNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6570077?v=4","gravatar_id":"","url":"https://api.github.com/users/OHDSI","html_url":"https://github.com/OHDSI","followers_url":"https://api.github.com/users/OHDSI/followers","following_url":"https://api.github.com/users/OHDSI/following{/other_user}","gists_url":"https://api.github.com/users/OHDSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OHDSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OHDSI/subscriptions","organizations_url":"https://api.github.com/users/OHDSI/orgs","repos_url":"https://api.github.com/users/OHDSI/repos","events_url":"https://api.github.com/users/OHDSI/events{/privacy}","received_events_url":"https://api.github.com/users/OHDSI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OHDSI/WebAPI","description":"[Under development] OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications","fork":false,"url":"https://api.github.com/repos/OHDSI/WebAPI","forks_url":"https://api.github.com/repos/OHDSI/WebAPI/forks","keys_url":"https://api.github.com/repos/OHDSI/WebAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OHDSI/WebAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OHDSI/WebAPI/teams","hooks_url":"https://api.github.com/repos/OHDSI/WebAPI/hooks","issue_events_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/events{/number}","events_url":"https://api.github.com/repos/OHDSI/WebAPI/events","assignees_url":"https://api.github.com/repos/OHDSI/WebAPI/assignees{/user}","branches_url":"https://api.github.com/repos/OHDSI/WebAPI/branches{/branch}","tags_url":"https://api.github.com/repos/OHDSI/WebAPI/tags","blobs_url":"https://api.github.com/repos/OHDSI/WebAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OHDSI/WebAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OHDSI/WebAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/OHDSI/WebAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OHDSI/WebAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/OHDSI/WebAPI/languages","stargazers_url":"https://api.github.com/repos/OHDSI/WebAPI/stargazers","contributors_url":"https://api.github.com/repos/OHDSI/WebAPI/contributors","subscribers_url":"https://api.github.com/repos/OHDSI/WebAPI/subscribers","subscription_url":"https://api.github.com/repos/OHDSI/WebAPI/subscription","commits_url":"https://api.github.com/repos/OHDSI/WebAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/OHDSI/WebAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/OHDSI/WebAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/OHDSI/WebAPI/contents/{+path}","compare_url":"https://api.github.com/repos/OHDSI/WebAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OHDSI/WebAPI/merges","archive_url":"https://api.github.com/repos/OHDSI/WebAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OHDSI/WebAPI/downloads","issues_url":"https://api.github.com/repos/OHDSI/WebAPI/issues{/number}","pulls_url":"https://api.github.com/repos/OHDSI/WebAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/OHDSI/WebAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/OHDSI/WebAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OHDSI/WebAPI/labels{/name}","releases_url":"https://api.github.com/repos/OHDSI/WebAPI/releases{/id}","deployments_url":"https://api.github.com/repos/OHDSI/WebAPI/deployments","created_at":"2014-12-03T19:49:51Z","updated_at":"2018-08-09T21:52:32Z","pushed_at":"2018-08-10T11:31:03Z","git_url":"git://github.com/OHDSI/WebAPI.git","ssh_url":"git@github.com:OHDSI/WebAPI.git","clone_url":"https://github.com/OHDSI/WebAPI.git","svn_url":"https://github.com/OHDSI/WebAPI","homepage":"","size":3885,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":115,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521"},"html":{"href":"https://github.com/OHDSI/WebAPI/pull/521"},"issue":{"href":"https://api.github.com/repos/OHDSI/WebAPI/issues/521"},"comments":{"href":"https://api.github.com/repos/OHDSI/WebAPI/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OHDSI/WebAPI/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/OHDSI/WebAPI/statuses/7d2718134d7f4a241850b6116757918bc344aa67"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chrisknoll"}}