{"action":"created","issue":{"url":"https://api.github.com/repos/apache/tinkerpop/issues/932","repository_url":"https://api.github.com/repos/apache/tinkerpop","labels_url":"https://api.github.com/repos/apache/tinkerpop/issues/932/labels{/name}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/932/comments","events_url":"https://api.github.com/repos/apache/tinkerpop/issues/932/events","html_url":"https://github.com/apache/tinkerpop/pull/932","id":359946161,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzIxOTEw","number":932,"title":"TINKERPOP-2033 Maintain order in profile() annotations","user":{"login":"spmallette","id":384249,"node_id":"MDQ6VXNlcjM4NDI0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/384249?v=4","gravatar_id":"","url":"https://api.github.com/users/spmallette","html_url":"https://github.com/spmallette","followers_url":"https://api.github.com/users/spmallette/followers","following_url":"https://api.github.com/users/spmallette/following{/other_user}","gists_url":"https://api.github.com/users/spmallette/gists{/gist_id}","starred_url":"https://api.github.com/users/spmallette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spmallette/subscriptions","organizations_url":"https://api.github.com/users/spmallette/orgs","repos_url":"https://api.github.com/users/spmallette/repos","events_url":"https://api.github.com/users/spmallette/events{/privacy}","received_events_url":"https://api.github.com/users/spmallette/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-13T15:24:12Z","updated_at":"2018-09-14T07:05:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/932","html_url":"https://github.com/apache/tinkerpop/pull/932","diff_url":"https://github.com/apache/tinkerpop/pull/932.diff","patch_url":"https://github.com/apache/tinkerpop/pull/932.patch"},"body":"https://issues.apache.org/jira/browse/TINKERPOP-2033\r\n\r\nUsed a synchronized map around a `LinkedHashMap` rather than `ConcurrentHashMap`. Not expecting a performance issue with this as its for `profile()` step which doesn't have to be \"fast\" necessarily as it is a debugging step. \r\n\r\nTested manually for backward compatibility across a number of different versions. That was quite time consuming because I'd not realized that the we'd introduced a perhaps unintended break between 3.3.0 and 3.2.x when it comes to \"metrics\" serialization in Gryo 1.0. Ultimately, I should have just accepted the output i was seeing in the IO tests as being correct in terms of what the compatibility was.\r\n\r\nNote that while the Gryo 1.0 test file changed for 3.4.0 it still remains compatible with previous versions - there is just a different representation of a {{Map}} in the binary. All of this seems somehow a  non-issue because Gryo 3.0 has been the default since 3.3.0 released.\r\n\r\nVOTE +1"},"comment":{"url":"https://api.github.com/repos/apache/tinkerpop/issues/comments/421252290","html_url":"https://github.com/apache/tinkerpop/pull/932#issuecomment-421252290","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/932","id":421252290,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTI1MjI5MA==","user":{"login":"nastra","id":271029,"node_id":"MDQ6VXNlcjI3MTAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/271029?v=4","gravatar_id":"","url":"https://api.github.com/users/nastra","html_url":"https://github.com/nastra","followers_url":"https://api.github.com/users/nastra/followers","following_url":"https://api.github.com/users/nastra/following{/other_user}","gists_url":"https://api.github.com/users/nastra/gists{/gist_id}","starred_url":"https://api.github.com/users/nastra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastra/subscriptions","organizations_url":"https://api.github.com/users/nastra/orgs","repos_url":"https://api.github.com/users/nastra/repos","events_url":"https://api.github.com/users/nastra/events{/privacy}","received_events_url":"https://api.github.com/users/nastra/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T07:05:11Z","updated_at":"2018-09-14T07:05:11Z","author_association":"NONE","body":"+1"}}
{"actor":{"display_login":"nastra"}}