{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/227194872","pull_request_review_id":167178220,"id":227194872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE5NDg3Mg==","diff_hunk":"@@ -55,13 +57,16 @@ def stop_mochad(event):\n \n     def start_mochad(event):\n         \"\"\"Start the Mochad service.\"\"\"\n-        hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP, stop_mochad)\n-    hass.bus.listen_once(EVENT_HOMEASSISTANT_START, start_mochad)\n+        hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, stop_mochad)\n+    hass.bus.async_listen_once(EVENT_HOMEASSISTANT_START, start_mochad)\n+\n+    \"\"\"Start listening thread for Mochad data.\"\"\"\n+    CONTROLLER.start()\n \n-    return True\n+    return True ","path":"homeassistant/components/mochad.py","position":33,"original_position":33,"commit_id":"2b30e91fb28e4a683549e265bdf540494d758111","original_commit_id":"2b30e91fb28e4a683549e265bdf540494d758111","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"trailing whitespace","created_at":"2018-10-23T01:45:24Z","updated_at":"2018-10-23T01:45:24Z","html_url":"https://github.com/home-assistant/home-assistant/pull/17709#discussion_r227194872","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/227194872"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/17709#discussion_r227194872"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709","id":224866964,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODY2OTY0","html_url":"https://github.com/home-assistant/home-assistant/pull/17709","diff_url":"https://github.com/home-assistant/home-assistant/pull/17709.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/17709.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17709","number":17709,"state":"open","locked":false,"title":"Mochad changed to asynchronous. Added reading loop for healthy buffers.","user":{"login":"aosadchyy","id":21959540,"node_id":"MDQ6VXNlcjIxOTU5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/21959540?v=4","gravatar_id":"","url":"https://api.github.com/users/aosadchyy","html_url":"https://github.com/aosadchyy","followers_url":"https://api.github.com/users/aosadchyy/followers","following_url":"https://api.github.com/users/aosadchyy/following{/other_user}","gists_url":"https://api.github.com/users/aosadchyy/gists{/gist_id}","starred_url":"https://api.github.com/users/aosadchyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aosadchyy/subscriptions","organizations_url":"https://api.github.com/users/aosadchyy/orgs","repos_url":"https://api.github.com/users/aosadchyy/repos","events_url":"https://api.github.com/users/aosadchyy/events{/privacy}","received_events_url":"https://api.github.com/users/aosadchyy/received_events","type":"User","site_admin":false},"body":"## Description:\r\nmochad component in homeassistant was synchronous. To improve responsiveness it is changed to asynchronous. It also allowed the addition of the reading loop. The component uses pymochad which wraps mochad service. Both have read_data() methods to read the data that is received. Without it, on the networks with X10 sensors in addition to X10 switches, receiving buffer of mochad service gets filled up and starts erroring (eventually cause stability issues). This commit resolves the issue and improves stability. There is a reading loop added that empties the buffer continuously. \r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** home-assistant/home-assistant.io#<home-assistant.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [X] The code change is tested and works locally.\r\n  - [X] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-10-23T01:45:18Z","updated_at":"2018-10-23T01:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88d048f524efb80e0928fb66160e29b2cfe5850e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":773429863,"node_id":"MDU6TGFiZWw3NzM0Mjk4NjM=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20mochad","name":"component: mochad","color":"ededed","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17709/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/2b30e91fb28e4a683549e265bdf540494d758111","head":{"label":"aosadchyy:dev","ref":"dev","sha":"2b30e91fb28e4a683549e265bdf540494d758111","user":{"login":"aosadchyy","id":21959540,"node_id":"MDQ6VXNlcjIxOTU5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/21959540?v=4","gravatar_id":"","url":"https://api.github.com/users/aosadchyy","html_url":"https://github.com/aosadchyy","followers_url":"https://api.github.com/users/aosadchyy/followers","following_url":"https://api.github.com/users/aosadchyy/following{/other_user}","gists_url":"https://api.github.com/users/aosadchyy/gists{/gist_id}","starred_url":"https://api.github.com/users/aosadchyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aosadchyy/subscriptions","organizations_url":"https://api.github.com/users/aosadchyy/orgs","repos_url":"https://api.github.com/users/aosadchyy/repos","events_url":"https://api.github.com/users/aosadchyy/events{/privacy}","received_events_url":"https://api.github.com/users/aosadchyy/received_events","type":"User","site_admin":false},"repo":{"id":154086042,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwODYwNDI=","name":"home-assistant","full_name":"aosadchyy/home-assistant","private":false,"owner":{"login":"aosadchyy","id":21959540,"node_id":"MDQ6VXNlcjIxOTU5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/21959540?v=4","gravatar_id":"","url":"https://api.github.com/users/aosadchyy","html_url":"https://github.com/aosadchyy","followers_url":"https://api.github.com/users/aosadchyy/followers","following_url":"https://api.github.com/users/aosadchyy/following{/other_user}","gists_url":"https://api.github.com/users/aosadchyy/gists{/gist_id}","starred_url":"https://api.github.com/users/aosadchyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aosadchyy/subscriptions","organizations_url":"https://api.github.com/users/aosadchyy/orgs","repos_url":"https://api.github.com/users/aosadchyy/repos","events_url":"https://api.github.com/users/aosadchyy/events{/privacy}","received_events_url":"https://api.github.com/users/aosadchyy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aosadchyy/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":true,"url":"https://api.github.com/repos/aosadchyy/home-assistant","forks_url":"https://api.github.com/repos/aosadchyy/home-assistant/forks","keys_url":"https://api.github.com/repos/aosadchyy/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aosadchyy/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aosadchyy/home-assistant/teams","hooks_url":"https://api.github.com/repos/aosadchyy/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/aosadchyy/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/aosadchyy/home-assistant/events","assignees_url":"https://api.github.com/repos/aosadchyy/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/aosadchyy/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/aosadchyy/home-assistant/tags","blobs_url":"https://api.github.com/repos/aosadchyy/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aosadchyy/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aosadchyy/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/aosadchyy/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aosadchyy/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/aosadchyy/home-assistant/languages","stargazers_url":"https://api.github.com/repos/aosadchyy/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/aosadchyy/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/aosadchyy/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/aosadchyy/home-assistant/subscription","commits_url":"https://api.github.com/repos/aosadchyy/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/aosadchyy/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/aosadchyy/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/aosadchyy/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/aosadchyy/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/aosadchyy/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aosadchyy/home-assistant/merges","archive_url":"https://api.github.com/repos/aosadchyy/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aosadchyy/home-assistant/downloads","issues_url":"https://api.github.com/repos/aosadchyy/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/aosadchyy/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/aosadchyy/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/aosadchyy/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aosadchyy/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/aosadchyy/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/aosadchyy/home-assistant/deployments","created_at":"2018-10-22T04:12:06Z","updated_at":"2018-10-23T01:35:38Z","pushed_at":"2018-10-23T01:35:36Z","git_url":"git://github.com/aosadchyy/home-assistant.git","ssh_url":"git@github.com:aosadchyy/home-assistant.git","clone_url":"https://github.com/aosadchyy/home-assistant.git","svn_url":"https://github.com/aosadchyy/home-assistant","homepage":"https://www.home-assistant.io","size":91249,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"b773a9049c7937327da174ee822318d69bbe4547","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-10-23T00:46:29Z","pushed_at":"2018-10-23T01:45:19Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":91273,"stargazers_count":17772,"watchers_count":17772,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5191,"mirror_url":null,"archived":false,"open_issues_count":1027,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5191,"open_issues":1027,"watchers":17772,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/17709"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/17709"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/17709/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17709/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/2b30e91fb28e4a683549e265bdf540494d758111"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}