{"action":"created","issue":{"url":"https://api.github.com/repos/botman/driver-facebook/issues/84","repository_url":"https://api.github.com/repos/botman/driver-facebook","labels_url":"https://api.github.com/repos/botman/driver-facebook/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/botman/driver-facebook/issues/84/comments","events_url":"https://api.github.com/repos/botman/driver-facebook/issues/84/events","html_url":"https://github.com/botman/driver-facebook/pull/84","id":366932292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDg3OTMx","number":84,"title":"Add I/O type hinting, remove duplicate code, improve Docblock, add some optimizations","user":{"login":"ker0x","id":5331654,"node_id":"MDQ6VXNlcjUzMzE2NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5331654?v=4","gravatar_id":"","url":"https://api.github.com/users/ker0x","html_url":"https://github.com/ker0x","followers_url":"https://api.github.com/users/ker0x/followers","following_url":"https://api.github.com/users/ker0x/following{/other_user}","gists_url":"https://api.github.com/users/ker0x/gists{/gist_id}","starred_url":"https://api.github.com/users/ker0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ker0x/subscriptions","organizations_url":"https://api.github.com/users/ker0x/orgs","repos_url":"https://api.github.com/users/ker0x/repos","events_url":"https://api.github.com/users/ker0x/events{/privacy}","received_events_url":"https://api.github.com/users/ker0x/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-04T19:17:08Z","updated_at":"2018-10-04T19:19:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/botman/driver-facebook/pulls/84","html_url":"https://github.com/botman/driver-facebook/pull/84","diff_url":"https://github.com/botman/driver-facebook/pull/84.diff","patch_url":"https://github.com/botman/driver-facebook/pull/84.patch"},"body":"This PR do:\r\n\r\n- add input/output type hinting for methods (as the minimum PHP version is set to 7.0 in composer.json)\r\n- remove some duplicate code already present in parent or abstract class\r\n- improve Docblock\r\n- add small optimizations\r\n\r\n**Warning**\r\n\r\nIf this PR is merged, the next release should be tag `2.0` as it bring I/O type hinting. By doing so, this will avoid BC break for people using version `< 2.0`"},"comment":{"url":"https://api.github.com/repos/botman/driver-facebook/issues/comments/427138397","html_url":"https://github.com/botman/driver-facebook/pull/84#issuecomment-427138397","issue_url":"https://api.github.com/repos/botman/driver-facebook/issues/84","id":427138397,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzEzODM5Nw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-04T19:19:15Z","updated_at":"2018-10-04T19:19:15Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=h1) Report\n> Merging [#84](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=desc) into [master](https://codecov.io/gh/botman/driver-facebook/commit/627d1b81f2822748b958b8cda7ec61f8211ba6d3?src=pr&el=desc) will **decrease** coverage by `0.61%`.\n> The diff coverage is `73.97%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/botman/driver-facebook/pull/84/graphs/tree.svg?width=650&token=lfgeTXlAtP&height=150&src=pr)](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master      #84      +/-   ##\n============================================\n- Coverage     71.17%   70.55%   -0.62%     \n+ Complexity      477      429      -48     \n============================================\n  Files            49       49              \n  Lines          1332     1304      -28     \n============================================\n- Hits            948      920      -28     \n  Misses          384      384\n```\n\n\n| [Impacted Files](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [src/Events/FacebookEvent.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0V2ZW50cy9GYWNlYm9va0V2ZW50LnBocA==) | `60% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |\n| [src/Commands/Nlp.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRzL05scC5waHA=) | `0% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |\n| [src/Commands/AddPersistentMenu.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRzL0FkZFBlcnNpc3RlbnRNZW51LnBocA==) | `0% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |\n| [src/Commands/WhitelistDomains.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRzL1doaXRlbGlzdERvbWFpbnMucGhw) | `0% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |\n| [src/Commands/AddGreetingText.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRzL0FkZEdyZWV0aW5nVGV4dC5waHA=) | `0% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |\n| [src/Events/MessagingPostbacks.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0V2ZW50cy9NZXNzYWdpbmdQb3N0YmFja3MucGhw) | `0% <0%> (ø)` | `1 <1> (ø)` | :arrow_down: |\n| [src/Providers/FacebookServiceProvider.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL1Byb3ZpZGVycy9GYWNlYm9va1NlcnZpY2VQcm92aWRlci5waHA=) | `0% <0%> (ø)` | `5 <1> (ø)` | :arrow_down: |\n| [src/Commands/AddStartButtonPayload.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRzL0FkZFN0YXJ0QnV0dG9uUGF5bG9hZC5waHA=) | `0% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |\n| [src/Events/MessagingDeliveries.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0V2ZW50cy9NZXNzYWdpbmdEZWxpdmVyaWVzLnBocA==) | `100% <100%> (ø)` | `1 <1> (ø)` | :arrow_down: |\n| [src/Events/MessagingOptins.php](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree#diff-c3JjL0V2ZW50cy9NZXNzYWdpbmdPcHRpbnMucGhw) | `100% <100%> (ø)` | `1 <1> (ø)` | :arrow_down: |\n| ... and [24 more](https://codecov.io/gh/botman/driver-facebook/pull/84/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=footer). Last update [627d1b8...6dba57a](https://codecov.io/gh/botman/driver-facebook/pull/84?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}