{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/211766884","pull_request_review_id":148259453,"id":211766884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc2Njg4NA==","diff_hunk":"@@ -25,6 +25,13 @@\n   <Import Project=\"$(ToolsDir)tests.targets\" Condition=\"Exists('$(ToolsDir)tests.targets')\" />\n   <Import Project=\"$(ToolsDir)VersionTools.targets\" Condition=\"Exists('$(ToolsDir)VersionTools.targets')\" />\n \n+  <Target Name=\"BinPlaceXUnitRuntimeForNetstandardSuite\" Condition=\"'$(TargetGroup)' == 'netstandard'\" BeforeTargets=\"BuildAllProjects\">","path":"src/tests.builds","position":4,"original_position":4,"commit_id":"fb838096955642666155622bcc457274aa810445","original_commit_id":"828984f02d365b20a00b22df1208b2f1b0cf99b3","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Even though we are adding a reference to all, we are only really adding a reference to Xunit.NETCore.Extensions, xunit.core, and xunit.assert. Those are the only 3 we use to actually compile test assemblies. The purpose of this PR isn't to produce a runtime in order to run the actual tests using the netstandard configurations, but instead to simply build the netsatndard test suite containing only our test libraries built against netstandard so that we can share that with other frameworks that want to verify that they pass our functionality requirements.","created_at":"2018-08-21T21:31:09Z","updated_at":"2018-08-21T21:31:09Z","html_url":"https://github.com/dotnet/corefx/pull/31850#discussion_r211766884","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/31850","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/211766884"},"html":{"href":"https://github.com/dotnet/corefx/pull/31850#discussion_r211766884"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31850"}},"in_reply_to_id":211407196},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31850","id":209643127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjQzMTI3","html_url":"https://github.com/dotnet/corefx/pull/31850","diff_url":"https://github.com/dotnet/corefx/pull/31850.diff","patch_url":"https://github.com/dotnet/corefx/pull/31850.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31850","number":31850,"state":"open","locked":false,"title":"Adding the ability to build a NETStandard test suite","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Fixing no. 1 item of issue #30729\r\n\r\nWith the changes on this PR we will now be able to produce a Netstandard Test suite that we can share to other frameworks that support NETStandard so that they are consistent with the expected behavior.\r\n\r\ncc: @weshaggard @danmosemsft @ericstj \r\n\r\nI'll add one more commit to this PR to add a CI that will build the netstandard test suite so that we ensure that netstandard test configurations won't get broken.","created_at":"2018-08-20T21:04:01Z","updated_at":"2018-08-21T21:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d19113f77e4568492aa5a0ce031ac3888f6a9b93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ericstj","id":8918108,"node_id":"MDQ6VXNlcjg5MTgxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8918108?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/31850/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/31850/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31850/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/fb838096955642666155622bcc457274aa810445","head":{"label":"joperezr:NetstandardTestSuite","ref":"NetstandardTestSuite","sha":"fb838096955642666155622bcc457274aa810445","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"repo":{"id":41888057,"node_id":"MDEwOlJlcG9zaXRvcnk0MTg4ODA1Nw==","name":"corefx","full_name":"joperezr/corefx","owner":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joperezr/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/joperezr/corefx","forks_url":"https://api.github.com/repos/joperezr/corefx/forks","keys_url":"https://api.github.com/repos/joperezr/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joperezr/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joperezr/corefx/teams","hooks_url":"https://api.github.com/repos/joperezr/corefx/hooks","issue_events_url":"https://api.github.com/repos/joperezr/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/joperezr/corefx/events","assignees_url":"https://api.github.com/repos/joperezr/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/joperezr/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/joperezr/corefx/tags","blobs_url":"https://api.github.com/repos/joperezr/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joperezr/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joperezr/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/joperezr/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joperezr/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/joperezr/corefx/languages","stargazers_url":"https://api.github.com/repos/joperezr/corefx/stargazers","contributors_url":"https://api.github.com/repos/joperezr/corefx/contributors","subscribers_url":"https://api.github.com/repos/joperezr/corefx/subscribers","subscription_url":"https://api.github.com/repos/joperezr/corefx/subscription","commits_url":"https://api.github.com/repos/joperezr/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/joperezr/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/joperezr/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/joperezr/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/joperezr/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/joperezr/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joperezr/corefx/merges","archive_url":"https://api.github.com/repos/joperezr/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joperezr/corefx/downloads","issues_url":"https://api.github.com/repos/joperezr/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/joperezr/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/joperezr/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/joperezr/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joperezr/corefx/labels{/name}","releases_url":"https://api.github.com/repos/joperezr/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/joperezr/corefx/deployments","created_at":"2015-09-03T23:06:38Z","updated_at":"2018-08-16T18:19:13Z","pushed_at":"2018-08-20T22:12:49Z","git_url":"git://github.com/joperezr/corefx.git","ssh_url":"git@github.com:joperezr/corefx.git","clone_url":"https://github.com/joperezr/corefx.git","svn_url":"https://github.com/joperezr/corefx","homepage":"http://dotnet.github.io/core/","size":182805,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5f2e78f0bd7d2bee1b6e332edc176e87283bdaed","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-08-21T19:00:58Z","pushed_at":"2018-08-21T21:30:24Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":185875,"stargazers_count":14641,"watchers_count":14641,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4255,"mirror_url":null,"archived":false,"open_issues_count":2537,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4255,"open_issues":2537,"watchers":14641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31850"},"html":{"href":"https://github.com/dotnet/corefx/pull/31850"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31850"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31850/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31850/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31850/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/fb838096955642666155622bcc457274aa810445"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joperezr"}}