{"action":"created","comment":{"url":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments/189174208","pull_request_review_id":121302482,"id":189174208,"diff_hunk":"@@ -381,7 +381,7 @@ public void deleteRepeatGroupWithCalculationsTimingTest() throws Exception {\n         }\n \n         // Then\n-        LocalTime duration = LocalTime.ofNanoOfDay(System.nanoTime() - start);\n+        LocalTime duration = LocalTime.fromMillisOfDay(System.nanoTime() - start);","path":"test/org/javarosa/core/model/Safe2014DagImplTest.java","position":null,"original_position":19,"commit_id":"1dd6dd586f68488036148878202c90c52429eb49","original_commit_id":"0aca0e77bdb6970a719c41822d55241cbb708101","user":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars0.githubusercontent.com/u/205913?v=4","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"body":"Fixed!","created_at":"2018-05-18T06:33:51Z","updated_at":"2018-05-18T06:33:51Z","html_url":"https://github.com/opendatakit/javarosa/pull/316#discussion_r189174208","pull_request_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/316","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments/189174208"},"html":{"href":"https://github.com/opendatakit/javarosa/pull/316#discussion_r189174208"},"pull_request":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/316"}},"in_reply_to_id":189024082},"pull_request":{"url":"https://api.github.com/repos/opendatakit/javarosa/pulls/316","id":188795034,"html_url":"https://github.com/opendatakit/javarosa/pull/316","diff_url":"https://github.com/opendatakit/javarosa/pull/316.diff","patch_url":"https://github.com/opendatakit/javarosa/pull/316.patch","issue_url":"https://api.github.com/repos/opendatakit/javarosa/issues/316","number":316,"state":"open","locked":false,"title":"Issue 314 revert use of java8 datetime api","user":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars0.githubusercontent.com/u/205913?v=4","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"body":"Closes #314\r\n\r\n#### What has been done to verify that this works as intended?\r\n- The changes in the implementation have been made **before** the changes in the tests, thus being safe.\r\n- All unit tests are passing\r\n- Searching for imports of `java.time` namespace doesn't show any results\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nI've just translated to Joda Time every date/time related operation made with Java8's Date/Time API.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nNope.","created_at":"2018-05-17T16:32:33Z","updated_at":"2018-05-18T06:33:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c75740ce5d444a6aedede0c14e041d47635ba011","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":918875168,"url":"https://api.github.com/repos/opendatakit/javarosa/labels/needs%20testing","name":"needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/316/commits","review_comments_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/316/comments","review_comment_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/javarosa/issues/316/comments","statuses_url":"https://api.github.com/repos/opendatakit/javarosa/statuses/1dd6dd586f68488036148878202c90c52429eb49","head":{"label":"ggalmazor:issue_314_revert_use_of_java8_datetime_api","ref":"issue_314_revert_use_of_java8_datetime_api","sha":"1dd6dd586f68488036148878202c90c52429eb49","user":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars0.githubusercontent.com/u/205913?v=4","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"repo":{"id":106079185,"name":"javarosa","full_name":"ggalmazor/javarosa","owner":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars0.githubusercontent.com/u/205913?v=4","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggalmazor/javarosa","description":"The core library that many of the ODK tools are built around. It's written in Java, implements the ODK XForms spec, and runs on mobile devices and cloud servers. ✨🏗✨","fork":true,"url":"https://api.github.com/repos/ggalmazor/javarosa","forks_url":"https://api.github.com/repos/ggalmazor/javarosa/forks","keys_url":"https://api.github.com/repos/ggalmazor/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggalmazor/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggalmazor/javarosa/teams","hooks_url":"https://api.github.com/repos/ggalmazor/javarosa/hooks","issue_events_url":"https://api.github.com/repos/ggalmazor/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/ggalmazor/javarosa/events","assignees_url":"https://api.github.com/repos/ggalmazor/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/ggalmazor/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/ggalmazor/javarosa/tags","blobs_url":"https://api.github.com/repos/ggalmazor/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggalmazor/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggalmazor/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggalmazor/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggalmazor/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/ggalmazor/javarosa/languages","stargazers_url":"https://api.github.com/repos/ggalmazor/javarosa/stargazers","contributors_url":"https://api.github.com/repos/ggalmazor/javarosa/contributors","subscribers_url":"https://api.github.com/repos/ggalmazor/javarosa/subscribers","subscription_url":"https://api.github.com/repos/ggalmazor/javarosa/subscription","commits_url":"https://api.github.com/repos/ggalmazor/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggalmazor/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggalmazor/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggalmazor/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggalmazor/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/ggalmazor/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggalmazor/javarosa/merges","archive_url":"https://api.github.com/repos/ggalmazor/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggalmazor/javarosa/downloads","issues_url":"https://api.github.com/repos/ggalmazor/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/ggalmazor/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/ggalmazor/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/ggalmazor/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggalmazor/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/ggalmazor/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/ggalmazor/javarosa/deployments","created_at":"2017-10-07T07:23:39Z","updated_at":"2018-05-06T07:03:41Z","pushed_at":"2018-05-18T06:33:28Z","git_url":"git://github.com/ggalmazor/javarosa.git","ssh_url":"git@github.com:ggalmazor/javarosa.git","clone_url":"https://github.com/ggalmazor/javarosa.git","svn_url":"https://github.com/ggalmazor/javarosa","homepage":"","size":8154,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatakit:master","ref":"master","sha":"8dc87c40766cddeab769fb1b0478d654d797a82d","user":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":66836598,"name":"javarosa","full_name":"opendatakit/javarosa","owner":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatakit/javarosa","description":"The core library that many of the ODK tools are built around. It's written in Java, implements the ODK XForms spec, and runs on mobile devices and cloud servers. ✨🏗✨","fork":false,"url":"https://api.github.com/repos/opendatakit/javarosa","forks_url":"https://api.github.com/repos/opendatakit/javarosa/forks","keys_url":"https://api.github.com/repos/opendatakit/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/javarosa/teams","hooks_url":"https://api.github.com/repos/opendatakit/javarosa/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/javarosa/events","assignees_url":"https://api.github.com/repos/opendatakit/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/javarosa/tags","blobs_url":"https://api.github.com/repos/opendatakit/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/javarosa/languages","stargazers_url":"https://api.github.com/repos/opendatakit/javarosa/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/javarosa/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/javarosa/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/javarosa/subscription","commits_url":"https://api.github.com/repos/opendatakit/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/javarosa/merges","archive_url":"https://api.github.com/repos/opendatakit/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/javarosa/downloads","issues_url":"https://api.github.com/repos/opendatakit/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/opendatakit/javarosa/deployments","created_at":"2016-08-29T11:08:59Z","updated_at":"2018-05-15T23:07:48Z","pushed_at":"2018-05-18T06:33:29Z","git_url":"git://github.com/opendatakit/javarosa.git","ssh_url":"git@github.com:opendatakit/javarosa.git","clone_url":"https://github.com/opendatakit/javarosa.git","svn_url":"https://github.com/opendatakit/javarosa","homepage":"","size":8716,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":77,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/316"},"html":{"href":"https://github.com/opendatakit/javarosa/pull/316"},"issue":{"href":"https://api.github.com/repos/opendatakit/javarosa/issues/316"},"comments":{"href":"https://api.github.com/repos/opendatakit/javarosa/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/javarosa/statuses/1dd6dd586f68488036148878202c90c52429eb49"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ggalmazor"}}