{"action":"created","comment":{"url":"https://api.github.com/repos/github/linguist/pulls/comments/208810485","pull_request_review_id":144695413,"id":208810485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODgxMDQ4NQ==","diff_hunk":"@@ -248,13 +257,25 @@ func (conv *Converter) Report() error {\n \treturn nil\n }\n \n+var VERSION_RE *regexp.Regexp = regexp.MustCompile(\"VERSION = \\\"(.+)\\\"\")","path":"tools/grammars/compiler/converter.go","position":36,"original_position":36,"commit_id":"95306b6fd34f4c66eae7e37dd29b94290e0b347d","original_commit_id":"95306b6fd34f4c66eae7e37dd29b94290e0b347d","user":{"login":"kivikakk","id":1915,"node_id":"MDQ6VXNlcjE5MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1915?v=4","gravatar_id":"","url":"https://api.github.com/users/kivikakk","html_url":"https://github.com/kivikakk","followers_url":"https://api.github.com/users/kivikakk/followers","following_url":"https://api.github.com/users/kivikakk/following{/other_user}","gists_url":"https://api.github.com/users/kivikakk/gists{/gist_id}","starred_url":"https://api.github.com/users/kivikakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivikakk/subscriptions","organizations_url":"https://api.github.com/users/kivikakk/orgs","repos_url":"https://api.github.com/users/kivikakk/repos","events_url":"https://api.github.com/users/kivikakk/events{/privacy}","received_events_url":"https://api.github.com/users/kivikakk/received_events","type":"User","site_admin":true},"body":"I prefer your suggestion 100%. Thank you!","created_at":"2018-08-09T05:33:22Z","updated_at":"2018-08-09T05:33:22Z","html_url":"https://github.com/github/linguist/pull/4215#discussion_r208810485","pull_request_url":"https://api.github.com/repos/github/linguist/pulls/4215","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/github/linguist/pulls/comments/208810485"},"html":{"href":"https://github.com/github/linguist/pull/4215#discussion_r208810485"},"pull_request":{"href":"https://api.github.com/repos/github/linguist/pulls/4215"}},"in_reply_to_id":208810271},"pull_request":{"url":"https://api.github.com/repos/github/linguist/pulls/4215","id":204998417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTk4NDE3","html_url":"https://github.com/github/linguist/pull/4215","diff_url":"https://github.com/github/linguist/pull/4215.diff","patch_url":"https://github.com/github/linguist/pull/4215.patch","issue_url":"https://api.github.com/repos/github/linguist/issues/4215","number":4215,"state":"open","locked":false,"title":"Compiler fixes","user":{"login":"kivikakk","id":1915,"node_id":"MDQ6VXNlcjE5MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1915?v=4","gravatar_id":"","url":"https://api.github.com/users/kivikakk","html_url":"https://github.com/kivikakk","followers_url":"https://api.github.com/users/kivikakk/followers","following_url":"https://api.github.com/users/kivikakk/following{/other_user}","gists_url":"https://api.github.com/users/kivikakk/gists{/gist_id}","starred_url":"https://api.github.com/users/kivikakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivikakk/subscriptions","organizations_url":"https://api.github.com/users/kivikakk/orgs","repos_url":"https://api.github.com/users/kivikakk/repos","events_url":"https://api.github.com/users/kivikakk/events{/privacy}","received_events_url":"https://api.github.com/users/kivikakk/received_events","type":"User","site_admin":true},"body":"Some fixes for the grammar compiler:\r\n\r\n* `-linguist-path` wasn't being used\r\n* some repositories have syntax files that don't declare a scope name (see [`ballerina.monarch.json`](https://github.com/ballerina-platform/ballerina-grammar/blob/b7372c23154b3ccf9a55ef14e1abdbf753f4e2f2/syntaxes/ballerina.monarch.json)) — these were being written to `.json` in the output directory, which will in turn crash prettylights when it tries to read `.json` from the grammar directory and can't find a `scopeName` in it.\r\n\r\n/cc @vmg ","created_at":"2018-07-31T05:17:19Z","updated_at":"2018-08-09T05:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a664a6d1261160a77139b9a4fd71d4f237ed414d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/github/linguist/pulls/4215/commits","review_comments_url":"https://api.github.com/repos/github/linguist/pulls/4215/comments","review_comment_url":"https://api.github.com/repos/github/linguist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/linguist/issues/4215/comments","statuses_url":"https://api.github.com/repos/github/linguist/statuses/95306b6fd34f4c66eae7e37dd29b94290e0b347d","head":{"label":"github:compiler-fixes","ref":"compiler-fixes","sha":"95306b6fd34f4c66eae7e37dd29b94290e0b347d","user":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":1725199,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1MTk5","name":"linguist","full_name":"github/linguist","owner":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/linguist","description":"Language Savant. If your repository's language is being reported incorrectly, send us a pull request!","fork":false,"url":"https://api.github.com/repos/github/linguist","forks_url":"https://api.github.com/repos/github/linguist/forks","keys_url":"https://api.github.com/repos/github/linguist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/linguist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/linguist/teams","hooks_url":"https://api.github.com/repos/github/linguist/hooks","issue_events_url":"https://api.github.com/repos/github/linguist/issues/events{/number}","events_url":"https://api.github.com/repos/github/linguist/events","assignees_url":"https://api.github.com/repos/github/linguist/assignees{/user}","branches_url":"https://api.github.com/repos/github/linguist/branches{/branch}","tags_url":"https://api.github.com/repos/github/linguist/tags","blobs_url":"https://api.github.com/repos/github/linguist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/linguist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/linguist/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/linguist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/linguist/statuses/{sha}","languages_url":"https://api.github.com/repos/github/linguist/languages","stargazers_url":"https://api.github.com/repos/github/linguist/stargazers","contributors_url":"https://api.github.com/repos/github/linguist/contributors","subscribers_url":"https://api.github.com/repos/github/linguist/subscribers","subscription_url":"https://api.github.com/repos/github/linguist/subscription","commits_url":"https://api.github.com/repos/github/linguist/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/linguist/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/linguist/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/linguist/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/linguist/contents/{+path}","compare_url":"https://api.github.com/repos/github/linguist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/linguist/merges","archive_url":"https://api.github.com/repos/github/linguist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/linguist/downloads","issues_url":"https://api.github.com/repos/github/linguist/issues{/number}","pulls_url":"https://api.github.com/repos/github/linguist/pulls{/number}","milestones_url":"https://api.github.com/repos/github/linguist/milestones{/number}","notifications_url":"https://api.github.com/repos/github/linguist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/linguist/labels{/name}","releases_url":"https://api.github.com/repos/github/linguist/releases{/id}","deployments_url":"https://api.github.com/repos/github/linguist/deployments","created_at":"2011-05-09T22:53:13Z","updated_at":"2018-08-09T02:09:53Z","pushed_at":"2018-08-08T14:08:01Z","git_url":"git://github.com/github/linguist.git","ssh_url":"git@github.com:github/linguist.git","clone_url":"https://github.com/github/linguist.git","svn_url":"https://github.com/github/linguist","homepage":"","size":34302,"stargazers_count":5932,"watchers_count":5932,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2243,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2243,"open_issues":83,"watchers":5932,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"ed44c0b86d317b753c607742b137dce9594bed97","user":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":1725199,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1MTk5","name":"linguist","full_name":"github/linguist","owner":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/linguist","description":"Language Savant. If your repository's language is being reported incorrectly, send us a pull request!","fork":false,"url":"https://api.github.com/repos/github/linguist","forks_url":"https://api.github.com/repos/github/linguist/forks","keys_url":"https://api.github.com/repos/github/linguist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/linguist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/linguist/teams","hooks_url":"https://api.github.com/repos/github/linguist/hooks","issue_events_url":"https://api.github.com/repos/github/linguist/issues/events{/number}","events_url":"https://api.github.com/repos/github/linguist/events","assignees_url":"https://api.github.com/repos/github/linguist/assignees{/user}","branches_url":"https://api.github.com/repos/github/linguist/branches{/branch}","tags_url":"https://api.github.com/repos/github/linguist/tags","blobs_url":"https://api.github.com/repos/github/linguist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/linguist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/linguist/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/linguist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/linguist/statuses/{sha}","languages_url":"https://api.github.com/repos/github/linguist/languages","stargazers_url":"https://api.github.com/repos/github/linguist/stargazers","contributors_url":"https://api.github.com/repos/github/linguist/contributors","subscribers_url":"https://api.github.com/repos/github/linguist/subscribers","subscription_url":"https://api.github.com/repos/github/linguist/subscription","commits_url":"https://api.github.com/repos/github/linguist/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/linguist/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/linguist/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/linguist/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/linguist/contents/{+path}","compare_url":"https://api.github.com/repos/github/linguist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/linguist/merges","archive_url":"https://api.github.com/repos/github/linguist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/linguist/downloads","issues_url":"https://api.github.com/repos/github/linguist/issues{/number}","pulls_url":"https://api.github.com/repos/github/linguist/pulls{/number}","milestones_url":"https://api.github.com/repos/github/linguist/milestones{/number}","notifications_url":"https://api.github.com/repos/github/linguist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/linguist/labels{/name}","releases_url":"https://api.github.com/repos/github/linguist/releases{/id}","deployments_url":"https://api.github.com/repos/github/linguist/deployments","created_at":"2011-05-09T22:53:13Z","updated_at":"2018-08-09T02:09:53Z","pushed_at":"2018-08-08T14:08:01Z","git_url":"git://github.com/github/linguist.git","ssh_url":"git@github.com:github/linguist.git","clone_url":"https://github.com/github/linguist.git","svn_url":"https://github.com/github/linguist","homepage":"","size":34302,"stargazers_count":5932,"watchers_count":5932,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2243,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2243,"open_issues":83,"watchers":5932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/linguist/pulls/4215"},"html":{"href":"https://github.com/github/linguist/pull/4215"},"issue":{"href":"https://api.github.com/repos/github/linguist/issues/4215"},"comments":{"href":"https://api.github.com/repos/github/linguist/issues/4215/comments"},"review_comments":{"href":"https://api.github.com/repos/github/linguist/pulls/4215/comments"},"review_comment":{"href":"https://api.github.com/repos/github/linguist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/linguist/pulls/4215/commits"},"statuses":{"href":"https://api.github.com/repos/github/linguist/statuses/95306b6fd34f4c66eae7e37dd29b94290e0b347d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kivikakk"}}