{"action":"created","comment":{"url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/comments/180614713","pull_request_review_id":111064989,"id":180614713,"diff_hunk":"@@ -0,0 +1,132 @@\n+{-# LANGUAGE FlexibleInstances, MultiParamTypeClasses, TypeSynonymInstances #-}\n+-----------------------------------------------------------------------------\n+-- |\n+-- Module      :  XMonad.Layout.BinaryColumn\n+-- Copyright   :  (c) 2009 Ilya Portnov, (c) 2018 Campbell Barton\n+-- License     :  BSD3-style (see LICENSE)\n+--\n+-- Maintainer  :  Campbell Barton <ideasman42@gmail.com>\n+-- Stability   :  unstable\n+-- Portability :  unportable\n+--\n+-- Provides Column layout that places all windows in one column.\n+-- Each window is half the height of the previous.\n+--\n+-- Note: Originally based on XMonad.Layout.Column with edits.\n+--\n+-----------------------------------------------------------------------------\n+\n+module XMonad.Layout.BinaryColumn (\n+                             -- * Usage\n+                             -- $usage\n+                             BinaryColumn (..)\n+                            ) where\n+import XMonad\n+import qualified XMonad.StackSet\n+import qualified Data.List\n+\n+-- $usage\n+-- This module defines layot named BinaryColumn.","path":"XMonad/Layout/BinaryColumn.hs","position":29,"original_position":29,"commit_id":"236ca9959d428228d1546e68f9c5183fd5b4f9a4","original_commit_id":"236ca9959d428228d1546e68f9c5183fd5b4f9a4","user":{"login":"byorgey","id":533859,"avatar_url":"https://avatars0.githubusercontent.com/u/533859?v=4","gravatar_id":"","url":"https://api.github.com/users/byorgey","html_url":"https://github.com/byorgey","followers_url":"https://api.github.com/users/byorgey/followers","following_url":"https://api.github.com/users/byorgey/following{/other_user}","gists_url":"https://api.github.com/users/byorgey/gists{/gist_id}","starred_url":"https://api.github.com/users/byorgey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byorgey/subscriptions","organizations_url":"https://api.github.com/users/byorgey/orgs","repos_url":"https://api.github.com/users/byorgey/repos","events_url":"https://api.github.com/users/byorgey/events{/privacy}","received_events_url":"https://api.github.com/users/byorgey/received_events","type":"User","site_admin":false},"body":"Should be \"layout\"","created_at":"2018-04-11T01:45:43Z","updated_at":"2018-04-11T01:48:08Z","html_url":"https://github.com/xmonad/xmonad-contrib/pull/233#discussion_r180614713","pull_request_url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/comments/180614713"},"html":{"href":"https://github.com/xmonad/xmonad-contrib/pull/233#discussion_r180614713"},"pull_request":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233","id":174203025,"html_url":"https://github.com/xmonad/xmonad-contrib/pull/233","diff_url":"https://github.com/xmonad/xmonad-contrib/pull/233.diff","patch_url":"https://github.com/xmonad/xmonad-contrib/pull/233.patch","issue_url":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/233","number":233,"state":"open","locked":false,"title":"Add BinaryColumn layout","user":{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars2.githubusercontent.com/u/1869379?v=4","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false},"body":"This is similar to 'Column' layout with some differences.\r\n\r\n- Add/remove windows keeps window bounds.\r\n\r\n  *(with `Column` all window frames re-size whenever windows are added or removed. I find it quite annoying).*\r\n- Enforce minimum window size.\r\n\r\n  *(this means you never get a bunch of unrecognizable 1-3 high pixel windows - even if you have many windows open).*\r\n\r\n- Scaling the master window down causes an evenly spaced grid.\r\n\r\n- Negative scale can be used to increase the size of the last window\r\n  instead of the master window.\r\n\r\n### Description\r\n\r\nUsing xmonad with monitors in portrait mode is well suited to a column grid.\r\nThere are however some constraints.\r\n\r\nNot that this is different enough from the Column layout that I don't think it can be a drop in replacement. Scale works differently window size minimum has been added.\r\n\r\n### Checklist\r\n\r\n  - [x] I've read [CONTRIBUTING.md](https://github.com/xmonad/xmonad/blob/master/CONTRIBUTING.md)\r\n\r\n  - [ ] I tested my changes with [xmonad-testing](https://github.com/xmonad/xmonad-testing)\r\n\r\nAttempted this but was getting error:\r\nhttps://gist.github.com/ideasman42/7bcbaa036e72036275ccd43b5fdf6555\r\n\r\n  - [x] I updated the `CHANGES.md` file\r\n","created_at":"2018-03-11T03:57:09Z","updated_at":"2018-04-11T01:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf6e543de1987f60a31537de266c7fc0e24efb2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233/commits","review_comments_url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233/comments","review_comment_url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/233/comments","statuses_url":"https://api.github.com/repos/xmonad/xmonad-contrib/statuses/236ca9959d428228d1546e68f9c5183fd5b4f9a4","head":{"label":"ideasman42:layout-binary-column","ref":"layout-binary-column","sha":"236ca9959d428228d1546e68f9c5183fd5b4f9a4","user":{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars2.githubusercontent.com/u/1869379?v=4","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false},"repo":{"id":124712735,"name":"xmonad-contrib","full_name":"ideasman42/xmonad-contrib","owner":{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars2.githubusercontent.com/u/1869379?v=4","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ideasman42/xmonad-contrib","description":"Contributed modules for xmonad","fork":true,"url":"https://api.github.com/repos/ideasman42/xmonad-contrib","forks_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/forks","keys_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/teams","hooks_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/hooks","issue_events_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/events","assignees_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/tags","blobs_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/languages","stargazers_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/stargazers","contributors_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/contributors","subscribers_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/subscribers","subscription_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/subscription","commits_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/merges","archive_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/downloads","issues_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/labels{/name}","releases_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/ideasman42/xmonad-contrib/deployments","created_at":"2018-03-11T01:22:12Z","updated_at":"2018-03-11T01:22:15Z","pushed_at":"2018-03-11T09:37:43Z","git_url":"git://github.com/ideasman42/xmonad-contrib.git","ssh_url":"git@github.com:ideasman42/xmonad-contrib.git","clone_url":"https://github.com/ideasman42/xmonad-contrib.git","svn_url":"https://github.com/ideasman42/xmonad-contrib","homepage":null,"size":9678,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xmonad:master","ref":"master","sha":"3d3e898166fd35ab91ff1c0cf76e925bfe370119","user":{"login":"xmonad","id":13919517,"avatar_url":"https://avatars2.githubusercontent.com/u/13919517?v=4","gravatar_id":"","url":"https://api.github.com/users/xmonad","html_url":"https://github.com/xmonad","followers_url":"https://api.github.com/users/xmonad/followers","following_url":"https://api.github.com/users/xmonad/following{/other_user}","gists_url":"https://api.github.com/users/xmonad/gists{/gist_id}","starred_url":"https://api.github.com/users/xmonad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmonad/subscriptions","organizations_url":"https://api.github.com/users/xmonad/orgs","repos_url":"https://api.github.com/users/xmonad/repos","events_url":"https://api.github.com/users/xmonad/events{/privacy}","received_events_url":"https://api.github.com/users/xmonad/received_events","type":"Organization","site_admin":false},"repo":{"id":41218220,"name":"xmonad-contrib","full_name":"xmonad/xmonad-contrib","owner":{"login":"xmonad","id":13919517,"avatar_url":"https://avatars2.githubusercontent.com/u/13919517?v=4","gravatar_id":"","url":"https://api.github.com/users/xmonad","html_url":"https://github.com/xmonad","followers_url":"https://api.github.com/users/xmonad/followers","following_url":"https://api.github.com/users/xmonad/following{/other_user}","gists_url":"https://api.github.com/users/xmonad/gists{/gist_id}","starred_url":"https://api.github.com/users/xmonad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmonad/subscriptions","organizations_url":"https://api.github.com/users/xmonad/orgs","repos_url":"https://api.github.com/users/xmonad/repos","events_url":"https://api.github.com/users/xmonad/events{/privacy}","received_events_url":"https://api.github.com/users/xmonad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xmonad/xmonad-contrib","description":"Contributed modules for xmonad","fork":false,"url":"https://api.github.com/repos/xmonad/xmonad-contrib","forks_url":"https://api.github.com/repos/xmonad/xmonad-contrib/forks","keys_url":"https://api.github.com/repos/xmonad/xmonad-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmonad/xmonad-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmonad/xmonad-contrib/teams","hooks_url":"https://api.github.com/repos/xmonad/xmonad-contrib/hooks","issue_events_url":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/xmonad/xmonad-contrib/events","assignees_url":"https://api.github.com/repos/xmonad/xmonad-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/xmonad/xmonad-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/xmonad/xmonad-contrib/tags","blobs_url":"https://api.github.com/repos/xmonad/xmonad-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmonad/xmonad-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmonad/xmonad-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmonad/xmonad-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmonad/xmonad-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/xmonad/xmonad-contrib/languages","stargazers_url":"https://api.github.com/repos/xmonad/xmonad-contrib/stargazers","contributors_url":"https://api.github.com/repos/xmonad/xmonad-contrib/contributors","subscribers_url":"https://api.github.com/repos/xmonad/xmonad-contrib/subscribers","subscription_url":"https://api.github.com/repos/xmonad/xmonad-contrib/subscription","commits_url":"https://api.github.com/repos/xmonad/xmonad-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmonad/xmonad-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmonad/xmonad-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmonad/xmonad-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/xmonad/xmonad-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmonad/xmonad-contrib/merges","archive_url":"https://api.github.com/repos/xmonad/xmonad-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmonad/xmonad-contrib/downloads","issues_url":"https://api.github.com/repos/xmonad/xmonad-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/xmonad/xmonad-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/xmonad/xmonad-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmonad/xmonad-contrib/labels{/name}","releases_url":"https://api.github.com/repos/xmonad/xmonad-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/xmonad/xmonad-contrib/deployments","created_at":"2015-08-22T17:45:35Z","updated_at":"2018-04-11T01:43:34Z","pushed_at":"2018-04-11T01:43:29Z","git_url":"git://github.com/xmonad/xmonad-contrib.git","ssh_url":"git@github.com:xmonad/xmonad-contrib.git","clone_url":"https://github.com/xmonad/xmonad-contrib.git","svn_url":"https://github.com/xmonad/xmonad-contrib","homepage":null,"size":9697,"stargazers_count":163,"watchers_count":163,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":122,"open_issues":64,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233"},"html":{"href":"https://github.com/xmonad/xmonad-contrib/pull/233"},"issue":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/233"},"comments":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/xmonad/xmonad-contrib/statuses/236ca9959d428228d1546e68f9c5183fd5b4f9a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"byorgey"}}