{"action":"created","issue":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/751","repository_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom","labels_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/751/labels{/name}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/751/comments","events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/751/events","html_url":"https://github.com/chocolate-doom/chocolate-doom/issues/751","id":165602201,"number":751,"title":"MSVC stuff out of date","user":{"login":"jmtd","id":63694,"avatar_url":"https://avatars1.githubusercontent.com/u/63694?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtd","html_url":"https://github.com/jmtd","followers_url":"https://api.github.com/users/jmtd/followers","following_url":"https://api.github.com/users/jmtd/following{/other_user}","gists_url":"https://api.github.com/users/jmtd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtd/subscriptions","organizations_url":"https://api.github.com/users/jmtd/orgs","repos_url":"https://api.github.com/users/jmtd/repos","events_url":"https://api.github.com/users/jmtd/events{/privacy}","received_events_url":"https://api.github.com/users/jmtd/received_events","type":"User","site_admin":false},"labels":[{"id":257755293,"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/labels/build","name":"build","color":"d4c5f9","default":false},{"id":257687003,"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/labels/windows","name":"windows","color":"FFCC00","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-07-14T16:22:28Z","updated_at":"2018-04-01T06:41:04Z","closed_at":"2018-04-01T06:41:04Z","author_association":"CONTRIBUTOR","body":"The msvc folder is out of date again. This is not really news (and on it's own is not really issue-worthy I suppose), but there's a couple of things I propose.\n\nFirstly this could be fixed up for the sdl2-branch so we have a working MSVC project at the beginning of v3. I would suggest we migrate to a VC2015 project, since that's currently freely available for people.\n\nIf we add \"lib\" to the linker path and \"include\" to the include path (which map to msvc/include and msvc/lib) we can simplify the instructions for the SDL dependencies to \"for each SDL2/SDL2_mixer/SDL2_net/SDL2_image zip, extract the lib/x86 files to msvc/lib and the include/ files to msvc/include). Hopefully we can specify these two directories in one place (the \"solution\"?) and all the projects will inherit them.\n\nWe could simplify it even further if we looked at NuGet for fetching the SDL dependencies.\n\nWe need to decide whether we are building an x86 target or an amd64 one.\n\nFinally there are a number of SaaS services that could be used for building the msvc project in the cloud, including triggering new builds on each commit. E.g. Visual Studio Team Services https://www.visualstudio.com or possibly https://www.appveyor.com. \n\nFinally out of scope for this bug (so I will raise this discussion elsewhere I guess) but i think we should promote the MSVC build process to be the \"official/blessed\" one for Windows. Rationale in brief: the argument against has generally been that it bit-rots quickly, but the same is true for the official instructions -- cross-building from Linux is different enough to doing it natively\" via cygwin that those instructions have bit-rotted too. Anecdotally after a few hours the other night I managed to get MSVC working again but I failed to get cygwin set up properly (and I'm a UNIX oriented person!). I'd suggest that cygwin and/or cross-compiling is relatively niche and expert enough that it's a lot to expect of potential windows-based contributors (but experts such as us can put up with the difficulties for convenience of building on our preferred environments if we choose). IF we set up a CI thing as per the last paragraph, we are going to notice/catch the MSVC route bit-rotting much more quickly. Oh and as an aside-inside-an-aside, cygwin-on-windows has mingw-built SDL2 packages available for it, so we don't need to (and probably shouldn't suggest) that folks build SDL from source as a prerequisite for chocolate doom.\n"},"comment":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/comments/377766558","html_url":"https://github.com/chocolate-doom/chocolate-doom/issues/751#issuecomment-377766558","issue_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/751","id":377766558,"user":{"login":"fragglet","id":96821,"avatar_url":"https://avatars2.githubusercontent.com/u/96821?v=4","gravatar_id":"","url":"https://api.github.com/users/fragglet","html_url":"https://github.com/fragglet","followers_url":"https://api.github.com/users/fragglet/followers","following_url":"https://api.github.com/users/fragglet/following{/other_user}","gists_url":"https://api.github.com/users/fragglet/gists{/gist_id}","starred_url":"https://api.github.com/users/fragglet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragglet/subscriptions","organizations_url":"https://api.github.com/users/fragglet/orgs","repos_url":"https://api.github.com/users/fragglet/repos","events_url":"https://api.github.com/users/fragglet/events{/privacy}","received_events_url":"https://api.github.com/users/fragglet/received_events","type":"User","site_admin":false},"created_at":"2018-04-01T06:41:04Z","updated_at":"2018-04-01T06:41:04Z","author_association":"OWNER","body":"Now fixed, I believe?"}}
{"actor":{"display_login":"fragglet"}}