{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/202092000","pull_request_review_id":136721630,"id":202092000,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA5MjAwMA==","diff_hunk":"@@ -189,14 +179,14 @@ func TestGet(t *testing.T) {\n \t\t\tconfigs: testGateways,\n \t\t\targs:    strings.Split(\"get gateways -n default\", \" \"),\n \t\t\texpectedOutput: `GATEWAY NAME       HOSTS     NAMESPACE   AGE\n-bookinfo-gateway   *         default     <unknown>","path":"istioctl/cmd/istioctl/istioctl_test.go","position":21,"original_position":21,"commit_id":"2942c8b8ddae7a9cea5c05dc03e89d06715149af","original_commit_id":"2942c8b8ddae7a9cea5c05dc03e89d06715149af","user":{"login":"esnible","id":3237651,"node_id":"MDQ6VXNlcjMyMzc2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3237651?v=4","gravatar_id":"","url":"https://api.github.com/users/esnible","html_url":"https://github.com/esnible","followers_url":"https://api.github.com/users/esnible/followers","following_url":"https://api.github.com/users/esnible/following{/other_user}","gists_url":"https://api.github.com/users/esnible/gists{/gist_id}","starred_url":"https://api.github.com/users/esnible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esnible/subscriptions","organizations_url":"https://api.github.com/users/esnible/orgs","repos_url":"https://api.github.com/users/esnible/repos","events_url":"https://api.github.com/users/esnible/events{/privacy}","received_events_url":"https://api.github.com/users/esnible/received_events","type":"User","site_admin":false},"body":"Nit: Would it ever be possible that this test might fail if it takes >1 second to execute?  I'm concerned that \"0s\" might turn into \"1s\".","created_at":"2018-07-12T16:05:54Z","updated_at":"2018-07-12T16:05:54Z","html_url":"https://github.com/istio/istio/pull/7043#discussion_r202092000","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/7043","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/202092000"},"html":{"href":"https://github.com/istio/istio/pull/7043#discussion_r202092000"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/7043"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7043","id":201026491,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDI2NDkx","html_url":"https://github.com/istio/istio/pull/7043","diff_url":"https://github.com/istio/istio/pull/7043.diff","patch_url":"https://github.com/istio/istio/pull/7043.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/7043","number":7043,"state":"open","locked":false,"title":"Remove listeners for newer services when conflicts occur.","user":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"This PR adds the CreationTime to the service struct and populates it\r\nin the k8s service registry. When available, services will be sorted\r\nby their creation time. Conflicts will cause the listeners for newer\r\nservices to be dropped.\r\n\r\nPartial fix for #5992","created_at":"2018-07-12T14:46:42Z","updated_at":"2018-07-12T16:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d6a24259809eb18651bdab156bf9e42c107d489","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"ijsnellf","id":19473346,"node_id":"MDQ6VXNlcjE5NDczMzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/7043/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/7043/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/7043/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/2942c8b8ddae7a9cea5c05dc03e89d06715149af","head":{"label":"nmittler:listener_conflict2","ref":"listener_conflict2","sha":"2942c8b8ddae7a9cea5c05dc03e89d06715149af","user":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":105299964,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyOTk5NjQ=","name":"istio","full_name":"nmittler/istio","owner":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/nmittler/istio","forks_url":"https://api.github.com/repos/nmittler/istio/forks","keys_url":"https://api.github.com/repos/nmittler/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/istio/teams","hooks_url":"https://api.github.com/repos/nmittler/istio/hooks","issue_events_url":"https://api.github.com/repos/nmittler/istio/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/istio/events","assignees_url":"https://api.github.com/repos/nmittler/istio/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/istio/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/istio/tags","blobs_url":"https://api.github.com/repos/nmittler/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/istio/languages","stargazers_url":"https://api.github.com/repos/nmittler/istio/stargazers","contributors_url":"https://api.github.com/repos/nmittler/istio/contributors","subscribers_url":"https://api.github.com/repos/nmittler/istio/subscribers","subscription_url":"https://api.github.com/repos/nmittler/istio/subscription","commits_url":"https://api.github.com/repos/nmittler/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/istio/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/istio/merges","archive_url":"https://api.github.com/repos/nmittler/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/istio/downloads","issues_url":"https://api.github.com/repos/nmittler/istio/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/istio/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/istio/releases{/id}","deployments_url":"https://api.github.com/repos/nmittler/istio/deployments","created_at":"2017-09-29T17:33:39Z","updated_at":"2017-09-29T17:33:41Z","pushed_at":"2018-07-12T14:51:03Z","git_url":"git://github.com/nmittler/istio.git","ssh_url":"git@github.com:nmittler/istio.git","clone_url":"https://github.com/nmittler/istio.git","svn_url":"https://github.com/nmittler/istio","homepage":"https://istio.io","size":123011,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.0","ref":"release-1.0","sha":"007d82f03056f5044850baf2592a5869122d2ffb","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-07-12T15:54:51Z","pushed_at":"2018-07-12T16:04:45Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":41243,"stargazers_count":9263,"watchers_count":9263,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1293,"mirror_url":null,"archived":false,"open_issues_count":797,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1293,"open_issues":797,"watchers":9263,"default_branch":"release-1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/7043"},"html":{"href":"https://github.com/istio/istio/pull/7043"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/7043"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/7043/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/7043/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/7043/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/2942c8b8ddae7a9cea5c05dc03e89d06715149af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"esnible"}}