{"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/comments/236115150","pull_request_review_id":178125713,"id":236115150,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjExNTE1MA==","diff_hunk":"@@ -352,12 +353,6 @@ func launch(api screwdriver.API, buildID int, rootDir, emitterPath, metaSpace, s\n \tfmt.Fprintf(emitter, \"%s%s\\n\", blackSprint(\"Source Dir:     \"), w.Src)\n \tfmt.Fprintf(emitter, \"%s%s\\n\", blackSprint(\"Artifacts Dir:  \"), w.Artifacts)\n \n-\toldJobName := job.Name\n-\tpr := prNumber(job.Name)\n-\tif pr != \"\" {","path":"launch.go","position":29,"original_position":29,"commit_id":"4f19d4dd777bf38f6054415bb860ec620124d531","original_commit_id":"4f19d4dd777bf38f6054415bb860ec620124d531","user":{"login":"s-yoshika","id":5774825,"node_id":"MDQ6VXNlcjU3NzQ4MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/5774825?v=4","gravatar_id":"","url":"https://api.github.com/users/s-yoshika","html_url":"https://github.com/s-yoshika","followers_url":"https://api.github.com/users/s-yoshika/followers","following_url":"https://api.github.com/users/s-yoshika/following{/other_user}","gists_url":"https://api.github.com/users/s-yoshika/gists{/gist_id}","starred_url":"https://api.github.com/users/s-yoshika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-yoshika/subscriptions","organizations_url":"https://api.github.com/users/s-yoshika/orgs","repos_url":"https://api.github.com/users/s-yoshika/repos","events_url":"https://api.github.com/users/s-yoshika/events{/privacy}","received_events_url":"https://api.github.com/users/s-yoshika/received_events","type":"User","site_admin":false},"body":"Is this if statement no longer necessary?","created_at":"2018-11-26T03:47:11Z","updated_at":"2018-11-26T03:47:12Z","html_url":"https://github.com/screwdriver-cd/launcher/pull/241#discussion_r236115150","pull_request_url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/comments/236115150"},"html":{"href":"https://github.com/screwdriver-cd/launcher/pull/241#discussion_r236115150"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241","id":232906656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTA2NjU2","html_url":"https://github.com/screwdriver-cd/launcher/pull/241","diff_url":"https://github.com/screwdriver-cd/launcher/pull/241.diff","patch_url":"https://github.com/screwdriver-cd/launcher/pull/241.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/launcher/issues/241","number":241,"state":"open","locked":false,"title":"feat(1010): use prNum of Job to set SD_PULL_REQUEST","user":{"login":"tk3fftk","id":3445553,"node_id":"MDQ6VXNlcjM0NDU1NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3445553?v=4","gravatar_id":"","url":"https://api.github.com/users/tk3fftk","html_url":"https://github.com/tk3fftk","followers_url":"https://api.github.com/users/tk3fftk/followers","following_url":"https://api.github.com/users/tk3fftk/following{/other_user}","gists_url":"https://api.github.com/users/tk3fftk/gists{/gist_id}","starred_url":"https://api.github.com/users/tk3fftk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk3fftk/subscriptions","organizations_url":"https://api.github.com/users/tk3fftk/orgs","repos_url":"https://api.github.com/users/tk3fftk/repos","events_url":"https://api.github.com/users/tk3fftk/events{/privacy}","received_events_url":"https://api.github.com/users/tk3fftk/received_events","type":"User","site_admin":false},"body":"## Context\r\nWe want to implement `prChain` feature. If `prChain` is true, a job name does not have `PR-` prefix. So we will add `prNum` to Job schema.\r\n\r\n## Objective\r\nUse `prNum` instead of a job name.\r\nThis PR has backward compatibility so we can also use `PR-` prefix.\r\nThis PR also provides some refactoring.\r\n\r\n## Misc.\r\nRelated Issue: https://github.com/screwdriver-cd/screwdriver/issues/1010\r\nRelated PRs:\r\n- https://github.com/screwdriver-cd/data-schema/pull/296\r\n- https://github.com/screwdriver-cd/config-parser/pull/81","created_at":"2018-11-22T09:17:40Z","updated_at":"2018-11-26T03:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd9a7e7b0eb84a5ed338ebf5030aa159ee34e61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/launcher/issues/241/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/launcher/statuses/4f19d4dd777bf38f6054415bb860ec620124d531","head":{"label":"sonic-screwdriver-cd:prChain","ref":"prChain","sha":"4f19d4dd777bf38f6054415bb860ec620124d531","user":{"login":"sonic-screwdriver-cd","id":30816763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE2NzYz","avatar_url":"https://avatars3.githubusercontent.com/u/30816763?v=4","gravatar_id":"","url":"https://api.github.com/users/sonic-screwdriver-cd","html_url":"https://github.com/sonic-screwdriver-cd","followers_url":"https://api.github.com/users/sonic-screwdriver-cd/followers","following_url":"https://api.github.com/users/sonic-screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/sonic-screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/sonic-screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonic-screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/sonic-screwdriver-cd/orgs","repos_url":"https://api.github.com/users/sonic-screwdriver-cd/repos","events_url":"https://api.github.com/users/sonic-screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/sonic-screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":101634653,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2MzQ2NTM=","name":"launcher","full_name":"sonic-screwdriver-cd/launcher","private":false,"owner":{"login":"sonic-screwdriver-cd","id":30816763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE2NzYz","avatar_url":"https://avatars3.githubusercontent.com/u/30816763?v=4","gravatar_id":"","url":"https://api.github.com/users/sonic-screwdriver-cd","html_url":"https://github.com/sonic-screwdriver-cd","followers_url":"https://api.github.com/users/sonic-screwdriver-cd/followers","following_url":"https://api.github.com/users/sonic-screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/sonic-screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/sonic-screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonic-screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/sonic-screwdriver-cd/orgs","repos_url":"https://api.github.com/users/sonic-screwdriver-cd/repos","events_url":"https://api.github.com/users/sonic-screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/sonic-screwdriver-cd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonic-screwdriver-cd/launcher","description":"The entrypoint for job launching in Screwdriver","fork":true,"url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher","forks_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/forks","keys_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/teams","hooks_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/hooks","issue_events_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/issues/events{/number}","events_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/events","assignees_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/assignees{/user}","branches_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/branches{/branch}","tags_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/tags","blobs_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/languages","stargazers_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/stargazers","contributors_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/contributors","subscribers_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/subscribers","subscription_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/subscription","commits_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/contents/{+path}","compare_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/merges","archive_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/downloads","issues_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/issues{/number}","pulls_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/labels{/name}","releases_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/releases{/id}","deployments_url":"https://api.github.com/repos/sonic-screwdriver-cd/launcher/deployments","created_at":"2017-08-28T11:08:44Z","updated_at":"2018-11-22T05:49:32Z","pushed_at":"2018-11-22T09:48:38Z","git_url":"git://github.com/sonic-screwdriver-cd/launcher.git","ssh_url":"git@github.com:sonic-screwdriver-cd/launcher.git","clone_url":"https://github.com/sonic-screwdriver-cd/launcher.git","svn_url":"https://github.com/sonic-screwdriver-cd/launcher","homepage":"https://github.com/screwdriver-cd/launcher/releases","size":389,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"6da62a4a7534ae76807db86f95f4f1c457e59db6","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":63980841,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzk4MDg0MQ==","name":"launcher","full_name":"screwdriver-cd/launcher","private":false,"owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/screwdriver-cd/launcher","description":"The entrypoint for job launching in Screwdriver","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/launcher","forks_url":"https://api.github.com/repos/screwdriver-cd/launcher/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/launcher/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/launcher/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/launcher/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/launcher/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/launcher/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/launcher/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/launcher/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/launcher/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/launcher/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/launcher/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/launcher/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/launcher/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/launcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/launcher/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/launcher/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/launcher/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/launcher/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/launcher/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/launcher/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/launcher/deployments","created_at":"2016-07-22T20:18:23Z","updated_at":"2018-11-21T00:04:45Z","pushed_at":"2018-11-22T09:48:39Z","git_url":"git://github.com/screwdriver-cd/launcher.git","ssh_url":"git@github.com:screwdriver-cd/launcher.git","clone_url":"https://github.com/screwdriver-cd/launcher.git","svn_url":"https://github.com/screwdriver-cd/launcher","homepage":"https://cd.screwdriver.cd/pipelines/21","size":359,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241"},"html":{"href":"https://github.com/screwdriver-cd/launcher/pull/241"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/issues/241"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/launcher/statuses/4f19d4dd777bf38f6054415bb860ec620124d531"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"s-yoshika"}}