{"action":"closed","number":1131,"pull_request":{"url":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131","id":233323893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzIzODkz","html_url":"https://github.com/goalgorilla/open_social/pull/1131","diff_url":"https://github.com/goalgorilla/open_social/pull/1131.diff","patch_url":"https://github.com/goalgorilla/open_social/pull/1131.patch","issue_url":"https://api.github.com/repos/goalgorilla/open_social/issues/1131","number":1131,"state":"closed","locked":false,"title":"Issue #2993086: Message related object entity type is empty","user":{"login":"jaapjan","id":2848293,"node_id":"MDQ6VXNlcjI4NDgyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2848293?v=4","gravatar_id":"","url":"https://api.github.com/users/jaapjan","html_url":"https://github.com/jaapjan","followers_url":"https://api.github.com/users/jaapjan/followers","following_url":"https://api.github.com/users/jaapjan/following{/other_user}","gists_url":"https://api.github.com/users/jaapjan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapjan/subscriptions","organizations_url":"https://api.github.com/users/jaapjan/orgs","repos_url":"https://api.github.com/users/jaapjan/repos","events_url":"https://api.github.com/users/jaapjan/events{/privacy}","received_events_url":"https://api.github.com/users/jaapjan/received_events","type":"User","site_admin":false},"body":"## Problem\r\nIn some cases, the entity type of the activity message is empty, therefore, the site encounters an error.\r\n\r\n## Solution\r\nWe can make the code more defensive to prevent this type of error.\r\n\r\n## Issue tracker\r\nhttps://www.drupal.org/project/social/issues/2993086\r\n\r\n## How to test\r\n- [x] Check the code changes\r\n- [ ] Verify message system still works as expected.\r\n\r\n## Release notes\r\nIn some cases, the entity type of the activity message is empty for customised sites, therefore, the site encounters an error. We've rewritten the code a bit to make this more defensive.","created_at":"2018-11-24T14:57:26Z","updated_at":"2018-11-26T09:54:08Z","closed_at":"2018-11-26T09:54:08Z","merged_at":"2018-11-26T09:54:08Z","merge_commit_sha":"d8c0ef2fef2017cf83310a247e83536021e10783","assignee":{"login":"jaapjan","id":2848293,"node_id":"MDQ6VXNlcjI4NDgyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2848293?v=4","gravatar_id":"","url":"https://api.github.com/users/jaapjan","html_url":"https://github.com/jaapjan","followers_url":"https://api.github.com/users/jaapjan/followers","following_url":"https://api.github.com/users/jaapjan/following{/other_user}","gists_url":"https://api.github.com/users/jaapjan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapjan/subscriptions","organizations_url":"https://api.github.com/users/jaapjan/orgs","repos_url":"https://api.github.com/users/jaapjan/repos","events_url":"https://api.github.com/users/jaapjan/events{/privacy}","received_events_url":"https://api.github.com/users/jaapjan/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaapjan","id":2848293,"node_id":"MDQ6VXNlcjI4NDgyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2848293?v=4","gravatar_id":"","url":"https://api.github.com/users/jaapjan","html_url":"https://github.com/jaapjan","followers_url":"https://api.github.com/users/jaapjan/followers","following_url":"https://api.github.com/users/jaapjan/following{/other_user}","gists_url":"https://api.github.com/users/jaapjan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapjan/subscriptions","organizations_url":"https://api.github.com/users/jaapjan/orgs","repos_url":"https://api.github.com/users/jaapjan/repos","events_url":"https://api.github.com/users/jaapjan/events{/privacy}","received_events_url":"https://api.github.com/users/jaapjan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":410682557,"node_id":"MDU6TGFiZWw0MTA2ODI1NTc=","url":"https://api.github.com/repos/goalgorilla/open_social/labels/bug","name":"bug","color":"ee0701","default":true},{"id":627874167,"node_id":"MDU6TGFiZWw2Mjc4NzQxNjc=","url":"https://api.github.com/repos/goalgorilla/open_social/labels/ext","name":"ext","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/goalgorilla/open_social/milestones/40","html_url":"https://github.com/goalgorilla/open_social/milestone/40","labels_url":"https://api.github.com/repos/goalgorilla/open_social/milestones/40/labels","id":3808265,"node_id":"MDk6TWlsZXN0b25lMzgwODI2NQ==","number":40,"title":"3.6","description":null,"creator":{"login":"ronaldtebrake","id":16667281,"node_id":"MDQ6VXNlcjE2NjY3Mjgx","avatar_url":"https://avatars0.githubusercontent.com/u/16667281?v=4","gravatar_id":"","url":"https://api.github.com/users/ronaldtebrake","html_url":"https://github.com/ronaldtebrake","followers_url":"https://api.github.com/users/ronaldtebrake/followers","following_url":"https://api.github.com/users/ronaldtebrake/following{/other_user}","gists_url":"https://api.github.com/users/ronaldtebrake/gists{/gist_id}","starred_url":"https://api.github.com/users/ronaldtebrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronaldtebrake/subscriptions","organizations_url":"https://api.github.com/users/ronaldtebrake/orgs","repos_url":"https://api.github.com/users/ronaldtebrake/repos","events_url":"https://api.github.com/users/ronaldtebrake/events{/privacy}","received_events_url":"https://api.github.com/users/ronaldtebrake/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":20,"state":"open","created_at":"2018-11-09T07:55:02Z","updated_at":"2018-11-26T09:54:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/goalgorilla/open_social/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goalgorilla/open_social/issues/1131/comments","statuses_url":"https://api.github.com/repos/goalgorilla/open_social/statuses/289bb2f5023a293e54cb93d5d1e48b00576ce3dd","head":{"label":"goalgorilla:feature/2993086","ref":"feature/2993086","sha":"289bb2f5023a293e54cb93d5d1e48b00576ce3dd","user":{"login":"goalgorilla","id":16816975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/16816975?v=4","gravatar_id":"","url":"https://api.github.com/users/goalgorilla","html_url":"https://github.com/goalgorilla","followers_url":"https://api.github.com/users/goalgorilla/followers","following_url":"https://api.github.com/users/goalgorilla/following{/other_user}","gists_url":"https://api.github.com/users/goalgorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/goalgorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goalgorilla/subscriptions","organizations_url":"https://api.github.com/users/goalgorilla/orgs","repos_url":"https://api.github.com/users/goalgorilla/repos","events_url":"https://api.github.com/users/goalgorilla/events{/privacy}","received_events_url":"https://api.github.com/users/goalgorilla/received_events","type":"Organization","site_admin":false},"repo":{"id":63693909,"node_id":"MDEwOlJlcG9zaXRvcnk2MzY5MzkwOQ==","name":"open_social","full_name":"goalgorilla/open_social","private":false,"owner":{"login":"goalgorilla","id":16816975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/16816975?v=4","gravatar_id":"","url":"https://api.github.com/users/goalgorilla","html_url":"https://github.com/goalgorilla","followers_url":"https://api.github.com/users/goalgorilla/followers","following_url":"https://api.github.com/users/goalgorilla/following{/other_user}","gists_url":"https://api.github.com/users/goalgorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/goalgorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goalgorilla/subscriptions","organizations_url":"https://api.github.com/users/goalgorilla/orgs","repos_url":"https://api.github.com/users/goalgorilla/repos","events_url":"https://api.github.com/users/goalgorilla/events{/privacy}","received_events_url":"https://api.github.com/users/goalgorilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/goalgorilla/open_social","description":"Open Social install profile Drupal 8","fork":false,"url":"https://api.github.com/repos/goalgorilla/open_social","forks_url":"https://api.github.com/repos/goalgorilla/open_social/forks","keys_url":"https://api.github.com/repos/goalgorilla/open_social/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goalgorilla/open_social/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goalgorilla/open_social/teams","hooks_url":"https://api.github.com/repos/goalgorilla/open_social/hooks","issue_events_url":"https://api.github.com/repos/goalgorilla/open_social/issues/events{/number}","events_url":"https://api.github.com/repos/goalgorilla/open_social/events","assignees_url":"https://api.github.com/repos/goalgorilla/open_social/assignees{/user}","branches_url":"https://api.github.com/repos/goalgorilla/open_social/branches{/branch}","tags_url":"https://api.github.com/repos/goalgorilla/open_social/tags","blobs_url":"https://api.github.com/repos/goalgorilla/open_social/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goalgorilla/open_social/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goalgorilla/open_social/git/refs{/sha}","trees_url":"https://api.github.com/repos/goalgorilla/open_social/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goalgorilla/open_social/statuses/{sha}","languages_url":"https://api.github.com/repos/goalgorilla/open_social/languages","stargazers_url":"https://api.github.com/repos/goalgorilla/open_social/stargazers","contributors_url":"https://api.github.com/repos/goalgorilla/open_social/contributors","subscribers_url":"https://api.github.com/repos/goalgorilla/open_social/subscribers","subscription_url":"https://api.github.com/repos/goalgorilla/open_social/subscription","commits_url":"https://api.github.com/repos/goalgorilla/open_social/commits{/sha}","git_commits_url":"https://api.github.com/repos/goalgorilla/open_social/git/commits{/sha}","comments_url":"https://api.github.com/repos/goalgorilla/open_social/comments{/number}","issue_comment_url":"https://api.github.com/repos/goalgorilla/open_social/issues/comments{/number}","contents_url":"https://api.github.com/repos/goalgorilla/open_social/contents/{+path}","compare_url":"https://api.github.com/repos/goalgorilla/open_social/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goalgorilla/open_social/merges","archive_url":"https://api.github.com/repos/goalgorilla/open_social/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goalgorilla/open_social/downloads","issues_url":"https://api.github.com/repos/goalgorilla/open_social/issues{/number}","pulls_url":"https://api.github.com/repos/goalgorilla/open_social/pulls{/number}","milestones_url":"https://api.github.com/repos/goalgorilla/open_social/milestones{/number}","notifications_url":"https://api.github.com/repos/goalgorilla/open_social/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goalgorilla/open_social/labels{/name}","releases_url":"https://api.github.com/repos/goalgorilla/open_social/releases{/id}","deployments_url":"https://api.github.com/repos/goalgorilla/open_social/deployments","created_at":"2016-07-19T12:56:46Z","updated_at":"2018-11-26T08:11:14Z","pushed_at":"2018-11-26T09:54:08Z","git_url":"git://github.com/goalgorilla/open_social.git","ssh_url":"git@github.com:goalgorilla/open_social.git","clone_url":"https://github.com/goalgorilla/open_social.git","svn_url":"https://github.com/goalgorilla/open_social","homepage":"http://www.getopensocial.com","size":129908,"stargazers_count":69,"watchers_count":69,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":71,"open_issues":37,"watchers":69,"default_branch":"8.x-3.x"}},"base":{"label":"goalgorilla:8.x-3.x","ref":"8.x-3.x","sha":"afc42ad192d9fc1ae98ab8c0e7889e1ca74807cc","user":{"login":"goalgorilla","id":16816975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/16816975?v=4","gravatar_id":"","url":"https://api.github.com/users/goalgorilla","html_url":"https://github.com/goalgorilla","followers_url":"https://api.github.com/users/goalgorilla/followers","following_url":"https://api.github.com/users/goalgorilla/following{/other_user}","gists_url":"https://api.github.com/users/goalgorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/goalgorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goalgorilla/subscriptions","organizations_url":"https://api.github.com/users/goalgorilla/orgs","repos_url":"https://api.github.com/users/goalgorilla/repos","events_url":"https://api.github.com/users/goalgorilla/events{/privacy}","received_events_url":"https://api.github.com/users/goalgorilla/received_events","type":"Organization","site_admin":false},"repo":{"id":63693909,"node_id":"MDEwOlJlcG9zaXRvcnk2MzY5MzkwOQ==","name":"open_social","full_name":"goalgorilla/open_social","private":false,"owner":{"login":"goalgorilla","id":16816975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/16816975?v=4","gravatar_id":"","url":"https://api.github.com/users/goalgorilla","html_url":"https://github.com/goalgorilla","followers_url":"https://api.github.com/users/goalgorilla/followers","following_url":"https://api.github.com/users/goalgorilla/following{/other_user}","gists_url":"https://api.github.com/users/goalgorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/goalgorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goalgorilla/subscriptions","organizations_url":"https://api.github.com/users/goalgorilla/orgs","repos_url":"https://api.github.com/users/goalgorilla/repos","events_url":"https://api.github.com/users/goalgorilla/events{/privacy}","received_events_url":"https://api.github.com/users/goalgorilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/goalgorilla/open_social","description":"Open Social install profile Drupal 8","fork":false,"url":"https://api.github.com/repos/goalgorilla/open_social","forks_url":"https://api.github.com/repos/goalgorilla/open_social/forks","keys_url":"https://api.github.com/repos/goalgorilla/open_social/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goalgorilla/open_social/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goalgorilla/open_social/teams","hooks_url":"https://api.github.com/repos/goalgorilla/open_social/hooks","issue_events_url":"https://api.github.com/repos/goalgorilla/open_social/issues/events{/number}","events_url":"https://api.github.com/repos/goalgorilla/open_social/events","assignees_url":"https://api.github.com/repos/goalgorilla/open_social/assignees{/user}","branches_url":"https://api.github.com/repos/goalgorilla/open_social/branches{/branch}","tags_url":"https://api.github.com/repos/goalgorilla/open_social/tags","blobs_url":"https://api.github.com/repos/goalgorilla/open_social/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goalgorilla/open_social/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goalgorilla/open_social/git/refs{/sha}","trees_url":"https://api.github.com/repos/goalgorilla/open_social/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goalgorilla/open_social/statuses/{sha}","languages_url":"https://api.github.com/repos/goalgorilla/open_social/languages","stargazers_url":"https://api.github.com/repos/goalgorilla/open_social/stargazers","contributors_url":"https://api.github.com/repos/goalgorilla/open_social/contributors","subscribers_url":"https://api.github.com/repos/goalgorilla/open_social/subscribers","subscription_url":"https://api.github.com/repos/goalgorilla/open_social/subscription","commits_url":"https://api.github.com/repos/goalgorilla/open_social/commits{/sha}","git_commits_url":"https://api.github.com/repos/goalgorilla/open_social/git/commits{/sha}","comments_url":"https://api.github.com/repos/goalgorilla/open_social/comments{/number}","issue_comment_url":"https://api.github.com/repos/goalgorilla/open_social/issues/comments{/number}","contents_url":"https://api.github.com/repos/goalgorilla/open_social/contents/{+path}","compare_url":"https://api.github.com/repos/goalgorilla/open_social/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goalgorilla/open_social/merges","archive_url":"https://api.github.com/repos/goalgorilla/open_social/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goalgorilla/open_social/downloads","issues_url":"https://api.github.com/repos/goalgorilla/open_social/issues{/number}","pulls_url":"https://api.github.com/repos/goalgorilla/open_social/pulls{/number}","milestones_url":"https://api.github.com/repos/goalgorilla/open_social/milestones{/number}","notifications_url":"https://api.github.com/repos/goalgorilla/open_social/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goalgorilla/open_social/labels{/name}","releases_url":"https://api.github.com/repos/goalgorilla/open_social/releases{/id}","deployments_url":"https://api.github.com/repos/goalgorilla/open_social/deployments","created_at":"2016-07-19T12:56:46Z","updated_at":"2018-11-26T08:11:14Z","pushed_at":"2018-11-26T09:54:08Z","git_url":"git://github.com/goalgorilla/open_social.git","ssh_url":"git@github.com:goalgorilla/open_social.git","clone_url":"https://github.com/goalgorilla/open_social.git","svn_url":"https://github.com/goalgorilla/open_social","homepage":"http://www.getopensocial.com","size":129908,"stargazers_count":69,"watchers_count":69,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":71,"open_issues":37,"watchers":69,"default_branch":"8.x-3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131"},"html":{"href":"https://github.com/goalgorilla/open_social/pull/1131"},"issue":{"href":"https://api.github.com/repos/goalgorilla/open_social/issues/1131"},"comments":{"href":"https://api.github.com/repos/goalgorilla/open_social/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/goalgorilla/open_social/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goalgorilla/open_social/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/goalgorilla/open_social/statuses/289bb2f5023a293e54cb93d5d1e48b00576ce3dd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jaapjan","id":2848293,"node_id":"MDQ6VXNlcjI4NDgyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2848293?v=4","gravatar_id":"","url":"https://api.github.com/users/jaapjan","html_url":"https://github.com/jaapjan","followers_url":"https://api.github.com/users/jaapjan/followers","following_url":"https://api.github.com/users/jaapjan/following{/other_user}","gists_url":"https://api.github.com/users/jaapjan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapjan/subscriptions","organizations_url":"https://api.github.com/users/jaapjan/orgs","repos_url":"https://api.github.com/users/jaapjan/repos","events_url":"https://api.github.com/users/jaapjan/events{/privacy}","received_events_url":"https://api.github.com/users/jaapjan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"jaapjan"}}