{"action":"created","comment":{"url":"https://api.github.com/repos/dedis/cothority/pulls/comments/227726469","pull_request_review_id":167811263,"id":227726469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzcyNjQ2OQ==","diff_hunk":"@@ -0,0 +1,165 @@\n+package trie\n+\n+import (\n+\t\"crypto/sha256\"\n+\t\"encoding/binary\"\n+\t\"errors\"\n+\t\"hash\"\n+\n+\t\"github.com/dedis/protobuf\"\n+)\n+\n+type nodeType int\n+\n+const (\n+\ttypeInterior nodeType = iota\n+\ttypeEmpty\n+\ttypeLeaf\n+)\n+\n+func (ty nodeType) toBytes() []byte {\n+\tswitch ty {\n+\tcase typeInterior:\n+\t\treturn []byte{0}\n+\tcase typeEmpty:\n+\t\treturn []byte{1}\n+\tcase typeLeaf:\n+\t\treturn []byte{2}\n+\tdefault:\n+\t\tpanic(\"no such type\")\n+\t}\n+}\n+\n+type interiorNode struct {\n+\tLeft  []byte\n+\tRight []byte\n+}\n+\n+func (n *interiorNode) hash() []byte {\n+\th := sha256.New()","path":"byzcoin/trie/node.go","position":39,"original_position":39,"commit_id":"ed2190f8c4a26275f910417dda95450dcc778192","original_commit_id":"ed2190f8c4a26275f910417dda95450dcc778192","user":{"login":"ineiti","id":1545067,"node_id":"MDQ6VXNlcjE1NDUwNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"body":"Why does this hash not include the `typeInteriorNode`?","created_at":"2018-10-24T10:11:12Z","updated_at":"2018-10-24T10:17:09Z","html_url":"https://github.com/dedis/cothority/pull/1534#discussion_r227726469","pull_request_url":"https://api.github.com/repos/dedis/cothority/pulls/1534","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dedis/cothority/pulls/comments/227726469"},"html":{"href":"https://github.com/dedis/cothority/pull/1534#discussion_r227726469"},"pull_request":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1534"}}},"pull_request":{"url":"https://api.github.com/repos/dedis/cothority/pulls/1534","id":224014175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDE0MTc1","html_url":"https://github.com/dedis/cothority/pull/1534","diff_url":"https://github.com/dedis/cothority/pull/1534.diff","patch_url":"https://github.com/dedis/cothority/pull/1534.patch","issue_url":"https://api.github.com/repos/dedis/cothority/issues/1534","number":1534,"state":"open","locked":false,"title":"Implementation of the coniks trie","user":{"login":"kc1212","id":1093806,"node_id":"MDQ6VXNlcjEwOTM4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1093806?v=4","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"body":"This is an implementation of the Merkle Prefix Tree from CONIKS. Which will eventually replace the collections library.","created_at":"2018-10-18T16:05:58Z","updated_at":"2018-10-24T10:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a51a3b9ed7ca44261736927f22a631f1e54cb410","assignee":{"login":"kc1212","id":1093806,"node_id":"MDQ6VXNlcjEwOTM4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1093806?v=4","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"assignees":[{"login":"kc1212","id":1093806,"node_id":"MDQ6VXNlcjEwOTM4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1093806?v=4","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jeffallen","id":1131456,"node_id":"MDQ6VXNlcjExMzE0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1131456?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffallen","html_url":"https://github.com/jeffallen","followers_url":"https://api.github.com/users/jeffallen/followers","following_url":"https://api.github.com/users/jeffallen/following{/other_user}","gists_url":"https://api.github.com/users/jeffallen/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffallen/subscriptions","organizations_url":"https://api.github.com/users/jeffallen/orgs","repos_url":"https://api.github.com/users/jeffallen/repos","events_url":"https://api.github.com/users/jeffallen/events{/privacy}","received_events_url":"https://api.github.com/users/jeffallen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dedis/cothority/pulls/1534/commits","review_comments_url":"https://api.github.com/repos/dedis/cothority/pulls/1534/comments","review_comment_url":"https://api.github.com/repos/dedis/cothority/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dedis/cothority/issues/1534/comments","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/ed2190f8c4a26275f910417dda95450dcc778192","head":{"label":"dedis:trie","ref":"trie","sha":"ed2190f8c4a26275f910417dda95450dcc778192","user":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc5MTY4NA==","name":"cothority","full_name":"dedis/cothority","private":false,"owner":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dedis/cothority","description":"Scalable collective authority","fork":false,"url":"https://api.github.com/repos/dedis/cothority","forks_url":"https://api.github.com/repos/dedis/cothority/forks","keys_url":"https://api.github.com/repos/dedis/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/cothority/teams","hooks_url":"https://api.github.com/repos/dedis/cothority/hooks","issue_events_url":"https://api.github.com/repos/dedis/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/cothority/events","assignees_url":"https://api.github.com/repos/dedis/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/cothority/tags","blobs_url":"https://api.github.com/repos/dedis/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/cothority/languages","stargazers_url":"https://api.github.com/repos/dedis/cothority/stargazers","contributors_url":"https://api.github.com/repos/dedis/cothority/contributors","subscribers_url":"https://api.github.com/repos/dedis/cothority/subscribers","subscription_url":"https://api.github.com/repos/dedis/cothority/subscription","commits_url":"https://api.github.com/repos/dedis/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/cothority/merges","archive_url":"https://api.github.com/repos/dedis/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/cothority/downloads","issues_url":"https://api.github.com/repos/dedis/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/cothority/labels{/name}","releases_url":"https://api.github.com/repos/dedis/cothority/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/cothority/deployments","created_at":"2015-09-02T09:13:57Z","updated_at":"2018-10-24T09:33:44Z","pushed_at":"2018-10-24T09:54:28Z","git_url":"git://github.com/dedis/cothority.git","ssh_url":"git@github.com:dedis/cothority.git","clone_url":"https://github.com/dedis/cothority.git","svn_url":"https://github.com/dedis/cothority","homepage":"","size":84431,"stargazers_count":264,"watchers_count":264,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":101,"watchers":264,"default_branch":"master"}},"base":{"label":"dedis:master","ref":"master","sha":"e6035c14ab06ae434524ed0897be4c53cacce88e","user":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc5MTY4NA==","name":"cothority","full_name":"dedis/cothority","private":false,"owner":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dedis/cothority","description":"Scalable collective authority","fork":false,"url":"https://api.github.com/repos/dedis/cothority","forks_url":"https://api.github.com/repos/dedis/cothority/forks","keys_url":"https://api.github.com/repos/dedis/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/cothority/teams","hooks_url":"https://api.github.com/repos/dedis/cothority/hooks","issue_events_url":"https://api.github.com/repos/dedis/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/cothority/events","assignees_url":"https://api.github.com/repos/dedis/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/cothority/tags","blobs_url":"https://api.github.com/repos/dedis/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/cothority/languages","stargazers_url":"https://api.github.com/repos/dedis/cothority/stargazers","contributors_url":"https://api.github.com/repos/dedis/cothority/contributors","subscribers_url":"https://api.github.com/repos/dedis/cothority/subscribers","subscription_url":"https://api.github.com/repos/dedis/cothority/subscription","commits_url":"https://api.github.com/repos/dedis/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/cothority/merges","archive_url":"https://api.github.com/repos/dedis/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/cothority/downloads","issues_url":"https://api.github.com/repos/dedis/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/cothority/labels{/name}","releases_url":"https://api.github.com/repos/dedis/cothority/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/cothority/deployments","created_at":"2015-09-02T09:13:57Z","updated_at":"2018-10-24T09:33:44Z","pushed_at":"2018-10-24T09:54:28Z","git_url":"git://github.com/dedis/cothority.git","ssh_url":"git@github.com:dedis/cothority.git","clone_url":"https://github.com/dedis/cothority.git","svn_url":"https://github.com/dedis/cothority","homepage":"","size":84431,"stargazers_count":264,"watchers_count":264,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":101,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1534"},"html":{"href":"https://github.com/dedis/cothority/pull/1534"},"issue":{"href":"https://api.github.com/repos/dedis/cothority/issues/1534"},"comments":{"href":"https://api.github.com/repos/dedis/cothority/issues/1534/comments"},"review_comments":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1534/comments"},"review_comment":{"href":"https://api.github.com/repos/dedis/cothority/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1534/commits"},"statuses":{"href":"https://api.github.com/repos/dedis/cothority/statuses/ed2190f8c4a26275f910417dda95450dcc778192"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ineiti"}}