{"action":"opened","number":4730,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/4730","id":170990905,"html_url":"https://github.com/snapcore/snapd/pull/4730","diff_url":"https://github.com/snapcore/snapd/pull/4730.diff","patch_url":"https://github.com/snapcore/snapd/pull/4730.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/4730","number":4730,"state":"open","locked":false,"title":"userd/tests: Test kdialog calls and mock kdialog too to make tests work in KDE","user":{"login":"stolowski","id":168604,"avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"body":"On KDE we invoke the real kdialog because it wasn't mocked and the tests fail.\r\nThis PR fixes it and also makes the test check both kdialog and zenity code paths.","created_at":"2018-02-23T11:18:35Z","updated_at":"2018-02-23T11:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/4730/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/4730/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/4730/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/24834b6382cb45d9301848f006aea7f9593a013b","head":{"label":"stolowski:mock-kdialog","ref":"mock-kdialog","sha":"24834b6382cb45d9301848f006aea7f9593a013b","user":{"login":"stolowski","id":168604,"avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"repo":{"id":66472850,"name":"snapd","full_name":"stolowski/snapd","owner":{"login":"stolowski","id":168604,"avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stolowski/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/stolowski/snapd","forks_url":"https://api.github.com/repos/stolowski/snapd/forks","keys_url":"https://api.github.com/repos/stolowski/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stolowski/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stolowski/snapd/teams","hooks_url":"https://api.github.com/repos/stolowski/snapd/hooks","issue_events_url":"https://api.github.com/repos/stolowski/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/stolowski/snapd/events","assignees_url":"https://api.github.com/repos/stolowski/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/stolowski/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/stolowski/snapd/tags","blobs_url":"https://api.github.com/repos/stolowski/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stolowski/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stolowski/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stolowski/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stolowski/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/stolowski/snapd/languages","stargazers_url":"https://api.github.com/repos/stolowski/snapd/stargazers","contributors_url":"https://api.github.com/repos/stolowski/snapd/contributors","subscribers_url":"https://api.github.com/repos/stolowski/snapd/subscribers","subscription_url":"https://api.github.com/repos/stolowski/snapd/subscription","commits_url":"https://api.github.com/repos/stolowski/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stolowski/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stolowski/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stolowski/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stolowski/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/stolowski/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stolowski/snapd/merges","archive_url":"https://api.github.com/repos/stolowski/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stolowski/snapd/downloads","issues_url":"https://api.github.com/repos/stolowski/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/stolowski/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/stolowski/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/stolowski/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stolowski/snapd/labels{/name}","releases_url":"https://api.github.com/repos/stolowski/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/stolowski/snapd/deployments","created_at":"2016-08-24T14:50:18Z","updated_at":"2016-08-24T14:50:21Z","pushed_at":"2018-02-23T11:16:02Z","git_url":"git://github.com/stolowski/snapd.git","ssh_url":"git@github.com:stolowski/snapd.git","clone_url":"https://github.com/stolowski/snapd.git","svn_url":"https://github.com/stolowski/snapd","homepage":"","size":60503,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"a07f493cf34d4a19c49e31a5a48f1498d388ac9b","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-02-23T02:07:32Z","pushed_at":"2018-02-23T10:21:33Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":59588,"stargazers_count":889,"watchers_count":889,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":223,"open_issues":43,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4730"},"html":{"href":"https://github.com/snapcore/snapd/pull/4730"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4730"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4730/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4730/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4730/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/24834b6382cb45d9301848f006aea7f9593a013b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":84,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"stolowski"}}