{"action":"created","comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/177027911","pull_request_review_id":106828165,"id":177027911,"diff_hunk":"@@ -0,0 +1,94 @@\n+#include \"PileupClusterMergeTool.h\"\n+\n+#include \"podio/EventStore.h\"\n+\n+#include \"datamodel/CaloClusterCollection.h\"\n+#include \"datamodel/TrackClusterCollection.h\"\n+\n+typedef PileupClusterMergeTool<fcc::CaloClusterCollection> PileupCaloClusterMergeTool;\n+typedef PileupClusterMergeTool<fcc::TrackClusterCollection> PileupTrackClusterMergeTool;\n+DECLARE_TOOL_FACTORY(PileupTrackClusterMergeTool)\n+DECLARE_COMPONENT_WITH_ID(PileupTrackClusterMergeTool, \"PileupTrackClusterMergeTool\")\n+DECLARE_TOOL_FACTORY(PileupCaloClusterMergeTool)\n+DECLARE_COMPONENT_WITH_ID(PileupCaloClusterMergeTool, \"PileupCaloClusterMergeTool\")\n+\n+template <class Clusters>\n+PileupClusterMergeTool<Clusters>::PileupClusterMergeTool(const std::string& aType, const std::string& aName,\n+                                                             const IInterface* aParent)\n+    : GaudiTool(aType, aName, aParent) {\n+  declareInterface<IEDMMergeTool>(this);\n+  declareProperty(\"signalClusters\", m_hitsSignal);\n+  declareProperty(\"mergedClusters\", m_hitsMerged);\n+}\n+\n+template <class Clusters>\n+StatusCode PileupClusterMergeTool<Clusters>::initialize() {\n+  return StatusCode::SUCCESS;\n+}\n+\n+template <class Clusters>\n+StatusCode PileupClusterMergeTool<Clusters>::finalize() {\n+  return StatusCode::SUCCESS;\n+}\n+\n+template <class Clusters>\n+StatusCode PileupClusterMergeTool<Clusters>::readPileupCollection(podio::EventStore& store) {\n+  // local pointers, to be filled by the event store\n+  const Clusters* hitCollection;\n+\n+  // get collection address and store it in container\n+  bool hitCollectionPresent = store.get(m_pileupClustersBranchName, hitCollection);","path":"FWCore/src/components/PileupClusterMergeTool.cpp","position":40,"original_position":40,"commit_id":"0ae91e114bd9d0788ee83ca885de7183dc2fabeb","original_commit_id":"0ae91e114bd9d0788ee83ca885de7183dc2fabeb","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars1.githubusercontent.com/u/5057884?v=4","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"body":"The variable names are out of sync with the code from copying, I think","created_at":"2018-03-26T09:25:53Z","updated_at":"2018-03-26T09:41:36Z","html_url":"https://github.com/HEP-FCC/FCCSW/pull/301#discussion_r177027911","pull_request_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/177027911"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/301#discussion_r177027911"},"pull_request":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301","id":175528814,"html_url":"https://github.com/HEP-FCC/FCCSW/pull/301","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/301.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/301.patch","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/301","number":301,"state":"open","locked":false,"title":"[WIP] Adding cluster and hit collection merge tool","user":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"body":"\r\nChanges proposed in this pull-request:\r\n\r\n- PileupHitMergeTool accepting also only one HitCollection\r\n- PileupClusterMergeTool to merge ClusterCollections\r\n\r\nTo be done:\r\n\r\n- debug tests","created_at":"2018-03-16T13:11:39Z","updated_at":"2018-03-26T09:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca483ac214af2dea9e23f67eb0b50cb193049e89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301/commits","review_comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301/comments","review_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/301/comments","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/0ae91e114bd9d0788ee83ca885de7183dc2fabeb","head":{"label":"CoralieNeubueser:pileupTool","ref":"pileupTool","sha":"0ae91e114bd9d0788ee83ca885de7183dc2fabeb","user":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"repo":{"id":75837937,"name":"FCCSW","full_name":"CoralieNeubueser/FCCSW","owner":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CoralieNeubueser/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":true,"url":"https://api.github.com/repos/CoralieNeubueser/FCCSW","forks_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/forks","keys_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/teams","hooks_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/events","assignees_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/tags","blobs_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/languages","stargazers_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/subscription","commits_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/merges","archive_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/downloads","issues_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/deployments","created_at":"2016-12-07T13:21:20Z","updated_at":"2018-03-16T09:40:59Z","pushed_at":"2018-03-22T15:12:40Z","git_url":"git://github.com/CoralieNeubueser/FCCSW.git","ssh_url":"git@github.com:CoralieNeubueser/FCCSW.git","clone_url":"https://github.com/CoralieNeubueser/FCCSW.git","svn_url":"https://github.com/CoralieNeubueser/FCCSW","homepage":"http://fccsw.web.cern.ch","size":176573,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HEP-FCC:master","ref":"master","sha":"2c39fce349681217f6771081085be6e500c317b6","user":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars0.githubusercontent.com/u/8003187?v=4","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"repo":{"id":21388221,"name":"FCCSW","full_name":"HEP-FCC/FCCSW","owner":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars0.githubusercontent.com/u/8003187?v=4","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HEP-FCC/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":false,"url":"https://api.github.com/repos/HEP-FCC/FCCSW","forks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/forks","keys_url":"https://api.github.com/repos/HEP-FCC/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HEP-FCC/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HEP-FCC/FCCSW/teams","hooks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/events","assignees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/HEP-FCC/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/tags","blobs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/HEP-FCC/FCCSW/languages","stargazers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscription","commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/HEP-FCC/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HEP-FCC/FCCSW/merges","archive_url":"https://api.github.com/repos/HEP-FCC/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HEP-FCC/FCCSW/downloads","issues_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/HEP-FCC/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/HEP-FCC/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/deployments","created_at":"2014-07-01T13:16:22Z","updated_at":"2018-03-20T08:49:44Z","pushed_at":"2018-03-23T16:26:38Z","git_url":"git://github.com/HEP-FCC/FCCSW.git","ssh_url":"git@github.com:HEP-FCC/FCCSW.git","clone_url":"https://github.com/HEP-FCC/FCCSW.git","svn_url":"https://github.com/HEP-FCC/FCCSW","homepage":"http://fccsw.web.cern.ch","size":176019,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":82,"open_issues":31,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/301"},"issue":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/301"},"comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/0ae91e114bd9d0788ee83ca885de7183dc2fabeb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vvolkl"}}