{"push_id":2471805300,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"7927745b4e1cea28941b41d1feac47aa5fea7db6","before":"a50e00bb5e5fd3cdb5d0832718b8b154a611f888","commits":[{"sha":"7927745b4e1cea28941b41d1feac47aa5fea7db6","author":{"name":"Jonathan Peppers","email":"bada9c05996b779e3b1d99a9591d4bfcbe6ff4f4@gmail.com"},"message":"[Aapt] fix original file name in error message (#1530)\n\nContext: https://github.com/xamarin/xamarin-android/pull/1490\r\n\r\nSince aee709d, the `ReportAaptErrorsInOriginalFileName` test has been\r\nfailing on Windows.\r\n\r\nLooking into it, there really was a problem. The error message was\r\nreporting the path as `\\layout\\main.xml`, which will not map back to\r\nfile within the user's project in an IDE.\r\n\r\nIt appears the change of the use of a `WorkingDirectory` caused the\r\nfollowing:\r\n- `file` starts out as a full path such as\r\n`C:\\Users\\myuser\\Desktop\\Git\\xamarin-android\\bin\\TestDebug\\temp\\ErroneousResource\\obj\\Debug\\res\\layout\\main.xml`\r\n- `resourceDirectory` is a full path such as\r\n`C:\\Users\\myuser\\Desktop\\Git\\xamarin-android\\bin\\TestDebug\\temp\\ErroneousResource\\obj\\Debug\\res`\r\n- After the `Substring` the result is `\\layout\\main.xml`, so we need to\r\ntrim the leading `\\` in order to locate the original file name from\r\n`resource_name_case_map`\r\n\r\nI am not sure how this test would pass on other platforms, but this\r\nwas definitely failing on Windows.","distinct":true,"url":"https://api.github.com/repos/xamarin/xamarin-android/commits/7927745b4e1cea28941b41d1feac47aa5fea7db6"}]}
{"actor":{"display_login":"grendello"}}