{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/16888","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/16888/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/16888/comments","events_url":"https://api.github.com/repos/atom/atom/issues/16888/events","html_url":"https://github.com/atom/atom/issues/16888","id":302501091,"number":16888,"title":"Atom/Core URL handler support for Markdown inside Datatip","user":{"login":"BoykoAlex","id":6433390,"avatar_url":"https://avatars1.githubusercontent.com/u/6433390?v=4","gravatar_id":"","url":"https://api.github.com/users/BoykoAlex","html_url":"https://github.com/BoykoAlex","followers_url":"https://api.github.com/users/BoykoAlex/followers","following_url":"https://api.github.com/users/BoykoAlex/following{/other_user}","gists_url":"https://api.github.com/users/BoykoAlex/gists{/gist_id}","starred_url":"https://api.github.com/users/BoykoAlex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoykoAlex/subscriptions","organizations_url":"https://api.github.com/users/BoykoAlex/orgs","repos_url":"https://api.github.com/users/BoykoAlex/repos","events_url":"https://api.github.com/users/BoykoAlex/events{/privacy}","received_events_url":"https://api.github.com/users/BoykoAlex/received_events","type":"User","site_admin":false},"labels":[{"id":505038679,"url":"https://api.github.com/repos/atom/atom/labels/triaged","name":"triaged","color":"00bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-05T23:11:48Z","updated_at":"2018-03-12T16:59:48Z","closed_at":null,"author_association":"NONE","body":"<!--\r\n\r\nHave you read Atom's Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/atom/atom/blob/master/CODE_OF_CONDUCT.md\r\n\r\nDo you want to ask a question? Are you looking for support? The Atom message board is the best place for getting support: https://discuss.atom.io\r\n\r\n-->\r\n\r\n### Prerequisites\r\n\r\n [ X]   * Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode\r\n [ X]   * Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/\r\n[ X]    * Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq\r\n[ X]    * Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom\r\n[ X]    * Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages\r\n\r\n### Description\r\n\r\nMD preview and MD datatips (hovers) don't support `atom/core` URL handlers from #15935. Would be useful if I want to provide source code links inside the datatip (hover)\r\n\r\n### Steps to Reproduce\r\n\r\n1. Create an MD file with a link similar to `[This is a link](atom://core/open/file?filename=<path to file>)`\r\n2. Open MD preview\r\n3. Click on the link - nothing happens. At the same time if one switches the URL to `http://www.bbc.com` the link would work\r\n\r\n**Expected behavior:**\r\nThe file specified by its path open in Atom text editor\r\n\r\n**Actual behavior:**\r\nCore URLs not supported\r\n\r\n**Reproduces how often:**\r\n100%\r\n\r\n### Versions\r\nAll verions up to 1.25-beta2\r\n\r\n### Additional Details\r\nLooking for directions... What to look at if I am to provide a patch for this"},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/372384184","html_url":"https://github.com/atom/atom/issues/16888#issuecomment-372384184","issue_url":"https://api.github.com/repos/atom/atom/issues/16888","id":372384184,"user":{"login":"UziTech","id":97994,"avatar_url":"https://avatars3.githubusercontent.com/u/97994?v=4","gravatar_id":"","url":"https://api.github.com/users/UziTech","html_url":"https://github.com/UziTech","followers_url":"https://api.github.com/users/UziTech/followers","following_url":"https://api.github.com/users/UziTech/following{/other_user}","gists_url":"https://api.github.com/users/UziTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UziTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UziTech/subscriptions","organizations_url":"https://api.github.com/users/UziTech/orgs","repos_url":"https://api.github.com/users/UziTech/repos","events_url":"https://api.github.com/users/UziTech/events{/privacy}","received_events_url":"https://api.github.com/users/UziTech/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T16:59:48Z","updated_at":"2018-03-12T16:59:48Z","author_association":"CONTRIBUTOR","body":"You are correct. It does seem to work with [hyperlink-hyperclick](https://atom.io/packages/hyperlink-hyperclick).\r\n\r\nAfter a bit of research it looks like the \"Open link\" explicitly only works with http/https links https://github.com/atom/link/blob/add8170e69c84e1ea438e22b6a023a32f6582eaf/lib/link.js#L28\r\n\r\nAnd markdown-preview doesn't seem to work with anything other than http or https (I tried `mailto://`) It seems atom would have to register the other protocols with [electron.protocol.registerHttpProtocol](https://github.com/electron/electron/blob/master/docs/api/protocol.md#protocolregisterhttpprotocolscheme-handler-completion) to allow links to open with those protocols."}}
{"actor":{"display_login":"UziTech"}}