{"action":"created","comment":{"url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/comments/218717483","pull_request_review_id":156713381,"id":218717483,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODcxNzQ4Mw==","diff_hunk":"@@ -77,3 +77,5 @@ export type TAcceptedFileType =\n   | \"image/svg+xml\"\n   | \"image/*\";\n // TODO: Correct TAcceptedFileType types it can contain more than one type\n+\n+export type Omit<T extends K, K> = Pick<T, Exclude<keyof T, keyof K>>;","path":"app/types.d.ts","position":5,"original_position":5,"commit_id":"c6d46b064af52c51bd8331375186f28df97b6847","original_commit_id":"c6d46b064af52c51bd8331375186f28df97b6847","user":{"login":"desfero","id":7031578,"node_id":"MDQ6VXNlcjcwMzE1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7031578?v=4","gravatar_id":"","url":"https://api.github.com/users/desfero","html_url":"https://github.com/desfero","followers_url":"https://api.github.com/users/desfero/followers","following_url":"https://api.github.com/users/desfero/following{/other_user}","gists_url":"https://api.github.com/users/desfero/gists{/gist_id}","starred_url":"https://api.github.com/users/desfero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desfero/subscriptions","organizations_url":"https://api.github.com/users/desfero/orgs","repos_url":"https://api.github.com/users/desfero/repos","events_url":"https://api.github.com/users/desfero/events{/privacy}","received_events_url":"https://api.github.com/users/desfero/received_events","type":"User","site_admin":false},"body":"It's a helper type that typescript didn't provide. \r\n```\r\ninterface Base {\r\n  onClick: () => {}\r\n}\r\n\r\ninterface Derived extends Base {\r\n  isLoading: boolean;\r\n}\r\n\r\ntype WithoutOnClick = Omit<Derived, Base>;\r\n// WithoutOnClick === { isLoading: boolean }\r\n\r\n```\r\nUsed to get rid of `onClick` inside ButtonLink as `OnClick` there is provided by component","created_at":"2018-09-19T08:44:40Z","updated_at":"2018-09-19T08:44:40Z","html_url":"https://github.com/Neufund/platform-frontend/pull/1374#discussion_r218717483","pull_request_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/comments/218717483"},"html":{"href":"https://github.com/Neufund/platform-frontend/pull/1374#discussion_r218717483"},"pull_request":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374"}},"in_reply_to_id":218715707},"pull_request":{"url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374","id":216384558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Mzg0NTU4","html_url":"https://github.com/Neufund/platform-frontend/pull/1374","diff_url":"https://github.com/Neufund/platform-frontend/pull/1374.diff","patch_url":"https://github.com/Neufund/platform-frontend/pull/1374.patch","issue_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/1374","number":1374,"state":"open","locked":false,"title":"#1342 Do not wrap router links in 'a' tag","user":{"login":"desfero","id":7031578,"node_id":"MDQ6VXNlcjcwMzE1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7031578?v=4","gravatar_id":"","url":"https://api.github.com/users/desfero","html_url":"https://github.com/desfero","followers_url":"https://api.github.com/users/desfero/followers","following_url":"https://api.github.com/users/desfero/following{/other_user}","gists_url":"https://api.github.com/users/desfero/gists{/gist_id}","starred_url":"https://api.github.com/users/desfero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desfero/subscriptions","organizations_url":"https://api.github.com/users/desfero/orgs","repos_url":"https://api.github.com/users/desfero/repos","events_url":"https://api.github.com/users/desfero/events{/privacy}","received_events_url":"https://api.github.com/users/desfero/received_events","type":"User","site_admin":false},"body":"#1342 \r\n\r\n@Moejoe90 @lizonp there are tons of import changes.\r\n\r\nThe main changes are:\r\n- New `ButtonLink` component that replaces all `<Link><Button/></Link>`.\r\n- `Buttons.tsx` are moved to the `buttons` folder with `ButtonLink` to have consistency with `forms` folder. ","created_at":"2018-09-18T17:24:31Z","updated_at":"2018-09-19T08:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94305586e0b879041ae5223d511247a82ece3007","assignee":{"login":"desfero","id":7031578,"node_id":"MDQ6VXNlcjcwMzE1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7031578?v=4","gravatar_id":"","url":"https://api.github.com/users/desfero","html_url":"https://github.com/desfero","followers_url":"https://api.github.com/users/desfero/followers","following_url":"https://api.github.com/users/desfero/following{/other_user}","gists_url":"https://api.github.com/users/desfero/gists{/gist_id}","starred_url":"https://api.github.com/users/desfero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desfero/subscriptions","organizations_url":"https://api.github.com/users/desfero/orgs","repos_url":"https://api.github.com/users/desfero/repos","events_url":"https://api.github.com/users/desfero/events{/privacy}","received_events_url":"https://api.github.com/users/desfero/received_events","type":"User","site_admin":false},"assignees":[{"login":"desfero","id":7031578,"node_id":"MDQ6VXNlcjcwMzE1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7031578?v=4","gravatar_id":"","url":"https://api.github.com/users/desfero","html_url":"https://github.com/desfero","followers_url":"https://api.github.com/users/desfero/followers","following_url":"https://api.github.com/users/desfero/following{/other_user}","gists_url":"https://api.github.com/users/desfero/gists{/gist_id}","starred_url":"https://api.github.com/users/desfero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desfero/subscriptions","organizations_url":"https://api.github.com/users/desfero/orgs","repos_url":"https://api.github.com/users/desfero/repos","events_url":"https://api.github.com/users/desfero/events{/privacy}","received_events_url":"https://api.github.com/users/desfero/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374/commits","review_comments_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374/comments","review_comment_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/1374/comments","statuses_url":"https://api.github.com/repos/Neufund/platform-frontend/statuses/c6d46b064af52c51bd8331375186f28df97b6847","head":{"label":"Neufund:plula/#1342-button-link-component","ref":"plula/#1342-button-link-component","sha":"c6d46b064af52c51bd8331375186f28df97b6847","user":{"login":"Neufund","id":25393169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzkzMTY5","avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"repo":{"id":116978635,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5Nzg2MzU=","name":"platform-frontend","full_name":"Neufund/platform-frontend","private":false,"owner":{"login":"Neufund","id":25393169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzkzMTY5","avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Neufund/platform-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/Neufund/platform-frontend","forks_url":"https://api.github.com/repos/Neufund/platform-frontend/forks","keys_url":"https://api.github.com/repos/Neufund/platform-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neufund/platform-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neufund/platform-frontend/teams","hooks_url":"https://api.github.com/repos/Neufund/platform-frontend/hooks","issue_events_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Neufund/platform-frontend/events","assignees_url":"https://api.github.com/repos/Neufund/platform-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Neufund/platform-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Neufund/platform-frontend/tags","blobs_url":"https://api.github.com/repos/Neufund/platform-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neufund/platform-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neufund/platform-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neufund/platform-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neufund/platform-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Neufund/platform-frontend/languages","stargazers_url":"https://api.github.com/repos/Neufund/platform-frontend/stargazers","contributors_url":"https://api.github.com/repos/Neufund/platform-frontend/contributors","subscribers_url":"https://api.github.com/repos/Neufund/platform-frontend/subscribers","subscription_url":"https://api.github.com/repos/Neufund/platform-frontend/subscription","commits_url":"https://api.github.com/repos/Neufund/platform-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neufund/platform-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neufund/platform-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neufund/platform-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Neufund/platform-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neufund/platform-frontend/merges","archive_url":"https://api.github.com/repos/Neufund/platform-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neufund/platform-frontend/downloads","issues_url":"https://api.github.com/repos/Neufund/platform-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Neufund/platform-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Neufund/platform-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neufund/platform-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Neufund/platform-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Neufund/platform-frontend/deployments","created_at":"2018-01-10T15:57:08Z","updated_at":"2018-09-18T18:49:18Z","pushed_at":"2018-09-18T17:24:31Z","git_url":"git://github.com/Neufund/platform-frontend.git","ssh_url":"git@github.com:Neufund/platform-frontend.git","clone_url":"https://github.com/Neufund/platform-frontend.git","svn_url":"https://github.com/Neufund/platform-frontend","homepage":"https://platform.neufund.org/","size":80575,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":111,"watchers":1,"default_branch":"master"}},"base":{"label":"Neufund:master","ref":"master","sha":"aa5ada02a59f17253dd20d9220e7e4c18f52a1e5","user":{"login":"Neufund","id":25393169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzkzMTY5","avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"repo":{"id":116978635,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5Nzg2MzU=","name":"platform-frontend","full_name":"Neufund/platform-frontend","private":false,"owner":{"login":"Neufund","id":25393169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzkzMTY5","avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Neufund/platform-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/Neufund/platform-frontend","forks_url":"https://api.github.com/repos/Neufund/platform-frontend/forks","keys_url":"https://api.github.com/repos/Neufund/platform-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neufund/platform-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neufund/platform-frontend/teams","hooks_url":"https://api.github.com/repos/Neufund/platform-frontend/hooks","issue_events_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Neufund/platform-frontend/events","assignees_url":"https://api.github.com/repos/Neufund/platform-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Neufund/platform-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Neufund/platform-frontend/tags","blobs_url":"https://api.github.com/repos/Neufund/platform-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neufund/platform-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neufund/platform-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neufund/platform-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neufund/platform-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Neufund/platform-frontend/languages","stargazers_url":"https://api.github.com/repos/Neufund/platform-frontend/stargazers","contributors_url":"https://api.github.com/repos/Neufund/platform-frontend/contributors","subscribers_url":"https://api.github.com/repos/Neufund/platform-frontend/subscribers","subscription_url":"https://api.github.com/repos/Neufund/platform-frontend/subscription","commits_url":"https://api.github.com/repos/Neufund/platform-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neufund/platform-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neufund/platform-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neufund/platform-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neufund/platform-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Neufund/platform-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neufund/platform-frontend/merges","archive_url":"https://api.github.com/repos/Neufund/platform-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neufund/platform-frontend/downloads","issues_url":"https://api.github.com/repos/Neufund/platform-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Neufund/platform-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Neufund/platform-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Neufund/platform-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neufund/platform-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Neufund/platform-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Neufund/platform-frontend/deployments","created_at":"2018-01-10T15:57:08Z","updated_at":"2018-09-18T18:49:18Z","pushed_at":"2018-09-18T17:24:31Z","git_url":"git://github.com/Neufund/platform-frontend.git","ssh_url":"git@github.com:Neufund/platform-frontend.git","clone_url":"https://github.com/Neufund/platform-frontend.git","svn_url":"https://github.com/Neufund/platform-frontend","homepage":"https://platform.neufund.org/","size":80575,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":111,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374"},"html":{"href":"https://github.com/Neufund/platform-frontend/pull/1374"},"issue":{"href":"https://api.github.com/repos/Neufund/platform-frontend/issues/1374"},"comments":{"href":"https://api.github.com/repos/Neufund/platform-frontend/issues/1374/comments"},"review_comments":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374/comments"},"review_comment":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neufund/platform-frontend/pulls/1374/commits"},"statuses":{"href":"https://api.github.com/repos/Neufund/platform-frontend/statuses/c6d46b064af52c51bd8331375186f28df97b6847"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"desfero"}}