{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4766","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4766/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4766/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4766/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4766","id":299126444,"number":4766,"title":"Fixes parameter inconsistency in IFieldWrapper (Fixes #4325)","user":{"login":"thilokru","id":11823052,"avatar_url":"https://avatars1.githubusercontent.com/u/11823052?v=4","gravatar_id":"","url":"https://api.github.com/users/thilokru","html_url":"https://github.com/thilokru","followers_url":"https://api.github.com/users/thilokru/followers","following_url":"https://api.github.com/users/thilokru/following{/other_user}","gists_url":"https://api.github.com/users/thilokru/gists{/gist_id}","starred_url":"https://api.github.com/users/thilokru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilokru/subscriptions","organizations_url":"https://api.github.com/users/thilokru/orgs","repos_url":"https://api.github.com/users/thilokru/repos","events_url":"https://api.github.com/users/thilokru/events{/privacy}","received_events_url":"https://api.github.com/users/thilokru/received_events","type":"User","site_admin":false},"labels":[{"id":507309489,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/1.12","name":"1.12","color":"c5def5","default":false},{"id":305387937,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Bug","name":"Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-21T20:59:25Z","updated_at":"2018-02-24T14:49:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4766","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4766","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4766.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4766.patch"},"body":"As described in Issue #4325, the interface IFieldWrapper wasn't clear about what the method parameters ment. This caused issues with the MapWrapper, because it disagreed with ConfigManager about what should be in the parameter name.\r\n\r\nThis PR fixes the parameter naming inconsistency by renaming it to `key` (which also fixes the collision with the field `name`).\r\nTo prevent similar problems in the future, `IFieldWrapper` and `ITypeAdapter` were documented.\r\nAlso, `ConfigManager::sync` now has more detailed comments to allow other developers to easier understand the code (I had trouble reading my own code...)"},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/368233352","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4766#issuecomment-368233352","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4766","id":368233352,"user":{"login":"thilokru","id":11823052,"avatar_url":"https://avatars1.githubusercontent.com/u/11823052?v=4","gravatar_id":"","url":"https://api.github.com/users/thilokru","html_url":"https://github.com/thilokru","followers_url":"https://api.github.com/users/thilokru/followers","following_url":"https://api.github.com/users/thilokru/following{/other_user}","gists_url":"https://api.github.com/users/thilokru/gists{/gist_id}","starred_url":"https://api.github.com/users/thilokru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilokru/subscriptions","organizations_url":"https://api.github.com/users/thilokru/orgs","repos_url":"https://api.github.com/users/thilokru/repos","events_url":"https://api.github.com/users/thilokru/events{/privacy}","received_events_url":"https://api.github.com/users/thilokru/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T14:49:31Z","updated_at":"2018-02-24T14:49:31Z","author_association":"CONTRIBUTOR","body":"Are you sure, that the way you use `@Mod.EventBusSubscriber` is correct? What you are describing sounds an awefull lot like `ConfigManager::sync` isn't been called when required. Maybe your event listener isn't working?"}}
{"actor":{"display_login":"thilokru"}}