{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/242323446","pull_request_review_id":185807387,"id":242323446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMyMzQ0Ng==","diff_hunk":"@@ -47,7 +50,6 @@ apiVersion: rbac.authorization.k8s.io/v1beta1\n kind: ClusterRoleBinding\n metadata:\n   name: cdi-sa\n-  namespace: {{.CDINamespace}}","path":"manifests/testing/cdi-v1.4.1.yaml.in","position":14,"original_position":14,"commit_id":"c5ef3cb5d92b4f2fc773f488884fe6cb7f23dcd8","original_commit_id":"c5ef3cb5d92b4f2fc773f488884fe6cb7f23dcd8","user":{"login":"davidvossel","id":683713,"node_id":"MDQ6VXNlcjY4MzcxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/683713?v=4","gravatar_id":"","url":"https://api.github.com/users/davidvossel","html_url":"https://github.com/davidvossel","followers_url":"https://api.github.com/users/davidvossel/followers","following_url":"https://api.github.com/users/davidvossel/following{/other_user}","gists_url":"https://api.github.com/users/davidvossel/gists{/gist_id}","starred_url":"https://api.github.com/users/davidvossel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidvossel/subscriptions","organizations_url":"https://api.github.com/users/davidvossel/orgs","repos_url":"https://api.github.com/users/davidvossel/repos","events_url":"https://api.github.com/users/davidvossel/events{/privacy}","received_events_url":"https://api.github.com/users/davidvossel/received_events","type":"User","site_admin":false},"body":"should this be removed?","created_at":"2018-12-17T21:31:26Z","updated_at":"2018-12-17T21:33:44Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1819#discussion_r242323446","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/242323446"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1819#discussion_r242323446"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819","id":236796085,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Nzk2MDg1","html_url":"https://github.com/kubevirt/kubevirt/pull/1819","diff_url":"https://github.com/kubevirt/kubevirt/pull/1819.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1819.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1819","number":1819,"state":"open","locked":false,"title":"Vendor in CDI 1.4.1","user":{"login":"dylanzr","id":2229630,"node_id":"MDQ6VXNlcjIyMjk2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2229630?v=4","gravatar_id":"","url":"https://api.github.com/users/dylanzr","html_url":"https://github.com/dylanzr","followers_url":"https://api.github.com/users/dylanzr/followers","following_url":"https://api.github.com/users/dylanzr/following{/other_user}","gists_url":"https://api.github.com/users/dylanzr/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanzr/subscriptions","organizations_url":"https://api.github.com/users/dylanzr/orgs","repos_url":"https://api.github.com/users/dylanzr/repos","events_url":"https://api.github.com/users/dylanzr/events{/privacy}","received_events_url":"https://api.github.com/users/dylanzr/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nUpdates CDI and testing manifest. Verified that DataVolumeTemplates now support blank volumes.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-12-07T09:00:57Z","updated_at":"2018-12-17T21:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0602a97c3be8e9774cd045e3a6cdf842a24937d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":971140815,"node_id":"MDU6TGFiZWw5NzExNDA4MTU=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":971140814,"node_id":"MDU6TGFiZWw5NzExNDA4MTQ=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1819/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/c5ef3cb5d92b4f2fc773f488884fe6cb7f23dcd8","head":{"label":"stackpath:cdi-1.4.1","ref":"cdi-1.4.1","sha":"c5ef3cb5d92b4f2fc773f488884fe6cb7f23dcd8","user":{"login":"stackpath","id":16548414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTQ4NDE0","avatar_url":"https://avatars3.githubusercontent.com/u/16548414?v=4","gravatar_id":"","url":"https://api.github.com/users/stackpath","html_url":"https://github.com/stackpath","followers_url":"https://api.github.com/users/stackpath/followers","following_url":"https://api.github.com/users/stackpath/following{/other_user}","gists_url":"https://api.github.com/users/stackpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stackpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackpath/subscriptions","organizations_url":"https://api.github.com/users/stackpath/orgs","repos_url":"https://api.github.com/users/stackpath/repos","events_url":"https://api.github.com/users/stackpath/events{/privacy}","received_events_url":"https://api.github.com/users/stackpath/received_events","type":"Organization","site_admin":false},"repo":{"id":160402877,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDI4Nzc=","name":"kubevirt","full_name":"stackpath/kubevirt","private":false,"owner":{"login":"stackpath","id":16548414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTQ4NDE0","avatar_url":"https://avatars3.githubusercontent.com/u/16548414?v=4","gravatar_id":"","url":"https://api.github.com/users/stackpath","html_url":"https://github.com/stackpath","followers_url":"https://api.github.com/users/stackpath/followers","following_url":"https://api.github.com/users/stackpath/following{/other_user}","gists_url":"https://api.github.com/users/stackpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stackpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackpath/subscriptions","organizations_url":"https://api.github.com/users/stackpath/orgs","repos_url":"https://api.github.com/users/stackpath/repos","events_url":"https://api.github.com/users/stackpath/events{/privacy}","received_events_url":"https://api.github.com/users/stackpath/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stackpath/kubevirt","description":"Kubernetes Virtualization API and runtime in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/stackpath/kubevirt","forks_url":"https://api.github.com/repos/stackpath/kubevirt/forks","keys_url":"https://api.github.com/repos/stackpath/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackpath/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackpath/kubevirt/teams","hooks_url":"https://api.github.com/repos/stackpath/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/stackpath/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/stackpath/kubevirt/events","assignees_url":"https://api.github.com/repos/stackpath/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/stackpath/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/stackpath/kubevirt/tags","blobs_url":"https://api.github.com/repos/stackpath/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackpath/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackpath/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackpath/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackpath/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/stackpath/kubevirt/languages","stargazers_url":"https://api.github.com/repos/stackpath/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/stackpath/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/stackpath/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/stackpath/kubevirt/subscription","commits_url":"https://api.github.com/repos/stackpath/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackpath/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackpath/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackpath/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/stackpath/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/stackpath/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackpath/kubevirt/merges","archive_url":"https://api.github.com/repos/stackpath/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackpath/kubevirt/downloads","issues_url":"https://api.github.com/repos/stackpath/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/stackpath/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/stackpath/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/stackpath/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackpath/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/stackpath/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/stackpath/kubevirt/deployments","created_at":"2018-12-04T18:41:04Z","updated_at":"2018-12-15T17:47:36Z","pushed_at":"2018-12-17T20:49:16Z","git_url":"git://github.com/stackpath/kubevirt.git","ssh_url":"git@github.com:stackpath/kubevirt.git","clone_url":"https://github.com/stackpath/kubevirt.git","svn_url":"https://github.com/stackpath/kubevirt","homepage":"https://kubevirt.io","size":117924,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"ba61019514707956f5f601bda39c93280a458200","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-12-17T09:13:49Z","pushed_at":"2018-12-17T20:49:18Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"https://kubevirt.io","size":117235,"stargazers_count":1013,"watchers_count":1013,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":219,"open_issues":149,"watchers":1013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1819"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1819"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1819/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1819/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/c5ef3cb5d92b4f2fc773f488884fe6cb7f23dcd8"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidvossel"}}