{"action":"created","issue":{"url":"https://api.github.com/repos/elfmz/far2l/issues/418","repository_url":"https://api.github.com/repos/elfmz/far2l","labels_url":"https://api.github.com/repos/elfmz/far2l/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/elfmz/far2l/issues/418/comments","events_url":"https://api.github.com/repos/elfmz/far2l/issues/418/events","html_url":"https://github.com/elfmz/far2l/issues/418","id":378279577,"node_id":"MDU6SXNzdWUzNzgyNzk1Nzc=","number":418,"title":"Type missuse?","user":{"login":"svost","id":6769910,"node_id":"MDQ6VXNlcjY3Njk5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/6769910?v=4","gravatar_id":"","url":"https://api.github.com/users/svost","html_url":"https://github.com/svost","followers_url":"https://api.github.com/users/svost/followers","following_url":"https://api.github.com/users/svost/following{/other_user}","gists_url":"https://api.github.com/users/svost/gists{/gist_id}","starred_url":"https://api.github.com/users/svost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svost/subscriptions","organizations_url":"https://api.github.com/users/svost/orgs","repos_url":"https://api.github.com/users/svost/repos","events_url":"https://api.github.com/users/svost/events{/privacy}","received_events_url":"https://api.github.com/users/svost/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-07T13:06:33Z","updated_at":"2018-11-11T18:48:43Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Может ssize_t или просто int? Т.к. есть вызов к примеру `\tUnregMacroFunction(-1);`\r\nКат взят из https://github.com/elfmz/far2l/blob/master/far2l/macro.cpp#L5564\r\n`bool KeyMacro::UnregMacroFunction(size_t Index)\r\n{\r\nif (Index < 0)`\r\n\r\nТут тоже, но не так критично https://github.com/elfmz/far2l/blob/master/WinPort/src/APITime.cpp#L114 uint < 0\r\n\r\nА вот это непонятно\r\nhttps://github.com/elfmz/far2l/blob/master/far2l/vtlog.cpp#L141\r\ng++ уверен что тут uint с нулём сравнивают...\r\nХотя на момент компиляции и вправду даёт выражение if ((0u - 1) < 0)"},"comment":{"url":"https://api.github.com/repos/elfmz/far2l/issues/comments/437694418","html_url":"https://github.com/elfmz/far2l/issues/418#issuecomment-437694418","issue_url":"https://api.github.com/repos/elfmz/far2l/issues/418","id":437694418,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzY5NDQxOA==","user":{"login":"svost","id":6769910,"node_id":"MDQ6VXNlcjY3Njk5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/6769910?v=4","gravatar_id":"","url":"https://api.github.com/users/svost","html_url":"https://github.com/svost","followers_url":"https://api.github.com/users/svost/followers","following_url":"https://api.github.com/users/svost/following{/other_user}","gists_url":"https://api.github.com/users/svost/gists{/gist_id}","starred_url":"https://api.github.com/users/svost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svost/subscriptions","organizations_url":"https://api.github.com/users/svost/orgs","repos_url":"https://api.github.com/users/svost/repos","events_url":"https://api.github.com/users/svost/events{/privacy}","received_events_url":"https://api.github.com/users/svost/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T18:48:43Z","updated_at":"2018-11-11T18:48:43Z","author_association":"CONTRIBUTOR","body":"Anyway, thanks for the reply. PS what about do cherry-pick to master branch those commits?\r\nhttps://github.com/3dflat/far2l/commit/8a8680e536d4cea9be9d5ec062533270b78f7dfb\r\nhttps://github.com/krzysgol/far2l/commit/2d735e1375b1ae7b13099946882cd1efefcafb9f"}}
{"actor":{"display_login":"svost"}}