{"action":"created","comment":{"url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments/232081283","pull_request_review_id":173198395,"id":232081283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA4MTI4Mw==","diff_hunk":"@@ -109,7 +110,19 @@ class MySqlZoneRepositoryIntegrationSpec\n \n   \"MySqlZoneRepository\" should {\n     \"return the zone when it is saved\" in {\n-      repo.save(okZone).unsafeRunSync() shouldBe okZone\n+      repo.save(okZone).unsafeRunSync() shouldBe Right(okZone)\n+    }\n+\n+    \"return the updated zone when it is saved with a new name\" in {\n+      repo.save(okZone).unsafeRunSync() shouldBe Right(okZone)\n+      val newZone = okZone.copy(name = \"newname.\")\n+      repo.save(newZone).unsafeRunSync() shouldBe Right(newZone)","path":"modules/mysql/src/it/scala/vinyldns/mysql/repository/MySqlZoneRepositoryIntegrationSpec.scala","position":19,"original_position":19,"commit_id":"9bde934e6cf487c788abee2a2a4f7154cf299b0e","original_commit_id":"9bde934e6cf487c788abee2a2a4f7154cf299b0e","user":{"login":"pauljamescleary","id":17361753,"node_id":"MDQ6VXNlcjE3MzYxNzUz","avatar_url":"https://avatars2.githubusercontent.com/u/17361753?v=4","gravatar_id":"","url":"https://api.github.com/users/pauljamescleary","html_url":"https://github.com/pauljamescleary","followers_url":"https://api.github.com/users/pauljamescleary/followers","following_url":"https://api.github.com/users/pauljamescleary/following{/other_user}","gists_url":"https://api.github.com/users/pauljamescleary/gists{/gist_id}","starred_url":"https://api.github.com/users/pauljamescleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauljamescleary/subscriptions","organizations_url":"https://api.github.com/users/pauljamescleary/orgs","repos_url":"https://api.github.com/users/pauljamescleary/repos","events_url":"https://api.github.com/users/pauljamescleary/events{/privacy}","received_events_url":"https://api.github.com/users/pauljamescleary/received_events","type":"User","site_admin":false},"body":"Do a `getZoneByName` and `getZone(id)` after this save of `newZone`\r\n\r\nVerify that the results of both calls `shouldBe newZone`\r\n\r\n We want to verify that we did not change the id.  That would be really bad.  It is probably a good idea to just check\r\n\r\n`val retrievedZone.id shouldBe okZone.id` just to be 100%","created_at":"2018-11-08T22:16:56Z","updated_at":"2018-11-08T22:18:23Z","html_url":"https://github.com/vinyldns/vinyldns/pull/331#discussion_r232081283","pull_request_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments/232081283"},"html":{"href":"https://github.com/vinyldns/vinyldns/pull/331#discussion_r232081283"},"pull_request":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331","id":228851482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODUxNDgy","html_url":"https://github.com/vinyldns/vinyldns/pull/331","diff_url":"https://github.com/vinyldns/vinyldns/pull/331.diff","patch_url":"https://github.com/vinyldns/vinyldns/pull/331.patch","issue_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/331","number":331,"state":"open","locked":false,"title":"Prevent duplicate zone creations","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"body":"Fixes #310.\r\n\r\nChanges in this pull request:\r\n- Handle duplicate zones in `MySqlZoneRepository` and `ZoneChangeHandler` only\r\n","created_at":"2018-11-06T22:09:38Z","updated_at":"2018-11-08T22:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"386ac865dd8e3bf4489e84431ed766790965098b","assignee":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"assignees":[{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331/commits","review_comments_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331/comments","review_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/331/comments","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/9bde934e6cf487c788abee2a2a4f7154cf299b0e","head":{"label":"britneywright:mysql-repo-zone-save","ref":"mysql-repo-zone-save","sha":"9bde934e6cf487c788abee2a2a4f7154cf299b0e","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"repo":{"id":142593271,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1OTMyNzE=","name":"vinyldns","full_name":"britneywright/vinyldns","private":false,"owner":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"html_url":"https://github.com/britneywright/vinyldns","description":"Vendor agnostic DNS front-end for managing DNS self-service across your systems.","fork":true,"url":"https://api.github.com/repos/britneywright/vinyldns","forks_url":"https://api.github.com/repos/britneywright/vinyldns/forks","keys_url":"https://api.github.com/repos/britneywright/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/britneywright/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/britneywright/vinyldns/teams","hooks_url":"https://api.github.com/repos/britneywright/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/britneywright/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/britneywright/vinyldns/events","assignees_url":"https://api.github.com/repos/britneywright/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/britneywright/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/britneywright/vinyldns/tags","blobs_url":"https://api.github.com/repos/britneywright/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/britneywright/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/britneywright/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/britneywright/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/britneywright/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/britneywright/vinyldns/languages","stargazers_url":"https://api.github.com/repos/britneywright/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/britneywright/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/britneywright/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/britneywright/vinyldns/subscription","commits_url":"https://api.github.com/repos/britneywright/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/britneywright/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/britneywright/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/britneywright/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/britneywright/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/britneywright/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/britneywright/vinyldns/merges","archive_url":"https://api.github.com/repos/britneywright/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/britneywright/vinyldns/downloads","issues_url":"https://api.github.com/repos/britneywright/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/britneywright/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/britneywright/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/britneywright/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/britneywright/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/britneywright/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/britneywright/vinyldns/deployments","created_at":"2018-07-27T15:18:39Z","updated_at":"2018-11-02T14:33:47Z","pushed_at":"2018-11-08T17:03:22Z","git_url":"git://github.com/britneywright/vinyldns.git","ssh_url":"git@github.com:britneywright/vinyldns.git","clone_url":"https://github.com/britneywright/vinyldns.git","svn_url":"https://github.com/britneywright/vinyldns","homepage":"","size":8840,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vinyldns:master","ref":"master","sha":"069d8468fe04497a24279f54211b4cf456371c54","user":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"repo":{"id":142474323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NzQzMjM=","name":"vinyldns","full_name":"vinyldns/vinyldns","private":false,"owner":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vinyldns/vinyldns","description":"Vendor agnostic DNS front-end for streamlining DNS operations and enabling self-service for your DNS infrastructure","fork":false,"url":"https://api.github.com/repos/vinyldns/vinyldns","forks_url":"https://api.github.com/repos/vinyldns/vinyldns/forks","keys_url":"https://api.github.com/repos/vinyldns/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinyldns/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinyldns/vinyldns/teams","hooks_url":"https://api.github.com/repos/vinyldns/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/vinyldns/vinyldns/events","assignees_url":"https://api.github.com/repos/vinyldns/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/vinyldns/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/vinyldns/vinyldns/tags","blobs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinyldns/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinyldns/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/vinyldns/vinyldns/languages","stargazers_url":"https://api.github.com/repos/vinyldns/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/vinyldns/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/vinyldns/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/vinyldns/vinyldns/subscription","commits_url":"https://api.github.com/repos/vinyldns/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinyldns/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinyldns/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/vinyldns/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinyldns/vinyldns/merges","archive_url":"https://api.github.com/repos/vinyldns/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinyldns/vinyldns/downloads","issues_url":"https://api.github.com/repos/vinyldns/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/vinyldns/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/vinyldns/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinyldns/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/vinyldns/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/vinyldns/vinyldns/deployments","created_at":"2018-07-26T17:43:18Z","updated_at":"2018-11-08T15:40:36Z","pushed_at":"2018-11-08T21:49:13Z","git_url":"git://github.com/vinyldns/vinyldns.git","ssh_url":"git@github.com:vinyldns/vinyldns.git","clone_url":"https://github.com/vinyldns/vinyldns.git","svn_url":"https://github.com/vinyldns/vinyldns","homepage":"http://vinyldns.io/","size":9907,"stargazers_count":121,"watchers_count":121,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":64,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331"},"html":{"href":"https://github.com/vinyldns/vinyldns/pull/331"},"issue":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/331"},"comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/vinyldns/vinyldns/statuses/9bde934e6cf487c788abee2a2a4f7154cf299b0e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pauljamescleary"}}