{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/300","repository_url":"https://api.github.com/repos/Islandora/islandora_scholar","labels_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/300/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/300/comments","events_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/300/events","html_url":"https://github.com/Islandora/islandora_scholar/pull/300","id":349817741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODI0NDQw","number":300,"title":"Work on ISLANDORA-2278 - Remove Islandora Scholar as a .info dependen…","user":{"login":"mjordan","id":403918,"node_id":"MDQ6VXNlcjQwMzkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/403918?v=4","gravatar_id":"","url":"https://api.github.com/users/mjordan","html_url":"https://github.com/mjordan","followers_url":"https://api.github.com/users/mjordan/followers","following_url":"https://api.github.com/users/mjordan/following{/other_user}","gists_url":"https://api.github.com/users/mjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjordan/subscriptions","organizations_url":"https://api.github.com/users/mjordan/orgs","repos_url":"https://api.github.com/users/mjordan/repos","events_url":"https://api.github.com/users/mjordan/events{/privacy}","received_events_url":"https://api.github.com/users/mjordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-08-12T14:40:59Z","updated_at":"2018-10-18T21:39:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/300","html_url":"https://github.com/Islandora/islandora_scholar/pull/300","diff_url":"https://github.com/Islandora/islandora_scholar/pull/300.diff","patch_url":"https://github.com/Islandora/islandora_scholar/pull/300.patch"},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-2278\r\n\r\n# What does this Pull Request do?\r\n\r\nRemoves Islandora Scholar as a .info dependency from Scholar Embargo\r\n\r\n# What's new?\r\n\r\nThis PR removes `dependencies[] = islandora_scholar` from islandora_scholar_embargo.info, allowing site admins to not have to run the full scholar suite to use the Scholar Embargo module. Islandora Scholar must remain installed, but it and the other members of that group need not be enabled to use Scholar Embargo.\r\n\r\nIt also updates Scholar Embargo's README to indicate that the main Scholar module is no longer an hard dependency.\r\n\r\n# How should this be tested?\r\n\r\n1. enable a content model that can have embargos, other than Citation and Thesis, at admin/islandora/tools/embargo\r\n1. on an object of the newly added content model, set an embargo, e.g. using tomorrow's date\r\n1. in a private browser window, visit the object. You should get an Access denied message.\r\n1. check out the [7.x-ISLANDORA-2278 branch](https://github.com/mjordan/islandora_scholar/tree/7.x-ISLANDORA-2278).\r\n1. disable the Islandora Scholar group of modules by running `drush dis -y islandora_scholar`. \"islandora_scholar_embargo\" will not be in the list of modules disabled.\r\n1. check Scholar Embargo's list of embargoed objects at `admin/islandora/tools/embargo/list`. Your test object should be in this list.\r\n1. revisit your test object. You should still get the Access denied message.\r\n\r\n\r\n# Additional Notes:\r\n\r\n* Does this change require documentation to be updated?\r\n\r\nYes, https://wiki.duraspace.org/display/ISLANDORA/Islandora+Scholar#IslandoraScholar-ScholarEmbargo.\r\n\r\n* Does this change add any new dependencies? \r\n\r\nNo.\r\n\r\n* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? \r\n\r\nNo.\r\n\r\n* Could this change impact execution of existing code?\r\n\r\nNo, it should not.\r\n\r\n# Interested parties\r\nTagging @bryjbrown.\r\n"},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/comments/431173316","html_url":"https://github.com/Islandora/islandora_scholar/pull/300#issuecomment-431173316","issue_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/300","id":431173316,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTE3MzMxNg==","user":{"login":"mjordan","id":403918,"node_id":"MDQ6VXNlcjQwMzkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/403918?v=4","gravatar_id":"","url":"https://api.github.com/users/mjordan","html_url":"https://github.com/mjordan","followers_url":"https://api.github.com/users/mjordan/followers","following_url":"https://api.github.com/users/mjordan/following{/other_user}","gists_url":"https://api.github.com/users/mjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjordan/subscriptions","organizations_url":"https://api.github.com/users/mjordan/orgs","repos_url":"https://api.github.com/users/mjordan/repos","events_url":"https://api.github.com/users/mjordan/events{/privacy}","received_events_url":"https://api.github.com/users/mjordan/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T21:39:46Z","updated_at":"2018-10-18T21:39:46Z","author_association":"CONTRIBUTOR","body":"OK, I've added logic to check to see if Scholar is enabled and populated the defaults accordingly. Revised testing instructions:\r\n\r\n1. Check out this branch.\r\n1. Make sure Islandora Scholar is enabled. The defaults at `admin/islandora/tools/embargo` should be the same as they are in the 7.x branch.\r\n1. Disable Islandora Scholar: `drush en -y islandora_scholar`\r\n1. Refresh `admin/islandora/tools/embargo`. No content models should be selected in the list.\r\n1. Re-enable Scholar: `drush en -y islandora_scholar`.\r\n1. Refresh `admin/islandora/tools/embargo`. Thesis and Citation cmodels should be the defaults again."}}
{"actor":{"display_login":"mjordan"}}