{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/628","repository_url":"https://api.github.com/repos/hyperledger/iroha","labels_url":"https://api.github.com/repos/hyperledger/iroha/issues/628/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/628/comments","events_url":"https://api.github.com/repos/hyperledger/iroha/issues/628/events","html_url":"https://github.com/hyperledger/iroha/issues/628","id":265326457,"number":628,"title":"Improve check of signatures subset in stateful validator","user":{"login":"neewy","id":11841667,"avatar_url":"https://avatars2.githubusercontent.com/u/11841667?v=4","gravatar_id":"","url":"https://api.github.com/users/neewy","html_url":"https://github.com/neewy","followers_url":"https://api.github.com/users/neewy/followers","following_url":"https://api.github.com/users/neewy/following{/other_user}","gists_url":"https://api.github.com/users/neewy/gists{/gist_id}","starred_url":"https://api.github.com/users/neewy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neewy/subscriptions","organizations_url":"https://api.github.com/users/neewy/orgs","repos_url":"https://api.github.com/users/neewy/repos","events_url":"https://api.github.com/users/neewy/events{/privacy}","received_events_url":"https://api.github.com/users/neewy/received_events","type":"User","site_admin":false},"labels":[{"id":777722170,"url":"https://api.github.com/repos/hyperledger/iroha/labels/compl:moderate","name":"compl:moderate","color":"fbea61","default":false},{"id":771100025,"url":"https://api.github.com/repos/hyperledger/iroha/labels/enhancement","name":"enhancement","color":"1d76db","default":true},{"id":717709999,"url":"https://api.github.com/repos/hyperledger/iroha/labels/good-first-issue","name":"good-first-issue","color":"7365ce","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-13T15:20:02Z","updated_at":"2018-03-17T07:28:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently set inclusion is verified in non-effective way. This is a good start for a newcomer to contribute to the code:\r\n\r\nhttps://github.com/hyperledger/iroha/blob/5fd84ec8191ceaf69bd49991ffdcbb4f1fb0440d/irohad/validation/impl/stateful_validator_impl.cpp#L74"},"comment":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/comments/373900784","html_url":"https://github.com/hyperledger/iroha/issues/628#issuecomment-373900784","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/628","id":373900784,"user":{"login":"darsh7807","id":14910889,"avatar_url":"https://avatars3.githubusercontent.com/u/14910889?v=4","gravatar_id":"","url":"https://api.github.com/users/darsh7807","html_url":"https://github.com/darsh7807","followers_url":"https://api.github.com/users/darsh7807/followers","following_url":"https://api.github.com/users/darsh7807/following{/other_user}","gists_url":"https://api.github.com/users/darsh7807/gists{/gist_id}","starred_url":"https://api.github.com/users/darsh7807/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darsh7807/subscriptions","organizations_url":"https://api.github.com/users/darsh7807/orgs","repos_url":"https://api.github.com/users/darsh7807/repos","events_url":"https://api.github.com/users/darsh7807/events{/privacy}","received_events_url":"https://api.github.com/users/darsh7807/received_events","type":"User","site_admin":false},"created_at":"2018-03-17T07:28:14Z","updated_at":"2018-03-17T07:28:14Z","author_association":"NONE","body":"\r\n```\r\nstd::map<pubkey_t,bool>map_keys;\r\nfor (auto sign : signatures) {\r\n        map_keys[sign.pubkey] = True;\r\n  }\r\nfor (auto pubkey : public_keys) {\r\n       if(map_keys[pubkey] == False) return False;\r\n      }\r\nreturn True;\r\n```\r\nIs this approach acceptable?"}}
{"actor":{"display_login":"darsh7807"}}