{"action":"created","issue":{"url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/105","repository_url":"https://api.github.com/repos/kaikramer/keystore-explorer","labels_url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/105/comments","events_url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/105/events","html_url":"https://github.com/kaikramer/keystore-explorer/pull/105","id":266296045,"number":105,"title":"Adding CRL Distribution Points extension attribute","user":{"login":"davydsantos","id":10036407,"avatar_url":"https://avatars2.githubusercontent.com/u/10036407?v=4","gravatar_id":"","url":"https://api.github.com/users/davydsantos","html_url":"https://github.com/davydsantos","followers_url":"https://api.github.com/users/davydsantos/followers","following_url":"https://api.github.com/users/davydsantos/following{/other_user}","gists_url":"https://api.github.com/users/davydsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/davydsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydsantos/subscriptions","organizations_url":"https://api.github.com/users/davydsantos/orgs","repos_url":"https://api.github.com/users/davydsantos/repos","events_url":"https://api.github.com/users/davydsantos/events{/privacy}","received_events_url":"https://api.github.com/users/davydsantos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-17T22:10:23Z","updated_at":"2018-04-07T18:04:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kaikramer/keystore-explorer/pulls/105","html_url":"https://github.com/kaikramer/keystore-explorer/pull/105","diff_url":"https://github.com/kaikramer/keystore-explorer/pull/105.diff","patch_url":"https://github.com/kaikramer/keystore-explorer/pull/105.patch"},"body":"Relevent comments about this PR:\r\n- I tried to extract some common behavior into super classes in a way that it could be reused by other classes;\r\n- I found a couple of LayoutManagers used (Mig, GridBag and Box) but I couldn't tell which one was the standard/better option so I used tried to follow the standard;\r\n- I added no unit tests, given that most of the logic is embedded into the GUI classes; If you want to start using it and move the extension creation into service classes I'd be happy to add the change + tests;\r\n- The resources were added **only** in the default file (en);"},"comment":{"url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/comments/379488109","html_url":"https://github.com/kaikramer/keystore-explorer/pull/105#issuecomment-379488109","issue_url":"https://api.github.com/repos/kaikramer/keystore-explorer/issues/105","id":379488109,"user":{"login":"kaikramer","id":7840192,"avatar_url":"https://avatars0.githubusercontent.com/u/7840192?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikramer","html_url":"https://github.com/kaikramer","followers_url":"https://api.github.com/users/kaikramer/followers","following_url":"https://api.github.com/users/kaikramer/following{/other_user}","gists_url":"https://api.github.com/users/kaikramer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikramer/subscriptions","organizations_url":"https://api.github.com/users/kaikramer/orgs","repos_url":"https://api.github.com/users/kaikramer/repos","events_url":"https://api.github.com/users/kaikramer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikramer/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T18:04:08Z","updated_at":"2018-04-07T18:04:08Z","author_association":"OWNER","body":"Do you still want to complete this feature? Otherwise I'll close this PR."}}
{"actor":{"display_login":"kaikramer"}}