{"action":"created","comment":{"url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/comments/196142845","pull_request_review_id":129639743,"id":196142845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE0Mjg0NQ==","diff_hunk":"@@ -10,16 +10,26 @@ yum -y install rpm-ostree selinux-policy-targeted rpm-build \\\n     rsync pygobject3-base python3-gobject-base \\\n     createrepo_c dnf-utils\n \n+# Gather RPMs before we ran builddep\n+rpm -qa --queryformat='%{NAME}\\n' | sort -u > /root/rpms.txt\n+dnf builddep -y rpm-ostree\n+git clone https://github.com/projectatomic/rpm-ostree\n+cd rpm-ostree\n+# Note --enable-rust\n+./autogen.sh --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc --enable-rust\n+make -j 8\n+make install\n+cd ..\n+rm rpm-ostree -rf\n+rpm -qa --queryformat='%{NAME}\\n' |sort -u > /root/rpms-new.txt\n+# Yeah this is a pretty awesome hack; now we remove the BuildRequires\n+comm -1 -3 /root/rpms{,-new}.txt | xargs yum -y remove\n+\n mkdir -p /usr/app/\n cd /usr/app/\n git clone https://github.com/ostreedev/ostree-releng-scripts\n \n-cd /root/src\n-ls -al\n-make build PREFIX=/usr/bin\n-cargo build --release\n-mv target/release/coreos-assembler /usr/bin\n-cd /\n+mv /root/src/coreos-assembler.sh /usr/bin","path":"build.sh","position":29,"original_position":29,"commit_id":"81af152194e9042b5f7321e37e66161c19cb5dd0","original_commit_id":"81af152194e9042b5f7321e37e66161c19cb5dd0","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"Should this be:\r\n\r\n```\r\nmv /root/src/coreos-assembler.sh /usr/bin/coreos-assembler\r\n```\r\n\r\nfor backcompat?","created_at":"2018-06-18T16:28:54Z","updated_at":"2018-06-18T16:30:41Z","html_url":"https://github.com/cgwalters/coreos-assembler/pull/5#discussion_r196142845","pull_request_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/comments/196142845"},"html":{"href":"https://github.com/cgwalters/coreos-assembler/pull/5#discussion_r196142845"},"pull_request":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5","id":195282331,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjgyMzMx","html_url":"https://github.com/cgwalters/coreos-assembler/pull/5","diff_url":"https://github.com/cgwalters/coreos-assembler/pull/5.diff","patch_url":"https://github.com/cgwalters/coreos-assembler/pull/5.patch","issue_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/5","number":5,"state":"open","locked":false,"title":"build: Use rpm-ostree git master","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"So we have https://github.com/projectatomic/rpm-ostree/pull/1417","created_at":"2018-06-15T21:03:01Z","updated_at":"2018-06-18T16:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a402395f5865c807d9bb9cddd1ebd82ffb74e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5/commits","review_comments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5/comments","review_comment_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/5/comments","statuses_url":"https://api.github.com/repos/cgwalters/coreos-assembler/statuses/81af152194e9042b5f7321e37e66161c19cb5dd0","head":{"label":"cgwalters:rpmostree-git","ref":"rpmostree-git","sha":"81af152194e9042b5f7321e37e66161c19cb5dd0","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":133999225,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTkyMjU=","name":"coreos-assembler","full_name":"cgwalters/coreos-assembler","owner":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgwalters/coreos-assembler","description":"\"rpm-ostree compose tree\" as a container","fork":false,"url":"https://api.github.com/repos/cgwalters/coreos-assembler","forks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/forks","keys_url":"https://api.github.com/repos/cgwalters/coreos-assembler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/coreos-assembler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/coreos-assembler/teams","hooks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/events","assignees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/coreos-assembler/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/tags","blobs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/coreos-assembler/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/coreos-assembler/languages","stargazers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscription","commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/coreos-assembler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/coreos-assembler/merges","archive_url":"https://api.github.com/repos/cgwalters/coreos-assembler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/coreos-assembler/downloads","issues_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/coreos-assembler/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/coreos-assembler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/coreos-assembler/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/coreos-assembler/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/deployments","created_at":"2018-05-18T20:07:27Z","updated_at":"2018-06-12T19:15:38Z","pushed_at":"2018-06-18T16:04:02Z","git_url":"git://github.com/cgwalters/coreos-assembler.git","ssh_url":"git@github.com:cgwalters/coreos-assembler.git","clone_url":"https://github.com/cgwalters/coreos-assembler.git","svn_url":"https://github.com/cgwalters/coreos-assembler","homepage":null,"size":12,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"cgwalters:master","ref":"master","sha":"9e74dfb32ed323dd2d66722eb2e81adcf113c399","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":133999225,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTkyMjU=","name":"coreos-assembler","full_name":"cgwalters/coreos-assembler","owner":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgwalters/coreos-assembler","description":"\"rpm-ostree compose tree\" as a container","fork":false,"url":"https://api.github.com/repos/cgwalters/coreos-assembler","forks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/forks","keys_url":"https://api.github.com/repos/cgwalters/coreos-assembler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/coreos-assembler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/coreos-assembler/teams","hooks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/events","assignees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/coreos-assembler/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/tags","blobs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/coreos-assembler/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/coreos-assembler/languages","stargazers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscription","commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/coreos-assembler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/coreos-assembler/merges","archive_url":"https://api.github.com/repos/cgwalters/coreos-assembler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/coreos-assembler/downloads","issues_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/coreos-assembler/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/coreos-assembler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/coreos-assembler/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/coreos-assembler/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/deployments","created_at":"2018-05-18T20:07:27Z","updated_at":"2018-06-12T19:15:38Z","pushed_at":"2018-06-18T16:04:02Z","git_url":"git://github.com/cgwalters/coreos-assembler.git","ssh_url":"git@github.com:cgwalters/coreos-assembler.git","clone_url":"https://github.com/cgwalters/coreos-assembler.git","svn_url":"https://github.com/cgwalters/coreos-assembler","homepage":null,"size":12,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5"},"html":{"href":"https://github.com/cgwalters/coreos-assembler/pull/5"},"issue":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/5"},"comments":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/cgwalters/coreos-assembler/statuses/81af152194e9042b5f7321e37e66161c19cb5dd0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jlebon"}}