{"action":"created","comment":{"url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments/239554310","pull_request_review_id":182371625,"id":239554310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTU1NDMxMA==","diff_hunk":"@@ -4,6 +4,12 @@\n       DFP_CATEGORY = \"<%=category.slug%>\";\n     <% end %>\n \n+    <% if story ||= nil %>","path":"app/views/shared/ads/_dfp_script_config.html.erb","position":4,"original_position":4,"commit_id":"3bd8fd2769ff88713a1c1d3c2f9eb7dbcfd82972","original_commit_id":"3bd8fd2769ff88713a1c1d3c2f9eb7dbcfd82972","user":{"login":"arellaTV","id":16679701,"node_id":"MDQ6VXNlcjE2Njc5NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/16679701?v=4","gravatar_id":"","url":"https://api.github.com/users/arellaTV","html_url":"https://github.com/arellaTV","followers_url":"https://api.github.com/users/arellaTV/followers","following_url":"https://api.github.com/users/arellaTV/following{/other_user}","gists_url":"https://api.github.com/users/arellaTV/gists{/gist_id}","starred_url":"https://api.github.com/users/arellaTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arellaTV/subscriptions","organizations_url":"https://api.github.com/users/arellaTV/orgs","repos_url":"https://api.github.com/users/arellaTV/repos","events_url":"https://api.github.com/users/arellaTV/events{/privacy}","received_events_url":"https://api.github.com/users/arellaTV/received_events","type":"User","site_admin":false},"body":"@nakedsushi, Thanks for the review! Yes you're right, the block doesn't run if there isn't a story. I had originally written it that way to match how the category block conditional is set up, but I realize that `if story.present?` is more readable, so I'll go ahead and change to that now. 🙌 ","created_at":"2018-12-06T18:01:55Z","updated_at":"2018-12-06T18:01:55Z","html_url":"https://github.com/SCPR/SCPRv4/pull/1374#discussion_r239554310","pull_request_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments/239554310"},"html":{"href":"https://github.com/SCPR/SCPRv4/pull/1374#discussion_r239554310"},"pull_request":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374"}},"in_reply_to_id":239529233},"pull_request":{"url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374","id":236362412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzYyNDEy","html_url":"https://github.com/SCPR/SCPRv4/pull/1374","diff_url":"https://github.com/SCPR/SCPRv4/pull/1374.diff","patch_url":"https://github.com/SCPR/SCPRv4/pull/1374.patch","issue_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/1374","number":1374,"state":"open","locked":false,"title":" Adds tag level targeting to article and segment pages","user":{"login":"arellaTV","id":16679701,"node_id":"MDQ6VXNlcjE2Njc5NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/16679701?v=4","gravatar_id":"","url":"https://api.github.com/users/arellaTV","html_url":"https://github.com/arellaTV","followers_url":"https://api.github.com/users/arellaTV/followers","following_url":"https://api.github.com/users/arellaTV/following{/other_user}","gists_url":"https://api.github.com/users/arellaTV/gists{/gist_id}","starred_url":"https://api.github.com/users/arellaTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arellaTV/subscriptions","organizations_url":"https://api.github.com/users/arellaTV/orgs","repos_url":"https://api.github.com/users/arellaTV/repos","events_url":"https://api.github.com/users/arellaTV/events{/privacy}","received_events_url":"https://api.github.com/users/arellaTV/received_events","type":"User","site_admin":false},"body":"This PR proposes to add tag level targeting to article pages. Similar to category level targeting, but instead passes an array of the tags to google dfp which will allow the ad ops dev to target pages with a specific tag. If there are no tags for a specific page, it defaults to sitewide position targeting.\r\n\r\nDocumentation:\r\n- Add docs explaining how the ad config scripts work\r\n- Adds a line about running SCPRv4 locally (needs a specific version of mysql installed locally to natively build the mysql gem)\r\n- Removes an intermittently failing test","created_at":"2018-12-05T23:49:07Z","updated_at":"2018-12-06T18:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8104bf48cbef9831d98855b2759cf37abe815539","assignee":{"login":"arellaTV","id":16679701,"node_id":"MDQ6VXNlcjE2Njc5NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/16679701?v=4","gravatar_id":"","url":"https://api.github.com/users/arellaTV","html_url":"https://github.com/arellaTV","followers_url":"https://api.github.com/users/arellaTV/followers","following_url":"https://api.github.com/users/arellaTV/following{/other_user}","gists_url":"https://api.github.com/users/arellaTV/gists{/gist_id}","starred_url":"https://api.github.com/users/arellaTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arellaTV/subscriptions","organizations_url":"https://api.github.com/users/arellaTV/orgs","repos_url":"https://api.github.com/users/arellaTV/repos","events_url":"https://api.github.com/users/arellaTV/events{/privacy}","received_events_url":"https://api.github.com/users/arellaTV/received_events","type":"User","site_admin":false},"assignees":[{"login":"arellaTV","id":16679701,"node_id":"MDQ6VXNlcjE2Njc5NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/16679701?v=4","gravatar_id":"","url":"https://api.github.com/users/arellaTV","html_url":"https://github.com/arellaTV","followers_url":"https://api.github.com/users/arellaTV/followers","following_url":"https://api.github.com/users/arellaTV/following{/other_user}","gists_url":"https://api.github.com/users/arellaTV/gists{/gist_id}","starred_url":"https://api.github.com/users/arellaTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arellaTV/subscriptions","organizations_url":"https://api.github.com/users/arellaTV/orgs","repos_url":"https://api.github.com/users/arellaTV/repos","events_url":"https://api.github.com/users/arellaTV/events{/privacy}","received_events_url":"https://api.github.com/users/arellaTV/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jo-im","id":16568530,"node_id":"MDQ6VXNlcjE2NTY4NTMw","avatar_url":"https://avatars2.githubusercontent.com/u/16568530?v=4","gravatar_id":"","url":"https://api.github.com/users/jo-im","html_url":"https://github.com/jo-im","followers_url":"https://api.github.com/users/jo-im/followers","following_url":"https://api.github.com/users/jo-im/following{/other_user}","gists_url":"https://api.github.com/users/jo-im/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-im/subscriptions","organizations_url":"https://api.github.com/users/jo-im/orgs","repos_url":"https://api.github.com/users/jo-im/repos","events_url":"https://api.github.com/users/jo-im/events{/privacy}","received_events_url":"https://api.github.com/users/jo-im/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374/commits","review_comments_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374/comments","review_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/1374/comments","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/3bd8fd2769ff88713a1c1d3c2f9eb7dbcfd82972","head":{"label":"SCPR:feat-tag-targeting","ref":"feat-tag-targeting","sha":"3bd8fd2769ff88713a1c1d3c2f9eb7dbcfd82972","user":{"login":"SCPR","id":855010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTAxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/855010?v=4","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"repo":{"id":2558636,"node_id":"MDEwOlJlcG9zaXRvcnkyNTU4NjM2","name":"SCPRv4","full_name":"SCPR/SCPRv4","private":false,"owner":{"login":"SCPR","id":855010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTAxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/855010?v=4","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SCPR/SCPRv4","description":"KPCC on Rails","fork":false,"url":"https://api.github.com/repos/SCPR/SCPRv4","forks_url":"https://api.github.com/repos/SCPR/SCPRv4/forks","keys_url":"https://api.github.com/repos/SCPR/SCPRv4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCPR/SCPRv4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCPR/SCPRv4/teams","hooks_url":"https://api.github.com/repos/SCPR/SCPRv4/hooks","issue_events_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/events{/number}","events_url":"https://api.github.com/repos/SCPR/SCPRv4/events","assignees_url":"https://api.github.com/repos/SCPR/SCPRv4/assignees{/user}","branches_url":"https://api.github.com/repos/SCPR/SCPRv4/branches{/branch}","tags_url":"https://api.github.com/repos/SCPR/SCPRv4/tags","blobs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCPR/SCPRv4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCPR/SCPRv4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/{sha}","languages_url":"https://api.github.com/repos/SCPR/SCPRv4/languages","stargazers_url":"https://api.github.com/repos/SCPR/SCPRv4/stargazers","contributors_url":"https://api.github.com/repos/SCPR/SCPRv4/contributors","subscribers_url":"https://api.github.com/repos/SCPR/SCPRv4/subscribers","subscription_url":"https://api.github.com/repos/SCPR/SCPRv4/subscription","commits_url":"https://api.github.com/repos/SCPR/SCPRv4/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCPR/SCPRv4/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCPR/SCPRv4/contents/{+path}","compare_url":"https://api.github.com/repos/SCPR/SCPRv4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCPR/SCPRv4/merges","archive_url":"https://api.github.com/repos/SCPR/SCPRv4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCPR/SCPRv4/downloads","issues_url":"https://api.github.com/repos/SCPR/SCPRv4/issues{/number}","pulls_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls{/number}","milestones_url":"https://api.github.com/repos/SCPR/SCPRv4/milestones{/number}","notifications_url":"https://api.github.com/repos/SCPR/SCPRv4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCPR/SCPRv4/labels{/name}","releases_url":"https://api.github.com/repos/SCPR/SCPRv4/releases{/id}","deployments_url":"https://api.github.com/repos/SCPR/SCPRv4/deployments","created_at":"2011-10-11T22:05:04Z","updated_at":"2018-12-04T01:11:05Z","pushed_at":"2018-12-05T23:50:47Z","git_url":"git://github.com/SCPR/SCPRv4.git","ssh_url":"git@github.com:SCPR/SCPRv4.git","clone_url":"https://github.com/SCPR/SCPRv4.git","svn_url":"https://github.com/SCPR/SCPRv4","homepage":"http://www.scpr.org","size":72831,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":89,"license":null,"forks":8,"open_issues":89,"watchers":15,"default_branch":"master"}},"base":{"label":"SCPR:master","ref":"master","sha":"b50e66dcb6fb1c53a3dfa9b2add07a1723f780f6","user":{"login":"SCPR","id":855010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTAxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/855010?v=4","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"repo":{"id":2558636,"node_id":"MDEwOlJlcG9zaXRvcnkyNTU4NjM2","name":"SCPRv4","full_name":"SCPR/SCPRv4","private":false,"owner":{"login":"SCPR","id":855010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTAxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/855010?v=4","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SCPR/SCPRv4","description":"KPCC on Rails","fork":false,"url":"https://api.github.com/repos/SCPR/SCPRv4","forks_url":"https://api.github.com/repos/SCPR/SCPRv4/forks","keys_url":"https://api.github.com/repos/SCPR/SCPRv4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCPR/SCPRv4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCPR/SCPRv4/teams","hooks_url":"https://api.github.com/repos/SCPR/SCPRv4/hooks","issue_events_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/events{/number}","events_url":"https://api.github.com/repos/SCPR/SCPRv4/events","assignees_url":"https://api.github.com/repos/SCPR/SCPRv4/assignees{/user}","branches_url":"https://api.github.com/repos/SCPR/SCPRv4/branches{/branch}","tags_url":"https://api.github.com/repos/SCPR/SCPRv4/tags","blobs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCPR/SCPRv4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCPR/SCPRv4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/{sha}","languages_url":"https://api.github.com/repos/SCPR/SCPRv4/languages","stargazers_url":"https://api.github.com/repos/SCPR/SCPRv4/stargazers","contributors_url":"https://api.github.com/repos/SCPR/SCPRv4/contributors","subscribers_url":"https://api.github.com/repos/SCPR/SCPRv4/subscribers","subscription_url":"https://api.github.com/repos/SCPR/SCPRv4/subscription","commits_url":"https://api.github.com/repos/SCPR/SCPRv4/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCPR/SCPRv4/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCPR/SCPRv4/contents/{+path}","compare_url":"https://api.github.com/repos/SCPR/SCPRv4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCPR/SCPRv4/merges","archive_url":"https://api.github.com/repos/SCPR/SCPRv4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCPR/SCPRv4/downloads","issues_url":"https://api.github.com/repos/SCPR/SCPRv4/issues{/number}","pulls_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls{/number}","milestones_url":"https://api.github.com/repos/SCPR/SCPRv4/milestones{/number}","notifications_url":"https://api.github.com/repos/SCPR/SCPRv4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCPR/SCPRv4/labels{/name}","releases_url":"https://api.github.com/repos/SCPR/SCPRv4/releases{/id}","deployments_url":"https://api.github.com/repos/SCPR/SCPRv4/deployments","created_at":"2011-10-11T22:05:04Z","updated_at":"2018-12-04T01:11:05Z","pushed_at":"2018-12-05T23:50:47Z","git_url":"git://github.com/SCPR/SCPRv4.git","ssh_url":"git@github.com:SCPR/SCPRv4.git","clone_url":"https://github.com/SCPR/SCPRv4.git","svn_url":"https://github.com/SCPR/SCPRv4","homepage":"http://www.scpr.org","size":72831,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":89,"license":null,"forks":8,"open_issues":89,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374"},"html":{"href":"https://github.com/SCPR/SCPRv4/pull/1374"},"issue":{"href":"https://api.github.com/repos/SCPR/SCPRv4/issues/1374"},"comments":{"href":"https://api.github.com/repos/SCPR/SCPRv4/issues/1374/comments"},"review_comments":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374/comments"},"review_comment":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/1374/commits"},"statuses":{"href":"https://api.github.com/repos/SCPR/SCPRv4/statuses/3bd8fd2769ff88713a1c1d3c2f9eb7dbcfd82972"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arellaTV"}}