{"action":"created","issue":{"url":"https://api.github.com/repos/standardhealth/flux/issues/304","repository_url":"https://api.github.com/repos/standardhealth/flux","labels_url":"https://api.github.com/repos/standardhealth/flux/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/standardhealth/flux/issues/304/comments","events_url":"https://api.github.com/repos/standardhealth/flux/issues/304/events","html_url":"https://github.com/standardhealth/flux/pull/304","id":309010093,"number":304,"title":"Search v1","user":{"login":"Dtphelan1","id":5703736,"avatar_url":"https://avatars3.githubusercontent.com/u/5703736?v=4","gravatar_id":"","url":"https://api.github.com/users/Dtphelan1","html_url":"https://github.com/Dtphelan1","followers_url":"https://api.github.com/users/Dtphelan1/followers","following_url":"https://api.github.com/users/Dtphelan1/following{/other_user}","gists_url":"https://api.github.com/users/Dtphelan1/gists{/gist_id}","starred_url":"https://api.github.com/users/Dtphelan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dtphelan1/subscriptions","organizations_url":"https://api.github.com/users/Dtphelan1/orgs","repos_url":"https://api.github.com/users/Dtphelan1/repos","events_url":"https://api.github.com/users/Dtphelan1/events{/privacy}","received_events_url":"https://api.github.com/users/Dtphelan1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-27T15:05:12Z","updated_at":"2018-03-28T14:13:15Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/standardhealth/flux/pulls/304","html_url":"https://github.com/standardhealth/flux/pull/304","diff_url":"https://github.com/standardhealth/flux/pull/304.diff","patch_url":"https://github.com/standardhealth/flux/pull/304.patch"},"body":"Initial implementation of a search on patient notes. Users can type in the upper-right search box and type out content they expect to be in a note or to be included as metadata of the note. If the search macthes part of the note content, the matching text is bolded and additional text is displayed for context. If the search matches the note metadata, the piece of metadata as a whole is bolded and a sample of the note content is displayed to the right of the metadata. Clicking on the suggestion opens up that note.\r\n\r\nThis functionality is enabled by a dependency [Downshift](https://github.com/paypal/downshift), linked to in Material-UI's suggestions on how to implement [autocomplete boxes](https://material-ui-next.com/demos/autocomplete/).\r\n\r\nLet me know what you think about the functionality as it stands now. There are ideas on how we can expand the search functionality in the longterm, but this at least adds some reasonable user interaction to what used to be a useless box in a very attractive part of our UI.\r\n\r\n_Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (**N/A**) and :white_check_mark:._\r\n\r\n\r\n## Submitter:\r\n\r\n**Running the Application**\r\n\r\n- [x] Manually tested in Chrome\r\n- [x] Manually tested in IE\r\n\r\n**Documentation**\r\n\r\n- [x] This pull request describes why these changes were made\r\n- [x] Recognizes any potential shortcomings/bugs in the description \r\n- [x] **N/A** Cheat sheet is updated\r\n- [x] **N/A** Demo script is updated \r\n- [x] **N/A** Documentation on Wiki has been updated \r\n- [x] Additional technical components and libraries are documented and added to wiki as needed\r\n\r\n**NoteParser**\r\n\r\n- [x] Note parser has been updated if structured phrases change\r\n\r\n**Code Quality**\r\n\r\n- [x] 4-space indents - convert any tabs to spaces\r\n- [x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };\r\n- [x] Code is commented\r\n\r\n**Tests**\r\n\r\n- [x] Existing tests passed\r\n-  **N/A** Added UI tests for slim mode \r\n-  **N/A** Added UI tests for full mode\r\n-  **N/A** Added backend tests for fluxNotes code\r\n-  **N/A** Added note parser examples to test new functionality\r\n\r\n\r\n## Reviewer 1: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\n\r\n## Reviewer 2: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n"},"comment":{"url":"https://api.github.com/repos/standardhealth/flux/issues/comments/376901697","html_url":"https://github.com/standardhealth/flux/pull/304#issuecomment-376901697","issue_url":"https://api.github.com/repos/standardhealth/flux/issues/304","id":376901697,"user":{"login":"gregquinn2001","id":20170846,"avatar_url":"https://avatars1.githubusercontent.com/u/20170846?v=4","gravatar_id":"","url":"https://api.github.com/users/gregquinn2001","html_url":"https://github.com/gregquinn2001","followers_url":"https://api.github.com/users/gregquinn2001/followers","following_url":"https://api.github.com/users/gregquinn2001/following{/other_user}","gists_url":"https://api.github.com/users/gregquinn2001/gists{/gist_id}","starred_url":"https://api.github.com/users/gregquinn2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregquinn2001/subscriptions","organizations_url":"https://api.github.com/users/gregquinn2001/orgs","repos_url":"https://api.github.com/users/gregquinn2001/repos","events_url":"https://api.github.com/users/gregquinn2001/events{/privacy}","received_events_url":"https://api.github.com/users/gregquinn2001/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T14:13:14Z","updated_at":"2018-03-28T14:13:14Z","author_association":"OWNER","body":"Very cool Dylan! I like the presentation of results and how it stays open!\r\n[GQ1] Can we maintain the correct case in displayed search results?\r\n[GQ2] Can we provide more context in the search results? Perhaps the complete sentence that contains the word or at least a good amount of content from the sentence containing the key word(s)?\r\n\r\nWe can say no for now to either of these and push them off to a future task..."}}
{"actor":{"display_login":"gregquinn2001"}}