{"action":"created","issue":{"url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/21","repository_url":"https://api.github.com/repos/fawkesrobotics/fawkes","labels_url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/21/comments","events_url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/21/events","html_url":"https://github.com/fawkesrobotics/fawkes/pull/21","id":378518384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjA2MzQx","number":21,"title":"Code reformatting (part 1)","user":{"login":"timn","id":69310,"node_id":"MDQ6VXNlcjY5MzEw","avatar_url":"https://avatars3.githubusercontent.com/u/69310?v=4","gravatar_id":"","url":"https://api.github.com/users/timn","html_url":"https://github.com/timn","followers_url":"https://api.github.com/users/timn/followers","following_url":"https://api.github.com/users/timn/following{/other_user}","gists_url":"https://api.github.com/users/timn/gists{/gist_id}","starred_url":"https://api.github.com/users/timn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timn/subscriptions","organizations_url":"https://api.github.com/users/timn/orgs","repos_url":"https://api.github.com/users/timn/repos","events_url":"https://api.github.com/users/timn/events{/privacy}","received_events_url":"https://api.github.com/users/timn/received_events","type":"User","site_admin":false},"labels":[{"id":1119950323,"node_id":"MDU6TGFiZWwxMTE5OTUwMzIz","url":"https://api.github.com/repos/fawkesrobotics/fawkes/labels/enhancement","name":"enhancement","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T23:47:39Z","updated_at":"2018-11-08T09:31:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/fawkesrobotics/fawkes/pulls/21","html_url":"https://github.com/fawkesrobotics/fawkes/pull/21","diff_url":"https://github.com/fawkesrobotics/fawkes/pull/21.diff","patch_url":"https://github.com/fawkesrobotics/fawkes/pull/21.patch"},"body":"This PR brings the following:\r\n- introduction of a unified code style encoded through clang-format\r\n- tool support to check style, or to automatically reformat the entire code base, local modifications, or branches\r\n- removal of Emacs-specific indentation workarounds\r\n- elimination of \"double underscore\" private member names used in older code\r\n\r\nThe latter two were done mostly automatic, the commands are given in the commit messages.\r\n\r\nThis PR does *not* include a reformatted code base. I'll file that PR after this one is accepted and merged, but it would clutter especially the tool changes from review. A potential second PR may be filed depending on the discussion in #20."},"comment":{"url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/comments/436930124","html_url":"https://github.com/fawkesrobotics/fawkes/pull/21#issuecomment-436930124","issue_url":"https://api.github.com/repos/fawkesrobotics/fawkes/issues/21","id":436930124,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjkzMDEyNA==","user":{"login":"timn","id":69310,"node_id":"MDQ6VXNlcjY5MzEw","avatar_url":"https://avatars3.githubusercontent.com/u/69310?v=4","gravatar_id":"","url":"https://api.github.com/users/timn","html_url":"https://github.com/timn","followers_url":"https://api.github.com/users/timn/followers","following_url":"https://api.github.com/users/timn/following{/other_user}","gists_url":"https://api.github.com/users/timn/gists{/gist_id}","starred_url":"https://api.github.com/users/timn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timn/subscriptions","organizations_url":"https://api.github.com/users/timn/orgs","repos_url":"https://api.github.com/users/timn/repos","events_url":"https://api.github.com/users/timn/events{/privacy}","received_events_url":"https://api.github.com/users/timn/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T09:31:00Z","updated_at":"2018-11-08T09:31:00Z","author_association":"MEMBER","body":"The recent update fixes the lgtm alerts. They were re-introduced since I rebased a previous run of the underscore private member fixing onto the recent master, rather than re-running the script. I have now run the script again. Along the way, fix some per-component commits.\r\n\r\nThe failed codacy check can be ignored for now. It's not actually new issues showing up, but the previously already existing ones again (the tech behind codacy seems to use pattern matching, rather than a model such as lgtm). We'll deal with the codacy issues in a later PR (there are some issues with codacy, such as using the wrong tslint config, which their support said would be fixed only later)."}}
{"actor":{"display_login":"timn"}}