{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/185088419","pull_request_review_id":116404651,"id":185088419,"diff_hunk":"@@ -94,7 +94,7 @@ if (( $EUID != 0 )); then\n fi\n \n #Check that sudo is available\n-if [[ \"$SUDO\" -eq \"sudo\" && ! (\"'$*'\" =~ skip-sudo-check) ]]; then\n+if [[ $EUID != 0 && \"$SUDO\" -eq \"sudo\" && ! (\"'$*'\" =~ skip-sudo-check) ]]; then","path":"tools/installpsh-debian.sh","position":5,"original_position":5,"commit_id":"62c3db5f34164923fd632c9122dd91365114156f","original_commit_id":"62c3db5f34164923fd632c9122dd91365114156f","user":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars1.githubusercontent.com/u/10873629?v=4","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"body":"verified... there is an error in the conditional... change `\"$SUDO\" -eq \"sudo\"` to `\"$SUDO\" == \"sudo\"` and remove your change","created_at":"2018-04-30T19:42:21Z","updated_at":"2018-04-30T19:42:31Z","html_url":"https://github.com/PowerShell/PowerShell/pull/6771#discussion_r185088419","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/185088419"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/6771#discussion_r185088419"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771"}},"in_reply_to_id":184881436},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771","id":184805363,"html_url":"https://github.com/PowerShell/PowerShell/pull/6771","diff_url":"https://github.com/PowerShell/PowerShell/pull/6771.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/6771.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/6771","number":6771,"state":"open","locked":false,"title":"updating error when running powershell installer as root","user":{"login":"bjh7242","id":4334716,"avatar_url":"https://avatars2.githubusercontent.com/u/4334716?v=4","gravatar_id":"","url":"https://api.github.com/users/bjh7242","html_url":"https://github.com/bjh7242","followers_url":"https://api.github.com/users/bjh7242/followers","following_url":"https://api.github.com/users/bjh7242/following{/other_user}","gists_url":"https://api.github.com/users/bjh7242/gists{/gist_id}","starred_url":"https://api.github.com/users/bjh7242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjh7242/subscriptions","organizations_url":"https://api.github.com/users/bjh7242/orgs","repos_url":"https://api.github.com/users/bjh7242/repos","events_url":"https://api.github.com/users/bjh7242/events{/privacy}","received_events_url":"https://api.github.com/users/bjh7242/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\n<!-- summarize your PR between here and the checklist -->\r\nTesting on Ubuntu, if the user is root, the $SUDO variable will be blank when attempting to execute the command 'sudo -v' on line 99. By checking if the EUID is not 0 will verify that the $SUDO variable was set above so that 'sudo -v' executes correctly as opposed to executing just '-v' which will throw an error as an unknown command.\r\n\r\n## PR Checklist\r\n\r\n- [ ] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n    - Use the present tense and imperative mood when describing your changes\r\n- [ ] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [ ] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)\r\n- [ ] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [ ] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).\r\n    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.\r\n- **User-facing changes**\r\n    - [ ] Not Applicable\r\n    - **OR**\r\n    - [ ] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n        - [ ] Issue filed - Issue link:\r\n- **Testing - New and feature**\r\n    - [ ] Not Applicable or can only be tested interactively\r\n    - **OR**\r\n    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)\r\n        - [ ] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)\r\n","created_at":"2018-04-28T21:01:46Z","updated_at":"2018-04-30T19:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e594d75ecef15baa9c188537427ebabb3d4aed96","assignee":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars1.githubusercontent.com/u/10873629?v=4","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"assignees":[{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars1.githubusercontent.com/u/10873629?v=4","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"daxian-dbw","id":127450,"avatar_url":"https://avatars2.githubusercontent.com/u/127450?v=4","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false},{"login":"adityapatwardhan","id":12820925,"avatar_url":"https://avatars0.githubusercontent.com/u/12820925?v=4","gravatar_id":"","url":"https://api.github.com/users/adityapatwardhan","html_url":"https://github.com/adityapatwardhan","followers_url":"https://api.github.com/users/adityapatwardhan/followers","following_url":"https://api.github.com/users/adityapatwardhan/following{/other_user}","gists_url":"https://api.github.com/users/adityapatwardhan/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapatwardhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapatwardhan/subscriptions","organizations_url":"https://api.github.com/users/adityapatwardhan/orgs","repos_url":"https://api.github.com/users/adityapatwardhan/repos","events_url":"https://api.github.com/users/adityapatwardhan/events{/privacy}","received_events_url":"https://api.github.com/users/adityapatwardhan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/6771/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/62c3db5f34164923fd632c9122dd91365114156f","head":{"label":"bjh7242:master","ref":"master","sha":"62c3db5f34164923fd632c9122dd91365114156f","user":{"login":"bjh7242","id":4334716,"avatar_url":"https://avatars2.githubusercontent.com/u/4334716?v=4","gravatar_id":"","url":"https://api.github.com/users/bjh7242","html_url":"https://github.com/bjh7242","followers_url":"https://api.github.com/users/bjh7242/followers","following_url":"https://api.github.com/users/bjh7242/following{/other_user}","gists_url":"https://api.github.com/users/bjh7242/gists{/gist_id}","starred_url":"https://api.github.com/users/bjh7242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjh7242/subscriptions","organizations_url":"https://api.github.com/users/bjh7242/orgs","repos_url":"https://api.github.com/users/bjh7242/repos","events_url":"https://api.github.com/users/bjh7242/events{/privacy}","received_events_url":"https://api.github.com/users/bjh7242/received_events","type":"User","site_admin":false},"repo":{"id":131442829,"name":"PowerShell","full_name":"bjh7242/PowerShell","owner":{"login":"bjh7242","id":4334716,"avatar_url":"https://avatars2.githubusercontent.com/u/4334716?v=4","gravatar_id":"","url":"https://api.github.com/users/bjh7242","html_url":"https://github.com/bjh7242","followers_url":"https://api.github.com/users/bjh7242/followers","following_url":"https://api.github.com/users/bjh7242/following{/other_user}","gists_url":"https://api.github.com/users/bjh7242/gists{/gist_id}","starred_url":"https://api.github.com/users/bjh7242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjh7242/subscriptions","organizations_url":"https://api.github.com/users/bjh7242/orgs","repos_url":"https://api.github.com/users/bjh7242/repos","events_url":"https://api.github.com/users/bjh7242/events{/privacy}","received_events_url":"https://api.github.com/users/bjh7242/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjh7242/PowerShell","description":"PowerShell for every system!","fork":true,"url":"https://api.github.com/repos/bjh7242/PowerShell","forks_url":"https://api.github.com/repos/bjh7242/PowerShell/forks","keys_url":"https://api.github.com/repos/bjh7242/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjh7242/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjh7242/PowerShell/teams","hooks_url":"https://api.github.com/repos/bjh7242/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/bjh7242/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/bjh7242/PowerShell/events","assignees_url":"https://api.github.com/repos/bjh7242/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/bjh7242/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/bjh7242/PowerShell/tags","blobs_url":"https://api.github.com/repos/bjh7242/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjh7242/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjh7242/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjh7242/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjh7242/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/bjh7242/PowerShell/languages","stargazers_url":"https://api.github.com/repos/bjh7242/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/bjh7242/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/bjh7242/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/bjh7242/PowerShell/subscription","commits_url":"https://api.github.com/repos/bjh7242/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjh7242/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjh7242/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjh7242/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjh7242/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/bjh7242/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjh7242/PowerShell/merges","archive_url":"https://api.github.com/repos/bjh7242/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjh7242/PowerShell/downloads","issues_url":"https://api.github.com/repos/bjh7242/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/bjh7242/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/bjh7242/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/bjh7242/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjh7242/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/bjh7242/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/bjh7242/PowerShell/deployments","created_at":"2018-04-28T20:43:10Z","updated_at":"2018-04-28T20:56:21Z","pushed_at":"2018-04-28T20:56:20Z","git_url":"git://github.com/bjh7242/PowerShell.git","ssh_url":"git@github.com:bjh7242/PowerShell.git","clone_url":"https://github.com/bjh7242/PowerShell.git","svn_url":"https://github.com/bjh7242/PowerShell","homepage":"https://microsoft.com/powershell","size":37081,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"8aec1585195e6d4871538aaa2ad2b112cf5fbfee","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"name":"PowerShell","full_name":"PowerShell/PowerShell","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2018-04-30T17:17:28Z","pushed_at":"2018-04-30T17:40:27Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"git@github.com:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":38063,"stargazers_count":10103,"watchers_count":10103,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1546,"mirror_url":null,"archived":false,"open_issues_count":1408,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1546,"open_issues":1408,"watchers":10103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/6771"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/6771"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/6771/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/6771/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/62c3db5f34164923fd632c9122dd91365114156f"}},"author_association":"NONE"}}
{"actor":{"display_login":"TravisEz13"}}