{"action":"created","comment":{"url":"https://api.github.com/repos/twitter-forks/hive/pulls/comments/214783935","pull_request_review_id":151907260,"id":214783935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc4MzkzNQ==","diff_hunk":"@@ -42,6 +41,10 @@\n import java.util.concurrent.CancellationException;\n import java.util.concurrent.locks.ReentrantLock;\n \n+import com.google.common.annotations.VisibleForTesting;","path":"ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java","position":12,"original_position":12,"commit_id":"830169b40b83d789494dba8daff6ecb16f1854fb","original_commit_id":"6bd715a5d6be822bd52562509d4b884a87a804ac","user":{"login":"luohao","id":323359,"node_id":"MDQ6VXNlcjMyMzM1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/323359?v=4","gravatar_id":"","url":"https://api.github.com/users/luohao","html_url":"https://github.com/luohao","followers_url":"https://api.github.com/users/luohao/followers","following_url":"https://api.github.com/users/luohao/following{/other_user}","gists_url":"https://api.github.com/users/luohao/gists{/gist_id}","starred_url":"https://api.github.com/users/luohao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luohao/subscriptions","organizations_url":"https://api.github.com/users/luohao/orgs","repos_url":"https://api.github.com/users/luohao/repos","events_url":"https://api.github.com/users/luohao/events{/privacy}","received_events_url":"https://api.github.com/users/luohao/received_events","type":"User","site_admin":false},"body":"You can just copy this line to its original place...","created_at":"2018-09-04T04:27:25Z","updated_at":"2018-09-04T04:27:34Z","html_url":"https://github.com/twitter-forks/hive/pull/5#discussion_r214783935","pull_request_url":"https://api.github.com/repos/twitter-forks/hive/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/comments/214783935"},"html":{"href":"https://github.com/twitter-forks/hive/pull/5#discussion_r214783935"},"pull_request":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/5"}},"in_reply_to_id":183566561},"pull_request":{"url":"https://api.github.com/repos/twitter-forks/hive/pulls/5","id":182910159,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyOTEwMTU5","html_url":"https://github.com/twitter-forks/hive/pull/5","diff_url":"https://github.com/twitter-forks/hive/pull/5.diff","patch_url":"https://github.com/twitter-forks/hive/pull/5.patch","issue_url":"https://api.github.com/repos/twitter-forks/hive/issues/5","number":5,"state":"open","locked":false,"title":"Hive query stats logging","user":{"login":"dcfocus","id":29189795,"node_id":"MDQ6VXNlcjI5MTg5Nzk1","avatar_url":"https://avatars1.githubusercontent.com/u/29189795?v=4","gravatar_id":"","url":"https://api.github.com/users/dcfocus","html_url":"https://github.com/dcfocus","followers_url":"https://api.github.com/users/dcfocus/followers","following_url":"https://api.github.com/users/dcfocus/following{/other_user}","gists_url":"https://api.github.com/users/dcfocus/gists{/gist_id}","starred_url":"https://api.github.com/users/dcfocus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcfocus/subscriptions","organizations_url":"https://api.github.com/users/dcfocus/orgs","repos_url":"https://api.github.com/users/dcfocus/repos","events_url":"https://api.github.com/users/dcfocus/events{/privacy}","received_events_url":"https://api.github.com/users/dcfocus/received_events","type":"User","site_admin":false},"body":"This patch adds an implementation of Hive query history logging that write query information to Twitter's `logpipeline`. This changeset includes:\r\n1. `HiveScribeImpl` that implements a mechanism that logs query information and statistics to Twitter Scribe.\r\n2. a new hive config: hive.session.history.scribe.enabled, with which we can choose to write query metric to local history file or to `logpipeline`. \r\n3. updating global pom.xml and ql pom.xml to include required libraries.","created_at":"2018-04-19T21:58:54Z","updated_at":"2018-09-04T04:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9407abe39e0ea528a12fda6d9f661a967814dd08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter-forks/hive/pulls/5/commits","review_comments_url":"https://api.github.com/repos/twitter-forks/hive/pulls/5/comments","review_comment_url":"https://api.github.com/repos/twitter-forks/hive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter-forks/hive/issues/5/comments","statuses_url":"https://api.github.com/repos/twitter-forks/hive/statuses/830169b40b83d789494dba8daff6ecb16f1854fb","head":{"label":"dcfocus:dac/hive_query_history_scriber","ref":"dac/hive_query_history_scriber","sha":"830169b40b83d789494dba8daff6ecb16f1854fb","user":{"login":"dcfocus","id":29189795,"node_id":"MDQ6VXNlcjI5MTg5Nzk1","avatar_url":"https://avatars1.githubusercontent.com/u/29189795?v=4","gravatar_id":"","url":"https://api.github.com/users/dcfocus","html_url":"https://github.com/dcfocus","followers_url":"https://api.github.com/users/dcfocus/followers","following_url":"https://api.github.com/users/dcfocus/following{/other_user}","gists_url":"https://api.github.com/users/dcfocus/gists{/gist_id}","starred_url":"https://api.github.com/users/dcfocus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcfocus/subscriptions","organizations_url":"https://api.github.com/users/dcfocus/orgs","repos_url":"https://api.github.com/users/dcfocus/repos","events_url":"https://api.github.com/users/dcfocus/events{/privacy}","received_events_url":"https://api.github.com/users/dcfocus/received_events","type":"User","site_admin":false},"repo":{"id":130274136,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyNzQxMzY=","name":"hive","full_name":"dcfocus/hive","owner":{"login":"dcfocus","id":29189795,"node_id":"MDQ6VXNlcjI5MTg5Nzk1","avatar_url":"https://avatars1.githubusercontent.com/u/29189795?v=4","gravatar_id":"","url":"https://api.github.com/users/dcfocus","html_url":"https://github.com/dcfocus","followers_url":"https://api.github.com/users/dcfocus/followers","following_url":"https://api.github.com/users/dcfocus/following{/other_user}","gists_url":"https://api.github.com/users/dcfocus/gists{/gist_id}","starred_url":"https://api.github.com/users/dcfocus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcfocus/subscriptions","organizations_url":"https://api.github.com/users/dcfocus/orgs","repos_url":"https://api.github.com/users/dcfocus/repos","events_url":"https://api.github.com/users/dcfocus/events{/privacy}","received_events_url":"https://api.github.com/users/dcfocus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcfocus/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/dcfocus/hive","forks_url":"https://api.github.com/repos/dcfocus/hive/forks","keys_url":"https://api.github.com/repos/dcfocus/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcfocus/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcfocus/hive/teams","hooks_url":"https://api.github.com/repos/dcfocus/hive/hooks","issue_events_url":"https://api.github.com/repos/dcfocus/hive/issues/events{/number}","events_url":"https://api.github.com/repos/dcfocus/hive/events","assignees_url":"https://api.github.com/repos/dcfocus/hive/assignees{/user}","branches_url":"https://api.github.com/repos/dcfocus/hive/branches{/branch}","tags_url":"https://api.github.com/repos/dcfocus/hive/tags","blobs_url":"https://api.github.com/repos/dcfocus/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcfocus/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcfocus/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcfocus/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcfocus/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/dcfocus/hive/languages","stargazers_url":"https://api.github.com/repos/dcfocus/hive/stargazers","contributors_url":"https://api.github.com/repos/dcfocus/hive/contributors","subscribers_url":"https://api.github.com/repos/dcfocus/hive/subscribers","subscription_url":"https://api.github.com/repos/dcfocus/hive/subscription","commits_url":"https://api.github.com/repos/dcfocus/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcfocus/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcfocus/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcfocus/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcfocus/hive/contents/{+path}","compare_url":"https://api.github.com/repos/dcfocus/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcfocus/hive/merges","archive_url":"https://api.github.com/repos/dcfocus/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcfocus/hive/downloads","issues_url":"https://api.github.com/repos/dcfocus/hive/issues{/number}","pulls_url":"https://api.github.com/repos/dcfocus/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/dcfocus/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/dcfocus/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcfocus/hive/labels{/name}","releases_url":"https://api.github.com/repos/dcfocus/hive/releases{/id}","deployments_url":"https://api.github.com/repos/dcfocus/hive/deployments","created_at":"2018-04-19T21:24:45Z","updated_at":"2018-04-19T21:25:36Z","pushed_at":"2018-09-03T19:27:51Z","git_url":"git://github.com/dcfocus/hive.git","ssh_url":"git@github.com:dcfocus/hive.git","clone_url":"https://github.com/dcfocus/hive.git","svn_url":"https://github.com/dcfocus/hive","homepage":null,"size":380210,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter-forks:twitter/branch-2.3","ref":"twitter/branch-2.3","sha":"9d42b14fcefdaca7bf12b8ca3fa35ef8736c9f95","user":{"login":"twitter-forks","id":5349157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDkxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5349157?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter-forks","html_url":"https://github.com/twitter-forks","followers_url":"https://api.github.com/users/twitter-forks/followers","following_url":"https://api.github.com/users/twitter-forks/following{/other_user}","gists_url":"https://api.github.com/users/twitter-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-forks/subscriptions","organizations_url":"https://api.github.com/users/twitter-forks/orgs","repos_url":"https://api.github.com/users/twitter-forks/repos","events_url":"https://api.github.com/users/twitter-forks/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":41699357,"node_id":"MDEwOlJlcG9zaXRvcnk0MTY5OTM1Nw==","name":"hive","full_name":"twitter-forks/hive","owner":{"login":"twitter-forks","id":5349157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDkxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5349157?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter-forks","html_url":"https://github.com/twitter-forks","followers_url":"https://api.github.com/users/twitter-forks/followers","following_url":"https://api.github.com/users/twitter-forks/following{/other_user}","gists_url":"https://api.github.com/users/twitter-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-forks/subscriptions","organizations_url":"https://api.github.com/users/twitter-forks/orgs","repos_url":"https://api.github.com/users/twitter-forks/repos","events_url":"https://api.github.com/users/twitter-forks/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter-forks/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/twitter-forks/hive","forks_url":"https://api.github.com/repos/twitter-forks/hive/forks","keys_url":"https://api.github.com/repos/twitter-forks/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter-forks/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter-forks/hive/teams","hooks_url":"https://api.github.com/repos/twitter-forks/hive/hooks","issue_events_url":"https://api.github.com/repos/twitter-forks/hive/issues/events{/number}","events_url":"https://api.github.com/repos/twitter-forks/hive/events","assignees_url":"https://api.github.com/repos/twitter-forks/hive/assignees{/user}","branches_url":"https://api.github.com/repos/twitter-forks/hive/branches{/branch}","tags_url":"https://api.github.com/repos/twitter-forks/hive/tags","blobs_url":"https://api.github.com/repos/twitter-forks/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter-forks/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter-forks/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter-forks/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter-forks/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter-forks/hive/languages","stargazers_url":"https://api.github.com/repos/twitter-forks/hive/stargazers","contributors_url":"https://api.github.com/repos/twitter-forks/hive/contributors","subscribers_url":"https://api.github.com/repos/twitter-forks/hive/subscribers","subscription_url":"https://api.github.com/repos/twitter-forks/hive/subscription","commits_url":"https://api.github.com/repos/twitter-forks/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter-forks/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter-forks/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter-forks/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter-forks/hive/contents/{+path}","compare_url":"https://api.github.com/repos/twitter-forks/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter-forks/hive/merges","archive_url":"https://api.github.com/repos/twitter-forks/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter-forks/hive/downloads","issues_url":"https://api.github.com/repos/twitter-forks/hive/issues{/number}","pulls_url":"https://api.github.com/repos/twitter-forks/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter-forks/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter-forks/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter-forks/hive/labels{/name}","releases_url":"https://api.github.com/repos/twitter-forks/hive/releases{/id}","deployments_url":"https://api.github.com/repos/twitter-forks/hive/deployments","created_at":"2015-08-31T20:39:19Z","updated_at":"2018-04-25T04:54:48Z","pushed_at":"2018-09-03T19:27:54Z","git_url":"git://github.com/twitter-forks/hive.git","ssh_url":"git@github.com:twitter-forks/hive.git","clone_url":"https://github.com/twitter-forks/hive.git","svn_url":"https://github.com/twitter-forks/hive","homepage":null,"size":379274,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/5"},"html":{"href":"https://github.com/twitter-forks/hive/pull/5"},"issue":{"href":"https://api.github.com/repos/twitter-forks/hive/issues/5"},"comments":{"href":"https://api.github.com/repos/twitter-forks/hive/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter-forks/hive/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/twitter-forks/hive/statuses/830169b40b83d789494dba8daff6ecb16f1854fb"}},"author_association":"NONE"}}
{"actor":{"display_login":"luohao"}}