{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/181448670","pull_request_review_id":112083091,"id":181448670,"diff_hunk":"@@ -68,13 +73,6 @@ export class WindowController extends ControllerInterface\n    * permission isn't granted.\n    */\n   getToken(): Promise<string | null> {\n-    // Check that the required API's are available\n-    if (!this.isSupported_()) {","path":"packages/messaging/src/controllers/window-controller.ts","position":47,"original_position":47,"commit_id":"827aa3d8d0f7bc8ee10a7fd8dfc6ebff8a5238d7","original_commit_id":"827aa3d8d0f7bc8ee10a7fd8dfc6ebff8a5238d7","user":{"login":"gauntface","id":139760,"avatar_url":"https://avatars0.githubusercontent.com/u/139760?v=4","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false},"body":"The check should stay here - moving it to the module instantiation could break peoples applications.","created_at":"2018-04-13T16:54:01Z","updated_at":"2018-04-13T16:59:47Z","html_url":"https://github.com/firebase/firebase-js-sdk/pull/684#discussion_r181448670","pull_request_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/181448670"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/684#discussion_r181448670"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684","id":181472066,"html_url":"https://github.com/firebase/firebase-js-sdk/pull/684","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/684.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/684.patch","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/684","number":684,"state":"open","locked":false,"title":"Lint rules and refactoring","user":{"login":"mmermerkaya","id":1613860,"avatar_url":"https://avatars2.githubusercontent.com/u/1613860?v=4","gravatar_id":"","url":"https://api.github.com/users/mmermerkaya","html_url":"https://github.com/mmermerkaya","followers_url":"https://api.github.com/users/mmermerkaya/followers","following_url":"https://api.github.com/users/mmermerkaya/following{/other_user}","gists_url":"https://api.github.com/users/mmermerkaya/gists{/gist_id}","starred_url":"https://api.github.com/users/mmermerkaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmermerkaya/subscriptions","organizations_url":"https://api.github.com/users/mmermerkaya/orgs","repos_url":"https://api.github.com/users/mmermerkaya/repos","events_url":"https://api.github.com/users/mmermerkaya/events{/privacy}","received_events_url":"https://api.github.com/users/mmermerkaya/received_events","type":"User","site_admin":false},"body":"Sorry for the large PR, but I wanted to get everything out before the weekend :)\r\n\r\nEnables TSLint rules `no-redundant-jsdoc`, `variable-name` and `no-any` (no-any is still disabled in test/).\r\n\r\nEnables `no-implicit-any` compiler option. With this change, we've enabled all of `--strict` in messaging.\r\n\r\nRefactors ErrorFactory to have only one factory object for all of messaging.\r\n\r\nSome more test and async/await refactoring.\r\n\r\nChanges the `--lib` target to ES2017 for messaging. This is (totally) safe, as messaging only works in [browsers with service worker support](https://www.caniuse.com/#feat=serviceworkers). All of these browsers [support all of ES2017](http://kangax.github.io/compat-table/es2016plus/) (except shared memory and atomics, which is disabled because of meltdown/spectre).\r\n\r\nTo make this even safer, messaging now checks browser support **before** instantiating the service controller. This also prevents issues such as #658 by making sure we don't call any unsupported methods by accident.\r\n","created_at":"2018-04-13T12:21:53Z","updated_at":"2018-04-13T16:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a0440217f956bdbf7b2fc17ce08eef0f678130","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jshcrowthe","id":5588878,"avatar_url":"https://avatars2.githubusercontent.com/u/5588878?v=4","gravatar_id":"","url":"https://api.github.com/users/jshcrowthe","html_url":"https://github.com/jshcrowthe","followers_url":"https://api.github.com/users/jshcrowthe/followers","following_url":"https://api.github.com/users/jshcrowthe/following{/other_user}","gists_url":"https://api.github.com/users/jshcrowthe/gists{/gist_id}","starred_url":"https://api.github.com/users/jshcrowthe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshcrowthe/subscriptions","organizations_url":"https://api.github.com/users/jshcrowthe/orgs","repos_url":"https://api.github.com/users/jshcrowthe/repos","events_url":"https://api.github.com/users/jshcrowthe/events{/privacy}","received_events_url":"https://api.github.com/users/jshcrowthe/received_events","type":"User","site_admin":false},{"login":"pinarx","id":20126085,"avatar_url":"https://avatars1.githubusercontent.com/u/20126085?v=4","gravatar_id":"","url":"https://api.github.com/users/pinarx","html_url":"https://github.com/pinarx","followers_url":"https://api.github.com/users/pinarx/followers","following_url":"https://api.github.com/users/pinarx/following{/other_user}","gists_url":"https://api.github.com/users/pinarx/gists{/gist_id}","starred_url":"https://api.github.com/users/pinarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinarx/subscriptions","organizations_url":"https://api.github.com/users/pinarx/orgs","repos_url":"https://api.github.com/users/pinarx/repos","events_url":"https://api.github.com/users/pinarx/events{/privacy}","received_events_url":"https://api.github.com/users/pinarx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":628179960,"url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels/Component-Messaging","name":"Component-Messaging","color":"FFEFBD","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/684/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/827aa3d8d0f7bc8ee10a7fd8dfc6ebff8a5238d7","head":{"label":"firebase:mmermerkaya-no-any","ref":"mmermerkaya-no-any","sha":"827aa3d8d0f7bc8ee10a7fd8dfc6ebff8a5238d7","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-04-13T09:15:25Z","pushed_at":"2018-04-13T16:07:36Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":15481,"stargazers_count":1029,"watchers_count":1029,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":139,"open_issues":133,"watchers":1029,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"05e05b81dc84cf89a62af6da3b19ca2480c0006a","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-04-13T09:15:25Z","pushed_at":"2018-04-13T16:07:36Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":15481,"stargazers_count":1029,"watchers_count":1029,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":139,"open_issues":133,"watchers":1029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/684"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/684"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/827aa3d8d0f7bc8ee10a7fd8dfc6ebff8a5238d7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gauntface"}}