{"action":"created","issue":{"url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/123","repository_url":"https://api.github.com/repos/badcamp/badcamp-2018","labels_url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/123/comments","events_url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/123/events","html_url":"https://github.com/badcamp/badcamp-2018/issues/123","id":331447726,"node_id":"MDU6SXNzdWUzMzE0NDc3MjY=","number":123,"title":"Session Submission QA Feedback","user":{"login":"JQTNguyen","id":3485338,"node_id":"MDQ6VXNlcjM0ODUzMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3485338?v=4","gravatar_id":"","url":"https://api.github.com/users/JQTNguyen","html_url":"https://github.com/JQTNguyen","followers_url":"https://api.github.com/users/JQTNguyen/followers","following_url":"https://api.github.com/users/JQTNguyen/following{/other_user}","gists_url":"https://api.github.com/users/JQTNguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/JQTNguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JQTNguyen/subscriptions","organizations_url":"https://api.github.com/users/JQTNguyen/orgs","repos_url":"https://api.github.com/users/JQTNguyen/repos","events_url":"https://api.github.com/users/JQTNguyen/events{/privacy}","received_events_url":"https://api.github.com/users/JQTNguyen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sean-e-dietrich","id":1564748,"node_id":"MDQ6VXNlcjE1NjQ3NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1564748?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-e-dietrich","html_url":"https://github.com/sean-e-dietrich","followers_url":"https://api.github.com/users/sean-e-dietrich/followers","following_url":"https://api.github.com/users/sean-e-dietrich/following{/other_user}","gists_url":"https://api.github.com/users/sean-e-dietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-e-dietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-e-dietrich/subscriptions","organizations_url":"https://api.github.com/users/sean-e-dietrich/orgs","repos_url":"https://api.github.com/users/sean-e-dietrich/repos","events_url":"https://api.github.com/users/sean-e-dietrich/events{/privacy}","received_events_url":"https://api.github.com/users/sean-e-dietrich/received_events","type":"User","site_admin":false},"assignees":[{"login":"sean-e-dietrich","id":1564748,"node_id":"MDQ6VXNlcjE1NjQ3NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1564748?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-e-dietrich","html_url":"https://github.com/sean-e-dietrich","followers_url":"https://api.github.com/users/sean-e-dietrich/followers","following_url":"https://api.github.com/users/sean-e-dietrich/following{/other_user}","gists_url":"https://api.github.com/users/sean-e-dietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-e-dietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-e-dietrich/subscriptions","organizations_url":"https://api.github.com/users/sean-e-dietrich/orgs","repos_url":"https://api.github.com/users/sean-e-dietrich/repos","events_url":"https://api.github.com/users/sean-e-dietrich/events{/privacy}","received_events_url":"https://api.github.com/users/sean-e-dietrich/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-12T05:59:03Z","updated_at":"2018-06-25T21:58:13Z","closed_at":null,"author_association":"NONE","body":"**Node/Add Form**\r\n- [x] Required fields are missing iconography to denote that they are required.\r\n- [x] Change label \"SPEAKERS\" → \"BADCamp User Names of Speakers\" \r\n- [x] Change help text of \"Who is speaking at this session?\" → \"Who is speaking at this session? (Must have an account on this site.)\"\r\n- [x] \"Who is speaking at this session?\" text and \"Add another item\" buttons are pushed up against each other.\r\n- [x] Text on the Skill Level Dropdown Menu is FRIGGIN' HUGE.\r\n- [x] Change \"Skill Level\" help text to \"What level of experience does the person attending need to have to understand your topic?\"\r\n- [x] Same goes for the Session Track Fields.\r\n- [x] Change label \"Track\" → \"Presentation Topics\" \r\n- [ ] Change \"Track\" help text to ```Select up to three Presentation Topics that fit your session in order of relevance, with the first being the best fit.<br><br>Options are: APIs, Architecture, Automation, Backend Development, Being Human, Beyond Drupal, Big Ideas, Business, Career Development, Case Study, Community, Content Strategy, CSS, Culture, Data, Decoupled, Design, DevOps, Drupal Community, Drupal Core, Editor Experience, Front End Development, Javascript, Leadership, Mental Health, People Management, Performance, PHP, Process, Project Management, Scaling, Security, Site Building, Testing, UX```\r\n- [x] Change \"Body\" help text to \"In as much detail as possible, what is your session about?\"\r\n- [x] For \"Files\", add help text: \"Upload your slide deck to help the selection committee before BADCamp OR upload your slide deck after your talk.\"\r\n\r\n\r\n**Submitted Sessions**\r\n\r\n_URLs to Example Sessions:_ \r\n- [ ] https://pr-118-badcamp-2018.pantheonsite.io/session/its-not-easy-being-green\r\n- [ ] https://pr-118-badcamp-2018.pantheonsite.io/session/you-leap\r\n- [ ] https://pr-118-badcamp-2018.pantheonsite.io/session/simple\r\n---\r\n- [x] Anonymous Users are unable to view Speakers on the Session node.\r\n- [x] After a Session that has multiple Tracks is submitted, the Node is created, but the following error is displayed on the resulting Node:  ```Notice: Undefined index: field_delimiter in field_delimiter_preprocess_field() (line 84 of modules/contrib/field_delimiter/field_delimiter.module).```\r\n- [ ] In the Speakers section of the page, there is a \"/\" that appears in between Multiple Speakers.\r\n- [ ] Should a Label be added for the username?\r\n- [x] Both \"Skill Level\" and \"Tracks\" do not appear with a label, and are smashed together next to the everything.\r\n- [x] Add some spacing between between the Description and the Smashed Together Tags.\r\n- [x] Do not display the Sponsors Labels when there are No Sponsors.\r\n- [x] For \"Interested\" button, add the text \"Interested in attending this session? Letting us know helps us allocate space. The more people that show interest, the bigger the room we will attempt to book. Click the button below to let us know.\"\r\n   - [ ] Suggestion: Add \"Thank you for letting us know you are interested in this session!\" text after submission, perhaps like https://github.com/sweetalert2/sweetalert2\r\n- [ ] In general, just make it a bit more presentable. ;D\r\n\r\n----\r\n\r\nGo through the Session Submission Registration process starting at https://pr-118-badcamp-2018.pantheonsite.io/node/add/session.  This should include:\r\n\r\n1. The [Node/Add/Session](https://pr-118-badcamp-2018.pantheonsite.io/node/add/session) Form\r\n2. The Node for the resulting Submitted Session\r\n\r\nPlease leave any feedback as a comment in this thread, and it will later be collected into One Giant List by John."},"comment":{"url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/comments/400109258","html_url":"https://github.com/badcamp/badcamp-2018/issues/123#issuecomment-400109258","issue_url":"https://api.github.com/repos/badcamp/badcamp-2018/issues/123","id":400109258,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDEwOTI1OA==","user":{"login":"JQTNguyen","id":3485338,"node_id":"MDQ6VXNlcjM0ODUzMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3485338?v=4","gravatar_id":"","url":"https://api.github.com/users/JQTNguyen","html_url":"https://github.com/JQTNguyen","followers_url":"https://api.github.com/users/JQTNguyen/followers","following_url":"https://api.github.com/users/JQTNguyen/following{/other_user}","gists_url":"https://api.github.com/users/JQTNguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/JQTNguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JQTNguyen/subscriptions","organizations_url":"https://api.github.com/users/JQTNguyen/orgs","repos_url":"https://api.github.com/users/JQTNguyen/repos","events_url":"https://api.github.com/users/JQTNguyen/events{/privacy}","received_events_url":"https://api.github.com/users/JQTNguyen/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T21:58:13Z","updated_at":"2018-06-25T21:58:13Z","author_association":"NONE","body":"@sean-e-dietrich: Another round of Feedback before Merge...\r\n\r\n----\r\n\r\n**Node/Add Form**\r\n\r\n- [ ] **Presentation Topics:** Because this is a required field, all three topics need to be filled in, which may results in an awkward situation for presenters who only want to select one or two.\r\n- [ ] The following message is encountered after submitting or editing a Session:\r\n\r\n```\r\nNotice: Undefined index: #value in Drupal\\multiple_selects\\Plugin\\Field\\FieldWidget\\OptionsMultipleSelectWidget::validateElement() (line 44 of modules/contrib/multiple_selects/src/Plugin/Field/FieldWidget/OptionsMultipleSelectWidget.php).\r\n\r\nDrupal\\multiple_selects\\Plugin\\Field\\FieldWidget\\OptionsMultipleSelectWidget::validateElement(Array, Object, Array)\r\ncall_user_func_array(Array, Array) (Line: 283)\r\nDrupal\\Core\\Form\\FormValidator->doValidateForm(Array, Object) (Line: 239)\r\nDrupal\\Core\\Form\\FormValidator->doValidateForm(Array, Object) (Line: 239)\r\nDrupal\\Core\\Form\\FormValidator->doValidateForm(Array, Object) (Line: 239)\r\nDrupal\\Core\\Form\\FormValidator->doValidateForm(Array, Object, 'node_session_edit_form') (Line: 119)\r\nDrupal\\Core\\Form\\FormValidator->validateForm('node_session_edit_form', Array, Object) (Line: 571)\r\nDrupal\\Core\\Form\\FormBuilder->processForm('node_session_edit_form', Array, Object) (Line: 314)\r\nDrupal\\Core\\Form\\FormBuilder->buildForm('node_session_edit_form', Object) (Line: 74)\r\nDrupal\\Core\\Controller\\FormController->getContentResult(Object, Object)\r\ncall_user_func_array(Array, Array) (Line: 123)\r\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->Drupal\\Core\\EventSubscriber\\{closure}() (Line: 582)\r\nDrupal\\Core\\Render\\Renderer->executeInRenderContext(Object, Object) (Line: 124)\r\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)\r\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->Drupal\\Core\\EventSubscriber\\{closure}() (Line: 151)\r\nSymfony\\Component\\HttpKernel\\HttpKernel->handleRaw(Object, 1) (Line: 68)\r\nSymfony\\Component\\HttpKernel\\HttpKernel->handle(Object, 1, 1) (Line: 57)\r\nDrupal\\Core\\StackMiddleware\\Session->handle(Object, 1, 1) (Line: 47)\r\nDrupal\\Core\\StackMiddleware\\KernelPreHandle->handle(Object, 1, 1) (Line: 99)\r\nDrupal\\page_cache\\StackMiddleware\\PageCache->pass(Object, 1, 1) (Line: 78)\r\nDrupal\\page_cache\\StackMiddleware\\PageCache->handle(Object, 1, 1) (Line: 47)\r\nDrupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)\r\nDrupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)\r\nStack\\StackedHttpKernel->handle(Object, 1, 1) (Line: 664)\r\nDrupal\\Core\\DrupalKernel->handle(Object) (Line: 19)\r\n```\r\n\r\n \r\n**Submitted Sessions**\r\n\r\n_URLs to Example Sessions:_\r\n\r\n- https://pr-118-badcamp-2018.pantheonsite.io/session/its-not-easy-being-green\r\n- https://pr-118-badcamp-2018.pantheonsite.io/session/simple\r\n\r\n----\r\n\r\n- [ ] The spacing after the iconography for Skill Level, Presentation Topics, and Speakers and before its contents is not consistent.\r\n  - Level and Speakers is the same, but Presentation Topics is different.\r\n  - For my money's worth, Presentation Topics looks the best.\r\n- **Suggestion:** Add Text Label in addition to the Iconography for Accessibility reasons, and also because it may not be clear to users what each Icon represents.\r\n- **Sponsors:** This heading appears, regardless of whether or not any Sponsors are actually selected (see [Simple Session](https://pr-118-badcamp-2018.pantheonsite.io/session/simple))."}}
{"actor":{"display_login":"JQTNguyen"}}