{"action":"closed","number":8866,"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/8866","id":227077338,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDc3MzM4","html_url":"https://github.com/coq/coq/pull/8866","diff_url":"https://github.com/coq/coq/pull/8866.diff","patch_url":"https://github.com/coq/coq/pull/8866.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/8866","number":8866,"state":"closed","locked":false,"title":"Check universe instances in Typing","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"body":"I've seen people mistakenly use eg `mkConst` on polymorphic constants and get undefined `Var(0)` exceptions as the type got substituted with the empty instance leaving the `Var(0)` alone. This should make things clearer for that use case.\r\n\r\nIn general it makes more sense for Typing to do this check than not.\r\n\r\nhttps://ci.inria.fr/coq/view/benchmarking/job/benchmark-part-of-the-branch/566/console","created_at":"2018-10-30T20:52:30Z","updated_at":"2018-11-05T12:21:28Z","closed_at":"2018-11-05T12:21:28Z","merged_at":"2018-11-05T12:21:28Z","merge_commit_sha":"f18ea56a697fe27467e499d35495e18b866de371","assignee":{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"assignees":[{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":723611231,"node_id":"MDU6TGFiZWw3MjM2MTEyMzE=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20enhancement","name":"kind: enhancement","color":"0e8a16","default":false},{"id":755681591,"node_id":"MDU6TGFiZWw3NTU2ODE1OTE=","url":"https://api.github.com/repos/coq/coq/labels/part:%20universes","name":"part: universes","color":"dddddd","default":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/16","html_url":"https://github.com/coq/coq/milestone/16","labels_url":"https://api.github.com/repos/coq/coq/milestones/16/labels","id":3512681,"node_id":"MDk6TWlsZXN0b25lMzUxMjY4MQ==","number":16,"title":"8.10+beta1","description":"","creator":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":106,"closed_issues":222,"state":"open","created_at":"2018-07-20T18:48:13Z","updated_at":"2018-11-05T12:21:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/coq/coq/pulls/8866/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/8866/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/8866/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/f18ea56a697fe27467e499d35495e18b866de371","head":{"label":"SkySkimmer:check-instance-length","ref":"check-instance-length","sha":"f18ea56a697fe27467e499d35495e18b866de371","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"repo":{"id":76260922,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI2MDkyMg==","name":"coq","full_name":"SkySkimmer/coq","private":false,"owner":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SkySkimmer/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/SkySkimmer/coq","forks_url":"https://api.github.com/repos/SkySkimmer/coq/forks","keys_url":"https://api.github.com/repos/SkySkimmer/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkySkimmer/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkySkimmer/coq/teams","hooks_url":"https://api.github.com/repos/SkySkimmer/coq/hooks","issue_events_url":"https://api.github.com/repos/SkySkimmer/coq/issues/events{/number}","events_url":"https://api.github.com/repos/SkySkimmer/coq/events","assignees_url":"https://api.github.com/repos/SkySkimmer/coq/assignees{/user}","branches_url":"https://api.github.com/repos/SkySkimmer/coq/branches{/branch}","tags_url":"https://api.github.com/repos/SkySkimmer/coq/tags","blobs_url":"https://api.github.com/repos/SkySkimmer/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkySkimmer/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkySkimmer/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkySkimmer/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkySkimmer/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/SkySkimmer/coq/languages","stargazers_url":"https://api.github.com/repos/SkySkimmer/coq/stargazers","contributors_url":"https://api.github.com/repos/SkySkimmer/coq/contributors","subscribers_url":"https://api.github.com/repos/SkySkimmer/coq/subscribers","subscription_url":"https://api.github.com/repos/SkySkimmer/coq/subscription","commits_url":"https://api.github.com/repos/SkySkimmer/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkySkimmer/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkySkimmer/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkySkimmer/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkySkimmer/coq/contents/{+path}","compare_url":"https://api.github.com/repos/SkySkimmer/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkySkimmer/coq/merges","archive_url":"https://api.github.com/repos/SkySkimmer/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkySkimmer/coq/downloads","issues_url":"https://api.github.com/repos/SkySkimmer/coq/issues{/number}","pulls_url":"https://api.github.com/repos/SkySkimmer/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/SkySkimmer/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/SkySkimmer/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkySkimmer/coq/labels{/name}","releases_url":"https://api.github.com/repos/SkySkimmer/coq/releases{/id}","deployments_url":"https://api.github.com/repos/SkySkimmer/coq/deployments","created_at":"2016-12-12T13:56:45Z","updated_at":"2018-11-05T11:40:41Z","pushed_at":"2018-11-05T12:17:17Z","git_url":"git://github.com/SkySkimmer/coq.git","ssh_url":"git@github.com:SkySkimmer/coq.git","clone_url":"https://github.com/SkySkimmer/coq.git","svn_url":"https://github.com/SkySkimmer/coq","homepage":"http://coq.inria.fr/","size":106803,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"d32301dde8071acc914286c675b9749e27f368d2","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","private":false,"owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-11-05T12:07:28Z","pushed_at":"2018-11-05T12:21:03Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":118728,"stargazers_count":1588,"watchers_count":1588,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":1874,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":287,"open_issues":1874,"watchers":1588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/8866"},"html":{"href":"https://github.com/coq/coq/pull/8866"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/8866"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/8866/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/8866/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/8866/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/f18ea56a697fe27467e499d35495e18b866de371"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":69,"deletions":61,"changed_files":7}}
{"actor":{"display_login":"ppedrot"}}