{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/jwst/issues/2399","repository_url":"https://api.github.com/repos/spacetelescope/jwst","labels_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2399/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2399/comments","events_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2399/events","html_url":"https://github.com/spacetelescope/jwst/issues/2399","id":352586875,"node_id":"MDU6SXNzdWUzNTI1ODY4NzU=","number":2399,"title":"create_data uses wrong subarray sizes for MIRI","user":{"login":"stscijgbot","id":38438914,"node_id":"MDQ6VXNlcjM4NDM4OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/38438914?v=4","gravatar_id":"","url":"https://api.github.com/users/stscijgbot","html_url":"https://github.com/stscijgbot","followers_url":"https://api.github.com/users/stscijgbot/followers","following_url":"https://api.github.com/users/stscijgbot/following{/other_user}","gists_url":"https://api.github.com/users/stscijgbot/gists{/gist_id}","starred_url":"https://api.github.com/users/stscijgbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stscijgbot/subscriptions","organizations_url":"https://api.github.com/users/stscijgbot/orgs","repos_url":"https://api.github.com/users/stscijgbot/repos","events_url":"https://api.github.com/users/stscijgbot/events{/privacy}","received_events_url":"https://api.github.com/users/stscijgbot/received_events","type":"User","site_admin":false},"labels":[{"id":991810932,"node_id":"MDU6TGFiZWw5OTE4MTA5MzI=","url":"https://api.github.com/repos/spacetelescope/jwst/labels/jira","name":"jira","color":"53b0b5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-21T15:10:06Z","updated_at":"2018-08-22T11:40:36Z","closed_at":null,"author_association":"COLLABORATOR","body":"Issue [JP-360](https://jira.stsci.edu/browse/JP-360) was created by Misty Cracraft:\n\nI haven't used create_data much for subarray data, but my recent test gave SUBARRAY=GENERIC for both subarrays I tried. When I went back to look at the subarray definitions in the code, I see that the code seems to be working from some very old parameters for the sizes of the subarrays. The subarrays should be defined as shown here:\r\n|Subarray|frame time|colstart|rowstart|ncols|nrows|\r\n|BRIGHTSKY|0.865|457|51|512|512|\r\n|SLITLESSPRISM|0.159|1|529|72|416|\r\n|SUB256|0.3|413|51|256|256|\r\n|SUB128|0.119|1|889|136|128|\r\n|SUB64|0.085|1|779|72|64|\r\n|MASKLYOT|0.324|1|717|320|304|\r\n|MASK1550|0.24|1|467|288|224|\r\n|MASK1140|0.24|1|245|288|224|\r\n|MASK1065|0.24|1|19|288|224|\r\n\r\n \r\n\r\nInstead, they seem to be defined as they were for FM data back in 2011.\r\n|Subarray|frame time|colstart|rowstart|ncols|nrows|\r\n| | | | | | |\r\n|BRIGHTSKY| |1|1|864|512|\r\n|SLITLESSPRISM| |1|321|68|704|\r\n|SUB256| |1|1|608|256|\r\n|SUB128| |1|897|132|128|\r\n|SUB64| |1|897|68|64|\r\n|MASKLYOT| |1|705|320|320|\r\n|MASK1550| |1|452|256|256|\r\n|MASK1140| |1|229|256|256|\r\n|MASK1065| |1|1|256|256|\r\n\r\n \r\n\r\nFor now, I'll just change the value myself in the file header, but this won't work for Subarray data as the script currently stands."},"comment":{"url":"https://api.github.com/repos/spacetelescope/jwst/issues/comments/415003341","html_url":"https://github.com/spacetelescope/jwst/issues/2399#issuecomment-415003341","issue_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2399","id":415003341,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTAwMzM0MQ==","user":{"login":"stscijgbot","id":38438914,"node_id":"MDQ6VXNlcjM4NDM4OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/38438914?v=4","gravatar_id":"","url":"https://api.github.com/users/stscijgbot","html_url":"https://github.com/stscijgbot","followers_url":"https://api.github.com/users/stscijgbot/followers","following_url":"https://api.github.com/users/stscijgbot/following{/other_user}","gists_url":"https://api.github.com/users/stscijgbot/gists{/gist_id}","starred_url":"https://api.github.com/users/stscijgbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stscijgbot/subscriptions","organizations_url":"https://api.github.com/users/stscijgbot/orgs","repos_url":"https://api.github.com/users/stscijgbot/repos","events_url":"https://api.github.com/users/stscijgbot/events{/privacy}","received_events_url":"https://api.github.com/users/stscijgbot/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T11:40:36Z","updated_at":"2018-08-22T11:40:36Z","author_association":"COLLABORATOR","body":"Comment by Rosa Diaz: Roert,\r\n\r\n   Daryl was trying to put this information in the PRD; however, I am trying to collect all this information (along with other things) to put in a place accessible to the instrument teams, SCSB, DMSWG, ReDCaT. Eventually this might end somewhere managed in collaboration between SCSB and ReDCaT. For now the latest values should be kept up to date in ReDCaT issues 49 to 53. Though we don't have the frame-time there. Maybe we should add it too."}}
{"actor":{"display_login":"stscijgbot"}}