{"action":"created","issue":{"url":"https://api.github.com/repos/qpdf/qpdf/issues/233","repository_url":"https://api.github.com/repos/qpdf/qpdf","labels_url":"https://api.github.com/repos/qpdf/qpdf/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/qpdf/qpdf/issues/233/comments","events_url":"https://api.github.com/repos/qpdf/qpdf/issues/233/events","html_url":"https://github.com/qpdf/qpdf/issues/233","id":349799335,"node_id":"MDU6SXNzdWUzNDk3OTkzMzU=","number":233,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"node_id":"MDQ6VXNlcjY2MDQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-12T09:48:20Z","updated_at":"2018-08-12T17:29:46Z","closed_at":null,"author_association":"NONE","body":"I would like to point out that identifiers like “[`__POINTERHOLDER_HH__`](https://github.com/qpdf/qpdf/blob/68572df2bf0c6d1d7756ff05a96e01d7e2f69c09/include/qpdf/PointerHolder.hh#L22 \"Update candidate\")” and “[`__PL_QPDFTOKENIZER_HH__`](https://github.com/qpdf/qpdf/blob/651b51f0564d7726df09faf6ac0a0dd36e4fa65a/include/qpdf/Pl_QPDFTokenizer.hh#L22 \"Another update candidate\")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not declare an identifier which is reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/qpdf/qpdf/issues/comments/412358548","html_url":"https://github.com/qpdf/qpdf/issues/233#issuecomment-412358548","issue_url":"https://api.github.com/repos/qpdf/qpdf/issues/233","id":412358548,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjM1ODU0OA==","user":{"login":"elfring","id":660477,"node_id":"MDQ6VXNlcjY2MDQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T17:29:46Z","updated_at":"2018-08-12T17:29:46Z","author_association":"NONE","body":"[You tampered with the reserved name space](https://en.cppreference.com/w/c/language/identifier#Reserved_identifiers \"Description for reserved identifiers\"), didn't you?\r\n\r\nI found mentioned update candidates by [ordinary source code review](https://en.wikipedia.org/wiki/Code_review \"Description for code review\")."}}
{"actor":{"display_login":"elfring"}}