{"action":"created","comment":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments/234327111","pull_request_review_id":175954063,"id":234327111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMyNzExMQ==","diff_hunk":"@@ -0,0 +1,134 @@\n+// Copyright 2018 The go-ethereum Authors\n+// This file is part of the go-ethereum library.\n+//\n+// The go-ethereum library is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU Lesser General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+//\n+// The go-ethereum library is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU Lesser General Public License for more details.\n+//\n+// You should have received a copy of the GNU Lesser General Public License\n+// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.\n+\n+package protocols\n+\n+import (\n+\t\"encoding/binary\"\n+\t\"time\"\n+\n+\t\"github.com/ethereum/go-ethereum/log\"\n+\t\"github.com/ethereum/go-ethereum/metrics\"\n+\n+\t\"github.com/syndtr/goleveldb/leveldb\"\n+)\n+\n+//reporter is an internal structure used to write p2p accounting related\n+//metrics to a LevelDB. It will periodically write the accrued metrics to the DB.\n+type reporter struct {\n+\treg      metrics.Registry //the registry for these metrics (independent of other metrics)\n+\tinterval time.Duration    //duration at which the reporter will persist metrics\n+\tdb       *leveldb.DB      //the actual DB\n+}\n+\n+//NewMetricsDB creates a new LevelDB instance used to persist metrics defined\n+//inside p2p/protocols/accounting.go\n+func NewMetricsDB(r metrics.Registry, d time.Duration, path string) *leveldb.DB {\n+\tvar val = make([]byte, 8)\n+\tvar err error\n+\n+\t//Create the LevelDB\n+\tdb, err := leveldb.OpenFile(path, nil)\n+\tif err != nil {\n+\t\tlog.Error(err.Error())\n+\t\treturn nil\n+\t}\n+\n+\t//Check for all defined metrics that there is a value in the DB\n+\t//If there is, assign it to the metric. This means that the node\n+\t//has been running before and that metrics have been persisted.\n+\tval, err = db.Get([]byte(\"account.balance.credit\"), nil)\n+\tif err == nil {\n+\t\tmBalanceCredit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.balance.debit\"), nil)\n+\tif err == nil {\n+\t\tmBalanceDebit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.bytes.credit\"), nil)\n+\tif err == nil {\n+\t\tmBytesCredit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.bytes.debit\"), nil)\n+\tif err == nil {\n+\t\tmBytesDebit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.msg.credit\"), nil)\n+\tif err == nil {\n+\t\tmMsgCredit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.msg.debit\"), nil)\n+\tif err == nil {\n+\t\tmMsgDebit.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.peerdrops\"), nil)\n+\tif err == nil {\n+\t\tmPeerDrops.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\tval, err = db.Get([]byte(\"account.selfdrops\"), nil)\n+\tif err == nil {\n+\t\tmSelfDrops.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t}\n+\n+\t//create the reporter\n+\treg := &reporter{\n+\t\treg:      r,\n+\t\tinterval: d,\n+\t\tdb:       db,\n+\t}\n+\n+\t//run the go routine\n+\tgo reg.run()\n+\n+\treturn db\n+\n+}\n+\n+//run is the go routine which periodically sends the metrics to the configued LevelDB\n+func (r *reporter) run() {\n+\tintervalTicker := time.NewTicker(r.interval)\n+\n+\tfor _ = range intervalTicker.C {\n+\t\t//at each tick send the metrics\n+\t\tif err := r.send(); err != nil {\n+\t\t\tlog.Error(\"unable to send metrics to LevelDB. err=%v\", \"err\", err)\n+\t\t\t//If there is an error in writing, exit the routine; we assume here that the error is\n+\t\t\t//severe and don't attempt to write again.\n+\t\t\t//Also, this should prevent leaking when the node is stopped","path":"p2p/protocols/reporter.go","position":110,"original_position":110,"commit_id":"2f08ce9c1683b8024e47e1962053116b120fa6c3","original_commit_id":"2f08ce9c1683b8024e47e1962053116b120fa6c3","user":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"body":"Is this enough of a strategy to prevent leaking? Ideally it should be gracefully stopped when the node shuts down, but I am not sure if this reporter needs that functionality?","created_at":"2018-11-16T19:45:51Z","updated_at":"2018-11-16T19:45:51Z","html_url":"https://github.com/ethersphere/go-ethereum/pull/1004#discussion_r234327111","pull_request_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments/234327111"},"html":{"href":"https://github.com/ethersphere/go-ethereum/pull/1004#discussion_r234327111"},"pull_request":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004"}}},"pull_request":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004","id":231636049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjM2MDQ5","html_url":"https://github.com/ethersphere/go-ethereum/pull/1004","diff_url":"https://github.com/ethersphere/go-ethereum/pull/1004.diff","patch_url":"https://github.com/ethersphere/go-ethereum/pull/1004.patch","issue_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1004","number":1004,"state":"open","locked":false,"title":"Swap metrics reporter","user":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"body":"This PR introduces metrics persistence to p2p accounting.\r\n\r\nThis PR is only for review and will be opened on the ethereum repo","created_at":"2018-11-16T19:43:57Z","updated_at":"2018-11-16T19:45:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a20a075f802717e455fb4dbb7be71be1beac5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nonsense","id":50459,"node_id":"MDQ6VXNlcjUwNDU5","avatar_url":"https://avatars0.githubusercontent.com/u/50459?v=4","gravatar_id":"","url":"https://api.github.com/users/nonsense","html_url":"https://github.com/nonsense","followers_url":"https://api.github.com/users/nonsense/followers","following_url":"https://api.github.com/users/nonsense/following{/other_user}","gists_url":"https://api.github.com/users/nonsense/gists{/gist_id}","starred_url":"https://api.github.com/users/nonsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonsense/subscriptions","organizations_url":"https://api.github.com/users/nonsense/orgs","repos_url":"https://api.github.com/users/nonsense/repos","events_url":"https://api.github.com/users/nonsense/events{/privacy}","received_events_url":"https://api.github.com/users/nonsense/received_events","type":"User","site_admin":false},{"login":"zelig","id":769725,"node_id":"MDQ6VXNlcjc2OTcyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/769725?v=4","gravatar_id":"","url":"https://api.github.com/users/zelig","html_url":"https://github.com/zelig","followers_url":"https://api.github.com/users/zelig/followers","following_url":"https://api.github.com/users/zelig/following{/other_user}","gists_url":"https://api.github.com/users/zelig/gists{/gist_id}","starred_url":"https://api.github.com/users/zelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelig/subscriptions","organizations_url":"https://api.github.com/users/zelig/orgs","repos_url":"https://api.github.com/users/zelig/repos","events_url":"https://api.github.com/users/zelig/events{/privacy}","received_events_url":"https://api.github.com/users/zelig/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004/commits","review_comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004/comments","review_comment_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1004/comments","statuses_url":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/2f08ce9c1683b8024e47e1962053116b120fa6c3","head":{"label":"holisticode:swap-metrics-reporter","ref":"swap-metrics-reporter","sha":"2f08ce9c1683b8024e47e1962053116b120fa6c3","user":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"repo":{"id":80787491,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4NzQ5MQ==","name":"go-ethereum","full_name":"holisticode/go-ethereum","private":false,"owner":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"html_url":"https://github.com/holisticode/go-ethereum","description":"Ethereum Go","fork":true,"url":"https://api.github.com/repos/holisticode/go-ethereum","forks_url":"https://api.github.com/repos/holisticode/go-ethereum/forks","keys_url":"https://api.github.com/repos/holisticode/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holisticode/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holisticode/go-ethereum/teams","hooks_url":"https://api.github.com/repos/holisticode/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/holisticode/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/holisticode/go-ethereum/events","assignees_url":"https://api.github.com/repos/holisticode/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/holisticode/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/holisticode/go-ethereum/tags","blobs_url":"https://api.github.com/repos/holisticode/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holisticode/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holisticode/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/holisticode/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holisticode/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/holisticode/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/holisticode/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/holisticode/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/holisticode/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/holisticode/go-ethereum/subscription","commits_url":"https://api.github.com/repos/holisticode/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/holisticode/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/holisticode/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/holisticode/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/holisticode/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/holisticode/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holisticode/go-ethereum/merges","archive_url":"https://api.github.com/repos/holisticode/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holisticode/go-ethereum/downloads","issues_url":"https://api.github.com/repos/holisticode/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/holisticode/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/holisticode/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/holisticode/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holisticode/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/holisticode/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/holisticode/go-ethereum/deployments","created_at":"2017-02-03T01:45:52Z","updated_at":"2017-02-03T01:46:03Z","pushed_at":"2018-11-16T19:39:01Z","git_url":"git://github.com/holisticode/go-ethereum.git","ssh_url":"git@github.com:holisticode/go-ethereum.git","clone_url":"https://github.com/holisticode/go-ethereum.git","svn_url":"https://github.com/holisticode/go-ethereum","homepage":"","size":104840,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethersphere:master","ref":"master","sha":"68be45e5f89a5bde33376a8e103c133392f18516","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"go-ethereum","full_name":"ethersphere/go-ethereum","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/go-ethereum","description":"Ethereum Go","fork":true,"url":"https://api.github.com/repos/ethersphere/go-ethereum","forks_url":"https://api.github.com/repos/ethersphere/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethersphere/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethersphere/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethersphere/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethersphere/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethersphere/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/go-ethereum/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2018-11-16T14:34:35Z","pushed_at":"2018-11-16T19:43:58Z","git_url":"git://github.com/ethersphere/go-ethereum.git","ssh_url":"git@github.com:ethersphere/go-ethereum.git","clone_url":"https://github.com/ethersphere/go-ethereum.git","svn_url":"https://github.com/ethersphere/go-ethereum","homepage":"","size":109597,"stargazers_count":117,"watchers_count":117,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":37,"open_issues":177,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004"},"html":{"href":"https://github.com/ethersphere/go-ethereum/pull/1004"},"issue":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1004"},"comments":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1004/comments"},"review_comments":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004/comments"},"review_comment":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1004/commits"},"statuses":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/2f08ce9c1683b8024e47e1962053116b120fa6c3"}},"author_association":"NONE"}}
{"actor":{"display_login":"holisticode"}}