{"action":"created","issue":{"url":"https://api.github.com/repos/peterwebster/henson/issues/100","repository_url":"https://api.github.com/repos/peterwebster/henson","labels_url":"https://api.github.com/repos/peterwebster/henson/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/peterwebster/henson/issues/100/comments","events_url":"https://api.github.com/repos/peterwebster/henson/issues/100/events","html_url":"https://github.com/peterwebster/henson/issues/100","id":330642831,"node_id":"MDU6SXNzdWUzMzA2NDI4MzE=","number":100,"title":"Missing mark-up: letters and quotes","user":{"login":"nomoregrapes","id":1181194,"node_id":"MDQ6VXNlcjExODExOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1181194?v=4","gravatar_id":"","url":"https://api.github.com/users/nomoregrapes","html_url":"https://github.com/nomoregrapes","followers_url":"https://api.github.com/users/nomoregrapes/followers","following_url":"https://api.github.com/users/nomoregrapes/following{/other_user}","gists_url":"https://api.github.com/users/nomoregrapes/gists{/gist_id}","starred_url":"https://api.github.com/users/nomoregrapes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomoregrapes/subscriptions","organizations_url":"https://api.github.com/users/nomoregrapes/orgs","repos_url":"https://api.github.com/users/nomoregrapes/repos","events_url":"https://api.github.com/users/nomoregrapes/events{/privacy}","received_events_url":"https://api.github.com/users/nomoregrapes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"DurHHHI","id":32575577,"node_id":"MDQ6VXNlcjMyNTc1NTc3","avatar_url":"https://avatars3.githubusercontent.com/u/32575577?v=4","gravatar_id":"","url":"https://api.github.com/users/DurHHHI","html_url":"https://github.com/DurHHHI","followers_url":"https://api.github.com/users/DurHHHI/followers","following_url":"https://api.github.com/users/DurHHHI/following{/other_user}","gists_url":"https://api.github.com/users/DurHHHI/gists{/gist_id}","starred_url":"https://api.github.com/users/DurHHHI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DurHHHI/subscriptions","organizations_url":"https://api.github.com/users/DurHHHI/orgs","repos_url":"https://api.github.com/users/DurHHHI/repos","events_url":"https://api.github.com/users/DurHHHI/events{/privacy}","received_events_url":"https://api.github.com/users/DurHHHI/received_events","type":"User","site_admin":false},"assignees":[{"login":"DurHHHI","id":32575577,"node_id":"MDQ6VXNlcjMyNTc1NTc3","avatar_url":"https://avatars3.githubusercontent.com/u/32575577?v=4","gravatar_id":"","url":"https://api.github.com/users/DurHHHI","html_url":"https://github.com/DurHHHI","followers_url":"https://api.github.com/users/DurHHHI/followers","following_url":"https://api.github.com/users/DurHHHI/following{/other_user}","gists_url":"https://api.github.com/users/DurHHHI/gists{/gist_id}","starred_url":"https://api.github.com/users/DurHHHI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DurHHHI/subscriptions","organizations_url":"https://api.github.com/users/DurHHHI/orgs","repos_url":"https://api.github.com/users/DurHHHI/repos","events_url":"https://api.github.com/users/DurHHHI/events{/privacy}","received_events_url":"https://api.github.com/users/DurHHHI/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-08T12:41:40Z","updated_at":"2018-06-11T07:50:34Z","closed_at":null,"author_association":"COLLABORATOR","body":"I noticed some markup was being ignored.\r\n\r\nQuotes: `<div type=\"quote\">` [example](http://10.245.28.108:3000/journals/05-02-12-05-17)\r\nIs styled in the standard HTML \"blockquote\" way, is this okay? The quote gets indented with a light grey line on the left side.\r\n![journal-quote](https://user-images.githubusercontent.com/1181194/41158505-1a880ab4-6b21-11e8-957a-3d369189b3e4.png)\r\n\r\n\r\nLetters: `<div type=\"letter\">` [example](http://10.245.28.108:3000/journals/01-02-18-03-07)\r\nWasn't being recognised as special styling at all. I've now done this as a blockquote too. I'm not sure what to do to distinguish it as a letter (rather than a quote), but then I'm not sure it's needed (as that's clear by the text).\r\n![journal-letter](https://user-images.githubusercontent.com/1181194/41158509-1d661a46-6b21-11e8-856f-26dc0ca43626.png)\r\n\r\n\r\nSide note: So far there are only 2 quotes, and [the other one](http://10.245.28.108:3000/journals/00-11-15-11-21) is from a letter anyway. How lazy of Henson not to copy the letter out in full!\r\n"},"comment":{"url":"https://api.github.com/repos/peterwebster/henson/issues/comments/396153460","html_url":"https://github.com/peterwebster/henson/issues/100#issuecomment-396153460","issue_url":"https://api.github.com/repos/peterwebster/henson/issues/100","id":396153460,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjE1MzQ2MA==","user":{"login":"peterwebster","id":5520710,"node_id":"MDQ6VXNlcjU1MjA3MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5520710?v=4","gravatar_id":"","url":"https://api.github.com/users/peterwebster","html_url":"https://github.com/peterwebster","followers_url":"https://api.github.com/users/peterwebster/followers","following_url":"https://api.github.com/users/peterwebster/following{/other_user}","gists_url":"https://api.github.com/users/peterwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwebster/subscriptions","organizations_url":"https://api.github.com/users/peterwebster/orgs","repos_url":"https://api.github.com/users/peterwebster/repos","events_url":"https://api.github.com/users/peterwebster/events{/privacy}","received_events_url":"https://api.github.com/users/peterwebster/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T07:50:33Z","updated_at":"2018-06-11T07:50:33Z","author_association":"OWNER","body":"@nomoregrapes good spot: see also the third type (div=verse), with example at #94 \r\nWith verse, I think we need indentation and single line spacing (so if the lines are given in individual <P elements, we may need to enforce a narrower line spacing. I'd be against a grey vertical line on the left"}}
{"actor":{"display_login":"peterwebster"}}