{"action":"created","issue":{"url":"https://api.github.com/repos/pybee/toga/issues/399","repository_url":"https://api.github.com/repos/pybee/toga","labels_url":"https://api.github.com/repos/pybee/toga/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/pybee/toga/issues/399/comments","events_url":"https://api.github.com/repos/pybee/toga/issues/399/events","html_url":"https://github.com/pybee/toga/pull/399","id":304061471,"number":399,"title":"Icons","user":{"login":"obulat","id":15233243,"avatar_url":"https://avatars1.githubusercontent.com/u/15233243?v=4","gravatar_id":"","url":"https://api.github.com/users/obulat","html_url":"https://github.com/obulat","followers_url":"https://api.github.com/users/obulat/followers","following_url":"https://api.github.com/users/obulat/following{/other_user}","gists_url":"https://api.github.com/users/obulat/gists{/gist_id}","starred_url":"https://api.github.com/users/obulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obulat/subscriptions","organizations_url":"https://api.github.com/users/obulat/orgs","repos_url":"https://api.github.com/users/obulat/repos","events_url":"https://api.github.com/users/obulat/events{/privacy}","received_events_url":"https://api.github.com/users/obulat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-10T10:54:19Z","updated_at":"2018-03-14T13:47:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pybee/toga/pulls/399","html_url":"https://github.com/pybee/toga/pull/399","diff_url":"https://github.com/pybee/toga/pull/399.diff","patch_url":"https://github.com/pybee/toga/pull/399.patch"},"body":"<!--- Describe your changes in detail -->\r\nMoved the icons file resolution to the backend for cocoa and winforms.\r\n\r\n<!--- What problem does this change solve? -->\r\nNow, backends can get their proprietary file format ('.icns' for cocoa and '.ico') or create icons from '.bmp' or '.png' files. (Although I didn't find a bmp icon file, so I only tested ico and png on winforms.) I also adjusted tests because now core/icon doesn't automatically add '.icns' to the icon filename. \r\n\r\nIf this is acceptable, we will need to test and update other backends, too.\r\n\r\n<!--- If this PR relates to an issue, include Refs #XXX or Fixes #XXX -->\r\nThere is an issue about lack of icons in windows in briefcase.\r\n\r\n## PR Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n- [ ] All new features have been tested\r\n- [x] All new features have been documented\r\n- [x] I have read the **CONTRIBUTING.md** file\r\n- [x] I will abide by the code of conduct\r\n"},"comment":{"url":"https://api.github.com/repos/pybee/toga/issues/comments/373026150","html_url":"https://github.com/pybee/toga/pull/399#issuecomment-373026150","issue_url":"https://api.github.com/repos/pybee/toga/issues/399","id":373026150,"user":{"login":"obulat","id":15233243,"avatar_url":"https://avatars1.githubusercontent.com/u/15233243?v=4","gravatar_id":"","url":"https://api.github.com/users/obulat","html_url":"https://github.com/obulat","followers_url":"https://api.github.com/users/obulat/followers","following_url":"https://api.github.com/users/obulat/following{/other_user}","gists_url":"https://api.github.com/users/obulat/gists{/gist_id}","starred_url":"https://api.github.com/users/obulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obulat/subscriptions","organizations_url":"https://api.github.com/users/obulat/orgs","repos_url":"https://api.github.com/users/obulat/repos","events_url":"https://api.github.com/users/obulat/events{/privacy}","received_events_url":"https://api.github.com/users/obulat/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T13:47:12Z","updated_at":"2018-03-14T13:47:12Z","author_association":"CONTRIBUTOR","body":"Thank you for the screenshots, they helped me understand what menu really for this app.\r\nFrom what I understand from the interface design guide, the deciding factor for choosing what to show on a toolbar button(icon/ text / icon with text) is whether an icon is well known or not. So, for `cut` it is suggested to use just the icon, but for `action 1` a text label without an icon is suggested. \r\n\r\n> Windows 7-style toolbars use icons only for commands whose icons are well known; otherwise they use text labels without icons. Doing so improves the clarity of the labels, but requires more space."}}
{"actor":{"display_login":"obulat"}}