{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2933","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2933/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2933/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2933/events","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2933","id":350181542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDk0MDcx","number":2933,"title":"Add annotation for proxy-http-version","user":{"login":"mrdima","id":10998932,"node_id":"MDQ6VXNlcjEwOTk4OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/10998932?v=4","gravatar_id":"","url":"https://api.github.com/users/mrdima","html_url":"https://github.com/mrdima","followers_url":"https://api.github.com/users/mrdima/followers","following_url":"https://api.github.com/users/mrdima/following{/other_user}","gists_url":"https://api.github.com/users/mrdima/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdima/subscriptions","organizations_url":"https://api.github.com/users/mrdima/orgs","repos_url":"https://api.github.com/users/mrdima/repos","events_url":"https://api.github.com/users/mrdima/events{/privacy}","received_events_url":"https://api.github.com/users/mrdima/received_events","type":"User","site_admin":false},"labels":[{"id":486873161,"node_id":"MDU6TGFiZWw0ODY4NzMxNjE=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676670532,"node_id":"MDU6TGFiZWw2NzY2NzA1MzI=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-13T20:28:10Z","updated_at":"2018-08-14T15:38:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2933","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2933","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2933.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2933.patch"},"body":"**What this PR does / why we need it**:\r\nAdds an annotation option for setting the proxy_http_version variable.\r\nSince 0.10.0 ; https://github.com/kubernetes/ingress-nginx/pull/1787 was actually a breaking change for us as the proxy_http_version became hardcoded to 1.1 in the template  which was 1.0 before as when unspecified this is the nginx default. Because of this we got HTTP 308's when getting our content from nginx-ingress from a HA proxy configuration which fetches the content in HTTP/1.0 from multiple sources of which nginx-ingress is only one. Changing this in HA proxy is currently not an option.\r\nWe could ofcourse override the whole template using a configmap but this is undesirable as it's easy to forget to update this configmap whenever there's a newer nginx-ingress with an updated template...\r\n\r\n**Special notes for your reviewer**:\r\nThere is no issue logged regarding this as far as I'm aware of, but I'm happy to create one if desired.\r\nThanks in advance for any feedback. "},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/412916567","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2933#issuecomment-412916567","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2933","id":412916567,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjkxNjU2Nw==","user":{"login":"diazjf","id":13592244,"node_id":"MDQ6VXNlcjEzNTkyMjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/13592244?v=4","gravatar_id":"","url":"https://api.github.com/users/diazjf","html_url":"https://github.com/diazjf","followers_url":"https://api.github.com/users/diazjf/followers","following_url":"https://api.github.com/users/diazjf/following{/other_user}","gists_url":"https://api.github.com/users/diazjf/gists{/gist_id}","starred_url":"https://api.github.com/users/diazjf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diazjf/subscriptions","organizations_url":"https://api.github.com/users/diazjf/orgs","repos_url":"https://api.github.com/users/diazjf/repos","events_url":"https://api.github.com/users/diazjf/events{/privacy}","received_events_url":"https://api.github.com/users/diazjf/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T15:38:58Z","updated_at":"2018-08-14T15:38:58Z","author_association":"CONTRIBUTOR","body":"LGTM! Needs an e2e test in https://github.com/kubernetes/ingress-nginx/tree/master/test/e2e/annotations"}}
{"actor":{"display_login":"diazjf"}}