{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/3124","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/3124/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/3124/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/3124/events","html_url":"https://github.com/eclipse/omr/pull/3124","id":374023008,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODE4OTQ2","number":3124,"title":"Update CMake code to handle NASM","user":{"login":"dnakamura","id":12418336,"node_id":"MDQ6VXNlcjEyNDE4MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"labels":[{"id":650663178,"node_id":"MDU6TGFiZWw2NTA2NjMxNzg=","url":"https://api.github.com/repos/eclipse/omr/labels/cmake","name":"cmake","color":"ff087f","default":false},{"id":463261830,"node_id":"MDU6TGFiZWw0NjMyNjE4MzA=","url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-25T16:07:37Z","updated_at":"2018-11-09T15:48:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/3124","html_url":"https://github.com/eclipse/omr/pull/3124","diff_url":"https://github.com/eclipse/omr/pull/3124.diff","patch_url":"https://github.com/eclipse/omr/pull/3124.patch"},"body":"See individual commits for details"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/437400753","html_url":"https://github.com/eclipse/omr/pull/3124#issuecomment-437400753","issue_url":"https://api.github.com/repos/eclipse/omr/issues/3124","id":437400753,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzQwMDc1Mw==","user":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T15:48:18Z","updated_at":"2018-11-09T15:48:18Z","author_association":"CONTRIBUTOR","body":"@0xdaryl \r\n> I'll admit I'm trying to wrap my head around why a project (OMR) that doesn't have x86 assembly files needs CMake support for NASM\r\n\r\nThis PR is not enabling CMake support for NASM in OMR, since `enable_language(ASM_NASM)` is not set anywhere in OMR CMake files. This is simply splitting the flags set for NASM (in the JIT) and non-NASM (in the VM) assembler differently, as the flags that GNU-as recognizes are not valid for NASM."}}
{"actor":{"display_login":"nbhuiyan"}}