{"action":"created","comment":{"url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/comments/193414501","pull_request_review_id":126366261,"id":193414501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQxNDUwMQ==","diff_hunk":"@@ -0,0 +1,78 @@\n+/**\n+ * SingleCellIteratorWrapper.h\n+ *\n+ *  Created on: 31 May 2018\n+ *      Author: seckler\n+ */\n+#pragma once\n+\n+#include <utils/ExceptionHandler.h>\n+#include \"SingleCellIteratorInterface.h\"\n+\n+namespace autopas {\n+\n+/**\n+ * ParticleIteratorInterface class to iterate over particles.\n+ * This class provides a basic interface for all iterators within AutoPas.\n+ * The particles can be accessed using \"iterator->\" or \"*iterator\". The next\n+ * particle using the ++operator, e.g. \"++iterator\"\n+ * @tparam Particle type of the particle that is accessed\n+ */\n+template <class Particle>\n+class SingleCellIteratorWrapper : public SingleCellIteratorInterface<Particle> {\n+ public:\n+  /**\n+   * Constructor of the ParticleIteratorWrapper\n+   * @param particleIteratorInterface\n+   * @tparam InterfacePtrType type of the interface ptr\n+   */\n+  template <class InterfacePtrType>\n+  SingleCellIteratorWrapper(InterfacePtrType* particleIteratorInterface)\n+      : _particleIterator(\n+            static_cast<internal::SingleCellIteratorInterfaceImpl<Particle>*>(particleIteratorInterface)) {}\n+\n+  /**\n+   * copy constructor\n+   * @param otherParticleIteratorWrapper the other ParticleIteratorWrapper\n+   */\n+  SingleCellIteratorWrapper(const SingleCellIteratorWrapper& otherParticleIteratorWrapper) {\n+    _particleIterator = std::unique_ptr<internal::SingleCellIteratorInterfaceImpl<Particle>>(\n+        otherParticleIteratorWrapper._particleIterator->clone());\n+  }\n+\n+  /**\n+   * copy constructor","path":"src/iterators/SingleCellIteratorWrapper.h","position":44,"original_position":44,"commit_id":"80136a9c01f3281a8c76fbf10e489ed3fa0bc6de","original_commit_id":"80136a9c01f3281a8c76fbf10e489ed3fa0bc6de","user":{"login":"FG-TUM","id":2656700,"node_id":"MDQ6VXNlcjI2NTY3MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2656700?v=4","gravatar_id":"","url":"https://api.github.com/users/FG-TUM","html_url":"https://github.com/FG-TUM","followers_url":"https://api.github.com/users/FG-TUM/followers","following_url":"https://api.github.com/users/FG-TUM/following{/other_user}","gists_url":"https://api.github.com/users/FG-TUM/gists{/gist_id}","starred_url":"https://api.github.com/users/FG-TUM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FG-TUM/subscriptions","organizations_url":"https://api.github.com/users/FG-TUM/orgs","repos_url":"https://api.github.com/users/FG-TUM/repos","events_url":"https://api.github.com/users/FG-TUM/events{/privacy}","received_events_url":"https://api.github.com/users/FG-TUM/received_events","type":"User","site_admin":false},"body":"istn't this called copy assignment operator?","created_at":"2018-06-06T13:43:59Z","updated_at":"2018-06-06T13:57:28Z","html_url":"https://github.com/AutoPas/AutoPas/pull/50#discussion_r193414501","pull_request_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/comments/193414501"},"html":{"href":"https://github.com/AutoPas/AutoPas/pull/50#discussion_r193414501"},"pull_request":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50","id":191624873,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjI0ODcz","html_url":"https://github.com/AutoPas/AutoPas/pull/50","diff_url":"https://github.com/AutoPas/AutoPas/pull/50.diff","patch_url":"https://github.com/AutoPas/AutoPas/pull/50.patch","issue_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/50","number":50,"state":"open","locked":false,"title":"particle iterator wrapper","user":{"login":"SteffenSeckler","id":38119442,"node_id":"MDQ6VXNlcjM4MTE5NDQy","avatar_url":"https://avatars2.githubusercontent.com/u/38119442?v=4","gravatar_id":"","url":"https://api.github.com/users/SteffenSeckler","html_url":"https://github.com/SteffenSeckler","followers_url":"https://api.github.com/users/SteffenSeckler/followers","following_url":"https://api.github.com/users/SteffenSeckler/following{/other_user}","gists_url":"https://api.github.com/users/SteffenSeckler/gists{/gist_id}","starred_url":"https://api.github.com/users/SteffenSeckler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteffenSeckler/subscriptions","organizations_url":"https://api.github.com/users/SteffenSeckler/orgs","repos_url":"https://api.github.com/users/SteffenSeckler/repos","events_url":"https://api.github.com/users/SteffenSeckler/events{/privacy}","received_events_url":"https://api.github.com/users/SteffenSeckler/received_events","type":"User","site_admin":false},"body":"for now just to track the changes:\r\n* interface and wrapper for ParticleIterator class\r\n* interface and wrapper for SingleCellIterator class -- (inherits from ParticleIteratorInterface)\r\n* interface for ParticleContainer class, which does not contain any implementation details. This class does not have the ParticleCell template, but also does not provide the iteratePairwise functions.\r\n\r\nthis introduces an interface and a wrapper for the particleiterator class, to get rid of some templates and to make everything better designable, i.e. we can now have different iterators for different containers, which is needed for things like a tree container where the normal RegionParticleIterator can no longer be used.\r\n\r\nalso introduces a ParticleContainerInterface, where no ParticleCell template is needed.\r\nThe ParticleCell template should later on also be removable from the AutoPas class (most likely)","created_at":"2018-05-31T02:01:08Z","updated_at":"2018-06-06T13:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d61f4096886da2d7ca5d532be564eb1ce4fdf3d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50/commits","review_comments_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50/comments","review_comment_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/50/comments","statuses_url":"https://api.github.com/repos/AutoPas/AutoPas/statuses/80136a9c01f3281a8c76fbf10e489ed3fa0bc6de","head":{"label":"AutoPas:feature/ParticleIteratorWrapper","ref":"feature/ParticleIteratorWrapper","sha":"80136a9c01f3281a8c76fbf10e489ed3fa0bc6de","user":{"login":"AutoPas","id":38119377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTE5Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/38119377?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoPas","html_url":"https://github.com/AutoPas","followers_url":"https://api.github.com/users/AutoPas/followers","following_url":"https://api.github.com/users/AutoPas/following{/other_user}","gists_url":"https://api.github.com/users/AutoPas/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoPas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoPas/subscriptions","organizations_url":"https://api.github.com/users/AutoPas/orgs","repos_url":"https://api.github.com/users/AutoPas/repos","events_url":"https://api.github.com/users/AutoPas/events{/privacy}","received_events_url":"https://api.github.com/users/AutoPas/received_events","type":"Organization","site_admin":false},"repo":{"id":128280579,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyODA1Nzk=","name":"AutoPas","full_name":"AutoPas/AutoPas","owner":{"login":"AutoPas","id":38119377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTE5Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/38119377?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoPas","html_url":"https://github.com/AutoPas","followers_url":"https://api.github.com/users/AutoPas/followers","following_url":"https://api.github.com/users/AutoPas/following{/other_user}","gists_url":"https://api.github.com/users/AutoPas/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoPas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoPas/subscriptions","organizations_url":"https://api.github.com/users/AutoPas/orgs","repos_url":"https://api.github.com/users/AutoPas/repos","events_url":"https://api.github.com/users/AutoPas/events{/privacy}","received_events_url":"https://api.github.com/users/AutoPas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutoPas/AutoPas","description":"Autopas is a node-level auto-tuned particle simulation library developed in the context of the TaLPas project.","fork":false,"url":"https://api.github.com/repos/AutoPas/AutoPas","forks_url":"https://api.github.com/repos/AutoPas/AutoPas/forks","keys_url":"https://api.github.com/repos/AutoPas/AutoPas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoPas/AutoPas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoPas/AutoPas/teams","hooks_url":"https://api.github.com/repos/AutoPas/AutoPas/hooks","issue_events_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/events{/number}","events_url":"https://api.github.com/repos/AutoPas/AutoPas/events","assignees_url":"https://api.github.com/repos/AutoPas/AutoPas/assignees{/user}","branches_url":"https://api.github.com/repos/AutoPas/AutoPas/branches{/branch}","tags_url":"https://api.github.com/repos/AutoPas/AutoPas/tags","blobs_url":"https://api.github.com/repos/AutoPas/AutoPas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoPas/AutoPas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoPas/AutoPas/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoPas/AutoPas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoPas/AutoPas/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoPas/AutoPas/languages","stargazers_url":"https://api.github.com/repos/AutoPas/AutoPas/stargazers","contributors_url":"https://api.github.com/repos/AutoPas/AutoPas/contributors","subscribers_url":"https://api.github.com/repos/AutoPas/AutoPas/subscribers","subscription_url":"https://api.github.com/repos/AutoPas/AutoPas/subscription","commits_url":"https://api.github.com/repos/AutoPas/AutoPas/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoPas/AutoPas/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoPas/AutoPas/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoPas/AutoPas/contents/{+path}","compare_url":"https://api.github.com/repos/AutoPas/AutoPas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoPas/AutoPas/merges","archive_url":"https://api.github.com/repos/AutoPas/AutoPas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoPas/AutoPas/downloads","issues_url":"https://api.github.com/repos/AutoPas/AutoPas/issues{/number}","pulls_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoPas/AutoPas/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoPas/AutoPas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoPas/AutoPas/labels{/name}","releases_url":"https://api.github.com/repos/AutoPas/AutoPas/releases{/id}","deployments_url":"https://api.github.com/repos/AutoPas/AutoPas/deployments","created_at":"2018-04-06T00:43:49Z","updated_at":"2018-06-06T03:07:58Z","pushed_at":"2018-06-06T03:36:39Z","git_url":"git://github.com/AutoPas/AutoPas.git","ssh_url":"git@github.com:AutoPas/AutoPas.git","clone_url":"https://github.com/AutoPas/AutoPas.git","svn_url":"https://github.com/AutoPas/AutoPas","homepage":"","size":2399,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"AutoPas:master","ref":"master","sha":"514e2637e85f8fd22cd5f700d5ae3678ec3ad67a","user":{"login":"AutoPas","id":38119377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTE5Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/38119377?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoPas","html_url":"https://github.com/AutoPas","followers_url":"https://api.github.com/users/AutoPas/followers","following_url":"https://api.github.com/users/AutoPas/following{/other_user}","gists_url":"https://api.github.com/users/AutoPas/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoPas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoPas/subscriptions","organizations_url":"https://api.github.com/users/AutoPas/orgs","repos_url":"https://api.github.com/users/AutoPas/repos","events_url":"https://api.github.com/users/AutoPas/events{/privacy}","received_events_url":"https://api.github.com/users/AutoPas/received_events","type":"Organization","site_admin":false},"repo":{"id":128280579,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyODA1Nzk=","name":"AutoPas","full_name":"AutoPas/AutoPas","owner":{"login":"AutoPas","id":38119377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTE5Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/38119377?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoPas","html_url":"https://github.com/AutoPas","followers_url":"https://api.github.com/users/AutoPas/followers","following_url":"https://api.github.com/users/AutoPas/following{/other_user}","gists_url":"https://api.github.com/users/AutoPas/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoPas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoPas/subscriptions","organizations_url":"https://api.github.com/users/AutoPas/orgs","repos_url":"https://api.github.com/users/AutoPas/repos","events_url":"https://api.github.com/users/AutoPas/events{/privacy}","received_events_url":"https://api.github.com/users/AutoPas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutoPas/AutoPas","description":"Autopas is a node-level auto-tuned particle simulation library developed in the context of the TaLPas project.","fork":false,"url":"https://api.github.com/repos/AutoPas/AutoPas","forks_url":"https://api.github.com/repos/AutoPas/AutoPas/forks","keys_url":"https://api.github.com/repos/AutoPas/AutoPas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoPas/AutoPas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoPas/AutoPas/teams","hooks_url":"https://api.github.com/repos/AutoPas/AutoPas/hooks","issue_events_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/events{/number}","events_url":"https://api.github.com/repos/AutoPas/AutoPas/events","assignees_url":"https://api.github.com/repos/AutoPas/AutoPas/assignees{/user}","branches_url":"https://api.github.com/repos/AutoPas/AutoPas/branches{/branch}","tags_url":"https://api.github.com/repos/AutoPas/AutoPas/tags","blobs_url":"https://api.github.com/repos/AutoPas/AutoPas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoPas/AutoPas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoPas/AutoPas/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoPas/AutoPas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoPas/AutoPas/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoPas/AutoPas/languages","stargazers_url":"https://api.github.com/repos/AutoPas/AutoPas/stargazers","contributors_url":"https://api.github.com/repos/AutoPas/AutoPas/contributors","subscribers_url":"https://api.github.com/repos/AutoPas/AutoPas/subscribers","subscription_url":"https://api.github.com/repos/AutoPas/AutoPas/subscription","commits_url":"https://api.github.com/repos/AutoPas/AutoPas/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoPas/AutoPas/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoPas/AutoPas/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoPas/AutoPas/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoPas/AutoPas/contents/{+path}","compare_url":"https://api.github.com/repos/AutoPas/AutoPas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoPas/AutoPas/merges","archive_url":"https://api.github.com/repos/AutoPas/AutoPas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoPas/AutoPas/downloads","issues_url":"https://api.github.com/repos/AutoPas/AutoPas/issues{/number}","pulls_url":"https://api.github.com/repos/AutoPas/AutoPas/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoPas/AutoPas/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoPas/AutoPas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoPas/AutoPas/labels{/name}","releases_url":"https://api.github.com/repos/AutoPas/AutoPas/releases{/id}","deployments_url":"https://api.github.com/repos/AutoPas/AutoPas/deployments","created_at":"2018-04-06T00:43:49Z","updated_at":"2018-06-06T03:07:58Z","pushed_at":"2018-06-06T03:36:39Z","git_url":"git://github.com/AutoPas/AutoPas.git","ssh_url":"git@github.com:AutoPas/AutoPas.git","clone_url":"https://github.com/AutoPas/AutoPas.git","svn_url":"https://github.com/AutoPas/AutoPas","homepage":"","size":2399,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50"},"html":{"href":"https://github.com/AutoPas/AutoPas/pull/50"},"issue":{"href":"https://api.github.com/repos/AutoPas/AutoPas/issues/50"},"comments":{"href":"https://api.github.com/repos/AutoPas/AutoPas/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutoPas/AutoPas/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/AutoPas/AutoPas/statuses/80136a9c01f3281a8c76fbf10e489ed3fa0bc6de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"FG-TUM"}}