{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/197352081","pull_request_review_id":131079986,"id":197352081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzM1MjA4MQ==","diff_hunk":"@@ -1683,6 +1685,42 @@ static int network_set_interface(const sockent_t *se,\n   return 0;\n } /* }}} network_set_interface */\n \n+static int network_bind_socket_to_addr(sockent_t *se,\n+                                       const struct addrinfo *ai) {\n+\n+  if (se->data.client.bind_addr == NULL)\n+    return 0;\n+\n+  DEBUG(\"network_plugin: fd %i: bind socket to address\", se->data.client.fd);\n+  char pbuffer[64];","path":"src/network.c","position":27,"original_position":27,"commit_id":"7e942ee673692b1b08dff8a4ad842f6cd628b376","original_commit_id":"7e942ee673692b1b08dff8a4ad842f6cd628b376","user":{"login":"rpv-tomsk","id":13328211,"node_id":"MDQ6VXNlcjEzMzI4MjEx","avatar_url":"https://avatars2.githubusercontent.com/u/13328211?v=4","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"body":"This variable currently used in `DEBUG()` call.\r\nThen Collectd compiled w/o debug, this variable will be unused at practice - it will be filled by `inet_ntop()`, but not used later.\r\n\r\nMine proposal is to put it into `ERROR()` calls:\r\n\r\n`ERROR(\"network plugin: failed to bind client socket (ipvX) to %s: %s\", pbuffer, STRERRNO);`\r\n\r\nThis will use variable when non-debug version is compiled, and message become more informative.","created_at":"2018-06-22T06:34:33Z","updated_at":"2018-06-22T06:34:33Z","html_url":"https://github.com/collectd/collectd/pull/2831#discussion_r197352081","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/2831","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/197352081"},"html":{"href":"https://github.com/collectd/collectd/pull/2831#discussion_r197352081"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2831"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/2831","id":195447150,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDQ3MTUw","html_url":"https://github.com/collectd/collectd/pull/2831","diff_url":"https://github.com/collectd/collectd/pull/2831.diff","patch_url":"https://github.com/collectd/collectd/pull/2831.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/2831","number":2831,"state":"open","locked":false,"title":"network plugin: Add BindAddress option","user":{"login":"elieyal","id":17270807,"node_id":"MDQ6VXNlcjE3MjcwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/17270807?v=4","gravatar_id":"","url":"https://api.github.com/users/elieyal","html_url":"https://github.com/elieyal","followers_url":"https://api.github.com/users/elieyal/followers","following_url":"https://api.github.com/users/elieyal/following{/other_user}","gists_url":"https://api.github.com/users/elieyal/gists{/gist_id}","starred_url":"https://api.github.com/users/elieyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieyal/subscriptions","organizations_url":"https://api.github.com/users/elieyal/orgs","repos_url":"https://api.github.com/users/elieyal/repos","events_url":"https://api.github.com/users/elieyal/events{/privacy}","received_events_url":"https://api.github.com/users/elieyal/received_events","type":"User","site_admin":false},"body":"This change allows to Bind Address to an IP address instead of the binding to the Interface Name in the server section.\r\nExample:\r\n```\r\n<Server \"239.192.74.66\" \"25826\">\r\n                SecurityLevel Encrypt\r\n                Username \"user\"\r\n                Password \"secret\"\r\n                BindAddress \"10.9.25.59\"\r\n                ResolveInterval 14400\r\n        </Server>\r\n```\r\nCredit to: Ofir Hermesh\r\n\r\nSuperseedes:  #2827\r\nIssue: #2818","created_at":"2018-06-18T08:00:17Z","updated_at":"2018-06-22T06:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d013f2bd7ab54f0c1dcfe3ac327905b8239624d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":13824791,"node_id":"MDU6TGFiZWwxMzgyNDc5MQ==","url":"https://api.github.com/repos/collectd/collectd/labels/Feature","name":"Feature","color":"5319e7","default":false},{"id":441006047,"node_id":"MDU6TGFiZWw0NDEwMDYwNDc=","url":"https://api.github.com/repos/collectd/collectd/labels/Pending%20contributor%20action","name":"Pending contributor action","color":"d0d0d0","default":false}],"milestone":{"url":"https://api.github.com/repos/collectd/collectd/milestones/13","html_url":"https://github.com/collectd/collectd/milestone/13","labels_url":"https://api.github.com/repos/collectd/collectd/milestones/13/labels","id":3428937,"node_id":"MDk6TWlsZXN0b25lMzQyODkzNw==","number":13,"title":"5.9","description":null,"creator":{"login":"rpv-tomsk","id":13328211,"node_id":"MDQ6VXNlcjEzMzI4MjEx","avatar_url":"https://avatars2.githubusercontent.com/u/13328211?v=4","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2018-06-16T05:48:22Z","updated_at":"2018-06-22T03:15:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/2831/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/2831/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/2831/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/7e942ee673692b1b08dff8a4ad842f6cd628b376","head":{"label":"elieyal:patch-3","ref":"patch-3","sha":"7e942ee673692b1b08dff8a4ad842f6cd628b376","user":{"login":"elieyal","id":17270807,"node_id":"MDQ6VXNlcjE3MjcwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/17270807?v=4","gravatar_id":"","url":"https://api.github.com/users/elieyal","html_url":"https://github.com/elieyal","followers_url":"https://api.github.com/users/elieyal/followers","following_url":"https://api.github.com/users/elieyal/following{/other_user}","gists_url":"https://api.github.com/users/elieyal/gists{/gist_id}","starred_url":"https://api.github.com/users/elieyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieyal/subscriptions","organizations_url":"https://api.github.com/users/elieyal/orgs","repos_url":"https://api.github.com/users/elieyal/repos","events_url":"https://api.github.com/users/elieyal/events{/privacy}","received_events_url":"https://api.github.com/users/elieyal/received_events","type":"User","site_admin":false},"repo":{"id":137720565,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MjA1NjU=","name":"collectd","full_name":"elieyal/collectd","owner":{"login":"elieyal","id":17270807,"node_id":"MDQ6VXNlcjE3MjcwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/17270807?v=4","gravatar_id":"","url":"https://api.github.com/users/elieyal","html_url":"https://github.com/elieyal","followers_url":"https://api.github.com/users/elieyal/followers","following_url":"https://api.github.com/users/elieyal/following{/other_user}","gists_url":"https://api.github.com/users/elieyal/gists{/gist_id}","starred_url":"https://api.github.com/users/elieyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieyal/subscriptions","organizations_url":"https://api.github.com/users/elieyal/orgs","repos_url":"https://api.github.com/users/elieyal/repos","events_url":"https://api.github.com/users/elieyal/events{/privacy}","received_events_url":"https://api.github.com/users/elieyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elieyal/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/elieyal/collectd","forks_url":"https://api.github.com/repos/elieyal/collectd/forks","keys_url":"https://api.github.com/repos/elieyal/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elieyal/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elieyal/collectd/teams","hooks_url":"https://api.github.com/repos/elieyal/collectd/hooks","issue_events_url":"https://api.github.com/repos/elieyal/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/elieyal/collectd/events","assignees_url":"https://api.github.com/repos/elieyal/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/elieyal/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/elieyal/collectd/tags","blobs_url":"https://api.github.com/repos/elieyal/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elieyal/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elieyal/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/elieyal/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elieyal/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/elieyal/collectd/languages","stargazers_url":"https://api.github.com/repos/elieyal/collectd/stargazers","contributors_url":"https://api.github.com/repos/elieyal/collectd/contributors","subscribers_url":"https://api.github.com/repos/elieyal/collectd/subscribers","subscription_url":"https://api.github.com/repos/elieyal/collectd/subscription","commits_url":"https://api.github.com/repos/elieyal/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/elieyal/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/elieyal/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/elieyal/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/elieyal/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/elieyal/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elieyal/collectd/merges","archive_url":"https://api.github.com/repos/elieyal/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elieyal/collectd/downloads","issues_url":"https://api.github.com/repos/elieyal/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/elieyal/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/elieyal/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/elieyal/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elieyal/collectd/labels{/name}","releases_url":"https://api.github.com/repos/elieyal/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/elieyal/collectd/deployments","created_at":"2018-06-18T07:13:35Z","updated_at":"2018-06-21T09:27:26Z","pushed_at":"2018-06-21T16:19:20Z","git_url":"git://github.com/elieyal/collectd.git","ssh_url":"git@github.com:elieyal/collectd.git","clone_url":"https://github.com/elieyal/collectd.git","svn_url":"https://github.com/elieyal/collectd","homepage":"http://collectd.org/","size":20637,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"655acd5a11d405b0fae8f2921de8216336825e90","user":{"login":"collectd","id":1027481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc0ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1027481?v=4","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA4NjQw","name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc0ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1027481?v=4","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2018-06-21T13:54:26Z","pushed_at":"2018-06-22T06:34:02Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":20461,"stargazers_count":1970,"watchers_count":1970,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":997,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":997,"open_issues":425,"watchers":1970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2831"},"html":{"href":"https://github.com/collectd/collectd/pull/2831"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/2831"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/2831/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2831/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2831/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/7e942ee673692b1b08dff8a4ad842f6cd628b376"}},"author_association":"NONE"}}
{"actor":{"display_login":"rpv-tomsk"}}