{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3420","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3420/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3420/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3420/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3420","id":297910790,"number":3420,"title":"[WIP] TextualSummaries: part of client side rendering with React.","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"id":736077188,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false},{"id":535030606,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/textual%20summaries","name":"textual summaries","color":"d4c5f9","default":false},{"id":505531653,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-16T20:30:05Z","updated_at":"2018-03-01T08:34:38Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3420","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3420","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3420.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3420.patch"},"body":"The goal is to implement a top level component for client-side rendering of textual summaries. Such component can then consume a JSON endpoint and later the API.\r\n\r\n### TODO\r\n * tests (snapshot testing)\r\n * ~~links~~\r\n * ~~images in general (see e.g. http://localhost:3000/ems_cluster/show/10000000000032 missing img)~~\r\n * preprocess inlined images (needed in PDF rendering)\r\n * what about PDF rendering?\r\n * TextualCustom: 2x in physical server: `textual_firmware_table`, `textual_network_adapter_table`\r\n * ~~TextualCustom: in app/helpers/vm_helper/textual_summary.rb: `textual_normal_operating_ranges`~~\r\n * ~~TextualListview: in ops/ vmdb tables~~\r\n * ~~TextualMultilabel -- seems to be a superset of TextualTable with sorting and value expanding\r\n  (expanding used in app/helpers/container_build_helper/textual_summary.rb)~~\r\n * ~~TextualMultilink\r\n  app/helpers/ems_cluster_helper/textual_summary.rb:    ret.blank? ? nil : \r\n  TextualMultilink.new(_(\"OpenStack Status\"), :items => ret)  \r\napp/helpers/host_helper/textual_summary.rb:    TextualMultilink.new(_(\"OpenStack Service Status\"), \r\n  :items => textual_generate_openstack_status)~~ (FIXME: specs)\r\n * ~~TextualTable (andible playbok job plays, security group firewall rules) (scurity group, network router)~~ \r\n\r\n * `:spinner => true` used only once in  `app/helpers/vm_helper/textual_summary.rb` in `textual_genealogy` can we drop it?\r\n\r\n * `:no_value => true` -- only used in GO, can we drop it? (introduced in https://github.com/ManageIQ/manageiq-ui-classic/pull/2852 I don't understand that change)\r\n\r\n### Next\r\n * share the click behavior using HOC https://reactjs.org/docs/higher-order-components.html\r\n * use patternfly-react icon?\r\n * use patternfly-react tables?\r\n * move to https://github.com/karelhala/react-ui-components (or move the generic parts)"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/369515098","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3420#issuecomment-369515098","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3420","id":369515098,"user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T08:34:38Z","updated_at":"2018-03-01T08:34:38Z","author_association":"COLLABORATOR","body":"@AparnaKarve : to be more explicit: What was the motivation behind the PR that introduced the new attribute? Why testing just `:value` was not enough?\r\n\r\nI'd like to remove this feature if it's not really needed, but there's no test that would fail if I do nor do I understand it when reading the PR.\r\n\r\nThx!"}}
{"actor":{"display_login":"martinpovolny"}}