{"action":"closed","number":40933,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/40933","id":191653922,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjUzOTIy","html_url":"https://github.com/ansible/ansible/pull/40933","diff_url":"https://github.com/ansible/ansible/pull/40933.diff","patch_url":"https://github.com/ansible/ansible/pull/40933.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/40933","number":40933,"state":"closed","locked":false,"title":"Fix eos_logging idempotency issue CP into 2.4","user":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nFixes eos_logging idempotency issue when trying to set both logging destination and facility.\r\n(https://github.com/ansible/ansible/issues/31862)\r\n\r\n- Added fix for the idempotency issue\r\n- Added new integration tests\r\n- Added fix in CHANGELOG.md\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\neos_logging.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nstable-2.4\r\n```\r\n","created_at":"2018-05-31T06:18:21Z","updated_at":"2018-05-31T06:36:27Z","closed_at":"2018-05-31T06:36:27Z","merged_at":"2018-05-31T06:36:27Z","merge_commit_sha":"eedb78a8ba88d11a8e2d6acf0e42f930912eb9f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":562292166,"node_id":"MDU6TGFiZWw1NjIyOTIxNjY=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.4","name":"affects_2.4","color":"ededed","default":false},{"id":266246971,"node_id":"MDU6TGFiZWwyNjYyNDY5NzE=","url":"https://api.github.com/repos/ansible/ansible/labels/backport","name":"backport","color":"00ff00","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"c7def8","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":669761792,"node_id":"MDU6TGFiZWw2Njk3NjE3OTI=","url":"https://api.github.com/repos/ansible/ansible/labels/support:network","name":"support:network","color":"ededed","default":false},{"id":468273802,"node_id":"MDU6TGFiZWw0NjgyNzM4MDI=","url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/40933/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/40933/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/40933/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/d0ef1fed688db17a7e14d4f311b94a5ed2491348","head":{"label":"NilashishC:stable-2.4","ref":"stable-2.4","sha":"d0ef1fed688db17a7e14d4f311b94a5ed2491348","user":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"repo":{"id":133320768,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjA3Njg=","name":"ansible","full_name":"NilashishC/ansible","owner":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NilashishC/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/NilashishC/ansible","forks_url":"https://api.github.com/repos/NilashishC/ansible/forks","keys_url":"https://api.github.com/repos/NilashishC/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NilashishC/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NilashishC/ansible/teams","hooks_url":"https://api.github.com/repos/NilashishC/ansible/hooks","issue_events_url":"https://api.github.com/repos/NilashishC/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/NilashishC/ansible/events","assignees_url":"https://api.github.com/repos/NilashishC/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/NilashishC/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/NilashishC/ansible/tags","blobs_url":"https://api.github.com/repos/NilashishC/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NilashishC/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NilashishC/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/NilashishC/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NilashishC/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/NilashishC/ansible/languages","stargazers_url":"https://api.github.com/repos/NilashishC/ansible/stargazers","contributors_url":"https://api.github.com/repos/NilashishC/ansible/contributors","subscribers_url":"https://api.github.com/repos/NilashishC/ansible/subscribers","subscription_url":"https://api.github.com/repos/NilashishC/ansible/subscription","commits_url":"https://api.github.com/repos/NilashishC/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/NilashishC/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/NilashishC/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/NilashishC/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/NilashishC/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/NilashishC/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NilashishC/ansible/merges","archive_url":"https://api.github.com/repos/NilashishC/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NilashishC/ansible/downloads","issues_url":"https://api.github.com/repos/NilashishC/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/NilashishC/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/NilashishC/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/NilashishC/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NilashishC/ansible/labels{/name}","releases_url":"https://api.github.com/repos/NilashishC/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/NilashishC/ansible/deployments","created_at":"2018-05-14T07:20:06Z","updated_at":"2018-05-14T07:20:34Z","pushed_at":"2018-05-31T06:12:38Z","git_url":"git://github.com/NilashishC/ansible.git","ssh_url":"git@github.com:NilashishC/ansible.git","clone_url":"https://github.com/NilashishC/ansible.git","svn_url":"https://github.com/NilashishC/ansible","homepage":"https://www.ansible.com/","size":117028,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:stable-2.4","ref":"stable-2.4","sha":"0967cc0c705bb6924b9b0b9006fee1841f03e40b","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-05-31T06:20:07Z","pushed_at":"2018-05-31T06:36:27Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":125032,"stargazers_count":30511,"watchers_count":30511,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11468,"mirror_url":null,"archived":false,"open_issues_count":5053,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11468,"open_issues":5053,"watchers":30511,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40933"},"html":{"href":"https://github.com/ansible/ansible/pull/40933"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/40933"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/40933/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40933/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40933/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/d0ef1fed688db17a7e14d4f311b94a5ed2491348"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":98,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"NilashishC"}}