{"action":"created","issue":{"url":"https://api.github.com/repos/adventuregamestudio/ags/issues/455","repository_url":"https://api.github.com/repos/adventuregamestudio/ags","labels_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/455/comments","events_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/455/events","html_url":"https://github.com/adventuregamestudio/ags/pull/455","id":331515742,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjI0MTQw","number":455,"title":"Add builtin stubs for AGSteam and AGSGalaxy","user":{"login":"monkey0506","id":1878864,"node_id":"MDQ6VXNlcjE4Nzg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1878864?v=4","gravatar_id":"","url":"https://api.github.com/users/monkey0506","html_url":"https://github.com/monkey0506","followers_url":"https://api.github.com/users/monkey0506/followers","following_url":"https://api.github.com/users/monkey0506/following{/other_user}","gists_url":"https://api.github.com/users/monkey0506/gists{/gist_id}","starred_url":"https://api.github.com/users/monkey0506/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkey0506/subscriptions","organizations_url":"https://api.github.com/users/monkey0506/orgs","repos_url":"https://api.github.com/users/monkey0506/repos","events_url":"https://api.github.com/users/monkey0506/events{/privacy}","received_events_url":"https://api.github.com/users/monkey0506/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-12T09:48:31Z","updated_at":"2018-06-14T17:07:24Z","closed_at":"2018-06-13T03:28:15Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/adventuregamestudio/ags/pulls/455","html_url":"https://github.com/adventuregamestudio/ags/pull/455","diff_url":"https://github.com/adventuregamestudio/ags/pull/455.diff","patch_url":"https://github.com/adventuregamestudio/ags/pull/455.patch"},"body":"The AGSteam and AGSGalaxy client plugins are beyond the scope of this project, but function stubs for them should not require much maintenance as their APIs are not expected to change much. This could also serve as a complete replacement for [ags2clientstub](https://github.com/monkey0506/ags2clientstub).\r\n\r\nI'm not sure if I knew plugins could be stubbed this way, but this seems appropriate based on the other existing stubs. I had started writing ags2clientstub as a builtin plugin when I found this file."},"comment":{"url":"https://api.github.com/repos/adventuregamestudio/ags/issues/comments/397368949","html_url":"https://github.com/adventuregamestudio/ags/pull/455#issuecomment-397368949","issue_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/455","id":397368949,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzM2ODk0OQ==","user":{"login":"ivan-mogilko","id":1833754,"node_id":"MDQ6VXNlcjE4MzM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1833754?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan-mogilko","html_url":"https://github.com/ivan-mogilko","followers_url":"https://api.github.com/users/ivan-mogilko/followers","following_url":"https://api.github.com/users/ivan-mogilko/following{/other_user}","gists_url":"https://api.github.com/users/ivan-mogilko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-mogilko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-mogilko/subscriptions","organizations_url":"https://api.github.com/users/ivan-mogilko/orgs","repos_url":"https://api.github.com/users/ivan-mogilko/repos","events_url":"https://api.github.com/users/ivan-mogilko/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-mogilko/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T17:07:24Z","updated_at":"2018-06-14T17:07:24Z","author_association":"MEMBER","body":"@monkey0506 , you've closed this pull request without any comment, I hope my reply did not sound as \"brush off\"?\r\nMy intention was to find out whether adding a stub is actually a necessity, because if there is a critical need to have it (e.g. if it's too complicated to have a stub plugin), then this could still be used as a temporary workaround. After all, quite a lot of games use your steam plugin now, and I've seen complaints about missing script links popping up from time to time on forums.\r\n\r\nOn the other hand, if it's merely an option, then having an actual plugin seem like a cleaner variant.\r\n\r\nRight now I am trying to refresh my memories on issues we have with plugins on different platforms. We had ideas how to \"automate\" plugin stubbing in the past, maybe that idea could be revisited."}}
{"actor":{"display_login":"ivan-mogilko"}}