{"action":"created","comment":{"url":"https://api.github.com/repos/scala/collection-strawman/pulls/comments/173223881","pull_request_review_id":102378109,"id":173223881,"diff_hunk":"@@ -171,4 +171,8 @@ trait LinearSeqOps[+A, +CC[X] <: LinearSeq[X], +C <: LinearSeq[A]] extends Any w\n     }\n     last\n   }\n+\n+  override def tails: Iterator[C] =\n+    Iterator.iterate(coll)(_.tail.asInstanceOf[C]).takeWhile(_.nonEmpty) ++ Iterator(newSpecificBuilder().result())","path":"collections/src/main/scala/strawman/collection/LinearSeq.scala","position":6,"original_position":6,"commit_id":"7a57af9691ed42052ac3b782a9d48afdcbb9571d","original_commit_id":"d049876d093909c4d3aba42ce3b27b93e1e59075","user":{"login":"szeiger","id":54262,"avatar_url":"https://avatars3.githubusercontent.com/u/54262?v=4","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"body":"Hm, that's not nice. We lose the precise type on repeated applications of `tail`. `this.type.tail` results in C but `C.type` is only `LinearSeq[A]`.","created_at":"2018-03-08T17:04:23Z","updated_at":"2018-03-08T17:04:23Z","html_url":"https://github.com/scala/collection-strawman/pull/493#discussion_r173223881","pull_request_url":"https://api.github.com/repos/scala/collection-strawman/pulls/493","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/comments/173223881"},"html":{"href":"https://github.com/scala/collection-strawman/pull/493#discussion_r173223881"},"pull_request":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/493"}},"in_reply_to_id":172869728},"pull_request":{"url":"https://api.github.com/repos/scala/collection-strawman/pulls/493","id":173230944,"html_url":"https://github.com/scala/collection-strawman/pull/493","diff_url":"https://github.com/scala/collection-strawman/pull/493.diff","patch_url":"https://github.com/scala/collection-strawman/pull/493.patch","issue_url":"https://api.github.com/repos/scala/collection-strawman/issues/493","number":493,"state":"open","locked":false,"title":"Fixes from scala/scala repository","user":{"login":"julienrf","id":332812,"avatar_url":"https://avatars2.githubusercontent.com/u/332812?v=4","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"body":"I went through the history of the collections on the scala/scala repo, for the last year, and backported all the things that were missing in the strawman.\r\n\r\nFixes #214.","created_at":"2018-03-06T17:39:35Z","updated_at":"2018-03-08T17:04:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05b6f5779f550855e0597d71f8e70300c193fd1c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lrytz","id":119636,"avatar_url":"https://avatars1.githubusercontent.com/u/119636?v=4","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scala/collection-strawman/pulls/493/commits","review_comments_url":"https://api.github.com/repos/scala/collection-strawman/pulls/493/comments","review_comment_url":"https://api.github.com/repos/scala/collection-strawman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/collection-strawman/issues/493/comments","statuses_url":"https://api.github.com/repos/scala/collection-strawman/statuses/7a57af9691ed42052ac3b782a9d48afdcbb9571d","head":{"label":"julienrf:fixes-from-scala-scala","ref":"fixes-from-scala-scala","sha":"7a57af9691ed42052ac3b782a9d48afdcbb9571d","user":{"login":"julienrf","id":332812,"avatar_url":"https://avatars2.githubusercontent.com/u/332812?v=4","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"repo":{"id":102126284,"name":"collection-strawman","full_name":"julienrf/collection-strawman","owner":{"login":"julienrf","id":332812,"avatar_url":"https://avatars2.githubusercontent.com/u/332812?v=4","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienrf/collection-strawman","description":"Experimenting with Scala Collections designs for Scala 2.13","fork":true,"url":"https://api.github.com/repos/julienrf/collection-strawman","forks_url":"https://api.github.com/repos/julienrf/collection-strawman/forks","keys_url":"https://api.github.com/repos/julienrf/collection-strawman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienrf/collection-strawman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienrf/collection-strawman/teams","hooks_url":"https://api.github.com/repos/julienrf/collection-strawman/hooks","issue_events_url":"https://api.github.com/repos/julienrf/collection-strawman/issues/events{/number}","events_url":"https://api.github.com/repos/julienrf/collection-strawman/events","assignees_url":"https://api.github.com/repos/julienrf/collection-strawman/assignees{/user}","branches_url":"https://api.github.com/repos/julienrf/collection-strawman/branches{/branch}","tags_url":"https://api.github.com/repos/julienrf/collection-strawman/tags","blobs_url":"https://api.github.com/repos/julienrf/collection-strawman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienrf/collection-strawman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienrf/collection-strawman/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienrf/collection-strawman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienrf/collection-strawman/statuses/{sha}","languages_url":"https://api.github.com/repos/julienrf/collection-strawman/languages","stargazers_url":"https://api.github.com/repos/julienrf/collection-strawman/stargazers","contributors_url":"https://api.github.com/repos/julienrf/collection-strawman/contributors","subscribers_url":"https://api.github.com/repos/julienrf/collection-strawman/subscribers","subscription_url":"https://api.github.com/repos/julienrf/collection-strawman/subscription","commits_url":"https://api.github.com/repos/julienrf/collection-strawman/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienrf/collection-strawman/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienrf/collection-strawman/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienrf/collection-strawman/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienrf/collection-strawman/contents/{+path}","compare_url":"https://api.github.com/repos/julienrf/collection-strawman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienrf/collection-strawman/merges","archive_url":"https://api.github.com/repos/julienrf/collection-strawman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienrf/collection-strawman/downloads","issues_url":"https://api.github.com/repos/julienrf/collection-strawman/issues{/number}","pulls_url":"https://api.github.com/repos/julienrf/collection-strawman/pulls{/number}","milestones_url":"https://api.github.com/repos/julienrf/collection-strawman/milestones{/number}","notifications_url":"https://api.github.com/repos/julienrf/collection-strawman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienrf/collection-strawman/labels{/name}","releases_url":"https://api.github.com/repos/julienrf/collection-strawman/releases{/id}","deployments_url":"https://api.github.com/repos/julienrf/collection-strawman/deployments","created_at":"2017-09-01T15:21:03Z","updated_at":"2017-09-01T15:21:05Z","pushed_at":"2018-03-08T14:35:46Z","git_url":"git://github.com/julienrf/collection-strawman.git","ssh_url":"git@github.com:julienrf/collection-strawman.git","clone_url":"https://github.com/julienrf/collection-strawman.git","svn_url":"https://github.com/julienrf/collection-strawman","homepage":null,"size":2099,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala:master","ref":"master","sha":"f17a3b3a33711b605f4a0723f2684ce42dbf963d","user":{"login":"scala","id":57059,"avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":69596738,"name":"collection-strawman","full_name":"scala/collection-strawman","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/collection-strawman","description":"Implementation of the new Scala 2.13 Collections","fork":false,"url":"https://api.github.com/repos/scala/collection-strawman","forks_url":"https://api.github.com/repos/scala/collection-strawman/forks","keys_url":"https://api.github.com/repos/scala/collection-strawman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/collection-strawman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/collection-strawman/teams","hooks_url":"https://api.github.com/repos/scala/collection-strawman/hooks","issue_events_url":"https://api.github.com/repos/scala/collection-strawman/issues/events{/number}","events_url":"https://api.github.com/repos/scala/collection-strawman/events","assignees_url":"https://api.github.com/repos/scala/collection-strawman/assignees{/user}","branches_url":"https://api.github.com/repos/scala/collection-strawman/branches{/branch}","tags_url":"https://api.github.com/repos/scala/collection-strawman/tags","blobs_url":"https://api.github.com/repos/scala/collection-strawman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/collection-strawman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/collection-strawman/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/collection-strawman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/collection-strawman/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/collection-strawman/languages","stargazers_url":"https://api.github.com/repos/scala/collection-strawman/stargazers","contributors_url":"https://api.github.com/repos/scala/collection-strawman/contributors","subscribers_url":"https://api.github.com/repos/scala/collection-strawman/subscribers","subscription_url":"https://api.github.com/repos/scala/collection-strawman/subscription","commits_url":"https://api.github.com/repos/scala/collection-strawman/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/collection-strawman/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/collection-strawman/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/collection-strawman/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/collection-strawman/contents/{+path}","compare_url":"https://api.github.com/repos/scala/collection-strawman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/collection-strawman/merges","archive_url":"https://api.github.com/repos/scala/collection-strawman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/collection-strawman/downloads","issues_url":"https://api.github.com/repos/scala/collection-strawman/issues{/number}","pulls_url":"https://api.github.com/repos/scala/collection-strawman/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/collection-strawman/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/collection-strawman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/collection-strawman/labels{/name}","releases_url":"https://api.github.com/repos/scala/collection-strawman/releases{/id}","deployments_url":"https://api.github.com/repos/scala/collection-strawman/deployments","created_at":"2016-09-29T18:38:21Z","updated_at":"2018-03-06T16:40:03Z","pushed_at":"2018-03-08T14:36:20Z","git_url":"git://github.com/scala/collection-strawman.git","ssh_url":"git@github.com:scala/collection-strawman.git","clone_url":"https://github.com/scala/collection-strawman.git","svn_url":"https://github.com/scala/collection-strawman","homepage":"","size":1931,"stargazers_count":184,"watchers_count":184,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":89,"license":null,"forks":63,"open_issues":89,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/493"},"html":{"href":"https://github.com/scala/collection-strawman/pull/493"},"issue":{"href":"https://api.github.com/repos/scala/collection-strawman/issues/493"},"comments":{"href":"https://api.github.com/repos/scala/collection-strawman/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/collection-strawman/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/scala/collection-strawman/statuses/7a57af9691ed42052ac3b782a9d48afdcbb9571d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"szeiger"}}