{"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/bsp/pulls/comments/229246563","pull_request_review_id":169697093,"id":229246563,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI0NjU2Mw==","diff_hunk":"@@ -336,7 +335,7 @@ case object BuildTargetEventKind {\n @JsonCodec final case class TestParams(\n     targets: List[BuildTargetIdentifier],\n     originId: Option[String],\n-    arguments: List[Json]\n+    arguments: Option[List[String]]","path":"bsp4s/src/main/scala/ch/epfl/scala/bsp/Bsp.scala","position":82,"original_position":82,"commit_id":"8d14a6a092682f57854a035e59d0cebfae598784","original_commit_id":"2f229c272c4209ecf65795e8bd6b17fe58a1aadb","user":{"login":"jastice","id":770879,"node_id":"MDQ6VXNlcjc3MDg3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/770879?v=4","gravatar_id":"","url":"https://api.github.com/users/jastice","html_url":"https://github.com/jastice","followers_url":"https://api.github.com/users/jastice/followers","following_url":"https://api.github.com/users/jastice/following{/other_user}","gists_url":"https://api.github.com/users/jastice/gists{/gist_id}","starred_url":"https://api.github.com/users/jastice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jastice/subscriptions","organizations_url":"https://api.github.com/users/jastice/orgs","repos_url":"https://api.github.com/users/jastice/repos","events_url":"https://api.github.com/users/jastice/events{/privacy}","received_events_url":"https://api.github.com/users/jastice/received_events","type":"User","site_admin":false},"body":"as above, `@NonNull` in Java","created_at":"2018-10-30T10:16:19Z","updated_at":"2018-10-30T10:33:43Z","html_url":"https://github.com/scalacenter/bsp/pull/62#discussion_r229246563","pull_request_url":"https://api.github.com/repos/scalacenter/bsp/pulls/62","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/comments/229246563"},"html":{"href":"https://github.com/scalacenter/bsp/pull/62#discussion_r229246563"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/scalacenter/bsp/pulls/62","id":226638563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjM4NTYz","html_url":"https://github.com/scalacenter/bsp/pull/62","diff_url":"https://github.com/scalacenter/bsp/pull/62.diff","patch_url":"https://github.com/scalacenter/bsp/pull/62.patch","issue_url":"https://api.github.com/repos/scalacenter/bsp/issues/62","number":62,"state":"open","locked":false,"title":"Setup test suite to stress bsp4s/bsp4j compatibility","user":{"login":"olafurpg","id":1408093,"node_id":"MDQ6VXNlcjE0MDgwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"body":"This commit adds a new test suite `TypoSuite` that catches\r\nincompatibilies between bsp4s and bsp4j. It turns out that there were\r\nmany minor differences between the two modules, both typos and\r\nmismatching types.\r\n\r\nThe new tests caught several issues that are fixed in this commit:\r\n\r\n- remove `providesFileWatching`\r\n- fix lsp4j `BuildServer.buildTargetInverseSources`\r\n- add `BuildTarget.dependencies` to the spec\r\n- make `BuildTarget.languageIds` required\r\n- fix lsp4j `InverseSourcesParams.textDocument` type\r\n- make all `BuildServerCapability` fields optional\r\n- make lsp4s `BuildTarget.displayName` optional\r\n- fix lsp4s `ResourcesResult.uris`\r\n- add missing lsp4s endpoints `BuildTarget.{resources,didChange}`\r\n- fix lsp4s endpoint `BuildTarget.sources`\r\n- add constructors for all fields in lsp4j, more convenient than\r\n  using setters.\r\n\r\n\r\nThis PR may have one controversial change: `{CompileParams,RunParams,TestParams}.arguments` are now typed as `Option[List[String]]`. I'm open for suggestions, it was inconsistent before in spec + bsp4s + bsp4j.\r\n\r\nFixes #57","created_at":"2018-10-29T16:58:41Z","updated_at":"2018-10-30T10:33:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b0588617a7d36d2b3981a294d9df15e3de145a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jvican","id":2462974,"node_id":"MDQ6VXNlcjI0NjI5NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/bsp/pulls/62/commits","review_comments_url":"https://api.github.com/repos/scalacenter/bsp/pulls/62/comments","review_comment_url":"https://api.github.com/repos/scalacenter/bsp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/bsp/issues/62/comments","statuses_url":"https://api.github.com/repos/scalacenter/bsp/statuses/8d14a6a092682f57854a035e59d0cebfae598784","head":{"label":"olafurpg:typos","ref":"typos","sha":"8d14a6a092682f57854a035e59d0cebfae598784","user":{"login":"olafurpg","id":1408093,"node_id":"MDQ6VXNlcjE0MDgwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"repo":{"id":117818056,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4MTgwNTY=","name":"bsp","full_name":"olafurpg/bsp","private":false,"owner":{"login":"olafurpg","id":1408093,"node_id":"MDQ6VXNlcjE0MDgwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/olafurpg/bsp","description":"Thought experiment for a potential Build Server Protocol for Scala","fork":true,"url":"https://api.github.com/repos/olafurpg/bsp","forks_url":"https://api.github.com/repos/olafurpg/bsp/forks","keys_url":"https://api.github.com/repos/olafurpg/bsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olafurpg/bsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olafurpg/bsp/teams","hooks_url":"https://api.github.com/repos/olafurpg/bsp/hooks","issue_events_url":"https://api.github.com/repos/olafurpg/bsp/issues/events{/number}","events_url":"https://api.github.com/repos/olafurpg/bsp/events","assignees_url":"https://api.github.com/repos/olafurpg/bsp/assignees{/user}","branches_url":"https://api.github.com/repos/olafurpg/bsp/branches{/branch}","tags_url":"https://api.github.com/repos/olafurpg/bsp/tags","blobs_url":"https://api.github.com/repos/olafurpg/bsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olafurpg/bsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olafurpg/bsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/olafurpg/bsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olafurpg/bsp/statuses/{sha}","languages_url":"https://api.github.com/repos/olafurpg/bsp/languages","stargazers_url":"https://api.github.com/repos/olafurpg/bsp/stargazers","contributors_url":"https://api.github.com/repos/olafurpg/bsp/contributors","subscribers_url":"https://api.github.com/repos/olafurpg/bsp/subscribers","subscription_url":"https://api.github.com/repos/olafurpg/bsp/subscription","commits_url":"https://api.github.com/repos/olafurpg/bsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/olafurpg/bsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/olafurpg/bsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/olafurpg/bsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/olafurpg/bsp/contents/{+path}","compare_url":"https://api.github.com/repos/olafurpg/bsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olafurpg/bsp/merges","archive_url":"https://api.github.com/repos/olafurpg/bsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olafurpg/bsp/downloads","issues_url":"https://api.github.com/repos/olafurpg/bsp/issues{/number}","pulls_url":"https://api.github.com/repos/olafurpg/bsp/pulls{/number}","milestones_url":"https://api.github.com/repos/olafurpg/bsp/milestones{/number}","notifications_url":"https://api.github.com/repos/olafurpg/bsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olafurpg/bsp/labels{/name}","releases_url":"https://api.github.com/repos/olafurpg/bsp/releases{/id}","deployments_url":"https://api.github.com/repos/olafurpg/bsp/deployments","created_at":"2018-01-17T09:59:10Z","updated_at":"2018-10-25T11:09:38Z","pushed_at":"2018-10-30T10:15:52Z","git_url":"git://github.com/olafurpg/bsp.git","ssh_url":"git@github.com:olafurpg/bsp.git","clone_url":"https://github.com/olafurpg/bsp.git","svn_url":"https://github.com/olafurpg/bsp","homepage":"","size":911,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"aca8bef32082e0470656827f50cd8fe9872295cc","user":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":116955501,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5NTU1MDE=","name":"bsp","full_name":"scalacenter/bsp","private":false,"owner":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalacenter/bsp","description":"Build Server Protocol for Scala","fork":false,"url":"https://api.github.com/repos/scalacenter/bsp","forks_url":"https://api.github.com/repos/scalacenter/bsp/forks","keys_url":"https://api.github.com/repos/scalacenter/bsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bsp/teams","hooks_url":"https://api.github.com/repos/scalacenter/bsp/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bsp/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bsp/events","assignees_url":"https://api.github.com/repos/scalacenter/bsp/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bsp/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bsp/tags","blobs_url":"https://api.github.com/repos/scalacenter/bsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bsp/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bsp/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bsp/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bsp/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bsp/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bsp/subscription","commits_url":"https://api.github.com/repos/scalacenter/bsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bsp/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bsp/merges","archive_url":"https://api.github.com/repos/scalacenter/bsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bsp/downloads","issues_url":"https://api.github.com/repos/scalacenter/bsp/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bsp/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bsp/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bsp/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bsp/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bsp/deployments","created_at":"2018-01-10T12:35:28Z","updated_at":"2018-10-26T15:22:16Z","pushed_at":"2018-10-30T10:15:53Z","git_url":"git://github.com/scalacenter/bsp.git","ssh_url":"git@github.com:scalacenter/bsp.git","clone_url":"https://github.com/scalacenter/bsp.git","svn_url":"https://github.com/scalacenter/bsp","homepage":"","size":953,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":18,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/62"},"html":{"href":"https://github.com/scalacenter/bsp/pull/62"},"issue":{"href":"https://api.github.com/repos/scalacenter/bsp/issues/62"},"comments":{"href":"https://api.github.com/repos/scalacenter/bsp/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/bsp/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/bsp/statuses/8d14a6a092682f57854a035e59d0cebfae598784"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jastice"}}