{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/community/pulls/comments/241677915","pull_request_review_id":185008856,"id":241677915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY3NzkxNQ==","diff_hunk":"@@ -161,6 +164,45 @@ reasons why this is _the right thing to do_:\n License: MIT\n Signed-off-by: Juan Benet <juan@ipfs.io>\n ```\n+\n+## Contributor Principles\n+\n+These principles are a living document and should be updated as-needed to better serve the go-ipfs community.\n+\n+In order of precedence:\n+\n+1. **Build the distributed peer-to-peer web.** This is our objective and aim - everything we do is in service of this goal and we only compromise our other principles if needed to achieve this.\n+2. **Don't break the IPFS ecosystem.** This isn't \"don't break protocols\"; we do occasionally break protocols and APIs (with care) when we know that users won't notice it. However, users trust us to not break their workflows/projects. If we do, we'll lose that trust and those users.\n+3. **Take ownership.** If you're working on something, own it and see it through. Given that (a) we don't have managers and (b) we don't work synchronously, coordination can be difficult. To make up for this, if you want something to happen, you have to make it happen (that may mean calling a meeting, bugging people, fixing unrelated issues, designing alternative solutions, etc.).\n+4. **Ask for forgiveness, not permission.** To enable P.3, if you're having trouble getting people to move on something, err on the side of getting things done (bounded by P.1 and P.2). Note: This doesn't apply when you *know* you'll need to ask for forgiveness... use your best judgment.\n+\n+## Code Change Policy\n+\n+The go code change policy must balance \"not breaking things\" with \"getting things done\" and should be read in that spirit. Use your best judgment when making changes and PRs; these rules are not set in stone.\n+\n+**How can the codebase be changed?**\n+\n+Except in special cases (and mass gx-workspace updates), all changes go through PRs.\n+\n+* Larger changes should be discussed in an issue *before* work is started to avoid wasted effort, tears, and dead fairies.\n+* WIP (work in progress), RFC (request for comments) changes should be marked as such. Not doing so can rouse the review gremlins.","path":"CONTRIBUTING_GO.md","position":49,"original_position":49,"commit_id":"486de2d8b916011b2c64caad1a0afbe65b43ad71","original_commit_id":"486de2d8b916011b2c64caad1a0afbe65b43ad71","user":{"login":"momack2","id":618519,"node_id":"MDQ6VXNlcjYxODUxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/618519?v=4","gravatar_id":"","url":"https://api.github.com/users/momack2","html_url":"https://github.com/momack2","followers_url":"https://api.github.com/users/momack2/followers","following_url":"https://api.github.com/users/momack2/following{/other_user}","gists_url":"https://api.github.com/users/momack2/gists{/gist_id}","starred_url":"https://api.github.com/users/momack2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momack2/subscriptions","organizations_url":"https://api.github.com/users/momack2/orgs","repos_url":"https://api.github.com/users/momack2/repos","events_url":"https://api.github.com/users/momack2/events{/privacy}","received_events_url":"https://api.github.com/users/momack2/received_events","type":"User","site_admin":false},"body":"cute - but IDK what the review gremlins are. Do you just mean someone might try to review your RFC before you intend them to? OR that it would make people mad / confused if it's an RFC but you don't explicitly say so?","created_at":"2018-12-14T08:41:21Z","updated_at":"2018-12-14T08:41:47Z","html_url":"https://github.com/ipfs/community/pull/377#discussion_r241677915","pull_request_url":"https://api.github.com/repos/ipfs/community/pulls/377","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ipfs/community/pulls/comments/241677915"},"html":{"href":"https://github.com/ipfs/community/pull/377#discussion_r241677915"},"pull_request":{"href":"https://api.github.com/repos/ipfs/community/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/community/pulls/377","id":237880886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODgwODg2","html_url":"https://github.com/ipfs/community/pull/377","diff_url":"https://github.com/ipfs/community/pull/377.diff","patch_url":"https://github.com/ipfs/community/pull/377.patch","issue_url":"https://api.github.com/repos/ipfs/community/issues/377","number":377,"state":"open","locked":false,"title":"[RFC] add contributor principles and merge policy","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"body":"cc @ipfs/go-team\r\n\r\nThis is a proposal, please discuss. If you don't think this answers questions like \"can I merge this?\", \"can I change this?\", etc., please say so.\r\n\r\nAlso, it would be *awesome* to get some examples here.","created_at":"2018-12-12T01:10:48Z","updated_at":"2018-12-14T08:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06da03c3d0f27dd6c22d9caf44c7ecb2d81bcf5e","assignee":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"assignees":[{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":195936695,"node_id":"MDU6TGFiZWwxOTU5MzY2OTU=","url":"https://api.github.com/repos/ipfs/community/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/community/pulls/377/commits","review_comments_url":"https://api.github.com/repos/ipfs/community/pulls/377/comments","review_comment_url":"https://api.github.com/repos/ipfs/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/community/issues/377/comments","statuses_url":"https://api.github.com/repos/ipfs/community/statuses/486de2d8b916011b2c64caad1a0afbe65b43ad71","head":{"label":"ipfs:feat/go-guidelines","ref":"feat/go-guidelines","sha":"486de2d8b916011b2c64caad1a0afbe65b43ad71","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":32509278,"node_id":"MDEwOlJlcG9zaXRvcnkzMjUwOTI3OA==","name":"community","full_name":"ipfs/community","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/community","description":"Discussion and documentation on community practices","fork":false,"url":"https://api.github.com/repos/ipfs/community","forks_url":"https://api.github.com/repos/ipfs/community/forks","keys_url":"https://api.github.com/repos/ipfs/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/community/teams","hooks_url":"https://api.github.com/repos/ipfs/community/hooks","issue_events_url":"https://api.github.com/repos/ipfs/community/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/community/events","assignees_url":"https://api.github.com/repos/ipfs/community/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/community/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/community/tags","blobs_url":"https://api.github.com/repos/ipfs/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/community/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/community/languages","stargazers_url":"https://api.github.com/repos/ipfs/community/stargazers","contributors_url":"https://api.github.com/repos/ipfs/community/contributors","subscribers_url":"https://api.github.com/repos/ipfs/community/subscribers","subscription_url":"https://api.github.com/repos/ipfs/community/subscription","commits_url":"https://api.github.com/repos/ipfs/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/community/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/community/merges","archive_url":"https://api.github.com/repos/ipfs/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/community/downloads","issues_url":"https://api.github.com/repos/ipfs/community/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/community/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/community/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/community/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/community/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/community/deployments","created_at":"2015-03-19T08:25:03Z","updated_at":"2018-12-11T20:04:25Z","pushed_at":"2018-12-13T03:47:08Z","git_url":"git://github.com/ipfs/community.git","ssh_url":"git@github.com:ipfs/community.git","clone_url":"https://github.com/ipfs/community.git","svn_url":"https://github.com/ipfs/community","homepage":"https://discuss.ipfs.io","size":3505,"stargazers_count":217,"watchers_count":217,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":71,"watchers":217,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"d5f7b7da83daa71c868e18f4723c0a783b4f16c1","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":32509278,"node_id":"MDEwOlJlcG9zaXRvcnkzMjUwOTI3OA==","name":"community","full_name":"ipfs/community","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/community","description":"Discussion and documentation on community practices","fork":false,"url":"https://api.github.com/repos/ipfs/community","forks_url":"https://api.github.com/repos/ipfs/community/forks","keys_url":"https://api.github.com/repos/ipfs/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/community/teams","hooks_url":"https://api.github.com/repos/ipfs/community/hooks","issue_events_url":"https://api.github.com/repos/ipfs/community/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/community/events","assignees_url":"https://api.github.com/repos/ipfs/community/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/community/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/community/tags","blobs_url":"https://api.github.com/repos/ipfs/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/community/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/community/languages","stargazers_url":"https://api.github.com/repos/ipfs/community/stargazers","contributors_url":"https://api.github.com/repos/ipfs/community/contributors","subscribers_url":"https://api.github.com/repos/ipfs/community/subscribers","subscription_url":"https://api.github.com/repos/ipfs/community/subscription","commits_url":"https://api.github.com/repos/ipfs/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/community/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/community/merges","archive_url":"https://api.github.com/repos/ipfs/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/community/downloads","issues_url":"https://api.github.com/repos/ipfs/community/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/community/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/community/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/community/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/community/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/community/deployments","created_at":"2015-03-19T08:25:03Z","updated_at":"2018-12-11T20:04:25Z","pushed_at":"2018-12-13T03:47:08Z","git_url":"git://github.com/ipfs/community.git","ssh_url":"git@github.com:ipfs/community.git","clone_url":"https://github.com/ipfs/community.git","svn_url":"https://github.com/ipfs/community","homepage":"https://discuss.ipfs.io","size":3505,"stargazers_count":217,"watchers_count":217,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":71,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/community/pulls/377"},"html":{"href":"https://github.com/ipfs/community/pull/377"},"issue":{"href":"https://api.github.com/repos/ipfs/community/issues/377"},"comments":{"href":"https://api.github.com/repos/ipfs/community/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/community/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/community/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/community/statuses/486de2d8b916011b2c64caad1a0afbe65b43ad71"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"momack2"}}