{"push_id":2370086461,"size":11,"distinct_size":9,"ref":"refs/heads/drmarsh/idiomatic-aspnet-integration","head":"90199e3e358c7d3d28cb3967e4c6d2da53f886cd","before":"ea6595e8f33ab4e8a8bb63ccf3cc7aae9041ac9f","commits":[{"sha":"5b0c41c8ad4a7ef145dda499ac6523a28d41af0f","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Fixes #226\n\n * Intro'd a static set of empty credentials on `MicrosoftAppCredentials` to minimize allocations/garbage being created for that scenario\n * Updated `BotFrameworkAdapter` to detect `null` application identity and use `Microsoft.AppCredentials.Empty` in that case","distinct":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/5b0c41c8ad4a7ef145dda499ac6523a28d41af0f"},{"sha":"d704ebd9a7aba0e902294cf954f06dc253efc06b","author":{"name":"Chris Mullins","email":"5ccadef2fc16837853c5a11e46b874117ccf43bf@users.noreply.github.com"},"message":"Merge pull request #229 from Microsoft/bug/226\n\nFix BotFrameworkAdapter::GetAppCredentials assuming configured credentials","distinct":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/d704ebd9a7aba0e902294cf954f06dc253efc06b"},{"sha":"b27ac6f476c0dcc2f7cf9b7ff040a9ca3fd96ab9","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Initial work to remove need for controller in 461 sample","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/b27ac6f476c0dcc2f7cf9b7ff040a9ca3fd96ab9"},{"sha":"8f6f82a7bbc08c45f01713a4579303c4272018b7","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Factored out ASP.NET integration into separate project\n\nMoved the integration code out of the sample project into its own.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/8f6f82a7bbc08c45f01713a4579303c4272018b7"},{"sha":"c715fc36cbef8921d5f3f49c918cb36cf19312c5","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Updating newer code with API changes after rebase\n\nNeeded to address API changes to state management after rebasing against latest from `master`.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/c715fc36cbef8921d5f3f49c918cb36cf19312c5"},{"sha":"ee664cc91fb7cd89a55aecab77b169e9d758a7dd","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Add initial request validation to ASP.NET (NetFx) request handler\n\nValidation things like HTTP method, Content-Length and Content-Type.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/ee664cc91fb7cd89a55aecab77b169e9d758a7dd"},{"sha":"0afa9ff319e17400a87858acc43781f16b48fb55","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Initial implementation of .NET Core integration","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/0afa9ff319e17400a87858acc43781f16b48fb55"},{"sha":"0cce750d53368a47f1d88ae665d3f9e5e1513efa","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Fix bug in samples where state *must* still inherit from StoreItem right now\n\nWas ending up with runtime binding exceptions in the state management code (hard crashes in .NET Core!) because right now the `BotState` implementations still assumes the type to be a `StoreItem` subclass even though `TState` is only statically constrained to `IStoreItem, new()`.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/0cce750d53368a47f1d88ae665d3f9e5e1513efa"},{"sha":"98dffa590bf0f3e41489b72f549096fb28988629","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Changes default root url to /bot for consistency with NetFx impl\n\nWas `/bots`, but should be `/bot` to align with the NetFx defaults and now that I've made the configuration only support single bot instance anyway.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/98dffa590bf0f3e41489b72f549096fb28988629"},{"sha":"4da9a5e1db7ba5ffe4c94793a5efda66fce21809","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Even more idiomatic .NET Core configuration\n\nWhile the original goal was to try and have some consistency between the .NET Core and NetFx configuration APIs, I did some deeper studying of .NET core configuration practices and decided the approach needed some revision.\n\nAlso removed dependency on routing as it is no longer needed.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/4da9a5e1db7ba5ffe4c94793a5efda66fce21809"},{"sha":"90199e3e358c7d3d28cb3967e4c6d2da53f886cd","author":{"name":"Drew Marsh","email":"293ebcf13b76d632d6fc73c6ebc5811c26dcae5a@microsoft.com"},"message":"Refactor sample bot into its own library\n\nBoth ASP.NET sample projects had their own MyBot, so I've refactored that into a separate, stand-alone library called EchoBot (since that's what the implementation actually is).\n\nI then updated both ASP.NET projects to reference this library and also refactored the Console based sample to use this bot as well to show the difference of hosting there.","distinct":true,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits/90199e3e358c7d3d28cb3967e4c6d2da53f886cd"}]}
{"actor":{"display_login":"drub0y"}}