{"action":"created","comment":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments/233522779","pull_request_review_id":174956535,"id":233522779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzUyMjc3OQ==","diff_hunk":"@@ -201,7 +204,7 @@ export class Toast implements ComponentInterface, OverlayInterface {\n       <div class={wrapperClass}>\n         <div class=\"toast-container\">\n           {this.message !== undefined &&\n-            <div class=\"toast-message\">{this.message}</div>\n+            <div class=\"toast-message\" innerHTML={this.message}></div>","path":"core/src/components/toast/toast.tsx","position":19,"original_position":19,"commit_id":"c1d68fe6c1472e32a78acf155e508486c80fe0c9","original_commit_id":"c1d68fe6c1472e32a78acf155e508486c80fe0c9","user":{"login":"manucorporat","id":127379,"node_id":"MDQ6VXNlcjEyNzM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/127379?v=4","gravatar_id":"","url":"https://api.github.com/users/manucorporat","html_url":"https://github.com/manucorporat","followers_url":"https://api.github.com/users/manucorporat/followers","following_url":"https://api.github.com/users/manucorporat/following{/other_user}","gists_url":"https://api.github.com/users/manucorporat/gists{/gist_id}","starred_url":"https://api.github.com/users/manucorporat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manucorporat/subscriptions","organizations_url":"https://api.github.com/users/manucorporat/orgs","repos_url":"https://api.github.com/users/manucorporat/repos","events_url":"https://api.github.com/users/manucorporat/events{/privacy}","received_events_url":"https://api.github.com/users/manucorporat/received_events","type":"User","site_admin":false},"body":"security, can we make this change in a different PR?","created_at":"2018-11-14T16:33:09Z","updated_at":"2018-11-14T16:33:18Z","html_url":"https://github.com/ionic-team/ionic/pull/16323#discussion_r233522779","pull_request_url":"https://api.github.com/repos/ionic-team/ionic/pulls/16323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments/233522779"},"html":{"href":"https://github.com/ionic-team/ionic/pull/16323#discussion_r233522779"},"pull_request":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16323"}}},"pull_request":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/16323","id":230895372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODk1Mzcy","html_url":"https://github.com/ionic-team/ionic/pull/16323","diff_url":"https://github.com/ionic-team/ionic/pull/16323.diff","patch_url":"https://github.com/ionic-team/ionic/pull/16323.patch","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/16323","number":16323,"state":"open","locked":false,"title":"fix(toast): update toast design to match MD spec","user":{"login":"brandyscarney","id":6577830,"node_id":"MDQ6VXNlcjY1Nzc4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6577830?v=4","gravatar_id":"","url":"https://api.github.com/users/brandyscarney","html_url":"https://github.com/brandyscarney","followers_url":"https://api.github.com/users/brandyscarney/followers","following_url":"https://api.github.com/users/brandyscarney/following{/other_user}","gists_url":"https://api.github.com/users/brandyscarney/gists{/gist_id}","starred_url":"https://api.github.com/users/brandyscarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandyscarney/subscriptions","organizations_url":"https://api.github.com/users/brandyscarney/orgs","repos_url":"https://api.github.com/users/brandyscarney/repos","events_url":"https://api.github.com/users/brandyscarney/events{/privacy}","received_events_url":"https://api.github.com/users/brandyscarney/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\nUpdates the Material Design Toast to closer match the spec: https://material.io/design/components/snackbars.html\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Updates the animation to use opacity, not translate\r\n- Updates design with the right background, box-shadow, etc.\r\n- Fixes the broken position middle of toast (https://github.com/ionic-team/ionic/issues/16271) and updates e2e test to include this\r\n- Allows for html to be passed to the message\r\n\r\n**Ionic Version**: 4.x\r\n\r\n**Fixes**: #16271\r\n\r\n| `master` | `fix-toast-design` |\r\n| ----------| -------------------|\r\n| ![localhost_3333_src_components_toast_test_basic galaxy s5 5](https://user-images.githubusercontent.com/6577830/48496311-c43fea80-e7ff-11e8-96ae-07a928f3325b.png) | ![localhost_3333_src_components_toast_test_basic galaxy s5 2](https://user-images.githubusercontent.com/6577830/48496183-7e832200-e7ff-11e8-8721-c0fc50613d10.png) |\r\n\r\n\r\n","created_at":"2018-11-14T16:19:04Z","updated_at":"2018-11-14T16:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"643db7ea4ad6379f4ec959249e8bbc8e2fcc4a42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":999100804,"node_id":"MDU6TGFiZWw5OTkxMDA4MDQ=","url":"https://api.github.com/repos/ionic-team/ionic/labels/core","name":"core","color":"1066ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ionic-team/ionic/pulls/16323/commits","review_comments_url":"https://api.github.com/repos/ionic-team/ionic/pulls/16323/comments","review_comment_url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/16323/comments","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/c1d68fe6c1472e32a78acf155e508486c80fe0c9","head":{"label":"ionic-team:fix-toast-design","ref":"fix-toast-design","sha":"c1d68fe6c1472e32a78acf155e508486c80fe0c9","user":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1NjM3Ng==","name":"ionic","full_name":"ionic-team/ionic","private":false,"owner":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ionic-team/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/ionic-team/ionic","forks_url":"https://api.github.com/repos/ionic-team/ionic/forks","keys_url":"https://api.github.com/repos/ionic-team/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/ionic/teams","hooks_url":"https://api.github.com/repos/ionic-team/ionic/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/ionic/events","assignees_url":"https://api.github.com/repos/ionic-team/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/ionic/tags","blobs_url":"https://api.github.com/repos/ionic-team/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/ionic/languages","stargazers_url":"https://api.github.com/repos/ionic-team/ionic/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/ionic/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/ionic/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/ionic/subscription","commits_url":"https://api.github.com/repos/ionic-team/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/ionic/merges","archive_url":"https://api.github.com/repos/ionic-team/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/ionic/downloads","issues_url":"https://api.github.com/repos/ionic-team/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/ionic/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2018-11-14T15:44:43Z","pushed_at":"2018-11-14T16:32:31Z","git_url":"git://github.com/ionic-team/ionic.git","ssh_url":"git@github.com:ionic-team/ionic.git","clone_url":"https://github.com/ionic-team/ionic.git","svn_url":"https://github.com/ionic-team/ionic","homepage":"https://ionicframework.com/","size":91106,"stargazers_count":35810,"watchers_count":35810,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12362,"mirror_url":null,"archived":false,"open_issues_count":1327,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12362,"open_issues":1327,"watchers":35810,"default_branch":"master"}},"base":{"label":"ionic-team:master","ref":"master","sha":"4c525fd9f7ef1e58abe4b7d0b091646460f7423e","user":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1NjM3Ng==","name":"ionic","full_name":"ionic-team/ionic","private":false,"owner":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ionic-team/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/ionic-team/ionic","forks_url":"https://api.github.com/repos/ionic-team/ionic/forks","keys_url":"https://api.github.com/repos/ionic-team/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/ionic/teams","hooks_url":"https://api.github.com/repos/ionic-team/ionic/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/ionic/events","assignees_url":"https://api.github.com/repos/ionic-team/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/ionic/tags","blobs_url":"https://api.github.com/repos/ionic-team/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/ionic/languages","stargazers_url":"https://api.github.com/repos/ionic-team/ionic/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/ionic/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/ionic/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/ionic/subscription","commits_url":"https://api.github.com/repos/ionic-team/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/ionic/merges","archive_url":"https://api.github.com/repos/ionic-team/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/ionic/downloads","issues_url":"https://api.github.com/repos/ionic-team/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/ionic/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2018-11-14T15:44:43Z","pushed_at":"2018-11-14T16:32:31Z","git_url":"git://github.com/ionic-team/ionic.git","ssh_url":"git@github.com:ionic-team/ionic.git","clone_url":"https://github.com/ionic-team/ionic.git","svn_url":"https://github.com/ionic-team/ionic","homepage":"https://ionicframework.com/","size":91106,"stargazers_count":35810,"watchers_count":35810,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12362,"mirror_url":null,"archived":false,"open_issues_count":1327,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12362,"open_issues":1327,"watchers":35810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16323"},"html":{"href":"https://github.com/ionic-team/ionic/pull/16323"},"issue":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/16323"},"comments":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/16323/comments"},"review_comments":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16323/comments"},"review_comment":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16323/commits"},"statuses":{"href":"https://api.github.com/repos/ionic-team/ionic/statuses/c1d68fe6c1472e32a78acf155e508486c80fe0c9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"manucorporat"}}