{"action":"created","comment":{"url":"https://api.github.com/repos/actiniumio/allspark/pulls/comments/214511378","pull_request_review_id":151590960,"id":214511378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUxMTM3OA==","diff_hunk":"@@ -2,12 +2,26 @@\n # vi: set ft=ruby :\n \n Vagrant.configure(\"2\") do |config|\n-  config.vm.box = \"centos/7\"\n-  config.vm.network \"forwarded_port\", guest: 80, host: 8080, host_ip: \"127.0.0.1\"\n-  config.vm.provider \"virtualbox\" do |vb|\n-    vb.memory = \"2048\"\n+  config.vm.define \"centos7\", primary: true do |centos7|\n+    centos7.vm.box = \"centos/7\"","path":"Vagrantfile","position":9,"original_position":9,"commit_id":"c93195441d7fd208a8679ee7d60dcd48c71bc106","original_commit_id":"c93195441d7fd208a8679ee7d60dcd48c71bc106","user":{"login":"Xide","id":3811182,"node_id":"MDQ6VXNlcjM4MTExODI=","avatar_url":"https://avatars2.githubusercontent.com/u/3811182?v=4","gravatar_id":"","url":"https://api.github.com/users/Xide","html_url":"https://github.com/Xide","followers_url":"https://api.github.com/users/Xide/followers","following_url":"https://api.github.com/users/Xide/following{/other_user}","gists_url":"https://api.github.com/users/Xide/gists{/gist_id}","starred_url":"https://api.github.com/users/Xide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xide/subscriptions","organizations_url":"https://api.github.com/users/Xide/orgs","repos_url":"https://api.github.com/users/Xide/repos","events_url":"https://api.github.com/users/Xide/events{/privacy}","received_events_url":"https://api.github.com/users/Xide/received_events","type":"User","site_admin":false},"body":"Feels strange to be to use the library box here and the actinium box for ubuntu. I think we should create an actinium box no matter what when we plan to support a new OS.","created_at":"2018-09-01T11:28:25Z","updated_at":"2018-09-01T11:55:00Z","html_url":"https://github.com/actiniumio/allspark/pull/80#discussion_r214511378","pull_request_url":"https://api.github.com/repos/actiniumio/allspark/pulls/80","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/comments/214511378"},"html":{"href":"https://github.com/actiniumio/allspark/pull/80#discussion_r214511378"},"pull_request":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/actiniumio/allspark/pulls/80","id":210456165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDU2MTY1","html_url":"https://github.com/actiniumio/allspark/pull/80","diff_url":"https://github.com/actiniumio/allspark/pull/80.diff","patch_url":"https://github.com/actiniumio/allspark/pull/80.patch","issue_url":"https://api.github.com/repos/actiniumio/allspark/issues/80","number":80,"state":"open","locked":false,"title":"Hotfix/os compatibility","user":{"login":"guiadco","id":34829865,"node_id":"MDQ6VXNlcjM0ODI5ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/34829865?v=4","gravatar_id":"","url":"https://api.github.com/users/guiadco","html_url":"https://github.com/guiadco","followers_url":"https://api.github.com/users/guiadco/followers","following_url":"https://api.github.com/users/guiadco/following{/other_user}","gists_url":"https://api.github.com/users/guiadco/gists{/gist_id}","starred_url":"https://api.github.com/users/guiadco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guiadco/subscriptions","organizations_url":"https://api.github.com/users/guiadco/orgs","repos_url":"https://api.github.com/users/guiadco/repos","events_url":"https://api.github.com/users/guiadco/events{/privacy}","received_events_url":"https://api.github.com/users/guiadco/received_events","type":"User","site_admin":false},"body":"### Current behaviour\r\n\r\nActually, you have 1 playbook for CentOS or RedHat. So AllSpark is only compatible with that 2 systems\r\n\r\n- I think it's necessary to talk over the convention:\r\n\r\nDo you want to use the ansible_distribution so you need 1 playbook by distribution like \r\n- CentOS \r\n- RedHat \r\n- Ubuntu \r\n- Debian\r\n\r\nOr do you want to use ansible_os_family so you need 1 playbook by OS Family like :\r\n- 1 for CentOS/RedHat\r\n- 1 for Ubuntu/Debian\r\n\r\nIn my mind, i prefere to use the ansible_distribution instead of family to be more precise on each distribution\r\n\r\n---\r\n### Expected behaviour\r\n\r\nThe current AllSpark version provides an appliance suite on docker so for me AllSpark is naturally compatible with all OS supporting Docker.\r\n\r\n---\r\n### Modifications\r\n\r\n-  [x] Change the call system to be dynamic with the system.\r\n-  [x] Rename the rhel7.yml to CentOS-7.yml\r\n-  [x] Modify the contributing.md to authorise everyone to add OS Compatibility like Ubuntu, etc...\r\n\r\n---\r\n### Related issues\r\n\r\n> What issue are affected by or affecting this pull request.\r\n\r\n- resolve #75 \r\n- resolve #74 \r\n- resolve #73 \r\n\r\n---\r\n### Status\r\n\r\n- [x] Implementation\r\n- [x] Test coverage\r\n- [x] Documentation\r\n","created_at":"2018-08-23T13:53:15Z","updated_at":"2018-09-01T11:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52029d48b8ff0ede2d5ef7d08640a621f70cccaf","assignee":{"login":"guiadco","id":34829865,"node_id":"MDQ6VXNlcjM0ODI5ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/34829865?v=4","gravatar_id":"","url":"https://api.github.com/users/guiadco","html_url":"https://github.com/guiadco","followers_url":"https://api.github.com/users/guiadco/followers","following_url":"https://api.github.com/users/guiadco/following{/other_user}","gists_url":"https://api.github.com/users/guiadco/gists{/gist_id}","starred_url":"https://api.github.com/users/guiadco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guiadco/subscriptions","organizations_url":"https://api.github.com/users/guiadco/orgs","repos_url":"https://api.github.com/users/guiadco/repos","events_url":"https://api.github.com/users/guiadco/events{/privacy}","received_events_url":"https://api.github.com/users/guiadco/received_events","type":"User","site_admin":false},"assignees":[{"login":"guiadco","id":34829865,"node_id":"MDQ6VXNlcjM0ODI5ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/34829865?v=4","gravatar_id":"","url":"https://api.github.com/users/guiadco","html_url":"https://github.com/guiadco","followers_url":"https://api.github.com/users/guiadco/followers","following_url":"https://api.github.com/users/guiadco/following{/other_user}","gists_url":"https://api.github.com/users/guiadco/gists{/gist_id}","starred_url":"https://api.github.com/users/guiadco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guiadco/subscriptions","organizations_url":"https://api.github.com/users/guiadco/orgs","repos_url":"https://api.github.com/users/guiadco/repos","events_url":"https://api.github.com/users/guiadco/events{/privacy}","received_events_url":"https://api.github.com/users/guiadco/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"davStar","id":26174579,"node_id":"MDQ6VXNlcjI2MTc0NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/26174579?v=4","gravatar_id":"","url":"https://api.github.com/users/davStar","html_url":"https://github.com/davStar","followers_url":"https://api.github.com/users/davStar/followers","following_url":"https://api.github.com/users/davStar/following{/other_user}","gists_url":"https://api.github.com/users/davStar/gists{/gist_id}","starred_url":"https://api.github.com/users/davStar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davStar/subscriptions","organizations_url":"https://api.github.com/users/davStar/orgs","repos_url":"https://api.github.com/users/davStar/repos","events_url":"https://api.github.com/users/davStar/events{/privacy}","received_events_url":"https://api.github.com/users/davStar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":935030640,"node_id":"MDU6TGFiZWw5MzUwMzA2NDA=","url":"https://api.github.com/repos/actiniumio/allspark/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/actiniumio/allspark/pulls/80/commits","review_comments_url":"https://api.github.com/repos/actiniumio/allspark/pulls/80/comments","review_comment_url":"https://api.github.com/repos/actiniumio/allspark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/actiniumio/allspark/issues/80/comments","statuses_url":"https://api.github.com/repos/actiniumio/allspark/statuses/c93195441d7fd208a8679ee7d60dcd48c71bc106","head":{"label":"actiniumio:hotfix/os-compatibility","ref":"hotfix/os-compatibility","sha":"c93195441d7fd208a8679ee7d60dcd48c71bc106","user":{"login":"actiniumio","id":39337752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzM3NzUy","avatar_url":"https://avatars3.githubusercontent.com/u/39337752?v=4","gravatar_id":"","url":"https://api.github.com/users/actiniumio","html_url":"https://github.com/actiniumio","followers_url":"https://api.github.com/users/actiniumio/followers","following_url":"https://api.github.com/users/actiniumio/following{/other_user}","gists_url":"https://api.github.com/users/actiniumio/gists{/gist_id}","starred_url":"https://api.github.com/users/actiniumio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actiniumio/subscriptions","organizations_url":"https://api.github.com/users/actiniumio/orgs","repos_url":"https://api.github.com/users/actiniumio/repos","events_url":"https://api.github.com/users/actiniumio/events{/privacy}","received_events_url":"https://api.github.com/users/actiniumio/received_events","type":"Organization","site_admin":false},"repo":{"id":133666885,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2NjY4ODU=","name":"allspark","full_name":"actiniumio/allspark","owner":{"login":"actiniumio","id":39337752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzM3NzUy","avatar_url":"https://avatars3.githubusercontent.com/u/39337752?v=4","gravatar_id":"","url":"https://api.github.com/users/actiniumio","html_url":"https://github.com/actiniumio","followers_url":"https://api.github.com/users/actiniumio/followers","following_url":"https://api.github.com/users/actiniumio/following{/other_user}","gists_url":"https://api.github.com/users/actiniumio/gists{/gist_id}","starred_url":"https://api.github.com/users/actiniumio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actiniumio/subscriptions","organizations_url":"https://api.github.com/users/actiniumio/orgs","repos_url":"https://api.github.com/users/actiniumio/repos","events_url":"https://api.github.com/users/actiniumio/events{/privacy}","received_events_url":"https://api.github.com/users/actiniumio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/actiniumio/allspark","description":"Developer toolbox","fork":false,"url":"https://api.github.com/repos/actiniumio/allspark","forks_url":"https://api.github.com/repos/actiniumio/allspark/forks","keys_url":"https://api.github.com/repos/actiniumio/allspark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actiniumio/allspark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actiniumio/allspark/teams","hooks_url":"https://api.github.com/repos/actiniumio/allspark/hooks","issue_events_url":"https://api.github.com/repos/actiniumio/allspark/issues/events{/number}","events_url":"https://api.github.com/repos/actiniumio/allspark/events","assignees_url":"https://api.github.com/repos/actiniumio/allspark/assignees{/user}","branches_url":"https://api.github.com/repos/actiniumio/allspark/branches{/branch}","tags_url":"https://api.github.com/repos/actiniumio/allspark/tags","blobs_url":"https://api.github.com/repos/actiniumio/allspark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actiniumio/allspark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actiniumio/allspark/git/refs{/sha}","trees_url":"https://api.github.com/repos/actiniumio/allspark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actiniumio/allspark/statuses/{sha}","languages_url":"https://api.github.com/repos/actiniumio/allspark/languages","stargazers_url":"https://api.github.com/repos/actiniumio/allspark/stargazers","contributors_url":"https://api.github.com/repos/actiniumio/allspark/contributors","subscribers_url":"https://api.github.com/repos/actiniumio/allspark/subscribers","subscription_url":"https://api.github.com/repos/actiniumio/allspark/subscription","commits_url":"https://api.github.com/repos/actiniumio/allspark/commits{/sha}","git_commits_url":"https://api.github.com/repos/actiniumio/allspark/git/commits{/sha}","comments_url":"https://api.github.com/repos/actiniumio/allspark/comments{/number}","issue_comment_url":"https://api.github.com/repos/actiniumio/allspark/issues/comments{/number}","contents_url":"https://api.github.com/repos/actiniumio/allspark/contents/{+path}","compare_url":"https://api.github.com/repos/actiniumio/allspark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actiniumio/allspark/merges","archive_url":"https://api.github.com/repos/actiniumio/allspark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actiniumio/allspark/downloads","issues_url":"https://api.github.com/repos/actiniumio/allspark/issues{/number}","pulls_url":"https://api.github.com/repos/actiniumio/allspark/pulls{/number}","milestones_url":"https://api.github.com/repos/actiniumio/allspark/milestones{/number}","notifications_url":"https://api.github.com/repos/actiniumio/allspark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actiniumio/allspark/labels{/name}","releases_url":"https://api.github.com/repos/actiniumio/allspark/releases{/id}","deployments_url":"https://api.github.com/repos/actiniumio/allspark/deployments","created_at":"2018-05-16T13:05:04Z","updated_at":"2018-08-31T11:25:56Z","pushed_at":"2018-08-31T18:28:46Z","git_url":"git://github.com/actiniumio/allspark.git","ssh_url":"git@github.com:actiniumio/allspark.git","clone_url":"https://github.com/actiniumio/allspark.git","svn_url":"https://github.com/actiniumio/allspark","homepage":null,"size":1050,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":3,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"actiniumio:master","ref":"master","sha":"30731b33bf92185a93f476f7727b868b2d7c68ea","user":{"login":"actiniumio","id":39337752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzM3NzUy","avatar_url":"https://avatars3.githubusercontent.com/u/39337752?v=4","gravatar_id":"","url":"https://api.github.com/users/actiniumio","html_url":"https://github.com/actiniumio","followers_url":"https://api.github.com/users/actiniumio/followers","following_url":"https://api.github.com/users/actiniumio/following{/other_user}","gists_url":"https://api.github.com/users/actiniumio/gists{/gist_id}","starred_url":"https://api.github.com/users/actiniumio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actiniumio/subscriptions","organizations_url":"https://api.github.com/users/actiniumio/orgs","repos_url":"https://api.github.com/users/actiniumio/repos","events_url":"https://api.github.com/users/actiniumio/events{/privacy}","received_events_url":"https://api.github.com/users/actiniumio/received_events","type":"Organization","site_admin":false},"repo":{"id":133666885,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2NjY4ODU=","name":"allspark","full_name":"actiniumio/allspark","owner":{"login":"actiniumio","id":39337752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzM3NzUy","avatar_url":"https://avatars3.githubusercontent.com/u/39337752?v=4","gravatar_id":"","url":"https://api.github.com/users/actiniumio","html_url":"https://github.com/actiniumio","followers_url":"https://api.github.com/users/actiniumio/followers","following_url":"https://api.github.com/users/actiniumio/following{/other_user}","gists_url":"https://api.github.com/users/actiniumio/gists{/gist_id}","starred_url":"https://api.github.com/users/actiniumio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actiniumio/subscriptions","organizations_url":"https://api.github.com/users/actiniumio/orgs","repos_url":"https://api.github.com/users/actiniumio/repos","events_url":"https://api.github.com/users/actiniumio/events{/privacy}","received_events_url":"https://api.github.com/users/actiniumio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/actiniumio/allspark","description":"Developer toolbox","fork":false,"url":"https://api.github.com/repos/actiniumio/allspark","forks_url":"https://api.github.com/repos/actiniumio/allspark/forks","keys_url":"https://api.github.com/repos/actiniumio/allspark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actiniumio/allspark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actiniumio/allspark/teams","hooks_url":"https://api.github.com/repos/actiniumio/allspark/hooks","issue_events_url":"https://api.github.com/repos/actiniumio/allspark/issues/events{/number}","events_url":"https://api.github.com/repos/actiniumio/allspark/events","assignees_url":"https://api.github.com/repos/actiniumio/allspark/assignees{/user}","branches_url":"https://api.github.com/repos/actiniumio/allspark/branches{/branch}","tags_url":"https://api.github.com/repos/actiniumio/allspark/tags","blobs_url":"https://api.github.com/repos/actiniumio/allspark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actiniumio/allspark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actiniumio/allspark/git/refs{/sha}","trees_url":"https://api.github.com/repos/actiniumio/allspark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actiniumio/allspark/statuses/{sha}","languages_url":"https://api.github.com/repos/actiniumio/allspark/languages","stargazers_url":"https://api.github.com/repos/actiniumio/allspark/stargazers","contributors_url":"https://api.github.com/repos/actiniumio/allspark/contributors","subscribers_url":"https://api.github.com/repos/actiniumio/allspark/subscribers","subscription_url":"https://api.github.com/repos/actiniumio/allspark/subscription","commits_url":"https://api.github.com/repos/actiniumio/allspark/commits{/sha}","git_commits_url":"https://api.github.com/repos/actiniumio/allspark/git/commits{/sha}","comments_url":"https://api.github.com/repos/actiniumio/allspark/comments{/number}","issue_comment_url":"https://api.github.com/repos/actiniumio/allspark/issues/comments{/number}","contents_url":"https://api.github.com/repos/actiniumio/allspark/contents/{+path}","compare_url":"https://api.github.com/repos/actiniumio/allspark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actiniumio/allspark/merges","archive_url":"https://api.github.com/repos/actiniumio/allspark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actiniumio/allspark/downloads","issues_url":"https://api.github.com/repos/actiniumio/allspark/issues{/number}","pulls_url":"https://api.github.com/repos/actiniumio/allspark/pulls{/number}","milestones_url":"https://api.github.com/repos/actiniumio/allspark/milestones{/number}","notifications_url":"https://api.github.com/repos/actiniumio/allspark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actiniumio/allspark/labels{/name}","releases_url":"https://api.github.com/repos/actiniumio/allspark/releases{/id}","deployments_url":"https://api.github.com/repos/actiniumio/allspark/deployments","created_at":"2018-05-16T13:05:04Z","updated_at":"2018-08-31T11:25:56Z","pushed_at":"2018-08-31T18:28:46Z","git_url":"git://github.com/actiniumio/allspark.git","ssh_url":"git@github.com:actiniumio/allspark.git","clone_url":"https://github.com/actiniumio/allspark.git","svn_url":"https://github.com/actiniumio/allspark","homepage":null,"size":1050,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":3,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/80"},"html":{"href":"https://github.com/actiniumio/allspark/pull/80"},"issue":{"href":"https://api.github.com/repos/actiniumio/allspark/issues/80"},"comments":{"href":"https://api.github.com/repos/actiniumio/allspark/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/actiniumio/allspark/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/actiniumio/allspark/statuses/c93195441d7fd208a8679ee7d60dcd48c71bc106"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Xide"}}