{"action":"created","issue":{"url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/4","repository_url":"https://api.github.com/repos/epsitec-sa/hazardous","labels_url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/4/comments","events_url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/4/events","html_url":"https://github.com/epsitec-sa/hazardous/pull/4","id":341756238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODE3NjMz","number":4,"title":"Removed unnecessary dependency for original-fs package","user":{"login":"kiddailey","id":358292,"node_id":"MDQ6VXNlcjM1ODI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/358292?v=4","gravatar_id":"","url":"https://api.github.com/users/kiddailey","html_url":"https://github.com/kiddailey","followers_url":"https://api.github.com/users/kiddailey/followers","following_url":"https://api.github.com/users/kiddailey/following{/other_user}","gists_url":"https://api.github.com/users/kiddailey/gists{/gist_id}","starred_url":"https://api.github.com/users/kiddailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiddailey/subscriptions","organizations_url":"https://api.github.com/users/kiddailey/orgs","repos_url":"https://api.github.com/users/kiddailey/repos","events_url":"https://api.github.com/users/kiddailey/events{/privacy}","received_events_url":"https://api.github.com/users/kiddailey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-17T03:52:15Z","updated_at":"2018-07-17T22:40:02Z","closed_at":"2018-07-17T22:07:37Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/epsitec-sa/hazardous/pulls/4","html_url":"https://github.com/epsitec-sa/hazardous/pull/4","diff_url":"https://github.com/epsitec-sa/hazardous/pull/4.diff","patch_url":"https://github.com/epsitec-sa/hazardous/pull/4.patch"},"body":"When including this package in my Electron project, I get an error trying to resolve \"original-fs\" on line 44:\r\n\r\n```\r\nconst fs = process.versions.electron\r\n     ? require ('original-fs')\r\n     : require ('fs');\r\n```\r\n\r\nLooking at the package.json, I see that original-fs is not included as a dependency.  All this package does is wrap a require(\"fs\") in a module.exports, which seems unnecessary.  I confirmed by modifying these lines to the following and it worked as expected.\r\n\r\n```\r\nconst fs = require ('fs');\r\n```"},"comment":{"url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/comments/405751203","html_url":"https://github.com/epsitec-sa/hazardous/pull/4#issuecomment-405751203","issue_url":"https://api.github.com/repos/epsitec-sa/hazardous/issues/4","id":405751203,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTc1MTIwMw==","user":{"login":"Skywalker13","id":397862,"node_id":"MDQ6VXNlcjM5Nzg2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/397862?v=4","gravatar_id":"","url":"https://api.github.com/users/Skywalker13","html_url":"https://github.com/Skywalker13","followers_url":"https://api.github.com/users/Skywalker13/followers","following_url":"https://api.github.com/users/Skywalker13/following{/other_user}","gists_url":"https://api.github.com/users/Skywalker13/gists{/gist_id}","starred_url":"https://api.github.com/users/Skywalker13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skywalker13/subscriptions","organizations_url":"https://api.github.com/users/Skywalker13/orgs","repos_url":"https://api.github.com/users/Skywalker13/repos","events_url":"https://api.github.com/users/Skywalker13/events{/privacy}","received_events_url":"https://api.github.com/users/Skywalker13/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T22:40:02Z","updated_at":"2018-07-17T22:40:02Z","author_association":"MEMBER","body":"> Your example seems to say that I could change Hazardous to set process.noAsar based on the presence of process.versions.electron instead of requiring original-fs. Am I understanding correctly?\r\n\r\nCorrect"}}
{"actor":{"display_login":"Skywalker13"}}