{"action":"closed","number":487,"pull_request":{"url":"https://api.github.com/repos/heptio/contour/pulls/487","id":198374643,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mzc0NjQz","html_url":"https://github.com/heptio/contour/pull/487","diff_url":"https://github.com/heptio/contour/pull/487.diff","patch_url":"https://github.com/heptio/contour/pull/487.patch","issue_url":"https://api.github.com/repos/heptio/contour/issues/487","number":487,"state":"closed","locked":false,"title":"Fix IngressRoute weights implementation","user":{"login":"stevesloka","id":1048184,"node_id":"MDQ6VXNlcjEwNDgxODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1048184?v=4","gravatar_id":"","url":"https://api.github.com/users/stevesloka","html_url":"https://github.com/stevesloka","followers_url":"https://api.github.com/users/stevesloka/followers","following_url":"https://api.github.com/users/stevesloka/following{/other_user}","gists_url":"https://api.github.com/users/stevesloka/gists{/gist_id}","starred_url":"https://api.github.com/users/stevesloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevesloka/subscriptions","organizations_url":"https://api.github.com/users/stevesloka/orgs","repos_url":"https://api.github.com/users/stevesloka/repos","events_url":"https://api.github.com/users/stevesloka/events{/privacy}","received_events_url":"https://api.github.com/users/stevesloka/received_events","type":"User","site_admin":false},"body":"This fixes #477 and uses the following strategy:\r\n\r\n- If no weights are specified, it's assumed even distribution\r\n- If all weights are specified then they are used and the \"total\" weight is the sum of those specified. (ex. If weights are 20, 30, 20 for three upstreams, the total weight would be 70)\r\n- If some weights are specified but others are not, then it's assumed that upstream not specified gets zero traffic and its weight is set to zero\r\n\r\nSigned-off-by: Steve Sloka <steves@heptio.com>","created_at":"2018-06-29T17:09:37Z","updated_at":"2018-07-05T10:11:59Z","closed_at":"2018-07-05T10:11:58Z","merged_at":"2018-07-05T10:11:58Z","merge_commit_sha":"f32460848575d3e275ace7dcdc2d12f0e32c8123","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heptio/contour/pulls/487/commits","review_comments_url":"https://api.github.com/repos/heptio/contour/pulls/487/comments","review_comment_url":"https://api.github.com/repos/heptio/contour/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/contour/issues/487/comments","statuses_url":"https://api.github.com/repos/heptio/contour/statuses/f32460848575d3e275ace7dcdc2d12f0e32c8123","head":{"label":"stevesloka:weights","ref":"weights","sha":"f32460848575d3e275ace7dcdc2d12f0e32c8123","user":{"login":"stevesloka","id":1048184,"node_id":"MDQ6VXNlcjEwNDgxODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1048184?v=4","gravatar_id":"","url":"https://api.github.com/users/stevesloka","html_url":"https://github.com/stevesloka","followers_url":"https://api.github.com/users/stevesloka/followers","following_url":"https://api.github.com/users/stevesloka/following{/other_user}","gists_url":"https://api.github.com/users/stevesloka/gists{/gist_id}","starred_url":"https://api.github.com/users/stevesloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevesloka/subscriptions","organizations_url":"https://api.github.com/users/stevesloka/orgs","repos_url":"https://api.github.com/users/stevesloka/repos","events_url":"https://api.github.com/users/stevesloka/events{/privacy}","received_events_url":"https://api.github.com/users/stevesloka/received_events","type":"User","site_admin":false},"repo":{"id":110730321,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA3MzAzMjE=","name":"contour","full_name":"stevesloka/contour","owner":{"login":"stevesloka","id":1048184,"node_id":"MDQ6VXNlcjEwNDgxODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1048184?v=4","gravatar_id":"","url":"https://api.github.com/users/stevesloka","html_url":"https://github.com/stevesloka","followers_url":"https://api.github.com/users/stevesloka/followers","following_url":"https://api.github.com/users/stevesloka/following{/other_user}","gists_url":"https://api.github.com/users/stevesloka/gists{/gist_id}","starred_url":"https://api.github.com/users/stevesloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevesloka/subscriptions","organizations_url":"https://api.github.com/users/stevesloka/orgs","repos_url":"https://api.github.com/users/stevesloka/repos","events_url":"https://api.github.com/users/stevesloka/events{/privacy}","received_events_url":"https://api.github.com/users/stevesloka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevesloka/contour","description":"Contour is a Kubernetes ingress controller for Lyft's Envoy proxy.","fork":true,"url":"https://api.github.com/repos/stevesloka/contour","forks_url":"https://api.github.com/repos/stevesloka/contour/forks","keys_url":"https://api.github.com/repos/stevesloka/contour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevesloka/contour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevesloka/contour/teams","hooks_url":"https://api.github.com/repos/stevesloka/contour/hooks","issue_events_url":"https://api.github.com/repos/stevesloka/contour/issues/events{/number}","events_url":"https://api.github.com/repos/stevesloka/contour/events","assignees_url":"https://api.github.com/repos/stevesloka/contour/assignees{/user}","branches_url":"https://api.github.com/repos/stevesloka/contour/branches{/branch}","tags_url":"https://api.github.com/repos/stevesloka/contour/tags","blobs_url":"https://api.github.com/repos/stevesloka/contour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevesloka/contour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevesloka/contour/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevesloka/contour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevesloka/contour/statuses/{sha}","languages_url":"https://api.github.com/repos/stevesloka/contour/languages","stargazers_url":"https://api.github.com/repos/stevesloka/contour/stargazers","contributors_url":"https://api.github.com/repos/stevesloka/contour/contributors","subscribers_url":"https://api.github.com/repos/stevesloka/contour/subscribers","subscription_url":"https://api.github.com/repos/stevesloka/contour/subscription","commits_url":"https://api.github.com/repos/stevesloka/contour/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevesloka/contour/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevesloka/contour/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevesloka/contour/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevesloka/contour/contents/{+path}","compare_url":"https://api.github.com/repos/stevesloka/contour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevesloka/contour/merges","archive_url":"https://api.github.com/repos/stevesloka/contour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevesloka/contour/downloads","issues_url":"https://api.github.com/repos/stevesloka/contour/issues{/number}","pulls_url":"https://api.github.com/repos/stevesloka/contour/pulls{/number}","milestones_url":"https://api.github.com/repos/stevesloka/contour/milestones{/number}","notifications_url":"https://api.github.com/repos/stevesloka/contour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevesloka/contour/labels{/name}","releases_url":"https://api.github.com/repos/stevesloka/contour/releases{/id}","deployments_url":"https://api.github.com/repos/stevesloka/contour/deployments","created_at":"2017-11-14T18:44:49Z","updated_at":"2018-07-03T18:38:18Z","pushed_at":"2018-07-03T20:57:09Z","git_url":"git://github.com/stevesloka/contour.git","ssh_url":"git@github.com:stevesloka/contour.git","clone_url":"https://github.com/stevesloka/contour.git","svn_url":"https://github.com/stevesloka/contour","homepage":null,"size":12131,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heptio:master","ref":"master","sha":"18a248f9752123c8f09363032676453e400996ad","user":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":108462822,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg0NjI4MjI=","name":"contour","full_name":"heptio/contour","owner":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/contour","description":"Contour is a Kubernetes ingress controller for Lyft's Envoy proxy.","fork":false,"url":"https://api.github.com/repos/heptio/contour","forks_url":"https://api.github.com/repos/heptio/contour/forks","keys_url":"https://api.github.com/repos/heptio/contour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/contour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/contour/teams","hooks_url":"https://api.github.com/repos/heptio/contour/hooks","issue_events_url":"https://api.github.com/repos/heptio/contour/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/contour/events","assignees_url":"https://api.github.com/repos/heptio/contour/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/contour/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/contour/tags","blobs_url":"https://api.github.com/repos/heptio/contour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/contour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/contour/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/contour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/contour/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/contour/languages","stargazers_url":"https://api.github.com/repos/heptio/contour/stargazers","contributors_url":"https://api.github.com/repos/heptio/contour/contributors","subscribers_url":"https://api.github.com/repos/heptio/contour/subscribers","subscription_url":"https://api.github.com/repos/heptio/contour/subscription","commits_url":"https://api.github.com/repos/heptio/contour/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/contour/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/contour/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/contour/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/contour/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/contour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/contour/merges","archive_url":"https://api.github.com/repos/heptio/contour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/contour/downloads","issues_url":"https://api.github.com/repos/heptio/contour/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/contour/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/contour/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/contour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/contour/labels{/name}","releases_url":"https://api.github.com/repos/heptio/contour/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/contour/deployments","created_at":"2017-10-26T20:35:22Z","updated_at":"2018-07-05T09:53:56Z","pushed_at":"2018-07-05T10:11:57Z","git_url":"git://github.com/heptio/contour.git","ssh_url":"git@github.com:heptio/contour.git","clone_url":"https://github.com/heptio/contour.git","svn_url":"https://github.com/heptio/contour","homepage":null,"size":1590,"stargazers_count":921,"watchers_count":921,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":91,"open_issues":72,"watchers":921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/contour/pulls/487"},"html":{"href":"https://github.com/heptio/contour/pull/487"},"issue":{"href":"https://api.github.com/repos/heptio/contour/issues/487"},"comments":{"href":"https://api.github.com/repos/heptio/contour/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/contour/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/contour/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/contour/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/contour/statuses/f32460848575d3e275ace7dcdc2d12f0e32c8123"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davecheney","id":7171,"node_id":"MDQ6VXNlcjcxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7171?v=4","gravatar_id":"","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"comments":7,"review_comments":9,"maintainer_can_modify":false,"commits":3,"additions":329,"deletions":34,"changed_files":8}}
{"actor":{"display_login":"davecheney"}}