{"action":"created","comment":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/205356671","pull_request_review_id":140607795,"id":205356671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM1NjY3MQ==","diff_hunk":"@@ -152,9 +152,13 @@ def addFile(self, dbsFile, datasetType, primaryDatasetType):\n         self.data['files'].append(fileDict)\n \n         # now add file to data\n-        parentLFNs = dbsFile.getParentLFNs()\n-        for lfn in parentLFNs:\n-            self.addFileParent(child = dbsFile['lfn'], parent = lfn)\n+        # If dataset_parent_list is defined don't add the file parentage.\n+        # This means it is block from StepChain workflow and parentage of file will be resloved later","path":"src/python/WMComponent/DBS3Buffer/DBSBufferBlock.py","position":8,"original_position":8,"commit_id":"21e6c53c068a61b9929d00e4982780f07004fe5a","original_commit_id":"21e6c53c068a61b9929d00e4982780f07004fe5a","user":{"login":"amaltaro","id":1798520,"node_id":"MDQ6VXNlcjE3OTg1MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1798520?v=4","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"body":"typo and I think this blank line can go away. Or you fix it in a later commit.","created_at":"2018-07-26T07:33:29Z","updated_at":"2018-07-26T07:57:17Z","html_url":"https://github.com/dmwm/WMCore/pull/8698#discussion_r205356671","pull_request_url":"https://api.github.com/repos/dmwm/WMCore/pulls/8698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/205356671"},"html":{"href":"https://github.com/dmwm/WMCore/pull/8698#discussion_r205356671"},"pull_request":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/8698"}}},"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/8698","id":203597195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTk3MTk1","html_url":"https://github.com/dmwm/WMCore/pull/8698","diff_url":"https://github.com/dmwm/WMCore/pull/8698.diff","patch_url":"https://github.com/dmwm/WMCore/pull/8698.patch","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/8698","number":8698,"state":"open","locked":false,"title":"scheleton for adding stepchain parentage","user":{"login":"ticoann","id":1247993,"node_id":"MDQ6VXNlcjEyNDc5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1247993?v=4","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"body":"replace #8676 \r\n#8700 need to be merged first","created_at":"2018-07-24T17:15:25Z","updated_at":"2018-07-26T07:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ea1856a4198aa5510a959f6000cfa648d646b75","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":311378297,"node_id":"MDU6TGFiZWwzMTEzNzgyOTc=","url":"https://api.github.com/repos/dmwm/WMCore/labels/Do%20not%20merge%20yet","name":"Do not merge yet","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dmwm/WMCore/pulls/8698/commits","review_comments_url":"https://api.github.com/repos/dmwm/WMCore/pulls/8698/comments","review_comment_url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/8698/comments","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/21e6c53c068a61b9929d00e4982780f07004fe5a","head":{"label":"ticoann:get_step_chain_dataset_parents","ref":"get_step_chain_dataset_parents","sha":"21e6c53c068a61b9929d00e4982780f07004fe5a","user":{"login":"ticoann","id":1247993,"node_id":"MDQ6VXNlcjEyNDc5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1247993?v=4","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"repo":{"id":2935076,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM1MDc2","name":"WMCore","full_name":"ticoann/WMCore","owner":{"login":"ticoann","id":1247993,"node_id":"MDQ6VXNlcjEyNDc5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1247993?v=4","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ticoann/WMCore","description":"WMCore","fork":true,"url":"https://api.github.com/repos/ticoann/WMCore","forks_url":"https://api.github.com/repos/ticoann/WMCore/forks","keys_url":"https://api.github.com/repos/ticoann/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ticoann/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ticoann/WMCore/teams","hooks_url":"https://api.github.com/repos/ticoann/WMCore/hooks","issue_events_url":"https://api.github.com/repos/ticoann/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/ticoann/WMCore/events","assignees_url":"https://api.github.com/repos/ticoann/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/ticoann/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/ticoann/WMCore/tags","blobs_url":"https://api.github.com/repos/ticoann/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ticoann/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ticoann/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ticoann/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ticoann/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ticoann/WMCore/languages","stargazers_url":"https://api.github.com/repos/ticoann/WMCore/stargazers","contributors_url":"https://api.github.com/repos/ticoann/WMCore/contributors","subscribers_url":"https://api.github.com/repos/ticoann/WMCore/subscribers","subscription_url":"https://api.github.com/repos/ticoann/WMCore/subscription","commits_url":"https://api.github.com/repos/ticoann/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ticoann/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ticoann/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ticoann/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ticoann/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/ticoann/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ticoann/WMCore/merges","archive_url":"https://api.github.com/repos/ticoann/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ticoann/WMCore/downloads","issues_url":"https://api.github.com/repos/ticoann/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/ticoann/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ticoann/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ticoann/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ticoann/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/ticoann/WMCore/releases{/id}","deployments_url":"https://api.github.com/repos/ticoann/WMCore/deployments","created_at":"2011-12-07T19:34:12Z","updated_at":"2017-03-10T15:20:38Z","pushed_at":"2018-07-26T03:43:40Z","git_url":"git://github.com/ticoann/WMCore.git","ssh_url":"git@github.com:ticoann/WMCore.git","clone_url":"https://github.com/ticoann/WMCore.git","svn_url":"https://github.com/ticoann/WMCore","homepage":"https://svnweb.cern.ch/trac/CMSDMWM/","size":36002,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"dmwm:master","ref":"master","sha":"27d3ed715c3eabff1ca17b95ef3649df58535e01","user":{"login":"dmwm","id":988897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4ODg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/988897?v=4","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"repo":{"id":2370458,"node_id":"MDEwOlJlcG9zaXRvcnkyMzcwNDU4","name":"WMCore","full_name":"dmwm/WMCore","owner":{"login":"dmwm","id":988897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4ODg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/988897?v=4","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmwm/WMCore","description":"Core workflow management components for CMS.","fork":false,"url":"https://api.github.com/repos/dmwm/WMCore","forks_url":"https://api.github.com/repos/dmwm/WMCore/forks","keys_url":"https://api.github.com/repos/dmwm/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmwm/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmwm/WMCore/teams","hooks_url":"https://api.github.com/repos/dmwm/WMCore/hooks","issue_events_url":"https://api.github.com/repos/dmwm/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/dmwm/WMCore/events","assignees_url":"https://api.github.com/repos/dmwm/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/dmwm/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/dmwm/WMCore/tags","blobs_url":"https://api.github.com/repos/dmwm/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmwm/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmwm/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmwm/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dmwm/WMCore/languages","stargazers_url":"https://api.github.com/repos/dmwm/WMCore/stargazers","contributors_url":"https://api.github.com/repos/dmwm/WMCore/contributors","subscribers_url":"https://api.github.com/repos/dmwm/WMCore/subscribers","subscription_url":"https://api.github.com/repos/dmwm/WMCore/subscription","commits_url":"https://api.github.com/repos/dmwm/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmwm/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmwm/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmwm/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmwm/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/dmwm/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmwm/WMCore/merges","archive_url":"https://api.github.com/repos/dmwm/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmwm/WMCore/downloads","issues_url":"https://api.github.com/repos/dmwm/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/dmwm/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dmwm/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dmwm/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmwm/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/dmwm/WMCore/releases{/id}","deployments_url":"https://api.github.com/repos/dmwm/WMCore/deployments","created_at":"2011-09-12T10:37:21Z","updated_at":"2018-07-25T16:51:53Z","pushed_at":"2018-07-26T03:43:41Z","git_url":"git://github.com/dmwm/WMCore.git","ssh_url":"git@github.com:dmwm/WMCore.git","clone_url":"https://github.com/dmwm/WMCore.git","svn_url":"https://github.com/dmwm/WMCore","homepage":"","size":36309,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":248,"license":null,"forks":69,"open_issues":248,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/8698"},"html":{"href":"https://github.com/dmwm/WMCore/pull/8698"},"issue":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/8698"},"comments":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/8698/comments"},"review_comments":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/8698/comments"},"review_comment":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/8698/commits"},"statuses":{"href":"https://api.github.com/repos/dmwm/WMCore/statuses/21e6c53c068a61b9929d00e4982780f07004fe5a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amaltaro"}}