{"action":"created","issue":{"url":"https://api.github.com/repos/parkouss/funq/issues/55","repository_url":"https://api.github.com/repos/parkouss/funq","labels_url":"https://api.github.com/repos/parkouss/funq/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/parkouss/funq/issues/55/comments","events_url":"https://api.github.com/repos/parkouss/funq/issues/55/events","html_url":"https://github.com/parkouss/funq/pull/55","id":394801322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDUwMDc5","number":55,"title":"Fix race conditions caused by queued signal/slot connections","user":{"login":"ubruhin","id":5374821,"node_id":"MDQ6VXNlcjUzNzQ4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5374821?v=4","gravatar_id":"","url":"https://api.github.com/users/ubruhin","html_url":"https://github.com/ubruhin","followers_url":"https://api.github.com/users/ubruhin/followers","following_url":"https://api.github.com/users/ubruhin/following{/other_user}","gists_url":"https://api.github.com/users/ubruhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ubruhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubruhin/subscriptions","organizations_url":"https://api.github.com/users/ubruhin/orgs","repos_url":"https://api.github.com/users/ubruhin/repos","events_url":"https://api.github.com/users/ubruhin/events{/privacy}","received_events_url":"https://api.github.com/users/ubruhin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-29T14:47:08Z","updated_at":"2018-12-29T17:18:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/parkouss/funq/pulls/55","html_url":"https://github.com/parkouss/funq/pull/55","diff_url":"https://github.com/parkouss/funq/pull/55.diff","patch_url":"https://github.com/parkouss/funq/pull/55.patch"},"body":"I'm not completely sure if it has any disadvantage to replace the queued connections by direct connections, but at least the tests seem to be stable now ;)\r\n\r\nFixes #39.\r\n\r\nNote: This conflicts with #54 - if one PR is merged, I'll rebase the other one."},"comment":{"url":"https://api.github.com/repos/parkouss/funq/issues/comments/450507138","html_url":"https://github.com/parkouss/funq/pull/55#issuecomment-450507138","issue_url":"https://api.github.com/repos/parkouss/funq/issues/55","id":450507138,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUwNzEzOA==","user":{"login":"ubruhin","id":5374821,"node_id":"MDQ6VXNlcjUzNzQ4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5374821?v=4","gravatar_id":"","url":"https://api.github.com/users/ubruhin","html_url":"https://github.com/ubruhin","followers_url":"https://api.github.com/users/ubruhin/followers","following_url":"https://api.github.com/users/ubruhin/following{/other_user}","gists_url":"https://api.github.com/users/ubruhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ubruhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubruhin/subscriptions","organizations_url":"https://api.github.com/users/ubruhin/orgs","repos_url":"https://api.github.com/users/ubruhin/repos","events_url":"https://api.github.com/users/ubruhin/events{/privacy}","received_events_url":"https://api.github.com/users/ubruhin/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T17:18:30Z","updated_at":"2018-12-29T17:18:30Z","author_association":"CONTRIBUTOR","body":"> I guess we can start applying your change, and in case anything goes wrong later we can still roll back the operation. (adding a test that would break at the same time if possible so we won't do the same mistake twice)\r\n\r\nSounds reasonable :+1:\r\n\r\nHmm now another test has failed, but I suspect it has nothing to do with this change...I'll take a look at it.\r\n\r\n```\r\n======================================================================\r\nFAIL: test_click.py:TestClick.test_middle_click\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"C:\\projects\\funq\\tests-functionnal\\test_click.py\", line 56, in test_middle_click\r\n    self.assertEquals(self.get_status_text(), 'middle clicked !')\r\nAssertionError: u'' != 'middle clicked !'\r\n-------------------- >> begin captured logging << --------------------\r\nfunq.client: INFO: The tested application will be launched in the directory 'C:\\\\projects\\\\funq\\\\tests-functionnal\\\\.' with the command ['C:\\\\Python27\\\\Scripts\\\\funq.exe', '--port', '1053', 'C:\\\\projects\\\\funq\\\\tests-functionnal\\\\./funq-test-app/funq-test-app']\r\nfunq.client: INFO: Launching tested application [3024].\r\n--------------------- >> end captured logging << ---------------------\r\n```"}}
{"actor":{"display_login":"ubruhin"}}