{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/johanpel/fletcher/pulls/26","id":196481475,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDgxNDc1","html_url":"https://github.com/johanpel/fletcher/pull/26","diff_url":"https://github.com/johanpel/fletcher/pull/26.diff","patch_url":"https://github.com/johanpel/fletcher/pull/26.patch","issue_url":"https://api.github.com/repos/johanpel/fletcher/issues/26","number":26,"state":"closed","locked":false,"title":"Refactor bus names","user":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"body":"In preperation of a new wrapper generation tool for Fletcher, internal bus system will use the following names:\r\n\r\nRead request channel: rreq\r\nRead response channel: rdat\r\nWrite request channel: wreq\r\nWrite data channel: wdat\r\n\r\nThis has been refactored from the examples down to the BufferReader layer, which is below what a typical user will see.\r\n\r\nBecause initially we only had reading capabilities, the Bus<Function>.vhd files that were originally created for reading only are now renamed to BusRead<Function>.vhd.\r\nBus write functional units are already called BusWrite<Function>.vhd. The port names were also just \"req\", but this might be confusing whether it's about a write or read request. This is why it is now changed to rreq and wreq and rdat and wdat.\r\n","created_at":"2018-06-21T14:57:29Z","updated_at":"2018-06-21T15:00:49Z","closed_at":"2018-06-21T15:00:49Z","merged_at":"2018-06-21T15:00:49Z","merge_commit_sha":"da60daeba4cdd18b7f04a9713f07841b1aea3d2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/johanpel/fletcher/pulls/26/commits","review_comments_url":"https://api.github.com/repos/johanpel/fletcher/pulls/26/comments","review_comment_url":"https://api.github.com/repos/johanpel/fletcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johanpel/fletcher/issues/26/comments","statuses_url":"https://api.github.com/repos/johanpel/fletcher/statuses/8aeb6398ad32e1371eccc1597949ef1703465855","head":{"label":"johanpel:bus_name_refactor","ref":"bus_name_refactor","sha":"8aeb6398ad32e1371eccc1597949ef1703465855","user":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"repo":{"id":120948886,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDg4ODY=","name":"fletcher","full_name":"johanpel/fletcher","owner":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johanpel/fletcher","description":"A framework to integrate FPGA accelerators with Apache Arrow","fork":false,"url":"https://api.github.com/repos/johanpel/fletcher","forks_url":"https://api.github.com/repos/johanpel/fletcher/forks","keys_url":"https://api.github.com/repos/johanpel/fletcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanpel/fletcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanpel/fletcher/teams","hooks_url":"https://api.github.com/repos/johanpel/fletcher/hooks","issue_events_url":"https://api.github.com/repos/johanpel/fletcher/issues/events{/number}","events_url":"https://api.github.com/repos/johanpel/fletcher/events","assignees_url":"https://api.github.com/repos/johanpel/fletcher/assignees{/user}","branches_url":"https://api.github.com/repos/johanpel/fletcher/branches{/branch}","tags_url":"https://api.github.com/repos/johanpel/fletcher/tags","blobs_url":"https://api.github.com/repos/johanpel/fletcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanpel/fletcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanpel/fletcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanpel/fletcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanpel/fletcher/statuses/{sha}","languages_url":"https://api.github.com/repos/johanpel/fletcher/languages","stargazers_url":"https://api.github.com/repos/johanpel/fletcher/stargazers","contributors_url":"https://api.github.com/repos/johanpel/fletcher/contributors","subscribers_url":"https://api.github.com/repos/johanpel/fletcher/subscribers","subscription_url":"https://api.github.com/repos/johanpel/fletcher/subscription","commits_url":"https://api.github.com/repos/johanpel/fletcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanpel/fletcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanpel/fletcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanpel/fletcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/johanpel/fletcher/contents/{+path}","compare_url":"https://api.github.com/repos/johanpel/fletcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanpel/fletcher/merges","archive_url":"https://api.github.com/repos/johanpel/fletcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanpel/fletcher/downloads","issues_url":"https://api.github.com/repos/johanpel/fletcher/issues{/number}","pulls_url":"https://api.github.com/repos/johanpel/fletcher/pulls{/number}","milestones_url":"https://api.github.com/repos/johanpel/fletcher/milestones{/number}","notifications_url":"https://api.github.com/repos/johanpel/fletcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanpel/fletcher/labels{/name}","releases_url":"https://api.github.com/repos/johanpel/fletcher/releases{/id}","deployments_url":"https://api.github.com/repos/johanpel/fletcher/deployments","created_at":"2018-02-09T19:51:26Z","updated_at":"2018-06-20T16:37:38Z","pushed_at":"2018-06-21T15:00:49Z","git_url":"git://github.com/johanpel/fletcher.git","ssh_url":"git@github.com:johanpel/fletcher.git","clone_url":"https://github.com/johanpel/fletcher.git","svn_url":"https://github.com/johanpel/fletcher","homepage":"","size":645,"stargazers_count":34,"watchers_count":34,"language":"VHDL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":8,"watchers":34,"default_branch":"master"}},"base":{"label":"johanpel:development","ref":"development","sha":"e4aaf03306de3b6df2b2165e0c05ed3d04aabe1c","user":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"repo":{"id":120948886,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDg4ODY=","name":"fletcher","full_name":"johanpel/fletcher","owner":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johanpel/fletcher","description":"A framework to integrate FPGA accelerators with Apache Arrow","fork":false,"url":"https://api.github.com/repos/johanpel/fletcher","forks_url":"https://api.github.com/repos/johanpel/fletcher/forks","keys_url":"https://api.github.com/repos/johanpel/fletcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanpel/fletcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanpel/fletcher/teams","hooks_url":"https://api.github.com/repos/johanpel/fletcher/hooks","issue_events_url":"https://api.github.com/repos/johanpel/fletcher/issues/events{/number}","events_url":"https://api.github.com/repos/johanpel/fletcher/events","assignees_url":"https://api.github.com/repos/johanpel/fletcher/assignees{/user}","branches_url":"https://api.github.com/repos/johanpel/fletcher/branches{/branch}","tags_url":"https://api.github.com/repos/johanpel/fletcher/tags","blobs_url":"https://api.github.com/repos/johanpel/fletcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanpel/fletcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanpel/fletcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanpel/fletcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanpel/fletcher/statuses/{sha}","languages_url":"https://api.github.com/repos/johanpel/fletcher/languages","stargazers_url":"https://api.github.com/repos/johanpel/fletcher/stargazers","contributors_url":"https://api.github.com/repos/johanpel/fletcher/contributors","subscribers_url":"https://api.github.com/repos/johanpel/fletcher/subscribers","subscription_url":"https://api.github.com/repos/johanpel/fletcher/subscription","commits_url":"https://api.github.com/repos/johanpel/fletcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanpel/fletcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanpel/fletcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanpel/fletcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/johanpel/fletcher/contents/{+path}","compare_url":"https://api.github.com/repos/johanpel/fletcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanpel/fletcher/merges","archive_url":"https://api.github.com/repos/johanpel/fletcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanpel/fletcher/downloads","issues_url":"https://api.github.com/repos/johanpel/fletcher/issues{/number}","pulls_url":"https://api.github.com/repos/johanpel/fletcher/pulls{/number}","milestones_url":"https://api.github.com/repos/johanpel/fletcher/milestones{/number}","notifications_url":"https://api.github.com/repos/johanpel/fletcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanpel/fletcher/labels{/name}","releases_url":"https://api.github.com/repos/johanpel/fletcher/releases{/id}","deployments_url":"https://api.github.com/repos/johanpel/fletcher/deployments","created_at":"2018-02-09T19:51:26Z","updated_at":"2018-06-20T16:37:38Z","pushed_at":"2018-06-21T15:00:49Z","git_url":"git://github.com/johanpel/fletcher.git","ssh_url":"git@github.com:johanpel/fletcher.git","clone_url":"https://github.com/johanpel/fletcher.git","svn_url":"https://github.com/johanpel/fletcher","homepage":"","size":645,"stargazers_count":34,"watchers_count":34,"language":"VHDL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":8,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johanpel/fletcher/pulls/26"},"html":{"href":"https://github.com/johanpel/fletcher/pull/26"},"issue":{"href":"https://api.github.com/repos/johanpel/fletcher/issues/26"},"comments":{"href":"https://api.github.com/repos/johanpel/fletcher/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/johanpel/fletcher/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/johanpel/fletcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johanpel/fletcher/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/johanpel/fletcher/statuses/8aeb6398ad32e1371eccc1597949ef1703465855"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"johanpel","id":17315262,"node_id":"MDQ6VXNlcjE3MzE1MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/17315262?v=4","gravatar_id":"","url":"https://api.github.com/users/johanpel","html_url":"https://github.com/johanpel","followers_url":"https://api.github.com/users/johanpel/followers","following_url":"https://api.github.com/users/johanpel/following{/other_user}","gists_url":"https://api.github.com/users/johanpel/gists{/gist_id}","starred_url":"https://api.github.com/users/johanpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanpel/subscriptions","organizations_url":"https://api.github.com/users/johanpel/orgs","repos_url":"https://api.github.com/users/johanpel/repos","events_url":"https://api.github.com/users/johanpel/events{/privacy}","received_events_url":"https://api.github.com/users/johanpel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":2187,"deletions":2227,"changed_files":34}}
{"actor":{"display_login":"johanpel"}}