{"action":"created","comment":{"url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/comments/210859147","pull_request_review_id":147162784,"id":210859147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg1OTE0Nw==","diff_hunk":"@@ -329,15 +329,19 @@ def get_all(self, sort_order=None, sort_target='key'):\n             for kv in range_response.kvs:\n                 yield (kv.value, KVMetadata(kv, range_response.header))\n \n-    def _build_put_request(self, key, value, lease=None):\n+    def _build_put_request(self, key, value, lease=None, prev_kv=None):","path":"etcd3/client.py","position":5,"original_position":5,"commit_id":"04570412a5445d309834bf615a83be33714bab07","original_commit_id":"04570412a5445d309834bf615a83be33714bab07","user":{"login":"jd","id":2644,"node_id":"MDQ6VXNlcjI2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2644?v=4","gravatar_id":"","url":"https://api.github.com/users/jd","html_url":"https://github.com/jd","followers_url":"https://api.github.com/users/jd/followers","following_url":"https://api.github.com/users/jd/following{/other_user}","gists_url":"https://api.github.com/users/jd/gists{/gist_id}","starred_url":"https://api.github.com/users/jd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd/subscriptions","organizations_url":"https://api.github.com/users/jd/orgs","repos_url":"https://api.github.com/users/jd/repos","events_url":"https://api.github.com/users/jd/events{/privacy}","received_events_url":"https://api.github.com/users/jd/received_events","type":"User","site_admin":false},"body":"Can you use `False` rather than `None` by default? That sounds more logical since it's a boolean.","created_at":"2018-08-17T09:48:48Z","updated_at":"2018-08-17T09:49:09Z","html_url":"https://github.com/kragniz/python-etcd3/pull/499#discussion_r210859147","pull_request_url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/comments/210859147"},"html":{"href":"https://github.com/kragniz/python-etcd3/pull/499#discussion_r210859147"},"pull_request":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499","id":205753823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzUzODIz","html_url":"https://github.com/kragniz/python-etcd3/pull/499","diff_url":"https://github.com/kragniz/python-etcd3/pull/499.diff","patch_url":"https://github.com/kragniz/python-etcd3/pull/499.patch","issue_url":"https://api.github.com/repos/kragniz/python-etcd3/issues/499","number":499,"state":"open","locked":false,"title":"Return the responses of put and delete operations","user":{"login":"boolean5","id":5280463,"node_id":"MDQ6VXNlcjUyODA0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5280463?v=4","gravatar_id":"","url":"https://api.github.com/users/boolean5","html_url":"https://github.com/boolean5","followers_url":"https://api.github.com/users/boolean5/followers","following_url":"https://api.github.com/users/boolean5/following{/other_user}","gists_url":"https://api.github.com/users/boolean5/gists{/gist_id}","starred_url":"https://api.github.com/users/boolean5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolean5/subscriptions","organizations_url":"https://api.github.com/users/boolean5/orgs","repos_url":"https://api.github.com/users/boolean5/repos","events_url":"https://api.github.com/users/boolean5/events{/privacy}","received_events_url":"https://api.github.com/users/boolean5/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nThis PR addresses issues #135 and #406. Its purpose is to:\r\n\r\n1. Make `put` and `delete` functions return an `rpc_pb2.PutResponse` and an `rpc_pb2.DeleteRangeResponse` respectively. These responses contain a `header` which includes the `revision`, `raft_term`, `cluster_id` and `member_id`. If the `prev_kv` keyword argument was set to `True`, they also contain the key-value pair as it was before modification in the case of `put` and the deleted key-value pair in the case of `delete.` Similar responses are returned by put and delete operations when they are performed within a transaction. This information was previously discarded by python-etcd3 and is very likely to be needed by users.\r\n\r\n2. Enable the use of the `prev_kv` keyword argument.\r\n\r\nRegards!","created_at":"2018-08-02T14:26:31Z","updated_at":"2018-08-17T09:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3618def9222653c5b4379521adabc2e12a2579cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499/commits","review_comments_url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499/comments","review_comment_url":"https://api.github.com/repos/kragniz/python-etcd3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kragniz/python-etcd3/issues/499/comments","statuses_url":"https://api.github.com/repos/kragniz/python-etcd3/statuses/04570412a5445d309834bf615a83be33714bab07","head":{"label":"boolean5:put-delete-responses","ref":"put-delete-responses","sha":"04570412a5445d309834bf615a83be33714bab07","user":{"login":"boolean5","id":5280463,"node_id":"MDQ6VXNlcjUyODA0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5280463?v=4","gravatar_id":"","url":"https://api.github.com/users/boolean5","html_url":"https://github.com/boolean5","followers_url":"https://api.github.com/users/boolean5/followers","following_url":"https://api.github.com/users/boolean5/following{/other_user}","gists_url":"https://api.github.com/users/boolean5/gists{/gist_id}","starred_url":"https://api.github.com/users/boolean5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolean5/subscriptions","organizations_url":"https://api.github.com/users/boolean5/orgs","repos_url":"https://api.github.com/users/boolean5/repos","events_url":"https://api.github.com/users/boolean5/events{/privacy}","received_events_url":"https://api.github.com/users/boolean5/received_events","type":"User","site_admin":false},"repo":{"id":143158647,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTg2NDc=","name":"python-etcd3","full_name":"boolean5/python-etcd3","owner":{"login":"boolean5","id":5280463,"node_id":"MDQ6VXNlcjUyODA0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5280463?v=4","gravatar_id":"","url":"https://api.github.com/users/boolean5","html_url":"https://github.com/boolean5","followers_url":"https://api.github.com/users/boolean5/followers","following_url":"https://api.github.com/users/boolean5/following{/other_user}","gists_url":"https://api.github.com/users/boolean5/gists{/gist_id}","starred_url":"https://api.github.com/users/boolean5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolean5/subscriptions","organizations_url":"https://api.github.com/users/boolean5/orgs","repos_url":"https://api.github.com/users/boolean5/repos","events_url":"https://api.github.com/users/boolean5/events{/privacy}","received_events_url":"https://api.github.com/users/boolean5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boolean5/python-etcd3","description":"Python client for the etcd API v3","fork":true,"url":"https://api.github.com/repos/boolean5/python-etcd3","forks_url":"https://api.github.com/repos/boolean5/python-etcd3/forks","keys_url":"https://api.github.com/repos/boolean5/python-etcd3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boolean5/python-etcd3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boolean5/python-etcd3/teams","hooks_url":"https://api.github.com/repos/boolean5/python-etcd3/hooks","issue_events_url":"https://api.github.com/repos/boolean5/python-etcd3/issues/events{/number}","events_url":"https://api.github.com/repos/boolean5/python-etcd3/events","assignees_url":"https://api.github.com/repos/boolean5/python-etcd3/assignees{/user}","branches_url":"https://api.github.com/repos/boolean5/python-etcd3/branches{/branch}","tags_url":"https://api.github.com/repos/boolean5/python-etcd3/tags","blobs_url":"https://api.github.com/repos/boolean5/python-etcd3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boolean5/python-etcd3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boolean5/python-etcd3/git/refs{/sha}","trees_url":"https://api.github.com/repos/boolean5/python-etcd3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boolean5/python-etcd3/statuses/{sha}","languages_url":"https://api.github.com/repos/boolean5/python-etcd3/languages","stargazers_url":"https://api.github.com/repos/boolean5/python-etcd3/stargazers","contributors_url":"https://api.github.com/repos/boolean5/python-etcd3/contributors","subscribers_url":"https://api.github.com/repos/boolean5/python-etcd3/subscribers","subscription_url":"https://api.github.com/repos/boolean5/python-etcd3/subscription","commits_url":"https://api.github.com/repos/boolean5/python-etcd3/commits{/sha}","git_commits_url":"https://api.github.com/repos/boolean5/python-etcd3/git/commits{/sha}","comments_url":"https://api.github.com/repos/boolean5/python-etcd3/comments{/number}","issue_comment_url":"https://api.github.com/repos/boolean5/python-etcd3/issues/comments{/number}","contents_url":"https://api.github.com/repos/boolean5/python-etcd3/contents/{+path}","compare_url":"https://api.github.com/repos/boolean5/python-etcd3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boolean5/python-etcd3/merges","archive_url":"https://api.github.com/repos/boolean5/python-etcd3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boolean5/python-etcd3/downloads","issues_url":"https://api.github.com/repos/boolean5/python-etcd3/issues{/number}","pulls_url":"https://api.github.com/repos/boolean5/python-etcd3/pulls{/number}","milestones_url":"https://api.github.com/repos/boolean5/python-etcd3/milestones{/number}","notifications_url":"https://api.github.com/repos/boolean5/python-etcd3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boolean5/python-etcd3/labels{/name}","releases_url":"https://api.github.com/repos/boolean5/python-etcd3/releases{/id}","deployments_url":"https://api.github.com/repos/boolean5/python-etcd3/deployments","created_at":"2018-08-01T13:18:16Z","updated_at":"2018-08-01T13:18:18Z","pushed_at":"2018-08-08T16:08:40Z","git_url":"git://github.com/boolean5/python-etcd3.git","ssh_url":"git@github.com:boolean5/python-etcd3.git","clone_url":"https://github.com/boolean5/python-etcd3.git","svn_url":"https://github.com/boolean5/python-etcd3","homepage":"","size":500,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kragniz:master","ref":"master","sha":"7e716d8f7be866b11f1337c6c438aafa1cda08c3","user":{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false},"repo":{"id":69691394,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MTM5NA==","name":"python-etcd3","full_name":"kragniz/python-etcd3","owner":{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kragniz/python-etcd3","description":"Python client for the etcd API v3","fork":false,"url":"https://api.github.com/repos/kragniz/python-etcd3","forks_url":"https://api.github.com/repos/kragniz/python-etcd3/forks","keys_url":"https://api.github.com/repos/kragniz/python-etcd3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kragniz/python-etcd3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kragniz/python-etcd3/teams","hooks_url":"https://api.github.com/repos/kragniz/python-etcd3/hooks","issue_events_url":"https://api.github.com/repos/kragniz/python-etcd3/issues/events{/number}","events_url":"https://api.github.com/repos/kragniz/python-etcd3/events","assignees_url":"https://api.github.com/repos/kragniz/python-etcd3/assignees{/user}","branches_url":"https://api.github.com/repos/kragniz/python-etcd3/branches{/branch}","tags_url":"https://api.github.com/repos/kragniz/python-etcd3/tags","blobs_url":"https://api.github.com/repos/kragniz/python-etcd3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kragniz/python-etcd3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kragniz/python-etcd3/git/refs{/sha}","trees_url":"https://api.github.com/repos/kragniz/python-etcd3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kragniz/python-etcd3/statuses/{sha}","languages_url":"https://api.github.com/repos/kragniz/python-etcd3/languages","stargazers_url":"https://api.github.com/repos/kragniz/python-etcd3/stargazers","contributors_url":"https://api.github.com/repos/kragniz/python-etcd3/contributors","subscribers_url":"https://api.github.com/repos/kragniz/python-etcd3/subscribers","subscription_url":"https://api.github.com/repos/kragniz/python-etcd3/subscription","commits_url":"https://api.github.com/repos/kragniz/python-etcd3/commits{/sha}","git_commits_url":"https://api.github.com/repos/kragniz/python-etcd3/git/commits{/sha}","comments_url":"https://api.github.com/repos/kragniz/python-etcd3/comments{/number}","issue_comment_url":"https://api.github.com/repos/kragniz/python-etcd3/issues/comments{/number}","contents_url":"https://api.github.com/repos/kragniz/python-etcd3/contents/{+path}","compare_url":"https://api.github.com/repos/kragniz/python-etcd3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kragniz/python-etcd3/merges","archive_url":"https://api.github.com/repos/kragniz/python-etcd3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kragniz/python-etcd3/downloads","issues_url":"https://api.github.com/repos/kragniz/python-etcd3/issues{/number}","pulls_url":"https://api.github.com/repos/kragniz/python-etcd3/pulls{/number}","milestones_url":"https://api.github.com/repos/kragniz/python-etcd3/milestones{/number}","notifications_url":"https://api.github.com/repos/kragniz/python-etcd3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kragniz/python-etcd3/labels{/name}","releases_url":"https://api.github.com/repos/kragniz/python-etcd3/releases{/id}","deployments_url":"https://api.github.com/repos/kragniz/python-etcd3/deployments","created_at":"2016-09-30T18:26:16Z","updated_at":"2018-08-16T12:36:17Z","pushed_at":"2018-08-16T12:36:13Z","git_url":"git://github.com/kragniz/python-etcd3.git","ssh_url":"git@github.com:kragniz/python-etcd3.git","clone_url":"https://github.com/kragniz/python-etcd3.git","svn_url":"https://github.com/kragniz/python-etcd3","homepage":"","size":504,"stargazers_count":106,"watchers_count":106,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":43,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499"},"html":{"href":"https://github.com/kragniz/python-etcd3/pull/499"},"issue":{"href":"https://api.github.com/repos/kragniz/python-etcd3/issues/499"},"comments":{"href":"https://api.github.com/repos/kragniz/python-etcd3/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kragniz/python-etcd3/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/kragniz/python-etcd3/statuses/04570412a5445d309834bf615a83be33714bab07"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jd"}}