{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/172633154","pull_request_review_id":101684048,"id":172633154,"diff_hunk":"@@ -123,6 +123,18 @@ endif()\n \n add_executable(plasma_store store.cc)\n target_link_libraries(plasma_store plasma_static ${PLASMA_LINK_LIBS})\n+SET_TARGET_PROPERTIES(plasma_store PROPERTIES\n+  LINK_FLAGS \"-Wl,--as-needed\")\n+\n+if (ARROW_RPATH_ORIGIN)","path":"cpp/src/plasma/CMakeLists.txt","position":7,"original_position":7,"commit_id":"55c21d6d0a28e05dbce3c6b384a26d849a0a498e","original_commit_id":"55c21d6d0a28e05dbce3c6b384a26d849a0a498e","user":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars3.githubusercontent.com/u/249517?v=4","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"I think this block could benefit from a short comment explaining what the purpose is.","created_at":"2018-03-06T19:31:11Z","updated_at":"2018-03-06T19:31:11Z","html_url":"https://github.com/apache/arrow/pull/1711#discussion_r172633154","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/1711","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/172633154"},"html":{"href":"https://github.com/apache/arrow/pull/1711#discussion_r172633154"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/1711"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/1711","id":173054883,"html_url":"https://github.com/apache/arrow/pull/1711","diff_url":"https://github.com/apache/arrow/pull/1711.diff","patch_url":"https://github.com/apache/arrow/pull/1711.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/1711","number":1711,"state":"open","locked":false,"title":"WIP ARROW-2193: [C++] Do not depend on Boost libraries at runtime in plasma_store","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"This is sort of a hack; I wasn't sure the way to deal with this more generally. Unfortunately, this only gets rid of the boost_system and boost_filesystem runtime dependencies. boost_regex still has a transitive dependency somehow","created_at":"2018-03-06T04:24:05Z","updated_at":"2018-03-06T19:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28215906c4fa17299c51b776c4afee6c9245e272","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/1711/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/55c21d6d0a28e05dbce3c6b384a26d849a0a498e","head":{"label":"wesm:ARROW-2193","ref":"ARROW-2193","sha":"55c21d6d0a28e05dbce3c6b384a26d849a0a498e","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":52022289,"name":"arrow","full_name":"wesm/arrow","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/wesm/arrow","forks_url":"https://api.github.com/repos/wesm/arrow/forks","keys_url":"https://api.github.com/repos/wesm/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/arrow/teams","hooks_url":"https://api.github.com/repos/wesm/arrow/hooks","issue_events_url":"https://api.github.com/repos/wesm/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/arrow/events","assignees_url":"https://api.github.com/repos/wesm/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/arrow/tags","blobs_url":"https://api.github.com/repos/wesm/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/arrow/languages","stargazers_url":"https://api.github.com/repos/wesm/arrow/stargazers","contributors_url":"https://api.github.com/repos/wesm/arrow/contributors","subscribers_url":"https://api.github.com/repos/wesm/arrow/subscribers","subscription_url":"https://api.github.com/repos/wesm/arrow/subscription","commits_url":"https://api.github.com/repos/wesm/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/arrow/merges","archive_url":"https://api.github.com/repos/wesm/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/arrow/downloads","issues_url":"https://api.github.com/repos/wesm/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/arrow/labels{/name}","releases_url":"https://api.github.com/repos/wesm/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/arrow/deployments","created_at":"2016-02-18T16:41:50Z","updated_at":"2017-05-06T18:18:09Z","pushed_at":"2018-03-06T19:22:28Z","git_url":"git://github.com/wesm/arrow.git","ssh_url":"git@github.com:wesm/arrow.git","clone_url":"https://github.com/wesm/arrow.git","svn_url":"https://github.com/wesm/arrow","homepage":null,"size":11387,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5f8a7934dde092a67798f0185dc500923e3dc8da","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"name":"arrow","full_name":"apache/arrow","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-03-06T18:35:13Z","pushed_at":"2018-03-06T19:30:49Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":11206,"stargazers_count":1686,"watchers_count":1686,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":452,"open_issues":40,"watchers":1686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/1711"},"html":{"href":"https://github.com/apache/arrow/pull/1711"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/1711"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/55c21d6d0a28e05dbce3c6b384a26d849a0a498e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robertnishihara"}}