{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/226466064","pull_request_review_id":166296369,"id":226466064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ2NjA2NA==","diff_hunk":"@@ -0,0 +1,41 @@\n+/*\n+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+ * or more contributor license agreements. Licensed under the Elastic License;\n+ * you may not use this file except in compliance with the Elastic License.\n+ */\n+\n+import React from 'react';\n+// @ts-ignore\n+import { legacyEncodeURIComponent, RelativeLink } from '../../utils/url';\n+\n+interface Props {\n+  name: string;\n+  serviceName?: string;\n+  transactionType?: string;\n+  transactionId?: string;\n+  traceId?: string;\n+}\n+\n+export const TraceLink: React.SFC<Props> = ({\n+  name,\n+  serviceName,\n+  transactionType,\n+  transactionId,\n+  traceId,\n+  children\n+}) => {\n+  if (!serviceName || !transactionType) {\n+    return <React.Fragment>{children}</React.Fragment>;\n+  }\n+\n+  return (\n+    <RelativeLink","path":"x-pack/plugins/apm/public/components/shared/TraceLink.tsx","position":32,"original_position":32,"commit_id":"6dfa696f72ba4d951b9f7ed49a7a97a4afa0781d","original_commit_id":"6dfa696f72ba4d951b9f7ed49a7a97a4afa0781d","user":{"login":"jasonrhodes","id":159370,"node_id":"MDQ6VXNlcjE1OTM3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/159370?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhodes","html_url":"https://github.com/jasonrhodes","followers_url":"https://api.github.com/users/jasonrhodes/followers","following_url":"https://api.github.com/users/jasonrhodes/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhodes/subscriptions","organizations_url":"https://api.github.com/users/jasonrhodes/orgs","repos_url":"https://api.github.com/users/jasonrhodes/repos","events_url":"https://api.github.com/users/jasonrhodes/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhodes/received_events","type":"User","site_admin":false},"body":"Yeah right now we can't add query params to KibanaLink ... I'll see what we have time to do but I am worried about dragging this out too much so it may stay for now and get refactored later.","created_at":"2018-10-18T21:08:06Z","updated_at":"2018-10-18T21:08:07Z","html_url":"https://github.com/elastic/kibana/pull/24027#discussion_r226466064","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/24027","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/226466064"},"html":{"href":"https://github.com/elastic/kibana/pull/24027#discussion_r226466064"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24027"}},"in_reply_to_id":226465135},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/24027","id":222935108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTM1MTA4","html_url":"https://github.com/elastic/kibana/pull/24027","diff_url":"https://github.com/elastic/kibana/pull/24027.diff","patch_url":"https://github.com/elastic/kibana/pull/24027.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/24027","number":24027,"state":"open","locked":false,"title":"Timeline transaction flyout","user":{"login":"jasonrhodes","id":159370,"node_id":"MDQ6VXNlcjE1OTM3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/159370?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhodes","html_url":"https://github.com/jasonrhodes","followers_url":"https://api.github.com/users/jasonrhodes/followers","following_url":"https://api.github.com/users/jasonrhodes/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhodes/subscriptions","organizations_url":"https://api.github.com/users/jasonrhodes/orgs","repos_url":"https://api.github.com/users/jasonrhodes/repos","events_url":"https://api.github.com/users/jasonrhodes/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhodes/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis replaces work in #24010 after discussions with the team and me better understanding the work here.  Closes #23567\r\n\r\nUPDATE: this work also includes persisting the flyout and flyout active tab state in the query string for both the transaction flyouts _and_ the span flyouts.\r\n\r\ne.g.\r\n\r\nexample transaction link (with service tab active)\r\nhttp://localhost:5601/app/apm#/opbeans-java/transactions/request/APIRestController~23products?_g=()&kuery=&flyoutDetailTab=service&activeTimelineId=6da58c75083c86e9\r\n\r\nexample span link\r\nhttp://localhost:5601/app/apm#/opbeans-java/transactions/request/APIRestController~23products?_g=()&kuery=&flyoutDetailTab=null&activeTimelineId=1b394e907aaf708d","created_at":"2018-10-15T14:51:26Z","updated_at":"2018-10-18T21:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70c01297f70aa553b959b9a9db1b9a863abf3abd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/24027/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/24027/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/24027/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/6dfa696f72ba4d951b9f7ed49a7a97a4afa0781d","head":{"label":"jasonrhodes:timeline-transaction-flyout-b","ref":"timeline-transaction-flyout-b","sha":"6dfa696f72ba4d951b9f7ed49a7a97a4afa0781d","user":{"login":"jasonrhodes","id":159370,"node_id":"MDQ6VXNlcjE1OTM3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/159370?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhodes","html_url":"https://github.com/jasonrhodes","followers_url":"https://api.github.com/users/jasonrhodes/followers","following_url":"https://api.github.com/users/jasonrhodes/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhodes/subscriptions","organizations_url":"https://api.github.com/users/jasonrhodes/orgs","repos_url":"https://api.github.com/users/jasonrhodes/repos","events_url":"https://api.github.com/users/jasonrhodes/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhodes/received_events","type":"User","site_admin":false},"repo":{"id":145128902,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMjg5MDI=","name":"kibana","full_name":"jasonrhodes/kibana","private":false,"owner":{"login":"jasonrhodes","id":159370,"node_id":"MDQ6VXNlcjE1OTM3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/159370?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhodes","html_url":"https://github.com/jasonrhodes","followers_url":"https://api.github.com/users/jasonrhodes/followers","following_url":"https://api.github.com/users/jasonrhodes/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhodes/subscriptions","organizations_url":"https://api.github.com/users/jasonrhodes/orgs","repos_url":"https://api.github.com/users/jasonrhodes/repos","events_url":"https://api.github.com/users/jasonrhodes/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jasonrhodes/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/jasonrhodes/kibana","forks_url":"https://api.github.com/repos/jasonrhodes/kibana/forks","keys_url":"https://api.github.com/repos/jasonrhodes/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonrhodes/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonrhodes/kibana/teams","hooks_url":"https://api.github.com/repos/jasonrhodes/kibana/hooks","issue_events_url":"https://api.github.com/repos/jasonrhodes/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/jasonrhodes/kibana/events","assignees_url":"https://api.github.com/repos/jasonrhodes/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/jasonrhodes/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/jasonrhodes/kibana/tags","blobs_url":"https://api.github.com/repos/jasonrhodes/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonrhodes/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonrhodes/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonrhodes/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonrhodes/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonrhodes/kibana/languages","stargazers_url":"https://api.github.com/repos/jasonrhodes/kibana/stargazers","contributors_url":"https://api.github.com/repos/jasonrhodes/kibana/contributors","subscribers_url":"https://api.github.com/repos/jasonrhodes/kibana/subscribers","subscription_url":"https://api.github.com/repos/jasonrhodes/kibana/subscription","commits_url":"https://api.github.com/repos/jasonrhodes/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonrhodes/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonrhodes/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonrhodes/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonrhodes/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/jasonrhodes/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonrhodes/kibana/merges","archive_url":"https://api.github.com/repos/jasonrhodes/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonrhodes/kibana/downloads","issues_url":"https://api.github.com/repos/jasonrhodes/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/jasonrhodes/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonrhodes/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonrhodes/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonrhodes/kibana/labels{/name}","releases_url":"https://api.github.com/repos/jasonrhodes/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/jasonrhodes/kibana/deployments","created_at":"2018-08-17T14:13:07Z","updated_at":"2018-10-05T12:46:27Z","pushed_at":"2018-10-18T20:35:32Z","git_url":"git://github.com/jasonrhodes/kibana.git","ssh_url":"git@github.com:jasonrhodes/kibana.git","clone_url":"https://github.com/jasonrhodes/kibana.git","svn_url":"https://github.com/jasonrhodes/kibana","homepage":"https://www.elastic.co/products/kibana","size":473601,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:apm/dt","ref":"apm/dt","sha":"de4bfe6f37bf9a80dd001e02d232234549bda81f","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-18T20:38:26Z","pushed_at":"2018-10-18T21:01:17Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":548517,"stargazers_count":10281,"watchers_count":10281,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4003,"mirror_url":null,"archived":false,"open_issues_count":3640,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4003,"open_issues":3640,"watchers":10281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24027"},"html":{"href":"https://github.com/elastic/kibana/pull/24027"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/24027"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/24027/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24027/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24027/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/6dfa696f72ba4d951b9f7ed49a7a97a4afa0781d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasonrhodes"}}