{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/204230254","pull_request_review_id":139277904,"id":204230254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIzMDI1NA==","diff_hunk":"@@ -507,14 +507,37 @@ impl<'a, 'tcx> FunctionCx<'a, 'tcx> {\n                         // promotes any complex rvalues to constants.\n                         if i == 2 && intrinsic.unwrap().starts_with(\"simd_shuffle\") {\n                             match *arg {\n+                                mir::Operand::Copy(mir::Place::Promoted(box(index, ty))) |\n+                                mir::Operand::Move(mir::Place::Promoted(box(index, ty))) => {\n+                                    let param_env = ty::ParamEnv::reveal_all();\n+                                    let cid = mir::interpret::GlobalId {\n+                                        instance: self.instance,\n+                                        promoted: Some(index),\n+                                    };\n+                                    let c = bx.tcx().const_eval(param_env.and(cid));\n+                                    let (llval, ty) = self.simd_shuffle_indices(","path":"src/librustc_codegen_llvm/mir/block.rs","position":12,"original_position":12,"commit_id":"e39e42a130e82ede91b4759bfe944521b3a419d8","original_commit_id":"e39e42a130e82ede91b4759bfe944521b3a419d8","user":{"login":"nagisa","id":679122,"node_id":"MDQ6VXNlcjY3OTEyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/679122?v=4","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":"What is the point of this?","created_at":"2018-07-22T07:14:13Z","updated_at":"2018-07-22T07:14:13Z","html_url":"https://github.com/rust-lang/rust/pull/52597#discussion_r204230254","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/52597","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/204230254"},"html":{"href":"https://github.com/rust-lang/rust/pull/52597#discussion_r204230254"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52597"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/52597","id":203030749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDMwNzQ5","html_url":"https://github.com/rust-lang/rust/pull/52597","diff_url":"https://github.com/rust-lang/rust/pull/52597.diff","patch_url":"https://github.com/rust-lang/rust/pull/52597.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/52597","number":52597,"state":"open","locked":false,"title":"Promoteds are statics and statics have a place, not just a value","user":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"r? @eddyb \r\n\r\nThis makes everything around promoteds a little simpler","created_at":"2018-07-21T23:03:01Z","updated_at":"2018-07-22T07:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69ccd8dc129bb2b2ec72346903eb17c6eea2684b","assignee":{"login":"eddyb","id":77424,"node_id":"MDQ6VXNlcjc3NDI0","avatar_url":"https://avatars2.githubusercontent.com/u/77424?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"eddyb","id":77424,"node_id":"MDQ6VXNlcjc3NDI0","avatar_url":"https://avatars2.githubusercontent.com/u/77424?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/52597/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/52597/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/52597/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/e39e42a130e82ede91b4759bfe944521b3a419d8","head":{"label":"oli-obk:promotion_simplify","ref":"promotion_simplify","sha":"e39e42a130e82ede91b4759bfe944521b3a419d8","user":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"repo":{"id":26541058,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU0MTA1OA==","name":"rust","full_name":"oli-obk/rust","owner":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oli-obk/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/oli-obk/rust","forks_url":"https://api.github.com/repos/oli-obk/rust/forks","keys_url":"https://api.github.com/repos/oli-obk/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oli-obk/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oli-obk/rust/teams","hooks_url":"https://api.github.com/repos/oli-obk/rust/hooks","issue_events_url":"https://api.github.com/repos/oli-obk/rust/issues/events{/number}","events_url":"https://api.github.com/repos/oli-obk/rust/events","assignees_url":"https://api.github.com/repos/oli-obk/rust/assignees{/user}","branches_url":"https://api.github.com/repos/oli-obk/rust/branches{/branch}","tags_url":"https://api.github.com/repos/oli-obk/rust/tags","blobs_url":"https://api.github.com/repos/oli-obk/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oli-obk/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oli-obk/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/oli-obk/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oli-obk/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/oli-obk/rust/languages","stargazers_url":"https://api.github.com/repos/oli-obk/rust/stargazers","contributors_url":"https://api.github.com/repos/oli-obk/rust/contributors","subscribers_url":"https://api.github.com/repos/oli-obk/rust/subscribers","subscription_url":"https://api.github.com/repos/oli-obk/rust/subscription","commits_url":"https://api.github.com/repos/oli-obk/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/oli-obk/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/oli-obk/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/oli-obk/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/oli-obk/rust/contents/{+path}","compare_url":"https://api.github.com/repos/oli-obk/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oli-obk/rust/merges","archive_url":"https://api.github.com/repos/oli-obk/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oli-obk/rust/downloads","issues_url":"https://api.github.com/repos/oli-obk/rust/issues{/number}","pulls_url":"https://api.github.com/repos/oli-obk/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/oli-obk/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/oli-obk/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oli-obk/rust/labels{/name}","releases_url":"https://api.github.com/repos/oli-obk/rust/releases{/id}","deployments_url":"https://api.github.com/repos/oli-obk/rust/deployments","created_at":"2014-11-12T15:00:39Z","updated_at":"2018-05-19T18:03:34Z","pushed_at":"2018-07-21T23:01:27Z","git_url":"git://github.com/oli-obk/rust.git","ssh_url":"git@github.com:oli-obk/rust.git","clone_url":"https://github.com/oli-obk/rust.git","svn_url":"https://github.com/oli-obk/rust","homepage":"http://www.rust-lang.org","size":380580,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"874dec25ed4c08d36f17d396b6872ca50313fc8e","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-07-22T05:39:50Z","pushed_at":"2018-07-22T06:52:54Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":380805,"stargazers_count":29489,"watchers_count":29489,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5070,"mirror_url":null,"archived":false,"open_issues_count":4026,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5070,"open_issues":4026,"watchers":29489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52597"},"html":{"href":"https://github.com/rust-lang/rust/pull/52597"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/52597"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/52597/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52597/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52597/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/e39e42a130e82ede91b4759bfe944521b3a419d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nagisa"}}