{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/185071618","pull_request_review_id":116390608,"id":185071618,"diff_hunk":"@@ -637,6 +637,11 @@ with pkgs;\n \n   genymotion = callPackage ../development/mobile/genymotion { };\n \n+  gams = callPackage ../tools/misc/gams {\n+    license = config.gams.license;","path":"pkgs/top-level/all-packages.nix","position":5,"original_position":5,"commit_id":"f244968c0878d49eda75f04c880caf269ff32709","original_commit_id":"ae930c4b6c254926761ae6b7a1c7f3fc7154583a","user":{"login":"xeji","id":36407913,"avatar_url":"https://avatars2.githubusercontent.com/u/36407913?v=4","gravatar_id":"","url":"https://api.github.com/users/xeji","html_url":"https://github.com/xeji","followers_url":"https://api.github.com/users/xeji/followers","following_url":"https://api.github.com/users/xeji/following{/other_user}","gists_url":"https://api.github.com/users/xeji/gists{/gist_id}","starred_url":"https://api.github.com/users/xeji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeji/subscriptions","organizations_url":"https://api.github.com/users/xeji/orgs","repos_url":"https://api.github.com/users/xeji/repos","events_url":"https://api.github.com/users/xeji/events{/privacy}","received_events_url":"https://api.github.com/users/xeji/received_events","type":"User","site_admin":false},"body":"Still doesn't eval if the two config options aren't set (like on ofborg). You need to define safe defaults for both of them, as in ` license = config.gams.license or \"someSensibleDefaultValue\";`. Please verify that the package builds with these default values, in this case it should result in an unlicensed demo version using default options.","created_at":"2018-04-30T18:38:11Z","updated_at":"2018-04-30T18:38:19Z","html_url":"https://github.com/NixOS/nixpkgs/pull/39603#discussion_r185071618","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/185071618"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39603#discussion_r185071618"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603"}},"in_reply_to_id":184688630},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603","id":184622496,"html_url":"https://github.com/NixOS/nixpkgs/pull/39603","diff_url":"https://github.com/NixOS/nixpkgs/pull/39603.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/39603.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39603","number":39603,"state":"open","locked":false,"title":"gams: init at 25.02","user":{"login":"Scriptkiddi","id":3598650,"avatar_url":"https://avatars1.githubusercontent.com/u/3598650?v=4","gravatar_id":"","url":"https://api.github.com/users/Scriptkiddi","html_url":"https://github.com/Scriptkiddi","followers_url":"https://api.github.com/users/Scriptkiddi/followers","following_url":"https://api.github.com/users/Scriptkiddi/following{/other_user}","gists_url":"https://api.github.com/users/Scriptkiddi/gists{/gist_id}","starred_url":"https://api.github.com/users/Scriptkiddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scriptkiddi/subscriptions","organizations_url":"https://api.github.com/users/Scriptkiddi/orgs","repos_url":"https://api.github.com/users/Scriptkiddi/repos","events_url":"https://api.github.com/users/Scriptkiddi/events{/privacy}","received_events_url":"https://api.github.com/users/Scriptkiddi/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nI need to use gams for my work so I thought I would package it.\r\nSince this is my first nix package I really would appreciate feedback. \r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-04-27T13:29:18Z","updated_at":"2018-04-30T18:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5dcdfcc414ee16003bbfc335b3546d69b713d0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39603/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f244968c0878d49eda75f04c880caf269ff32709","head":{"label":"Scriptkiddi:master","ref":"master","sha":"f244968c0878d49eda75f04c880caf269ff32709","user":{"login":"Scriptkiddi","id":3598650,"avatar_url":"https://avatars1.githubusercontent.com/u/3598650?v=4","gravatar_id":"","url":"https://api.github.com/users/Scriptkiddi","html_url":"https://github.com/Scriptkiddi","followers_url":"https://api.github.com/users/Scriptkiddi/followers","following_url":"https://api.github.com/users/Scriptkiddi/following{/other_user}","gists_url":"https://api.github.com/users/Scriptkiddi/gists{/gist_id}","starred_url":"https://api.github.com/users/Scriptkiddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scriptkiddi/subscriptions","organizations_url":"https://api.github.com/users/Scriptkiddi/orgs","repos_url":"https://api.github.com/users/Scriptkiddi/repos","events_url":"https://api.github.com/users/Scriptkiddi/events{/privacy}","received_events_url":"https://api.github.com/users/Scriptkiddi/received_events","type":"User","site_admin":false},"repo":{"id":131297865,"name":"nixpkgs","full_name":"Scriptkiddi/nixpkgs","owner":{"login":"Scriptkiddi","id":3598650,"avatar_url":"https://avatars1.githubusercontent.com/u/3598650?v=4","gravatar_id":"","url":"https://api.github.com/users/Scriptkiddi","html_url":"https://github.com/Scriptkiddi","followers_url":"https://api.github.com/users/Scriptkiddi/followers","following_url":"https://api.github.com/users/Scriptkiddi/following{/other_user}","gists_url":"https://api.github.com/users/Scriptkiddi/gists{/gist_id}","starred_url":"https://api.github.com/users/Scriptkiddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scriptkiddi/subscriptions","organizations_url":"https://api.github.com/users/Scriptkiddi/orgs","repos_url":"https://api.github.com/users/Scriptkiddi/repos","events_url":"https://api.github.com/users/Scriptkiddi/events{/privacy}","received_events_url":"https://api.github.com/users/Scriptkiddi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Scriptkiddi/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Scriptkiddi/nixpkgs","forks_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/forks","keys_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/events","assignees_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/merges","archive_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Scriptkiddi/nixpkgs/deployments","created_at":"2018-04-27T13:08:18Z","updated_at":"2018-04-30T16:08:18Z","pushed_at":"2018-04-30T16:08:15Z","git_url":"git://github.com/Scriptkiddi/nixpkgs.git","ssh_url":"git@github.com:Scriptkiddi/nixpkgs.git","clone_url":"https://github.com/Scriptkiddi/nixpkgs.git","svn_url":"https://github.com/Scriptkiddi/nixpkgs","homepage":null,"size":769747,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"02cb787c0cf4d38c9eb64e7110201a19ab6469cd","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-04-30T18:36:45Z","pushed_at":"2018-04-30T18:33:22Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":780354,"stargazers_count":2400,"watchers_count":2400,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2744,"mirror_url":null,"archived":false,"open_issues_count":3077,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2744,"open_issues":3077,"watchers":2400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39603"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39603"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39603/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39603/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f244968c0878d49eda75f04c880caf269ff32709"}},"author_association":"NONE"}}
{"actor":{"display_login":"xeji"}}