{"action":"closed","number":596,"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/596","id":217125507,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTI1NTA3","html_url":"https://github.com/dojo/widgets/pull/596","diff_url":"https://github.com/dojo/widgets/pull/596.diff","patch_url":"https://github.com/dojo/widgets/pull/596.patch","issue_url":"https://api.github.com/repos/dojo/widgets/issues/596","number":596,"state":"closed","locked":false,"title":"Add paging aria semantics, update pageChange","user":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"body":"**Type:** bug\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [x] There is a related issue\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [x] Unit or Functional tests are included in the PR\r\n\r\n<!--\r\nOur bots should ensure:\r\n\r\n* [ ] All contributors have signed a CLA\r\n* [ ] The PR passes CI testing\r\n* [ ] Code coverage is maintained\r\n* [ ] The PR has been reviewed and approved\r\n-->\r\n\r\n**Description:**\r\n\r\nResolves #585 \r\n\r\nAdds ARIA attributes for row count and index to handle not all rows existing in the DOM. Also adds ARIA attribute for column sorting.\r\n\r\nUpdates `pageChange` page numbering logic. Previously, when the grid fetched more rows at once than existing in a single page, it was possible to never land on the first page.\r\n","created_at":"2018-09-20T22:33:39Z","updated_at":"2018-09-22T08:41:53Z","closed_at":"2018-09-22T08:41:53Z","merged_at":"2018-09-22T08:41:53Z","merge_commit_sha":"4aebc7ebba11359eaf8af4d71274bdbf0c408691","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/widgets/pulls/596/commits","review_comments_url":"https://api.github.com/repos/dojo/widgets/pulls/596/comments","review_comment_url":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/596/comments","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/c1cc4962a6c9934a71f85f71295b7682775275f1","head":{"label":"smhigley:grid-paging","ref":"grid-paging","sha":"c1cc4962a6c9934a71f85f71295b7682775275f1","user":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"repo":{"id":80783166,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzE2Ng==","name":"widgets","full_name":"smhigley/widgets","private":false,"owner":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smhigley/widgets","description":":rocket: UI components for dojo2.","fork":true,"url":"https://api.github.com/repos/smhigley/widgets","forks_url":"https://api.github.com/repos/smhigley/widgets/forks","keys_url":"https://api.github.com/repos/smhigley/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smhigley/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smhigley/widgets/teams","hooks_url":"https://api.github.com/repos/smhigley/widgets/hooks","issue_events_url":"https://api.github.com/repos/smhigley/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/smhigley/widgets/events","assignees_url":"https://api.github.com/repos/smhigley/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/smhigley/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/smhigley/widgets/tags","blobs_url":"https://api.github.com/repos/smhigley/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smhigley/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smhigley/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/smhigley/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smhigley/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/smhigley/widgets/languages","stargazers_url":"https://api.github.com/repos/smhigley/widgets/stargazers","contributors_url":"https://api.github.com/repos/smhigley/widgets/contributors","subscribers_url":"https://api.github.com/repos/smhigley/widgets/subscribers","subscription_url":"https://api.github.com/repos/smhigley/widgets/subscription","commits_url":"https://api.github.com/repos/smhigley/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/smhigley/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/smhigley/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/smhigley/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/smhigley/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/smhigley/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smhigley/widgets/merges","archive_url":"https://api.github.com/repos/smhigley/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smhigley/widgets/downloads","issues_url":"https://api.github.com/repos/smhigley/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/smhigley/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/smhigley/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/smhigley/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smhigley/widgets/labels{/name}","releases_url":"https://api.github.com/repos/smhigley/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/smhigley/widgets/deployments","created_at":"2017-02-03T00:33:10Z","updated_at":"2018-09-12T22:41:59Z","pushed_at":"2018-09-22T08:32:00Z","git_url":"git://github.com/smhigley/widgets.git","ssh_url":"git@github.com:smhigley/widgets.git","clone_url":"https://github.com/smhigley/widgets.git","svn_url":"https://github.com/smhigley/widgets","homepage":"","size":2634,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"1dd3cc86518f7805455dc4bb32d0784e51e2accb","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":79911519,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkxMTUxOQ==","name":"widgets","full_name":"dojo/widgets","private":false,"owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dojo/widgets","description":":rocket: Dojo - UI widgets.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2017-01-24T12:55:57Z","updated_at":"2018-09-22T08:15:12Z","pushed_at":"2018-09-22T08:41:53Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"http://dojo.io","size":2953,"stargazers_count":34,"watchers_count":34,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":39,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/596"},"html":{"href":"https://github.com/dojo/widgets/pull/596"},"issue":{"href":"https://api.github.com/repos/dojo/widgets/issues/596"},"comments":{"href":"https://api.github.com/repos/dojo/widgets/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/widgets/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/widgets/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/widgets/statuses/c1cc4962a6c9934a71f85f71295b7682775275f1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":108,"deletions":25,"changed_files":8}}
{"actor":{"display_login":"smhigley"}}