{"action":"closed","issue":{"url":"https://api.github.com/repos/telepresenceio/telepresence/issues/641","repository_url":"https://api.github.com/repos/telepresenceio/telepresence","labels_url":"https://api.github.com/repos/telepresenceio/telepresence/issues/641/labels{/name}","comments_url":"https://api.github.com/repos/telepresenceio/telepresence/issues/641/comments","events_url":"https://api.github.com/repos/telepresenceio/telepresence/issues/641/events","html_url":"https://github.com/telepresenceio/telepresence/issues/641","id":323765486,"node_id":"MDU6SXNzdWUzMjM3NjU0ODY=","number":641,"title":"Improve version handling","user":{"login":"ark3","id":1765854,"node_id":"MDQ6VXNlcjE3NjU4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1765854?v=4","gravatar_id":"","url":"https://api.github.com/users/ark3","html_url":"https://github.com/ark3","followers_url":"https://api.github.com/users/ark3/followers","following_url":"https://api.github.com/users/ark3/following{/other_user}","gists_url":"https://api.github.com/users/ark3/gists{/gist_id}","starred_url":"https://api.github.com/users/ark3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ark3/subscriptions","organizations_url":"https://api.github.com/users/ark3/orgs","repos_url":"https://api.github.com/users/ark3/repos","events_url":"https://api.github.com/users/ark3/events{/privacy}","received_events_url":"https://api.github.com/users/ark3/received_events","type":"User","site_admin":false},"labels":[{"id":611450616,"node_id":"MDU6TGFiZWw2MTE0NTA2MTY=","url":"https://api.github.com/repos/telepresenceio/telepresence/labels/infrastructure","name":"infrastructure","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":{"login":"ark3","id":1765854,"node_id":"MDQ6VXNlcjE3NjU4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1765854?v=4","gravatar_id":"","url":"https://api.github.com/users/ark3","html_url":"https://github.com/ark3","followers_url":"https://api.github.com/users/ark3/followers","following_url":"https://api.github.com/users/ark3/following{/other_user}","gists_url":"https://api.github.com/users/ark3/gists{/gist_id}","starred_url":"https://api.github.com/users/ark3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ark3/subscriptions","organizations_url":"https://api.github.com/users/ark3/orgs","repos_url":"https://api.github.com/users/ark3/repos","events_url":"https://api.github.com/users/ark3/events{/privacy}","received_events_url":"https://api.github.com/users/ark3/received_events","type":"User","site_admin":false},"assignees":[{"login":"ark3","id":1765854,"node_id":"MDQ6VXNlcjE3NjU4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1765854?v=4","gravatar_id":"","url":"https://api.github.com/users/ark3","html_url":"https://github.com/ark3","followers_url":"https://api.github.com/users/ark3/followers","following_url":"https://api.github.com/users/ark3/following{/other_user}","gists_url":"https://api.github.com/users/ark3/gists{/gist_id}","starred_url":"https://api.github.com/users/ark3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ark3/subscriptions","organizations_url":"https://api.github.com/users/ark3/orgs","repos_url":"https://api.github.com/users/ark3/repos","events_url":"https://api.github.com/users/ark3/events{/privacy}","received_events_url":"https://api.github.com/users/ark3/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-16T20:00:57Z","updated_at":"2018-06-04T22:12:03Z","closed_at":"2018-06-04T22:12:03Z","author_association":"CONTRIBUTOR","body":"Goals\r\n- Telepresence knows whether it is running from a released artifact or from source\r\n- Telepresence warns the user when environment variables override the version of the proxy image (and the local image for container method)\r\n- Telepresence reports both the original (built-in) version and override version info when an environment override is used\r\n- Tagged release commits and unreleased commits have a computable version number that the deploy script can use to mark the artifacts it generates (Telepresence itself, images, deb/rpm packages, etc.)\r\n- When running a released codebase, Telepresence reports a release version string (e.g., `0.88`) and uses the same version for images\r\n- When running installed from a non-release commit, Telepresence reports a dev version string (e.g., `0.88+3.gFEED1BEEF.dirty`) and uses the same version for images\r\n- When running from a developer's Git checkout, Telepresence reports a dev version string but uses the prior release's images (`0.88`)\r\n\r\nPlan\r\n- [x] Remove all hard-coded references to the version number. \r\n    - Such references are already catalogued in `.bumpversion.cfg`\r\n    - `docs/build-website.py` will need special handling\r\n- [x] Remove Bumpversion\r\n- [x] Add [Versioneer](https://github.com/warner/python-versioneer/blob/master/INSTALL.md)\r\n- [x] Update the `deploy.py` script so that unique dev version numbers are used on untagged builds (as opposed to re-using the prior release's version number, which is what happens right now)\r\n- [x] Update the release process documentation\r\n    - Manually compute the next version\r\n    - Call `towncrier` with the new version number as before\r\n    - Tag the repo manually with the new version number. This replaces the current `bumpversion` step\r\n\r\nVersioneer automatically takes care of reporting the appropriate type of version number from a source tree, from an installed deployment, etc. It computes the version based on the SCM state in dev. When using setuptools to deploy/install, it replaces the version computation code with a hard-coded value. It may be some work to figure out which case is in play; need to investigate.\r\n\r\n\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"ark3"}}