{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/168614706","pull_request_review_id":97011532,"id":168614706,"diff_hunk":"@@ -574,27 +570,62 @@ define([\n      */\n     ClippingPlaneCollection.TEXTURE_WIDTH = CesiumMath.nextPowerOfTwo(Math.ceil(Math.sqrt(ClippingPlaneCollection.MAX_CLIPPING_PLANES * 2)));\n \n+    /**\n+     * Returns true if this object was destroyed; otherwise, false.\n+     * <br /><br />\n+     * If this object was destroyed, it should not be used; calling any function other than\n+     * <code>isDestroyed</code> will result in a {@link DeveloperError} exception.\n+     *\n+     * @returns {Boolean} <code>true</code> if this object was destroyed; otherwise, <code>false</code>.\n+     *\n+     * @see ClippingPlaneCollection#destroy\n+     */\n     ClippingPlaneCollection.prototype.isDestroyed = function() {\n         return false;\n     };\n \n     /**\n-     * Destroys this ClippingPlaneCollection if it either has no owner or a reference to the owner is passed in.\n-     * We only expect an owner to be defined if this collection is shared by one Cesium3DTileset\n-     * and a series of Cesium3DTiles with Model content.\n+     * Destroys this ClippingPlaneCollectionand its WebGL resources.\n      * @private\n+     */\n+    ClippingPlaneCollection.prototype.destroy = function() {","path":"Source/Core/ClippingPlaneCollection.js","position":null,"original_position":150,"commit_id":"c699d4ba1904d0d4f14d9cb9c68138b7565d408f","original_commit_id":"b61f98f0dad011e723f34b395bed407a8f741614","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars2.githubusercontent.com/u/915398?v=4","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"body":"Round out the doc for this. For example:\r\n\r\n```\r\n    /**\r\n     * Destroys the WebGL resources held by this object.  Destroying an object allows for deterministic\r\n     * release of WebGL resources, instead of relying on the garbage collector to destroy this object.\r\n     * <br /><br />\r\n     * Once an object is destroyed, it should not be used; calling any function other than\r\n     * <code>isDestroyed</code> will result in a {@link DeveloperError} exception.  Therefore,\r\n     * assign the return value (<code>undefined</code>) to the object as done in the example.\r\n     *\r\n     * @returns {undefined}\r\n     *\r\n     * @exception {DeveloperError} This object was destroyed, i.e., destroy() was called.\r\n     *\r\n     *\r\n     * @example\r\n     * clippingPlanes = clippingPlanes && clippingPlanes .destroy();\r\n     *\r\n     * @see ClippingPlaneCollection#isDestroyed\r\n     */\r\n```","created_at":"2018-02-15T21:33:45Z","updated_at":"2018-02-15T21:57:17Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201#discussion_r168614706","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/168614706"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201#discussion_r168614706"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201","id":168312100,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6201","number":6201,"state":"open","locked":false,"title":"Increase max clipping planes using textures","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars3.githubusercontent.com/u/5395255?v=4","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"body":"Storing the clipping planes in textures leads to a few caveats:\r\n* precision problems with compression to RGBA means plane transformations happen in the shader now instead of on the CPU side\r\n  * so it's a bit more shader math\r\n  * but nice benefit is that the texture doesn't get updated as the view changes - yay!\r\n* attaching a `Texture` gl resource to `ClippingPlaneCollection` means it's no longer super practical to `clone` it onto each model in a 3D Tileset backed by gltf, so now they share the tileset's reference to a single `ClippingPlaneCollection`\r\n* `Texture` also means `ClippingPlaneCollection` now has to be destroyed, but since a `Model` may either have a reference to its own `ClippingPlaneCollection` or a `Cesium3DTileset`'s `ClippingPlaneCollection`, the `destroy` function is a little weird and might need discussion.\r\n\r\nThere's also a new Sandcastle that I used for debugging. Performance predictably isn't great with all 2048 planes and gets worse as you get closer to the model or use a 3D Tileset. But it works! Even my laptop with Atom Z3700 Series Intel Graphics will gamely throw up a frame or two every couple seconds.\r\n\r\n---\r\n\r\nFixes #6184\r\nFixes #6048","created_at":"2018-02-09T18:35:19Z","updated_at":"2018-02-15T21:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bdeacea6d68d6bdadc6273b574e8d87904772b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6201/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/c699d4ba1904d0d4f14d9cb9c68138b7565d408f","head":{"label":"likangning93:clippingPlanesByTexture","ref":"clippingPlanesByTexture","sha":"c699d4ba1904d0d4f14d9cb9c68138b7565d408f","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars3.githubusercontent.com/u/5395255?v=4","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"repo":{"id":59577300,"name":"cesium","full_name":"likangning93/cesium","owner":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars3.githubusercontent.com/u/5395255?v=4","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/likangning93/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/likangning93/cesium","forks_url":"https://api.github.com/repos/likangning93/cesium/forks","keys_url":"https://api.github.com/repos/likangning93/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/likangning93/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/likangning93/cesium/teams","hooks_url":"https://api.github.com/repos/likangning93/cesium/hooks","issue_events_url":"https://api.github.com/repos/likangning93/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/likangning93/cesium/events","assignees_url":"https://api.github.com/repos/likangning93/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/likangning93/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/likangning93/cesium/tags","blobs_url":"https://api.github.com/repos/likangning93/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/likangning93/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/likangning93/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/likangning93/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/likangning93/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/likangning93/cesium/languages","stargazers_url":"https://api.github.com/repos/likangning93/cesium/stargazers","contributors_url":"https://api.github.com/repos/likangning93/cesium/contributors","subscribers_url":"https://api.github.com/repos/likangning93/cesium/subscribers","subscription_url":"https://api.github.com/repos/likangning93/cesium/subscription","commits_url":"https://api.github.com/repos/likangning93/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/likangning93/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/likangning93/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/likangning93/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/likangning93/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/likangning93/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/likangning93/cesium/merges","archive_url":"https://api.github.com/repos/likangning93/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/likangning93/cesium/downloads","issues_url":"https://api.github.com/repos/likangning93/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/likangning93/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/likangning93/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/likangning93/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/likangning93/cesium/labels{/name}","releases_url":"https://api.github.com/repos/likangning93/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/likangning93/cesium/deployments","created_at":"2016-05-24T13:50:36Z","updated_at":"2016-05-24T13:50:48Z","pushed_at":"2018-02-15T20:14:51Z","git_url":"git://github.com/likangning93/cesium.git","ssh_url":"git@github.com:likangning93/cesium.git","clone_url":"https://github.com/likangning93/cesium.git","svn_url":"https://github.com/likangning93/cesium","homepage":"cesiumjs.org","size":279821,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"08cdd6eddc21d2f3c3476161d0ff3be3387ca1fe","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2018-02-13T09:35:49Z","pushed_at":"2018-02-15T21:24:07Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":289092,"stargazers_count":2833,"watchers_count":2833,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1288,"mirror_url":null,"archived":false,"open_issues_count":675,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1288,"open_issues":675,"watchers":2833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6201"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6201"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6201/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6201/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/c699d4ba1904d0d4f14d9cb9c68138b7565d408f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lilleyse"}}