{"action":"created","comment":{"url":"https://api.github.com/repos/magento/magento2/pulls/comments/221290028","pull_request_review_id":159907418,"id":221290028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI5MDAyOA==","diff_hunk":"@@ -1794,7 +1794,8 @@ protected function _getSpecificTypeData(array $rowData, $optionTypeId, $defaultS\n             ];\n \n             $priceData = false;\n-            if (!empty($rowData[self::COLUMN_ROW_PRICE])) {\n+            $customOptionRowPrice = $rowData[self::COLUMN_ROW_PRICE];\n+            if (!empty($customOptionRowPrice) || $customOptionRowPrice === '0') {","path":"app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php","position":6,"original_position":6,"commit_id":"74ca77ca8023516fea3be1c4eb4714d6f63b791b","original_commit_id":"74ca77ca8023516fea3be1c4eb4714d6f63b791b","user":{"login":"amatanovic","id":9751170,"node_id":"MDQ6VXNlcjk3NTExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9751170?v=4","gravatar_id":"","url":"https://api.github.com/users/amatanovic","html_url":"https://github.com/amatanovic","followers_url":"https://api.github.com/users/amatanovic/followers","following_url":"https://api.github.com/users/amatanovic/following{/other_user}","gists_url":"https://api.github.com/users/amatanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/amatanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amatanovic/subscriptions","organizations_url":"https://api.github.com/users/amatanovic/orgs","repos_url":"https://api.github.com/users/amatanovic/repos","events_url":"https://api.github.com/users/amatanovic/events{/privacy}","received_events_url":"https://api.github.com/users/amatanovic/received_events","type":"User","site_admin":false},"body":"Hey @slavvka for '0.0' the empty() would return false so it worked even before this. The issue was with '0' because the empty() returns true so the price was never set. ","created_at":"2018-09-28T15:19:43Z","updated_at":"2018-09-28T15:19:43Z","html_url":"https://github.com/magento/magento2/pull/18284#discussion_r221290028","pull_request_url":"https://api.github.com/repos/magento/magento2/pulls/18284","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/221290028"},"html":{"href":"https://github.com/magento/magento2/pull/18284#discussion_r221290028"},"pull_request":{"href":"https://api.github.com/repos/magento/magento2/pulls/18284"}},"in_reply_to_id":221282462},"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18284","id":218618842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjE4ODQy","html_url":"https://github.com/magento/magento2/pull/18284","diff_url":"https://github.com/magento/magento2/pull/18284.diff","patch_url":"https://github.com/magento/magento2/pull/18284.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/18284","number":18284,"state":"open","locked":false,"title":"save the custom option price when it is 0","user":{"login":"amatanovic","id":9751170,"node_id":"MDQ6VXNlcjk3NTExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9751170?v=4","gravatar_id":"","url":"https://api.github.com/users/amatanovic","html_url":"https://github.com/amatanovic","followers_url":"https://api.github.com/users/amatanovic/followers","following_url":"https://api.github.com/users/amatanovic/following{/other_user}","gists_url":"https://api.github.com/users/amatanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/amatanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amatanovic/subscriptions","organizations_url":"https://api.github.com/users/amatanovic/orgs","repos_url":"https://api.github.com/users/amatanovic/repos","events_url":"https://api.github.com/users/amatanovic/events{/privacy}","received_events_url":"https://api.github.com/users/amatanovic/received_events","type":"User","site_admin":false},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. magento/magento2#17616: Importer fails when updating an existing product with custom options\r\n2. ...\r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. ... See issue description\r\n2. ...\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-09-27T11:35:01Z","updated_at":"2018-09-28T15:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ed5ba6bc19e88957d467d08bdc2a81ca4699ecc","assignee":{"login":"miguelbalparda","id":3997682,"node_id":"MDQ6VXNlcjM5OTc2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3997682?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbalparda","html_url":"https://github.com/miguelbalparda","followers_url":"https://api.github.com/users/miguelbalparda/followers","following_url":"https://api.github.com/users/miguelbalparda/following{/other_user}","gists_url":"https://api.github.com/users/miguelbalparda/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbalparda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbalparda/subscriptions","organizations_url":"https://api.github.com/users/miguelbalparda/orgs","repos_url":"https://api.github.com/users/miguelbalparda/repos","events_url":"https://api.github.com/users/miguelbalparda/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbalparda/received_events","type":"User","site_admin":false},"assignees":[{"login":"miguelbalparda","id":3997682,"node_id":"MDQ6VXNlcjM5OTc2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3997682?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbalparda","html_url":"https://github.com/miguelbalparda","followers_url":"https://api.github.com/users/miguelbalparda/followers","following_url":"https://api.github.com/users/miguelbalparda/following{/other_user}","gists_url":"https://api.github.com/users/miguelbalparda/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbalparda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbalparda/subscriptions","organizations_url":"https://api.github.com/users/miguelbalparda/orgs","repos_url":"https://api.github.com/users/miguelbalparda/repos","events_url":"https://api.github.com/users/miguelbalparda/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbalparda/received_events","type":"User","site_admin":false},{"login":"slavvka","id":9741905,"node_id":"MDQ6VXNlcjk3NDE5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/9741905?v=4","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":955033790,"node_id":"MDU6TGFiZWw5NTUwMzM3OTA=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20CatalogImportExport","name":"Component: CatalogImportExport","color":"7fb703","default":false},{"id":1071130788,"node_id":"MDU6TGFiZWwxMDcxMTMwNzg4","url":"https://api.github.com/repos/magento/magento2/labels/Event:%20mm18hr","name":"Event: mm18hr","color":"ededed","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/18284/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/18284/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18284/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/74ca77ca8023516fea3be1c4eb4714d6f63b791b","head":{"label":"amatanovic:#17616_importer_issue","ref":"#17616_importer_issue","sha":"74ca77ca8023516fea3be1c4eb4714d6f63b791b","user":{"login":"amatanovic","id":9751170,"node_id":"MDQ6VXNlcjk3NTExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9751170?v=4","gravatar_id":"","url":"https://api.github.com/users/amatanovic","html_url":"https://github.com/amatanovic","followers_url":"https://api.github.com/users/amatanovic/followers","following_url":"https://api.github.com/users/amatanovic/following{/other_user}","gists_url":"https://api.github.com/users/amatanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/amatanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amatanovic/subscriptions","organizations_url":"https://api.github.com/users/amatanovic/orgs","repos_url":"https://api.github.com/users/amatanovic/repos","events_url":"https://api.github.com/users/amatanovic/events{/privacy}","received_events_url":"https://api.github.com/users/amatanovic/received_events","type":"User","site_admin":false},"repo":{"id":150240968,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyNDA5Njg=","name":"magento2","full_name":"amatanovic/magento2","private":false,"owner":{"login":"amatanovic","id":9751170,"node_id":"MDQ6VXNlcjk3NTExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9751170?v=4","gravatar_id":"","url":"https://api.github.com/users/amatanovic","html_url":"https://github.com/amatanovic","followers_url":"https://api.github.com/users/amatanovic/followers","following_url":"https://api.github.com/users/amatanovic/following{/other_user}","gists_url":"https://api.github.com/users/amatanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/amatanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amatanovic/subscriptions","organizations_url":"https://api.github.com/users/amatanovic/orgs","repos_url":"https://api.github.com/users/amatanovic/repos","events_url":"https://api.github.com/users/amatanovic/events{/privacy}","received_events_url":"https://api.github.com/users/amatanovic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amatanovic/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/amatanovic/magento2","forks_url":"https://api.github.com/repos/amatanovic/magento2/forks","keys_url":"https://api.github.com/repos/amatanovic/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amatanovic/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amatanovic/magento2/teams","hooks_url":"https://api.github.com/repos/amatanovic/magento2/hooks","issue_events_url":"https://api.github.com/repos/amatanovic/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/amatanovic/magento2/events","assignees_url":"https://api.github.com/repos/amatanovic/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/amatanovic/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/amatanovic/magento2/tags","blobs_url":"https://api.github.com/repos/amatanovic/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amatanovic/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amatanovic/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/amatanovic/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amatanovic/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/amatanovic/magento2/languages","stargazers_url":"https://api.github.com/repos/amatanovic/magento2/stargazers","contributors_url":"https://api.github.com/repos/amatanovic/magento2/contributors","subscribers_url":"https://api.github.com/repos/amatanovic/magento2/subscribers","subscription_url":"https://api.github.com/repos/amatanovic/magento2/subscription","commits_url":"https://api.github.com/repos/amatanovic/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/amatanovic/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/amatanovic/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/amatanovic/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/amatanovic/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/amatanovic/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amatanovic/magento2/merges","archive_url":"https://api.github.com/repos/amatanovic/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amatanovic/magento2/downloads","issues_url":"https://api.github.com/repos/amatanovic/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/amatanovic/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/amatanovic/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/amatanovic/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amatanovic/magento2/labels{/name}","releases_url":"https://api.github.com/repos/amatanovic/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/amatanovic/magento2/deployments","created_at":"2018-09-25T09:35:31Z","updated_at":"2018-09-25T09:36:45Z","pushed_at":"2018-09-27T11:38:04Z","git_url":"git://github.com/amatanovic/magento2.git","ssh_url":"git@github.com:amatanovic/magento2.git","clone_url":"https://github.com/amatanovic/magento2.git","svn_url":"https://github.com/amatanovic/magento2","homepage":"http://www.magento.com","size":484039,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"4b0750c8773380e4c747daa8388a8e8ce3cf9107","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-09-28T12:09:36Z","pushed_at":"2018-09-28T13:34:47Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":484630,"stargazers_count":6169,"watchers_count":6169,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5306,"mirror_url":null,"archived":false,"open_issues_count":1236,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5306,"open_issues":1236,"watchers":6169,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/18284"},"html":{"href":"https://github.com/magento/magento2/pull/18284"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/18284"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/18284/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/18284/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/18284/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/74ca77ca8023516fea3be1c4eb4714d6f63b791b"}},"author_association":"NONE"}}
{"actor":{"display_login":"amatanovic"}}