{"action":"created","comment":{"url":"https://api.github.com/repos/keycloak/keycloak/pulls/comments/224822893","pull_request_review_id":164292169,"id":224822893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDgyMjg5Mw==","diff_hunk":"@@ -424,7 +424,7 @@ private static PolicyRepresentation createPolicyRepresentation(AuthorizationProv\n      * @return RoleRepresentation with all stuff filled (including composite roles)\n      */\n     public static RoleRepresentation exportRole(RoleModel role) {\n-        RoleRepresentation roleRep = ModelToRepresentation.toRepresentation(role);\n+        RoleRepresentation roleRep = ModelToRepresentation.toBriefRepresentation(role);","path":"services/src/main/java/org/keycloak/exportimport/util/ExportUtils.java","position":5,"original_position":5,"commit_id":"51516abf34b2ebbb22952d94008d82b38dc4eb6c","original_commit_id":"51516abf34b2ebbb22952d94008d82b38dc4eb6c","user":{"login":"unly","id":4183757,"node_id":"MDQ6VXNlcjQxODM3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4183757?v=4","gravatar_id":"","url":"https://api.github.com/users/unly","html_url":"https://github.com/unly","followers_url":"https://api.github.com/users/unly/followers","following_url":"https://api.github.com/users/unly/following{/other_user}","gists_url":"https://api.github.com/users/unly/gists{/gist_id}","starred_url":"https://api.github.com/users/unly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unly/subscriptions","organizations_url":"https://api.github.com/users/unly/orgs","repos_url":"https://api.github.com/users/unly/repos","events_url":"https://api.github.com/users/unly/events{/privacy}","received_events_url":"https://api.github.com/users/unly/received_events","type":"User","site_admin":false},"body":"So far I renamed the existing `toRepresentation` to `toBriefRepresentation` except for the GET call for a role resource. I could have a look into the `exportRole` function you mentioned as it sounds like you're right. It would make sense to export the full detail role representation. Before I update the commit are there any other places that would need to have the full `toRepresentation` call?","created_at":"2018-10-12T15:24:36Z","updated_at":"2018-10-12T15:24:36Z","html_url":"https://github.com/keycloak/keycloak/pull/5615#discussion_r224822893","pull_request_url":"https://api.github.com/repos/keycloak/keycloak/pulls/5615","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/comments/224822893"},"html":{"href":"https://github.com/keycloak/keycloak/pull/5615#discussion_r224822893"},"pull_request":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5615"}},"in_reply_to_id":224810270},"pull_request":{"url":"https://api.github.com/repos/keycloak/keycloak/pulls/5615","id":220726778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzI2Nzc4","html_url":"https://github.com/keycloak/keycloak/pull/5615","diff_url":"https://github.com/keycloak/keycloak/pull/5615.diff","patch_url":"https://github.com/keycloak/keycloak/pull/5615.patch","issue_url":"https://api.github.com/repos/keycloak/keycloak/issues/5615","number":5615,"state":"open","locked":false,"title":"[KEYCLOAK-8377] Role Attributes","user":{"login":"unly","id":4183757,"node_id":"MDQ6VXNlcjQxODM3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4183757?v=4","gravatar_id":"","url":"https://api.github.com/users/unly","html_url":"https://github.com/unly","followers_url":"https://api.github.com/users/unly/followers","following_url":"https://api.github.com/users/unly/following{/other_user}","gists_url":"https://api.github.com/users/unly/gists{/gist_id}","starred_url":"https://api.github.com/users/unly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unly/subscriptions","organizations_url":"https://api.github.com/users/unly/orgs","repos_url":"https://api.github.com/users/unly/repos","events_url":"https://api.github.com/users/unly/events{/privacy}","received_events_url":"https://api.github.com/users/unly/received_events","type":"User","site_admin":false},"body":"Implementation of attributes for roles in Keycloak like the already existing attributes for groups and users.\r\n\r\nThis issue has been discussed on the mailing list and is tracked in Jira at: https://issues.jboss.org/browse/KEYCLOAK-8377","created_at":"2018-10-05T14:46:31Z","updated_at":"2018-10-12T15:24:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9e8cfbf0a631420fbe5689f1c5232be2d266124","assignee":{"login":"mposolda","id":1223965,"node_id":"MDQ6VXNlcjEyMjM5NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1223965?v=4","gravatar_id":"","url":"https://api.github.com/users/mposolda","html_url":"https://github.com/mposolda","followers_url":"https://api.github.com/users/mposolda/followers","following_url":"https://api.github.com/users/mposolda/following{/other_user}","gists_url":"https://api.github.com/users/mposolda/gists{/gist_id}","starred_url":"https://api.github.com/users/mposolda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mposolda/subscriptions","organizations_url":"https://api.github.com/users/mposolda/orgs","repos_url":"https://api.github.com/users/mposolda/repos","events_url":"https://api.github.com/users/mposolda/events{/privacy}","received_events_url":"https://api.github.com/users/mposolda/received_events","type":"User","site_admin":false},"assignees":[{"login":"mposolda","id":1223965,"node_id":"MDQ6VXNlcjEyMjM5NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1223965?v=4","gravatar_id":"","url":"https://api.github.com/users/mposolda","html_url":"https://github.com/mposolda","followers_url":"https://api.github.com/users/mposolda/followers","following_url":"https://api.github.com/users/mposolda/following{/other_user}","gists_url":"https://api.github.com/users/mposolda/gists{/gist_id}","starred_url":"https://api.github.com/users/mposolda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mposolda/subscriptions","organizations_url":"https://api.github.com/users/mposolda/orgs","repos_url":"https://api.github.com/users/mposolda/repos","events_url":"https://api.github.com/users/mposolda/events{/privacy}","received_events_url":"https://api.github.com/users/mposolda/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keycloak/keycloak/pulls/5615/commits","review_comments_url":"https://api.github.com/repos/keycloak/keycloak/pulls/5615/comments","review_comment_url":"https://api.github.com/repos/keycloak/keycloak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keycloak/keycloak/issues/5615/comments","statuses_url":"https://api.github.com/repos/keycloak/keycloak/statuses/51516abf34b2ebbb22952d94008d82b38dc4eb6c","head":{"label":"bsinno:KEYCLOAK-8377","ref":"KEYCLOAK-8377","sha":"51516abf34b2ebbb22952d94008d82b38dc4eb6c","user":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":147543011,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NDMwMTE=","name":"keycloak","full_name":"bsinno/keycloak","private":false,"owner":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bsinno/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":true,"url":"https://api.github.com/repos/bsinno/keycloak","forks_url":"https://api.github.com/repos/bsinno/keycloak/forks","keys_url":"https://api.github.com/repos/bsinno/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/keycloak/teams","hooks_url":"https://api.github.com/repos/bsinno/keycloak/hooks","issue_events_url":"https://api.github.com/repos/bsinno/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/keycloak/events","assignees_url":"https://api.github.com/repos/bsinno/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/keycloak/tags","blobs_url":"https://api.github.com/repos/bsinno/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/keycloak/languages","stargazers_url":"https://api.github.com/repos/bsinno/keycloak/stargazers","contributors_url":"https://api.github.com/repos/bsinno/keycloak/contributors","subscribers_url":"https://api.github.com/repos/bsinno/keycloak/subscribers","subscription_url":"https://api.github.com/repos/bsinno/keycloak/subscription","commits_url":"https://api.github.com/repos/bsinno/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/keycloak/merges","archive_url":"https://api.github.com/repos/bsinno/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/keycloak/downloads","issues_url":"https://api.github.com/repos/bsinno/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/keycloak/deployments","created_at":"2018-09-05T15:50:31Z","updated_at":"2018-10-05T14:30:23Z","pushed_at":"2018-10-12T13:20:15Z","git_url":"git://github.com/bsinno/keycloak.git","ssh_url":"git@github.com:bsinno/keycloak.git","clone_url":"https://github.com/bsinno/keycloak.git","svn_url":"https://github.com/bsinno/keycloak","homepage":"http://www.keycloak.org","size":126588,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keycloak:master","ref":"master","sha":"11374a27078266bebe5239d595796589e78bae9d","user":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"repo":{"id":11125589,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNTU4OQ==","name":"keycloak","full_name":"keycloak/keycloak","private":false,"owner":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keycloak/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":false,"url":"https://api.github.com/repos/keycloak/keycloak","forks_url":"https://api.github.com/repos/keycloak/keycloak/forks","keys_url":"https://api.github.com/repos/keycloak/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keycloak/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keycloak/keycloak/teams","hooks_url":"https://api.github.com/repos/keycloak/keycloak/hooks","issue_events_url":"https://api.github.com/repos/keycloak/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/keycloak/keycloak/events","assignees_url":"https://api.github.com/repos/keycloak/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/keycloak/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/keycloak/keycloak/tags","blobs_url":"https://api.github.com/repos/keycloak/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keycloak/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keycloak/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/keycloak/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keycloak/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/keycloak/keycloak/languages","stargazers_url":"https://api.github.com/repos/keycloak/keycloak/stargazers","contributors_url":"https://api.github.com/repos/keycloak/keycloak/contributors","subscribers_url":"https://api.github.com/repos/keycloak/keycloak/subscribers","subscription_url":"https://api.github.com/repos/keycloak/keycloak/subscription","commits_url":"https://api.github.com/repos/keycloak/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/keycloak/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/keycloak/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/keycloak/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/keycloak/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/keycloak/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keycloak/keycloak/merges","archive_url":"https://api.github.com/repos/keycloak/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keycloak/keycloak/downloads","issues_url":"https://api.github.com/repos/keycloak/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/keycloak/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/keycloak/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/keycloak/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keycloak/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/keycloak/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/keycloak/keycloak/deployments","created_at":"2013-07-02T13:38:51Z","updated_at":"2018-10-12T14:15:46Z","pushed_at":"2018-10-12T13:20:18Z","git_url":"git://github.com/keycloak/keycloak.git","ssh_url":"git@github.com:keycloak/keycloak.git","clone_url":"https://github.com/keycloak/keycloak.git","svn_url":"https://github.com/keycloak/keycloak","homepage":"http://www.keycloak.org","size":126793,"stargazers_count":2900,"watchers_count":2900,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1563,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1563,"open_issues":40,"watchers":2900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5615"},"html":{"href":"https://github.com/keycloak/keycloak/pull/5615"},"issue":{"href":"https://api.github.com/repos/keycloak/keycloak/issues/5615"},"comments":{"href":"https://api.github.com/repos/keycloak/keycloak/issues/5615/comments"},"review_comments":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5615/comments"},"review_comment":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5615/commits"},"statuses":{"href":"https://api.github.com/repos/keycloak/keycloak/statuses/51516abf34b2ebbb22952d94008d82b38dc4eb6c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"unly"}}