{"action":"created","comment":{"url":"https://api.github.com/repos/grafana/grafana-docker/pulls/comments/176791056","pull_request_review_id":106561425,"id":176791056,"diff_hunk":"@@ -43,18 +43,22 @@ More information in the grafana configuration documentation: http://docs.grafana\n ## Grafana container with persistent storage (recommended)\n \n ```\n-# create /var/lib/grafana as persistent volume storage\n-docker run -d -v /var/lib/grafana --name grafana-storage busybox:latest\n+# create a persistent volume for your data in /var/lib/grafana (database and plugins)\n+docker volume create grafana-storage\n \n # start grafana\n docker run \\\n   -d \\\n   -p 3000:3000 \\\n   --name=grafana \\\n-  --volumes-from grafana-storage \\\n+  -v grafana-storage:/var/lib/grafana \\","path":"README.md","position":15,"original_position":15,"commit_id":"ef9f2321890506643dffd89f439023566510e960","original_commit_id":"ef9f2321890506643dffd89f439023566510e960","user":{"login":"Spindel","id":1673446,"avatar_url":"https://avatars3.githubusercontent.com/u/1673446?v=4","gravatar_id":"","url":"https://api.github.com/users/Spindel","html_url":"https://github.com/Spindel","followers_url":"https://api.github.com/users/Spindel/followers","following_url":"https://api.github.com/users/Spindel/following{/other_user}","gists_url":"https://api.github.com/users/Spindel/gists{/gist_id}","starred_url":"https://api.github.com/users/Spindel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spindel/subscriptions","organizations_url":"https://api.github.com/users/Spindel/orgs","repos_url":"https://api.github.com/users/Spindel/repos","events_url":"https://api.github.com/users/Spindel/events{/privacy}","received_events_url":"https://api.github.com/users/Spindel/received_events","type":"User","site_admin":false},"body":"should probably have `:z` as an argument as well, in case of SELinux?","created_at":"2018-03-23T16:29:11Z","updated_at":"2018-03-23T16:32:06Z","html_url":"https://github.com/grafana/grafana-docker/pull/146#discussion_r176791056","pull_request_url":"https://api.github.com/repos/grafana/grafana-docker/pulls/146","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/comments/176791056"},"html":{"href":"https://github.com/grafana/grafana-docker/pull/146#discussion_r176791056"},"pull_request":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/grafana/grafana-docker/pulls/146","id":177056582,"html_url":"https://github.com/grafana/grafana-docker/pull/146","diff_url":"https://github.com/grafana/grafana-docker/pull/146.diff","patch_url":"https://github.com/grafana/grafana-docker/pull/146.patch","issue_url":"https://api.github.com/repos/grafana/grafana-docker/issues/146","number":146,"state":"open","locked":false,"title":"Image improvements","user":{"login":"xlson","id":114937,"avatar_url":"https://avatars1.githubusercontent.com/u/114937?v=4","gravatar_id":"","url":"https://api.github.com/users/xlson","html_url":"https://github.com/xlson","followers_url":"https://api.github.com/users/xlson/followers","following_url":"https://api.github.com/users/xlson/following{/other_user}","gists_url":"https://api.github.com/users/xlson/gists{/gist_id}","starred_url":"https://api.github.com/users/xlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlson/subscriptions","organizations_url":"https://api.github.com/users/xlson/orgs","repos_url":"https://api.github.com/users/xlson/repos","events_url":"https://api.github.com/users/xlson/events{/privacy}","received_events_url":"https://api.github.com/users/xlson/received_events","type":"User","site_admin":false},"body":"*Important:* do not merge before we are ready to release 5.1.\r\n\r\nRe-structured docker image which makes it easier to control what user Grafana runs as, limits default volumes to the data dir (`/var/lib/grafana`) and no longer chowns any folders on startup. The default user has been changed from grafana (id: 104) to nobody (id: 65534) which will cause permission problems if used together with files created in a previous version. The main grafana docs has been updated to help solve these issues. Docs PR here https://github.com/grafana/grafana/pull/11365. \r\n\r\nCloses #141\r\nCloses #140 \r\nCloses #50 \r\nCloses #124 \r\nCloses  #102 \r\n\r\n","created_at":"2018-03-23T12:31:46Z","updated_at":"2018-03-23T16:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85364daf8d71337c891f06e2590c217386c2e8a3","assignee":{"login":"xlson","id":114937,"avatar_url":"https://avatars1.githubusercontent.com/u/114937?v=4","gravatar_id":"","url":"https://api.github.com/users/xlson","html_url":"https://github.com/xlson","followers_url":"https://api.github.com/users/xlson/followers","following_url":"https://api.github.com/users/xlson/following{/other_user}","gists_url":"https://api.github.com/users/xlson/gists{/gist_id}","starred_url":"https://api.github.com/users/xlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlson/subscriptions","organizations_url":"https://api.github.com/users/xlson/orgs","repos_url":"https://api.github.com/users/xlson/repos","events_url":"https://api.github.com/users/xlson/events{/privacy}","received_events_url":"https://api.github.com/users/xlson/received_events","type":"User","site_admin":false},"assignees":[{"login":"xlson","id":114937,"avatar_url":"https://avatars1.githubusercontent.com/u/114937?v=4","gravatar_id":"","url":"https://api.github.com/users/xlson","html_url":"https://github.com/xlson","followers_url":"https://api.github.com/users/xlson/followers","following_url":"https://api.github.com/users/xlson/following{/other_user}","gists_url":"https://api.github.com/users/xlson/gists{/gist_id}","starred_url":"https://api.github.com/users/xlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlson/subscriptions","organizations_url":"https://api.github.com/users/xlson/orgs","repos_url":"https://api.github.com/users/xlson/repos","events_url":"https://api.github.com/users/xlson/events{/privacy}","received_events_url":"https://api.github.com/users/xlson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grafana/grafana-docker/pulls/146/commits","review_comments_url":"https://api.github.com/repos/grafana/grafana-docker/pulls/146/comments","review_comment_url":"https://api.github.com/repos/grafana/grafana-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grafana/grafana-docker/issues/146/comments","statuses_url":"https://api.github.com/repos/grafana/grafana-docker/statuses/ef9f2321890506643dffd89f439023566510e960","head":{"label":"grafana:image-improvements","ref":"image-improvements","sha":"ef9f2321890506643dffd89f439023566510e960","user":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":27180382,"name":"grafana-docker","full_name":"grafana/grafana-docker","owner":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grafana/grafana-docker","description":"Grafana docker container","fork":false,"url":"https://api.github.com/repos/grafana/grafana-docker","forks_url":"https://api.github.com/repos/grafana/grafana-docker/forks","keys_url":"https://api.github.com/repos/grafana/grafana-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana-docker/teams","hooks_url":"https://api.github.com/repos/grafana/grafana-docker/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana-docker/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana-docker/events","assignees_url":"https://api.github.com/repos/grafana/grafana-docker/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana-docker/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana-docker/tags","blobs_url":"https://api.github.com/repos/grafana/grafana-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana-docker/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana-docker/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana-docker/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana-docker/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana-docker/subscription","commits_url":"https://api.github.com/repos/grafana/grafana-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana-docker/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana-docker/merges","archive_url":"https://api.github.com/repos/grafana/grafana-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana-docker/downloads","issues_url":"https://api.github.com/repos/grafana/grafana-docker/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana-docker/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana-docker/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana-docker/deployments","created_at":"2014-11-26T14:25:42Z","updated_at":"2018-03-20T12:31:54Z","pushed_at":"2018-03-23T12:41:01Z","git_url":"git://github.com/grafana/grafana-docker.git","ssh_url":"git@github.com:grafana/grafana-docker.git","clone_url":"https://github.com/grafana/grafana-docker.git","svn_url":"https://github.com/grafana/grafana-docker","homepage":null,"size":78,"stargazers_count":494,"watchers_count":494,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":287,"open_issues":35,"watchers":494,"default_branch":"master"}},"base":{"label":"grafana:master","ref":"master","sha":"ff3a974203616b20c35101c6cf803c2f9c84fe6d","user":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":27180382,"name":"grafana-docker","full_name":"grafana/grafana-docker","owner":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grafana/grafana-docker","description":"Grafana docker container","fork":false,"url":"https://api.github.com/repos/grafana/grafana-docker","forks_url":"https://api.github.com/repos/grafana/grafana-docker/forks","keys_url":"https://api.github.com/repos/grafana/grafana-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana-docker/teams","hooks_url":"https://api.github.com/repos/grafana/grafana-docker/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana-docker/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana-docker/events","assignees_url":"https://api.github.com/repos/grafana/grafana-docker/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana-docker/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana-docker/tags","blobs_url":"https://api.github.com/repos/grafana/grafana-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana-docker/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana-docker/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana-docker/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana-docker/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana-docker/subscription","commits_url":"https://api.github.com/repos/grafana/grafana-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana-docker/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana-docker/merges","archive_url":"https://api.github.com/repos/grafana/grafana-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana-docker/downloads","issues_url":"https://api.github.com/repos/grafana/grafana-docker/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana-docker/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana-docker/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana-docker/deployments","created_at":"2014-11-26T14:25:42Z","updated_at":"2018-03-20T12:31:54Z","pushed_at":"2018-03-23T12:41:01Z","git_url":"git://github.com/grafana/grafana-docker.git","ssh_url":"git@github.com:grafana/grafana-docker.git","clone_url":"https://github.com/grafana/grafana-docker.git","svn_url":"https://github.com/grafana/grafana-docker","homepage":null,"size":78,"stargazers_count":494,"watchers_count":494,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":287,"open_issues":35,"watchers":494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/146"},"html":{"href":"https://github.com/grafana/grafana-docker/pull/146"},"issue":{"href":"https://api.github.com/repos/grafana/grafana-docker/issues/146"},"comments":{"href":"https://api.github.com/repos/grafana/grafana-docker/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grafana/grafana-docker/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/grafana/grafana-docker/statuses/ef9f2321890506643dffd89f439023566510e960"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Spindel"}}