{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/75","repository_url":"https://api.github.com/repos/vaadin/expense-manager-demo","labels_url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/75/comments","events_url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/75/events","html_url":"https://github.com/vaadin/expense-manager-demo/pull/75","id":297774085,"number":75,"title":"Initial replacement of the dialogs","user":{"login":"YuriyVaadin","id":29372419,"avatar_url":"https://avatars2.githubusercontent.com/u/29372419?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriyVaadin","html_url":"https://github.com/YuriyVaadin","followers_url":"https://api.github.com/users/YuriyVaadin/followers","following_url":"https://api.github.com/users/YuriyVaadin/following{/other_user}","gists_url":"https://api.github.com/users/YuriyVaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriyVaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriyVaadin/subscriptions","organizations_url":"https://api.github.com/users/YuriyVaadin/orgs","repos_url":"https://api.github.com/users/YuriyVaadin/repos","events_url":"https://api.github.com/users/YuriyVaadin/events{/privacy}","received_events_url":"https://api.github.com/users/YuriyVaadin/received_events","type":"User","site_admin":false},"labels":[{"id":820062985,"url":"https://api.github.com/repos/vaadin/expense-manager-demo/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-16T12:46:42Z","updated_at":"2018-02-20T09:35:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vaadin/expense-manager-demo/pulls/75","html_url":"https://github.com/vaadin/expense-manager-demo/pull/75","diff_url":"https://github.com/vaadin/expense-manager-demo/pull/75.diff","patch_url":"https://github.com/vaadin/expense-manager-demo/pull/75.patch"},"body":"Initial replacement of the `paper-dialog` with `vaadin-dialog`.\r\nStyling will be discussed later in cosmetic-fixes.\r\n\r\nConnected to #59\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/expense-manager-demo/75)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/comments/366920193","html_url":"https://github.com/vaadin/expense-manager-demo/pull/75#issuecomment-366920193","issue_url":"https://api.github.com/repos/vaadin/expense-manager-demo/issues/75","id":366920193,"user":{"login":"web-padawan","id":10589913,"avatar_url":"https://avatars2.githubusercontent.com/u/10589913?v=4","gravatar_id":"","url":"https://api.github.com/users/web-padawan","html_url":"https://github.com/web-padawan","followers_url":"https://api.github.com/users/web-padawan/followers","following_url":"https://api.github.com/users/web-padawan/following{/other_user}","gists_url":"https://api.github.com/users/web-padawan/gists{/gist_id}","starred_url":"https://api.github.com/users/web-padawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-padawan/subscriptions","organizations_url":"https://api.github.com/users/web-padawan/orgs","repos_url":"https://api.github.com/users/web-padawan/repos","events_url":"https://api.github.com/users/web-padawan/events{/privacy}","received_events_url":"https://api.github.com/users/web-padawan/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T09:35:03Z","updated_at":"2018-02-20T09:35:03Z","author_association":"NONE","body":"\n\n\n\nReviewed 1 of 1 files at r2.\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/expense-editor.html, line 18 at r1](https://beta.reviewable.io/reviews/vaadin/expense-manager-demo/75#-L5TnMjc3DT4mPlxyYSc:-L5mZ4ba9izk0rhtYBi8:b-896fix) ([raw file](https://github.com/vaadin/expense-manager-demo/blob/0f61109b4782d080ea4968af94f236f0fae2d9c6/src/expense-editor.html#L18)):*\n<details><summary><i>Previously, web-padawan (Sergey Kulikov) wrote…</i></summary><blockquote>\n\n` no-cancel-on-esc-key=\"false\"` should be removed, that never worked.\n\nAlso consider using some helper function like `_isEmpty` returning boolean value instead of binding `_expense` to `opened` directly, otherwise you would end up in stuff like this:\n\n```\n<vaadin-dialog-overlay id=\"overlay\" with-backdrop=\"\" focus-trap=\"\" role=\"dialog\" opened=\"{\"id\":\"88e8c66b-2ff4-463c-9735-a4cf12f298a0\",\"date\":\"2018-01-02\",\"merchant\":\"Rental car\",\"total\":573.23,\"status\":\"new\",\"receipt\":\"\",\"comment\":\"Expense from my business trip.\"}\">\n    </vaadin-dialog-overlay>\n```\n\nThat would especially mean that empty object is still true.\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/expense-editor.html, line 267 at r1](https://beta.reviewable.io/reviews/vaadin/expense-manager-demo/75#-L5Tp3tdXxqIkibnJ2lb:-L5mZARLCkYpxkVGpvhm:b-896fix) ([raw file](https://github.com/vaadin/expense-manager-demo/blob/0f61109b4782d080ea4968af94f236f0fae2d9c6/src/expense-editor.html#L267)):*\n<details><summary><i>Previously, web-padawan (Sergey Kulikov) wrote…</i></summary><blockquote>\n\nconsider moving the `this.$.dialog.$.overlay.$.content` code to the utility method, it is used multiple times.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/vaadin/expense-manager-demo/75)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"web-padawan"}}