{"push_id":2430227850,"size":32,"distinct_size":23,"ref":"refs/heads/master","head":"3e417a66072b11902637874394934b6ddb39ea71","before":"da82aab126f706fa7f01a4dc88c01a6b706268b0","commits":[{"sha":"ecfca1ff597f1ee4a6ebdc5a7a076fff444606cf","author":{"name":"Huachao Huang","email":"4bc6b0b1fc382673098f8f635dd5e437acb4a56d@gmail.com"},"message":"Optimize overlap checking for external file ingestion\n\nSummary:\nIf there are a lot of overlapped files in L0, creating a merging iterator for\nall files in L0 to check overlap can be very slow because we need to read and\nseek all files in L0. However, in that case, the ingested file is likely to\noverlap with some files in L0, so if we check those files one by one, we can stop\nonce we encounter overlap.\n\nRef: https://github.com/facebook/rocksdb/issues/3540\nCloses https://github.com/facebook/rocksdb/pull/3564\n\nDifferential Revision: D7196784\n\nPulled By: anand1976\n\nfbshipit-source-id: 8700c1e903bd515d0fa7005b6ce9b3a3d9db2d67","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/ecfca1ff597f1ee4a6ebdc5a7a076fff444606cf"},{"sha":"cc340268e93345ac5dc7630b1c8838fe59a36684","author":{"name":"zhsj","email":"abe5f6d157ef29b8259b1bc8f0ddde73e607895f@gmail.com"},"message":"fix wrong length in snprintf\n\nSummary: Closes https://github.com/facebook/rocksdb/pull/3622\n\nDifferential Revision: D7307689\n\nPulled By: ajkr\n\nfbshipit-source-id: b8f52effc63fea06c2058b39c60944c2c1f814b4","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/cc340268e93345ac5dc7630b1c8838fe59a36684"},{"sha":"bef95be5d8b2486ccf0a83d82a98d6b2d8cc7667","author":{"name":"Adam Retter","email":"1714c04e2f6329bc2d8fbab7e86970f8e23366e4@googlemail.com"},"message":"Improve the output of the RocksJava JUnit runner\n\nSummary:\nThis changes the console output when the RocksJava tests are run. It makes spotting the errors and failures much easier; perviously the output was malformed with results like \"ERun\" where the \"E\" represented an error in the preceding test.\nCloses https://github.com/facebook/rocksdb/pull/3621\n\nDifferential Revision: D7306172\n\nPulled By: sagar0\n\nfbshipit-source-id: 3fa6f6e1ca6c6ea7ceef55a23ca81903716132b7","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/bef95be5d8b2486ccf0a83d82a98d6b2d8cc7667"},{"sha":"1139422dfbdc3cdf290f8b57583563d8c678d559","author":{"name":"Yanqin Jin","email":"aa35deb25749bd156166b7c3fe3f0a183bf69764@devvm29019.prn1.facebook.com"},"message":"Fix the command used to generate ctags\n\nSummary:\nIn original $ROCKSDB_HOME/Makefile, the command used to generate ctags is\n```\nctags * -R\n```\nHowever, this failed to generate tags for me.\nI did some search on the usage of ctags command and found that it should be\n```\nctags -R .\n```\nor\n```\nctags -R *\n```\nAfter the change, I can find the tags in vim using `:ts <identifier>`.\nCloses https://github.com/facebook/rocksdb/pull/3626\n\nReviewed By: ajkr\n\nDifferential Revision: D7320217\n\nPulled By: riversand963\n\nfbshipit-source-id: e4cd8f8a67842370a2343f0213df3cbd07754111","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/1139422dfbdc3cdf290f8b57583563d8c678d559"},{"sha":"ccb761364d04b7c3bfffc8fba6ac66b327e5833b","author":{"name":"Tobias Tschinkowitz","email":"6461f68c5ba25ad6f1731a2759dfd2878a268f76@posteo.de"},"message":"Enable compilation on OpenBSD\n\nSummary:\nI modified the Makefile so that we can compile rocksdb on OpenBSD.\nThe instructions for building have been added to INSTALL.md.\nThe whole compilation process works fine like this on OpenBSD-current\nCloses https://github.com/facebook/rocksdb/pull/3617\n\nDifferential Revision: D7323754\n\nPulled By: siying\n\nfbshipit-source-id: 990037d1cc69138d22f85bd77ef4dc8c1ba9edea","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/ccb761364d04b7c3bfffc8fba6ac66b327e5833b"},{"sha":"d1b26507bd97791437d870665277b55eb9e7ce95","author":{"name":"Andrew Kryczka","email":"2767857978544a72f0f744c149483746f43eec21@fb.com"},"message":"fix db_compaction_test when compression disabled\n\nSummary:\nPreviously, the compaction in `DBCompactionTestWithParam.ForceBottommostLevelCompaction` generated multiple files in no-compression use case, andone file in compression use case. I increased `target_file_size_base` so it generates one file in both use cases.\nCloses https://github.com/facebook/rocksdb/pull/3625\n\nDifferential Revision: D7311885\n\nPulled By: ajkr\n\nfbshipit-source-id: 97f249fa83a9924ac34357a4bb3189c969ecb107","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/d1b26507bd97791437d870665277b55eb9e7ce95"},{"sha":"93d52696bf1fca7db015cc58dc516f1120dca61c","author":{"name":"Siying Dong","email":"08df9db76b309dd2ff2f48dff8ee103d766ed3ff@fb.com"},"message":"Memory Problem Of Destorying ColumnFamilyHandle after deleting the CF\n\nSummary:\nWhen destorying column family handle after the column family has been deleted, the handle may hold share pointers of some objects in ColumnFamilyOptions, but in the destructor, the destructing order may cause some of the objects to be destoryed before being used by the following steps. Fix it by making a copy of the option object and destory it as the last step.\nCloses https://github.com/facebook/rocksdb/pull/3610\n\nDifferential Revision: D7281025\n\nPulled By: siying\n\nfbshipit-source-id: ac18f3b2841788cba4ccfa1abd8d59158c1113bc","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/93d52696bf1fca7db015cc58dc516f1120dca61c"},{"sha":"61785c73ed2be584a3a2a50bc38a4fadeba3596e","author":{"name":"Dmitri Smirnov","email":"a0dd58b2d61ad7967b99c13a18133d55ed4af08d@microsoft.com"},"message":"CloseHandle docs says that the return is non-zero, does not say TRUE(1)\n\nSummary:\nsay it is TRUE(1). Add assert.\nCloses https://github.com/facebook/rocksdb/pull/3630\n\nDifferential Revision: D7346895\n\nPulled By: ajkr\n\nfbshipit-source-id: a46075aa4dd89f32520230606adecccecc874cdf","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/61785c73ed2be584a3a2a50bc38a4fadeba3596e"},{"sha":"6383e423626932b6ce4642e373a984a052042b8b","author":{"name":"Siying Dong","email":"08df9db76b309dd2ff2f48dff8ee103d766ed3ff@fb.com"},"message":"benchmark.sh to use --max_background_job\n\nSummary: Closes https://github.com/facebook/rocksdb/pull/3632\n\nDifferential Revision: D7347012\n\nPulled By: siying\n\nfbshipit-source-id: 46230ec4a917ccf4c478825b07e92b4665a4820b","distinct":false,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/6383e423626932b6ce4642e373a984a052042b8b"},{"sha":"8823487ff79d46a6123f52bad28eb7a3c319624d","author":{"name":"Jingguo Yao","email":"a7a4724448aa9c7c9f31ddb4cfed8887abc950bf@gmail.com"},"message":"doc: fix a typo\n\nSummary:\ns/synchromization/synchronization/\nCloses https://github.com/facebook/rocksdb/pull/3583\n\nDifferential Revision: D7276596\n\nPulled By: sagar0\n\nfbshipit-source-id: 552ec6d6935f642e1a3a7c552de6c94441ac50e0","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/8823487ff79d46a6123f52bad28eb7a3c319624d"},{"sha":"f1b7b790c9828c466bc3cb217de3e0e30c4da90b","author":{"name":"Yi Wu","email":"48a66ef5496d60eb19f1394caf868c10e2fb1acc@fb.com"},"message":"BlobDB: Fix BlobDBImpl::GCFileAndUpdateLSM issues\n\nSummary:\n* Fix BlobDBImpl::GCFileAndUpdateLSM doesn't close the new file, and the new file will not be able to be garbage collected later.\n* Fix BlobDBImpl::GCFileAndUpdateLSM doesn't copy over metadata from old file to new file.\nCloses https://github.com/facebook/rocksdb/pull/3639\n\nDifferential Revision: D7355092\n\nPulled By: yiwu-arbug\n\nfbshipit-source-id: 4fa3594ac5ce376bed1af04a545c532cfc0088c4","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/f1b7b790c9828c466bc3cb217de3e0e30c4da90b"},{"sha":"d5585bb605824e33a47359714b04b7bf14c0a2f6","author":{"name":"Sagar Vemuri","email":"a88052e63a10b8355704b4b45d2cf40cba2ee75c@fb.com"},"message":"Shared block cache in RocksJava\n\nSummary:\nChanges to support sharing block cache using the Java API.\n\nPreviously DB instances could share the block cache only when the same Options instance is passed to all the DB instances. But now, with this change, it is possible to explicitly create a cache and pass it to multiple options instances, to share the block cache.\n\nImplementing this for [Rocksandra](https://github.com/instagram/cassandra/tree/rocks_3.0), but this feature has been requested by many java api users over the years.\nCloses https://github.com/facebook/rocksdb/pull/3623\n\nDifferential Revision: D7305794\n\nPulled By: sagar0\n\nfbshipit-source-id: 03e4e8ed7aeee6f88bada4a8365d4279ede2ad71","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/d5585bb605824e33a47359714b04b7bf14c0a2f6"},{"sha":"2ce8f63f81850851912f45fcb5040259fa96ca8e","author":{"name":"QingpingWang","email":"78fd6950a135ffad3feca61de393e32b108e9c27@gmail.com"},"message":"C API for PerfContext\n\nSummary:\nThis pull request exposes the interface of PerfContext as C API\nCloses https://github.com/facebook/rocksdb/pull/3607\n\nDifferential Revision: D7294225\n\nPulled By: ajkr\n\nfbshipit-source-id: eddcfbc13538f379950b2c8b299486695ffb5e2c","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/2ce8f63f81850851912f45fcb5040259fa96ca8e"},{"sha":"70282cf876597ae2d51bf9838dccd2b214448c02","author":{"name":"QingpingWang","email":"78fd6950a135ffad3feca61de393e32b108e9c27@gmail.com"},"message":"fix behavior does not match name for \"IsFileDeletionsEnabled\"\n\nSummary:\nfor PR https://github.com/facebook/rocksdb/pull/3598\nI deleted the original repo for some reason. Sorry for the inconvenience.\nCloses https://github.com/facebook/rocksdb/pull/3612\n\nDifferential Revision: D7291671\n\nPulled By: ajkr\n\nfbshipit-source-id: 918490ba86b13fe450d232af436cbe259d847c64","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/70282cf876597ae2d51bf9838dccd2b214448c02"},{"sha":"7a6353bd1c516fe3f7118248c77035697c5ac247","author":{"name":"Huachao Huang","email":"4bc6b0b1fc382673098f8f635dd5e437acb4a56d@gmail.com"},"message":"Ignore empty filter block when data block is empty\n\nSummary:\nClose https://github.com/facebook/rocksdb/issues/3592\nCloses https://github.com/facebook/rocksdb/pull/3614\n\nDifferential Revision: D7291706\n\nPulled By: ajkr\n\nfbshipit-source-id: 9dd8f40bd7716588e1e3fd6be0c2bc2766861f8c","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/7a6353bd1c516fe3f7118248c77035697c5ac247"},{"sha":"fa8c050e9ff2fa2e25e3620798f0d60c3c72157e","author":{"name":"Rohan Rathi","email":"5bbdd5d6ee3da0c1e6895bac7efbf72e1e9f36d0@gmail.com"},"message":"Fixed buffer overrun in BackupEngineImpl::BackupMeta::StoreToFile\n\nSummary:\nThe 10MB buffer in BackupEngineImpl::BackupMeta::StoreToFile can be corrupted with a large number of files. Added a check to determine current buffer length and append data to file if buffer becomes full.\n\nResolves https://github.com/facebook/rocksdb/issues/3228\nCloses https://github.com/facebook/rocksdb/pull/3636\n\nDifferential Revision: D7354160\n\nPulled By: ajkr\n\nfbshipit-source-id: eec12d38095a0d17551a4aaee52b99d30a555722","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/fa8c050e9ff2fa2e25e3620798f0d60c3c72157e"},{"sha":"7429b20e3901e0bcc7e028b37536a262cf11a448","author":{"name":"Maysam Yabandeh","email":"d798bb0d8853f6b4de736c59eb5ace353daef67e@fb.com"},"message":"WritePrepared Txn: fix race condition on publishing seq\n\nSummary:\nThis commit fixes a race condition on calling SetLastPublishedSequence. The function must be called only from the 2nd write queue when two_write_queues is enabled. However there was a bug that would also call it from the main write queue if CommitTimeWriteBatch is provided to the commit request and yet use_only_the_last_commit_time_batch_for_recovery optimization is not enabled. To fix that we penalize the commit request in such cases by doing an additional write solely to publish the seq number from the 2nd queue.\nCloses https://github.com/facebook/rocksdb/pull/3641\n\nDifferential Revision: D7361508\n\nPulled By: maysamyabandeh\n\nfbshipit-source-id: bf8f7a27e5cccf5425dccbce25eb0032e8e5a4d7","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/7429b20e3901e0bcc7e028b37536a262cf11a448"},{"sha":"de6cf95a5383b833c08d88ddb27a5ab125da1634","author":{"name":"Fosco Marotto","email":"9303d6a70107b3e96bbaf753a10d3d61acb636db@gmail.com"},"message":"Update history for future 5.13 release\n\nSummary: Closes https://github.com/facebook/rocksdb/pull/3631\n\nDifferential Revision: D7367519\n\nPulled By: gfosco\n\nfbshipit-source-id: 57826cc1c9ffc9f2b351075567b8ad929809cb74","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/de6cf95a5383b833c08d88ddb27a5ab125da1634"},{"sha":"620823f88b8402f99087420a805fc1eab0256d9e","author":{"name":"Andrew Kryczka","email":"2767857978544a72f0f744c149483746f43eec21@fb.com"},"message":"parse CompressionOptions::zstd_max_train_bytes in options string\n\nSummary: Closes https://github.com/facebook/rocksdb/pull/3588\n\nDifferential Revision: D7208087\n\nPulled By: ajkr\n\nfbshipit-source-id: 688f7a7c447cb17bee1b410d1fd891c0bf966617","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/620823f88b8402f99087420a805fc1eab0256d9e"},{"sha":"88c3e26cc05a9b87f7485f8828ce608487e81b91","author":{"name":"Andrew Kryczka","email":"2767857978544a72f0f744c149483746f43eec21@fb.com"},"message":"log value of CompressionOptions::zstd_max_train_bytes\n\nSummary: Closes https://github.com/facebook/rocksdb/pull/3587\n\nDifferential Revision: D7206901\n\nPulled By: ajkr\n\nfbshipit-source-id: 5d4b1a2653627b44aa3c22db7d98c9cd5dcdb67a","distinct":true,"url":"https://api.github.com/repos/adamretter/rocksdb/commits/88c3e26cc05a9b87f7485f8828ce608487e81b91"}]}
{"actor":{"display_login":"adamretter"}}