{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13","id":236641253,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NjQxMjUz","html_url":"https://github.com/WGBH-MLA/pbcore/pull/13","diff_url":"https://github.com/WGBH-MLA/pbcore/pull/13.diff","patch_url":"https://github.com/WGBH-MLA/pbcore/pull/13.patch","issue_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/13","number":13,"state":"closed","locked":false,"title":"Adds support for PBCore::InstantiationDocument","user":{"login":"afred","id":1507490,"node_id":"MDQ6VXNlcjE1MDc0OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1507490?v=4","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"body":"The <pbcoreInstantiationDocument> element is basically the same as a\r\n<pbcoreInstantiation> element, only it comprises the entire XML document.\r\n\r\nThis PR adds the PBCore::InstantiationDocument model, a spec that checks for\r\nparsed attributes and children, and also builds out the spec for\r\nPBCore::Instantiation to be much the same.\r\n\r\nAlso,\r\n* Adds logic to add the time attributes (i.e. startTime, endTime, and\r\n  timeAnnotation) to the xml_attributes_hash used to build the XML output.\r\n  Because of how SAXMachine forces us to declare these attributes (i.e. using\r\n  the `element` class method instead of the `attribute` class method) these\r\n  attributes are not getting discovered by the #attributes method.\r\n\r\n  This is a bit of a hack, and it would be a lot better if we could figure out\r\n  a more elegant way to treat the time attributes.\r\n* Fixes broken build_xml block for PBCore::Instantiation::TimeStart element.\r\n* Better message on failure of have_parsed_xml_attribute_values matcher.\r\n* Fixes broken spec for PBCore::Extension::Wrap.","created_at":"2018-12-06T19:16:22Z","updated_at":"2018-12-12T18:54:50Z","closed_at":"2018-12-12T18:54:50Z","merged_at":"2018-12-12T18:54:50Z","merge_commit_sha":"d7928719a82c93bfb29f7ff9506e33c180e1b2d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13/commits","review_comments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13/comments","review_comment_url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/13/comments","statuses_url":"https://api.github.com/repos/WGBH-MLA/pbcore/statuses/485030b3ff90e8079ca92fd73506a3c59a6f92e0","head":{"label":"WGBH-MLA:instantiation_document","ref":"instantiation_document","sha":"485030b3ff90e8079ca92fd73506a3c59a6f92e0","user":{"login":"WGBH-MLA","id":36052312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUyMzEy","avatar_url":"https://avatars1.githubusercontent.com/u/36052312?v=4","gravatar_id":"","url":"https://api.github.com/users/WGBH-MLA","html_url":"https://github.com/WGBH-MLA","followers_url":"https://api.github.com/users/WGBH-MLA/followers","following_url":"https://api.github.com/users/WGBH-MLA/following{/other_user}","gists_url":"https://api.github.com/users/WGBH-MLA/gists{/gist_id}","starred_url":"https://api.github.com/users/WGBH-MLA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WGBH-MLA/subscriptions","organizations_url":"https://api.github.com/users/WGBH-MLA/orgs","repos_url":"https://api.github.com/users/WGBH-MLA/repos","events_url":"https://api.github.com/users/WGBH-MLA/events{/privacy}","received_events_url":"https://api.github.com/users/WGBH-MLA/received_events","type":"Organization","site_admin":false},"repo":{"id":159440403,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0NDA0MDM=","name":"pbcore","full_name":"WGBH-MLA/pbcore","private":false,"owner":{"login":"WGBH-MLA","id":36052312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUyMzEy","avatar_url":"https://avatars1.githubusercontent.com/u/36052312?v=4","gravatar_id":"","url":"https://api.github.com/users/WGBH-MLA","html_url":"https://github.com/WGBH-MLA","followers_url":"https://api.github.com/users/WGBH-MLA/followers","following_url":"https://api.github.com/users/WGBH-MLA/following{/other_user}","gists_url":"https://api.github.com/users/WGBH-MLA/gists{/gist_id}","starred_url":"https://api.github.com/users/WGBH-MLA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WGBH-MLA/subscriptions","organizations_url":"https://api.github.com/users/WGBH-MLA/orgs","repos_url":"https://api.github.com/users/WGBH-MLA/repos","events_url":"https://api.github.com/users/WGBH-MLA/events{/privacy}","received_events_url":"https://api.github.com/users/WGBH-MLA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WGBH-MLA/pbcore","description":"PBCore model in Ruby","fork":false,"url":"https://api.github.com/repos/WGBH-MLA/pbcore","forks_url":"https://api.github.com/repos/WGBH-MLA/pbcore/forks","keys_url":"https://api.github.com/repos/WGBH-MLA/pbcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WGBH-MLA/pbcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WGBH-MLA/pbcore/teams","hooks_url":"https://api.github.com/repos/WGBH-MLA/pbcore/hooks","issue_events_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/events{/number}","events_url":"https://api.github.com/repos/WGBH-MLA/pbcore/events","assignees_url":"https://api.github.com/repos/WGBH-MLA/pbcore/assignees{/user}","branches_url":"https://api.github.com/repos/WGBH-MLA/pbcore/branches{/branch}","tags_url":"https://api.github.com/repos/WGBH-MLA/pbcore/tags","blobs_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WGBH-MLA/pbcore/statuses/{sha}","languages_url":"https://api.github.com/repos/WGBH-MLA/pbcore/languages","stargazers_url":"https://api.github.com/repos/WGBH-MLA/pbcore/stargazers","contributors_url":"https://api.github.com/repos/WGBH-MLA/pbcore/contributors","subscribers_url":"https://api.github.com/repos/WGBH-MLA/pbcore/subscribers","subscription_url":"https://api.github.com/repos/WGBH-MLA/pbcore/subscription","commits_url":"https://api.github.com/repos/WGBH-MLA/pbcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/WGBH-MLA/pbcore/contents/{+path}","compare_url":"https://api.github.com/repos/WGBH-MLA/pbcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WGBH-MLA/pbcore/merges","archive_url":"https://api.github.com/repos/WGBH-MLA/pbcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WGBH-MLA/pbcore/downloads","issues_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues{/number}","pulls_url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls{/number}","milestones_url":"https://api.github.com/repos/WGBH-MLA/pbcore/milestones{/number}","notifications_url":"https://api.github.com/repos/WGBH-MLA/pbcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WGBH-MLA/pbcore/labels{/name}","releases_url":"https://api.github.com/repos/WGBH-MLA/pbcore/releases{/id}","deployments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/deployments","created_at":"2018-11-28T03:51:45Z","updated_at":"2018-12-06T19:00:26Z","pushed_at":"2018-12-12T18:54:50Z","git_url":"git://github.com/WGBH-MLA/pbcore.git","ssh_url":"git@github.com:WGBH-MLA/pbcore.git","clone_url":"https://github.com/WGBH-MLA/pbcore.git","svn_url":"https://github.com/WGBH-MLA/pbcore","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"WGBH-MLA:master","ref":"master","sha":"9f608f301284acf2ba1818bf08ff420239af7417","user":{"login":"WGBH-MLA","id":36052312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUyMzEy","avatar_url":"https://avatars1.githubusercontent.com/u/36052312?v=4","gravatar_id":"","url":"https://api.github.com/users/WGBH-MLA","html_url":"https://github.com/WGBH-MLA","followers_url":"https://api.github.com/users/WGBH-MLA/followers","following_url":"https://api.github.com/users/WGBH-MLA/following{/other_user}","gists_url":"https://api.github.com/users/WGBH-MLA/gists{/gist_id}","starred_url":"https://api.github.com/users/WGBH-MLA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WGBH-MLA/subscriptions","organizations_url":"https://api.github.com/users/WGBH-MLA/orgs","repos_url":"https://api.github.com/users/WGBH-MLA/repos","events_url":"https://api.github.com/users/WGBH-MLA/events{/privacy}","received_events_url":"https://api.github.com/users/WGBH-MLA/received_events","type":"Organization","site_admin":false},"repo":{"id":159440403,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0NDA0MDM=","name":"pbcore","full_name":"WGBH-MLA/pbcore","private":false,"owner":{"login":"WGBH-MLA","id":36052312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUyMzEy","avatar_url":"https://avatars1.githubusercontent.com/u/36052312?v=4","gravatar_id":"","url":"https://api.github.com/users/WGBH-MLA","html_url":"https://github.com/WGBH-MLA","followers_url":"https://api.github.com/users/WGBH-MLA/followers","following_url":"https://api.github.com/users/WGBH-MLA/following{/other_user}","gists_url":"https://api.github.com/users/WGBH-MLA/gists{/gist_id}","starred_url":"https://api.github.com/users/WGBH-MLA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WGBH-MLA/subscriptions","organizations_url":"https://api.github.com/users/WGBH-MLA/orgs","repos_url":"https://api.github.com/users/WGBH-MLA/repos","events_url":"https://api.github.com/users/WGBH-MLA/events{/privacy}","received_events_url":"https://api.github.com/users/WGBH-MLA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WGBH-MLA/pbcore","description":"PBCore model in Ruby","fork":false,"url":"https://api.github.com/repos/WGBH-MLA/pbcore","forks_url":"https://api.github.com/repos/WGBH-MLA/pbcore/forks","keys_url":"https://api.github.com/repos/WGBH-MLA/pbcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WGBH-MLA/pbcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WGBH-MLA/pbcore/teams","hooks_url":"https://api.github.com/repos/WGBH-MLA/pbcore/hooks","issue_events_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/events{/number}","events_url":"https://api.github.com/repos/WGBH-MLA/pbcore/events","assignees_url":"https://api.github.com/repos/WGBH-MLA/pbcore/assignees{/user}","branches_url":"https://api.github.com/repos/WGBH-MLA/pbcore/branches{/branch}","tags_url":"https://api.github.com/repos/WGBH-MLA/pbcore/tags","blobs_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WGBH-MLA/pbcore/statuses/{sha}","languages_url":"https://api.github.com/repos/WGBH-MLA/pbcore/languages","stargazers_url":"https://api.github.com/repos/WGBH-MLA/pbcore/stargazers","contributors_url":"https://api.github.com/repos/WGBH-MLA/pbcore/contributors","subscribers_url":"https://api.github.com/repos/WGBH-MLA/pbcore/subscribers","subscription_url":"https://api.github.com/repos/WGBH-MLA/pbcore/subscription","commits_url":"https://api.github.com/repos/WGBH-MLA/pbcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/WGBH-MLA/pbcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/WGBH-MLA/pbcore/contents/{+path}","compare_url":"https://api.github.com/repos/WGBH-MLA/pbcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WGBH-MLA/pbcore/merges","archive_url":"https://api.github.com/repos/WGBH-MLA/pbcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WGBH-MLA/pbcore/downloads","issues_url":"https://api.github.com/repos/WGBH-MLA/pbcore/issues{/number}","pulls_url":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls{/number}","milestones_url":"https://api.github.com/repos/WGBH-MLA/pbcore/milestones{/number}","notifications_url":"https://api.github.com/repos/WGBH-MLA/pbcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WGBH-MLA/pbcore/labels{/name}","releases_url":"https://api.github.com/repos/WGBH-MLA/pbcore/releases{/id}","deployments_url":"https://api.github.com/repos/WGBH-MLA/pbcore/deployments","created_at":"2018-11-28T03:51:45Z","updated_at":"2018-12-06T19:00:26Z","pushed_at":"2018-12-12T18:54:50Z","git_url":"git://github.com/WGBH-MLA/pbcore.git","ssh_url":"git@github.com:WGBH-MLA/pbcore.git","clone_url":"https://github.com/WGBH-MLA/pbcore.git","svn_url":"https://github.com/WGBH-MLA/pbcore","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13"},"html":{"href":"https://github.com/WGBH-MLA/pbcore/pull/13"},"issue":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/13"},"comments":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/WGBH-MLA/pbcore/statuses/485030b3ff90e8079ca92fd73506a3c59a6f92e0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jasoncorum","id":3814190,"node_id":"MDQ6VXNlcjM4MTQxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3814190?v=4","gravatar_id":"","url":"https://api.github.com/users/jasoncorum","html_url":"https://github.com/jasoncorum","followers_url":"https://api.github.com/users/jasoncorum/followers","following_url":"https://api.github.com/users/jasoncorum/following{/other_user}","gists_url":"https://api.github.com/users/jasoncorum/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncorum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncorum/subscriptions","organizations_url":"https://api.github.com/users/jasoncorum/orgs","repos_url":"https://api.github.com/users/jasoncorum/repos","events_url":"https://api.github.com/users/jasoncorum/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncorum/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":294,"deletions":39,"changed_files":12}}
{"actor":{"display_login":"jasoncorum"}}