{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/176766228","pull_request_review_id":106531966,"id":176766228,"diff_hunk":"@@ -943,7 +869,7 @@ def find_peaks(x, height=None, threshold=None, distance=None,\n     >>> plt.show()\n     \"\"\"\n     # _argmaxima1d expects array of dtype 'float64'\n-    x = np.asarray(x, dtype=np.float64)\n+    x = np.asarray(x, order=\"C\", dtype=np.float64)","path":"scipy/signal/_peak_finding.py","position":104,"original_position":104,"commit_id":"e09efb80cc8beb0fd681d282a969bf79065cd3c6","original_commit_id":"e09efb80cc8beb0fd681d282a969bf79065cd3c6","user":{"login":"lagru","id":20140352,"avatar_url":"https://avatars3.githubusercontent.com/u/20140352?v=4","gravatar_id":"","url":"https://api.github.com/users/lagru","html_url":"https://github.com/lagru","followers_url":"https://api.github.com/users/lagru/followers","following_url":"https://api.github.com/users/lagru/following{/other_user}","gists_url":"https://api.github.com/users/lagru/gists{/gist_id}","starred_url":"https://api.github.com/users/lagru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagru/subscriptions","organizations_url":"https://api.github.com/users/lagru/orgs","repos_url":"https://api.github.com/users/lagru/repos","events_url":"https://api.github.com/users/lagru/events{/privacy}","received_events_url":"https://api.github.com/users/lagru/received_events","type":"User","site_admin":false},"body":"As mentioned in the commit message:\r\n> Ensure that x is C-contiguous. This way it doesn't need to get  converted twice for prominence and width calculation. Later this might  prove useful if the input of `_argmaxima1d` is declared as C-contiguous.\r\n\r\nBut I can revert this and introduce it once `_argmaxima1d` actually requires C-contiguous arrays. Your call.","created_at":"2018-03-23T15:11:16Z","updated_at":"2018-03-23T15:11:16Z","html_url":"https://github.com/scipy/scipy/pull/8523#discussion_r176766228","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/8523","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/176766228"},"html":{"href":"https://github.com/scipy/scipy/pull/8523#discussion_r176766228"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8523"}},"in_reply_to_id":176740590},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/8523","id":172953964,"html_url":"https://github.com/scipy/scipy/pull/8523","diff_url":"https://github.com/scipy/scipy/pull/8523.diff","patch_url":"https://github.com/scipy/scipy/pull/8523.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/8523","number":8523,"state":"open","locked":false,"title":"ENH: Speed-up peak distance filtering with Cython","user":{"login":"lagru","id":20140352,"avatar_url":"https://avatars3.githubusercontent.com/u/20140352?v=4","gravatar_id":"","url":"https://api.github.com/users/lagru","html_url":"https://github.com/lagru","followers_url":"https://api.github.com/users/lagru/followers","following_url":"https://api.github.com/users/lagru/following{/other_user}","gists_url":"https://api.github.com/users/lagru/gists{/gist_id}","starred_url":"https://api.github.com/users/lagru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagru/subscriptions","organizations_url":"https://api.github.com/users/lagru/orgs","repos_url":"https://api.github.com/users/lagru/repos","events_url":"https://api.github.com/users/lagru/events{/privacy}","received_events_url":"https://api.github.com/users/lagru/received_events","type":"User","site_admin":false},"body":"This replaces the function `_select_by_peak_distance` introduced with #8264 with a faster Cython version. \r\nI've provided a short and naive performance comparison between the old and proposed function [here](http://nbviewer.jupyter.org/urls/gist.githubusercontent.com/lagru/0cc494385c12bd7f21b9477a13c79329/raw/d8e37db5827a6e0f39962139f6790bf5e84c9099/eval_select_by_peak_distance.ipynb).","created_at":"2018-03-05T18:52:14Z","updated_at":"2018-03-23T15:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f001fc7b0a5b279ada11dac1de369d5721bad461","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37340735,"url":"https://api.github.com/repos/scipy/scipy/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true},{"id":37342572,"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.signal","name":"scipy.signal","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/8523/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/8523/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/8523/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/e09efb80cc8beb0fd681d282a969bf79065cd3c6","head":{"label":"lagru:cy-peak-distance","ref":"cy-peak-distance","sha":"e09efb80cc8beb0fd681d282a969bf79065cd3c6","user":{"login":"lagru","id":20140352,"avatar_url":"https://avatars3.githubusercontent.com/u/20140352?v=4","gravatar_id":"","url":"https://api.github.com/users/lagru","html_url":"https://github.com/lagru","followers_url":"https://api.github.com/users/lagru/followers","following_url":"https://api.github.com/users/lagru/following{/other_user}","gists_url":"https://api.github.com/users/lagru/gists{/gist_id}","starred_url":"https://api.github.com/users/lagru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagru/subscriptions","organizations_url":"https://api.github.com/users/lagru/orgs","repos_url":"https://api.github.com/users/lagru/repos","events_url":"https://api.github.com/users/lagru/events{/privacy}","received_events_url":"https://api.github.com/users/lagru/received_events","type":"User","site_admin":false},"repo":{"id":115860985,"name":"scipy","full_name":"lagru/scipy","owner":{"login":"lagru","id":20140352,"avatar_url":"https://avatars3.githubusercontent.com/u/20140352?v=4","gravatar_id":"","url":"https://api.github.com/users/lagru","html_url":"https://github.com/lagru","followers_url":"https://api.github.com/users/lagru/followers","following_url":"https://api.github.com/users/lagru/following{/other_user}","gists_url":"https://api.github.com/users/lagru/gists{/gist_id}","starred_url":"https://api.github.com/users/lagru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagru/subscriptions","organizations_url":"https://api.github.com/users/lagru/orgs","repos_url":"https://api.github.com/users/lagru/repos","events_url":"https://api.github.com/users/lagru/events{/privacy}","received_events_url":"https://api.github.com/users/lagru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lagru/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/lagru/scipy","forks_url":"https://api.github.com/repos/lagru/scipy/forks","keys_url":"https://api.github.com/repos/lagru/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagru/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagru/scipy/teams","hooks_url":"https://api.github.com/repos/lagru/scipy/hooks","issue_events_url":"https://api.github.com/repos/lagru/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/lagru/scipy/events","assignees_url":"https://api.github.com/repos/lagru/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/lagru/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/lagru/scipy/tags","blobs_url":"https://api.github.com/repos/lagru/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagru/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagru/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagru/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagru/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/lagru/scipy/languages","stargazers_url":"https://api.github.com/repos/lagru/scipy/stargazers","contributors_url":"https://api.github.com/repos/lagru/scipy/contributors","subscribers_url":"https://api.github.com/repos/lagru/scipy/subscribers","subscription_url":"https://api.github.com/repos/lagru/scipy/subscription","commits_url":"https://api.github.com/repos/lagru/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagru/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagru/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagru/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagru/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/lagru/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagru/scipy/merges","archive_url":"https://api.github.com/repos/lagru/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagru/scipy/downloads","issues_url":"https://api.github.com/repos/lagru/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/lagru/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/lagru/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/lagru/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagru/scipy/labels{/name}","releases_url":"https://api.github.com/repos/lagru/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/lagru/scipy/deployments","created_at":"2017-12-31T12:10:57Z","updated_at":"2018-03-22T21:37:25Z","pushed_at":"2018-03-22T21:37:23Z","git_url":"git://github.com/lagru/scipy.git","ssh_url":"git@github.com:lagru/scipy.git","clone_url":"https://github.com/lagru/scipy.git","svn_url":"https://github.com/lagru/scipy","homepage":"http://scipy.org/scipylib/","size":76872,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"c10dc215339f99ade86267f519ff8b7726141821","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-03-23T14:05:44Z","pushed_at":"2018-03-23T14:33:28Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":78903,"stargazers_count":4232,"watchers_count":4232,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2232,"mirror_url":null,"archived":false,"open_issues_count":1227,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2232,"open_issues":1227,"watchers":4232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8523"},"html":{"href":"https://github.com/scipy/scipy/pull/8523"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/8523"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/8523/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8523/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8523/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/e09efb80cc8beb0fd681d282a969bf79065cd3c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lagru"}}