{"action":"created","issue":{"url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4015","repository_url":"https://api.github.com/repos/endless-sky/endless-sky","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4015/labels{/name}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4015/comments","events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4015/events","html_url":"https://github.com/endless-sky/endless-sky/pull/4015","id":382375201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDk3ODgw","number":4015,"title":"Orbital Defense Stations","user":{"login":"IntegratedQuantum","id":43880493,"node_id":"MDQ6VXNlcjQzODgwNDkz","avatar_url":"https://avatars1.githubusercontent.com/u/43880493?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedQuantum","html_url":"https://github.com/IntegratedQuantum","followers_url":"https://api.github.com/users/IntegratedQuantum/followers","following_url":"https://api.github.com/users/IntegratedQuantum/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedQuantum/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedQuantum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedQuantum/subscriptions","organizations_url":"https://api.github.com/users/IntegratedQuantum/orgs","repos_url":"https://api.github.com/users/IntegratedQuantum/repos","events_url":"https://api.github.com/users/IntegratedQuantum/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedQuantum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-19T20:12:52Z","updated_at":"2018-11-22T14:47:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4015","html_url":"https://github.com/endless-sky/endless-sky/pull/4015","diff_url":"https://github.com/endless-sky/endless-sky/pull/4015.diff","patch_url":"https://github.com/endless-sky/endless-sky/pull/4015.patch"},"body":"This will add ships which are in orbit of a planet. They will only be able to turn and shoot. They will be infinitly heavy so they won't move. If the ship is destroyed there will be a static sprite in the background. The defense stations automatically spawn when the system is entered and they can be seen in the map(they currently are no different to moons. Maybe I'll add a different color later).\r\n\r\nI just have one tiny problem I need help with. I don't know why, but the ships I create via StellarObject always get removed(they are successfully added before) from the newShips list."},"comment":{"url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments/441051860","html_url":"https://github.com/endless-sky/endless-sky/pull/4015#issuecomment-441051860","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4015","id":441051860,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTA1MTg2MA==","user":{"login":"IntegratedQuantum","id":43880493,"node_id":"MDQ6VXNlcjQzODgwNDkz","avatar_url":"https://avatars1.githubusercontent.com/u/43880493?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedQuantum","html_url":"https://github.com/IntegratedQuantum","followers_url":"https://api.github.com/users/IntegratedQuantum/followers","following_url":"https://api.github.com/users/IntegratedQuantum/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedQuantum/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedQuantum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedQuantum/subscriptions","organizations_url":"https://api.github.com/users/IntegratedQuantum/orgs","repos_url":"https://api.github.com/users/IntegratedQuantum/repos","events_url":"https://api.github.com/users/IntegratedQuantum/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedQuantum/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T14:47:26Z","updated_at":"2018-11-22T14:47:26Z","author_association":"NONE","body":"It seems like I made myself unclear.\r\nAt a specific position(defined by a `StellarObject`) in a system there will always spawn a specific ship if the player enters the system.\r\nThis ship has the same properties as any other ship(boardable, targetable, ...) except their velocity will always be zero(I might change that to a basic circular orbit) and nothing can push the ship from a specific position.\r\nThey can still turn so their mass seems only infinite when observing its inertia when pushing it with the explosion of a missile or the momentum of a projectile.\r\nYou can board it(if not specified otherwise in data), but it would be unreasonable to make them capturable without adding new mechanics that would fix them in orbit and make them unable to land/jump/... (otherwise it would be a too easy way of farming ships).\r\n\r\nOnly after the ship was **destroyed** there would be the static background sprite showing a destroyed version of the ship, since such a big station wouldn't just _vanish_ in a big explosion. It is build so that it can defend a system for a longer time period than the live of a single ship."}}
{"actor":{"display_login":"IntegratedQuantum"}}