{"action":"created","comment":{"url":"https://api.github.com/repos/mikel/mail/pulls/comments/219591162","pull_request_review_id":157811734,"id":219591162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTU5MTE2Mg==","diff_hunk":"@@ -37,7 +37,9 @@ def info\n     end\n \n     def formatted_date\n-      date_time.strftime(\"%a, %d %b %Y %H:%M:%S \") + date_time.zone.delete(':')\n+      if date_time.respond_to? :strftime and date_time.respond_to? :zone\n+        date_time.strftime(\"%a, %d %b %Y %H:%M:%S \") + date_time.zone.delete(':')\n+      end","path":"lib/mail/fields/received_field.rb","position":7,"original_position":7,"commit_id":"ce905c2b0cc59aab987131a3c8f955df1d8e2122","original_commit_id":"ce905c2b0cc59aab987131a3c8f955df1d8e2122","user":{"login":"jeremy","id":199,"node_id":"MDQ6VXNlcjE5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/199?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"body":"Let's add a test case that demonstrates that `#formatted_date` is `nil` for an invalid field 👍","created_at":"2018-09-21T18:35:36Z","updated_at":"2018-09-21T18:35:36Z","html_url":"https://github.com/mikel/mail/pull/1272#discussion_r219591162","pull_request_url":"https://api.github.com/repos/mikel/mail/pulls/1272","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mikel/mail/pulls/comments/219591162"},"html":{"href":"https://github.com/mikel/mail/pull/1272#discussion_r219591162"},"pull_request":{"href":"https://api.github.com/repos/mikel/mail/pulls/1272"}}},"pull_request":{"url":"https://api.github.com/repos/mikel/mail/pulls/1272","id":217240864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjQwODY0","html_url":"https://github.com/mikel/mail/pull/1272","diff_url":"https://github.com/mikel/mail/pull/1272.diff","patch_url":"https://github.com/mikel/mail/pull/1272.patch","issue_url":"https://api.github.com/repos/mikel/mail/issues/1272","number":1272,"state":"open","locked":false,"title":"Prevent unhandled NoMethodError when date_time in ReceivedField is invalid","user":{"login":"zelivans","id":15815884,"node_id":"MDQ6VXNlcjE1ODE1ODg0","avatar_url":"https://avatars0.githubusercontent.com/u/15815884?v=4","gravatar_id":"","url":"https://api.github.com/users/zelivans","html_url":"https://github.com/zelivans","followers_url":"https://api.github.com/users/zelivans/followers","following_url":"https://api.github.com/users/zelivans/following{/other_user}","gists_url":"https://api.github.com/users/zelivans/gists{/gist_id}","starred_url":"https://api.github.com/users/zelivans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelivans/subscriptions","organizations_url":"https://api.github.com/users/zelivans/orgs","repos_url":"https://api.github.com/users/zelivans/repos","events_url":"https://api.github.com/users/zelivans/events{/privacy}","received_events_url":"https://api.github.com/users/zelivans/received_events","type":"User","site_admin":false},"body":"Fixes #1271","created_at":"2018-09-21T10:32:28Z","updated_at":"2018-09-21T18:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63605604ff239c9ee4dd9899c0b1b54b2afc732e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mikel/mail/pulls/1272/commits","review_comments_url":"https://api.github.com/repos/mikel/mail/pulls/1272/comments","review_comment_url":"https://api.github.com/repos/mikel/mail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mikel/mail/issues/1272/comments","statuses_url":"https://api.github.com/repos/mikel/mail/statuses/ce905c2b0cc59aab987131a3c8f955df1d8e2122","head":{"label":"zelivans:fix_received_crash","ref":"fix_received_crash","sha":"ce905c2b0cc59aab987131a3c8f955df1d8e2122","user":{"login":"zelivans","id":15815884,"node_id":"MDQ6VXNlcjE1ODE1ODg0","avatar_url":"https://avatars0.githubusercontent.com/u/15815884?v=4","gravatar_id":"","url":"https://api.github.com/users/zelivans","html_url":"https://github.com/zelivans","followers_url":"https://api.github.com/users/zelivans/followers","following_url":"https://api.github.com/users/zelivans/following{/other_user}","gists_url":"https://api.github.com/users/zelivans/gists{/gist_id}","starred_url":"https://api.github.com/users/zelivans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelivans/subscriptions","organizations_url":"https://api.github.com/users/zelivans/orgs","repos_url":"https://api.github.com/users/zelivans/repos","events_url":"https://api.github.com/users/zelivans/events{/privacy}","received_events_url":"https://api.github.com/users/zelivans/received_events","type":"User","site_admin":false},"repo":{"id":149680935,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2ODA5MzU=","name":"mail","full_name":"zelivans/mail","private":false,"owner":{"login":"zelivans","id":15815884,"node_id":"MDQ6VXNlcjE1ODE1ODg0","avatar_url":"https://avatars0.githubusercontent.com/u/15815884?v=4","gravatar_id":"","url":"https://api.github.com/users/zelivans","html_url":"https://github.com/zelivans","followers_url":"https://api.github.com/users/zelivans/followers","following_url":"https://api.github.com/users/zelivans/following{/other_user}","gists_url":"https://api.github.com/users/zelivans/gists{/gist_id}","starred_url":"https://api.github.com/users/zelivans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelivans/subscriptions","organizations_url":"https://api.github.com/users/zelivans/orgs","repos_url":"https://api.github.com/users/zelivans/repos","events_url":"https://api.github.com/users/zelivans/events{/privacy}","received_events_url":"https://api.github.com/users/zelivans/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zelivans/mail","description":"A Really Ruby Mail Library","fork":true,"url":"https://api.github.com/repos/zelivans/mail","forks_url":"https://api.github.com/repos/zelivans/mail/forks","keys_url":"https://api.github.com/repos/zelivans/mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zelivans/mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zelivans/mail/teams","hooks_url":"https://api.github.com/repos/zelivans/mail/hooks","issue_events_url":"https://api.github.com/repos/zelivans/mail/issues/events{/number}","events_url":"https://api.github.com/repos/zelivans/mail/events","assignees_url":"https://api.github.com/repos/zelivans/mail/assignees{/user}","branches_url":"https://api.github.com/repos/zelivans/mail/branches{/branch}","tags_url":"https://api.github.com/repos/zelivans/mail/tags","blobs_url":"https://api.github.com/repos/zelivans/mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zelivans/mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zelivans/mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/zelivans/mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zelivans/mail/statuses/{sha}","languages_url":"https://api.github.com/repos/zelivans/mail/languages","stargazers_url":"https://api.github.com/repos/zelivans/mail/stargazers","contributors_url":"https://api.github.com/repos/zelivans/mail/contributors","subscribers_url":"https://api.github.com/repos/zelivans/mail/subscribers","subscription_url":"https://api.github.com/repos/zelivans/mail/subscription","commits_url":"https://api.github.com/repos/zelivans/mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/zelivans/mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/zelivans/mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/zelivans/mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/zelivans/mail/contents/{+path}","compare_url":"https://api.github.com/repos/zelivans/mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zelivans/mail/merges","archive_url":"https://api.github.com/repos/zelivans/mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zelivans/mail/downloads","issues_url":"https://api.github.com/repos/zelivans/mail/issues{/number}","pulls_url":"https://api.github.com/repos/zelivans/mail/pulls{/number}","milestones_url":"https://api.github.com/repos/zelivans/mail/milestones{/number}","notifications_url":"https://api.github.com/repos/zelivans/mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zelivans/mail/labels{/name}","releases_url":"https://api.github.com/repos/zelivans/mail/releases{/id}","deployments_url":"https://api.github.com/repos/zelivans/mail/deployments","created_at":"2018-09-20T23:07:00Z","updated_at":"2018-09-20T23:07:02Z","pushed_at":"2018-09-21T16:36:32Z","git_url":"git://github.com/zelivans/mail.git","ssh_url":"git@github.com:zelivans/mail.git","clone_url":"https://github.com/zelivans/mail.git","svn_url":"https://github.com/zelivans/mail","homepage":"","size":6267,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mikel:master","ref":"master","sha":"0d28fcbcc3ba4d46362ebc083057f5372b3822a1","user":{"login":"mikel","id":3366,"node_id":"MDQ6VXNlcjMzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3366?v=4","gravatar_id":"","url":"https://api.github.com/users/mikel","html_url":"https://github.com/mikel","followers_url":"https://api.github.com/users/mikel/followers","following_url":"https://api.github.com/users/mikel/following{/other_user}","gists_url":"https://api.github.com/users/mikel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikel/subscriptions","organizations_url":"https://api.github.com/users/mikel/orgs","repos_url":"https://api.github.com/users/mikel/repos","events_url":"https://api.github.com/users/mikel/events{/privacy}","received_events_url":"https://api.github.com/users/mikel/received_events","type":"User","site_admin":false},"repo":{"id":79352,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM1Mg==","name":"mail","full_name":"mikel/mail","private":false,"owner":{"login":"mikel","id":3366,"node_id":"MDQ6VXNlcjMzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3366?v=4","gravatar_id":"","url":"https://api.github.com/users/mikel","html_url":"https://github.com/mikel","followers_url":"https://api.github.com/users/mikel/followers","following_url":"https://api.github.com/users/mikel/following{/other_user}","gists_url":"https://api.github.com/users/mikel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikel/subscriptions","organizations_url":"https://api.github.com/users/mikel/orgs","repos_url":"https://api.github.com/users/mikel/repos","events_url":"https://api.github.com/users/mikel/events{/privacy}","received_events_url":"https://api.github.com/users/mikel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikel/mail","description":"A Really Ruby Mail Library","fork":false,"url":"https://api.github.com/repos/mikel/mail","forks_url":"https://api.github.com/repos/mikel/mail/forks","keys_url":"https://api.github.com/repos/mikel/mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikel/mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikel/mail/teams","hooks_url":"https://api.github.com/repos/mikel/mail/hooks","issue_events_url":"https://api.github.com/repos/mikel/mail/issues/events{/number}","events_url":"https://api.github.com/repos/mikel/mail/events","assignees_url":"https://api.github.com/repos/mikel/mail/assignees{/user}","branches_url":"https://api.github.com/repos/mikel/mail/branches{/branch}","tags_url":"https://api.github.com/repos/mikel/mail/tags","blobs_url":"https://api.github.com/repos/mikel/mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikel/mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikel/mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikel/mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikel/mail/statuses/{sha}","languages_url":"https://api.github.com/repos/mikel/mail/languages","stargazers_url":"https://api.github.com/repos/mikel/mail/stargazers","contributors_url":"https://api.github.com/repos/mikel/mail/contributors","subscribers_url":"https://api.github.com/repos/mikel/mail/subscribers","subscription_url":"https://api.github.com/repos/mikel/mail/subscription","commits_url":"https://api.github.com/repos/mikel/mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikel/mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikel/mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikel/mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikel/mail/contents/{+path}","compare_url":"https://api.github.com/repos/mikel/mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikel/mail/merges","archive_url":"https://api.github.com/repos/mikel/mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikel/mail/downloads","issues_url":"https://api.github.com/repos/mikel/mail/issues{/number}","pulls_url":"https://api.github.com/repos/mikel/mail/pulls{/number}","milestones_url":"https://api.github.com/repos/mikel/mail/milestones{/number}","notifications_url":"https://api.github.com/repos/mikel/mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikel/mail/labels{/name}","releases_url":"https://api.github.com/repos/mikel/mail/releases{/id}","deployments_url":"https://api.github.com/repos/mikel/mail/deployments","created_at":"2008-11-22T03:16:54Z","updated_at":"2018-09-20T21:28:19Z","pushed_at":"2018-09-21T16:36:34Z","git_url":"git://github.com/mikel/mail.git","ssh_url":"git@github.com:mikel/mail.git","clone_url":"https://github.com/mikel/mail.git","svn_url":"https://github.com/mikel/mail","homepage":"","size":6265,"stargazers_count":2965,"watchers_count":2965,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":748,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":748,"open_issues":67,"watchers":2965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mikel/mail/pulls/1272"},"html":{"href":"https://github.com/mikel/mail/pull/1272"},"issue":{"href":"https://api.github.com/repos/mikel/mail/issues/1272"},"comments":{"href":"https://api.github.com/repos/mikel/mail/issues/1272/comments"},"review_comments":{"href":"https://api.github.com/repos/mikel/mail/pulls/1272/comments"},"review_comment":{"href":"https://api.github.com/repos/mikel/mail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mikel/mail/pulls/1272/commits"},"statuses":{"href":"https://api.github.com/repos/mikel/mail/statuses/ce905c2b0cc59aab987131a3c8f955df1d8e2122"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeremy"}}