{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-go/issues/1125","repository_url":"https://api.github.com/repos/status-im/status-go","labels_url":"https://api.github.com/repos/status-im/status-go/issues/1125/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/1125/comments","events_url":"https://api.github.com/repos/status-im/status-go/issues/1125/events","html_url":"https://github.com/status-im/status-go/pull/1125","id":345545402,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjUxMDQ4","number":1125,"title":"Feature/remove transactions queue 1027","user":{"login":"sebastiandelgado","id":2100272,"node_id":"MDQ6VXNlcjIxMDAyNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2100272?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastiandelgado","html_url":"https://github.com/sebastiandelgado","followers_url":"https://api.github.com/users/sebastiandelgado/followers","following_url":"https://api.github.com/users/sebastiandelgado/following{/other_user}","gists_url":"https://api.github.com/users/sebastiandelgado/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiandelgado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiandelgado/subscriptions","organizations_url":"https://api.github.com/users/sebastiandelgado/orgs","repos_url":"https://api.github.com/users/sebastiandelgado/repos","events_url":"https://api.github.com/users/sebastiandelgado/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiandelgado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"adambabik","id":277870,"node_id":"MDQ6VXNlcjI3Nzg3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false},"assignees":[{"login":"adambabik","id":277870,"node_id":"MDQ6VXNlcjI3Nzg3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-07-29T16:51:29Z","updated_at":"2018-08-10T09:31:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/1125","html_url":"https://github.com/status-im/status-go/pull/1125","diff_url":"https://github.com/status-im/status-go/pull/1125.diff","patch_url":"https://github.com/status-im/status-go/pull/1125.patch"},"body":"Remove `PendingSignRequests` queue from the sign module.\r\n\r\nThis closes #1027 by removing the pending sign requests queue  dependency from the `SendTransaction`, `SignMessage` and `Recover`. It was split into 3 different PRs that were reviewed before merging into this feature branch:\r\n - Remove `pendingSignRequests` queue from the transactor and sign transactions without the queue on `SendTransaction` calls\r\n - Remove `pendingSignRequests` queue from the `personalAPI` service module so that messages are signed/recovered without it in the `SignMessage` and `Recover` methods\r\n - Remove all of the `pendingSignRequests` code, along with its references in `api/backend.go` and any tests that used it.\r\n\r\nThe `sign` module was left pretty barebones, so we might want to simplify that in a separate PR (this one is definitely big enough already) by removing most interfaces from them.\r\n\r\n@mandrigin @adambabik Thanks for all the help reviewing these PRs. Let me know if you spot anything here before merging.\r\n\r\n@flexsurfer please take a look at the `library.go` file which has all the changes to the rpc interface (basically add `SendTransaction`, `SignMessage` and `Recover` methods in place of the `ApproveSignRequest...` methods).\r\n\r\nWhat considerations do I need to take when merging this? For example, if I need to hold off on merging this so you can update the status-react interface to match these changes. What do we need to coordinate with status-react so that we don't break anything when deploying this change?"},"comment":{"url":"https://api.github.com/repos/status-im/status-go/issues/comments/412030559","html_url":"https://github.com/status-im/status-go/pull/1125#issuecomment-412030559","issue_url":"https://api.github.com/repos/status-im/status-go/issues/1125","id":412030559,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAzMDU1OQ==","user":{"login":"flexsurfer","id":11790366,"node_id":"MDQ6VXNlcjExNzkwMzY2","avatar_url":"https://avatars1.githubusercontent.com/u/11790366?v=4","gravatar_id":"","url":"https://api.github.com/users/flexsurfer","html_url":"https://github.com/flexsurfer","followers_url":"https://api.github.com/users/flexsurfer/followers","following_url":"https://api.github.com/users/flexsurfer/following{/other_user}","gists_url":"https://api.github.com/users/flexsurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/flexsurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flexsurfer/subscriptions","organizations_url":"https://api.github.com/users/flexsurfer/orgs","repos_url":"https://api.github.com/users/flexsurfer/repos","events_url":"https://api.github.com/users/flexsurfer/events{/privacy}","received_events_url":"https://api.github.com/users/flexsurfer/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T09:31:26Z","updated_at":"2018-08-10T09:31:26Z","author_association":"MEMBER","body":"https://docs.google.com/drawings/d/1l472xaRgEJzizxUkNmeL0STSNqX9ClUy0OoZpKEjjXo/edit"}}
{"actor":{"display_login":"flexsurfer"}}