{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/188858736","pull_request_review_id":120919311,"id":188858736,"diff_hunk":"@@ -242,7 +248,7 @@ def turn_on(self, **kwargs):\n             self._bulb.setPresetPattern(EFFECT_MAP[effect], 50)\n \n         # white change only\n-        elif white is not None:\n+        if white is not None:","path":"homeassistant/components/light/flux_led.py","position":32,"original_position":32,"commit_id":"4238fa58fb5c4bcb018b25d91669ca4b91801215","original_commit_id":"4238fa58fb5c4bcb018b25d91669ca4b91801215","user":{"login":"OverloadUT","id":44676,"avatar_url":"https://avatars2.githubusercontent.com/u/44676?v=4","gravatar_id":"","url":"https://api.github.com/users/OverloadUT","html_url":"https://github.com/OverloadUT","followers_url":"https://api.github.com/users/OverloadUT/followers","following_url":"https://api.github.com/users/OverloadUT/following{/other_user}","gists_url":"https://api.github.com/users/OverloadUT/gists{/gist_id}","starred_url":"https://api.github.com/users/OverloadUT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OverloadUT/subscriptions","organizations_url":"https://api.github.com/users/OverloadUT/orgs","repos_url":"https://api.github.com/users/OverloadUT/repos","events_url":"https://api.github.com/users/OverloadUT/events{/privacy}","received_events_url":"https://api.github.com/users/OverloadUT/received_events","type":"User","site_admin":false},"body":"Wait, scratch that, as the first two ifs are mutually exclusive (I recommend switching that second block to elif to make that clearer.) It still seems like there's an issue if `brightness` and `effect` are both defined, as it'll make two `.setRgb` calls","created_at":"2018-05-17T07:17:38Z","updated_at":"2018-05-17T07:17:38Z","html_url":"https://github.com/home-assistant/home-assistant/pull/14476#discussion_r188858736","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/188858736"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14476#discussion_r188858736"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476"}},"in_reply_to_id":188858258},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476","id":188212419,"html_url":"https://github.com/home-assistant/home-assistant/pull/14476","diff_url":"https://github.com/home-assistant/home-assistant/pull/14476.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/14476.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14476","number":14476,"state":"open","locked":false,"title":"Flux bug fix","user":{"login":"oblogic7","id":453840,"avatar_url":"https://avatars0.githubusercontent.com/u/453840?v=4","gravatar_id":"","url":"https://api.github.com/users/oblogic7","html_url":"https://github.com/oblogic7","followers_url":"https://api.github.com/users/oblogic7/followers","following_url":"https://api.github.com/users/oblogic7/following{/other_user}","gists_url":"https://api.github.com/users/oblogic7/gists{/gist_id}","starred_url":"https://api.github.com/users/oblogic7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oblogic7/subscriptions","organizations_url":"https://api.github.com/users/oblogic7/orgs","repos_url":"https://api.github.com/users/oblogic7/repos","events_url":"https://api.github.com/users/oblogic7/events{/privacy}","received_events_url":"https://api.github.com/users/oblogic7/received_events","type":"User","site_admin":false},"body":"## Description:\r\nFixes bugs introduced by changes on https://github.com/home-assistant/home-assistant/pull/13985 \r\n\r\nSpecifically, this PR fixes issues with setting brightness and rgb values simultaneously (reported by kineticscreen on the original PR). \r\n\r\nAlso fixes issue (reported by tadly on original PR) with flux.switch component not setting white_value which is required after the orignal PR was merged.\r\n## Checklist:\r\n  - [ ] The code change is tested and works locally.\r\n  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**","created_at":"2018-05-15T18:13:14Z","updated_at":"2018-05-17T07:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a69c161114cc32f3eb51dd9bbd9ef6cde36b8997","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":529572455,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20light.flux_led","name":"platform: light.flux_led","color":"ededed","default":false},{"id":550212189,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20switch.flux","name":"platform: switch.flux","color":"ededed","default":false},{"id":832964196,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14476/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/4238fa58fb5c4bcb018b25d91669ca4b91801215","head":{"label":"oblogic7:flux_bug_fix","ref":"flux_bug_fix","sha":"4238fa58fb5c4bcb018b25d91669ca4b91801215","user":{"login":"oblogic7","id":453840,"avatar_url":"https://avatars0.githubusercontent.com/u/453840?v=4","gravatar_id":"","url":"https://api.github.com/users/oblogic7","html_url":"https://github.com/oblogic7","followers_url":"https://api.github.com/users/oblogic7/followers","following_url":"https://api.github.com/users/oblogic7/following{/other_user}","gists_url":"https://api.github.com/users/oblogic7/gists{/gist_id}","starred_url":"https://api.github.com/users/oblogic7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oblogic7/subscriptions","organizations_url":"https://api.github.com/users/oblogic7/orgs","repos_url":"https://api.github.com/users/oblogic7/repos","events_url":"https://api.github.com/users/oblogic7/events{/privacy}","received_events_url":"https://api.github.com/users/oblogic7/received_events","type":"User","site_admin":false},"repo":{"id":129623876,"name":"home-assistant","full_name":"oblogic7/home-assistant","owner":{"login":"oblogic7","id":453840,"avatar_url":"https://avatars0.githubusercontent.com/u/453840?v=4","gravatar_id":"","url":"https://api.github.com/users/oblogic7","html_url":"https://github.com/oblogic7","followers_url":"https://api.github.com/users/oblogic7/followers","following_url":"https://api.github.com/users/oblogic7/following{/other_user}","gists_url":"https://api.github.com/users/oblogic7/gists{/gist_id}","starred_url":"https://api.github.com/users/oblogic7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oblogic7/subscriptions","organizations_url":"https://api.github.com/users/oblogic7/orgs","repos_url":"https://api.github.com/users/oblogic7/repos","events_url":"https://api.github.com/users/oblogic7/events{/privacy}","received_events_url":"https://api.github.com/users/oblogic7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oblogic7/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/oblogic7/home-assistant","forks_url":"https://api.github.com/repos/oblogic7/home-assistant/forks","keys_url":"https://api.github.com/repos/oblogic7/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oblogic7/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oblogic7/home-assistant/teams","hooks_url":"https://api.github.com/repos/oblogic7/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/oblogic7/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/oblogic7/home-assistant/events","assignees_url":"https://api.github.com/repos/oblogic7/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/oblogic7/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/oblogic7/home-assistant/tags","blobs_url":"https://api.github.com/repos/oblogic7/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oblogic7/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oblogic7/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/oblogic7/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oblogic7/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/oblogic7/home-assistant/languages","stargazers_url":"https://api.github.com/repos/oblogic7/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/oblogic7/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/oblogic7/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/oblogic7/home-assistant/subscription","commits_url":"https://api.github.com/repos/oblogic7/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/oblogic7/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/oblogic7/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/oblogic7/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/oblogic7/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/oblogic7/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oblogic7/home-assistant/merges","archive_url":"https://api.github.com/repos/oblogic7/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oblogic7/home-assistant/downloads","issues_url":"https://api.github.com/repos/oblogic7/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/oblogic7/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/oblogic7/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/oblogic7/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oblogic7/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/oblogic7/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/oblogic7/home-assistant/deployments","created_at":"2018-04-15T15:32:22Z","updated_at":"2018-04-15T15:32:31Z","pushed_at":"2018-05-16T13:05:58Z","git_url":"git://github.com/oblogic7/home-assistant.git","ssh_url":"git@github.com:oblogic7/home-assistant.git","clone_url":"https://github.com/oblogic7/home-assistant.git","svn_url":"https://github.com/oblogic7/home-assistant","homepage":"https://home-assistant.io","size":82224,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"de50d5d9c1c0375c5e46042f3168d356c73f6aa1","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-05-17T06:25:48Z","pushed_at":"2018-05-17T06:48:27Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":82283,"stargazers_count":14282,"watchers_count":14282,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4239,"mirror_url":null,"archived":false,"open_issues_count":815,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4239,"open_issues":815,"watchers":14282,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14476"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14476"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14476/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14476/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/4238fa58fb5c4bcb018b25d91669ca4b91801215"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OverloadUT"}}