{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/174962422","pull_request_review_id":104414697,"id":174962422,"diff_hunk":"@@ -429,6 +429,27 @@ String ``Index`` also supports ``get_dummies`` which returns a ``MultiIndex``.\n \n See also :func:`~pandas.get_dummies`.\n ","path":"doc/source/text.rst","position":3,"original_position":3,"commit_id":"c9ed04f1dc2ec53b2346374847757fc07b3b2a10","original_commit_id":"c9ed04f1dc2ec53b2346374847757fc07b3b2a10","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"need a reference tag here","created_at":"2018-03-15T23:28:26Z","updated_at":"2018-03-15T23:32:48Z","html_url":"https://github.com/pandas-dev/pandas/pull/20347#discussion_r174962422","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/174962422"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/20347#discussion_r174962422"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347","id":174978231,"html_url":"https://github.com/pandas-dev/pandas/pull/20347","diff_url":"https://github.com/pandas-dev/pandas/pull/20347.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/20347.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347","number":20347,"state":"open","locked":false,"title":"API: str.cat will align on Series","user":{"login":"h-vetinari","id":33685575,"avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"Fixes issue #18657, fixed existing tests, added new test; all pass.\r\n\r\nAfter I pushed everything and thought about it some more, I realised that one may argue about the default alignment-behavior, and whether it should be changed to `join=outer`. The behavior as implemented is compatible with the current requirement that everything be of the same length. To me, it is more intuitive that the concatenated `other` is added to the current series without enlarging it, but I can also see the argument why that restriction is unnecessary.\r\n\r\nPS. This is my first PR, tried to follow all the rules. Sorry if I overlooked something.","created_at":"2018-03-14T14:44:38Z","updated_at":"2018-03-15T23:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eadb0f998b9491f0d0be898acb6f9aaa3799a7b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":35818298,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false},{"id":57522093,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Strings","name":"Strings","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/c9ed04f1dc2ec53b2346374847757fc07b3b2a10","head":{"label":"h-vetinari:str_cat_align","ref":"str_cat_align","sha":"c9ed04f1dc2ec53b2346374847757fc07b3b2a10","user":{"login":"h-vetinari","id":33685575,"avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"repo":{"id":125207159,"name":"pandas","full_name":"h-vetinari/pandas","owner":{"login":"h-vetinari","id":33685575,"avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-vetinari/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/h-vetinari/pandas","forks_url":"https://api.github.com/repos/h-vetinari/pandas/forks","keys_url":"https://api.github.com/repos/h-vetinari/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-vetinari/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-vetinari/pandas/teams","hooks_url":"https://api.github.com/repos/h-vetinari/pandas/hooks","issue_events_url":"https://api.github.com/repos/h-vetinari/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/h-vetinari/pandas/events","assignees_url":"https://api.github.com/repos/h-vetinari/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/h-vetinari/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/h-vetinari/pandas/tags","blobs_url":"https://api.github.com/repos/h-vetinari/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-vetinari/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-vetinari/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-vetinari/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-vetinari/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/h-vetinari/pandas/languages","stargazers_url":"https://api.github.com/repos/h-vetinari/pandas/stargazers","contributors_url":"https://api.github.com/repos/h-vetinari/pandas/contributors","subscribers_url":"https://api.github.com/repos/h-vetinari/pandas/subscribers","subscription_url":"https://api.github.com/repos/h-vetinari/pandas/subscription","commits_url":"https://api.github.com/repos/h-vetinari/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-vetinari/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-vetinari/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-vetinari/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-vetinari/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/h-vetinari/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-vetinari/pandas/merges","archive_url":"https://api.github.com/repos/h-vetinari/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-vetinari/pandas/downloads","issues_url":"https://api.github.com/repos/h-vetinari/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/h-vetinari/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/h-vetinari/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/h-vetinari/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-vetinari/pandas/labels{/name}","releases_url":"https://api.github.com/repos/h-vetinari/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/h-vetinari/pandas/deployments","created_at":"2018-03-14T12:12:19Z","updated_at":"2018-03-14T12:12:27Z","pushed_at":"2018-03-15T14:27:00Z","git_url":"git://github.com/h-vetinari/pandas.git","ssh_url":"git@github.com:h-vetinari/pandas.git","clone_url":"https://github.com/h-vetinari/pandas.git","svn_url":"https://github.com/h-vetinari/pandas","homepage":"http://pandas.pydata.org","size":118638,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"c857b4fdd1d1e72b0a058803cf38d1d1235a1364","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-03-15T23:32:13Z","pushed_at":"2018-03-15T23:18:52Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":119314,"stargazers_count":13441,"watchers_count":13441,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5452,"mirror_url":null,"archived":false,"open_issues_count":2487,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5452,"open_issues":2487,"watchers":13441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/20347"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/20347"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/20347/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/c9ed04f1dc2ec53b2346374847757fc07b3b2a10"}},"author_association":"NONE"}}
{"actor":{"display_login":"jreback"}}