{"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82","id":169790531,"html_url":"https://github.com/fus-marcom/franciscan-react/pull/82","diff_url":"https://github.com/fus-marcom/franciscan-react/pull/82.diff","patch_url":"https://github.com/fus-marcom/franciscan-react/pull/82.patch","issue_url":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/82","number":82,"state":"open","locked":false,"title":"Fix for client side routing and error warnings","user":{"login":"pantharshit00","id":22195362,"avatar_url":"https://avatars3.githubusercontent.com/u/22195362?v=4","gravatar_id":"","url":"https://api.github.com/users/pantharshit00","html_url":"https://github.com/pantharshit00","followers_url":"https://api.github.com/users/pantharshit00/followers","following_url":"https://api.github.com/users/pantharshit00/following{/other_user}","gists_url":"https://api.github.com/users/pantharshit00/gists{/gist_id}","starred_url":"https://api.github.com/users/pantharshit00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantharshit00/subscriptions","organizations_url":"https://api.github.com/users/pantharshit00/orgs","repos_url":"https://api.github.com/users/pantharshit00/repos","events_url":"https://api.github.com/users/pantharshit00/events{/privacy}","received_events_url":"https://api.github.com/users/pantharshit00/received_events","type":"User","site_admin":false},"body":"## IMPORTANT MESSAGE\r\nAs you have setup custom next js server the client side routing doesnt work the usual way. You can see by running the current code that browser reloads when you click a link which should not be the case. For that to work next Link component needs the url passed to the server  in the href prop(means the `/pages?id=something&type=something`) and for the representation link (means `/about/mission`) needs to pass in the as prop. I have added an asUrl key to each link item. You need to fill them will correct links. You can refer the server.js file. It was a ton of work that I cant do(SORRY for that). See https://github.com/fus-marcom/franciscan-react/blob/da5010a9cf55984c4320a678153589c204367326/data/drawerMenu.js#L5\r\nAnd this https://github.com/fus-marcom/franciscan-react/blob/da5010a9cf55984c4320a678153589c204367326/components/DrawerItem.js#L48\r\n\r\nAdditional fixes:\r\n1. *MADE MASONRY LOOK BETTER IN EVERY SCREEN SIZE*. I have tested this upto 4032px width. Before it was looking trash in md size\r\n2. Fix invert buttons and error message related to them\r\n3. FIx the Link props error meassge that we are getting\r\n","created_at":"2018-02-17T16:37:29Z","updated_at":"2018-02-17T16:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82/commits","review_comments_url":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82/comments","review_comment_url":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/82/comments","statuses_url":"https://api.github.com/repos/fus-marcom/franciscan-react/statuses/da5010a9cf55984c4320a678153589c204367326","head":{"label":"pantharshit00:fixmas","ref":"fixmas","sha":"da5010a9cf55984c4320a678153589c204367326","user":{"login":"pantharshit00","id":22195362,"avatar_url":"https://avatars3.githubusercontent.com/u/22195362?v=4","gravatar_id":"","url":"https://api.github.com/users/pantharshit00","html_url":"https://github.com/pantharshit00","followers_url":"https://api.github.com/users/pantharshit00/followers","following_url":"https://api.github.com/users/pantharshit00/following{/other_user}","gists_url":"https://api.github.com/users/pantharshit00/gists{/gist_id}","starred_url":"https://api.github.com/users/pantharshit00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantharshit00/subscriptions","organizations_url":"https://api.github.com/users/pantharshit00/orgs","repos_url":"https://api.github.com/users/pantharshit00/repos","events_url":"https://api.github.com/users/pantharshit00/events{/privacy}","received_events_url":"https://api.github.com/users/pantharshit00/received_events","type":"User","site_admin":false},"repo":{"id":117234818,"name":"franciscan-react","full_name":"pantharshit00/franciscan-react","owner":{"login":"pantharshit00","id":22195362,"avatar_url":"https://avatars3.githubusercontent.com/u/22195362?v=4","gravatar_id":"","url":"https://api.github.com/users/pantharshit00","html_url":"https://github.com/pantharshit00","followers_url":"https://api.github.com/users/pantharshit00/followers","following_url":"https://api.github.com/users/pantharshit00/following{/other_user}","gists_url":"https://api.github.com/users/pantharshit00/gists{/gist_id}","starred_url":"https://api.github.com/users/pantharshit00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantharshit00/subscriptions","organizations_url":"https://api.github.com/users/pantharshit00/orgs","repos_url":"https://api.github.com/users/pantharshit00/repos","events_url":"https://api.github.com/users/pantharshit00/events{/privacy}","received_events_url":"https://api.github.com/users/pantharshit00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pantharshit00/franciscan-react","description":"A new website for Franciscan University of Steubenville built with ReactJS.","fork":true,"url":"https://api.github.com/repos/pantharshit00/franciscan-react","forks_url":"https://api.github.com/repos/pantharshit00/franciscan-react/forks","keys_url":"https://api.github.com/repos/pantharshit00/franciscan-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantharshit00/franciscan-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantharshit00/franciscan-react/teams","hooks_url":"https://api.github.com/repos/pantharshit00/franciscan-react/hooks","issue_events_url":"https://api.github.com/repos/pantharshit00/franciscan-react/issues/events{/number}","events_url":"https://api.github.com/repos/pantharshit00/franciscan-react/events","assignees_url":"https://api.github.com/repos/pantharshit00/franciscan-react/assignees{/user}","branches_url":"https://api.github.com/repos/pantharshit00/franciscan-react/branches{/branch}","tags_url":"https://api.github.com/repos/pantharshit00/franciscan-react/tags","blobs_url":"https://api.github.com/repos/pantharshit00/franciscan-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantharshit00/franciscan-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantharshit00/franciscan-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantharshit00/franciscan-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantharshit00/franciscan-react/statuses/{sha}","languages_url":"https://api.github.com/repos/pantharshit00/franciscan-react/languages","stargazers_url":"https://api.github.com/repos/pantharshit00/franciscan-react/stargazers","contributors_url":"https://api.github.com/repos/pantharshit00/franciscan-react/contributors","subscribers_url":"https://api.github.com/repos/pantharshit00/franciscan-react/subscribers","subscription_url":"https://api.github.com/repos/pantharshit00/franciscan-react/subscription","commits_url":"https://api.github.com/repos/pantharshit00/franciscan-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantharshit00/franciscan-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantharshit00/franciscan-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantharshit00/franciscan-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantharshit00/franciscan-react/contents/{+path}","compare_url":"https://api.github.com/repos/pantharshit00/franciscan-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantharshit00/franciscan-react/merges","archive_url":"https://api.github.com/repos/pantharshit00/franciscan-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantharshit00/franciscan-react/downloads","issues_url":"https://api.github.com/repos/pantharshit00/franciscan-react/issues{/number}","pulls_url":"https://api.github.com/repos/pantharshit00/franciscan-react/pulls{/number}","milestones_url":"https://api.github.com/repos/pantharshit00/franciscan-react/milestones{/number}","notifications_url":"https://api.github.com/repos/pantharshit00/franciscan-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantharshit00/franciscan-react/labels{/name}","releases_url":"https://api.github.com/repos/pantharshit00/franciscan-react/releases{/id}","deployments_url":"https://api.github.com/repos/pantharshit00/franciscan-react/deployments","created_at":"2018-01-12T11:45:33Z","updated_at":"2018-01-12T11:45:36Z","pushed_at":"2018-02-17T16:26:17Z","git_url":"git://github.com/pantharshit00/franciscan-react.git","ssh_url":"git@github.com:pantharshit00/franciscan-react.git","clone_url":"https://github.com/pantharshit00/franciscan-react.git","svn_url":"https://github.com/pantharshit00/franciscan-react","homepage":null,"size":5061,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fus-marcom:master","ref":"master","sha":"babcc455c977e1aae566738f567171860cfbcc33","user":{"login":"fus-marcom","id":26118511,"avatar_url":"https://avatars2.githubusercontent.com/u/26118511?v=4","gravatar_id":"","url":"https://api.github.com/users/fus-marcom","html_url":"https://github.com/fus-marcom","followers_url":"https://api.github.com/users/fus-marcom/followers","following_url":"https://api.github.com/users/fus-marcom/following{/other_user}","gists_url":"https://api.github.com/users/fus-marcom/gists{/gist_id}","starred_url":"https://api.github.com/users/fus-marcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fus-marcom/subscriptions","organizations_url":"https://api.github.com/users/fus-marcom/orgs","repos_url":"https://api.github.com/users/fus-marcom/repos","events_url":"https://api.github.com/users/fus-marcom/events{/privacy}","received_events_url":"https://api.github.com/users/fus-marcom/received_events","type":"Organization","site_admin":false},"repo":{"id":110157035,"name":"franciscan-react","full_name":"fus-marcom/franciscan-react","owner":{"login":"fus-marcom","id":26118511,"avatar_url":"https://avatars2.githubusercontent.com/u/26118511?v=4","gravatar_id":"","url":"https://api.github.com/users/fus-marcom","html_url":"https://github.com/fus-marcom","followers_url":"https://api.github.com/users/fus-marcom/followers","following_url":"https://api.github.com/users/fus-marcom/following{/other_user}","gists_url":"https://api.github.com/users/fus-marcom/gists{/gist_id}","starred_url":"https://api.github.com/users/fus-marcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fus-marcom/subscriptions","organizations_url":"https://api.github.com/users/fus-marcom/orgs","repos_url":"https://api.github.com/users/fus-marcom/repos","events_url":"https://api.github.com/users/fus-marcom/events{/privacy}","received_events_url":"https://api.github.com/users/fus-marcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fus-marcom/franciscan-react","description":"A new website for Franciscan University of Steubenville built with ReactJS.","fork":false,"url":"https://api.github.com/repos/fus-marcom/franciscan-react","forks_url":"https://api.github.com/repos/fus-marcom/franciscan-react/forks","keys_url":"https://api.github.com/repos/fus-marcom/franciscan-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fus-marcom/franciscan-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fus-marcom/franciscan-react/teams","hooks_url":"https://api.github.com/repos/fus-marcom/franciscan-react/hooks","issue_events_url":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/events{/number}","events_url":"https://api.github.com/repos/fus-marcom/franciscan-react/events","assignees_url":"https://api.github.com/repos/fus-marcom/franciscan-react/assignees{/user}","branches_url":"https://api.github.com/repos/fus-marcom/franciscan-react/branches{/branch}","tags_url":"https://api.github.com/repos/fus-marcom/franciscan-react/tags","blobs_url":"https://api.github.com/repos/fus-marcom/franciscan-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fus-marcom/franciscan-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fus-marcom/franciscan-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/fus-marcom/franciscan-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fus-marcom/franciscan-react/statuses/{sha}","languages_url":"https://api.github.com/repos/fus-marcom/franciscan-react/languages","stargazers_url":"https://api.github.com/repos/fus-marcom/franciscan-react/stargazers","contributors_url":"https://api.github.com/repos/fus-marcom/franciscan-react/contributors","subscribers_url":"https://api.github.com/repos/fus-marcom/franciscan-react/subscribers","subscription_url":"https://api.github.com/repos/fus-marcom/franciscan-react/subscription","commits_url":"https://api.github.com/repos/fus-marcom/franciscan-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/fus-marcom/franciscan-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/fus-marcom/franciscan-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/fus-marcom/franciscan-react/contents/{+path}","compare_url":"https://api.github.com/repos/fus-marcom/franciscan-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fus-marcom/franciscan-react/merges","archive_url":"https://api.github.com/repos/fus-marcom/franciscan-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fus-marcom/franciscan-react/downloads","issues_url":"https://api.github.com/repos/fus-marcom/franciscan-react/issues{/number}","pulls_url":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls{/number}","milestones_url":"https://api.github.com/repos/fus-marcom/franciscan-react/milestones{/number}","notifications_url":"https://api.github.com/repos/fus-marcom/franciscan-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fus-marcom/franciscan-react/labels{/name}","releases_url":"https://api.github.com/repos/fus-marcom/franciscan-react/releases{/id}","deployments_url":"https://api.github.com/repos/fus-marcom/franciscan-react/deployments","created_at":"2017-11-09T19:26:22Z","updated_at":"2018-02-16T19:15:37Z","pushed_at":"2018-02-16T19:18:31Z","git_url":"git://github.com/fus-marcom/franciscan-react.git","ssh_url":"git@github.com:fus-marcom/franciscan-react.git","clone_url":"https://github.com/fus-marcom/franciscan-react.git","svn_url":"https://github.com/fus-marcom/franciscan-react","homepage":null,"size":5084,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":8,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82"},"html":{"href":"https://github.com/fus-marcom/franciscan-react/pull/82"},"issue":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/82"},"comments":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/fus-marcom/franciscan-react/statuses/da5010a9cf55984c4320a678153589c204367326"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":152,"deletions":148,"changed_files":8}}
{"actor":{"display_login":"pantharshit00"}}