{"action":"created","issue":{"url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/31","repository_url":"https://api.github.com/repos/Glitchfiend/SereneSeasons","labels_url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/31/comments","events_url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/31/events","html_url":"https://github.com/Glitchfiend/SereneSeasons/pull/31","id":318465037,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NjY0MTA4","number":31,"title":"Ported code for offline season simulation from TAN.","user":{"login":"Avatair","id":21110130,"node_id":"MDQ6VXNlcjIxMTEwMTMw","avatar_url":"https://avatars0.githubusercontent.com/u/21110130?v=4","gravatar_id":"","url":"https://api.github.com/users/Avatair","html_url":"https://github.com/Avatair","followers_url":"https://api.github.com/users/Avatair/followers","following_url":"https://api.github.com/users/Avatair/following{/other_user}","gists_url":"https://api.github.com/users/Avatair/gists{/gist_id}","starred_url":"https://api.github.com/users/Avatair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avatair/subscriptions","organizations_url":"https://api.github.com/users/Avatair/orgs","repos_url":"https://api.github.com/users/Avatair/repos","events_url":"https://api.github.com/users/Avatair/events{/privacy}","received_events_url":"https://api.github.com/users/Avatair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-04-27T16:03:19Z","updated_at":"2018-11-28T12:03:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/pulls/31","html_url":"https://github.com/Glitchfiend/SereneSeasons/pull/31","diff_url":"https://github.com/Glitchfiend/SereneSeasons/pull/31.diff","patch_url":"https://github.com/Glitchfiend/SereneSeasons/pull/31.patch"},"body":"This change allows to simulate weather effects (like snowing, melting or freezing) in chunks which are not loaded and generated and thus makes season weather effects happen globally. It introduces some changes in chunk loading/generation handling.\r\n\r\nA journal of happened weather events, like season changing and raining is recorded and replayed on older and newly generated chunks by a patching mechanism. To perform this, new information has to be stored in season data. It contains the journal data and time stamp values per chunk of their last updates.\r\n\r\n### Things to be done:\r\n* _Crop death simulation_: The chunk patcher must be extended to handle crop deaths during cold seasons. When introducing this change, villagers should be adapted to replant dead crops.\r\n\r\n### Known Bugs:\r\n* _Balance_: Melting at offline chunks are too fast compared to melting by chunk ticks resulting in seams when travelling far away.\r\n\r\n### Test version:\r\nTo enable the feature edit \"Enable Global Frost\"=true in seasons.cfg \r\n**This feature is in alpha stage! Back up your world first before using to avoid losing data!**\r\n[SereneSeasons-1.12.2-1.2.6.null-universal.jar-2018-09-30-R2.zip](https://github.com/Glitchfiend/SereneSeasons/files/2431492/SereneSeasons-1.12.2-1.2.6.null-universal.jar-2018-09-30-R2.zip)"},"comment":{"url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/comments/442423543","html_url":"https://github.com/Glitchfiend/SereneSeasons/pull/31#issuecomment-442423543","issue_url":"https://api.github.com/repos/Glitchfiend/SereneSeasons/issues/31","id":442423543,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjQyMzU0Mw==","user":{"login":"Avatair","id":21110130,"node_id":"MDQ6VXNlcjIxMTEwMTMw","avatar_url":"https://avatars0.githubusercontent.com/u/21110130?v=4","gravatar_id":"","url":"https://api.github.com/users/Avatair","html_url":"https://github.com/Avatair","followers_url":"https://api.github.com/users/Avatair/followers","following_url":"https://api.github.com/users/Avatair/following{/other_user}","gists_url":"https://api.github.com/users/Avatair/gists{/gist_id}","starred_url":"https://api.github.com/users/Avatair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avatair/subscriptions","organizations_url":"https://api.github.com/users/Avatair/orgs","repos_url":"https://api.github.com/users/Avatair/repos","events_url":"https://api.github.com/users/Avatair/events{/privacy}","received_events_url":"https://api.github.com/users/Avatair/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T12:03:40Z","updated_at":"2018-11-28T12:03:40Z","author_association":"NONE","body":"I've seen that there are a lot of changes in the past 48 hours. Is it expected more to come? If yes, then it is better to wait before merging.\r\n\r\nFor the ability to disable the feature there exists already the \"Enable Global Frost\" property, which has maybe a little confusing name, but it simply disables global season change effects."}}
{"actor":{"display_login":"Avatair"}}