{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/2862","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2862/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2862/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2862/events","html_url":"https://github.com/trilinos/Trilinos/pull/2862","id":328339066,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTA1MjQx","number":2862,"title":"Ifpack2 + Belos + equilibration demo","user":{"login":"mhoemmen","id":926747,"node_id":"MDQ6VXNlcjkyNjc0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/926747?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"labels":[{"id":315614807,"node_id":"MDU6TGFiZWwzMTU2MTQ4MDc=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/Belos","name":"Belos","color":"5319e7","default":false},{"id":291289398,"node_id":"MDU6TGFiZWwyOTEyODkzOTg=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/Ifpack2","name":"Ifpack2","color":"5319e7","default":false},{"id":289606028,"node_id":"MDU6TGFiZWwyODk2MDYwMjg=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tpetra","name":"Tpetra","color":"5319e7","default":false},{"id":732061788,"node_id":"MDU6TGFiZWw3MzIwNjE3ODg=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/TpetraRF","name":"TpetraRF","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"mhoemmen","id":926747,"node_id":"MDQ6VXNlcjkyNjc0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/926747?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhoemmen","id":926747,"node_id":"MDQ6VXNlcjkyNjc0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/926747?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-01T00:16:52Z","updated_at":"2018-06-01T04:29:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2862","html_url":"https://github.com/trilinos/Trilinos/pull/2862","diff_url":"https://github.com/trilinos/Trilinos/pull/2862.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/2862.patch"},"body":"Add an Ifpack2 example that demonstrates a complete linear solver:\r\n\r\n  - Belos iterative solver\r\n  - Ifpack2 preconditioner (optional)\r\n  - Equilibration (optional), using new Tpetra capabilities I added recently\r\n\r\n@trilinos/ifpack2 @trilinos/tpetra @trilinos/belos \r\n\r\n## Description\r\n\r\nThis is an example, not a new feature.  It's not clear where a feature would go in Trilinos.\r\n\r\n## Motivation and Context\r\n\r\nSierra (specifically Fuego) really really needs row scaling.  It works great with their AztecOO solves.\r\n\r\n## How Has This Been Tested?\r\n\r\nLocally, with various command-line options.\r\n\r\n## Checklist\r\n\r\n- [ ] My commit messages mention the appropriate GitHub issue numbers.\r\n- [x] My code follows the code style of the affected package(s).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] No new compiler warnings were introduced.\r\n- [ ] These changes break backwards compatibility.\r\n\r\n<!--- \r\n## Additional Information\r\nAnything else we need to know in evaluating this merge request?\r\n -->\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/393754655","html_url":"https://github.com/trilinos/Trilinos/pull/2862#issuecomment-393754655","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2862","id":393754655,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc1NDY1NQ==","user":{"login":"mhoemmen","id":926747,"node_id":"MDQ6VXNlcjkyNjc0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/926747?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T04:29:50Z","updated_at":"2018-06-01T04:29:50Z","author_association":"CONTRIBUTOR","body":"@aprokop wrote:\r\n> The test's code looks really large to me :) \r\n\r\nThere are some missing computational kernels.\r\n\r\n> Before I looked at it, I just expected a single parameter to the solver/ifpack2 to say I want to use equilibration and use diagonal/lumped diagonal. I missed it, but is there such a parameter in your last PR?\r\n\r\nEquilibration is a solve pre-processing and post-processing step.  Thus, it can't just go in Ifpack2; it has to happen before and after Belos.  Furthermore, it shouldn't really go in Belos, since Belos is supposed to be agnostic of the linear algebra implementation.\r\n\r\nMore importantly, I want the application to try it out first and see if it's the right interface, before I put it back in Trilinos.\r\n\r\n"}}
{"actor":{"display_login":"mhoemmen"}}