{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments/243659732","pull_request_review_id":187496815,"id":243659732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzY1OTczMg==","diff_hunk":"@@ -239,6 +243,15 @@ public void testLoadFromFile() {\n     KubernetesClient client = server.getClient();\n     assertNotNull(client.batch().cronjobs().load(getClass().getResourceAsStream(\"/test-cronjob.yml\")).get());\n   }\n+  @Test\n+  public void testHandlersLoadFromFile() {","path":"kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/CronJobTest.java","position":23,"original_position":23,"commit_id":"438c0fc424dc339dd8d902cfc3d50c3edd1e7ac5","original_commit_id":"438c0fc424dc339dd8d902cfc3d50c3edd1e7ac5","user":{"login":"traviswinter","id":4635971,"node_id":"MDQ6VXNlcjQ2MzU5NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4635971?v=4","gravatar_id":"","url":"https://api.github.com/users/traviswinter","html_url":"https://github.com/traviswinter","followers_url":"https://api.github.com/users/traviswinter/followers","following_url":"https://api.github.com/users/traviswinter/following{/other_user}","gists_url":"https://api.github.com/users/traviswinter/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswinter/subscriptions","organizations_url":"https://api.github.com/users/traviswinter/orgs","repos_url":"https://api.github.com/users/traviswinter/repos","events_url":"https://api.github.com/users/traviswinter/events{/privacy}","received_events_url":"https://api.github.com/users/traviswinter/received_events","type":"User","site_admin":false},"body":"I wasn't sure where best to put it - looked like CronJobTest already had some tests around this so I built it out from there.  Where would you like for me to place them?","created_at":"2018-12-21T18:36:32Z","updated_at":"2018-12-21T18:36:32Z","html_url":"https://github.com/fabric8io/kubernetes-client/pull/1300#discussion_r243659732","pull_request_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments/243659732"},"html":{"href":"https://github.com/fabric8io/kubernetes-client/pull/1300#discussion_r243659732"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300"}},"in_reply_to_id":243643906},"pull_request":{"url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300","id":240368961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzY4OTYx","html_url":"https://github.com/fabric8io/kubernetes-client/pull/1300","diff_url":"https://github.com/fabric8io/kubernetes-client/pull/1300.diff","patch_url":"https://github.com/fabric8io/kubernetes-client/pull/1300.patch","issue_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1300","number":1300,"state":"open","locked":false,"title":"Fix #1152: Renamed Kubernetes RBAC resources to use non-prefixed names and renamed Openshift RBAC resources to prefix with Openshift","user":{"login":"traviswinter","id":4635971,"node_id":"MDQ6VXNlcjQ2MzU5NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4635971?v=4","gravatar_id":"","url":"https://api.github.com/users/traviswinter","html_url":"https://github.com/traviswinter","followers_url":"https://api.github.com/users/traviswinter/followers","following_url":"https://api.github.com/users/traviswinter/following{/other_user}","gists_url":"https://api.github.com/users/traviswinter/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswinter/subscriptions","organizations_url":"https://api.github.com/users/traviswinter/orgs","repos_url":"https://api.github.com/users/traviswinter/repos","events_url":"https://api.github.com/users/traviswinter/events{/privacy}","received_events_url":"https://api.github.com/users/traviswinter/received_events","type":"User","site_admin":false},"body":"Not sure if this level of change is what you meant @rohanKanojia but I think it cleans the Kubernetes RBAC references up quite a bit.  It does change the client api (eg. rbac().kubernetesClusterRoles() becomes rbac().clusterRoles()) but I believe it would be a little more intuitive.\r\n\r\nIf those changes are too severe, I can back off the renaming of the methods at least.\r\n\r\nKey changes are in generate.go, kube-schema.json and validation-schema.json\r\n\r\nFixes #1152 ","created_at":"2018-12-21T04:24:44Z","updated_at":"2018-12-21T18:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afa873555946ce7a11573561447dea71fcc75da1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iocanel","id":402008,"node_id":"MDQ6VXNlcjQwMjAwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/402008?v=4","gravatar_id":"","url":"https://api.github.com/users/iocanel","html_url":"https://github.com/iocanel","followers_url":"https://api.github.com/users/iocanel/followers","following_url":"https://api.github.com/users/iocanel/following{/other_user}","gists_url":"https://api.github.com/users/iocanel/gists{/gist_id}","starred_url":"https://api.github.com/users/iocanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocanel/subscriptions","organizations_url":"https://api.github.com/users/iocanel/orgs","repos_url":"https://api.github.com/users/iocanel/repos","events_url":"https://api.github.com/users/iocanel/events{/privacy}","received_events_url":"https://api.github.com/users/iocanel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300/commits","review_comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300/comments","review_comment_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1300/comments","statuses_url":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/438c0fc424dc339dd8d902cfc3d50c3edd1e7ac5","head":{"label":"traviswinter:issue1152_k8srbacfix","ref":"issue1152_k8srbacfix","sha":"438c0fc424dc339dd8d902cfc3d50c3edd1e7ac5","user":{"login":"traviswinter","id":4635971,"node_id":"MDQ6VXNlcjQ2MzU5NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4635971?v=4","gravatar_id":"","url":"https://api.github.com/users/traviswinter","html_url":"https://github.com/traviswinter","followers_url":"https://api.github.com/users/traviswinter/followers","following_url":"https://api.github.com/users/traviswinter/following{/other_user}","gists_url":"https://api.github.com/users/traviswinter/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswinter/subscriptions","organizations_url":"https://api.github.com/users/traviswinter/orgs","repos_url":"https://api.github.com/users/traviswinter/repos","events_url":"https://api.github.com/users/traviswinter/events{/privacy}","received_events_url":"https://api.github.com/users/traviswinter/received_events","type":"User","site_admin":false},"repo":{"id":153509969,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MDk5Njk=","name":"kubernetes-client","full_name":"traviswinter/kubernetes-client","private":false,"owner":{"login":"traviswinter","id":4635971,"node_id":"MDQ6VXNlcjQ2MzU5NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4635971?v=4","gravatar_id":"","url":"https://api.github.com/users/traviswinter","html_url":"https://github.com/traviswinter","followers_url":"https://api.github.com/users/traviswinter/followers","following_url":"https://api.github.com/users/traviswinter/following{/other_user}","gists_url":"https://api.github.com/users/traviswinter/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswinter/subscriptions","organizations_url":"https://api.github.com/users/traviswinter/orgs","repos_url":"https://api.github.com/users/traviswinter/repos","events_url":"https://api.github.com/users/traviswinter/events{/privacy}","received_events_url":"https://api.github.com/users/traviswinter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/traviswinter/kubernetes-client","description":"Java client for Kubernetes & OpenShift 3","fork":true,"url":"https://api.github.com/repos/traviswinter/kubernetes-client","forks_url":"https://api.github.com/repos/traviswinter/kubernetes-client/forks","keys_url":"https://api.github.com/repos/traviswinter/kubernetes-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traviswinter/kubernetes-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traviswinter/kubernetes-client/teams","hooks_url":"https://api.github.com/repos/traviswinter/kubernetes-client/hooks","issue_events_url":"https://api.github.com/repos/traviswinter/kubernetes-client/issues/events{/number}","events_url":"https://api.github.com/repos/traviswinter/kubernetes-client/events","assignees_url":"https://api.github.com/repos/traviswinter/kubernetes-client/assignees{/user}","branches_url":"https://api.github.com/repos/traviswinter/kubernetes-client/branches{/branch}","tags_url":"https://api.github.com/repos/traviswinter/kubernetes-client/tags","blobs_url":"https://api.github.com/repos/traviswinter/kubernetes-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traviswinter/kubernetes-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traviswinter/kubernetes-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/traviswinter/kubernetes-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traviswinter/kubernetes-client/statuses/{sha}","languages_url":"https://api.github.com/repos/traviswinter/kubernetes-client/languages","stargazers_url":"https://api.github.com/repos/traviswinter/kubernetes-client/stargazers","contributors_url":"https://api.github.com/repos/traviswinter/kubernetes-client/contributors","subscribers_url":"https://api.github.com/repos/traviswinter/kubernetes-client/subscribers","subscription_url":"https://api.github.com/repos/traviswinter/kubernetes-client/subscription","commits_url":"https://api.github.com/repos/traviswinter/kubernetes-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/traviswinter/kubernetes-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/traviswinter/kubernetes-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/traviswinter/kubernetes-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/traviswinter/kubernetes-client/contents/{+path}","compare_url":"https://api.github.com/repos/traviswinter/kubernetes-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traviswinter/kubernetes-client/merges","archive_url":"https://api.github.com/repos/traviswinter/kubernetes-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traviswinter/kubernetes-client/downloads","issues_url":"https://api.github.com/repos/traviswinter/kubernetes-client/issues{/number}","pulls_url":"https://api.github.com/repos/traviswinter/kubernetes-client/pulls{/number}","milestones_url":"https://api.github.com/repos/traviswinter/kubernetes-client/milestones{/number}","notifications_url":"https://api.github.com/repos/traviswinter/kubernetes-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traviswinter/kubernetes-client/labels{/name}","releases_url":"https://api.github.com/repos/traviswinter/kubernetes-client/releases{/id}","deployments_url":"https://api.github.com/repos/traviswinter/kubernetes-client/deployments","created_at":"2018-10-17T19:09:34Z","updated_at":"2018-12-18T21:23:00Z","pushed_at":"2018-12-21T14:23:01Z","git_url":"git://github.com/traviswinter/kubernetes-client.git","ssh_url":"git@github.com:traviswinter/kubernetes-client.git","clone_url":"https://github.com/traviswinter/kubernetes-client.git","svn_url":"https://github.com/traviswinter/kubernetes-client","homepage":"http://fabric8.io","size":75761,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"4c76248d7e6cacf4caf89b1bf084f81280835c4d","user":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":38829639,"node_id":"MDEwOlJlcG9zaXRvcnkzODgyOTYzOQ==","name":"kubernetes-client","full_name":"fabric8io/kubernetes-client","private":false,"owner":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8io/kubernetes-client","description":"Java client for Kubernetes & OpenShift 3","fork":false,"url":"https://api.github.com/repos/fabric8io/kubernetes-client","forks_url":"https://api.github.com/repos/fabric8io/kubernetes-client/forks","keys_url":"https://api.github.com/repos/fabric8io/kubernetes-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/kubernetes-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/kubernetes-client/teams","hooks_url":"https://api.github.com/repos/fabric8io/kubernetes-client/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/kubernetes-client/events","assignees_url":"https://api.github.com/repos/fabric8io/kubernetes-client/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/kubernetes-client/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/kubernetes-client/tags","blobs_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/kubernetes-client/languages","stargazers_url":"https://api.github.com/repos/fabric8io/kubernetes-client/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/kubernetes-client/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/kubernetes-client/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/kubernetes-client/subscription","commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/kubernetes-client/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/kubernetes-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/kubernetes-client/merges","archive_url":"https://api.github.com/repos/fabric8io/kubernetes-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/kubernetes-client/downloads","issues_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/kubernetes-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/kubernetes-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/kubernetes-client/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/kubernetes-client/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/deployments","created_at":"2015-07-09T15:43:13Z","updated_at":"2018-12-20T16:59:19Z","pushed_at":"2018-12-21T14:48:39Z","git_url":"git://github.com/fabric8io/kubernetes-client.git","ssh_url":"git@github.com:fabric8io/kubernetes-client.git","clone_url":"https://github.com/fabric8io/kubernetes-client.git","svn_url":"https://github.com/fabric8io/kubernetes-client","homepage":"http://fabric8.io","size":75780,"stargazers_count":622,"watchers_count":622,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":365,"open_issues":218,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300"},"html":{"href":"https://github.com/fabric8io/kubernetes-client/pull/1300"},"issue":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1300"},"comments":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1300/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1300/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/438c0fc424dc339dd8d902cfc3d50c3edd1e7ac5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"traviswinter"}}