{"action":"closed","number":9628,"pull_request":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628","id":201193708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTkzNzA4","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/9628","diff_url":"https://github.com/ballerina-platform/ballerina-lang/pull/9628.diff","patch_url":"https://github.com/ballerina-platform/ballerina-lang/pull/9628.patch","issue_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/9628","number":9628,"state":"closed","locked":false,"title":"Fix taint analyzer block resolution for multiple looping invocations","user":{"login":"ayomawdb","id":612458,"node_id":"MDQ6VXNlcjYxMjQ1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/612458?v=4","gravatar_id":"","url":"https://api.github.com/users/ayomawdb","html_url":"https://github.com/ayomawdb","followers_url":"https://api.github.com/users/ayomawdb/followers","following_url":"https://api.github.com/users/ayomawdb/following{/other_user}","gists_url":"https://api.github.com/users/ayomawdb/gists{/gist_id}","starred_url":"https://api.github.com/users/ayomawdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayomawdb/subscriptions","organizations_url":"https://api.github.com/users/ayomawdb/orgs","repos_url":"https://api.github.com/users/ayomawdb/repos","events_url":"https://api.github.com/users/ayomawdb/events{/privacy}","received_events_url":"https://api.github.com/users/ayomawdb/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nTaint analyzer block resolution mechanism will detect and prevent analysis of recursions or function loops. This is expected to prevent infinite loops when analyzing invocation outcomes. \r\n\r\nDuring the block resolution, taint analyzer will ignore recursive invocations and analyze the rest of the function to determine the tainted outcome of the function. However, as soon as the blocking invocation get ignored, taint analyzer will change into a mode where it will not skip any proceeding booking invocations. This is done to prevent invalid taint outcomes. \r\n\r\nWhen there are multiple recursive invocations, the following recursive invocations will not get skipped causing a stack-overflow.\r\n\r\nDue to this issue the analysis of the second `sort(-)` recursive invocation in the following code resulted in a stack overflow. \r\n\r\n```\r\nfunction sort(int[] arr, int l, int r) {\r\n        if (l < r) {\r\n            int m = (l+r)/2;\r\n\r\n            sort(arr, l, m);\r\n            sort(arr , m+1, r);\r\n\r\n            merge(arr, l, m, r);\r\n        }\r\n}\r\n```\r\n## Approach\r\n\r\nThis is fixed by maintaining the skipped invocation of the current block resolution iteration and skipping any proceeding invocations to the same. ","created_at":"2018-07-13T05:51:53Z","updated_at":"2018-07-13T06:07:24Z","closed_at":"2018-07-13T06:07:24Z","merged_at":"2018-07-13T06:07:24Z","merge_commit_sha":"da6f215fb47da5fc5f0a1ce06ef404cc81b98d78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628/commits","review_comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628/comments","review_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/9628/comments","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/db92c2eb2e9d94f1d0bb81556e925298ef72721a","head":{"label":"ayomawdb:next-release","ref":"next-release","sha":"db92c2eb2e9d94f1d0bb81556e925298ef72721a","user":{"login":"ayomawdb","id":612458,"node_id":"MDQ6VXNlcjYxMjQ1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/612458?v=4","gravatar_id":"","url":"https://api.github.com/users/ayomawdb","html_url":"https://github.com/ayomawdb","followers_url":"https://api.github.com/users/ayomawdb/followers","following_url":"https://api.github.com/users/ayomawdb/following{/other_user}","gists_url":"https://api.github.com/users/ayomawdb/gists{/gist_id}","starred_url":"https://api.github.com/users/ayomawdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayomawdb/subscriptions","organizations_url":"https://api.github.com/users/ayomawdb/orgs","repos_url":"https://api.github.com/users/ayomawdb/repos","events_url":"https://api.github.com/users/ayomawdb/events{/privacy}","received_events_url":"https://api.github.com/users/ayomawdb/received_events","type":"User","site_admin":false},"repo":{"id":116817916,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MTc5MTY=","name":"ballerina","full_name":"ayomawdb/ballerina","owner":{"login":"ayomawdb","id":612458,"node_id":"MDQ6VXNlcjYxMjQ1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/612458?v=4","gravatar_id":"","url":"https://api.github.com/users/ayomawdb","html_url":"https://github.com/ayomawdb","followers_url":"https://api.github.com/users/ayomawdb/followers","following_url":"https://api.github.com/users/ayomawdb/following{/other_user}","gists_url":"https://api.github.com/users/ayomawdb/gists{/gist_id}","starred_url":"https://api.github.com/users/ayomawdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayomawdb/subscriptions","organizations_url":"https://api.github.com/users/ayomawdb/orgs","repos_url":"https://api.github.com/users/ayomawdb/repos","events_url":"https://api.github.com/users/ayomawdb/events{/privacy}","received_events_url":"https://api.github.com/users/ayomawdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayomawdb/ballerina","description":"Ballerina is a new programming language for integration built on a sequence diagram metaphor.","fork":true,"url":"https://api.github.com/repos/ayomawdb/ballerina","forks_url":"https://api.github.com/repos/ayomawdb/ballerina/forks","keys_url":"https://api.github.com/repos/ayomawdb/ballerina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayomawdb/ballerina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayomawdb/ballerina/teams","hooks_url":"https://api.github.com/repos/ayomawdb/ballerina/hooks","issue_events_url":"https://api.github.com/repos/ayomawdb/ballerina/issues/events{/number}","events_url":"https://api.github.com/repos/ayomawdb/ballerina/events","assignees_url":"https://api.github.com/repos/ayomawdb/ballerina/assignees{/user}","branches_url":"https://api.github.com/repos/ayomawdb/ballerina/branches{/branch}","tags_url":"https://api.github.com/repos/ayomawdb/ballerina/tags","blobs_url":"https://api.github.com/repos/ayomawdb/ballerina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayomawdb/ballerina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayomawdb/ballerina/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayomawdb/ballerina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayomawdb/ballerina/statuses/{sha}","languages_url":"https://api.github.com/repos/ayomawdb/ballerina/languages","stargazers_url":"https://api.github.com/repos/ayomawdb/ballerina/stargazers","contributors_url":"https://api.github.com/repos/ayomawdb/ballerina/contributors","subscribers_url":"https://api.github.com/repos/ayomawdb/ballerina/subscribers","subscription_url":"https://api.github.com/repos/ayomawdb/ballerina/subscription","commits_url":"https://api.github.com/repos/ayomawdb/ballerina/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayomawdb/ballerina/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayomawdb/ballerina/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayomawdb/ballerina/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayomawdb/ballerina/contents/{+path}","compare_url":"https://api.github.com/repos/ayomawdb/ballerina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayomawdb/ballerina/merges","archive_url":"https://api.github.com/repos/ayomawdb/ballerina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayomawdb/ballerina/downloads","issues_url":"https://api.github.com/repos/ayomawdb/ballerina/issues{/number}","pulls_url":"https://api.github.com/repos/ayomawdb/ballerina/pulls{/number}","milestones_url":"https://api.github.com/repos/ayomawdb/ballerina/milestones{/number}","notifications_url":"https://api.github.com/repos/ayomawdb/ballerina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayomawdb/ballerina/labels{/name}","releases_url":"https://api.github.com/repos/ayomawdb/ballerina/releases{/id}","deployments_url":"https://api.github.com/repos/ayomawdb/ballerina/deployments","created_at":"2018-01-09T13:13:12Z","updated_at":"2018-07-13T05:11:10Z","pushed_at":"2018-07-13T05:51:01Z","git_url":"git://github.com/ayomawdb/ballerina.git","ssh_url":"git@github.com:ayomawdb/ballerina.git","clone_url":"https://github.com/ayomawdb/ballerina.git","svn_url":"https://github.com/ayomawdb/ballerina","homepage":"","size":242009,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ballerina-platform:next-release","ref":"next-release","sha":"31965c36552e85957f60c7965f97f56f669e12f1","user":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"node_id":"MDEwOlJlcG9zaXRvcnk3MzkzMDMwNQ==","name":"ballerina-lang","full_name":"ballerina-platform/ballerina-lang","owner":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ballerina-platform/ballerina-lang","description":"Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.","fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2018-07-13T04:55:35Z","pushed_at":"2018-07-13T06:07:24Z","git_url":"git://github.com/ballerina-platform/ballerina-lang.git","ssh_url":"git@github.com:ballerina-platform/ballerina-lang.git","clone_url":"https://github.com/ballerina-platform/ballerina-lang.git","svn_url":"https://github.com/ballerina-platform/ballerina-lang","homepage":"","size":242791,"stargazers_count":933,"watchers_count":933,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":507,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":347,"open_issues":507,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/9628"},"issue":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/9628"},"comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/9628/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/9628/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/db92c2eb2e9d94f1d0bb81556e925298ef72721a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"keizer619","id":2918812,"node_id":"MDQ6VXNlcjI5MTg4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2918812?v=4","gravatar_id":"","url":"https://api.github.com/users/keizer619","html_url":"https://github.com/keizer619","followers_url":"https://api.github.com/users/keizer619/followers","following_url":"https://api.github.com/users/keizer619/following{/other_user}","gists_url":"https://api.github.com/users/keizer619/gists{/gist_id}","starred_url":"https://api.github.com/users/keizer619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keizer619/subscriptions","organizations_url":"https://api.github.com/users/keizer619/orgs","repos_url":"https://api.github.com/users/keizer619/repos","events_url":"https://api.github.com/users/keizer619/events{/privacy}","received_events_url":"https://api.github.com/users/keizer619/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":39,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"keizer619"}}