{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/fili/pulls/comments/172271300","pull_request_review_id":101260243,"id":172271300,"diff_hunk":"@@ -541,7 +541,9 @@ protected ResponseContext addPaginationInfoToResponseContext(\n                 .map(pair -> Utils.withRight(pair, pair.getRight().getAsInt()))\n                 .map(pair -> Utils.withRight(\n                         pair,\n-                        uriInfo.getRequestUriBuilder().replaceQueryParam(\"page\", pair.getRight())\n+                        uriInfo.getRequestUriBuilder()\n+                                .replaceQueryParam(\"page\", pair.getRight())\n+                                .replaceQueryParam(\"perPage\", pages.getPerPage())","path":"fili-core/src/main/java/com/yahoo/bard/webservice/web/endpoints/JobsServlet.java","position":7,"original_position":7,"commit_id":"413606c2202bdffbfa126ece371d36e3b6d4b6d8","original_commit_id":"413606c2202bdffbfa126ece371d36e3b6d4b6d8","user":{"login":"michael-mclawhorn","id":4105159,"avatar_url":"https://avatars1.githubusercontent.com/u/4105159?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-mclawhorn","html_url":"https://github.com/michael-mclawhorn","followers_url":"https://api.github.com/users/michael-mclawhorn/followers","following_url":"https://api.github.com/users/michael-mclawhorn/following{/other_user}","gists_url":"https://api.github.com/users/michael-mclawhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-mclawhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-mclawhorn/subscriptions","organizations_url":"https://api.github.com/users/michael-mclawhorn/orgs","repos_url":"https://api.github.com/users/michael-mclawhorn/repos","events_url":"https://api.github.com/users/michael-mclawhorn/events{/privacy}","received_events_url":"https://api.github.com/users/michael-mclawhorn/received_events","type":"User","site_admin":false},"body":"You replaced \"page\" and \"perPage\" everywhere but here.","created_at":"2018-03-05T17:48:27Z","updated_at":"2018-03-05T17:48:27Z","html_url":"https://github.com/yahoo/fili/pull/641#discussion_r172271300","pull_request_url":"https://api.github.com/repos/yahoo/fili/pulls/641","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments/172271300"},"html":{"href":"https://github.com/yahoo/fili/pull/641#discussion_r172271300"},"pull_request":{"href":"https://api.github.com/repos/yahoo/fili/pulls/641"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/fili/pulls/641","id":172632283,"html_url":"https://github.com/yahoo/fili/pull/641","diff_url":"https://github.com/yahoo/fili/pull/641.diff","patch_url":"https://github.com/yahoo/fili/pull/641.patch","issue_url":"https://api.github.com/repos/yahoo/fili/issues/641","number":641,"state":"open","locked":false,"title":"Add Missing perPage Param","user":{"login":"QubitPi","id":16126939,"avatar_url":"https://avatars3.githubusercontent.com/u/16126939?v=4","gravatar_id":"","url":"https://api.github.com/users/QubitPi","html_url":"https://github.com/QubitPi","followers_url":"https://api.github.com/users/QubitPi/followers","following_url":"https://api.github.com/users/QubitPi/following{/other_user}","gists_url":"https://api.github.com/users/QubitPi/gists{/gist_id}","starred_url":"https://api.github.com/users/QubitPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubitPi/subscriptions","organizations_url":"https://api.github.com/users/QubitPi/orgs","repos_url":"https://api.github.com/users/QubitPi/repos","events_url":"https://api.github.com/users/QubitPi/events{/privacy}","received_events_url":"https://api.github.com/users/QubitPi/received_events","type":"User","site_admin":false},"body":"This PR fixes https://github.com/yahoo/fili/issues/640","created_at":"2018-03-02T23:50:06Z","updated_at":"2018-03-05T17:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"846028081f3fca253460e9d54c6cff7cc8c70181","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583260793,"url":"https://api.github.com/repos/yahoo/fili/labels/DEBUG","name":"DEBUG","color":"c5def5","default":false},{"id":433842333,"url":"https://api.github.com/repos/yahoo/fili/labels/NEED%202%20REVIEWS","name":"NEED 2 REVIEWS","color":"ff7f00","default":false},{"id":433842968,"url":"https://api.github.com/repos/yahoo/fili/labels/REVIEWABLE","name":"REVIEWABLE","color":"b391b5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fili/pulls/641/commits","review_comments_url":"https://api.github.com/repos/yahoo/fili/pulls/641/comments","review_comment_url":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fili/issues/641/comments","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/413606c2202bdffbfa126ece371d36e3b6d4b6d8","head":{"label":"yahoo:issue-640-add-missing-perPage-param","ref":"issue-640-add-missing-perPage-param","sha":"413606c2202bdffbfa126ece371d36e3b6d4b6d8","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2018-03-02T03:24:18Z","pushed_at":"2018-03-02T23:50:08Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":"","size":9258,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":205,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":49,"open_issues":205,"watchers":78,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"b84f494fe525239ac007c4c9fc2ca2a4ee06bfe6","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2018-03-02T03:24:18Z","pushed_at":"2018-03-02T23:50:08Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":"","size":9258,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":205,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":49,"open_issues":205,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/641"},"html":{"href":"https://github.com/yahoo/fili/pull/641"},"issue":{"href":"https://api.github.com/repos/yahoo/fili/issues/641"},"comments":{"href":"https://api.github.com/repos/yahoo/fili/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fili/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fili/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fili/statuses/413606c2202bdffbfa126ece371d36e3b6d4b6d8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"michael-mclawhorn"}}