{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/198845451","pull_request_review_id":132843920,"id":198845451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODg0NTQ1MQ==","diff_hunk":"@@ -1,144 +0,0 @@\n-// Copyright 2017 Canonical Ltd.\n-// Licensed under the AGPLv3, see LICENCE file for details.\n-\n-package lxdclient\n-","path":"tools/lxdclient/client_storage.go","position":5,"original_position":5,"commit_id":"8bccd7580eff3443f46eb0c2aea33032292e26d2","original_commit_id":"8bccd7580eff3443f46eb0c2aea33032292e26d2","user":{"login":"jameinel","id":202877,"node_id":"MDQ6VXNlcjIwMjg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/202877?v=4","gravatar_id":"","url":"https://api.github.com/users/jameinel","html_url":"https://github.com/jameinel","followers_url":"https://api.github.com/users/jameinel/followers","following_url":"https://api.github.com/users/jameinel/following{/other_user}","gists_url":"https://api.github.com/users/jameinel/gists{/gist_id}","starred_url":"https://api.github.com/users/jameinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameinel/subscriptions","organizations_url":"https://api.github.com/users/jameinel/orgs","repos_url":"https://api.github.com/users/jameinel/repos","events_url":"https://api.github.com/users/jameinel/events{/privacy}","received_events_url":"https://api.github.com/users/jameinel/received_events","type":"User","site_admin":false},"body":"always a pleasure to see","created_at":"2018-06-28T13:45:38Z","updated_at":"2018-06-28T13:46:18Z","html_url":"https://github.com/juju/juju/pull/8862#discussion_r198845451","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8862","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/198845451"},"html":{"href":"https://github.com/juju/juju/pull/8862#discussion_r198845451"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8862"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8862","id":197724685,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzI0Njg1","html_url":"https://github.com/juju/juju/pull/8862","diff_url":"https://github.com/juju/juju/pull/8862.diff","patch_url":"https://github.com/juju/juju/pull/8862.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8862","number":8862,"state":"open","locked":false,"title":"Lxd Provider Uses Storage Concerns from New LXD Server","user":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nRemoves storage functionality from tools/lxdclient and replaces usage of these concerns in LXD provider with implementations in container/lxd.\r\n\r\nThis is the last of the methods from the old LXD client, which can now be deleted along with rawProvider, allowing the LXD provider to use the new LXD server directly.\r\n\r\n## QA steps\r\n\r\nBootstrapping and deploying to LXD continues to work as before.\r\n\r\n## Documentation changes\r\n\r\nNone.\r\n\r\n## Bug reference\r\n\r\nN/A\r\n","created_at":"2018-06-27T13:00:23Z","updated_at":"2018-06-28T13:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a72fe561c6a56f98947fd94d4bec3b4264ea4ee0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8862/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8862/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8862/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/8bccd7580eff3443f46eb0c2aea33032292e26d2","head":{"label":"manadart:lxd-provider-storage-use-server","ref":"lxd-provider-storage-use-server","sha":"8bccd7580eff3443f46eb0c2aea33032292e26d2","user":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"repo":{"id":113540853,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1NDA4NTM=","name":"juju","full_name":"manadart/juju","owner":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manadart/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/manadart/juju","forks_url":"https://api.github.com/repos/manadart/juju/forks","keys_url":"https://api.github.com/repos/manadart/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manadart/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manadart/juju/teams","hooks_url":"https://api.github.com/repos/manadart/juju/hooks","issue_events_url":"https://api.github.com/repos/manadart/juju/issues/events{/number}","events_url":"https://api.github.com/repos/manadart/juju/events","assignees_url":"https://api.github.com/repos/manadart/juju/assignees{/user}","branches_url":"https://api.github.com/repos/manadart/juju/branches{/branch}","tags_url":"https://api.github.com/repos/manadart/juju/tags","blobs_url":"https://api.github.com/repos/manadart/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manadart/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manadart/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/manadart/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manadart/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/manadart/juju/languages","stargazers_url":"https://api.github.com/repos/manadart/juju/stargazers","contributors_url":"https://api.github.com/repos/manadart/juju/contributors","subscribers_url":"https://api.github.com/repos/manadart/juju/subscribers","subscription_url":"https://api.github.com/repos/manadart/juju/subscription","commits_url":"https://api.github.com/repos/manadart/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/manadart/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/manadart/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/manadart/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/manadart/juju/contents/{+path}","compare_url":"https://api.github.com/repos/manadart/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manadart/juju/merges","archive_url":"https://api.github.com/repos/manadart/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manadart/juju/downloads","issues_url":"https://api.github.com/repos/manadart/juju/issues{/number}","pulls_url":"https://api.github.com/repos/manadart/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/manadart/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/manadart/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manadart/juju/labels{/name}","releases_url":"https://api.github.com/repos/manadart/juju/releases{/id}","deployments_url":"https://api.github.com/repos/manadart/juju/deployments","created_at":"2017-12-08T06:38:11Z","updated_at":"2018-06-28T13:17:45Z","pushed_at":"2018-06-28T13:17:44Z","git_url":"git://github.com/manadart/juju.git","ssh_url":"git@github.com:manadart/juju.git","clone_url":"https://github.com/manadart/juju.git","svn_url":"https://github.com/manadart/juju","homepage":"juju.ubuntu.com","size":213577,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"1cc0b4642cacd92df9b9b61d5d1772d687017f1e","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-06-28T13:11:34Z","pushed_at":"2018-06-28T13:34:15Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":213563,"stargazers_count":1174,"watchers_count":1174,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":272,"open_issues":18,"watchers":1174,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8862"},"html":{"href":"https://github.com/juju/juju/pull/8862"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8862"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8862/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8862/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8862/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/8bccd7580eff3443f46eb0c2aea33032292e26d2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jameinel"}}