{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/174109200","pull_request_review_id":103393424,"id":174109200,"diff_hunk":"@@ -0,0 +1,92 @@\n+---\n+layout: \"aws\"\n+page_title: \"AWS: aws_wafregional_web_acl\"\n+sidebar_current: \"docs-aws-resource-wafregional-web-acl\"\n+description: |-\n+  Provides a AWS WAF Regional web access control group (ACL) resource for use with ALB.\n+---\n+\n+# aws\\_wafregional\\_web\\_acl\n+\n+Provides a WAF Regional Web ACL Resource for use with Application Load Balancer.\n+\n+## Example Usage\n+\n+```hcl\n+resource \"aws_wafregional_ipset\" \"ipset\" {\n+  name = \"tfIPSet\"\n+  \n+  ip_set_descriptors {\n+    type  = \"IPV4\"\n+    value = \"192.0.7.0/24\"\n+  }\n+}\n+\n+resource \"aws_wafregional_rule\" \"wafrule\" {\n+  depends_on  = [\"aws_wafregional_ipset.ipset\"]\n+  name        = \"tfWAFRule\"\n+  metric_name = \"tfWAFRule\"\n+  \n+  predicates {\n+    data_id = \"${aws_wafregional_ipset.ipset.id}\"\n+    negated = false\n+    type    = \"IPMatch\"\n+  }\n+}\n+\n+resource \"aws_wafregional_web_acl\" \"wafacl\" {\n+  depends_on  = [\"aws_wafregional_ipset.ipset\", \"aws_wafregional_rule.wafrule\"]","path":"website/docs/r/wafregional_web_acl.html.markdown","position":38,"original_position":38,"commit_id":"819ade1f0c17489489f82da03cb9a18def6c8a2c","original_commit_id":"819ade1f0c17489489f82da03cb9a18def6c8a2c","user":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars1.githubusercontent.com/u/287584?v=4","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"body":"This is redundant because the relationship is already built by the reference `${aws_wafregional_rule.wafrule.id}` below and further reference inside the rule. Do you mind removing it?","created_at":"2018-03-13T12:23:53Z","updated_at":"2018-03-13T12:26:05Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754#discussion_r174109200","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/174109200"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754#discussion_r174109200"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754","id":174514670,"html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3754","number":3754,"state":"open","locked":false,"title":"New Resource: aws_wafregional_web_acl","user":{"login":"pvanbuijtene","id":7116354,"avatar_url":"https://avatars0.githubusercontent.com/u/7116354?v=4","gravatar_id":"","url":"https://api.github.com/users/pvanbuijtene","html_url":"https://github.com/pvanbuijtene","followers_url":"https://api.github.com/users/pvanbuijtene/followers","following_url":"https://api.github.com/users/pvanbuijtene/following{/other_user}","gists_url":"https://api.github.com/users/pvanbuijtene/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanbuijtene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanbuijtene/subscriptions","organizations_url":"https://api.github.com/users/pvanbuijtene/orgs","repos_url":"https://api.github.com/users/pvanbuijtene/repos","events_url":"https://api.github.com/users/pvanbuijtene/events{/privacy}","received_events_url":"https://api.github.com/users/pvanbuijtene/received_events","type":"User","site_admin":false},"body":"Trying to help a bit to finish the WAF Regional PRs, this is the result of the split up of #3199\r\n\r\nRelated PRs: #1046 hashicorp/terraform#13711\r\n\r\nThanks to the contributors: @yusukegoto @DennyLoko @BSick7","created_at":"2018-03-12T22:42:52Z","updated_at":"2018-03-13T12:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80f84392e51ee260bd642e9650a3495861bf00d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":625892945,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/new-resource","name":"new-resource","color":"d4c5f9","default":false},{"id":801971624,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/waf","name":"service/waf","color":"bfd4f2","default":false},{"id":737832191,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XL","name":"size/XL","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3754/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/819ade1f0c17489489f82da03cb9a18def6c8a2c","head":{"label":"pvanbuijtene:wafregional-web-acl","ref":"wafregional-web-acl","sha":"819ade1f0c17489489f82da03cb9a18def6c8a2c","user":{"login":"pvanbuijtene","id":7116354,"avatar_url":"https://avatars0.githubusercontent.com/u/7116354?v=4","gravatar_id":"","url":"https://api.github.com/users/pvanbuijtene","html_url":"https://github.com/pvanbuijtene","followers_url":"https://api.github.com/users/pvanbuijtene/followers","following_url":"https://api.github.com/users/pvanbuijtene/following{/other_user}","gists_url":"https://api.github.com/users/pvanbuijtene/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanbuijtene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanbuijtene/subscriptions","organizations_url":"https://api.github.com/users/pvanbuijtene/orgs","repos_url":"https://api.github.com/users/pvanbuijtene/repos","events_url":"https://api.github.com/users/pvanbuijtene/events{/privacy}","received_events_url":"https://api.github.com/users/pvanbuijtene/received_events","type":"User","site_admin":false},"repo":{"id":124689068,"name":"terraform-provider-aws","full_name":"pvanbuijtene/terraform-provider-aws","owner":{"login":"pvanbuijtene","id":7116354,"avatar_url":"https://avatars0.githubusercontent.com/u/7116354?v=4","gravatar_id":"","url":"https://api.github.com/users/pvanbuijtene","html_url":"https://github.com/pvanbuijtene","followers_url":"https://api.github.com/users/pvanbuijtene/followers","following_url":"https://api.github.com/users/pvanbuijtene/following{/other_user}","gists_url":"https://api.github.com/users/pvanbuijtene/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanbuijtene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanbuijtene/subscriptions","organizations_url":"https://api.github.com/users/pvanbuijtene/orgs","repos_url":"https://api.github.com/users/pvanbuijtene/repos","events_url":"https://api.github.com/users/pvanbuijtene/events{/privacy}","received_events_url":"https://api.github.com/users/pvanbuijtene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvanbuijtene/terraform-provider-aws","description":"Terraform AWS provider","fork":true,"url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws","forks_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/pvanbuijtene/terraform-provider-aws/deployments","created_at":"2018-03-10T18:55:28Z","updated_at":"2018-03-10T18:55:34Z","pushed_at":"2018-03-12T22:32:03Z","git_url":"git://github.com/pvanbuijtene/terraform-provider-aws.git","ssh_url":"git@github.com:pvanbuijtene/terraform-provider-aws.git","clone_url":"https://github.com/pvanbuijtene/terraform-provider-aws.git","svn_url":"https://github.com/pvanbuijtene/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":31646,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"3382b984843a1b3b52c183fb308537f716536384","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-03-13T12:25:24Z","pushed_at":"2018-03-13T12:09:30Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":31854,"stargazers_count":895,"watchers_count":895,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":821,"mirror_url":null,"archived":false,"open_issues_count":1775,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":821,"open_issues":1775,"watchers":895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/3754"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3754"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3754/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3754/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/819ade1f0c17489489f82da03cb9a18def6c8a2c"}},"author_association":"NONE"}}
{"actor":{"display_login":"radeksimko"}}