{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/240805947","pull_request_review_id":183922488,"id":240805947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgwNTk0Nw==","diff_hunk":"@@ -110,11 +114,15 @@ export function compileNgModuleDefs(moduleType: Type<any>, ngModule: NgModule):\n       return ngModuleDef;\n     }\n   });\n+  if (ngModule.id) {\n+    registerNgModuleType(ngModule.id, moduleType);\n+  }\n \n   let ngInjectorDef: any = null;\n   Object.defineProperty(moduleType, NG_INJECTOR_DEF, {\n     get: () => {\n       if (ngInjectorDef === null) {\n+        verifySemanticsOfNgModuleDef(moduleType as unknown as NgModuleType, ngModule);","path":"packages/core/src/render3/jit/module.ts","position":47,"original_position":47,"commit_id":"2ba9011c7355d17b6d7c219b99f20b1d36688c74","original_commit_id":"8197b6dd3b9a3e2720fa96ef9728ae7fd845cfd9","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"good idea, done.","created_at":"2018-12-11T21:54:55Z","updated_at":"2018-12-11T21:54:55Z","html_url":"https://github.com/angular/angular/pull/27604#discussion_r240805947","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/27604","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/240805947"},"html":{"href":"https://github.com/angular/angular/pull/27604#discussion_r240805947"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/27604"}},"in_reply_to_id":240751056},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27604","id":237787054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Nzg3MDU0","html_url":"https://github.com/angular/angular/pull/27604","diff_url":"https://github.com/angular/angular/pull/27604.diff","patch_url":"https://github.com/angular/angular/pull/27604.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/27604","number":27604,"state":"open","locked":false,"title":"fix(ivy): check semantics of NgModule for consistency","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"`NgModule` requires that `Component`s/`Directive`s/`Pipe`s are listed in\r\ndeclarations, and that each `Component`s/`Directive`s/`Pipe` is declared\r\nin exactly one `NgModule`. This change adds runtime checks to ensure\r\nthat these sementics are true at runtime.\r\n\r\nThere will need to be seperate set of checks for the AoT path of the\r\ncodebase to verify that same set of semantics hold. Due to current\r\ndesign there does not seem to be an easy way to share the two checks\r\nbecause JIT deal with references where as AoT deals with AST nodes.\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [n/a] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n- [X] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [X] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Documentation content changes\r\n- [ ] angular.io application / infrastructure changes\r\n- [ ] Other... Please describe:\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [X] No\r\n\r\n","created_at":"2018-12-11T18:43:59Z","updated_at":"2018-12-11T21:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e3cc88ad26b12fc832b3a7034cbe21be2503c96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":217969169,"node_id":"MDU6TGFiZWwyMTc5NjkxNjk=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":660621334,"node_id":"MDU6TGFiZWw2NjA2MjEzMzQ=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476288,"node_id":"MDU6TGFiZWwxNDk0NzYyODg=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20no","name":"cla: no","color":"e11d21","default":false},{"id":799860804,"node_id":"MDU6TGFiZWw3OTk4NjA4MDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false},{"id":130606843,"node_id":"MDU6TGFiZWwxMzA2MDY4NDM=","url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":178,"closed_issues":1054,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-12-11T21:02:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/27604/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/27604/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/27604/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/2ba9011c7355d17b6d7c219b99f20b1d36688c74","head":{"label":"mhevery:fw-682","ref":"fw-682","sha":"2ba9011c7355d17b6d7c219b99f20b1d36688c74","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"repo":{"id":24658749,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY1ODc0OQ==","name":"angular","full_name":"mhevery/angular","private":false,"owner":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhevery/angular","description":null,"fork":true,"url":"https://api.github.com/repos/mhevery/angular","forks_url":"https://api.github.com/repos/mhevery/angular/forks","keys_url":"https://api.github.com/repos/mhevery/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhevery/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhevery/angular/teams","hooks_url":"https://api.github.com/repos/mhevery/angular/hooks","issue_events_url":"https://api.github.com/repos/mhevery/angular/issues/events{/number}","events_url":"https://api.github.com/repos/mhevery/angular/events","assignees_url":"https://api.github.com/repos/mhevery/angular/assignees{/user}","branches_url":"https://api.github.com/repos/mhevery/angular/branches{/branch}","tags_url":"https://api.github.com/repos/mhevery/angular/tags","blobs_url":"https://api.github.com/repos/mhevery/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhevery/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhevery/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhevery/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhevery/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/mhevery/angular/languages","stargazers_url":"https://api.github.com/repos/mhevery/angular/stargazers","contributors_url":"https://api.github.com/repos/mhevery/angular/contributors","subscribers_url":"https://api.github.com/repos/mhevery/angular/subscribers","subscription_url":"https://api.github.com/repos/mhevery/angular/subscription","commits_url":"https://api.github.com/repos/mhevery/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhevery/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhevery/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhevery/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhevery/angular/contents/{+path}","compare_url":"https://api.github.com/repos/mhevery/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhevery/angular/merges","archive_url":"https://api.github.com/repos/mhevery/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhevery/angular/downloads","issues_url":"https://api.github.com/repos/mhevery/angular/issues{/number}","pulls_url":"https://api.github.com/repos/mhevery/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/mhevery/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/mhevery/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhevery/angular/labels{/name}","releases_url":"https://api.github.com/repos/mhevery/angular/releases{/id}","deployments_url":"https://api.github.com/repos/mhevery/angular/deployments","created_at":"2014-09-30T22:59:23Z","updated_at":"2018-07-25T17:24:32Z","pushed_at":"2018-12-11T21:47:51Z","git_url":"git://github.com/mhevery/angular.git","ssh_url":"git@github.com:mhevery/angular.git","clone_url":"https://github.com/mhevery/angular.git","svn_url":"https://github.com/mhevery/angular","homepage":null,"size":92322,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"3290fc3365819bb5069332ae280a2cc5b2a71a67","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-12-11T21:47:40Z","pushed_at":"2018-12-11T21:48:53Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":95841,"stargazers_count":43415,"watchers_count":43415,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11126,"mirror_url":null,"archived":false,"open_issues_count":2615,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11126,"open_issues":2615,"watchers":43415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/27604"},"html":{"href":"https://github.com/angular/angular/pull/27604"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/27604"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/27604/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/27604/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/27604/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/2ba9011c7355d17b6d7c219b99f20b1d36688c74"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mhevery"}}