{"action":"created","issue":{"url":"https://api.github.com/repos/spack/spack/issues/9153","repository_url":"https://api.github.com/repos/spack/spack","labels_url":"https://api.github.com/repos/spack/spack/issues/9153/labels{/name}","comments_url":"https://api.github.com/repos/spack/spack/issues/9153/comments","events_url":"https://api.github.com/repos/spack/spack/issues/9153/events","html_url":"https://github.com/spack/spack/pull/9153","id":356122937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDkzNDg2","number":9153,"title":"Fix two dependencies with silo.","user":{"login":"drwells","id":3917035,"node_id":"MDQ6VXNlcjM5MTcwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/3917035?v=4","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-31T21:03:00Z","updated_at":"2018-08-31T22:17:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/9153","html_url":"https://github.com/spack/spack/pull/9153","diff_url":"https://github.com/spack/spack/pull/9153.diff","patch_url":"https://github.com/spack/spack/pull/9153.patch"},"body":"1. I presently get errors of the sort\r\n```\r\n==> Error: KeyError: 'No spec with name mpi in silo@4.10.2%gcc@8.1.0+fortran+mpi\r\n[...]\r\n$HOME/spack/var/spack/repos/builtin/packages/silo/package.py:84, in configure_args:\r\n         81                'FCFLAGS={0}'.format(self.compiler.pic_flag)]\r\n         82\r\n         83        if '+mpi' in self.spec:\r\n  >>     84            config_args.append('CC=%s' % self.spec['mpi'].mpicc)\r\n         85            config_args.append('CXX=%s' % self.spec['mpi'].mpicxx)\r\n         86            config_args.append('FC=%s' % self.spec['mpi'].mpifc)\r\n```\r\nwithout the extra explicit MPI dependency. I am a bit of a spack novice; I don't really understand why we need to explicitly write out the dependency when `+mpi` is in the spec, though a lot of other packages (e.g., Zoltan) do it.\r\n\r\n2. Silo uses zlib, so we should explicitly depend on it.\r\n\r\nEdit: clarify the MPI error message"},"comment":{"url":"https://api.github.com/repos/spack/spack/issues/comments/417803105","html_url":"https://github.com/spack/spack/pull/9153#issuecomment-417803105","issue_url":"https://api.github.com/repos/spack/spack/issues/9153","id":417803105,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzgwMzEwNQ==","user":{"login":"davydden","id":8023934,"node_id":"MDQ6VXNlcjgwMjM5MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8023934?v=4","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T22:17:04Z","updated_at":"2018-08-31T22:17:04Z","author_association":"MEMBER","body":"p.s. \r\n\r\n> I don't really understand why we need to explicitly write out the dependency when +mpi is in the spec\r\n\r\n`+mpi` is just a variant name:\r\n\r\n```\r\n     variant('mpi', default=True,\r\n             description='Compile with MPI Compatibility')\r\n```\r\n\r\nwhat package should do with it, is up to it. There is no automatic relationship between `+mpi` variant and dependency on `mpi` package. Therefore packages would normally have\r\n\r\n```\r\ndepends_on(mpi, when='+mpi')\r\n```"}}
{"actor":{"display_login":"davydden"}}