{"action":"created","comment":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/comments/203843021","pull_request_review_id":138816244,"id":203843021,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzg0MzAyMQ==","diff_hunk":"@@ -44,14 +44,15 @@ int xdag_free_all(void)\n #include <sys/mman.h>\n #include <errno.h>\n \n-#define MEM_PORTION     ((size_t)1 << 25)\n+#define MEM_PORTION     \t((size_t)1 << 25)\n+#define TMPFILE_TEMPLATE \t\"xdag-tmp-XXXXXX\"\n \n static int g_fd = -1;\n static size_t g_pos = 0, g_fsize = 0, g_size = 0;\n static void *g_mem;\n static pthread_mutex_t g_mem_mutex = PTHREAD_MUTEX_INITIALIZER;\n static char g_tmpfile_path[1024] = \"\";\n-static char g_tmpname[64] = \"xdag-tmp-XXXXXX\";\n+static char g_tmpfile_to_remove[1088];","path":"client/memory.c","position":20,"original_position":20,"commit_id":"d6e66a807cf0d5251f2964f8b53225296a1886f8","original_commit_id":"d6e66a807cf0d5251f2964f8b53225296a1886f8","user":{"login":"jonano614","id":6870809,"node_id":"MDQ6VXNlcjY4NzA4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6870809?v=4","gravatar_id":"","url":"https://api.github.com/users/jonano614","html_url":"https://github.com/jonano614","followers_url":"https://api.github.com/users/jonano614/followers","following_url":"https://api.github.com/users/jonano614/following{/other_user}","gists_url":"https://api.github.com/users/jonano614/gists{/gist_id}","starred_url":"https://api.github.com/users/jonano614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonano614/subscriptions","organizations_url":"https://api.github.com/users/jonano614/orgs","repos_url":"https://api.github.com/users/jonano614/repos","events_url":"https://api.github.com/users/jonano614/events{/privacy}","received_events_url":"https://api.github.com/users/jonano614/received_events","type":"User","site_admin":false},"body":"Why 1088? :)","created_at":"2018-07-19T19:22:42Z","updated_at":"2018-07-19T19:22:42Z","html_url":"https://github.com/XDagger/xdag/pull/268#discussion_r203843021","pull_request_url":"https://api.github.com/repos/XDagger/xdag/pulls/268","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments/203843021"},"html":{"href":"https://github.com/XDagger/xdag/pull/268#discussion_r203843021"},"pull_request":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/268","id":202587458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTg3NDU4","html_url":"https://github.com/XDagger/xdag/pull/268","diff_url":"https://github.com/XDagger/xdag/pull/268.diff","patch_url":"https://github.com/XDagger/xdag/pull/268.patch","issue_url":"https://api.github.com/repos/XDagger/xdag/issues/268","number":268,"state":"open","locked":false,"title":"Bugfix exit/termination freeze and tmpfile not deleted","user":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"body":"ftruncate does not return in some circumstance and doesn't let xdag close correctly\r\nand name of file to remove was wrong in remove function","created_at":"2018-07-19T14:54:19Z","updated_at":"2018-07-19T19:22:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3ae508571edafbbbcc92b38b703749d946cb113","assignee":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"assignees":[{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":975124383,"node_id":"MDU6TGFiZWw5NzUxMjQzODM=","url":"https://api.github.com/repos/XDagger/xdag/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/XDagger/xdag/pulls/268/commits","review_comments_url":"https://api.github.com/repos/XDagger/xdag/pulls/268/comments","review_comment_url":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XDagger/xdag/issues/268/comments","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/d6e66a807cf0d5251f2964f8b53225296a1886f8","head":{"label":"sgaragagghu:patch-6","ref":"patch-6","sha":"d6e66a807cf0d5251f2964f8b53225296a1886f8","user":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"repo":{"id":128134063,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMzQwNjM=","name":"xdag-commented","full_name":"sgaragagghu/xdag-commented","owner":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgaragagghu/xdag-commented","description":"XDAG Cryptocurrency COMMENTED REPOSITORY","fork":true,"url":"https://api.github.com/repos/sgaragagghu/xdag-commented","forks_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/forks","keys_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/teams","hooks_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/hooks","issue_events_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues/events{/number}","events_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/events","assignees_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/assignees{/user}","branches_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/branches{/branch}","tags_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/tags","blobs_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/statuses/{sha}","languages_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/languages","stargazers_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/stargazers","contributors_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/contributors","subscribers_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/subscribers","subscription_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/subscription","commits_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/contents/{+path}","compare_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/merges","archive_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/downloads","issues_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues{/number}","pulls_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/pulls{/number}","milestones_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/milestones{/number}","notifications_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/labels{/name}","releases_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/releases{/id}","deployments_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/deployments","created_at":"2018-04-04T23:21:48Z","updated_at":"2018-07-08T23:03:21Z","pushed_at":"2018-07-19T18:41:59Z","git_url":"git://github.com/sgaragagghu/xdag-commented.git","ssh_url":"git@github.com:sgaragagghu/xdag-commented.git","clone_url":"https://github.com/sgaragagghu/xdag-commented.git","svn_url":"https://github.com/sgaragagghu/xdag-commented","homepage":"","size":6685,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"Comment-1"}},"base":{"label":"XDagger:develop","ref":"develop","sha":"a0c8957c18d60fb97b51e6fb136d01b07b6485d5","user":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"repo":{"id":117907222,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDcyMjI=","name":"xdag","full_name":"XDagger/xdag","owner":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XDagger/xdag","description":"XDAG (Dagger Coin) Official Main Repository.  XDAG is a novel DAG based cryptocurrency.","fork":true,"url":"https://api.github.com/repos/XDagger/xdag","forks_url":"https://api.github.com/repos/XDagger/xdag/forks","keys_url":"https://api.github.com/repos/XDagger/xdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XDagger/xdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XDagger/xdag/teams","hooks_url":"https://api.github.com/repos/XDagger/xdag/hooks","issue_events_url":"https://api.github.com/repos/XDagger/xdag/issues/events{/number}","events_url":"https://api.github.com/repos/XDagger/xdag/events","assignees_url":"https://api.github.com/repos/XDagger/xdag/assignees{/user}","branches_url":"https://api.github.com/repos/XDagger/xdag/branches{/branch}","tags_url":"https://api.github.com/repos/XDagger/xdag/tags","blobs_url":"https://api.github.com/repos/XDagger/xdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XDagger/xdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XDagger/xdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/XDagger/xdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/{sha}","languages_url":"https://api.github.com/repos/XDagger/xdag/languages","stargazers_url":"https://api.github.com/repos/XDagger/xdag/stargazers","contributors_url":"https://api.github.com/repos/XDagger/xdag/contributors","subscribers_url":"https://api.github.com/repos/XDagger/xdag/subscribers","subscription_url":"https://api.github.com/repos/XDagger/xdag/subscription","commits_url":"https://api.github.com/repos/XDagger/xdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/XDagger/xdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/XDagger/xdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/XDagger/xdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/XDagger/xdag/contents/{+path}","compare_url":"https://api.github.com/repos/XDagger/xdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XDagger/xdag/merges","archive_url":"https://api.github.com/repos/XDagger/xdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XDagger/xdag/downloads","issues_url":"https://api.github.com/repos/XDagger/xdag/issues{/number}","pulls_url":"https://api.github.com/repos/XDagger/xdag/pulls{/number}","milestones_url":"https://api.github.com/repos/XDagger/xdag/milestones{/number}","notifications_url":"https://api.github.com/repos/XDagger/xdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XDagger/xdag/labels{/name}","releases_url":"https://api.github.com/repos/XDagger/xdag/releases{/id}","deployments_url":"https://api.github.com/repos/XDagger/xdag/deployments","created_at":"2018-01-17T23:55:56Z","updated_at":"2018-07-19T15:48:16Z","pushed_at":"2018-07-19T19:21:27Z","git_url":"git://github.com/XDagger/xdag.git","ssh_url":"git@github.com:XDagger/xdag.git","clone_url":"https://github.com/XDagger/xdag.git","svn_url":"https://github.com/XDagger/xdag","homepage":"http://xdag.io","size":6317,"stargazers_count":198,"watchers_count":198,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":86,"open_issues":29,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/268"},"html":{"href":"https://github.com/XDagger/xdag/pull/268"},"issue":{"href":"https://api.github.com/repos/XDagger/xdag/issues/268"},"comments":{"href":"https://api.github.com/repos/XDagger/xdag/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/XDagger/xdag/statuses/d6e66a807cf0d5251f2964f8b53225296a1886f8"}},"author_association":"NONE"}}
{"actor":{"display_login":"jonano614"}}