{"action":"created","issue":{"url":"https://api.github.com/repos/jdbi/jdbi/issues/1086","repository_url":"https://api.github.com/repos/jdbi/jdbi","labels_url":"https://api.github.com/repos/jdbi/jdbi/issues/1086/labels{/name}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/1086/comments","events_url":"https://api.github.com/repos/jdbi/jdbi/issues/1086/events","html_url":"https://github.com/jdbi/jdbi/pull/1086","id":315981393,"number":1086,"title":"WIP fix #988 default arguments/mappers","user":{"login":"TheRealMarnes","id":3950300,"avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-19T18:02:35Z","updated_at":"2018-04-23T22:45:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/1086","html_url":"https://github.com/jdbi/jdbi/pull/1086","diff_url":"https://github.com/jdbi/jdbi/pull/1086.diff","patch_url":"https://github.com/jdbi/jdbi/pull/1086.patch"},"body":"#988\r\n\r\nI've had a look through the code. \"Fixing\" the arguments and mappers is simple enough, but I think some other `Config` classes have the same issue, there are other OOTB impls being registered by default.\r\n\r\nI think it's best to separate it all, make a \"dumb\" no-assumptions core with all the convenient impls provided separately in `Plugin`s, and pre-installed in some of the methods in `Jdbi` to keep compatibility. Separation of church and state or API and impl if you will, so we'd have a `PrimitivesPlugin`, `BuiltInCollectorsPlugin` and the like. They could all be composed into a single `JdbiDefaultsPlugin`.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/jdbi/jdbi/issues/comments/383746460","html_url":"https://github.com/jdbi/jdbi/pull/1086#issuecomment-383746460","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/1086","id":383746460,"user":{"login":"TheRealMarnes","id":3950300,"avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T22:45:37Z","updated_at":"2018-04-23T22:45:37Z","author_association":"CONTRIBUTOR","body":"Ooooh I totally missed that there's a `ColumnMapperFactory`! I thought it was only `ArgumentFactory` and then `ColumnMapper`s matched by type. Yeah, that will probably work then, will see tomorrow"}}
{"actor":{"display_login":"TheRealMarnes"}}