{"action":"created","comment":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments/192048093","pull_request_review_id":124742126,"id":192048093,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjA0ODA5Mw==","diff_hunk":"@@ -37,29 +37,24 @@ void mini1(const char* path)\n {\n     ExifData exifData;\n     Blob blob;\n-    WriteMethod wm;\n \n     // Write nothing to a new structure, without a previous binary image\n-    wm = ExifParser::encode(blob, 0, 0, bigEndian, exifData);\n-    assert(wm == wmIntrusive);","path":"samples/tiff-test.cpp","position":8,"original_position":8,"commit_id":"30963af3fab5181f3303e21bcb3b79d1065575d7","original_commit_id":"aefaf65342765b2d6e167603345b70ea485928dc","user":{"login":"D4N","id":786021,"node_id":"MDQ6VXNlcjc4NjAyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/786021?v=4","gravatar_id":"","url":"https://api.github.com/users/D4N","html_url":"https://github.com/D4N","followers_url":"https://api.github.com/users/D4N/followers","following_url":"https://api.github.com/users/D4N/following{/other_user}","gists_url":"https://api.github.com/users/D4N/gists{/gist_id}","starred_url":"https://api.github.com/users/D4N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D4N/subscriptions","organizations_url":"https://api.github.com/users/D4N/orgs","repos_url":"https://api.github.com/users/D4N/repos","events_url":"https://api.github.com/users/D4N/events{/privacy}","received_events_url":"https://api.github.com/users/D4N/received_events","type":"User","site_admin":false},"body":"Ah, sorry, I kind of didn't get the point of removing the `assert`. But I just remembered that cmake defines `NDEBUG` in Release builds and then the variable is indeed useless.\r\n\r\n`enforce` is probably the way to go here for now.\r\n\r\n(I just realized that we then did not test this stuff in Release builds...)","created_at":"2018-05-31T09:58:45Z","updated_at":"2018-05-31T09:58:45Z","html_url":"https://github.com/Exiv2/exiv2/pull/326#discussion_r192048093","pull_request_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/326","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments/192048093"},"html":{"href":"https://github.com/Exiv2/exiv2/pull/326#discussion_r192048093"},"pull_request":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/326"}},"in_reply_to_id":191011592},"pull_request":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/326","id":190595183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTk1MTgz","html_url":"https://github.com/Exiv2/exiv2/pull/326","diff_url":"https://github.com/Exiv2/exiv2/pull/326.diff","patch_url":"https://github.com/Exiv2/exiv2/pull/326.patch","issue_url":"https://api.github.com/repos/Exiv2/exiv2/issues/326","number":326,"state":"open","locked":false,"title":"Fix warnings","user":{"login":"piponazo","id":102645,"node_id":"MDQ6VXNlcjEwMjY0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"body":"In this PR I took care of fixing most of the warnings that are reported by GCC.\r\n\r\nThere are still some warnings that I will address separately since they need a deeper analysis.","created_at":"2018-05-25T13:51:34Z","updated_at":"2018-05-31T09:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f97c78ae722359926c81ca45895214252c29b859","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/326/commits","review_comments_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/326/comments","review_comment_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/issues/326/comments","statuses_url":"https://api.github.com/repos/Exiv2/exiv2/statuses/30963af3fab5181f3303e21bcb3b79d1065575d7","head":{"label":"piponazo:fixWarnings","ref":"fixWarnings","sha":"30963af3fab5181f3303e21bcb3b79d1065575d7","user":{"login":"piponazo","id":102645,"node_id":"MDQ6VXNlcjEwMjY0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"repo":{"id":99720872,"node_id":"MDEwOlJlcG9zaXRvcnk5OTcyMDg3Mg==","name":"exiv2","full_name":"piponazo/exiv2","owner":{"login":"piponazo","id":102645,"node_id":"MDQ6VXNlcjEwMjY0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piponazo/exiv2","description":"Image metadata library and tools","fork":true,"url":"https://api.github.com/repos/piponazo/exiv2","forks_url":"https://api.github.com/repos/piponazo/exiv2/forks","keys_url":"https://api.github.com/repos/piponazo/exiv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piponazo/exiv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piponazo/exiv2/teams","hooks_url":"https://api.github.com/repos/piponazo/exiv2/hooks","issue_events_url":"https://api.github.com/repos/piponazo/exiv2/issues/events{/number}","events_url":"https://api.github.com/repos/piponazo/exiv2/events","assignees_url":"https://api.github.com/repos/piponazo/exiv2/assignees{/user}","branches_url":"https://api.github.com/repos/piponazo/exiv2/branches{/branch}","tags_url":"https://api.github.com/repos/piponazo/exiv2/tags","blobs_url":"https://api.github.com/repos/piponazo/exiv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piponazo/exiv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piponazo/exiv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/piponazo/exiv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piponazo/exiv2/statuses/{sha}","languages_url":"https://api.github.com/repos/piponazo/exiv2/languages","stargazers_url":"https://api.github.com/repos/piponazo/exiv2/stargazers","contributors_url":"https://api.github.com/repos/piponazo/exiv2/contributors","subscribers_url":"https://api.github.com/repos/piponazo/exiv2/subscribers","subscription_url":"https://api.github.com/repos/piponazo/exiv2/subscription","commits_url":"https://api.github.com/repos/piponazo/exiv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/piponazo/exiv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/piponazo/exiv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/piponazo/exiv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/piponazo/exiv2/contents/{+path}","compare_url":"https://api.github.com/repos/piponazo/exiv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piponazo/exiv2/merges","archive_url":"https://api.github.com/repos/piponazo/exiv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piponazo/exiv2/downloads","issues_url":"https://api.github.com/repos/piponazo/exiv2/issues{/number}","pulls_url":"https://api.github.com/repos/piponazo/exiv2/pulls{/number}","milestones_url":"https://api.github.com/repos/piponazo/exiv2/milestones{/number}","notifications_url":"https://api.github.com/repos/piponazo/exiv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piponazo/exiv2/labels{/name}","releases_url":"https://api.github.com/repos/piponazo/exiv2/releases{/id}","deployments_url":"https://api.github.com/repos/piponazo/exiv2/deployments","created_at":"2017-08-08T17:49:30Z","updated_at":"2018-05-30T16:43:22Z","pushed_at":"2018-05-31T09:48:11Z","git_url":"git://github.com/piponazo/exiv2.git","ssh_url":"git@github.com:piponazo/exiv2.git","clone_url":"https://github.com/piponazo/exiv2.git","svn_url":"https://github.com/piponazo/exiv2","homepage":" http://www.exiv2.org","size":86313,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Exiv2:master","ref":"master","sha":"8eca055058a15ecc42b45550d19c1561b065aa89","user":{"login":"Exiv2","id":23559442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU5NDQy","avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"repo":{"id":89623031,"node_id":"MDEwOlJlcG9zaXRvcnk4OTYyMzAzMQ==","name":"exiv2","full_name":"Exiv2/exiv2","owner":{"login":"Exiv2","id":23559442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU5NDQy","avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exiv2/exiv2","description":"Image metadata library and tools","fork":false,"url":"https://api.github.com/repos/Exiv2/exiv2","forks_url":"https://api.github.com/repos/Exiv2/exiv2/forks","keys_url":"https://api.github.com/repos/Exiv2/exiv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exiv2/exiv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exiv2/exiv2/teams","hooks_url":"https://api.github.com/repos/Exiv2/exiv2/hooks","issue_events_url":"https://api.github.com/repos/Exiv2/exiv2/issues/events{/number}","events_url":"https://api.github.com/repos/Exiv2/exiv2/events","assignees_url":"https://api.github.com/repos/Exiv2/exiv2/assignees{/user}","branches_url":"https://api.github.com/repos/Exiv2/exiv2/branches{/branch}","tags_url":"https://api.github.com/repos/Exiv2/exiv2/tags","blobs_url":"https://api.github.com/repos/Exiv2/exiv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exiv2/exiv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exiv2/exiv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exiv2/exiv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exiv2/exiv2/statuses/{sha}","languages_url":"https://api.github.com/repos/Exiv2/exiv2/languages","stargazers_url":"https://api.github.com/repos/Exiv2/exiv2/stargazers","contributors_url":"https://api.github.com/repos/Exiv2/exiv2/contributors","subscribers_url":"https://api.github.com/repos/Exiv2/exiv2/subscribers","subscription_url":"https://api.github.com/repos/Exiv2/exiv2/subscription","commits_url":"https://api.github.com/repos/Exiv2/exiv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exiv2/exiv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exiv2/exiv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exiv2/exiv2/contents/{+path}","compare_url":"https://api.github.com/repos/Exiv2/exiv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exiv2/exiv2/merges","archive_url":"https://api.github.com/repos/Exiv2/exiv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exiv2/exiv2/downloads","issues_url":"https://api.github.com/repos/Exiv2/exiv2/issues{/number}","pulls_url":"https://api.github.com/repos/Exiv2/exiv2/pulls{/number}","milestones_url":"https://api.github.com/repos/Exiv2/exiv2/milestones{/number}","notifications_url":"https://api.github.com/repos/Exiv2/exiv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exiv2/exiv2/labels{/name}","releases_url":"https://api.github.com/repos/Exiv2/exiv2/releases{/id}","deployments_url":"https://api.github.com/repos/Exiv2/exiv2/deployments","created_at":"2017-04-27T17:25:13Z","updated_at":"2018-05-29T13:33:12Z","pushed_at":"2018-05-31T07:10:22Z","git_url":"git://github.com/Exiv2/exiv2.git","ssh_url":"git@github.com:Exiv2/exiv2.git","clone_url":"https://github.com/Exiv2/exiv2.git","svn_url":"https://github.com/Exiv2/exiv2","homepage":"http://www.exiv2.org/","size":87035,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":49,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/326"},"html":{"href":"https://github.com/Exiv2/exiv2/pull/326"},"issue":{"href":"https://api.github.com/repos/Exiv2/exiv2/issues/326"},"comments":{"href":"https://api.github.com/repos/Exiv2/exiv2/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/Exiv2/exiv2/statuses/30963af3fab5181f3303e21bcb3b79d1065575d7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"D4N"}}