{"action":"closed","number":385,"pull_request":{"url":"https://api.github.com/repos/satijalab/seurat/pulls/385","id":177873721,"html_url":"https://github.com/satijalab/seurat/pull/385","diff_url":"https://github.com/satijalab/seurat/pull/385.diff","patch_url":"https://github.com/satijalab/seurat/pull/385.patch","issue_url":"https://api.github.com/repos/satijalab/seurat/issues/385","number":385,"state":"closed","locked":false,"title":"Updating PrintTSNEParams","user":{"login":"leonfodoulian","id":30617172,"avatar_url":"https://avatars1.githubusercontent.com/u/30617172?v=4","gravatar_id":"","url":"https://api.github.com/users/leonfodoulian","html_url":"https://github.com/leonfodoulian","followers_url":"https://api.github.com/users/leonfodoulian/followers","following_url":"https://api.github.com/users/leonfodoulian/following{/other_user}","gists_url":"https://api.github.com/users/leonfodoulian/gists{/gist_id}","starred_url":"https://api.github.com/users/leonfodoulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonfodoulian/subscriptions","organizations_url":"https://api.github.com/users/leonfodoulian/orgs","repos_url":"https://api.github.com/users/leonfodoulian/repos","events_url":"https://api.github.com/users/leonfodoulian/events{/privacy}","received_events_url":"https://api.github.com/users/leonfodoulian/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI have updated the `Seurat::PrintTSNEParams()` function to support the new argument of the `Seurat::RunTSNE()` function. Briefly, the `do.fast` argument has been replaced by `tsne.method`, which led to the following error:\r\n\r\n```R\r\n> Seurat::PrintTSNEParams(object = object, raw = FALSE) # print tSNE calculation parameters\r\nParameters used in latest TSNE calculation run on: 2018-03-27 23:20:53\r\n=============================================================================\r\nReduction use          do.fast          dim.embed\r\nError in if (n <= 0) { : argument is of length zero\r\n```\r\n\r\nNow, the function prints the expected output:\r\n\r\n```R\r\n> PrintTSNEParams(object = object, raw = FALSE) # print tSNE calculation parameters\r\nParameters used in latest TSNE calculation run on: 2018-03-27 23:20:53\r\n=============================================================================\r\nReduction use          tsne.method          dim.embed\r\n     pca                  Rtsne                 2\r\n-----------------------------------------------------------------------------\r\nDims used in calculation\r\n=============================================================================\r\n1 2 3 4 5 6 7 9 11 12 13 14 15 16 19 20 22 23 25 28 34 35 37 44 48 51 55 56 60\r\n61 65 \r\n```\r\n\r\nBest,\r\nLeon","created_at":"2018-03-27T21:43:22Z","updated_at":"2018-03-29T17:11:25Z","closed_at":"2018-03-29T17:11:25Z","merged_at":"2018-03-29T17:11:25Z","merge_commit_sha":"bafb80e3020bfe23113daea3f29d5f0da9b05e61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/satijalab/seurat/pulls/385/commits","review_comments_url":"https://api.github.com/repos/satijalab/seurat/pulls/385/comments","review_comment_url":"https://api.github.com/repos/satijalab/seurat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/satijalab/seurat/issues/385/comments","statuses_url":"https://api.github.com/repos/satijalab/seurat/statuses/27936429644d9b6c22a77fc3ea62c8160888d1c8","head":{"label":"leonfodoulian:patch-1","ref":"patch-1","sha":"27936429644d9b6c22a77fc3ea62c8160888d1c8","user":{"login":"leonfodoulian","id":30617172,"avatar_url":"https://avatars1.githubusercontent.com/u/30617172?v=4","gravatar_id":"","url":"https://api.github.com/users/leonfodoulian","html_url":"https://github.com/leonfodoulian","followers_url":"https://api.github.com/users/leonfodoulian/followers","following_url":"https://api.github.com/users/leonfodoulian/following{/other_user}","gists_url":"https://api.github.com/users/leonfodoulian/gists{/gist_id}","starred_url":"https://api.github.com/users/leonfodoulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonfodoulian/subscriptions","organizations_url":"https://api.github.com/users/leonfodoulian/orgs","repos_url":"https://api.github.com/users/leonfodoulian/repos","events_url":"https://api.github.com/users/leonfodoulian/events{/privacy}","received_events_url":"https://api.github.com/users/leonfodoulian/received_events","type":"User","site_admin":false},"repo":{"id":100305210,"name":"seurat","full_name":"leonfodoulian/seurat","owner":{"login":"leonfodoulian","id":30617172,"avatar_url":"https://avatars1.githubusercontent.com/u/30617172?v=4","gravatar_id":"","url":"https://api.github.com/users/leonfodoulian","html_url":"https://github.com/leonfodoulian","followers_url":"https://api.github.com/users/leonfodoulian/followers","following_url":"https://api.github.com/users/leonfodoulian/following{/other_user}","gists_url":"https://api.github.com/users/leonfodoulian/gists{/gist_id}","starred_url":"https://api.github.com/users/leonfodoulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonfodoulian/subscriptions","organizations_url":"https://api.github.com/users/leonfodoulian/orgs","repos_url":"https://api.github.com/users/leonfodoulian/repos","events_url":"https://api.github.com/users/leonfodoulian/events{/privacy}","received_events_url":"https://api.github.com/users/leonfodoulian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leonfodoulian/seurat","description":"R toolkit for single cell genomics","fork":true,"url":"https://api.github.com/repos/leonfodoulian/seurat","forks_url":"https://api.github.com/repos/leonfodoulian/seurat/forks","keys_url":"https://api.github.com/repos/leonfodoulian/seurat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonfodoulian/seurat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonfodoulian/seurat/teams","hooks_url":"https://api.github.com/repos/leonfodoulian/seurat/hooks","issue_events_url":"https://api.github.com/repos/leonfodoulian/seurat/issues/events{/number}","events_url":"https://api.github.com/repos/leonfodoulian/seurat/events","assignees_url":"https://api.github.com/repos/leonfodoulian/seurat/assignees{/user}","branches_url":"https://api.github.com/repos/leonfodoulian/seurat/branches{/branch}","tags_url":"https://api.github.com/repos/leonfodoulian/seurat/tags","blobs_url":"https://api.github.com/repos/leonfodoulian/seurat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonfodoulian/seurat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonfodoulian/seurat/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonfodoulian/seurat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonfodoulian/seurat/statuses/{sha}","languages_url":"https://api.github.com/repos/leonfodoulian/seurat/languages","stargazers_url":"https://api.github.com/repos/leonfodoulian/seurat/stargazers","contributors_url":"https://api.github.com/repos/leonfodoulian/seurat/contributors","subscribers_url":"https://api.github.com/repos/leonfodoulian/seurat/subscribers","subscription_url":"https://api.github.com/repos/leonfodoulian/seurat/subscription","commits_url":"https://api.github.com/repos/leonfodoulian/seurat/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonfodoulian/seurat/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonfodoulian/seurat/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonfodoulian/seurat/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonfodoulian/seurat/contents/{+path}","compare_url":"https://api.github.com/repos/leonfodoulian/seurat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonfodoulian/seurat/merges","archive_url":"https://api.github.com/repos/leonfodoulian/seurat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonfodoulian/seurat/downloads","issues_url":"https://api.github.com/repos/leonfodoulian/seurat/issues{/number}","pulls_url":"https://api.github.com/repos/leonfodoulian/seurat/pulls{/number}","milestones_url":"https://api.github.com/repos/leonfodoulian/seurat/milestones{/number}","notifications_url":"https://api.github.com/repos/leonfodoulian/seurat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonfodoulian/seurat/labels{/name}","releases_url":"https://api.github.com/repos/leonfodoulian/seurat/releases{/id}","deployments_url":"https://api.github.com/repos/leonfodoulian/seurat/deployments","created_at":"2017-08-14T20:06:52Z","updated_at":"2017-09-03T19:17:43Z","pushed_at":"2018-03-29T16:45:39Z","git_url":"git://github.com/leonfodoulian/seurat.git","ssh_url":"git@github.com:leonfodoulian/seurat.git","clone_url":"https://github.com/leonfodoulian/seurat.git","svn_url":"https://github.com/leonfodoulian/seurat","homepage":null,"size":4559,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"satijalab:develop","ref":"develop","sha":"cfc2f29b448cd92204099264d3b6cf9737a82e85","user":{"login":"satijalab","id":8411851,"avatar_url":"https://avatars1.githubusercontent.com/u/8411851?v=4","gravatar_id":"","url":"https://api.github.com/users/satijalab","html_url":"https://github.com/satijalab","followers_url":"https://api.github.com/users/satijalab/followers","following_url":"https://api.github.com/users/satijalab/following{/other_user}","gists_url":"https://api.github.com/users/satijalab/gists{/gist_id}","starred_url":"https://api.github.com/users/satijalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satijalab/subscriptions","organizations_url":"https://api.github.com/users/satijalab/orgs","repos_url":"https://api.github.com/users/satijalab/repos","events_url":"https://api.github.com/users/satijalab/events{/privacy}","received_events_url":"https://api.github.com/users/satijalab/received_events","type":"User","site_admin":false},"repo":{"id":35927665,"name":"seurat","full_name":"satijalab/seurat","owner":{"login":"satijalab","id":8411851,"avatar_url":"https://avatars1.githubusercontent.com/u/8411851?v=4","gravatar_id":"","url":"https://api.github.com/users/satijalab","html_url":"https://github.com/satijalab","followers_url":"https://api.github.com/users/satijalab/followers","following_url":"https://api.github.com/users/satijalab/following{/other_user}","gists_url":"https://api.github.com/users/satijalab/gists{/gist_id}","starred_url":"https://api.github.com/users/satijalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satijalab/subscriptions","organizations_url":"https://api.github.com/users/satijalab/orgs","repos_url":"https://api.github.com/users/satijalab/repos","events_url":"https://api.github.com/users/satijalab/events{/privacy}","received_events_url":"https://api.github.com/users/satijalab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satijalab/seurat","description":"R toolkit for single cell genomics","fork":false,"url":"https://api.github.com/repos/satijalab/seurat","forks_url":"https://api.github.com/repos/satijalab/seurat/forks","keys_url":"https://api.github.com/repos/satijalab/seurat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satijalab/seurat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satijalab/seurat/teams","hooks_url":"https://api.github.com/repos/satijalab/seurat/hooks","issue_events_url":"https://api.github.com/repos/satijalab/seurat/issues/events{/number}","events_url":"https://api.github.com/repos/satijalab/seurat/events","assignees_url":"https://api.github.com/repos/satijalab/seurat/assignees{/user}","branches_url":"https://api.github.com/repos/satijalab/seurat/branches{/branch}","tags_url":"https://api.github.com/repos/satijalab/seurat/tags","blobs_url":"https://api.github.com/repos/satijalab/seurat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satijalab/seurat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satijalab/seurat/git/refs{/sha}","trees_url":"https://api.github.com/repos/satijalab/seurat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satijalab/seurat/statuses/{sha}","languages_url":"https://api.github.com/repos/satijalab/seurat/languages","stargazers_url":"https://api.github.com/repos/satijalab/seurat/stargazers","contributors_url":"https://api.github.com/repos/satijalab/seurat/contributors","subscribers_url":"https://api.github.com/repos/satijalab/seurat/subscribers","subscription_url":"https://api.github.com/repos/satijalab/seurat/subscription","commits_url":"https://api.github.com/repos/satijalab/seurat/commits{/sha}","git_commits_url":"https://api.github.com/repos/satijalab/seurat/git/commits{/sha}","comments_url":"https://api.github.com/repos/satijalab/seurat/comments{/number}","issue_comment_url":"https://api.github.com/repos/satijalab/seurat/issues/comments{/number}","contents_url":"https://api.github.com/repos/satijalab/seurat/contents/{+path}","compare_url":"https://api.github.com/repos/satijalab/seurat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satijalab/seurat/merges","archive_url":"https://api.github.com/repos/satijalab/seurat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satijalab/seurat/downloads","issues_url":"https://api.github.com/repos/satijalab/seurat/issues{/number}","pulls_url":"https://api.github.com/repos/satijalab/seurat/pulls{/number}","milestones_url":"https://api.github.com/repos/satijalab/seurat/milestones{/number}","notifications_url":"https://api.github.com/repos/satijalab/seurat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satijalab/seurat/labels{/name}","releases_url":"https://api.github.com/repos/satijalab/seurat/releases{/id}","deployments_url":"https://api.github.com/repos/satijalab/seurat/deployments","created_at":"2015-05-20T05:23:02Z","updated_at":"2018-03-27T14:44:38Z","pushed_at":"2018-03-29T17:11:25Z","git_url":"git://github.com/satijalab/seurat.git","ssh_url":"git@github.com:satijalab/seurat.git","clone_url":"https://github.com/satijalab/seurat.git","svn_url":"https://github.com/satijalab/seurat","homepage":null,"size":4712,"stargazers_count":167,"watchers_count":167,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":114,"open_issues":14,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/satijalab/seurat/pulls/385"},"html":{"href":"https://github.com/satijalab/seurat/pull/385"},"issue":{"href":"https://api.github.com/repos/satijalab/seurat/issues/385"},"comments":{"href":"https://api.github.com/repos/satijalab/seurat/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/satijalab/seurat/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/satijalab/seurat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/satijalab/seurat/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/satijalab/seurat/statuses/27936429644d9b6c22a77fc3ea62c8160888d1c8"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewwbutler","id":5632416,"avatar_url":"https://avatars0.githubusercontent.com/u/5632416?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewwbutler","html_url":"https://github.com/andrewwbutler","followers_url":"https://api.github.com/users/andrewwbutler/followers","following_url":"https://api.github.com/users/andrewwbutler/following{/other_user}","gists_url":"https://api.github.com/users/andrewwbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewwbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewwbutler/subscriptions","organizations_url":"https://api.github.com/users/andrewwbutler/orgs","repos_url":"https://api.github.com/users/andrewwbutler/repos","events_url":"https://api.github.com/users/andrewwbutler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewwbutler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":9,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"andrewwbutler"}}