{"action":"created","comment":{"url":"https://api.github.com/repos/zeyla/serenity/pulls/comments/167465783","pull_request_review_id":95685894,"id":167465783,"diff_hunk":"@@ -257,17 +257,28 @@ impl Handler {\n \n     /// Plays audio from a source.\n     ///\n-    /// Unlike `play`, this stops all other sources attached\n+    /// Unlike [`play()`] or [`play_returning()`], this stops all other sources attached","path":"src/voice/handler.rs","position":14,"original_position":14,"commit_id":"0c1b8d1e5e83223c7c5c539d6645ddf067735207","original_commit_id":"0c1b8d1e5e83223c7c5c539d6645ddf067735207","user":{"login":"zeyla","id":23287880,"avatar_url":"https://avatars0.githubusercontent.com/u/23287880?v=4","gravatar_id":"","url":"https://api.github.com/users/zeyla","html_url":"https://github.com/zeyla","followers_url":"https://api.github.com/users/zeyla/followers","following_url":"https://api.github.com/users/zeyla/following{/other_user}","gists_url":"https://api.github.com/users/zeyla/gists{/gist_id}","starred_url":"https://api.github.com/users/zeyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeyla/subscriptions","organizations_url":"https://api.github.com/users/zeyla/orgs","repos_url":"https://api.github.com/users/zeyla/repos","events_url":"https://api.github.com/users/zeyla/events{/privacy}","received_events_url":"https://api.github.com/users/zeyla/received_events","type":"User","site_admin":false},"body":"same ","created_at":"2018-02-12T03:47:27Z","updated_at":"2018-02-12T03:51:39Z","html_url":"https://github.com/zeyla/serenity/pull/272#discussion_r167465783","pull_request_url":"https://api.github.com/repos/zeyla/serenity/pulls/272","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/comments/167465783"},"html":{"href":"https://github.com/zeyla/serenity/pull/272#discussion_r167465783"},"pull_request":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/zeyla/serenity/pulls/272","id":166995997,"html_url":"https://github.com/zeyla/serenity/pull/272","diff_url":"https://github.com/zeyla/serenity/pull/272.diff","patch_url":"https://github.com/zeyla/serenity/pull/272.patch","issue_url":"https://api.github.com/repos/zeyla/serenity/issues/272","number":272,"state":"open","locked":false,"title":"Voice fixes, better API adherence, bitrate control, documentation","user":{"login":"FelixMcFelix","id":6815381,"avatar_url":"https://avatars3.githubusercontent.com/u/6815381?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixMcFelix","html_url":"https://github.com/FelixMcFelix","followers_url":"https://api.github.com/users/FelixMcFelix/followers","following_url":"https://api.github.com/users/FelixMcFelix/following{/other_user}","gists_url":"https://api.github.com/users/FelixMcFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixMcFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixMcFelix/subscriptions","organizations_url":"https://api.github.com/users/FelixMcFelix/orgs","repos_url":"https://api.github.com/users/FelixMcFelix/repos","events_url":"https://api.github.com/users/FelixMcFelix/events{/privacy}","received_events_url":"https://api.github.com/users/FelixMcFelix/received_events","type":"User","site_admin":false},"body":"* Control over Encoder send rate in Voice. Default is 128kbps.\r\n\r\n* Way better documentation for the new Audio control structs. Additionally, clients can now see the current position within each track (modifying this currently serves no purpose).\r\n\r\n* Raw Opus frame streams are now mixed into the multitrack output.\r\n\r\n* Mainly changes and adds OpCodes and Events which govern communication with the Discord Voice API. This includes soft checks for heartbeat ACK, as in #270. These SHOULD now match the docs, and reflects the fact that we are awaiting both a Hello AND a Ready at connection initialisation. I've added the OpCodes around Resume/Resumed, but there is no code to make use of these. *I did need to rename/rework a lot of the voice OpCodes to match the spec, be advised.*\r\n\r\n* Fixes to silent frames.","created_at":"2018-02-04T05:36:09Z","updated_at":"2018-02-12T03:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe39dfaadc6460cc90929ae5c68a327eff8381c5","assignee":{"login":"zeyla","id":23287880,"avatar_url":"https://avatars0.githubusercontent.com/u/23287880?v=4","gravatar_id":"","url":"https://api.github.com/users/zeyla","html_url":"https://github.com/zeyla","followers_url":"https://api.github.com/users/zeyla/followers","following_url":"https://api.github.com/users/zeyla/following{/other_user}","gists_url":"https://api.github.com/users/zeyla/gists{/gist_id}","starred_url":"https://api.github.com/users/zeyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeyla/subscriptions","organizations_url":"https://api.github.com/users/zeyla/orgs","repos_url":"https://api.github.com/users/zeyla/repos","events_url":"https://api.github.com/users/zeyla/events{/privacy}","received_events_url":"https://api.github.com/users/zeyla/received_events","type":"User","site_admin":false},"assignees":[{"login":"zeyla","id":23287880,"avatar_url":"https://avatars0.githubusercontent.com/u/23287880?v=4","gravatar_id":"","url":"https://api.github.com/users/zeyla","html_url":"https://github.com/zeyla","followers_url":"https://api.github.com/users/zeyla/followers","following_url":"https://api.github.com/users/zeyla/following{/other_user}","gists_url":"https://api.github.com/users/zeyla/gists{/gist_id}","starred_url":"https://api.github.com/users/zeyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeyla/subscriptions","organizations_url":"https://api.github.com/users/zeyla/orgs","repos_url":"https://api.github.com/users/zeyla/repos","events_url":"https://api.github.com/users/zeyla/events{/privacy}","received_events_url":"https://api.github.com/users/zeyla/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":476385280,"url":"https://api.github.com/repos/zeyla/serenity/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/zeyla/serenity/pulls/272/commits","review_comments_url":"https://api.github.com/repos/zeyla/serenity/pulls/272/comments","review_comment_url":"https://api.github.com/repos/zeyla/serenity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeyla/serenity/issues/272/comments","statuses_url":"https://api.github.com/repos/zeyla/serenity/statuses/0c1b8d1e5e83223c7c5c539d6645ddf067735207","head":{"label":"FelixMcFelix:more-voice-work","ref":"more-voice-work","sha":"0c1b8d1e5e83223c7c5c539d6645ddf067735207","user":{"login":"FelixMcFelix","id":6815381,"avatar_url":"https://avatars3.githubusercontent.com/u/6815381?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixMcFelix","html_url":"https://github.com/FelixMcFelix","followers_url":"https://api.github.com/users/FelixMcFelix/followers","following_url":"https://api.github.com/users/FelixMcFelix/following{/other_user}","gists_url":"https://api.github.com/users/FelixMcFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixMcFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixMcFelix/subscriptions","organizations_url":"https://api.github.com/users/FelixMcFelix/orgs","repos_url":"https://api.github.com/users/FelixMcFelix/repos","events_url":"https://api.github.com/users/FelixMcFelix/events{/privacy}","received_events_url":"https://api.github.com/users/FelixMcFelix/received_events","type":"User","site_admin":false},"repo":{"id":119463928,"name":"serenity","full_name":"FelixMcFelix/serenity","owner":{"login":"FelixMcFelix","id":6815381,"avatar_url":"https://avatars3.githubusercontent.com/u/6815381?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixMcFelix","html_url":"https://github.com/FelixMcFelix","followers_url":"https://api.github.com/users/FelixMcFelix/followers","following_url":"https://api.github.com/users/FelixMcFelix/following{/other_user}","gists_url":"https://api.github.com/users/FelixMcFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixMcFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixMcFelix/subscriptions","organizations_url":"https://api.github.com/users/FelixMcFelix/orgs","repos_url":"https://api.github.com/users/FelixMcFelix/repos","events_url":"https://api.github.com/users/FelixMcFelix/events{/privacy}","received_events_url":"https://api.github.com/users/FelixMcFelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FelixMcFelix/serenity","description":"A Rust library for the Discord API.","fork":true,"url":"https://api.github.com/repos/FelixMcFelix/serenity","forks_url":"https://api.github.com/repos/FelixMcFelix/serenity/forks","keys_url":"https://api.github.com/repos/FelixMcFelix/serenity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FelixMcFelix/serenity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FelixMcFelix/serenity/teams","hooks_url":"https://api.github.com/repos/FelixMcFelix/serenity/hooks","issue_events_url":"https://api.github.com/repos/FelixMcFelix/serenity/issues/events{/number}","events_url":"https://api.github.com/repos/FelixMcFelix/serenity/events","assignees_url":"https://api.github.com/repos/FelixMcFelix/serenity/assignees{/user}","branches_url":"https://api.github.com/repos/FelixMcFelix/serenity/branches{/branch}","tags_url":"https://api.github.com/repos/FelixMcFelix/serenity/tags","blobs_url":"https://api.github.com/repos/FelixMcFelix/serenity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FelixMcFelix/serenity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FelixMcFelix/serenity/git/refs{/sha}","trees_url":"https://api.github.com/repos/FelixMcFelix/serenity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FelixMcFelix/serenity/statuses/{sha}","languages_url":"https://api.github.com/repos/FelixMcFelix/serenity/languages","stargazers_url":"https://api.github.com/repos/FelixMcFelix/serenity/stargazers","contributors_url":"https://api.github.com/repos/FelixMcFelix/serenity/contributors","subscribers_url":"https://api.github.com/repos/FelixMcFelix/serenity/subscribers","subscription_url":"https://api.github.com/repos/FelixMcFelix/serenity/subscription","commits_url":"https://api.github.com/repos/FelixMcFelix/serenity/commits{/sha}","git_commits_url":"https://api.github.com/repos/FelixMcFelix/serenity/git/commits{/sha}","comments_url":"https://api.github.com/repos/FelixMcFelix/serenity/comments{/number}","issue_comment_url":"https://api.github.com/repos/FelixMcFelix/serenity/issues/comments{/number}","contents_url":"https://api.github.com/repos/FelixMcFelix/serenity/contents/{+path}","compare_url":"https://api.github.com/repos/FelixMcFelix/serenity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FelixMcFelix/serenity/merges","archive_url":"https://api.github.com/repos/FelixMcFelix/serenity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FelixMcFelix/serenity/downloads","issues_url":"https://api.github.com/repos/FelixMcFelix/serenity/issues{/number}","pulls_url":"https://api.github.com/repos/FelixMcFelix/serenity/pulls{/number}","milestones_url":"https://api.github.com/repos/FelixMcFelix/serenity/milestones{/number}","notifications_url":"https://api.github.com/repos/FelixMcFelix/serenity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FelixMcFelix/serenity/labels{/name}","releases_url":"https://api.github.com/repos/FelixMcFelix/serenity/releases{/id}","deployments_url":"https://api.github.com/repos/FelixMcFelix/serenity/deployments","created_at":"2018-01-30T01:18:06Z","updated_at":"2018-01-30T01:18:08Z","pushed_at":"2018-02-04T05:26:06Z","git_url":"git://github.com/FelixMcFelix/serenity.git","ssh_url":"git@github.com:FelixMcFelix/serenity.git","clone_url":"https://github.com/FelixMcFelix/serenity.git","svn_url":"https://github.com/FelixMcFelix/serenity","homepage":"https://discord.gg/WBdGJCc","size":3975,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeyla:master","ref":"master","sha":"d8c9d89c80ffb0ae95b91c4dcc593fd70fa976d8","user":{"login":"zeyla","id":23287880,"avatar_url":"https://avatars0.githubusercontent.com/u/23287880?v=4","gravatar_id":"","url":"https://api.github.com/users/zeyla","html_url":"https://github.com/zeyla","followers_url":"https://api.github.com/users/zeyla/followers","following_url":"https://api.github.com/users/zeyla/following{/other_user}","gists_url":"https://api.github.com/users/zeyla/gists{/gist_id}","starred_url":"https://api.github.com/users/zeyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeyla/subscriptions","organizations_url":"https://api.github.com/users/zeyla/orgs","repos_url":"https://api.github.com/users/zeyla/repos","events_url":"https://api.github.com/users/zeyla/events{/privacy}","received_events_url":"https://api.github.com/users/zeyla/received_events","type":"User","site_admin":false},"repo":{"id":73012103,"name":"serenity","full_name":"zeyla/serenity","owner":{"login":"zeyla","id":23287880,"avatar_url":"https://avatars0.githubusercontent.com/u/23287880?v=4","gravatar_id":"","url":"https://api.github.com/users/zeyla","html_url":"https://github.com/zeyla","followers_url":"https://api.github.com/users/zeyla/followers","following_url":"https://api.github.com/users/zeyla/following{/other_user}","gists_url":"https://api.github.com/users/zeyla/gists{/gist_id}","starred_url":"https://api.github.com/users/zeyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeyla/subscriptions","organizations_url":"https://api.github.com/users/zeyla/orgs","repos_url":"https://api.github.com/users/zeyla/repos","events_url":"https://api.github.com/users/zeyla/events{/privacy}","received_events_url":"https://api.github.com/users/zeyla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeyla/serenity","description":"A Rust library for the Discord API.","fork":false,"url":"https://api.github.com/repos/zeyla/serenity","forks_url":"https://api.github.com/repos/zeyla/serenity/forks","keys_url":"https://api.github.com/repos/zeyla/serenity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeyla/serenity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeyla/serenity/teams","hooks_url":"https://api.github.com/repos/zeyla/serenity/hooks","issue_events_url":"https://api.github.com/repos/zeyla/serenity/issues/events{/number}","events_url":"https://api.github.com/repos/zeyla/serenity/events","assignees_url":"https://api.github.com/repos/zeyla/serenity/assignees{/user}","branches_url":"https://api.github.com/repos/zeyla/serenity/branches{/branch}","tags_url":"https://api.github.com/repos/zeyla/serenity/tags","blobs_url":"https://api.github.com/repos/zeyla/serenity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeyla/serenity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeyla/serenity/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeyla/serenity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeyla/serenity/statuses/{sha}","languages_url":"https://api.github.com/repos/zeyla/serenity/languages","stargazers_url":"https://api.github.com/repos/zeyla/serenity/stargazers","contributors_url":"https://api.github.com/repos/zeyla/serenity/contributors","subscribers_url":"https://api.github.com/repos/zeyla/serenity/subscribers","subscription_url":"https://api.github.com/repos/zeyla/serenity/subscription","commits_url":"https://api.github.com/repos/zeyla/serenity/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeyla/serenity/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeyla/serenity/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeyla/serenity/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeyla/serenity/contents/{+path}","compare_url":"https://api.github.com/repos/zeyla/serenity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeyla/serenity/merges","archive_url":"https://api.github.com/repos/zeyla/serenity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeyla/serenity/downloads","issues_url":"https://api.github.com/repos/zeyla/serenity/issues{/number}","pulls_url":"https://api.github.com/repos/zeyla/serenity/pulls{/number}","milestones_url":"https://api.github.com/repos/zeyla/serenity/milestones{/number}","notifications_url":"https://api.github.com/repos/zeyla/serenity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeyla/serenity/labels{/name}","releases_url":"https://api.github.com/repos/zeyla/serenity/releases{/id}","deployments_url":"https://api.github.com/repos/zeyla/serenity/deployments","created_at":"2016-11-06T18:59:56Z","updated_at":"2018-02-12T03:11:06Z","pushed_at":"2018-02-10T04:32:58Z","git_url":"git://github.com/zeyla/serenity.git","ssh_url":"git@github.com:zeyla/serenity.git","clone_url":"https://github.com/zeyla/serenity.git","svn_url":"https://github.com/zeyla/serenity","homepage":"https://discord.gg/WBdGJCc","size":3909,"stargazers_count":211,"watchers_count":211,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":52,"open_issues":20,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/272"},"html":{"href":"https://github.com/zeyla/serenity/pull/272"},"issue":{"href":"https://api.github.com/repos/zeyla/serenity/issues/272"},"comments":{"href":"https://api.github.com/repos/zeyla/serenity/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeyla/serenity/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/zeyla/serenity/statuses/0c1b8d1e5e83223c7c5c539d6645ddf067735207"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zeyla"}}