{"action":"created","comment":{"url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/comments/186074857","pull_request_review_id":117589886,"id":186074857,"diff_hunk":"@@ -1,38 +1,52 @@\n import { div, h1 } from 'react-hyperscript-helpers'\n+import { buttonPrimary, link, search, textInput } from 'src/components/common'\n+import { validatedInput } from 'src/components/input'\n import * as Nav from 'src/libs/nav'\n-import { buttonPrimary, textInput, link, search } from 'src/components/common'\n+import { Component } from 'src/libs/wrapped-components'","path":"src/pages/StyleGuide.js","position":6,"original_position":6,"commit_id":"1425fa5a97740f514d0150723e56ded5cfaba0e8","original_commit_id":"1425fa5a97740f514d0150723e56ded5cfaba0e8","user":{"login":"panentheos","id":555632,"avatar_url":"https://avatars0.githubusercontent.com/u/555632?v=4","gravatar_id":"","url":"https://api.github.com/users/panentheos","html_url":"https://github.com/panentheos","followers_url":"https://api.github.com/users/panentheos/followers","following_url":"https://api.github.com/users/panentheos/following{/other_user}","gists_url":"https://api.github.com/users/panentheos/gists{/gist_id}","starred_url":"https://api.github.com/users/panentheos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panentheos/subscriptions","organizations_url":"https://api.github.com/users/panentheos/orgs","repos_url":"https://api.github.com/users/panentheos/repos","events_url":"https://api.github.com/users/panentheos/events{/privacy}","received_events_url":"https://api.github.com/users/panentheos/received_events","type":"User","site_admin":false},"body":"TOL: I don't like this wrapped `Component`. As a general rule, we should be aiming to _reduce_ the amount and frequency of state, whereas this pattern seems to encourage more of it. At the very least, I think all state should be explicitly initialized in a constructor, so it's obvious to readers.","created_at":"2018-05-04T13:02:40Z","updated_at":"2018-05-04T13:28:35Z","html_url":"https://github.com/DataBiosphere/saturn-ui/pull/112#discussion_r186074857","pull_request_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/comments/186074857"},"html":{"href":"https://github.com/DataBiosphere/saturn-ui/pull/112#discussion_r186074857"},"pull_request":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112","id":185571749,"html_url":"https://github.com/DataBiosphere/saturn-ui/pull/112","diff_url":"https://github.com/DataBiosphere/saturn-ui/pull/112.diff","patch_url":"https://github.com/DataBiosphere/saturn-ui/pull/112.patch","issue_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/112","number":112,"state":"open","locked":false,"title":"Prevent illegal characters in notebook names","user":{"login":"zarsky-broad","id":22642695,"avatar_url":"https://avatars2.githubusercontent.com/u/22642695?v=4","gravatar_id":"","url":"https://api.github.com/users/zarsky-broad","html_url":"https://github.com/zarsky-broad","followers_url":"https://api.github.com/users/zarsky-broad/followers","following_url":"https://api.github.com/users/zarsky-broad/following{/other_user}","gists_url":"https://api.github.com/users/zarsky-broad/gists{/gist_id}","starred_url":"https://api.github.com/users/zarsky-broad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarsky-broad/subscriptions","organizations_url":"https://api.github.com/users/zarsky-broad/orgs","repos_url":"https://api.github.com/users/zarsky-broad/repos","events_url":"https://api.github.com/users/zarsky-broad/events{/privacy}","received_events_url":"https://api.github.com/users/zarsky-broad/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-02T21:55:49Z","updated_at":"2018-05-04T13:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e3751f357ed665c51312579e139626afc59398","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MattPutnam","id":785011,"avatar_url":"https://avatars3.githubusercontent.com/u/785011?v=4","gravatar_id":"","url":"https://api.github.com/users/MattPutnam","html_url":"https://github.com/MattPutnam","followers_url":"https://api.github.com/users/MattPutnam/followers","following_url":"https://api.github.com/users/MattPutnam/following{/other_user}","gists_url":"https://api.github.com/users/MattPutnam/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPutnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPutnam/subscriptions","organizations_url":"https://api.github.com/users/MattPutnam/orgs","repos_url":"https://api.github.com/users/MattPutnam/repos","events_url":"https://api.github.com/users/MattPutnam/events{/privacy}","received_events_url":"https://api.github.com/users/MattPutnam/received_events","type":"User","site_admin":false},{"login":"dmohs","id":1545444,"avatar_url":"https://avatars2.githubusercontent.com/u/1545444?v=4","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112/commits","review_comments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112/comments","review_comment_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/112/comments","statuses_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/statuses/1425fa5a97740f514d0150723e56ded5cfaba0e8","head":{"label":"DataBiosphere:iz-illegal-characters-in-notebook-names","ref":"iz-illegal-characters-in-notebook-names","sha":"1425fa5a97740f514d0150723e56ded5cfaba0e8","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":122538461,"name":"saturn-ui","full_name":"DataBiosphere/saturn-ui","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/saturn-ui","description":"Workbench app","fork":false,"url":"https://api.github.com/repos/DataBiosphere/saturn-ui","forks_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/forks","keys_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/events","assignees_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/merges","archive_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/deployments","created_at":"2018-02-22T21:38:34Z","updated_at":"2018-05-03T13:06:03Z","pushed_at":"2018-05-04T12:25:46Z","git_url":"git://github.com/DataBiosphere/saturn-ui.git","ssh_url":"git@github.com:DataBiosphere/saturn-ui.git","clone_url":"https://github.com/DataBiosphere/saturn-ui.git","svn_url":"https://github.com/DataBiosphere/saturn-ui","homepage":"","size":441,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":31,"watchers":2,"default_branch":"dev"}},"base":{"label":"DataBiosphere:dev","ref":"dev","sha":"0223fe17af12307736adb5cac81d8e7295dd8cef","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":122538461,"name":"saturn-ui","full_name":"DataBiosphere/saturn-ui","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/saturn-ui","description":"Workbench app","fork":false,"url":"https://api.github.com/repos/DataBiosphere/saturn-ui","forks_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/forks","keys_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/events","assignees_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/merges","archive_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/saturn-ui/deployments","created_at":"2018-02-22T21:38:34Z","updated_at":"2018-05-03T13:06:03Z","pushed_at":"2018-05-04T12:25:46Z","git_url":"git://github.com/DataBiosphere/saturn-ui.git","ssh_url":"git@github.com:DataBiosphere/saturn-ui.git","clone_url":"https://github.com/DataBiosphere/saturn-ui.git","svn_url":"https://github.com/DataBiosphere/saturn-ui","homepage":"","size":441,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":31,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112"},"html":{"href":"https://github.com/DataBiosphere/saturn-ui/pull/112"},"issue":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/112"},"comments":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/DataBiosphere/saturn-ui/statuses/1425fa5a97740f514d0150723e56ded5cfaba0e8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"panentheos"}}