{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/comments/177760284","pull_request_review_id":107689092,"id":177760284,"diff_hunk":"@@ -24,11 +24,10 @@ $docs-purple: #5300cc;\n $emerald: #2aac02;\n $base-grey: #2e3c43;\n $light-grey: rgba($base-grey, 0.02);\n-$typo0: #2e3c43;\n \n // Typo Scale\n-$typo1: #162945;\n-$typo2: #747d82;\n+$typo1: #2e3c43;\n+$typo2: #828a8f;","path":"src/scss/_variables.scss","position":10,"original_position":10,"commit_id":"41f25035fed06247a73ab1d2d1e0bb014b4cada2","original_commit_id":"41f25035fed06247a73ab1d2d1e0bb014b4cada2","user":{"login":"albertoac","id":4774531,"avatar_url":"https://avatars2.githubusercontent.com/u/4774531?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoac","html_url":"https://github.com/albertoac","followers_url":"https://api.github.com/users/albertoac/followers","following_url":"https://api.github.com/users/albertoac/following{/other_user}","gists_url":"https://api.github.com/users/albertoac/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoac/subscriptions","organizations_url":"https://api.github.com/users/albertoac/orgs","repos_url":"https://api.github.com/users/albertoac/repos","events_url":"https://api.github.com/users/albertoac/events{/privacy}","received_events_url":"https://api.github.com/users/albertoac/received_events","type":"User","site_admin":false},"body":"For me the new colors are ok. If those're the right ones for me is perfect!","created_at":"2018-03-28T14:03:27Z","updated_at":"2018-03-28T14:03:33Z","html_url":"https://github.com/CartoDB/hangar-alpha/pull/49#discussion_r177760284","pull_request_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/comments/177760284"},"html":{"href":"https://github.com/CartoDB/hangar-alpha/pull/49#discussion_r177760284"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49","id":178040747,"html_url":"https://github.com/CartoDB/hangar-alpha/pull/49","diff_url":"https://github.com/CartoDB/hangar-alpha/pull/49.diff","patch_url":"https://github.com/CartoDB/hangar-alpha/pull/49.patch","issue_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/49","number":49,"state":"open","locked":false,"title":"Typo colors fix","user":{"login":"arianaescobar","id":16247628,"avatar_url":"https://avatars0.githubusercontent.com/u/16247628?v=4","gravatar_id":"","url":"https://api.github.com/users/arianaescobar","html_url":"https://github.com/arianaescobar","followers_url":"https://api.github.com/users/arianaescobar/followers","following_url":"https://api.github.com/users/arianaescobar/following{/other_user}","gists_url":"https://api.github.com/users/arianaescobar/gists{/gist_id}","starred_url":"https://api.github.com/users/arianaescobar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arianaescobar/subscriptions","organizations_url":"https://api.github.com/users/arianaescobar/orgs","repos_url":"https://api.github.com/users/arianaescobar/repos","events_url":"https://api.github.com/users/arianaescobar/events{/privacy}","received_events_url":"https://api.github.com/users/arianaescobar/received_events","type":"User","site_admin":false},"body":"- There's no `typo0` in Hangar \r\n- `typo1` was using Navy Blue `#162945` instead of the correct one `#2e3c43`\r\n- `typo2` was using Builder's `typo2` `#747d82` instead of Hangar's one `#828a8f`. \r\n\r\nCreating PR to review this well before merging, I don't want to break anything by removing the variable `$typo0`","created_at":"2018-03-28T13:35:16Z","updated_at":"2018-03-28T14:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"151a90ce32b8835fdc3a7f59fabc45c534fba4df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49/commits","review_comments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49/comments","review_comment_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/49/comments","statuses_url":"https://api.github.com/repos/CartoDB/hangar-alpha/statuses/41f25035fed06247a73ab1d2d1e0bb014b4cada2","head":{"label":"CartoDB:typo-colors","ref":"typo-colors","sha":"41f25035fed06247a73ab1d2d1e0bb014b4cada2","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":96989948,"name":"hangar-alpha","full_name":"CartoDB/hangar-alpha","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/hangar-alpha","description":"Share frontend assets between different web repositories","fork":false,"url":"https://api.github.com/repos/CartoDB/hangar-alpha","forks_url":"https://api.github.com/repos/CartoDB/hangar-alpha/forks","keys_url":"https://api.github.com/repos/CartoDB/hangar-alpha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/hangar-alpha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/hangar-alpha/teams","hooks_url":"https://api.github.com/repos/CartoDB/hangar-alpha/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/hangar-alpha/events","assignees_url":"https://api.github.com/repos/CartoDB/hangar-alpha/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/hangar-alpha/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/hangar-alpha/tags","blobs_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/hangar-alpha/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/hangar-alpha/languages","stargazers_url":"https://api.github.com/repos/CartoDB/hangar-alpha/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/hangar-alpha/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/hangar-alpha/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/hangar-alpha/subscription","commits_url":"https://api.github.com/repos/CartoDB/hangar-alpha/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/hangar-alpha/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/hangar-alpha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/hangar-alpha/merges","archive_url":"https://api.github.com/repos/CartoDB/hangar-alpha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/hangar-alpha/downloads","issues_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/hangar-alpha/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/hangar-alpha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/hangar-alpha/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/hangar-alpha/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/deployments","created_at":"2017-07-12T09:29:26Z","updated_at":"2018-03-28T13:18:36Z","pushed_at":"2018-03-28T13:35:16Z","git_url":"git://github.com/CartoDB/hangar-alpha.git","ssh_url":"git@github.com:CartoDB/hangar-alpha.git","clone_url":"https://github.com/CartoDB/hangar-alpha.git","svn_url":"https://github.com/CartoDB/hangar-alpha","homepage":"https://cartodb.github.io/hangar-alpha/framework/","size":5260,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"5fc31339e8c52e54fe9cfd2fde0c5b2b6cad33a3","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":96989948,"name":"hangar-alpha","full_name":"CartoDB/hangar-alpha","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/hangar-alpha","description":"Share frontend assets between different web repositories","fork":false,"url":"https://api.github.com/repos/CartoDB/hangar-alpha","forks_url":"https://api.github.com/repos/CartoDB/hangar-alpha/forks","keys_url":"https://api.github.com/repos/CartoDB/hangar-alpha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/hangar-alpha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/hangar-alpha/teams","hooks_url":"https://api.github.com/repos/CartoDB/hangar-alpha/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/hangar-alpha/events","assignees_url":"https://api.github.com/repos/CartoDB/hangar-alpha/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/hangar-alpha/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/hangar-alpha/tags","blobs_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/hangar-alpha/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/hangar-alpha/languages","stargazers_url":"https://api.github.com/repos/CartoDB/hangar-alpha/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/hangar-alpha/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/hangar-alpha/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/hangar-alpha/subscription","commits_url":"https://api.github.com/repos/CartoDB/hangar-alpha/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/hangar-alpha/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/hangar-alpha/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/hangar-alpha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/hangar-alpha/merges","archive_url":"https://api.github.com/repos/CartoDB/hangar-alpha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/hangar-alpha/downloads","issues_url":"https://api.github.com/repos/CartoDB/hangar-alpha/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/hangar-alpha/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/hangar-alpha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/hangar-alpha/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/hangar-alpha/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/hangar-alpha/deployments","created_at":"2017-07-12T09:29:26Z","updated_at":"2018-03-28T13:18:36Z","pushed_at":"2018-03-28T13:35:16Z","git_url":"git://github.com/CartoDB/hangar-alpha.git","ssh_url":"git@github.com:CartoDB/hangar-alpha.git","clone_url":"https://github.com/CartoDB/hangar-alpha.git","svn_url":"https://github.com/CartoDB/hangar-alpha","homepage":"https://cartodb.github.io/hangar-alpha/framework/","size":5260,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49"},"html":{"href":"https://github.com/CartoDB/hangar-alpha/pull/49"},"issue":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/49"},"comments":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/hangar-alpha/statuses/41f25035fed06247a73ab1d2d1e0bb014b4cada2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"albertoac"}}