{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/comments/196304705","pull_request_review_id":129829278,"id":196304705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjMwNDcwNQ==","diff_hunk":"@@ -591,6 +591,43 @@ function cal2jd(iy, im, id)\n end\n \n \n+@inline function d2tf(ndp, days)\n+    sign = (days >= 0.0 ) ? '+' : '-'\n+    a = SECONDS_PER_DAY * abs(days)\n+\n+    if ndp < 0\n+        nrs = 1\n+        for n in range(1,-ndp)\n+            nrs *= (n == 2 || n == 4) ? 6 : 10\n+        end\n+        w = a / nrs\n+        a = nrs * round(w)\n+    end\n+\n+    nrs = 1\n+    for n in range(1,ndp)\n+        nrs *= 10\n+    end\n+    rm = nrs * 60.0\n+    rh = rm * 60.0\n+\n+    a = round(nrs * a)\n+    ah = floor(a / rh)\n+    a -= ah * rh\n+    am = floor(a / rm)\n+    a -= am * rm\n+    as = floor(a / nrs)\n+    af = floor(a - as * nrs)\n+\n+    ihmsf = zeros(Int,4)","path":"src/conversions.jl","position":32,"original_position":32,"commit_id":"2d720e78904d0be884af69f21f4650e6ff9e91fb","original_commit_id":"2d720e78904d0be884af69f21f4650e6ff9e91fb","user":{"login":"helgee","id":1408922,"node_id":"MDQ6VXNlcjE0MDg5MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1408922?v=4","gravatar_id":"","url":"https://api.github.com/users/helgee","html_url":"https://github.com/helgee","followers_url":"https://api.github.com/users/helgee/followers","following_url":"https://api.github.com/users/helgee/following{/other_user}","gists_url":"https://api.github.com/users/helgee/gists{/gist_id}","starred_url":"https://api.github.com/users/helgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgee/subscriptions","organizations_url":"https://api.github.com/users/helgee/orgs","repos_url":"https://api.github.com/users/helgee/repos","events_url":"https://api.github.com/users/helgee/events{/privacy}","received_events_url":"https://api.github.com/users/helgee/received_events","type":"User","site_admin":false},"body":"This does not make sense 😉 Why not return the values directly?","created_at":"2018-06-19T06:15:56Z","updated_at":"2018-06-19T06:15:57Z","html_url":"https://github.com/JuliaAstro/AstroTime.jl/pull/30#discussion_r196304705","pull_request_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/comments/196304705"},"html":{"href":"https://github.com/JuliaAstro/AstroTime.jl/pull/30#discussion_r196304705"},"pull_request":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30","id":192907895,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTA3ODk1","html_url":"https://github.com/JuliaAstro/AstroTime.jl/pull/30","diff_url":"https://github.com/JuliaAstro/AstroTime.jl/pull/30.diff","patch_url":"https://github.com/JuliaAstro/AstroTime.jl/pull/30.patch","issue_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/30","number":30,"state":"open","locked":false,"title":"D2tf","user":{"login":"prakharcode","id":13493237,"node_id":"MDQ6VXNlcjEzNDkzMjM3","avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"body":"Ported D2tf ","created_at":"2018-06-06T06:03:00Z","updated_at":"2018-06-19T06:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a17b9282f0f7d9a2e98702d44a437c1b3c5f41a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30/commits","review_comments_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30/comments","review_comment_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/30/comments","statuses_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/statuses/2d720e78904d0be884af69f21f4650e6ff9e91fb","head":{"label":"prakharcode:d2tf","ref":"d2tf","sha":"2d720e78904d0be884af69f21f4650e6ff9e91fb","user":{"login":"prakharcode","id":13493237,"node_id":"MDQ6VXNlcjEzNDkzMjM3","avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"repo":{"id":122171962,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxNzE5NjI=","name":"AstronomicalTime.jl","full_name":"prakharcode/AstronomicalTime.jl","owner":{"login":"prakharcode","id":13493237,"node_id":"MDQ6VXNlcjEzNDkzMjM3","avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prakharcode/AstronomicalTime.jl","description":"Astronomical time keeping in Julia","fork":true,"url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl","forks_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/forks","keys_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/teams","hooks_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/hooks","issue_events_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues/events{/number}","events_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/events","assignees_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/assignees{/user}","branches_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/branches{/branch}","tags_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/tags","blobs_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/languages","stargazers_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/stargazers","contributors_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/contributors","subscribers_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/subscribers","subscription_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/subscription","commits_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/contents/{+path}","compare_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/merges","archive_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/downloads","issues_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues{/number}","pulls_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/labels{/name}","releases_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/releases{/id}","deployments_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/deployments","created_at":"2018-02-20T08:24:18Z","updated_at":"2018-06-15T12:55:36Z","pushed_at":"2018-06-17T09:53:16Z","git_url":"git://github.com/prakharcode/AstronomicalTime.jl.git","ssh_url":"git@github.com:prakharcode/AstronomicalTime.jl.git","clone_url":"https://github.com/prakharcode/AstronomicalTime.jl.git","svn_url":"https://github.com/prakharcode/AstronomicalTime.jl","homepage":"http://juliaastro.github.io/","size":188,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaAstro:master","ref":"master","sha":"3799faec3da5d0073b35cf3e17153e09138a8d2a","user":{"login":"JuliaAstro","id":6685132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2ODUxMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"repo":{"id":83114211,"node_id":"MDEwOlJlcG9zaXRvcnk4MzExNDIxMQ==","name":"AstroTime.jl","full_name":"JuliaAstro/AstroTime.jl","owner":{"login":"JuliaAstro","id":6685132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2ODUxMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaAstro/AstroTime.jl","description":"Astronomical time keeping in Julia","fork":false,"url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl","forks_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/forks","keys_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/teams","hooks_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/events","assignees_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/tags","blobs_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/subscription","commits_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/merges","archive_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/downloads","issues_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/deployments","created_at":"2017-02-25T07:18:27Z","updated_at":"2018-06-14T12:42:50Z","pushed_at":"2018-06-17T09:54:36Z","git_url":"git://github.com/JuliaAstro/AstroTime.jl.git","ssh_url":"git@github.com:JuliaAstro/AstroTime.jl.git","clone_url":"https://github.com/JuliaAstro/AstroTime.jl.git","svn_url":"https://github.com/JuliaAstro/AstroTime.jl","homepage":"http://juliaastro.github.io/","size":149,"stargazers_count":3,"watchers_count":3,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30"},"html":{"href":"https://github.com/JuliaAstro/AstroTime.jl/pull/30"},"issue":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/30"},"comments":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaAstro/AstroTime.jl/statuses/2d720e78904d0be884af69f21f4650e6ff9e91fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"helgee"}}