{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20380","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20380/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20380/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20380/events","html_url":"https://github.com/joomla/joomla-cms/pull/20380","id":322545316,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjQxNzI2","number":20380,"title":"[4.0] Debug bar","user":{"login":"elkuku","id":33978,"node_id":"MDQ6VXNlcjMzOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/33978?v=4","gravatar_id":"","url":"https://api.github.com/users/elkuku","html_url":"https://github.com/elkuku","followers_url":"https://api.github.com/users/elkuku/followers","following_url":"https://api.github.com/users/elkuku/following{/other_user}","gists_url":"https://api.github.com/users/elkuku/gists{/gist_id}","starred_url":"https://api.github.com/users/elkuku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkuku/subscriptions","organizations_url":"https://api.github.com/users/elkuku/orgs","repos_url":"https://api.github.com/users/elkuku/repos","events_url":"https://api.github.com/users/elkuku/events{/privacy}","received_events_url":"https://api.github.com/users/elkuku/received_events","type":"User","site_admin":false},"labels":[{"id":307745144,"node_id":"MDU6TGFiZWwzMDc3NDUxNDQ=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Composer%20Dependency%20Changed","name":"Composer Dependency Changed","color":"207de5","default":false},{"id":198658453,"node_id":"MDU6TGFiZWwxOTg2NTg0NTM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2018-05-12T21:47:05Z","updated_at":"2018-08-14T06:31:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20380","html_url":"https://github.com/joomla/joomla-cms/pull/20380","diff_url":"https://github.com/joomla/joomla-cms/pull/20380.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20380.patch"},"body":"This is a redo of #15472 \r\n\r\n### Summary of Changes\r\n\r\nThe goal of this PR is to refactor the debug plugin (currently more than 2.000 lines of code) into smaller pieces.\r\nAn external library is used to display a floating debug bar. [See a demo](http://phpdebugbar.com/)\r\n\r\n### Testing Instructions\r\nRun\r\n\r\n    composer install\r\n    npm i\r\n\r\nTurn on debug and/or language debug and play with the various options in plugin configuration.\r\n\r\n### Expected result\r\n\r\n#### A beautiful floating debug toolbar (mobile ready) :wink: \r\n![bildschirmfoto_2018-05-12_16-19-09](https://user-images.githubusercontent.com/33978/39961654-bc5d9e66-5600-11e8-80d3-7e7f79ab08d0.png)\r\n\r\n### Actual result\r\n\r\n#### A not so beautiful looong thingy, fixed to the very bottom of the page.\r\n\r\n![bildschirmfoto_2018-05-12_16-20-57](https://user-images.githubusercontent.com/33978/39961655-bca736b6-5600-11e8-821a-6ade307f0973.png)\r\n\r\n### Documentation Changes Required\r\nAlot :tongue: \r\n\r\n### Extended Description\r\n\r\nWhile working on a [Symfony](https://symfony.com) project, I was amazed by the debug bar they offer and I thought about the old Joomla! plugin...<br />\r\nIntegrating the Symfony bar would require a lot of dependencies from Symfony, probably including the Symfony Application class. While this would be amazing, I suspect that this is not gonna happen any time soon...\r\n\r\nSo I started playing with [maximebf/debugbar](https://github.com/maximebf/php-debugbar) which claims to be inspired by the Symfony debug bar, but for \"non Symfony\" projects `;)`\r\n\r\nThis resulted in some `DataCollector` classes which, apart from collecting data, are responsible for bringing the collected data to something \"serializable\".\r\n\r\nThis data is then serialized and written to disk for later analysis. (**Not implemented yet**)\r\n\r\nAfter a thousand words, here are some screens:\r\n**Note**: Since the \"old\" code is still in place, you will see the \"old\" output as well as the \"new \" output in the screenshots.\r\n\r\n----\r\n\r\n### Session\r\n![2017-04-18-121246_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298253/2494a056-26b9-11e7-9665-c3a25c06b794.png)\r\n\r\n----\r\n\r\n### Profile\r\n![2017-04-21-133031_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298255/249a030c-26b9-11e7-8b95-0a6abbf31da6.png)\r\n\r\n----\r\n\r\n### Queries\r\nThe database query tab features including\r\n    * Highlighted queries\r\n    * Timings and memory reports\r\n    * A (clickable) call stack with indication of the \"caller\" (somewhat experimental)\r\n    * Duplicated query check\r\n    * Duplicated queries can be filtered **Note** the filter buttons are at the lower right corner :wink: \r\n    * A button to \"copy\" the query to the clipboard\r\n![bildschirmfotoxxx](https://user-images.githubusercontent.com/33978/43985741-7f9d3994-9ccf-11e8-97ba-d59c1001b695.png)\r\n\r\nCall stack\r\n![joomla 4 debug bar -call-stack](https://user-images.githubusercontent.com/33978/44042430-dc38f482-9ee5-11e8-91ec-9bd2667c322a.png)\r\n\r\nDuplicates filter\r\n![menus items main menu joomla 4 debug bar administration](https://user-images.githubusercontent.com/33978/44042438-dfd1afd0-9ee5-11e8-9770-2dcbccc82443.png)\r\n\r\n----\r\n\r\n### Deprecation logging\r\n![2017-04-21-171552_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298260/24d1f938-26b9-11e7-90b1-7e585fa01473.png)\r\n![bildschirmfoto_2018-05-12_16-37-52](https://user-images.githubusercontent.com/33978/39961780-ff001c24-5602-11e8-8a8c-9503f0d5d91a.png)\r\n\r\n----\r\n\r\n### Language stuff\r\nShould look as before, just more readable and compact.\r\n\r\n#### Loaded\r\n![2017-04-21-132535_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298256/249d4558-26b9-11e7-90a3-1d8f15842a81.png)\r\n\r\n#### Errors \r\n![2017-04-18-121557_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298257/249d6ae2-26b9-11e7-8406-8ef19db5b84b.png)\r\n\r\n#### Untranslated\r\n![2017-04-18-121539_1366x768_scrot](https://cloud.githubusercontent.com/assets/33978/25298258/249e1d2a-26b9-11e7-87c6-8a563fd82965.png)\r\n\r\n----\r\n\r\n### Mobile ready\r\n![screenshot_20170426-010917](https://cloud.githubusercontent.com/assets/33978/25421343/054e2354-2a22-11e7-8501-256bd4e49acc.png)\r\n\r\nTested on a 5'' screen with fat fingers and it worked pretty well.\r\n\r\n----\r\n\r\nHappy debugging `=;)`"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/412768731","html_url":"https://github.com/joomla/joomla-cms/pull/20380#issuecomment-412768731","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20380","id":412768731,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc2ODczMQ==","user":{"login":"roland-d","id":359377,"node_id":"MDQ6VXNlcjM1OTM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/359377?v=4","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T06:31:34Z","updated_at":"2018-08-14T06:31:34Z","author_association":"CONTRIBUTOR","body":"@elkuku I tested the caller text clickable for queries and they work but there is a weird side-effect. Every time I click on the link it opens in PhpStorm as expected but it also opens a blank tab. This only happens with the links in the queries.\r\n\r\n> Actually this is the standard behaviour which is also used to filter log messages.\r\n\r\nSo we can't have a button to toggle them all on/off?"}}
{"actor":{"display_login":"roland-d"}}