{"action":"created","issue":{"url":"https://api.github.com/repos/ranisalt/node-argon2/issues/117","repository_url":"https://api.github.com/repos/ranisalt/node-argon2","labels_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/117/comments","events_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/117/events","html_url":"https://github.com/ranisalt/node-argon2/issues/117","id":297730910,"number":117,"title":"Argon2 build fails on GCC 4.8","user":{"login":"danielopitz","id":1937970,"avatar_url":"https://avatars2.githubusercontent.com/u/1937970?v=4","gravatar_id":"","url":"https://api.github.com/users/danielopitz","html_url":"https://github.com/danielopitz","followers_url":"https://api.github.com/users/danielopitz/followers","following_url":"https://api.github.com/users/danielopitz/following{/other_user}","gists_url":"https://api.github.com/users/danielopitz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielopitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielopitz/subscriptions","organizations_url":"https://api.github.com/users/danielopitz/orgs","repos_url":"https://api.github.com/users/danielopitz/repos","events_url":"https://api.github.com/users/danielopitz/events{/privacy}","received_events_url":"https://api.github.com/users/danielopitz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars0.githubusercontent.com/u/1993083?v=4","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars0.githubusercontent.com/u/1993083?v=4","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-02-16T09:56:00Z","updated_at":"2018-03-27T10:54:58Z","closed_at":"2018-03-27T02:18:11Z","author_association":"NONE","body":"### Steps to reproduce\r\n1. Install argon2 v0.17.2 package via npm\r\n\r\n### Expected behaviour\r\nThe package is installed correctly, the build of the C++ argon2 binary does not fail. The build did not fail with argon2 v0.16.2\r\n\r\n### Actual behaviour\r\nThe build of argon2 v0.17.2 binary fails with following errors:\r\n```\r\nmake: Entering directory `/home/builds/c15a579e/0/sb/px/node_modules/argon2/build'\r\n  CC(target) Release/obj.target/libargon2/argon2/src/opt.o\r\n  CC(target) Release/obj.target/libargon2/argon2/src/argon2.o\r\n  CC(target) Release/obj.target/libargon2/argon2/src/core.o\r\n  CC(target) Release/obj.target/libargon2/argon2/src/blake2/blake2b.o\r\n  CC(target) Release/obj.target/libargon2/argon2/src/thread.o\r\n  CC(target) Release/obj.target/libargon2/argon2/src/encoding.o\r\n  AR(target) Release/obj.target/argon2.a\r\n  COPY Release/argon2.a\r\n  CXX(target) Release/obj.target/argon2/src/argon2_node.o\r\n../src/argon2_node.cpp: In constructor ‘NodeArgon2::HashWorker::HashWorker(std::string, NodeArgon2::Options)’:\r\n../src/argon2_node.cpp:85:31: error: could not convert ‘std::move<NodeArgon2::Options&>((* & options))’ from ‘std::remove_reference<NodeArgon2::Options&>::type {aka NodeArgon2::Options}’ to ‘std::string {aka std::basic_string<char>}’\r\n     options{std::move(options)}\r\n                               ^\r\n../src/argon2_node.cpp:85:31: warning: missing initializer for member ‘NodeArgon2::Options::hash_length’ [-Wmissing-field-initializers]\r\n../src/argon2_node.cpp:85:31: warning: missing initializer for member ‘NodeArgon2::Options::time_cost’ [-Wmissing-field-initializers]\r\n../src/argon2_node.cpp:85:31: warning: missing initializer for member ‘NodeArgon2::Options::memory_cost’ [-Wmissing-field-initializers]\r\n../src/argon2_node.cpp:85:31: warning: missing initializer for member ‘NodeArgon2::Options::parallelism’ [-Wmissing-field-initializers]\r\n../src/argon2_node.cpp:85:31: warning: missing initializer for member ‘NodeArgon2::Options::type’ [-Wmissing-field-initializers]\r\nmake: *** [Release/obj.target/argon2/src/argon2_node.o] Error 1\r\nmake: Leaving directory `/home/builds/c15a579e/0/sb/px/node_modules/argon2/build'\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)\r\ngyp ERR! stack     at emitTwo (events.js:126:13)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:214:7)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)\r\ngyp ERR! System Linux 3.10.0-693.17.1.el7.x86_64\r\ngyp ERR! command \"/usr/bin/node\" \"/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /home/builds/c15a579e/0/sb/px/node_modules/argon2\r\ngyp ERR! node -v v8.9.4\r\ngyp ERR! node-gyp -v v3.6.2\r\ngyp ERR! not ok \r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! argon2@0.17.2 install: `node-gyp rebuild`\r\nnpm ERR! Exit status 1\r\n```\r\n\r\n### Environment\r\n**Operating system**:\r\nCentOS 7 3.10.0-693.17.1.el7.x86_64\r\n**Node version:**\r\n8.9.4\r\n**Compiler version:**\r\n```\r\n$ gcc -v\r\nUsing built-in specs.\r\nCOLLECT_GCC=gcc\r\nCOLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper\r\nTarget: x86_64-redhat-linux\r\nConfigured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux\r\nThread model: posix\r\ngcc version 4.8.5 20150623 (Red Hat 4.8.5-16) (GCC)\r\n```"},"comment":{"url":"https://api.github.com/repos/ranisalt/node-argon2/issues/comments/376482664","html_url":"https://github.com/ranisalt/node-argon2/issues/117#issuecomment-376482664","issue_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/117","id":376482664,"user":{"login":"shaunie2fly","id":18495824,"avatar_url":"https://avatars3.githubusercontent.com/u/18495824?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunie2fly","html_url":"https://github.com/shaunie2fly","followers_url":"https://api.github.com/users/shaunie2fly/followers","following_url":"https://api.github.com/users/shaunie2fly/following{/other_user}","gists_url":"https://api.github.com/users/shaunie2fly/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunie2fly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunie2fly/subscriptions","organizations_url":"https://api.github.com/users/shaunie2fly/orgs","repos_url":"https://api.github.com/users/shaunie2fly/repos","events_url":"https://api.github.com/users/shaunie2fly/events{/privacy}","received_events_url":"https://api.github.com/users/shaunie2fly/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T10:54:58Z","updated_at":"2018-03-27T10:54:58Z","author_association":"NONE","body":"but ubuntu is the coolest  ;)"}}
{"actor":{"display_login":"shaunie2fly"}}