{"action":"created","comment":{"url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/comments/215036670","pull_request_review_id":152215663,"id":215036670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTAzNjY3MA==","diff_hunk":"@@ -642,3 +642,10 @@ gcamchina.TIBET_NATIONAL_ENERGY_SHARE <- 0.01\n # FUTURE_YEARS <- seq(2010, 2100, 5)  # normally seq(2015, 2100, 5)\n # BASE_YEARS <- c(1975, 1990, 2005)   # normally (1975, 1990, 2005, 2010)\n # MODEL_YEARS <- c(BASE_YEARS, FUTURE_YEARS)\n+\n+# GCAM-China provinces\n+gcamchina.PROVINCES <- c(\"AH\", \"BJ\", \"CQ\", \"FJ\", \"GD\", \"GS\", \"GX\", \"GZ\", \"HA\", \"HB\", \"HE\", \"HI\", \"HL\", \"HN\", \"JL\", \"JS\", \"JX\", \"LN\", \"NM\", \"NX\", \"QH\", \"SC\", \"SD\", \"SH\",\n+                         \"SN\", \"SX\", \"TJ\", \"XJ\", \"XZ\", \"YN\", \"ZJ\")\n+\n+gcamchina.PROVINCES.WITHOUT_XZ <- c(\"AH\", \"BJ\", \"CQ\", \"FJ\", \"GD\", \"GS\", \"GX\", \"GZ\", \"HA\", \"HB\", \"HE\", \"HI\", \"HL\", \"HN\", \"JL\", \"JS\", \"JX\", \"LN\", \"NM\", \"NX\", \"QH\", \"SC\", \"SD\", \"SH\",","path":"R/constants.R","position":9,"original_position":9,"commit_id":"819a292274ad00f25e4918bc01b222aedad1581b","original_commit_id":"819a292274ad00f25e4918bc01b222aedad1581b","user":{"login":"rynacui","id":25306778,"node_id":"MDQ6VXNlcjI1MzA2Nzc4","avatar_url":"https://avatars2.githubusercontent.com/u/25306778?v=4","gravatar_id":"","url":"https://api.github.com/users/rynacui","html_url":"https://github.com/rynacui","followers_url":"https://api.github.com/users/rynacui/followers","following_url":"https://api.github.com/users/rynacui/following{/other_user}","gists_url":"https://api.github.com/users/rynacui/gists{/gist_id}","starred_url":"https://api.github.com/users/rynacui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynacui/subscriptions","organizations_url":"https://api.github.com/users/rynacui/orgs","repos_url":"https://api.github.com/users/rynacui/repos","events_url":"https://api.github.com/users/rynacui/events{/privacy}","received_events_url":"https://api.github.com/users/rynacui/received_events","type":"User","site_admin":false},"body":"I don't think we need a separate list for this. ","created_at":"2018-09-04T19:20:34Z","updated_at":"2018-09-04T19:20:34Z","html_url":"https://github.com/JGCRI/gcamdata/pull/1045#discussion_r215036670","pull_request_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/comments/215036670"},"html":{"href":"https://github.com/JGCRI/gcamdata/pull/1045#discussion_r215036670"},"pull_request":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045"}}},"pull_request":{"url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045","id":206512474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTEyNDc0","html_url":"https://github.com/JGCRI/gcamdata/pull/1045","diff_url":"https://github.com/JGCRI/gcamdata/pull/1045.diff","patch_url":"https://github.com/JGCRI/gcamdata/pull/1045.patch","issue_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/1045","number":1045,"state":"open","locked":false,"title":"Yang lA1322.Fert china","user":{"login":"thuliuyang","id":30075641,"node_id":"MDQ6VXNlcjMwMDc1NjQx","avatar_url":"https://avatars1.githubusercontent.com/u/30075641?v=4","gravatar_id":"","url":"https://api.github.com/users/thuliuyang","html_url":"https://github.com/thuliuyang","followers_url":"https://api.github.com/users/thuliuyang/followers","following_url":"https://api.github.com/users/thuliuyang/following{/other_user}","gists_url":"https://api.github.com/users/thuliuyang/gists{/gist_id}","starred_url":"https://api.github.com/users/thuliuyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thuliuyang/subscriptions","organizations_url":"https://api.github.com/users/thuliuyang/orgs","repos_url":"https://api.github.com/users/thuliuyang/repos","events_url":"https://api.github.com/users/thuliuyang/events{/privacy}","received_events_url":"https://api.github.com/users/thuliuyang/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T20:47:43Z","updated_at":"2018-09-04T19:20:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b70314c2037f7844bacee7a13da5a2cf2570b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":989874376,"node_id":"MDU6TGFiZWw5ODk4NzQzNzY=","url":"https://api.github.com/repos/JGCRI/gcamdata/labels/gcam-china","name":"gcam-china","color":"002c7f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045/commits","review_comments_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045/comments","review_comment_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/1045/comments","statuses_url":"https://api.github.com/repos/JGCRI/gcamdata/statuses/819a292274ad00f25e4918bc01b222aedad1581b","head":{"label":"JGCRI:Yang_LA1322.Fert_china","ref":"Yang_LA1322.Fert_china","sha":"819a292274ad00f25e4918bc01b222aedad1581b","user":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"repo":{"id":72801482,"node_id":"MDEwOlJlcG9zaXRvcnk3MjgwMTQ4Mg==","name":"gcamdata","full_name":"JGCRI/gcamdata","owner":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JGCRI/gcamdata","description":"The GCAM data system","fork":false,"url":"https://api.github.com/repos/JGCRI/gcamdata","forks_url":"https://api.github.com/repos/JGCRI/gcamdata/forks","keys_url":"https://api.github.com/repos/JGCRI/gcamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JGCRI/gcamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JGCRI/gcamdata/teams","hooks_url":"https://api.github.com/repos/JGCRI/gcamdata/hooks","issue_events_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/events{/number}","events_url":"https://api.github.com/repos/JGCRI/gcamdata/events","assignees_url":"https://api.github.com/repos/JGCRI/gcamdata/assignees{/user}","branches_url":"https://api.github.com/repos/JGCRI/gcamdata/branches{/branch}","tags_url":"https://api.github.com/repos/JGCRI/gcamdata/tags","blobs_url":"https://api.github.com/repos/JGCRI/gcamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JGCRI/gcamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JGCRI/gcamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/JGCRI/gcamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JGCRI/gcamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/JGCRI/gcamdata/languages","stargazers_url":"https://api.github.com/repos/JGCRI/gcamdata/stargazers","contributors_url":"https://api.github.com/repos/JGCRI/gcamdata/contributors","subscribers_url":"https://api.github.com/repos/JGCRI/gcamdata/subscribers","subscription_url":"https://api.github.com/repos/JGCRI/gcamdata/subscription","commits_url":"https://api.github.com/repos/JGCRI/gcamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/JGCRI/gcamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/JGCRI/gcamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/JGCRI/gcamdata/contents/{+path}","compare_url":"https://api.github.com/repos/JGCRI/gcamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JGCRI/gcamdata/merges","archive_url":"https://api.github.com/repos/JGCRI/gcamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JGCRI/gcamdata/downloads","issues_url":"https://api.github.com/repos/JGCRI/gcamdata/issues{/number}","pulls_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/JGCRI/gcamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/JGCRI/gcamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JGCRI/gcamdata/labels{/name}","releases_url":"https://api.github.com/repos/JGCRI/gcamdata/releases{/id}","deployments_url":"https://api.github.com/repos/JGCRI/gcamdata/deployments","created_at":"2016-11-04T01:09:57Z","updated_at":"2018-08-27T11:58:56Z","pushed_at":"2018-09-04T18:03:09Z","git_url":"git://github.com/JGCRI/gcamdata.git","ssh_url":"git@github.com:JGCRI/gcamdata.git","clone_url":"https://github.com/JGCRI/gcamdata.git","svn_url":"https://github.com/JGCRI/gcamdata","homepage":"","size":90013,"stargazers_count":6,"watchers_count":6,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":110,"watchers":6,"default_branch":"master"}},"base":{"label":"JGCRI:gcamdata-China-v1.0","ref":"gcamdata-China-v1.0","sha":"7f5d2bf96ee9e520215bf748efc62a45ca0be85a","user":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"repo":{"id":72801482,"node_id":"MDEwOlJlcG9zaXRvcnk3MjgwMTQ4Mg==","name":"gcamdata","full_name":"JGCRI/gcamdata","owner":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JGCRI/gcamdata","description":"The GCAM data system","fork":false,"url":"https://api.github.com/repos/JGCRI/gcamdata","forks_url":"https://api.github.com/repos/JGCRI/gcamdata/forks","keys_url":"https://api.github.com/repos/JGCRI/gcamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JGCRI/gcamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JGCRI/gcamdata/teams","hooks_url":"https://api.github.com/repos/JGCRI/gcamdata/hooks","issue_events_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/events{/number}","events_url":"https://api.github.com/repos/JGCRI/gcamdata/events","assignees_url":"https://api.github.com/repos/JGCRI/gcamdata/assignees{/user}","branches_url":"https://api.github.com/repos/JGCRI/gcamdata/branches{/branch}","tags_url":"https://api.github.com/repos/JGCRI/gcamdata/tags","blobs_url":"https://api.github.com/repos/JGCRI/gcamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JGCRI/gcamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JGCRI/gcamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/JGCRI/gcamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JGCRI/gcamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/JGCRI/gcamdata/languages","stargazers_url":"https://api.github.com/repos/JGCRI/gcamdata/stargazers","contributors_url":"https://api.github.com/repos/JGCRI/gcamdata/contributors","subscribers_url":"https://api.github.com/repos/JGCRI/gcamdata/subscribers","subscription_url":"https://api.github.com/repos/JGCRI/gcamdata/subscription","commits_url":"https://api.github.com/repos/JGCRI/gcamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/JGCRI/gcamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/JGCRI/gcamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/JGCRI/gcamdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/JGCRI/gcamdata/contents/{+path}","compare_url":"https://api.github.com/repos/JGCRI/gcamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JGCRI/gcamdata/merges","archive_url":"https://api.github.com/repos/JGCRI/gcamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JGCRI/gcamdata/downloads","issues_url":"https://api.github.com/repos/JGCRI/gcamdata/issues{/number}","pulls_url":"https://api.github.com/repos/JGCRI/gcamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/JGCRI/gcamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/JGCRI/gcamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JGCRI/gcamdata/labels{/name}","releases_url":"https://api.github.com/repos/JGCRI/gcamdata/releases{/id}","deployments_url":"https://api.github.com/repos/JGCRI/gcamdata/deployments","created_at":"2016-11-04T01:09:57Z","updated_at":"2018-08-27T11:58:56Z","pushed_at":"2018-09-04T18:03:09Z","git_url":"git://github.com/JGCRI/gcamdata.git","ssh_url":"git@github.com:JGCRI/gcamdata.git","clone_url":"https://github.com/JGCRI/gcamdata.git","svn_url":"https://github.com/JGCRI/gcamdata","homepage":"","size":90013,"stargazers_count":6,"watchers_count":6,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":110,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045"},"html":{"href":"https://github.com/JGCRI/gcamdata/pull/1045"},"issue":{"href":"https://api.github.com/repos/JGCRI/gcamdata/issues/1045"},"comments":{"href":"https://api.github.com/repos/JGCRI/gcamdata/issues/1045/comments"},"review_comments":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045/comments"},"review_comment":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JGCRI/gcamdata/pulls/1045/commits"},"statuses":{"href":"https://api.github.com/repos/JGCRI/gcamdata/statuses/819a292274ad00f25e4918bc01b222aedad1581b"}},"author_association":"NONE"}}
{"actor":{"display_login":"rynacui"}}