{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/5040","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/5040/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5040/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/5040/events","html_url":"https://github.com/dotnet/corefx/issues/5040","id":122803154,"node_id":"MDU6SXNzdWUxMjI4MDMxNTQ=","number":5040,"title":"String resources need to be configurable on a per-configuration basis","user":{"login":"mellinoe","id":8918977,"node_id":"MDQ6VXNlcjg5MTg5Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8918977?v=4","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"labels":[{"id":174888041,"node_id":"MDU6TGFiZWwxNzQ4ODgwNDE=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-Infrastructure","name":"area-Infrastructure","color":"d4c5f9","default":false},{"id":145399957,"node_id":"MDU6TGFiZWwxNDUzOTk5NTc=","url":"https://api.github.com/repos/dotnet/corefx/labels/enhancement","name":"enhancement","color":"207de5","default":true},{"id":145399958,"node_id":"MDU6TGFiZWwxNDUzOTk5NTg=","url":"https://api.github.com/repos/dotnet/corefx/labels/up-for-grabs","name":"up-for-grabs","color":"159818","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/5","html_url":"https://github.com/dotnet/corefx/milestone/5","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/5/labels","id":1328080,"node_id":"MDk6TWlsZXN0b25lMTMyODA4MA==","number":5,"title":"Future","description":"Milestone tracking issues not triaged to a planned release. Work in this milestone may happen, or may not: it is not committed.","creator":{"login":"joshfree","id":1302850,"node_id":"MDQ6VXNlcjEzMDI4NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1302850?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":1912,"closed_issues":139,"state":"open","created_at":"2015-09-29T00:25:45Z","updated_at":"2018-08-17T12:44:46Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-12-17T19:15:52Z","updated_at":"2018-08-17T12:44:45Z","closed_at":"2018-08-17T12:44:45Z","author_association":"CONTRIBUTOR","body":"Right now, string resources are included by default in an assembly if there exists a \"Strings.resx\" file in a \"Resources\" subdirectory under the csproj. All of the string resources in that file are included in the assembly, even if they are not used at all, or if only a subset are used. You can \"opt-out\" in a sense by changing the directory that the resource targets look in for the \"Strings.resx\" file (the `ResourcesSourceOutputDirectory` Property).\n\nThis has worked fine for our projects with a single configuration, or with only a few similar configurations. However, this can cause significant bloat in assemblies which don't need those resources. For example, full-facade projects are generally around 5-6 KB in total size. With unnecessary string resources included, they can easily bloat to 25-30 KB each. To a lesser extent, configurations which only need a subset of the resources are also bloated by having extra strings in them.\n\nIn our internal build, I recall we used text files that allowed condition inclusion/exclusion of certain strings, based on the project's DefineConstants. We might want to look into something similar to that in order to accomodate this.\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/413853896","html_url":"https://github.com/dotnet/corefx/issues/5040#issuecomment-413853896","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5040","id":413853896,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzg1Mzg5Ng==","user":{"login":"ViktorHofer","id":7412651,"node_id":"MDQ6VXNlcjc0MTI2NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7412651?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T12:44:45Z","updated_at":"2018-08-17T12:44:45Z","author_association":"MEMBER","body":"I'm not convinced we need to do anything here after we trimmed most of the assemblies and removed dead code / resources. Not sure, but the linker that we now use could also remove additional bloat. Closing for now. Feel free to reopen if you disagree."}}
{"actor":{"display_login":"ViktorHofer"}}