{"action":"created","comment":{"url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/comments/210568267","pull_request_review_id":146809492,"id":210568267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDU2ODI2Nw==","diff_hunk":"@@ -13,6 +13,7 @@ import (\n \t\"testing\"\n \n \t\"github.com/gorilla/rpc/v2\"\n+\t\"strings\"","path":"v2/json2/json_test.go","position":4,"original_position":4,"commit_id":"ce16ce66f384d0cfa4c41cb3f27dc743bda62443","original_commit_id":"ce16ce66f384d0cfa4c41cb3f27dc743bda62443","user":{"login":"tcard","id":727422,"node_id":"MDQ6VXNlcjcyNzQyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/727422?v=4","gravatar_id":"","url":"https://api.github.com/users/tcard","html_url":"https://github.com/tcard","followers_url":"https://api.github.com/users/tcard/followers","following_url":"https://api.github.com/users/tcard/following{/other_user}","gists_url":"https://api.github.com/users/tcard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcard/subscriptions","organizations_url":"https://api.github.com/users/tcard/orgs","repos_url":"https://api.github.com/users/tcard/repos","events_url":"https://api.github.com/users/tcard/events{/privacy}","received_events_url":"https://api.github.com/users/tcard/received_events","type":"User","site_admin":false},"body":"Remove `\"strings\"`, then run `goimports` again. It should add `\"strings\"` to the import group above, alongside the rest of the standard library imports.","created_at":"2018-08-16T11:58:39Z","updated_at":"2018-08-16T11:59:02Z","html_url":"https://github.com/cabify/gorilla-rpc/pull/1#discussion_r210568267","pull_request_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/comments/210568267"},"html":{"href":"https://github.com/cabify/gorilla-rpc/pull/1#discussion_r210568267"},"pull_request":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1"}},"in_reply_to_id":210549874},"pull_request":{"url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1","id":208813777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODEzNzc3","html_url":"https://github.com/cabify/gorilla-rpc/pull/1","diff_url":"https://github.com/cabify/gorilla-rpc/pull/1.diff","patch_url":"https://github.com/cabify/gorilla-rpc/pull/1.patch","issue_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/1","number":1,"state":"open","locked":false,"title":"Return E_PARSE error when JSON can't be parsed","user":{"login":"colega","id":1511481,"node_id":"MDQ6VXNlcjE1MTE0ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1511481?v=4","gravatar_id":"","url":"https://api.github.com/users/colega","html_url":"https://github.com/colega","followers_url":"https://api.github.com/users/colega/followers","following_url":"https://api.github.com/users/colega/following{/other_user}","gists_url":"https://api.github.com/users/colega/gists{/gist_id}","starred_url":"https://api.github.com/users/colega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colega/subscriptions","organizations_url":"https://api.github.com/users/colega/orgs","repos_url":"https://api.github.com/users/colega/repos","events_url":"https://api.github.com/users/colega/events{/privacy}","received_events_url":"https://api.github.com/users/colega/received_events","type":"User","site_admin":false},"body":"An empty-body HTTP 200 OK response was returned to malformed requests\r\nbecause:\r\n - As JSON could not be parsed, res.Version was empty and `err` was\r\n being overwritten by E_INVALID_REQ. Solution: only check that if there\r\n was no parse error.\r\n - As JSON could not be parsed, red.Id was empty and writeServerResponse\r\n was considering it was a Notification request, so the response was\r\n discarded. Solution: if ID is empty, make sure we're not trying to\r\n write an E_PARSE error.","created_at":"2018-08-16T10:28:34Z","updated_at":"2018-08-16T11:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af62d5f53046812b83f3825e2a8a7474c33626f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/1/comments","statuses_url":"https://api.github.com/repos/cabify/gorilla-rpc/statuses/ce16ce66f384d0cfa4c41cb3f27dc743bda62443","head":{"label":"cabify:colega/return-parse-error-responses","ref":"colega/return-parse-error-responses","sha":"ce16ce66f384d0cfa4c41cb3f27dc743bda62443","user":{"login":"cabify","id":924915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/924915?v=4","gravatar_id":"","url":"https://api.github.com/users/cabify","html_url":"https://github.com/cabify","followers_url":"https://api.github.com/users/cabify/followers","following_url":"https://api.github.com/users/cabify/following{/other_user}","gists_url":"https://api.github.com/users/cabify/gists{/gist_id}","starred_url":"https://api.github.com/users/cabify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabify/subscriptions","organizations_url":"https://api.github.com/users/cabify/orgs","repos_url":"https://api.github.com/users/cabify/repos","events_url":"https://api.github.com/users/cabify/events{/privacy}","received_events_url":"https://api.github.com/users/cabify/received_events","type":"Organization","site_admin":false},"repo":{"id":144968903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5Njg5MDM=","name":"gorilla-rpc","full_name":"cabify/gorilla-rpc","owner":{"login":"cabify","id":924915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/924915?v=4","gravatar_id":"","url":"https://api.github.com/users/cabify","html_url":"https://github.com/cabify","followers_url":"https://api.github.com/users/cabify/followers","following_url":"https://api.github.com/users/cabify/following{/other_user}","gists_url":"https://api.github.com/users/cabify/gists{/gist_id}","starred_url":"https://api.github.com/users/cabify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabify/subscriptions","organizations_url":"https://api.github.com/users/cabify/orgs","repos_url":"https://api.github.com/users/cabify/repos","events_url":"https://api.github.com/users/cabify/events{/privacy}","received_events_url":"https://api.github.com/users/cabify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cabify/gorilla-rpc","description":"A golang foundation for RPC over HTTP services.","fork":true,"url":"https://api.github.com/repos/cabify/gorilla-rpc","forks_url":"https://api.github.com/repos/cabify/gorilla-rpc/forks","keys_url":"https://api.github.com/repos/cabify/gorilla-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cabify/gorilla-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cabify/gorilla-rpc/teams","hooks_url":"https://api.github.com/repos/cabify/gorilla-rpc/hooks","issue_events_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/cabify/gorilla-rpc/events","assignees_url":"https://api.github.com/repos/cabify/gorilla-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/cabify/gorilla-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/cabify/gorilla-rpc/tags","blobs_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cabify/gorilla-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/cabify/gorilla-rpc/languages","stargazers_url":"https://api.github.com/repos/cabify/gorilla-rpc/stargazers","contributors_url":"https://api.github.com/repos/cabify/gorilla-rpc/contributors","subscribers_url":"https://api.github.com/repos/cabify/gorilla-rpc/subscribers","subscription_url":"https://api.github.com/repos/cabify/gorilla-rpc/subscription","commits_url":"https://api.github.com/repos/cabify/gorilla-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cabify/gorilla-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cabify/gorilla-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/cabify/gorilla-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cabify/gorilla-rpc/merges","archive_url":"https://api.github.com/repos/cabify/gorilla-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cabify/gorilla-rpc/downloads","issues_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/cabify/gorilla-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/cabify/gorilla-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cabify/gorilla-rpc/labels{/name}","releases_url":"https://api.github.com/repos/cabify/gorilla-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/cabify/gorilla-rpc/deployments","created_at":"2018-08-16T09:49:34Z","updated_at":"2018-08-16T10:40:12Z","pushed_at":"2018-08-16T11:53:24Z","git_url":"git://github.com/cabify/gorilla-rpc.git","ssh_url":"git@github.com:cabify/gorilla-rpc.git","clone_url":"https://github.com/cabify/gorilla-rpc.git","svn_url":"https://github.com/cabify/gorilla-rpc","homepage":"http://www.gorillatoolkit.org/pkg/rpc","size":92,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"cabify:fork","ref":"fork","sha":"5c1378103183095acc1b9289ac1475e3bc1e818e","user":{"login":"cabify","id":924915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/924915?v=4","gravatar_id":"","url":"https://api.github.com/users/cabify","html_url":"https://github.com/cabify","followers_url":"https://api.github.com/users/cabify/followers","following_url":"https://api.github.com/users/cabify/following{/other_user}","gists_url":"https://api.github.com/users/cabify/gists{/gist_id}","starred_url":"https://api.github.com/users/cabify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabify/subscriptions","organizations_url":"https://api.github.com/users/cabify/orgs","repos_url":"https://api.github.com/users/cabify/repos","events_url":"https://api.github.com/users/cabify/events{/privacy}","received_events_url":"https://api.github.com/users/cabify/received_events","type":"Organization","site_admin":false},"repo":{"id":144968903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5Njg5MDM=","name":"gorilla-rpc","full_name":"cabify/gorilla-rpc","owner":{"login":"cabify","id":924915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/924915?v=4","gravatar_id":"","url":"https://api.github.com/users/cabify","html_url":"https://github.com/cabify","followers_url":"https://api.github.com/users/cabify/followers","following_url":"https://api.github.com/users/cabify/following{/other_user}","gists_url":"https://api.github.com/users/cabify/gists{/gist_id}","starred_url":"https://api.github.com/users/cabify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabify/subscriptions","organizations_url":"https://api.github.com/users/cabify/orgs","repos_url":"https://api.github.com/users/cabify/repos","events_url":"https://api.github.com/users/cabify/events{/privacy}","received_events_url":"https://api.github.com/users/cabify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cabify/gorilla-rpc","description":"A golang foundation for RPC over HTTP services.","fork":true,"url":"https://api.github.com/repos/cabify/gorilla-rpc","forks_url":"https://api.github.com/repos/cabify/gorilla-rpc/forks","keys_url":"https://api.github.com/repos/cabify/gorilla-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cabify/gorilla-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cabify/gorilla-rpc/teams","hooks_url":"https://api.github.com/repos/cabify/gorilla-rpc/hooks","issue_events_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/cabify/gorilla-rpc/events","assignees_url":"https://api.github.com/repos/cabify/gorilla-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/cabify/gorilla-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/cabify/gorilla-rpc/tags","blobs_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cabify/gorilla-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/cabify/gorilla-rpc/languages","stargazers_url":"https://api.github.com/repos/cabify/gorilla-rpc/stargazers","contributors_url":"https://api.github.com/repos/cabify/gorilla-rpc/contributors","subscribers_url":"https://api.github.com/repos/cabify/gorilla-rpc/subscribers","subscription_url":"https://api.github.com/repos/cabify/gorilla-rpc/subscription","commits_url":"https://api.github.com/repos/cabify/gorilla-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cabify/gorilla-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cabify/gorilla-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cabify/gorilla-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/cabify/gorilla-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cabify/gorilla-rpc/merges","archive_url":"https://api.github.com/repos/cabify/gorilla-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cabify/gorilla-rpc/downloads","issues_url":"https://api.github.com/repos/cabify/gorilla-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/cabify/gorilla-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/cabify/gorilla-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/cabify/gorilla-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cabify/gorilla-rpc/labels{/name}","releases_url":"https://api.github.com/repos/cabify/gorilla-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/cabify/gorilla-rpc/deployments","created_at":"2018-08-16T09:49:34Z","updated_at":"2018-08-16T10:40:12Z","pushed_at":"2018-08-16T11:53:24Z","git_url":"git://github.com/cabify/gorilla-rpc.git","ssh_url":"git@github.com:cabify/gorilla-rpc.git","clone_url":"https://github.com/cabify/gorilla-rpc.git","svn_url":"https://github.com/cabify/gorilla-rpc","homepage":"http://www.gorillatoolkit.org/pkg/rpc","size":92,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1"},"html":{"href":"https://github.com/cabify/gorilla-rpc/pull/1"},"issue":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/issues/1"},"comments":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cabify/gorilla-rpc/statuses/ce16ce66f384d0cfa4c41cb3f27dc743bda62443"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tcard"}}