{"action":"opened","number":1506,"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506","id":172863124,"html_url":"https://github.com/aws/aws-sdk-php/pull/1506","diff_url":"https://github.com/aws/aws-sdk-php/pull/1506.diff","patch_url":"https://github.com/aws/aws-sdk-php/pull/1506.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506","number":1506,"state":"open","locked":false,"title":"CURLE_RECV_ERROR  error retry fixed","user":{"login":"Halama","id":903531,"avatar_url":"https://avatars3.githubusercontent.com/u/903531?v=4","gravatar_id":"","url":"https://api.github.com/users/Halama","html_url":"https://github.com/Halama","followers_url":"https://api.github.com/users/Halama/followers","following_url":"https://api.github.com/users/Halama/following{/other_user}","gists_url":"https://api.github.com/users/Halama/gists{/gist_id}","starred_url":"https://api.github.com/users/Halama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halama/subscriptions","organizations_url":"https://api.github.com/users/Halama/orgs","repos_url":"https://api.github.com/users/Halama/repos","events_url":"https://api.github.com/users/Halama/events{/privacy}","received_events_url":"https://api.github.com/users/Halama/received_events","type":"User","site_admin":false},"body":"Hello,\r\nwe have upgraded to the latest AWS SDK because the retry of `CURLE_RECV_ERROR` was fixed in https://github.com/aws/aws-sdk-php/releases/tag/3.52.0\r\n\r\nUnfortunately after deploy of the new application version with updated AWS SDK we are still receiving occasional `CURLE_RECV_ERROR` errors.\r\n\r\nI've tried to debug a code and I've noticed that `GuzzleHttp\\Exception\\ConnectException` exception is expected in AWS SDK https://github.com/aws/aws-sdk-php/blob/299ac47ff5171d6a25f788dc333c0a3c8db40f69/src/RetryMiddleware.php#L104 but `GuzzleHttp\\Exception\\RequestException` is  thrown in Guzzle https://github.com/guzzle/guzzle/blob/748d67e23a984e7a2562847994fd133fd4e629a6/src/Handler/CurlFactory.php#L154 . \r\nSo I think that `CURLE_RECV_ERROR` is never retried. \r\nThis PR should fix it.\r\n\r\nthanks\r\n\r\n","created_at":"2018-03-05T13:12:26Z","updated_at":"2018-03-05T13:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-php/statuses/998e8f141e3c2f90bee3b805af4babe55cc84a99","head":{"label":"Halama:curl-retry","ref":"curl-retry","sha":"998e8f141e3c2f90bee3b805af4babe55cc84a99","user":{"login":"Halama","id":903531,"avatar_url":"https://avatars3.githubusercontent.com/u/903531?v=4","gravatar_id":"","url":"https://api.github.com/users/Halama","html_url":"https://github.com/Halama","followers_url":"https://api.github.com/users/Halama/followers","following_url":"https://api.github.com/users/Halama/following{/other_user}","gists_url":"https://api.github.com/users/Halama/gists{/gist_id}","starred_url":"https://api.github.com/users/Halama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halama/subscriptions","organizations_url":"https://api.github.com/users/Halama/orgs","repos_url":"https://api.github.com/users/Halama/repos","events_url":"https://api.github.com/users/Halama/events{/privacy}","received_events_url":"https://api.github.com/users/Halama/received_events","type":"User","site_admin":false},"repo":{"id":55173349,"name":"aws-sdk-php","full_name":"Halama/aws-sdk-php","owner":{"login":"Halama","id":903531,"avatar_url":"https://avatars3.githubusercontent.com/u/903531?v=4","gravatar_id":"","url":"https://api.github.com/users/Halama","html_url":"https://github.com/Halama","followers_url":"https://api.github.com/users/Halama/followers","following_url":"https://api.github.com/users/Halama/following{/other_user}","gists_url":"https://api.github.com/users/Halama/gists{/gist_id}","starred_url":"https://api.github.com/users/Halama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halama/subscriptions","organizations_url":"https://api.github.com/users/Halama/orgs","repos_url":"https://api.github.com/users/Halama/repos","events_url":"https://api.github.com/users/Halama/events{/privacy}","received_events_url":"https://api.github.com/users/Halama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Halama/aws-sdk-php","description":"Official repository of the AWS SDK for PHP (@awsforphp)","fork":true,"url":"https://api.github.com/repos/Halama/aws-sdk-php","forks_url":"https://api.github.com/repos/Halama/aws-sdk-php/forks","keys_url":"https://api.github.com/repos/Halama/aws-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Halama/aws-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Halama/aws-sdk-php/teams","hooks_url":"https://api.github.com/repos/Halama/aws-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/Halama/aws-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/Halama/aws-sdk-php/events","assignees_url":"https://api.github.com/repos/Halama/aws-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/Halama/aws-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/Halama/aws-sdk-php/tags","blobs_url":"https://api.github.com/repos/Halama/aws-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Halama/aws-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Halama/aws-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/Halama/aws-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Halama/aws-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/Halama/aws-sdk-php/languages","stargazers_url":"https://api.github.com/repos/Halama/aws-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/Halama/aws-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/Halama/aws-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/Halama/aws-sdk-php/subscription","commits_url":"https://api.github.com/repos/Halama/aws-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/Halama/aws-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/Halama/aws-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/Halama/aws-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/Halama/aws-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/Halama/aws-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Halama/aws-sdk-php/merges","archive_url":"https://api.github.com/repos/Halama/aws-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Halama/aws-sdk-php/downloads","issues_url":"https://api.github.com/repos/Halama/aws-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/Halama/aws-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/Halama/aws-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/Halama/aws-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Halama/aws-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/Halama/aws-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/Halama/aws-sdk-php/deployments","created_at":"2016-03-31T18:23:30Z","updated_at":"2016-03-31T18:23:33Z","pushed_at":"2018-03-05T12:56:12Z","git_url":"git://github.com/Halama/aws-sdk-php.git","ssh_url":"git@github.com:Halama/aws-sdk-php.git","clone_url":"https://github.com/Halama/aws-sdk-php.git","svn_url":"https://github.com/Halama/aws-sdk-php","homepage":"http://aws.amazon.com/sdkforphp","size":24747,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"299ac47ff5171d6a25f788dc333c0a3c8db40f69","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":6269013,"name":"aws-sdk-php","full_name":"aws/aws-sdk-php","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-php","description":"Official repository of the AWS SDK for PHP (@awsforphp)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-php","forks_url":"https://api.github.com/repos/aws/aws-sdk-php/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-php/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-php/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-php/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-php/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-php/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-php/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-php/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-php/deployments","created_at":"2012-10-17T21:28:32Z","updated_at":"2018-03-05T02:14:55Z","pushed_at":"2018-03-01T20:19:45Z","git_url":"git://github.com/aws/aws-sdk-php.git","ssh_url":"git@github.com:aws/aws-sdk-php.git","clone_url":"https://github.com/aws/aws-sdk-php.git","svn_url":"https://github.com/aws/aws-sdk-php","homepage":"http://aws.amazon.com/sdkforphp","size":41113,"stargazers_count":2970,"watchers_count":2970,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":751,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":751,"open_issues":13,"watchers":2970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506"},"html":{"href":"https://github.com/aws/aws-sdk-php/pull/1506"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-php/statuses/998e8f141e3c2f90bee3b805af4babe55cc84a99"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":13,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"Halama"}}