{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/88","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/88/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/88/events","html_url":"https://github.com/openshift/installer/pull/88","id":346364606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjQ3MzI0","number":88,"title":"wip: modules/aws: Drop auto-scaling groups","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959731323,"node_id":"MDU6TGFiZWw5NTk3MzEzMjM=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":981486838,"node_id":"MDU6TGFiZWw5ODE0ODY4Mzg=","url":"https://api.github.com/repos/openshift/installer/labels/run-smoke-tests","name":"run-smoke-tests","color":"0e8a16","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-31T21:26:47Z","updated_at":"2018-08-20T18:35:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/88","html_url":"https://github.com/openshift/installer/pull/88","diff_url":"https://github.com/openshift/installer/pull/88.diff","patch_url":"https://github.com/openshift/installer/pull/88.patch"},"body":"Currently, the installer creates an ASG for both masters and workers.  While this is okay for workers, this causes quite a few headaches for masters.  For example, etcd will be run on the master nodes, but this will be unstable if Amazon is free to delete nodes and recreate them without etcd knowing about it.  Additionally, this makes bootstrap tricky because every master needs to be identical.  In order to break the dependency loop between the MachineConfigController (TNC) and the master nodes, a CNAME is currently used to temporarily redirect Ignition's requests to an S3 bucket with a pre-computed bootstrap config.\n\nThis commit drops the use of ASG for both masters and workers and instead creates individual machines. Once we adopt the use of MachineSets and MachineControllers, we'll regain the functionality we lost by dropping ASGs.\n\nWhile renaming the previous `*-asg` modules, I've also renamed the main Terraform files to `main.tf` to comply with [the standard module structure][1].\n\nThe new `main.tf` follow the example set by `modules/aws/etcd/nodes.tf`, which is why the instance resource declarations have moved to the end of the file.  I've also adjusted the master policy to more closely match the more-restrictive etcd policy, because I don't think the masters will need to push S3 resources, etc.\n\nI've also dropped some redundant names (e.g. `master_profile` -> `master`), because the profile-ness is already covered in the resource name (e.g. `aws_iam_instance_profile.master`).\n\nThe worker load balancer is a bit more complicated now, since we have to loop over both the provided load balancers and the created worker instances to setup associations.\n\n[1]: https://www.terraform.io/docs/modules/create.html#standard-module-structure"},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/414418877","html_url":"https://github.com/openshift/installer/pull/88#issuecomment-414418877","issue_url":"https://api.github.com/repos/openshift/installer/issues/88","id":414418877,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQxODg3Nw==","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T18:35:58Z","updated_at":"2018-08-20T18:35:58Z","author_association":"MEMBER","body":"@yifan-gu rebased around #127 with 9421288 -> d93d94b"}}
{"actor":{"display_login":"wking"}}