{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206128570","pull_request_review_id":141527393,"id":206128570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyODU3MA==","diff_hunk":"@@ -22,14 +22,18 @@ let\n \n     makeFlags = [ \"world\" ];\n \n+    preConfigure = ''\n+    export NIX_CFLAGS_COMPILE=\"$NIX_CFLAGS_COMPILE -I${libxml2.dev}/include/libxml2\"","path":"pkgs/servers/sql/postgresql/default.nix","position":11,"original_position":11,"commit_id":"bb2dda2b37494cc7a9be25e8c5df82c7bf7714bc","original_commit_id":"bb2dda2b37494cc7a9be25e8c5df82c7bf7714bc","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"The long-term solution would be `pkg-config`: However this would been an upstream fix: https://github.com/libarchive/libarchive/issues/407","created_at":"2018-07-30T13:17:45Z","updated_at":"2018-07-30T13:17:45Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44083#discussion_r206128570","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206128570"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44083#discussion_r206128570"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083"}},"in_reply_to_id":206123623},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083","id":203763608,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzYzNjA4","html_url":"https://github.com/NixOS/nixpkgs/pull/44083","diff_url":"https://github.com/NixOS/nixpkgs/pull/44083.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44083.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44083","number":44083,"state":"open","locked":false,"title":"Allow postgresql to cross compile","user":{"login":"dingxiangfei2009","id":6884440,"node_id":"MDQ6VXNlcjY4ODQ0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6884440?v=4","gravatar_id":"","url":"https://api.github.com/users/dingxiangfei2009","html_url":"https://github.com/dingxiangfei2009","followers_url":"https://api.github.com/users/dingxiangfei2009/followers","following_url":"https://api.github.com/users/dingxiangfei2009/following{/other_user}","gists_url":"https://api.github.com/users/dingxiangfei2009/gists{/gist_id}","starred_url":"https://api.github.com/users/dingxiangfei2009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dingxiangfei2009/subscriptions","organizations_url":"https://api.github.com/users/dingxiangfei2009/orgs","repos_url":"https://api.github.com/users/dingxiangfei2009/repos","events_url":"https://api.github.com/users/dingxiangfei2009/events{/privacy}","received_events_url":"https://api.github.com/users/dingxiangfei2009/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nCurrently, `PostgreSQL` does not cross compile due to not listing `libXML2` headers as a native build dependency properly, and `libossp-uuid` as a dependency of `PostgreSQL` does not cross compile because it does not respect `strip` command setting made by `configure`.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-07-25T08:46:14Z","updated_at":"2018-07-30T13:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a1eb1adfa2d66f5aee7a4a11603807805f3a248","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735640,"node_id":"MDU6TGFiZWw3MzE3MzU2NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20101-500","name":"10.rebuild-darwin: 101-500","color":"d93f0b","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44083/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bb2dda2b37494cc7a9be25e8c5df82c7bf7714bc","head":{"label":"dingxiangfei2009:cross-compiling-postgresql","ref":"cross-compiling-postgresql","sha":"bb2dda2b37494cc7a9be25e8c5df82c7bf7714bc","user":{"login":"dingxiangfei2009","id":6884440,"node_id":"MDQ6VXNlcjY4ODQ0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6884440?v=4","gravatar_id":"","url":"https://api.github.com/users/dingxiangfei2009","html_url":"https://github.com/dingxiangfei2009","followers_url":"https://api.github.com/users/dingxiangfei2009/followers","following_url":"https://api.github.com/users/dingxiangfei2009/following{/other_user}","gists_url":"https://api.github.com/users/dingxiangfei2009/gists{/gist_id}","starred_url":"https://api.github.com/users/dingxiangfei2009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dingxiangfei2009/subscriptions","organizations_url":"https://api.github.com/users/dingxiangfei2009/orgs","repos_url":"https://api.github.com/users/dingxiangfei2009/repos","events_url":"https://api.github.com/users/dingxiangfei2009/events{/privacy}","received_events_url":"https://api.github.com/users/dingxiangfei2009/received_events","type":"User","site_admin":false},"repo":{"id":137902075,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MDIwNzU=","name":"nixpkgs","full_name":"dingxiangfei2009/nixpkgs","owner":{"login":"dingxiangfei2009","id":6884440,"node_id":"MDQ6VXNlcjY4ODQ0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6884440?v=4","gravatar_id":"","url":"https://api.github.com/users/dingxiangfei2009","html_url":"https://github.com/dingxiangfei2009","followers_url":"https://api.github.com/users/dingxiangfei2009/followers","following_url":"https://api.github.com/users/dingxiangfei2009/following{/other_user}","gists_url":"https://api.github.com/users/dingxiangfei2009/gists{/gist_id}","starred_url":"https://api.github.com/users/dingxiangfei2009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dingxiangfei2009/subscriptions","organizations_url":"https://api.github.com/users/dingxiangfei2009/orgs","repos_url":"https://api.github.com/users/dingxiangfei2009/repos","events_url":"https://api.github.com/users/dingxiangfei2009/events{/privacy}","received_events_url":"https://api.github.com/users/dingxiangfei2009/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dingxiangfei2009/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs","forks_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/forks","keys_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/events","assignees_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/merges","archive_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dingxiangfei2009/nixpkgs/deployments","created_at":"2018-06-19T14:22:45Z","updated_at":"2018-07-26T12:31:34Z","pushed_at":"2018-07-30T07:48:01Z","git_url":"git://github.com/dingxiangfei2009/nixpkgs.git","ssh_url":"git@github.com:dingxiangfei2009/nixpkgs.git","clone_url":"https://github.com/dingxiangfei2009/nixpkgs.git","svn_url":"https://github.com/dingxiangfei2009/nixpkgs","homepage":null,"size":817846,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"408bd2b80ed198004311c9bb638e776dafffa908","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-07-30T12:49:50Z","pushed_at":"2018-07-30T12:47:02Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":828779,"stargazers_count":2609,"watchers_count":2609,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2903,"mirror_url":null,"archived":false,"open_issues_count":3081,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2903,"open_issues":3081,"watchers":2609,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44083"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44083"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44083/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44083/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bb2dda2b37494cc7a9be25e8c5df82c7bf7714bc"}},"author_association":"NONE"}}
{"actor":{"display_login":"Mic92"}}