{"action":"created","comment":{"url":"https://api.github.com/repos/inviwo/inviwo/pulls/comments/192221625","pull_request_review_id":124956852,"id":192221625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjIyMTYyNQ==","diff_hunk":"@@ -32,55 +32,100 @@\n #include <modules/vectorfieldvisualization/processors/3d/streamlines.h>\n #include <inviwo/core/datastructures/geometry/basicmesh.h>\n #include <inviwo/core/network/networklock.h>\n+#include <inviwo/core/util/zip.h>\n \n namespace inviwo {\n-namespace {\n-struct MetaDataSampler {\n-    MetaDataSampler(const IntegralLine &line, std::string name)\n-        : hasMetaData_(line.hasMetaData(name)), v(0), dv(0) {\n-        if (hasMetaData_) {\n-            it = line.getMetaData(name).begin();\n-            v = *it;\n-        }\n-    }\n \n-    operator dvec3 &() { return v; }\n-    operator const dvec3 &() const { return v; }\n+namespace detail {\n \n-    dvec3 operator++() {\n-        if (hasMetaData_) {\n-            it++;\n-            v = *it;\n-        } else {\n-            v += dv;\n-        }\n-        return v;\n-    }\n-    dvec3 operator++(int) {\n-        auto prev = v;\n-        operator++();\n-        return prev;\n-    }\n+template <typename T>\n+static double metadataToDouble(const T &t) {","path":"modules/vectorfieldvisualization/processors/integrallinevectortomesh.cpp","position":36,"original_position":36,"commit_id":"3d00176fdeb90a6182c62ad9254169d88abc71c7","original_commit_id":"7ca8fd38578113bae6b1b3c60c2c9887c06624ea","user":{"login":"r-englund","id":534670,"node_id":"MDQ6VXNlcjUzNDY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/534670?v=4","gravatar_id":"","url":"https://api.github.com/users/r-englund","html_url":"https://github.com/r-englund","followers_url":"https://api.github.com/users/r-englund/followers","following_url":"https://api.github.com/users/r-englund/following{/other_user}","gists_url":"https://api.github.com/users/r-englund/gists{/gist_id}","starred_url":"https://api.github.com/users/r-englund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-englund/subscriptions","organizations_url":"https://api.github.com/users/r-englund/orgs","repos_url":"https://api.github.com/users/r-englund/repos","events_url":"https://api.github.com/users/r-englund/events{/privacy}","received_events_url":"https://api.github.com/users/r-englund/received_events","type":"User","site_admin":false},"body":"Hrm, both yes and now. For scalar it just converts it to double while for vec types it uses the length, so it would make sense to have length in the name only for vecs, but they need to have the same name to be used in the dispatch. ","created_at":"2018-05-31T20:09:02Z","updated_at":"2018-05-31T20:09:02Z","html_url":"https://github.com/inviwo/inviwo/pull/119#discussion_r192221625","pull_request_url":"https://api.github.com/repos/inviwo/inviwo/pulls/119","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/comments/192221625"},"html":{"href":"https://github.com/inviwo/inviwo/pull/119#discussion_r192221625"},"pull_request":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/119"}},"in_reply_to_id":189674658},"pull_request":{"url":"https://api.github.com/repos/inviwo/inviwo/pulls/119","id":189330976,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MzMwOTc2","html_url":"https://github.com/inviwo/inviwo/pull/119","diff_url":"https://github.com/inviwo/inviwo/pull/119.diff","patch_url":"https://github.com/inviwo/inviwo/pull/119.patch","issue_url":"https://api.github.com/repos/inviwo/inviwo/issues/119","number":119,"state":"open","locked":false,"title":"Feature/templatedtracers","user":{"login":"r-englund","id":534670,"node_id":"MDQ6VXNlcjUzNDY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/534670?v=4","gravatar_id":"","url":"https://api.github.com/users/r-englund","html_url":"https://github.com/r-englund","followers_url":"https://api.github.com/users/r-englund/followers","following_url":"https://api.github.com/users/r-englund/following{/other_user}","gists_url":"https://api.github.com/users/r-englund/gists{/gist_id}","starred_url":"https://api.github.com/users/r-englund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-englund/subscriptions","organizations_url":"https://api.github.com/users/r-englund/orgs","repos_url":"https://api.github.com/users/r-englund/repos","events_url":"https://api.github.com/users/r-englund/events{/privacy}","received_events_url":"https://api.github.com/users/r-englund/received_events","type":"User","site_admin":false},"body":"As discussed on a meeting some week ago I've done some work on the integralline tracer. \r\nThe tracer is now uses templates for spatial and temporal dimensions. Before there were almost identical code for pathlines and streamlines.\r\nThis commit also adds support for 2D Streamlines. \r\nThe old StreamLines, PathLines and StreamRibbons processors is flagged as deprecated with a warning message, they still work and are using the new tracer. A network conversion script will come in a future PR. \r\n","created_at":"2018-05-21T09:45:50Z","updated_at":"2018-05-31T20:09:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecf003c6ce2d2e6a4a75d98a502c01a79645b499","assignee":null,"assignees":[],"requested_reviewers":[{"login":"martinfalk","id":9251300,"node_id":"MDQ6VXNlcjkyNTEzMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/9251300?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfalk","html_url":"https://github.com/martinfalk","followers_url":"https://api.github.com/users/martinfalk/followers","following_url":"https://api.github.com/users/martinfalk/following{/other_user}","gists_url":"https://api.github.com/users/martinfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfalk/subscriptions","organizations_url":"https://api.github.com/users/martinfalk/orgs","repos_url":"https://api.github.com/users/martinfalk/repos","events_url":"https://api.github.com/users/martinfalk/events{/privacy}","received_events_url":"https://api.github.com/users/martinfalk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inviwo/inviwo/pulls/119/commits","review_comments_url":"https://api.github.com/repos/inviwo/inviwo/pulls/119/comments","review_comment_url":"https://api.github.com/repos/inviwo/inviwo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inviwo/inviwo/issues/119/comments","statuses_url":"https://api.github.com/repos/inviwo/inviwo/statuses/3d00176fdeb90a6182c62ad9254169d88abc71c7","head":{"label":"inviwo:feature/templatedtracers","ref":"feature/templatedtracers","sha":"3d00176fdeb90a6182c62ad9254169d88abc71c7","user":{"login":"inviwo","id":8736629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzY2Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/8736629?v=4","gravatar_id":"","url":"https://api.github.com/users/inviwo","html_url":"https://github.com/inviwo","followers_url":"https://api.github.com/users/inviwo/followers","following_url":"https://api.github.com/users/inviwo/following{/other_user}","gists_url":"https://api.github.com/users/inviwo/gists{/gist_id}","starred_url":"https://api.github.com/users/inviwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inviwo/subscriptions","organizations_url":"https://api.github.com/users/inviwo/orgs","repos_url":"https://api.github.com/users/inviwo/repos","events_url":"https://api.github.com/users/inviwo/events{/privacy}","received_events_url":"https://api.github.com/users/inviwo/received_events","type":"Organization","site_admin":false},"repo":{"id":108262622,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNjI2MjI=","name":"inviwo","full_name":"inviwo/inviwo","owner":{"login":"inviwo","id":8736629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzY2Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/8736629?v=4","gravatar_id":"","url":"https://api.github.com/users/inviwo","html_url":"https://github.com/inviwo","followers_url":"https://api.github.com/users/inviwo/followers","following_url":"https://api.github.com/users/inviwo/following{/other_user}","gists_url":"https://api.github.com/users/inviwo/gists{/gist_id}","starred_url":"https://api.github.com/users/inviwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inviwo/subscriptions","organizations_url":"https://api.github.com/users/inviwo/orgs","repos_url":"https://api.github.com/users/inviwo/repos","events_url":"https://api.github.com/users/inviwo/events{/privacy}","received_events_url":"https://api.github.com/users/inviwo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inviwo/inviwo","description":"Inviwo - Interactive Visualization Workshop","fork":false,"url":"https://api.github.com/repos/inviwo/inviwo","forks_url":"https://api.github.com/repos/inviwo/inviwo/forks","keys_url":"https://api.github.com/repos/inviwo/inviwo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inviwo/inviwo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inviwo/inviwo/teams","hooks_url":"https://api.github.com/repos/inviwo/inviwo/hooks","issue_events_url":"https://api.github.com/repos/inviwo/inviwo/issues/events{/number}","events_url":"https://api.github.com/repos/inviwo/inviwo/events","assignees_url":"https://api.github.com/repos/inviwo/inviwo/assignees{/user}","branches_url":"https://api.github.com/repos/inviwo/inviwo/branches{/branch}","tags_url":"https://api.github.com/repos/inviwo/inviwo/tags","blobs_url":"https://api.github.com/repos/inviwo/inviwo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inviwo/inviwo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inviwo/inviwo/git/refs{/sha}","trees_url":"https://api.github.com/repos/inviwo/inviwo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inviwo/inviwo/statuses/{sha}","languages_url":"https://api.github.com/repos/inviwo/inviwo/languages","stargazers_url":"https://api.github.com/repos/inviwo/inviwo/stargazers","contributors_url":"https://api.github.com/repos/inviwo/inviwo/contributors","subscribers_url":"https://api.github.com/repos/inviwo/inviwo/subscribers","subscription_url":"https://api.github.com/repos/inviwo/inviwo/subscription","commits_url":"https://api.github.com/repos/inviwo/inviwo/commits{/sha}","git_commits_url":"https://api.github.com/repos/inviwo/inviwo/git/commits{/sha}","comments_url":"https://api.github.com/repos/inviwo/inviwo/comments{/number}","issue_comment_url":"https://api.github.com/repos/inviwo/inviwo/issues/comments{/number}","contents_url":"https://api.github.com/repos/inviwo/inviwo/contents/{+path}","compare_url":"https://api.github.com/repos/inviwo/inviwo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inviwo/inviwo/merges","archive_url":"https://api.github.com/repos/inviwo/inviwo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inviwo/inviwo/downloads","issues_url":"https://api.github.com/repos/inviwo/inviwo/issues{/number}","pulls_url":"https://api.github.com/repos/inviwo/inviwo/pulls{/number}","milestones_url":"https://api.github.com/repos/inviwo/inviwo/milestones{/number}","notifications_url":"https://api.github.com/repos/inviwo/inviwo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inviwo/inviwo/labels{/name}","releases_url":"https://api.github.com/repos/inviwo/inviwo/releases{/id}","deployments_url":"https://api.github.com/repos/inviwo/inviwo/deployments","created_at":"2017-10-25T11:47:56Z","updated_at":"2018-05-31T13:00:37Z","pushed_at":"2018-05-31T17:48:49Z","git_url":"git://github.com/inviwo/inviwo.git","ssh_url":"git@github.com:inviwo/inviwo.git","clone_url":"https://github.com/inviwo/inviwo.git","svn_url":"https://github.com/inviwo/inviwo","homepage":null,"size":500351,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":3,"open_issues":37,"watchers":17,"default_branch":"master"}},"base":{"label":"inviwo:master","ref":"master","sha":"3764b5095d98707c8897eac6b16645df9419af5e","user":{"login":"inviwo","id":8736629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzY2Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/8736629?v=4","gravatar_id":"","url":"https://api.github.com/users/inviwo","html_url":"https://github.com/inviwo","followers_url":"https://api.github.com/users/inviwo/followers","following_url":"https://api.github.com/users/inviwo/following{/other_user}","gists_url":"https://api.github.com/users/inviwo/gists{/gist_id}","starred_url":"https://api.github.com/users/inviwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inviwo/subscriptions","organizations_url":"https://api.github.com/users/inviwo/orgs","repos_url":"https://api.github.com/users/inviwo/repos","events_url":"https://api.github.com/users/inviwo/events{/privacy}","received_events_url":"https://api.github.com/users/inviwo/received_events","type":"Organization","site_admin":false},"repo":{"id":108262622,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNjI2MjI=","name":"inviwo","full_name":"inviwo/inviwo","owner":{"login":"inviwo","id":8736629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzY2Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/8736629?v=4","gravatar_id":"","url":"https://api.github.com/users/inviwo","html_url":"https://github.com/inviwo","followers_url":"https://api.github.com/users/inviwo/followers","following_url":"https://api.github.com/users/inviwo/following{/other_user}","gists_url":"https://api.github.com/users/inviwo/gists{/gist_id}","starred_url":"https://api.github.com/users/inviwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inviwo/subscriptions","organizations_url":"https://api.github.com/users/inviwo/orgs","repos_url":"https://api.github.com/users/inviwo/repos","events_url":"https://api.github.com/users/inviwo/events{/privacy}","received_events_url":"https://api.github.com/users/inviwo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inviwo/inviwo","description":"Inviwo - Interactive Visualization Workshop","fork":false,"url":"https://api.github.com/repos/inviwo/inviwo","forks_url":"https://api.github.com/repos/inviwo/inviwo/forks","keys_url":"https://api.github.com/repos/inviwo/inviwo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inviwo/inviwo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inviwo/inviwo/teams","hooks_url":"https://api.github.com/repos/inviwo/inviwo/hooks","issue_events_url":"https://api.github.com/repos/inviwo/inviwo/issues/events{/number}","events_url":"https://api.github.com/repos/inviwo/inviwo/events","assignees_url":"https://api.github.com/repos/inviwo/inviwo/assignees{/user}","branches_url":"https://api.github.com/repos/inviwo/inviwo/branches{/branch}","tags_url":"https://api.github.com/repos/inviwo/inviwo/tags","blobs_url":"https://api.github.com/repos/inviwo/inviwo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inviwo/inviwo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inviwo/inviwo/git/refs{/sha}","trees_url":"https://api.github.com/repos/inviwo/inviwo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inviwo/inviwo/statuses/{sha}","languages_url":"https://api.github.com/repos/inviwo/inviwo/languages","stargazers_url":"https://api.github.com/repos/inviwo/inviwo/stargazers","contributors_url":"https://api.github.com/repos/inviwo/inviwo/contributors","subscribers_url":"https://api.github.com/repos/inviwo/inviwo/subscribers","subscription_url":"https://api.github.com/repos/inviwo/inviwo/subscription","commits_url":"https://api.github.com/repos/inviwo/inviwo/commits{/sha}","git_commits_url":"https://api.github.com/repos/inviwo/inviwo/git/commits{/sha}","comments_url":"https://api.github.com/repos/inviwo/inviwo/comments{/number}","issue_comment_url":"https://api.github.com/repos/inviwo/inviwo/issues/comments{/number}","contents_url":"https://api.github.com/repos/inviwo/inviwo/contents/{+path}","compare_url":"https://api.github.com/repos/inviwo/inviwo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inviwo/inviwo/merges","archive_url":"https://api.github.com/repos/inviwo/inviwo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inviwo/inviwo/downloads","issues_url":"https://api.github.com/repos/inviwo/inviwo/issues{/number}","pulls_url":"https://api.github.com/repos/inviwo/inviwo/pulls{/number}","milestones_url":"https://api.github.com/repos/inviwo/inviwo/milestones{/number}","notifications_url":"https://api.github.com/repos/inviwo/inviwo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inviwo/inviwo/labels{/name}","releases_url":"https://api.github.com/repos/inviwo/inviwo/releases{/id}","deployments_url":"https://api.github.com/repos/inviwo/inviwo/deployments","created_at":"2017-10-25T11:47:56Z","updated_at":"2018-05-31T13:00:37Z","pushed_at":"2018-05-31T17:48:49Z","git_url":"git://github.com/inviwo/inviwo.git","ssh_url":"git@github.com:inviwo/inviwo.git","clone_url":"https://github.com/inviwo/inviwo.git","svn_url":"https://github.com/inviwo/inviwo","homepage":null,"size":500351,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":3,"open_issues":37,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/119"},"html":{"href":"https://github.com/inviwo/inviwo/pull/119"},"issue":{"href":"https://api.github.com/repos/inviwo/inviwo/issues/119"},"comments":{"href":"https://api.github.com/repos/inviwo/inviwo/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inviwo/inviwo/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/inviwo/inviwo/statuses/3d00176fdeb90a6182c62ad9254169d88abc71c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"r-englund"}}