{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3225","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3225/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3225/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3225/events","html_url":"https://github.com/codice/ddf/pull/3225","id":321301397,"number":3225,"title":"[2.11.x] DDF-3817 Add support for separate external/internal urls","user":{"login":"vinamartin","id":9013407,"avatar_url":"https://avatars1.githubusercontent.com/u/9013407?v=4","gravatar_id":"","url":"https://api.github.com/users/vinamartin","html_url":"https://github.com/vinamartin","followers_url":"https://api.github.com/users/vinamartin/followers","following_url":"https://api.github.com/users/vinamartin/following{/other_user}","gists_url":"https://api.github.com/users/vinamartin/gists{/gist_id}","starred_url":"https://api.github.com/users/vinamartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinamartin/subscriptions","organizations_url":"https://api.github.com/users/vinamartin/orgs","repos_url":"https://api.github.com/users/vinamartin/repos","events_url":"https://api.github.com/users/vinamartin/events{/privacy}","received_events_url":"https://api.github.com/users/vinamartin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars0.githubusercontent.com/u/8660335?v=4","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars0.githubusercontent.com/u/8660335?v=4","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/codice/ddf/milestones/19","html_url":"https://github.com/codice/ddf/milestone/19","labels_url":"https://api.github.com/repos/codice/ddf/milestones/19/labels","id":3352204,"number":19,"title":"2.11.7","description":"","creator":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars3.githubusercontent.com/u/4359166?v=4","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2018-05-16T15:15:17Z","updated_at":"2018-05-23T20:14:55Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-05-08T18:42:56Z","updated_at":"2018-05-25T20:09:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3225","html_url":"https://github.com/codice/ddf/pull/3225","diff_url":"https://github.com/codice/ddf/pull/3225.diff","patch_url":"https://github.com/codice/ddf/pull/3225.patch"},"body":"#### What does this PR do?\r\nAdds support for external host and port properties in DDF. \r\nThis is useful when DDF is behind a proxy and the URL a user sees is different than the local url DDF uses.\r\nI still need to update documentation on this and any feedback on where that should go and what it should be would be helpful!\r\n\r\n⚠️ **THIS PR WILL BREAK PROJECTS THAT DEPEND ON DDF**\r\n⚠️ **SHOULD THE INTERNAL PROPERTIES BE RENAMED?**\r\n\r\n#### Who is reviewing it? \r\n@alexaabrd \r\n@SmithJosh \r\n@tbatie \r\n@rzwiefel \r\n@clockard \r\n\r\n#### Choose 2 committers to review/merge the PR. \r\n@brendan-hofmann\r\n@lessarderic\r\n\r\n#### How should this be tested?  \r\nConfigure a DDF with an internal host of localhost and an external host of the machine's name. Configure them to be on different ports.\r\nVerify that when accessing action providers in Intrigue that the link is the external host and port. \r\nIDP may need to be disabled to test this as it doesn't work with the external host/port. \r\n\r\nOptionally, use docker and nginx to set up a DDF with a reverse proxy and verify things work as expected. \r\n\r\n#### Any background context you want to provide?\r\nWith DDF-2.11.6, when a DDF is set up with a reverse proxy, the action providers in Intrigue don't work as expected. \r\n\r\n#### What are the relevant tickets?\r\n[DDF-3817](https://codice.atlassian.net/browse/DDF-3817)\r\n\r\n#### Checklist:\r\n- [x] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [x] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/392166591","html_url":"https://github.com/codice/ddf/pull/3225#issuecomment-392166591","issue_url":"https://api.github.com/repos/codice/ddf/issues/3225","id":392166591,"user":{"login":"vinamartin","id":9013407,"avatar_url":"https://avatars1.githubusercontent.com/u/9013407?v=4","gravatar_id":"","url":"https://api.github.com/users/vinamartin","html_url":"https://github.com/vinamartin","followers_url":"https://api.github.com/users/vinamartin/followers","following_url":"https://api.github.com/users/vinamartin/following{/other_user}","gists_url":"https://api.github.com/users/vinamartin/gists{/gist_id}","starred_url":"https://api.github.com/users/vinamartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinamartin/subscriptions","organizations_url":"https://api.github.com/users/vinamartin/orgs","repos_url":"https://api.github.com/users/vinamartin/repos","events_url":"https://api.github.com/users/vinamartin/events{/privacy}","received_events_url":"https://api.github.com/users/vinamartin/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T20:09:02Z","updated_at":"2018-05-25T20:09:02Z","author_association":"MEMBER","body":"There's an OWASP issue that needs to be addressed on this branch. "}}
{"actor":{"display_login":"vinamartin"}}