{"action":"created","issue":{"url":"https://api.github.com/repos/PCMDI/cmor/issues/294","repository_url":"https://api.github.com/repos/PCMDI/cmor","labels_url":"https://api.github.com/repos/PCMDI/cmor/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/PCMDI/cmor/issues/294/comments","events_url":"https://api.github.com/repos/PCMDI/cmor/issues/294/events","html_url":"https://github.com/PCMDI/cmor/issues/294","id":291869667,"number":294,"title":"New soil depth dimensions","user":{"login":"martinjuckes","id":7803071,"avatar_url":"https://avatars3.githubusercontent.com/u/7803071?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjuckes","html_url":"https://github.com/martinjuckes","followers_url":"https://api.github.com/users/martinjuckes/followers","following_url":"https://api.github.com/users/martinjuckes/following{/other_user}","gists_url":"https://api.github.com/users/martinjuckes/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjuckes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjuckes/subscriptions","organizations_url":"https://api.github.com/users/martinjuckes/orgs","repos_url":"https://api.github.com/users/martinjuckes/repos","events_url":"https://api.github.com/users/martinjuckes/events{/privacy}","received_events_url":"https://api.github.com/users/martinjuckes/received_events","type":"User","site_admin":false},"labels":[{"id":40064103,"url":"https://api.github.com/repos/PCMDI/cmor/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"taylor13","id":4993439,"avatar_url":"https://avatars3.githubusercontent.com/u/4993439?v=4","gravatar_id":"","url":"https://api.github.com/users/taylor13","html_url":"https://github.com/taylor13","followers_url":"https://api.github.com/users/taylor13/followers","following_url":"https://api.github.com/users/taylor13/following{/other_user}","gists_url":"https://api.github.com/users/taylor13/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor13/subscriptions","organizations_url":"https://api.github.com/users/taylor13/orgs","repos_url":"https://api.github.com/users/taylor13/repos","events_url":"https://api.github.com/users/taylor13/events{/privacy}","received_events_url":"https://api.github.com/users/taylor13/received_events","type":"User","site_admin":false},"assignees":[{"login":"taylor13","id":4993439,"avatar_url":"https://avatars3.githubusercontent.com/u/4993439?v=4","gravatar_id":"","url":"https://api.github.com/users/taylor13","html_url":"https://github.com/taylor13","followers_url":"https://api.github.com/users/taylor13/followers","following_url":"https://api.github.com/users/taylor13/following{/other_user}","gists_url":"https://api.github.com/users/taylor13/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor13/subscriptions","organizations_url":"https://api.github.com/users/taylor13/orgs","repos_url":"https://api.github.com/users/taylor13/repos","events_url":"https://api.github.com/users/taylor13/events{/privacy}","received_events_url":"https://api.github.com/users/taylor13/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/PCMDI/cmor/milestones/21","html_url":"https://github.com/PCMDI/cmor/milestone/21","labels_url":"https://api.github.com/repos/PCMDI/cmor/milestones/21/labels","id":3117396,"number":21,"title":"3.3.2","description":null,"creator":{"login":"dnadeau4","id":6933634,"avatar_url":"https://avatars0.githubusercontent.com/u/6933634?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadeau4","html_url":"https://github.com/dnadeau4","followers_url":"https://api.github.com/users/dnadeau4/followers","following_url":"https://api.github.com/users/dnadeau4/following{/other_user}","gists_url":"https://api.github.com/users/dnadeau4/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadeau4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadeau4/subscriptions","organizations_url":"https://api.github.com/users/dnadeau4/orgs","repos_url":"https://api.github.com/users/dnadeau4/repos","events_url":"https://api.github.com/users/dnadeau4/events{/privacy}","received_events_url":"https://api.github.com/users/dnadeau4/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":3,"state":"open","created_at":"2018-02-14T19:19:34Z","updated_at":"2018-02-15T09:29:17Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-01-26T11:11:05Z","updated_at":"2018-02-20T23:01:44Z","closed_at":null,"author_association":"NONE","body":"There are two variables in the data request which, I think, need new vertical coordinates. They are cSoilAbove1m (the carbon content in the soil above 1m depth) and cSoilBelow1m (the carbon content in soil below 1m depth).\r\n\r\nThe request currently includes, as in CMIP5, `sdepth` for all soil levels and `sdepth1` for the upper 0.1m.\r\n\r\nI propose to add `sdepth1m` for the upper 1m .. which would be a simple modification of `sdepth1`. I'm not sure how to specify the dimension for below 1m: it should have bounds from 1 to the bottom of the model. We could put in a large negative number? What do you think?\r\n\r\nI intend to update the request today, but will not include this change."},"comment":{"url":"https://api.github.com/repos/PCMDI/cmor/issues/comments/367151679","html_url":"https://github.com/PCMDI/cmor/issues/294#issuecomment-367151679","issue_url":"https://api.github.com/repos/PCMDI/cmor/issues/294","id":367151679,"user":{"login":"taylor13","id":4993439,"avatar_url":"https://avatars3.githubusercontent.com/u/4993439?v=4","gravatar_id":"","url":"https://api.github.com/users/taylor13","html_url":"https://github.com/taylor13","followers_url":"https://api.github.com/users/taylor13/followers","following_url":"https://api.github.com/users/taylor13/following{/other_user}","gists_url":"https://api.github.com/users/taylor13/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor13/subscriptions","organizations_url":"https://api.github.com/users/taylor13/orgs","repos_url":"https://api.github.com/users/taylor13/repos","events_url":"https://api.github.com/users/taylor13/events{/privacy}","received_events_url":"https://api.github.com/users/taylor13/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T23:01:44Z","updated_at":"2018-02-20T23:01:44Z","author_association":"NONE","body":"@martinjuckes : while you're at it, wouldn't it make sense to modify the 10cm surface soil layer so that the valid_max lies between the upper and lower bound, i.e.:\r\n\r\nTop 10dm layer:\r\nlabel: sdepth1\r\nboundsValues: 0. 0.1\r\ndescription: coordinate value for topmost 10 cm layer of soil\r\nuid: dim:sdepth1\r\nvalid_min: 0.0\r\nvalid_max: 0.1\r\nvalue: 0.05  \r\n \r\nand then similarly define for the 1 m surface layer:\r\n\r\nlabel: sdepth10\r\nboundsValues: 0. 1.\r\ndescription: coordinate value for topmost 1 meter layer of soil\r\ntables: Emon\r\nuid: dim:sdepth10\r\nvalid_min: 0.\r\nvalid_max: 1.\r\nvalue: 0.5\r\n"}}
{"actor":{"display_login":"taylor13"}}