{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/181047476","pull_request_review_id":111579300,"id":181047476,"diff_hunk":"@@ -14,61 +14,67 @@\n  * limitations under the License.\n  */\n \n+import './sw-types';\n+\n import { FirebaseApp } from '@firebase/app-types';\n \n import { ERROR_CODES } from '../models/errors';\n import { DEFAULT_PUBLIC_VAPID_KEY } from '../models/fcm-details';\n-import * as WorkerPageMessage from '../models/worker-page-message';\n+import {\n+  InternalMessage,\n+  MessageParameter,\n+  MessageType\n+} from '../models/worker-page-message';\n import { ControllerInterface } from './controller-interface';\n \n+// Let TS know that this is a service worker\n+declare const self: ServiceWorkerGlobalScope;\n+\n const FCM_MSG = 'FCM_MSG';\n \n-export type BgMessageHandler = (input: any) => Promise<any>;\n+export type BgMessageHandler = (input: Payload) => void;","path":"packages/messaging/src/controllers/sw-controller.ts","position":24,"original_position":24,"commit_id":"c0e6db376b44ec78d91f23e27abb1fe5dc8b3644","original_commit_id":"c0e6db376b44ec78d91f23e27abb1fe5dc8b3644","user":{"login":"mmermerkaya","id":1613860,"avatar_url":"https://avatars2.githubusercontent.com/u/1613860?v=4","gravatar_id":"","url":"https://api.github.com/users/mmermerkaya","html_url":"https://github.com/mmermerkaya","followers_url":"https://api.github.com/users/mmermerkaya/followers","following_url":"https://api.github.com/users/mmermerkaya/following{/other_user}","gists_url":"https://api.github.com/users/mmermerkaya/gists{/gist_id}","starred_url":"https://api.github.com/users/mmermerkaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmermerkaya/subscriptions","organizations_url":"https://api.github.com/users/mmermerkaya/orgs","repos_url":"https://api.github.com/users/mmermerkaya/repos","events_url":"https://api.github.com/users/mmermerkaya/events{/privacy}","received_events_url":"https://api.github.com/users/mmermerkaya/received_events","type":"User","site_admin":false},"body":"That's a good point, thanks!","created_at":"2018-04-12T11:25:59Z","updated_at":"2018-04-12T11:25:59Z","html_url":"https://github.com/firebase/firebase-js-sdk/pull/673#discussion_r181047476","pull_request_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/181047476"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/673#discussion_r181047476"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673"}},"in_reply_to_id":180926502},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673","id":180990731,"html_url":"https://github.com/firebase/firebase-js-sdk/pull/673","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/673.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/673.patch","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/673","number":673,"state":"open","locked":false,"title":" Add types for Service Worker Controller","user":{"login":"mmermerkaya","id":1613860,"avatar_url":"https://avatars2.githubusercontent.com/u/1613860?v=4","gravatar_id":"","url":"https://api.github.com/users/mmermerkaya","html_url":"https://github.com/mmermerkaya","followers_url":"https://api.github.com/users/mmermerkaya/followers","following_url":"https://api.github.com/users/mmermerkaya/following{/other_user}","gists_url":"https://api.github.com/users/mmermerkaya/gists{/gist_id}","starred_url":"https://api.github.com/users/mmermerkaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmermerkaya/subscriptions","organizations_url":"https://api.github.com/users/mmermerkaya/orgs","repos_url":"https://api.github.com/users/mmermerkaya/repos","events_url":"https://api.github.com/users/mmermerkaya/events{/privacy}","received_events_url":"https://api.github.com/users/mmermerkaya/received_events","type":"User","site_admin":false},"body":"Also updates TypeScript to 2.8.1, which has much better WebWorker and Notification typings, which allowed me to remove some more \"any\" casts.","created_at":"2018-04-11T18:32:16Z","updated_at":"2018-04-12T11:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e07d54715e826d41174844d3a5d7ae33d4449cb7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pinarx","id":20126085,"avatar_url":"https://avatars1.githubusercontent.com/u/20126085?v=4","gravatar_id":"","url":"https://api.github.com/users/pinarx","html_url":"https://github.com/pinarx","followers_url":"https://api.github.com/users/pinarx/followers","following_url":"https://api.github.com/users/pinarx/following{/other_user}","gists_url":"https://api.github.com/users/pinarx/gists{/gist_id}","starred_url":"https://api.github.com/users/pinarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinarx/subscriptions","organizations_url":"https://api.github.com/users/pinarx/orgs","repos_url":"https://api.github.com/users/pinarx/repos","events_url":"https://api.github.com/users/pinarx/events{/privacy}","received_events_url":"https://api.github.com/users/pinarx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":606540090,"url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels/needs-triage","name":"needs-triage","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/673/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/c0e6db376b44ec78d91f23e27abb1fe5dc8b3644","head":{"label":"firebase:mmermerkaya-sw-types","ref":"mmermerkaya-sw-types","sha":"c0e6db376b44ec78d91f23e27abb1fe5dc8b3644","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-04-12T08:26:16Z","pushed_at":"2018-04-12T11:23:15Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":15235,"stargazers_count":1024,"watchers_count":1024,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":139,"open_issues":133,"watchers":1024,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"078f83a09631b3fe9d882db1eed4b80e7da41251","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-04-12T08:26:16Z","pushed_at":"2018-04-12T11:23:15Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":15235,"stargazers_count":1024,"watchers_count":1024,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":139,"open_issues":133,"watchers":1024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/673"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/673"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/c0e6db376b44ec78d91f23e27abb1fe5dc8b3644"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmermerkaya"}}