{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/884","repository_url":"https://api.github.com/repos/amethyst/amethyst","labels_url":"https://api.github.com/repos/amethyst/amethyst/issues/884/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/884/comments","events_url":"https://api.github.com/repos/amethyst/amethyst/issues/884/events","html_url":"https://github.com/amethyst/amethyst/pull/884","id":351260411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTAxNzQ4","number":884,"title":"Automated testing of code in concepts and pong chapters of the book","user":{"login":"Moxinilian","id":30992420,"node_id":"MDQ6VXNlcjMwOTkyNDIw","avatar_url":"https://avatars0.githubusercontent.com/u/30992420?v=4","gravatar_id":"","url":"https://api.github.com/users/Moxinilian","html_url":"https://github.com/Moxinilian","followers_url":"https://api.github.com/users/Moxinilian/followers","following_url":"https://api.github.com/users/Moxinilian/following{/other_user}","gists_url":"https://api.github.com/users/Moxinilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Moxinilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moxinilian/subscriptions","organizations_url":"https://api.github.com/users/Moxinilian/orgs","repos_url":"https://api.github.com/users/Moxinilian/repos","events_url":"https://api.github.com/users/Moxinilian/events{/privacy}","received_events_url":"https://api.github.com/users/Moxinilian/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-16T15:38:43Z","updated_at":"2018-08-17T01:51:02Z","closed_at":"2018-08-17T01:50:29Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/884","html_url":"https://github.com/amethyst/amethyst/pull/884","diff_url":"https://github.com/amethyst/amethyst/pull/884.diff","patch_url":"https://github.com/amethyst/amethyst/pull/884.patch"},"body":"This PR allows for the testing of code in the book for the two first parts (concepts and pong tutorial).\r\nTo run a test, build the engine once with `cargo build` then run `mdbook test book -L ./target/debug/deps`.\r\n\r\nThis has been done by adding (hacky) context to every single of the code snippets.\r\nThis process revealed new mistakes in the book, so I had to change things.\r\nThis is why **this PR needs to be carefully inspected**.\r\n\r\nNote that testing is not enforced on the building of the book, so the corresponding logic will be handled in amethyst/website.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/amethyst/amethyst/884)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/comments/413734118","html_url":"https://github.com/amethyst/amethyst/pull/884#issuecomment-413734118","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/884","id":413734118,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzczNDExOA==","user":{"login":"jojolepro","id":4755185,"node_id":"MDQ6VXNlcjQ3NTUxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4755185?v=4","gravatar_id":"","url":"https://api.github.com/users/jojolepro","html_url":"https://github.com/jojolepro","followers_url":"https://api.github.com/users/jojolepro/followers","following_url":"https://api.github.com/users/jojolepro/following{/other_user}","gists_url":"https://api.github.com/users/jojolepro/gists{/gist_id}","starred_url":"https://api.github.com/users/jojolepro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojolepro/subscriptions","organizations_url":"https://api.github.com/users/jojolepro/orgs","repos_url":"https://api.github.com/users/jojolepro/repos","events_url":"https://api.github.com/users/jojolepro/events{/privacy}","received_events_url":"https://api.github.com/users/jojolepro/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T01:51:02Z","updated_at":"2018-08-17T01:51:02Z","author_association":"COLLABORATOR","body":"failed over a performance test for stdout on one of the 3 mac targets."}}
{"actor":{"display_login":"jojolepro"}}