{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/comments/185196605","pull_request_review_id":116535863,"id":185196605,"diff_hunk":"@@ -125,18 +342,19 @@ For example:\n }\n ```\n \n-### Transaction History\n+### Withdrawal History\n \n-The transaction history endpoint helps anchors enable a better experience for users using an external wallet. With it, wallets can display the status of deposits and withdrawals while they process and a history of past transactions with the anchor. It's only for transactions that are deposits to or withdrawals from the anchor.\n+The transaction history endpoint helps anchors enable a better experience for users using an external wallet. With it, wallets can display the status of withdrawals while they process and a history of past transactions with the anchor. It's only for transactions that are withdrawals to the anchor.\n \n-Endpoint: `DEPOSIT_SERVER/transactions`<br>\n-Purpose: Get status of current and past deposits/withdrawals.<br>\n+Endpoint: `WITHDRAWAL_SERVER/withdrawal/transactions`<br>\n+Purpose: Get status of current and past withdrawals.<br>\n Method: GET<br>\n Request parameters\n \n Name | Type | Description\n -----|------|------------\n `asset_code` | string | The code of the asset of interest. E.g. BTC,ETH,USD,INR,etc\n+`asset_code` | string | The issuing account id of the asset of interest.","path":"ecosystem/sep-0006.md","position":290,"original_position":290,"commit_id":"9110ba194cb944fd66bd1e14a6f10d8d8a2424be","original_commit_id":"9110ba194cb944fd66bd1e14a6f10d8d8a2424be","user":{"login":"s-a-y","id":1667781,"avatar_url":"https://avatars0.githubusercontent.com/u/1667781?v=4","gravatar_id":"","url":"https://api.github.com/users/s-a-y","html_url":"https://github.com/s-a-y","followers_url":"https://api.github.com/users/s-a-y/followers","following_url":"https://api.github.com/users/s-a-y/following{/other_user}","gists_url":"https://api.github.com/users/s-a-y/gists{/gist_id}","starred_url":"https://api.github.com/users/s-a-y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-a-y/subscriptions","organizations_url":"https://api.github.com/users/s-a-y/orgs","repos_url":"https://api.github.com/users/s-a-y/repos","events_url":"https://api.github.com/users/s-a-y/events{/privacy}","received_events_url":"https://api.github.com/users/s-a-y/received_events","type":"User","site_admin":false},"body":"typo `asset_issuer`","created_at":"2018-05-01T10:06:30Z","updated_at":"2018-05-01T10:06:30Z","html_url":"https://github.com/stellar/stellar-protocol/pull/106#discussion_r185196605","pull_request_url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/comments/185196605"},"html":{"href":"https://github.com/stellar/stellar-protocol/pull/106#discussion_r185196605"},"pull_request":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106","id":185145022,"html_url":"https://github.com/stellar/stellar-protocol/pull/106","diff_url":"https://github.com/stellar/stellar-protocol/pull/106.diff","patch_url":"https://github.com/stellar/stellar-protocol/pull/106.patch","issue_url":"https://api.github.com/repos/stellar/stellar-protocol/issues/106","number":106,"state":"open","locked":false,"title":"Expands SEP-0006","user":{"login":"istrau2","id":8128572,"avatar_url":"https://avatars0.githubusercontent.com/u/8128572?v=4","gravatar_id":"","url":"https://api.github.com/users/istrau2","html_url":"https://github.com/istrau2","followers_url":"https://api.github.com/users/istrau2/followers","following_url":"https://api.github.com/users/istrau2/following{/other_user}","gists_url":"https://api.github.com/users/istrau2/gists{/gist_id}","starred_url":"https://api.github.com/users/istrau2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istrau2/subscriptions","organizations_url":"https://api.github.com/users/istrau2/orgs","repos_url":"https://api.github.com/users/istrau2/repos","events_url":"https://api.github.com/users/istrau2/events{/privacy}","received_events_url":"https://api.github.com/users/istrau2/received_events","type":"User","site_admin":false},"body":"We've recently implemented deposits/withdrawals on stellarport using a very similar pattern to this PR. If this PR gets accepted, we intend to ensure our anchor service as well as our portal fully complies with it. This means that any anchor that complies with this standard will be listed as a deposit or withdrawal option on stellarport.","created_at":"2018-05-01T09:11:24Z","updated_at":"2018-05-01T10:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6c8122ca6ee2c3d57f4b87032febb2279a6c471","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-protocol/issues/106/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-protocol/statuses/9110ba194cb944fd66bd1e14a6f10d8d8a2424be","head":{"label":"stellarport:master","ref":"master","sha":"9110ba194cb944fd66bd1e14a6f10d8d8a2424be","user":{"login":"stellarport","id":34421493,"avatar_url":"https://avatars3.githubusercontent.com/u/34421493?v=4","gravatar_id":"","url":"https://api.github.com/users/stellarport","html_url":"https://github.com/stellarport","followers_url":"https://api.github.com/users/stellarport/followers","following_url":"https://api.github.com/users/stellarport/following{/other_user}","gists_url":"https://api.github.com/users/stellarport/gists{/gist_id}","starred_url":"https://api.github.com/users/stellarport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellarport/subscriptions","organizations_url":"https://api.github.com/users/stellarport/orgs","repos_url":"https://api.github.com/users/stellarport/repos","events_url":"https://api.github.com/users/stellarport/events{/privacy}","received_events_url":"https://api.github.com/users/stellarport/received_events","type":"Organization","site_admin":false},"repo":{"id":131685532,"name":"stellar-protocol","full_name":"stellarport/stellar-protocol","owner":{"login":"stellarport","id":34421493,"avatar_url":"https://avatars3.githubusercontent.com/u/34421493?v=4","gravatar_id":"","url":"https://api.github.com/users/stellarport","html_url":"https://github.com/stellarport","followers_url":"https://api.github.com/users/stellarport/followers","following_url":"https://api.github.com/users/stellarport/following{/other_user}","gists_url":"https://api.github.com/users/stellarport/gists{/gist_id}","starred_url":"https://api.github.com/users/stellarport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellarport/subscriptions","organizations_url":"https://api.github.com/users/stellarport/orgs","repos_url":"https://api.github.com/users/stellarport/repos","events_url":"https://api.github.com/users/stellarport/events{/privacy}","received_events_url":"https://api.github.com/users/stellarport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellarport/stellar-protocol","description":"Developer discussion about possible changes to the protocol.","fork":true,"url":"https://api.github.com/repos/stellarport/stellar-protocol","forks_url":"https://api.github.com/repos/stellarport/stellar-protocol/forks","keys_url":"https://api.github.com/repos/stellarport/stellar-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellarport/stellar-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellarport/stellar-protocol/teams","hooks_url":"https://api.github.com/repos/stellarport/stellar-protocol/hooks","issue_events_url":"https://api.github.com/repos/stellarport/stellar-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/stellarport/stellar-protocol/events","assignees_url":"https://api.github.com/repos/stellarport/stellar-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/stellarport/stellar-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/stellarport/stellar-protocol/tags","blobs_url":"https://api.github.com/repos/stellarport/stellar-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellarport/stellar-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellarport/stellar-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellarport/stellar-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellarport/stellar-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/stellarport/stellar-protocol/languages","stargazers_url":"https://api.github.com/repos/stellarport/stellar-protocol/stargazers","contributors_url":"https://api.github.com/repos/stellarport/stellar-protocol/contributors","subscribers_url":"https://api.github.com/repos/stellarport/stellar-protocol/subscribers","subscription_url":"https://api.github.com/repos/stellarport/stellar-protocol/subscription","commits_url":"https://api.github.com/repos/stellarport/stellar-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellarport/stellar-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellarport/stellar-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellarport/stellar-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellarport/stellar-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/stellarport/stellar-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellarport/stellar-protocol/merges","archive_url":"https://api.github.com/repos/stellarport/stellar-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellarport/stellar-protocol/downloads","issues_url":"https://api.github.com/repos/stellarport/stellar-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/stellarport/stellar-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/stellarport/stellar-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/stellarport/stellar-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellarport/stellar-protocol/labels{/name}","releases_url":"https://api.github.com/repos/stellarport/stellar-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/stellarport/stellar-protocol/deployments","created_at":"2018-05-01T06:59:47Z","updated_at":"2018-05-01T09:08:58Z","pushed_at":"2018-05-01T09:08:57Z","git_url":"git://github.com/stellarport/stellar-protocol.git","ssh_url":"git@github.com:stellarport/stellar-protocol.git","clone_url":"https://github.com/stellarport/stellar-protocol.git","svn_url":"https://github.com/stellarport/stellar-protocol","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"06e771ed43e2a4864aab0c7b378d83a7019d01c0","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":22821380,"name":"stellar-protocol","full_name":"stellar/stellar-protocol","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-protocol","description":"Developer discussion about possible changes to the protocol.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-protocol","forks_url":"https://api.github.com/repos/stellar/stellar-protocol/forks","keys_url":"https://api.github.com/repos/stellar/stellar-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-protocol/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-protocol/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-protocol/events","assignees_url":"https://api.github.com/repos/stellar/stellar-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-protocol/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-protocol/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-protocol/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-protocol/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-protocol/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-protocol/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-protocol/merges","archive_url":"https://api.github.com/repos/stellar/stellar-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-protocol/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-protocol/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-protocol/deployments","created_at":"2014-08-10T23:41:13Z","updated_at":"2018-04-30T18:36:33Z","pushed_at":"2018-05-01T09:11:28Z","git_url":"git://github.com/stellar/stellar-protocol.git","ssh_url":"git@github.com:stellar/stellar-protocol.git","clone_url":"https://github.com/stellar/stellar-protocol.git","svn_url":"https://github.com/stellar/stellar-protocol","homepage":null,"size":102,"stargazers_count":55,"watchers_count":55,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":22,"open_issues":56,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106"},"html":{"href":"https://github.com/stellar/stellar-protocol/pull/106"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-protocol/issues/106"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-protocol/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-protocol/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-protocol/statuses/9110ba194cb944fd66bd1e14a6f10d8d8a2424be"}},"author_association":"NONE"}}
{"actor":{"display_login":"s-a-y"}}