{"action":"created","comment":{"url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/comments/223228333","pull_request_review_id":162305120,"id":223228333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyODMzMw==","diff_hunk":"@@ -6,6 +6,7 @@\n * Fix `FactoryBot/AttributeDefinedStatically` not working when there is a non-symbol key. ([@vzvu3k6k][])\n * Fix false positive in `RSpec/ImplicitSubject` when `is_expected` is used inside `its()` block. ([@Darhazer][])\n * Add `single_statement_only` style to  `RSpec/ImplicitSubject` as a more relaxed alternative to `single_line_only`. ([@Darhazer][])\n+* Add `RSpec/UnspecifiedException` as a non-default cop to encourage more-specific `expect{}.to raise_error(ExceptionType)`, or `raise_exception` style handling of exceptions. ([@daveworth][])","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"79072ad663ecb25c210aa2c443f127a1d2c44a1b","original_commit_id":"79072ad663ecb25c210aa2c443f127a1d2c44a1b","user":{"login":"Darhazer","id":679778,"node_id":"MDQ6VXNlcjY3OTc3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/679778?v=4","gravatar_id":"","url":"https://api.github.com/users/Darhazer","html_url":"https://github.com/Darhazer","followers_url":"https://api.github.com/users/Darhazer/followers","following_url":"https://api.github.com/users/Darhazer/following{/other_user}","gists_url":"https://api.github.com/users/Darhazer/gists{/gist_id}","starred_url":"https://api.github.com/users/Darhazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darhazer/subscriptions","organizations_url":"https://api.github.com/users/Darhazer/orgs","repos_url":"https://api.github.com/users/Darhazer/repos","events_url":"https://api.github.com/users/Darhazer/events{/privacy}","received_events_url":"https://api.github.com/users/Darhazer/received_events","type":"User","site_admin":false},"body":"Hm, we actually made it a default cop :smirk: ","created_at":"2018-10-07T21:17:47Z","updated_at":"2018-10-07T21:17:47Z","html_url":"https://github.com/rubocop-hq/rubocop-rspec/pull/692#discussion_r223228333","pull_request_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/comments/223228333"},"html":{"href":"https://github.com/rubocop-hq/rubocop-rspec/pull/692#discussion_r223228333"},"pull_request":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692","id":219865813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODY1ODEz","html_url":"https://github.com/rubocop-hq/rubocop-rspec/pull/692","diff_url":"https://github.com/rubocop-hq/rubocop-rspec/pull/692.diff","patch_url":"https://github.com/rubocop-hq/rubocop-rspec/pull/692.patch","issue_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/692","number":692,"state":"closed","locked":false,"title":"Add a cop to enforce expected exceptions to be specified","user":{"login":"daveworth","id":996477,"node_id":"MDQ6VXNlcjk5NjQ3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/996477?v=4","gravatar_id":"","url":"https://api.github.com/users/daveworth","html_url":"https://github.com/daveworth","followers_url":"https://api.github.com/users/daveworth/followers","following_url":"https://api.github.com/users/daveworth/following{/other_user}","gists_url":"https://api.github.com/users/daveworth/gists{/gist_id}","starred_url":"https://api.github.com/users/daveworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveworth/subscriptions","organizations_url":"https://api.github.com/users/daveworth/orgs","repos_url":"https://api.github.com/users/daveworth/repos","events_url":"https://api.github.com/users/daveworth/events{/privacy}","received_events_url":"https://api.github.com/users/daveworth/received_events","type":"User","site_admin":false},"body":"In order to avoid false-positives in the context of exception checking it is valuable to be able to enforce that each `to raise` pair to include specifying information about the type of exception.\r\n\r\nWe have this vendored internally at Strava and have been happy with the improvement and would love an opt-in solution upstream.\r\n\r\n---\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md) if the new code introduces user-observable changes.\r\n* [x] The build (`bundle exec rake`) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).\r\n\r\nIf you have created a new cop:\r\n\r\n* [x] Added the new cop to `config/default.yml`.\r\n* [x] The cop documents examples of good and bad code.\r\n* [x] The tests assert both that bad code is reported and that good code is not reported.\r\n","created_at":"2018-10-02T22:33:57Z","updated_at":"2018-10-07T21:17:47Z","closed_at":"2018-10-07T20:54:28Z","merged_at":"2018-10-07T20:54:28Z","merge_commit_sha":"2cbf520de1e6065265ae419bd69be46e3bf70fc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692/commits","review_comments_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692/comments","review_comment_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/692/comments","statuses_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/statuses/79072ad663ecb25c210aa2c443f127a1d2c44a1b","head":{"label":"daveworth:feature/add-empty-raise_error-cop","ref":"feature/add-empty-raise_error-cop","sha":"79072ad663ecb25c210aa2c443f127a1d2c44a1b","user":{"login":"daveworth","id":996477,"node_id":"MDQ6VXNlcjk5NjQ3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/996477?v=4","gravatar_id":"","url":"https://api.github.com/users/daveworth","html_url":"https://github.com/daveworth","followers_url":"https://api.github.com/users/daveworth/followers","following_url":"https://api.github.com/users/daveworth/following{/other_user}","gists_url":"https://api.github.com/users/daveworth/gists{/gist_id}","starred_url":"https://api.github.com/users/daveworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveworth/subscriptions","organizations_url":"https://api.github.com/users/daveworth/orgs","repos_url":"https://api.github.com/users/daveworth/repos","events_url":"https://api.github.com/users/daveworth/events{/privacy}","received_events_url":"https://api.github.com/users/daveworth/received_events","type":"User","site_admin":false},"repo":{"id":151299072,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyOTkwNzI=","name":"rubocop-rspec","full_name":"daveworth/rubocop-rspec","private":false,"owner":{"login":"daveworth","id":996477,"node_id":"MDQ6VXNlcjk5NjQ3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/996477?v=4","gravatar_id":"","url":"https://api.github.com/users/daveworth","html_url":"https://github.com/daveworth","followers_url":"https://api.github.com/users/daveworth/followers","following_url":"https://api.github.com/users/daveworth/following{/other_user}","gists_url":"https://api.github.com/users/daveworth/gists{/gist_id}","starred_url":"https://api.github.com/users/daveworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveworth/subscriptions","organizations_url":"https://api.github.com/users/daveworth/orgs","repos_url":"https://api.github.com/users/daveworth/repos","events_url":"https://api.github.com/users/daveworth/events{/privacy}","received_events_url":"https://api.github.com/users/daveworth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/daveworth/rubocop-rspec","description":"Code style checking for RSpec files","fork":true,"url":"https://api.github.com/repos/daveworth/rubocop-rspec","forks_url":"https://api.github.com/repos/daveworth/rubocop-rspec/forks","keys_url":"https://api.github.com/repos/daveworth/rubocop-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daveworth/rubocop-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daveworth/rubocop-rspec/teams","hooks_url":"https://api.github.com/repos/daveworth/rubocop-rspec/hooks","issue_events_url":"https://api.github.com/repos/daveworth/rubocop-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/daveworth/rubocop-rspec/events","assignees_url":"https://api.github.com/repos/daveworth/rubocop-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/daveworth/rubocop-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/daveworth/rubocop-rspec/tags","blobs_url":"https://api.github.com/repos/daveworth/rubocop-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daveworth/rubocop-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daveworth/rubocop-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/daveworth/rubocop-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daveworth/rubocop-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/daveworth/rubocop-rspec/languages","stargazers_url":"https://api.github.com/repos/daveworth/rubocop-rspec/stargazers","contributors_url":"https://api.github.com/repos/daveworth/rubocop-rspec/contributors","subscribers_url":"https://api.github.com/repos/daveworth/rubocop-rspec/subscribers","subscription_url":"https://api.github.com/repos/daveworth/rubocop-rspec/subscription","commits_url":"https://api.github.com/repos/daveworth/rubocop-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/daveworth/rubocop-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/daveworth/rubocop-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/daveworth/rubocop-rspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/daveworth/rubocop-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/daveworth/rubocop-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daveworth/rubocop-rspec/merges","archive_url":"https://api.github.com/repos/daveworth/rubocop-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daveworth/rubocop-rspec/downloads","issues_url":"https://api.github.com/repos/daveworth/rubocop-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/daveworth/rubocop-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/daveworth/rubocop-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/daveworth/rubocop-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daveworth/rubocop-rspec/labels{/name}","releases_url":"https://api.github.com/repos/daveworth/rubocop-rspec/releases{/id}","deployments_url":"https://api.github.com/repos/daveworth/rubocop-rspec/deployments","created_at":"2018-10-02T17:57:21Z","updated_at":"2018-10-02T17:57:24Z","pushed_at":"2018-10-04T23:21:41Z","git_url":"git://github.com/daveworth/rubocop-rspec.git","ssh_url":"git@github.com:daveworth/rubocop-rspec.git","clone_url":"https://github.com/daveworth/rubocop-rspec.git","svn_url":"https://github.com/daveworth/rubocop-rspec","homepage":null,"size":1166,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubocop-hq:master","ref":"master","sha":"a791b4d451347f0cac77b9f6415d8bee6a996920","user":{"login":"rubocop-hq","id":39672756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjcyNzU2","avatar_url":"https://avatars3.githubusercontent.com/u/39672756?v=4","gravatar_id":"","url":"https://api.github.com/users/rubocop-hq","html_url":"https://github.com/rubocop-hq","followers_url":"https://api.github.com/users/rubocop-hq/followers","following_url":"https://api.github.com/users/rubocop-hq/following{/other_user}","gists_url":"https://api.github.com/users/rubocop-hq/gists{/gist_id}","starred_url":"https://api.github.com/users/rubocop-hq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubocop-hq/subscriptions","organizations_url":"https://api.github.com/users/rubocop-hq/orgs","repos_url":"https://api.github.com/users/rubocop-hq/repos","events_url":"https://api.github.com/users/rubocop-hq/events{/privacy}","received_events_url":"https://api.github.com/users/rubocop-hq/received_events","type":"Organization","site_admin":false},"repo":{"id":16263354,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI2MzM1NA==","name":"rubocop-rspec","full_name":"rubocop-hq/rubocop-rspec","private":false,"owner":{"login":"rubocop-hq","id":39672756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjcyNzU2","avatar_url":"https://avatars3.githubusercontent.com/u/39672756?v=4","gravatar_id":"","url":"https://api.github.com/users/rubocop-hq","html_url":"https://github.com/rubocop-hq","followers_url":"https://api.github.com/users/rubocop-hq/followers","following_url":"https://api.github.com/users/rubocop-hq/following{/other_user}","gists_url":"https://api.github.com/users/rubocop-hq/gists{/gist_id}","starred_url":"https://api.github.com/users/rubocop-hq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubocop-hq/subscriptions","organizations_url":"https://api.github.com/users/rubocop-hq/orgs","repos_url":"https://api.github.com/users/rubocop-hq/repos","events_url":"https://api.github.com/users/rubocop-hq/events{/privacy}","received_events_url":"https://api.github.com/users/rubocop-hq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubocop-hq/rubocop-rspec","description":"Code style checking for RSpec files","fork":false,"url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec","forks_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/forks","keys_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/teams","hooks_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/hooks","issue_events_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/events","assignees_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/tags","blobs_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/languages","stargazers_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/stargazers","contributors_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/contributors","subscribers_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/subscribers","subscription_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/subscription","commits_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/merges","archive_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/downloads","issues_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/labels{/name}","releases_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/releases{/id}","deployments_url":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/deployments","created_at":"2014-01-26T22:31:26Z","updated_at":"2018-10-07T20:54:32Z","pushed_at":"2018-10-07T20:54:28Z","git_url":"git://github.com/rubocop-hq/rubocop-rspec.git","ssh_url":"git@github.com:rubocop-hq/rubocop-rspec.git","clone_url":"https://github.com/rubocop-hq/rubocop-rspec.git","svn_url":"https://github.com/rubocop-hq/rubocop-rspec","homepage":null,"size":1162,"stargazers_count":390,"watchers_count":390,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":112,"open_issues":73,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692"},"html":{"href":"https://github.com/rubocop-hq/rubocop-rspec/pull/692"},"issue":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/692"},"comments":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/rubocop-hq/rubocop-rspec/statuses/79072ad663ecb25c210aa2c443f127a1d2c44a1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Darhazer"}}