{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/3711","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/3711/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/3711/comments","events_url":"https://api.github.com/repos/php/php-src/issues/3711/events","html_url":"https://github.com/php/php-src/pull/3711","id":392679150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODk2ODU0","number":3711,"title":"fix #77298 segfault occurs when add property to unserialized empty ArrayObject","user":{"login":"jhdxr","id":1993373,"node_id":"MDQ6VXNlcjE5OTMzNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1993373?v=4","gravatar_id":"","url":"https://api.github.com/users/jhdxr","html_url":"https://github.com/jhdxr","followers_url":"https://api.github.com/users/jhdxr/followers","following_url":"https://api.github.com/users/jhdxr/following{/other_user}","gists_url":"https://api.github.com/users/jhdxr/gists{/gist_id}","starred_url":"https://api.github.com/users/jhdxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhdxr/subscriptions","organizations_url":"https://api.github.com/users/jhdxr/orgs","repos_url":"https://api.github.com/users/jhdxr/repos","events_url":"https://api.github.com/users/jhdxr/events{/privacy}","received_events_url":"https://api.github.com/users/jhdxr/received_events","type":"User","site_admin":false},"labels":[{"id":148912283,"node_id":"MDU6TGFiZWwxNDg5MTIyODM=","url":"https://api.github.com/repos/php/php-src/labels/Bugfix","name":"Bugfix","color":"f7c6c7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-19T16:26:06Z","updated_at":"2018-12-21T16:48:17Z","closed_at":"2018-12-21T16:48:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/3711","html_url":"https://github.com/php/php-src/pull/3711","diff_url":"https://github.com/php/php-src/pull/3711.diff","patch_url":"https://github.com/php/php-src/pull/3711.patch"},"body":"9cf87aa1965504b1cd9dc595a3c6af418a416cfc brings `zend_empty_array`, whose gc.refcount is 2, when unserialize a string representing empty array (`\"a:0:{}\"`), and leads to `HT_ASSERT_RC1` failure.\r\n\r\nto be honest I don't think it's a good fix, since `spl_array_get_hash_table` is very common used in `ArrayObject`, and `SEPARATE_ARRAY` will check gc_refcount everytime, the overhead may defeat the benfit of using `zend_empty_array`. Another possible solution is we can do `SEPARATE_ARRAY` in `ArrayObject::unserialize`, which defeats the purpose of `zend_empty_array` as well."},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/449438993","html_url":"https://github.com/php/php-src/pull/3711#issuecomment-449438993","issue_url":"https://api.github.com/repos/php/php-src/issues/3711","id":449438993,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQzODk5Mw==","user":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T16:48:17Z","updated_at":"2018-12-21T16:48:17Z","author_association":"CONTRIBUTOR","body":"Thanks! Applied as b15189f4d8af396cc5731a7b7eaeb0791cf0bced."}}
{"actor":{"display_login":"cmb69"}}