{"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/186352151","pull_request_review_id":117911664,"id":186352151,"diff_hunk":"@@ -81,25 +81,24 @@ def create_from_kwargs(cls, index=True, has_pid=True, **kwargs):\n         instance.record_metadata = super(TestRecordMetadata, cls)\\\n                 .create_from_kwargs(updated_kwargs)\n \n-        if index:\n+        if index_name:\n             instance.es_index_result = es.index(\n-                index='records-hep',\n-                doc_type='hep',\n+                index=index_name,\n+                doc_type=index_name.split('-')[-1],\n                 body=instance.record_metadata.json,\n                 params={}\n             )\n-            instance.es_refresh_result = es.indices.refresh('records-hep')\n-\n-        if has_pid:\n-            instance.persistent_identifier = TestPersistentIdentifier\\\n-                    .create_from_kwargs(\n-                        object_uuid=instance.record_metadata.id,\n-                        pid_value=instance.record_metadata.json.get('control_number')\n-                    ).persistent_identifier\n+            instance.es_refresh_result = es.indices.refresh(index_name)\n+\n+        instance.persistent_identifier = TestPersistentIdentifier\\","path":"tests/integration/helpers/factories/db/invenio_records.py","position":33,"original_position":33,"commit_id":"788ed0b4e4fc7c64b94aee6f3dabfa9e24760778","original_commit_id":"788ed0b4e4fc7c64b94aee6f3dabfa9e24760778","user":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"body":"heads-up: we will always create a ``pid``, do we really want this?","created_at":"2018-05-07T07:57:49Z","updated_at":"2018-05-07T07:57:50Z","html_url":"https://github.com/inspirehep/inspire-next/pull/3380#discussion_r186352151","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/186352151"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3380#discussion_r186352151"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380","id":184006756,"html_url":"https://github.com/inspirehep/inspire-next/pull/3380","diff_url":"https://github.com/inspirehep/inspire-next/pull/3380.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/3380.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3380","number":3380,"state":"open","locked":false,"title":"workflows: add data references matcher","user":{"login":"salmanmaq","id":13566663,"avatar_url":"https://avatars0.githubusercontent.com/u/13566663?v=4","gravatar_id":"","url":"https://api.github.com/users/salmanmaq","html_url":"https://github.com/salmanmaq","followers_url":"https://api.github.com/users/salmanmaq/followers","following_url":"https://api.github.com/users/salmanmaq/following{/other_user}","gists_url":"https://api.github.com/users/salmanmaq/gists{/gist_id}","starred_url":"https://api.github.com/users/salmanmaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salmanmaq/subscriptions","organizations_url":"https://api.github.com/users/salmanmaq/orgs","repos_url":"https://api.github.com/users/salmanmaq/repos","events_url":"https://api.github.com/users/salmanmaq/events{/privacy}","received_events_url":"https://api.github.com/users/salmanmaq/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis adds the capability to match references to data records in the current reference matcher.\r\n\r\n## Related Issue\r\nhttps://its.cern.ch/jira/browse/INSPIR-472\r\n\r\n## Motivation and Context\r\nThis would improve citation counts.\r\n\r\n## Checklist:\r\n- [x] I have all the information that I need (if not, move to `RFC` and look for it).\r\n- [x] I linked the related issue(s) in the corresponding commit logs.\r\n- [x] I wrote [good commit log messages](https://github.com/torvalds/subsurface-for-dirk/blob/5f15ad5a86ada3c5e574041a5f9d85235322dabb/README#L92-L119).\r\n- [x] My code follows the code style of this project.\r\n- [x] I've added any new docs if API/utils methods were added.\r\n- [x] I have updated the existing documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\nSigned-off-by: Salman Maqbool <salman.maqbool@cern.ch>","created_at":"2018-04-25T11:39:19Z","updated_at":"2018-05-07T07:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69589aabec93eb87bbcc713edbc82a661b5f7f52","assignee":{"login":"salmanmaq","id":13566663,"avatar_url":"https://avatars0.githubusercontent.com/u/13566663?v=4","gravatar_id":"","url":"https://api.github.com/users/salmanmaq","html_url":"https://github.com/salmanmaq","followers_url":"https://api.github.com/users/salmanmaq/followers","following_url":"https://api.github.com/users/salmanmaq/following{/other_user}","gists_url":"https://api.github.com/users/salmanmaq/gists{/gist_id}","starred_url":"https://api.github.com/users/salmanmaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salmanmaq/subscriptions","organizations_url":"https://api.github.com/users/salmanmaq/orgs","repos_url":"https://api.github.com/users/salmanmaq/repos","events_url":"https://api.github.com/users/salmanmaq/events{/privacy}","received_events_url":"https://api.github.com/users/salmanmaq/received_events","type":"User","site_admin":false},"assignees":[{"login":"salmanmaq","id":13566663,"avatar_url":"https://avatars0.githubusercontent.com/u/13566663?v=4","gravatar_id":"","url":"https://api.github.com/users/salmanmaq","html_url":"https://github.com/salmanmaq","followers_url":"https://api.github.com/users/salmanmaq/followers","following_url":"https://api.github.com/users/salmanmaq/following{/other_user}","gists_url":"https://api.github.com/users/salmanmaq/gists{/gist_id}","starred_url":"https://api.github.com/users/salmanmaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salmanmaq/subscriptions","organizations_url":"https://api.github.com/users/salmanmaq/orgs","repos_url":"https://api.github.com/users/salmanmaq/repos","events_url":"https://api.github.com/users/salmanmaq/events{/privacy}","received_events_url":"https://api.github.com/users/salmanmaq/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":828439694,"url":"https://api.github.com/repos/inspirehep/inspire-next/labels/Review:%20WIP","name":"Review: WIP","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3380/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/788ed0b4e4fc7c64b94aee6f3dabfa9e24760778","head":{"label":"salmanmaq:data_citations","ref":"data_citations","sha":"788ed0b4e4fc7c64b94aee6f3dabfa9e24760778","user":{"login":"salmanmaq","id":13566663,"avatar_url":"https://avatars0.githubusercontent.com/u/13566663?v=4","gravatar_id":"","url":"https://api.github.com/users/salmanmaq","html_url":"https://github.com/salmanmaq","followers_url":"https://api.github.com/users/salmanmaq/followers","following_url":"https://api.github.com/users/salmanmaq/following{/other_user}","gists_url":"https://api.github.com/users/salmanmaq/gists{/gist_id}","starred_url":"https://api.github.com/users/salmanmaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salmanmaq/subscriptions","organizations_url":"https://api.github.com/users/salmanmaq/orgs","repos_url":"https://api.github.com/users/salmanmaq/repos","events_url":"https://api.github.com/users/salmanmaq/events{/privacy}","received_events_url":"https://api.github.com/users/salmanmaq/received_events","type":"User","site_admin":false},"repo":{"id":126160857,"name":"inspire-next","full_name":"salmanmaq/inspire-next","owner":{"login":"salmanmaq","id":13566663,"avatar_url":"https://avatars0.githubusercontent.com/u/13566663?v=4","gravatar_id":"","url":"https://api.github.com/users/salmanmaq","html_url":"https://github.com/salmanmaq","followers_url":"https://api.github.com/users/salmanmaq/followers","following_url":"https://api.github.com/users/salmanmaq/following{/other_user}","gists_url":"https://api.github.com/users/salmanmaq/gists{/gist_id}","starred_url":"https://api.github.com/users/salmanmaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salmanmaq/subscriptions","organizations_url":"https://api.github.com/users/salmanmaq/orgs","repos_url":"https://api.github.com/users/salmanmaq/repos","events_url":"https://api.github.com/users/salmanmaq/events{/privacy}","received_events_url":"https://api.github.com/users/salmanmaq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/salmanmaq/inspire-next","description":"The next version of INSPIRE","fork":true,"url":"https://api.github.com/repos/salmanmaq/inspire-next","forks_url":"https://api.github.com/repos/salmanmaq/inspire-next/forks","keys_url":"https://api.github.com/repos/salmanmaq/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salmanmaq/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salmanmaq/inspire-next/teams","hooks_url":"https://api.github.com/repos/salmanmaq/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/salmanmaq/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/salmanmaq/inspire-next/events","assignees_url":"https://api.github.com/repos/salmanmaq/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/salmanmaq/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/salmanmaq/inspire-next/tags","blobs_url":"https://api.github.com/repos/salmanmaq/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salmanmaq/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salmanmaq/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/salmanmaq/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salmanmaq/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/salmanmaq/inspire-next/languages","stargazers_url":"https://api.github.com/repos/salmanmaq/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/salmanmaq/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/salmanmaq/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/salmanmaq/inspire-next/subscription","commits_url":"https://api.github.com/repos/salmanmaq/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/salmanmaq/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/salmanmaq/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/salmanmaq/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/salmanmaq/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/salmanmaq/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salmanmaq/inspire-next/merges","archive_url":"https://api.github.com/repos/salmanmaq/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salmanmaq/inspire-next/downloads","issues_url":"https://api.github.com/repos/salmanmaq/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/salmanmaq/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/salmanmaq/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/salmanmaq/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salmanmaq/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/salmanmaq/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/salmanmaq/inspire-next/deployments","created_at":"2018-03-21T10:17:44Z","updated_at":"2018-04-25T11:34:37Z","pushed_at":"2018-05-04T15:23:25Z","git_url":"git://github.com/salmanmaq/inspire-next.git","ssh_url":"git@github.com:salmanmaq/inspire-next.git","clone_url":"https://github.com/salmanmaq/inspire-next.git","svn_url":"https://github.com/salmanmaq/inspire-next","homepage":"https://labs.inspirehep.net","size":80377,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspirehep:master","ref":"master","sha":"0e26d969b2347bcfcfce27b06ef90e3a1a99f613","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"The next version of INSPIRE","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/inspirehep/inspire-next/deployments","created_at":"2013-12-16T09:11:58Z","updated_at":"2018-05-04T14:16:41Z","pushed_at":"2018-05-05T15:02:37Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"git@github.com:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":"https://labs.inspirehep.net","size":80355,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":52,"open_issues":250,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3380"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3380"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3380/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3380/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/788ed0b4e4fc7c64b94aee6f3dabfa9e24760778"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drjova"}}