{"action":"created","issue":{"url":"https://api.github.com/repos/simbody/simbody/issues/630","repository_url":"https://api.github.com/repos/simbody/simbody","labels_url":"https://api.github.com/repos/simbody/simbody/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/simbody/simbody/issues/630/comments","events_url":"https://api.github.com/repos/simbody/simbody/issues/630/events","html_url":"https://github.com/simbody/simbody/pull/630","id":311725886,"number":630,"title":"Adolc compile common","user":{"login":"antoinefalisse","id":19328993,"avatar_url":"https://avatars1.githubusercontent.com/u/19328993?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinefalisse","html_url":"https://github.com/antoinefalisse","followers_url":"https://api.github.com/users/antoinefalisse/followers","following_url":"https://api.github.com/users/antoinefalisse/following{/other_user}","gists_url":"https://api.github.com/users/antoinefalisse/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinefalisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinefalisse/subscriptions","organizations_url":"https://api.github.com/users/antoinefalisse/orgs","repos_url":"https://api.github.com/users/antoinefalisse/repos","events_url":"https://api.github.com/users/antoinefalisse/events{/privacy}","received_events_url":"https://api.github.com/users/antoinefalisse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-05T18:45:42Z","updated_at":"2018-04-05T21:46:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/simbody/simbody/pulls/630","html_url":"https://github.com/simbody/simbody/pull/630","diff_url":"https://github.com/simbody/simbody/pull/630.diff","patch_url":"https://github.com/simbody/simbody/pull/630.patch"},"body":"@chrisdembia, this is a first PR on the new branch `feature_adolc_common`. I made all changes in SimTKcommon that I had made on my local branch (except regarding polynomials). I also adjusted the tests so that they compile and pass. However, I have not yet added cases in the tests to directly test adouble cases. I have excluded the `PolynomialTest `directly from CMake since it contains almost entirely expressions with complex numbers. Also, I have not tried to deal with the adhoc test `BigMatrixTest` yet. I have not added comments, nor limited changes to lines of 80 characters since this branch will only be used as \"support\" when merging changes in feature_adolc.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/simbody/simbody/630)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/simbody/simbody/issues/comments/379086740","html_url":"https://github.com/simbody/simbody/pull/630#issuecomment-379086740","issue_url":"https://api.github.com/repos/simbody/simbody/issues/630","id":379086740,"user":{"login":"chrisdembia","id":846001,"avatar_url":"https://avatars0.githubusercontent.com/u/846001?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdembia","html_url":"https://github.com/chrisdembia","followers_url":"https://api.github.com/users/chrisdembia/followers","following_url":"https://api.github.com/users/chrisdembia/following{/other_user}","gists_url":"https://api.github.com/users/chrisdembia/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdembia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdembia/subscriptions","organizations_url":"https://api.github.com/users/chrisdembia/orgs","repos_url":"https://api.github.com/users/chrisdembia/repos","events_url":"https://api.github.com/users/chrisdembia/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdembia/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T21:46:26Z","updated_at":"2018-04-05T21:46:26Z","author_association":"MEMBER","body":"Thanks @antoinefalisse.\r\n\r\nAs @antoinefalisse and I have discussed, the `feature_adolc_common` branch in this repository is not intended to be merged into `master`. This branch contains Antoine's mostly complete changes to `SimTKcommon` so that the test cases pass. The idea is that @antoinefalisse will make small PRs into `feature_adolc`, as he has been doing; however, the CI tests will not pass for these PRs because we won't be able to build the complete `SimTKcommon` library in the incremental PRs. Instead, reviewers (@sherm1 and I) can refer to the CI tests in the `feature_adolc_common` branch when reviewing the smaller PRs destined for `feature_adolc`.\r\n\r\nAs part of this plan, I am merging this PR without review."}}
{"actor":{"display_login":"chrisdembia"}}