{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/177418568","pull_request_review_id":107283785,"id":177418568,"diff_hunk":"@@ -1258,6 +1265,19 @@ policies and contribution forms [3].\n                 throw e;\n             }\n \n+            if ((typeof IdlHarnessError !== 'undefined')","path":"resources/testharness.js","position":18,"original_position":18,"commit_id":"35ef11d0f60dae103603ee92fd71a98bc3e12e7c","original_commit_id":"35ef11d0f60dae103603ee92fd71a98bc3e12e7c","user":{"login":"foolip","id":498917,"avatar_url":"https://avatars1.githubusercontent.com/u/498917?v=4","gravatar_id":"","url":"https://api.github.com/users/foolip","html_url":"https://github.com/foolip","followers_url":"https://api.github.com/users/foolip/followers","following_url":"https://api.github.com/users/foolip/following{/other_user}","gists_url":"https://api.github.com/users/foolip/gists{/gist_id}","starred_url":"https://api.github.com/users/foolip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foolip/subscriptions","organizations_url":"https://api.github.com/users/foolip/orgs","repos_url":"https://api.github.com/users/foolip/repos","events_url":"https://api.github.com/users/foolip/events{/privacy}","received_events_url":"https://api.github.com/users/foolip/received_events","type":"User","site_admin":false},"body":"Yep, there were a handful, like this one:\r\nhttps://chromium.googlesource.com/chromium/src/+/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/LayoutTests/external/wpt/mediasession/setactionhandler.html\r\n\r\nSeems manageable if we want to do it that way, though.","created_at":"2018-03-27T13:15:09Z","updated_at":"2018-03-27T13:15:10Z","html_url":"https://github.com/w3c/web-platform-tests/pull/10164#discussion_r177418568","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/177418568"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/10164#discussion_r177418568"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164"}},"in_reply_to_id":177352145},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164","id":177162619,"html_url":"https://github.com/w3c/web-platform-tests/pull/10164","diff_url":"https://github.com/w3c/web-platform-tests/pull/10164.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/10164.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/10164","number":10164,"state":"open","locked":false,"title":"Special-case idlharness.js errors as an assert_throw option","user":{"login":"lukebjerring","id":777956,"avatar_url":"https://avatars2.githubusercontent.com/u/777956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebjerring","html_url":"https://github.com/lukebjerring","followers_url":"https://api.github.com/users/lukebjerring/followers","following_url":"https://api.github.com/users/lukebjerring/following{/other_user}","gists_url":"https://api.github.com/users/lukebjerring/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebjerring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebjerring/subscriptions","organizations_url":"https://api.github.com/users/lukebjerring/orgs","repos_url":"https://api.github.com/users/lukebjerring/repos","events_url":"https://api.github.com/users/lukebjerring/events{/privacy}","received_events_url":"https://api.github.com/users/lukebjerring/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/w3c/web-platform-tests/issues/10162\r\n\r\nThis adds support for more succinctly asserting behaviour of `idlharness.js` itself, using the same mechanism in `testharness.js`, e.g. when testing expected errors in `IdlArray.test()`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/w3c/web-platform-tests/10164)\n<!-- Reviewable:end -->\n","created_at":"2018-03-23T19:20:35Z","updated_at":"2018-03-27T13:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce15f9daccb781614da84064b4510aba44a0a059","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tobie","id":3392,"avatar_url":"https://avatars3.githubusercontent.com/u/3392?v=4","gravatar_id":"","url":"https://api.github.com/users/tobie","html_url":"https://github.com/tobie","followers_url":"https://api.github.com/users/tobie/followers","following_url":"https://api.github.com/users/tobie/following{/other_user}","gists_url":"https://api.github.com/users/tobie/gists{/gist_id}","starred_url":"https://api.github.com/users/tobie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobie/subscriptions","organizations_url":"https://api.github.com/users/tobie/orgs","repos_url":"https://api.github.com/users/tobie/repos","events_url":"https://api.github.com/users/tobie/events{/privacy}","received_events_url":"https://api.github.com/users/tobie/received_events","type":"User","site_admin":false},{"login":"gsnedders","id":176218,"avatar_url":"https://avatars2.githubusercontent.com/u/176218?v=4","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},{"login":"jgraham","id":294864,"avatar_url":"https://avatars1.githubusercontent.com/u/294864?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraham","html_url":"https://github.com/jgraham","followers_url":"https://api.github.com/users/jgraham/followers","following_url":"https://api.github.com/users/jgraham/following{/other_user}","gists_url":"https://api.github.com/users/jgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraham/subscriptions","organizations_url":"https://api.github.com/users/jgraham/orgs","repos_url":"https://api.github.com/users/jgraham/repos","events_url":"https://api.github.com/users/jgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jgraham/received_events","type":"User","site_admin":false},{"login":"ayg","id":940446,"avatar_url":"https://avatars0.githubusercontent.com/u/940446?v=4","gravatar_id":"","url":"https://api.github.com/users/ayg","html_url":"https://github.com/ayg","followers_url":"https://api.github.com/users/ayg/followers","following_url":"https://api.github.com/users/ayg/following{/other_user}","gists_url":"https://api.github.com/users/ayg/gists{/gist_id}","starred_url":"https://api.github.com/users/ayg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayg/subscriptions","organizations_url":"https://api.github.com/users/ayg/orgs","repos_url":"https://api.github.com/users/ayg/repos","events_url":"https://api.github.com/users/ayg/events{/privacy}","received_events_url":"https://api.github.com/users/ayg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45230790,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/infra","name":"infra","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/10164/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/35ef11d0f60dae103603ee92fd71a98bc3e12e7c","head":{"label":"lukebjerring:idlharness-errors","ref":"idlharness-errors","sha":"35ef11d0f60dae103603ee92fd71a98bc3e12e7c","user":{"login":"lukebjerring","id":777956,"avatar_url":"https://avatars2.githubusercontent.com/u/777956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebjerring","html_url":"https://github.com/lukebjerring","followers_url":"https://api.github.com/users/lukebjerring/followers","following_url":"https://api.github.com/users/lukebjerring/following{/other_user}","gists_url":"https://api.github.com/users/lukebjerring/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebjerring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebjerring/subscriptions","organizations_url":"https://api.github.com/users/lukebjerring/orgs","repos_url":"https://api.github.com/users/lukebjerring/repos","events_url":"https://api.github.com/users/lukebjerring/events{/privacy}","received_events_url":"https://api.github.com/users/lukebjerring/received_events","type":"User","site_admin":false},"repo":{"id":105306745,"name":"web-platform-tests","full_name":"lukebjerring/web-platform-tests","owner":{"login":"lukebjerring","id":777956,"avatar_url":"https://avatars2.githubusercontent.com/u/777956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebjerring","html_url":"https://github.com/lukebjerring","followers_url":"https://api.github.com/users/lukebjerring/followers","following_url":"https://api.github.com/users/lukebjerring/following{/other_user}","gists_url":"https://api.github.com/users/lukebjerring/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebjerring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebjerring/subscriptions","organizations_url":"https://api.github.com/users/lukebjerring/orgs","repos_url":"https://api.github.com/users/lukebjerring/repos","events_url":"https://api.github.com/users/lukebjerring/events{/privacy}","received_events_url":"https://api.github.com/users/lukebjerring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukebjerring/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":true,"url":"https://api.github.com/repos/lukebjerring/web-platform-tests","forks_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/forks","keys_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/events","assignees_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/merges","archive_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/lukebjerring/web-platform-tests/deployments","created_at":"2017-09-29T18:53:25Z","updated_at":"2018-03-22T12:54:39Z","pushed_at":"2018-03-23T19:58:14Z","git_url":"git://github.com/lukebjerring/web-platform-tests.git","ssh_url":"git@github.com:lukebjerring/web-platform-tests.git","clone_url":"https://github.com/lukebjerring/web-platform-tests.git","svn_url":"https://github.com/lukebjerring/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":273321,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"7991f4bac7d03ac0251bc5eac60b725ad53ca81f","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-03-27T12:17:13Z","pushed_at":"2018-03-27T12:35:22Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":289069,"stargazers_count":1497,"watchers_count":1497,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1374,"mirror_url":null,"archived":false,"open_issues_count":1160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1374,"open_issues":1160,"watchers":1497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/10164"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/10164"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/10164/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10164/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/35ef11d0f60dae103603ee92fd71a98bc3e12e7c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"foolip"}}