{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/243460760","pull_request_review_id":187237997,"id":243460760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ2MDc2MA==","diff_hunk":"@@ -137,6 +140,22 @@ func NewFDBBackend(conf map[string]string, logger log.Logger) (physical.Backend,\n \n \tdirPath := strings.Split(strings.Trim(path, \"/\"), \"/\")\n \n+\t// TLS support\n+\ttlsCertFile, hasCertFile := conf[\"tls_cert_file\"]\n+\ttlsKeyFile, hasKeyFile := conf[\"tls_key_file\"]\n+\ttlsCAFile, hasCAFile := conf[\"tls_ca_file\"]\n+\n+\ttlsEnabled := hasCertFile && hasKeyFile && hasCAFile","path":"physical/foundationdb/foundationdb.go","position":19,"original_position":19,"commit_id":"1cc77cc5de8b114bd42f60e379ba075479096b3d","original_commit_id":"1cc77cc5de8b114bd42f60e379ba075479096b3d","user":{"login":"jblache","id":30199212,"node_id":"MDQ6VXNlcjMwMTk5MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/30199212?v=4","gravatar_id":"","url":"https://api.github.com/users/jblache","html_url":"https://github.com/jblache","followers_url":"https://api.github.com/users/jblache/followers","following_url":"https://api.github.com/users/jblache/following{/other_user}","gists_url":"https://api.github.com/users/jblache/gists{/gist_id}","starred_url":"https://api.github.com/users/jblache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jblache/subscriptions","organizations_url":"https://api.github.com/users/jblache/orgs","repos_url":"https://api.github.com/users/jblache/repos","events_url":"https://api.github.com/users/jblache/events{/privacy}","received_events_url":"https://api.github.com/users/jblache/received_events","type":"User","site_admin":false},"body":"Thanks! 🎩 ","created_at":"2018-12-21T00:36:50Z","updated_at":"2018-12-21T00:36:50Z","html_url":"https://github.com/hashicorp/vault/pull/5800#discussion_r243460760","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/5800","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/243460760"},"html":{"href":"https://github.com/hashicorp/vault/pull/5800#discussion_r243460760"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5800"}},"in_reply_to_id":243383565},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/5800","id":231340297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzQwMjk3","html_url":"https://github.com/hashicorp/vault/pull/5800","diff_url":"https://github.com/hashicorp/vault/pull/5800.diff","patch_url":"https://github.com/hashicorp/vault/pull/5800.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/5800","number":5800,"state":"open","locked":false,"title":"FoundationDB backend TLS support and housekeeping","user":{"login":"jblache","id":30199212,"node_id":"MDQ6VXNlcjMwMTk5MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/30199212?v=4","gravatar_id":"","url":"https://api.github.com/users/jblache","html_url":"https://github.com/jblache","followers_url":"https://api.github.com/users/jblache/followers","following_url":"https://api.github.com/users/jblache/following{/other_user}","gists_url":"https://api.github.com/users/jblache/gists{/gist_id}","starred_url":"https://api.github.com/users/jblache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jblache/subscriptions","organizations_url":"https://api.github.com/users/jblache/orgs","repos_url":"https://api.github.com/users/jblache/repos","events_url":"https://api.github.com/users/jblache/events{/privacy}","received_events_url":"https://api.github.com/users/jblache/received_events","type":"User","site_admin":false},"body":"TLS support was added to FoundationDB in 5.2.4; this PR adds the necessary bits for TLS support to the FoundationDB Vault backend, along with documentation updates.\r\n\r\nSome housekeeping is included for good measure. Of note, the FoundationDB Go bindings got vendored in an update, which breaks the build and doesn't work in practice. Revert that and add the proper ignores.","created_at":"2018-11-15T21:29:12Z","updated_at":"2018-12-21T00:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f81bb83446dfc656881dffdfa656e8a308c53d4b","assignee":{"login":"tyrannosaurus-becks","id":1152361,"node_id":"MDQ6VXNlcjExNTIzNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1152361?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannosaurus-becks","html_url":"https://github.com/tyrannosaurus-becks","followers_url":"https://api.github.com/users/tyrannosaurus-becks/followers","following_url":"https://api.github.com/users/tyrannosaurus-becks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannosaurus-becks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannosaurus-becks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannosaurus-becks/subscriptions","organizations_url":"https://api.github.com/users/tyrannosaurus-becks/orgs","repos_url":"https://api.github.com/users/tyrannosaurus-becks/repos","events_url":"https://api.github.com/users/tyrannosaurus-becks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannosaurus-becks/received_events","type":"User","site_admin":false},"assignees":[{"login":"tyrannosaurus-becks","id":1152361,"node_id":"MDQ6VXNlcjExNTIzNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1152361?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannosaurus-becks","html_url":"https://github.com/tyrannosaurus-becks","followers_url":"https://api.github.com/users/tyrannosaurus-becks/followers","following_url":"https://api.github.com/users/tyrannosaurus-becks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannosaurus-becks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannosaurus-becks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannosaurus-becks/subscriptions","organizations_url":"https://api.github.com/users/tyrannosaurus-becks/orgs","repos_url":"https://api.github.com/users/tyrannosaurus-becks/repos","events_url":"https://api.github.com/users/tyrannosaurus-becks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannosaurus-becks/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/hashicorp/vault/milestones/44","html_url":"https://github.com/hashicorp/vault/milestone/44","labels_url":"https://api.github.com/repos/hashicorp/vault/milestones/44/labels","id":3821910,"node_id":"MDk6TWlsZXN0b25lMzgyMTkxMA==","number":44,"title":"1.1","description":null,"creator":{"login":"jefferai","id":28627,"node_id":"MDQ6VXNlcjI4NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/28627?v=4","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2018-11-14T15:36:16Z","updated_at":"2018-12-12T20:44:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/5800/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/5800/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/5800/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/1cc77cc5de8b114bd42f60e379ba075479096b3d","head":{"label":"jblache:apple/foundationdb-tls","ref":"apple/foundationdb-tls","sha":"1cc77cc5de8b114bd42f60e379ba075479096b3d","user":{"login":"jblache","id":30199212,"node_id":"MDQ6VXNlcjMwMTk5MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/30199212?v=4","gravatar_id":"","url":"https://api.github.com/users/jblache","html_url":"https://github.com/jblache","followers_url":"https://api.github.com/users/jblache/followers","following_url":"https://api.github.com/users/jblache/following{/other_user}","gists_url":"https://api.github.com/users/jblache/gists{/gist_id}","starred_url":"https://api.github.com/users/jblache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jblache/subscriptions","organizations_url":"https://api.github.com/users/jblache/orgs","repos_url":"https://api.github.com/users/jblache/repos","events_url":"https://api.github.com/users/jblache/events{/privacy}","received_events_url":"https://api.github.com/users/jblache/received_events","type":"User","site_admin":false},"repo":{"id":140491651,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0OTE2NTE=","name":"vault","full_name":"jblache/vault","private":false,"owner":{"login":"jblache","id":30199212,"node_id":"MDQ6VXNlcjMwMTk5MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/30199212?v=4","gravatar_id":"","url":"https://api.github.com/users/jblache","html_url":"https://github.com/jblache","followers_url":"https://api.github.com/users/jblache/followers","following_url":"https://api.github.com/users/jblache/following{/other_user}","gists_url":"https://api.github.com/users/jblache/gists{/gist_id}","starred_url":"https://api.github.com/users/jblache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jblache/subscriptions","organizations_url":"https://api.github.com/users/jblache/orgs","repos_url":"https://api.github.com/users/jblache/repos","events_url":"https://api.github.com/users/jblache/events{/privacy}","received_events_url":"https://api.github.com/users/jblache/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jblache/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":true,"url":"https://api.github.com/repos/jblache/vault","forks_url":"https://api.github.com/repos/jblache/vault/forks","keys_url":"https://api.github.com/repos/jblache/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jblache/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jblache/vault/teams","hooks_url":"https://api.github.com/repos/jblache/vault/hooks","issue_events_url":"https://api.github.com/repos/jblache/vault/issues/events{/number}","events_url":"https://api.github.com/repos/jblache/vault/events","assignees_url":"https://api.github.com/repos/jblache/vault/assignees{/user}","branches_url":"https://api.github.com/repos/jblache/vault/branches{/branch}","tags_url":"https://api.github.com/repos/jblache/vault/tags","blobs_url":"https://api.github.com/repos/jblache/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jblache/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jblache/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/jblache/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jblache/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/jblache/vault/languages","stargazers_url":"https://api.github.com/repos/jblache/vault/stargazers","contributors_url":"https://api.github.com/repos/jblache/vault/contributors","subscribers_url":"https://api.github.com/repos/jblache/vault/subscribers","subscription_url":"https://api.github.com/repos/jblache/vault/subscription","commits_url":"https://api.github.com/repos/jblache/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/jblache/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/jblache/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/jblache/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/jblache/vault/contents/{+path}","compare_url":"https://api.github.com/repos/jblache/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jblache/vault/merges","archive_url":"https://api.github.com/repos/jblache/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jblache/vault/downloads","issues_url":"https://api.github.com/repos/jblache/vault/issues{/number}","pulls_url":"https://api.github.com/repos/jblache/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/jblache/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/jblache/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jblache/vault/labels{/name}","releases_url":"https://api.github.com/repos/jblache/vault/releases{/id}","deployments_url":"https://api.github.com/repos/jblache/vault/deployments","created_at":"2018-07-10T22:03:07Z","updated_at":"2018-11-15T21:26:19Z","pushed_at":"2018-11-15T23:34:42Z","git_url":"git://github.com/jblache/vault.git","ssh_url":"git@github.com:jblache/vault.git","clone_url":"https://github.com/jblache/vault.git","svn_url":"https://github.com/jblache/vault","homepage":"https://www.vaultproject.io/","size":80298,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"737a26d1561be2f1c5e64f097e92c1ac4232f995","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI4ODk1OA==","name":"vault","full_name":"hashicorp/vault","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-12-20T23:54:42Z","pushed_at":"2018-12-20T19:54:27Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":74954,"stargazers_count":10889,"watchers_count":10889,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1674,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1674,"open_issues":349,"watchers":10889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5800"},"html":{"href":"https://github.com/hashicorp/vault/pull/5800"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/5800"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/5800/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5800/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5800/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/1cc77cc5de8b114bd42f60e379ba075479096b3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jblache"}}