{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/190344273","pull_request_review_id":122683306,"id":190344273,"diff_hunk":"@@ -138,6 +139,54 @@ public void TestDeleteE2E()\n             Assert.False(CheckBlobExists(blob));\n         }\n \n+        [Fact(Skip = SkipMessage)]\n+        public void TestGetChildBlobsInContainerE2E()\n+        {\n+            // setup\n+            string[] parentFileNames = new string[] { \"sample1\", \"sample2\", \"sample3\" };\n+            string[] folderfileNames = new string[] { \"folder1/sample4\", \"folder1/sample5\" };\n+            string[] parentListNames = new string[] { \"sample1\", \"sample2\", \"sample3\", \"folder1/\" };","path":"lang/cs/Org.Apache.REEF.IO.Tests/TestAzureBlockBlobFileSystemE2E.cs","position":18,"original_position":18,"commit_id":"3a710e408a4e7209f0805c02659de004efdaab32","original_commit_id":"3a710e408a4e7209f0805c02659de004efdaab32","user":{"login":"tyclintw","id":19498033,"avatar_url":"https://avatars0.githubusercontent.com/u/19498033?v=4","gravatar_id":"","url":"https://api.github.com/users/tyclintw","html_url":"https://github.com/tyclintw","followers_url":"https://api.github.com/users/tyclintw/followers","following_url":"https://api.github.com/users/tyclintw/following{/other_user}","gists_url":"https://api.github.com/users/tyclintw/gists{/gist_id}","starred_url":"https://api.github.com/users/tyclintw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyclintw/subscriptions","organizations_url":"https://api.github.com/users/tyclintw/orgs","repos_url":"https://api.github.com/users/tyclintw/repos","events_url":"https://api.github.com/users/tyclintw/events{/privacy}","received_events_url":"https://api.github.com/users/tyclintw/received_events","type":"User","site_admin":false},"body":"These three arrays and their naming conventions make if very difficult to follow your logic. Can this be simplified with one list and the use of select statements? Something like the following. At the very least change parentFileNames to a concrete list so the concat at 150 isn't necessary. \r\n```csharp\r\nstring[] fileNames = new string[] { \"sample1\", \"sample2\", \"sample3\", \"folder1/sample4\", \"folder1/sample5\" };\r\n\r\nvar rootFilenames = fileNames.GroupBy(f => f.Split('/')[0]).Select(g => g.Key);\r\nValidateChildenWithBlobs(_container.Uri, rootFilenames);\r\n\r\nvar folderBlobs = fileNames.Where(f => f.StartsWith(\"folder1\");\r\nValidateChildenWithBlobs(folderUri, folderBlobs);\r\n```\r\nOR\r\n```csharp\r\nstring[] fileNames = new string[] { \"sample1\", \"sample2\", \"sample3\",\"folder1/sample4\", \"folder1/sample5\" };\r\nstring[] expectedFolderChildren = new string[] { \"folder1/sample4\", \"folder1/sample5\" };\r\nstring[] expectedRootChildren = new string[] { \"sample1\", \"sample2\", \"sample3\", \"folder1/\" };\r\n```","created_at":"2018-05-23T17:59:05Z","updated_at":"2018-05-23T17:59:15Z","html_url":"https://github.com/apache/reef/pull/1464#discussion_r190344273","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/1464","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/190344273"},"html":{"href":"https://github.com/apache/reef/pull/1464#discussion_r190344273"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/1464"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/1464","id":189536144,"html_url":"https://github.com/apache/reef/pull/1464","diff_url":"https://github.com/apache/reef/pull/1464.diff","patch_url":"https://github.com/apache/reef/pull/1464.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/1464","number":1464,"state":"open","locked":false,"title":"[REEF-2022] Fixed AzureBlockBlobFileSystem.GetChildren api and unit tests","user":{"login":"sharathmalladi","id":9726998,"avatar_url":"https://avatars0.githubusercontent.com/u/9726998?v=4","gravatar_id":"","url":"https://api.github.com/users/sharathmalladi","html_url":"https://github.com/sharathmalladi","followers_url":"https://api.github.com/users/sharathmalladi/followers","following_url":"https://api.github.com/users/sharathmalladi/following{/other_user}","gists_url":"https://api.github.com/users/sharathmalladi/gists{/gist_id}","starred_url":"https://api.github.com/users/sharathmalladi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharathmalladi/subscriptions","organizations_url":"https://api.github.com/users/sharathmalladi/orgs","repos_url":"https://api.github.com/users/sharathmalladi/repos","events_url":"https://api.github.com/users/sharathmalladi/events{/privacy}","received_events_url":"https://api.github.com/users/sharathmalladi/received_events","type":"User","site_admin":false},"body":"Fixed the GetChildren api and added unit test.\r\n\r\nJIRA:\r\n[REEF-2022] https://issues.apache.org/jira/browse/REEF-2022\r\n\r\n","created_at":"2018-05-22T03:03:12Z","updated_at":"2018-05-23T17:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ca283e271f25cccb8223941983bd4e541611c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/1464/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/1464/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/1464/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/3a710e408a4e7209f0805c02659de004efdaab32","head":{"label":"sharathmalladi:users/sharathm/blobgetchildren","ref":"users/sharathm/blobgetchildren","sha":"3a710e408a4e7209f0805c02659de004efdaab32","user":{"login":"sharathmalladi","id":9726998,"avatar_url":"https://avatars0.githubusercontent.com/u/9726998?v=4","gravatar_id":"","url":"https://api.github.com/users/sharathmalladi","html_url":"https://github.com/sharathmalladi","followers_url":"https://api.github.com/users/sharathmalladi/followers","following_url":"https://api.github.com/users/sharathmalladi/following{/other_user}","gists_url":"https://api.github.com/users/sharathmalladi/gists{/gist_id}","starred_url":"https://api.github.com/users/sharathmalladi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharathmalladi/subscriptions","organizations_url":"https://api.github.com/users/sharathmalladi/orgs","repos_url":"https://api.github.com/users/sharathmalladi/repos","events_url":"https://api.github.com/users/sharathmalladi/events{/privacy}","received_events_url":"https://api.github.com/users/sharathmalladi/received_events","type":"User","site_admin":false},"repo":{"id":117293881,"name":"reef","full_name":"sharathmalladi/reef","owner":{"login":"sharathmalladi","id":9726998,"avatar_url":"https://avatars0.githubusercontent.com/u/9726998?v=4","gravatar_id":"","url":"https://api.github.com/users/sharathmalladi","html_url":"https://github.com/sharathmalladi","followers_url":"https://api.github.com/users/sharathmalladi/followers","following_url":"https://api.github.com/users/sharathmalladi/following{/other_user}","gists_url":"https://api.github.com/users/sharathmalladi/gists{/gist_id}","starred_url":"https://api.github.com/users/sharathmalladi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharathmalladi/subscriptions","organizations_url":"https://api.github.com/users/sharathmalladi/orgs","repos_url":"https://api.github.com/users/sharathmalladi/repos","events_url":"https://api.github.com/users/sharathmalladi/events{/privacy}","received_events_url":"https://api.github.com/users/sharathmalladi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharathmalladi/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/sharathmalladi/reef","forks_url":"https://api.github.com/repos/sharathmalladi/reef/forks","keys_url":"https://api.github.com/repos/sharathmalladi/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharathmalladi/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharathmalladi/reef/teams","hooks_url":"https://api.github.com/repos/sharathmalladi/reef/hooks","issue_events_url":"https://api.github.com/repos/sharathmalladi/reef/issues/events{/number}","events_url":"https://api.github.com/repos/sharathmalladi/reef/events","assignees_url":"https://api.github.com/repos/sharathmalladi/reef/assignees{/user}","branches_url":"https://api.github.com/repos/sharathmalladi/reef/branches{/branch}","tags_url":"https://api.github.com/repos/sharathmalladi/reef/tags","blobs_url":"https://api.github.com/repos/sharathmalladi/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharathmalladi/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharathmalladi/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharathmalladi/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharathmalladi/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/sharathmalladi/reef/languages","stargazers_url":"https://api.github.com/repos/sharathmalladi/reef/stargazers","contributors_url":"https://api.github.com/repos/sharathmalladi/reef/contributors","subscribers_url":"https://api.github.com/repos/sharathmalladi/reef/subscribers","subscription_url":"https://api.github.com/repos/sharathmalladi/reef/subscription","commits_url":"https://api.github.com/repos/sharathmalladi/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharathmalladi/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharathmalladi/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharathmalladi/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharathmalladi/reef/contents/{+path}","compare_url":"https://api.github.com/repos/sharathmalladi/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharathmalladi/reef/merges","archive_url":"https://api.github.com/repos/sharathmalladi/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharathmalladi/reef/downloads","issues_url":"https://api.github.com/repos/sharathmalladi/reef/issues{/number}","pulls_url":"https://api.github.com/repos/sharathmalladi/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/sharathmalladi/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/sharathmalladi/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharathmalladi/reef/labels{/name}","releases_url":"https://api.github.com/repos/sharathmalladi/reef/releases{/id}","deployments_url":"https://api.github.com/repos/sharathmalladi/reef/deployments","created_at":"2018-01-12T22:28:44Z","updated_at":"2018-05-18T16:47:52Z","pushed_at":"2018-05-23T17:04:05Z","git_url":"git://github.com/sharathmalladi/reef.git","ssh_url":"git@github.com:sharathmalladi/reef.git","clone_url":"https://github.com/sharathmalladi/reef.git","svn_url":"https://github.com/sharathmalladi/reef","homepage":"","size":39517,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5ed56eba3b0b438dc0fdf10a37a58fcfdeb81223","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","deployments_url":"https://api.github.com/repos/apache/reef/deployments","created_at":"2014-10-23T07:00:10Z","updated_at":"2018-05-14T01:20:54Z","pushed_at":"2018-05-23T17:36:23Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":39633,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":99,"open_issues":17,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/1464"},"html":{"href":"https://github.com/apache/reef/pull/1464"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/1464"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/1464/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/1464/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/1464/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/3a710e408a4e7209f0805c02659de004efdaab32"}},"author_association":"NONE"}}
{"actor":{"display_login":"tyclintw"}}