{"action":"created","comment":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/210478437","pull_request_review_id":146700855,"id":210478437,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQ3ODQzNw==","diff_hunk":"@@ -204,12 +204,15 @@ napi_status napi_get_value_string_utf8(napi_env env, napi_value value,\n \n   if (buf == NULL) {\n     size_t str_size = jerry_get_utf8_string_size(jval);\n+    /** null terminator is excluded */","path":"src/napi/node_api_value.c","position":4,"original_position":4,"commit_id":"ffbb2e6d5cc0ddaec032fe8ba14922c5bdf0a1a4","original_commit_id":"ffbb2e6d5cc0ddaec032fe8ba14922c5bdf0a1a4","user":{"login":"legendecas","id":8500303,"node_id":"MDQ6VXNlcjg1MDAzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8500303?v=4","gravatar_id":"","url":"https://api.github.com/users/legendecas","html_url":"https://github.com/legendecas","followers_url":"https://api.github.com/users/legendecas/followers","following_url":"https://api.github.com/users/legendecas/following{/other_user}","gists_url":"https://api.github.com/users/legendecas/gists{/gist_id}","starred_url":"https://api.github.com/users/legendecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legendecas/subscriptions","organizations_url":"https://api.github.com/users/legendecas/orgs","repos_url":"https://api.github.com/users/legendecas/repos","events_url":"https://api.github.com/users/legendecas/events{/privacy}","received_events_url":"https://api.github.com/users/legendecas/received_events","type":"User","site_admin":false},"body":"`/**` can be turned into multi-line comment with ease :)\r\n\r\n```\r\n/**\r\n * Like this\r\n */\r\n```","created_at":"2018-08-16T05:13:50Z","updated_at":"2018-08-16T05:13:50Z","html_url":"https://github.com/Rokid/ShadowNode/pull/300#discussion_r210478437","pull_request_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/210478437"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/300#discussion_r210478437"},"pull_request":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300"}},"in_reply_to_id":210474513},"pull_request":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300","id":208738884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzM4ODg0","html_url":"https://github.com/Rokid/ShadowNode/pull/300","diff_url":"https://github.com/Rokid/ShadowNode/pull/300.diff","patch_url":"https://github.com/Rokid/ShadowNode/pull/300.patch","issue_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/300","number":300,"state":"open","locked":false,"title":"napi: null terminator on copying string value","user":{"login":"legendecas","id":8500303,"node_id":"MDQ6VXNlcjg1MDAzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8500303?v=4","gravatar_id":"","url":"https://api.github.com/users/legendecas","html_url":"https://github.com/legendecas","followers_url":"https://api.github.com/users/legendecas/followers","following_url":"https://api.github.com/users/legendecas/following{/other_user}","gists_url":"https://api.github.com/users/legendecas/gists{/gist_id}","starred_url":"https://api.github.com/users/legendecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legendecas/subscriptions","organizations_url":"https://api.github.com/users/legendecas/orgs","repos_url":"https://api.github.com/users/legendecas/repos","events_url":"https://api.github.com/users/legendecas/events{/privacy}","received_events_url":"https://api.github.com/users/legendecas/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `npm test` passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n\r\nIssues fixed in this PR:\r\n\r\n- no null terminator added on end of string on copying string value\r\n- returning number value `0` on N-API function would be transformed to `undefined`: now no tranformation is performed","created_at":"2018-08-16T03:53:20Z","updated_at":"2018-08-16T05:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0cc59b8570ac278fcef617fbfaabdd830fbb4bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lolBig","id":3438038,"node_id":"MDQ6VXNlcjM0MzgwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3438038?v=4","gravatar_id":"","url":"https://api.github.com/users/lolBig","html_url":"https://github.com/lolBig","followers_url":"https://api.github.com/users/lolBig/followers","following_url":"https://api.github.com/users/lolBig/following{/other_user}","gists_url":"https://api.github.com/users/lolBig/gists{/gist_id}","starred_url":"https://api.github.com/users/lolBig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolBig/subscriptions","organizations_url":"https://api.github.com/users/lolBig/orgs","repos_url":"https://api.github.com/users/lolBig/repos","events_url":"https://api.github.com/users/lolBig/events{/privacy}","received_events_url":"https://api.github.com/users/lolBig/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":982835640,"node_id":"MDU6TGFiZWw5ODI4MzU2NDA=","url":"https://api.github.com/repos/Rokid/ShadowNode/labels/napi","name":"napi","color":"9acde2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300/commits","review_comments_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300/comments","review_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/300/comments","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/ffbb2e6d5cc0ddaec032fe8ba14922c5bdf0a1a4","head":{"label":"Rokid:napi/string","ref":"napi/string","sha":"ffbb2e6d5cc0ddaec032fe8ba14922c5bdf0a1a4","user":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"repo":{"id":114971968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NzE5Njg=","name":"ShadowNode","full_name":"Rokid/ShadowNode","owner":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rokid/ShadowNode","description":"Use Node.js in your end devices :)","fork":false,"url":"https://api.github.com/repos/Rokid/ShadowNode","forks_url":"https://api.github.com/repos/Rokid/ShadowNode/forks","keys_url":"https://api.github.com/repos/Rokid/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rokid/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rokid/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Rokid/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Rokid/ShadowNode/events","assignees_url":"https://api.github.com/repos/Rokid/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Rokid/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Rokid/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rokid/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rokid/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Rokid/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Rokid/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Rokid/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Rokid/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Rokid/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Rokid/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rokid/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rokid/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Rokid/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rokid/ShadowNode/merges","archive_url":"https://api.github.com/repos/Rokid/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rokid/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Rokid/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Rokid/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Rokid/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rokid/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Rokid/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Rokid/ShadowNode/deployments","created_at":"2017-12-21T06:40:28Z","updated_at":"2018-08-15T10:51:12Z","pushed_at":"2018-08-16T03:57:23Z","git_url":"git://github.com/Rokid/ShadowNode.git","ssh_url":"git@github.com:Rokid/ShadowNode.git","clone_url":"https://github.com/Rokid/ShadowNode.git","svn_url":"https://github.com/Rokid/ShadowNode","homepage":"https://rokid.github.io/ShadowNode/","size":8729,"stargazers_count":331,"watchers_count":331,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":54,"watchers":331,"default_branch":"master"}},"base":{"label":"Rokid:master","ref":"master","sha":"3b82f45ec93bf18b8ac42a26522111ad0048802d","user":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"repo":{"id":114971968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NzE5Njg=","name":"ShadowNode","full_name":"Rokid/ShadowNode","owner":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rokid/ShadowNode","description":"Use Node.js in your end devices :)","fork":false,"url":"https://api.github.com/repos/Rokid/ShadowNode","forks_url":"https://api.github.com/repos/Rokid/ShadowNode/forks","keys_url":"https://api.github.com/repos/Rokid/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rokid/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rokid/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Rokid/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Rokid/ShadowNode/events","assignees_url":"https://api.github.com/repos/Rokid/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Rokid/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Rokid/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rokid/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rokid/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Rokid/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Rokid/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Rokid/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Rokid/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Rokid/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Rokid/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rokid/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rokid/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Rokid/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rokid/ShadowNode/merges","archive_url":"https://api.github.com/repos/Rokid/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rokid/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Rokid/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Rokid/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Rokid/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rokid/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Rokid/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Rokid/ShadowNode/deployments","created_at":"2017-12-21T06:40:28Z","updated_at":"2018-08-15T10:51:12Z","pushed_at":"2018-08-16T03:57:23Z","git_url":"git://github.com/Rokid/ShadowNode.git","ssh_url":"git@github.com:Rokid/ShadowNode.git","clone_url":"https://github.com/Rokid/ShadowNode.git","svn_url":"https://github.com/Rokid/ShadowNode","homepage":"https://rokid.github.io/ShadowNode/","size":8729,"stargazers_count":331,"watchers_count":331,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":54,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/300"},"issue":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/300"},"comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/Rokid/ShadowNode/statuses/ffbb2e6d5cc0ddaec032fe8ba14922c5bdf0a1a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"legendecas"}}