{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/184845997","pull_request_review_id":116127933,"id":184845997,"diff_hunk":"@@ -490,6 +490,12 @@ def deploy_template(self):\n                 uri=self.template_link\n             )\n \n+        # this is to fix issue #35536 -- it's impossible to pass int parameters\n+        if self.parameters and self.template:","path":"lib/ansible/modules/cloud/azure/azure_rm_deployment.py","position":5,"original_position":5,"commit_id":"a1ad0c04294fb24f5dc90330c1f05b51b18e267c","original_commit_id":"a1ad0c04294fb24f5dc90330c1f05b51b18e267c","user":{"login":"yungezz","id":37337818,"avatar_url":"https://avatars3.githubusercontent.com/u/37337818?v=4","gravatar_id":"","url":"https://api.github.com/users/yungezz","html_url":"https://github.com/yungezz","followers_url":"https://api.github.com/users/yungezz/followers","following_url":"https://api.github.com/users/yungezz/following{/other_user}","gists_url":"https://api.github.com/users/yungezz/gists{/gist_id}","starred_url":"https://api.github.com/users/yungezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungezz/subscriptions","organizations_url":"https://api.github.com/users/yungezz/orgs","repos_url":"https://api.github.com/users/yungezz/repos","events_url":"https://api.github.com/users/yungezz/events{/privacy}","received_events_url":"https://api.github.com/users/yungezz/received_events","type":"User","site_admin":false},"body":"pls also help to fix in paremeters_link","created_at":"2018-04-28T08:47:09Z","updated_at":"2018-04-28T08:47:09Z","html_url":"https://github.com/ansible/ansible/pull/36818#discussion_r184845997","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/36818","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/184845997"},"html":{"href":"https://github.com/ansible/ansible/pull/36818#discussion_r184845997"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36818"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36818","id":171855093,"html_url":"https://github.com/ansible/ansible/pull/36818","diff_url":"https://github.com/ansible/ansible/pull/36818.diff","patch_url":"https://github.com/ansible/ansible/pull/36818.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36818","number":36818,"state":"open","locked":false,"title":"fix parameters passed as string that should be integer","user":{"login":"zikalino","id":11562540,"avatar_url":"https://avatars1.githubusercontent.com/u/11562540?v=4","gravatar_id":"","url":"https://api.github.com/users/zikalino","html_url":"https://github.com/zikalino","followers_url":"https://api.github.com/users/zikalino/followers","following_url":"https://api.github.com/users/zikalino/following{/other_user}","gists_url":"https://api.github.com/users/zikalino/gists{/gist_id}","starred_url":"https://api.github.com/users/zikalino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikalino/subscriptions","organizations_url":"https://api.github.com/users/zikalino/orgs","repos_url":"https://api.github.com/users/zikalino/repos","events_url":"https://api.github.com/users/zikalino/events{/privacy}","received_events_url":"https://api.github.com/users/zikalino/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nFixes bug #35536 \r\nConverts parameters passed as string to int based on template definition.\r\nNote: template has to be specified via **template** parameter, for example using **lookup** instead of **template_url**\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nazure_rm_deployment\r\n\r\n##### ANSIBLE VERSION\r\n2.4\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!---\r\nInclude additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful.\r\n  -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\n\r\n```\r\n","created_at":"2018-02-28T04:45:31Z","updated_at":"2018-04-28T08:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0707b00b1389baa9f095b97c63e642d25382116f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jborean93","id":8462645,"avatar_url":"https://avatars3.githubusercontent.com/u/8462645?v=4","gravatar_id":"","url":"https://api.github.com/users/jborean93","html_url":"https://github.com/jborean93","followers_url":"https://api.github.com/users/jborean93/followers","following_url":"https://api.github.com/users/jborean93/following{/other_user}","gists_url":"https://api.github.com/users/jborean93/gists{/gist_id}","starred_url":"https://api.github.com/users/jborean93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jborean93/subscriptions","organizations_url":"https://api.github.com/users/jborean93/orgs","repos_url":"https://api.github.com/users/jborean93/repos","events_url":"https://api.github.com/users/jborean93/events{/privacy}","received_events_url":"https://api.github.com/users/jborean93/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":379680468,"url":"https://api.github.com/repos/ansible/ansible/labels/azure","name":"azure","color":"c5def5","default":false},{"id":785271699,"url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":499433583,"url":"https://api.github.com/repos/ansible/ansible/labels/shipit","name":"shipit","color":"fbca04","default":false},{"id":669975544,"url":"https://api.github.com/repos/ansible/ansible/labels/support:certified","name":"support:certified","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/36818/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/36818/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36818/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/a1ad0c04294fb24f5dc90330c1f05b51b18e267c","head":{"label":"VSChina:deployment-int-params","ref":"deployment-int-params","sha":"a1ad0c04294fb24f5dc90330c1f05b51b18e267c","user":{"login":"VSChina","id":25995662,"avatar_url":"https://avatars3.githubusercontent.com/u/25995662?v=4","gravatar_id":"","url":"https://api.github.com/users/VSChina","html_url":"https://github.com/VSChina","followers_url":"https://api.github.com/users/VSChina/followers","following_url":"https://api.github.com/users/VSChina/following{/other_user}","gists_url":"https://api.github.com/users/VSChina/gists{/gist_id}","starred_url":"https://api.github.com/users/VSChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSChina/subscriptions","organizations_url":"https://api.github.com/users/VSChina/orgs","repos_url":"https://api.github.com/users/VSChina/repos","events_url":"https://api.github.com/users/VSChina/events{/privacy}","received_events_url":"https://api.github.com/users/VSChina/received_events","type":"Organization","site_admin":false},"repo":{"id":104982939,"name":"ansible","full_name":"VSChina/ansible","owner":{"login":"VSChina","id":25995662,"avatar_url":"https://avatars3.githubusercontent.com/u/25995662?v=4","gravatar_id":"","url":"https://api.github.com/users/VSChina","html_url":"https://github.com/VSChina","followers_url":"https://api.github.com/users/VSChina/followers","following_url":"https://api.github.com/users/VSChina/following{/other_user}","gists_url":"https://api.github.com/users/VSChina/gists{/gist_id}","starred_url":"https://api.github.com/users/VSChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSChina/subscriptions","organizations_url":"https://api.github.com/users/VSChina/orgs","repos_url":"https://api.github.com/users/VSChina/repos","events_url":"https://api.github.com/users/VSChina/events{/privacy}","received_events_url":"https://api.github.com/users/VSChina/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VSChina/ansible","description":"To sync with ansible's devel branch, click","fork":true,"url":"https://api.github.com/repos/VSChina/ansible","forks_url":"https://api.github.com/repos/VSChina/ansible/forks","keys_url":"https://api.github.com/repos/VSChina/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSChina/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSChina/ansible/teams","hooks_url":"https://api.github.com/repos/VSChina/ansible/hooks","issue_events_url":"https://api.github.com/repos/VSChina/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/VSChina/ansible/events","assignees_url":"https://api.github.com/repos/VSChina/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/VSChina/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/VSChina/ansible/tags","blobs_url":"https://api.github.com/repos/VSChina/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSChina/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSChina/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSChina/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSChina/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/VSChina/ansible/languages","stargazers_url":"https://api.github.com/repos/VSChina/ansible/stargazers","contributors_url":"https://api.github.com/repos/VSChina/ansible/contributors","subscribers_url":"https://api.github.com/repos/VSChina/ansible/subscribers","subscription_url":"https://api.github.com/repos/VSChina/ansible/subscription","commits_url":"https://api.github.com/repos/VSChina/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSChina/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSChina/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSChina/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSChina/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/VSChina/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSChina/ansible/merges","archive_url":"https://api.github.com/repos/VSChina/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSChina/ansible/downloads","issues_url":"https://api.github.com/repos/VSChina/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/VSChina/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/VSChina/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/VSChina/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSChina/ansible/labels{/name}","releases_url":"https://api.github.com/repos/VSChina/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/VSChina/ansible/deployments","created_at":"2017-09-27T06:52:43Z","updated_at":"2018-04-28T01:32:31Z","pushed_at":"2018-04-28T01:32:11Z","git_url":"git://github.com/VSChina/ansible.git","ssh_url":"git@github.com:VSChina/ansible.git","clone_url":"https://github.com/VSChina/ansible.git","svn_url":"https://github.com/VSChina/ansible","homepage":"https://travis-ci.org/VSChina/ansible","size":111046,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"8d49bb6eee51661e3dd6dcc2a493ba84aa8a516b","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-04-28T08:35:32Z","pushed_at":"2018-04-28T08:11:14Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":119072,"stargazers_count":29918,"watchers_count":29918,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11047,"mirror_url":null,"archived":false,"open_issues_count":5036,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":11047,"open_issues":5036,"watchers":29918,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36818"},"html":{"href":"https://github.com/ansible/ansible/pull/36818"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/36818"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/36818/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36818/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36818/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/a1ad0c04294fb24f5dc90330c1f05b51b18e267c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yungezz"}}