{"action":"created","comment":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments/213563020","pull_request_review_id":150422885,"id":213563020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzU2MzAyMA==","diff_hunk":"@@ -171,13 +171,13 @@ class MultipleFields extends Component {\n       state: { newItemAdded },\n       props: { label, value: values, component, onChange },\n     } = this;\n-    const usedValues = values.length ? values : [this.createEmptyItem()];\n+    const usedValues = values || [this.createEmptyItem()];\n     return (\n       <FormControl margin=\"normal\" fullWidth>\n         <FormLabel component=\"legend\">{label}</FormLabel>\n         <List>\n           {usedValues &&\n-            values.map((value, index) => (\n+            usedValues.map((value, index) => (","path":"src/components/02_atoms/MultipleFields/MultipleFields.js","position":12,"original_position":12,"commit_id":"26e81486a7c52e3f7ea4518c0ff53ab442206fd5","original_commit_id":"26e81486a7c52e3f7ea4518c0ff53ab442206fd5","user":{"login":"dawehner","id":29678,"node_id":"MDQ6VXNlcjI5Njc4","avatar_url":"https://avatars0.githubusercontent.com/u/29678?v=4","gravatar_id":"","url":"https://api.github.com/users/dawehner","html_url":"https://github.com/dawehner","followers_url":"https://api.github.com/users/dawehner/followers","following_url":"https://api.github.com/users/dawehner/following{/other_user}","gists_url":"https://api.github.com/users/dawehner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawehner/subscriptions","organizations_url":"https://api.github.com/users/dawehner/orgs","repos_url":"https://api.github.com/users/dawehner/repos","events_url":"https://api.github.com/users/dawehner/events{/privacy}","received_events_url":"https://api.github.com/users/dawehner/received_events","type":"User","site_admin":false},"body":"oh yeah that's indeed needed!","created_at":"2018-08-29T06:51:19Z","updated_at":"2018-08-29T06:51:19Z","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/431#discussion_r213563020","pull_request_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments/213563020"},"html":{"href":"https://github.com/jsdrupal/drupal-admin-ui/pull/431#discussion_r213563020"},"pull_request":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431","id":211645337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjQ1MzM3","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/431","diff_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/431.diff","patch_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/431.patch","issue_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/431","number":431,"state":"open","locked":false,"title":"MultipleFields usedValues mapping and values.length validation correc…","user":{"login":"vishalchandna1","id":13252288,"node_id":"MDQ6VXNlcjEzMjUyMjg4","avatar_url":"https://avatars0.githubusercontent.com/u/13252288?v=4","gravatar_id":"","url":"https://api.github.com/users/vishalchandna1","html_url":"https://github.com/vishalchandna1","followers_url":"https://api.github.com/users/vishalchandna1/followers","following_url":"https://api.github.com/users/vishalchandna1/following{/other_user}","gists_url":"https://api.github.com/users/vishalchandna1/gists{/gist_id}","starred_url":"https://api.github.com/users/vishalchandna1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishalchandna1/subscriptions","organizations_url":"https://api.github.com/users/vishalchandna1/orgs","repos_url":"https://api.github.com/users/vishalchandna1/repos","events_url":"https://api.github.com/users/vishalchandna1/events{/privacy}","received_events_url":"https://api.github.com/users/vishalchandna1/received_events","type":"User","site_admin":false},"body":"…ted.\r\n\r\n## Issue\r\n\r\nhttps://github.com/jsdrupal/drupal-admin-ui/issues/430\r\n\r\n`values.length` validation changed to the whole object validation\r\n\r\n`values.map` changed to `usedValues.map` to render an empty ingredient field on **add recipe** page. It also resolves the error for the **node edit page**\r\n\r\n\r\n\r\n","created_at":"2018-08-29T06:48:08Z","updated_at":"2018-08-29T06:51:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d319a981ebefdf4f8f6623293d0c6209c5e50db5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431/commits","review_comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431/comments","review_comment_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/431/comments","statuses_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/26e81486a7c52e3f7ea4518c0ff53ab442206fd5","head":{"label":"vishalchandna1:multiple-fields-validation","ref":"multiple-fields-validation","sha":"26e81486a7c52e3f7ea4518c0ff53ab442206fd5","user":{"login":"vishalchandna1","id":13252288,"node_id":"MDQ6VXNlcjEzMjUyMjg4","avatar_url":"https://avatars0.githubusercontent.com/u/13252288?v=4","gravatar_id":"","url":"https://api.github.com/users/vishalchandna1","html_url":"https://github.com/vishalchandna1","followers_url":"https://api.github.com/users/vishalchandna1/followers","following_url":"https://api.github.com/users/vishalchandna1/following{/other_user}","gists_url":"https://api.github.com/users/vishalchandna1/gists{/gist_id}","starred_url":"https://api.github.com/users/vishalchandna1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishalchandna1/subscriptions","organizations_url":"https://api.github.com/users/vishalchandna1/orgs","repos_url":"https://api.github.com/users/vishalchandna1/repos","events_url":"https://api.github.com/users/vishalchandna1/events{/privacy}","received_events_url":"https://api.github.com/users/vishalchandna1/received_events","type":"User","site_admin":false},"repo":{"id":144981855,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5ODE4NTU=","name":"drupal-admin-ui","full_name":"vishalchandna1/drupal-admin-ui","owner":{"login":"vishalchandna1","id":13252288,"node_id":"MDQ6VXNlcjEzMjUyMjg4","avatar_url":"https://avatars0.githubusercontent.com/u/13252288?v=4","gravatar_id":"","url":"https://api.github.com/users/vishalchandna1","html_url":"https://github.com/vishalchandna1","followers_url":"https://api.github.com/users/vishalchandna1/followers","following_url":"https://api.github.com/users/vishalchandna1/following{/other_user}","gists_url":"https://api.github.com/users/vishalchandna1/gists{/gist_id}","starred_url":"https://api.github.com/users/vishalchandna1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishalchandna1/subscriptions","organizations_url":"https://api.github.com/users/vishalchandna1/orgs","repos_url":"https://api.github.com/users/vishalchandna1/repos","events_url":"https://api.github.com/users/vishalchandna1/events{/privacy}","received_events_url":"https://api.github.com/users/vishalchandna1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishalchandna1/drupal-admin-ui","description":"This is an admin UI for Drupal, built with JavaScript & React. ⬅️✌️➡️","fork":true,"url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui","forks_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/forks","keys_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/teams","hooks_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/events","assignees_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/tags","blobs_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/languages","stargazers_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/subscription","commits_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/merges","archive_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/downloads","issues_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/vishalchandna1/drupal-admin-ui/deployments","created_at":"2018-08-16T12:01:32Z","updated_at":"2018-08-16T12:01:34Z","pushed_at":"2018-08-29T06:44:38Z","git_url":"git://github.com/vishalchandna1/drupal-admin-ui.git","ssh_url":"git@github.com:vishalchandna1/drupal-admin-ui.git","clone_url":"https://github.com/vishalchandna1/drupal-admin-ui.git","svn_url":"https://github.com/vishalchandna1/drupal-admin-ui","homepage":"","size":1013,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsdrupal:master","ref":"master","sha":"ce9cf64616fca20420a50eb2fbe9e65bccc1f280","user":{"login":"jsdrupal","id":34455645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/34455645?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdrupal","html_url":"https://github.com/jsdrupal","followers_url":"https://api.github.com/users/jsdrupal/followers","following_url":"https://api.github.com/users/jsdrupal/following{/other_user}","gists_url":"https://api.github.com/users/jsdrupal/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdrupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdrupal/subscriptions","organizations_url":"https://api.github.com/users/jsdrupal/orgs","repos_url":"https://api.github.com/users/jsdrupal/repos","events_url":"https://api.github.com/users/jsdrupal/events{/privacy}","received_events_url":"https://api.github.com/users/jsdrupal/received_events","type":"Organization","site_admin":false},"repo":{"id":121880923,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODA5MjM=","name":"drupal-admin-ui","full_name":"jsdrupal/drupal-admin-ui","owner":{"login":"jsdrupal","id":34455645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/34455645?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdrupal","html_url":"https://github.com/jsdrupal","followers_url":"https://api.github.com/users/jsdrupal/followers","following_url":"https://api.github.com/users/jsdrupal/following{/other_user}","gists_url":"https://api.github.com/users/jsdrupal/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdrupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdrupal/subscriptions","organizations_url":"https://api.github.com/users/jsdrupal/orgs","repos_url":"https://api.github.com/users/jsdrupal/repos","events_url":"https://api.github.com/users/jsdrupal/events{/privacy}","received_events_url":"https://api.github.com/users/jsdrupal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsdrupal/drupal-admin-ui","description":"This is an admin UI for Drupal, built with JavaScript & React. ⬅️✌️➡️","fork":false,"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui","forks_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/forks","keys_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/teams","hooks_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/events","assignees_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/tags","blobs_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/languages","stargazers_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/subscription","commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/merges","archive_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/downloads","issues_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/deployments","created_at":"2018-02-17T18:26:58Z","updated_at":"2018-08-28T21:14:27Z","pushed_at":"2018-08-29T06:48:08Z","git_url":"git://github.com/jsdrupal/drupal-admin-ui.git","ssh_url":"git@github.com:jsdrupal/drupal-admin-ui.git","clone_url":"https://github.com/jsdrupal/drupal-admin-ui.git","svn_url":"https://github.com/jsdrupal/drupal-admin-ui","homepage":"","size":1074,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":66,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431"},"html":{"href":"https://github.com/jsdrupal/drupal-admin-ui/pull/431"},"issue":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/431"},"comments":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/26e81486a7c52e3f7ea4518c0ff53ab442206fd5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dawehner"}}