{"action":"created","comment":{"url":"https://api.github.com/repos/wulkano/kap/pulls/comments/221738260","pull_request_review_id":160462140,"id":221738260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTczODI2MA==","diff_hunk":"@@ -37,9 +37,26 @@ export default class Editor extends React.Component {\n         <div className=\"title-bar\">\n           <div className=\"title-bar-container\">\n             <div className=\"traffic-lights\">","path":"renderer/components/editor/index.js","position":13,"original_position":3,"commit_id":"89f5978d5bcde65e86bd8d27f573ed9eaef2feea","original_commit_id":"89f5978d5bcde65e86bd8d27f573ed9eaef2feea","user":{"login":"karaggeorge","id":8822835,"node_id":"MDQ6VXNlcjg4MjI4MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/8822835?v=4","gravatar_id":"","url":"https://api.github.com/users/karaggeorge","html_url":"https://github.com/karaggeorge","followers_url":"https://api.github.com/users/karaggeorge/followers","following_url":"https://api.github.com/users/karaggeorge/following{/other_user}","gists_url":"https://api.github.com/users/karaggeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/karaggeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karaggeorge/subscriptions","organizations_url":"https://api.github.com/users/karaggeorge/orgs","repos_url":"https://api.github.com/users/karaggeorge/repos","events_url":"https://api.github.com/users/karaggeorge/events{/privacy}","received_events_url":"https://api.github.com/users/karaggeorge/received_events","type":"User","site_admin":false},"body":"For code clarity? Because I don't think we use them anywhere else","created_at":"2018-10-01T20:03:39Z","updated_at":"2018-10-01T20:03:39Z","html_url":"https://github.com/wulkano/kap/pull/548#discussion_r221738260","pull_request_url":"https://api.github.com/repos/wulkano/kap/pulls/548","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wulkano/kap/pulls/comments/221738260"},"html":{"href":"https://github.com/wulkano/kap/pull/548#discussion_r221738260"},"pull_request":{"href":"https://api.github.com/repos/wulkano/kap/pulls/548"}},"in_reply_to_id":221437816},"pull_request":{"url":"https://api.github.com/repos/wulkano/kap/pulls/548","id":218823363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODIzMzYz","html_url":"https://github.com/wulkano/kap/pull/548","diff_url":"https://github.com/wulkano/kap/pull/548.diff","patch_url":"https://github.com/wulkano/kap/pull/548.patch","issue_url":"https://api.github.com/repos/wulkano/kap/issues/548","number":548,"state":"open","locked":false,"title":"Editor behavior","user":{"login":"karaggeorge","id":8822835,"node_id":"MDQ6VXNlcjg4MjI4MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/8822835?v=4","gravatar_id":"","url":"https://api.github.com/users/karaggeorge","html_url":"https://github.com/karaggeorge","followers_url":"https://api.github.com/users/karaggeorge/followers","following_url":"https://api.github.com/users/karaggeorge/following{/other_user}","gists_url":"https://api.github.com/users/karaggeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/karaggeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karaggeorge/subscriptions","organizations_url":"https://api.github.com/users/karaggeorge/orgs","repos_url":"https://api.github.com/users/karaggeorge/repos","events_url":"https://api.github.com/users/karaggeorge/events{/privacy}","received_events_url":"https://api.github.com/users/karaggeorge/received_events","type":"User","site_admin":false},"body":"Fixes #540 \r\nFixes #542 \r\n\r\nThe right side of the controls looked too empty without the fullscreen icon. Might need to find something to fill that with. For now, I just added the duration of the video.\r\n\r\nFullscreen behaves the way a native window would\r\n\r\n@skllcrn if you have a better idea I'll update\r\n\r\n<img width=\"64\" alt=\"screenshot 2018-09-27 20 23 00\" src=\"https://user-images.githubusercontent.com/8822835/46181368-5feabb00-c293-11e8-992c-85dafafe19e2.png\">\r\n\r\n![screenshot 2018-09-27 20 22 54](https://user-images.githubusercontent.com/8822835/46181369-5feabb00-c293-11e8-93a8-ff60f627f72f.png)\r\n\r\n![kapture 2018-09-27 at 20 23 50](https://user-images.githubusercontent.com/8822835/46181371-64af6f00-c293-11e8-8568-f4dcfdef0042.gif)\r\n\r\n\r\n","created_at":"2018-09-28T00:25:34Z","updated_at":"2018-10-01T20:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"918f5668142acea46207cb01fd82ff1644ac1911","assignee":null,"assignees":[],"requested_reviewers":[{"login":"albinekb","id":5027156,"node_id":"MDQ6VXNlcjUwMjcxNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5027156?v=4","gravatar_id":"","url":"https://api.github.com/users/albinekb","html_url":"https://github.com/albinekb","followers_url":"https://api.github.com/users/albinekb/followers","following_url":"https://api.github.com/users/albinekb/following{/other_user}","gists_url":"https://api.github.com/users/albinekb/gists{/gist_id}","starred_url":"https://api.github.com/users/albinekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinekb/subscriptions","organizations_url":"https://api.github.com/users/albinekb/orgs","repos_url":"https://api.github.com/users/albinekb/repos","events_url":"https://api.github.com/users/albinekb/events{/privacy}","received_events_url":"https://api.github.com/users/albinekb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wulkano/kap/pulls/548/commits","review_comments_url":"https://api.github.com/repos/wulkano/kap/pulls/548/comments","review_comment_url":"https://api.github.com/repos/wulkano/kap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wulkano/kap/issues/548/comments","statuses_url":"https://api.github.com/repos/wulkano/kap/statuses/89f5978d5bcde65e86bd8d27f573ed9eaef2feea","head":{"label":"wulkano:editor-traffic-lights","ref":"editor-traffic-lights","sha":"89f5978d5bcde65e86bd8d27f573ed9eaef2feea","user":{"login":"wulkano","id":16321113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIxMTEz","avatar_url":"https://avatars2.githubusercontent.com/u/16321113?v=4","gravatar_id":"","url":"https://api.github.com/users/wulkano","html_url":"https://github.com/wulkano","followers_url":"https://api.github.com/users/wulkano/followers","following_url":"https://api.github.com/users/wulkano/following{/other_user}","gists_url":"https://api.github.com/users/wulkano/gists{/gist_id}","starred_url":"https://api.github.com/users/wulkano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulkano/subscriptions","organizations_url":"https://api.github.com/users/wulkano/orgs","repos_url":"https://api.github.com/users/wulkano/repos","events_url":"https://api.github.com/users/wulkano/events{/privacy}","received_events_url":"https://api.github.com/users/wulkano/received_events","type":"Organization","site_admin":false},"repo":{"id":65411043,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQxMTA0Mw==","name":"kap","full_name":"wulkano/kap","private":false,"owner":{"login":"wulkano","id":16321113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIxMTEz","avatar_url":"https://avatars2.githubusercontent.com/u/16321113?v=4","gravatar_id":"","url":"https://api.github.com/users/wulkano","html_url":"https://github.com/wulkano","followers_url":"https://api.github.com/users/wulkano/followers","following_url":"https://api.github.com/users/wulkano/following{/other_user}","gists_url":"https://api.github.com/users/wulkano/gists{/gist_id}","starred_url":"https://api.github.com/users/wulkano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulkano/subscriptions","organizations_url":"https://api.github.com/users/wulkano/orgs","repos_url":"https://api.github.com/users/wulkano/repos","events_url":"https://api.github.com/users/wulkano/events{/privacy}","received_events_url":"https://api.github.com/users/wulkano/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wulkano/kap","description":"An open-source screen recorder built with web technology","fork":false,"url":"https://api.github.com/repos/wulkano/kap","forks_url":"https://api.github.com/repos/wulkano/kap/forks","keys_url":"https://api.github.com/repos/wulkano/kap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wulkano/kap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wulkano/kap/teams","hooks_url":"https://api.github.com/repos/wulkano/kap/hooks","issue_events_url":"https://api.github.com/repos/wulkano/kap/issues/events{/number}","events_url":"https://api.github.com/repos/wulkano/kap/events","assignees_url":"https://api.github.com/repos/wulkano/kap/assignees{/user}","branches_url":"https://api.github.com/repos/wulkano/kap/branches{/branch}","tags_url":"https://api.github.com/repos/wulkano/kap/tags","blobs_url":"https://api.github.com/repos/wulkano/kap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wulkano/kap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wulkano/kap/git/refs{/sha}","trees_url":"https://api.github.com/repos/wulkano/kap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wulkano/kap/statuses/{sha}","languages_url":"https://api.github.com/repos/wulkano/kap/languages","stargazers_url":"https://api.github.com/repos/wulkano/kap/stargazers","contributors_url":"https://api.github.com/repos/wulkano/kap/contributors","subscribers_url":"https://api.github.com/repos/wulkano/kap/subscribers","subscription_url":"https://api.github.com/repos/wulkano/kap/subscription","commits_url":"https://api.github.com/repos/wulkano/kap/commits{/sha}","git_commits_url":"https://api.github.com/repos/wulkano/kap/git/commits{/sha}","comments_url":"https://api.github.com/repos/wulkano/kap/comments{/number}","issue_comment_url":"https://api.github.com/repos/wulkano/kap/issues/comments{/number}","contents_url":"https://api.github.com/repos/wulkano/kap/contents/{+path}","compare_url":"https://api.github.com/repos/wulkano/kap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wulkano/kap/merges","archive_url":"https://api.github.com/repos/wulkano/kap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wulkano/kap/downloads","issues_url":"https://api.github.com/repos/wulkano/kap/issues{/number}","pulls_url":"https://api.github.com/repos/wulkano/kap/pulls{/number}","milestones_url":"https://api.github.com/repos/wulkano/kap/milestones{/number}","notifications_url":"https://api.github.com/repos/wulkano/kap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wulkano/kap/labels{/name}","releases_url":"https://api.github.com/repos/wulkano/kap/releases{/id}","deployments_url":"https://api.github.com/repos/wulkano/kap/deployments","created_at":"2016-08-10T19:37:08Z","updated_at":"2018-10-01T13:30:55Z","pushed_at":"2018-10-01T19:58:33Z","git_url":"git://github.com/wulkano/kap.git","ssh_url":"git@github.com:wulkano/kap.git","clone_url":"https://github.com/wulkano/kap.git","svn_url":"https://github.com/wulkano/kap","homepage":"https://getkap.co","size":8146,"stargazers_count":9555,"watchers_count":9555,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":435,"open_issues":61,"watchers":9555,"default_branch":"master"}},"base":{"label":"wulkano:master","ref":"master","sha":"f2a708476ba2e9994eab9fb5de1ecf31049524af","user":{"login":"wulkano","id":16321113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIxMTEz","avatar_url":"https://avatars2.githubusercontent.com/u/16321113?v=4","gravatar_id":"","url":"https://api.github.com/users/wulkano","html_url":"https://github.com/wulkano","followers_url":"https://api.github.com/users/wulkano/followers","following_url":"https://api.github.com/users/wulkano/following{/other_user}","gists_url":"https://api.github.com/users/wulkano/gists{/gist_id}","starred_url":"https://api.github.com/users/wulkano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulkano/subscriptions","organizations_url":"https://api.github.com/users/wulkano/orgs","repos_url":"https://api.github.com/users/wulkano/repos","events_url":"https://api.github.com/users/wulkano/events{/privacy}","received_events_url":"https://api.github.com/users/wulkano/received_events","type":"Organization","site_admin":false},"repo":{"id":65411043,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQxMTA0Mw==","name":"kap","full_name":"wulkano/kap","private":false,"owner":{"login":"wulkano","id":16321113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIxMTEz","avatar_url":"https://avatars2.githubusercontent.com/u/16321113?v=4","gravatar_id":"","url":"https://api.github.com/users/wulkano","html_url":"https://github.com/wulkano","followers_url":"https://api.github.com/users/wulkano/followers","following_url":"https://api.github.com/users/wulkano/following{/other_user}","gists_url":"https://api.github.com/users/wulkano/gists{/gist_id}","starred_url":"https://api.github.com/users/wulkano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulkano/subscriptions","organizations_url":"https://api.github.com/users/wulkano/orgs","repos_url":"https://api.github.com/users/wulkano/repos","events_url":"https://api.github.com/users/wulkano/events{/privacy}","received_events_url":"https://api.github.com/users/wulkano/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wulkano/kap","description":"An open-source screen recorder built with web technology","fork":false,"url":"https://api.github.com/repos/wulkano/kap","forks_url":"https://api.github.com/repos/wulkano/kap/forks","keys_url":"https://api.github.com/repos/wulkano/kap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wulkano/kap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wulkano/kap/teams","hooks_url":"https://api.github.com/repos/wulkano/kap/hooks","issue_events_url":"https://api.github.com/repos/wulkano/kap/issues/events{/number}","events_url":"https://api.github.com/repos/wulkano/kap/events","assignees_url":"https://api.github.com/repos/wulkano/kap/assignees{/user}","branches_url":"https://api.github.com/repos/wulkano/kap/branches{/branch}","tags_url":"https://api.github.com/repos/wulkano/kap/tags","blobs_url":"https://api.github.com/repos/wulkano/kap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wulkano/kap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wulkano/kap/git/refs{/sha}","trees_url":"https://api.github.com/repos/wulkano/kap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wulkano/kap/statuses/{sha}","languages_url":"https://api.github.com/repos/wulkano/kap/languages","stargazers_url":"https://api.github.com/repos/wulkano/kap/stargazers","contributors_url":"https://api.github.com/repos/wulkano/kap/contributors","subscribers_url":"https://api.github.com/repos/wulkano/kap/subscribers","subscription_url":"https://api.github.com/repos/wulkano/kap/subscription","commits_url":"https://api.github.com/repos/wulkano/kap/commits{/sha}","git_commits_url":"https://api.github.com/repos/wulkano/kap/git/commits{/sha}","comments_url":"https://api.github.com/repos/wulkano/kap/comments{/number}","issue_comment_url":"https://api.github.com/repos/wulkano/kap/issues/comments{/number}","contents_url":"https://api.github.com/repos/wulkano/kap/contents/{+path}","compare_url":"https://api.github.com/repos/wulkano/kap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wulkano/kap/merges","archive_url":"https://api.github.com/repos/wulkano/kap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wulkano/kap/downloads","issues_url":"https://api.github.com/repos/wulkano/kap/issues{/number}","pulls_url":"https://api.github.com/repos/wulkano/kap/pulls{/number}","milestones_url":"https://api.github.com/repos/wulkano/kap/milestones{/number}","notifications_url":"https://api.github.com/repos/wulkano/kap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wulkano/kap/labels{/name}","releases_url":"https://api.github.com/repos/wulkano/kap/releases{/id}","deployments_url":"https://api.github.com/repos/wulkano/kap/deployments","created_at":"2016-08-10T19:37:08Z","updated_at":"2018-10-01T13:30:55Z","pushed_at":"2018-10-01T19:58:33Z","git_url":"git://github.com/wulkano/kap.git","ssh_url":"git@github.com:wulkano/kap.git","clone_url":"https://github.com/wulkano/kap.git","svn_url":"https://github.com/wulkano/kap","homepage":"https://getkap.co","size":8146,"stargazers_count":9555,"watchers_count":9555,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":435,"open_issues":61,"watchers":9555,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wulkano/kap/pulls/548"},"html":{"href":"https://github.com/wulkano/kap/pull/548"},"issue":{"href":"https://api.github.com/repos/wulkano/kap/issues/548"},"comments":{"href":"https://api.github.com/repos/wulkano/kap/issues/548/comments"},"review_comments":{"href":"https://api.github.com/repos/wulkano/kap/pulls/548/comments"},"review_comment":{"href":"https://api.github.com/repos/wulkano/kap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wulkano/kap/pulls/548/commits"},"statuses":{"href":"https://api.github.com/repos/wulkano/kap/statuses/89f5978d5bcde65e86bd8d27f573ed9eaef2feea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"karaggeorge"}}