{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/1794","repository_url":"https://api.github.com/repos/OpenMW/openmw","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/1794/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1794/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/1794/events","html_url":"https://github.com/OpenMW/openmw/pull/1794","id":338785457,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjMxMDIx","number":1794,"title":"Movement solver changes/fixes","user":{"login":"wareya","id":585488,"node_id":"MDQ6VXNlcjU4NTQ4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/585488?v=4","gravatar_id":"","url":"https://api.github.com/users/wareya","html_url":"https://github.com/wareya","followers_url":"https://api.github.com/users/wareya/followers","following_url":"https://api.github.com/users/wareya/following{/other_user}","gists_url":"https://api.github.com/users/wareya/gists{/gist_id}","starred_url":"https://api.github.com/users/wareya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wareya/subscriptions","organizations_url":"https://api.github.com/users/wareya/orgs","repos_url":"https://api.github.com/users/wareya/repos","events_url":"https://api.github.com/users/wareya/events{/privacy}","received_events_url":"https://api.github.com/users/wareya/received_events","type":"User","site_admin":false},"labels":[{"id":221591348,"node_id":"MDU6TGFiZWwyMjE1OTEzNDg=","url":"https://api.github.com/repos/OpenMW/openmw/labels/Discussion","name":"Discussion","color":"fbca04","default":false},{"id":510035820,"node_id":"MDU6TGFiZWw1MTAwMzU4MjA=","url":"https://api.github.com/repos/OpenMW/openmw/labels/Needs%20testing","name":"Needs testing","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":101,"created_at":"2018-07-06T02:37:03Z","updated_at":"2018-10-26T09:51:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1794","html_url":"https://github.com/OpenMW/openmw/pull/1794","diff_url":"https://github.com/OpenMW/openmw/pull/1794.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1794.patch"},"body":"This fixes several major problems with the current movement solver, which make it a lot harder to get stuck and much less common that you can't jump in certain locations unless you stand still.\r\n\r\nNo changelog additions yet and not ready to merge. Some of these changes can cause performance problems and bring some other bugs to attention (like capsules breaking some vanilla level design), so it shouldn't get merged until enough people look at it.\r\n\r\nIf you look at this, though, please test it, too, and compare its behavior ingame directly to current master. The problems it fixes are monumental.\r\n\r\nThis is certainly still not a perfect movement solver, but it's a lot better than what OpenMW has right now.\r\n\r\nProblems fixed:\r\n\r\n- Not mapping against what's hit unless the stair code successfully runs\r\n- Lack of safety margin making it unsafe to do the above\r\n- Problem with how \"don't skid up steep slopes\" worked, preventing jumping while running into walls\r\n- Some bad interactions between jumping and stairstepping\r\n- Getting stuck in simple acute crevices, including some hanging sloped walls and things like the double stairs in the ald'ruhn mage's guild (complex acute crevices still get stuck)\r\n- The stair code freaking out in obscure cases involving steep slopes\r\n\r\nTest cases:\r\n\r\n- The bottom of the stair meshes in interior vivec areas (test these with cylinders and rounded cylinders too, see actor.cpp)\r\n- The beds in the ald'ruhn mage's guild (their sides are steep slopes)\r\n- The bedside tables in the ald'ruhn mage's guild (their sides are VERY steep slopes)\r\n- The hanging sloped walls in the ald'ruhn mage's guild\r\n- The big plant pot thing near the entrance of the ald'ruhn mage's guild\r\n- Most walls anywhere\r\n- The double stairs in the ald'ruhn mage's guild (falling between the railings, not between them where you could always fit and get stuck) (note: in vanilla you can just walk between them for some reason)\r\n- Some of the pillars in the ald'ruhn mage's guild walls, where they intersect with the wall at an obtuse angle (as far as player collision is concerned)\r\n- A place in the ald'ruhn mage's guild (near a merchant) where two tall pots meet eachother at an obtuse angle (as far as player collision is concerned) (try jumping)\r\n\r\nThings that might need adjustment:\r\n\r\n- ~~~There's a hack that ensures the stairs code works correctly when the player is jumping and moving upwards, but maybe the stairs code shouldn't work in this case at all.~~~\r\n- There's a hack that makes slopes act like walls in some cases, to keep the character from stuttering and unable to jump when like walking into the sides of beds and tables in ald'ruhn, or some rocks in the wilderness. It doesn't help in some cases.\r\n\r\nRelated forum thread (linked for bookkeeping purposes): https://forum.openmw.org/viewtopic.php?f=6&t=5200"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/433353930","html_url":"https://github.com/OpenMW/openmw/pull/1794#issuecomment-433353930","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1794","id":433353930,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzM1MzkzMA==","user":{"login":"Capostrophic","id":21265616,"node_id":"MDQ6VXNlcjIxMjY1NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/21265616?v=4","gravatar_id":"","url":"https://api.github.com/users/Capostrophic","html_url":"https://github.com/Capostrophic","followers_url":"https://api.github.com/users/Capostrophic/followers","following_url":"https://api.github.com/users/Capostrophic/following{/other_user}","gists_url":"https://api.github.com/users/Capostrophic/gists{/gist_id}","starred_url":"https://api.github.com/users/Capostrophic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capostrophic/subscriptions","organizations_url":"https://api.github.com/users/Capostrophic/orgs","repos_url":"https://api.github.com/users/Capostrophic/repos","events_url":"https://api.github.com/users/Capostrophic/events{/privacy}","received_events_url":"https://api.github.com/users/Capostrophic/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T09:51:53Z","updated_at":"2018-10-26T09:51:53Z","author_association":"CONTRIBUTOR","body":">Also, this PR probably breaks the fix for Bug #2274 unless the platform moves extremely slowly.\r\n\r\nYou keep saying that (I remember you've said something similar before) but I don't understand what would be the problem because the fix is not physics-related at all, it simply applies the platform position change to the position of actors that are standing on the platform.\r\n\r\nWith the latest changes mRotationallyInvariant boolean is redundant."}}
{"actor":{"display_login":"Capostrophic"}}