{"action":"created","comment":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/228950036","pull_request_review_id":169258048,"id":228950036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk1MDAzNg==","diff_hunk":"@@ -4,5 +4,10 @@\n     \"@babel/preset-react\",\n     \"@babel/preset-flow\"\n   ],\n-  \"plugins\": [\"@babel/plugin-proposal-class-properties\", \"@babel/plugin-transform-flow-strip-types\", \"@babel/plugin-syntax-object-rest-spread\"]\n-}\n+  \"plugins\": [\n+    \"@babel/plugin-proposal-class-properties\",\n+    \"@babel/plugin-transform-flow-strip-types\",\n+    \"@babel/plugin-syntax-object-rest-spread\",\n+    \"react-hot-loader/babel\"\n+  ]\n+}","path":"web/html/src/.babelrc","position":12,"original_position":12,"commit_id":"9ed3839f63133aff73e2bbbbb377f4cae4753491","original_commit_id":"9ed3839f63133aff73e2bbbbb377f4cae4753491","user":{"login":"cbbayburt","id":1103552,"node_id":"MDQ6VXNlcjExMDM1NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1103552?v=4","gravatar_id":"","url":"https://api.github.com/users/cbbayburt","html_url":"https://github.com/cbbayburt","followers_url":"https://api.github.com/users/cbbayburt/followers","following_url":"https://api.github.com/users/cbbayburt/following{/other_user}","gists_url":"https://api.github.com/users/cbbayburt/gists{/gist_id}","starred_url":"https://api.github.com/users/cbbayburt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbbayburt/subscriptions","organizations_url":"https://api.github.com/users/cbbayburt/orgs","repos_url":"https://api.github.com/users/cbbayburt/repos","events_url":"https://api.github.com/users/cbbayburt/events{/privacy}","received_events_url":"https://api.github.com/users/cbbayburt/received_events","type":"User","site_admin":false},"body":"Nitpick: no newline at the end","created_at":"2018-10-29T14:32:54Z","updated_at":"2018-10-29T14:36:43Z","html_url":"https://github.com/uyuni-project/uyuni/pull/254#discussion_r228950036","pull_request_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/228950036"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/254#discussion_r228950036"},"pull_request":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254","id":226494227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDk0MjI3","html_url":"https://github.com/uyuni-project/uyuni/pull/254","diff_url":"https://github.com/uyuni-project/uyuni/pull/254.diff","patch_url":"https://github.com/uyuni-project/uyuni/pull/254.patch","issue_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/254","number":254,"state":"open","locked":false,"title":"Webpack frontend proxy server","user":{"login":"lneves12","id":1140720,"node_id":"MDQ6VXNlcjExNDA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1140720?v=4","gravatar_id":"","url":"https://api.github.com/users/lneves12","html_url":"https://github.com/lneves12","followers_url":"https://api.github.com/users/lneves12/followers","following_url":"https://api.github.com/users/lneves12/following{/other_user}","gists_url":"https://api.github.com/users/lneves12/gists{/gist_id}","starred_url":"https://api.github.com/users/lneves12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lneves12/subscriptions","organizations_url":"https://api.github.com/users/lneves12/orgs","repos_url":"https://api.github.com/users/lneves12/repos","events_url":"https://api.github.com/users/lneves12/events{/privacy}","received_events_url":"https://api.github.com/users/lneves12/received_events","type":"User","site_admin":false},"body":"## Things to be aware while testing\r\n\r\nThe notification paths were updated so you need to redeploy you backend server.\r\nIf connecting to a ref-server the hot reload will only work on the page subscription channels. The notification pages suffered some path changes so it will only work after this being merged and the backend jar is redeployed on the ref servers.\r\n\r\n## What does this PR change?\r\n\r\nNew frontend proxy server that serve all the static files and proxy everything for a chosen backend server.\r\n\r\nThis is based on my hackweek project work: https://hackweek.suse.com/17/projects/suse-manager-self-sufficient-frontend-server\r\n\r\n**Example to run the proxy server point to a local instance:**\r\n\r\n\"yarn proxy --server \"https://server.tf.local\" \r\n\r\nby default https://suma-refhead-srv.mgr.suse.de/ will be used\r\n\r\n**Advantages:**\r\n\r\n- Enable react hot reload of changed javascript\r\n- No need to sync static files through lsyncd to our vm, they are served directly from the webpack proxy server\r\n- Being able to change and troubleshoot frontend code connected to different backend servers, eg manager.suse.de, testesuite server, ref-servers, etc\r\n\r\n- [x] **DONE**\r\n\r\n## Documentation\r\n- No documentation needed: **add explanation. \r\n\r\n- [x] **DONE**\r\n\r\n## Test coverage\r\n- No tests: **add explanation**\r\n\r\n- [x] **DONE**\r\n\r\n## Links\r\n\r\nFixes https://github.com/SUSE/spacewalk/issues/6000\r\n\r\n- [x] **DONE**\r\n","created_at":"2018-10-29T09:48:23Z","updated_at":"2018-10-29T14:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220d5be715cac428fd9597b558e7dbf73049b4c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ncounter","id":7080830,"node_id":"MDQ6VXNlcjcwODA4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7080830?v=4","gravatar_id":"","url":"https://api.github.com/users/ncounter","html_url":"https://github.com/ncounter","followers_url":"https://api.github.com/users/ncounter/followers","following_url":"https://api.github.com/users/ncounter/following{/other_user}","gists_url":"https://api.github.com/users/ncounter/gists{/gist_id}","starred_url":"https://api.github.com/users/ncounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncounter/subscriptions","organizations_url":"https://api.github.com/users/ncounter/orgs","repos_url":"https://api.github.com/users/ncounter/repos","events_url":"https://api.github.com/users/ncounter/events{/privacy}","received_events_url":"https://api.github.com/users/ncounter/received_events","type":"User","site_admin":false},{"login":"mateiw","id":11468018,"node_id":"MDQ6VXNlcjExNDY4MDE4","avatar_url":"https://avatars2.githubusercontent.com/u/11468018?v=4","gravatar_id":"","url":"https://api.github.com/users/mateiw","html_url":"https://github.com/mateiw","followers_url":"https://api.github.com/users/mateiw/followers","following_url":"https://api.github.com/users/mateiw/following{/other_user}","gists_url":"https://api.github.com/users/mateiw/gists{/gist_id}","starred_url":"https://api.github.com/users/mateiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateiw/subscriptions","organizations_url":"https://api.github.com/users/mateiw/orgs","repos_url":"https://api.github.com/users/mateiw/repos","events_url":"https://api.github.com/users/mateiw/events{/privacy}","received_events_url":"https://api.github.com/users/mateiw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254/commits","review_comments_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254/comments","review_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/254/comments","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/9ed3839f63133aff73e2bbbbb377f4cae4753491","head":{"label":"lneves12:webpack_frontend_proxy_server","ref":"webpack_frontend_proxy_server","sha":"9ed3839f63133aff73e2bbbbb377f4cae4753491","user":{"login":"lneves12","id":1140720,"node_id":"MDQ6VXNlcjExNDA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1140720?v=4","gravatar_id":"","url":"https://api.github.com/users/lneves12","html_url":"https://github.com/lneves12","followers_url":"https://api.github.com/users/lneves12/followers","following_url":"https://api.github.com/users/lneves12/following{/other_user}","gists_url":"https://api.github.com/users/lneves12/gists{/gist_id}","starred_url":"https://api.github.com/users/lneves12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lneves12/subscriptions","organizations_url":"https://api.github.com/users/lneves12/orgs","repos_url":"https://api.github.com/users/lneves12/repos","events_url":"https://api.github.com/users/lneves12/events{/privacy}","received_events_url":"https://api.github.com/users/lneves12/received_events","type":"User","site_admin":false},"repo":{"id":145703198,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3MDMxOTg=","name":"uyuni","full_name":"lneves12/uyuni","private":false,"owner":{"login":"lneves12","id":1140720,"node_id":"MDQ6VXNlcjExNDA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1140720?v=4","gravatar_id":"","url":"https://api.github.com/users/lneves12","html_url":"https://github.com/lneves12","followers_url":"https://api.github.com/users/lneves12/followers","following_url":"https://api.github.com/users/lneves12/following{/other_user}","gists_url":"https://api.github.com/users/lneves12/gists{/gist_id}","starred_url":"https://api.github.com/users/lneves12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lneves12/subscriptions","organizations_url":"https://api.github.com/users/lneves12/orgs","repos_url":"https://api.github.com/users/lneves12/repos","events_url":"https://api.github.com/users/lneves12/events{/privacy}","received_events_url":"https://api.github.com/users/lneves12/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lneves12/uyuni","description":"Source code for Uyuni","fork":true,"url":"https://api.github.com/repos/lneves12/uyuni","forks_url":"https://api.github.com/repos/lneves12/uyuni/forks","keys_url":"https://api.github.com/repos/lneves12/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lneves12/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lneves12/uyuni/teams","hooks_url":"https://api.github.com/repos/lneves12/uyuni/hooks","issue_events_url":"https://api.github.com/repos/lneves12/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/lneves12/uyuni/events","assignees_url":"https://api.github.com/repos/lneves12/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/lneves12/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/lneves12/uyuni/tags","blobs_url":"https://api.github.com/repos/lneves12/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lneves12/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lneves12/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/lneves12/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lneves12/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/lneves12/uyuni/languages","stargazers_url":"https://api.github.com/repos/lneves12/uyuni/stargazers","contributors_url":"https://api.github.com/repos/lneves12/uyuni/contributors","subscribers_url":"https://api.github.com/repos/lneves12/uyuni/subscribers","subscription_url":"https://api.github.com/repos/lneves12/uyuni/subscription","commits_url":"https://api.github.com/repos/lneves12/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/lneves12/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/lneves12/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/lneves12/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/lneves12/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/lneves12/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lneves12/uyuni/merges","archive_url":"https://api.github.com/repos/lneves12/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lneves12/uyuni/downloads","issues_url":"https://api.github.com/repos/lneves12/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/lneves12/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/lneves12/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/lneves12/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lneves12/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/lneves12/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/lneves12/uyuni/deployments","created_at":"2018-08-22T12:01:29Z","updated_at":"2018-09-11T15:31:31Z","pushed_at":"2018-10-29T12:26:25Z","git_url":"git://github.com/lneves12/uyuni.git","ssh_url":"git@github.com:lneves12/uyuni.git","clone_url":"https://github.com/lneves12/uyuni.git","svn_url":"https://github.com/lneves12/uyuni","homepage":"https://www.uyuni-project.org/","size":790511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyuni-project:master","ref":"master","sha":"5528b66adde4db9d692fa9953d826344d8333580","user":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"repo":{"id":143291989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5ODk=","name":"uyuni","full_name":"uyuni-project/uyuni","private":false,"owner":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uyuni-project/uyuni","description":"Source code for Uyuni","fork":false,"url":"https://api.github.com/repos/uyuni-project/uyuni","forks_url":"https://api.github.com/repos/uyuni-project/uyuni/forks","keys_url":"https://api.github.com/repos/uyuni-project/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyuni-project/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyuni-project/uyuni/teams","hooks_url":"https://api.github.com/repos/uyuni-project/uyuni/hooks","issue_events_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/uyuni-project/uyuni/events","assignees_url":"https://api.github.com/repos/uyuni-project/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/uyuni-project/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/uyuni-project/uyuni/tags","blobs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyuni-project/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyuni-project/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/uyuni-project/uyuni/languages","stargazers_url":"https://api.github.com/repos/uyuni-project/uyuni/stargazers","contributors_url":"https://api.github.com/repos/uyuni-project/uyuni/contributors","subscribers_url":"https://api.github.com/repos/uyuni-project/uyuni/subscribers","subscription_url":"https://api.github.com/repos/uyuni-project/uyuni/subscription","commits_url":"https://api.github.com/repos/uyuni-project/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyuni-project/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyuni-project/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/uyuni-project/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyuni-project/uyuni/merges","archive_url":"https://api.github.com/repos/uyuni-project/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyuni-project/uyuni/downloads","issues_url":"https://api.github.com/repos/uyuni-project/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/uyuni-project/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/uyuni-project/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyuni-project/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/uyuni-project/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/uyuni-project/uyuni/deployments","created_at":"2018-08-02T12:31:20Z","updated_at":"2018-10-29T14:28:20Z","pushed_at":"2018-10-29T14:28:14Z","git_url":"git://github.com/uyuni-project/uyuni.git","ssh_url":"git@github.com:uyuni-project/uyuni.git","clone_url":"https://github.com/uyuni-project/uyuni.git","svn_url":"https://github.com/uyuni-project/uyuni","homepage":"https://www.uyuni-project.org/","size":790565,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":22,"open_issues":22,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/254"},"issue":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/254"},"comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/uyuni-project/uyuni/statuses/9ed3839f63133aff73e2bbbbb377f4cae4753491"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cbbayburt"}}