{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/235947497","pull_request_review_id":177935111,"id":235947497,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk0NzQ5Nw==","diff_hunk":"@@ -0,0 +1,4 @@\n+#!/bin/sh","path":"tests/lib/snaps/test-devmode-cgroup/bin/read-dev","position":1,"original_position":1,"commit_id":"13f946f46333b9871ea6dda9d76103eb1fea1b57","original_commit_id":"13f946f46333b9871ea6dda9d76103eb1fea1b57","user":{"login":"zyga","id":784262,"node_id":"MDQ6VXNlcjc4NDI2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"Can you please make this \r\n```suggestion\r\n#!/bin/sh -eu\r\n```","created_at":"2018-11-23T13:55:21Z","updated_at":"2018-11-23T13:57:47Z","html_url":"https://github.com/snapcore/snapd/pull/6200#discussion_r235947497","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/6200","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/235947497"},"html":{"href":"https://github.com/snapcore/snapd/pull/6200#discussion_r235947497"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6200"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/6200","id":233074112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDc0MTEy","html_url":"https://github.com/snapcore/snapd/pull/6200","diff_url":"https://github.com/snapcore/snapd/pull/6200.diff","patch_url":"https://github.com/snapcore/snapd/pull/6200.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/6200","number":6200,"state":"open","locked":false,"title":"tests: fix for tests test-*-cgroup","user":{"login":"sergiocazzolato","id":5382983,"node_id":"MDQ6VXNlcjUzODI5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5382983?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiocazzolato","html_url":"https://github.com/sergiocazzolato","followers_url":"https://api.github.com/users/sergiocazzolato/followers","following_url":"https://api.github.com/users/sergiocazzolato/following{/other_user}","gists_url":"https://api.github.com/users/sergiocazzolato/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiocazzolato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiocazzolato/subscriptions","organizations_url":"https://api.github.com/users/sergiocazzolato/orgs","repos_url":"https://api.github.com/users/sergiocazzolato/repos","events_url":"https://api.github.com/users/sergiocazzolato/events{/privacy}","received_events_url":"https://api.github.com/users/sergiocazzolato/received_events","type":"User","site_admin":false},"body":"This change makes more simple the snaps used and changes the char device\r\nused which was causing issues sporadically.\r\n\r\nThe errror in travis:\r\ngoogle:arch-linux-64 .../tests/main/security-device-cgroups-devmode#\r\ntest-devmode-cgroup.read-kmsg\r\nhead: error reading '/dev/kmsg': Broken pipe\r\n","created_at":"2018-11-22T21:20:12Z","updated_at":"2018-11-23T13:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a07a017fa9f4893a8ea8f7e496ea8a1b937e00d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/6200/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/6200/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/6200/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/13f946f46333b9871ea6dda9d76103eb1fea1b57","head":{"label":"sergiocazzolato:tests-fix-security-device-cgroups-devmode","ref":"tests-fix-security-device-cgroups-devmode","sha":"13f946f46333b9871ea6dda9d76103eb1fea1b57","user":{"login":"sergiocazzolato","id":5382983,"node_id":"MDQ6VXNlcjUzODI5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5382983?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiocazzolato","html_url":"https://github.com/sergiocazzolato","followers_url":"https://api.github.com/users/sergiocazzolato/followers","following_url":"https://api.github.com/users/sergiocazzolato/following{/other_user}","gists_url":"https://api.github.com/users/sergiocazzolato/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiocazzolato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiocazzolato/subscriptions","organizations_url":"https://api.github.com/users/sergiocazzolato/orgs","repos_url":"https://api.github.com/users/sergiocazzolato/repos","events_url":"https://api.github.com/users/sergiocazzolato/events{/privacy}","received_events_url":"https://api.github.com/users/sergiocazzolato/received_events","type":"User","site_admin":false},"repo":{"id":92107271,"node_id":"MDEwOlJlcG9zaXRvcnk5MjEwNzI3MQ==","name":"snapd","full_name":"sergiocazzolato/snapd","private":false,"owner":{"login":"sergiocazzolato","id":5382983,"node_id":"MDQ6VXNlcjUzODI5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5382983?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiocazzolato","html_url":"https://github.com/sergiocazzolato","followers_url":"https://api.github.com/users/sergiocazzolato/followers","following_url":"https://api.github.com/users/sergiocazzolato/following{/other_user}","gists_url":"https://api.github.com/users/sergiocazzolato/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiocazzolato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiocazzolato/subscriptions","organizations_url":"https://api.github.com/users/sergiocazzolato/orgs","repos_url":"https://api.github.com/users/sergiocazzolato/repos","events_url":"https://api.github.com/users/sergiocazzolato/events{/privacy}","received_events_url":"https://api.github.com/users/sergiocazzolato/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sergiocazzolato/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/sergiocazzolato/snapd","forks_url":"https://api.github.com/repos/sergiocazzolato/snapd/forks","keys_url":"https://api.github.com/repos/sergiocazzolato/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergiocazzolato/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergiocazzolato/snapd/teams","hooks_url":"https://api.github.com/repos/sergiocazzolato/snapd/hooks","issue_events_url":"https://api.github.com/repos/sergiocazzolato/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/sergiocazzolato/snapd/events","assignees_url":"https://api.github.com/repos/sergiocazzolato/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/sergiocazzolato/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/sergiocazzolato/snapd/tags","blobs_url":"https://api.github.com/repos/sergiocazzolato/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergiocazzolato/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergiocazzolato/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergiocazzolato/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergiocazzolato/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/sergiocazzolato/snapd/languages","stargazers_url":"https://api.github.com/repos/sergiocazzolato/snapd/stargazers","contributors_url":"https://api.github.com/repos/sergiocazzolato/snapd/contributors","subscribers_url":"https://api.github.com/repos/sergiocazzolato/snapd/subscribers","subscription_url":"https://api.github.com/repos/sergiocazzolato/snapd/subscription","commits_url":"https://api.github.com/repos/sergiocazzolato/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergiocazzolato/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergiocazzolato/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergiocazzolato/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergiocazzolato/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/sergiocazzolato/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergiocazzolato/snapd/merges","archive_url":"https://api.github.com/repos/sergiocazzolato/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergiocazzolato/snapd/downloads","issues_url":"https://api.github.com/repos/sergiocazzolato/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/sergiocazzolato/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/sergiocazzolato/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/sergiocazzolato/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergiocazzolato/snapd/labels{/name}","releases_url":"https://api.github.com/repos/sergiocazzolato/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/sergiocazzolato/snapd/deployments","created_at":"2017-05-22T23:10:59Z","updated_at":"2018-11-22T11:31:27Z","pushed_at":"2018-11-22T21:19:40Z","git_url":"git://github.com/sergiocazzolato/snapd.git","ssh_url":"git@github.com:sergiocazzolato/snapd.git","clone_url":"https://github.com/sergiocazzolato/snapd.git","svn_url":"https://github.com/sergiocazzolato/snapd","homepage":"","size":75991,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"fc365e1807b701a0c7ff9f2a31e6d22735b30c1a","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-11-23T13:54:42Z","pushed_at":"2018-11-23T13:54:30Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":75812,"stargazers_count":1047,"watchers_count":1047,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":263,"open_issues":61,"watchers":1047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6200"},"html":{"href":"https://github.com/snapcore/snapd/pull/6200"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6200"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6200/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6200/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6200/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/13f946f46333b9871ea6dda9d76103eb1fea1b57"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zyga"}}