{"action":"created","issue":{"url":"https://api.github.com/repos/percona/percona-server/issues/2329","repository_url":"https://api.github.com/repos/percona/percona-server","labels_url":"https://api.github.com/repos/percona/percona-server/issues/2329/labels{/name}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2329/comments","events_url":"https://api.github.com/repos/percona/percona-server/issues/2329/events","html_url":"https://github.com/percona/percona-server/pull/2329","id":315523622,"number":2329,"title":"Fix PS-3959 (Installing QRT plugins causes server crash) (5.6)","user":{"login":"percona-ysorokin","id":13441497,"avatar_url":"https://avatars1.githubusercontent.com/u/13441497?v=4","gravatar_id":"","url":"https://api.github.com/users/percona-ysorokin","html_url":"https://github.com/percona-ysorokin","followers_url":"https://api.github.com/users/percona-ysorokin/followers","following_url":"https://api.github.com/users/percona-ysorokin/following{/other_user}","gists_url":"https://api.github.com/users/percona-ysorokin/gists{/gist_id}","starred_url":"https://api.github.com/users/percona-ysorokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona-ysorokin/subscriptions","organizations_url":"https://api.github.com/users/percona-ysorokin/orgs","repos_url":"https://api.github.com/users/percona-ysorokin/repos","events_url":"https://api.github.com/users/percona-ysorokin/events{/privacy}","received_events_url":"https://api.github.com/users/percona-ysorokin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-18T15:12:08Z","updated_at":"2018-04-18T15:50:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2329","html_url":"https://github.com/percona/percona-server/pull/2329","diff_url":"https://github.com/percona/percona-server/pull/2329.diff","patch_url":"https://github.com/percona/percona-server/pull/2329.patch"},"body":"https://jira.percona.com/browse/PS-3959\r\n\r\nWhen only the audit part of the QRT plugin ('QUERY_RESPONSE_TIME_AUDIT') was\r\ninstalled\r\n\"INSTALL PLUGIN QUERY_RESPONSE_TIME_AUDIT SONAME 'query_response_time.so'\",\r\nserver used to crash in 'query_response_time_audit_notify()' as\r\n'session_stats' plugin session variable used in this function\r\nwas not registered by MySQL plugin loading system in THD. This used to happen\r\nbecause this variable was declared in another part of the same plugin -\r\n'QUERY_RESPONSE_TIME'.\r\n\r\nFixed by introducing a new global flag 'query_response_time_vars_initialized'\r\nindicating whether all the plugin variables from 'QUERY_RESPONSE_TIME' were\r\nregistered and initialized and it is safe to access them.\r\n\r\n'query_response_time_should_log()' now attempts to access 'session_stats'\r\nvariable only if this flag is set. If it is not set, its value considered to\r\nbe 'OFF'.\r\n\r\nIn addition, fixed problem with declaring 'session_stat_names' array\r\nwithout terminating 'NullS'.\r\n\r\nAdded new MTR test case 'query_response_time.install_query_response_time'\r\nwhich simulates the scenario reported in the original bug description."},"comment":{"url":"https://api.github.com/repos/percona/percona-server/issues/comments/382435616","html_url":"https://github.com/percona/percona-server/pull/2329#issuecomment-382435616","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2329","id":382435616,"user":{"login":"percona-ysorokin","id":13441497,"avatar_url":"https://avatars1.githubusercontent.com/u/13441497?v=4","gravatar_id":"","url":"https://api.github.com/users/percona-ysorokin","html_url":"https://github.com/percona-ysorokin","followers_url":"https://api.github.com/users/percona-ysorokin/followers","following_url":"https://api.github.com/users/percona-ysorokin/following{/other_user}","gists_url":"https://api.github.com/users/percona-ysorokin/gists{/gist_id}","starred_url":"https://api.github.com/users/percona-ysorokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona-ysorokin/subscriptions","organizations_url":"https://api.github.com/users/percona-ysorokin/orgs","repos_url":"https://api.github.com/users/percona-ysorokin/repos","events_url":"https://api.github.com/users/percona-ysorokin/events{/privacy}","received_events_url":"https://api.github.com/users/percona-ysorokin/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T15:50:53Z","updated_at":"2018-04-18T15:50:53Z","author_association":"CONTRIBUTOR","body":"Jenkins build link (--suite=query_response_time)\r\nhttps://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/2162/"}}
{"actor":{"display_login":"percona-ysorokin"}}