{"action":"created","comment":{"url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/comments/240809625","pull_request_review_id":183927120,"id":240809625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgwOTYyNQ==","diff_hunk":"@@ -0,0 +1,62 @@\n+\"\"\"\n+Service that periodically reports component heartbeats to Wavefront.\n+\n+@author Hao Song (songhao@vmware.com).\n+\"\"\"\n+\n+import time\n+import logging\n+from threading import Timer\n+from wavefront_sdk.common.constants import HEART_BEAT_METRIC, \\\n+    APPLICATION_TAG_KEY, CLUSTER_TAG_KEY, SERVICE_TAG_KEY, SHARD_TAG_KEY, \\\n+    COMPONENT_TAG_KEY, NULL_TAG_VAL\n+\n+logging.basicConfig(level=logging.INFO)\n+logger = logging.getLogger(__name__)\n+\n+\n+class HeartbeaterService:","path":"wavefront_sdk/common/heartbeater_service.py","position":18,"original_position":18,"commit_id":"93178f3ad77bc2ab428d14050cb1cd7d1b389dc4","original_commit_id":"93178f3ad77bc2ab428d14050cb1cd7d1b389dc4","user":{"login":"song-hao","id":7380836,"node_id":"MDQ6VXNlcjczODA4MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/7380836?v=4","gravatar_id":"","url":"https://api.github.com/users/song-hao","html_url":"https://github.com/song-hao","followers_url":"https://api.github.com/users/song-hao/followers","following_url":"https://api.github.com/users/song-hao/following{/other_user}","gists_url":"https://api.github.com/users/song-hao/gists{/gist_id}","starred_url":"https://api.github.com/users/song-hao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/song-hao/subscriptions","organizations_url":"https://api.github.com/users/song-hao/orgs","repos_url":"https://api.github.com/users/song-hao/repos","events_url":"https://api.github.com/users/song-hao/events{/privacy}","received_events_url":"https://api.github.com/users/song-hao/received_events","type":"User","site_admin":false},"body":"Hope we can drop it as well, will add explicit object inheritance","created_at":"2018-12-11T22:07:00Z","updated_at":"2018-12-11T22:07:00Z","html_url":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8#discussion_r240809625","pull_request_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/comments/240809625"},"html":{"href":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8#discussion_r240809625"},"pull_request":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8"}},"in_reply_to_id":240807500},"pull_request":{"url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8","id":237822565,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODIyNTY1","html_url":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8","diff_url":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8.diff","patch_url":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8.patch","issue_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/8","number":8,"state":"open","locked":false,"title":"Add application tags and hearbeater service","user":{"login":"song-hao","id":7380836,"node_id":"MDQ6VXNlcjczODA4MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/7380836?v=4","gravatar_id":"","url":"https://api.github.com/users/song-hao","html_url":"https://github.com/song-hao","followers_url":"https://api.github.com/users/song-hao/followers","following_url":"https://api.github.com/users/song-hao/following{/other_user}","gists_url":"https://api.github.com/users/song-hao/gists{/gist_id}","starred_url":"https://api.github.com/users/song-hao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/song-hao/subscriptions","organizations_url":"https://api.github.com/users/song-hao/orgs","repos_url":"https://api.github.com/users/song-hao/repos","events_url":"https://api.github.com/users/song-hao/events{/privacy}","received_events_url":"https://api.github.com/users/song-hao/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-11T20:49:41Z","updated_at":"2018-12-11T22:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1caaf5fc971f310909f39dc9ad353b6f34214200","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sushantdewan123","id":3233321,"node_id":"MDQ6VXNlcjMyMzMzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3233321?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantdewan123","html_url":"https://github.com/sushantdewan123","followers_url":"https://api.github.com/users/sushantdewan123/followers","following_url":"https://api.github.com/users/sushantdewan123/following{/other_user}","gists_url":"https://api.github.com/users/sushantdewan123/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdewan123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdewan123/subscriptions","organizations_url":"https://api.github.com/users/sushantdewan123/orgs","repos_url":"https://api.github.com/users/sushantdewan123/repos","events_url":"https://api.github.com/users/sushantdewan123/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdewan123/received_events","type":"User","site_admin":false},{"login":"vikramraman","id":8147253,"node_id":"MDQ6VXNlcjgxNDcyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8147253?v=4","gravatar_id":"","url":"https://api.github.com/users/vikramraman","html_url":"https://github.com/vikramraman","followers_url":"https://api.github.com/users/vikramraman/followers","following_url":"https://api.github.com/users/vikramraman/following{/other_user}","gists_url":"https://api.github.com/users/vikramraman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikramraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikramraman/subscriptions","organizations_url":"https://api.github.com/users/vikramraman/orgs","repos_url":"https://api.github.com/users/vikramraman/repos","events_url":"https://api.github.com/users/vikramraman/events{/privacy}","received_events_url":"https://api.github.com/users/vikramraman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8/commits","review_comments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8/comments","review_comment_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/8/comments","statuses_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/statuses/93178f3ad77bc2ab428d14050cb1cd7d1b389dc4","head":{"label":"wavefrontHQ:hao/application_tags","ref":"hao/application_tags","sha":"93178f3ad77bc2ab428d14050cb1cd7d1b389dc4","user":{"login":"wavefrontHQ","id":13057332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU3MzMy","avatar_url":"https://avatars3.githubusercontent.com/u/13057332?v=4","gravatar_id":"","url":"https://api.github.com/users/wavefrontHQ","html_url":"https://github.com/wavefrontHQ","followers_url":"https://api.github.com/users/wavefrontHQ/followers","following_url":"https://api.github.com/users/wavefrontHQ/following{/other_user}","gists_url":"https://api.github.com/users/wavefrontHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/wavefrontHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavefrontHQ/subscriptions","organizations_url":"https://api.github.com/users/wavefrontHQ/orgs","repos_url":"https://api.github.com/users/wavefrontHQ/repos","events_url":"https://api.github.com/users/wavefrontHQ/events{/privacy}","received_events_url":"https://api.github.com/users/wavefrontHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":144609774,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MDk3NzQ=","name":"wavefront-sdk-python","full_name":"wavefrontHQ/wavefront-sdk-python","private":false,"owner":{"login":"wavefrontHQ","id":13057332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU3MzMy","avatar_url":"https://avatars3.githubusercontent.com/u/13057332?v=4","gravatar_id":"","url":"https://api.github.com/users/wavefrontHQ","html_url":"https://github.com/wavefrontHQ","followers_url":"https://api.github.com/users/wavefrontHQ/followers","following_url":"https://api.github.com/users/wavefrontHQ/following{/other_user}","gists_url":"https://api.github.com/users/wavefrontHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/wavefrontHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavefrontHQ/subscriptions","organizations_url":"https://api.github.com/users/wavefrontHQ/orgs","repos_url":"https://api.github.com/users/wavefrontHQ/repos","events_url":"https://api.github.com/users/wavefrontHQ/events{/privacy}","received_events_url":"https://api.github.com/users/wavefrontHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wavefrontHQ/wavefront-sdk-python","description":"Wavefront Core Python SDK","fork":false,"url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python","forks_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/forks","keys_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/teams","hooks_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/hooks","issue_events_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/events{/number}","events_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/events","assignees_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/assignees{/user}","branches_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/branches{/branch}","tags_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/tags","blobs_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/statuses/{sha}","languages_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/languages","stargazers_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/stargazers","contributors_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/contributors","subscribers_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/subscribers","subscription_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/subscription","commits_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/contents/{+path}","compare_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/merges","archive_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/downloads","issues_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues{/number}","pulls_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls{/number}","milestones_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/milestones{/number}","notifications_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/labels{/name}","releases_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/releases{/id}","deployments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/deployments","created_at":"2018-08-13T17:07:20Z","updated_at":"2018-12-08T01:03:57Z","pushed_at":"2018-12-11T20:56:31Z","git_url":"git://github.com/wavefrontHQ/wavefront-sdk-python.git","ssh_url":"git@github.com:wavefrontHQ/wavefront-sdk-python.git","clone_url":"https://github.com/wavefrontHQ/wavefront-sdk-python.git","svn_url":"https://github.com/wavefrontHQ/wavefront-sdk-python","homepage":"","size":58,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"wavefrontHQ:master","ref":"master","sha":"8842a06045f406c2d34fe1b41597806b53ec0a8f","user":{"login":"wavefrontHQ","id":13057332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU3MzMy","avatar_url":"https://avatars3.githubusercontent.com/u/13057332?v=4","gravatar_id":"","url":"https://api.github.com/users/wavefrontHQ","html_url":"https://github.com/wavefrontHQ","followers_url":"https://api.github.com/users/wavefrontHQ/followers","following_url":"https://api.github.com/users/wavefrontHQ/following{/other_user}","gists_url":"https://api.github.com/users/wavefrontHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/wavefrontHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavefrontHQ/subscriptions","organizations_url":"https://api.github.com/users/wavefrontHQ/orgs","repos_url":"https://api.github.com/users/wavefrontHQ/repos","events_url":"https://api.github.com/users/wavefrontHQ/events{/privacy}","received_events_url":"https://api.github.com/users/wavefrontHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":144609774,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MDk3NzQ=","name":"wavefront-sdk-python","full_name":"wavefrontHQ/wavefront-sdk-python","private":false,"owner":{"login":"wavefrontHQ","id":13057332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU3MzMy","avatar_url":"https://avatars3.githubusercontent.com/u/13057332?v=4","gravatar_id":"","url":"https://api.github.com/users/wavefrontHQ","html_url":"https://github.com/wavefrontHQ","followers_url":"https://api.github.com/users/wavefrontHQ/followers","following_url":"https://api.github.com/users/wavefrontHQ/following{/other_user}","gists_url":"https://api.github.com/users/wavefrontHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/wavefrontHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavefrontHQ/subscriptions","organizations_url":"https://api.github.com/users/wavefrontHQ/orgs","repos_url":"https://api.github.com/users/wavefrontHQ/repos","events_url":"https://api.github.com/users/wavefrontHQ/events{/privacy}","received_events_url":"https://api.github.com/users/wavefrontHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wavefrontHQ/wavefront-sdk-python","description":"Wavefront Core Python SDK","fork":false,"url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python","forks_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/forks","keys_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/teams","hooks_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/hooks","issue_events_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/events{/number}","events_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/events","assignees_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/assignees{/user}","branches_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/branches{/branch}","tags_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/tags","blobs_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/statuses/{sha}","languages_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/languages","stargazers_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/stargazers","contributors_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/contributors","subscribers_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/subscribers","subscription_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/subscription","commits_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/contents/{+path}","compare_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/merges","archive_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/downloads","issues_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues{/number}","pulls_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls{/number}","milestones_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/milestones{/number}","notifications_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/labels{/name}","releases_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/releases{/id}","deployments_url":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/deployments","created_at":"2018-08-13T17:07:20Z","updated_at":"2018-12-08T01:03:57Z","pushed_at":"2018-12-11T20:56:31Z","git_url":"git://github.com/wavefrontHQ/wavefront-sdk-python.git","ssh_url":"git@github.com:wavefrontHQ/wavefront-sdk-python.git","clone_url":"https://github.com/wavefrontHQ/wavefront-sdk-python.git","svn_url":"https://github.com/wavefrontHQ/wavefront-sdk-python","homepage":"","size":58,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8"},"html":{"href":"https://github.com/wavefrontHQ/wavefront-sdk-python/pull/8"},"issue":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/8"},"comments":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/wavefrontHQ/wavefront-sdk-python/statuses/93178f3ad77bc2ab428d14050cb1cd7d1b389dc4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"song-hao"}}