{"action":"created","issue":{"url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/881","repository_url":"https://api.github.com/repos/web-platform-tests/wpt.fyi","labels_url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/881/labels{/name}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/881/comments","events_url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/881/events","html_url":"https://github.com/web-platform-tests/wpt.fyi/pull/881","id":388824086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDAxNTM4","number":881,"title":"Compare PR results against the results without changes","user":{"login":"Hexcles","id":1436812,"node_id":"MDQ6VXNlcjE0MzY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1436812?v=4","gravatar_id":"","url":"https://api.github.com/users/Hexcles","html_url":"https://github.com/Hexcles","followers_url":"https://api.github.com/users/Hexcles/followers","following_url":"https://api.github.com/users/Hexcles/following{/other_user}","gists_url":"https://api.github.com/users/Hexcles/gists{/gist_id}","starred_url":"https://api.github.com/users/Hexcles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hexcles/subscriptions","organizations_url":"https://api.github.com/users/Hexcles/orgs","repos_url":"https://api.github.com/users/Hexcles/repos","events_url":"https://api.github.com/users/Hexcles/events{/privacy}","received_events_url":"https://api.github.com/users/Hexcles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-07T21:41:30Z","updated_at":"2018-12-10T22:00:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/pulls/881","html_url":"https://github.com/web-platform-tests/wpt.fyi/pull/881","diff_url":"https://github.com/web-platform-tests/wpt.fyi/pull/881.diff","patch_url":"https://github.com/web-platform-tests/wpt.fyi/pull/881.patch"},"body":"## Description\r\n\r\nThe biggest changes are in `loadRunsToCompare` and `api/receiver/create_run.go`:\r\n* In `loadRunsToCompare`, we now need to handle the master runs and PR runs separately.\r\n* In `api/receiver/create_run.go`, we no longer schedule the results processing for runs with the label \"pr_base\"; otherwise, checks on PRs will be scheduled to be updated twice.\r\n\r\nFixes #708 .\r\n\r\n## Review Information\r\n\r\nPlease review commit by commit, as the second one is largely mechanical."},"comment":{"url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/comments/445990617","html_url":"https://github.com/web-platform-tests/wpt.fyi/pull/881#issuecomment-445990617","issue_url":"https://api.github.com/repos/web-platform-tests/wpt.fyi/issues/881","id":445990617,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTk5MDYxNw==","user":{"login":"Hexcles","id":1436812,"node_id":"MDQ6VXNlcjE0MzY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1436812?v=4","gravatar_id":"","url":"https://api.github.com/users/Hexcles","html_url":"https://github.com/Hexcles","followers_url":"https://api.github.com/users/Hexcles/followers","following_url":"https://api.github.com/users/Hexcles/following{/other_user}","gists_url":"https://api.github.com/users/Hexcles/gists{/gist_id}","starred_url":"https://api.github.com/users/Hexcles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hexcles/subscriptions","organizations_url":"https://api.github.com/users/Hexcles/orgs","repos_url":"https://api.github.com/users/Hexcles/repos","events_url":"https://api.github.com/users/Hexcles/events{/privacy}","received_events_url":"https://api.github.com/users/Hexcles/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T22:00:19Z","updated_at":"2018-12-10T22:00:19Z","author_association":"MEMBER","body":"@lukebjerring PTAL again (at the first commit). I didn't exactly follow your suggestions; instead, the logic is:\r\n\r\n0. Find the first (latest) run matching the spec.\r\n1. If the run has label \"master\", use it as the head run, find an earlier run as the base run to compare against.\r\n2. If the run has label \"pr_base\", use it as the base run, find another run matching the spec but also with label \"pr_head\" as the head run.\r\n3. If the run has label \"pr_head\", use it as the head run, find another run matching the spec but also with label \"pr_base\" as the base run.\r\n\r\n(1, 2, 3 are mutually exclusive.)"}}
{"actor":{"display_login":"Hexcles"}}