{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6431","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6431/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6431/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6431/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6431","id":287173810,"number":6431,"title":"Heat exchanger sizing changes","user":{"login":"drewyh","id":20280470,"avatar_url":"https://avatars1.githubusercontent.com/u/20280470?v=4","gravatar_id":"","url":"https://api.github.com/users/drewyh","html_url":"https://github.com/drewyh","followers_url":"https://api.github.com/users/drewyh/followers","following_url":"https://api.github.com/users/drewyh/following{/other_user}","gists_url":"https://api.github.com/users/drewyh/gists{/gist_id}","starred_url":"https://api.github.com/users/drewyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewyh/subscriptions","organizations_url":"https://api.github.com/users/drewyh/orgs","repos_url":"https://api.github.com/users/drewyh/repos","events_url":"https://api.github.com/users/drewyh/events{/privacy}","received_events_url":"https://api.github.com/users/drewyh/received_events","type":"User","site_admin":false},"labels":[{"id":837087400,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/NotIDDChange","name":"NotIDDChange","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7","html_url":"https://github.com/NREL/EnergyPlus/milestone/7","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7/labels","id":2668648,"number":7,"title":"EnergyPlus 8.9.0","description":"Tentative on the naming.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":51,"state":"open","created_at":"2017-07-29T02:49:31Z","updated_at":"2018-03-13T14:13:15Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-01-09T17:45:35Z","updated_at":"2018-03-14T01:05:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6431","html_url":"https://github.com/NREL/EnergyPlus/pull/6431","diff_url":"https://github.com/NREL/EnergyPlus/pull/6431.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6431.patch"},"body":"Pull request overview\r\n---------------------\r\nThis pull request changes the methodology for sizing the demand side flow rate for fluid to fluid heat exchangers. Previously the demand side flow rate was set equal to the supply side flow rate. However this meant that it did not take into account any differences in the fluid or temperature differences of the two loops. This is changed in this pull request to take this into account and includes tests for sizing of the HX.\r\n\r\nThe changes require that the demand side loop have a Sizing:Plant object if the demand side flow is to be autosized. This is a new requirement so may cause some errors in existing files.\r\n\r\nThis addresses the suggestion made in #6064.\r\n\r\n### Queries\r\n- When auto-sizing the HX, the temperature `DataGlobals::InitConvTemp` is used for calculating specific heat and density, which was based on the existing code for auto-sizing UA. There seems to be some inconsistency on how this is addressed in other plant items, e.g. boiler uses `DataGlobals::CWInitConvTemp` for density, and boiler outlet temperature for specific heat capacity. Is there any guidance on how this should be standardised across plant items?\r\n- I'm currently unsure how to set up a unit test for differing fluids between the supply and demand loops, any pointers would be helpful as this really should be part of the testing.\r\n- The HX model is run to determine the nominal capacity, however, if the HX is autosized for flows and UA then this may not be necessary?\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/372870377","html_url":"https://github.com/NREL/EnergyPlus/pull/6431#issuecomment-372870377","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6431","id":372870377,"user":{"login":"nrel-bot","id":7593710,"avatar_url":"https://avatars3.githubusercontent.com/u/7593710?v=4","gravatar_id":"","url":"https://api.github.com/users/nrel-bot","html_url":"https://github.com/nrel-bot","followers_url":"https://api.github.com/users/nrel-bot/followers","following_url":"https://api.github.com/users/nrel-bot/following{/other_user}","gists_url":"https://api.github.com/users/nrel-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/nrel-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrel-bot/subscriptions","organizations_url":"https://api.github.com/users/nrel-bot/orgs","repos_url":"https://api.github.com/users/nrel-bot/repos","events_url":"https://api.github.com/users/nrel-bot/events{/privacy}","received_events_url":"https://api.github.com/users/nrel-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T01:05:01Z","updated_at":"2018-03-14T01:05:01Z","author_association":"NONE","body":"@drewyh @lgentile it has been 14 days since this pull request was last updated."}}
{"actor":{"display_login":"nrel-bot"}}