{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments/180741877","pull_request_review_id":111211488,"id":180741877,"diff_hunk":"@@ -27,7 +27,8 @@ describe(test.label, function () {\n     this.on('selectAction', selectSpy)\n     this.setProperties({\n       hook: 'myListItemSelection',\n-      model: model\n+      model: model,\n+      singleSelection: false","path":"tests/integration/components/frost-list-item-selection-test.js","position":6,"original_position":6,"commit_id":"0fc5f7118e0b5c7a3f7c2e5cb5158210ae09f7a0","original_commit_id":"0fc5f7118e0b5c7a3f7c2e5cb5158210ae09f7a0","user":{"login":"notmessenger","id":435544,"avatar_url":"https://avatars1.githubusercontent.com/u/435544?v=4","gravatar_id":"","url":"https://api.github.com/users/notmessenger","html_url":"https://github.com/notmessenger","followers_url":"https://api.github.com/users/notmessenger/followers","following_url":"https://api.github.com/users/notmessenger/following{/other_user}","gists_url":"https://api.github.com/users/notmessenger/gists{/gist_id}","starred_url":"https://api.github.com/users/notmessenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notmessenger/subscriptions","organizations_url":"https://api.github.com/users/notmessenger/orgs","repos_url":"https://api.github.com/users/notmessenger/repos","events_url":"https://api.github.com/users/notmessenger/events{/privacy}","received_events_url":"https://api.github.com/users/notmessenger/received_events","type":"User","site_admin":false},"body":"With the specific setting of this property I am not seeing any test cases that are also ensuring that this value/behavior is `false` by default.  We should be testing the setting of it to `false` and `true` as is currently being done but ensuring that it is defaults to what is expected should be tested as well.\r\n\r\nNormally I would approach that via a unit test but it can be done in an integration test as well.","created_at":"2018-04-11T12:51:13Z","updated_at":"2018-04-11T12:54:00Z","html_url":"https://github.com/ciena-frost/ember-frost-list/pull/186#discussion_r180741877","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments/180741877"},"html":{"href":"https://github.com/ciena-frost/ember-frost-list/pull/186#discussion_r180741877"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186","id":180031427,"html_url":"https://github.com/ciena-frost/ember-frost-list/pull/186","diff_url":"https://github.com/ciena-frost/ember-frost-list/pull/186.diff","patch_url":"https://github.com/ciena-frost/ember-frost-list/pull/186.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/186","number":186,"state":"open","locked":false,"title":"Add always expanded and single selection","user":{"login":"twjohnston","id":22649340,"avatar_url":"https://avatars1.githubusercontent.com/u/22649340?v=4","gravatar_id":"","url":"https://api.github.com/users/twjohnston","html_url":"https://github.com/twjohnston","followers_url":"https://api.github.com/users/twjohnston/followers","following_url":"https://api.github.com/users/twjohnston/following{/other_user}","gists_url":"https://api.github.com/users/twjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/twjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twjohnston/subscriptions","organizations_url":"https://api.github.com/users/twjohnston/orgs","repos_url":"https://api.github.com/users/twjohnston/repos","events_url":"https://api.github.com/users/twjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/twjohnston/received_events","type":"User","site_admin":false},"body":"# Overview\r\n\r\n## Summary\r\nAdding two new optional parameters to `frost-list` to provide single-selection behavior and to force all items to always be expanded if they have expanded data.\r\n\r\n## Issue Number(s)\r\n* Closes #185\r\n\r\n## Screenshots or recordings\r\nSingle select:\r\n![ember-frost-list_testbed](https://user-images.githubusercontent.com/22649340/38439143-8f7c6dd6-39aa-11e8-9874-b7aa48ff2318.png)\r\n\r\nAlways expanded:\r\n![ember-frost-list_testbed](https://user-images.githubusercontent.com/22649340/38439208-cbd494f2-39aa-11e8-90ea-05831c9d3e8d.png)\r\n\r\n# Semver\r\n- [ ] #none#\r\n- [ ] #patch#\r\n- [x] #minor#\r\n- [ ] #major#\r\n\r\n# CHANGELOG\r\n- Add always expanded and single selection behaviors\r\n","created_at":"2018-04-06T19:14:10Z","updated_at":"2018-04-11T12:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e020dd6c1e25321c2340d5419aa2ee4d7776641","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/186/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/0fc5f7118e0b5c7a3f7c2e5cb5158210ae09f7a0","head":{"label":"twjohnston:expansion-and-single-select","ref":"expansion-and-single-select","sha":"0fc5f7118e0b5c7a3f7c2e5cb5158210ae09f7a0","user":{"login":"twjohnston","id":22649340,"avatar_url":"https://avatars1.githubusercontent.com/u/22649340?v=4","gravatar_id":"","url":"https://api.github.com/users/twjohnston","html_url":"https://github.com/twjohnston","followers_url":"https://api.github.com/users/twjohnston/followers","following_url":"https://api.github.com/users/twjohnston/following{/other_user}","gists_url":"https://api.github.com/users/twjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/twjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twjohnston/subscriptions","organizations_url":"https://api.github.com/users/twjohnston/orgs","repos_url":"https://api.github.com/users/twjohnston/repos","events_url":"https://api.github.com/users/twjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/twjohnston/received_events","type":"User","site_admin":false},"repo":{"id":127800918,"name":"ember-frost-list","full_name":"twjohnston/ember-frost-list","owner":{"login":"twjohnston","id":22649340,"avatar_url":"https://avatars1.githubusercontent.com/u/22649340?v=4","gravatar_id":"","url":"https://api.github.com/users/twjohnston","html_url":"https://github.com/twjohnston","followers_url":"https://api.github.com/users/twjohnston/followers","following_url":"https://api.github.com/users/twjohnston/following{/other_user}","gists_url":"https://api.github.com/users/twjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/twjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twjohnston/subscriptions","organizations_url":"https://api.github.com/users/twjohnston/orgs","repos_url":"https://api.github.com/users/twjohnston/repos","events_url":"https://api.github.com/users/twjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/twjohnston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twjohnston/ember-frost-list","description":"Breakin' down table-centric application views","fork":true,"url":"https://api.github.com/repos/twjohnston/ember-frost-list","forks_url":"https://api.github.com/repos/twjohnston/ember-frost-list/forks","keys_url":"https://api.github.com/repos/twjohnston/ember-frost-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twjohnston/ember-frost-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twjohnston/ember-frost-list/teams","hooks_url":"https://api.github.com/repos/twjohnston/ember-frost-list/hooks","issue_events_url":"https://api.github.com/repos/twjohnston/ember-frost-list/issues/events{/number}","events_url":"https://api.github.com/repos/twjohnston/ember-frost-list/events","assignees_url":"https://api.github.com/repos/twjohnston/ember-frost-list/assignees{/user}","branches_url":"https://api.github.com/repos/twjohnston/ember-frost-list/branches{/branch}","tags_url":"https://api.github.com/repos/twjohnston/ember-frost-list/tags","blobs_url":"https://api.github.com/repos/twjohnston/ember-frost-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twjohnston/ember-frost-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twjohnston/ember-frost-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/twjohnston/ember-frost-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twjohnston/ember-frost-list/statuses/{sha}","languages_url":"https://api.github.com/repos/twjohnston/ember-frost-list/languages","stargazers_url":"https://api.github.com/repos/twjohnston/ember-frost-list/stargazers","contributors_url":"https://api.github.com/repos/twjohnston/ember-frost-list/contributors","subscribers_url":"https://api.github.com/repos/twjohnston/ember-frost-list/subscribers","subscription_url":"https://api.github.com/repos/twjohnston/ember-frost-list/subscription","commits_url":"https://api.github.com/repos/twjohnston/ember-frost-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/twjohnston/ember-frost-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/twjohnston/ember-frost-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/twjohnston/ember-frost-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/twjohnston/ember-frost-list/contents/{+path}","compare_url":"https://api.github.com/repos/twjohnston/ember-frost-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twjohnston/ember-frost-list/merges","archive_url":"https://api.github.com/repos/twjohnston/ember-frost-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twjohnston/ember-frost-list/downloads","issues_url":"https://api.github.com/repos/twjohnston/ember-frost-list/issues{/number}","pulls_url":"https://api.github.com/repos/twjohnston/ember-frost-list/pulls{/number}","milestones_url":"https://api.github.com/repos/twjohnston/ember-frost-list/milestones{/number}","notifications_url":"https://api.github.com/repos/twjohnston/ember-frost-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twjohnston/ember-frost-list/labels{/name}","releases_url":"https://api.github.com/repos/twjohnston/ember-frost-list/releases{/id}","deployments_url":"https://api.github.com/repos/twjohnston/ember-frost-list/deployments","created_at":"2018-04-02T19:13:53Z","updated_at":"2018-04-02T19:13:55Z","pushed_at":"2018-04-10T14:57:47Z","git_url":"git://github.com/twjohnston/ember-frost-list.git","ssh_url":"git@github.com:twjohnston/ember-frost-list.git","clone_url":"https://github.com/twjohnston/ember-frost-list.git","svn_url":"https://github.com/twjohnston/ember-frost-list","homepage":"http://ciena-frost.github.io/ember-frost-list","size":11307,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"a728be25416f9eb19b0f4ab6b27f9b1f2b26a32e","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":51887742,"name":"ember-frost-list","full_name":"ciena-frost/ember-frost-list","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-list","description":"Breakin' down table-centric application views","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-list","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/deployments","created_at":"2016-02-17T02:28:53Z","updated_at":"2018-03-23T13:21:24Z","pushed_at":"2018-04-10T14:57:48Z","git_url":"git://github.com/ciena-frost/ember-frost-list.git","ssh_url":"git@github.com:ciena-frost/ember-frost-list.git","clone_url":"https://github.com/ciena-frost/ember-frost-list.git","svn_url":"https://github.com/ciena-frost/ember-frost-list","homepage":"http://ciena-frost.github.io/ember-frost-list","size":11284,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":24,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186"},"html":{"href":"https://github.com/ciena-frost/ember-frost-list/pull/186"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/186"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/0fc5f7118e0b5c7a3f7c2e5cb5158210ae09f7a0"}},"author_association":"NONE"}}
{"actor":{"display_login":"notmessenger"}}