{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/199498756","pull_request_review_id":133627235,"id":199498756,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQ5ODc1Ng==","diff_hunk":"@@ -0,0 +1,87 @@\n+# -*- coding: utf-8 -*-\n+'''\n+.. versionadded:: 2018.3.2\n+\n+Management of Dell DRAC\n+\n+The DRAC module is used to create and manage DRAC cards on Dell servers\n+\n+Ensure the property is set\n+\n+  .. code-block:: yaml\n+\n+  test:\n+    dracr.property:\n+       - properties:\n+           System.ServerOS.HostName: \"Pretty-server\"\n+           System.ServerOS.OSName: \"Ubuntu 16.04\"\n+       - admin_password: calvin\n+       - admin_root: myuser\n+       - host: 10.10.10.1\n+\n+'''\n+\n+from __future__ import absolute_import\n+\n+import salt.exceptions\n+\n+\n+def __virtual__():\n+    '''\n+    Ensure the racadm command is installed\n+    '''\n+    if salt.utils.which('racadm'):\n+        return True\n+\n+    return False\n+\n+\n+def property(properties, admin_username='root', admin_password='calvin', host=None, **kwargs):","path":"salt/states/dracr.py","position":39,"original_position":39,"commit_id":"073b29989516471fa894f0590228bc6ba77a2a1d","original_commit_id":"073b29989516471fa894f0590228bc6ba77a2a1d","user":{"login":"rallytime","id":6547906,"node_id":"MDQ6VXNlcjY1NDc5MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6547906?v=4","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"body":"What about `property_present` instead of just `property`? I think that is more inline with our state syntax.","created_at":"2018-07-02T13:35:10Z","updated_at":"2018-07-02T13:43:53Z","html_url":"https://github.com/saltstack/salt/pull/48148#discussion_r199498756","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/48148","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/199498756"},"html":{"href":"https://github.com/saltstack/salt/pull/48148#discussion_r199498756"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48148"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/48148","id":195139626,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTM5NjI2","html_url":"https://github.com/saltstack/salt/pull/48148","diff_url":"https://github.com/saltstack/salt/pull/48148.diff","patch_url":"https://github.com/saltstack/salt/pull/48148.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48148","number":48148,"state":"open","locked":false,"title":"property managment in dracr module + state","user":{"login":"johnybx","id":15018762,"node_id":"MDQ6VXNlcjE1MDE4NzYy","avatar_url":"https://avatars0.githubusercontent.com/u/15018762?v=4","gravatar_id":"","url":"https://api.github.com/users/johnybx","html_url":"https://github.com/johnybx","followers_url":"https://api.github.com/users/johnybx/followers","following_url":"https://api.github.com/users/johnybx/following{/other_user}","gists_url":"https://api.github.com/users/johnybx/gists{/gist_id}","starred_url":"https://api.github.com/users/johnybx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnybx/subscriptions","organizations_url":"https://api.github.com/users/johnybx/orgs","repos_url":"https://api.github.com/users/johnybx/repos","events_url":"https://api.github.com/users/johnybx/events{/privacy}","received_events_url":"https://api.github.com/users/johnybx/received_events","type":"User","site_admin":false},"body":"### New feature:\r\nAdds managment for properties in idrac and state for this case.\r\n\r\n```  test:\r\n    dracr.property:  \r\n       - properties:\r\n           System.ServerOS.HostName: \"Pretty-server\"\r\n           System.ServerOS.OSName: \"Ubuntu 16.04\"\r\n       - admin_password: calvin\r\n       - admin_root: myuser\r\n       - host: 10.10.10.1\r\n```\r\n\r\n","created_at":"2018-06-15T10:46:53Z","updated_at":"2018-07-02T13:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e76c18e8f1b87e5128a5ed46c002a37563b32fea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/48148/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/48148/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48148/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/073b29989516471fa894f0590228bc6ba77a2a1d","head":{"label":"johnybx:develop","ref":"develop","sha":"073b29989516471fa894f0590228bc6ba77a2a1d","user":{"login":"johnybx","id":15018762,"node_id":"MDQ6VXNlcjE1MDE4NzYy","avatar_url":"https://avatars0.githubusercontent.com/u/15018762?v=4","gravatar_id":"","url":"https://api.github.com/users/johnybx","html_url":"https://github.com/johnybx","followers_url":"https://api.github.com/users/johnybx/followers","following_url":"https://api.github.com/users/johnybx/following{/other_user}","gists_url":"https://api.github.com/users/johnybx/gists{/gist_id}","starred_url":"https://api.github.com/users/johnybx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnybx/subscriptions","organizations_url":"https://api.github.com/users/johnybx/orgs","repos_url":"https://api.github.com/users/johnybx/repos","events_url":"https://api.github.com/users/johnybx/events{/privacy}","received_events_url":"https://api.github.com/users/johnybx/received_events","type":"User","site_admin":false},"repo":{"id":137474694,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NzQ2OTQ=","name":"salt","full_name":"johnybx/salt","owner":{"login":"johnybx","id":15018762,"node_id":"MDQ6VXNlcjE1MDE4NzYy","avatar_url":"https://avatars0.githubusercontent.com/u/15018762?v=4","gravatar_id":"","url":"https://api.github.com/users/johnybx","html_url":"https://github.com/johnybx","followers_url":"https://api.github.com/users/johnybx/followers","following_url":"https://api.github.com/users/johnybx/following{/other_user}","gists_url":"https://api.github.com/users/johnybx/gists{/gist_id}","starred_url":"https://api.github.com/users/johnybx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnybx/subscriptions","organizations_url":"https://api.github.com/users/johnybx/orgs","repos_url":"https://api.github.com/users/johnybx/repos","events_url":"https://api.github.com/users/johnybx/events{/privacy}","received_events_url":"https://api.github.com/users/johnybx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnybx/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/johnybx/salt","forks_url":"https://api.github.com/repos/johnybx/salt/forks","keys_url":"https://api.github.com/repos/johnybx/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnybx/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnybx/salt/teams","hooks_url":"https://api.github.com/repos/johnybx/salt/hooks","issue_events_url":"https://api.github.com/repos/johnybx/salt/issues/events{/number}","events_url":"https://api.github.com/repos/johnybx/salt/events","assignees_url":"https://api.github.com/repos/johnybx/salt/assignees{/user}","branches_url":"https://api.github.com/repos/johnybx/salt/branches{/branch}","tags_url":"https://api.github.com/repos/johnybx/salt/tags","blobs_url":"https://api.github.com/repos/johnybx/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnybx/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnybx/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnybx/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnybx/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/johnybx/salt/languages","stargazers_url":"https://api.github.com/repos/johnybx/salt/stargazers","contributors_url":"https://api.github.com/repos/johnybx/salt/contributors","subscribers_url":"https://api.github.com/repos/johnybx/salt/subscribers","subscription_url":"https://api.github.com/repos/johnybx/salt/subscription","commits_url":"https://api.github.com/repos/johnybx/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnybx/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnybx/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnybx/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnybx/salt/contents/{+path}","compare_url":"https://api.github.com/repos/johnybx/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnybx/salt/merges","archive_url":"https://api.github.com/repos/johnybx/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnybx/salt/downloads","issues_url":"https://api.github.com/repos/johnybx/salt/issues{/number}","pulls_url":"https://api.github.com/repos/johnybx/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/johnybx/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/johnybx/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnybx/salt/labels{/name}","releases_url":"https://api.github.com/repos/johnybx/salt/releases{/id}","deployments_url":"https://api.github.com/repos/johnybx/salt/deployments","created_at":"2018-06-15T10:28:34Z","updated_at":"2018-07-01T13:28:44Z","pushed_at":"2018-07-01T13:28:38Z","git_url":"git://github.com/johnybx/salt.git","ssh_url":"git@github.com:johnybx/salt.git","clone_url":"https://github.com/johnybx/salt.git","svn_url":"https://github.com/johnybx/salt","homepage":"https://repo.saltstack.com/","size":406798,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"c61a58cb1e7ad52a1a4767e183455dde18805a8b","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-07-02T13:09:30Z","pushed_at":"2018-07-02T13:22:32Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":407247,"stargazers_count":8959,"watchers_count":8959,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4196,"mirror_url":null,"archived":false,"open_issues_count":3149,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4196,"open_issues":3149,"watchers":8959,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48148"},"html":{"href":"https://github.com/saltstack/salt/pull/48148"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/48148"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/48148/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48148/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48148/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/073b29989516471fa894f0590228bc6ba77a2a1d"}},"author_association":"NONE"}}
{"actor":{"display_login":"rallytime"}}