{"action":"created","issue":{"url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/4","repository_url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import","labels_url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/4/comments","events_url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/4/events","html_url":"https://github.com/fiduswriter/fiduswriter-citation-api-import/issues/4","id":319427909,"number":4,"title":"Several DOI URL variants possible","user":{"login":"katrinleinweber","id":9948149,"avatar_url":"https://avatars2.githubusercontent.com/u/9948149?v=4","gravatar_id":"","url":"https://api.github.com/users/katrinleinweber","html_url":"https://github.com/katrinleinweber","followers_url":"https://api.github.com/users/katrinleinweber/followers","following_url":"https://api.github.com/users/katrinleinweber/following{/other_user}","gists_url":"https://api.github.com/users/katrinleinweber/gists{/gist_id}","starred_url":"https://api.github.com/users/katrinleinweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katrinleinweber/subscriptions","organizations_url":"https://api.github.com/users/katrinleinweber/orgs","repos_url":"https://api.github.com/users/katrinleinweber/repos","events_url":"https://api.github.com/users/katrinleinweber/events{/privacy}","received_events_url":"https://api.github.com/users/katrinleinweber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-02T06:43:33Z","updated_at":"2018-05-02T07:16:50Z","closed_at":null,"author_association":"NONE","body":"Because of https://www.doi.org/doi_handbook/3_Resolution.html#3.8 there are most likely DOU URL variants floating around that have `https` or `http`, with or without `dx.`.\r\n\r\n1. Might this code section need a reg-ex to catch them all? Maybe `https://(dx\\.)?doi\\.org`?\r\n\r\nhttps://github.com/fiduswriter/fiduswriter-citation-api-import/blob/8b8803c140b563eff0d4083bb5973f03a7a5b775/citation-api-import/static/js/es6_modules/citation-api-import/templates.js#L120\r\n\r\n2. Also, [some statics links (in tests, I presume)](https://github.com/search?q=org%3Afiduswriter+dx.doi&type=Code) could be updated. Shall I?"},"comment":{"url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/comments/385886027","html_url":"https://github.com/fiduswriter/fiduswriter-citation-api-import/issues/4#issuecomment-385886027","issue_url":"https://api.github.com/repos/fiduswriter/fiduswriter-citation-api-import/issues/4","id":385886027,"user":{"login":"johanneswilm","id":595512,"avatar_url":"https://avatars2.githubusercontent.com/u/595512?v=4","gravatar_id":"","url":"https://api.github.com/users/johanneswilm","html_url":"https://github.com/johanneswilm","followers_url":"https://api.github.com/users/johanneswilm/followers","following_url":"https://api.github.com/users/johanneswilm/following{/other_user}","gists_url":"https://api.github.com/users/johanneswilm/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswilm/subscriptions","organizations_url":"https://api.github.com/users/johanneswilm/orgs","repos_url":"https://api.github.com/users/johanneswilm/repos","events_url":"https://api.github.com/users/johanneswilm/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswilm/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T07:16:50Z","updated_at":"2018-05-02T07:16:50Z","author_association":"OWNER","body":"@katrinleinweber Thanks! I had no idea about this.\r\n\r\nIn the case 1 you mention, we are replacing a value that comes from crossref. If I recall correctly we do that because when getting more information about the item, crossref expects it without the domain. I don't know if crossref has entries with other domains, but if it does, then yes, indeed, we need that updated!\r\n\r\nCase 2 are indeed, as you suspected, test cases. Most of those are \"real life\" test cases that we have come across over the years (it's end users' bibtex files) and we try to be as fault tolerant as possible with them. So it would probably be better to add more test cases rather than to \"fix\" existing ones. And yes, you are welcome to add those!"}}
{"actor":{"display_login":"johanneswilm"}}