{"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments/209744330","pull_request_review_id":145818164,"id":209744330,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc0NDMzMA==","diff_hunk":"@@ -113,9 +113,11 @@ namespace fc {\n     if( ve.size() )\n     {\n         memcpy(&bi, ve.data(), fc::min<size_t>(ve.size(),sizeof(bi)) );\n+    }else{\n+        for(size_t i=0;i<N;i++){\n+            bi.data[i]=T();","path":"include/fc/array.hpp","position":6,"original_position":6,"commit_id":"036fc196134c6037f14581aa2c09d038ecdc2cbc","original_commit_id":"036fc196134c6037f14581aa2c09d038ecdc2cbc","user":{"login":"pmconrad","id":6449255,"node_id":"MDQ6VXNlcjY0NDkyNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6449255?v=4","gravatar_id":"","url":"https://api.github.com/users/pmconrad","html_url":"https://github.com/pmconrad","followers_url":"https://api.github.com/users/pmconrad/followers","following_url":"https://api.github.com/users/pmconrad/following{/other_user}","gists_url":"https://api.github.com/users/pmconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/pmconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmconrad/subscriptions","organizations_url":"https://api.github.com/users/pmconrad/orgs","repos_url":"https://api.github.com/users/pmconrad/repos","events_url":"https://api.github.com/users/pmconrad/events{/privacy}","received_events_url":"https://api.github.com/users/pmconrad/received_events","type":"User","site_admin":false},"body":"This is a functional change, zeroing out something is not necessarily the same as invoking its no-arg constructor.\r\nIf the compile complains about memset'ing a class but not memcpy'ing it, memset an array of appropriate size and memcpy that. Still less efficient than the original though, anyone got a better idea?","created_at":"2018-08-13T20:18:09Z","updated_at":"2018-08-13T20:18:16Z","html_url":"https://github.com/bitshares/bitshares-fc/pull/75#discussion_r209744330","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments/209744330"},"html":{"href":"https://github.com/bitshares/bitshares-fc/pull/75#discussion_r209744330"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75","id":207969407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTY5NDA3","html_url":"https://github.com/bitshares/bitshares-fc/pull/75","diff_url":"https://github.com/bitshares/bitshares-fc/pull/75.diff","patch_url":"https://github.com/bitshares/bitshares-fc/pull/75.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/75","number":75,"state":"open","locked":false,"title":"Fix compile warnings","user":{"login":"cwyyprog","id":13314977,"node_id":"MDQ6VXNlcjEzMzE0OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/13314977?v=4","gravatar_id":"","url":"https://api.github.com/users/cwyyprog","html_url":"https://github.com/cwyyprog","followers_url":"https://api.github.com/users/cwyyprog/followers","following_url":"https://api.github.com/users/cwyyprog/following{/other_user}","gists_url":"https://api.github.com/users/cwyyprog/gists{/gist_id}","starred_url":"https://api.github.com/users/cwyyprog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwyyprog/subscriptions","organizations_url":"https://api.github.com/users/cwyyprog/orgs","repos_url":"https://api.github.com/users/cwyyprog/repos","events_url":"https://api.github.com/users/cwyyprog/events{/privacy}","received_events_url":"https://api.github.com/users/cwyyprog/received_events","type":"User","site_admin":false},"body":"get rid of some annoying warnings","created_at":"2018-08-13T12:59:16Z","updated_at":"2018-08-13T20:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c72c022778307266df959f872f4600990de542f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/75/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/036fc196134c6037f14581aa2c09d038ecdc2cbc","head":{"label":"cwyyprog:master","ref":"master","sha":"036fc196134c6037f14581aa2c09d038ecdc2cbc","user":{"login":"cwyyprog","id":13314977,"node_id":"MDQ6VXNlcjEzMzE0OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/13314977?v=4","gravatar_id":"","url":"https://api.github.com/users/cwyyprog","html_url":"https://github.com/cwyyprog","followers_url":"https://api.github.com/users/cwyyprog/followers","following_url":"https://api.github.com/users/cwyyprog/following{/other_user}","gists_url":"https://api.github.com/users/cwyyprog/gists{/gist_id}","starred_url":"https://api.github.com/users/cwyyprog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwyyprog/subscriptions","organizations_url":"https://api.github.com/users/cwyyprog/orgs","repos_url":"https://api.github.com/users/cwyyprog/repos","events_url":"https://api.github.com/users/cwyyprog/events{/privacy}","received_events_url":"https://api.github.com/users/cwyyprog/received_events","type":"User","site_admin":false},"repo":{"id":139224745,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyMjQ3NDU=","name":"bitshares-fc","full_name":"cwyyprog/bitshares-fc","owner":{"login":"cwyyprog","id":13314977,"node_id":"MDQ6VXNlcjEzMzE0OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/13314977?v=4","gravatar_id":"","url":"https://api.github.com/users/cwyyprog","html_url":"https://github.com/cwyyprog","followers_url":"https://api.github.com/users/cwyyprog/followers","following_url":"https://api.github.com/users/cwyyprog/following{/other_user}","gists_url":"https://api.github.com/users/cwyyprog/gists{/gist_id}","starred_url":"https://api.github.com/users/cwyyprog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwyyprog/subscriptions","organizations_url":"https://api.github.com/users/cwyyprog/orgs","repos_url":"https://api.github.com/users/cwyyprog/repos","events_url":"https://api.github.com/users/cwyyprog/events{/privacy}","received_events_url":"https://api.github.com/users/cwyyprog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwyyprog/bitshares-fc","description":"Fast-compiling C++ library","fork":true,"url":"https://api.github.com/repos/cwyyprog/bitshares-fc","forks_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/forks","keys_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/teams","hooks_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/hooks","issue_events_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/issues/events{/number}","events_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/events","assignees_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/assignees{/user}","branches_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/branches{/branch}","tags_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/tags","blobs_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/statuses/{sha}","languages_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/languages","stargazers_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/stargazers","contributors_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/contributors","subscribers_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/subscribers","subscription_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/subscription","commits_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/contents/{+path}","compare_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/merges","archive_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/downloads","issues_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/issues{/number}","pulls_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/pulls{/number}","milestones_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/milestones{/number}","notifications_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/labels{/name}","releases_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/releases{/id}","deployments_url":"https://api.github.com/repos/cwyyprog/bitshares-fc/deployments","created_at":"2018-06-30T06:21:43Z","updated_at":"2018-08-13T12:57:27Z","pushed_at":"2018-08-13T12:57:25Z","git_url":"git://github.com/cwyyprog/bitshares-fc.git","ssh_url":"git@github.com:cwyyprog/bitshares-fc.git","clone_url":"https://github.com/cwyyprog/bitshares-fc.git","svn_url":"https://github.com/cwyyprog/bitshares-fc","homepage":"","size":4931,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitshares:master","ref":"master","sha":"1a457caf3348024c245f3f32206717cff2e313e5","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":78883567,"node_id":"MDEwOlJlcG9zaXRvcnk3ODg4MzU2Nw==","name":"bitshares-fc","full_name":"bitshares/bitshares-fc","owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-fc","description":"Fast-compiling C++ library","fork":true,"url":"https://api.github.com/repos/bitshares/bitshares-fc","forks_url":"https://api.github.com/repos/bitshares/bitshares-fc/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-fc/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-fc/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-fc/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-fc/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-fc/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-fc/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-fc/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-fc/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-fc/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-fc/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-fc/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-fc/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-fc/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-fc/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-fc/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-fc/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-fc/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-fc/deployments","created_at":"2017-01-13T20:20:23Z","updated_at":"2018-08-13T14:17:23Z","pushed_at":"2018-08-13T14:17:25Z","git_url":"git://github.com/bitshares/bitshares-fc.git","ssh_url":"git@github.com:bitshares/bitshares-fc.git","clone_url":"https://github.com/bitshares/bitshares-fc.git","svn_url":"https://github.com/bitshares/bitshares-fc","homepage":"","size":4953,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":57,"open_issues":6,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75"},"html":{"href":"https://github.com/bitshares/bitshares-fc/pull/75"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/issues/75"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/036fc196134c6037f14581aa2c09d038ecdc2cbc"}},"author_association":"NONE"}}
{"actor":{"display_login":"pmconrad"}}