{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/19070","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/19070/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/19070/comments","events_url":"https://api.github.com/repos/apple/swift/issues/19070/events","html_url":"https://github.com/apple/swift/pull/19070","id":355755937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjEyNTE1","number":19070,"title":"[stdlib][DNM] Replace ArraySlice with Slice<Array>","user":{"login":"airspeedswift","id":8058277,"node_id":"MDQ6VXNlcjgwNTgyNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8058277?v=4","gravatar_id":"","url":"https://api.github.com/users/airspeedswift","html_url":"https://github.com/airspeedswift","followers_url":"https://api.github.com/users/airspeedswift/followers","following_url":"https://api.github.com/users/airspeedswift/following{/other_user}","gists_url":"https://api.github.com/users/airspeedswift/gists{/gist_id}","starred_url":"https://api.github.com/users/airspeedswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airspeedswift/subscriptions","organizations_url":"https://api.github.com/users/airspeedswift/orgs","repos_url":"https://api.github.com/users/airspeedswift/repos","events_url":"https://api.github.com/users/airspeedswift/events{/privacy}","received_events_url":"https://api.github.com/users/airspeedswift/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-30T21:11:39Z","updated_at":"2018-08-31T00:15:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19070","html_url":"https://github.com/apple/swift/pull/19070","diff_url":"https://github.com/apple/swift/pull/19070.diff","patch_url":"https://github.com/apple/swift/pull/19070.patch"},"body":"Very much a WIP, just looking at performance impact. This still needs generalized accessors to do properly without regressing some of the in-place operations `ArraySlice` has. But once `Slice` has a `subscript.modify` we might see regressions on this PR improve."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/417508499","html_url":"https://github.com/apple/swift/pull/19070#issuecomment-417508499","issue_url":"https://api.github.com/repos/apple/swift/issues/19070","id":417508499,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzUwODQ5OQ==","user":{"login":"swift-ci","id":15467072,"node_id":"MDQ6VXNlcjE1NDY3MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/15467072?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-ci","html_url":"https://github.com/swift-ci","followers_url":"https://api.github.com/users/swift-ci/followers","following_url":"https://api.github.com/users/swift-ci/following{/other_user}","gists_url":"https://api.github.com/users/swift-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-ci/subscriptions","organizations_url":"https://api.github.com/users/swift-ci/orgs","repos_url":"https://api.github.com/users/swift-ci/repos","events_url":"https://api.github.com/users/swift-ci/events{/privacy}","received_events_url":"https://api.github.com/users/swift-ci/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T00:15:32Z","updated_at":"2018-08-31T00:15:32Z","author_association":"CONTRIBUTOR","body":"Build comment file: \n--------------\n# Summary for master smoketest\n\n**Unexpected test results, excluded stats for Kingfisher, ReactiveCocoa**\n\n**Regressions found (see below)**\n\n- [Debug](#debug-5674cd79d5a3d29f)\n    - [debug brief](#debug-brief-5674cd79d5a3d29f)\n    - [debug detailed](#debug-detailed-5674cd79d5a3d29f)\n- [Release](#release-5674cd79d5a3d29f)\n    - [release brief](#release-brief-5674cd79d5a3d29f)\n    - [release detailed](#release-detailed-5674cd79d5a3d29f)\n\n\n\n<a name=\"debug-5674cd79d5a3d29f\">\n\n# Debug\n\n<a name=\"debug-brief-5674cd79d5a3d29f\">\n\n## debug brief\n<details>\n<summary>Regressed (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Improved (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (3)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nFrontend.NumInstructionsExecuted | 177,070,278,509 | 177,282,642,756 | 212,364,247 | 0.12%\nLLVM.NumLLVMBytesOutput | 9,382,640 | 9,374,352 | -8,288 | -0.09%\ntime.swift-driver.wall | 22.9s | 22.8s | -88.6ms | -0.39%\n</details>\n\n<a name=\"debug-detailed-5674cd79d5a3d29f\">\n\n## debug detailed\n<details>\n<summary>Regressed (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nSema.NumConformancesDeserialized | 32,824 | 33,425 | 601 | 1.83% :no_entry:\nSema.NumGenericSignatureBuilders | 11,526 | 11,743 | 217 | 1.88% :no_entry:\n</details>\n<details>\n<summary>Improved (1)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nIRModule.NumIRBasicBlocks | 31,504 | 31,165 | -339 | -1.08% :white_check_mark:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (20)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumImportedExternalDefinitions | 5,966 | 5,966 | 0 | 0.0%\nAST.NumLoadedModules | 1,510 | 1,510 | 0 | 0.0%\nAST.NumTotalClangImportedEntities | 18,342 | 18,342 | 0 | 0.0%\nAST.NumUsedConformances | 1,344 | 1,346 | 2 | 0.15%\nIRModule.NumIRFunctions | 17,269 | 17,273 | 4 | 0.02%\nIRModule.NumIRGlobals | 14,034 | 14,036 | 2 | 0.01%\nIRModule.NumIRInsts | 439,942 | 439,521 | -421 | -0.1%\nIRModule.NumIRValueSymbols | 29,496 | 29,502 | 6 | 0.02%\nLLVM.NumLLVMBytesOutput | 9,382,640 | 9,374,352 | -8,288 | -0.09%\nSILModule.NumSILGenFunctions | 7,967 | 7,967 | 0 | 0.0%\nSILModule.NumSILOptFunctions | 10,909 | 10,909 | 0 | 0.0%\nSema.NumConstraintScopes | 75,244 | 75,731 | 487 | 0.65%\nSema.NumDeclsDeserialized | 270,803 | 270,867 | 64 | 0.02%\nSema.NumDeclsValidated | 16,641 | 16,641 | 0 | 0.0%\nSema.NumFunctionsTypechecked | 7,085 | 7,085 | 0 | 0.0%\nSema.NumLazyGenericEnvironments | 53,681 | 54,014 | 333 | 0.62%\nSema.NumLazyGenericEnvironmentsLoaded | 6,168 | 6,184 | 16 | 0.26%\nSema.NumLazyIterableDeclContexts | 44,598 | 44,793 | 195 | 0.44%\nSema.NumTypesDeserialized | 121,601 | 122,440 | 839 | 0.69%\nSema.NumTypesValidated | 14,188 | 14,188 | 0 | 0.0%\n</details>\n\n<a name=\"release-5674cd79d5a3d29f\">\n\n# Release\n\n<a name=\"release-brief-5674cd79d5a3d29f\">\n\n## release brief\n<details>\n<summary>Regressed (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Improved (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nFrontend.NumInstructionsExecuted | 222,634,253,098 | 217,492,862,565 | -5,141,390,533 | -2.31% :white_check_mark:\ntime.swift-driver.wall | 39.7s | 38.6s | -1.1s | -2.82% :white_check_mark:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (1)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nLLVM.NumLLVMBytesOutput | 10,518,428 | 10,513,000 | -5,428 | -0.05%\n</details>\n\n<a name=\"release-detailed-5674cd79d5a3d29f\">\n\n## release detailed\n<details>\n<summary>Regressed (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nSema.NumConformancesDeserialized | 16,288 | 16,488 | 200 | 1.23% :no_entry:\nSema.NumGenericSignatureBuilders | 2,575 | 2,609 | 34 | 1.32% :no_entry:\n</details>\n<details>\n<summary>Improved (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nSema.NumDeclsDeserialized | 52,165 | 51,548 | -617 | -1.18% :white_check_mark:\nSema.NumLazyGenericEnvironments | 9,458 | 9,316 | -142 | -1.5% :white_check_mark:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (19)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumImportedExternalDefinitions | 1,385 | 1,385 | 0 | 0.0%\nAST.NumLoadedModules | 100 | 100 | 0 | 0.0%\nAST.NumTotalClangImportedEntities | 4,901 | 4,901 | 0 | 0.0%\nAST.NumUsedConformances | 1,346 | 1,348 | 2 | 0.15%\nIRModule.NumIRBasicBlocks | 34,282 | 34,254 | -28 | -0.08%\nIRModule.NumIRFunctions | 15,392 | 15,382 | -10 | -0.06%\nIRModule.NumIRGlobals | 13,540 | 13,540 | 0 | 0.0%\nIRModule.NumIRInsts | 334,067 | 333,887 | -180 | -0.05%\nIRModule.NumIRValueSymbols | 27,427 | 27,418 | -9 | -0.03%\nLLVM.NumLLVMBytesOutput | 10,518,428 | 10,513,000 | -5,428 | -0.05%\nSILModule.NumSILGenFunctions | 6,190 | 6,190 | 0 | 0.0%\nSILModule.NumSILOptFunctions | 9,229 | 9,173 | -56 | -0.61%\nSema.NumConstraintScopes | 73,804 | 74,291 | 487 | 0.66%\nSema.NumDeclsValidated | 10,362 | 10,362 | 0 | 0.0%\nSema.NumFunctionsTypechecked | 4,362 | 4,362 | 0 | 0.0%\nSema.NumLazyGenericEnvironmentsLoaded | 1,332 | 1,334 | 2 | 0.15%\nSema.NumLazyIterableDeclContexts | 5,818 | 5,852 | 34 | 0.58%\nSema.NumTypesDeserialized | 30,423 | 30,287 | -136 | -0.45%\nSema.NumTypesValidated | 7,103 | 7,103 | 0 | 0.0%\n</details>\n\n--------------\n"}}
{"actor":{"display_login":"swift-ci"}}