{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/208333704","pull_request_review_id":144107675,"id":208333704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMzMzcwNA==","diff_hunk":"@@ -53,67 +48,52 @@\n   private static final int LONG_WAIT_MS = 2 * 60 * 1000;\n   private static final int SHORT_WAIT_MS = 1;\n \n-  private static final String KEY = \"key\";\n-\n-  private String uniqueName;\n-  private String regionName;\n+  @ClassRule\n+  public static ServerStarterRule server = new ServerStarterRule().withAutoStart();","path":"geode-core/src/integrationTest/java/org/apache/geode/cache30/ShorteningExpirationTimeRegressionTest.java","position":42,"original_position":42,"commit_id":"17a38cd900cf70cde138e2a75ab5fa3a30760a22","original_commit_id":"17a38cd900cf70cde138e2a75ab5fa3a30760a22","user":{"login":"dschneider-pivotal","id":11197400,"node_id":"MDQ6VXNlcjExMTk3NDAw","avatar_url":"https://avatars0.githubusercontent.com/u/11197400?v=4","gravatar_id":"","url":"https://api.github.com/users/dschneider-pivotal","html_url":"https://github.com/dschneider-pivotal","followers_url":"https://api.github.com/users/dschneider-pivotal/followers","following_url":"https://api.github.com/users/dschneider-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/dschneider-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/dschneider-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschneider-pivotal/subscriptions","organizations_url":"https://api.github.com/users/dschneider-pivotal/orgs","repos_url":"https://api.github.com/users/dschneider-pivotal/repos","events_url":"https://api.github.com/users/dschneider-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/dschneider-pivotal/received_events","type":"User","site_admin":false},"body":"I like the old way this test setup and teared down the cache for each test.\r\nAny reason for changing that?\r\nI think your actual fix for this test was deleting line 100 which asserted that the value was \"quickExpire\" which might not be true because the expire could have already happened.\r\n\r\nI like the tests using the actual product APIs. The rules obscure what is happening. In this case I would guess that ServerStarterRule starts up a cache server which is overkill for this test. All this test needs is a cache.\r\n\r\nWhy switch to \"@ClassRule\" and \"@BeforeClass\"? Was it just to save some time? I guess that is okay.","created_at":"2018-08-07T18:16:02Z","updated_at":"2018-08-07T18:17:01Z","html_url":"https://github.com/apache/geode/pull/2265#discussion_r208333704","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/2265","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/208333704"},"html":{"href":"https://github.com/apache/geode/pull/2265#discussion_r208333704"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/2265"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2265","id":206518677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTE4Njc3","html_url":"https://github.com/apache/geode/pull/2265","diff_url":"https://github.com/apache/geode/pull/2265.diff","patch_url":"https://github.com/apache/geode/pull/2265.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2265","number":2265,"state":"open","locked":false,"title":"GEODE-5257: remove unnecessary assertion that introduced the flakiness.","user":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"body":"* the timeout is changed to 1ms after the 2nd put. If the assertion call happens 1ms after the 2nd put, the test would fail\r\n* remove boiler code using ServerStarterRule\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n- [ ] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2018-08-06T21:14:34Z","updated_at":"2018-08-07T18:17:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8613ef6139cc7b8bb1c9d8c4a138fd5f6998460c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"upthewaterspout","id":857521,"node_id":"MDQ6VXNlcjg1NzUyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/857521?v=4","gravatar_id":"","url":"https://api.github.com/users/upthewaterspout","html_url":"https://github.com/upthewaterspout","followers_url":"https://api.github.com/users/upthewaterspout/followers","following_url":"https://api.github.com/users/upthewaterspout/following{/other_user}","gists_url":"https://api.github.com/users/upthewaterspout/gists{/gist_id}","starred_url":"https://api.github.com/users/upthewaterspout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upthewaterspout/subscriptions","organizations_url":"https://api.github.com/users/upthewaterspout/orgs","repos_url":"https://api.github.com/users/upthewaterspout/repos","events_url":"https://api.github.com/users/upthewaterspout/events{/privacy}","received_events_url":"https://api.github.com/users/upthewaterspout/received_events","type":"User","site_admin":false},{"login":"kirklund","id":1444301,"node_id":"MDQ6VXNlcjE0NDQzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1444301?v=4","gravatar_id":"","url":"https://api.github.com/users/kirklund","html_url":"https://github.com/kirklund","followers_url":"https://api.github.com/users/kirklund/followers","following_url":"https://api.github.com/users/kirklund/following{/other_user}","gists_url":"https://api.github.com/users/kirklund/gists{/gist_id}","starred_url":"https://api.github.com/users/kirklund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirklund/subscriptions","organizations_url":"https://api.github.com/users/kirklund/orgs","repos_url":"https://api.github.com/users/kirklund/repos","events_url":"https://api.github.com/users/kirklund/events{/privacy}","received_events_url":"https://api.github.com/users/kirklund/received_events","type":"User","site_admin":false},{"login":"PurelyApplied","id":7175687,"node_id":"MDQ6VXNlcjcxNzU2ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},{"login":"kohlmu-pivotal","id":11528691,"node_id":"MDQ6VXNlcjExNTI4Njkx","avatar_url":"https://avatars2.githubusercontent.com/u/11528691?v=4","gravatar_id":"","url":"https://api.github.com/users/kohlmu-pivotal","html_url":"https://github.com/kohlmu-pivotal","followers_url":"https://api.github.com/users/kohlmu-pivotal/followers","following_url":"https://api.github.com/users/kohlmu-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/kohlmu-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/kohlmu-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohlmu-pivotal/subscriptions","organizations_url":"https://api.github.com/users/kohlmu-pivotal/orgs","repos_url":"https://api.github.com/users/kohlmu-pivotal/repos","events_url":"https://api.github.com/users/kohlmu-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/kohlmu-pivotal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2265/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2265/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2265/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/17a38cd900cf70cde138e2a75ab5fa3a30760a22","head":{"label":"jinmeiliao:quickExpire","ref":"quickExpire","sha":"17a38cd900cf70cde138e2a75ab5fa3a30760a22","user":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"repo":{"id":45697400,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY5NzQwMA==","name":"geode","full_name":"jinmeiliao/geode","owner":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jinmeiliao/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/jinmeiliao/geode","forks_url":"https://api.github.com/repos/jinmeiliao/geode/forks","keys_url":"https://api.github.com/repos/jinmeiliao/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jinmeiliao/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jinmeiliao/geode/teams","hooks_url":"https://api.github.com/repos/jinmeiliao/geode/hooks","issue_events_url":"https://api.github.com/repos/jinmeiliao/geode/issues/events{/number}","events_url":"https://api.github.com/repos/jinmeiliao/geode/events","assignees_url":"https://api.github.com/repos/jinmeiliao/geode/assignees{/user}","branches_url":"https://api.github.com/repos/jinmeiliao/geode/branches{/branch}","tags_url":"https://api.github.com/repos/jinmeiliao/geode/tags","blobs_url":"https://api.github.com/repos/jinmeiliao/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jinmeiliao/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jinmeiliao/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jinmeiliao/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jinmeiliao/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/jinmeiliao/geode/languages","stargazers_url":"https://api.github.com/repos/jinmeiliao/geode/stargazers","contributors_url":"https://api.github.com/repos/jinmeiliao/geode/contributors","subscribers_url":"https://api.github.com/repos/jinmeiliao/geode/subscribers","subscription_url":"https://api.github.com/repos/jinmeiliao/geode/subscription","commits_url":"https://api.github.com/repos/jinmeiliao/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jinmeiliao/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jinmeiliao/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jinmeiliao/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jinmeiliao/geode/contents/{+path}","compare_url":"https://api.github.com/repos/jinmeiliao/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jinmeiliao/geode/merges","archive_url":"https://api.github.com/repos/jinmeiliao/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jinmeiliao/geode/downloads","issues_url":"https://api.github.com/repos/jinmeiliao/geode/issues{/number}","pulls_url":"https://api.github.com/repos/jinmeiliao/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/jinmeiliao/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/jinmeiliao/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jinmeiliao/geode/labels{/name}","releases_url":"https://api.github.com/repos/jinmeiliao/geode/releases{/id}","deployments_url":"https://api.github.com/repos/jinmeiliao/geode/deployments","created_at":"2015-11-06T17:43:16Z","updated_at":"2016-12-06T16:17:21Z","pushed_at":"2018-08-07T17:23:34Z","git_url":"git://github.com/jinmeiliao/geode.git","ssh_url":"git@github.com:jinmeiliao/geode.git","clone_url":"https://github.com/jinmeiliao/geode.git","svn_url":"https://github.com/jinmeiliao/geode","homepage":"","size":132471,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"2c139a563b3d8931c26664ed9c54ac202579a438","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-08-07T18:12:41Z","pushed_at":"2018-08-07T18:12:36Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":158195,"stargazers_count":1300,"watchers_count":1300,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":456,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":456,"open_issues":23,"watchers":1300,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2265"},"html":{"href":"https://github.com/apache/geode/pull/2265"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2265"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2265/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2265/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2265/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/17a38cd900cf70cde138e2a75ab5fa3a30760a22"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dschneider-pivotal"}}