{"action":"created","comment":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments/227736146","pull_request_review_id":167841903,"id":227736146,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzczNjE0Ng==","diff_hunk":"@@ -30,5 +27,17 @@ public void GivenALearnerWithLearnRefNumberAndUln(string learnRefNumber, long ul\n         {\n             //TODO: TestSession now contains the learner, urkprn, etc. get rid of those ref numbers, etc","path":"src/SFA.DAS.Payments.RequiredPayments.AcceptanceTests/Steps/LearnerSteps.cs","position":29,"original_position":29,"commit_id":"6acd8b0724db04d76a4fe625a445078e080d7860","original_commit_id":"623870887b79191e683e0a27ead2c67d01016019","user":{"login":"kuzinator","id":5204772,"node_id":"MDQ6VXNlcjUyMDQ3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5204772?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzinator","html_url":"https://github.com/kuzinator","followers_url":"https://api.github.com/users/kuzinator/followers","following_url":"https://api.github.com/users/kuzinator/following{/other_user}","gists_url":"https://api.github.com/users/kuzinator/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzinator/subscriptions","organizations_url":"https://api.github.com/users/kuzinator/orgs","repos_url":"https://api.github.com/users/kuzinator/repos","events_url":"https://api.github.com/users/kuzinator/events{/privacy}","received_events_url":"https://api.github.com/users/kuzinator/received_events","type":"User","site_admin":false},"body":"I have populated this method instead of removing it. Now that we have multiple learners, it made sense to put single learner initialisation to this method instead of TestSession constructor","created_at":"2018-10-24T10:44:17Z","updated_at":"2018-10-24T10:44:18Z","html_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50#discussion_r227736146","pull_request_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments/227736146"},"html":{"href":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50#discussion_r227736146"},"pull_request":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50"}},"in_reply_to_id":227678871},"pull_request":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50","id":223998690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTk4Njkw","html_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50","diff_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50.diff","patch_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50.patch","issue_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/50","number":50,"state":"open","locked":false,"title":"PV2-197: 2 non levy learners finishes on time","user":{"login":"kuzinator","id":5204772,"node_id":"MDQ6VXNlcjUyMDQ3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5204772?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzinator","html_url":"https://github.com/kuzinator","followers_url":"https://api.github.com/users/kuzinator/followers","following_url":"https://api.github.com/users/kuzinator/following{/other_user}","gists_url":"https://api.github.com/users/kuzinator/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzinator/subscriptions","organizations_url":"https://api.github.com/users/kuzinator/orgs","repos_url":"https://api.github.com/users/kuzinator/repos","events_url":"https://api.github.com/users/kuzinator/events{/privacy}","received_events_url":"https://api.github.com/users/kuzinator/received_events","type":"User","site_admin":false},"body":"Payments due, Required payments and Funding source component tests for the story.\r\nAcceptance tests updated to find any events that shouldn't have been generated during scenario run.\r\n","created_at":"2018-10-18T15:21:17Z","updated_at":"2018-10-24T10:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d50cb5194d692499f83a30a2f02948bd11a862a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abroodie","id":2170720,"node_id":"MDQ6VXNlcjIxNzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2170720?v=4","gravatar_id":"","url":"https://api.github.com/users/abroodie","html_url":"https://github.com/abroodie","followers_url":"https://api.github.com/users/abroodie/followers","following_url":"https://api.github.com/users/abroodie/following{/other_user}","gists_url":"https://api.github.com/users/abroodie/gists{/gist_id}","starred_url":"https://api.github.com/users/abroodie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abroodie/subscriptions","organizations_url":"https://api.github.com/users/abroodie/orgs","repos_url":"https://api.github.com/users/abroodie/repos","events_url":"https://api.github.com/users/abroodie/events{/privacy}","received_events_url":"https://api.github.com/users/abroodie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50/commits","review_comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50/comments","review_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/50/comments","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/6acd8b0724db04d76a4fe625a445078e080d7860","head":{"label":"SkillsFundingAgency:PV2-197_2_non_levy_learners_finishes_OnTime","ref":"PV2-197_2_non_levy_learners_finishes_OnTime","sha":"6acd8b0724db04d76a4fe625a445078e080d7860","user":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":138287680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyODc2ODA=","name":"das-payments-V2","full_name":"SkillsFundingAgency/das-payments-V2","private":false,"owner":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkillsFundingAgency/das-payments-V2","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/deployments","created_at":"2018-06-22T10:06:34Z","updated_at":"2018-10-17T07:20:00Z","pushed_at":"2018-10-24T09:47:41Z","git_url":"git://github.com/SkillsFundingAgency/das-payments-V2.git","ssh_url":"git@github.com:SkillsFundingAgency/das-payments-V2.git","clone_url":"https://github.com/SkillsFundingAgency/das-payments-V2.git","svn_url":"https://github.com/SkillsFundingAgency/das-payments-V2","homepage":null,"size":1973,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SkillsFundingAgency:master","ref":"master","sha":"6f4cd7cb12b1ac8c7f8d9ad130d39d527bec989f","user":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":138287680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyODc2ODA=","name":"das-payments-V2","full_name":"SkillsFundingAgency/das-payments-V2","private":false,"owner":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkillsFundingAgency/das-payments-V2","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/deployments","created_at":"2018-06-22T10:06:34Z","updated_at":"2018-10-17T07:20:00Z","pushed_at":"2018-10-24T09:47:41Z","git_url":"git://github.com/SkillsFundingAgency/das-payments-V2.git","ssh_url":"git@github.com:SkillsFundingAgency/das-payments-V2.git","clone_url":"https://github.com/SkillsFundingAgency/das-payments-V2.git","svn_url":"https://github.com/SkillsFundingAgency/das-payments-V2","homepage":null,"size":1973,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50"},"html":{"href":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/50"},"issue":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/50"},"comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/6acd8b0724db04d76a4fe625a445078e080d7860"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kuzinator"}}