{"action":"opened","number":2329,"pull_request":{"url":"https://api.github.com/repos/throneteki/throneteki/pulls/2329","id":233246961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjQ2OTYx","html_url":"https://github.com/throneteki/throneteki/pull/2329","diff_url":"https://github.com/throneteki/throneteki/pull/2329.diff","patch_url":"https://github.com/throneteki/throneteki/pull/2329.patch","issue_url":"https://api.github.com/repos/throneteki/throneteki/issues/2329","number":2329,"state":"open","locked":false,"title":"Expire effects in reverse order","user":{"login":"ystros","id":145077,"node_id":"MDQ6VXNlcjE0NTA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/145077?v=4","gravatar_id":"","url":"https://api.github.com/users/ystros","html_url":"https://github.com/ystros","followers_url":"https://api.github.com/users/ystros/followers","following_url":"https://api.github.com/users/ystros/following{/other_user}","gists_url":"https://api.github.com/users/ystros/gists{/gist_id}","starred_url":"https://api.github.com/users/ystros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystros/subscriptions","organizations_url":"https://api.github.com/users/ystros/orgs","repos_url":"https://api.github.com/users/ystros/repos","events_url":"https://api.github.com/users/ystros/events{/privacy}","received_events_url":"https://api.github.com/users/ystros/received_events","type":"User","site_admin":false},"body":"Previously, lasting effects that buffed and then burned a character\r\ncould end up killing the character if they expired simultaneously. The\r\nSTR buff would expire first, putting the character at 0 STR and thus\r\nkilling the character before even attempting to expire the burn effect.\r\n\r\nNow, just as effects are applied in a specific order, they are expired\r\nin reverse order from which they were applied. This should ensure that\r\nnegative effects are expired first, preventing STR from improperly\r\nreaching 0 and thus killing the character.\r\n\r\nFixes #2328 \r\nFixes #1706 \r\n","created_at":"2018-11-23T16:40:26Z","updated_at":"2018-11-23T16:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/throneteki/throneteki/pulls/2329/commits","review_comments_url":"https://api.github.com/repos/throneteki/throneteki/pulls/2329/comments","review_comment_url":"https://api.github.com/repos/throneteki/throneteki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/throneteki/throneteki/issues/2329/comments","statuses_url":"https://api.github.com/repos/throneteki/throneteki/statuses/42a2a4fea3beb7a742ba24939227101f2b4512f9","head":{"label":"ystros:simultaneous-expiration","ref":"simultaneous-expiration","sha":"42a2a4fea3beb7a742ba24939227101f2b4512f9","user":{"login":"ystros","id":145077,"node_id":"MDQ6VXNlcjE0NTA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/145077?v=4","gravatar_id":"","url":"https://api.github.com/users/ystros","html_url":"https://github.com/ystros","followers_url":"https://api.github.com/users/ystros/followers","following_url":"https://api.github.com/users/ystros/following{/other_user}","gists_url":"https://api.github.com/users/ystros/gists{/gist_id}","starred_url":"https://api.github.com/users/ystros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystros/subscriptions","organizations_url":"https://api.github.com/users/ystros/orgs","repos_url":"https://api.github.com/users/ystros/repos","events_url":"https://api.github.com/users/ystros/events{/privacy}","received_events_url":"https://api.github.com/users/ystros/received_events","type":"User","site_admin":false},"repo":{"id":73194591,"node_id":"MDEwOlJlcG9zaXRvcnk3MzE5NDU5MQ==","name":"throneteki","full_name":"ystros/throneteki","private":false,"owner":{"login":"ystros","id":145077,"node_id":"MDQ6VXNlcjE0NTA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/145077?v=4","gravatar_id":"","url":"https://api.github.com/users/ystros","html_url":"https://github.com/ystros","followers_url":"https://api.github.com/users/ystros/followers","following_url":"https://api.github.com/users/ystros/following{/other_user}","gists_url":"https://api.github.com/users/ystros/gists{/gist_id}","starred_url":"https://api.github.com/users/ystros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystros/subscriptions","organizations_url":"https://api.github.com/users/ystros/orgs","repos_url":"https://api.github.com/users/ystros/repos","events_url":"https://api.github.com/users/ystros/events{/privacy}","received_events_url":"https://api.github.com/users/ystros/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ystros/throneteki","description":"Browser based A Game of Thrones LCG 2nd Edition","fork":true,"url":"https://api.github.com/repos/ystros/throneteki","forks_url":"https://api.github.com/repos/ystros/throneteki/forks","keys_url":"https://api.github.com/repos/ystros/throneteki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ystros/throneteki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ystros/throneteki/teams","hooks_url":"https://api.github.com/repos/ystros/throneteki/hooks","issue_events_url":"https://api.github.com/repos/ystros/throneteki/issues/events{/number}","events_url":"https://api.github.com/repos/ystros/throneteki/events","assignees_url":"https://api.github.com/repos/ystros/throneteki/assignees{/user}","branches_url":"https://api.github.com/repos/ystros/throneteki/branches{/branch}","tags_url":"https://api.github.com/repos/ystros/throneteki/tags","blobs_url":"https://api.github.com/repos/ystros/throneteki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ystros/throneteki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ystros/throneteki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ystros/throneteki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ystros/throneteki/statuses/{sha}","languages_url":"https://api.github.com/repos/ystros/throneteki/languages","stargazers_url":"https://api.github.com/repos/ystros/throneteki/stargazers","contributors_url":"https://api.github.com/repos/ystros/throneteki/contributors","subscribers_url":"https://api.github.com/repos/ystros/throneteki/subscribers","subscription_url":"https://api.github.com/repos/ystros/throneteki/subscription","commits_url":"https://api.github.com/repos/ystros/throneteki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ystros/throneteki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ystros/throneteki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ystros/throneteki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ystros/throneteki/contents/{+path}","compare_url":"https://api.github.com/repos/ystros/throneteki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ystros/throneteki/merges","archive_url":"https://api.github.com/repos/ystros/throneteki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ystros/throneteki/downloads","issues_url":"https://api.github.com/repos/ystros/throneteki/issues{/number}","pulls_url":"https://api.github.com/repos/ystros/throneteki/pulls{/number}","milestones_url":"https://api.github.com/repos/ystros/throneteki/milestones{/number}","notifications_url":"https://api.github.com/repos/ystros/throneteki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ystros/throneteki/labels{/name}","releases_url":"https://api.github.com/repos/ystros/throneteki/releases{/id}","deployments_url":"https://api.github.com/repos/ystros/throneteki/deployments","created_at":"2016-11-08T14:37:57Z","updated_at":"2018-10-20T17:01:37Z","pushed_at":"2018-11-23T16:35:57Z","git_url":"git://github.com/ystros/throneteki.git","ssh_url":"git@github.com:ystros/throneteki.git","clone_url":"https://github.com/ystros/throneteki.git","svn_url":"https://github.com/ystros/throneteki","homepage":"http://theironthrone.net","size":18543,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"throneteki:master","ref":"master","sha":"027de5921df7b1bc5dfc7e268649fec129af8928","user":{"login":"throneteki","id":39158992,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTU4OTky","avatar_url":"https://avatars2.githubusercontent.com/u/39158992?v=4","gravatar_id":"","url":"https://api.github.com/users/throneteki","html_url":"https://github.com/throneteki","followers_url":"https://api.github.com/users/throneteki/followers","following_url":"https://api.github.com/users/throneteki/following{/other_user}","gists_url":"https://api.github.com/users/throneteki/gists{/gist_id}","starred_url":"https://api.github.com/users/throneteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/throneteki/subscriptions","organizations_url":"https://api.github.com/users/throneteki/orgs","repos_url":"https://api.github.com/users/throneteki/repos","events_url":"https://api.github.com/users/throneteki/events{/privacy}","received_events_url":"https://api.github.com/users/throneteki/received_events","type":"Organization","site_admin":false},"repo":{"id":68015558,"node_id":"MDEwOlJlcG9zaXRvcnk2ODAxNTU1OA==","name":"throneteki","full_name":"throneteki/throneteki","private":false,"owner":{"login":"throneteki","id":39158992,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTU4OTky","avatar_url":"https://avatars2.githubusercontent.com/u/39158992?v=4","gravatar_id":"","url":"https://api.github.com/users/throneteki","html_url":"https://github.com/throneteki","followers_url":"https://api.github.com/users/throneteki/followers","following_url":"https://api.github.com/users/throneteki/following{/other_user}","gists_url":"https://api.github.com/users/throneteki/gists{/gist_id}","starred_url":"https://api.github.com/users/throneteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/throneteki/subscriptions","organizations_url":"https://api.github.com/users/throneteki/orgs","repos_url":"https://api.github.com/users/throneteki/repos","events_url":"https://api.github.com/users/throneteki/events{/privacy}","received_events_url":"https://api.github.com/users/throneteki/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/throneteki/throneteki","description":"Browser based A Game of Thrones LCG 2nd Edition","fork":false,"url":"https://api.github.com/repos/throneteki/throneteki","forks_url":"https://api.github.com/repos/throneteki/throneteki/forks","keys_url":"https://api.github.com/repos/throneteki/throneteki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/throneteki/throneteki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/throneteki/throneteki/teams","hooks_url":"https://api.github.com/repos/throneteki/throneteki/hooks","issue_events_url":"https://api.github.com/repos/throneteki/throneteki/issues/events{/number}","events_url":"https://api.github.com/repos/throneteki/throneteki/events","assignees_url":"https://api.github.com/repos/throneteki/throneteki/assignees{/user}","branches_url":"https://api.github.com/repos/throneteki/throneteki/branches{/branch}","tags_url":"https://api.github.com/repos/throneteki/throneteki/tags","blobs_url":"https://api.github.com/repos/throneteki/throneteki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/throneteki/throneteki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/throneteki/throneteki/git/refs{/sha}","trees_url":"https://api.github.com/repos/throneteki/throneteki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/throneteki/throneteki/statuses/{sha}","languages_url":"https://api.github.com/repos/throneteki/throneteki/languages","stargazers_url":"https://api.github.com/repos/throneteki/throneteki/stargazers","contributors_url":"https://api.github.com/repos/throneteki/throneteki/contributors","subscribers_url":"https://api.github.com/repos/throneteki/throneteki/subscribers","subscription_url":"https://api.github.com/repos/throneteki/throneteki/subscription","commits_url":"https://api.github.com/repos/throneteki/throneteki/commits{/sha}","git_commits_url":"https://api.github.com/repos/throneteki/throneteki/git/commits{/sha}","comments_url":"https://api.github.com/repos/throneteki/throneteki/comments{/number}","issue_comment_url":"https://api.github.com/repos/throneteki/throneteki/issues/comments{/number}","contents_url":"https://api.github.com/repos/throneteki/throneteki/contents/{+path}","compare_url":"https://api.github.com/repos/throneteki/throneteki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/throneteki/throneteki/merges","archive_url":"https://api.github.com/repos/throneteki/throneteki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/throneteki/throneteki/downloads","issues_url":"https://api.github.com/repos/throneteki/throneteki/issues{/number}","pulls_url":"https://api.github.com/repos/throneteki/throneteki/pulls{/number}","milestones_url":"https://api.github.com/repos/throneteki/throneteki/milestones{/number}","notifications_url":"https://api.github.com/repos/throneteki/throneteki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/throneteki/throneteki/labels{/name}","releases_url":"https://api.github.com/repos/throneteki/throneteki/releases{/id}","deployments_url":"https://api.github.com/repos/throneteki/throneteki/deployments","created_at":"2016-09-12T14:16:21Z","updated_at":"2018-11-23T02:49:21Z","pushed_at":"2018-11-22T21:02:15Z","git_url":"git://github.com/throneteki/throneteki.git","ssh_url":"git@github.com:throneteki/throneteki.git","clone_url":"https://github.com/throneteki/throneteki.git","svn_url":"https://github.com/throneteki/throneteki","homepage":"http://theironthrone.net","size":18198,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":98,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/throneteki/throneteki/pulls/2329"},"html":{"href":"https://github.com/throneteki/throneteki/pull/2329"},"issue":{"href":"https://api.github.com/repos/throneteki/throneteki/issues/2329"},"comments":{"href":"https://api.github.com/repos/throneteki/throneteki/issues/2329/comments"},"review_comments":{"href":"https://api.github.com/repos/throneteki/throneteki/pulls/2329/comments"},"review_comment":{"href":"https://api.github.com/repos/throneteki/throneteki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/throneteki/throneteki/pulls/2329/commits"},"statuses":{"href":"https://api.github.com/repos/throneteki/throneteki/statuses/42a2a4fea3beb7a742ba24939227101f2b4512f9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":66,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"ystros"}}