{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/170592591","pull_request_review_id":99299788,"id":170592591,"diff_hunk":"@@ -914,6 +914,16 @@ Type: Runtime\n \n This was never a documented feature.\n \n+<a id=\"DEP01XX\"></a>\n+### DEP01XX: process.env string coercion\n+\n+Type: Documentation-only (supports [`--pending-deprecation`][])","path":"doc/api/deprecations.md","position":7,"original_position":7,"commit_id":"21f1ba53f27e43167becf5e0af7c77e7159e7545","original_commit_id":"21f1ba53f27e43167becf5e0af7c77e7159e7545","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"I'd move the supports `--pending-deprecation` to the description below.","created_at":"2018-02-26T13:37:57Z","updated_at":"2018-02-26T13:40:51Z","html_url":"https://github.com/nodejs/node/pull/18990#discussion_r170592591","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/18990","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/170592591"},"html":{"href":"https://github.com/nodejs/node/pull/18990#discussion_r170592591"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/18990"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18990","id":171253664,"html_url":"https://github.com/nodejs/node/pull/18990","diff_url":"https://github.com/nodejs/node/pull/18990.diff","patch_url":"https://github.com/nodejs/node/pull/18990.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18990","number":18990,"state":"open","locked":false,"title":"process: doc-only deprecate non-string env value","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"body":"This PR provides an alternative approach to #18158 by deprecating the problematic behavior of `process.env` when a non-string is assigned to a property. I would like this deprecation to become Runtime in Node.js v11.\r\n\r\nRefs: https://github.com/nodejs/node/pull/15089\r\nRefs: https://github.com/nodejs/node/pull/18158\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nprocess","created_at":"2018-02-25T21:51:36Z","updated_at":"2018-02-26T13:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982f139776bea38a3c1bbf0e80e2c15ab8e531fe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":207521371,"url":"https://api.github.com/repos/nodejs/node/labels/process","name":"process","color":"00aaff","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false},{"id":678967957,"url":"https://api.github.com/repos/nodejs/node/labels/tsc-agenda","name":"tsc-agenda","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18990/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18990/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18990/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/21f1ba53f27e43167becf5e0af7c77e7159e7545","head":{"label":"TimothyGu:doc-deprecate-process-env-non-string","ref":"doc-deprecate-process-env-non-string","sha":"21f1ba53f27e43167becf5e0af7c77e7159e7545","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"repo":{"id":72949850,"name":"node","full_name":"TimothyGu/node","owner":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimothyGu/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/TimothyGu/node","forks_url":"https://api.github.com/repos/TimothyGu/node/forks","keys_url":"https://api.github.com/repos/TimothyGu/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimothyGu/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimothyGu/node/teams","hooks_url":"https://api.github.com/repos/TimothyGu/node/hooks","issue_events_url":"https://api.github.com/repos/TimothyGu/node/issues/events{/number}","events_url":"https://api.github.com/repos/TimothyGu/node/events","assignees_url":"https://api.github.com/repos/TimothyGu/node/assignees{/user}","branches_url":"https://api.github.com/repos/TimothyGu/node/branches{/branch}","tags_url":"https://api.github.com/repos/TimothyGu/node/tags","blobs_url":"https://api.github.com/repos/TimothyGu/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimothyGu/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimothyGu/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimothyGu/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimothyGu/node/statuses/{sha}","languages_url":"https://api.github.com/repos/TimothyGu/node/languages","stargazers_url":"https://api.github.com/repos/TimothyGu/node/stargazers","contributors_url":"https://api.github.com/repos/TimothyGu/node/contributors","subscribers_url":"https://api.github.com/repos/TimothyGu/node/subscribers","subscription_url":"https://api.github.com/repos/TimothyGu/node/subscription","commits_url":"https://api.github.com/repos/TimothyGu/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimothyGu/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimothyGu/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimothyGu/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimothyGu/node/contents/{+path}","compare_url":"https://api.github.com/repos/TimothyGu/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimothyGu/node/merges","archive_url":"https://api.github.com/repos/TimothyGu/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimothyGu/node/downloads","issues_url":"https://api.github.com/repos/TimothyGu/node/issues{/number}","pulls_url":"https://api.github.com/repos/TimothyGu/node/pulls{/number}","milestones_url":"https://api.github.com/repos/TimothyGu/node/milestones{/number}","notifications_url":"https://api.github.com/repos/TimothyGu/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimothyGu/node/labels{/name}","releases_url":"https://api.github.com/repos/TimothyGu/node/releases{/id}","deployments_url":"https://api.github.com/repos/TimothyGu/node/deployments","created_at":"2016-11-05T19:54:41Z","updated_at":"2016-11-05T19:55:03Z","pushed_at":"2018-02-25T23:55:40Z","git_url":"git://github.com/TimothyGu/node.git","ssh_url":"git@github.com:TimothyGu/node.git","clone_url":"https://github.com/TimothyGu/node.git","svn_url":"https://github.com/TimothyGu/node","homepage":"https://nodejs.org","size":328746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"da886d9a4cd923bd5fc33eff7df22ff7d855a00b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-02-26T13:25:50Z","pushed_at":"2018-02-26T13:24:24Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":349760,"stargazers_count":45802,"watchers_count":45802,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9600,"mirror_url":null,"archived":false,"open_issues_count":803,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9600,"open_issues":803,"watchers":45802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18990"},"html":{"href":"https://github.com/nodejs/node/pull/18990"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18990"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18990/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18990/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18990/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/21f1ba53f27e43167becf5e0af7c77e7159e7545"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasnell"}}