{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/167099594","pull_request_review_id":95270631,"id":167099594,"diff_hunk":"@@ -442,6 +442,10 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext\n \n   private _renderNormalItem(item: IContextualMenuItem, classNames: IMenuItemClassNames, index: number, focusableElementIndex: number, totalItemCount: number, hasCheckmarks: boolean, hasIcons: boolean): React.ReactNode {\n     if (item.onRender) {\n+      item.positionInSet = focusableElementIndex;","path":"packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.tsx","position":null,"original_position":4,"commit_id":"c7da45a2deadb897b699b8aba1fe076043553eda","original_commit_id":"b9c1e848328f524557686b8ff306ae6e73c8f90e","user":{"login":"chang47","id":5695630,"avatar_url":"https://avatars1.githubusercontent.com/u/5695630?v=4","gravatar_id":"","url":"https://api.github.com/users/chang47","html_url":"https://github.com/chang47","followers_url":"https://api.github.com/users/chang47/followers","following_url":"https://api.github.com/users/chang47/following{/other_user}","gists_url":"https://api.github.com/users/chang47/gists{/gist_id}","starred_url":"https://api.github.com/users/chang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang47/subscriptions","organizations_url":"https://api.github.com/users/chang47/orgs","repos_url":"https://api.github.com/users/chang47/repos","events_url":"https://api.github.com/users/chang47/events{/privacy}","received_events_url":"https://api.github.com/users/chang47/received_events","type":"User","site_admin":false},"body":"Perfect, I switched to use the spread operator.","created_at":"2018-02-08T23:26:23Z","updated_at":"2018-02-08T23:26:23Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878#discussion_r167099594","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/167099594"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878#discussion_r167099594"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878"}},"in_reply_to_id":166089765},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878","id":166937785,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3878","number":3878,"state":"open","locked":false,"title":"Contextual Menu Item - Passing Extra Information For MenuItem OnRender","user":{"login":"chang47","id":5695630,"avatar_url":"https://avatars1.githubusercontent.com/u/5695630?v=4","gravatar_id":"","url":"https://api.github.com/users/chang47","html_url":"https://github.com/chang47","followers_url":"https://api.github.com/users/chang47/followers","following_url":"https://api.github.com/users/chang47/following{/other_user}","gists_url":"https://api.github.com/users/chang47/gists{/gist_id}","starred_url":"https://api.github.com/users/chang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang47/subscriptions","organizations_url":"https://api.github.com/users/chang47/orgs","repos_url":"https://api.github.com/users/chang47/repos","events_url":"https://api.github.com/users/chang47/events{/privacy}","received_events_url":"https://api.github.com/users/chang47/received_events","type":"User","site_admin":false},"body":"#### Description of changes\r\n\r\nWhen we're rendering other types of menu item in our ContextualMenu we expose certain information like the current index or the total number of items in a contextual menu.\r\n\r\nWe currently don't expose these values to our Menu Items when we let them use their own custom onRender(). As a result we miss information that we might need. \r\n\r\nThe specific scenario for this is when we need to set the aria-setsize and aria-posinset for custom onRender() for the swatchcolorpicker and fullgallery menu items in the contextual menu but we don't have the information to set these values correctly.\r\n","created_at":"2018-02-03T01:23:35Z","updated_at":"2018-02-08T23:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f7935225dbcdcb9aeea7d8a0f2efd69f75e0939","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3878/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/c7da45a2deadb897b699b8aba1fe076043553eda","head":{"label":"chang47:accContextualMenu","ref":"accContextualMenu","sha":"c7da45a2deadb897b699b8aba1fe076043553eda","user":{"login":"chang47","id":5695630,"avatar_url":"https://avatars1.githubusercontent.com/u/5695630?v=4","gravatar_id":"","url":"https://api.github.com/users/chang47","html_url":"https://github.com/chang47","followers_url":"https://api.github.com/users/chang47/followers","following_url":"https://api.github.com/users/chang47/following{/other_user}","gists_url":"https://api.github.com/users/chang47/gists{/gist_id}","starred_url":"https://api.github.com/users/chang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang47/subscriptions","organizations_url":"https://api.github.com/users/chang47/orgs","repos_url":"https://api.github.com/users/chang47/repos","events_url":"https://api.github.com/users/chang47/events{/privacy}","received_events_url":"https://api.github.com/users/chang47/received_events","type":"User","site_admin":false},"repo":{"id":110761299,"name":"office-ui-fabric-react","full_name":"chang47/office-ui-fabric-react","owner":{"login":"chang47","id":5695630,"avatar_url":"https://avatars1.githubusercontent.com/u/5695630?v=4","gravatar_id":"","url":"https://api.github.com/users/chang47","html_url":"https://github.com/chang47","followers_url":"https://api.github.com/users/chang47/followers","following_url":"https://api.github.com/users/chang47/following{/other_user}","gists_url":"https://api.github.com/users/chang47/gists{/gist_id}","starred_url":"https://api.github.com/users/chang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang47/subscriptions","organizations_url":"https://api.github.com/users/chang47/orgs","repos_url":"https://api.github.com/users/chang47/repos","events_url":"https://api.github.com/users/chang47/events{/privacy}","received_events_url":"https://api.github.com/users/chang47/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chang47/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/chang47/office-ui-fabric-react","forks_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/chang47/office-ui-fabric-react/deployments","created_at":"2017-11-15T00:18:57Z","updated_at":"2017-11-15T00:19:02Z","pushed_at":"2018-02-08T23:24:10Z","git_url":"git://github.com/chang47/office-ui-fabric-react.git","ssh_url":"git@github.com:chang47/office-ui-fabric-react.git","clone_url":"https://github.com/chang47/office-ui-fabric-react.git","svn_url":"https://github.com/chang47/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":22007,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"fe1c0f061947e66f1a3c63b168cdfecdc282b39b","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-02-08T15:35:59Z","pushed_at":"2018-02-08T23:24:11Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":23051,"stargazers_count":2259,"watchers_count":2259,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":454,"mirror_url":null,"archived":false,"open_issues_count":462,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":454,"open_issues":462,"watchers":2259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3878"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3878"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3878/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3878/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/c7da45a2deadb897b699b8aba1fe076043553eda"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chang47"}}