{"action":"created","comment":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/222371656","pull_request_review_id":161240408,"id":222371656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM3MTY1Ng==","diff_hunk":"@@ -113,6 +113,116 @@ private with sharing class BDI_DataImportService_TEST {\n         }\n     }\n \n+    /*******************************************************************************************************************\n+    * @description Verifies correct working using the custom metadata instead of help text.\n+    *\n+    */\n+    @isTest\n+    private static void useCustomMetatadaInsteadOfHelpText() {\n+\n+        List<DataImport__c> dataImports = new List<DataImport__c>();\n+\n+        BDISettings__c bdiSettings = BDISettings__c.getOrgDefaults();\n+\n+        bdiSettings.UseCustomMetadatainsteadOfHelpText__c = true;\n+\n+        upsert bdiSettings;\n+\n+        Boolean isDryRun = false;\n+\n+        BDI_DataImportService service = new BDI_DataImportService(isDryRun);\n+\n+        DataImport__c firstDataImport = new DataImport__c(\n+           Contact1_Firstname__c = 'John',\n+           Contact1_Lastname__c = 'Doe',\n+           Contact1_Personal_Email__c = 'john@doe.com'\n+        );\n+\n+        DataImport__c secondDataImport = new DataImport__c(\n+           Contact1_Firstname__c = 'John',\n+           Contact1_Lastname__c = 'Doe',\n+           Contact1_Personal_Email__c = 'john@doe.com'\n+        );\n+\n+        dataImports.add(firstDataImport);\n+        dataImports.add(secondDataImport);\n+\n+        insert dataImports;\n+\n+        System.assertEquals(firstDataImport.status__c,  null);\n+        System.assertEquals(secondDataImport.status__c, null);\n+\n+        //run batch data import\n+        Test.StartTest();","path":"src/classes/BDI_DataImportService_TEST.cls","position":null,"original_position":53,"commit_id":"d8cf7aa6b4c0bc31fea3d04a8ecf668538ded99d","original_commit_id":"e3c893c172be16440eccc89a7b2355bd6fa5e555","user":{"login":"randi274","id":9795193,"node_id":"MDQ6VXNlcjk3OTUxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/9795193?v=4","gravatar_id":"","url":"https://api.github.com/users/randi274","html_url":"https://github.com/randi274","followers_url":"https://api.github.com/users/randi274/followers","following_url":"https://api.github.com/users/randi274/following{/other_user}","gists_url":"https://api.github.com/users/randi274/gists{/gist_id}","starred_url":"https://api.github.com/users/randi274/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randi274/subscriptions","organizations_url":"https://api.github.com/users/randi274/orgs","repos_url":"https://api.github.com/users/randi274/repos","events_url":"https://api.github.com/users/randi274/events{/privacy}","received_events_url":"https://api.github.com/users/randi274/received_events","type":"User","site_admin":false},"body":"Verified.","created_at":"2018-10-03T16:08:11Z","updated_at":"2018-10-03T16:20:45Z","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3672#discussion_r222371656","pull_request_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/222371656"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3672#discussion_r222371656"},"pull_request":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672"}},"in_reply_to_id":221398124},"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672","id":219058897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDU4ODk3","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3672","diff_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3672.diff","patch_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3672.patch","issue_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3672","number":3672,"state":"open","locked":false,"title":"W-028603 BDI mapping refactor Proof of concept","user":{"login":"mdeleon0","id":17030909,"node_id":"MDQ6VXNlcjE3MDMwOTA5","avatar_url":"https://avatars3.githubusercontent.com/u/17030909?v=4","gravatar_id":"","url":"https://api.github.com/users/mdeleon0","html_url":"https://github.com/mdeleon0","followers_url":"https://api.github.com/users/mdeleon0/followers","following_url":"https://api.github.com/users/mdeleon0/following{/other_user}","gists_url":"https://api.github.com/users/mdeleon0/gists{/gist_id}","starred_url":"https://api.github.com/users/mdeleon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdeleon0/subscriptions","organizations_url":"https://api.github.com/users/mdeleon0/orgs","repos_url":"https://api.github.com/users/mdeleon0/repos","events_url":"https://api.github.com/users/mdeleon0/events{/privacy}","received_events_url":"https://api.github.com/users/mdeleon0/received_events","type":"User","site_admin":false},"body":"# Critical Changes\r\nModified class BDI_DataImportService\r\n# Changes\r\nCreated Custom Setting \"BDI Settings\"\r\nCreated Custom Metadata \"BDI Field Mapping\"\r\n# Issues Closed\r\nhttps://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x80000007fNzmAAE/view\r\n# New Metadata\r\nBDI Settings\r\nBDI Field Mapping\r\n# Deleted Metadata\r\nNO","created_at":"2018-09-28T19:05:26Z","updated_at":"2018-10-03T16:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fe81c5ebe9bb701f046135d94d6a86e490a865b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672/commits","review_comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672/comments","review_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3672/comments","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/d8cf7aa6b4c0bc31fea3d04a8ecf668538ded99d","head":{"label":"SalesforceFoundation:feature/BGE-LC__Refactor_BDI_field_mappings_as_Custom_Metadata_Types","ref":"feature/BGE-LC__Refactor_BDI_field_mappings_as_Custom_Metadata_Types","sha":"d8cf7aa6b4c0bc31fea3d04a8ecf668538ded99d","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-10-02T21:30:53Z","pushed_at":"2018-10-03T15:37:13Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":92288,"stargazers_count":274,"watchers_count":274,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":202,"open_issues":317,"watchers":274,"default_branch":"master"}},"base":{"label":"SalesforceFoundation:feature/BGE-LC","ref":"feature/BGE-LC","sha":"2c06a719d1414d8bbc7b8a94a56359586d65806b","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-10-02T21:30:53Z","pushed_at":"2018-10-03T15:37:13Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":92288,"stargazers_count":274,"watchers_count":274,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":202,"open_issues":317,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3672"},"issue":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3672"},"comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3672/comments"},"review_comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672/comments"},"review_comment":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3672/commits"},"statuses":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/d8cf7aa6b4c0bc31fea3d04a8ecf668538ded99d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"randi274"}}