{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3781","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3781/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3781/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3781/events","html_url":"https://github.com/codice/ddf/pull/3781","id":363263777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzQ0NTYx","number":3781,"title":"DDF-4160 Update Basic Search Form to use configurable attribute for type","user":{"login":"andrewzimmer","id":39923178,"node_id":"MDQ6VXNlcjM5OTIzMTc4","avatar_url":"https://avatars3.githubusercontent.com/u/39923178?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewzimmer","html_url":"https://github.com/andrewzimmer","followers_url":"https://api.github.com/users/andrewzimmer/followers","following_url":"https://api.github.com/users/andrewzimmer/following{/other_user}","gists_url":"https://api.github.com/users/andrewzimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewzimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewzimmer/subscriptions","organizations_url":"https://api.github.com/users/andrewzimmer/orgs","repos_url":"https://api.github.com/users/andrewzimmer/repos","events_url":"https://api.github.com/users/andrewzimmer/events{/privacy}","received_events_url":"https://api.github.com/users/andrewzimmer/received_events","type":"User","site_admin":false},"labels":[{"id":1068890027,"node_id":"MDU6TGFiZWwxMDY4ODkwMDI3","url":"https://api.github.com/repos/codice/ddf/labels/Impacts%20Downstream","name":"Impacts Downstream","color":"f47944","default":false}],"state":"open","locked":false,"assignee":{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},"assignees":[{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-09-24T18:20:22Z","updated_at":"2018-09-27T19:56:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3781","html_url":"https://github.com/codice/ddf/pull/3781","diff_url":"https://github.com/codice/ddf/pull/3781.diff","patch_url":"https://github.com/codice/ddf/pull/3781.patch"},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nUpdate Basic Search Form to use configurable attribute for type; right now it is hardcoded to use the datatype attribute.\r\n#### Who is reviewing it? \r\n@bdeining @Bdthomson @alanchampion \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@andrewkfiedler\r\n@djblue\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\n- build/run\r\n- Run a Basic Search with a specific Match Type selected \r\n- verify type selected was searched with \"datatype\" and \"metadata-content-type\" \r\n<img width=\"972\" alt=\"screen shot 2018-09-24 at 12 17 30 pm\" src=\"https://user-images.githubusercontent.com/39923178/45970481-d79aba80-bff3-11e8-8c42-bc469a3551f8.png\">\r\n\r\n- in Admin search ui config set Basic Search Match Type Metacard Attribute to a valid metacard attribute\r\n<img width=\"1025\" alt=\"screen shot 2018-09-24 at 12 09 42 pm\" src=\"https://user-images.githubusercontent.com/39923178/45970278-57745500-bff3-11e8-965a-8cf62b0f8cfc.png\">\r\n\r\n- run another search and verify type selected was searched with \"metadata-content-type\" and the attribute set in admin config\r\n- in Admin search ui config set Basic Search Match Type Metacard Attribute to an invalid metacard attribute\r\n- run another search and verify type selected was searched with \"metadata-content-type\" and \"datatype\"\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4160](https://codice.atlassian.net/browse/DDF-4160)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/425222378","html_url":"https://github.com/codice/ddf/pull/3781#issuecomment-425222378","issue_url":"https://api.github.com/repos/codice/ddf/issues/3781","id":425222378,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTIyMjM3OA==","user":{"login":"Bdthomson","id":7236299,"node_id":"MDQ6VXNlcjcyMzYyOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7236299?v=4","gravatar_id":"","url":"https://api.github.com/users/Bdthomson","html_url":"https://github.com/Bdthomson","followers_url":"https://api.github.com/users/Bdthomson/followers","following_url":"https://api.github.com/users/Bdthomson/following{/other_user}","gists_url":"https://api.github.com/users/Bdthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/Bdthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bdthomson/subscriptions","organizations_url":"https://api.github.com/users/Bdthomson/orgs","repos_url":"https://api.github.com/users/Bdthomson/repos","events_url":"https://api.github.com/users/Bdthomson/events{/privacy}","received_events_url":"https://api.github.com/users/Bdthomson/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T19:56:16Z","updated_at":"2018-09-27T19:56:16Z","author_association":"CONTRIBUTOR","body":"build now"}}
{"actor":{"display_login":"Bdthomson"}}