{"action":"opened","number":1470,"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470","id":192316614,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzE2NjE0","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1470","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1470.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1470.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1470","number":1470,"state":"open","locked":false,"title":"Normalize settings classes and improve logging","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"body":"This PR:\r\n\r\n- improves the similarity of implementation among the various settings classes.\r\n- improves the similarity/completeness of logging among the various setting classes.\r\n\r\nThe next PR will split the NodeSettings class, which is currently both a configuration source for all settings classes AND the settings class for the base feature, into NodeConfiguration and BaseSettings.","created_at":"2018-06-04T07:13:43Z","updated_at":"2018-06-04T07:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1470/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/e77ebdf92e81e09cceb6ce9274c1cafb11f35ad1","head":{"label":"quantumagi:move2basefeature","ref":"move2basefeature","sha":"e77ebdf92e81e09cceb6ce9274c1cafb11f35ad1","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"repo":{"id":95172741,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE3Mjc0MQ==","name":"StratisBitcoinFullNode","full_name":"quantumagi/StratisBitcoinFullNode","owner":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quantumagi/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/deployments","created_at":"2017-06-23T01:50:53Z","updated_at":"2018-06-03T12:09:24Z","pushed_at":"2018-06-04T07:09:44Z","git_url":"git://github.com/quantumagi/StratisBitcoinFullNode.git","ssh_url":"git@github.com:quantumagi/StratisBitcoinFullNode.git","clone_url":"https://github.com/quantumagi/StratisBitcoinFullNode.git","svn_url":"https://github.com/quantumagi/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":32783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"92647e97697d3551b8d79995a40ed01e567122b3","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-06-03T14:44:45Z","pushed_at":"2018-06-03T13:30:13Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":29314,"stargazers_count":483,"watchers_count":483,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":209,"open_issues":105,"watchers":483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1470"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1470"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/e77ebdf92e81e09cceb6ce9274c1cafb11f35ad1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":204,"deletions":9,"changed_files":9}}
{"actor":{"display_login":"quantumagi"}}