{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/24647","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/24647/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/24647/comments","events_url":"https://api.github.com/repos/golang/go/issues/24647/events","html_url":"https://github.com/golang/go/issues/24647","id":310591591,"number":24647,"title":"strings: TestBuilderGrow test flake","user":{"login":"josharian","id":67496,"avatar_url":"https://avatars2.githubusercontent.com/u/67496?v=4","gravatar_id":"","url":"https://api.github.com/users/josharian","html_url":"https://github.com/josharian","followers_url":"https://api.github.com/users/josharian/followers","following_url":"https://api.github.com/users/josharian/following{/other_user}","gists_url":"https://api.github.com/users/josharian/gists{/gist_id}","starred_url":"https://api.github.com/users/josharian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josharian/subscriptions","organizations_url":"https://api.github.com/users/josharian/orgs","repos_url":"https://api.github.com/users/josharian/repos","events_url":"https://api.github.com/users/josharian/events{/privacy}","received_events_url":"https://api.github.com/users/josharian/received_events","type":"User","site_admin":false},"labels":[{"id":373399998,"url":"https://api.github.com/repos/golang/go/labels/NeedsFix","name":"NeedsFix","color":"ededed","default":false},{"id":150880205,"url":"https://api.github.com/repos/golang/go/labels/Testing","name":"Testing","color":"aaffaa","default":false},{"id":150880243,"url":"https://api.github.com/repos/golang/go/labels/help%20wanted","name":"help wanted","color":"fbca04","default":true}],"state":"open","locked":false,"assignee":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars1.githubusercontent.com/u/2621?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"assignees":[{"login":"bradfitz","id":2621,"avatar_url":"https://avatars1.githubusercontent.com/u/2621?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/62","html_url":"https://github.com/golang/go/milestone/62","labels_url":"https://api.github.com/repos/golang/go/milestones/62/labels","id":2827591,"number":62,"title":"Go1.11","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":891,"closed_issues":251,"state":"open","created_at":"2017-10-10T13:39:17Z","updated_at":"2018-04-02T21:49:39Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-04-02T19:59:34Z","updated_at":"2018-04-02T23:08:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://build.golang.org/log/bc6b2519adffb638dbe8ad1fcd447d1737740e6d\r\n\r\n```\r\n--- FAIL: TestBuilderGrow (0.04s)\r\n\tbuilder_test.go:94: growLen=10000: allocation occurred during write\r\nFAIL\r\nFAIL\tstrings\t5.487s\r\n```\r\n\r\n@aclements commented over in #24631 about alloc measurements in the testing package:\r\n\r\n> I worry slightly that the random background allocations that aren't coupled to iterations (e.g., when a GC cycle runs) would almost always cause this number to be slightly above a whole number and that that could confuse people.\r\n\r\nPerhaps that effect is responsible for this build failure. Note that the strings package has its own handrolled alloc count implementation, one which does no averaging and is thus more susceptible to such flakes.\r\n\r\ncc @cespare @bradfitz \r\n"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/378076199","html_url":"https://github.com/golang/go/issues/24647#issuecomment-378076199","issue_url":"https://api.github.com/repos/golang/go/issues/24647","id":378076199,"user":{"login":"gopherbot","id":8566911,"avatar_url":"https://avatars1.githubusercontent.com/u/8566911?v=4","gravatar_id":"","url":"https://api.github.com/users/gopherbot","html_url":"https://github.com/gopherbot","followers_url":"https://api.github.com/users/gopherbot/followers","following_url":"https://api.github.com/users/gopherbot/following{/other_user}","gists_url":"https://api.github.com/users/gopherbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherbot/subscriptions","organizations_url":"https://api.github.com/users/gopherbot/orgs","repos_url":"https://api.github.com/users/gopherbot/repos","events_url":"https://api.github.com/users/gopherbot/events{/privacy}","received_events_url":"https://api.github.com/users/gopherbot/received_events","type":"User","site_admin":false},"created_at":"2018-04-02T23:08:05Z","updated_at":"2018-04-02T23:08:05Z","author_association":"NONE","body":"Change https://golang.org/cl/104235 mentions this issue: `strings: fix flaky TestBuilderGrow test`"}}
{"actor":{"display_login":"gopherbot"}}