{"action":"created","comment":{"url":"https://api.github.com/repos/projecteru2/core/pulls/comments/209481826","pull_request_review_id":145503053,"id":209481826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ4MTgyNg==","diff_hunk":"@@ -45,7 +45,32 @@ func (c *Container) Inspect(ctx context.Context) (enginetypes.ContainerJSON, err\n \treturn c.Engine.ContainerInspect(inspectCtx, c.ID)\n }\n \n-//DeployStatus store deploy status\n+// Stop a container\n+func (c *Container) Stop(ctx context.Context, timeout time.Duration) error {\n+\tif c.Engine == nil {\n+\t\treturn ErrNilEngine\n+\t}\n+\t// 这里 block 的问题很严重，按照目前的配置是 5 分钟一级的 block\n+\t// 一个简单的处理方法是相信 ctx 不相信 docker 自身的处理","path":"types/container.go","position":38,"original_position":38,"commit_id":"593ed7cae40741e649ad3aeafc7f12ea72796abf","original_commit_id":"593ed7cae40741e649ad3aeafc7f12ea72796abf","user":{"login":"CMGS","id":506216,"node_id":"MDQ6VXNlcjUwNjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/506216?v=4","gravatar_id":"","url":"https://api.github.com/users/CMGS","html_url":"https://github.com/CMGS","followers_url":"https://api.github.com/users/CMGS/followers","following_url":"https://api.github.com/users/CMGS/following{/other_user}","gists_url":"https://api.github.com/users/CMGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CMGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMGS/subscriptions","organizations_url":"https://api.github.com/users/CMGS/orgs","repos_url":"https://api.github.com/users/CMGS/repos","events_url":"https://api.github.com/users/CMGS/events{/privacy}","received_events_url":"https://api.github.com/users/CMGS/received_events","type":"User","site_admin":false},"body":"这里不涉及 kill -9 吧","created_at":"2018-08-13T02:47:00Z","updated_at":"2018-08-13T02:47:00Z","html_url":"https://github.com/projecteru2/core/pull/41#discussion_r209481826","pull_request_url":"https://api.github.com/repos/projecteru2/core/pulls/41","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projecteru2/core/pulls/comments/209481826"},"html":{"href":"https://github.com/projecteru2/core/pull/41#discussion_r209481826"},"pull_request":{"href":"https://api.github.com/repos/projecteru2/core/pulls/41"}},"in_reply_to_id":209461986},"pull_request":{"url":"https://api.github.com/repos/projecteru2/core/pulls/41","id":207671423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjcxNDIz","html_url":"https://github.com/projecteru2/core/pull/41","diff_url":"https://github.com/projecteru2/core/pull/41.diff","patch_url":"https://github.com/projecteru2/core/pull/41.patch","issue_url":"https://api.github.com/repos/projecteru2/core/issues/41","number":41,"state":"open","locked":false,"title":"refactor container life control","user":{"login":"CMGS","id":506216,"node_id":"MDQ6VXNlcjUwNjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/506216?v=4","gravatar_id":"","url":"https://api.github.com/users/CMGS","html_url":"https://github.com/CMGS","followers_url":"https://api.github.com/users/CMGS/followers","following_url":"https://api.github.com/users/CMGS/following{/other_user}","gists_url":"https://api.github.com/users/CMGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CMGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMGS/subscriptions","organizations_url":"https://api.github.com/users/CMGS/orgs","repos_url":"https://api.github.com/users/CMGS/repos","events_url":"https://api.github.com/users/CMGS/events{/privacy}","received_events_url":"https://api.github.com/users/CMGS/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-10T17:08:43Z","updated_at":"2018-08-13T02:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c03f739c07ad8ea94d26f78b7852e82e6d921ada","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projecteru2/core/pulls/41/commits","review_comments_url":"https://api.github.com/repos/projecteru2/core/pulls/41/comments","review_comment_url":"https://api.github.com/repos/projecteru2/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecteru2/core/issues/41/comments","statuses_url":"https://api.github.com/repos/projecteru2/core/statuses/593ed7cae40741e649ad3aeafc7f12ea72796abf","head":{"label":"projecteru2:dev","ref":"dev","sha":"593ed7cae40741e649ad3aeafc7f12ea72796abf","user":{"login":"projecteru2","id":26270096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjcwMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/26270096?v=4","gravatar_id":"","url":"https://api.github.com/users/projecteru2","html_url":"https://github.com/projecteru2","followers_url":"https://api.github.com/users/projecteru2/followers","following_url":"https://api.github.com/users/projecteru2/following{/other_user}","gists_url":"https://api.github.com/users/projecteru2/gists{/gist_id}","starred_url":"https://api.github.com/users/projecteru2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecteru2/subscriptions","organizations_url":"https://api.github.com/users/projecteru2/orgs","repos_url":"https://api.github.com/users/projecteru2/repos","events_url":"https://api.github.com/users/projecteru2/events{/privacy}","received_events_url":"https://api.github.com/users/projecteru2/received_events","type":"Organization","site_admin":false},"repo":{"id":102703923,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDM5MjM=","name":"core","full_name":"projecteru2/core","owner":{"login":"projecteru2","id":26270096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjcwMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/26270096?v=4","gravatar_id":"","url":"https://api.github.com/users/projecteru2","html_url":"https://github.com/projecteru2","followers_url":"https://api.github.com/users/projecteru2/followers","following_url":"https://api.github.com/users/projecteru2/following{/other_user}","gists_url":"https://api.github.com/users/projecteru2/gists{/gist_id}","starred_url":"https://api.github.com/users/projecteru2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecteru2/subscriptions","organizations_url":"https://api.github.com/users/projecteru2/orgs","repos_url":"https://api.github.com/users/projecteru2/repos","events_url":"https://api.github.com/users/projecteru2/events{/privacy}","received_events_url":"https://api.github.com/users/projecteru2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecteru2/core","description":"Eru core","fork":false,"url":"https://api.github.com/repos/projecteru2/core","forks_url":"https://api.github.com/repos/projecteru2/core/forks","keys_url":"https://api.github.com/repos/projecteru2/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecteru2/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecteru2/core/teams","hooks_url":"https://api.github.com/repos/projecteru2/core/hooks","issue_events_url":"https://api.github.com/repos/projecteru2/core/issues/events{/number}","events_url":"https://api.github.com/repos/projecteru2/core/events","assignees_url":"https://api.github.com/repos/projecteru2/core/assignees{/user}","branches_url":"https://api.github.com/repos/projecteru2/core/branches{/branch}","tags_url":"https://api.github.com/repos/projecteru2/core/tags","blobs_url":"https://api.github.com/repos/projecteru2/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecteru2/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecteru2/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecteru2/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecteru2/core/statuses/{sha}","languages_url":"https://api.github.com/repos/projecteru2/core/languages","stargazers_url":"https://api.github.com/repos/projecteru2/core/stargazers","contributors_url":"https://api.github.com/repos/projecteru2/core/contributors","subscribers_url":"https://api.github.com/repos/projecteru2/core/subscribers","subscription_url":"https://api.github.com/repos/projecteru2/core/subscription","commits_url":"https://api.github.com/repos/projecteru2/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecteru2/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecteru2/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecteru2/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecteru2/core/contents/{+path}","compare_url":"https://api.github.com/repos/projecteru2/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecteru2/core/merges","archive_url":"https://api.github.com/repos/projecteru2/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecteru2/core/downloads","issues_url":"https://api.github.com/repos/projecteru2/core/issues{/number}","pulls_url":"https://api.github.com/repos/projecteru2/core/pulls{/number}","milestones_url":"https://api.github.com/repos/projecteru2/core/milestones{/number}","notifications_url":"https://api.github.com/repos/projecteru2/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecteru2/core/labels{/name}","releases_url":"https://api.github.com/repos/projecteru2/core/releases{/id}","deployments_url":"https://api.github.com/repos/projecteru2/core/deployments","created_at":"2017-09-07T07:10:04Z","updated_at":"2018-08-10T10:07:00Z","pushed_at":"2018-08-11T16:20:26Z","git_url":"git://github.com/projecteru2/core.git","ssh_url":"git@github.com:projecteru2/core.git","clone_url":"https://github.com/projecteru2/core.git","svn_url":"https://github.com/projecteru2/core","homepage":null,"size":1235,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":1,"watchers":30,"default_branch":"master"}},"base":{"label":"projecteru2:master","ref":"master","sha":"73d7826727f4b3b335bd90da4a07ce80764d7f5a","user":{"login":"projecteru2","id":26270096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjcwMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/26270096?v=4","gravatar_id":"","url":"https://api.github.com/users/projecteru2","html_url":"https://github.com/projecteru2","followers_url":"https://api.github.com/users/projecteru2/followers","following_url":"https://api.github.com/users/projecteru2/following{/other_user}","gists_url":"https://api.github.com/users/projecteru2/gists{/gist_id}","starred_url":"https://api.github.com/users/projecteru2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecteru2/subscriptions","organizations_url":"https://api.github.com/users/projecteru2/orgs","repos_url":"https://api.github.com/users/projecteru2/repos","events_url":"https://api.github.com/users/projecteru2/events{/privacy}","received_events_url":"https://api.github.com/users/projecteru2/received_events","type":"Organization","site_admin":false},"repo":{"id":102703923,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDM5MjM=","name":"core","full_name":"projecteru2/core","owner":{"login":"projecteru2","id":26270096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjcwMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/26270096?v=4","gravatar_id":"","url":"https://api.github.com/users/projecteru2","html_url":"https://github.com/projecteru2","followers_url":"https://api.github.com/users/projecteru2/followers","following_url":"https://api.github.com/users/projecteru2/following{/other_user}","gists_url":"https://api.github.com/users/projecteru2/gists{/gist_id}","starred_url":"https://api.github.com/users/projecteru2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecteru2/subscriptions","organizations_url":"https://api.github.com/users/projecteru2/orgs","repos_url":"https://api.github.com/users/projecteru2/repos","events_url":"https://api.github.com/users/projecteru2/events{/privacy}","received_events_url":"https://api.github.com/users/projecteru2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecteru2/core","description":"Eru core","fork":false,"url":"https://api.github.com/repos/projecteru2/core","forks_url":"https://api.github.com/repos/projecteru2/core/forks","keys_url":"https://api.github.com/repos/projecteru2/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecteru2/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecteru2/core/teams","hooks_url":"https://api.github.com/repos/projecteru2/core/hooks","issue_events_url":"https://api.github.com/repos/projecteru2/core/issues/events{/number}","events_url":"https://api.github.com/repos/projecteru2/core/events","assignees_url":"https://api.github.com/repos/projecteru2/core/assignees{/user}","branches_url":"https://api.github.com/repos/projecteru2/core/branches{/branch}","tags_url":"https://api.github.com/repos/projecteru2/core/tags","blobs_url":"https://api.github.com/repos/projecteru2/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecteru2/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecteru2/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecteru2/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecteru2/core/statuses/{sha}","languages_url":"https://api.github.com/repos/projecteru2/core/languages","stargazers_url":"https://api.github.com/repos/projecteru2/core/stargazers","contributors_url":"https://api.github.com/repos/projecteru2/core/contributors","subscribers_url":"https://api.github.com/repos/projecteru2/core/subscribers","subscription_url":"https://api.github.com/repos/projecteru2/core/subscription","commits_url":"https://api.github.com/repos/projecteru2/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecteru2/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecteru2/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecteru2/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecteru2/core/contents/{+path}","compare_url":"https://api.github.com/repos/projecteru2/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecteru2/core/merges","archive_url":"https://api.github.com/repos/projecteru2/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecteru2/core/downloads","issues_url":"https://api.github.com/repos/projecteru2/core/issues{/number}","pulls_url":"https://api.github.com/repos/projecteru2/core/pulls{/number}","milestones_url":"https://api.github.com/repos/projecteru2/core/milestones{/number}","notifications_url":"https://api.github.com/repos/projecteru2/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecteru2/core/labels{/name}","releases_url":"https://api.github.com/repos/projecteru2/core/releases{/id}","deployments_url":"https://api.github.com/repos/projecteru2/core/deployments","created_at":"2017-09-07T07:10:04Z","updated_at":"2018-08-10T10:07:00Z","pushed_at":"2018-08-11T16:20:26Z","git_url":"git://github.com/projecteru2/core.git","ssh_url":"git@github.com:projecteru2/core.git","clone_url":"https://github.com/projecteru2/core.git","svn_url":"https://github.com/projecteru2/core","homepage":null,"size":1235,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":1,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecteru2/core/pulls/41"},"html":{"href":"https://github.com/projecteru2/core/pull/41"},"issue":{"href":"https://api.github.com/repos/projecteru2/core/issues/41"},"comments":{"href":"https://api.github.com/repos/projecteru2/core/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/projecteru2/core/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/projecteru2/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecteru2/core/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/projecteru2/core/statuses/593ed7cae40741e649ad3aeafc7f12ea72796abf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CMGS"}}