{"action":"created","comment":{"url":"https://api.github.com/repos/blackbaud/skyux2/pulls/comments/193831005","pull_request_review_id":126884293,"id":193831005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzgzMTAwNQ==","diff_hunk":"@@ -1,5 +1,5 @@\n export class NumericOptions {\n-  public digits: number = 1;\n-  public format: string = 'number';\n-  public iso: string = 'USD';\n+  public digits = 1;\n+  public format: 'currency' | 'number' = 'number';","path":"src/modules/numeric/numeric.options.ts","position":6,"original_position":6,"commit_id":"91aac19937dfa0547710880df957af32bc36fb17","original_commit_id":"91aac19937dfa0547710880df957af32bc36fb17","user":{"login":"Blackbaud-SteveBrush","id":12497062,"node_id":"MDQ6VXNlcjEyNDk3MDYy","avatar_url":"https://avatars3.githubusercontent.com/u/12497062?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-SteveBrush","html_url":"https://github.com/Blackbaud-SteveBrush","followers_url":"https://api.github.com/users/Blackbaud-SteveBrush/followers","following_url":"https://api.github.com/users/Blackbaud-SteveBrush/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-SteveBrush/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-SteveBrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-SteveBrush/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-SteveBrush/orgs","repos_url":"https://api.github.com/users/Blackbaud-SteveBrush/repos","events_url":"https://api.github.com/users/Blackbaud-SteveBrush/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-SteveBrush/received_events","type":"User","site_admin":false},"body":"Hm, I suppose, since it might throw a TSLint error for consumers (internally, it wouldn't be a breaking change).\r\n\r\nI'll remove it.","created_at":"2018-06-07T17:35:35Z","updated_at":"2018-06-07T17:35:35Z","html_url":"https://github.com/blackbaud/skyux2/pull/1716#discussion_r193831005","pull_request_url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/comments/193831005"},"html":{"href":"https://github.com/blackbaud/skyux2/pull/1716#discussion_r193831005"},"pull_request":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716"}},"in_reply_to_id":192858919},"pull_request":{"url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716","id":191583735,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTgzNzM1","html_url":"https://github.com/blackbaud/skyux2/pull/1716","diff_url":"https://github.com/blackbaud/skyux2/pull/1716.diff","patch_url":"https://github.com/blackbaud/skyux2/pull/1716.patch","issue_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1716","number":1716,"state":"open","locked":false,"title":"Numeric Service > Using localized shorten symbol","user":{"login":"Blackbaud-SteveBrush","id":12497062,"node_id":"MDQ6VXNlcjEyNDk3MDYy","avatar_url":"https://avatars3.githubusercontent.com/u/12497062?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-SteveBrush","html_url":"https://github.com/Blackbaud-SteveBrush","followers_url":"https://api.github.com/users/Blackbaud-SteveBrush/followers","following_url":"https://api.github.com/users/Blackbaud-SteveBrush/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-SteveBrush/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-SteveBrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-SteveBrush/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-SteveBrush/orgs","repos_url":"https://api.github.com/users/Blackbaud-SteveBrush/repos","events_url":"https://api.github.com/users/Blackbaud-SteveBrush/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-SteveBrush/received_events","type":"User","site_admin":false},"body":"Addresses: https://github.com/blackbaud/skyux2/issues/965","created_at":"2018-05-30T21:18:08Z","updated_at":"2018-06-07T17:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0215a301e8d58df0f8ad2cd79766bb10b8eb44e","assignee":{"login":"Blackbaud-BobbyEarl","id":4612419,"node_id":"MDQ6VXNlcjQ2MTI0MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4612419?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-BobbyEarl","html_url":"https://github.com/Blackbaud-BobbyEarl","followers_url":"https://api.github.com/users/Blackbaud-BobbyEarl/followers","following_url":"https://api.github.com/users/Blackbaud-BobbyEarl/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-BobbyEarl/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-BobbyEarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-BobbyEarl/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-BobbyEarl/orgs","repos_url":"https://api.github.com/users/Blackbaud-BobbyEarl/repos","events_url":"https://api.github.com/users/Blackbaud-BobbyEarl/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-BobbyEarl/received_events","type":"User","site_admin":false},"assignees":[{"login":"Blackbaud-BobbyEarl","id":4612419,"node_id":"MDQ6VXNlcjQ2MTI0MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4612419?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-BobbyEarl","html_url":"https://github.com/Blackbaud-BobbyEarl","followers_url":"https://api.github.com/users/Blackbaud-BobbyEarl/followers","following_url":"https://api.github.com/users/Blackbaud-BobbyEarl/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-BobbyEarl/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-BobbyEarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-BobbyEarl/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-BobbyEarl/orgs","repos_url":"https://api.github.com/users/Blackbaud-BobbyEarl/repos","events_url":"https://api.github.com/users/Blackbaud-BobbyEarl/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-BobbyEarl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/blackbaud/skyux2/milestones/84","html_url":"https://github.com/blackbaud/skyux2/milestone/84","labels_url":"https://api.github.com/repos/blackbaud/skyux2/milestones/84/labels","id":3321132,"node_id":"MDk6TWlsZXN0b25lMzMyMTEzMg==","number":84,"title":"Block 4 Sprint 5 - 6/8/2018","description":"","creator":{"login":"blackbaud-johnly","id":7850105,"node_id":"MDQ6VXNlcjc4NTAxMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/7850105?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud-johnly","html_url":"https://github.com/blackbaud-johnly","followers_url":"https://api.github.com/users/blackbaud-johnly/followers","following_url":"https://api.github.com/users/blackbaud-johnly/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud-johnly/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud-johnly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud-johnly/subscriptions","organizations_url":"https://api.github.com/users/blackbaud-johnly/orgs","repos_url":"https://api.github.com/users/blackbaud-johnly/repos","events_url":"https://api.github.com/users/blackbaud-johnly/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud-johnly/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":7,"state":"open","created_at":"2018-05-04T17:54:51Z","updated_at":"2018-06-07T17:07:28Z","due_on":"2018-06-08T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716/commits","review_comments_url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716/comments","review_comment_url":"https://api.github.com/repos/blackbaud/skyux2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1716/comments","statuses_url":"https://api.github.com/repos/blackbaud/skyux2/statuses/91aac19937dfa0547710880df957af32bc36fb17","head":{"label":"blackbaud:fix-numeric-localization","ref":"fix-numeric-localization","sha":"91aac19937dfa0547710880df957af32bc36fb17","user":{"login":"blackbaud","id":1738029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzgwMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1738029?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud","html_url":"https://github.com/blackbaud","followers_url":"https://api.github.com/users/blackbaud/followers","following_url":"https://api.github.com/users/blackbaud/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud/subscriptions","organizations_url":"https://api.github.com/users/blackbaud/orgs","repos_url":"https://api.github.com/users/blackbaud/repos","events_url":"https://api.github.com/users/blackbaud/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud/received_events","type":"Organization","site_admin":false},"repo":{"id":56515804,"node_id":"MDEwOlJlcG9zaXRvcnk1NjUxNTgwNA==","name":"skyux2","full_name":"blackbaud/skyux2","owner":{"login":"blackbaud","id":1738029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzgwMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1738029?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud","html_url":"https://github.com/blackbaud","followers_url":"https://api.github.com/users/blackbaud/followers","following_url":"https://api.github.com/users/blackbaud/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud/subscriptions","organizations_url":"https://api.github.com/users/blackbaud/orgs","repos_url":"https://api.github.com/users/blackbaud/repos","events_url":"https://api.github.com/users/blackbaud/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blackbaud/skyux2","description":"SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.","fork":false,"url":"https://api.github.com/repos/blackbaud/skyux2","forks_url":"https://api.github.com/repos/blackbaud/skyux2/forks","keys_url":"https://api.github.com/repos/blackbaud/skyux2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackbaud/skyux2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackbaud/skyux2/teams","hooks_url":"https://api.github.com/repos/blackbaud/skyux2/hooks","issue_events_url":"https://api.github.com/repos/blackbaud/skyux2/issues/events{/number}","events_url":"https://api.github.com/repos/blackbaud/skyux2/events","assignees_url":"https://api.github.com/repos/blackbaud/skyux2/assignees{/user}","branches_url":"https://api.github.com/repos/blackbaud/skyux2/branches{/branch}","tags_url":"https://api.github.com/repos/blackbaud/skyux2/tags","blobs_url":"https://api.github.com/repos/blackbaud/skyux2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackbaud/skyux2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackbaud/skyux2/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackbaud/skyux2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackbaud/skyux2/statuses/{sha}","languages_url":"https://api.github.com/repos/blackbaud/skyux2/languages","stargazers_url":"https://api.github.com/repos/blackbaud/skyux2/stargazers","contributors_url":"https://api.github.com/repos/blackbaud/skyux2/contributors","subscribers_url":"https://api.github.com/repos/blackbaud/skyux2/subscribers","subscription_url":"https://api.github.com/repos/blackbaud/skyux2/subscription","commits_url":"https://api.github.com/repos/blackbaud/skyux2/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackbaud/skyux2/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackbaud/skyux2/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackbaud/skyux2/issues/comments{/number}","contents_url":"https://api.github.com/repos/blackbaud/skyux2/contents/{+path}","compare_url":"https://api.github.com/repos/blackbaud/skyux2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackbaud/skyux2/merges","archive_url":"https://api.github.com/repos/blackbaud/skyux2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackbaud/skyux2/downloads","issues_url":"https://api.github.com/repos/blackbaud/skyux2/issues{/number}","pulls_url":"https://api.github.com/repos/blackbaud/skyux2/pulls{/number}","milestones_url":"https://api.github.com/repos/blackbaud/skyux2/milestones{/number}","notifications_url":"https://api.github.com/repos/blackbaud/skyux2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackbaud/skyux2/labels{/name}","releases_url":"https://api.github.com/repos/blackbaud/skyux2/releases{/id}","deployments_url":"https://api.github.com/repos/blackbaud/skyux2/deployments","created_at":"2016-04-18T14:41:50Z","updated_at":"2018-06-05T16:19:25Z","pushed_at":"2018-06-07T17:30:51Z","git_url":"git://github.com/blackbaud/skyux2.git","ssh_url":"git@github.com:blackbaud/skyux2.git","clone_url":"https://github.com/blackbaud/skyux2.git","svn_url":"https://github.com/blackbaud/skyux2","homepage":"https://developer.blackbaud.com/skyux","size":35738,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":61,"open_issues":290,"watchers":22,"default_branch":"master"}},"base":{"label":"blackbaud:master","ref":"master","sha":"35d9e2a63aec268a67e46e8711f7e9cf1eec7359","user":{"login":"blackbaud","id":1738029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzgwMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1738029?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud","html_url":"https://github.com/blackbaud","followers_url":"https://api.github.com/users/blackbaud/followers","following_url":"https://api.github.com/users/blackbaud/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud/subscriptions","organizations_url":"https://api.github.com/users/blackbaud/orgs","repos_url":"https://api.github.com/users/blackbaud/repos","events_url":"https://api.github.com/users/blackbaud/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud/received_events","type":"Organization","site_admin":false},"repo":{"id":56515804,"node_id":"MDEwOlJlcG9zaXRvcnk1NjUxNTgwNA==","name":"skyux2","full_name":"blackbaud/skyux2","owner":{"login":"blackbaud","id":1738029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzgwMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1738029?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud","html_url":"https://github.com/blackbaud","followers_url":"https://api.github.com/users/blackbaud/followers","following_url":"https://api.github.com/users/blackbaud/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud/subscriptions","organizations_url":"https://api.github.com/users/blackbaud/orgs","repos_url":"https://api.github.com/users/blackbaud/repos","events_url":"https://api.github.com/users/blackbaud/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blackbaud/skyux2","description":"SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.","fork":false,"url":"https://api.github.com/repos/blackbaud/skyux2","forks_url":"https://api.github.com/repos/blackbaud/skyux2/forks","keys_url":"https://api.github.com/repos/blackbaud/skyux2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackbaud/skyux2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackbaud/skyux2/teams","hooks_url":"https://api.github.com/repos/blackbaud/skyux2/hooks","issue_events_url":"https://api.github.com/repos/blackbaud/skyux2/issues/events{/number}","events_url":"https://api.github.com/repos/blackbaud/skyux2/events","assignees_url":"https://api.github.com/repos/blackbaud/skyux2/assignees{/user}","branches_url":"https://api.github.com/repos/blackbaud/skyux2/branches{/branch}","tags_url":"https://api.github.com/repos/blackbaud/skyux2/tags","blobs_url":"https://api.github.com/repos/blackbaud/skyux2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackbaud/skyux2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackbaud/skyux2/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackbaud/skyux2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackbaud/skyux2/statuses/{sha}","languages_url":"https://api.github.com/repos/blackbaud/skyux2/languages","stargazers_url":"https://api.github.com/repos/blackbaud/skyux2/stargazers","contributors_url":"https://api.github.com/repos/blackbaud/skyux2/contributors","subscribers_url":"https://api.github.com/repos/blackbaud/skyux2/subscribers","subscription_url":"https://api.github.com/repos/blackbaud/skyux2/subscription","commits_url":"https://api.github.com/repos/blackbaud/skyux2/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackbaud/skyux2/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackbaud/skyux2/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackbaud/skyux2/issues/comments{/number}","contents_url":"https://api.github.com/repos/blackbaud/skyux2/contents/{+path}","compare_url":"https://api.github.com/repos/blackbaud/skyux2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackbaud/skyux2/merges","archive_url":"https://api.github.com/repos/blackbaud/skyux2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackbaud/skyux2/downloads","issues_url":"https://api.github.com/repos/blackbaud/skyux2/issues{/number}","pulls_url":"https://api.github.com/repos/blackbaud/skyux2/pulls{/number}","milestones_url":"https://api.github.com/repos/blackbaud/skyux2/milestones{/number}","notifications_url":"https://api.github.com/repos/blackbaud/skyux2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackbaud/skyux2/labels{/name}","releases_url":"https://api.github.com/repos/blackbaud/skyux2/releases{/id}","deployments_url":"https://api.github.com/repos/blackbaud/skyux2/deployments","created_at":"2016-04-18T14:41:50Z","updated_at":"2018-06-05T16:19:25Z","pushed_at":"2018-06-07T17:30:51Z","git_url":"git://github.com/blackbaud/skyux2.git","ssh_url":"git@github.com:blackbaud/skyux2.git","clone_url":"https://github.com/blackbaud/skyux2.git","svn_url":"https://github.com/blackbaud/skyux2","homepage":"https://developer.blackbaud.com/skyux","size":35738,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":61,"open_issues":290,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716"},"html":{"href":"https://github.com/blackbaud/skyux2/pull/1716"},"issue":{"href":"https://api.github.com/repos/blackbaud/skyux2/issues/1716"},"comments":{"href":"https://api.github.com/repos/blackbaud/skyux2/issues/1716/comments"},"review_comments":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716/comments"},"review_comment":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blackbaud/skyux2/pulls/1716/commits"},"statuses":{"href":"https://api.github.com/repos/blackbaud/skyux2/statuses/91aac19937dfa0547710880df957af32bc36fb17"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Blackbaud-SteveBrush"}}