{"action":"closed","number":3035,"pull_request":{"url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035","id":236296162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Mjk2MTYy","html_url":"https://github.com/hydroshare/hydroshare/pull/3035","diff_url":"https://github.com/hydroshare/hydroshare/pull/3035.diff","patch_url":"https://github.com/hydroshare/hydroshare/pull/3035.patch","issue_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/3035","number":3035,"state":"closed","locked":false,"title":"[#2980] separate file extension an daggregation matching logic","user":{"login":"sblack-usu","id":35820390,"node_id":"MDQ6VXNlcjM1ODIwMzkw","avatar_url":"https://avatars1.githubusercontent.com/u/35820390?v=4","gravatar_id":"","url":"https://api.github.com/users/sblack-usu","html_url":"https://github.com/sblack-usu","followers_url":"https://api.github.com/users/sblack-usu/followers","following_url":"https://api.github.com/users/sblack-usu/following{/other_user}","gists_url":"https://api.github.com/users/sblack-usu/gists{/gist_id}","starred_url":"https://api.github.com/users/sblack-usu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sblack-usu/subscriptions","organizations_url":"https://api.github.com/users/sblack-usu/orgs","repos_url":"https://api.github.com/users/sblack-usu/repos","events_url":"https://api.github.com/users/sblack-usu/events{/privacy}","received_events_url":"https://api.github.com/users/sblack-usu/received_events","type":"User","site_admin":false},"body":"<!--\r\n\r\nPlease read, and add your text at the bottom of this message.\r\n\r\nThanks for contributing code to HydroShare. In order to maintain code quality and expedite this process, please assist the development team by making sure the following is present in this pull request.\r\n\r\nFor more information, see https://docs.google.com/document/d/1dzxqlZW5fKNEyQSeKiSFq-SmS-VOPCva95XXkBjPExs\r\n\r\n-->\r\n\r\n### Pull Request Checklist: \r\n- [x] Positive Test Case Written by Dev\r\n\r\n<!-- Enter steps that a QA engineer, stakeholder, or user documentation writer would follow to test the positive or \"successful\" case of the functionality your code provides or fixes -->\r\n\r\n- [x] Automated Testing\r\n\r\n<!-- Our Jenkins Instance is set up to automatically test every commit from a pull request. Code coverage must not decrease so new functionality or code paths added during a bug fix must have appropriate tests written. Every test must pass, including PEP8 code formatting tests. -->\r\n\r\n- [x] Sufficient User and Developer Documentation\r\n\r\n<!-- Please email your positive test case lbrazil@cuahsi.org, who will make the decision regarding user documentation. -->\r\n\r\n- [x] Passing Jenkins Build\r\n\r\n<!-- Our Jenkins Instance is set up to automatically test every commit from a pull request. Every test must pass, including PEP8 code formatting tests. -->\r\n\r\n- [x] Peer Code review and approval\r\n\r\n<!-- This is the process by which a peer developer on the HydroShare team will read the changeset, provide feedback, and ultimately give a formal approval to the code before it passes PR status. -->\r\n\r\n### Positive Test Case\r\n1. Setup a webapp for a single file aggregation (.refts.json).  Add a launching pattern on both the file level and aggregation level.  for the file extension the aggregation's extension (.json)\r\n2. Setup a webapp for a multi file aggregation (.nc).  Add a launching pattern on both the file level and aggregation level.  for the file extension, use the main file extension (.nc)\r\n3. Add both webapps to your open with list\r\n4. Create a composite resource with the aggregation types the two web apps were created with.\r\n5. Right click on the multi file aggregation, verify the correct web app shows and launches correctly.  Open the multi file aggregation folder, right click on the files inside and verify the aggregation level web app doesn't show.  Verify the file extension launching pattern shows.\r\n6. Right click on the single file aggregation.  Verify both aggregation level and file extension aggregations show and launch correctly.\r\n","created_at":"2018-12-05T19:33:26Z","updated_at":"2018-12-08T02:50:02Z","closed_at":"2018-12-08T02:50:02Z","merged_at":"2018-12-08T02:50:02Z","merge_commit_sha":"3bc79bbd3df062526e8f463adf4f0e75d8be6ec7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":275707500,"node_id":"MDU6TGFiZWwyNzU3MDc1MDA=","url":"https://api.github.com/repos/hydroshare/hydroshare/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035/commits","review_comments_url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035/comments","review_comment_url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/3035/comments","statuses_url":"https://api.github.com/repos/hydroshare/hydroshare/statuses/2b0369aacdbea89b3c4edc916dcc67bbae8ae2bf","head":{"label":"hydroshare:2980-web-app","ref":"2980-web-app","sha":"2b0369aacdbea89b3c4edc916dcc67bbae8ae2bf","user":{"login":"hydroshare","id":3444493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3444493?v=4","gravatar_id":"","url":"https://api.github.com/users/hydroshare","html_url":"https://github.com/hydroshare","followers_url":"https://api.github.com/users/hydroshare/followers","following_url":"https://api.github.com/users/hydroshare/following{/other_user}","gists_url":"https://api.github.com/users/hydroshare/gists{/gist_id}","starred_url":"https://api.github.com/users/hydroshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydroshare/subscriptions","organizations_url":"https://api.github.com/users/hydroshare/orgs","repos_url":"https://api.github.com/users/hydroshare/repos","events_url":"https://api.github.com/users/hydroshare/events{/privacy}","received_events_url":"https://api.github.com/users/hydroshare/received_events","type":"Organization","site_admin":false},"repo":{"id":24703136,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcwMzEzNg==","name":"hydroshare","full_name":"hydroshare/hydroshare","private":false,"owner":{"login":"hydroshare","id":3444493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3444493?v=4","gravatar_id":"","url":"https://api.github.com/users/hydroshare","html_url":"https://github.com/hydroshare","followers_url":"https://api.github.com/users/hydroshare/followers","following_url":"https://api.github.com/users/hydroshare/following{/other_user}","gists_url":"https://api.github.com/users/hydroshare/gists{/gist_id}","starred_url":"https://api.github.com/users/hydroshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydroshare/subscriptions","organizations_url":"https://api.github.com/users/hydroshare/orgs","repos_url":"https://api.github.com/users/hydroshare/repos","events_url":"https://api.github.com/users/hydroshare/events{/privacy}","received_events_url":"https://api.github.com/users/hydroshare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hydroshare/hydroshare","description":"HydroShare is a collaborative website for better access to data and models in the hydrologic sciences. ","fork":false,"url":"https://api.github.com/repos/hydroshare/hydroshare","forks_url":"https://api.github.com/repos/hydroshare/hydroshare/forks","keys_url":"https://api.github.com/repos/hydroshare/hydroshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hydroshare/hydroshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hydroshare/hydroshare/teams","hooks_url":"https://api.github.com/repos/hydroshare/hydroshare/hooks","issue_events_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/events{/number}","events_url":"https://api.github.com/repos/hydroshare/hydroshare/events","assignees_url":"https://api.github.com/repos/hydroshare/hydroshare/assignees{/user}","branches_url":"https://api.github.com/repos/hydroshare/hydroshare/branches{/branch}","tags_url":"https://api.github.com/repos/hydroshare/hydroshare/tags","blobs_url":"https://api.github.com/repos/hydroshare/hydroshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hydroshare/hydroshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hydroshare/hydroshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/hydroshare/hydroshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hydroshare/hydroshare/statuses/{sha}","languages_url":"https://api.github.com/repos/hydroshare/hydroshare/languages","stargazers_url":"https://api.github.com/repos/hydroshare/hydroshare/stargazers","contributors_url":"https://api.github.com/repos/hydroshare/hydroshare/contributors","subscribers_url":"https://api.github.com/repos/hydroshare/hydroshare/subscribers","subscription_url":"https://api.github.com/repos/hydroshare/hydroshare/subscription","commits_url":"https://api.github.com/repos/hydroshare/hydroshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/hydroshare/hydroshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/hydroshare/hydroshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/hydroshare/hydroshare/contents/{+path}","compare_url":"https://api.github.com/repos/hydroshare/hydroshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hydroshare/hydroshare/merges","archive_url":"https://api.github.com/repos/hydroshare/hydroshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hydroshare/hydroshare/downloads","issues_url":"https://api.github.com/repos/hydroshare/hydroshare/issues{/number}","pulls_url":"https://api.github.com/repos/hydroshare/hydroshare/pulls{/number}","milestones_url":"https://api.github.com/repos/hydroshare/hydroshare/milestones{/number}","notifications_url":"https://api.github.com/repos/hydroshare/hydroshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hydroshare/hydroshare/labels{/name}","releases_url":"https://api.github.com/repos/hydroshare/hydroshare/releases{/id}","deployments_url":"https://api.github.com/repos/hydroshare/hydroshare/deployments","created_at":"2014-10-02T02:19:41Z","updated_at":"2018-12-07T21:40:13Z","pushed_at":"2018-12-08T02:50:02Z","git_url":"git://github.com/hydroshare/hydroshare.git","ssh_url":"git@github.com:hydroshare/hydroshare.git","clone_url":"https://github.com/hydroshare/hydroshare.git","svn_url":"https://github.com/hydroshare/hydroshare","homepage":"https://www.hydroshare.org","size":228285,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":457,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":457,"watchers":63,"default_branch":"develop"}},"base":{"label":"hydroshare:develop","ref":"develop","sha":"751b3e1796bd9b13882d1fb60685db46f4022cba","user":{"login":"hydroshare","id":3444493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3444493?v=4","gravatar_id":"","url":"https://api.github.com/users/hydroshare","html_url":"https://github.com/hydroshare","followers_url":"https://api.github.com/users/hydroshare/followers","following_url":"https://api.github.com/users/hydroshare/following{/other_user}","gists_url":"https://api.github.com/users/hydroshare/gists{/gist_id}","starred_url":"https://api.github.com/users/hydroshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydroshare/subscriptions","organizations_url":"https://api.github.com/users/hydroshare/orgs","repos_url":"https://api.github.com/users/hydroshare/repos","events_url":"https://api.github.com/users/hydroshare/events{/privacy}","received_events_url":"https://api.github.com/users/hydroshare/received_events","type":"Organization","site_admin":false},"repo":{"id":24703136,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcwMzEzNg==","name":"hydroshare","full_name":"hydroshare/hydroshare","private":false,"owner":{"login":"hydroshare","id":3444493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3444493?v=4","gravatar_id":"","url":"https://api.github.com/users/hydroshare","html_url":"https://github.com/hydroshare","followers_url":"https://api.github.com/users/hydroshare/followers","following_url":"https://api.github.com/users/hydroshare/following{/other_user}","gists_url":"https://api.github.com/users/hydroshare/gists{/gist_id}","starred_url":"https://api.github.com/users/hydroshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydroshare/subscriptions","organizations_url":"https://api.github.com/users/hydroshare/orgs","repos_url":"https://api.github.com/users/hydroshare/repos","events_url":"https://api.github.com/users/hydroshare/events{/privacy}","received_events_url":"https://api.github.com/users/hydroshare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hydroshare/hydroshare","description":"HydroShare is a collaborative website for better access to data and models in the hydrologic sciences. ","fork":false,"url":"https://api.github.com/repos/hydroshare/hydroshare","forks_url":"https://api.github.com/repos/hydroshare/hydroshare/forks","keys_url":"https://api.github.com/repos/hydroshare/hydroshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hydroshare/hydroshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hydroshare/hydroshare/teams","hooks_url":"https://api.github.com/repos/hydroshare/hydroshare/hooks","issue_events_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/events{/number}","events_url":"https://api.github.com/repos/hydroshare/hydroshare/events","assignees_url":"https://api.github.com/repos/hydroshare/hydroshare/assignees{/user}","branches_url":"https://api.github.com/repos/hydroshare/hydroshare/branches{/branch}","tags_url":"https://api.github.com/repos/hydroshare/hydroshare/tags","blobs_url":"https://api.github.com/repos/hydroshare/hydroshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hydroshare/hydroshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hydroshare/hydroshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/hydroshare/hydroshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hydroshare/hydroshare/statuses/{sha}","languages_url":"https://api.github.com/repos/hydroshare/hydroshare/languages","stargazers_url":"https://api.github.com/repos/hydroshare/hydroshare/stargazers","contributors_url":"https://api.github.com/repos/hydroshare/hydroshare/contributors","subscribers_url":"https://api.github.com/repos/hydroshare/hydroshare/subscribers","subscription_url":"https://api.github.com/repos/hydroshare/hydroshare/subscription","commits_url":"https://api.github.com/repos/hydroshare/hydroshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/hydroshare/hydroshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/hydroshare/hydroshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/hydroshare/hydroshare/contents/{+path}","compare_url":"https://api.github.com/repos/hydroshare/hydroshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hydroshare/hydroshare/merges","archive_url":"https://api.github.com/repos/hydroshare/hydroshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hydroshare/hydroshare/downloads","issues_url":"https://api.github.com/repos/hydroshare/hydroshare/issues{/number}","pulls_url":"https://api.github.com/repos/hydroshare/hydroshare/pulls{/number}","milestones_url":"https://api.github.com/repos/hydroshare/hydroshare/milestones{/number}","notifications_url":"https://api.github.com/repos/hydroshare/hydroshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hydroshare/hydroshare/labels{/name}","releases_url":"https://api.github.com/repos/hydroshare/hydroshare/releases{/id}","deployments_url":"https://api.github.com/repos/hydroshare/hydroshare/deployments","created_at":"2014-10-02T02:19:41Z","updated_at":"2018-12-07T21:40:13Z","pushed_at":"2018-12-08T02:50:02Z","git_url":"git://github.com/hydroshare/hydroshare.git","ssh_url":"git@github.com:hydroshare/hydroshare.git","clone_url":"https://github.com/hydroshare/hydroshare.git","svn_url":"https://github.com/hydroshare/hydroshare","homepage":"https://www.hydroshare.org","size":228285,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":457,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":457,"watchers":63,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035"},"html":{"href":"https://github.com/hydroshare/hydroshare/pull/3035"},"issue":{"href":"https://api.github.com/repos/hydroshare/hydroshare/issues/3035"},"comments":{"href":"https://api.github.com/repos/hydroshare/hydroshare/issues/3035/comments"},"review_comments":{"href":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035/comments"},"review_comment":{"href":"https://api.github.com/repos/hydroshare/hydroshare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hydroshare/hydroshare/pulls/3035/commits"},"statuses":{"href":"https://api.github.com/repos/hydroshare/hydroshare/statuses/2b0369aacdbea89b3c4edc916dcc67bbae8ae2bf"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sblack-usu","id":35820390,"node_id":"MDQ6VXNlcjM1ODIwMzkw","avatar_url":"https://avatars1.githubusercontent.com/u/35820390?v=4","gravatar_id":"","url":"https://api.github.com/users/sblack-usu","html_url":"https://github.com/sblack-usu","followers_url":"https://api.github.com/users/sblack-usu/followers","following_url":"https://api.github.com/users/sblack-usu/following{/other_user}","gists_url":"https://api.github.com/users/sblack-usu/gists{/gist_id}","starred_url":"https://api.github.com/users/sblack-usu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sblack-usu/subscriptions","organizations_url":"https://api.github.com/users/sblack-usu/orgs","repos_url":"https://api.github.com/users/sblack-usu/repos","events_url":"https://api.github.com/users/sblack-usu/events{/privacy}","received_events_url":"https://api.github.com/users/sblack-usu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":5,"additions":25,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"sblack-usu"}}