{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/201216898","pull_request_review_id":135673657,"id":201216898,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTIxNjg5OA==","diff_hunk":"@@ -842,7 +872,8 @@ function DragAndDropBlock(runtime, element, configuration) {\n \n             initDraggable();\n             initDroppable();\n-\n+            initializeSlider = sliderInitializer;\n+            sliderInitializer();","path":"drag_and_drop_v2/public/js/drag_and_drop.js","position":126,"original_position":120,"commit_id":"4721c0444f526bcd1f47eb2e7a644929c8d4b0e8","original_commit_id":"722d78f2eed7ec616da11ca08fc3d850bda58d49","user":{"login":"pomegranited","id":7556571,"node_id":"MDQ6VXNlcjc1NTY1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"Ah ok, I didn't test the draggable tiles with images in, so didn't see that failing.\r\n\r\nIn that case, I think your original mechanism was clearer -- setting the `pageLoaded` global instead of replacing the `initializeSlider` function pointer.  At least that way, we can follow the process in the debugger.","created_at":"2018-07-10T04:53:00Z","updated_at":"2018-07-10T04:53:00Z","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160#discussion_r201216898","pull_request_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/201216898"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160#discussion_r201216898"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160"}},"in_reply_to_id":200880978},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160","id":194506882,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTA2ODgy","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160","diff_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160.diff","patch_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160.patch","issue_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/160","number":160,"state":"open","locked":false,"title":"MCKIN-7633 added horizontal slider","user":{"login":"jawad-khan","id":5320368,"node_id":"MDQ6VXNlcjUzMjAzNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/5320368?v=4","gravatar_id":"","url":"https://api.github.com/users/jawad-khan","html_url":"https://github.com/jawad-khan","followers_url":"https://api.github.com/users/jawad-khan/followers","following_url":"https://api.github.com/users/jawad-khan/following{/other_user}","gists_url":"https://api.github.com/users/jawad-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/jawad-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawad-khan/subscriptions","organizations_url":"https://api.github.com/users/jawad-khan/orgs","repos_url":"https://api.github.com/users/jawad-khan/repos","events_url":"https://api.github.com/users/jawad-khan/events{/privacy}","received_events_url":"https://api.github.com/users/jawad-khan/received_events","type":"User","site_admin":false},"body":"Added Horizontal slider.\r\n[MCKIN-7633](https://edx-wiki.atlassian.net/browse/MCKIN-7633)\r\nAdded [bxslider](http://jsfiddle.net/VgHb7/85/)","created_at":"2018-06-13T08:27:18Z","updated_at":"2018-07-10T04:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce3b0c8fbc9ee0fb8b5126e75110ba82cd0ac709","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/160/comments","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/4721c0444f526bcd1f47eb2e7a644929c8d4b0e8","head":{"label":"jawad-khan:MCKIN-7633","ref":"MCKIN-7633","sha":"4721c0444f526bcd1f47eb2e7a644929c8d4b0e8","user":{"login":"jawad-khan","id":5320368,"node_id":"MDQ6VXNlcjUzMjAzNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/5320368?v=4","gravatar_id":"","url":"https://api.github.com/users/jawad-khan","html_url":"https://github.com/jawad-khan","followers_url":"https://api.github.com/users/jawad-khan/followers","following_url":"https://api.github.com/users/jawad-khan/following{/other_user}","gists_url":"https://api.github.com/users/jawad-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/jawad-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawad-khan/subscriptions","organizations_url":"https://api.github.com/users/jawad-khan/orgs","repos_url":"https://api.github.com/users/jawad-khan/repos","events_url":"https://api.github.com/users/jawad-khan/events{/privacy}","received_events_url":"https://api.github.com/users/jawad-khan/received_events","type":"User","site_admin":false},"repo":{"id":136916571,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MTY1NzE=","name":"xblock-drag-and-drop-v2","full_name":"jawad-khan/xblock-drag-and-drop-v2","owner":{"login":"jawad-khan","id":5320368,"node_id":"MDQ6VXNlcjUzMjAzNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/5320368?v=4","gravatar_id":"","url":"https://api.github.com/users/jawad-khan","html_url":"https://github.com/jawad-khan","followers_url":"https://api.github.com/users/jawad-khan/followers","following_url":"https://api.github.com/users/jawad-khan/following{/other_user}","gists_url":"https://api.github.com/users/jawad-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/jawad-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawad-khan/subscriptions","organizations_url":"https://api.github.com/users/jawad-khan/orgs","repos_url":"https://api.github.com/users/jawad-khan/repos","events_url":"https://api.github.com/users/jawad-khan/events{/privacy}","received_events_url":"https://api.github.com/users/jawad-khan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jawad-khan/xblock-drag-and-drop-v2","description":null,"fork":true,"url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/jawad-khan/xblock-drag-and-drop-v2/deployments","created_at":"2018-06-11T11:24:38Z","updated_at":"2018-06-11T11:24:40Z","pushed_at":"2018-07-09T21:00:01Z","git_url":"git://github.com/jawad-khan/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:jawad-khan/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/jawad-khan/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/jawad-khan/xblock-drag-and-drop-v2","homepage":null,"size":2079,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx-solutions:drag-and-drop-v4","ref":"drag-and-drop-v4","sha":"fd27e9e69ae3ba023217e332602d1ff7f223a17e","user":{"login":"edx-solutions","id":6585054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":21356168,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM1NjE2OA==","name":"xblock-drag-and-drop-v2","full_name":"edx-solutions/xblock-drag-and-drop-v2","owner":{"login":"edx-solutions","id":6585054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/deployments","created_at":"2014-06-30T15:30:30Z","updated_at":"2018-05-15T00:01:01Z","pushed_at":"2018-07-09T21:00:03Z","git_url":"git://github.com/edx-solutions/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:edx-solutions/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","homepage":null,"size":2054,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":28,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/160"},"issue":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/160"},"comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/4721c0444f526bcd1f47eb2e7a644929c8d4b0e8"}},"author_association":"NONE"}}
{"actor":{"display_login":"pomegranited"}}