{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168943732","pull_request_review_id":97395640,"id":168943732,"diff_hunk":"@@ -6,27 +6,24 @@\n  * Represents a Person's address in the address book.\n  * Guarantees: immutable; is valid as declared in {@link #isValidAddress(String)}\n  */\n-public class Address {\n+public class Address extends Contact {\n \n     public static final String EXAMPLE = \"123, some street\";\n     public static final String MESSAGE_ADDRESS_CONSTRAINTS = \"Person addresses can be in any format\";\n     public static final String ADDRESS_VALIDATION_REGEX = \".+\";\n \n-    public final String value;\n-    private boolean isPrivate;\n-\n     /**\n      * Validates given address.\n      *\n      * @throws IllegalValueException if given address string is invalid.\n      */\n     public Address(String address, boolean isPrivate) throws IllegalValueException {\n+        super(isPrivate);\n         String trimmedAddress = address.trim();\n-        this.isPrivate = isPrivate;\n         if (!isValidAddress(trimmedAddress)) {\n             throw new IllegalValueException(MESSAGE_ADDRESS_CONSTRAINTS);\n         }\n-        this.value = trimmedAddress;\n+        setValue(trimmedAddress);","path":"src/seedu/addressbook/data/person/Address.java","position":27,"original_position":27,"commit_id":"18bc8604f8b98d3a0e606e66d5e6379b70f33bd6","original_commit_id":"18bc8604f8b98d3a0e606e66d5e6379b70f33bd6","user":{"login":"eugenepeh","id":19277206,"avatar_url":"https://avatars2.githubusercontent.com/u/19277206?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenepeh","html_url":"https://github.com/eugenepeh","followers_url":"https://api.github.com/users/eugenepeh/followers","following_url":"https://api.github.com/users/eugenepeh/following{/other_user}","gists_url":"https://api.github.com/users/eugenepeh/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenepeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenepeh/subscriptions","organizations_url":"https://api.github.com/users/eugenepeh/orgs","repos_url":"https://api.github.com/users/eugenepeh/repos","events_url":"https://api.github.com/users/eugenepeh/events{/privacy}","received_events_url":"https://api.github.com/users/eugenepeh/received_events","type":"User","site_admin":false},"body":"You can reduce the constructor code for each class by pushing them to the parent class","created_at":"2018-02-18T08:44:12Z","updated_at":"2018-02-18T08:49:04Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306#discussion_r168943732","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168943732"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306#discussion_r168943732"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306","id":168454346,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/306","number":306,"state":"open","locked":false,"title":"[W5.3b][W09-A2] Jethro Kuan","user":{"login":"jethrokuan","id":1667473,"avatar_url":"https://avatars0.githubusercontent.com/u/1667473?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrokuan","html_url":"https://github.com/jethrokuan","followers_url":"https://api.github.com/users/jethrokuan/followers","following_url":"https://api.github.com/users/jethrokuan/following{/other_user}","gists_url":"https://api.github.com/users/jethrokuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrokuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrokuan/subscriptions","organizations_url":"https://api.github.com/users/jethrokuan/orgs","repos_url":"https://api.github.com/users/jethrokuan/repos","events_url":"https://api.github.com/users/jethrokuan/events{/privacy}","received_events_url":"https://api.github.com/users/jethrokuan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-11T13:49:22Z","updated_at":"2018-02-18T08:49:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9cb8aa629df513e0fdd36cf448f721a1652934","assignee":{"login":"hwkchia","id":16570616,"avatar_url":"https://avatars2.githubusercontent.com/u/16570616?v=4","gravatar_id":"","url":"https://api.github.com/users/hwkchia","html_url":"https://github.com/hwkchia","followers_url":"https://api.github.com/users/hwkchia/followers","following_url":"https://api.github.com/users/hwkchia/following{/other_user}","gists_url":"https://api.github.com/users/hwkchia/gists{/gist_id}","starred_url":"https://api.github.com/users/hwkchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwkchia/subscriptions","organizations_url":"https://api.github.com/users/hwkchia/orgs","repos_url":"https://api.github.com/users/hwkchia/repos","events_url":"https://api.github.com/users/hwkchia/events{/privacy}","received_events_url":"https://api.github.com/users/hwkchia/received_events","type":"User","site_admin":false},"assignees":[{"login":"hwkchia","id":16570616,"avatar_url":"https://avatars2.githubusercontent.com/u/16570616?v=4","gravatar_id":"","url":"https://api.github.com/users/hwkchia","html_url":"https://github.com/hwkchia","followers_url":"https://api.github.com/users/hwkchia/followers","following_url":"https://api.github.com/users/hwkchia/following{/other_user}","gists_url":"https://api.github.com/users/hwkchia/gists{/gist_id}","starred_url":"https://api.github.com/users/hwkchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwkchia/subscriptions","organizations_url":"https://api.github.com/users/hwkchia/orgs","repos_url":"https://api.github.com/users/hwkchia/repos","events_url":"https://api.github.com/users/hwkchia/events{/privacy}","received_events_url":"https://api.github.com/users/hwkchia/received_events","type":"User","site_admin":false},{"login":"eugenepeh","id":19277206,"avatar_url":"https://avatars2.githubusercontent.com/u/19277206?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenepeh","html_url":"https://github.com/eugenepeh","followers_url":"https://api.github.com/users/eugenepeh/followers","following_url":"https://api.github.com/users/eugenepeh/following{/other_user}","gists_url":"https://api.github.com/users/eugenepeh/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenepeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenepeh/subscriptions","organizations_url":"https://api.github.com/users/eugenepeh/orgs","repos_url":"https://api.github.com/users/eugenepeh/repos","events_url":"https://api.github.com/users/eugenepeh/events{/privacy}","received_events_url":"https://api.github.com/users/eugenepeh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873038,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A2","name":"team.A2","color":"ededed","default":false},{"id":784873267,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.W09","name":"tutorial.W09","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/306/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/18bc8604f8b98d3a0e606e66d5e6379b70f33bd6","head":{"label":"jethrokuan:feat/W5.3b","ref":"feat/W5.3b","sha":"18bc8604f8b98d3a0e606e66d5e6379b70f33bd6","user":{"login":"jethrokuan","id":1667473,"avatar_url":"https://avatars0.githubusercontent.com/u/1667473?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrokuan","html_url":"https://github.com/jethrokuan","followers_url":"https://api.github.com/users/jethrokuan/followers","following_url":"https://api.github.com/users/jethrokuan/following{/other_user}","gists_url":"https://api.github.com/users/jethrokuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrokuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrokuan/subscriptions","organizations_url":"https://api.github.com/users/jethrokuan/orgs","repos_url":"https://api.github.com/users/jethrokuan/repos","events_url":"https://api.github.com/users/jethrokuan/events{/privacy}","received_events_url":"https://api.github.com/users/jethrokuan/received_events","type":"User","site_admin":false},"repo":{"id":120256132,"name":"addressbook-level2","full_name":"jethrokuan/addressbook-level2","owner":{"login":"jethrokuan","id":1667473,"avatar_url":"https://avatars0.githubusercontent.com/u/1667473?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrokuan","html_url":"https://github.com/jethrokuan","followers_url":"https://api.github.com/users/jethrokuan/followers","following_url":"https://api.github.com/users/jethrokuan/following{/other_user}","gists_url":"https://api.github.com/users/jethrokuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrokuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrokuan/subscriptions","organizations_url":"https://api.github.com/users/jethrokuan/orgs","repos_url":"https://api.github.com/users/jethrokuan/repos","events_url":"https://api.github.com/users/jethrokuan/events{/privacy}","received_events_url":"https://api.github.com/users/jethrokuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jethrokuan/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/jethrokuan/addressbook-level2","forks_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/forks","keys_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/events","assignees_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/merges","archive_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/jethrokuan/addressbook-level2/deployments","created_at":"2018-02-05T04:47:27Z","updated_at":"2018-02-05T04:47:29Z","pushed_at":"2018-02-14T01:36:34Z","git_url":"git://github.com/jethrokuan/addressbook-level2.git","ssh_url":"git@github.com:jethrokuan/addressbook-level2.git","clone_url":"https://github.com/jethrokuan/addressbook-level2.git","svn_url":"https://github.com/jethrokuan/addressbook-level2","homepage":null,"size":3309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-18T02:32:33Z","pushed_at":"2018-02-18T08:30:31Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":486,"license":null,"forks":187,"open_issues":486,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/306"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/306"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/18bc8604f8b98d3a0e606e66d5e6379b70f33bd6"}},"author_association":"NONE"}}
{"actor":{"display_login":"eugenepeh"}}