{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/comments/244654293","pull_request_review_id":188574963,"id":244654293,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY1NDI5Mw==","diff_hunk":"@@ -36,22 +36,20 @@ def check_package(package_name, minimum_version=None, verbose=True):\n     return errors\n \n \n-pkgs = {'IPython': '5.1',\n-        'notebook': '4.2.3',\n-        'numpy': '1.7',\n-        'scipy': '0.15',\n-        'matplotlib': '1.3',\n-        'astropy': '1.2.1',\n-        'photutils': '0.4',\n-        'skimage': '0.12.3',\n-        'pandas': '0.18.1',\n+pkgs = {'IPython': '7.2',\n+        'notebook': '5.7',\n+        'numpy': '1.14',\n+        'scipy': '1.1',\n+        'matplotlib': '2.0',","path":"00-Install_and_Setup/check_env.py","position":null,"original_position":17,"commit_id":"363158d4bc3f3e0c6fe7c5e105b0238045f935a3","original_commit_id":"9288bae034a08fbe212bd3163ff55947fefe107a","user":{"login":"JuanCab","id":1940512,"node_id":"MDQ6VXNlcjE5NDA1MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1940512?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanCab","html_url":"https://github.com/JuanCab","followers_url":"https://api.github.com/users/JuanCab/followers","following_url":"https://api.github.com/users/JuanCab/following{/other_user}","gists_url":"https://api.github.com/users/JuanCab/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanCab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanCab/subscriptions","organizations_url":"https://api.github.com/users/JuanCab/orgs","repos_url":"https://api.github.com/users/JuanCab/repos","events_url":"https://api.github.com/users/JuanCab/events{/privacy}","received_events_url":"https://api.github.com/users/JuanCab/received_events","type":"User","site_admin":false},"body":"Just addressed it.\r\n","created_at":"2019-01-02T01:44:29Z","updated_at":"2019-01-02T01:44:29Z","html_url":"https://github.com/astropy/astropy-workshop/pull/31#discussion_r244654293","pull_request_url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/comments/244654293"},"html":{"href":"https://github.com/astropy/astropy-workshop/pull/31#discussion_r244654293"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31"}},"in_reply_to_id":244654252},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31","id":241516043,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTE2MDQz","html_url":"https://github.com/astropy/astropy-workshop/pull/31","diff_url":"https://github.com/astropy/astropy-workshop/pull/31.diff","patch_url":"https://github.com/astropy/astropy-workshop/pull/31.patch","issue_url":"https://api.github.com/repos/astropy/astropy-workshop/issues/31","number":31,"state":"open","locked":false,"title":"Various fixes to allow tutorials to work with astropy 3.1 (and python 3.6)","user":{"login":"JuanCab","id":1940512,"node_id":"MDQ6VXNlcjE5NDA1MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1940512?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanCab","html_url":"https://github.com/JuanCab","followers_url":"https://api.github.com/users/JuanCab/followers","following_url":"https://api.github.com/users/JuanCab/following{/other_user}","gists_url":"https://api.github.com/users/JuanCab/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanCab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanCab/subscriptions","organizations_url":"https://api.github.com/users/JuanCab/orgs","repos_url":"https://api.github.com/users/JuanCab/repos","events_url":"https://api.github.com/users/JuanCab/events{/privacy}","received_events_url":"https://api.github.com/users/JuanCab/received_events","type":"User","site_admin":false},"body":"I've been retesting the tutorial using the current astropy 3.1 and have found the following issues needing resolving:\r\n\r\n1.  I am running into an error in **03-UnitsQuantities/Astropy_Units.ipynb**.  When I execute the cell containing:  `u.add_enabled_units([h100, h70])`  I am getting an error reported that `ValueError: Object with name 'littleh' already exists in namespace. Filter the set of units to avoid name clashes before enabling them.`  The error appears to exist because for some reason 'littleh' is treated as an existing unit. (Probably because it was added in astropy 3.1, incorrectly according to  https://github.com/astropy/astropy/issues/8271). Removing the declaration of the littleh unit with h100 seems to have fixed this.  If there is another solution out there, I would love to hear it.\r\n\r\n2. Apparently `xlwt` wasn't caught as a required library to install in order to allow **06-Tables/Tables.ipynb** to run, specifically, the library is required by pandas to allow import of excel files.  I suspect the bug is a conda bug in that the requirement should have been caught.  Fixed the `environment.yml` file to include this in its list of required packages.\r\n\r\n3. Added `imexam` to `environment.yml` file to so that it will be available for the **09-Photutils/image_psf_photometry_withNIRCam.ipynb** notebook if needed.  I have confirmed that the `environment.yml` setup works for macOS and windows-64bit using conda and linux using miniconda.\r\n\r\n4. I removed superfluous \"from __future__ import print_function, division\" lines from various notebooks since we are forcing use of python 3.6 in the `environment.yml` file.  This resolves issue #25 I believe.\r\n\r\n5. Removed notebook output accidentally included in repo in **04-Coordinates/astropy_coordinates.ipynb**.\r\n\r\n6. Updated `check_env.py` in the **00-Install_and_Setup** directory to check out properly on macos/windows/linux under the new `environment.yml` setup.\r\n\r\nOnce these issues are resolved, everything will run in the `astropy-workshop` environment with astropy 3.1 EXCEPT that the `imexam` example in **09-Photutils/image_psf_photometry_withNIRCam.ipynb** will throw an error for reasons cited in issue #29 .","created_at":"2018-12-31T00:18:21Z","updated_at":"2019-01-02T01:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6730d51c8b1ba16b59623dd8f855e20a4308da2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy-workshop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy-workshop/issues/31/comments","statuses_url":"https://api.github.com/repos/astropy/astropy-workshop/statuses/363158d4bc3f3e0c6fe7c5e105b0238045f935a3","head":{"label":"JuanCab:astropy31_fixes","ref":"astropy31_fixes","sha":"363158d4bc3f3e0c6fe7c5e105b0238045f935a3","user":{"login":"JuanCab","id":1940512,"node_id":"MDQ6VXNlcjE5NDA1MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1940512?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanCab","html_url":"https://github.com/JuanCab","followers_url":"https://api.github.com/users/JuanCab/followers","following_url":"https://api.github.com/users/JuanCab/following{/other_user}","gists_url":"https://api.github.com/users/JuanCab/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanCab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanCab/subscriptions","organizations_url":"https://api.github.com/users/JuanCab/orgs","repos_url":"https://api.github.com/users/JuanCab/repos","events_url":"https://api.github.com/users/JuanCab/events{/privacy}","received_events_url":"https://api.github.com/users/JuanCab/received_events","type":"User","site_admin":false},"repo":{"id":160431641,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MzE2NDE=","name":"astropy-workshop","full_name":"JuanCab/astropy-workshop","private":false,"owner":{"login":"JuanCab","id":1940512,"node_id":"MDQ6VXNlcjE5NDA1MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1940512?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanCab","html_url":"https://github.com/JuanCab","followers_url":"https://api.github.com/users/JuanCab/followers","following_url":"https://api.github.com/users/JuanCab/following{/other_user}","gists_url":"https://api.github.com/users/JuanCab/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanCab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanCab/subscriptions","organizations_url":"https://api.github.com/users/JuanCab/orgs","repos_url":"https://api.github.com/users/JuanCab/repos","events_url":"https://api.github.com/users/JuanCab/events{/privacy}","received_events_url":"https://api.github.com/users/JuanCab/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JuanCab/astropy-workshop","description":"Materials for Astropy Workshop","fork":true,"url":"https://api.github.com/repos/JuanCab/astropy-workshop","forks_url":"https://api.github.com/repos/JuanCab/astropy-workshop/forks","keys_url":"https://api.github.com/repos/JuanCab/astropy-workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuanCab/astropy-workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuanCab/astropy-workshop/teams","hooks_url":"https://api.github.com/repos/JuanCab/astropy-workshop/hooks","issue_events_url":"https://api.github.com/repos/JuanCab/astropy-workshop/issues/events{/number}","events_url":"https://api.github.com/repos/JuanCab/astropy-workshop/events","assignees_url":"https://api.github.com/repos/JuanCab/astropy-workshop/assignees{/user}","branches_url":"https://api.github.com/repos/JuanCab/astropy-workshop/branches{/branch}","tags_url":"https://api.github.com/repos/JuanCab/astropy-workshop/tags","blobs_url":"https://api.github.com/repos/JuanCab/astropy-workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuanCab/astropy-workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuanCab/astropy-workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuanCab/astropy-workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuanCab/astropy-workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/JuanCab/astropy-workshop/languages","stargazers_url":"https://api.github.com/repos/JuanCab/astropy-workshop/stargazers","contributors_url":"https://api.github.com/repos/JuanCab/astropy-workshop/contributors","subscribers_url":"https://api.github.com/repos/JuanCab/astropy-workshop/subscribers","subscription_url":"https://api.github.com/repos/JuanCab/astropy-workshop/subscription","commits_url":"https://api.github.com/repos/JuanCab/astropy-workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuanCab/astropy-workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuanCab/astropy-workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuanCab/astropy-workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuanCab/astropy-workshop/contents/{+path}","compare_url":"https://api.github.com/repos/JuanCab/astropy-workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuanCab/astropy-workshop/merges","archive_url":"https://api.github.com/repos/JuanCab/astropy-workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuanCab/astropy-workshop/downloads","issues_url":"https://api.github.com/repos/JuanCab/astropy-workshop/issues{/number}","pulls_url":"https://api.github.com/repos/JuanCab/astropy-workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/JuanCab/astropy-workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/JuanCab/astropy-workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuanCab/astropy-workshop/labels{/name}","releases_url":"https://api.github.com/repos/JuanCab/astropy-workshop/releases{/id}","deployments_url":"https://api.github.com/repos/JuanCab/astropy-workshop/deployments","created_at":"2018-12-04T23:23:56Z","updated_at":"2018-12-28T20:12:03Z","pushed_at":"2019-01-02T01:44:16Z","git_url":"git://github.com/JuanCab/astropy-workshop.git","ssh_url":"git@github.com:JuanCab/astropy-workshop.git","clone_url":"https://github.com/JuanCab/astropy-workshop.git","svn_url":"https://github.com/JuanCab/astropy-workshop","homepage":"","size":117711,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"07b5802891c099ca035815ff591f995401b39e2a","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":116093743,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwOTM3NDM=","name":"astropy-workshop","full_name":"astropy/astropy-workshop","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astropy-workshop","description":"Materials for Astropy Workshop","fork":false,"url":"https://api.github.com/repos/astropy/astropy-workshop","forks_url":"https://api.github.com/repos/astropy/astropy-workshop/forks","keys_url":"https://api.github.com/repos/astropy/astropy-workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy-workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy-workshop/teams","hooks_url":"https://api.github.com/repos/astropy/astropy-workshop/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy-workshop/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy-workshop/events","assignees_url":"https://api.github.com/repos/astropy/astropy-workshop/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy-workshop/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy-workshop/tags","blobs_url":"https://api.github.com/repos/astropy/astropy-workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy-workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy-workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy-workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy-workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy-workshop/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy-workshop/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy-workshop/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy-workshop/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy-workshop/subscription","commits_url":"https://api.github.com/repos/astropy/astropy-workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy-workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy-workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy-workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy-workshop/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy-workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy-workshop/merges","archive_url":"https://api.github.com/repos/astropy/astropy-workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy-workshop/downloads","issues_url":"https://api.github.com/repos/astropy/astropy-workshop/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy-workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy-workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy-workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy-workshop/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy-workshop/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy-workshop/deployments","created_at":"2018-01-03T05:05:47Z","updated_at":"2018-12-28T19:26:45Z","pushed_at":"2019-01-02T01:44:17Z","git_url":"git://github.com/astropy/astropy-workshop.git","ssh_url":"git@github.com:astropy/astropy-workshop.git","clone_url":"https://github.com/astropy/astropy-workshop.git","svn_url":"https://github.com/astropy/astropy-workshop","homepage":"","size":60784,"stargazers_count":7,"watchers_count":7,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":14,"open_issues":14,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31"},"html":{"href":"https://github.com/astropy/astropy-workshop/pull/31"},"issue":{"href":"https://api.github.com/repos/astropy/astropy-workshop/issues/31"},"comments":{"href":"https://api.github.com/repos/astropy/astropy-workshop/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy-workshop/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy-workshop/statuses/363158d4bc3f3e0c6fe7c5e105b0238045f935a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JuanCab"}}