{"action":"created","issue":{"url":"https://api.github.com/repos/teamcapybara/capybara/issues/1972","repository_url":"https://api.github.com/repos/teamcapybara/capybara","labels_url":"https://api.github.com/repos/teamcapybara/capybara/issues/1972/labels{/name}","comments_url":"https://api.github.com/repos/teamcapybara/capybara/issues/1972/comments","events_url":"https://api.github.com/repos/teamcapybara/capybara/issues/1972/events","html_url":"https://github.com/teamcapybara/capybara/pull/1972","id":297897685,"number":1972,"title":"[comments only] Clarify semantics of Finders#first","user":{"login":"ms-ati","id":592892,"avatar_url":"https://avatars2.githubusercontent.com/u/592892?v=4","gravatar_id":"","url":"https://api.github.com/users/ms-ati","html_url":"https://github.com/ms-ati","followers_url":"https://api.github.com/users/ms-ati/followers","following_url":"https://api.github.com/users/ms-ati/following{/other_user}","gists_url":"https://api.github.com/users/ms-ati/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-ati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-ati/subscriptions","organizations_url":"https://api.github.com/users/ms-ati/orgs","repos_url":"https://api.github.com/users/ms-ati/repos","events_url":"https://api.github.com/users/ms-ati/events{/privacy}","received_events_url":"https://api.github.com/users/ms-ati/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-16T19:39:57Z","updated_at":"2018-02-21T20:33:18Z","closed_at":"2018-02-21T20:33:18Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/teamcapybara/capybara/pulls/1972","html_url":"https://github.com/teamcapybara/capybara/pull/1972","diff_url":"https://github.com/teamcapybara/capybara/pull/1972.diff","patch_url":"https://github.com/teamcapybara/capybara/pull/1972.patch"},"body":"Proposed change is only to documentation comments, to clarify the semantics\r\naround exactly when and how the `Finders#first` method can be changed from\r\nthe default behavior (of throwing an exception) to the alternate behavior (of\r\nreturning `nil`) when no matching element is found before the max wait time\r\nexpires.\r\n\r\ncc @twalpole\r\n\r\nSee original discussion on #1971"},"comment":{"url":"https://api.github.com/repos/teamcapybara/capybara/issues/comments/367462413","html_url":"https://github.com/teamcapybara/capybara/pull/1972#issuecomment-367462413","issue_url":"https://api.github.com/repos/teamcapybara/capybara/issues/1972","id":367462413,"user":{"login":"twalpole","id":16556,"avatar_url":"https://avatars2.githubusercontent.com/u/16556?v=4","gravatar_id":"","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T20:33:18Z","updated_at":"2018-02-21T20:33:18Z","author_association":"COLLABORATOR","body":"@ms-ati Sorry -- though I commented -- closing in favor of PR #1973 which add more tests to confirm the full behavior of this."}}
{"actor":{"display_login":"twalpole"}}