{"action":"created","comment":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments/221768026","pull_request_review_id":160499497,"id":221768026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc2ODAyNg==","diff_hunk":"@@ -1560,6 +1560,9 @@ def _create_or_update_list(self, library, name, entries, collections, deletedEnt\n         list.name = name\n         membership_change = False\n \n+        if deleteAll:\n+            list.entries = []","path":"api/admin/controller.py","position":91,"original_position":14,"commit_id":"64e5099d3c676564f0931f4df7c079b28a296dca","original_commit_id":"64e5099d3c676564f0931f4df7c079b28a296dca","user":{"login":"aslagle","id":3409215,"node_id":"MDQ6VXNlcjM0MDkyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3409215?v=4","gravatar_id":"","url":"https://api.github.com/users/aslagle","html_url":"https://github.com/aslagle","followers_url":"https://api.github.com/users/aslagle/followers","following_url":"https://api.github.com/users/aslagle/following{/other_user}","gists_url":"https://api.github.com/users/aslagle/gists{/gist_id}","starred_url":"https://api.github.com/users/aslagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslagle/subscriptions","organizations_url":"https://api.github.com/users/aslagle/orgs","repos_url":"https://api.github.com/users/aslagle/repos","events_url":"https://api.github.com/users/aslagle/events{/privacy}","received_events_url":"https://api.github.com/users/aslagle/received_events","type":"User","site_admin":false},"body":"I think this might leave the CustomListEntry rows in the database, detached from their list. We may need to modify that relationship in the model so they get deleted. Otherwise this approach seems good.","created_at":"2018-10-01T21:49:09Z","updated_at":"2018-10-01T21:49:09Z","html_url":"https://github.com/NYPL-Simplified/circulation/pull/1043#discussion_r221768026","pull_request_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments/221768026"},"html":{"href":"https://github.com/NYPL-Simplified/circulation/pull/1043#discussion_r221768026"},"pull_request":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043"}},"in_reply_to_id":221708583},"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043","id":213404950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDA0OTUw","html_url":"https://github.com/NYPL-Simplified/circulation/pull/1043","diff_url":"https://github.com/NYPL-Simplified/circulation/pull/1043.diff","patch_url":"https://github.com/NYPL-Simplified/circulation/pull/1043.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/1043","number":1043,"state":"open","locked":false,"title":"Fetching opds custom list","user":{"login":"EdwinGuzman","id":1280564,"node_id":"MDQ6VXNlcjEyODA1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1280564?v=4","gravatar_id":"","url":"https://api.github.com/users/EdwinGuzman","html_url":"https://github.com/EdwinGuzman","followers_url":"https://api.github.com/users/EdwinGuzman/followers","following_url":"https://api.github.com/users/EdwinGuzman/following{/other_user}","gists_url":"https://api.github.com/users/EdwinGuzman/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwinGuzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwinGuzman/subscriptions","organizations_url":"https://api.github.com/users/EdwinGuzman/orgs","repos_url":"https://api.github.com/users/EdwinGuzman/repos","events_url":"https://api.github.com/users/EdwinGuzman/events{/privacy}","received_events_url":"https://api.github.com/users/EdwinGuzman/received_events","type":"User","site_admin":false},"body":"I think this could use a bit more refactoring (and tests) but wanted to get this out here to break out the work. It may be easier to do this and work on the front-end at the same time for rendering this opds custom list feed, and then another PR for saving and deleting entries in the custom list. That way I won't hold up Adriana, too.","created_at":"2018-09-05T19:37:46Z","updated_at":"2018-10-01T21:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db57d5ba694ffe5d9458f1f977f5849b584a570f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":307740685,"node_id":"MDU6TGFiZWwzMDc3NDA2ODU=","url":"https://api.github.com/repos/NYPL-Simplified/circulation/labels/in%20review","name":"in review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/1043/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/64e5099d3c676564f0931f4df7c079b28a296dca","head":{"label":"NYPL-Simplified:fetching_opds_custom_list","ref":"fetching_opds_custom_list","sha":"64e5099d3c676564f0931f4df7c079b28a296dca","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27605405,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYwNTQwNQ==","name":"circulation","full_name":"NYPL-Simplified/circulation","private":false,"owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYPL-Simplified/circulation","description":"Circulation manager for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/deployments","created_at":"2014-12-05T18:53:04Z","updated_at":"2018-09-27T15:35:54Z","pushed_at":"2018-10-01T20:24:24Z","git_url":"git://github.com/NYPL-Simplified/circulation.git","ssh_url":"git@github.com:NYPL-Simplified/circulation.git","clone_url":"https://github.com/NYPL-Simplified/circulation.git","svn_url":"https://github.com/NYPL-Simplified/circulation","homepage":null,"size":9223,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":84,"license":null,"forks":12,"open_issues":84,"watchers":5,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"1d2ce7af3937867e322cd24f292af44b0989aa70","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27605405,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYwNTQwNQ==","name":"circulation","full_name":"NYPL-Simplified/circulation","private":false,"owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYPL-Simplified/circulation","description":"Circulation manager for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/deployments","created_at":"2014-12-05T18:53:04Z","updated_at":"2018-09-27T15:35:54Z","pushed_at":"2018-10-01T20:24:24Z","git_url":"git://github.com/NYPL-Simplified/circulation.git","ssh_url":"git@github.com:NYPL-Simplified/circulation.git","clone_url":"https://github.com/NYPL-Simplified/circulation.git","svn_url":"https://github.com/NYPL-Simplified/circulation","homepage":null,"size":9223,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":84,"license":null,"forks":12,"open_issues":84,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043"},"html":{"href":"https://github.com/NYPL-Simplified/circulation/pull/1043"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/1043"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/1043/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/1043/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/64e5099d3c676564f0931f4df7c079b28a296dca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aslagle"}}