{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/library-go/pulls/comments/239857875","pull_request_review_id":182758545,"id":239857875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg1Nzg3NQ==","diff_hunk":"@@ -114,42 +108,32 @@ func (c ConfigObserver) sync() error {\n \tif !equality.Semantic.DeepEqual(existingConfig, mergedObservedConfig) {\n \t\tglog.Infof(\"writing updated observedConfig: %v\", diff.ObjectDiff(existingConfig, mergedObservedConfig))\n \t\tspec.ObservedConfig = runtime.RawExtension{Object: &unstructured.Unstructured{Object: mergedObservedConfig}}\n-\t\t_, resourceVersion, err = c.operatorClient.UpdateOperatorSpec(resourceVersion, spec)\n+\t\t_, resourceVersion, err = c.operatorConfigClient.UpdateOperatorSpec(resourceVersion, spec)\n \t\tif err != nil {\n \t\t\terrs = append(errs, fmt.Errorf(\"error writing updated observed config: %v\", err))\n \t\t\tc.eventRecorder.Warningf(\"ObservedConfigWriteError\", \"Failed to write observed config: %v\", err)\n \t\t} else {\n \t\t\tc.eventRecorder.Eventf(\"ObservedConfigChanged\", \"Writing updated observed config\")\n \t\t}\n \t}\n+\terr = common.NewMultiLineAggregate(errs)\n \n-\tstatus := originalStatus.DeepCopy()\n-\tif len(errs) > 0 {\n-\t\tvar messages []string\n-\t\tfor _, currentError := range errs {\n-\t\t\tmessages = append(messages, currentError.Error())\n-\t\t}\n-\t\tv1helpers.SetOperatorCondition(&status.Conditions, operatorv1.OperatorCondition{\n-\t\t\tType:    operatorStatusTypeConfigObservationFailing,\n-\t\t\tStatus:  operatorv1.ConditionTrue,\n-\t\t\tReason:  configObservationErrorConditionReason,\n-\t\t\tMessage: strings.Join(messages, \"\\n\"),\n-\t\t})\n-\n-\t} else {\n-\t\tv1helpers.SetOperatorCondition(&status.Conditions, operatorv1.OperatorCondition{\n-\t\t\tType:   operatorStatusTypeConfigObservationFailing,\n-\t\t\tStatus: operatorv1.ConditionFalse,\n-\t\t})\n+\t// update failing condition\n+\tcond := operatorv1.OperatorCondition{\n+\t\tType:   operatorStatusTypeConfigObservationFailing,\n+\t\tStatus: operatorv1.ConditionFalse,\n \t}\n-\n-\tif !equality.Semantic.DeepEqual(originalStatus, status) {\n-\t\t_, _, err = c.operatorClient.UpdateOperatorStatus(resourceVersion, status)\n-\t\tif err != nil {\n-\t\t\treturn err\n-\t\t}\n+\tif err != nil {\n+\t\tcond.Status = operatorv1.ConditionTrue\n+\t\tcond.Reason = \"Error\"\n+\t\tcond.Message = err.Error()\n+\t}\n+\tif _, updateError := v1helpers.UpdateStatus(c.operatorConfigClient, v1helpers.UpdateConditionFn(cond)); updateError != nil {\n+\t\tglog.Error(updateError)","path":"pkg/operator/configobserver/config_observer_controller.go","position":122,"original_position":122,"commit_id":"4691c9d1c0837c2e46b3935acb8a12f0ed9b528a","original_commit_id":"ed8544e8342ea3615ced7d1aa5b29c24d3a1ae0a","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"Something for @mfojtik. There is still a \"more events\" PR open. @mfojtik what's the status of that?","created_at":"2018-12-07T16:02:03Z","updated_at":"2018-12-07T16:02:03Z","html_url":"https://github.com/openshift/library-go/pull/143#discussion_r239857875","pull_request_url":"https://api.github.com/repos/openshift/library-go/pulls/143","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/library-go/pulls/comments/239857875"},"html":{"href":"https://github.com/openshift/library-go/pull/143#discussion_r239857875"},"pull_request":{"href":"https://api.github.com/repos/openshift/library-go/pulls/143"}},"in_reply_to_id":239850482},"pull_request":{"url":"https://api.github.com/repos/openshift/library-go/pulls/143","id":236830659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODMwNjU5","html_url":"https://github.com/openshift/library-go/pull/143","diff_url":"https://github.com/openshift/library-go/pull/143.diff","patch_url":"https://github.com/openshift/library-go/pull/143.patch","issue_url":"https://api.github.com/repos/openshift/library-go/issues/143","number":143,"state":"open","locked":false,"title":"operator: unify status updates","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"- unify update status logic in sync funcs\n- use differential status updates with retries in static pod controllers","created_at":"2018-12-07T11:02:57Z","updated_at":"2018-12-07T16:02:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e20605bfea313c6c56302ded4188ea7b73e3780a","assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":930105872,"node_id":"MDU6TGFiZWw5MzAxMDU4NzI=","url":"https://api.github.com/repos/openshift/library-go/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":930108054,"node_id":"MDU6TGFiZWw5MzAxMDgwNTQ=","url":"https://api.github.com/repos/openshift/library-go/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/library-go/pulls/143/commits","review_comments_url":"https://api.github.com/repos/openshift/library-go/pulls/143/comments","review_comment_url":"https://api.github.com/repos/openshift/library-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/library-go/issues/143/comments","statuses_url":"https://api.github.com/repos/openshift/library-go/statuses/4691c9d1c0837c2e46b3935acb8a12f0ed9b528a","head":{"label":"sttts:sttts-uniform-status-failure","ref":"sttts-uniform-status-failure","sha":"4691c9d1c0837c2e46b3935acb8a12f0ed9b528a","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":149453543,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0NTM1NDM=","name":"library-go","full_name":"sttts/library-go","private":false,"owner":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sttts/library-go","description":"Helpers for going from apis and clients to useful runtime constructs","fork":true,"url":"https://api.github.com/repos/sttts/library-go","forks_url":"https://api.github.com/repos/sttts/library-go/forks","keys_url":"https://api.github.com/repos/sttts/library-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/library-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/library-go/teams","hooks_url":"https://api.github.com/repos/sttts/library-go/hooks","issue_events_url":"https://api.github.com/repos/sttts/library-go/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/library-go/events","assignees_url":"https://api.github.com/repos/sttts/library-go/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/library-go/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/library-go/tags","blobs_url":"https://api.github.com/repos/sttts/library-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/library-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/library-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/library-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/library-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/library-go/languages","stargazers_url":"https://api.github.com/repos/sttts/library-go/stargazers","contributors_url":"https://api.github.com/repos/sttts/library-go/contributors","subscribers_url":"https://api.github.com/repos/sttts/library-go/subscribers","subscription_url":"https://api.github.com/repos/sttts/library-go/subscription","commits_url":"https://api.github.com/repos/sttts/library-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/library-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/library-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/library-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/library-go/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/library-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/library-go/merges","archive_url":"https://api.github.com/repos/sttts/library-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/library-go/downloads","issues_url":"https://api.github.com/repos/sttts/library-go/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/library-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/library-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/library-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/library-go/labels{/name}","releases_url":"https://api.github.com/repos/sttts/library-go/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/library-go/deployments","created_at":"2018-09-19T13:17:13Z","updated_at":"2018-09-19T13:17:15Z","pushed_at":"2018-12-07T15:59:08Z","git_url":"git://github.com/sttts/library-go.git","ssh_url":"git@github.com:sttts/library-go.git","clone_url":"https://github.com/sttts/library-go.git","svn_url":"https://github.com/sttts/library-go","homepage":null,"size":20645,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fb2b2d81e39b0dcdbcac1d69aae0005b383d6a0f","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":132917906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MTc5MDY=","name":"library-go","full_name":"openshift/library-go","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/library-go","description":"Helpers for going from apis and clients to useful runtime constructs","fork":false,"url":"https://api.github.com/repos/openshift/library-go","forks_url":"https://api.github.com/repos/openshift/library-go/forks","keys_url":"https://api.github.com/repos/openshift/library-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/library-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/library-go/teams","hooks_url":"https://api.github.com/repos/openshift/library-go/hooks","issue_events_url":"https://api.github.com/repos/openshift/library-go/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/library-go/events","assignees_url":"https://api.github.com/repos/openshift/library-go/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/library-go/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/library-go/tags","blobs_url":"https://api.github.com/repos/openshift/library-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/library-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/library-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/library-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/library-go/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/library-go/languages","stargazers_url":"https://api.github.com/repos/openshift/library-go/stargazers","contributors_url":"https://api.github.com/repos/openshift/library-go/contributors","subscribers_url":"https://api.github.com/repos/openshift/library-go/subscribers","subscription_url":"https://api.github.com/repos/openshift/library-go/subscription","commits_url":"https://api.github.com/repos/openshift/library-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/library-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/library-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/library-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/library-go/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/library-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/library-go/merges","archive_url":"https://api.github.com/repos/openshift/library-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/library-go/downloads","issues_url":"https://api.github.com/repos/openshift/library-go/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/library-go/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/library-go/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/library-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/library-go/labels{/name}","releases_url":"https://api.github.com/repos/openshift/library-go/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/library-go/deployments","created_at":"2018-05-10T15:14:38Z","updated_at":"2018-12-06T11:06:06Z","pushed_at":"2018-12-07T15:59:10Z","git_url":"git://github.com/openshift/library-go.git","ssh_url":"git@github.com:openshift/library-go.git","clone_url":"https://github.com/openshift/library-go.git","svn_url":"https://github.com/openshift/library-go","homepage":null,"size":20628,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/library-go/pulls/143"},"html":{"href":"https://github.com/openshift/library-go/pull/143"},"issue":{"href":"https://api.github.com/repos/openshift/library-go/issues/143"},"comments":{"href":"https://api.github.com/repos/openshift/library-go/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/library-go/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/library-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/library-go/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/library-go/statuses/4691c9d1c0837c2e46b3935acb8a12f0ed9b528a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sttts"}}