{"action":"created","issue":{"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/223","repository_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes","labels_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/223/comments","events_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/223/events","html_url":"https://github.com/openvswitch/ovn-kubernetes/pull/223","id":296355221,"number":223,"title":"go-controller: Add Windows support for minion-init","user":{"login":"alinbalutoiu","id":12464768,"avatar_url":"https://avatars2.githubusercontent.com/u/12464768?v=4","gravatar_id":"","url":"https://api.github.com/users/alinbalutoiu","html_url":"https://github.com/alinbalutoiu","followers_url":"https://api.github.com/users/alinbalutoiu/followers","following_url":"https://api.github.com/users/alinbalutoiu/following{/other_user}","gists_url":"https://api.github.com/users/alinbalutoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alinbalutoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinbalutoiu/subscriptions","organizations_url":"https://api.github.com/users/alinbalutoiu/orgs","repos_url":"https://api.github.com/users/alinbalutoiu/repos","events_url":"https://api.github.com/users/alinbalutoiu/events{/privacy}","received_events_url":"https://api.github.com/users/alinbalutoiu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-12T12:15:55Z","updated_at":"2018-02-14T17:10:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/223","html_url":"https://github.com/openvswitch/ovn-kubernetes/pull/223","diff_url":"https://github.com/openvswitch/ovn-kubernetes/pull/223.diff","patch_url":"https://github.com/openvswitch/ovn-kubernetes/pull/223.patch"},"body":"This patch adds support for doing minion-init on a Windows host.\r\n\r\nThe following changes were made:\r\n- Add check for master / gateway init on Windows hosts which is\r\ncurrently not supported\r\n- Update build scripts to compile the Windows version of ovnkube.\r\nThe binary will be found in _output/go/windows/ovnkube.exe\r\n- Moved the gatewayInit code in another file and added conditional\r\ncompilation. The gatewayInit is making use of \"github.com/vishvananda/netlink\"\r\npackage which does not compile on Windows.\r\n- Implemented configureManagementPort for Windows. Added the equivalent\r\ncommands for enabling the interface, setting IP and the rest.\r\n- Added conditional compilation for nicstobridge.go which is used\r\nonly in gatewayInit and imports the package \"github.com/vishvananda/netlink\"\r\n- Added equivalent commands to start / restart the\r\nopenvswitch / ovn-controller services on Windows\r\n\r\nThe make command will also build the ovnkube.exe binary for Windows which will be placed under _output/go/windows\r\n\r\nSigned-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>"},"comment":{"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/comments/365677114","html_url":"https://github.com/openvswitch/ovn-kubernetes/pull/223#issuecomment-365677114","issue_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/223","id":365677114,"user":{"login":"shettyg","id":4305021,"avatar_url":"https://avatars1.githubusercontent.com/u/4305021?v=4","gravatar_id":"","url":"https://api.github.com/users/shettyg","html_url":"https://github.com/shettyg","followers_url":"https://api.github.com/users/shettyg/followers","following_url":"https://api.github.com/users/shettyg/following{/other_user}","gists_url":"https://api.github.com/users/shettyg/gists{/gist_id}","starred_url":"https://api.github.com/users/shettyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shettyg/subscriptions","organizations_url":"https://api.github.com/users/shettyg/orgs","repos_url":"https://api.github.com/users/shettyg/repos","events_url":"https://api.github.com/users/shettyg/events{/privacy}","received_events_url":"https://api.github.com/users/shettyg/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T17:10:24Z","updated_at":"2018-02-14T17:10:24Z","author_association":"CONTRIBUTOR","body":"For some reason, this doubles the compilation time for ovnkube. Yet to see why."}}
{"actor":{"display_login":"shettyg"}}