{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/173","repository_url":"https://api.github.com/repos/CartoDB/renderer-prototype","labels_url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/173/comments","events_url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/173/events","html_url":"https://github.com/CartoDB/renderer-prototype/pull/173","id":305294213,"number":173,"title":"Refactor dataframe","user":{"login":"IagoLast","id":2657897,"avatar_url":"https://avatars0.githubusercontent.com/u/2657897?v=4","gravatar_id":"","url":"https://api.github.com/users/IagoLast","html_url":"https://github.com/IagoLast","followers_url":"https://api.github.com/users/IagoLast/followers","following_url":"https://api.github.com/users/IagoLast/following{/other_user}","gists_url":"https://api.github.com/users/IagoLast/gists{/gist_id}","starred_url":"https://api.github.com/users/IagoLast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IagoLast/subscriptions","organizations_url":"https://api.github.com/users/IagoLast/orgs","repos_url":"https://api.github.com/users/IagoLast/repos","events_url":"https://api.github.com/users/IagoLast/events{/privacy}","received_events_url":"https://api.github.com/users/IagoLast/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-14T19:16:08Z","updated_at":"2018-03-15T10:33:06Z","closed_at":"2018-03-15T09:54:49Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/CartoDB/renderer-prototype/pulls/173","html_url":"https://github.com/CartoDB/renderer-prototype/pull/173","diff_url":"https://github.com/CartoDB/renderer-prototype/pull/173.diff","patch_url":"https://github.com/CartoDB/renderer-prototype/pull/173.patch"},"body":"- Refactor dataframe constructor\r\n- Dataframe.setStyle is defined in the class\r\n- Move geometry decoding logic to its own file"},"comment":{"url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/comments/373331288","html_url":"https://github.com/CartoDB/renderer-prototype/pull/173#issuecomment-373331288","issue_url":"https://api.github.com/repos/CartoDB/renderer-prototype/issues/173","id":373331288,"user":{"login":"davidmanzanares","id":1692175,"avatar_url":"https://avatars2.githubusercontent.com/u/1692175?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmanzanares","html_url":"https://github.com/davidmanzanares","followers_url":"https://api.github.com/users/davidmanzanares/followers","following_url":"https://api.github.com/users/davidmanzanares/following{/other_user}","gists_url":"https://api.github.com/users/davidmanzanares/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmanzanares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmanzanares/subscriptions","organizations_url":"https://api.github.com/users/davidmanzanares/orgs","repos_url":"https://api.github.com/users/davidmanzanares/repos","events_url":"https://api.github.com/users/davidmanzanares/events{/privacy}","received_events_url":"https://api.github.com/users/davidmanzanares/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T10:33:06Z","updated_at":"2018-03-15T10:33:06Z","author_association":"COLLABORATOR","body":"@IagoLast The problem with that is that you need access to the WebGL context. `bind()` is called right now by the renderer once when the dataframe is added to the dataframe, so, it is only done once.\r\n\r\nHowever, there are some possible optimizations here that could be used in a mid-term future. The decode geometry pass is JS (CPU) heavy, particularly the earcut algorithm. If we find this is a performance problem we can try to solve it by using webworkers, and to do that we'll need to subdivide `bind()`\r\n\r\nIn any case, I think this is a future problem :smile:"}}
{"actor":{"display_login":"davidmanzanares"}}