{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/comments/177204143","pull_request_review_id":107037579,"id":177204143,"diff_hunk":"@@ -613,7 +613,21 @@ def __init__(self, socket, pydevd, logfile=None, killonclose=True):\n         self.event_loop_thread.daemon = True\n         self.event_loop_thread.start()\n \n+    def __input(self, message):","path":"ptvsd/wrapper.py","position":13,"original_position":13,"commit_id":"a2e955d17643809dbbbb5752811b7a1aa329aff6","original_commit_id":"a2e955d17643809dbbbb5752811b7a1aa329aff6","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"To facilitate testing this, I'd recommend making the \"input\" function an attribute of VSCodeMessageProcessor:\r\n\r\n    def __init__(self, ..., inputfunc=None, ...):\r\n        ...\r\n        try:\r\n            self.inputfunc = raw_input\r\n        except NameError:\r\n            self.inputfunc = input\r\n        ...\r\n\r\nThen in _handle_exit() just call self.inputfunc().\r\n\r\nThen for the test machinery you'll need to pass an appropriate inputfunc.  Look for any place we pass `killonclose=False`.  There should be a couple of spots, both under tests/helpers/pydevd/.\r\n\r\nAlso, FYI, using \"__\"-prefixed names is discouraged in Python.  A single underscore should be sufficient.","created_at":"2018-03-26T19:17:28Z","updated_at":"2018-03-26T19:17:42Z","html_url":"https://github.com/Microsoft/ptvsd/pull/260#discussion_r177204143","pull_request_url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/comments/177204143"},"html":{"href":"https://github.com/Microsoft/ptvsd/pull/260#discussion_r177204143"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260","id":177533623,"html_url":"https://github.com/Microsoft/ptvsd/pull/260","diff_url":"https://github.com/Microsoft/ptvsd/pull/260.diff","patch_url":"https://github.com/Microsoft/ptvsd/pull/260.patch","issue_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/260","number":260,"state":"open","locked":false,"title":"Support few more debug options from VS","user":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"body":"In this PR:\r\n1. Wait on normal exit and abnormal exit #195\r\n2. Redirect output is now supported #250","created_at":"2018-03-26T18:45:09Z","updated_at":"2018-03-26T19:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e9aafaca4b1b7ce857a3d09146669718a8f826e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/260/comments","statuses_url":"https://api.github.com/repos/Microsoft/ptvsd/statuses/a2e955d17643809dbbbb5752811b7a1aa329aff6","head":{"label":"karthiknadig:dbgopt","ref":"dbgopt","sha":"a2e955d17643809dbbbb5752811b7a1aa329aff6","user":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"repo":{"id":123494653,"name":"ptvsd","full_name":"karthiknadig/ptvsd","owner":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karthiknadig/ptvsd","description":"Python debugger package for use with Visual Studio and Visual Studio Code.","fork":true,"url":"https://api.github.com/repos/karthiknadig/ptvsd","forks_url":"https://api.github.com/repos/karthiknadig/ptvsd/forks","keys_url":"https://api.github.com/repos/karthiknadig/ptvsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthiknadig/ptvsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthiknadig/ptvsd/teams","hooks_url":"https://api.github.com/repos/karthiknadig/ptvsd/hooks","issue_events_url":"https://api.github.com/repos/karthiknadig/ptvsd/issues/events{/number}","events_url":"https://api.github.com/repos/karthiknadig/ptvsd/events","assignees_url":"https://api.github.com/repos/karthiknadig/ptvsd/assignees{/user}","branches_url":"https://api.github.com/repos/karthiknadig/ptvsd/branches{/branch}","tags_url":"https://api.github.com/repos/karthiknadig/ptvsd/tags","blobs_url":"https://api.github.com/repos/karthiknadig/ptvsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthiknadig/ptvsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthiknadig/ptvsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthiknadig/ptvsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthiknadig/ptvsd/statuses/{sha}","languages_url":"https://api.github.com/repos/karthiknadig/ptvsd/languages","stargazers_url":"https://api.github.com/repos/karthiknadig/ptvsd/stargazers","contributors_url":"https://api.github.com/repos/karthiknadig/ptvsd/contributors","subscribers_url":"https://api.github.com/repos/karthiknadig/ptvsd/subscribers","subscription_url":"https://api.github.com/repos/karthiknadig/ptvsd/subscription","commits_url":"https://api.github.com/repos/karthiknadig/ptvsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthiknadig/ptvsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthiknadig/ptvsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthiknadig/ptvsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthiknadig/ptvsd/contents/{+path}","compare_url":"https://api.github.com/repos/karthiknadig/ptvsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthiknadig/ptvsd/merges","archive_url":"https://api.github.com/repos/karthiknadig/ptvsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthiknadig/ptvsd/downloads","issues_url":"https://api.github.com/repos/karthiknadig/ptvsd/issues{/number}","pulls_url":"https://api.github.com/repos/karthiknadig/ptvsd/pulls{/number}","milestones_url":"https://api.github.com/repos/karthiknadig/ptvsd/milestones{/number}","notifications_url":"https://api.github.com/repos/karthiknadig/ptvsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthiknadig/ptvsd/labels{/name}","releases_url":"https://api.github.com/repos/karthiknadig/ptvsd/releases{/id}","deployments_url":"https://api.github.com/repos/karthiknadig/ptvsd/deployments","created_at":"2018-03-01T21:30:04Z","updated_at":"2018-03-26T17:37:42Z","pushed_at":"2018-03-26T18:41:00Z","git_url":"git://github.com/karthiknadig/ptvsd.git","ssh_url":"git@github.com:karthiknadig/ptvsd.git","clone_url":"https://github.com/karthiknadig/ptvsd.git","svn_url":"https://github.com/karthiknadig/ptvsd","homepage":null,"size":4085,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2d94dfd22dc68efc4f1733d75eab10f2a675734e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":113512989,"name":"ptvsd","full_name":"Microsoft/ptvsd","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ptvsd","description":"Python debugger package for use with Visual Studio and Visual Studio Code.","fork":false,"url":"https://api.github.com/repos/Microsoft/ptvsd","forks_url":"https://api.github.com/repos/Microsoft/ptvsd/forks","keys_url":"https://api.github.com/repos/Microsoft/ptvsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ptvsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ptvsd/teams","hooks_url":"https://api.github.com/repos/Microsoft/ptvsd/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ptvsd/events","assignees_url":"https://api.github.com/repos/Microsoft/ptvsd/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ptvsd/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ptvsd/tags","blobs_url":"https://api.github.com/repos/Microsoft/ptvsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ptvsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ptvsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ptvsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ptvsd/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ptvsd/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ptvsd/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ptvsd/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ptvsd/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ptvsd/subscription","commits_url":"https://api.github.com/repos/Microsoft/ptvsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ptvsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ptvsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ptvsd/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ptvsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ptvsd/merges","archive_url":"https://api.github.com/repos/Microsoft/ptvsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ptvsd/downloads","issues_url":"https://api.github.com/repos/Microsoft/ptvsd/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ptvsd/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ptvsd/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ptvsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ptvsd/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ptvsd/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ptvsd/deployments","created_at":"2017-12-08T00:36:13Z","updated_at":"2018-03-25T22:14:26Z","pushed_at":"2018-03-26T18:45:10Z","git_url":"git://github.com/Microsoft/ptvsd.git","ssh_url":"git@github.com:Microsoft/ptvsd.git","clone_url":"https://github.com/Microsoft/ptvsd.git","svn_url":"https://github.com/Microsoft/ptvsd","homepage":null,"size":4099,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":60,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260"},"html":{"href":"https://github.com/Microsoft/ptvsd/pull/260"},"issue":{"href":"https://api.github.com/repos/Microsoft/ptvsd/issues/260"},"comments":{"href":"https://api.github.com/repos/Microsoft/ptvsd/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ptvsd/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ptvsd/statuses/a2e955d17643809dbbbb5752811b7a1aa329aff6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ericsnowcurrently"}}