{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/193041001","pull_request_review_id":125925184,"id":193041001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA0MTAwMQ==","diff_hunk":"@@ -800,27 +839,39 @@ class AuthorizerIntegrationTest extends BaseRequestTest {\n }\n \n   @Test\n-  def testCreatePermissionNeededToReadFromNonExistentTopic() {\n-    val newTopic = \"newTopic\"\n+  def testCreatePermissionOnTopicToReadFromNonExistentTopic() {\n+    testCreatePermissionNeededToReadFromNonExistentTopic(\"newTopic\",\n+      Set(new Acl(userPrincipal, Allow, Acl.WildCardHost, Create)),\n+      Topic)\n+  }\n+\n+  @Test\n+  def testCreatePermissionOnClusterToReadFromNonExistentTopic() {\n+    testCreatePermissionNeededToReadFromNonExistentTopic(\"newTopic\",\n+      Set(new Acl(userPrincipal, Allow, Acl.WildCardHost, Create)), \n+      Cluster)\n+  }\n+\n+  private def testCreatePermissionNeededToReadFromNonExistentTopic(newTopic: String, acls: Set[Acl], resType: ResourceType) {\n     val topicPartition = new TopicPartition(newTopic, 0)\n     val newTopicResource = new Resource(Topic, newTopic)\n     addAndVerifyAcls(Set(new Acl(userPrincipal, Allow, Acl.WildCardHost, Read)), newTopicResource)\n     addAndVerifyAcls(groupReadAcl(groupResource), groupResource)\n-    addAndVerifyAcls(clusterAcl(Resource.ClusterResource), Resource.ClusterResource)\n+    this.consumers.head.assign(List(topicPartition).asJava)\n     try {\n-      this.consumers.head.assign(List(topicPartition).asJava)\n-      consumeRecords(this.consumers.head)\n-      Assert.fail(\"should have thrown exception\")\n+      this.consumers.head.poll(Duration.ofMillis(50L));","path":"core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala","position":122,"original_position":130,"commit_id":"b86c3c2fb057eea332be167a31d4019908502bed","original_commit_id":"afd55d77a2fd0f7e9ecbc01b4d145fa704aafc91","user":{"login":"ijuma","id":24747,"node_id":"MDQ6VXNlcjI0NzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24747?v=4","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"Even then, `poll` provides little in the way of guarantees. I suggest using `TestUtils.retry` with a generous timeout and a short timeout for `poll`. This also ensures we finish as quickly as possible.","created_at":"2018-06-05T11:44:14Z","updated_at":"2018-06-05T11:53:47Z","html_url":"https://github.com/apache/kafka/pull/4795#discussion_r193041001","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4795","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/193041001"},"html":{"href":"https://github.com/apache/kafka/pull/4795#discussion_r193041001"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4795"}},"in_reply_to_id":193020212},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4795","id":178337981,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4MzM3OTgx","html_url":"https://github.com/apache/kafka/pull/4795","diff_url":"https://github.com/apache/kafka/pull/4795.diff","patch_url":"https://github.com/apache/kafka/pull/4795.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4795","number":4795,"state":"open","locked":false,"title":"KAFKA-6726: Fine Grained ACL for CreateTopics (KIP-277)","user":{"login":"edoardocomar","id":6661532,"node_id":"MDQ6VXNlcjY2NjE1MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6661532?v=4","gravatar_id":"","url":"https://api.github.com/users/edoardocomar","html_url":"https://github.com/edoardocomar","followers_url":"https://api.github.com/users/edoardocomar/followers","following_url":"https://api.github.com/users/edoardocomar/following{/other_user}","gists_url":"https://api.github.com/users/edoardocomar/gists{/gist_id}","starred_url":"https://api.github.com/users/edoardocomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoardocomar/subscriptions","organizations_url":"https://api.github.com/users/edoardocomar/orgs","repos_url":"https://api.github.com/users/edoardocomar/repos","events_url":"https://api.github.com/users/edoardocomar/events{/privacy}","received_events_url":"https://api.github.com/users/edoardocomar/received_events","type":"User","site_admin":false},"body":"* Handling CreateTopicsRequest now requires Create auth on Topic resource and does not require Create on Cluster\r\n\r\n* AclCommand --producer option adjusted \r\n\r\n* Existing Unit and Integration tests adjusted accordingly\r\n\r\nhttps://issues.apache.org/jira/browse/KAFKA-6726\r\nhttps://cwiki.apache.org/confluence/display/KAFKA/KIP-277+-+Fine+Grained+ACL+for+CreateTopics+API\r\n\r\nCo-authored-by: Edoardo Comar <ecomar@uk.ibm.com>\r\nCo-authored-by: Mickael Maison <mickael.maison@gmail.com>\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-03-29T14:02:20Z","updated_at":"2018-06-05T11:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e89a78471c710315f7042e42699ca5f1601a5d","assignee":{"login":"ijuma","id":24747,"node_id":"MDQ6VXNlcjI0NzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24747?v=4","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"assignees":[{"login":"ijuma","id":24747,"node_id":"MDQ6VXNlcjI0NzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24747?v=4","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apache/kafka/milestones/2","html_url":"https://github.com/apache/kafka/milestone/2","labels_url":"https://api.github.com/repos/apache/kafka/milestones/2/labels","id":3360249,"node_id":"MDk6TWlsZXN0b25lMzM2MDI0OQ==","number":2,"title":"2.0.0","description":null,"creator":{"login":"ijuma","id":24747,"node_id":"MDQ6VXNlcjI0NzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24747?v=4","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":9,"state":"open","created_at":"2018-05-21T04:45:55Z","updated_at":"2018-06-05T11:08:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4795/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4795/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4795/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/b86c3c2fb057eea332be167a31d4019908502bed","head":{"label":"edoardocomar:topic_create_acl","ref":"topic_create_acl","sha":"b86c3c2fb057eea332be167a31d4019908502bed","user":{"login":"edoardocomar","id":6661532,"node_id":"MDQ6VXNlcjY2NjE1MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6661532?v=4","gravatar_id":"","url":"https://api.github.com/users/edoardocomar","html_url":"https://github.com/edoardocomar","followers_url":"https://api.github.com/users/edoardocomar/followers","following_url":"https://api.github.com/users/edoardocomar/following{/other_user}","gists_url":"https://api.github.com/users/edoardocomar/gists{/gist_id}","starred_url":"https://api.github.com/users/edoardocomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoardocomar/subscriptions","organizations_url":"https://api.github.com/users/edoardocomar/orgs","repos_url":"https://api.github.com/users/edoardocomar/repos","events_url":"https://api.github.com/users/edoardocomar/events{/privacy}","received_events_url":"https://api.github.com/users/edoardocomar/received_events","type":"User","site_admin":false},"repo":{"id":53959119,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk1OTExOQ==","name":"kafka","full_name":"edoardocomar/kafka","owner":{"login":"edoardocomar","id":6661532,"node_id":"MDQ6VXNlcjY2NjE1MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6661532?v=4","gravatar_id":"","url":"https://api.github.com/users/edoardocomar","html_url":"https://github.com/edoardocomar","followers_url":"https://api.github.com/users/edoardocomar/followers","following_url":"https://api.github.com/users/edoardocomar/following{/other_user}","gists_url":"https://api.github.com/users/edoardocomar/gists{/gist_id}","starred_url":"https://api.github.com/users/edoardocomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoardocomar/subscriptions","organizations_url":"https://api.github.com/users/edoardocomar/orgs","repos_url":"https://api.github.com/users/edoardocomar/repos","events_url":"https://api.github.com/users/edoardocomar/events{/privacy}","received_events_url":"https://api.github.com/users/edoardocomar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edoardocomar/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/edoardocomar/kafka","forks_url":"https://api.github.com/repos/edoardocomar/kafka/forks","keys_url":"https://api.github.com/repos/edoardocomar/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edoardocomar/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edoardocomar/kafka/teams","hooks_url":"https://api.github.com/repos/edoardocomar/kafka/hooks","issue_events_url":"https://api.github.com/repos/edoardocomar/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/edoardocomar/kafka/events","assignees_url":"https://api.github.com/repos/edoardocomar/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/edoardocomar/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/edoardocomar/kafka/tags","blobs_url":"https://api.github.com/repos/edoardocomar/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edoardocomar/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edoardocomar/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/edoardocomar/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edoardocomar/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/edoardocomar/kafka/languages","stargazers_url":"https://api.github.com/repos/edoardocomar/kafka/stargazers","contributors_url":"https://api.github.com/repos/edoardocomar/kafka/contributors","subscribers_url":"https://api.github.com/repos/edoardocomar/kafka/subscribers","subscription_url":"https://api.github.com/repos/edoardocomar/kafka/subscription","commits_url":"https://api.github.com/repos/edoardocomar/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/edoardocomar/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/edoardocomar/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/edoardocomar/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/edoardocomar/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/edoardocomar/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edoardocomar/kafka/merges","archive_url":"https://api.github.com/repos/edoardocomar/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edoardocomar/kafka/downloads","issues_url":"https://api.github.com/repos/edoardocomar/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/edoardocomar/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/edoardocomar/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/edoardocomar/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edoardocomar/kafka/labels{/name}","releases_url":"https://api.github.com/repos/edoardocomar/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/edoardocomar/kafka/deployments","created_at":"2016-03-15T16:07:21Z","updated_at":"2018-05-25T13:01:46Z","pushed_at":"2018-06-05T11:09:56Z","git_url":"git://github.com/edoardocomar/kafka.git","ssh_url":"git@github.com:edoardocomar/kafka.git","clone_url":"https://github.com/edoardocomar/kafka.git","svn_url":"https://github.com/edoardocomar/kafka","homepage":null,"size":63515,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"d02f02130eb36cdc4375eb40bdbe4a1f9b58fc60","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-06-05T11:10:21Z","pushed_at":"2018-06-05T11:09:58Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":66676,"stargazers_count":8540,"watchers_count":8540,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4953,"mirror_url":null,"archived":false,"open_issues_count":459,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4953,"open_issues":459,"watchers":8540,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4795"},"html":{"href":"https://github.com/apache/kafka/pull/4795"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4795"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4795/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4795/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4795/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/b86c3c2fb057eea332be167a31d4019908502bed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ijuma"}}