{"action":"created","comment":{"url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/comments/231696943","pull_request_review_id":172723731,"id":231696943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY5Njk0Mw==","diff_hunk":"@@ -22,38 +24,15 @@ end\n ## extension instead. We need to work this out...\n \n \n-from_gap_string(obj :: MPtr) = CSTR_STRING(obj)\n-from_gap_symbol(obj :: MPtr) = Symbol(from_gap_string(obj))\n+from_gap(obj        , ::Any)                  = obj\n+from_gap(obj :: MPtr, ::Type{AbstractString}) = CSTR_STRING(obj)","path":"LibGAP.jl/src/conversion.jl","position":26,"original_position":26,"commit_id":"e288ca5080d1c76735cf51f5daea084a9307d899","original_commit_id":"e288ca5080d1c76735cf51f5daea084a9307d899","user":{"login":"fingolfin","id":241512,"node_id":"MDQ6VXNlcjI0MTUxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/241512?v=4","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"body":"As per the comment above, this (still) does not perform any input validation and will crash or produce garbage if called on a non-string GAP object. Something to fix in a future PR, I guess.","created_at":"2018-11-07T22:09:29Z","updated_at":"2018-11-07T22:11:09Z","html_url":"https://github.com/oscar-system/GAPJulia/pull/145#discussion_r231696943","pull_request_url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/comments/231696943"},"html":{"href":"https://github.com/oscar-system/GAPJulia/pull/145#discussion_r231696943"},"pull_request":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145","id":229088071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDg4MDcx","html_url":"https://github.com/oscar-system/GAPJulia/pull/145","diff_url":"https://github.com/oscar-system/GAPJulia/pull/145.diff","patch_url":"https://github.com/oscar-system/GAPJulia/pull/145.patch","issue_url":"https://api.github.com/repos/oscar-system/GAPJulia/issues/145","number":145,"state":"open","locked":false,"title":"Changed conversion, added tests","user":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-07T16:27:18Z","updated_at":"2018-11-07T22:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ae64b6001506866fc9705b9b0802d2a1bf637f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145/commits","review_comments_url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145/comments","review_comment_url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oscar-system/GAPJulia/issues/145/comments","statuses_url":"https://api.github.com/repos/oscar-system/GAPJulia/statuses/e288ca5080d1c76735cf51f5daea084a9307d899","head":{"label":"sebasguts:new_conversion","ref":"new_conversion","sha":"e288ca5080d1c76735cf51f5daea084a9307d899","user":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"repo":{"id":139581986,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1ODE5ODY=","name":"GAPJulia","full_name":"sebasguts/GAPJulia","private":false,"owner":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebasguts/GAPJulia","description":"GAP packages for Julia integration","fork":true,"url":"https://api.github.com/repos/sebasguts/GAPJulia","forks_url":"https://api.github.com/repos/sebasguts/GAPJulia/forks","keys_url":"https://api.github.com/repos/sebasguts/GAPJulia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebasguts/GAPJulia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebasguts/GAPJulia/teams","hooks_url":"https://api.github.com/repos/sebasguts/GAPJulia/hooks","issue_events_url":"https://api.github.com/repos/sebasguts/GAPJulia/issues/events{/number}","events_url":"https://api.github.com/repos/sebasguts/GAPJulia/events","assignees_url":"https://api.github.com/repos/sebasguts/GAPJulia/assignees{/user}","branches_url":"https://api.github.com/repos/sebasguts/GAPJulia/branches{/branch}","tags_url":"https://api.github.com/repos/sebasguts/GAPJulia/tags","blobs_url":"https://api.github.com/repos/sebasguts/GAPJulia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebasguts/GAPJulia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebasguts/GAPJulia/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebasguts/GAPJulia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebasguts/GAPJulia/statuses/{sha}","languages_url":"https://api.github.com/repos/sebasguts/GAPJulia/languages","stargazers_url":"https://api.github.com/repos/sebasguts/GAPJulia/stargazers","contributors_url":"https://api.github.com/repos/sebasguts/GAPJulia/contributors","subscribers_url":"https://api.github.com/repos/sebasguts/GAPJulia/subscribers","subscription_url":"https://api.github.com/repos/sebasguts/GAPJulia/subscription","commits_url":"https://api.github.com/repos/sebasguts/GAPJulia/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebasguts/GAPJulia/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebasguts/GAPJulia/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebasguts/GAPJulia/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebasguts/GAPJulia/contents/{+path}","compare_url":"https://api.github.com/repos/sebasguts/GAPJulia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebasguts/GAPJulia/merges","archive_url":"https://api.github.com/repos/sebasguts/GAPJulia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebasguts/GAPJulia/downloads","issues_url":"https://api.github.com/repos/sebasguts/GAPJulia/issues{/number}","pulls_url":"https://api.github.com/repos/sebasguts/GAPJulia/pulls{/number}","milestones_url":"https://api.github.com/repos/sebasguts/GAPJulia/milestones{/number}","notifications_url":"https://api.github.com/repos/sebasguts/GAPJulia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebasguts/GAPJulia/labels{/name}","releases_url":"https://api.github.com/repos/sebasguts/GAPJulia/releases{/id}","deployments_url":"https://api.github.com/repos/sebasguts/GAPJulia/deployments","created_at":"2018-07-03T12:43:14Z","updated_at":"2018-10-25T15:42:49Z","pushed_at":"2018-11-07T16:55:38Z","git_url":"git://github.com/sebasguts/GAPJulia.git","ssh_url":"git@github.com:sebasguts/GAPJulia.git","clone_url":"https://github.com/sebasguts/GAPJulia.git","svn_url":"https://github.com/sebasguts/GAPJulia","homepage":null,"size":581,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oscar-system:master","ref":"master","sha":"bd420153aa3df3dd8902eb71fd6053b8a97ace49","user":{"login":"oscar-system","id":25104835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTA0ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/25104835?v=4","gravatar_id":"","url":"https://api.github.com/users/oscar-system","html_url":"https://github.com/oscar-system","followers_url":"https://api.github.com/users/oscar-system/followers","following_url":"https://api.github.com/users/oscar-system/following{/other_user}","gists_url":"https://api.github.com/users/oscar-system/gists{/gist_id}","starred_url":"https://api.github.com/users/oscar-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscar-system/subscriptions","organizations_url":"https://api.github.com/users/oscar-system/orgs","repos_url":"https://api.github.com/users/oscar-system/repos","events_url":"https://api.github.com/users/oscar-system/events{/privacy}","received_events_url":"https://api.github.com/users/oscar-system/received_events","type":"Organization","site_admin":false},"repo":{"id":127049780,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNDk3ODA=","name":"GAPJulia","full_name":"oscar-system/GAPJulia","private":false,"owner":{"login":"oscar-system","id":25104835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTA0ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/25104835?v=4","gravatar_id":"","url":"https://api.github.com/users/oscar-system","html_url":"https://github.com/oscar-system","followers_url":"https://api.github.com/users/oscar-system/followers","following_url":"https://api.github.com/users/oscar-system/following{/other_user}","gists_url":"https://api.github.com/users/oscar-system/gists{/gist_id}","starred_url":"https://api.github.com/users/oscar-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscar-system/subscriptions","organizations_url":"https://api.github.com/users/oscar-system/orgs","repos_url":"https://api.github.com/users/oscar-system/repos","events_url":"https://api.github.com/users/oscar-system/events{/privacy}","received_events_url":"https://api.github.com/users/oscar-system/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oscar-system/GAPJulia","description":"GAP packages for Julia integration","fork":false,"url":"https://api.github.com/repos/oscar-system/GAPJulia","forks_url":"https://api.github.com/repos/oscar-system/GAPJulia/forks","keys_url":"https://api.github.com/repos/oscar-system/GAPJulia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscar-system/GAPJulia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscar-system/GAPJulia/teams","hooks_url":"https://api.github.com/repos/oscar-system/GAPJulia/hooks","issue_events_url":"https://api.github.com/repos/oscar-system/GAPJulia/issues/events{/number}","events_url":"https://api.github.com/repos/oscar-system/GAPJulia/events","assignees_url":"https://api.github.com/repos/oscar-system/GAPJulia/assignees{/user}","branches_url":"https://api.github.com/repos/oscar-system/GAPJulia/branches{/branch}","tags_url":"https://api.github.com/repos/oscar-system/GAPJulia/tags","blobs_url":"https://api.github.com/repos/oscar-system/GAPJulia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscar-system/GAPJulia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscar-system/GAPJulia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscar-system/GAPJulia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscar-system/GAPJulia/statuses/{sha}","languages_url":"https://api.github.com/repos/oscar-system/GAPJulia/languages","stargazers_url":"https://api.github.com/repos/oscar-system/GAPJulia/stargazers","contributors_url":"https://api.github.com/repos/oscar-system/GAPJulia/contributors","subscribers_url":"https://api.github.com/repos/oscar-system/GAPJulia/subscribers","subscription_url":"https://api.github.com/repos/oscar-system/GAPJulia/subscription","commits_url":"https://api.github.com/repos/oscar-system/GAPJulia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscar-system/GAPJulia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscar-system/GAPJulia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscar-system/GAPJulia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscar-system/GAPJulia/contents/{+path}","compare_url":"https://api.github.com/repos/oscar-system/GAPJulia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscar-system/GAPJulia/merges","archive_url":"https://api.github.com/repos/oscar-system/GAPJulia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscar-system/GAPJulia/downloads","issues_url":"https://api.github.com/repos/oscar-system/GAPJulia/issues{/number}","pulls_url":"https://api.github.com/repos/oscar-system/GAPJulia/pulls{/number}","milestones_url":"https://api.github.com/repos/oscar-system/GAPJulia/milestones{/number}","notifications_url":"https://api.github.com/repos/oscar-system/GAPJulia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscar-system/GAPJulia/labels{/name}","releases_url":"https://api.github.com/repos/oscar-system/GAPJulia/releases{/id}","deployments_url":"https://api.github.com/repos/oscar-system/GAPJulia/deployments","created_at":"2018-03-27T21:49:51Z","updated_at":"2018-11-07T13:00:16Z","pushed_at":"2018-11-07T16:55:39Z","git_url":"git://github.com/oscar-system/GAPJulia.git","ssh_url":"git@github.com:oscar-system/GAPJulia.git","clone_url":"https://github.com/oscar-system/GAPJulia.git","svn_url":"https://github.com/oscar-system/GAPJulia","homepage":null,"size":583,"stargazers_count":2,"watchers_count":2,"language":"GAP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":20,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145"},"html":{"href":"https://github.com/oscar-system/GAPJulia/pull/145"},"issue":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/issues/145"},"comments":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/oscar-system/GAPJulia/statuses/e288ca5080d1c76735cf51f5daea084a9307d899"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fingolfin"}}