{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/helm/issues/3540","repository_url":"https://api.github.com/repos/kubernetes/helm","labels_url":"https://api.github.com/repos/kubernetes/helm/issues/3540/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/3540/comments","events_url":"https://api.github.com/repos/kubernetes/helm/issues/3540/events","html_url":"https://github.com/kubernetes/helm/pull/3540","id":298636969,"number":3540,"title":"WIP: Implement hook-recreate policy","user":{"login":"alexey-igrychev","id":17360817,"avatar_url":"https://avatars3.githubusercontent.com/u/17360817?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-igrychev","html_url":"https://github.com/alexey-igrychev","followers_url":"https://api.github.com/users/alexey-igrychev/followers","following_url":"https://api.github.com/users/alexey-igrychev/following{/other_user}","gists_url":"https://api.github.com/users/alexey-igrychev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-igrychev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-igrychev/subscriptions","organizations_url":"https://api.github.com/users/alexey-igrychev/orgs","repos_url":"https://api.github.com/users/alexey-igrychev/repos","events_url":"https://api.github.com/users/alexey-igrychev/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-igrychev/received_events","type":"User","site_admin":false},"labels":[{"id":484574947,"url":"https://api.github.com/repos/kubernetes/helm/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778135114,"url":"https://api.github.com/repos/kubernetes/helm/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":562687520,"url":"https://api.github.com/repos/kubernetes/helm/labels/feature","name":"feature","color":"0052cc","default":false},{"id":676353308,"url":"https://api.github.com/repos/kubernetes/helm/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-20T15:29:53Z","updated_at":"2018-03-21T14:57:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/3540","html_url":"https://github.com/kubernetes/helm/pull/3540","diff_url":"https://github.com/kubernetes/helm/pull/3540.diff","patch_url":"https://github.com/kubernetes/helm/pull/3540.patch"},"body":"Existing **helm.sh/hook-delete-policy** annotation policies (`hook-failed`, `hook-succeeded`) do not allow to leave failed jobs for debugging without blocking the next job launching: every failed job must be deleted manually before the next related release is launching (installing, updating or rolling back).\r\n\r\nNew policy, `hook-recreate`, removes the hook from previous release if there is one before the new hook is launched and can be used with another policies."},"comment":{"url":"https://api.github.com/repos/kubernetes/helm/issues/comments/374967202","html_url":"https://github.com/kubernetes/helm/pull/3540#issuecomment-374967202","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/3540","id":374967202,"user":{"login":"distorhead","id":1161992,"avatar_url":"https://avatars2.githubusercontent.com/u/1161992?v=4","gravatar_id":"","url":"https://api.github.com/users/distorhead","html_url":"https://github.com/distorhead","followers_url":"https://api.github.com/users/distorhead/followers","following_url":"https://api.github.com/users/distorhead/following{/other_user}","gists_url":"https://api.github.com/users/distorhead/gists{/gist_id}","starred_url":"https://api.github.com/users/distorhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/distorhead/subscriptions","organizations_url":"https://api.github.com/users/distorhead/orgs","repos_url":"https://api.github.com/users/distorhead/repos","events_url":"https://api.github.com/users/distorhead/events{/privacy}","received_events_url":"https://api.github.com/users/distorhead/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T14:57:39Z","updated_at":"2018-03-21T14:57:39Z","author_association":"CONTRIBUTOR","body":"@Lentil1016 After another look at the situation we have decided just to rename `hook-recreate` into `before-hook-creation` and keep this function under already existing `hook-delete-policy`. Because having another policy `\"hook-exists-policy\": \"delete\"` will make a total mess together wih `\"hook-delete-policy\"` because of this `HOOK_STATE => ACTION` inversed form with overlapping `delete` action.\r\n\r\nWe made this decision also, because that way this hook-recreation function can be merged into helm 2. But there are talks about helm 3 major release, which will allow more radical changes.\r\n\r\nBy the way there is some experiments with `\"hook-exists-policy\"` in a separate branch of our fork: https://github.com/flant/helm/tree/hook_delete_exists_policy -- you can use that freely if you want for your implementation of new policy for `keep` action."}}
{"actor":{"display_login":"distorhead"}}