{"action":"created","issue":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2597","repository_url":"https://api.github.com/repos/MvvmCross/MvvmCross","labels_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2597/labels{/name}","comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2597/comments","events_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2597/events","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2597","id":295710623,"number":2597,"title":"Using IActivatedEventArgs in MvxFormsWindowsSetup","user":{"login":"MartinZikmund","id":1075116,"avatar_url":"https://avatars3.githubusercontent.com/u/1075116?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinZikmund","html_url":"https://github.com/MartinZikmund","followers_url":"https://api.github.com/users/MartinZikmund/followers","following_url":"https://api.github.com/users/MartinZikmund/following{/other_user}","gists_url":"https://api.github.com/users/MartinZikmund/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinZikmund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinZikmund/subscriptions","organizations_url":"https://api.github.com/users/MartinZikmund/orgs","repos_url":"https://api.github.com/users/MartinZikmund/repos","events_url":"https://api.github.com/users/MartinZikmund/events{/privacy}","received_events_url":"https://api.github.com/users/MartinZikmund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/milestones/14","html_url":"https://github.com/MvvmCross/MvvmCross/milestone/14","labels_url":"https://api.github.com/repos/MvvmCross/MvvmCross/milestones/14/labels","id":2457154,"number":14,"title":"6.0.0","description":"","creator":{"login":"martijn00","id":6221156,"avatar_url":"https://avatars2.githubusercontent.com/u/6221156?v=4","gravatar_id":"","url":"https://api.github.com/users/martijn00","html_url":"https://github.com/martijn00","followers_url":"https://api.github.com/users/martijn00/followers","following_url":"https://api.github.com/users/martijn00/following{/other_user}","gists_url":"https://api.github.com/users/martijn00/gists{/gist_id}","starred_url":"https://api.github.com/users/martijn00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijn00/subscriptions","organizations_url":"https://api.github.com/users/martijn00/orgs","repos_url":"https://api.github.com/users/martijn00/repos","events_url":"https://api.github.com/users/martijn00/events{/privacy}","received_events_url":"https://api.github.com/users/martijn00/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":82,"state":"open","created_at":"2017-04-14T11:21:45Z","updated_at":"2018-02-09T10:23:06Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-02-09T00:09:01Z","updated_at":"2018-02-09T10:24:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/2597","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2597","diff_url":"https://github.com/MvvmCross/MvvmCross/pull/2597.diff","patch_url":"https://github.com/MvvmCross/MvvmCross/pull/2597.patch"},"body":"### :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)\r\n\r\n**New feature**\r\nThis PR switches the `LaunchActivatedEventArgs` class in the constructor of `MvxFormsWindowsSetup` class for the more general `IActivatedEventArgs` interface.\r\n\r\nThe app can be launched in many **other ways than just by direct launch** (URI, File association, etc.), and instead of `LaunchActivatedEventArgs` you then have an instance of different class implementing `IActivatedEventArgs` and can't therefore create `MvxFormsWindowsSetup` instance.\r\n\r\nInternally, `MvxFormsWindowsSetup` calls `Xamarin.Forms.Forms.Init` method, which expects an instance of `IActivatedEventArgs` and doesn't require an instance of `LaunchActivatedEventArgs` specifically.\r\n\r\n### :arrow_heading_down: What is the current behavior?\r\n\r\nThe `MvxFormsWindowsSetup` constructor requires an instance of `LaunchActivatedEventArgs`.\r\n\r\n### :new: What is the new behavior (if this is a feature change)?\r\n\r\nThe `MvxFormsWindowsSetup` constructor expects a more general instance of `IActivatedEventArgs`.\r\n\r\n### :boom: Does this PR introduce a breaking change?\r\n\r\nNo, because `LaunchActivatedEventArgs` implements `IActivatedEventArgs`, the new interface is just more permissive and allows other activation types like URI, File, Search and many others.\r\n\r\n### :bug: Recommendations for testing\r\n\r\n\r\n### :memo: Links to relevant issues/docs\r\n\r\n[IActivatedEventArgs in Docs](https://docs.microsoft.com/en-us/uwp/api/Windows.ApplicationModel.Activation.IActivatedEventArgs).\r\n\r\n[LaunchActivatedEventArgs in Docs](https://docs.microsoft.com/en-us/uwp/api/Windows.ApplicationModel.Activation.LaunchActivatedEventArgs).\r\n\r\n### :thinking: Checklist before submitting\r\n\r\n- [x] All projects build\r\n- [x] Follows style guide lines ([code style guide](https://github.com/MvvmCross/MvvmCross#code-style-guidelines))\r\n- [x] Relevant documentation was updated ([docs style guide](https://www.mvvmcross.com/documentation/contribute/mvvmcross-docs-style-guide))\r\n- [x] Rebased onto current develop\r\n"},"comment":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/comments/364395196","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2597#issuecomment-364395196","issue_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2597","id":364395196,"user":{"login":"martijn00","id":6221156,"avatar_url":"https://avatars2.githubusercontent.com/u/6221156?v=4","gravatar_id":"","url":"https://api.github.com/users/martijn00","html_url":"https://github.com/martijn00","followers_url":"https://api.github.com/users/martijn00/followers","following_url":"https://api.github.com/users/martijn00/following{/other_user}","gists_url":"https://api.github.com/users/martijn00/gists{/gist_id}","starred_url":"https://api.github.com/users/martijn00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijn00/subscriptions","organizations_url":"https://api.github.com/users/martijn00/orgs","repos_url":"https://api.github.com/users/martijn00/repos","events_url":"https://api.github.com/users/martijn00/events{/privacy}","received_events_url":"https://api.github.com/users/martijn00/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T10:24:48Z","updated_at":"2018-02-09T10:24:48Z","author_association":"OWNER","body":"I would vote for changing this in the base too, especially since we are working on 6.0."}}
{"actor":{"display_login":"martijn00"}}