{"push_id":2300826834,"size":1,"distinct_size":0,"ref":"refs/heads/master","head":"a2ca4ae98b35d76b14cc936af1ebf13b93199d79","before":"08712fff7fba84b88e2e57b3c739d53b1aab1ed6","commits":[{"sha":"a2ca4ae98b35d76b14cc936af1ebf13b93199d79","author":{"name":"Ilya Biryukov","email":"658e01dc67dbff791f5efc53553965889ddf88ac@google.com"},"message":"[Sema] Add implicit members even for invalid CXXRecordDecls\n\nSummary:\nIt should be safe, since other code paths are already generating\nimplicit members even in invalid CXXRecordDecls (e.g. lookup).\n\nIf we don't generate implicit members on CXXRecordDecl's completion,\nthey will be generated by next lookup of constructors. This causes a\ncrash when the following conditions are met:\n  - a CXXRecordDecl is invalid,\n  - it is provided via ExternalASTSource (e.g. from PCH),\n  - it has inherited constructors (they create ShadowDecls),\n  - lookup of its constructors was not run before ASTWriter serialized\n    it.\n\nThis may require the ShadowDecls created for inherited constructors to\nbe removed from the class, but that's no longer possible since class is\nprovided by ExternalASTSource.\n\nSee provided lit test for an example.\n\nReviewers: bkramer\n\nReviewed By: bkramer\n\nSubscribers: cfe-commits\n\nDifferential Revision: https://reviews.llvm.org/D42810\n\ngit-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@324062 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":false,"url":"https://api.github.com/repos/fuchsia-mirror/third_party-clang/commits/a2ca4ae98b35d76b14cc936af1ebf13b93199d79"}]}
{"actor":{"display_login":"FF0080"}}