{"action":"opened","issue":{"url":"https://api.github.com/repos/Sitecore/jss/issues/80","repository_url":"https://api.github.com/repos/Sitecore/jss","labels_url":"https://api.github.com/repos/Sitecore/jss/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/Sitecore/jss/issues/80/comments","events_url":"https://api.github.com/repos/Sitecore/jss/issues/80/events","html_url":"https://github.com/Sitecore/jss/issues/80","id":383797022,"node_id":"MDU6SXNzdWUzODM3OTcwMjI=","number":80,"title":"createDefaultDisconnectedServer expects `appRoot ` to be set to the script folder","user":{"login":"jantimon","id":4113649,"node_id":"MDQ6VXNlcjQxMTM2NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4113649?v=4","gravatar_id":"","url":"https://api.github.com/users/jantimon","html_url":"https://github.com/jantimon","followers_url":"https://api.github.com/users/jantimon/followers","following_url":"https://api.github.com/users/jantimon/following{/other_user}","gists_url":"https://api.github.com/users/jantimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jantimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantimon/subscriptions","organizations_url":"https://api.github.com/users/jantimon/orgs","repos_url":"https://api.github.com/users/jantimon/repos","events_url":"https://api.github.com/users/jantimon/events{/privacy}","received_events_url":"https://api.github.com/users/jantimon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-23T11:51:22Z","updated_at":"2018-11-23T11:51:22Z","closed_at":null,"author_association":"NONE","body":"## Description\r\n<!-- A clear and concise description of the issue, and why you consider it to be a bug. -->\r\n\r\nRight now the createDefaultDisconnectedServer is expecting the \"root\" not to be set to the root of the project but to the scripts directory:\r\n\r\nhttps://github.com/Sitecore/jss/blob/0292a05077c4ef21b668eb9c30412f57620c3779/samples/react/scripts/disconnected-mode-proxy.js#L18-L19\r\n\r\nThis is also hard coded inside the `createDefaultDisconnectedServer` (Version 9.0.6) code:\r\n\r\n`@sitecore-jss/sitecore-jss-dev-tools/dist/disconnected-server/create-default-disconnected-server.js` line 52, 53:\r\n\r\n```\r\napp.use('/assets', express_1.default.static(path_1.join(options.appRoot, '../assets')));\r\napp.use('/data/media', express_1.default.static(path_1.join(options.appRoot, '../data/media')));\r\n```\r\n\r\nAs you can see it has to add `..` to get rid of the scripts folder.\r\n"}}
{"actor":{"display_login":"jantimon"}}