{"action":"created","issue":{"url":"https://api.github.com/repos/pytroll/satpy/issues/562","repository_url":"https://api.github.com/repos/pytroll/satpy","labels_url":"https://api.github.com/repos/pytroll/satpy/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/pytroll/satpy/issues/562/comments","events_url":"https://api.github.com/repos/pytroll/satpy/issues/562/events","html_url":"https://github.com/pytroll/satpy/issues/562","id":394857577,"node_id":"MDU6SXNzdWUzOTQ4NTc1Nzc=","number":562,"title":"Undocumented dependency packages","user":{"login":"avalentino","id":614554,"node_id":"MDQ6VXNlcjYxNDU1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/614554?v=4","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-30T09:08:31Z","updated_at":"2018-12-30T17:00:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There are three packages that are used by satpy but are not listed in the (optional) requirements list in setup.py:\r\n\r\n * pydecorate\r\n * glymur\r\n * pyninjotiff\r\n\r\nIn particular pydecorate seems to be used during unit testing.\r\n\r\n**To Reproduce**\r\n```\r\n$ python3 setup.py test\r\n```\r\n\r\n**Expected behavior**\r\nAll tests are executed without errors\r\n\r\n**Actual results**\r\n4 test failures\r\n```\r\n======================================================================\r\nERROR: test_add_decorate_basic_l (satpy.tests.test_writers.TestOverlays)\r\nTest basic add_decorate usage with L data.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/antonio/debian/git/satpy/satpy/tests/test_writers.py\", line 599, in setUp\r\n    self.dw = self.dec_writer.start()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1390, in start\r\n    result = self.__enter__()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1243, in __enter__\r\n    self.target = self.getter()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1413, in <lambda>\r\n    getter = lambda: _importer(target)\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1096, in _importer\r\n    thing = __import__(import_path)\r\nModuleNotFoundError: No module named 'pydecorate'\r\n\r\n======================================================================\r\nERROR: test_add_decorate_basic_rgb (satpy.tests.test_writers.TestOverlays)\r\nTest basic add_decorate usage with RGB data.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/antonio/debian/git/satpy/satpy/tests/test_writers.py\", line 599, in setUp\r\n    self.dw = self.dec_writer.start()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1390, in start\r\n    result = self.__enter__()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1243, in __enter__\r\n    self.target = self.getter()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1413, in <lambda>\r\n    getter = lambda: _importer(target)\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1096, in _importer\r\n    thing = __import__(import_path)\r\nModuleNotFoundError: No module named 'pydecorate'\r\n\r\n======================================================================\r\nERROR: test_add_overlay_basic_l (satpy.tests.test_writers.TestOverlays)\r\nTest basic add_overlay usage with L data.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/antonio/debian/git/satpy/satpy/tests/test_writers.py\", line 599, in setUp\r\n    self.dw = self.dec_writer.start()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1390, in start\r\n    result = self.__enter__()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1243, in __enter__\r\n    self.target = self.getter()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1413, in <lambda>\r\n    getter = lambda: _importer(target)\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1096, in _importer\r\n    thing = __import__(import_path)\r\nModuleNotFoundError: No module named 'pydecorate'\r\n\r\n======================================================================\r\nERROR: test_add_overlay_basic_rgb (satpy.tests.test_writers.TestOverlays)\r\nTest basic add_overlay usage with RGB data.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/antonio/debian/git/satpy/satpy/tests/test_writers.py\", line 599, in setUp\r\n    self.dw = self.dec_writer.start()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1390, in start\r\n    result = self.__enter__()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1243, in __enter__\r\n    self.target = self.getter()\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1413, in <lambda>\r\n    getter = lambda: _importer(target)\r\n  File \"/usr/lib/python3.7/unittest/mock.py\", line 1096, in _importer\r\n    thing = __import__(import_path)\r\nModuleNotFoundError: No module named 'pydecorate'\r\n```\r\n\r\n**Environment Info:**\r\n - Linux (debian sid)\r\n - SatPy Version: 0.11.0\r\n - PyResample Version: 1.10.3\r\n - Readers and writers dependencies (when relevant): \r\nReaders\r\n=======\r\nEnvironment variable PYGAC_CONFIG_FILE not set!\r\nabi_l1b: ok\r\nabi_l1b_scmi: ok\r\nacspo: ok\r\nahi_hrit: ok\r\nahi_hsd: ok\r\namsr2_l1b: ok\r\navhrr_l1b_aapp: ok\r\navhrr_l1b_eps: ok\r\navhrr_l1b_gaclac: cannot find module 'satpy.readers.avhrr_l1b_gaclac' (No module named 'ConfigParser')\r\navhrr_l1b_hrpt: ok\r\ncaliop_l2_cloud: cannot find module 'satpy.readers.caliop_l2_cloud' (No module named 'pyhdf')\r\nclavrx: cannot find module 'satpy.readers.clavrx' (No module named 'pyhdf')\r\nelectrol_hrit: ok\r\nfci_l1c_fdhsi: ok\r\ngeneric_image: ok\r\ngeocat: ok\r\nghrsst_l3c_sst: ok\r\ngoes-imager_hrit: ok\r\ngoes-imager_nc: ok\r\ngrib: ok\r\niasi_l2: ok\r\njami_hrit: ok\r\nli_l2: ok\r\nmaia: ok\r\nmodis_l1b: cannot find module 'satpy.readers.modis_l1b' (No module named 'pyhdf')\r\nmsi_safe: cannot find module 'satpy.readers.msi_safe' (No module named 'glymur')\r\nmtsat2-imager_hrit: ok\r\nnucaps: ok\r\nnwcsaf-geo: ok\r\nnwcsaf-pps_nc: ok\r\nolci_l1b: ok\r\nolci_l2: ok\r\nomps_edr: ok\r\nsar-c_safe: ok\r\nscatsat1_l2b: ok\r\nseviri_l1b_hrit: ok\r\nseviri_l1b_native: ok\r\nseviri_l1b_nc: ok\r\nslstr_l1b: ok\r\nviirs_compact: ok\r\nviirs_edr_flood: cannot find module 'satpy.readers.viirs_edr_flood' (No module named 'pyhdf')\r\nviirs_l1b: ok\r\nviirs_sdr: ok\r\n\r\nWriters\r\n=======\r\ncf: ok\r\ngeotiff: ok\r\nmitiff: ok\r\nninjotiff: cannot find module 'satpy.writers.ninjotiff' (No module named 'pyninjotiff')\r\nscmi: ok\r\nsimple_image: ok\r\n"},"comment":{"url":"https://api.github.com/repos/pytroll/satpy/issues/comments/450573514","html_url":"https://github.com/pytroll/satpy/issues/562#issuecomment-450573514","issue_url":"https://api.github.com/repos/pytroll/satpy/issues/562","id":450573514,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU3MzUxNA==","user":{"login":"avalentino","id":614554,"node_id":"MDQ6VXNlcjYxNDU1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/614554?v=4","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T17:00:54Z","updated_at":"2018-12-30T17:00:54Z","author_association":"CONTRIBUTOR","body":"@djhoese the current status of the debian package can be found in [1].\r\nIn particular in [2] you can find the list of hard dependencies and recommended packages:\r\n\r\n```\r\nDepends: python3-dask,\r\n         python3-grib,\r\n         python3-hdf4,\r\n         python3-numpy (>= 1:1.13),\r\n         python3-pil,\r\n         python3-pykdtree,\r\n         python3-pyproj,\r\n         python3-pyresample (>= 1.10.3),\r\n         python3-scipy,\r\n         python3-six,\r\n         python3-trollimage,\r\n         python3-trollsift,\r\n         python3-xarray,\r\n         python3-yaml\r\nRecommends: python3-behave,\r\n            python3-bs4,\r\n            python3-gdal,\r\n            python3-geotiepoints,\r\n            python3-h5netcdf,\r\n            python3-h5py,\r\n            python3-imageio,\r\n            python3-libtiff (>= 0.4.2),\r\n            python3-netcdf4,\r\n            python3-pycoast,\r\n            python3-pygac,\r\n            python3-pyorbital (>= 1.3.1),\r\n            python3-pyspectral,\r\n            python3-rasterio,\r\n            python3-requests,\r\n            python3-tables,\r\n            python3-trollsched\r\n```\r\n\r\nAll the above packages are already available in debian (or are in the queue to be uploaded in the main archive).\r\n\r\nAt the moment i only plan to add:\r\n\r\n* pydecorate\r\n* glymur\r\n* pyninjotiff\r\n\r\nthat will be added to the list of recommended packages.\r\n\r\nActually some of the less important packages that are currently in recommended could me moved to the \"suggested\" section which is a weaker kind of relation.\r\nMaybe you can provide some hint about that.\r\nProbably pytables is one of the packages that could be moved to \"suggested\" but surely there are others.\r\n\r\n[1] https://salsa.debian.org/debian-gis-team/satpy\r\n[2] https://salsa.debian.org/debian-gis-team/satpy/blob/master/debian/control"}}
{"actor":{"display_login":"avalentino"}}