{"action":"closed","number":1855,"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1855","id":181439771,"html_url":"https://github.com/root-project/root/pull/1855","diff_url":"https://github.com/root-project/root/pull/1855.diff","patch_url":"https://github.com/root-project/root/pull/1855.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1855","number":1855,"state":"closed","locked":false,"title":"[TDF] Replace the name TResultProxy with TResultPtr","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"body":"- Rename the template\r\n- Add the default constructor\r\n- Remove the TResultProxy.hxx header from the PCH\r\n- Include the TResultPtr.hxx header from within the TResultProxy.hxx and create alias for the TResultPtr called TResultProxy. Add a compiler warning about this change.\r\n\r\nThis addresses https://sft.its.cern.ch/jira/browse/ROOT-9350 and relates to roottest PR https://github.com/root-project/roottest/pull/156","created_at":"2018-04-13T09:54:42Z","updated_at":"2018-04-16T09:28:08Z","closed_at":"2018-04-16T09:28:08Z","merged_at":"2018-04-16T09:28:08Z","merge_commit_sha":"6de17a91f57b462e9087fc06f45dfb09fae999fe","assignee":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"assignees":[{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1855/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1855/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1855/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/b92d7afd352582c8726f5872187d9d3a85604cc0","head":{"label":"dpiparo:TResultPtr","ref":"TResultPtr","sha":"b92d7afd352582c8726f5872187d9d3a85604cc0","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"repo":{"id":88480268,"name":"root","full_name":"dpiparo/root","owner":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpiparo/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/dpiparo/root","forks_url":"https://api.github.com/repos/dpiparo/root/forks","keys_url":"https://api.github.com/repos/dpiparo/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpiparo/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpiparo/root/teams","hooks_url":"https://api.github.com/repos/dpiparo/root/hooks","issue_events_url":"https://api.github.com/repos/dpiparo/root/issues/events{/number}","events_url":"https://api.github.com/repos/dpiparo/root/events","assignees_url":"https://api.github.com/repos/dpiparo/root/assignees{/user}","branches_url":"https://api.github.com/repos/dpiparo/root/branches{/branch}","tags_url":"https://api.github.com/repos/dpiparo/root/tags","blobs_url":"https://api.github.com/repos/dpiparo/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpiparo/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpiparo/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpiparo/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpiparo/root/statuses/{sha}","languages_url":"https://api.github.com/repos/dpiparo/root/languages","stargazers_url":"https://api.github.com/repos/dpiparo/root/stargazers","contributors_url":"https://api.github.com/repos/dpiparo/root/contributors","subscribers_url":"https://api.github.com/repos/dpiparo/root/subscribers","subscription_url":"https://api.github.com/repos/dpiparo/root/subscription","commits_url":"https://api.github.com/repos/dpiparo/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpiparo/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpiparo/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpiparo/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpiparo/root/contents/{+path}","compare_url":"https://api.github.com/repos/dpiparo/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpiparo/root/merges","archive_url":"https://api.github.com/repos/dpiparo/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpiparo/root/downloads","issues_url":"https://api.github.com/repos/dpiparo/root/issues{/number}","pulls_url":"https://api.github.com/repos/dpiparo/root/pulls{/number}","milestones_url":"https://api.github.com/repos/dpiparo/root/milestones{/number}","notifications_url":"https://api.github.com/repos/dpiparo/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpiparo/root/labels{/name}","releases_url":"https://api.github.com/repos/dpiparo/root/releases{/id}","deployments_url":"https://api.github.com/repos/dpiparo/root/deployments","created_at":"2017-04-17T06:48:51Z","updated_at":"2017-04-17T06:49:54Z","pushed_at":"2018-04-16T08:55:02Z","git_url":"git://github.com/dpiparo/root.git","ssh_url":"git@github.com:dpiparo/root.git","clone_url":"https://github.com/dpiparo/root.git","svn_url":"https://github.com/dpiparo/root","homepage":"","size":686829,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"1e67c4d9f6277e65b14fef635486655aa8fc8ea1","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-04-15T09:19:28Z","pushed_at":"2018-04-16T09:28:08Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":686632,"stargazers_count":559,"watchers_count":559,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":410,"open_issues":55,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1855"},"html":{"href":"https://github.com/root-project/root/pull/1855"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1855"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1855/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1855/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1855/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/b92d7afd352582c8726f5872187d9d3a85604cc0"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"comments":27,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":509,"deletions":371,"changed_files":12}}
{"actor":{"display_login":"dpiparo"}}