{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/4369","repository_url":"https://api.github.com/repos/xamarin/Xamarin.Forms","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/4369/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/4369/comments","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/4369/events","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/4369","id":379369026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODU2MjAw","number":4369,"title":"WIP - CheckBox & CheckBoxCell Implementation","user":{"login":"jamesmontemagno","id":1676321,"node_id":"MDQ6VXNlcjE2NzYzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1676321?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmontemagno","html_url":"https://github.com/jamesmontemagno","followers_url":"https://api.github.com/users/jamesmontemagno/followers","following_url":"https://api.github.com/users/jamesmontemagno/following{/other_user}","gists_url":"https://api.github.com/users/jamesmontemagno/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmontemagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmontemagno/subscriptions","organizations_url":"https://api.github.com/users/jamesmontemagno/orgs","repos_url":"https://api.github.com/users/jamesmontemagno/repos","events_url":"https://api.github.com/users/jamesmontemagno/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmontemagno/received_events","type":"User","site_admin":false},"labels":[{"id":503596343,"node_id":"MDU6TGFiZWw1MDM1OTYzNDM=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/DO-NOT-MERGE-!!!%20:stop_sign:","name":"DO-NOT-MERGE-!!! :stop_sign:","color":"b60205","default":false},{"id":978568686,"node_id":"MDU6TGFiZWw5Nzg1Njg2ODY=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/e/9%20:clock9:","name":"e/9 :clock9:","color":"23d3cd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-10T00:39:20Z","updated_at":"2018-12-21T19:33:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/4369","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/4369","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/4369.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/4369.patch"},"body":"### Description of Change ###\r\n\r\nStart Implementation of CheckBox and CheckBoxCell. Initial feedback is welcome.\r\n\r\nCheckBox Implementations:\r\n* [x] Android\r\n* [x] iOS\r\n* [x] UWP\r\n* [x] macOS\r\n* [x] WPF\r\n\r\nCheckBoxCell Implementations:\r\n* [x] Android\r\n* [x] iOS\r\n* [x] UWP\r\n* [x] macOS\r\n* [x] WPF\r\n\r\nProperties:\r\n* [x] IsChecked\r\n* [x] CheckedColor \r\n* [x] UncheckedColor \r\n\r\n### Issues Resolved ### \r\n- fixes #1728\r\n\r\n### API Changes ###\r\nAdded:\r\n - CheckBox\r\n\r\n### Platforms Affected ### \r\n- Core/XAML (all platforms)\r\n- iOS\r\n- Android\r\n- UWP\r\n- WPF\r\n\r\n### Behavioral/Visual Changes ###\r\nNone\r\n\r\n### Before/After Screenshots ### \r\n\r\nAndroid:\r\n![image](https://user-images.githubusercontent.com/1676321/48295124-cee43380-e43d-11e8-8d55-aa72a77135bd.png)\r\n\r\niOS:\r\n![image](https://user-images.githubusercontent.com/1676321/50036653-318d9980-ffbf-11e8-8051-fbba1f4296e4.png)\r\n\r\nWPF:\r\n![image](https://user-images.githubusercontent.com/1676321/50036797-a90ff880-ffc0-11e8-9d5d-37106185e947.png)\r\n\r\nUWP:\r\n![image](https://user-images.githubusercontent.com/1676321/50036808-b75e1480-ffc0-11e8-9e84-ca76b039e11b.png)\r\n\r\n\r\n\r\n### Testing Procedure ###\r\n<!-- Please list the steps that should be taken to properly test these changes on each relevant platform. If you were unable to test these changes yourself on any or all platforms, please let us know. Also, if you are able to attach a video of your test run, you will be our personal hero. -->\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has automated tests <!-- (if tests are omitted or manual, state reason in description) -->\r\n- [x] Rebased on top of the target branch at time of PR\r\n- [x] Changes adhere to coding standard\r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments/449479035","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/4369#issuecomment-449479035","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/4369","id":449479035,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQ3OTAzNQ==","user":{"login":"andreinitescu","id":743918,"node_id":"MDQ6VXNlcjc0MzkxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/743918?v=4","gravatar_id":"","url":"https://api.github.com/users/andreinitescu","html_url":"https://github.com/andreinitescu","followers_url":"https://api.github.com/users/andreinitescu/followers","following_url":"https://api.github.com/users/andreinitescu/following{/other_user}","gists_url":"https://api.github.com/users/andreinitescu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreinitescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreinitescu/subscriptions","organizations_url":"https://api.github.com/users/andreinitescu/orgs","repos_url":"https://api.github.com/users/andreinitescu/repos","events_url":"https://api.github.com/users/andreinitescu/events{/privacy}","received_events_url":"https://api.github.com/users/andreinitescu/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T19:33:48Z","updated_at":"2018-12-21T19:33:48Z","author_association":"CONTRIBUTOR","body":"> I think that a Text property is a novel idea\r\nNot sure what you mean by \"novel\" idea. Please see my comment above, I mentioned that except iOS, where check-box doesn't exist, ALL platforms have check-box, and ALL have label too.\r\n\r\n> the text isn't always on the right side, maybe left, maybe below or above\r\nThe most common scenario is having it on the right or left side (depending on the RTL setting).\r\n\r\n> Having a default text option is nice, but what about scale, font properties, text properties, so much overlap in general. \r\nI mentioned in my comment that, many of the implementation can be reused easily. Please take a look.\r\n\r\n> but I look at Switch and there is no Text property there and really CheckBox and Switch are the exact same control IMHO.\r\nLet's think it another way. Apple doesn't seem to want on iOS a check-box control as we know it, the iOS Human Interface Guidelines doesn't mention it anywhere, and UIKit.UISwitch is the iOS control for an on/off widget. \r\nWe definitely want a check-box, even native apps implement it. But a check-box inherently has a label. Like I said, all platforms which have check-box, have label.\r\n\r\n\r\n"}}
{"actor":{"display_login":"andreinitescu"}}