{"action":"created","comment":{"url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/comments/197485303","pull_request_review_id":131243811,"id":197485303,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzQ4NTMwMw==","diff_hunk":"@@ -79,19 +99,75 @@ public void testElementValues() {\n \n         // Cannot compare ID strings, as they change when uploading to a Fedora server.\n         Publication publication = (Publication)entities.get(submissionEntity.getPublication());\n-        assertEquals(submission.getMetadata().getArticleMetadata().getDoi().toString(), publication.getDoi());\n+        assertEquals(EXPECTED_DOI, submission.getMetadata().getArticleMetadata().getDoi().toString());\n \n         assertNotNull(submission.getFiles());\n         assertEquals(2, submission.getFiles().size());\n \n         // Confirm that some values were set correctly from the Submission metadata\n         DepositMetadata.Journal journalMetadata = submission.getMetadata().getJournalMetadata();\n-        assertEquals(\"Food Funct.\", journalMetadata.getJournalTitle());\n-        assertEquals(\"TD452689\", journalMetadata.getJournalId());\n-        assertEquals(\"2042-6496,2042-650X\", journalMetadata.getIssn());\n+        assertEquals(EXPECTED_JOURNAL_TITLE, journalMetadata.getJournalTitle());\n+        assertEquals(EXPECTED_ISSN, journalMetadata.getIssn());\n \n         DepositMetadata.Manuscript manuscriptMetadata = submission.getMetadata().getManuscriptMetadata();\n-        assertEquals(\"http://dx.doi.org/10.1039/c7fo01251a\", manuscriptMetadata.getManuscriptUrl().toString());\n+        assertNull(manuscriptMetadata.getManuscriptUrl());\n+\n+//        assertTrue(submission.getMetadata().getArticleMetadata().getUnderEmbargo());\n+        assertEquals(EXPECTED_EMBARGO_END_DATE, submission.getMetadata().getArticleMetadata().getEmbargoLiftDate()\n+                .format(DateTimeFormatter.ofPattern(\"uuuu-MM-dd\")));\n+\n+        List<DepositMetadata.Person> persons = submission.getMetadata().getPersons();\n+        int authors = 0;\n+        int pis = 0;\n+        int copis = 0;\n+        int submitters = 0;\n+        for (DepositMetadata.Person person : persons) {\n+            switch (person.getType()) {\n+                case author:\n+                    authors++;\n+                    break;\n+                case pi:\n+                    pis++;\n+                    break;\n+                case copi:\n+                    copis++;\n+                    break;\n+                case submitter:\n+                    submitters++;\n+                    break;\n+            }\n+        }\n+\n+        assertEquals(EXPECTED_SUBMITER_COUNT, submitters);\n+        assertEquals(EXPECTED_PI_COUNT, pis);\n+        assertEquals(EXPECTED_CO_PI_COUNT, copis);\n+        assertEquals(EXPECTED_AUTHOR_COUNT, authors);\n+\n+        assertTrue(persons.stream()","path":"nihms-integration/src/test/java/org/dataconservancy/pass/deposit/builder/fedora/FcrepoModelBuilderIT.java","position":null,"original_position":95,"commit_id":"b32dc1704458b9e821e0f64fdba0baf3925b195c","original_commit_id":"1c71405b40ee16402a14b20c6c9216ad012f6852","user":{"login":"emetsger","id":146970,"node_id":"MDQ6VXNlcjE0Njk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/146970?v=4","gravatar_id":"","url":"https://api.github.com/users/emetsger","html_url":"https://github.com/emetsger","followers_url":"https://api.github.com/users/emetsger/followers","following_url":"https://api.github.com/users/emetsger/following{/other_user}","gists_url":"https://api.github.com/users/emetsger/gists{/gist_id}","starred_url":"https://api.github.com/users/emetsger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emetsger/subscriptions","organizations_url":"https://api.github.com/users/emetsger/orgs","repos_url":"https://api.github.com/users/emetsger/repos","events_url":"https://api.github.com/users/emetsger/events{/privacy}","received_events_url":"https://api.github.com/users/emetsger/received_events","type":"User","site_admin":false},"body":"@Trumbore I went ahead and added these to `FilesystemModelBuilderTest` and `FcrepoModelBuilderIT`.\r\n\r\nI think that this functionality is critical enough that this duplication is \"ok\".  Maybe not \"warranted\", but definitely \"ok\".  I wanted my changes to the two tests to be minimal, so I just added these in to insure coverage.\r\n\r\n","created_at":"2018-06-22T15:36:41Z","updated_at":"2018-06-22T15:36:42Z","html_url":"https://github.com/OA-PASS/nihms-submission/pull/121#discussion_r197485303","pull_request_url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/comments/197485303"},"html":{"href":"https://github.com/OA-PASS/nihms-submission/pull/121#discussion_r197485303"},"pull_request":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121"}},"in_reply_to_id":197266990},"pull_request":{"url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121","id":196558730,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTU4NzMw","html_url":"https://github.com/OA-PASS/nihms-submission/pull/121","diff_url":"https://github.com/OA-PASS/nihms-submission/pull/121.diff","patch_url":"https://github.com/OA-PASS/nihms-submission/pull/121.patch","issue_url":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/121","number":121,"state":"open","locked":false,"title":"Correct parsing of the metadata JSON blob from the UI.","user":{"login":"emetsger","id":146970,"node_id":"MDQ6VXNlcjE0Njk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/146970?v=4","gravatar_id":"","url":"https://api.github.com/users/emetsger","html_url":"https://github.com/emetsger","followers_url":"https://api.github.com/users/emetsger/followers","following_url":"https://api.github.com/users/emetsger/following{/other_user}","gists_url":"https://api.github.com/users/emetsger/gists{/gist_id}","starred_url":"https://api.github.com/users/emetsger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emetsger/subscriptions","organizations_url":"https://api.github.com/users/emetsger/orgs","repos_url":"https://api.github.com/users/emetsger/repos","events_url":"https://api.github.com/users/emetsger/events{/privacy}","received_events_url":"https://api.github.com/users/emetsger/received_events","type":"User","site_admin":false},"body":"The metadata blob used for updated testing is copied verbatim from:\r\nhttps://github.com/OA-PASS/nihms-submission/issues/119#issuecomment-399133248\r\n\r\nChanges include:\r\n- No longer using or supporting `Manuscript.manuscriptUrl`\r\n- `Publication` resource is no longer consulted for metadata\r\n- DOI is parsed from `crossref` metadata\r\n- Journal ID is no longer parsed\r\n- No longer consult 'JScholarship' metadata in the blob, it has nothing needed by Deposit Services\r\n- Embargo metadata is now parsed from the `common` metadata\r\n- Article metadata no longer has a boolean for `underEmbargo`, it simply provides the `embargoLiftDate`; the caller is responsible for determining if the embargo still applies.\r\n- additional tests in `FcrepoModelBuilderIT`\r\n\r\nCloses #119","created_at":"2018-06-21T19:56:09Z","updated_at":"2018-06-22T15:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87e92a8e1dc40387624735baba51281206d5eb4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121/commits","review_comments_url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121/comments","review_comment_url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/121/comments","statuses_url":"https://api.github.com/repos/OA-PASS/nihms-submission/statuses/b32dc1704458b9e821e0f64fdba0baf3925b195c","head":{"label":"emetsger:metadata-blob-parsing","ref":"metadata-blob-parsing","sha":"b32dc1704458b9e821e0f64fdba0baf3925b195c","user":{"login":"emetsger","id":146970,"node_id":"MDQ6VXNlcjE0Njk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/146970?v=4","gravatar_id":"","url":"https://api.github.com/users/emetsger","html_url":"https://github.com/emetsger","followers_url":"https://api.github.com/users/emetsger/followers","following_url":"https://api.github.com/users/emetsger/following{/other_user}","gists_url":"https://api.github.com/users/emetsger/gists{/gist_id}","starred_url":"https://api.github.com/users/emetsger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emetsger/subscriptions","organizations_url":"https://api.github.com/users/emetsger/orgs","repos_url":"https://api.github.com/users/emetsger/repos","events_url":"https://api.github.com/users/emetsger/events{/privacy}","received_events_url":"https://api.github.com/users/emetsger/received_events","type":"User","site_admin":false},"repo":{"id":110991001,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA5OTEwMDE=","name":"nihms-submission","full_name":"emetsger/nihms-submission","owner":{"login":"emetsger","id":146970,"node_id":"MDQ6VXNlcjE0Njk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/146970?v=4","gravatar_id":"","url":"https://api.github.com/users/emetsger","html_url":"https://github.com/emetsger","followers_url":"https://api.github.com/users/emetsger/followers","following_url":"https://api.github.com/users/emetsger/following{/other_user}","gists_url":"https://api.github.com/users/emetsger/gists{/gist_id}","starred_url":"https://api.github.com/users/emetsger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emetsger/subscriptions","organizations_url":"https://api.github.com/users/emetsger/orgs","repos_url":"https://api.github.com/users/emetsger/repos","events_url":"https://api.github.com/users/emetsger/events{/privacy}","received_events_url":"https://api.github.com/users/emetsger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emetsger/nihms-submission","description":"NIH manuscript submission","fork":true,"url":"https://api.github.com/repos/emetsger/nihms-submission","forks_url":"https://api.github.com/repos/emetsger/nihms-submission/forks","keys_url":"https://api.github.com/repos/emetsger/nihms-submission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emetsger/nihms-submission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emetsger/nihms-submission/teams","hooks_url":"https://api.github.com/repos/emetsger/nihms-submission/hooks","issue_events_url":"https://api.github.com/repos/emetsger/nihms-submission/issues/events{/number}","events_url":"https://api.github.com/repos/emetsger/nihms-submission/events","assignees_url":"https://api.github.com/repos/emetsger/nihms-submission/assignees{/user}","branches_url":"https://api.github.com/repos/emetsger/nihms-submission/branches{/branch}","tags_url":"https://api.github.com/repos/emetsger/nihms-submission/tags","blobs_url":"https://api.github.com/repos/emetsger/nihms-submission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emetsger/nihms-submission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emetsger/nihms-submission/git/refs{/sha}","trees_url":"https://api.github.com/repos/emetsger/nihms-submission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emetsger/nihms-submission/statuses/{sha}","languages_url":"https://api.github.com/repos/emetsger/nihms-submission/languages","stargazers_url":"https://api.github.com/repos/emetsger/nihms-submission/stargazers","contributors_url":"https://api.github.com/repos/emetsger/nihms-submission/contributors","subscribers_url":"https://api.github.com/repos/emetsger/nihms-submission/subscribers","subscription_url":"https://api.github.com/repos/emetsger/nihms-submission/subscription","commits_url":"https://api.github.com/repos/emetsger/nihms-submission/commits{/sha}","git_commits_url":"https://api.github.com/repos/emetsger/nihms-submission/git/commits{/sha}","comments_url":"https://api.github.com/repos/emetsger/nihms-submission/comments{/number}","issue_comment_url":"https://api.github.com/repos/emetsger/nihms-submission/issues/comments{/number}","contents_url":"https://api.github.com/repos/emetsger/nihms-submission/contents/{+path}","compare_url":"https://api.github.com/repos/emetsger/nihms-submission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emetsger/nihms-submission/merges","archive_url":"https://api.github.com/repos/emetsger/nihms-submission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emetsger/nihms-submission/downloads","issues_url":"https://api.github.com/repos/emetsger/nihms-submission/issues{/number}","pulls_url":"https://api.github.com/repos/emetsger/nihms-submission/pulls{/number}","milestones_url":"https://api.github.com/repos/emetsger/nihms-submission/milestones{/number}","notifications_url":"https://api.github.com/repos/emetsger/nihms-submission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emetsger/nihms-submission/labels{/name}","releases_url":"https://api.github.com/repos/emetsger/nihms-submission/releases{/id}","deployments_url":"https://api.github.com/repos/emetsger/nihms-submission/deployments","created_at":"2017-11-16T15:50:19Z","updated_at":"2018-05-31T13:47:47Z","pushed_at":"2018-06-22T15:23:02Z","git_url":"git://github.com/emetsger/nihms-submission.git","ssh_url":"git@github.com:emetsger/nihms-submission.git","clone_url":"https://github.com/emetsger/nihms-submission.git","svn_url":"https://github.com/emetsger/nihms-submission","homepage":null,"size":13258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OA-PASS:master","ref":"master","sha":"b489c60bfac938aada591863d9efb1cc4cba19be","user":{"login":"OA-PASS","id":36713230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzEzMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/36713230?v=4","gravatar_id":"","url":"https://api.github.com/users/OA-PASS","html_url":"https://github.com/OA-PASS","followers_url":"https://api.github.com/users/OA-PASS/followers","following_url":"https://api.github.com/users/OA-PASS/following{/other_user}","gists_url":"https://api.github.com/users/OA-PASS/gists{/gist_id}","starred_url":"https://api.github.com/users/OA-PASS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OA-PASS/subscriptions","organizations_url":"https://api.github.com/users/OA-PASS/orgs","repos_url":"https://api.github.com/users/OA-PASS/repos","events_url":"https://api.github.com/users/OA-PASS/events{/privacy}","received_events_url":"https://api.github.com/users/OA-PASS/received_events","type":"Organization","site_admin":false},"repo":{"id":110598576,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1OTg1NzY=","name":"nihms-submission","full_name":"OA-PASS/nihms-submission","owner":{"login":"OA-PASS","id":36713230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzEzMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/36713230?v=4","gravatar_id":"","url":"https://api.github.com/users/OA-PASS","html_url":"https://github.com/OA-PASS","followers_url":"https://api.github.com/users/OA-PASS/followers","following_url":"https://api.github.com/users/OA-PASS/following{/other_user}","gists_url":"https://api.github.com/users/OA-PASS/gists{/gist_id}","starred_url":"https://api.github.com/users/OA-PASS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OA-PASS/subscriptions","organizations_url":"https://api.github.com/users/OA-PASS/orgs","repos_url":"https://api.github.com/users/OA-PASS/repos","events_url":"https://api.github.com/users/OA-PASS/events{/privacy}","received_events_url":"https://api.github.com/users/OA-PASS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OA-PASS/nihms-submission","description":"NIH manuscript submission","fork":false,"url":"https://api.github.com/repos/OA-PASS/nihms-submission","forks_url":"https://api.github.com/repos/OA-PASS/nihms-submission/forks","keys_url":"https://api.github.com/repos/OA-PASS/nihms-submission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OA-PASS/nihms-submission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OA-PASS/nihms-submission/teams","hooks_url":"https://api.github.com/repos/OA-PASS/nihms-submission/hooks","issue_events_url":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/events{/number}","events_url":"https://api.github.com/repos/OA-PASS/nihms-submission/events","assignees_url":"https://api.github.com/repos/OA-PASS/nihms-submission/assignees{/user}","branches_url":"https://api.github.com/repos/OA-PASS/nihms-submission/branches{/branch}","tags_url":"https://api.github.com/repos/OA-PASS/nihms-submission/tags","blobs_url":"https://api.github.com/repos/OA-PASS/nihms-submission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OA-PASS/nihms-submission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OA-PASS/nihms-submission/git/refs{/sha}","trees_url":"https://api.github.com/repos/OA-PASS/nihms-submission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OA-PASS/nihms-submission/statuses/{sha}","languages_url":"https://api.github.com/repos/OA-PASS/nihms-submission/languages","stargazers_url":"https://api.github.com/repos/OA-PASS/nihms-submission/stargazers","contributors_url":"https://api.github.com/repos/OA-PASS/nihms-submission/contributors","subscribers_url":"https://api.github.com/repos/OA-PASS/nihms-submission/subscribers","subscription_url":"https://api.github.com/repos/OA-PASS/nihms-submission/subscription","commits_url":"https://api.github.com/repos/OA-PASS/nihms-submission/commits{/sha}","git_commits_url":"https://api.github.com/repos/OA-PASS/nihms-submission/git/commits{/sha}","comments_url":"https://api.github.com/repos/OA-PASS/nihms-submission/comments{/number}","issue_comment_url":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/comments{/number}","contents_url":"https://api.github.com/repos/OA-PASS/nihms-submission/contents/{+path}","compare_url":"https://api.github.com/repos/OA-PASS/nihms-submission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OA-PASS/nihms-submission/merges","archive_url":"https://api.github.com/repos/OA-PASS/nihms-submission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OA-PASS/nihms-submission/downloads","issues_url":"https://api.github.com/repos/OA-PASS/nihms-submission/issues{/number}","pulls_url":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls{/number}","milestones_url":"https://api.github.com/repos/OA-PASS/nihms-submission/milestones{/number}","notifications_url":"https://api.github.com/repos/OA-PASS/nihms-submission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OA-PASS/nihms-submission/labels{/name}","releases_url":"https://api.github.com/repos/OA-PASS/nihms-submission/releases{/id}","deployments_url":"https://api.github.com/repos/OA-PASS/nihms-submission/deployments","created_at":"2017-11-13T20:31:32Z","updated_at":"2018-06-21T20:04:06Z","pushed_at":"2018-06-22T15:23:03Z","git_url":"git://github.com/OA-PASS/nihms-submission.git","ssh_url":"git@github.com:OA-PASS/nihms-submission.git","clone_url":"https://github.com/OA-PASS/nihms-submission.git","svn_url":"https://github.com/OA-PASS/nihms-submission","homepage":null,"size":12941,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":4,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121"},"html":{"href":"https://github.com/OA-PASS/nihms-submission/pull/121"},"issue":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/121"},"comments":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/OA-PASS/nihms-submission/statuses/b32dc1704458b9e821e0f64fdba0baf3925b195c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emetsger"}}