{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/lagom/pulls/comments/203507981","pull_request_review_id":138412374,"id":203507981,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzUwNzk4MQ==","diff_hunk":"@@ -36,21 +35,15 @@ def common: Seq[Setting[_]] = releaseSettings ++ bintraySettings ++ evictionSett\n   licenses := Seq((\"Apache-2.0\", url(\"http://www.apache.org/licenses/LICENSE-2.0.html\"))),\n   homepage := Some(url(\"https://www.lagomframework.com/\")),\n   sonatypeProfileName := \"com.lightbend\",\n-  headers := headers.value ++ Map(\n-     \"scala\" -> (\n-       HeaderPattern.cStyleBlockComment,\n-       \"\"\"|/*\n-          | * Copyright (C) 2016-2018 Lightbend Inc. <https://www.lightbend.com>\n-          | */\n-          |\"\"\".stripMargin\n-     ),\n-     \"java\" -> (\n-       HeaderPattern.cStyleBlockComment,\n-       \"\"\"|/*\n-          | * Copyright (C) 2016-2018 Lightbend Inc. <https://www.lightbend.com>\n-          | */\n-          |\"\"\".stripMargin\n-     )\n+  headerLicense := Some(HeaderLicense.Custom(\n+    \"\"\"|/*\n+       | * Copyright (C) 2016-2018 Lightbend Inc. <https://www.lightbend.com>\n+       | */\n+       |\"\"\".stripMargin\n+  )),\n+  headerMappings := headerMappings.value ++ Map(\n+    HeaderFileType.scala -> HeaderCommentStyle.cStyleBlockComment,\n+    HeaderFileType.java -> HeaderCommentStyle.cStyleBlockComment","path":"build.sbt","position":35,"original_position":35,"commit_id":"7aa02ba157b262b29bba826e34d80ad2aa439363","original_commit_id":"7aa02ba157b262b29bba826e34d80ad2aa439363","user":{"login":"erip","id":2348806,"node_id":"MDQ6VXNlcjIzNDg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2348806?v=4","gravatar_id":"","url":"https://api.github.com/users/erip","html_url":"https://github.com/erip","followers_url":"https://api.github.com/users/erip/followers","following_url":"https://api.github.com/users/erip/following{/other_user}","gists_url":"https://api.github.com/users/erip/gists{/gist_id}","starred_url":"https://api.github.com/users/erip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erip/subscriptions","organizations_url":"https://api.github.com/users/erip/orgs","repos_url":"https://api.github.com/users/erip/repos","events_url":"https://api.github.com/users/erip/events{/privacy}","received_events_url":"https://api.github.com/users/erip/received_events","type":"User","site_admin":false},"body":"So you want `Seq(HeaderFileType.scala, HeaderFileType.java).map(_ -> HeaderCommentStyle.cStyleBlockComment)`? 😅 ","created_at":"2018-07-18T19:52:45Z","updated_at":"2018-07-18T19:52:45Z","html_url":"https://github.com/lagom/lagom/pull/1455#discussion_r203507981","pull_request_url":"https://api.github.com/repos/lagom/lagom/pulls/1455","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments/203507981"},"html":{"href":"https://github.com/lagom/lagom/pull/1455#discussion_r203507981"},"pull_request":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1455"}},"in_reply_to_id":203507431},"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1455","id":202358890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzU4ODkw","html_url":"https://github.com/lagom/lagom/pull/1455","diff_url":"https://github.com/lagom/lagom/pull/1455.diff","patch_url":"https://github.com/lagom/lagom/pull/1455.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1455","number":1455,"state":"open","locked":false,"title":"WIP: Build Lagom with sbt 1.x","user":{"login":"erip","id":2348806,"node_id":"MDQ6VXNlcjIzNDg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2348806?v=4","gravatar_id":"","url":"https://api.github.com/users/erip","html_url":"https://github.com/erip","followers_url":"https://api.github.com/users/erip/followers","following_url":"https://api.github.com/users/erip/following{/other_user}","gists_url":"https://api.github.com/users/erip/gists{/gist_id}","starred_url":"https://api.github.com/users/erip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erip/subscriptions","organizations_url":"https://api.github.com/users/erip/orgs","repos_url":"https://api.github.com/users/erip/repos","events_url":"https://api.github.com/users/erip/events{/privacy}","received_events_url":"https://api.github.com/users/erip/received_events","type":"User","site_admin":false},"body":"Fixes #1329.\r\n\r\n___\r\n\r\nI'm going to make a (potentially non-exhaustive) list of plugins that need to be updated for compatibility here... the RHS of the arrow is the at-least version. \r\n\r\n- [ ] `com.eed3si9n#sbt-buildinfo;0.3.2` -> `addSbtPlugin(\"com.eed3si9n\" % \"sbt-buildinfo\" % \"0.7.1\")`\r\n- [ ] `org.scala-sbt#scripted-plugin;1.1.4`-> included in sbt... but is an `AutoPlugin`. needs to be disabled for non-scripted projects\r\n- [ ] `com.eed3si9n#sbt-unidoc;0.3.3` -> `addSbtPlugin(\"com.eed3si9n\" % \"sbt-unidoc\" % \"0.4.1\")`\r\n- [ ] `de.heikoseeberger#sbt-header;1.8.0` -> `addSbtPlugin(\"de.heikoseeberger\" % \"sbt-header\" % \"3.0.0\")`\r\n- [ ] `org.xerial.sbt#sbt-sonatype;0.5.0` -> `addSbtPlugin(\"org.xerial.sbt\" % \"sbt-sonatype\" % \"2.0\")`\r\n- [ ] `com.github.gseitz#sbt-release;1.0.3` -> `addSbtPlugin(\"com.github.gseitz\" % \"sbt-release\" % \"1.0.6\")`\r\n- [ ] `com.jsuereth#sbt-pgp;1.0.0` -> `addSbtPlugin(\"com.jsuereth\" % \"sbt-pgp\" % \"1.1.0\")`\r\n- [ ] `me.lessis#bintray-sbt;0.3.0` -> `addSbtPlugin(\"org.foundweekends\" % \"sbt-bintray\" % \"0.5.1\")` ???\r\n- [ ] `com.typesafe.sbt#sbt-site;0.7.1` -> `addSbtPlugin(\"com.typesafe.sbt\" % \"sbt-site\" % \"1.3.0\")`\r\n- [ ] `org.scalariform#sbt-scalariform;1.6.0` -> `addSbtPlugin(\"org.scalariform\" % \"sbt-scalariform\" % \"1.8.0\")`\r\n- [ ] `com.typesafe.sbt#sbt-multi-jvm;0.3.8` -> `addSbtPlugin(\"com.typesafe.sbt\" % \"sbt-multi-jvm\" % \"0.4.0\")`\r\n- [ ] `com.eed3si9n#sbt-doge;0.1.5` -> now part of sbt\r\n- [ ] `net.virtual-void#sbt-dependency-graph;0.8.2` -> `addSbtPlugin(\"net.virtual-void\" % \"sbt-dependency-graph\" % \"0.9.0\")`","created_at":"2018-07-18T19:41:47Z","updated_at":"2018-07-18T19:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc32fc330b1d888927a5b8f93da8bea62e79ef6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1455/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1455/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1455/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/7aa02ba157b262b29bba826e34d80ad2aa439363","head":{"label":"erip:feature/build-with-sbt-1.x","ref":"feature/build-with-sbt-1.x","sha":"7aa02ba157b262b29bba826e34d80ad2aa439363","user":{"login":"erip","id":2348806,"node_id":"MDQ6VXNlcjIzNDg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2348806?v=4","gravatar_id":"","url":"https://api.github.com/users/erip","html_url":"https://github.com/erip","followers_url":"https://api.github.com/users/erip/followers","following_url":"https://api.github.com/users/erip/following{/other_user}","gists_url":"https://api.github.com/users/erip/gists{/gist_id}","starred_url":"https://api.github.com/users/erip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erip/subscriptions","organizations_url":"https://api.github.com/users/erip/orgs","repos_url":"https://api.github.com/users/erip/repos","events_url":"https://api.github.com/users/erip/events{/privacy}","received_events_url":"https://api.github.com/users/erip/received_events","type":"User","site_admin":false},"repo":{"id":122673715,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NzM3MTU=","name":"lagom","full_name":"erip/lagom","owner":{"login":"erip","id":2348806,"node_id":"MDQ6VXNlcjIzNDg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2348806?v=4","gravatar_id":"","url":"https://api.github.com/users/erip","html_url":"https://github.com/erip","followers_url":"https://api.github.com/users/erip/followers","following_url":"https://api.github.com/users/erip/following{/other_user}","gists_url":"https://api.github.com/users/erip/gists{/gist_id}","starred_url":"https://api.github.com/users/erip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erip/subscriptions","organizations_url":"https://api.github.com/users/erip/orgs","repos_url":"https://api.github.com/users/erip/repos","events_url":"https://api.github.com/users/erip/events{/privacy}","received_events_url":"https://api.github.com/users/erip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erip/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/erip/lagom","forks_url":"https://api.github.com/repos/erip/lagom/forks","keys_url":"https://api.github.com/repos/erip/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erip/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erip/lagom/teams","hooks_url":"https://api.github.com/repos/erip/lagom/hooks","issue_events_url":"https://api.github.com/repos/erip/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/erip/lagom/events","assignees_url":"https://api.github.com/repos/erip/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/erip/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/erip/lagom/tags","blobs_url":"https://api.github.com/repos/erip/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erip/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erip/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/erip/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erip/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/erip/lagom/languages","stargazers_url":"https://api.github.com/repos/erip/lagom/stargazers","contributors_url":"https://api.github.com/repos/erip/lagom/contributors","subscribers_url":"https://api.github.com/repos/erip/lagom/subscribers","subscription_url":"https://api.github.com/repos/erip/lagom/subscription","commits_url":"https://api.github.com/repos/erip/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/erip/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/erip/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/erip/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/erip/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/erip/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erip/lagom/merges","archive_url":"https://api.github.com/repos/erip/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erip/lagom/downloads","issues_url":"https://api.github.com/repos/erip/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/erip/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/erip/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/erip/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erip/lagom/labels{/name}","releases_url":"https://api.github.com/repos/erip/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/erip/lagom/deployments","created_at":"2018-02-23T21:18:20Z","updated_at":"2018-07-18T16:19:09Z","pushed_at":"2018-07-18T19:40:13Z","git_url":"git://github.com/erip/lagom.git","ssh_url":"git@github.com:erip/lagom.git","clone_url":"https://github.com/erip/lagom.git","svn_url":"https://github.com/erip/lagom","homepage":"https://www.lagomframework.com","size":7820,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"336a856f770087bd30989f2d2fb9b297aca884d9","user":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyMDk2Nw==","name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2018-07-18T07:01:57Z","pushed_at":"2018-07-18T19:41:48Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":7929,"stargazers_count":1934,"watchers_count":1934,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":415,"mirror_url":null,"archived":false,"open_issues_count":281,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":415,"open_issues":281,"watchers":1934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1455"},"html":{"href":"https://github.com/lagom/lagom/pull/1455"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1455"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1455/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1455/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1455/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/7aa02ba157b262b29bba826e34d80ad2aa439363"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"erip"}}