{"action":"opened","number":4036,"pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/4036","id":239863449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODYzNDQ5","html_url":"https://github.com/toggl/mobileapp/pull/4036","diff_url":"https://github.com/toggl/mobileapp/pull/4036.diff","patch_url":"https://github.com/toggl/mobileapp/pull/4036.patch","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/4036","number":4036,"state":"open","locked":false,"title":"Separate asking for google data from actual sign up process","user":{"login":"kornelijepetak","id":7033216,"node_id":"MDQ6VXNlcjcwMzMyMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7033216?v=4","gravatar_id":"","url":"https://api.github.com/users/kornelijepetak","html_url":"https://github.com/kornelijepetak","followers_url":"https://api.github.com/users/kornelijepetak/followers","following_url":"https://api.github.com/users/kornelijepetak/following{/other_user}","gists_url":"https://api.github.com/users/kornelijepetak/gists{/gist_id}","starred_url":"https://api.github.com/users/kornelijepetak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kornelijepetak/subscriptions","organizations_url":"https://api.github.com/users/kornelijepetak/orgs","repos_url":"https://api.github.com/users/kornelijepetak/repos","events_url":"https://api.github.com/users/kornelijepetak/events{/privacy}","received_events_url":"https://api.github.com/users/kornelijepetak/received_events","type":"User","site_admin":false},"body":"### What's this?\r\nSeparates the call to get Google user data and call to the signup so that we don't send user information to our servers until the very last step. If user decides to cancel the signup with google request, we should have zero API requests.\r\n\r\n### Relationships\r\n🔑 Project. Required for #4029.\r\n\r\n## How is it done?\r\nUser Access Manager now provides two methods\r\n1. Access google user data\r\n2. Signup with that data\r\n\r\n### Why not another way?\r\nThe old way conflated the steps, making us unable to work out the new flow.\r\n\r\n## :squid: Permissions\r\n🔑 people.","created_at":"2018-12-19T14:53:03Z","updated_at":"2018-12-19T14:53:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831152836,"node_id":"MDU6TGFiZWw4MzExNTI4MzY=","url":"https://api.github.com/repos/toggl/mobileapp/labels/foundation","name":"foundation","color":"646490","default":false},{"id":829930771,"node_id":"MDU6TGFiZWw4Mjk5MzA3NzE=","url":"https://api.github.com/repos/toggl/mobileapp/labels/refactoring","name":"refactoring","color":"ffe787","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/toggl/mobileapp/pulls/4036/commits","review_comments_url":"https://api.github.com/repos/toggl/mobileapp/pulls/4036/comments","review_comment_url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/4036/comments","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/cd169feac44e0adab8059b38e4be174ae10a026e","head":{"label":"toggl:kornelije/uam-google-token","ref":"kornelije/uam-google-token","sha":"cd169feac44e0adab8059b38e4be174ae10a026e","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-12-19T13:32:03Z","pushed_at":"2018-12-19T14:40:13Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":28156,"stargazers_count":100,"watchers_count":100,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":240,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":240,"watchers":100,"default_branch":"develop"}},"base":{"label":"toggl:project/user-access-improvements","ref":"project/user-access-improvements","sha":"c1ddcea8acf7199919dfccc9de3fa501f57a939d","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-12-19T13:32:03Z","pushed_at":"2018-12-19T14:40:13Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":28156,"stargazers_count":100,"watchers_count":100,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":240,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":240,"watchers":100,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/4036"},"html":{"href":"https://github.com/toggl/mobileapp/pull/4036"},"issue":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/4036"},"comments":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/4036/comments"},"review_comments":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/4036/comments"},"review_comment":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/4036/commits"},"statuses":{"href":"https://api.github.com/repos/toggl/mobileapp/statuses/cd169feac44e0adab8059b38e4be174ae10a026e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":80,"deletions":41,"changed_files":10}}
{"actor":{"display_login":"kornelijepetak"}}