{"action":"closed","number":1707,"pull_request":{"url":"https://api.github.com/repos/brave/brave-browser/pulls/1707","id":224036148,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDM2MTQ4","html_url":"https://github.com/brave/brave-browser/pull/1707","diff_url":"https://github.com/brave/brave-browser/pull/1707.diff","patch_url":"https://github.com/brave/brave-browser/pull/1707.patch","issue_url":"https://api.github.com/repos/brave/brave-browser/issues/1707","number":1707,"state":"closed","locked":false,"title":"Detect internal IPs, expand whitelist, add output_path option for release builds","user":{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/brave/brave-browser/issues/1706\r\n\r\n## Submitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- Verified that these changes build without errors on\r\n  - [ ] Windows\r\n  - [ ] macOS\r\n  - [ ] Linux\r\n- Verified that these changes pass automated tests (`npm test brave_unit_tests && npm test brave_browser_tests`) on\r\n  - [ ] Windows\r\n  - [ ] macOS\r\n  - [ ] Linux\r\n- [ ] Ran `git rebase master` (if needed).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Requested a security/privacy review as needed.\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions.\r\n","created_at":"2018-10-18T17:23:52Z","updated_at":"2018-10-18T21:47:02Z","closed_at":"2018-10-18T21:47:02Z","merged_at":"2018-10-18T21:47:02Z","merge_commit_sha":"dc482e09800edab4136fee6e5705f547dfd1443c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-browser/pulls/1707/commits","review_comments_url":"https://api.github.com/repos/brave/brave-browser/pulls/1707/comments","review_comment_url":"https://api.github.com/repos/brave/brave-browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-browser/issues/1707/comments","statuses_url":"https://api.github.com/repos/brave/brave-browser/statuses/f918860c745c5c77747bcd3783985c98e30e6670","head":{"label":"brave:fix/audit-whitelist1","ref":"fix/audit-whitelist1","sha":"f918860c745c5c77747bcd3783985c98e30e6670","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110178895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxNzg4OTU=","name":"brave-browser","full_name":"brave/brave-browser","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-browser","description":"Next generation Brave browser for macOS, Windows, Linux, and eventually Android","fork":false,"url":"https://api.github.com/repos/brave/brave-browser","forks_url":"https://api.github.com/repos/brave/brave-browser/forks","keys_url":"https://api.github.com/repos/brave/brave-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-browser/teams","hooks_url":"https://api.github.com/repos/brave/brave-browser/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-browser/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-browser/events","assignees_url":"https://api.github.com/repos/brave/brave-browser/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-browser/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-browser/tags","blobs_url":"https://api.github.com/repos/brave/brave-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-browser/languages","stargazers_url":"https://api.github.com/repos/brave/brave-browser/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-browser/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-browser/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-browser/subscription","commits_url":"https://api.github.com/repos/brave/brave-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-browser/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-browser/merges","archive_url":"https://api.github.com/repos/brave/brave-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-browser/downloads","issues_url":"https://api.github.com/repos/brave/brave-browser/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-browser/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-browser/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-browser/deployments","created_at":"2017-11-09T23:44:38Z","updated_at":"2018-10-18T20:48:15Z","pushed_at":"2018-10-18T21:47:02Z","git_url":"git://github.com/brave/brave-browser.git","ssh_url":"git@github.com:brave/brave-browser.git","clone_url":"https://github.com/brave/brave-browser.git","svn_url":"https://github.com/brave/brave-browser","homepage":"https://www.brave.com","size":731,"stargazers_count":495,"watchers_count":495,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":645,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":645,"watchers":495,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"ce363d2ad70c5782a9c6a75fd561f0c0e4642a9d","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110178895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxNzg4OTU=","name":"brave-browser","full_name":"brave/brave-browser","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-browser","description":"Next generation Brave browser for macOS, Windows, Linux, and eventually Android","fork":false,"url":"https://api.github.com/repos/brave/brave-browser","forks_url":"https://api.github.com/repos/brave/brave-browser/forks","keys_url":"https://api.github.com/repos/brave/brave-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-browser/teams","hooks_url":"https://api.github.com/repos/brave/brave-browser/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-browser/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-browser/events","assignees_url":"https://api.github.com/repos/brave/brave-browser/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-browser/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-browser/tags","blobs_url":"https://api.github.com/repos/brave/brave-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-browser/languages","stargazers_url":"https://api.github.com/repos/brave/brave-browser/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-browser/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-browser/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-browser/subscription","commits_url":"https://api.github.com/repos/brave/brave-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-browser/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-browser/merges","archive_url":"https://api.github.com/repos/brave/brave-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-browser/downloads","issues_url":"https://api.github.com/repos/brave/brave-browser/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-browser/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-browser/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-browser/deployments","created_at":"2017-11-09T23:44:38Z","updated_at":"2018-10-18T20:48:15Z","pushed_at":"2018-10-18T21:47:02Z","git_url":"git://github.com/brave/brave-browser.git","ssh_url":"git@github.com:brave/brave-browser.git","clone_url":"https://github.com/brave/brave-browser.git","svn_url":"https://github.com/brave/brave-browser","homepage":"https://www.brave.com","size":731,"stargazers_count":495,"watchers_count":495,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":645,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":645,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-browser/pulls/1707"},"html":{"href":"https://github.com/brave/brave-browser/pull/1707"},"issue":{"href":"https://api.github.com/repos/brave/brave-browser/issues/1707"},"comments":{"href":"https://api.github.com/repos/brave/brave-browser/issues/1707/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-browser/pulls/1707/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-browser/pulls/1707/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-browser/statuses/f918860c745c5c77747bcd3783985c98e30e6670"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":45,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"diracdeltas"}}