{"action":"created","issue":{"url":"https://api.github.com/repos/docker/cli/issues/1252","repository_url":"https://api.github.com/repos/docker/cli","labels_url":"https://api.github.com/repos/docker/cli/issues/1252/labels{/name}","comments_url":"https://api.github.com/repos/docker/cli/issues/1252/comments","events_url":"https://api.github.com/repos/docker/cli/issues/1252/events","html_url":"https://github.com/docker/cli/pull/1252","id":346474183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzI3OTI2","number":1252,"title":"[WIP] Add bash completion for experimental CLI commands (manifest)","user":{"login":"albers","id":2901725,"node_id":"MDQ6VXNlcjI5MDE3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2901725?v=4","gravatar_id":"","url":"https://api.github.com/users/albers","html_url":"https://github.com/albers","followers_url":"https://api.github.com/users/albers/followers","following_url":"https://api.github.com/users/albers/following{/other_user}","gists_url":"https://api.github.com/users/albers/gists{/gist_id}","starred_url":"https://api.github.com/users/albers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albers/subscriptions","organizations_url":"https://api.github.com/users/albers/orgs","repos_url":"https://api.github.com/users/albers/repos","events_url":"https://api.github.com/users/albers/events{/privacy}","received_events_url":"https://api.github.com/users/albers/received_events","type":"User","site_admin":false},"labels":[{"id":1013603055,"node_id":"MDU6TGFiZWwxMDEzNjAzMDU1","url":"https://api.github.com/repos/docker/cli/labels/area/completion","name":"area/completion","color":"fef2c0","default":false},{"id":585916071,"node_id":"MDU6TGFiZWw1ODU5MTYwNzE=","url":"https://api.github.com/repos/docker/cli/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-01T07:07:35Z","updated_at":"2018-08-07T14:55:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/1252","html_url":"https://github.com/docker/cli/pull/1252","diff_url":"https://github.com/docker/cli/pull/1252.diff","patch_url":"https://github.com/docker/cli/pull/1252.patch"},"body":"This adds bash completion for `docker manifest` and its subcommands.\r\n\r\nCompletion for the `manifest` command is only activated if experimental CLI features are enabled (either by setting `\"experimental\": \"enabled\"` in _.docker/config.json_ or the env var `DOCKER_CLI_EXPERIMENTAL=enabled`). This configuration setting is harvested from the output of `docker version`.\r\n\r\nBefore adding the third configuration setting that is extracted from `docker version`'s output , I refactored the existing logic to a more consistent and clearer state. There is only one call to `docker version`. It is executed lazily and caches its result.\r\n\r\n*Note: The initial concept also included gathering the orchestrator in this step, but this piece of information went bananas in #1137.*\r\n\r\nIn the context of `docker version` and its output, I changed the domain language to use _server_ instead of _daemon_ because this is the term used there (bounded context). _daemon_ is better suited for local calls whereas _server_ is more appropriate for (potentially) remote calls."},"comment":{"url":"https://api.github.com/repos/docker/cli/issues/comments/411086124","html_url":"https://github.com/docker/cli/pull/1252#issuecomment-411086124","issue_url":"https://api.github.com/repos/docker/cli/issues/1252","id":411086124,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTA4NjEyNA==","user":{"login":"clnperez","id":4493281,"node_id":"MDQ6VXNlcjQ0OTMyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4493281?v=4","gravatar_id":"","url":"https://api.github.com/users/clnperez","html_url":"https://github.com/clnperez","followers_url":"https://api.github.com/users/clnperez/followers","following_url":"https://api.github.com/users/clnperez/following{/other_user}","gists_url":"https://api.github.com/users/clnperez/gists{/gist_id}","starred_url":"https://api.github.com/users/clnperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clnperez/subscriptions","organizations_url":"https://api.github.com/users/clnperez/orgs","repos_url":"https://api.github.com/users/clnperez/repos","events_url":"https://api.github.com/users/clnperez/events{/privacy}","received_events_url":"https://api.github.com/users/clnperez/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T14:55:59Z","updated_at":"2018-08-07T14:55:59Z","author_association":"CONTRIBUTOR","body":"There are some examples in the doc: https://docs.docker.com/engine/reference/commandline/manifest/#working-with-insecure-registries\r\n\r\nYour issue is that `alpine:3.6`, `alpine:3.7` and `alpine:3.8` are all already manifest lists, and you can't make a recursive manifest list. "}}
{"actor":{"display_login":"clnperez"}}