{"action":"created","issue":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/1013","repository_url":"https://api.github.com/repos/jbalsas/liferay-portal","labels_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/1013/labels{/name}","comments_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/1013/comments","events_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/1013/events","html_url":"https://github.com/jbalsas/liferay-portal/pull/1013","id":297429463,"number":1013,"title":"LPS-78047 Empty id attributes created in the DOM by taglib aui:icon","user":{"login":"ricardocousolr","id":22747905,"avatar_url":"https://avatars1.githubusercontent.com/u/22747905?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardocousolr","html_url":"https://github.com/ricardocousolr","followers_url":"https://api.github.com/users/ricardocousolr/followers","following_url":"https://api.github.com/users/ricardocousolr/following{/other_user}","gists_url":"https://api.github.com/users/ricardocousolr/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardocousolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardocousolr/subscriptions","organizations_url":"https://api.github.com/users/ricardocousolr/orgs","repos_url":"https://api.github.com/users/ricardocousolr/repos","events_url":"https://api.github.com/users/ricardocousolr/events{/privacy}","received_events_url":"https://api.github.com/users/ricardocousolr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-15T12:31:45Z","updated_at":"2018-02-15T12:33:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/1013","html_url":"https://github.com/jbalsas/liferay-portal/pull/1013","diff_url":"https://github.com/jbalsas/liferay-portal/pull/1013.diff","patch_url":"https://github.com/jbalsas/liferay-portal/pull/1013.patch"},"body":"Hi, @jbalsas. This fix is for a customer. I've taken the approach of not adding attributes whose value is the empty string. This is not strictly necessary for class but it is for id (see the LPS description). The other approach would be to generate a value for id if empty, but I'm not sure if that's preferable. Tell me if you have any questions. Thanks!"},"comment":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/comments/365914046","html_url":"https://github.com/jbalsas/liferay-portal/pull/1013#issuecomment-365914046","issue_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/1013","id":365914046,"user":{"login":"ricardocousolr","id":22747905,"avatar_url":"https://avatars1.githubusercontent.com/u/22747905?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardocousolr","html_url":"https://github.com/ricardocousolr","followers_url":"https://api.github.com/users/ricardocousolr/followers","following_url":"https://api.github.com/users/ricardocousolr/following{/other_user}","gists_url":"https://api.github.com/users/ricardocousolr/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardocousolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardocousolr/subscriptions","organizations_url":"https://api.github.com/users/ricardocousolr/orgs","repos_url":"https://api.github.com/users/ricardocousolr/repos","events_url":"https://api.github.com/users/ricardocousolr/events{/privacy}","received_events_url":"https://api.github.com/users/ricardocousolr/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T12:33:08Z","updated_at":"2018-02-15T12:33:08Z","author_association":"NONE","body":"ci:test"}}
{"actor":{"display_login":"ricardocousolr"}}