{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/escoria/issues/144","repository_url":"https://api.github.com/repos/godotengine/escoria","labels_url":"https://api.github.com/repos/godotengine/escoria/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/escoria/issues/144/comments","events_url":"https://api.github.com/repos/godotengine/escoria/issues/144/events","html_url":"https://github.com/godotengine/escoria/issues/144","id":319290307,"number":144,"title":"Make camera_set_target block execution of events","user":{"login":"fleskesvor","id":672876,"avatar_url":"https://avatars3.githubusercontent.com/u/672876?v=4","gravatar_id":"","url":"https://api.github.com/users/fleskesvor","html_url":"https://github.com/fleskesvor","followers_url":"https://api.github.com/users/fleskesvor/followers","following_url":"https://api.github.com/users/fleskesvor/following{/other_user}","gists_url":"https://api.github.com/users/fleskesvor/gists{/gist_id}","starred_url":"https://api.github.com/users/fleskesvor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fleskesvor/subscriptions","organizations_url":"https://api.github.com/users/fleskesvor/orgs","repos_url":"https://api.github.com/users/fleskesvor/repos","events_url":"https://api.github.com/users/fleskesvor/events{/privacy}","received_events_url":"https://api.github.com/users/fleskesvor/received_events","type":"User","site_admin":false},"labels":[{"id":422502553,"url":"https://api.github.com/repos/godotengine/escoria/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/godotengine/escoria/milestones/1","html_url":"https://github.com/godotengine/escoria/milestone/1","labels_url":"https://api.github.com/repos/godotengine/escoria/milestones/1/labels","id":3308211,"number":1,"title":"Adventure Jam 2018","description":"","creator":{"login":"fleskesvor","id":672876,"avatar_url":"https://avatars3.githubusercontent.com/u/672876?v=4","gravatar_id":"","url":"https://api.github.com/users/fleskesvor","html_url":"https://github.com/fleskesvor","followers_url":"https://api.github.com/users/fleskesvor/followers","following_url":"https://api.github.com/users/fleskesvor/following{/other_user}","gists_url":"https://api.github.com/users/fleskesvor/gists{/gist_id}","starred_url":"https://api.github.com/users/fleskesvor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fleskesvor/subscriptions","organizations_url":"https://api.github.com/users/fleskesvor/orgs","repos_url":"https://api.github.com/users/fleskesvor/repos","events_url":"https://api.github.com/users/fleskesvor/events{/privacy}","received_events_url":"https://api.github.com/users/fleskesvor/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2018-04-30T09:52:35Z","updated_at":"2018-05-02T22:22:14Z","due_on":"2018-05-04T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-05-01T18:55:27Z","updated_at":"2018-05-03T08:43:35Z","closed_at":null,"author_association":"COLLABORATOR","body":"As discussed in #111, using `camera_set_target` does not block execution of events, unlike `say`, `change_scene` and several other esc functions. This results in surprises with multiple consecutive calls to `camera_set_target`, since each new call will interfere with the previous. The issue can be mitigated somewhat with `wait`, but since `camera_set_target` does not block, `wait` will be executed immediately, so to achieve the desired result with camera movement, one must make sure that the wait time is longer than the time it will take the camera to reach its destination before the next call."},"comment":{"url":"https://api.github.com/repos/godotengine/escoria/issues/comments/386228134","html_url":"https://github.com/godotengine/escoria/issues/144#issuecomment-386228134","issue_url":"https://api.github.com/repos/godotengine/escoria/issues/144","id":386228134,"user":{"login":"mjtorn","id":78427,"avatar_url":"https://avatars2.githubusercontent.com/u/78427?v=4","gravatar_id":"","url":"https://api.github.com/users/mjtorn","html_url":"https://github.com/mjtorn","followers_url":"https://api.github.com/users/mjtorn/followers","following_url":"https://api.github.com/users/mjtorn/following{/other_user}","gists_url":"https://api.github.com/users/mjtorn/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtorn/subscriptions","organizations_url":"https://api.github.com/users/mjtorn/orgs","repos_url":"https://api.github.com/users/mjtorn/repos","events_url":"https://api.github.com/users/mjtorn/events{/privacy}","received_events_url":"https://api.github.com/users/mjtorn/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T08:43:35Z","updated_at":"2018-05-03T08:43:35Z","author_association":"CONTRIBUTOR","body":"Not sure I see where the \"how many seconds\" output would be printed. I did think that a measuring tool would be useful, or something else that calculates a distance between two nodes or points, but that'd have to be integrated into the UI and relates to making Escoria an asset and is generally overkill.\r\n\r\n`walk` has a counterpart `walk_block`, so I think `camera_set_target_block` would be a good idea despite its verbosity. And we could stick to a speed measured in px/s for now to not break anything.\r\n\r\nThe hard part is that the camera update would have to be tied into the state of the vm, so that execution of the ESC stack is blocked for anything except `camera_set_target_block`."}}
{"actor":{"display_login":"mjtorn"}}