{"action":"closed","number":805,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805","id":189369941,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MzY5OTQx","html_url":"https://github.com/emberjs/ember-inspector/pull/805","diff_url":"https://github.com/emberjs/ember-inspector/pull/805.diff","patch_url":"https://github.com/emberjs/ember-inspector/pull/805.patch","issue_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/805","number":805,"state":"closed","locked":false,"title":"Don't render excluded columns in tables.","user":{"login":"Bestra","id":2043348,"node_id":"MDQ6VXNlcjIwNDMzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2043348?v=4","gravatar_id":"","url":"https://api.github.com/users/Bestra","html_url":"https://github.com/Bestra","followers_url":"https://api.github.com/users/Bestra/followers","following_url":"https://api.github.com/users/Bestra/following{/other_user}","gists_url":"https://api.github.com/users/Bestra/gists{/gist_id}","starred_url":"https://api.github.com/users/Bestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bestra/subscriptions","organizations_url":"https://api.github.com/users/Bestra/orgs","repos_url":"https://api.github.com/users/Bestra/repos","events_url":"https://api.github.com/users/Bestra/events{/privacy}","received_events_url":"https://api.github.com/users/Bestra/received_events","type":"User","site_admin":false},"body":"Fixes #803 \r\n\r\nThis PR attempts to fix issues we've been having with displaying the correct content in tables after users have filtered out some columns.\r\nThis PR threads the column schema down through the `x-list` into the `x-list-cell` component.  Consumers can then pass a `column` property to the `x-list-cell` that corresponds to one of the column ids defined in the schema.  Now when the columns change (when a user filters them out via the context menu) we don't render the `td` elements at all. \r\n\r\nThis PR also fixes a problem on the data tab where the filters wouldn't work correctly after a user had selected a different model to view.  See f4f2283 for more details.\r\n\r\n\r\n","created_at":"2018-05-21T12:49:09Z","updated_at":"2018-05-31T15:24:19Z","closed_at":"2018-05-31T15:24:19Z","merged_at":null,"merge_commit_sha":"ea4fa4ff5da702b3b3da2906a593f3daaf1e8aca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/805/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/5a48d9d86c89ce0c72de68e6203c05195cccec6d","head":{"label":"Bestra:fix-column-filtering","ref":"fix-column-filtering","sha":"5a48d9d86c89ce0c72de68e6203c05195cccec6d","user":{"login":"Bestra","id":2043348,"node_id":"MDQ6VXNlcjIwNDMzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2043348?v=4","gravatar_id":"","url":"https://api.github.com/users/Bestra","html_url":"https://github.com/Bestra","followers_url":"https://api.github.com/users/Bestra/followers","following_url":"https://api.github.com/users/Bestra/following{/other_user}","gists_url":"https://api.github.com/users/Bestra/gists{/gist_id}","starred_url":"https://api.github.com/users/Bestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bestra/subscriptions","organizations_url":"https://api.github.com/users/Bestra/orgs","repos_url":"https://api.github.com/users/Bestra/repos","events_url":"https://api.github.com/users/Bestra/events{/privacy}","received_events_url":"https://api.github.com/users/Bestra/received_events","type":"User","site_admin":false},"repo":{"id":126522121,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY1MjIxMjE=","name":"ember-inspector","full_name":"Bestra/ember-inspector","owner":{"login":"Bestra","id":2043348,"node_id":"MDQ6VXNlcjIwNDMzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2043348?v=4","gravatar_id":"","url":"https://api.github.com/users/Bestra","html_url":"https://github.com/Bestra","followers_url":"https://api.github.com/users/Bestra/followers","following_url":"https://api.github.com/users/Bestra/following{/other_user}","gists_url":"https://api.github.com/users/Bestra/gists{/gist_id}","starred_url":"https://api.github.com/users/Bestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bestra/subscriptions","organizations_url":"https://api.github.com/users/Bestra/orgs","repos_url":"https://api.github.com/users/Bestra/repos","events_url":"https://api.github.com/users/Bestra/events{/privacy}","received_events_url":"https://api.github.com/users/Bestra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bestra/ember-inspector","description":null,"fork":true,"url":"https://api.github.com/repos/Bestra/ember-inspector","forks_url":"https://api.github.com/repos/Bestra/ember-inspector/forks","keys_url":"https://api.github.com/repos/Bestra/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bestra/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bestra/ember-inspector/teams","hooks_url":"https://api.github.com/repos/Bestra/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/Bestra/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/Bestra/ember-inspector/events","assignees_url":"https://api.github.com/repos/Bestra/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/Bestra/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/Bestra/ember-inspector/tags","blobs_url":"https://api.github.com/repos/Bestra/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bestra/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bestra/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bestra/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bestra/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/Bestra/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/Bestra/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/Bestra/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/Bestra/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/Bestra/ember-inspector/subscription","commits_url":"https://api.github.com/repos/Bestra/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bestra/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bestra/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bestra/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bestra/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/Bestra/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bestra/ember-inspector/merges","archive_url":"https://api.github.com/repos/Bestra/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bestra/ember-inspector/downloads","issues_url":"https://api.github.com/repos/Bestra/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/Bestra/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/Bestra/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/Bestra/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bestra/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/Bestra/ember-inspector/releases{/id}","deployments_url":"https://api.github.com/repos/Bestra/ember-inspector/deployments","created_at":"2018-03-23T18:04:14Z","updated_at":"2018-03-23T18:04:16Z","pushed_at":"2018-05-21T16:09:40Z","git_url":"git://github.com/Bestra/ember-inspector.git","ssh_url":"git@github.com:Bestra/ember-inspector.git","clone_url":"https://github.com/Bestra/ember-inspector.git","svn_url":"https://github.com/Bestra/ember-inspector","homepage":null,"size":4471,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"ad8b18ae8aeecfb6645627943932f41150b2cecb","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7876204,"node_id":"MDEwOlJlcG9zaXRvcnk3ODc2MjA0","name":"ember-inspector","full_name":"emberjs/ember-inspector","owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-inspector","description":null,"fork":false,"url":"https://api.github.com/repos/emberjs/ember-inspector","forks_url":"https://api.github.com/repos/emberjs/ember-inspector/forks","keys_url":"https://api.github.com/repos/emberjs/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-inspector/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-inspector/events","assignees_url":"https://api.github.com/repos/emberjs/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-inspector/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-inspector/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-inspector/merges","archive_url":"https://api.github.com/repos/emberjs/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-inspector/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-inspector/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember-inspector/deployments","created_at":"2013-01-28T18:36:15Z","updated_at":"2018-05-31T13:45:17Z","pushed_at":"2018-05-31T15:24:18Z","git_url":"git://github.com/emberjs/ember-inspector.git","ssh_url":"git@github.com:emberjs/ember-inspector.git","clone_url":"https://github.com/emberjs/ember-inspector.git","svn_url":"https://github.com/emberjs/ember-inspector","homepage":null,"size":4450,"stargazers_count":861,"watchers_count":861,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":219,"open_issues":67,"watchers":861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/805"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/805"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/805/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/805/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-inspector/statuses/5a48d9d86c89ce0c72de68e6203c05195cccec6d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":142,"deletions":68,"changed_files":10}}
{"actor":{"display_login":"rwwagner90"}}