{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/177062693","pull_request_review_id":106869300,"id":177062693,"diff_hunk":"@@ -50,6 +51,18 @@ def summary_header\n \n     private\n \n+    def check_untrusted_pkg\n+      odebug \"Auditing pkg stanza: allow_untrusted\"\n+\n+      return if @cask.sourcefile_path.nil?\n+\n+      tap = Tap.select { |t| t.cask_file?(@cask.sourcefile_path) }.first\n+      return if tap.nil? || tap.user != \"caskroom\"","path":"Library/Homebrew/cask/lib/hbc/audit.rb","position":18,"original_position":18,"commit_id":"47693a45f939654511c869cddf28476bf5027a63","original_commit_id":"47693a45f939654511c869cddf28476bf5027a63","user":{"login":"commitay","id":26216252,"avatar_url":"https://avatars3.githubusercontent.com/u/26216252?v=4","gravatar_id":"","url":"https://api.github.com/users/commitay","html_url":"https://github.com/commitay","followers_url":"https://api.github.com/users/commitay/followers","following_url":"https://api.github.com/users/commitay/following{/other_user}","gists_url":"https://api.github.com/users/commitay/gists{/gist_id}","starred_url":"https://api.github.com/users/commitay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commitay/subscriptions","organizations_url":"https://api.github.com/users/commitay/orgs","repos_url":"https://api.github.com/users/commitay/repos","events_url":"https://api.github.com/users/commitay/events{/privacy}","received_events_url":"https://api.github.com/users/commitay/received_events","type":"User","site_admin":false},"body":"`@cask.tap` works, should I change both?","created_at":"2018-03-26T11:51:35Z","updated_at":"2018-03-26T11:51:35Z","html_url":"https://github.com/Homebrew/brew/pull/3974#discussion_r177062693","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/3974","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/177062693"},"html":{"href":"https://github.com/Homebrew/brew/pull/3974#discussion_r177062693"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3974"}},"in_reply_to_id":176989080},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/3974","id":177275036,"html_url":"https://github.com/Homebrew/brew/pull/3974","diff_url":"https://github.com/Homebrew/brew/pull/3974.diff","patch_url":"https://github.com/Homebrew/brew/pull/3974.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/3974","number":3974,"state":"open","locked":false,"title":"cask audit: check for allow_untrusted within caskroom taps","user":{"login":"commitay","id":26216252,"avatar_url":"https://avatars3.githubusercontent.com/u/26216252?v=4","gravatar_id":"","url":"https://api.github.com/users/commitay","html_url":"https://github.com/commitay","followers_url":"https://api.github.com/users/commitay/followers","following_url":"https://api.github.com/users/commitay/following{/other_user}","gists_url":"https://api.github.com/users/commitay/gists{/gist_id}","starred_url":"https://api.github.com/users/commitay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commitay/subscriptions","organizations_url":"https://api.github.com/users/commitay/orgs","repos_url":"https://api.github.com/users/commitay/repos","events_url":"https://api.github.com/users/commitay/events{/privacy}","received_events_url":"https://api.github.com/users/commitay/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\ncc @vitorgalvao @reitermarkus ","created_at":"2018-03-25T06:22:34Z","updated_at":"2018-03-26T11:51:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e09b8a5b9a8e283c77aa182a02fa755136c5026a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":459085783,"url":"https://api.github.com/repos/Homebrew/brew/labels/cask","name":"cask","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/3974/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/3974/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/3974/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/47693a45f939654511c869cddf28476bf5027a63","head":{"label":"commitay:cask-audit-pkg","ref":"cask-audit-pkg","sha":"47693a45f939654511c869cddf28476bf5027a63","user":{"login":"commitay","id":26216252,"avatar_url":"https://avatars3.githubusercontent.com/u/26216252?v=4","gravatar_id":"","url":"https://api.github.com/users/commitay","html_url":"https://github.com/commitay","followers_url":"https://api.github.com/users/commitay/followers","following_url":"https://api.github.com/users/commitay/following{/other_user}","gists_url":"https://api.github.com/users/commitay/gists{/gist_id}","starred_url":"https://api.github.com/users/commitay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commitay/subscriptions","organizations_url":"https://api.github.com/users/commitay/orgs","repos_url":"https://api.github.com/users/commitay/repos","events_url":"https://api.github.com/users/commitay/events{/privacy}","received_events_url":"https://api.github.com/users/commitay/received_events","type":"User","site_admin":false},"repo":{"id":96015046,"name":"brew","full_name":"commitay/brew","owner":{"login":"commitay","id":26216252,"avatar_url":"https://avatars3.githubusercontent.com/u/26216252?v=4","gravatar_id":"","url":"https://api.github.com/users/commitay","html_url":"https://github.com/commitay","followers_url":"https://api.github.com/users/commitay/followers","following_url":"https://api.github.com/users/commitay/following{/other_user}","gists_url":"https://api.github.com/users/commitay/gists{/gist_id}","starred_url":"https://api.github.com/users/commitay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commitay/subscriptions","organizations_url":"https://api.github.com/users/commitay/orgs","repos_url":"https://api.github.com/users/commitay/repos","events_url":"https://api.github.com/users/commitay/events{/privacy}","received_events_url":"https://api.github.com/users/commitay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/commitay/brew","description":"🍺 The missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/commitay/brew","forks_url":"https://api.github.com/repos/commitay/brew/forks","keys_url":"https://api.github.com/repos/commitay/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commitay/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commitay/brew/teams","hooks_url":"https://api.github.com/repos/commitay/brew/hooks","issue_events_url":"https://api.github.com/repos/commitay/brew/issues/events{/number}","events_url":"https://api.github.com/repos/commitay/brew/events","assignees_url":"https://api.github.com/repos/commitay/brew/assignees{/user}","branches_url":"https://api.github.com/repos/commitay/brew/branches{/branch}","tags_url":"https://api.github.com/repos/commitay/brew/tags","blobs_url":"https://api.github.com/repos/commitay/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commitay/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commitay/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/commitay/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commitay/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/commitay/brew/languages","stargazers_url":"https://api.github.com/repos/commitay/brew/stargazers","contributors_url":"https://api.github.com/repos/commitay/brew/contributors","subscribers_url":"https://api.github.com/repos/commitay/brew/subscribers","subscription_url":"https://api.github.com/repos/commitay/brew/subscription","commits_url":"https://api.github.com/repos/commitay/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/commitay/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/commitay/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/commitay/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/commitay/brew/contents/{+path}","compare_url":"https://api.github.com/repos/commitay/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commitay/brew/merges","archive_url":"https://api.github.com/repos/commitay/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commitay/brew/downloads","issues_url":"https://api.github.com/repos/commitay/brew/issues{/number}","pulls_url":"https://api.github.com/repos/commitay/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/commitay/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/commitay/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commitay/brew/labels{/name}","releases_url":"https://api.github.com/repos/commitay/brew/releases{/id}","deployments_url":"https://api.github.com/repos/commitay/brew/deployments","created_at":"2017-07-02T10:00:02Z","updated_at":"2018-03-25T21:40:24Z","pushed_at":"2018-03-26T11:32:43Z","git_url":"git://github.com/commitay/brew.git","ssh_url":"git@github.com:commitay/brew.git","clone_url":"https://github.com/commitay/brew.git","svn_url":"https://github.com/commitay/brew","homepage":"https://brew.sh","size":23168,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"63da230425f4517103aec950109f11ee353ba7c6","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":"🍺 The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2018-03-26T11:17:29Z","pushed_at":"2018-03-26T11:50:24Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"https://brew.sh","size":23173,"stargazers_count":11583,"watchers_count":11583,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2739,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":2739,"open_issues":31,"watchers":11583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3974"},"html":{"href":"https://github.com/Homebrew/brew/pull/3974"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3974"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3974/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3974/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3974/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/47693a45f939654511c869cddf28476bf5027a63"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"commitay"}}