{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/232085405","pull_request_review_id":173203717,"id":232085405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA4NTQwNQ==","diff_hunk":"@@ -15,27 +15,31 @@\n  */\n \n #import \"FAuthTokenProvider.h\"\n-#import \"FUtilities.h\"\n+\n+#import <FirebaseAuthInterop/FIRAuthInterop.h>\n #import <FirebaseCore/FIRAppInternal.h>\n+#import <FirebaseCore/FIRComponent.h>","path":"Firebase/Database/Login/FAuthTokenProvider.m","position":8,"original_position":8,"commit_id":"a618063a6247c40a9b3d70b5125fcd4ecf33253a","original_commit_id":"a618063a6247c40a9b3d70b5125fcd4ecf33253a","user":{"login":"bstpierr","id":464763,"node_id":"MDQ6VXNlcjQ2NDc2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/464763?v=4","gravatar_id":"","url":"https://api.github.com/users/bstpierr","html_url":"https://github.com/bstpierr","followers_url":"https://api.github.com/users/bstpierr/followers","following_url":"https://api.github.com/users/bstpierr/following{/other_user}","gists_url":"https://api.github.com/users/bstpierr/gists{/gist_id}","starred_url":"https://api.github.com/users/bstpierr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstpierr/subscriptions","organizations_url":"https://api.github.com/users/bstpierr/orgs","repos_url":"https://api.github.com/users/bstpierr/repos","events_url":"https://api.github.com/users/bstpierr/events{/privacy}","received_events_url":"https://api.github.com/users/bstpierr/received_events","type":"User","site_admin":false},"body":"Actually, the AppInternal is needed for the ","created_at":"2018-11-08T22:32:28Z","updated_at":"2018-11-08T22:32:28Z","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/1865#discussion_r232085405","pull_request_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/232085405"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/1865#discussion_r232085405"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865"}},"in_reply_to_id":232036464},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865","id":217541177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTQxMTc3","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/1865","diff_url":"https://github.com/firebase/firebase-ios-sdk/pull/1865.diff","patch_url":"https://github.com/firebase/firebase-ios-sdk/pull/1865.patch","issue_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1865","number":1865,"state":"open","locked":false,"title":"Database Interop","user":{"login":"bstpierr","id":464763,"node_id":"MDQ6VXNlcjQ2NDc2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/464763?v=4","gravatar_id":"","url":"https://api.github.com/users/bstpierr","html_url":"https://github.com/bstpierr","followers_url":"https://api.github.com/users/bstpierr/followers","following_url":"https://api.github.com/users/bstpierr/following{/other_user}","gists_url":"https://api.github.com/users/bstpierr/gists{/gist_id}","starred_url":"https://api.github.com/users/bstpierr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstpierr/subscriptions","organizations_url":"https://api.github.com/users/bstpierr/orgs","repos_url":"https://api.github.com/users/bstpierr/repos","events_url":"https://api.github.com/users/bstpierr/events{/privacy}","received_events_url":"https://api.github.com/users/bstpierr/received_events","type":"User","site_admin":false},"body":"Note that many Database integration tests appear to be failing on the master branch as well as in my branch at the moment. I'm not sure if this is expected, of if I need a valid Google-Info.plist file to make the tests work beyond local fakes.\r\n\r\nRegister Database with Interop:\r\n\r\n  + Add AuthInterop dependency\r\n  + Have Database register with Interop component container\r\n  + Add weak dependency on Auth\r\n  + Cleaned up imports\r\n\r\nUse Interop for Auth token fetching:\r\n\r\n  + Use macro to get auth component\r\n  + Change `getTokenForcingRefresh:withCallback:` call to use Interop component version of Auth\r\n  + Clean up imports\r\n\r\nImplement necessary protocols:\r\n\r\n  + Added FIRComponentRegistrant and FIRDatabaseNilProtocol to FIRDatabase\r\n\r\nClean up Database tests:\r\n\r\n  + Removed all unnecessary header files\r\n  + Ran style.sh across all the tests\r\n\r\nCleaned Up project file:\r\n\r\n  Some header removals were missed in the last commit.\r\n\r\nSorted some test files\r\n\r\nFix Database Fake App Tests:\r\n\r\n  + Added container property\r\n  + Added an Auth fake in the container\r\n  + Added the Shared utils files to the necessary targets\r\n  + Added a missing XCTest reference in a test that didn't compile for me","created_at":"2018-09-24T00:45:28Z","updated_at":"2018-11-08T22:32:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c831a3423e9862a1ca4c52f1943c63aa4fb88fc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":658858759,"node_id":"MDU6TGFiZWw2NTg4NTg3NTk=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1865/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/a618063a6247c40a9b3d70b5125fcd4ecf33253a","head":{"label":"firebase:bs-databaseinterop","ref":"bs-databaseinterop","sha":"a618063a6247c40a9b3d70b5125fcd4ecf33253a","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-11-08T17:50:31Z","pushed_at":"2018-11-08T20:42:04Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":15438,"stargazers_count":920,"watchers_count":920,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":195,"open_issues":97,"watchers":920,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"f098fb29e68a826cd6d0acad7e7fd8b3b2b2ea3f","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-11-08T17:50:31Z","pushed_at":"2018-11-08T20:42:04Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":15438,"stargazers_count":920,"watchers_count":920,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":195,"open_issues":97,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/1865"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1865"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1865/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1865/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/a618063a6247c40a9b3d70b5125fcd4ecf33253a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bstpierr"}}