{"action":"created","comment":{"url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/comments/201758750","pull_request_review_id":136322114,"id":201758750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc1ODc1MA==","diff_hunk":"@@ -0,0 +1,63 @@\n+//\n+//  GATTScanIntervalWindow.swift\n+//  Bluetooth\n+//\n+//  Created by Carlos Duclos on 7/11/18.\n+//  Copyright © 2018 PureSwift. All rights reserved.\n+//\n+\n+import Foundation\n+\n+/**\n+ Scan Interval Window\n+ \n+ The Scan Interval Window characteristic is used to store the scan parameters of the GATT Client. Included in this characteristic are the Scan Interval and Scan Window of the GATT Client device.\n+ \n+ The Scan Interval Window characteristic is used to store the scan parameters of the GATT Client. The GATT Server can use these values to optimize its own advertisement rate and to minimize the rate of its own advertisements while also minimizing the latency of reconnections.\n+ \n+ - SeeAlso: [Scan Interval Window](https://www.bluetooth.com/specifications/gatt/viewer?attributeXmlFile=org.bluetooth.characteristic.scan_interval_window.xml)\n+ */\n+public struct GATTScanIntervalWindow: GATTCharacteristic {\n+    \n+    internal static let length = MemoryLayout<UInt16>.size * 2\n+    \n+    public static var uuid: BluetoothUUID { return .scanIntervalWindow }\n+    \n+    public var scanInterval: UInt16","path":"Sources/GATTScanIntervalWindow.swift","position":26,"original_position":26,"commit_id":"cf92ef9e141f2a58ac8cbf6f3134117c9c3d5f79","original_commit_id":"cf92ef9e141f2a58ac8cbf6f3134117c9c3d5f79","user":{"login":"colemancda","id":3419766,"node_id":"MDQ6VXNlcjM0MTk3NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3419766?v=4","gravatar_id":"","url":"https://api.github.com/users/colemancda","html_url":"https://github.com/colemancda","followers_url":"https://api.github.com/users/colemancda/followers","following_url":"https://api.github.com/users/colemancda/following{/other_user}","gists_url":"https://api.github.com/users/colemancda/gists{/gist_id}","starred_url":"https://api.github.com/users/colemancda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemancda/subscriptions","organizations_url":"https://api.github.com/users/colemancda/orgs","repos_url":"https://api.github.com/users/colemancda/repos","events_url":"https://api.github.com/users/colemancda/events{/privacy}","received_events_url":"https://api.github.com/users/colemancda/received_events","type":"User","site_admin":false},"body":"What does this represent? We need another struct to represent this value and convert it to milliseconds or seconds.","created_at":"2018-07-11T16:27:36Z","updated_at":"2018-07-11T16:30:11Z","html_url":"https://github.com/PureSwift/Bluetooth/pull/96#discussion_r201758750","pull_request_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/comments/201758750"},"html":{"href":"https://github.com/PureSwift/Bluetooth/pull/96#discussion_r201758750"},"pull_request":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96","id":200757133,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzU3MTMz","html_url":"https://github.com/PureSwift/Bluetooth/pull/96","diff_url":"https://github.com/PureSwift/Bluetooth/pull/96.diff","patch_url":"https://github.com/PureSwift/Bluetooth/pull/96.patch","issue_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/96","number":96,"state":"open","locked":false,"title":"Added GATT Scan Characteristics","user":{"login":"carlos21","id":1591321,"node_id":"MDQ6VXNlcjE1OTEzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1591321?v=4","gravatar_id":"","url":"https://api.github.com/users/carlos21","html_url":"https://github.com/carlos21","followers_url":"https://api.github.com/users/carlos21/followers","following_url":"https://api.github.com/users/carlos21/following{/other_user}","gists_url":"https://api.github.com/users/carlos21/gists{/gist_id}","starred_url":"https://api.github.com/users/carlos21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlos21/subscriptions","organizations_url":"https://api.github.com/users/carlos21/orgs","repos_url":"https://api.github.com/users/carlos21/repos","events_url":"https://api.github.com/users/carlos21/events{/privacy}","received_events_url":"https://api.github.com/users/carlos21/received_events","type":"User","site_admin":false},"body":"**Issue**\r\n\r\n#58.\r\n\r\n**What does this PR Do?**\r\n\r\nAdded GATT Scan Characteristics.\r\n\r\n**Where should the reviewer start?**\r\n\r\nGATTScanRefresh.swift, GATTScanIntervalWindow.swift","created_at":"2018-07-11T16:24:44Z","updated_at":"2018-07-11T16:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa186c0426a612825832b1774705b7883f0f4b5a","assignee":{"login":"carlos21","id":1591321,"node_id":"MDQ6VXNlcjE1OTEzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1591321?v=4","gravatar_id":"","url":"https://api.github.com/users/carlos21","html_url":"https://github.com/carlos21","followers_url":"https://api.github.com/users/carlos21/followers","following_url":"https://api.github.com/users/carlos21/following{/other_user}","gists_url":"https://api.github.com/users/carlos21/gists{/gist_id}","starred_url":"https://api.github.com/users/carlos21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlos21/subscriptions","organizations_url":"https://api.github.com/users/carlos21/orgs","repos_url":"https://api.github.com/users/carlos21/repos","events_url":"https://api.github.com/users/carlos21/events{/privacy}","received_events_url":"https://api.github.com/users/carlos21/received_events","type":"User","site_admin":false},"assignees":[{"login":"carlos21","id":1591321,"node_id":"MDQ6VXNlcjE1OTEzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1591321?v=4","gravatar_id":"","url":"https://api.github.com/users/carlos21","html_url":"https://github.com/carlos21","followers_url":"https://api.github.com/users/carlos21/followers","following_url":"https://api.github.com/users/carlos21/following{/other_user}","gists_url":"https://api.github.com/users/carlos21/gists{/gist_id}","starred_url":"https://api.github.com/users/carlos21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlos21/subscriptions","organizations_url":"https://api.github.com/users/carlos21/orgs","repos_url":"https://api.github.com/users/carlos21/repos","events_url":"https://api.github.com/users/carlos21/events{/privacy}","received_events_url":"https://api.github.com/users/carlos21/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96/commits","review_comments_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96/comments","review_comment_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/96/comments","statuses_url":"https://api.github.com/repos/PureSwift/Bluetooth/statuses/cf92ef9e141f2a58ac8cbf6f3134117c9c3d5f79","head":{"label":"PureSwift:feature/characteristics/add-scan-characteristics","ref":"feature/characteristics/add-scan-characteristics","sha":"cf92ef9e141f2a58ac8cbf6f3134117c9c3d5f79","user":{"login":"PureSwift","id":13123923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTIzOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/13123923?v=4","gravatar_id":"","url":"https://api.github.com/users/PureSwift","html_url":"https://github.com/PureSwift","followers_url":"https://api.github.com/users/PureSwift/followers","following_url":"https://api.github.com/users/PureSwift/following{/other_user}","gists_url":"https://api.github.com/users/PureSwift/gists{/gist_id}","starred_url":"https://api.github.com/users/PureSwift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureSwift/subscriptions","organizations_url":"https://api.github.com/users/PureSwift/orgs","repos_url":"https://api.github.com/users/PureSwift/repos","events_url":"https://api.github.com/users/PureSwift/events{/privacy}","received_events_url":"https://api.github.com/users/PureSwift/received_events","type":"Organization","site_admin":false},"repo":{"id":55272510,"node_id":"MDEwOlJlcG9zaXRvcnk1NTI3MjUxMA==","name":"Bluetooth","full_name":"PureSwift/Bluetooth","owner":{"login":"PureSwift","id":13123923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTIzOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/13123923?v=4","gravatar_id":"","url":"https://api.github.com/users/PureSwift","html_url":"https://github.com/PureSwift","followers_url":"https://api.github.com/users/PureSwift/followers","following_url":"https://api.github.com/users/PureSwift/following{/other_user}","gists_url":"https://api.github.com/users/PureSwift/gists{/gist_id}","starred_url":"https://api.github.com/users/PureSwift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureSwift/subscriptions","organizations_url":"https://api.github.com/users/PureSwift/orgs","repos_url":"https://api.github.com/users/PureSwift/repos","events_url":"https://api.github.com/users/PureSwift/events{/privacy}","received_events_url":"https://api.github.com/users/PureSwift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PureSwift/Bluetooth","description":"Pure Swift Bluetooth Definitions","fork":false,"url":"https://api.github.com/repos/PureSwift/Bluetooth","forks_url":"https://api.github.com/repos/PureSwift/Bluetooth/forks","keys_url":"https://api.github.com/repos/PureSwift/Bluetooth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PureSwift/Bluetooth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PureSwift/Bluetooth/teams","hooks_url":"https://api.github.com/repos/PureSwift/Bluetooth/hooks","issue_events_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/events{/number}","events_url":"https://api.github.com/repos/PureSwift/Bluetooth/events","assignees_url":"https://api.github.com/repos/PureSwift/Bluetooth/assignees{/user}","branches_url":"https://api.github.com/repos/PureSwift/Bluetooth/branches{/branch}","tags_url":"https://api.github.com/repos/PureSwift/Bluetooth/tags","blobs_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/refs{/sha}","trees_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PureSwift/Bluetooth/statuses/{sha}","languages_url":"https://api.github.com/repos/PureSwift/Bluetooth/languages","stargazers_url":"https://api.github.com/repos/PureSwift/Bluetooth/stargazers","contributors_url":"https://api.github.com/repos/PureSwift/Bluetooth/contributors","subscribers_url":"https://api.github.com/repos/PureSwift/Bluetooth/subscribers","subscription_url":"https://api.github.com/repos/PureSwift/Bluetooth/subscription","commits_url":"https://api.github.com/repos/PureSwift/Bluetooth/commits{/sha}","git_commits_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/commits{/sha}","comments_url":"https://api.github.com/repos/PureSwift/Bluetooth/comments{/number}","issue_comment_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/comments{/number}","contents_url":"https://api.github.com/repos/PureSwift/Bluetooth/contents/{+path}","compare_url":"https://api.github.com/repos/PureSwift/Bluetooth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PureSwift/Bluetooth/merges","archive_url":"https://api.github.com/repos/PureSwift/Bluetooth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PureSwift/Bluetooth/downloads","issues_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues{/number}","pulls_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls{/number}","milestones_url":"https://api.github.com/repos/PureSwift/Bluetooth/milestones{/number}","notifications_url":"https://api.github.com/repos/PureSwift/Bluetooth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PureSwift/Bluetooth/labels{/name}","releases_url":"https://api.github.com/repos/PureSwift/Bluetooth/releases{/id}","deployments_url":"https://api.github.com/repos/PureSwift/Bluetooth/deployments","created_at":"2016-04-02T01:45:12Z","updated_at":"2018-07-11T07:25:49Z","pushed_at":"2018-07-11T16:24:45Z","git_url":"git://github.com/PureSwift/Bluetooth.git","ssh_url":"git@github.com:PureSwift/Bluetooth.git","clone_url":"https://github.com/PureSwift/Bluetooth.git","svn_url":"https://github.com/PureSwift/Bluetooth","homepage":"http://pureswift.github.io/Bluetooth/","size":16654,"stargazers_count":17,"watchers_count":17,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":6,"watchers":17,"default_branch":"master"}},"base":{"label":"PureSwift:master","ref":"master","sha":"d7ea377550f4ca64b2c9f3812a04346517657536","user":{"login":"PureSwift","id":13123923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTIzOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/13123923?v=4","gravatar_id":"","url":"https://api.github.com/users/PureSwift","html_url":"https://github.com/PureSwift","followers_url":"https://api.github.com/users/PureSwift/followers","following_url":"https://api.github.com/users/PureSwift/following{/other_user}","gists_url":"https://api.github.com/users/PureSwift/gists{/gist_id}","starred_url":"https://api.github.com/users/PureSwift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureSwift/subscriptions","organizations_url":"https://api.github.com/users/PureSwift/orgs","repos_url":"https://api.github.com/users/PureSwift/repos","events_url":"https://api.github.com/users/PureSwift/events{/privacy}","received_events_url":"https://api.github.com/users/PureSwift/received_events","type":"Organization","site_admin":false},"repo":{"id":55272510,"node_id":"MDEwOlJlcG9zaXRvcnk1NTI3MjUxMA==","name":"Bluetooth","full_name":"PureSwift/Bluetooth","owner":{"login":"PureSwift","id":13123923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTIzOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/13123923?v=4","gravatar_id":"","url":"https://api.github.com/users/PureSwift","html_url":"https://github.com/PureSwift","followers_url":"https://api.github.com/users/PureSwift/followers","following_url":"https://api.github.com/users/PureSwift/following{/other_user}","gists_url":"https://api.github.com/users/PureSwift/gists{/gist_id}","starred_url":"https://api.github.com/users/PureSwift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureSwift/subscriptions","organizations_url":"https://api.github.com/users/PureSwift/orgs","repos_url":"https://api.github.com/users/PureSwift/repos","events_url":"https://api.github.com/users/PureSwift/events{/privacy}","received_events_url":"https://api.github.com/users/PureSwift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PureSwift/Bluetooth","description":"Pure Swift Bluetooth Definitions","fork":false,"url":"https://api.github.com/repos/PureSwift/Bluetooth","forks_url":"https://api.github.com/repos/PureSwift/Bluetooth/forks","keys_url":"https://api.github.com/repos/PureSwift/Bluetooth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PureSwift/Bluetooth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PureSwift/Bluetooth/teams","hooks_url":"https://api.github.com/repos/PureSwift/Bluetooth/hooks","issue_events_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/events{/number}","events_url":"https://api.github.com/repos/PureSwift/Bluetooth/events","assignees_url":"https://api.github.com/repos/PureSwift/Bluetooth/assignees{/user}","branches_url":"https://api.github.com/repos/PureSwift/Bluetooth/branches{/branch}","tags_url":"https://api.github.com/repos/PureSwift/Bluetooth/tags","blobs_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/refs{/sha}","trees_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PureSwift/Bluetooth/statuses/{sha}","languages_url":"https://api.github.com/repos/PureSwift/Bluetooth/languages","stargazers_url":"https://api.github.com/repos/PureSwift/Bluetooth/stargazers","contributors_url":"https://api.github.com/repos/PureSwift/Bluetooth/contributors","subscribers_url":"https://api.github.com/repos/PureSwift/Bluetooth/subscribers","subscription_url":"https://api.github.com/repos/PureSwift/Bluetooth/subscription","commits_url":"https://api.github.com/repos/PureSwift/Bluetooth/commits{/sha}","git_commits_url":"https://api.github.com/repos/PureSwift/Bluetooth/git/commits{/sha}","comments_url":"https://api.github.com/repos/PureSwift/Bluetooth/comments{/number}","issue_comment_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues/comments{/number}","contents_url":"https://api.github.com/repos/PureSwift/Bluetooth/contents/{+path}","compare_url":"https://api.github.com/repos/PureSwift/Bluetooth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PureSwift/Bluetooth/merges","archive_url":"https://api.github.com/repos/PureSwift/Bluetooth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PureSwift/Bluetooth/downloads","issues_url":"https://api.github.com/repos/PureSwift/Bluetooth/issues{/number}","pulls_url":"https://api.github.com/repos/PureSwift/Bluetooth/pulls{/number}","milestones_url":"https://api.github.com/repos/PureSwift/Bluetooth/milestones{/number}","notifications_url":"https://api.github.com/repos/PureSwift/Bluetooth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PureSwift/Bluetooth/labels{/name}","releases_url":"https://api.github.com/repos/PureSwift/Bluetooth/releases{/id}","deployments_url":"https://api.github.com/repos/PureSwift/Bluetooth/deployments","created_at":"2016-04-02T01:45:12Z","updated_at":"2018-07-11T07:25:49Z","pushed_at":"2018-07-11T16:24:45Z","git_url":"git://github.com/PureSwift/Bluetooth.git","ssh_url":"git@github.com:PureSwift/Bluetooth.git","clone_url":"https://github.com/PureSwift/Bluetooth.git","svn_url":"https://github.com/PureSwift/Bluetooth","homepage":"http://pureswift.github.io/Bluetooth/","size":16654,"stargazers_count":17,"watchers_count":17,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":6,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96"},"html":{"href":"https://github.com/PureSwift/Bluetooth/pull/96"},"issue":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/issues/96"},"comments":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/PureSwift/Bluetooth/statuses/cf92ef9e141f2a58ac8cbf6f3134117c9c3d5f79"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"colemancda"}}