{"action":"created","issue":{"url":"https://api.github.com/repos/pytroll/satpy/issues/239","repository_url":"https://api.github.com/repos/pytroll/satpy","labels_url":"https://api.github.com/repos/pytroll/satpy/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/pytroll/satpy/issues/239/comments","events_url":"https://api.github.com/repos/pytroll/satpy/issues/239/events","html_url":"https://github.com/pytroll/satpy/pull/239","id":308570292,"number":239,"title":"Add CSPP Geo (geocat) AHI reading support","user":{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false},"labels":[{"id":841946101,"url":"https://api.github.com/repos/pytroll/satpy/labels/component:readers","name":"component:readers","color":"1d76db","default":false},{"id":323805264,"url":"https://api.github.com/repos/pytroll/satpy/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pytroll/satpy/milestones/2","html_url":"https://github.com/pytroll/satpy/milestone/2","labels_url":"https://api.github.com/repos/pytroll/satpy/milestones/2/labels","id":2979810,"number":2,"title":"v0.9","description":"Xarray and dask","creator":{"login":"mraspaud","id":167802,"avatar_url":"https://avatars1.githubusercontent.com/u/167802?v=4","gravatar_id":"","url":"https://api.github.com/users/mraspaud","html_url":"https://github.com/mraspaud","followers_url":"https://api.github.com/users/mraspaud/followers","following_url":"https://api.github.com/users/mraspaud/following{/other_user}","gists_url":"https://api.github.com/users/mraspaud/gists{/gist_id}","starred_url":"https://api.github.com/users/mraspaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mraspaud/subscriptions","organizations_url":"https://api.github.com/users/mraspaud/orgs","repos_url":"https://api.github.com/users/mraspaud/repos","events_url":"https://api.github.com/users/mraspaud/events{/privacy}","received_events_url":"https://api.github.com/users/mraspaud/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":19,"state":"open","created_at":"2017-12-14T12:48:31Z","updated_at":"2018-03-26T13:23:38Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-03-26T13:23:38Z","updated_at":"2018-03-26T14:04:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pytroll/satpy/pulls/239","html_url":"https://github.com/pytroll/satpy/pull/239","diff_url":"https://github.com/pytroll/satpy/pull/239.diff","patch_url":"https://github.com/pytroll/satpy/pull/239.patch"},"body":"This PR adds AHI dataset identifiers to the geocat reader which will allow full support for CSPP Geo AHI products. Without this added to the reader config the datasets would not have an associated wavelength.\r\n\r\nThis PR also includes a large-ish change to the base readers and file handlers with a `sensor_names` property. Previously this was just an instance attribute. The default behavior is the same as before. The difference happens for any file handler that redefines `sensor_names` which will be used to determine what sensor's files have been loaded. This was needed for the geocat reader which supports multiple sensors including ABI and AHI. Some of the composite entries for these sensors conflict and in the previous implementation it was loading both ABI and AHI configs and which one took priority was unspecified.\r\n\r\n - [ ] Tests added <!-- for all bug fixes or enhancements -->\r\n - [x] Tests passed <!-- for all non-documentation changes) -->\r\n - [x] Passes ``git diff origin/develop **/*py | flake8 --diff`` <!-- remove if you did not edit any Python files -->\r\n"},"comment":{"url":"https://api.github.com/repos/pytroll/satpy/issues/comments/376177299","html_url":"https://github.com/pytroll/satpy/pull/239#issuecomment-376177299","issue_url":"https://api.github.com/repos/pytroll/satpy/issues/239","id":376177299,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T14:04:29Z","updated_at":"2018-03-26T14:04:29Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=h1) Report\n> Merging [#239](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=desc) into [develop](https://codecov.io/gh/pytroll/satpy/commit/422c02fb1afdfc3bfcc2cdd9b3c77a0061b9278f?src=pr&el=desc) will **increase** coverage by `19.6%`.\n> The diff coverage is `73.33%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/pytroll/satpy/pull/239/graphs/tree.svg?width=650&token=plt2new8tY&height=150&src=pr)](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop     #239      +/-   ##\n===========================================\n+ Coverage    41.06%   60.67%   +19.6%     \n===========================================\n  Files          212      111     -101     \n  Lines        26842    13655   -13187     \n===========================================\n- Hits         11023     8285    -2738     \n+ Misses       15819     5370   -10449\n```\n\n\n| [Impacted Files](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [satpy/tests/compositor\\_tests/test\\_abi.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvdGVzdHMvY29tcG9zaXRvcl90ZXN0cy90ZXN0X2FiaS5weQ==) | `96.77% <ø> (ø)` | :arrow_up: |\n| [satpy/tests/compositor\\_tests/\\_\\_init\\_\\_.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvdGVzdHMvY29tcG9zaXRvcl90ZXN0cy9fX2luaXRfXy5weQ==) | `98.46% <100%> (+0.02%)` | :arrow_up: |\n| [satpy/tests/reader\\_tests/test\\_geocat.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvdGVzdHMvcmVhZGVyX3Rlc3RzL3Rlc3RfZ2VvY2F0LnB5) | `98.11% <100%> (ø)` | :arrow_up: |\n| [satpy/composites/ahi.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvY29tcG9zaXRlcy9haGkucHk=) | `100% <100%> (+100%)` | :arrow_up: |\n| [satpy/readers/yaml\\_reader.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy95YW1sX3JlYWRlci5weQ==) | `87.23% <13.33%> (-2.2%)` | :arrow_down: |\n| [satpy/readers/file\\_handlers.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy9maWxlX2hhbmRsZXJzLnB5) | `91.48% <50%> (-1.85%)` | :arrow_down: |\n| [satpy/readers/geocat.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy9nZW9jYXQucHk=) | `92.02% <66.66%> (-0.57%)` | :arrow_down: |\n| [satpy/tests/compositor\\_tests/test\\_ahi.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-c2F0cHkvdGVzdHMvY29tcG9zaXRvcl90ZXN0cy90ZXN0X2FoaS5weQ==) | `96.66% <96.66%> (ø)` | |\n| [old/ahi\\_l1b/src/satpy/satpy/tests/test\\_plugin.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-b2xkL2FoaV9sMWIvc3JjL3NhdHB5L3NhdHB5L3Rlc3RzL3Rlc3RfcGx1Z2luLnB5) | | |\n| [...atpy/satpy/tests/reader\\_tests/test\\_netcdf\\_utils.py](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree#diff-b2xkL2FoaV9sMWIvc3JjL3NhdHB5L3NhdHB5L3Rlc3RzL3JlYWRlcl90ZXN0cy90ZXN0X25ldGNkZl91dGlscy5weQ==) | | |\n| ... and [102 more](https://codecov.io/gh/pytroll/satpy/pull/239/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=footer). Last update [422c02f...e5988bf](https://codecov.io/gh/pytroll/satpy/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}