{"action":"created","issue":{"url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/153","repository_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore","labels_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/153/comments","events_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/153/events","html_url":"https://github.com/LuxCoreRender/BlendLuxCore/issues/153","id":320885820,"number":153,"title":"Denoiser Integration","user":{"login":"Theverat","id":1584761,"avatar_url":"https://avatars2.githubusercontent.com/u/1584761?v=4","gravatar_id":"","url":"https://api.github.com/users/Theverat","html_url":"https://github.com/Theverat","followers_url":"https://api.github.com/users/Theverat/followers","following_url":"https://api.github.com/users/Theverat/following{/other_user}","gists_url":"https://api.github.com/users/Theverat/gists{/gist_id}","starred_url":"https://api.github.com/users/Theverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theverat/subscriptions","organizations_url":"https://api.github.com/users/Theverat/orgs","repos_url":"https://api.github.com/users/Theverat/repos","events_url":"https://api.github.com/users/Theverat/events{/privacy}","received_events_url":"https://api.github.com/users/Theverat/received_events","type":"User","site_admin":false},"labels":[{"id":764545078,"url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/labels/enhancement","name":"enhancement","color":"8fc5ff","default":true}],"state":"open","locked":false,"assignee":{"login":"Theverat","id":1584761,"avatar_url":"https://avatars2.githubusercontent.com/u/1584761?v=4","gravatar_id":"","url":"https://api.github.com/users/Theverat","html_url":"https://github.com/Theverat","followers_url":"https://api.github.com/users/Theverat/followers","following_url":"https://api.github.com/users/Theverat/following{/other_user}","gists_url":"https://api.github.com/users/Theverat/gists{/gist_id}","starred_url":"https://api.github.com/users/Theverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theverat/subscriptions","organizations_url":"https://api.github.com/users/Theverat/orgs","repos_url":"https://api.github.com/users/Theverat/repos","events_url":"https://api.github.com/users/Theverat/events{/privacy}","received_events_url":"https://api.github.com/users/Theverat/received_events","type":"User","site_admin":false},"assignees":[{"login":"Theverat","id":1584761,"avatar_url":"https://avatars2.githubusercontent.com/u/1584761?v=4","gravatar_id":"","url":"https://api.github.com/users/Theverat","html_url":"https://github.com/Theverat","followers_url":"https://api.github.com/users/Theverat/followers","following_url":"https://api.github.com/users/Theverat/following{/other_user}","gists_url":"https://api.github.com/users/Theverat/gists{/gist_id}","starred_url":"https://api.github.com/users/Theverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theverat/subscriptions","organizations_url":"https://api.github.com/users/Theverat/orgs","repos_url":"https://api.github.com/users/Theverat/repos","events_url":"https://api.github.com/users/Theverat/events{/privacy}","received_events_url":"https://api.github.com/users/Theverat/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/milestones/2","html_url":"https://github.com/LuxCoreRender/BlendLuxCore/milestone/2","labels_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/milestones/2/labels","id":3323791,"number":2,"title":"BlendLuxCore v2.1","description":"","creator":{"login":"Theverat","id":1584761,"avatar_url":"https://avatars2.githubusercontent.com/u/1584761?v=4","gravatar_id":"","url":"https://api.github.com/users/Theverat","html_url":"https://github.com/Theverat","followers_url":"https://api.github.com/users/Theverat/followers","following_url":"https://api.github.com/users/Theverat/following{/other_user}","gists_url":"https://api.github.com/users/Theverat/gists{/gist_id}","starred_url":"https://api.github.com/users/Theverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theverat/subscriptions","organizations_url":"https://api.github.com/users/Theverat/orgs","repos_url":"https://api.github.com/users/Theverat/repos","events_url":"https://api.github.com/users/Theverat/events{/privacy}","received_events_url":"https://api.github.com/users/Theverat/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-05-06T21:50:39Z","updated_at":"2018-05-07T17:23:12Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-05-07T17:23:12Z","updated_at":"2018-05-14T09:11:16Z","closed_at":null,"author_association":"MEMBER","body":"My TODO list for the denoiser integration.\r\n\r\n* [x] Check which settings can be hidden (probably the lower 3)\r\n* [x] Add a LuxCore panel to the image editor toolshelf\r\n* [x] Add denoiser settings to the panel, with a button to refresh the denoised image\r\n* [x] Remove periodic refresh\r\n* [ ] Sensible max values for the denoiser settings\r\n* [ ] [Descriptions](https://forums.luxcorerender.org/viewtopic.php?f=9&p=3882#p3882)\r\n* [ ] Easy mode or some presets for different qualities, if possible\r\n* [ ] The refresh buttons should only be visible when a render is running\r\n* [ ] Add warning when using Metropolis sampler (because the denoiser does not really work well in this case)\r\n\r\nUsability Ideas:\r\n* [x] Prevent users from accidentally triggering multiple denoiser calculations in a row\r\n* [x] Add a label to the denoiser panel (both render props and image tools) telling the user where to find the denoised image (\"In the image editor, open the rendered image and select the \"DENOISED\" pass. Make sure that the correct render layer is selected\")\r\n* [x] Show a helpful text over the black image that is shown by default in the denoiser pass (something like `Open the tool shelf with [T], go to the \"LuxCore\" category and press \"Run Denoiser\"`)\r\n\r\nKnown issues:\r\n* [ ] Only the \"combined\" imagepipeline is updated when the tonemapper or lightgroups are edited, denoiser output and lightgroup imagepipelines are not updated\r\n* [ ] Writing to ID classes in this context is not allowed\r\n```\r\nTraceback (most recent call last):\r\n  File \"/home/simon/.config/blender/2.79/scripts/addons/BlendLuxCore/engine/__init__.py\", line 36, in render_final\r\n    final.render(self, scene)\r\n  File \"/home/simon/.config/blender/2.79/scripts/addons/BlendLuxCore/engine/final.py\", line 36, in render\r\n    _render_layer(engine, scene)\r\n  File \"/home/simon/.config/blender/2.79/scripts/addons/BlendLuxCore/engine/final.py\", line 88, in _render_layer\r\n    utils_render.refresh(engine, scene, config, draw_film=True)\r\n  File \"/home/simon/.config/blender/2.79/scripts/addons/BlendLuxCore/utils/render.py\", line 53, in refresh\r\n    engine.framebuffer.draw(engine, engine.session, scene, render_stopped)\r\n  File \"/home/simon/.config/blender/2.79/scripts/addons/BlendLuxCore/draw/final.py\", line 70, in draw\r\n    scene.luxcore.display.refresh = False\r\nAttributeError: Writing to ID classes in this context is not allowed: Scene, Scene datablock, error setting LuxCoreDisplaySettings.refresh\r\n```\r\n\r\n* [ ] Enabling the denoiser after a render was started and pressing refresh leads to problems (film is no longer refreshed). It should be impossible to enable denoiser after final render was started (disable denoiser UI).\r\n* [ ] I think my Python code has some kind of memory leak caused by the buffers. Maybe I just have to delete them manually because GC works too late, or I keep a reference somewhere."},"comment":{"url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/comments/388749534","html_url":"https://github.com/LuxCoreRender/BlendLuxCore/issues/153#issuecomment-388749534","issue_url":"https://api.github.com/repos/LuxCoreRender/BlendLuxCore/issues/153","id":388749534,"user":{"login":"Dade916","id":3247881,"avatar_url":"https://avatars0.githubusercontent.com/u/3247881?v=4","gravatar_id":"","url":"https://api.github.com/users/Dade916","html_url":"https://github.com/Dade916","followers_url":"https://api.github.com/users/Dade916/followers","following_url":"https://api.github.com/users/Dade916/following{/other_user}","gists_url":"https://api.github.com/users/Dade916/gists{/gist_id}","starred_url":"https://api.github.com/users/Dade916/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dade916/subscriptions","organizations_url":"https://api.github.com/users/Dade916/orgs","repos_url":"https://api.github.com/users/Dade916/repos","events_url":"https://api.github.com/users/Dade916/events{/privacy}","received_events_url":"https://api.github.com/users/Dade916/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T09:11:16Z","updated_at":"2018-05-14T09:11:16Z","author_association":"OWNER","body":"Use the default scale value of 3 and use a resolution that is a multiple of 4. It is quite easy and it will help a bit in your case.\r\n\r\nAnyway, there is simple too much noise in the original image, you need a longer rendering time.\r\n"}}
{"actor":{"display_login":"Dade916"}}