{"action":"opened","number":3285,"pull_request":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285","id":239623238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjIzMjM4","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3285","diff_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3285.diff","patch_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3285.patch","issue_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/3285","number":3285,"state":"open","locked":false,"title":"Pointer line length bugs","user":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"body":"Overview\r\n---\r\nLine 176 in LinePointer was adding 0 (the distance between a point and itself) for the raystep that hit the object. This now properly adds the distance between the start of the raystep and the hit point.\r\n\r\nAdditionally, `GetNormalizedLengthFromWorldLength` was consistently overshooting and providing a slightly larger value than the true normalized length. This code now subtracts the amount that was overshot.\r\n\r\nChanges\r\n---\r\n- Related to #2960 \r\n","created_at":"2018-12-18T20:35:47Z","updated_at":"2018-12-18T20:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"assignees":[{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1158819821,"node_id":"MDU6TGFiZWwxMTU4ODE5ODIx","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/2018%20Bugs","name":"2018 Bugs","color":"ffccec","default":false},{"id":936491559,"node_id":"MDU6TGFiZWw5MzY0OTE1NTk=","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Input%20/%20Interactions","name":"Input / Interactions","color":"5ecae5","default":false},{"id":769313068,"node_id":"MDU6TGFiZWw3NjkzMTMwNjg=","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Ready%20for%20Review","name":"Ready for Review","color":"88f91d","default":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones/1","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/milestone/1","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones/1/labels","id":3141032,"node_id":"MDk6TWlsZXN0b25lMzE0MTAzMg==","number":1,"title":"MRTK 2018","description":"Mixed Reality Toolkit 2018","creator":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":492,"state":"open","created_at":"2018-02-24T21:08:44Z","updated_at":"2018-12-18T20:35:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/3285/comments","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/713ab8ee454ff12baf0e88d3f5f566afcce0d1bd","head":{"label":"keveleigh:pointer-line-length-bugs","ref":"pointer-line-length-bugs","sha":"713ab8ee454ff12baf0e88d3f5f566afcce0d1bd","user":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"repo":{"id":93100892,"node_id":"MDEwOlJlcG9zaXRvcnk5MzEwMDg5Mg==","name":"HoloToolkit-Unity","full_name":"keveleigh/HoloToolkit-Unity","private":false,"owner":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/keveleigh/HoloToolkit-Unity","description":"This is effectively part of the existing HoloToolkit, but is the repo that will contain all Unity specific components.","fork":true,"url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity","forks_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/forks","keys_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/events","assignees_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/merges","archive_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/deployments","created_at":"2017-06-01T21:27:04Z","updated_at":"2018-12-15T00:40:33Z","pushed_at":"2018-12-18T20:28:17Z","git_url":"git://github.com/keveleigh/HoloToolkit-Unity.git","ssh_url":"git@github.com:keveleigh/HoloToolkit-Unity.git","clone_url":"https://github.com/keveleigh/HoloToolkit-Unity.git","svn_url":"https://github.com/keveleigh/HoloToolkit-Unity","homepage":"","size":697196,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"mrtk_development"}},"base":{"label":"Microsoft:mrtk_development","ref":"mrtk_development","sha":"5f945d25514a87e4d072d894a6a9f90f1c909f31","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"node_id":"MDEwOlJlcG9zaXRvcnk1MDYwNTQyNg==","name":"MixedRealityToolkit-Unity","full_name":"Microsoft/MixedRealityToolkit-Unity","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":false,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2018-12-18T08:51:05Z","pushed_at":"2018-12-18T20:22:12Z","git_url":"git://github.com/Microsoft/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","homepage":"","size":728240,"stargazers_count":2292,"watchers_count":2292,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1099,"mirror_url":null,"archived":false,"open_issues_count":461,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1099,"open_issues":461,"watchers":2292,"default_branch":"mrtk_release"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3285"},"issue":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/3285"},"comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/3285/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/3285/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/713ab8ee454ff12baf0e88d3f5f566afcce0d1bd"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":8,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"keveleigh"}}