{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/188794221","pull_request_review_id":120845906,"id":188794221,"diff_hunk":"@@ -319,7 +320,13 @@\n *****************\n  6       CONTINUE\n *****************\n-         ALPHA = RHO / <xdot>( N, WORK(1,PTLD), 1, WORK(1,Q), 1 )\n+         TMPVAL = <xdot>( N, WORK(1,PTLD), 1, WORK(1,Q), 1 )\n+         IF (TMPVAL.EQ.0) THEN\n+*           Breakdown\n+            INFO = -11\n+            GO TO 20\n+         ENDIF\n+         ALPHA = RHO / TMPVAL","path":"scipy/sparse/linalg/isolve/iterative/BiCGREVCOM.f.src","position":21,"original_position":21,"commit_id":"09bd6ea7d02d45a544e991e9dd0b5b3768dd8785","original_commit_id":"09bd6ea7d02d45a544e991e9dd0b5b3768dd8785","user":{"login":"tylerjereddy","id":7903078,"avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"Is abstracting the duplicated error handling logic to a function (or similar) in Fortran more trouble than it is worth?\r\n\r\nAnd no better option than `GO TO`? I guess for error handling this is pretty common.","created_at":"2018-05-16T22:45:36Z","updated_at":"2018-05-16T22:48:12Z","html_url":"https://github.com/scipy/scipy/pull/8829#discussion_r188794221","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/8829","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/188794221"},"html":{"href":"https://github.com/scipy/scipy/pull/8829#discussion_r188794221"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8829"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/8829","id":188230394,"html_url":"https://github.com/scipy/scipy/pull/8829","diff_url":"https://github.com/scipy/scipy/pull/8829.diff","patch_url":"https://github.com/scipy/scipy/pull/8829.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/8829","number":8829,"state":"open","locked":false,"title":"BUG: sparse.linalg: fix up breakdown detection in cgs/bicg/bicgstab","user":{"login":"pv","id":35046,"avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"body":"The cgs/bicg/bicgstab algorithms have the known property that they can run into division by zero, in which case the algorithm cannot continue. In principle, in literature there are variants that can deal with this, but in the meantime change the codes so that the computation stops, instead of continuing until maxiter with vectors containing nans.\r\n\r\nAlso pick some minres bugfixes from upstream.","created_at":"2018-05-15T19:25:25Z","updated_at":"2018-05-16T22:48:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb4da856c098c5a0d045b94614c450357141daef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37334597,"url":"https://api.github.com/repos/scipy/scipy/labels/defect","name":"defect","color":"e11d21","default":false},{"id":37340854,"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.sparse.linalg","name":"scipy.sparse.linalg","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/8829/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/8829/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/8829/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/09bd6ea7d02d45a544e991e9dd0b5b3768dd8785","head":{"label":"pv:spsolve-fails","ref":"spsolve-fails","sha":"09bd6ea7d02d45a544e991e9dd0b5b3768dd8785","user":{"login":"pv","id":35046,"avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"repo":{"id":1460536,"name":"scipy-work","full_name":"pv/scipy-work","owner":{"login":"pv","id":35046,"avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pv/scipy-work","description":"Work on Scipy","fork":true,"url":"https://api.github.com/repos/pv/scipy-work","forks_url":"https://api.github.com/repos/pv/scipy-work/forks","keys_url":"https://api.github.com/repos/pv/scipy-work/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pv/scipy-work/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pv/scipy-work/teams","hooks_url":"https://api.github.com/repos/pv/scipy-work/hooks","issue_events_url":"https://api.github.com/repos/pv/scipy-work/issues/events{/number}","events_url":"https://api.github.com/repos/pv/scipy-work/events","assignees_url":"https://api.github.com/repos/pv/scipy-work/assignees{/user}","branches_url":"https://api.github.com/repos/pv/scipy-work/branches{/branch}","tags_url":"https://api.github.com/repos/pv/scipy-work/tags","blobs_url":"https://api.github.com/repos/pv/scipy-work/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pv/scipy-work/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pv/scipy-work/git/refs{/sha}","trees_url":"https://api.github.com/repos/pv/scipy-work/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pv/scipy-work/statuses/{sha}","languages_url":"https://api.github.com/repos/pv/scipy-work/languages","stargazers_url":"https://api.github.com/repos/pv/scipy-work/stargazers","contributors_url":"https://api.github.com/repos/pv/scipy-work/contributors","subscribers_url":"https://api.github.com/repos/pv/scipy-work/subscribers","subscription_url":"https://api.github.com/repos/pv/scipy-work/subscription","commits_url":"https://api.github.com/repos/pv/scipy-work/commits{/sha}","git_commits_url":"https://api.github.com/repos/pv/scipy-work/git/commits{/sha}","comments_url":"https://api.github.com/repos/pv/scipy-work/comments{/number}","issue_comment_url":"https://api.github.com/repos/pv/scipy-work/issues/comments{/number}","contents_url":"https://api.github.com/repos/pv/scipy-work/contents/{+path}","compare_url":"https://api.github.com/repos/pv/scipy-work/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pv/scipy-work/merges","archive_url":"https://api.github.com/repos/pv/scipy-work/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pv/scipy-work/downloads","issues_url":"https://api.github.com/repos/pv/scipy-work/issues{/number}","pulls_url":"https://api.github.com/repos/pv/scipy-work/pulls{/number}","milestones_url":"https://api.github.com/repos/pv/scipy-work/milestones{/number}","notifications_url":"https://api.github.com/repos/pv/scipy-work/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pv/scipy-work/labels{/name}","releases_url":"https://api.github.com/repos/pv/scipy-work/releases{/id}","deployments_url":"https://api.github.com/repos/pv/scipy-work/deployments","created_at":"2011-03-09T19:33:17Z","updated_at":"2016-06-24T15:36:42Z","pushed_at":"2018-05-15T19:21:19Z","git_url":"git://github.com/pv/scipy-work.git","ssh_url":"git@github.com:pv/scipy-work.git","clone_url":"https://github.com/pv/scipy-work.git","svn_url":"https://github.com/pv/scipy-work","homepage":"http://scipy.org/","size":85837,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"f259d9d560a5a3d0dda003d47e604b0f87709e6f","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-05-16T20:50:14Z","pushed_at":"2018-05-16T16:16:49Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":79983,"stargazers_count":4448,"watchers_count":4448,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2319,"mirror_url":null,"archived":false,"open_issues_count":1224,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2319,"open_issues":1224,"watchers":4448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8829"},"html":{"href":"https://github.com/scipy/scipy/pull/8829"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/8829"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/8829/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8829/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8829/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/09bd6ea7d02d45a544e991e9dd0b5b3768dd8785"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tylerjereddy"}}