{"action":"closed","number":33324,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33324","id":200245459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjQ1NDU5","html_url":"https://github.com/rails/rails/pull/33324","diff_url":"https://github.com/rails/rails/pull/33324.diff","patch_url":"https://github.com/rails/rails/pull/33324.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/33324","number":33324,"state":"closed","locked":false,"title":"respect only_path option when an array is passed into url_for","user":{"login":"Jcambass","id":3436381,"node_id":"MDQ6VXNlcjM0MzYzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3436381?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcambass","html_url":"https://github.com/Jcambass","followers_url":"https://api.github.com/users/Jcambass/followers","following_url":"https://api.github.com/users/Jcambass/following{/other_user}","gists_url":"https://api.github.com/users/Jcambass/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcambass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcambass/subscriptions","organizations_url":"https://api.github.com/users/Jcambass/orgs","repos_url":"https://api.github.com/users/Jcambass/repos","events_url":"https://api.github.com/users/Jcambass/events{/privacy}","received_events_url":"https://api.github.com/users/Jcambass/received_events","type":"User","site_admin":false},"body":"The url_for method is now extracting the only_path option in order to determine if polymorphic_path or polymorphic_url should be called.\r\n\r\nIf the only_path option is not set it will be set to true unless the host option is set. This behaviour is the same as when a Hash or Params object is passed.\r\n\r\nTo support this unifying, the code responsible for setting this default value has been extracted into a private method\r\n\r\nSummary\r\nFixes: #33237\r\n\r\nI also added two tests to ensure the correct behaviour","created_at":"2018-07-09T23:24:42Z","updated_at":"2018-10-08T08:52:40Z","closed_at":"2018-10-08T08:52:40Z","merged_at":"2018-10-08T08:52:40Z","merge_commit_sha":"d4127a014c110faa9c4611244f01f4320616a49b","assignee":{"login":"rafaelfranca","id":47848,"node_id":"MDQ6VXNlcjQ3ODQ4","avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafaelfranca","id":47848,"node_id":"MDQ6VXNlcjQ3ODQ4","avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":3666649,"node_id":"MDU6TGFiZWwzNjY2NjQ5","url":"https://api.github.com/repos/rails/rails/labels/actionview","name":"actionview","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/33324/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/33324/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/33324/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/b48c2ade09e9c43d6f7acee02d074a9d54323a70","head":{"label":"Jcambass:fix-only-path-option-in-url-for-with-arrays","ref":"fix-only-path-option-in-url-for-with-arrays","sha":"b48c2ade09e9c43d6f7acee02d074a9d54323a70","user":{"login":"Jcambass","id":3436381,"node_id":"MDQ6VXNlcjM0MzYzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3436381?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcambass","html_url":"https://github.com/Jcambass","followers_url":"https://api.github.com/users/Jcambass/followers","following_url":"https://api.github.com/users/Jcambass/following{/other_user}","gists_url":"https://api.github.com/users/Jcambass/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcambass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcambass/subscriptions","organizations_url":"https://api.github.com/users/Jcambass/orgs","repos_url":"https://api.github.com/users/Jcambass/repos","events_url":"https://api.github.com/users/Jcambass/events{/privacy}","received_events_url":"https://api.github.com/users/Jcambass/received_events","type":"User","site_admin":false},"repo":{"id":138936119,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5MzYxMTk=","name":"rails","full_name":"Jcambass/rails","private":false,"owner":{"login":"Jcambass","id":3436381,"node_id":"MDQ6VXNlcjM0MzYzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3436381?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcambass","html_url":"https://github.com/Jcambass","followers_url":"https://api.github.com/users/Jcambass/followers","following_url":"https://api.github.com/users/Jcambass/following{/other_user}","gists_url":"https://api.github.com/users/Jcambass/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcambass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcambass/subscriptions","organizations_url":"https://api.github.com/users/Jcambass/orgs","repos_url":"https://api.github.com/users/Jcambass/repos","events_url":"https://api.github.com/users/Jcambass/events{/privacy}","received_events_url":"https://api.github.com/users/Jcambass/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jcambass/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/Jcambass/rails","forks_url":"https://api.github.com/repos/Jcambass/rails/forks","keys_url":"https://api.github.com/repos/Jcambass/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jcambass/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jcambass/rails/teams","hooks_url":"https://api.github.com/repos/Jcambass/rails/hooks","issue_events_url":"https://api.github.com/repos/Jcambass/rails/issues/events{/number}","events_url":"https://api.github.com/repos/Jcambass/rails/events","assignees_url":"https://api.github.com/repos/Jcambass/rails/assignees{/user}","branches_url":"https://api.github.com/repos/Jcambass/rails/branches{/branch}","tags_url":"https://api.github.com/repos/Jcambass/rails/tags","blobs_url":"https://api.github.com/repos/Jcambass/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jcambass/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jcambass/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jcambass/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jcambass/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/Jcambass/rails/languages","stargazers_url":"https://api.github.com/repos/Jcambass/rails/stargazers","contributors_url":"https://api.github.com/repos/Jcambass/rails/contributors","subscribers_url":"https://api.github.com/repos/Jcambass/rails/subscribers","subscription_url":"https://api.github.com/repos/Jcambass/rails/subscription","commits_url":"https://api.github.com/repos/Jcambass/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jcambass/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jcambass/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jcambass/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jcambass/rails/contents/{+path}","compare_url":"https://api.github.com/repos/Jcambass/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jcambass/rails/merges","archive_url":"https://api.github.com/repos/Jcambass/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jcambass/rails/downloads","issues_url":"https://api.github.com/repos/Jcambass/rails/issues{/number}","pulls_url":"https://api.github.com/repos/Jcambass/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/Jcambass/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/Jcambass/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jcambass/rails/labels{/name}","releases_url":"https://api.github.com/repos/Jcambass/rails/releases{/id}","deployments_url":"https://api.github.com/repos/Jcambass/rails/deployments","created_at":"2018-06-27T21:45:04Z","updated_at":"2018-06-27T21:45:24Z","pushed_at":"2018-10-01T17:31:25Z","git_url":"git://github.com/Jcambass/rails.git","ssh_url":"git@github.com:Jcambass/rails.git","clone_url":"https://github.com/Jcambass/rails.git","svn_url":"https://github.com/Jcambass/rails","homepage":"http://rubyonrails.org","size":166738,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"2334fe8ffab7aa67504ae4a6b483f1a914b415bb","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","private":false,"owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-10-08T08:52:08Z","pushed_at":"2018-10-08T08:52:40Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"https://rubyonrails.org","size":167290,"stargazers_count":41050,"watchers_count":41050,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16599,"mirror_url":null,"archived":false,"open_issues_count":1063,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16599,"open_issues":1063,"watchers":41050,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/33324"},"html":{"href":"https://github.com/rails/rails/pull/33324"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/33324"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/33324/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/33324/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/33324/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/b48c2ade09e9c43d6f7acee02d074a9d54323a70"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kamipo","id":12642,"node_id":"MDQ6VXNlcjEyNjQy","avatar_url":"https://avatars0.githubusercontent.com/u/12642?v=4","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"kamipo"}}