{"action":"created","issue":{"url":"https://api.github.com/repos/risacan/kehi/issues/46","repository_url":"https://api.github.com/repos/risacan/kehi","labels_url":"https://api.github.com/repos/risacan/kehi/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/risacan/kehi/issues/46/comments","events_url":"https://api.github.com/repos/risacan/kehi/issues/46/events","html_url":"https://github.com/risacan/kehi/pull/46","id":330105167,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTk1Mjgz","number":46,"title":"その他の詳細を記入、参照できるようにする","user":{"login":"pittsunkana","id":38416697,"node_id":"MDQ6VXNlcjM4NDE2Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/38416697?v=4","gravatar_id":"","url":"https://api.github.com/users/pittsunkana","html_url":"https://github.com/pittsunkana","followers_url":"https://api.github.com/users/pittsunkana/followers","following_url":"https://api.github.com/users/pittsunkana/following{/other_user}","gists_url":"https://api.github.com/users/pittsunkana/gists{/gist_id}","starred_url":"https://api.github.com/users/pittsunkana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittsunkana/subscriptions","organizations_url":"https://api.github.com/users/pittsunkana/orgs","repos_url":"https://api.github.com/users/pittsunkana/repos","events_url":"https://api.github.com/users/pittsunkana/events{/privacy}","received_events_url":"https://api.github.com/users/pittsunkana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-07T03:37:21Z","updated_at":"2018-06-08T06:38:09Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/risacan/kehi/pulls/46","html_url":"https://github.com/risacan/kehi/pull/46","diff_url":"https://github.com/risacan/kehi/pull/46.diff","patch_url":"https://github.com/risacan/kehi/pull/46.patch"},"body":"**やりたいこと**\r\n\r\n- その他の詳細を記入するフォームを作成\r\n- 経費詳細画面でカテゴリが「その他」のときだけ詳細も表示\r\n\r\n**やったこと**\r\n\r\n- remarkカラムを作成\r\n-ストロングパラメーターにremarkを追加\r\n-Viewでカテゴリがその他のときだけ詳細が表示されるように設定\r\n\r\n**やらなかったこと**\r\n\r\n- validationをつける\r\n　　その他で詳細書かないときもあるかと思いつけなかった。\r\n　　備考欄的にその他を選んでないときでも書き込めるようにしたかった。\r\n**反省**\r\n\r\n- 経費の申請なので、その他を明らかにするのは絶対必要。Validation追加すべき。\r\n- その他以外で書き込んだときに参照できるスキームを考えなければならない。\r\n\r\n**Before**\r\n[Uploading** Kehi - http___localhost_3456_expenses_new.pdf…]()\r\n\r\n**After**\r\n\r\n![kehi - http___localhost_3456_expenses_new](https://user-images.githubusercontent.com/38416697/41077042-81be0332-6a4f-11e8-85b5-72ddc61933b9.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/risacan/kehi/issues/comments/395663190","html_url":"https://github.com/risacan/kehi/pull/46#issuecomment-395663190","issue_url":"https://api.github.com/repos/risacan/kehi/issues/46","id":395663190,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTY2MzE5MA==","user":{"login":"pittsunkana","id":38416697,"node_id":"MDQ6VXNlcjM4NDE2Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/38416697?v=4","gravatar_id":"","url":"https://api.github.com/users/pittsunkana","html_url":"https://github.com/pittsunkana","followers_url":"https://api.github.com/users/pittsunkana/followers","following_url":"https://api.github.com/users/pittsunkana/following{/other_user}","gists_url":"https://api.github.com/users/pittsunkana/gists{/gist_id}","starred_url":"https://api.github.com/users/pittsunkana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittsunkana/subscriptions","organizations_url":"https://api.github.com/users/pittsunkana/orgs","repos_url":"https://api.github.com/users/pittsunkana/repos","events_url":"https://api.github.com/users/pittsunkana/events{/privacy}","received_events_url":"https://api.github.com/users/pittsunkana/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T06:38:09Z","updated_at":"2018-06-08T06:38:09Z","author_association":"COLLABORATOR","body":"Migrationファイルは書き換えたらだめなものだと思っていました😳\r\n試しにやってみたいと思います。"}}
{"actor":{"display_login":"pittsunkana"}}