{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/linter/pulls/comments/229778472","pull_request_review_id":170359901,"id":229778472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc3ODQ3Mg==","diff_hunk":"@@ -0,0 +1,80 @@\n+// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file\n+// for details. All rights reserved. Use of this source code is governed by a\n+// BSD-style license that can be found in the LICENSE file.\n+\n+import 'package:analyzer/dart/ast/ast.dart';\n+import 'package:analyzer/dart/ast/visitor.dart';\n+import 'package:analyzer/dart/element/type.dart';\n+import 'package:linter/src/analyzer.dart';\n+\n+const _desc = r'Avoid returning null for Future.';\n+\n+const _details = r'''\n+\n+**AVOID** returning null for Future.\n+\n+Future being used to represent a potential value, or error, that will be\n+available at some time in the future it's almost always wrong to return null for","path":"lib/src/rules/avoid_returning_null_for_future.dart","position":null,"original_position":17,"commit_id":"a556362324a582b8af4df6322b8d2d1747b5c282","original_commit_id":"2b39190498694a09dccecbc7e2c7a7e83406c5a3","user":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-10-31T16:48:15Z","updated_at":"2018-10-31T16:48:15Z","html_url":"https://github.com/dart-lang/linter/pull/1238#discussion_r229778472","pull_request_url":"https://api.github.com/repos/dart-lang/linter/pulls/1238","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/comments/229778472"},"html":{"href":"https://github.com/dart-lang/linter/pull/1238#discussion_r229778472"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/1238"}},"in_reply_to_id":229773631},"pull_request":{"url":"https://api.github.com/repos/dart-lang/linter/pulls/1238","id":227198952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTk4OTUy","html_url":"https://github.com/dart-lang/linter/pull/1238","diff_url":"https://github.com/dart-lang/linter/pull/1238.diff","patch_url":"https://github.com/dart-lang/linter/pull/1238.patch","issue_url":"https://api.github.com/repos/dart-lang/linter/issues/1238","number":1238,"state":"open","locked":false,"title":"add lint avoid_returning_null_for_future","user":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-31T08:36:35Z","updated_at":"2018-10-31T16:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d380999ce0ddce0ab4ab34ab99104ab8821718ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":421017818,"node_id":"MDU6TGFiZWw0MjEwMTc4MTg=","url":"https://api.github.com/repos/dart-lang/linter/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/linter/pulls/1238/commits","review_comments_url":"https://api.github.com/repos/dart-lang/linter/pulls/1238/comments","review_comment_url":"https://api.github.com/repos/dart-lang/linter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/linter/issues/1238/comments","statuses_url":"https://api.github.com/repos/dart-lang/linter/statuses/a556362324a582b8af4df6322b8d2d1747b5c282","head":{"label":"a14n:avoid_returning_null_for_future","ref":"avoid_returning_null_for_future","sha":"a556362324a582b8af4df6322b8d2d1747b5c282","user":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"repo":{"id":81377658,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM3NzY1OA==","name":"linter","full_name":"a14n/linter","private":false,"owner":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a14n/linter","description":"Style linter for Dart.","fork":true,"url":"https://api.github.com/repos/a14n/linter","forks_url":"https://api.github.com/repos/a14n/linter/forks","keys_url":"https://api.github.com/repos/a14n/linter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a14n/linter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a14n/linter/teams","hooks_url":"https://api.github.com/repos/a14n/linter/hooks","issue_events_url":"https://api.github.com/repos/a14n/linter/issues/events{/number}","events_url":"https://api.github.com/repos/a14n/linter/events","assignees_url":"https://api.github.com/repos/a14n/linter/assignees{/user}","branches_url":"https://api.github.com/repos/a14n/linter/branches{/branch}","tags_url":"https://api.github.com/repos/a14n/linter/tags","blobs_url":"https://api.github.com/repos/a14n/linter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a14n/linter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a14n/linter/git/refs{/sha}","trees_url":"https://api.github.com/repos/a14n/linter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a14n/linter/statuses/{sha}","languages_url":"https://api.github.com/repos/a14n/linter/languages","stargazers_url":"https://api.github.com/repos/a14n/linter/stargazers","contributors_url":"https://api.github.com/repos/a14n/linter/contributors","subscribers_url":"https://api.github.com/repos/a14n/linter/subscribers","subscription_url":"https://api.github.com/repos/a14n/linter/subscription","commits_url":"https://api.github.com/repos/a14n/linter/commits{/sha}","git_commits_url":"https://api.github.com/repos/a14n/linter/git/commits{/sha}","comments_url":"https://api.github.com/repos/a14n/linter/comments{/number}","issue_comment_url":"https://api.github.com/repos/a14n/linter/issues/comments{/number}","contents_url":"https://api.github.com/repos/a14n/linter/contents/{+path}","compare_url":"https://api.github.com/repos/a14n/linter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a14n/linter/merges","archive_url":"https://api.github.com/repos/a14n/linter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a14n/linter/downloads","issues_url":"https://api.github.com/repos/a14n/linter/issues{/number}","pulls_url":"https://api.github.com/repos/a14n/linter/pulls{/number}","milestones_url":"https://api.github.com/repos/a14n/linter/milestones{/number}","notifications_url":"https://api.github.com/repos/a14n/linter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a14n/linter/labels{/name}","releases_url":"https://api.github.com/repos/a14n/linter/releases{/id}","deployments_url":"https://api.github.com/repos/a14n/linter/deployments","created_at":"2017-02-08T21:26:38Z","updated_at":"2017-02-08T21:26:41Z","pushed_at":"2018-10-31T16:47:59Z","git_url":"git://github.com/a14n/linter.git","ssh_url":"git@github.com:a14n/linter.git","clone_url":"https://github.com/a14n/linter.git","svn_url":"https://github.com/a14n/linter","homepage":"https://dart-lang.github.io/linter/","size":1946,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"2c9125f6cbb0b4650fe115768513f4847c74c227","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":29209166,"node_id":"MDEwOlJlcG9zaXRvcnkyOTIwOTE2Ng==","name":"linter","full_name":"dart-lang/linter","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/linter","description":"Linter for Dart.","fork":false,"url":"https://api.github.com/repos/dart-lang/linter","forks_url":"https://api.github.com/repos/dart-lang/linter/forks","keys_url":"https://api.github.com/repos/dart-lang/linter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/linter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/linter/teams","hooks_url":"https://api.github.com/repos/dart-lang/linter/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/linter/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/linter/events","assignees_url":"https://api.github.com/repos/dart-lang/linter/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/linter/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/linter/tags","blobs_url":"https://api.github.com/repos/dart-lang/linter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/linter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/linter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/linter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/linter/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/linter/languages","stargazers_url":"https://api.github.com/repos/dart-lang/linter/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/linter/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/linter/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/linter/subscription","commits_url":"https://api.github.com/repos/dart-lang/linter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/linter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/linter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/linter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/linter/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/linter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/linter/merges","archive_url":"https://api.github.com/repos/dart-lang/linter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/linter/downloads","issues_url":"https://api.github.com/repos/dart-lang/linter/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/linter/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/linter/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/linter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/linter/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/linter/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/linter/deployments","created_at":"2015-01-13T20:21:11Z","updated_at":"2018-10-30T22:33:20Z","pushed_at":"2018-10-31T16:48:01Z","git_url":"git://github.com/dart-lang/linter.git","ssh_url":"git@github.com:dart-lang/linter.git","clone_url":"https://github.com/dart-lang/linter.git","svn_url":"https://github.com/dart-lang/linter","homepage":"https://dart-lang.github.io/linter/","size":1957,"stargazers_count":79,"watchers_count":79,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":43,"open_issues":217,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/1238"},"html":{"href":"https://github.com/dart-lang/linter/pull/1238"},"issue":{"href":"https://api.github.com/repos/dart-lang/linter/issues/1238"},"comments":{"href":"https://api.github.com/repos/dart-lang/linter/issues/1238/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/1238/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/linter/pulls/1238/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/linter/statuses/a556362324a582b8af4df6322b8d2d1747b5c282"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"a14n"}}