{"action":"created","issue":{"url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/90","repository_url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching","labels_url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/90/comments","events_url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/90/events","html_url":"https://github.com/albatrossflavour/puppet_os_patching/pull/90","id":367145932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjUwODE4","number":90,"title":"shared logic and acceptance tests","user":{"login":"GeoffWilliams","id":3904115,"node_id":"MDQ6VXNlcjM5MDQxMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3904115?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffWilliams","html_url":"https://github.com/GeoffWilliams","followers_url":"https://api.github.com/users/GeoffWilliams/followers","following_url":"https://api.github.com/users/GeoffWilliams/following{/other_user}","gists_url":"https://api.github.com/users/GeoffWilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffWilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffWilliams/subscriptions","organizations_url":"https://api.github.com/users/GeoffWilliams/orgs","repos_url":"https://api.github.com/users/GeoffWilliams/repos","events_url":"https://api.github.com/users/GeoffWilliams/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffWilliams/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-05T10:11:51Z","updated_at":"2018-10-12T00:18:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/pulls/90","html_url":"https://github.com/albatrossflavour/puppet_os_patching/pull/90","diff_url":"https://github.com/albatrossflavour/puppet_os_patching/pull/90.diff","patch_url":"https://github.com/albatrossflavour/puppet_os_patching/pull/90.patch"},"body":"We had some limited testing in place already, this adds a lot more:\r\n* acceptance test *running* apt-get/yum with mock commands\r\n* consolidate duplicated logic into a single ruby module\r\n* debug logging via JSON input parameter\r\n* remove calls to facter at runtime, replace with call to ruby API\r\n* a _compile_ step is now needed to write the final tasks:\r\n  * `/tasks.real` - this is where the real task code lives\r\n  * To _compile_ (sigh.. concatenate) the final files: `cd tasks && make` (don't add to main makefile to avoid clobber on upgrade)\r\n* update to latest beta PDQTest 2.0\r\n* switch facts array hash keys to use labels/strings as returned from facter API\r\n* RSpec tests + testcases for ruby fact parsing (skeleton form only - tests still need writing)\r\n* backport upstream fixes that happened while this was going on\r\n\r\nNotes: \r\n* Needs more testing but getting this out there\r\n* Security updates listing does't work on RHEL6:\r\n```\r\nCommand line error: no such option: --security\r\n[root@localhost vagrant]# yum -q --security check-update\r\n```"},"comment":{"url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/comments/429163359","html_url":"https://github.com/albatrossflavour/puppet_os_patching/pull/90#issuecomment-429163359","issue_url":"https://api.github.com/repos/albatrossflavour/puppet_os_patching/issues/90","id":429163359,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE2MzM1OQ==","user":{"login":"GeoffWilliams","id":3904115,"node_id":"MDQ6VXNlcjM5MDQxMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3904115?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffWilliams","html_url":"https://github.com/GeoffWilliams","followers_url":"https://api.github.com/users/GeoffWilliams/followers","following_url":"https://api.github.com/users/GeoffWilliams/following{/other_user}","gists_url":"https://api.github.com/users/GeoffWilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffWilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffWilliams/subscriptions","organizations_url":"https://api.github.com/users/GeoffWilliams/orgs","repos_url":"https://api.github.com/users/GeoffWilliams/repos","events_url":"https://api.github.com/users/GeoffWilliams/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffWilliams/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T00:18:30Z","updated_at":"2018-10-12T00:18:30Z","author_association":"CONTRIBUTOR","body":"Jobs are killed after 10 seconds ;-)"}}
{"actor":{"display_login":"GeoffWilliams"}}