{"action":"created","comment":{"url":"https://api.github.com/repos/salesforce/Argus/pulls/comments/219355905","pull_request_review_id":157512289,"id":219355905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTM1NTkwNQ==","diff_hunk":"@@ -52,6 +55,8 @@\n     private String tagKey;\n     @JsonProperty(\"tagv\")\n     private String tagValue;\n+    @JsonProperty(RETENTION_DISCOVERY)\n+    private Integer retentionDiscovery;","path":"ArgusCore/src/main/java/com/salesforce/dva/argus/entity/MetricSchemaRecord.java","position":15,"original_position":15,"commit_id":"9013bf9d593d6874556a406d5c6b0ecb4b4734f9","original_commit_id":"9013bf9d593d6874556a406d5c6b0ecb4b4734f9","user":{"login":"nkunal","id":604069,"node_id":"MDQ6VXNlcjYwNDA2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/604069?v=4","gravatar_id":"","url":"https://api.github.com/users/nkunal","html_url":"https://github.com/nkunal","followers_url":"https://api.github.com/users/nkunal/followers","following_url":"https://api.github.com/users/nkunal/following{/other_user}","gists_url":"https://api.github.com/users/nkunal/gists{/gist_id}","starred_url":"https://api.github.com/users/nkunal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkunal/subscriptions","organizations_url":"https://api.github.com/users/nkunal/orgs","repos_url":"https://api.github.com/users/nkunal/repos","events_url":"https://api.github.com/users/nkunal/events{/privacy}","received_events_url":"https://api.github.com/users/nkunal/received_events","type":"User","site_admin":false},"body":"Just to be extra careful, could you check if having this as a class var/json prop, will not impact any other places where this class is used. ","created_at":"2018-09-21T00:29:52Z","updated_at":"2018-09-21T00:51:09Z","html_url":"https://github.com/salesforce/Argus/pull/923#discussion_r219355905","pull_request_url":"https://api.github.com/repos/salesforce/Argus/pulls/923","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/comments/219355905"},"html":{"href":"https://github.com/salesforce/Argus/pull/923#discussion_r219355905"},"pull_request":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/923"}}},"pull_request":{"url":"https://api.github.com/repos/salesforce/Argus/pulls/923","id":217113593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTEzNTkz","html_url":"https://github.com/salesforce/Argus/pull/923","diff_url":"https://github.com/salesforce/Argus/pull/923.diff","patch_url":"https://github.com/salesforce/Argus/pull/923.patch","issue_url":"https://api.github.com/repos/salesforce/Argus/issues/923","number":923,"state":"open","locked":false,"title":"DO NOT MERGE - W-5349757: Provide custom discovery retention period (part 1)","user":{"login":"kow1011b","id":42449748,"node_id":"MDQ6VXNlcjQyNDQ5NzQ4","avatar_url":"https://avatars2.githubusercontent.com/u/42449748?v=4","gravatar_id":"","url":"https://api.github.com/users/kow1011b","html_url":"https://github.com/kow1011b","followers_url":"https://api.github.com/users/kow1011b/followers","following_url":"https://api.github.com/users/kow1011b/following{/other_user}","gists_url":"https://api.github.com/users/kow1011b/gists{/gist_id}","starred_url":"https://api.github.com/users/kow1011b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow1011b/subscriptions","organizations_url":"https://api.github.com/users/kow1011b/orgs","repos_url":"https://api.github.com/users/kow1011b/repos","events_url":"https://api.github.com/users/kow1011b/events{/privacy}","received_events_url":"https://api.github.com/users/kow1011b/received_events","type":"User","site_admin":false},"body":"tests will follow.","created_at":"2018-09-20T21:34:01Z","updated_at":"2018-09-21T00:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"276a16bec2d8f2b507660cffbd415a767f446469","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesforce/Argus/pulls/923/commits","review_comments_url":"https://api.github.com/repos/salesforce/Argus/pulls/923/comments","review_comment_url":"https://api.github.com/repos/salesforce/Argus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesforce/Argus/issues/923/comments","statuses_url":"https://api.github.com/repos/salesforce/Argus/statuses/9013bf9d593d6874556a406d5c6b0ecb4b4734f9","head":{"label":"salesforce:customRetention","ref":"customRetention","sha":"9013bf9d593d6874556a406d5c6b0ecb4b4734f9","user":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":44994636,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5NDYzNg==","name":"Argus","full_name":"salesforce/Argus","private":false,"owner":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/salesforce/Argus","description":"Time series monitoring and alerting platform.","fork":false,"url":"https://api.github.com/repos/salesforce/Argus","forks_url":"https://api.github.com/repos/salesforce/Argus/forks","keys_url":"https://api.github.com/repos/salesforce/Argus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/Argus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/Argus/teams","hooks_url":"https://api.github.com/repos/salesforce/Argus/hooks","issue_events_url":"https://api.github.com/repos/salesforce/Argus/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/Argus/events","assignees_url":"https://api.github.com/repos/salesforce/Argus/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/Argus/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/Argus/tags","blobs_url":"https://api.github.com/repos/salesforce/Argus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/Argus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/Argus/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/Argus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/Argus/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/Argus/languages","stargazers_url":"https://api.github.com/repos/salesforce/Argus/stargazers","contributors_url":"https://api.github.com/repos/salesforce/Argus/contributors","subscribers_url":"https://api.github.com/repos/salesforce/Argus/subscribers","subscription_url":"https://api.github.com/repos/salesforce/Argus/subscription","commits_url":"https://api.github.com/repos/salesforce/Argus/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/Argus/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/Argus/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/Argus/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/Argus/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/Argus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/Argus/merges","archive_url":"https://api.github.com/repos/salesforce/Argus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/Argus/downloads","issues_url":"https://api.github.com/repos/salesforce/Argus/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/Argus/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/Argus/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/Argus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/Argus/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/Argus/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/Argus/deployments","created_at":"2015-10-26T20:17:17Z","updated_at":"2018-09-19T02:14:24Z","pushed_at":"2018-09-20T22:31:58Z","git_url":"git://github.com/salesforce/Argus.git","ssh_url":"git@github.com:salesforce/Argus.git","clone_url":"https://github.com/salesforce/Argus.git","svn_url":"https://github.com/salesforce/Argus","homepage":"","size":8029,"stargazers_count":370,"watchers_count":370,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":108,"open_issues":58,"watchers":370,"default_branch":"develop"}},"base":{"label":"salesforce:develop","ref":"develop","sha":"624b222f70a2f10c5ff7e108f7bc1526347f5e59","user":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":44994636,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5NDYzNg==","name":"Argus","full_name":"salesforce/Argus","private":false,"owner":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/salesforce/Argus","description":"Time series monitoring and alerting platform.","fork":false,"url":"https://api.github.com/repos/salesforce/Argus","forks_url":"https://api.github.com/repos/salesforce/Argus/forks","keys_url":"https://api.github.com/repos/salesforce/Argus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/Argus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/Argus/teams","hooks_url":"https://api.github.com/repos/salesforce/Argus/hooks","issue_events_url":"https://api.github.com/repos/salesforce/Argus/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/Argus/events","assignees_url":"https://api.github.com/repos/salesforce/Argus/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/Argus/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/Argus/tags","blobs_url":"https://api.github.com/repos/salesforce/Argus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/Argus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/Argus/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/Argus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/Argus/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/Argus/languages","stargazers_url":"https://api.github.com/repos/salesforce/Argus/stargazers","contributors_url":"https://api.github.com/repos/salesforce/Argus/contributors","subscribers_url":"https://api.github.com/repos/salesforce/Argus/subscribers","subscription_url":"https://api.github.com/repos/salesforce/Argus/subscription","commits_url":"https://api.github.com/repos/salesforce/Argus/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/Argus/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/Argus/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/Argus/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/Argus/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/Argus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/Argus/merges","archive_url":"https://api.github.com/repos/salesforce/Argus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/Argus/downloads","issues_url":"https://api.github.com/repos/salesforce/Argus/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/Argus/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/Argus/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/Argus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/Argus/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/Argus/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/Argus/deployments","created_at":"2015-10-26T20:17:17Z","updated_at":"2018-09-19T02:14:24Z","pushed_at":"2018-09-20T22:31:58Z","git_url":"git://github.com/salesforce/Argus.git","ssh_url":"git@github.com:salesforce/Argus.git","clone_url":"https://github.com/salesforce/Argus.git","svn_url":"https://github.com/salesforce/Argus","homepage":"","size":8029,"stargazers_count":370,"watchers_count":370,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":108,"open_issues":58,"watchers":370,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/923"},"html":{"href":"https://github.com/salesforce/Argus/pull/923"},"issue":{"href":"https://api.github.com/repos/salesforce/Argus/issues/923"},"comments":{"href":"https://api.github.com/repos/salesforce/Argus/issues/923/comments"},"review_comments":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/923/comments"},"review_comment":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/923/commits"},"statuses":{"href":"https://api.github.com/repos/salesforce/Argus/statuses/9013bf9d593d6874556a406d5c6b0ecb4b4734f9"}},"author_association":"NONE"}}
{"actor":{"display_login":"nkunal"}}