{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrd/pulls/comments/172726504","pull_request_review_id":101792190,"id":172726504,"diff_hunk":"@@ -670,7 +670,10 @@ func (a *AddrManager) AddressCache() []*wire.NetAddress {\n \tallAddr := make([]*wire.NetAddress, 0, addrIndexLen)\n \t// Iteration order is undefined here, but we randomise it anyway.\n \tfor _, v := range a.addrIndex {\n-\t\tallAddr = append(allAddr, v.na)\n+\t\t// Skip low quality addresses.\n+\t\tif !v.isBad() {","path":"addrmgr/addrmanager.go","position":null,"original_position":6,"commit_id":"4968eed85792f3cb484639046ede491101d5b4d2","original_commit_id":"0fc383782fa51cf829980685a9db72afc846e3a4","user":{"login":"markusrichter","id":35237512,"avatar_url":"https://avatars1.githubusercontent.com/u/35237512?v=4","gravatar_id":"","url":"https://api.github.com/users/markusrichter","html_url":"https://github.com/markusrichter","followers_url":"https://api.github.com/users/markusrichter/followers","following_url":"https://api.github.com/users/markusrichter/following{/other_user}","gists_url":"https://api.github.com/users/markusrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/markusrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusrichter/subscriptions","organizations_url":"https://api.github.com/users/markusrichter/orgs","repos_url":"https://api.github.com/users/markusrichter/repos","events_url":"https://api.github.com/users/markusrichter/events{/privacy}","received_events_url":"https://api.github.com/users/markusrichter/received_events","type":"User","site_admin":false},"body":"OK, changed.","created_at":"2018-03-07T02:39:16Z","updated_at":"2018-03-07T02:39:17Z","html_url":"https://github.com/decred/dcrd/pull/1135#discussion_r172726504","pull_request_url":"https://api.github.com/repos/decred/dcrd/pulls/1135","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments/172726504"},"html":{"href":"https://github.com/decred/dcrd/pull/1135#discussion_r172726504"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1135"}},"in_reply_to_id":172723597},"pull_request":{"url":"https://api.github.com/repos/decred/dcrd/pulls/1135","id":173311006,"html_url":"https://github.com/decred/dcrd/pull/1135","diff_url":"https://github.com/decred/dcrd/pull/1135.diff","patch_url":"https://github.com/decred/dcrd/pull/1135.patch","issue_url":"https://api.github.com/repos/decred/dcrd/issues/1135","number":1135,"state":"open","locked":false,"title":"addrmgr: Skip low quality addresses for getaddr.","user":{"login":"markusrichter","id":35237512,"avatar_url":"https://avatars1.githubusercontent.com/u/35237512?v=4","gravatar_id":"","url":"https://api.github.com/users/markusrichter","html_url":"https://github.com/markusrichter","followers_url":"https://api.github.com/users/markusrichter/followers","following_url":"https://api.github.com/users/markusrichter/following{/other_user}","gists_url":"https://api.github.com/users/markusrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/markusrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusrichter/subscriptions","organizations_url":"https://api.github.com/users/markusrichter/orgs","repos_url":"https://api.github.com/users/markusrichter/repos","events_url":"https://api.github.com/users/markusrichter/events{/privacy}","received_events_url":"https://api.github.com/users/markusrichter/received_events","type":"User","site_admin":false},"body":"The AddressCache() should not propagate addresses of known low quality\r\nto its peers.\r\n\r\nInspired by the Bitcoin Core implementation.","created_at":"2018-03-06T23:22:36Z","updated_at":"2018-03-07T02:39:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5ad4f4e368e92eb0b009b0088c3a902b12d292","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrd/pulls/1135/commits","review_comments_url":"https://api.github.com/repos/decred/dcrd/pulls/1135/comments","review_comment_url":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrd/issues/1135/comments","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/4968eed85792f3cb484639046ede491101d5b4d2","head":{"label":"markusrichter:addrmgr-better-address-cache","ref":"addrmgr-better-address-cache","sha":"4968eed85792f3cb484639046ede491101d5b4d2","user":{"login":"markusrichter","id":35237512,"avatar_url":"https://avatars1.githubusercontent.com/u/35237512?v=4","gravatar_id":"","url":"https://api.github.com/users/markusrichter","html_url":"https://github.com/markusrichter","followers_url":"https://api.github.com/users/markusrichter/followers","following_url":"https://api.github.com/users/markusrichter/following{/other_user}","gists_url":"https://api.github.com/users/markusrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/markusrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusrichter/subscriptions","organizations_url":"https://api.github.com/users/markusrichter/orgs","repos_url":"https://api.github.com/users/markusrichter/repos","events_url":"https://api.github.com/users/markusrichter/events{/privacy}","received_events_url":"https://api.github.com/users/markusrichter/received_events","type":"User","site_admin":false},"repo":{"id":116722628,"name":"dcrd","full_name":"markusrichter/dcrd","owner":{"login":"markusrichter","id":35237512,"avatar_url":"https://avatars1.githubusercontent.com/u/35237512?v=4","gravatar_id":"","url":"https://api.github.com/users/markusrichter","html_url":"https://github.com/markusrichter","followers_url":"https://api.github.com/users/markusrichter/followers","following_url":"https://api.github.com/users/markusrichter/following{/other_user}","gists_url":"https://api.github.com/users/markusrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/markusrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusrichter/subscriptions","organizations_url":"https://api.github.com/users/markusrichter/orgs","repos_url":"https://api.github.com/users/markusrichter/repos","events_url":"https://api.github.com/users/markusrichter/events{/privacy}","received_events_url":"https://api.github.com/users/markusrichter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markusrichter/dcrd","description":"Decred daemon in Go (golang).","fork":true,"url":"https://api.github.com/repos/markusrichter/dcrd","forks_url":"https://api.github.com/repos/markusrichter/dcrd/forks","keys_url":"https://api.github.com/repos/markusrichter/dcrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusrichter/dcrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusrichter/dcrd/teams","hooks_url":"https://api.github.com/repos/markusrichter/dcrd/hooks","issue_events_url":"https://api.github.com/repos/markusrichter/dcrd/issues/events{/number}","events_url":"https://api.github.com/repos/markusrichter/dcrd/events","assignees_url":"https://api.github.com/repos/markusrichter/dcrd/assignees{/user}","branches_url":"https://api.github.com/repos/markusrichter/dcrd/branches{/branch}","tags_url":"https://api.github.com/repos/markusrichter/dcrd/tags","blobs_url":"https://api.github.com/repos/markusrichter/dcrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusrichter/dcrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusrichter/dcrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusrichter/dcrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusrichter/dcrd/statuses/{sha}","languages_url":"https://api.github.com/repos/markusrichter/dcrd/languages","stargazers_url":"https://api.github.com/repos/markusrichter/dcrd/stargazers","contributors_url":"https://api.github.com/repos/markusrichter/dcrd/contributors","subscribers_url":"https://api.github.com/repos/markusrichter/dcrd/subscribers","subscription_url":"https://api.github.com/repos/markusrichter/dcrd/subscription","commits_url":"https://api.github.com/repos/markusrichter/dcrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusrichter/dcrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusrichter/dcrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusrichter/dcrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/markusrichter/dcrd/contents/{+path}","compare_url":"https://api.github.com/repos/markusrichter/dcrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusrichter/dcrd/merges","archive_url":"https://api.github.com/repos/markusrichter/dcrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusrichter/dcrd/downloads","issues_url":"https://api.github.com/repos/markusrichter/dcrd/issues{/number}","pulls_url":"https://api.github.com/repos/markusrichter/dcrd/pulls{/number}","milestones_url":"https://api.github.com/repos/markusrichter/dcrd/milestones{/number}","notifications_url":"https://api.github.com/repos/markusrichter/dcrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusrichter/dcrd/labels{/name}","releases_url":"https://api.github.com/repos/markusrichter/dcrd/releases{/id}","deployments_url":"https://api.github.com/repos/markusrichter/dcrd/deployments","created_at":"2018-01-08T20:08:55Z","updated_at":"2018-01-08T20:09:00Z","pushed_at":"2018-03-07T02:38:00Z","git_url":"git://github.com/markusrichter/dcrd.git","ssh_url":"git@github.com:markusrichter/dcrd.git","clone_url":"https://github.com/markusrichter/dcrd.git","svn_url":"https://github.com/markusrichter/dcrd","homepage":"https://decred.org","size":23480,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"c49a9bd2612789ef244db51d96e7529605044fc8","user":{"login":"decred","id":16297194,"avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457080,"name":"dcrd","full_name":"decred/dcrd","owner":{"login":"decred","id":16297194,"avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrd","description":"Decred daemon in Go (golang).","fork":true,"url":"https://api.github.com/repos/decred/dcrd","forks_url":"https://api.github.com/repos/decred/dcrd/forks","keys_url":"https://api.github.com/repos/decred/dcrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrd/teams","hooks_url":"https://api.github.com/repos/decred/dcrd/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrd/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrd/events","assignees_url":"https://api.github.com/repos/decred/dcrd/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrd/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrd/tags","blobs_url":"https://api.github.com/repos/decred/dcrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrd/languages","stargazers_url":"https://api.github.com/repos/decred/dcrd/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrd/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrd/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrd/subscription","commits_url":"https://api.github.com/repos/decred/dcrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrd/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrd/merges","archive_url":"https://api.github.com/repos/decred/dcrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrd/downloads","issues_url":"https://api.github.com/repos/decred/dcrd/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrd/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrd/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrd/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrd/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrd/deployments","created_at":"2016-01-26T20:28:42Z","updated_at":"2018-03-06T04:59:42Z","pushed_at":"2018-03-07T02:38:03Z","git_url":"git://github.com/decred/dcrd.git","ssh_url":"git@github.com:decred/dcrd.git","clone_url":"https://github.com/decred/dcrd.git","svn_url":"https://github.com/decred/dcrd","homepage":"https://decred.org","size":23465,"stargazers_count":310,"watchers_count":310,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":103,"open_issues":47,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1135"},"html":{"href":"https://github.com/decred/dcrd/pull/1135"},"issue":{"href":"https://api.github.com/repos/decred/dcrd/issues/1135"},"comments":{"href":"https://api.github.com/repos/decred/dcrd/issues/1135/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1135/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1135/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrd/statuses/4968eed85792f3cb484639046ede491101d5b4d2"}},"author_association":"NONE"}}
{"actor":{"display_login":"markusrichter"}}