{"action":"created","issue":{"url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/76","repository_url":"https://api.github.com/repos/maennchen/ZipStream-PHP","labels_url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/76/comments","events_url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/76/events","html_url":"https://github.com/maennchen/ZipStream-PHP/issues/76","id":330686388,"node_id":"MDU6SXNzdWUzMzA2ODYzODg=","number":76,"title":"The Native OSX-Unzipper can not handle the Archives.","user":{"login":"superjunky","id":9337767,"node_id":"MDQ6VXNlcjkzMzc3Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/9337767?v=4","gravatar_id":"","url":"https://api.github.com/users/superjunky","html_url":"https://github.com/superjunky","followers_url":"https://api.github.com/users/superjunky/followers","following_url":"https://api.github.com/users/superjunky/following{/other_user}","gists_url":"https://api.github.com/users/superjunky/gists{/gist_id}","starred_url":"https://api.github.com/users/superjunky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superjunky/subscriptions","organizations_url":"https://api.github.com/users/superjunky/orgs","repos_url":"https://api.github.com/users/superjunky/repos","events_url":"https://api.github.com/users/superjunky/events{/privacy}","received_events_url":"https://api.github.com/users/superjunky/received_events","type":"User","site_admin":false},"labels":[{"id":65663827,"node_id":"MDU6TGFiZWw2NTY2MzgyNw==","url":"https://api.github.com/repos/maennchen/ZipStream-PHP/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-08T14:42:41Z","updated_at":"2018-07-31T15:06:47Z","closed_at":null,"author_association":"NONE","body":"I'm struggling to get correct archives that can be unzipped by the native OSX-Unzipper.\r\n\r\nI'm reading and testing for some time now, but now I'm wondering if it is even possible for version >1. (I read several of these type of issues.)\r\n\r\n- Can you confirm `->addFileFromStream()` does not work for the OSX-Unzipper?\r\n- If so, would it be wise to use version 0.5?\r\n\r\nFor a clear reference I'll post the code that I used, and a test.zip file.\r\n\r\n[test.zip](https://github.com/maennchen/ZipStream-PHP/files/2084809/test.zip)\r\n\r\n```\r\n$options = new ZipStream\\Option\\Archive();\r\n$options->setZeroHeader(true); \r\n$options->setContentType( 'application/octet-stream' ); \r\n$options->setSendHttpHeaders(true);\r\n$options->setHttpHeaderCallback('header');\r\n\r\n$zip = new ZipStream\\ZipStream( $filename . '.zip', $options );\r\n\r\nforeach ( $files as $file ) {\r\n\r\n\tif ( ! file_exists( $file ) ) {\r\n\t\tcontinue;\r\n\t}\r\n\r\n\tif ( ! $stream = fopen( $file, 'r' ) ) {\r\n\t\t$zip->addFileFromStream( basename( $file ), $stream );        \r\n\t} else {\r\n\t\tdie( __( 'Could not open stream for reading', 'photosessions' ) );\r\n\t}\r\n\r\n}\r\n\r\n$zip->finish();\r\n```"},"comment":{"url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/comments/409254974","html_url":"https://github.com/maennchen/ZipStream-PHP/issues/76#issuecomment-409254974","issue_url":"https://api.github.com/repos/maennchen/ZipStream-PHP/issues/76","id":409254974,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI1NDk3NA==","user":{"login":"NicolasCARPi","id":3043706,"node_id":"MDQ6VXNlcjMwNDM3MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3043706?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasCARPi","html_url":"https://github.com/NicolasCARPi","followers_url":"https://api.github.com/users/NicolasCARPi/followers","following_url":"https://api.github.com/users/NicolasCARPi/following{/other_user}","gists_url":"https://api.github.com/users/NicolasCARPi/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasCARPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasCARPi/subscriptions","organizations_url":"https://api.github.com/users/NicolasCARPi/orgs","repos_url":"https://api.github.com/users/NicolasCARPi/repos","events_url":"https://api.github.com/users/NicolasCARPi/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasCARPi/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T15:06:46Z","updated_at":"2018-07-31T15:06:46Z","author_association":"COLLABORATOR","body":"> What actual difference will it make to change the content_type?\r\n\r\nIt's to tell the browser what to expect. Some users for instance will download zip immediatly, others will have a dialog to select the action (save or extract directly). It doesn't change anything to the file itself afaik.\r\n\r\n> I reverted back to ZipStream version 0.3.0. This solved my issues.\r\n\r\nWell that's interesting, it means a regression was introduced. Now let's go `git bisect` some commits…"}}
{"actor":{"display_login":"NicolasCARPi"}}