{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1453","repository_url":"https://api.github.com/repos/ARMmbed/mbedtls","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1453/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1453/comments","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1453/events","html_url":"https://github.com/ARMmbed/mbedtls/pull/1453","id":305224854,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1MDA1NDE2","number":1453,"title":"Update Windows Crypto APIs","user":{"login":"sbutcher-arm","id":8195775,"node_id":"MDQ6VXNlcjgxOTU3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8195775?v=4","gravatar_id":"","url":"https://api.github.com/users/sbutcher-arm","html_url":"https://github.com/sbutcher-arm","followers_url":"https://api.github.com/users/sbutcher-arm/followers","following_url":"https://api.github.com/users/sbutcher-arm/following{/other_user}","gists_url":"https://api.github.com/users/sbutcher-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbutcher-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbutcher-arm/subscriptions","organizations_url":"https://api.github.com/users/sbutcher-arm/orgs","repos_url":"https://api.github.com/users/sbutcher-arm/repos","events_url":"https://api.github.com/users/sbutcher-arm/events{/privacy}","received_events_url":"https://api.github.com/users/sbutcher-arm/received_events","type":"User","site_admin":false},"labels":[{"id":278176777,"node_id":"MDU6TGFiZWwyNzgxNzY3Nzc=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/CLA%20valid","name":"CLA valid","color":"bfdadc","default":false},{"id":817445289,"node_id":"MDU6TGFiZWw4MTc0NDUyODk=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/approved%20for%20design","name":"approved for design","color":"66cc00","default":false},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":435765575,"node_id":"MDU6TGFiZWw0MzU3NjU1NzU=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"sbutcher-arm","id":8195775,"node_id":"MDQ6VXNlcjgxOTU3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8195775?v=4","gravatar_id":"","url":"https://api.github.com/users/sbutcher-arm","html_url":"https://github.com/sbutcher-arm","followers_url":"https://api.github.com/users/sbutcher-arm/followers","following_url":"https://api.github.com/users/sbutcher-arm/following{/other_user}","gists_url":"https://api.github.com/users/sbutcher-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbutcher-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbutcher-arm/subscriptions","organizations_url":"https://api.github.com/users/sbutcher-arm/orgs","repos_url":"https://api.github.com/users/sbutcher-arm/repos","events_url":"https://api.github.com/users/sbutcher-arm/events{/privacy}","received_events_url":"https://api.github.com/users/sbutcher-arm/received_events","type":"User","site_admin":false},"assignees":[{"login":"sbutcher-arm","id":8195775,"node_id":"MDQ6VXNlcjgxOTU3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8195775?v=4","gravatar_id":"","url":"https://api.github.com/users/sbutcher-arm","html_url":"https://github.com/sbutcher-arm","followers_url":"https://api.github.com/users/sbutcher-arm/followers","following_url":"https://api.github.com/users/sbutcher-arm/following{/other_user}","gists_url":"https://api.github.com/users/sbutcher-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbutcher-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbutcher-arm/subscriptions","organizations_url":"https://api.github.com/users/sbutcher-arm/orgs","repos_url":"https://api.github.com/users/sbutcher-arm/repos","events_url":"https://api.github.com/users/sbutcher-arm/events{/privacy}","received_events_url":"https://api.github.com/users/sbutcher-arm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":29,"created_at":"2018-03-14T16:06:08Z","updated_at":"2018-12-27T12:15:56Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1453","html_url":"https://github.com/ARMmbed/mbedtls/pull/1453","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1453.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1453.patch"},"body":"## Description\r\n\r\nThis is an update on PR #730 to address issues building with mingw and Visual Studio when using `cmake` generated files.\r\n\r\nTo quote the original PR.\r\n\r\n> CryptGenRandom and lstrlenW are not permitted in Windows Store apps, meaning apps that use mbedTLS can't ship in the Windows Store. Instead, use BCryptGenRandom and wcslen, respectively, which are permitted.\r\n> \r\n> Also make sure conversions between size_t, ULONG, and int are always done safely; on a 64-bit platform, these types are differnt sizes.\r\n>\r\n\r\nAlso, removed the obsolete Visual Studio 6 data files which are no longer used.\r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\nNO  \r\n\r\n## Migrations\r\nNO\r\n\r\n## Todos\r\n- [X] Tests\r\n- [] Documentation\r\n- [X] Changelog updated\r\n- [] Backported\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments/450140206","html_url":"https://github.com/ARMmbed/mbedtls/pull/1453#issuecomment-450140206","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1453","id":450140206,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDE0MDIwNg==","user":{"login":"sbutcher-arm","id":8195775,"node_id":"MDQ6VXNlcjgxOTU3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8195775?v=4","gravatar_id":"","url":"https://api.github.com/users/sbutcher-arm","html_url":"https://github.com/sbutcher-arm","followers_url":"https://api.github.com/users/sbutcher-arm/followers","following_url":"https://api.github.com/users/sbutcher-arm/following{/other_user}","gists_url":"https://api.github.com/users/sbutcher-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbutcher-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbutcher-arm/subscriptions","organizations_url":"https://api.github.com/users/sbutcher-arm/orgs","repos_url":"https://api.github.com/users/sbutcher-arm/repos","events_url":"https://api.github.com/users/sbutcher-arm/events{/privacy}","received_events_url":"https://api.github.com/users/sbutcher-arm/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T12:15:56Z","updated_at":"2018-12-27T12:15:56Z","author_association":"COLLABORATOR","body":"I've tested with the Docker image in the CI, and the issue is the version of mingw is too old, being `i686-w64-mingw32-gcc (GCC) 5.3.1 20160211`.\r\n\r\nThis is too old, and even Ubuntu 17.10 currently has a package version of `i686-w64-mingw32-gcc (GCC) 6.3.0 20170415`.\r\n\r\nThis issue is with the CI and needs to be updated to merge this PR."}}
{"actor":{"display_login":"sbutcher-arm"}}