{"action":"created","comment":{"url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/comments/171167278","pull_request_review_id":99971415,"id":171167278,"diff_hunk":"@@ -0,0 +1,20 @@\n+# frozen_string_literal: true\n+module Sls::UserAuthenticationConcern\n+  extend ActiveSupport::Concern\n+\n+  # Overrides `Devise::Models::Validatable`\n+  # This disables the devise email validation for SLS users.\n+  def email_required?\n+    sls_user? ? false : super\n+  end\n+\n+  # Overrides `Devise::Models::Validatable`\n+  # This disables the devise password validation for SLS users.\n+  def password_required?\n+    sls_user? ? false : super","path":"app/models/concerns/sls/user_authentication_concern.rb","position":null,"original_position":14,"commit_id":"480b88ca50f8b72573dd44bb435acd3c72ea6b06","original_commit_id":"28ec2ee452b39d4780bb8e327b016228a242a87e","user":{"login":"kxmbrian","id":6252919,"avatar_url":"https://avatars0.githubusercontent.com/u/6252919?v=4","gravatar_id":"","url":"https://api.github.com/users/kxmbrian","html_url":"https://github.com/kxmbrian","followers_url":"https://api.github.com/users/kxmbrian/followers","following_url":"https://api.github.com/users/kxmbrian/following{/other_user}","gists_url":"https://api.github.com/users/kxmbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/kxmbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxmbrian/subscriptions","organizations_url":"https://api.github.com/users/kxmbrian/orgs","repos_url":"https://api.github.com/users/kxmbrian/repos","events_url":"https://api.github.com/users/kxmbrian/events{/privacy}","received_events_url":"https://api.github.com/users/kxmbrian/received_events","type":"User","site_admin":false},"body":"Added `emails.empty?` check to prevent users from locking themselves out of the public interface.","created_at":"2018-02-28T08:12:14Z","updated_at":"2018-02-28T08:12:14Z","html_url":"https://github.com/moexmen/coursemology-sls/pull/1#discussion_r171167278","pull_request_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/comments/171167278"},"html":{"href":"https://github.com/moexmen/coursemology-sls/pull/1#discussion_r171167278"},"pull_request":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1"}},"in_reply_to_id":171146765},"pull_request":{"url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1","id":168792249,"html_url":"https://github.com/moexmen/coursemology-sls/pull/1","diff_url":"https://github.com/moexmen/coursemology-sls/pull/1.diff","patch_url":"https://github.com/moexmen/coursemology-sls/pull/1.patch","issue_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/1","number":1,"state":"open","locked":false,"title":"Integration","user":{"login":"kxmbrian","id":6252919,"avatar_url":"https://avatars0.githubusercontent.com/u/6252919?v=4","gravatar_id":"","url":"https://api.github.com/users/kxmbrian","html_url":"https://github.com/kxmbrian","followers_url":"https://api.github.com/users/kxmbrian/followers","following_url":"https://api.github.com/users/kxmbrian/following{/other_user}","gists_url":"https://api.github.com/users/kxmbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/kxmbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxmbrian/subscriptions","organizations_url":"https://api.github.com/users/kxmbrian/orgs","repos_url":"https://api.github.com/users/kxmbrian/repos","events_url":"https://api.github.com/users/kxmbrian/events{/privacy}","received_events_url":"https://api.github.com/users/kxmbrian/received_events","type":"User","site_admin":false},"body":"Do not merge yet.\r\n\r\n- For now, users that are removed from the subject group are not deleted from `Course`. I think the teacher should manually remove them since it might be difficult to undo if there is a mistake. We should add an alert for this later. \r\n- Bulk user creation can be slow, but I think the current set up is fine for now. Also, we can be less aggressive about keeping subject group users up to date later on.\r\n- `User.stamper` is set to system. I think this makes more sense than setting to an arbitrary teacher.\r\n- For course `end_at`, I made the assumption that when a `Course` is created, it is for either the current year or coming year. Arbitrarily set it to end at the later of the two.","created_at":"2018-02-13T09:26:26Z","updated_at":"2018-02-28T08:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf37b6369827bbf8d85c0b314ff74f5af3b4ed9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1/commits","review_comments_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1/comments","review_comment_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/1/comments","statuses_url":"https://api.github.com/repos/moexmen/coursemology-sls/statuses/480b88ca50f8b72573dd44bb435acd3c72ea6b06","head":{"label":"moexmen:kxmbrian/integration","ref":"kxmbrian/integration","sha":"480b88ca50f8b72573dd44bb435acd3c72ea6b06","user":{"login":"moexmen","id":8214900,"avatar_url":"https://avatars1.githubusercontent.com/u/8214900?v=4","gravatar_id":"","url":"https://api.github.com/users/moexmen","html_url":"https://github.com/moexmen","followers_url":"https://api.github.com/users/moexmen/followers","following_url":"https://api.github.com/users/moexmen/following{/other_user}","gists_url":"https://api.github.com/users/moexmen/gists{/gist_id}","starred_url":"https://api.github.com/users/moexmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moexmen/subscriptions","organizations_url":"https://api.github.com/users/moexmen/orgs","repos_url":"https://api.github.com/users/moexmen/repos","events_url":"https://api.github.com/users/moexmen/events{/privacy}","received_events_url":"https://api.github.com/users/moexmen/received_events","type":"Organization","site_admin":false},"repo":{"id":121362565,"name":"coursemology-sls","full_name":"moexmen/coursemology-sls","owner":{"login":"moexmen","id":8214900,"avatar_url":"https://avatars1.githubusercontent.com/u/8214900?v=4","gravatar_id":"","url":"https://api.github.com/users/moexmen","html_url":"https://github.com/moexmen","followers_url":"https://api.github.com/users/moexmen/followers","following_url":"https://api.github.com/users/moexmen/following{/other_user}","gists_url":"https://api.github.com/users/moexmen/gists{/gist_id}","starred_url":"https://api.github.com/users/moexmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moexmen/subscriptions","organizations_url":"https://api.github.com/users/moexmen/orgs","repos_url":"https://api.github.com/users/moexmen/repos","events_url":"https://api.github.com/users/moexmen/events{/privacy}","received_events_url":"https://api.github.com/users/moexmen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moexmen/coursemology-sls","description":"SLS-Integrable Coursemology","fork":false,"url":"https://api.github.com/repos/moexmen/coursemology-sls","forks_url":"https://api.github.com/repos/moexmen/coursemology-sls/forks","keys_url":"https://api.github.com/repos/moexmen/coursemology-sls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moexmen/coursemology-sls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moexmen/coursemology-sls/teams","hooks_url":"https://api.github.com/repos/moexmen/coursemology-sls/hooks","issue_events_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/events{/number}","events_url":"https://api.github.com/repos/moexmen/coursemology-sls/events","assignees_url":"https://api.github.com/repos/moexmen/coursemology-sls/assignees{/user}","branches_url":"https://api.github.com/repos/moexmen/coursemology-sls/branches{/branch}","tags_url":"https://api.github.com/repos/moexmen/coursemology-sls/tags","blobs_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/refs{/sha}","trees_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moexmen/coursemology-sls/statuses/{sha}","languages_url":"https://api.github.com/repos/moexmen/coursemology-sls/languages","stargazers_url":"https://api.github.com/repos/moexmen/coursemology-sls/stargazers","contributors_url":"https://api.github.com/repos/moexmen/coursemology-sls/contributors","subscribers_url":"https://api.github.com/repos/moexmen/coursemology-sls/subscribers","subscription_url":"https://api.github.com/repos/moexmen/coursemology-sls/subscription","commits_url":"https://api.github.com/repos/moexmen/coursemology-sls/commits{/sha}","git_commits_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/commits{/sha}","comments_url":"https://api.github.com/repos/moexmen/coursemology-sls/comments{/number}","issue_comment_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/comments{/number}","contents_url":"https://api.github.com/repos/moexmen/coursemology-sls/contents/{+path}","compare_url":"https://api.github.com/repos/moexmen/coursemology-sls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moexmen/coursemology-sls/merges","archive_url":"https://api.github.com/repos/moexmen/coursemology-sls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moexmen/coursemology-sls/downloads","issues_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues{/number}","pulls_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls{/number}","milestones_url":"https://api.github.com/repos/moexmen/coursemology-sls/milestones{/number}","notifications_url":"https://api.github.com/repos/moexmen/coursemology-sls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moexmen/coursemology-sls/labels{/name}","releases_url":"https://api.github.com/repos/moexmen/coursemology-sls/releases{/id}","deployments_url":"https://api.github.com/repos/moexmen/coursemology-sls/deployments","created_at":"2018-02-13T09:22:12Z","updated_at":"2018-02-13T09:25:13Z","pushed_at":"2018-02-28T07:48:58Z","git_url":"git://github.com/moexmen/coursemology-sls.git","ssh_url":"git@github.com:moexmen/coursemology-sls.git","clone_url":"https://github.com/moexmen/coursemology-sls.git","svn_url":"https://github.com/moexmen/coursemology-sls","homepage":null,"size":10213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"moexmen:master","ref":"master","sha":"8904676746143b6bf56ed60694340a9738d38285","user":{"login":"moexmen","id":8214900,"avatar_url":"https://avatars1.githubusercontent.com/u/8214900?v=4","gravatar_id":"","url":"https://api.github.com/users/moexmen","html_url":"https://github.com/moexmen","followers_url":"https://api.github.com/users/moexmen/followers","following_url":"https://api.github.com/users/moexmen/following{/other_user}","gists_url":"https://api.github.com/users/moexmen/gists{/gist_id}","starred_url":"https://api.github.com/users/moexmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moexmen/subscriptions","organizations_url":"https://api.github.com/users/moexmen/orgs","repos_url":"https://api.github.com/users/moexmen/repos","events_url":"https://api.github.com/users/moexmen/events{/privacy}","received_events_url":"https://api.github.com/users/moexmen/received_events","type":"Organization","site_admin":false},"repo":{"id":121362565,"name":"coursemology-sls","full_name":"moexmen/coursemology-sls","owner":{"login":"moexmen","id":8214900,"avatar_url":"https://avatars1.githubusercontent.com/u/8214900?v=4","gravatar_id":"","url":"https://api.github.com/users/moexmen","html_url":"https://github.com/moexmen","followers_url":"https://api.github.com/users/moexmen/followers","following_url":"https://api.github.com/users/moexmen/following{/other_user}","gists_url":"https://api.github.com/users/moexmen/gists{/gist_id}","starred_url":"https://api.github.com/users/moexmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moexmen/subscriptions","organizations_url":"https://api.github.com/users/moexmen/orgs","repos_url":"https://api.github.com/users/moexmen/repos","events_url":"https://api.github.com/users/moexmen/events{/privacy}","received_events_url":"https://api.github.com/users/moexmen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moexmen/coursemology-sls","description":"SLS-Integrable Coursemology","fork":false,"url":"https://api.github.com/repos/moexmen/coursemology-sls","forks_url":"https://api.github.com/repos/moexmen/coursemology-sls/forks","keys_url":"https://api.github.com/repos/moexmen/coursemology-sls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moexmen/coursemology-sls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moexmen/coursemology-sls/teams","hooks_url":"https://api.github.com/repos/moexmen/coursemology-sls/hooks","issue_events_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/events{/number}","events_url":"https://api.github.com/repos/moexmen/coursemology-sls/events","assignees_url":"https://api.github.com/repos/moexmen/coursemology-sls/assignees{/user}","branches_url":"https://api.github.com/repos/moexmen/coursemology-sls/branches{/branch}","tags_url":"https://api.github.com/repos/moexmen/coursemology-sls/tags","blobs_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/refs{/sha}","trees_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moexmen/coursemology-sls/statuses/{sha}","languages_url":"https://api.github.com/repos/moexmen/coursemology-sls/languages","stargazers_url":"https://api.github.com/repos/moexmen/coursemology-sls/stargazers","contributors_url":"https://api.github.com/repos/moexmen/coursemology-sls/contributors","subscribers_url":"https://api.github.com/repos/moexmen/coursemology-sls/subscribers","subscription_url":"https://api.github.com/repos/moexmen/coursemology-sls/subscription","commits_url":"https://api.github.com/repos/moexmen/coursemology-sls/commits{/sha}","git_commits_url":"https://api.github.com/repos/moexmen/coursemology-sls/git/commits{/sha}","comments_url":"https://api.github.com/repos/moexmen/coursemology-sls/comments{/number}","issue_comment_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues/comments{/number}","contents_url":"https://api.github.com/repos/moexmen/coursemology-sls/contents/{+path}","compare_url":"https://api.github.com/repos/moexmen/coursemology-sls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moexmen/coursemology-sls/merges","archive_url":"https://api.github.com/repos/moexmen/coursemology-sls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moexmen/coursemology-sls/downloads","issues_url":"https://api.github.com/repos/moexmen/coursemology-sls/issues{/number}","pulls_url":"https://api.github.com/repos/moexmen/coursemology-sls/pulls{/number}","milestones_url":"https://api.github.com/repos/moexmen/coursemology-sls/milestones{/number}","notifications_url":"https://api.github.com/repos/moexmen/coursemology-sls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moexmen/coursemology-sls/labels{/name}","releases_url":"https://api.github.com/repos/moexmen/coursemology-sls/releases{/id}","deployments_url":"https://api.github.com/repos/moexmen/coursemology-sls/deployments","created_at":"2018-02-13T09:22:12Z","updated_at":"2018-02-13T09:25:13Z","pushed_at":"2018-02-28T07:48:58Z","git_url":"git://github.com/moexmen/coursemology-sls.git","ssh_url":"git@github.com:moexmen/coursemology-sls.git","clone_url":"https://github.com/moexmen/coursemology-sls.git","svn_url":"https://github.com/moexmen/coursemology-sls","homepage":null,"size":10213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1"},"html":{"href":"https://github.com/moexmen/coursemology-sls/pull/1"},"issue":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/issues/1"},"comments":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/moexmen/coursemology-sls/statuses/480b88ca50f8b72573dd44bb435acd3c72ea6b06"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kxmbrian"}}