{"action":"closed","number":595,"pull_request":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/595","id":236942041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTQyMDQx","html_url":"https://github.com/YunoHost/yunohost/pull/595","diff_url":"https://github.com/YunoHost/yunohost/pull/595.diff","patch_url":"https://github.com/YunoHost/yunohost/pull/595.patch","issue_url":"https://api.github.com/repos/YunoHost/yunohost/issues/595","number":595,"state":"closed","locked":false,"title":"[fix] Repair tests","user":{"login":"Josue-T","id":7387681,"node_id":"MDQ6VXNlcjczODc2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7387681?v=4","gravatar_id":"","url":"https://api.github.com/users/Josue-T","html_url":"https://github.com/Josue-T","followers_url":"https://api.github.com/users/Josue-T/followers","following_url":"https://api.github.com/users/Josue-T/following{/other_user}","gists_url":"https://api.github.com/users/Josue-T/gists{/gist_id}","starred_url":"https://api.github.com/users/Josue-T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josue-T/subscriptions","organizations_url":"https://api.github.com/users/Josue-T/orgs","repos_url":"https://api.github.com/users/Josue-T/repos","events_url":"https://api.github.com/users/Josue-T/events{/privacy}","received_events_url":"https://api.github.com/users/Josue-T/received_events","type":"User","site_admin":false},"body":"## The problem\r\n\r\nMany tests are broken\r\n\r\n## Solution\r\n\r\nFix it\r\n\r\nNote that a fix is solved in moulinette in [#185](https://github.com/YunoHost/moulinette/pull/185)\r\n\r\n## PR Status\r\n\r\nAll test should be fixed\r\n\r\n## How to test\r\n\r\nIn the moulinette repos, use the branch `fix_ldap_authenticator`.\r\n\r\nrun `./ynh-dev test yunohost`\r\n\r\n## Validation\r\n\r\n- [ ] Principle agreement 0/2 : \r\n- [ ] Quick review 0/1 : \r\n- [ ] Simple test 0/1 : \r\n- [ ] Deep review 0/1 : \r\n","created_at":"2018-12-07T17:35:30Z","updated_at":"2018-12-12T15:53:49Z","closed_at":"2018-12-12T15:53:48Z","merged_at":"2018-12-12T15:53:48Z","merge_commit_sha":"0d83d35c4d00345cf6df0a91bbe801969b9fd5a6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Psycojoker","id":41827,"node_id":"MDQ6VXNlcjQxODI3","avatar_url":"https://avatars0.githubusercontent.com/u/41827?v=4","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},{"login":"zamentur","id":4080016,"node_id":"MDQ6VXNlcjQwODAwMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4080016?v=4","gravatar_id":"","url":"https://api.github.com/users/zamentur","html_url":"https://github.com/zamentur","followers_url":"https://api.github.com/users/zamentur/followers","following_url":"https://api.github.com/users/zamentur/following{/other_user}","gists_url":"https://api.github.com/users/zamentur/gists{/gist_id}","starred_url":"https://api.github.com/users/zamentur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamentur/subscriptions","organizations_url":"https://api.github.com/users/zamentur/orgs","repos_url":"https://api.github.com/users/zamentur/repos","events_url":"https://api.github.com/users/zamentur/events{/privacy}","received_events_url":"https://api.github.com/users/zamentur/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487247789,"node_id":"MDU6TGFiZWw0ODcyNDc3ODk=","url":"https://api.github.com/repos/YunoHost/yunohost/labels/opinion%20needed","name":"opinion needed","color":"fbca04","default":false},{"id":487243058,"node_id":"MDU6TGFiZWw0ODcyNDMwNTg=","url":"https://api.github.com/repos/YunoHost/yunohost/labels/small%20decision","name":"small decision","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/YunoHost/yunohost/milestones/17","html_url":"https://github.com/YunoHost/yunohost/milestone/17","labels_url":"https://api.github.com/repos/YunoHost/yunohost/milestones/17/labels","id":3840923,"node_id":"MDk6TWlsZXN0b25lMzg0MDkyMw==","number":17,"title":"3.4.x","description":null,"creator":{"login":"alexAubin","id":4533074,"node_id":"MDQ6VXNlcjQ1MzMwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4533074?v=4","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":14,"state":"open","created_at":"2018-11-22T13:53:30Z","updated_at":"2018-12-12T15:53:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/595/commits","review_comments_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/595/comments","review_comment_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/issues/595/comments","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/d7f25bec2ab05faa6f69a9a37f75b570eb7430f4","head":{"label":"YunoHost:fix_test","ref":"fix_test","sha":"d7f25bec2ab05faa6f69a9a37f75b570eb7430f4","user":{"login":"YunoHost","id":1519495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTk0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1519495?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1NDI0Ng==","name":"yunohost","full_name":"YunoHost/yunohost","private":false,"owner":{"login":"YunoHost","id":1519495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTk0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1519495?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2018-12-12T12:12:09Z","pushed_at":"2018-12-12T15:53:48Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":4357,"stargazers_count":330,"watchers_count":330,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":92,"open_issues":48,"watchers":330,"default_branch":"stretch-unstable"}},"base":{"label":"YunoHost:stretch-unstable","ref":"stretch-unstable","sha":"1ac97c46adc4518eefdf2a43b57c86e9626b087d","user":{"login":"YunoHost","id":1519495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTk0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1519495?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1NDI0Ng==","name":"yunohost","full_name":"YunoHost/yunohost","private":false,"owner":{"login":"YunoHost","id":1519495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTk0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1519495?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2018-12-12T12:12:09Z","pushed_at":"2018-12-12T15:53:48Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":4357,"stargazers_count":330,"watchers_count":330,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":92,"open_issues":48,"watchers":330,"default_branch":"stretch-unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/595"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/595"},"issue":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/595"},"comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/YunoHost/yunohost/statuses/d7f25bec2ab05faa6f69a9a37f75b570eb7430f4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexAubin","id":4533074,"node_id":"MDQ6VXNlcjQ1MzMwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4533074?v=4","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":6,"maintainer_can_modify":false,"commits":7,"additions":45,"deletions":44,"changed_files":5}}
{"actor":{"display_login":"alexAubin"}}