{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/213965450","pull_request_review_id":150913242,"id":213965450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk2NTQ1MA==","diff_hunk":"@@ -402,11 +422,7 @@ impl Builder {\n                         Some(p) => p,\n                         None => return false,\n                     };\n-                    let target = match pkg.target.get(&c.target) {\n-                        Some(t) => t,\n-                        None => return false,\n-                    };\n-                    target.available","path":"src/tools/build-manifest/src/main.rs","position":55,"original_position":55,"commit_id":"729a87ede90e5fd4740743783a245432fc0a824e","original_commit_id":"729a87ede90e5fd4740743783a245432fc0a824e","user":{"login":"pietroalbini","id":2299951,"node_id":"MDQ6VXNlcjIyOTk5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"body":"Ok, no, with this change that bug would probably come up again. We need an explicit list of targets with docs and pass it [here](https://github.com/rust-lang/rust/blob/f1a5373a1b6222cf510d410f37278012b096fbfb/src/tools/build-manifest/src/main.rs#L321) instead of all the targets.","created_at":"2018-08-30T09:37:37Z","updated_at":"2018-08-30T09:37:37Z","html_url":"https://github.com/rust-lang/rust/pull/53803#discussion_r213965450","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/53803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/213965450"},"html":{"href":"https://github.com/rust-lang/rust/pull/53803#discussion_r213965450"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53803"}},"in_reply_to_id":213867777},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/53803","id":211887718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODg3NzE4","html_url":"https://github.com/rust-lang/rust/pull/53803","diff_url":"https://github.com/rust-lang/rust/pull/53803.diff","patch_url":"https://github.com/rust-lang/rust/pull/53803.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53803","number":53803,"state":"open","locked":false,"title":"Fix manifests for broken tools: take 2","user":{"login":"pietroalbini","id":2299951,"node_id":"MDQ6VXNlcjIyOTk5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"body":"This is a follow up of #53715, to avoid stripping unavailable components from the extensions list. This time I also figured out how to test the changes, so the produced manifest is correct.\r\n\r\nAlong with the fix I added a README with instructions on how to test the tool, and a new `BUILD_MANIFEST_DISABLE_SIGNING` env var to avoid dealing with gpg while testing the tool. I chose an env var instead of a flag because it's more difficult to have it slip in by accident on CI, and there is also another protection that panics if that env var is set on CI, just to be sure we don't release unsigned artifacts.\r\n\r\nr? @alexcrichton \r\ncc https://github.com/rust-lang-nursery/rustup.rs/issues/1486","created_at":"2018-08-29T21:07:35Z","updated_at":"2018-08-30T09:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9186ed7ae3684979008bf2e151690d500b82b839","assignee":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false},{"id":593503757,"node_id":"MDU6TGFiZWw1OTM1MDM3NTc=","url":"https://api.github.com/repos/rust-lang/rust/labels/T-infra","name":"T-infra","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/53803/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/53803/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53803/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/729a87ede90e5fd4740743783a245432fc0a824e","head":{"label":"pietroalbini:fix-manifest-2","ref":"fix-manifest-2","sha":"729a87ede90e5fd4740743783a245432fc0a824e","user":{"login":"pietroalbini","id":2299951,"node_id":"MDQ6VXNlcjIyOTk5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"repo":{"id":104113511,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQxMTM1MTE=","name":"rust","full_name":"pietroalbini/rust","owner":{"login":"pietroalbini","id":2299951,"node_id":"MDQ6VXNlcjIyOTk5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pietroalbini/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/pietroalbini/rust","forks_url":"https://api.github.com/repos/pietroalbini/rust/forks","keys_url":"https://api.github.com/repos/pietroalbini/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pietroalbini/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pietroalbini/rust/teams","hooks_url":"https://api.github.com/repos/pietroalbini/rust/hooks","issue_events_url":"https://api.github.com/repos/pietroalbini/rust/issues/events{/number}","events_url":"https://api.github.com/repos/pietroalbini/rust/events","assignees_url":"https://api.github.com/repos/pietroalbini/rust/assignees{/user}","branches_url":"https://api.github.com/repos/pietroalbini/rust/branches{/branch}","tags_url":"https://api.github.com/repos/pietroalbini/rust/tags","blobs_url":"https://api.github.com/repos/pietroalbini/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pietroalbini/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pietroalbini/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/pietroalbini/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pietroalbini/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/pietroalbini/rust/languages","stargazers_url":"https://api.github.com/repos/pietroalbini/rust/stargazers","contributors_url":"https://api.github.com/repos/pietroalbini/rust/contributors","subscribers_url":"https://api.github.com/repos/pietroalbini/rust/subscribers","subscription_url":"https://api.github.com/repos/pietroalbini/rust/subscription","commits_url":"https://api.github.com/repos/pietroalbini/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/pietroalbini/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/pietroalbini/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/pietroalbini/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/pietroalbini/rust/contents/{+path}","compare_url":"https://api.github.com/repos/pietroalbini/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pietroalbini/rust/merges","archive_url":"https://api.github.com/repos/pietroalbini/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pietroalbini/rust/downloads","issues_url":"https://api.github.com/repos/pietroalbini/rust/issues{/number}","pulls_url":"https://api.github.com/repos/pietroalbini/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/pietroalbini/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/pietroalbini/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pietroalbini/rust/labels{/name}","releases_url":"https://api.github.com/repos/pietroalbini/rust/releases{/id}","deployments_url":"https://api.github.com/repos/pietroalbini/rust/deployments","created_at":"2017-09-19T18:37:43Z","updated_at":"2018-07-18T19:26:03Z","pushed_at":"2018-08-29T21:02:02Z","git_url":"git://github.com/pietroalbini/rust.git","ssh_url":"git@github.com:pietroalbini/rust.git","clone_url":"https://github.com/pietroalbini/rust.git","svn_url":"https://github.com/pietroalbini/rust","homepage":"https://www.rust-lang.org","size":388791,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"e6b35b0e1115f008796e8313574e4a4739b6d39d","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-08-30T08:00:01Z","pushed_at":"2018-08-30T09:22:19Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":389748,"stargazers_count":30319,"watchers_count":30319,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5136,"mirror_url":null,"archived":false,"open_issues_count":4262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5136,"open_issues":4262,"watchers":30319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53803"},"html":{"href":"https://github.com/rust-lang/rust/pull/53803"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53803"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53803/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53803/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53803/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/729a87ede90e5fd4740743783a245432fc0a824e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pietroalbini"}}