{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/9604","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/9604/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/9604/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/9604/events","html_url":"https://github.com/librenms/librenms/issues/9604","id":395153191,"node_id":"MDU6SXNzdWUzOTUxNTMxOTE=","number":9604,"title":"Widget weirdness in 1.47, and previous dashboards seem to have been deleted","user":{"login":"fake-name","id":1401239,"node_id":"MDQ6VXNlcjE0MDEyMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1401239?v=4","gravatar_id":"","url":"https://api.github.com/users/fake-name","html_url":"https://github.com/fake-name","followers_url":"https://api.github.com/users/fake-name/followers","following_url":"https://api.github.com/users/fake-name/following{/other_user}","gists_url":"https://api.github.com/users/fake-name/gists{/gist_id}","starred_url":"https://api.github.com/users/fake-name/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fake-name/subscriptions","organizations_url":"https://api.github.com/users/fake-name/orgs","repos_url":"https://api.github.com/users/fake-name/repos","events_url":"https://api.github.com/users/fake-name/events{/privacy}","received_events_url":"https://api.github.com/users/fake-name/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2019-01-02T05:35:35Z","updated_at":"2019-01-04T07:52:15Z","closed_at":"2019-01-02T07:50:12Z","author_association":"NONE","body":"From the issue template:\r\n\r\n> Please do not post bugs \r\n\r\nUh, what? This is explicitly a bug tracker.\r\n\r\n-------\r\n\r\nApparently a new dashboard system has been released? Anyways, it appears it has deleted (or no longer obeys) my existing home-page config:\r\n\r\nSteps to replicate:\r\n\r\n1. Browse to local LibreNMS install\r\n2. Expect home landing page to still be there.\r\n\r\nI had previously configured the homepage graphs via editing `config.php`, e.g. `$config['frontpage']['minigraphs']['ids']    = <stuff>`\r\n\r\nApparently this isn't supported any more? Is there an actual migration path?\r\n\r\nI've looked through the recent changelogs, and I can't see anything that indicates this was changing, let alone that the old config interface was just going to explode.\r\n\r\n------\r\n\r\nAdditionally, the replacement widgets seem a bit rough about the edges:\r\n\r\n![image](https://user-images.githubusercontent.com/1401239/50580862-d524d980-0e08-11e9-9b4a-9a79a94e5c62.png)\r\n\r\nThis is a \"Top Devices\" widget thing, set to display traffic. You can expand the widget width, but the graphs don't expand to fit.\r\n\r\n<strike>Additionally, the widget is set to traffic, but the mouse-over pop-up graphs for each widget show CPU usage? If the widget is set to traffic, the mouse-over behaviour should also show traffic. It should behave the same for other settings (response time should show response time in mouseover, etc...).</strike>\r\n\r\nOk, this is still kind of true, but if you mouse over the *name*, you get the CPU stats, and if you mouse over the graph/bar-graph, you get selected value stats. That's pretty fiddly. I'd think it should always show the selected statistic, but I can see arguments each way.\r\n\r\n\r\n\r\n------\r\n\r\nIf you're editing a widget in the new interface, and you resize it, any unsaved changes to the widget config get erased. E.g:\r\n\r\n1. Configure widget. Don't hit \"save\" yet.\r\n2. Resize widget\r\n3. Whatever you configured then gets deleted.\r\n\r\n------\r\n\r\nAdditionally, there's some weird layout oddness:\r\n\r\n![image](https://user-images.githubusercontent.com/1401239/50581154-cdb2ff80-0e0b-11e9-87fd-5d73318fdba5.png)\r\n\r\nThis is two \"Top Devices\" widgets immediately adjacent to each other, one displaying CPU load and one displaying free disk space. For some reason, the line height for the CPU widget is slightly greater then the line height for the disk space widget. That means there's a visual disconnect between the two adjacent widgets, and the CPU widget is forced to have a scroll bar.\r\n\r\n------\r\n\r\nI don't have a screenshot, but I've also managed to completely brain the drag-and-drop interface, and somehow get multiple widgets to be overlayed on top of each other.\r\n\r\n------\r\n\r\n![image](https://user-images.githubusercontent.com/1401239/50581247-dbb55000-0e0c-11e9-8d8e-f23e2f29da9f.png)\r\n\r\nThe \"Top Interfaces\" widget has a **giant** title (that you can't turn off). The \"Top Devices\" widget has no title. \r\n\r\nAdditionally, you can set the top-bar text for the top devices widget, but not the top interfaces widget.\r\n\r\n------\r\n\r\n![image](https://user-images.githubusercontent.com/1401239/50581445-a447a300-0e0e-11e9-8d60-66c374eb12c3.png)\r\n\r\nThe entries for the \"Device\" combobox are sorted by *some order*. I legitimately don't know why they're the order they're in, but it's not lexicographical, natural or alphabetical (is it device addition order?), but it seems to be repeatable.\r\n\r\nIt'd make sense to me if they were sorted something like [natural order](https://en.wikipedia.org/wiki/Natural_sort_order).\r\n\r\nRelated: https://github.com/librenms/librenms/issues/9605\r\n\r\n------\r\n\r\nIn general (after fiddling with it for a while), the new widget system is pretty swish, but I wish there was a migration route so I didn't find out that the config interface was being replaced by going to my local LibreNMS install and finding the previous config I had was deleted.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/451374053","html_url":"https://github.com/librenms/librenms/issues/9604#issuecomment-451374053","issue_url":"https://api.github.com/repos/librenms/librenms/issues/9604","id":451374053,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTM3NDA1Mw==","user":{"login":"fake-name","id":1401239,"node_id":"MDQ6VXNlcjE0MDEyMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1401239?v=4","gravatar_id":"","url":"https://api.github.com/users/fake-name","html_url":"https://github.com/fake-name","followers_url":"https://api.github.com/users/fake-name/followers","following_url":"https://api.github.com/users/fake-name/following{/other_user}","gists_url":"https://api.github.com/users/fake-name/gists{/gist_id}","starred_url":"https://api.github.com/users/fake-name/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fake-name/subscriptions","organizations_url":"https://api.github.com/users/fake-name/orgs","repos_url":"https://api.github.com/users/fake-name/repos","events_url":"https://api.github.com/users/fake-name/events{/privacy}","received_events_url":"https://api.github.com/users/fake-name/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T07:52:15Z","updated_at":"2019-01-04T07:52:15Z","author_association":"NONE","body":"> it is built in search, \r\n\r\nThat doesn't help when you're using a normal search engine much now, does it?\r\n\r\nBeing able to find where to go to find an answer when you're already where you need to go to find the answer is useless. \r\n\r\nThe point is discord is completely undiscoverable from the perspective of basically everywhere on the internet *but* discord. I don't think anyone on encountering an issue thinks \"I'll search an obnoxious JS-bloated proprietary garbage chat service most known for hosting hordes of annoying \"l33t g4m3r\" kids and grossly abusing what the word \"server\" means\".   \r\n\r\nThey use a normal search engine.\r\n\r\n------\r\n\r\n1. I don't think LibreNMS has ever supported $config['frontpage']['minigraphs']['ids'] I searched the git history.\r\n2. It sounds like you were using some other frontpage before and switched to the widget based \"tiles\" frontpage. Nothing was deleted.\r\n\r\nThis was set up a *long* time ago. It was before the home page *was* configurable (because I remember having to fiddle with stuff to change it). Looking about, it appears to [date back to before the observium fork](https://observium.observium.narkive.com/eozXBE77/front-page). \r\n\r\nGiven that, I'm not surprised no one remembers it. I'm surprised it kept working, frankly. I suspect that maybe there was a importer at some time in the ancient past, and it created a new dashboard or something, and then the recent rework displaced it or something. Digging through ancient git history, I have no idea what's going on either.\r\n\r\nAll I know is about 2 weeks ago, the old dashboard config was working fine. 3 days ago, it no longer was. The server this all runs on *might* have had `apt-get dist-upgrade -y` run on it in the interim, but I touched nothing else (I hadn't `ssh`'ed into it for *months* (I use landscape to apply updates)), so ¯\\_(ツ)_/¯\r\n\r\nAnyways, the dashboard changing is probably specific to my extremely oddball setup. \r\n\r\nActually, that's another interesting, possibly useful idea: Warn about config stuff that doesn't do anything. I bet I have other legacy crap in my config, and I may not be the only person.\r\n\r\n------\r\n\r\n> 3. 90% of the issues you mention existed before 1.47 and are bugs in the js library LibreNMS uses. I posted patches for the others already.\r\n\r\nTo be honest, I wasn't aware you could edit dashboards before just now. \r\n\r\nSo reporting bugs on the bug tracker *does* work. \r\n\r\n"}}
{"actor":{"display_login":"fake-name"}}