{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments/235915762","pull_request_review_id":177894272,"id":235915762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkxNTc2Mg==","diff_hunk":"@@ -34,6 +41,7 @@ export abstract class CmsModuleConfig extends OccConfig\n   };\n \n   cmsComponentMapping?: CMSComponentMappingConfig;\n+  cmsComponentProviders?: CMSComponentProviders;","path":"projects/storefrontlib/src/lib/cms/cms-module-config.ts","position":56,"original_position":56,"commit_id":"18fca55bce3c595e5d5b92bd521f068e10a52e22","original_commit_id":"18fca55bce3c595e5d5b92bd521f068e10a52e22","user":{"login":"tobi-or-not-tobi","id":4745807,"node_id":"MDQ6VXNlcjQ3NDU4MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4745807?v=4","gravatar_id":"","url":"https://api.github.com/users/tobi-or-not-tobi","html_url":"https://github.com/tobi-or-not-tobi","followers_url":"https://api.github.com/users/tobi-or-not-tobi/followers","following_url":"https://api.github.com/users/tobi-or-not-tobi/following{/other_user}","gists_url":"https://api.github.com/users/tobi-or-not-tobi/gists{/gist_id}","starred_url":"https://api.github.com/users/tobi-or-not-tobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobi-or-not-tobi/subscriptions","organizations_url":"https://api.github.com/users/tobi-or-not-tobi/orgs","repos_url":"https://api.github.com/users/tobi-or-not-tobi/repos","events_url":"https://api.github.com/users/tobi-or-not-tobi/events{/privacy}","received_events_url":"https://api.github.com/users/tobi-or-not-tobi/received_events","type":"User","site_admin":false},"body":"One of the ideas that I had earlier this week (forgot to tell), is to combine the configuration of the component mapping and component providers in one object. The config would have a typing that allows for both as an optional property. I believe it simplifies configuration as well as its' all more connected when you customise. ","created_at":"2018-11-23T11:37:39Z","updated_at":"2018-11-23T11:39:57Z","html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375#discussion_r235915762","pull_request_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments/235915762"},"html":{"href":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375#discussion_r235915762"},"pull_request":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375","id":232980425,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTgwNDI1","html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375","diff_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375.diff","patch_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375.patch","issue_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/375","number":375,"state":"open","locked":false,"title":"GH-300: Comfigurable cmsComponentProviders","user":{"login":"dunqan","id":5839835,"node_id":"MDQ6VXNlcjU4Mzk4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5839835?v=4","gravatar_id":"","url":"https://api.github.com/users/dunqan","html_url":"https://github.com/dunqan","followers_url":"https://api.github.com/users/dunqan/followers","following_url":"https://api.github.com/users/dunqan/following{/other_user}","gists_url":"https://api.github.com/users/dunqan/gists{/gist_id}","starred_url":"https://api.github.com/users/dunqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunqan/subscriptions","organizations_url":"https://api.github.com/users/dunqan/orgs","repos_url":"https://api.github.com/users/dunqan/repos","events_url":"https://api.github.com/users/dunqan/events{/privacy}","received_events_url":"https://api.github.com/users/dunqan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-22T13:30:43Z","updated_at":"2018-11-23T11:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d10e7af9d993e2d3df5dd6ad5f7422f4047e9d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375/commits","review_comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375/comments","review_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/375/comments","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/18fca55bce3c595e5d5b92bd521f068e10a52e22","head":{"label":"SAP:feature/GH-300","ref":"feature/GH-300","sha":"18fca55bce3c595e5d5b92bd521f068e10a52e22","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":149351199,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTExOTk=","name":"cloud-commerce-spartacus-storefront","full_name":"SAP/cloud-commerce-spartacus-storefront","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","description":"Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.","fork":false,"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront","forks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/forks","keys_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/events","assignees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/merges","archive_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/deployments","created_at":"2018-09-18T20:56:49Z","updated_at":"2018-11-22T20:55:50Z","pushed_at":"2018-11-23T09:09:51Z","git_url":"git://github.com/SAP/cloud-commerce-spartacus-storefront.git","ssh_url":"git@github.com:SAP/cloud-commerce-spartacus-storefront.git","clone_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront.git","svn_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","homepage":"","size":12104,"stargazers_count":87,"watchers_count":87,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":191,"watchers":87,"default_branch":"develop"}},"base":{"label":"SAP:develop","ref":"develop","sha":"d2a8c649a5a502bc80f223315bbedd7ebb738fd8","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":149351199,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTExOTk=","name":"cloud-commerce-spartacus-storefront","full_name":"SAP/cloud-commerce-spartacus-storefront","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","description":"Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.","fork":false,"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront","forks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/forks","keys_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/events","assignees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/merges","archive_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/deployments","created_at":"2018-09-18T20:56:49Z","updated_at":"2018-11-22T20:55:50Z","pushed_at":"2018-11-23T09:09:51Z","git_url":"git://github.com/SAP/cloud-commerce-spartacus-storefront.git","ssh_url":"git@github.com:SAP/cloud-commerce-spartacus-storefront.git","clone_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront.git","svn_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","homepage":"","size":12104,"stargazers_count":87,"watchers_count":87,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":191,"watchers":87,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375"},"html":{"href":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/375"},"issue":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/375"},"comments":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/18fca55bce3c595e5d5b92bd521f068e10a52e22"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tobi-or-not-tobi"}}