{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments/196217270","pull_request_review_id":129729195,"id":196217270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjIxNzI3MA==","diff_hunk":"@@ -0,0 +1,164 @@\n+####################\n+# CircleCI configuration reference:\n+#   https://circleci.com/docs/2.0/configuration-reference\n+####################\n+# CircleCI built-in environment variables:\n+#   https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables\n+####################\n+\n+\n+####################\n+# Templates: see \"anchors\" in https://learnxinyminutes.com/docs/yaml/\n+####################\n+\n+# See available image tags at https://hub.docker.com/r/mozilla/sbt/\n+sbt_image: &sbt_image mozilla/sbt:8u171_1.1.6\n+\n+# The ~/.sbt directory holds any sbt or Scala versions requested by previous builds.\n+# The ~/.ivy2 directory holds Java and Scala dependencies declared in the build.\n+# Caching these two can significantly reduce sbt startup time.\n+save_cache_settings: &save_cache_settings\n+  key: telemetry-batch-view-{{ .Branch }}-{{ .Environment.CIRCLE_WORKFLOW_ID }}\n+  paths:\n+    - ~/.ivy2\n+    - ~/.sbt\n+\n+prep_cache_settings: &prep_cache_settings\n+  name: Clean directories to restore\n+  command: |\n+    rm -r ~/.ivy2 ~/.sbt\n+\n+restore_cache_settings: &restore_cache_settings\n+  keys:\n+    - telemetry-batch-view-{{ .Branch }}-{{ .Environment.CIRCLE_WORKFLOW_ID }}\n+    - telemetry-batch-view-{{ .Branch }}\n+    - telemetry-batch-view-\n+\n+# At time of writing, we use the default container size (2 CPUs and 4GB memory),\n+# but may renogotiate with CircleCI and enable larger resource_class\n+# options at which point we might want to bump up the Java memory settings\n+# and reduce the test parallelism.\n+test_settings: &test_settings\n+  docker:\n+    - image: *sbt_image\n+      environment:\n+        _JAVA_OPTIONS: \"-Xms3G -Xmx3G -Xss4M -XX:MaxMetaspaceSize=512M\"\n+  working_directory: /telemetry-batch-view","path":".circleci/config.yml","position":46,"original_position":46,"commit_id":"a786f145f547b7dd1368361daad08a2784469f01","original_commit_id":"a786f145f547b7dd1368361daad08a2784469f01","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"This section provides what used to be in the Dockerfile","created_at":"2018-06-18T20:39:09Z","updated_at":"2018-06-18T20:39:09Z","html_url":"https://github.com/mozilla/telemetry-batch-view/pull/440#discussion_r196217270","pull_request_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments/196217270"},"html":{"href":"https://github.com/mozilla/telemetry-batch-view/pull/440#discussion_r196217270"},"pull_request":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440","id":195310526,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzEwNTI2","html_url":"https://github.com/mozilla/telemetry-batch-view/pull/440","diff_url":"https://github.com/mozilla/telemetry-batch-view/pull/440.diff","patch_url":"https://github.com/mozilla/telemetry-batch-view/pull/440.patch","issue_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/440","number":440,"state":"open","locked":false,"title":"WIP: CircleCI","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"This consolidates us down to one CI provider for t-b-v and takes\r\nadvantage of CircleCI's more powerful machinery for defining workflows\r\nwith parallel jobs and shared files between them.\r\n\r\nWe eliminate the Scalatest tags we previously used to manually assign\r\ntest cases to different build jobs. We now split up tests by source file\r\nand use CircleCI's 'parallelize' config option to reliably assign them\r\nto jobs.\r\n\r\nWe also eliminate the concept of git tags for controlling deploys,\r\nas discussed during All Hands week. We always upload a successful\r\nbuild as the current jar for the branch. This means now that whatever\r\nhits `master` will be what's running in production.\r\n\r\nThe local workflow is simplified somewhat by no longer building a docker\r\nimage specific to this project, but rather relying on the mozilla/sbt\r\nimage.\r\n\r\nThis CircleCI configuration runs a bit faster and with better consistency\r\n(9 to 10 minutes) compared to the current TravisCI configuration\r\n(12 minutes to 20 minutes).","created_at":"2018-06-16T01:18:29Z","updated_at":"2018-06-18T20:39:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa6d698fc8682c30b792a261408ae90578e27bd0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fbertsch","id":20819040,"node_id":"MDQ6VXNlcjIwODE5MDQw","avatar_url":"https://avatars1.githubusercontent.com/u/20819040?v=4","gravatar_id":"","url":"https://api.github.com/users/fbertsch","html_url":"https://github.com/fbertsch","followers_url":"https://api.github.com/users/fbertsch/followers","following_url":"https://api.github.com/users/fbertsch/following{/other_user}","gists_url":"https://api.github.com/users/fbertsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fbertsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbertsch/subscriptions","organizations_url":"https://api.github.com/users/fbertsch/orgs","repos_url":"https://api.github.com/users/fbertsch/repos","events_url":"https://api.github.com/users/fbertsch/events{/privacy}","received_events_url":"https://api.github.com/users/fbertsch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440/commits","review_comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440/comments","review_comment_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/440/comments","statuses_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/a786f145f547b7dd1368361daad08a2784469f01","head":{"label":"jklukas:circleci","ref":"circleci","sha":"a786f145f547b7dd1368361daad08a2784469f01","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"repo":{"id":134450755,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NTA3NTU=","name":"telemetry-batch-view","full_name":"jklukas/telemetry-batch-view","owner":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklukas/telemetry-batch-view","description":"A Scala framework to build derived datasets, aka batch views, of Telemetry data.","fork":true,"url":"https://api.github.com/repos/jklukas/telemetry-batch-view","forks_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/forks","keys_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/teams","hooks_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/hooks","issue_events_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/issues/events{/number}","events_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/events","assignees_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/assignees{/user}","branches_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/branches{/branch}","tags_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/tags","blobs_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/statuses/{sha}","languages_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/languages","stargazers_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/stargazers","contributors_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/contributors","subscribers_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/subscribers","subscription_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/subscription","commits_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/contents/{+path}","compare_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/merges","archive_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/downloads","issues_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/issues{/number}","pulls_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/pulls{/number}","milestones_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/milestones{/number}","notifications_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/labels{/name}","releases_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/releases{/id}","deployments_url":"https://api.github.com/repos/jklukas/telemetry-batch-view/deployments","created_at":"2018-05-22T17:25:00Z","updated_at":"2018-05-22T17:25:02Z","pushed_at":"2018-06-18T20:25:37Z","git_url":"git://github.com/jklukas/telemetry-batch-view.git","ssh_url":"git@github.com:jklukas/telemetry-batch-view.git","clone_url":"https://github.com/jklukas/telemetry-batch-view.git","svn_url":"https://github.com/jklukas/telemetry-batch-view","homepage":"","size":1782,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"14741db20dd3873b94944b8238dfc48a003c744d","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":44998549,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODU0OQ==","name":"telemetry-batch-view","full_name":"mozilla/telemetry-batch-view","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/telemetry-batch-view","description":"A Scala framework to build derived datasets, aka batch views, of Telemetry data.","fork":false,"url":"https://api.github.com/repos/mozilla/telemetry-batch-view","forks_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/forks","keys_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/teams","hooks_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/hooks","issue_events_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/events","assignees_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/tags","blobs_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/languages","stargazers_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/stargazers","contributors_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/contributors","subscribers_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/subscribers","subscription_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/subscription","commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/merges","archive_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/downloads","issues_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/deployments","created_at":"2015-10-26T21:29:57Z","updated_at":"2018-06-18T05:08:43Z","pushed_at":"2018-06-18T20:25:38Z","git_url":"git://github.com/mozilla/telemetry-batch-view.git","ssh_url":"git@github.com:mozilla/telemetry-batch-view.git","clone_url":"https://github.com/mozilla/telemetry-batch-view.git","svn_url":"https://github.com/mozilla/telemetry-batch-view","homepage":"","size":12150,"stargazers_count":28,"watchers_count":28,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":47,"open_issues":4,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440"},"html":{"href":"https://github.com/mozilla/telemetry-batch-view/pull/440"},"issue":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/440"},"comments":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/a786f145f547b7dd1368361daad08a2784469f01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jklukas"}}