{"action":"created","comment":{"url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/comments/235641259","pull_request_review_id":177551317,"id":235641259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY0MTI1OQ==","diff_hunk":"@@ -0,0 +1,124 @@\n+//\n+//  ReadAppInformation.swift\n+//  AppStoreConnect-Swift-SDK\n+//\n+//  Created by Pascal Edmond on 20/11/2018.\n+//\n+\n+import Alamofire\n+\n+extension APIEndpoint {\n+    \n+    /// Get information about a specific app.\n+    ///\n+    /// - Parameters:\n+    ///   - id: An opaque resource ID that uniquely identifies the resource.\n+    ///   - fields: Fields to return for included related types.\n+    ///   - relationships: Relationship data to include in the response.\n+    ///   - limits: Number of included related resources to return.\n+    public static func app(\n+        with id: String,\n+        select fields: [ReadAppInformation.Field]? = nil,\n+        include relationships: [ReadAppInformation.Relationship]? = nil,\n+        limits: [ReadAppInformation.Limit]? = nil) -> APIEndpoint<AppResponse> {\n+        var parameters = [String: Any]()\n+        if let fields = fields { parameters.merge(with: fields) }\n+        if let relationships = relationships { parameters.merge(with: relationships) }\n+        if let limits = limits { parameters.merge(with: limits) }\n+        return APIEndpoint<AppResponse>(path: \"apps/\\(id)\", method: .get, parameters: parameters)","path":"Sources/Endpoints/TestFlight/Apps/GetAppInformation.swift","position":28,"original_position":28,"commit_id":"28638066228fb23c9a99b8aef0b336289be4c744","original_commit_id":"28638066228fb23c9a99b8aef0b336289be4c744","user":{"login":"AvdLee","id":4329185,"node_id":"MDQ6VXNlcjQzMjkxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4329185?v=4","gravatar_id":"","url":"https://api.github.com/users/AvdLee","html_url":"https://github.com/AvdLee","followers_url":"https://api.github.com/users/AvdLee/followers","following_url":"https://api.github.com/users/AvdLee/following{/other_user}","gists_url":"https://api.github.com/users/AvdLee/gists{/gist_id}","starred_url":"https://api.github.com/users/AvdLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvdLee/subscriptions","organizations_url":"https://api.github.com/users/AvdLee/orgs","repos_url":"https://api.github.com/users/AvdLee/repos","events_url":"https://api.github.com/users/AvdLee/events{/privacy}","received_events_url":"https://api.github.com/users/AvdLee/received_events","type":"User","site_admin":false},"body":"Can we write tests for this to verify the outcoming request?","created_at":"2018-11-22T08:49:39Z","updated_at":"2018-11-22T08:49:39Z","html_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24#discussion_r235641259","pull_request_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/comments/235641259"},"html":{"href":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24#discussion_r235641259"},"pull_request":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24","id":232619410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjE5NDEw","html_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24","diff_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24.diff","patch_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24.patch","issue_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/24","number":24,"state":"open","locked":false,"title":"List apps request","user":{"login":"pakko972","id":27460,"node_id":"MDQ6VXNlcjI3NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/27460?v=4","gravatar_id":"","url":"https://api.github.com/users/pakko972","html_url":"https://github.com/pakko972","followers_url":"https://api.github.com/users/pakko972/followers","following_url":"https://api.github.com/users/pakko972/following{/other_user}","gists_url":"https://api.github.com/users/pakko972/gists{/gist_id}","starred_url":"https://api.github.com/users/pakko972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakko972/subscriptions","organizations_url":"https://api.github.com/users/pakko972/orgs","repos_url":"https://api.github.com/users/pakko972/repos","events_url":"https://api.github.com/users/pakko972/events{/privacy}","received_events_url":"https://api.github.com/users/pakko972/received_events","type":"User","site_admin":false},"body":"- Adds fully implemented Endpoints `.apps` & `.app`:\r\n    ```swift\r\n    provider.request(.apps(\r\n        select: [.apps([.name]), .builds([.version, .processingState, .uploadedDate])],\r\n        include: [.builds],\r\n        sortBy: [.ascending(.bundleId)],\r\n        limits: [.apps(2)])) {\r\n        // Use result here\r\n    }\r\n    ```\r\n- `ResourceLinks` is now generic, it conveys the expected response type of the request.\r\n- Introduces `Sorting` type\r\n- The API does not accept query parameters like this `apps?include=betaGroups&include=builds`, so we now manually encode them to be like this `apps?include=betaGroups,builds`\r\n","created_at":"2018-11-21T10:55:13Z","updated_at":"2018-11-22T08:49:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a9f0092d1068d04dd4d780dcedc3cefdfaa4286","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24/commits","review_comments_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24/comments","review_comment_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/24/comments","statuses_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/statuses/28638066228fb23c9a99b8aef0b336289be4c744","head":{"label":"pakko972:list-apps-request","ref":"list-apps-request","sha":"28638066228fb23c9a99b8aef0b336289be4c744","user":{"login":"pakko972","id":27460,"node_id":"MDQ6VXNlcjI3NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/27460?v=4","gravatar_id":"","url":"https://api.github.com/users/pakko972","html_url":"https://github.com/pakko972","followers_url":"https://api.github.com/users/pakko972/followers","following_url":"https://api.github.com/users/pakko972/following{/other_user}","gists_url":"https://api.github.com/users/pakko972/gists{/gist_id}","starred_url":"https://api.github.com/users/pakko972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakko972/subscriptions","organizations_url":"https://api.github.com/users/pakko972/orgs","repos_url":"https://api.github.com/users/pakko972/repos","events_url":"https://api.github.com/users/pakko972/events{/privacy}","received_events_url":"https://api.github.com/users/pakko972/received_events","type":"User","site_admin":false},"repo":{"id":156680891,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY2ODA4OTE=","name":"appstoreconnect-swift-sdk","full_name":"pakko972/appstoreconnect-swift-sdk","private":false,"owner":{"login":"pakko972","id":27460,"node_id":"MDQ6VXNlcjI3NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/27460?v=4","gravatar_id":"","url":"https://api.github.com/users/pakko972","html_url":"https://github.com/pakko972","followers_url":"https://api.github.com/users/pakko972/followers","following_url":"https://api.github.com/users/pakko972/following{/other_user}","gists_url":"https://api.github.com/users/pakko972/gists{/gist_id}","starred_url":"https://api.github.com/users/pakko972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakko972/subscriptions","organizations_url":"https://api.github.com/users/pakko972/orgs","repos_url":"https://api.github.com/users/pakko972/repos","events_url":"https://api.github.com/users/pakko972/events{/privacy}","received_events_url":"https://api.github.com/users/pakko972/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pakko972/appstoreconnect-swift-sdk","description":"The Swift SDK to work with the App Store Connect API from Apple.","fork":true,"url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk","forks_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/forks","keys_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/teams","hooks_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/events","assignees_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/tags","blobs_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/languages","stargazers_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/subscription","commits_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/merges","archive_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/downloads","issues_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/pakko972/appstoreconnect-swift-sdk/deployments","created_at":"2018-11-08T09:18:59Z","updated_at":"2018-11-21T09:54:30Z","pushed_at":"2018-11-21T10:21:18Z","git_url":"git://github.com/pakko972/appstoreconnect-swift-sdk.git","ssh_url":"git@github.com:pakko972/appstoreconnect-swift-sdk.git","clone_url":"https://github.com/pakko972/appstoreconnect-swift-sdk.git","svn_url":"https://github.com/pakko972/appstoreconnect-swift-sdk","homepage":null,"size":292,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AvdLee:master","ref":"master","sha":"73c1c823aa8e13df6131317be5949fa25785ca18","user":{"login":"AvdLee","id":4329185,"node_id":"MDQ6VXNlcjQzMjkxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4329185?v=4","gravatar_id":"","url":"https://api.github.com/users/AvdLee","html_url":"https://github.com/AvdLee","followers_url":"https://api.github.com/users/AvdLee/followers","following_url":"https://api.github.com/users/AvdLee/following{/other_user}","gists_url":"https://api.github.com/users/AvdLee/gists{/gist_id}","starred_url":"https://api.github.com/users/AvdLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvdLee/subscriptions","organizations_url":"https://api.github.com/users/AvdLee/orgs","repos_url":"https://api.github.com/users/AvdLee/repos","events_url":"https://api.github.com/users/AvdLee/events{/privacy}","received_events_url":"https://api.github.com/users/AvdLee/received_events","type":"User","site_admin":false},"repo":{"id":156271126,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYyNzExMjY=","name":"appstoreconnect-swift-sdk","full_name":"AvdLee/appstoreconnect-swift-sdk","private":false,"owner":{"login":"AvdLee","id":4329185,"node_id":"MDQ6VXNlcjQzMjkxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4329185?v=4","gravatar_id":"","url":"https://api.github.com/users/AvdLee","html_url":"https://github.com/AvdLee","followers_url":"https://api.github.com/users/AvdLee/followers","following_url":"https://api.github.com/users/AvdLee/following{/other_user}","gists_url":"https://api.github.com/users/AvdLee/gists{/gist_id}","starred_url":"https://api.github.com/users/AvdLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvdLee/subscriptions","organizations_url":"https://api.github.com/users/AvdLee/orgs","repos_url":"https://api.github.com/users/AvdLee/repos","events_url":"https://api.github.com/users/AvdLee/events{/privacy}","received_events_url":"https://api.github.com/users/AvdLee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk","description":"The Swift SDK to work with the App Store Connect API from Apple.","fork":false,"url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk","forks_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/forks","keys_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/teams","hooks_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/events","assignees_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/tags","blobs_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/languages","stargazers_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/subscription","commits_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/merges","archive_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/downloads","issues_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/deployments","created_at":"2018-11-05T19:27:31Z","updated_at":"2018-11-22T07:06:06Z","pushed_at":"2018-11-21T10:55:14Z","git_url":"git://github.com/AvdLee/appstoreconnect-swift-sdk.git","ssh_url":"git@github.com:AvdLee/appstoreconnect-swift-sdk.git","clone_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk.git","svn_url":"https://github.com/AvdLee/appstoreconnect-swift-sdk","homepage":null,"size":269,"stargazers_count":231,"watchers_count":231,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":5,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24"},"html":{"href":"https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/24"},"issue":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/24"},"comments":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/AvdLee/appstoreconnect-swift-sdk/statuses/28638066228fb23c9a99b8aef0b336289be4c744"}},"author_association":"NONE"}}
{"actor":{"display_login":"AvdLee"}}