{"action":"created","issue":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1232","repository_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1232/labels{/name}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1232/comments","events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1232/events","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/issues/1232","id":353192607,"node_id":"MDU6SXNzdWUzNTMxOTI2MDc=","number":1232,"title":"Use expectEvent to test logs","user":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"labels":[{"id":1000188800,"node_id":"MDU6TGFiZWwxMDAwMTg4ODAw","url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels/area:tests","name":"area:tests","color":"1d76db","default":false},{"id":503650966,"node_id":"MDU6TGFiZWw1MDM2NTA5NjY=","url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels/good%20first%20issue","name":"good first issue","color":"0e8a16","default":true},{"id":662145211,"node_id":"MDU6TGFiZWw2NjIxNDUyMTE=","url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels/kind:improvement","name":"kind:improvement","color":"b9db64","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones/4","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/milestone/4","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones/4/labels","id":3563304,"node_id":"MDk6TWlsZXN0b25lMzU2MzMwNA==","number":4,"title":"v2.1","description":"Bundling of test suite (incl. suite improvements, testing of the suite, testing guide)","creator":{"login":"frangio","id":481465,"node_id":"MDQ6VXNlcjQ4MTQ2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/481465?v=4","gravatar_id":"","url":"https://api.github.com/users/frangio","html_url":"https://github.com/frangio","followers_url":"https://api.github.com/users/frangio/followers","following_url":"https://api.github.com/users/frangio/following{/other_user}","gists_url":"https://api.github.com/users/frangio/gists{/gist_id}","starred_url":"https://api.github.com/users/frangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frangio/subscriptions","organizations_url":"https://api.github.com/users/frangio/orgs","repos_url":"https://api.github.com/users/frangio/repos","events_url":"https://api.github.com/users/frangio/events{/privacy}","received_events_url":"https://api.github.com/users/frangio/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":10,"state":"open","created_at":"2018-08-12T19:24:59Z","updated_at":"2018-09-18T22:54:28Z","due_on":"2018-10-15T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-08-23T02:06:33Z","updated_at":"2018-09-19T15:27:01Z","closed_at":null,"author_association":"MEMBER","body":"Most log tests directly access the log array: we should instead use the `expectEvent` helper to do that.\r\n\r\nExample from the `Escrow` tests:\r\n\r\n```\r\nconst { logs } = await this.escrow.deposit(payee1, { from: owner, value: amount });\r\nexpectEvent.inLogs(logs, 'Deposited', { payee: payee1 });\r\n```\r\n\r\nPart of #1091.\r\nRequires https://github.com/OpenZeppelin/openzeppelin-solidity/issues/1026."},"comment":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/comments/422846751","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/issues/1232#issuecomment-422846751","issue_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1232","id":422846751,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjg0Njc1MQ==","user":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T15:27:01Z","updated_at":"2018-09-19T15:27:01Z","author_association":"MEMBER","body":"Hey there @jbogacz! You're absolutely right, `expectEvent` doesn't work properly with `BigNumber` values, which is why some of the tests mix both styles (e.g. they use `expectEvent` for event name, account, etc, but then test the values separetely). We actually have a separate issue for this: https://github.com/OpenZeppelin/openzeppelin-solidity/issues/1026, if you can open a PR with your change to the test helper, that'd be amazing!"}}
{"actor":{"display_login":"nventuro"}}