{"action":"created","comment":{"url":"https://api.github.com/repos/beaufour/flickr-download/pulls/comments/233421399","pull_request_review_id":174828309,"id":233421399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzQyMTM5OQ==","diff_hunk":"@@ -255,7 +267,7 @@ def print_sets(username):\n     @param username: str,\n     \"\"\"\n     with Timer('findByUserName()'):","path":"flickr_download/flick_download.py","position":40,"original_position":40,"commit_id":"53e98e6cd08b18aaa9f0639a5b81b158143cde60","original_commit_id":"53e98e6cd08b18aaa9f0639a5b81b158143cde60","user":{"login":"beaufour","id":239545,"node_id":"MDQ6VXNlcjIzOTU0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/239545?v=4","gravatar_id":"","url":"https://api.github.com/users/beaufour","html_url":"https://github.com/beaufour","followers_url":"https://api.github.com/users/beaufour/followers","following_url":"https://api.github.com/users/beaufour/following{/other_user}","gists_url":"https://api.github.com/users/beaufour/gists{/gist_id}","starred_url":"https://api.github.com/users/beaufour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaufour/subscriptions","organizations_url":"https://api.github.com/users/beaufour/orgs","repos_url":"https://api.github.com/users/beaufour/repos","events_url":"https://api.github.com/users/beaufour/events{/privacy}","received_events_url":"https://api.github.com/users/beaufour/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    with Timer('find_user()'):\r\n```\r\n","created_at":"2018-11-14T12:10:55Z","updated_at":"2018-11-14T12:10:55Z","html_url":"https://github.com/beaufour/flickr-download/pull/43#discussion_r233421399","pull_request_url":"https://api.github.com/repos/beaufour/flickr-download/pulls/43","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/comments/233421399"},"html":{"href":"https://github.com/beaufour/flickr-download/pull/43#discussion_r233421399"},"pull_request":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/beaufour/flickr-download/pulls/43","id":230760815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzYwODE1","html_url":"https://github.com/beaufour/flickr-download/pull/43","diff_url":"https://github.com/beaufour/flickr-download/pull/43.diff","patch_url":"https://github.com/beaufour/flickr-download/pull/43.patch","issue_url":"https://api.github.com/repos/beaufour/flickr-download/issues/43","number":43,"state":"open","locked":false,"title":"Allow to use profile URL or email instead of username","user":{"login":"astanin","id":71802,"node_id":"MDQ6VXNlcjcxODAy","avatar_url":"https://avatars2.githubusercontent.com/u/71802?v=4","gravatar_id":"","url":"https://api.github.com/users/astanin","html_url":"https://github.com/astanin","followers_url":"https://api.github.com/users/astanin/followers","following_url":"https://api.github.com/users/astanin/following{/other_user}","gists_url":"https://api.github.com/users/astanin/gists{/gist_id}","starred_url":"https://api.github.com/users/astanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astanin/subscriptions","organizations_url":"https://api.github.com/users/astanin/orgs","repos_url":"https://api.github.com/users/astanin/repos","events_url":"https://api.github.com/users/astanin/events{/privacy}","received_events_url":"https://api.github.com/users/astanin/received_events","type":"User","site_admin":false},"body":"It appears that some users cannot be found by findByUserName();\r\nAPI returns error code 1. Such users can still be referenced by\r\ntheir email or URL.\r\n\r\nProposed change: use findByEmail and findByUrl methods instead of\r\nfindByUserName if the given username appears to be an email (contains `@`)\r\nor a URL (starts with `https://`, `www.flickr.com`, or `flickr.com`.).\r\n\r\nPotential issues: users having @ in their username may have to use\r\nURL of their profile instead.\r\n\r\nP.S. This is the same as the closed pull request #40, but now from a feature branch.","created_at":"2018-11-14T09:17:33Z","updated_at":"2018-11-14T12:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d803a1e159f90e4fe5880d4b4e670585688169fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/beaufour/flickr-download/pulls/43/commits","review_comments_url":"https://api.github.com/repos/beaufour/flickr-download/pulls/43/comments","review_comment_url":"https://api.github.com/repos/beaufour/flickr-download/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beaufour/flickr-download/issues/43/comments","statuses_url":"https://api.github.com/repos/beaufour/flickr-download/statuses/53e98e6cd08b18aaa9f0639a5b81b158143cde60","head":{"label":"astanin:feature/profile-urls-as-id","ref":"feature/profile-urls-as-id","sha":"53e98e6cd08b18aaa9f0639a5b81b158143cde60","user":{"login":"astanin","id":71802,"node_id":"MDQ6VXNlcjcxODAy","avatar_url":"https://avatars2.githubusercontent.com/u/71802?v=4","gravatar_id":"","url":"https://api.github.com/users/astanin","html_url":"https://github.com/astanin","followers_url":"https://api.github.com/users/astanin/followers","following_url":"https://api.github.com/users/astanin/following{/other_user}","gists_url":"https://api.github.com/users/astanin/gists{/gist_id}","starred_url":"https://api.github.com/users/astanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astanin/subscriptions","organizations_url":"https://api.github.com/users/astanin/orgs","repos_url":"https://api.github.com/users/astanin/repos","events_url":"https://api.github.com/users/astanin/events{/privacy}","received_events_url":"https://api.github.com/users/astanin/received_events","type":"User","site_admin":false},"repo":{"id":156247447,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYyNDc0NDc=","name":"flickr-download","full_name":"astanin/flickr-download","private":false,"owner":{"login":"astanin","id":71802,"node_id":"MDQ6VXNlcjcxODAy","avatar_url":"https://avatars2.githubusercontent.com/u/71802?v=4","gravatar_id":"","url":"https://api.github.com/users/astanin","html_url":"https://github.com/astanin","followers_url":"https://api.github.com/users/astanin/followers","following_url":"https://api.github.com/users/astanin/following{/other_user}","gists_url":"https://api.github.com/users/astanin/gists{/gist_id}","starred_url":"https://api.github.com/users/astanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astanin/subscriptions","organizations_url":"https://api.github.com/users/astanin/orgs","repos_url":"https://api.github.com/users/astanin/repos","events_url":"https://api.github.com/users/astanin/events{/privacy}","received_events_url":"https://api.github.com/users/astanin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/astanin/flickr-download","description":"Simple script to download sets and photos from Flickr","fork":true,"url":"https://api.github.com/repos/astanin/flickr-download","forks_url":"https://api.github.com/repos/astanin/flickr-download/forks","keys_url":"https://api.github.com/repos/astanin/flickr-download/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astanin/flickr-download/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astanin/flickr-download/teams","hooks_url":"https://api.github.com/repos/astanin/flickr-download/hooks","issue_events_url":"https://api.github.com/repos/astanin/flickr-download/issues/events{/number}","events_url":"https://api.github.com/repos/astanin/flickr-download/events","assignees_url":"https://api.github.com/repos/astanin/flickr-download/assignees{/user}","branches_url":"https://api.github.com/repos/astanin/flickr-download/branches{/branch}","tags_url":"https://api.github.com/repos/astanin/flickr-download/tags","blobs_url":"https://api.github.com/repos/astanin/flickr-download/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astanin/flickr-download/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astanin/flickr-download/git/refs{/sha}","trees_url":"https://api.github.com/repos/astanin/flickr-download/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astanin/flickr-download/statuses/{sha}","languages_url":"https://api.github.com/repos/astanin/flickr-download/languages","stargazers_url":"https://api.github.com/repos/astanin/flickr-download/stargazers","contributors_url":"https://api.github.com/repos/astanin/flickr-download/contributors","subscribers_url":"https://api.github.com/repos/astanin/flickr-download/subscribers","subscription_url":"https://api.github.com/repos/astanin/flickr-download/subscription","commits_url":"https://api.github.com/repos/astanin/flickr-download/commits{/sha}","git_commits_url":"https://api.github.com/repos/astanin/flickr-download/git/commits{/sha}","comments_url":"https://api.github.com/repos/astanin/flickr-download/comments{/number}","issue_comment_url":"https://api.github.com/repos/astanin/flickr-download/issues/comments{/number}","contents_url":"https://api.github.com/repos/astanin/flickr-download/contents/{+path}","compare_url":"https://api.github.com/repos/astanin/flickr-download/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astanin/flickr-download/merges","archive_url":"https://api.github.com/repos/astanin/flickr-download/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astanin/flickr-download/downloads","issues_url":"https://api.github.com/repos/astanin/flickr-download/issues{/number}","pulls_url":"https://api.github.com/repos/astanin/flickr-download/pulls{/number}","milestones_url":"https://api.github.com/repos/astanin/flickr-download/milestones{/number}","notifications_url":"https://api.github.com/repos/astanin/flickr-download/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astanin/flickr-download/labels{/name}","releases_url":"https://api.github.com/repos/astanin/flickr-download/releases{/id}","deployments_url":"https://api.github.com/repos/astanin/flickr-download/deployments","created_at":"2018-11-05T16:23:15Z","updated_at":"2018-11-14T08:13:55Z","pushed_at":"2018-11-14T09:14:12Z","git_url":"git://github.com/astanin/flickr-download.git","ssh_url":"git@github.com:astanin/flickr-download.git","clone_url":"https://github.com/astanin/flickr-download.git","svn_url":"https://github.com/astanin/flickr-download","homepage":"","size":62,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"beaufour:master","ref":"master","sha":"b14eebe2f743b237c6d5a1711089c233301a5307","user":{"login":"beaufour","id":239545,"node_id":"MDQ6VXNlcjIzOTU0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/239545?v=4","gravatar_id":"","url":"https://api.github.com/users/beaufour","html_url":"https://github.com/beaufour","followers_url":"https://api.github.com/users/beaufour/followers","following_url":"https://api.github.com/users/beaufour/following{/other_user}","gists_url":"https://api.github.com/users/beaufour/gists{/gist_id}","starred_url":"https://api.github.com/users/beaufour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaufour/subscriptions","organizations_url":"https://api.github.com/users/beaufour/orgs","repos_url":"https://api.github.com/users/beaufour/repos","events_url":"https://api.github.com/users/beaufour/events{/privacy}","received_events_url":"https://api.github.com/users/beaufour/received_events","type":"User","site_admin":false},"repo":{"id":7306647,"node_id":"MDEwOlJlcG9zaXRvcnk3MzA2NjQ3","name":"flickr-download","full_name":"beaufour/flickr-download","private":false,"owner":{"login":"beaufour","id":239545,"node_id":"MDQ6VXNlcjIzOTU0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/239545?v=4","gravatar_id":"","url":"https://api.github.com/users/beaufour","html_url":"https://github.com/beaufour","followers_url":"https://api.github.com/users/beaufour/followers","following_url":"https://api.github.com/users/beaufour/following{/other_user}","gists_url":"https://api.github.com/users/beaufour/gists{/gist_id}","starred_url":"https://api.github.com/users/beaufour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaufour/subscriptions","organizations_url":"https://api.github.com/users/beaufour/orgs","repos_url":"https://api.github.com/users/beaufour/repos","events_url":"https://api.github.com/users/beaufour/events{/privacy}","received_events_url":"https://api.github.com/users/beaufour/received_events","type":"User","site_admin":false},"html_url":"https://github.com/beaufour/flickr-download","description":"Simple script to download sets and photos from Flickr","fork":false,"url":"https://api.github.com/repos/beaufour/flickr-download","forks_url":"https://api.github.com/repos/beaufour/flickr-download/forks","keys_url":"https://api.github.com/repos/beaufour/flickr-download/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beaufour/flickr-download/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beaufour/flickr-download/teams","hooks_url":"https://api.github.com/repos/beaufour/flickr-download/hooks","issue_events_url":"https://api.github.com/repos/beaufour/flickr-download/issues/events{/number}","events_url":"https://api.github.com/repos/beaufour/flickr-download/events","assignees_url":"https://api.github.com/repos/beaufour/flickr-download/assignees{/user}","branches_url":"https://api.github.com/repos/beaufour/flickr-download/branches{/branch}","tags_url":"https://api.github.com/repos/beaufour/flickr-download/tags","blobs_url":"https://api.github.com/repos/beaufour/flickr-download/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beaufour/flickr-download/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beaufour/flickr-download/git/refs{/sha}","trees_url":"https://api.github.com/repos/beaufour/flickr-download/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beaufour/flickr-download/statuses/{sha}","languages_url":"https://api.github.com/repos/beaufour/flickr-download/languages","stargazers_url":"https://api.github.com/repos/beaufour/flickr-download/stargazers","contributors_url":"https://api.github.com/repos/beaufour/flickr-download/contributors","subscribers_url":"https://api.github.com/repos/beaufour/flickr-download/subscribers","subscription_url":"https://api.github.com/repos/beaufour/flickr-download/subscription","commits_url":"https://api.github.com/repos/beaufour/flickr-download/commits{/sha}","git_commits_url":"https://api.github.com/repos/beaufour/flickr-download/git/commits{/sha}","comments_url":"https://api.github.com/repos/beaufour/flickr-download/comments{/number}","issue_comment_url":"https://api.github.com/repos/beaufour/flickr-download/issues/comments{/number}","contents_url":"https://api.github.com/repos/beaufour/flickr-download/contents/{+path}","compare_url":"https://api.github.com/repos/beaufour/flickr-download/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beaufour/flickr-download/merges","archive_url":"https://api.github.com/repos/beaufour/flickr-download/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beaufour/flickr-download/downloads","issues_url":"https://api.github.com/repos/beaufour/flickr-download/issues{/number}","pulls_url":"https://api.github.com/repos/beaufour/flickr-download/pulls{/number}","milestones_url":"https://api.github.com/repos/beaufour/flickr-download/milestones{/number}","notifications_url":"https://api.github.com/repos/beaufour/flickr-download/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beaufour/flickr-download/labels{/name}","releases_url":"https://api.github.com/repos/beaufour/flickr-download/releases{/id}","deployments_url":"https://api.github.com/repos/beaufour/flickr-download/deployments","created_at":"2012-12-24T11:59:28Z","updated_at":"2018-11-14T08:34:51Z","pushed_at":"2018-11-14T09:17:34Z","git_url":"git://github.com/beaufour/flickr-download.git","ssh_url":"git@github.com:beaufour/flickr-download.git","clone_url":"https://github.com/beaufour/flickr-download.git","svn_url":"https://github.com/beaufour/flickr-download","homepage":"","size":64,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":9,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/43"},"html":{"href":"https://github.com/beaufour/flickr-download/pull/43"},"issue":{"href":"https://api.github.com/repos/beaufour/flickr-download/issues/43"},"comments":{"href":"https://api.github.com/repos/beaufour/flickr-download/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beaufour/flickr-download/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/beaufour/flickr-download/statuses/53e98e6cd08b18aaa9f0639a5b81b158143cde60"}},"author_association":"NONE"}}
{"actor":{"display_login":"beaufour"}}