{"action":"created","comment":{"url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/comments/212043227","pull_request_review_id":148592188,"id":212043227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA0MzIyNw==","diff_hunk":"@@ -800,7 +802,27 @@ public void destroyCastPlayer(){\n         sambaCastPlayer = null;\n     }\n \n-    public void showCast() {\n+    public void showCast(boolean isLive, final CastLiveButtonListener castLiveButtonListener) {\n+\n+        if (isLive) {\n+            castControlView.findViewById(R.id.exo_progress_controls).setVisibility(View.GONE);\n+            View castButton = castControlView.findViewById(R.id.topbar_live_button);","path":"sambaplayersdk/src/main/java/com/sambatech/player/SambaSimplePlayerView.java","position":33,"original_position":33,"commit_id":"3411a033f7b606394a5892a874d77229b387219a","original_commit_id":"3411a033f7b606394a5892a874d77229b387219a","user":{"login":"sambatech-ti","id":31410136,"node_id":"MDQ6VXNlcjMxNDEwMTM2","avatar_url":"https://avatars3.githubusercontent.com/u/31410136?v=4","gravatar_id":"","url":"https://api.github.com/users/sambatech-ti","html_url":"https://github.com/sambatech-ti","followers_url":"https://api.github.com/users/sambatech-ti/followers","following_url":"https://api.github.com/users/sambatech-ti/following{/other_user}","gists_url":"https://api.github.com/users/sambatech-ti/gists{/gist_id}","starred_url":"https://api.github.com/users/sambatech-ti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambatech-ti/subscriptions","organizations_url":"https://api.github.com/users/sambatech-ti/orgs","repos_url":"https://api.github.com/users/sambatech-ti/repos","events_url":"https://api.github.com/users/sambatech-ti/events{/privacy}","received_events_url":"https://api.github.com/users/sambatech-ti/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Rename \"castButton\" which hides the field declared at line 90. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://sonar.sambatech.com/coding_rules#rule_key=squid%3AHiddenFieldCheck)\n","created_at":"2018-08-22T17:38:40Z","updated_at":"2018-08-22T17:38:40Z","html_url":"https://github.com/sambatech/player_sdk_android/pull/38#discussion_r212043227","pull_request_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/comments/212043227"},"html":{"href":"https://github.com/sambatech/player_sdk_android/pull/38#discussion_r212043227"},"pull_request":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38","id":210210120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjEwMTIw","html_url":"https://github.com/sambatech/player_sdk_android/pull/38","diff_url":"https://github.com/sambatech/player_sdk_android/pull/38.diff","patch_url":"https://github.com/sambatech/player_sdk_android/pull/38.patch","issue_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/38","number":38,"state":"open","locked":false,"title":"Dev","user":{"login":"kesleyvazsamba","id":30668523,"node_id":"MDQ6VXNlcjMwNjY4NTIz","avatar_url":"https://avatars0.githubusercontent.com/u/30668523?v=4","gravatar_id":"","url":"https://api.github.com/users/kesleyvazsamba","html_url":"https://github.com/kesleyvazsamba","followers_url":"https://api.github.com/users/kesleyvazsamba/followers","following_url":"https://api.github.com/users/kesleyvazsamba/following{/other_user}","gists_url":"https://api.github.com/users/kesleyvazsamba/gists{/gist_id}","starred_url":"https://api.github.com/users/kesleyvazsamba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesleyvazsamba/subscriptions","organizations_url":"https://api.github.com/users/kesleyvazsamba/orgs","repos_url":"https://api.github.com/users/kesleyvazsamba/repos","events_url":"https://api.github.com/users/kesleyvazsamba/events{/privacy}","received_events_url":"https://api.github.com/users/kesleyvazsamba/received_events","type":"User","site_admin":false},"body":"Chromecast live support","created_at":"2018-08-22T17:36:43Z","updated_at":"2018-08-22T17:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57110f8d9fd98cf5eadae2c8c664c9015d038d5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38/commits","review_comments_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38/comments","review_comment_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/38/comments","statuses_url":"https://api.github.com/repos/sambatech/player_sdk_android/statuses/3411a033f7b606394a5892a874d77229b387219a","head":{"label":"sambatech:dev","ref":"dev","sha":"3411a033f7b606394a5892a874d77229b387219a","user":{"login":"sambatech","id":695559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTU1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/695559?v=4","gravatar_id":"","url":"https://api.github.com/users/sambatech","html_url":"https://github.com/sambatech","followers_url":"https://api.github.com/users/sambatech/followers","following_url":"https://api.github.com/users/sambatech/following{/other_user}","gists_url":"https://api.github.com/users/sambatech/gists{/gist_id}","starred_url":"https://api.github.com/users/sambatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambatech/subscriptions","organizations_url":"https://api.github.com/users/sambatech/orgs","repos_url":"https://api.github.com/users/sambatech/repos","events_url":"https://api.github.com/users/sambatech/events{/privacy}","received_events_url":"https://api.github.com/users/sambatech/received_events","type":"Organization","site_admin":false},"repo":{"id":51753367,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc1MzM2Nw==","name":"player_sdk_android","full_name":"sambatech/player_sdk_android","owner":{"login":"sambatech","id":695559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTU1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/695559?v=4","gravatar_id":"","url":"https://api.github.com/users/sambatech","html_url":"https://github.com/sambatech","followers_url":"https://api.github.com/users/sambatech/followers","following_url":"https://api.github.com/users/sambatech/following{/other_user}","gists_url":"https://api.github.com/users/sambatech/gists{/gist_id}","starred_url":"https://api.github.com/users/sambatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambatech/subscriptions","organizations_url":"https://api.github.com/users/sambatech/orgs","repos_url":"https://api.github.com/users/sambatech/repos","events_url":"https://api.github.com/users/sambatech/events{/privacy}","received_events_url":"https://api.github.com/users/sambatech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sambatech/player_sdk_android","description":"Samba Player SDK for Android","fork":false,"url":"https://api.github.com/repos/sambatech/player_sdk_android","forks_url":"https://api.github.com/repos/sambatech/player_sdk_android/forks","keys_url":"https://api.github.com/repos/sambatech/player_sdk_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambatech/player_sdk_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambatech/player_sdk_android/teams","hooks_url":"https://api.github.com/repos/sambatech/player_sdk_android/hooks","issue_events_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/events{/number}","events_url":"https://api.github.com/repos/sambatech/player_sdk_android/events","assignees_url":"https://api.github.com/repos/sambatech/player_sdk_android/assignees{/user}","branches_url":"https://api.github.com/repos/sambatech/player_sdk_android/branches{/branch}","tags_url":"https://api.github.com/repos/sambatech/player_sdk_android/tags","blobs_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambatech/player_sdk_android/statuses/{sha}","languages_url":"https://api.github.com/repos/sambatech/player_sdk_android/languages","stargazers_url":"https://api.github.com/repos/sambatech/player_sdk_android/stargazers","contributors_url":"https://api.github.com/repos/sambatech/player_sdk_android/contributors","subscribers_url":"https://api.github.com/repos/sambatech/player_sdk_android/subscribers","subscription_url":"https://api.github.com/repos/sambatech/player_sdk_android/subscription","commits_url":"https://api.github.com/repos/sambatech/player_sdk_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambatech/player_sdk_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambatech/player_sdk_android/contents/{+path}","compare_url":"https://api.github.com/repos/sambatech/player_sdk_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambatech/player_sdk_android/merges","archive_url":"https://api.github.com/repos/sambatech/player_sdk_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambatech/player_sdk_android/downloads","issues_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues{/number}","pulls_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls{/number}","milestones_url":"https://api.github.com/repos/sambatech/player_sdk_android/milestones{/number}","notifications_url":"https://api.github.com/repos/sambatech/player_sdk_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambatech/player_sdk_android/labels{/name}","releases_url":"https://api.github.com/repos/sambatech/player_sdk_android/releases{/id}","deployments_url":"https://api.github.com/repos/sambatech/player_sdk_android/deployments","created_at":"2016-02-15T12:15:05Z","updated_at":"2018-08-21T13:50:32Z","pushed_at":"2018-08-22T17:36:44Z","git_url":"git://github.com/sambatech/player_sdk_android.git","ssh_url":"git@github.com:sambatech/player_sdk_android.git","clone_url":"https://github.com/sambatech/player_sdk_android.git","svn_url":"https://github.com/sambatech/player_sdk_android","homepage":null,"size":14577,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":4,"open_issues":10,"watchers":6,"default_branch":"master"}},"base":{"label":"sambatech:master","ref":"master","sha":"1d53413e1e33cab6bb18c1046e7a2fce9f187cf1","user":{"login":"sambatech","id":695559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTU1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/695559?v=4","gravatar_id":"","url":"https://api.github.com/users/sambatech","html_url":"https://github.com/sambatech","followers_url":"https://api.github.com/users/sambatech/followers","following_url":"https://api.github.com/users/sambatech/following{/other_user}","gists_url":"https://api.github.com/users/sambatech/gists{/gist_id}","starred_url":"https://api.github.com/users/sambatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambatech/subscriptions","organizations_url":"https://api.github.com/users/sambatech/orgs","repos_url":"https://api.github.com/users/sambatech/repos","events_url":"https://api.github.com/users/sambatech/events{/privacy}","received_events_url":"https://api.github.com/users/sambatech/received_events","type":"Organization","site_admin":false},"repo":{"id":51753367,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc1MzM2Nw==","name":"player_sdk_android","full_name":"sambatech/player_sdk_android","owner":{"login":"sambatech","id":695559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTU1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/695559?v=4","gravatar_id":"","url":"https://api.github.com/users/sambatech","html_url":"https://github.com/sambatech","followers_url":"https://api.github.com/users/sambatech/followers","following_url":"https://api.github.com/users/sambatech/following{/other_user}","gists_url":"https://api.github.com/users/sambatech/gists{/gist_id}","starred_url":"https://api.github.com/users/sambatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambatech/subscriptions","organizations_url":"https://api.github.com/users/sambatech/orgs","repos_url":"https://api.github.com/users/sambatech/repos","events_url":"https://api.github.com/users/sambatech/events{/privacy}","received_events_url":"https://api.github.com/users/sambatech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sambatech/player_sdk_android","description":"Samba Player SDK for Android","fork":false,"url":"https://api.github.com/repos/sambatech/player_sdk_android","forks_url":"https://api.github.com/repos/sambatech/player_sdk_android/forks","keys_url":"https://api.github.com/repos/sambatech/player_sdk_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambatech/player_sdk_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambatech/player_sdk_android/teams","hooks_url":"https://api.github.com/repos/sambatech/player_sdk_android/hooks","issue_events_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/events{/number}","events_url":"https://api.github.com/repos/sambatech/player_sdk_android/events","assignees_url":"https://api.github.com/repos/sambatech/player_sdk_android/assignees{/user}","branches_url":"https://api.github.com/repos/sambatech/player_sdk_android/branches{/branch}","tags_url":"https://api.github.com/repos/sambatech/player_sdk_android/tags","blobs_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambatech/player_sdk_android/statuses/{sha}","languages_url":"https://api.github.com/repos/sambatech/player_sdk_android/languages","stargazers_url":"https://api.github.com/repos/sambatech/player_sdk_android/stargazers","contributors_url":"https://api.github.com/repos/sambatech/player_sdk_android/contributors","subscribers_url":"https://api.github.com/repos/sambatech/player_sdk_android/subscribers","subscription_url":"https://api.github.com/repos/sambatech/player_sdk_android/subscription","commits_url":"https://api.github.com/repos/sambatech/player_sdk_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambatech/player_sdk_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambatech/player_sdk_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambatech/player_sdk_android/contents/{+path}","compare_url":"https://api.github.com/repos/sambatech/player_sdk_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambatech/player_sdk_android/merges","archive_url":"https://api.github.com/repos/sambatech/player_sdk_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambatech/player_sdk_android/downloads","issues_url":"https://api.github.com/repos/sambatech/player_sdk_android/issues{/number}","pulls_url":"https://api.github.com/repos/sambatech/player_sdk_android/pulls{/number}","milestones_url":"https://api.github.com/repos/sambatech/player_sdk_android/milestones{/number}","notifications_url":"https://api.github.com/repos/sambatech/player_sdk_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambatech/player_sdk_android/labels{/name}","releases_url":"https://api.github.com/repos/sambatech/player_sdk_android/releases{/id}","deployments_url":"https://api.github.com/repos/sambatech/player_sdk_android/deployments","created_at":"2016-02-15T12:15:05Z","updated_at":"2018-08-21T13:50:32Z","pushed_at":"2018-08-22T17:36:44Z","git_url":"git://github.com/sambatech/player_sdk_android.git","ssh_url":"git@github.com:sambatech/player_sdk_android.git","clone_url":"https://github.com/sambatech/player_sdk_android.git","svn_url":"https://github.com/sambatech/player_sdk_android","homepage":null,"size":14577,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":4,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38"},"html":{"href":"https://github.com/sambatech/player_sdk_android/pull/38"},"issue":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/issues/38"},"comments":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/sambatech/player_sdk_android/statuses/3411a033f7b606394a5892a874d77229b387219a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sambatech-ti"}}