{"push_id":2955962970,"size":6,"distinct_size":1,"ref":"refs/heads/commitfest/20/1574","head":"d0ab07b3650c66747dfa20c0dcd70ac07992908b","before":"655cba573709db88a9c799d5e22570c0c7156ce4","commits":[{"sha":"f1885386f6246ac7b6f8d3f0aef247988f48ee7a","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Make float exponent output on Windows look the same as elsewhere.\n\nWindows, alone among our supported platforms, likes to emit three-digit\nexponent fields even when two digits would do.  Adjust such results to\nlook like the way everyone else does it.  Eliminate a bunch of variant\nexpected-output files that were needed only because of this quirk.\n\nDiscussion: https://postgr.es/m/2934.1539122454@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/f1885386f6246ac7b6f8d3f0aef247988f48ee7a"},{"sha":"c7d43c4d8a5b7215ea0a32d95260188b5d3ae3f4","author":{"name":"Alvaro Herrera","email":"3c84f0de6f8a0f296d36cdd9f57fa166641c96b1@alvh.no-ip.org"},"message":"Correct attach/detach logic for FKs in partitions\n\nThere was no code to handle foreign key constraints on partitioned\ntables in the case of ALTER TABLE DETACH; and if you happened to ATTACH\na partition that already had an equivalent constraint, that one was\nignored and a new constraint was created.  Adding this to the fact that\nforeign key cloning reuses the constraint name on the partition instead\nof generating a new name (as it probably should, to cater to SQL\nstandard rules about constraint naming within schemas), the result was a\npretty poor user experience -- the most visible failure was that just\ndetaching a partition and re-attaching it failed with an error such as\n\n  ERROR:  duplicate key value violates unique constraint \"pg_constraint_conrelid_contypid_conname_index\"\n  DETAIL:  Key (conrelid, contypid, conname)=(26702, 0, test_result_asset_id_fkey) already exists.\n\nbecause it would try to create an identically-named constraint in the\npartition.  To make matters worse, if you tried to drop the constraint\nin the now-independent partition, that would fail because the constraint\nwas still seen as dependent on the constraint in its former parent\npartitioned table:\n  ERROR:  cannot drop inherited constraint \"test_result_asset_id_fkey\" of relation \"test_result_cbsystem_0001_0050_monthly_2018_09\"\n\nThis fix attacks the problem from two angles: first, when the partition\nis detached, the constraint is also marked as independent, so the drop\nnow works.  Second, when the partition is re-attached, we scan existing\nconstraints searching for one matching the FK in the parent, and if one\nexists, we link that one to the parent constraint.  So we don't end up\nwith a duplicate -- and better yet, we don't need to scan the referenced\ntable to verify that the constraint holds.\n\nTo implement this I made a small change to previously planner-only\nstruct ForeignKeyCacheInfo to contain the constraint OID; also relcache\nnow maintains the list of FKs for partitioned tables too.\n\nBackpatch to 11.\n\nReported-by: Michael Vitale (bug #15425)\nDiscussion: https://postgr.es/m/15425-2dbc9d2aa999f816@postgresql.org","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/c7d43c4d8a5b7215ea0a32d95260188b5d3ae3f4"},{"sha":"24a2c436a5ce1912373a6c9561cbabd09495552d","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Remove dead reference to ecpg resultmap file.\n\nI missed this in my prior commit because it doesn't matter in non-VPATH\nbuilds.\n\nPer buildfarm.","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/24a2c436a5ce1912373a6c9561cbabd09495552d"},{"sha":"13cd7209f794d9dff8084c9748a78a0a5bf0464a","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Simplify use of AllocSetContextCreate() wrapper macro.\n\nWe can allow this macro to accept either abbreviated or non-abbreviated\nallocation parameters by making use of __VA_ARGS__.  As noted by Andres\nFreund, it's unlikely that any compiler would have __builtin_constant_p\nbut not __VA_ARGS__, so this gives up little or no error checking, and\nit avoids a minor but annoying API break for extensions.\n\nWith this change, there is no reason for anybody to call\nAllocSetContextCreateExtended directly, so in HEAD I renamed it to\nAllocSetContextCreateInternal.  It's probably too late for an ABI\nbreak like that in 11, though.\n\nDiscussion: https://postgr.es/m/20181012170355.bhxi273skjt6sag4@alap3.anarazel.de","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/13cd7209f794d9dff8084c9748a78a0a5bf0464a"},{"sha":"240cd6bc8366c9848bc2511c623743326e5a187b","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Another round of portability hacking on ECPG regression tests.\n\nRemoving the separate Windows expected-files in commit f1885386f\nturns out to have been too optimistic: on most (but not all!) of our\nWindows buildfarm members, the tests still print floats with three\nexponent digits, because they're invoking the native printf()\nnot snprintf.c.\n\nBut rather than put back the extra expected-files, let's hack\nthe three tests in question so that they adjust float formatting\nthe same way snprintf.c does.\n\nDiscussion: https://postgr.es/m/18890.1539374107@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/240cd6bc8366c9848bc2511c623743326e5a187b"},{"sha":"d0ab07b3650c66747dfa20c0dcd70ac07992908b","author":{"name":"Commitfest Bot","email":"b9e638e07cc2e2abf56c9c0cad7954f2e3bc1641@cputube.org"},"message":"[CF 20/1574] Transactions involving multiple postgres foreign servers\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread, and also periodically to check for bitrot caused by changes\non the master branch.\n\nCommitfest entry: https://commitfest.postgresql.org/20/1574\nPatch(es): https://www.postgresql.org/message-id/CAD21AoDD1HfxNkjZKnd2O7KpFF6qy6u0_iizqMfaTWgC3ZO7Xg@mail.gmail.com\nAuthor(s): Masahiko Sawada, Ashutosh Bapat","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/d0ab07b3650c66747dfa20c0dcd70ac07992908b"}]}
{"actor":{"display_login":"postgresql-cfbot"}}