{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1904","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1904/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1904/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1904/events","html_url":"https://github.com/shopware/shopware/pull/1904","id":385936823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzk0NjE4","number":1904,"title":"Listing Boxes should use Flexbox instead of floating – It behaves smoother and is modern","user":{"login":"jverhoelen","id":6791360,"node_id":"MDQ6VXNlcjY3OTEzNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6791360?v=4","gravatar_id":"","url":"https://api.github.com/users/jverhoelen","html_url":"https://github.com/jverhoelen","followers_url":"https://api.github.com/users/jverhoelen/followers","following_url":"https://api.github.com/users/jverhoelen/following{/other_user}","gists_url":"https://api.github.com/users/jverhoelen/gists{/gist_id}","starred_url":"https://api.github.com/users/jverhoelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverhoelen/subscriptions","organizations_url":"https://api.github.com/users/jverhoelen/orgs","repos_url":"https://api.github.com/users/jverhoelen/repos","events_url":"https://api.github.com/users/jverhoelen/events{/privacy}","received_events_url":"https://api.github.com/users/jverhoelen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-29T21:37:23Z","updated_at":"2018-11-30T07:54:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1904","html_url":"https://github.com/shopware/shopware/pull/1904","diff_url":"https://github.com/shopware/shopware/pull/1904.diff","patch_url":"https://github.com/shopware/shopware/pull/1904.patch"},"body":"### 1. Why is this change necessary?\r\n\r\nFor example on Article listing pages like category pages, articles will behave ugly when their short description texts have different lengths and result in different amounts of line breaks. Due to this, the responsive layout is very unstable and tends to look ugly if short description texts have different length.\r\n\r\nExample: [Screenshot with the issue](https://pbs.twimg.com/media/DtMmlh3X4AEG6Bi.jpg)\r\n\r\nFlexbox is a modern standard while being compatible with a decent amount of older browsers, too. It makes layouting of grids with columns far more easy and solves the described problem smoothly.\r\n\r\n### 2. What does this change do, exactly?\r\n\r\nClearfixes and left floats were thrown out of the listing boxes layout. Flexbox will take care of the layouting by preserving also a width of a \"column\" in percentage value (just like before).\r\nIf there is no bug in my changes, it should do exactly the same as before. In addition in fixes the described ugly behaviour.\r\n\r\nExpected result is: [Screenshot with fix](https://pbs.twimg.com/media/DtMnJ3eX4AY2jhf.jpg)\r\n\r\nSee the change in action here on this shop: https://lifefoto.de/foto-fineart-papier/?p=1\r\nAlthough implemented and therefor overwritten in a child template, it should perform exactly as in this PR.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n\r\n* Create a category\r\n* Create some articles (e.g. 4) with short descriptions of different length (e.g. 80, 140 and 200 characters)\r\n* On the shop frontend, visit the category and see the articles of different height form an ugly experience\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n\r\n- none -\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n\r\nI guess none.\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [ ] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [ x ] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/443121264","html_url":"https://github.com/shopware/shopware/pull/1904#issuecomment-443121264","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1904","id":443121264,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzEyMTI2NA==","user":{"login":"jverhoelen","id":6791360,"node_id":"MDQ6VXNlcjY3OTEzNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6791360?v=4","gravatar_id":"","url":"https://api.github.com/users/jverhoelen","html_url":"https://github.com/jverhoelen","followers_url":"https://api.github.com/users/jverhoelen/followers","following_url":"https://api.github.com/users/jverhoelen/following{/other_user}","gists_url":"https://api.github.com/users/jverhoelen/gists{/gist_id}","starred_url":"https://api.github.com/users/jverhoelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverhoelen/subscriptions","organizations_url":"https://api.github.com/users/jverhoelen/orgs","repos_url":"https://api.github.com/users/jverhoelen/repos","events_url":"https://api.github.com/users/jverhoelen/events{/privacy}","received_events_url":"https://api.github.com/users/jverhoelen/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T07:54:06Z","updated_at":"2018-11-30T07:54:06Z","author_association":"NONE","body":"Hey all,\r\nI never ran Shopware locally. 1,5 hours ago I really wanted to do so, but I had to quit because the lack of documentation. Honestly: how do I start this? I found several scripts about starting something, I found a docker-compose file which complaints about `sh: dev-ops/docker/actions/.copy_mysql-config.sh: No such file or directory`.\r\n\r\nMore honestly: I can't and don't want to put much time into it. Could somebody help me please?"}}
{"actor":{"display_login":"jverhoelen"}}