{"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/219708499","pull_request_review_id":157948776,"id":219708499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcwODQ5OQ==","diff_hunk":"@@ -29,31 +46,50 @@ void DataTable::Select(transaction::TransactionContext *const txn, const TupleSl\n     // Here we will need to check that the version pointer did not change during our read. If it did, the content\n     // we have read might have been rolled back and an abort has already unlinked the associated undo-record,\n     // we will have to loop around to avoid a dirty read.\n+    visible = Visible(slot, accessor_);","path":"src/storage/data_table.cpp","position":48,"original_position":51,"commit_id":"e1eafc096c892ef6e77c216c6cfb095d0838bed3","original_commit_id":"1a48fbd018a40100baf54bde010387da33417cba","user":{"login":"tli2","id":12805799,"node_id":"MDQ6VXNlcjEyODA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12805799?v=4","gravatar_id":"","url":"https://api.github.com/users/tli2","html_url":"https://github.com/tli2","followers_url":"https://api.github.com/users/tli2/followers","following_url":"https://api.github.com/users/tli2/following{/other_user}","gists_url":"https://api.github.com/users/tli2/gists{/gist_id}","starred_url":"https://api.github.com/users/tli2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tli2/subscriptions","organizations_url":"https://api.github.com/users/tli2/orgs","repos_url":"https://api.github.com/users/tli2/repos","events_url":"https://api.github.com/users/tli2/events{/privacy}","received_events_url":"https://api.github.com/users/tli2/received_events","type":"User","site_admin":false},"body":"Yeah sure","created_at":"2018-09-23T19:15:50Z","updated_at":"2018-09-23T19:15:50Z","html_url":"https://github.com/cmu-db/terrier/pull/174#discussion_r219708499","pull_request_url":"https://api.github.com/repos/cmu-db/terrier/pulls/174","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/219708499"},"html":{"href":"https://github.com/cmu-db/terrier/pull/174#discussion_r219708499"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/174"}},"in_reply_to_id":219704358},"pull_request":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/174","id":217485657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDg1NjU3","html_url":"https://github.com/cmu-db/terrier/pull/174","diff_url":"https://github.com/cmu-db/terrier/pull/174.diff","patch_url":"https://github.com/cmu-db/terrier/pull/174.patch","issue_url":"https://api.github.com/repos/cmu-db/terrier/issues/174","number":174,"state":"open","locked":false,"title":"Delete() added to DataTable","user":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"body":"Fix #173.\r\n\r\nNeed to beef up the testing but I'm ready to see what CI looks like.","created_at":"2018-09-23T00:35:28Z","updated_at":"2018-09-23T19:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e38d9f4d8498494f31ec5c0bf5bb7e0cc5abce08","assignee":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010456618,"node_id":"MDU6TGFiZWwxMDEwNDU2NjE4","url":"https://api.github.com/repos/cmu-db/terrier/labels/feature","name":"feature","color":"1d76db","default":false},{"id":1010451271,"node_id":"MDU6TGFiZWwxMDEwNDUxMjcx","url":"https://api.github.com/repos/cmu-db/terrier/labels/ready-for-review","name":"ready-for-review","color":"76b726","default":false}],"milestone":{"url":"https://api.github.com/repos/cmu-db/terrier/milestones/3","html_url":"https://github.com/cmu-db/terrier/milestone/3","labels_url":"https://api.github.com/repos/cmu-db/terrier/milestones/3/labels","id":3607997,"node_id":"MDk6TWlsZXN0b25lMzYwNzk5Nw==","number":3,"title":"SQL Table","description":"","creator":{"login":"tli2","id":12805799,"node_id":"MDQ6VXNlcjEyODA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12805799?v=4","gravatar_id":"","url":"https://api.github.com/users/tli2","html_url":"https://github.com/tli2","followers_url":"https://api.github.com/users/tli2/followers","following_url":"https://api.github.com/users/tli2/following{/other_user}","gists_url":"https://api.github.com/users/tli2/gists{/gist_id}","starred_url":"https://api.github.com/users/tli2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tli2/subscriptions","organizations_url":"https://api.github.com/users/tli2/orgs","repos_url":"https://api.github.com/users/tli2/repos","events_url":"https://api.github.com/users/tli2/events{/privacy}","received_events_url":"https://api.github.com/users/tli2/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2018-08-29T19:38:41Z","updated_at":"2018-09-23T03:53:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cmu-db/terrier/pulls/174/commits","review_comments_url":"https://api.github.com/repos/cmu-db/terrier/pulls/174/comments","review_comment_url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/terrier/issues/174/comments","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/e1eafc096c892ef6e77c216c6cfb095d0838bed3","head":{"label":"mbutrovich:logical_delete","ref":"logical_delete","sha":"e1eafc096c892ef6e77c216c6cfb095d0838bed3","user":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"repo":{"id":142196570,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxOTY1NzA=","name":"terrier","full_name":"mbutrovich/terrier","private":false,"owner":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mbutrovich/terrier","description":"You know what this is...","fork":true,"url":"https://api.github.com/repos/mbutrovich/terrier","forks_url":"https://api.github.com/repos/mbutrovich/terrier/forks","keys_url":"https://api.github.com/repos/mbutrovich/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbutrovich/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbutrovich/terrier/teams","hooks_url":"https://api.github.com/repos/mbutrovich/terrier/hooks","issue_events_url":"https://api.github.com/repos/mbutrovich/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/mbutrovich/terrier/events","assignees_url":"https://api.github.com/repos/mbutrovich/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/mbutrovich/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/mbutrovich/terrier/tags","blobs_url":"https://api.github.com/repos/mbutrovich/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbutrovich/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbutrovich/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbutrovich/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbutrovich/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/mbutrovich/terrier/languages","stargazers_url":"https://api.github.com/repos/mbutrovich/terrier/stargazers","contributors_url":"https://api.github.com/repos/mbutrovich/terrier/contributors","subscribers_url":"https://api.github.com/repos/mbutrovich/terrier/subscribers","subscription_url":"https://api.github.com/repos/mbutrovich/terrier/subscription","commits_url":"https://api.github.com/repos/mbutrovich/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbutrovich/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbutrovich/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbutrovich/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbutrovich/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/mbutrovich/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbutrovich/terrier/merges","archive_url":"https://api.github.com/repos/mbutrovich/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbutrovich/terrier/downloads","issues_url":"https://api.github.com/repos/mbutrovich/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/mbutrovich/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/mbutrovich/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/mbutrovich/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbutrovich/terrier/labels{/name}","releases_url":"https://api.github.com/repos/mbutrovich/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/mbutrovich/terrier/deployments","created_at":"2018-07-24T18:17:16Z","updated_at":"2018-09-22T17:06:12Z","pushed_at":"2018-09-23T17:32:16Z","git_url":"git://github.com/mbutrovich/terrier.git","ssh_url":"git@github.com:mbutrovich/terrier.git","clone_url":"https://github.com/mbutrovich/terrier.git","svn_url":"https://github.com/mbutrovich/terrier","homepage":null,"size":1500,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmu-db:col-access","ref":"col-access","sha":"67c20d49851a754fcd102f0fddc771cb5089cd2a","user":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":140325970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzA=","name":"terrier","full_name":"cmu-db/terrier","private":false,"owner":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cmu-db/terrier","description":"You know what this is...","fork":false,"url":"https://api.github.com/repos/cmu-db/terrier","forks_url":"https://api.github.com/repos/cmu-db/terrier/forks","keys_url":"https://api.github.com/repos/cmu-db/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/terrier/teams","hooks_url":"https://api.github.com/repos/cmu-db/terrier/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/terrier/events","assignees_url":"https://api.github.com/repos/cmu-db/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/terrier/tags","blobs_url":"https://api.github.com/repos/cmu-db/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/terrier/languages","stargazers_url":"https://api.github.com/repos/cmu-db/terrier/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/terrier/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/terrier/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/terrier/subscription","commits_url":"https://api.github.com/repos/cmu-db/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/terrier/merges","archive_url":"https://api.github.com/repos/cmu-db/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/terrier/downloads","issues_url":"https://api.github.com/repos/cmu-db/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/terrier/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/terrier/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2018-09-23T17:37:31Z","pushed_at":"2018-09-23T17:32:18Z","git_url":"git://github.com/cmu-db/terrier.git","ssh_url":"git@github.com:cmu-db/terrier.git","clone_url":"https://github.com/cmu-db/terrier.git","svn_url":"https://github.com/cmu-db/terrier","homepage":null,"size":1388,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/174"},"html":{"href":"https://github.com/cmu-db/terrier/pull/174"},"issue":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/174"},"comments":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/terrier/statuses/e1eafc096c892ef6e77c216c6cfb095d0838bed3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tli2"}}