{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/221539088","pull_request_review_id":160208825,"id":221539088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTUzOTA4OA==","diff_hunk":"@@ -69,32 +64,54 @@ define('ext.wikia.adEngine.provider.btfBlocker', [\n \t\t\t}\n \t\t}\n \n-\t\tfunction startBtfQueue() {\n-\t\t\tlog('startBtfQueue', log.levels.info.debug, logGroup);\n+\t\tfunction startSecondCallSlots() {\n+\t\t\tlog('startSecondCallSlots', log.levels.info.debug, logGroup);\n \n-\t\t\tif (btfQueueStarted) {\n+\t\t\tif (secondCallQueueStarted) {\n \t\t\t\treturn;\n \t\t\t}\n \n-\t\t\tlazyQueue.makeQueue(btfQueue, processBtfSlot);\n-\t\t\tbtfQueue.start();\n+\t\t\t// highly viewable slots can be unblocked in second call\n+\t\t\tif (win.ads.runtime.unblockHighlyViewableSlots && config.highlyViewableSlots) {\n+\t\t\t\tconfig.highlyViewableSlots.forEach(function(slotName) {\n+\t\t\t\t\tlog(['Unblocking HiVi slots', slotName], log.levels.info, logGroup);\n+\t\t\t\t\tunblock(slotName);\n+\t\t\t\t});\n+\t\t\t}\n+\n+\t\t\t// ATF slots are always called in second call if not called in first\n+\t\t\tif (config.atfSlots) {\n+\t\t\t\tconfig.atfSlots\n+\t\t\t\t// remove slot already called in first call\n+\t\t\t\t.filter(function(slotName) {\n+\t\t\t\t\treturn config.firstCallSlots.indexOf(slotName) === -1;\n+\t\t\t\t})\n+\t\t\t\t// unblock slot","path":"extensions/wikia/AdEngine/js/provider/btfBlocker.js","position":88,"original_position":88,"commit_id":"7a3fe5b16b755648a483db9701025847b851e130","original_commit_id":"7a3fe5b16b755648a483db9701025847b851e130","user":{"login":"jacekbj","id":40768156,"node_id":"MDQ6VXNlcjQwNzY4MTU2","avatar_url":"https://avatars2.githubusercontent.com/u/40768156?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekbj","html_url":"https://github.com/jacekbj","followers_url":"https://api.github.com/users/jacekbj/followers","following_url":"https://api.github.com/users/jacekbj/following{/other_user}","gists_url":"https://api.github.com/users/jacekbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekbj/subscriptions","organizations_url":"https://api.github.com/users/jacekbj/orgs","repos_url":"https://api.github.com/users/jacekbj/repos","events_url":"https://api.github.com/users/jacekbj/events{/privacy}","received_events_url":"https://api.github.com/users/jacekbj/received_events","type":"User","site_admin":false},"body":"I really dislike the idea of variable `unblockedSlots`. Why not set the property `disabled` in slot config instead? What do you think about that?","created_at":"2018-10-01T09:09:12Z","updated_at":"2018-10-01T09:09:12Z","html_url":"https://github.com/Wikia/app/pull/16078#discussion_r221539088","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/16078","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/221539088"},"html":{"href":"https://github.com/Wikia/app/pull/16078#discussion_r221539088"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/16078"}},"in_reply_to_id":221508502},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/16078","id":217585072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTg1MDcy","html_url":"https://github.com/Wikia/app/pull/16078","diff_url":"https://github.com/Wikia/app/pull/16078.diff","patch_url":"https://github.com/Wikia/app/pull/16078.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/16078","number":16078,"state":"open","locked":false,"title":"ADEN-7702 Introduce the idea of firstCallSlots and secondCallSlots.","user":{"login":"jacekbj","id":40768156,"node_id":"MDQ6VXNlcjQwNzY4MTU2","avatar_url":"https://avatars2.githubusercontent.com/u/40768156?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekbj","html_url":"https://github.com/jacekbj","followers_url":"https://api.github.com/users/jacekbj/followers","following_url":"https://api.github.com/users/jacekbj/following{/other_user}","gists_url":"https://api.github.com/users/jacekbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekbj/subscriptions","organizations_url":"https://api.github.com/users/jacekbj/orgs","repos_url":"https://api.github.com/users/jacekbj/repos","events_url":"https://api.github.com/users/jacekbj/events{/privacy}","received_events_url":"https://api.github.com/users/jacekbj/received_events","type":"User","site_admin":false},"body":"The idea:\r\n* we can configure which slots should be queried in the first call\r\n* we can disable BTF slots","created_at":"2018-09-24T08:32:02Z","updated_at":"2018-10-01T09:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37e9df0309c2218022f933bfcfa1aab369a6e0d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/16078/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/16078/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/16078/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/7a3fe5b16b755648a483db9701025847b851e130","head":{"label":"Wikia:ADEN-7702","ref":"ADEN-7702","sha":"7a3fe5b16b755648a483db9701025847b851e130","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzEz","name":"app","full_name":"Wikia/app","private":false,"owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2018-09-28T22:33:05Z","pushed_at":"2018-10-01T08:56:04Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":768971,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":119,"open_issues":19,"watchers":143,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"ded7a5e7e76e54eca10ea09579c21bcb7bf23429","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzEz","name":"app","full_name":"Wikia/app","private":false,"owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2018-09-28T22:33:05Z","pushed_at":"2018-10-01T08:56:04Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":768971,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":119,"open_issues":19,"watchers":143,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/16078"},"html":{"href":"https://github.com/Wikia/app/pull/16078"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/16078"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/16078/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/16078/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/16078/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/7a3fe5b16b755648a483db9701025847b851e130"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jacekbj"}}