{"action":"opened","number":850,"pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/850","id":234526384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTI2Mzg0","html_url":"https://github.com/bosnet/sebak/pull/850","diff_url":"https://github.com/bosnet/sebak/pull/850.diff","patch_url":"https://github.com/bosnet/sebak/pull/850.patch","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/850","number":850,"state":"open","locked":false,"title":"Do not use Operation Hash for validation","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"body":"### Github Issue\r\n<!--\r\n    Add the Github issue number if one exists, prefixed by one of Github's keywords, ex. `Fixes #1`, `Closes #1` or `Resolves #1`.\r\n-->\r\n\r\n### Background\r\nDefinition of the `Hash` for operation is debatable.\r\nBut I want to resolve this.\r\n\r\nHash is a fingerprint of given data. If the data is changed then the Hash also changed.\r\nHence, the Hash is unique when the data is unique.\r\n\r\nWe use the hash for the transaction or block as a unique identifier.\r\nBecause the payload for the tx and block is unique.\r\n\r\nHowever, as we already knew, the operation payload is not unique. And the hash also not unique.\r\nSo, the hash for the operation cannot be used as the identifier.\r\n\r\nOn the other side,\r\nCombination of TxHash and Operation Index is unique because TxHash is unique and Operation Index is unique within the Transaction.\r\n\r\nAccording to this,\r\nValidation for the operation should be done with the unique identifier.\r\n\r\n### Solution\r\n* Do not use Operation Hash for validation\r\n* Identifier the operation is changed to Tx + Index\r\n\r\n### Possible Drawbacks\r\n<!--\r\n    What are the possible side-effects or negative impacts of the code change?\r\n-->\r\n\r\n","created_at":"2018-11-29T06:48:26Z","updated_at":"2018-11-29T06:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bosnet/sebak/pulls/850/commits","review_comments_url":"https://api.github.com/repos/bosnet/sebak/pulls/850/comments","review_comment_url":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/850/comments","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/d008441a665de6d1f2f0cf6ea4307a5c19df8503","head":{"label":"kfangw:congressvoting_validation_tx","ref":"congressvoting_validation_tx","sha":"d008441a665de6d1f2f0cf6ea4307a5c19df8503","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"repo":{"id":137439556,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0Mzk1NTY=","name":"sebak","full_name":"kfangw/sebak","private":false,"owner":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kfangw/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":true,"url":"https://api.github.com/repos/kfangw/sebak","forks_url":"https://api.github.com/repos/kfangw/sebak/forks","keys_url":"https://api.github.com/repos/kfangw/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kfangw/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kfangw/sebak/teams","hooks_url":"https://api.github.com/repos/kfangw/sebak/hooks","issue_events_url":"https://api.github.com/repos/kfangw/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/kfangw/sebak/events","assignees_url":"https://api.github.com/repos/kfangw/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/kfangw/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/kfangw/sebak/tags","blobs_url":"https://api.github.com/repos/kfangw/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kfangw/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kfangw/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/kfangw/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kfangw/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/kfangw/sebak/languages","stargazers_url":"https://api.github.com/repos/kfangw/sebak/stargazers","contributors_url":"https://api.github.com/repos/kfangw/sebak/contributors","subscribers_url":"https://api.github.com/repos/kfangw/sebak/subscribers","subscription_url":"https://api.github.com/repos/kfangw/sebak/subscription","commits_url":"https://api.github.com/repos/kfangw/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/kfangw/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/kfangw/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/kfangw/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/kfangw/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/kfangw/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kfangw/sebak/merges","archive_url":"https://api.github.com/repos/kfangw/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kfangw/sebak/downloads","issues_url":"https://api.github.com/repos/kfangw/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/kfangw/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/kfangw/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/kfangw/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kfangw/sebak/labels{/name}","releases_url":"https://api.github.com/repos/kfangw/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/kfangw/sebak/deployments","created_at":"2018-06-15T04:05:44Z","updated_at":"2018-11-15T06:56:22Z","pushed_at":"2018-11-29T06:48:09Z","git_url":"git://github.com/kfangw/sebak.git","ssh_url":"git@github.com:kfangw/sebak.git","clone_url":"https://github.com/kfangw/sebak.git","svn_url":"https://github.com/kfangw/sebak","homepage":"https://boscoin.io","size":2309,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bosnet:master","ref":"master","sha":"3763bb149aba2cf40cfff5ba603180c9029ddb3f","user":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"repo":{"id":129848943,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg5NDM=","name":"sebak","full_name":"bosnet/sebak","private":false,"owner":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bosnet/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":false,"url":"https://api.github.com/repos/bosnet/sebak","forks_url":"https://api.github.com/repos/bosnet/sebak/forks","keys_url":"https://api.github.com/repos/bosnet/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosnet/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosnet/sebak/teams","hooks_url":"https://api.github.com/repos/bosnet/sebak/hooks","issue_events_url":"https://api.github.com/repos/bosnet/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/bosnet/sebak/events","assignees_url":"https://api.github.com/repos/bosnet/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/bosnet/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/bosnet/sebak/tags","blobs_url":"https://api.github.com/repos/bosnet/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosnet/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosnet/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosnet/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/bosnet/sebak/languages","stargazers_url":"https://api.github.com/repos/bosnet/sebak/stargazers","contributors_url":"https://api.github.com/repos/bosnet/sebak/contributors","subscribers_url":"https://api.github.com/repos/bosnet/sebak/subscribers","subscription_url":"https://api.github.com/repos/bosnet/sebak/subscription","commits_url":"https://api.github.com/repos/bosnet/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosnet/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosnet/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosnet/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosnet/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/bosnet/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosnet/sebak/merges","archive_url":"https://api.github.com/repos/bosnet/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosnet/sebak/downloads","issues_url":"https://api.github.com/repos/bosnet/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/bosnet/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/bosnet/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/bosnet/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosnet/sebak/labels{/name}","releases_url":"https://api.github.com/repos/bosnet/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/bosnet/sebak/deployments","created_at":"2018-04-17T05:05:34Z","updated_at":"2018-11-29T06:05:17Z","pushed_at":"2018-11-29T06:05:15Z","git_url":"git://github.com/bosnet/sebak.git","ssh_url":"git@github.com:bosnet/sebak.git","clone_url":"https://github.com/bosnet/sebak.git","svn_url":"https://github.com/bosnet/sebak","homepage":"https://bosnet.github.io","size":2282,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":88,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850"},"html":{"href":"https://github.com/bosnet/sebak/pull/850"},"issue":{"href":"https://api.github.com/repos/bosnet/sebak/issues/850"},"comments":{"href":"https://api.github.com/repos/bosnet/sebak/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/bosnet/sebak/statuses/d008441a665de6d1f2f0cf6ea4307a5c19df8503"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":75,"deletions":14,"changed_files":4}}
{"actor":{"display_login":"kfangw"}}