{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/21892","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/21892/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/21892/comments","events_url":"https://api.github.com/repos/apache/spark/issues/21892/events","html_url":"https://github.com/apache/spark/pull/21892","id":345232299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDM2NTI1","number":21892,"title":"[SPARK-24945][SQL] Switching to uniVocity 2.7.2","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-27T13:46:21Z","updated_at":"2018-07-27T18:21:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21892","html_url":"https://github.com/apache/spark/pull/21892","diff_url":"https://github.com/apache/spark/pull/21892.diff","patch_url":"https://github.com/apache/spark/pull/21892.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nIn the PR, I propose to upgrade uniVocity parser from **2.6.3** to **2.7.2**. The recent version includes a fix for the SPARK-24645 issue. Here is the bug report for uniVocity https://github.com/uniVocity/univocity-parsers/issues/250.\r\n\r\nI removed the changes in `UnivocityParser` introduced by the commit: https://github.com/apache/spark/commit/bd32b509a1728366494cba13f8f6612b7bd46ec0 but leaved the test from the commit.\r\n\r\n## How was this patch tested?\r\n\r\nI tested by `CSVSuite` and by running `CSVBenchmarsk`. The difference between 2.6.3 and 2.7.2 is 0.2% - 8% except a benchmark for `count()`. Performance degradation in the last case is **x3.8**.\r\n\r\nBefore changes:\r\n```\r\nParsing quoted values:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative\r\n------------------------------------------------------------------------------------------------\r\nOne quoted string                           33336 / 34122          0.0      666727.0       1.0X\r\n\r\nWide rows with 1000 columns:             Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative\r\n------------------------------------------------------------------------------------------------\r\nSelect 1000 columns                         90287 / 91713          0.0       90286.9       1.0X\r\nSelect 100 columns                          31826 / 36589          0.0       31826.4       2.8X\r\nSelect one column                           25738 / 25872          0.0       25737.9       3.5X\r\ncount()                                       6931 / 7269          0.1        6931.5      13.0X\r\n```\r\nafter:\r\n```\r\nParsing quoted values:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative\r\n------------------------------------------------------------------------------------------------\r\nOne quoted string                           34191 / 34332          0.0      683826.7       1.0X\r\n\r\nWide rows with 1000 columns:             Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative\r\n------------------------------------------------------------------------------------------------\r\nSelect 1000 columns                         90446 / 91900          0.0       90446.1       1.0X\r\nSelect 100 columns                          34315 / 39895          0.0       34314.9       2.6X\r\nSelect one column                           27955 / 28125          0.0       27954.8       3.2X\r\ncount()                                     27713 / 27803          0.0       27712.8       3.3X\r\n```"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/408500090","html_url":"https://github.com/apache/spark/pull/21892#issuecomment-408500090","issue_url":"https://api.github.com/repos/apache/spark/issues/21892","id":408500090,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODUwMDA5MA==","user":{"login":"SparkQA","id":8108735,"node_id":"MDQ6VXNlcjgxMDg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T18:21:02Z","updated_at":"2018-07-27T18:21:02Z","author_association":"NONE","body":"**[Test build #93665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93665/testReport)** for PR 21892 at commit [`b116987`](https://github.com/apache/spark/commit/b116987d9a0adb887201177d41c1b94e6f5aeb63).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}