{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8950","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8950/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8950/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8950/events","html_url":"https://github.com/istio/istio/pull/8950","id":363651848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDM0NDIz","number":8950,"title":"RFC tracing: Enable zipkinAddress host:port to be overridden in helm inst…","user":{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"assignees":[{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-25T15:57:53Z","updated_at":"2018-09-26T11:28:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8950","html_url":"https://github.com/istio/istio/pull/8950","diff_url":"https://github.com/istio/istio/pull/8950.diff","patch_url":"https://github.com/istio/istio/pull/8950.patch"},"body":"…all/template\r\n\r\nThis PR provides a global property that can enable the zipkinAddress (host/port) to be overridden, to enable spans to be reported to a zipkin compatible service endpoint in another namespace.\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/424681111","html_url":"https://github.com/istio/istio/pull/8950#issuecomment-424681111","issue_url":"https://api.github.com/repos/istio/istio/issues/8950","id":424681111,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDY4MTExMQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/marketplace/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-26T11:28:29Z","updated_at":"2018-09-26T11:28:29Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=h1) Report\n> Merging [#8950](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=desc) into [master](https://codecov.io/gh/istio/istio/commit/a34bf95f929ffc4c01013b22c35e4469d04c143d?src=pr&el=desc) will **increase** coverage by `1%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/8950/graphs/tree.svg?width=650&token=nYtepj7fDQ&height=150&src=pr)](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master   #8950    +/-   ##\n=======================================\n+ Coverage      70%     70%    +1%     \n=======================================\n  Files         418     418            \n  Lines       38094   37984   -110     \n=======================================\n- Hits        26562   26536    -26     \n+ Misses      10298   10221    -77     \n+ Partials     1234    1227     -7\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...er/adapter/solarwinds/internal/appoptics/client.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zb2xhcndpbmRzL2ludGVybmFsL2FwcG9wdGljcy9jbGllbnQuZ28=) | `40% <0%> (-28%)` | :arrow_down: |\n| [pilot/pkg/config/kube/ingress/status.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2NvbmZpZy9rdWJlL2luZ3Jlc3Mvc3RhdHVzLmdv) | `22% <0%> (-25%)` | :arrow_down: |\n| [pilot/pkg/model/authorization.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL21vZGVsL2F1dGhvcml6YXRpb24uZ28=) | `72% <0%> (-8%)` | :arrow_down: |\n| [pilot/pkg/proxy/envoy/v2/discovery.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3Byb3h5L2Vudm95L3YyL2Rpc2NvdmVyeS5nbw==) | `61% <0%> (-5%)` | :arrow_down: |\n| [mixer/adapter/rbac/rbacStore.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9yYmFjL3JiYWNTdG9yZS5nbw==) | `76% <0%> (-3%)` | :arrow_down: |\n| [...olarwinds/internal/papertrail/papertrail\\_logger.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zb2xhcndpbmRzL2ludGVybmFsL3BhcGVydHJhaWwvcGFwZXJ0cmFpbF9sb2dnZXIuZ28=) | `79% <0%> (-2%)` | :arrow_down: |\n| [mixer/adapter/fluentd/fluentd.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9mbHVlbnRkL2ZsdWVudGQuZ28=) | `74% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/opa/opa.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9vcGEvb3BhLmdv) | `79% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/statsd/statsd.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zdGF0c2Qvc3RhdHNkLmdv) | `96% <0%> (-1%)` | :arrow_down: |\n| [pilot/pkg/networking/core/v1alpha3/listener.go](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL25ldHdvcmtpbmcvY29yZS92MWFscGhhMy9saXN0ZW5lci5nbw==) | `75% <0%> (ø)` | :arrow_down: |\n| ... and [28 more](https://codecov.io/gh/istio/istio/pull/8950/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=footer). Last update [a34bf95...1278ecd](https://codecov.io/gh/istio/istio/pull/8950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}