{"action":"created","issue":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1321","repository_url":"https://api.github.com/repos/react-native-community/react-native-video","labels_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1321/labels{/name}","comments_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1321/comments","events_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1321/events","html_url":"https://github.com/react-native-community/react-native-video/issues/1321","id":379304263,"node_id":"MDU6SXNzdWUzNzkzMDQyNjM=","number":1321,"title":"Video does not take up entire space","user":{"login":"willds40","id":14314808,"node_id":"MDQ6VXNlcjE0MzE0ODA4","avatar_url":"https://avatars1.githubusercontent.com/u/14314808?v=4","gravatar_id":"","url":"https://api.github.com/users/willds40","html_url":"https://github.com/willds40","followers_url":"https://api.github.com/users/willds40/followers","following_url":"https://api.github.com/users/willds40/following{/other_user}","gists_url":"https://api.github.com/users/willds40/gists{/gist_id}","starred_url":"https://api.github.com/users/willds40/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willds40/subscriptions","organizations_url":"https://api.github.com/users/willds40/orgs","repos_url":"https://api.github.com/users/willds40/repos","events_url":"https://api.github.com/users/willds40/events{/privacy}","received_events_url":"https://api.github.com/users/willds40/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-09T20:07:18Z","updated_at":"2018-11-19T14:35:26Z","closed_at":"2018-11-19T14:35:26Z","author_association":"NONE","body":"### Current behavior\r\nWhen video loads, video leaves a border around it. Even when set to take up the entire space of the container, there is still empty space around the video. \r\n\r\nhttps://user-images.githubusercontent.com/14314808/48285417-8bcf9380-e430-11e8-8f34-d0dc1a129e01.png\r\n\r\n### Reproduction steps\r\n\r\n**Styles** \r\n\r\n  videoPlayer: {\r\n    position: 'absolute',\r\n    top:0,\r\n    left: 0,\r\n    bottom: 0,\r\n    right: 0,\r\n  },\r\nvideo_player_container: {\r\n    flex:.4,\r\n    justifyContent: 'center',\r\n    alignItems: 'center',\r\n    backgroundColor: Colors.black,\r\n  },\r\n\r\n**Video player render function** \r\n\r\n<View style={this.state.fullScreen === true ? styles.video_player_container_fullscreen : styles.video_player_container}>\r\n            {this.state.spinnerVisible !== true || this.props.hidden ? null :\r\n            <View style={[styles.activityContainer, styles.activityHorizontal]}>\r\n              <ActivityIndicator size=\"large\" color={Colors.primary_red} />\r\n            </View>\r\n            }\r\n            {this.captionsLoaded() ?\r\n              <Video\r\n                audioOnly={this.props.AvType==='audio' ? true : false}\r\n                ref={(ref) => {\r\n                  this.player = ref\r\n                }}\r\n                source={{uri:mediaItem.url}}\r\n                style={styles.videoPlayer}\r\n                textTracks={\r\n                  this.captionsExist() ?\r\n                    [{\r\n                      title: \"English\",\r\n                      language: \"en\",\r\n                      type: \"text/vtt\",\r\n                      uri: this.state.captionsFilePath\r\n                    },\r\n                    {\r\n                      title: \"empty\",\r\n                      language: \"en\",\r\n                      type: \"text/vtt\",\r\n                      uri: this.state.emptyCaptionFilePath\r\n                    }]\r\n                    : null\r\n                }\r\n                selectedTextTrack={this.state.captionsFilePath ? this.state.captions : null}\r\n                rate={this.state.rate}\r\n                paused={this.props.paused}\r\n                volume={this.state.volume}\r\n                muted={this.state.muted}\r\n                resizeMode={this.state.resizeMode}\r\n                onProgress={this.onProgress}\r\n                onLoad={this.onLoad}\r\n                onEnd={this.onEnd}\r\n              />\r\n              : null\r\n            }\r\n\r\n### Expected behavior\r\nVideo takes up entire space of container. \r\n\r\n### Platform\r\nWhich player are you experiencing the problem on:\r\n* Android ExoPlayer\r\n"},"comment":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/comments/439913109","html_url":"https://github.com/react-native-community/react-native-video/issues/1321#issuecomment-439913109","issue_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1321","id":439913109,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkxMzEwOQ==","user":{"login":"willds40","id":14314808,"node_id":"MDQ6VXNlcjE0MzE0ODA4","avatar_url":"https://avatars1.githubusercontent.com/u/14314808?v=4","gravatar_id":"","url":"https://api.github.com/users/willds40","html_url":"https://github.com/willds40","followers_url":"https://api.github.com/users/willds40/followers","following_url":"https://api.github.com/users/willds40/following{/other_user}","gists_url":"https://api.github.com/users/willds40/gists{/gist_id}","starred_url":"https://api.github.com/users/willds40/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willds40/subscriptions","organizations_url":"https://api.github.com/users/willds40/orgs","repos_url":"https://api.github.com/users/willds40/repos","events_url":"https://api.github.com/users/willds40/events{/privacy}","received_events_url":"https://api.github.com/users/willds40/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T14:35:26Z","updated_at":"2018-11-19T14:35:26Z","author_association":"NONE","body":"I was using \"contain\" and the was definitely the issue. I apologize. I am not sure how we missed that, "}}
{"actor":{"display_login":"willds40"}}