{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/244512683","pull_request_review_id":188422804,"id":244512683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUxMjY4Mw==","diff_hunk":"@@ -35,11 +35,21 @@ constexpr inline size_t ceilToMultiple(size_t a, size_t b) {\n   return ((a + b - 1) / b) * b;\n }\n \n+#if defined(__MACH__) && !defined(CLOCK_REALTIME)\n+#include <sys/time.h>\n+// clock_gettime is not implemented on older versions of OS X (< 10.12).\n+// If implemented, CLOCK_REALTIME will have already been defined.\n+#endif\n+\n inline int64_t getTime() {\n #ifdef _WIN32\n   using namespace std::chrono;\n   using clock = std::conditional<high_resolution_clock::is_steady, high_resolution_clock, steady_clock>::type;\n   return duration_cast<nanoseconds>(clock::now().time_since_epoch()).count();\n+#elif defined(__MACH__) && !defined(CLOCK_REALTIME)\n+  struct timeval now;\n+  gettimeofday(&now, NULL);","path":"torch/csrc/autograd/profiler.h","position":17,"original_position":17,"commit_id":"f2ea748a12d1035758981967ca4d716ffad2ce63","original_commit_id":"f2ea748a12d1035758981967ca4d716ffad2ce63","user":{"login":"hmaarrfk","id":90008,"node_id":"MDQ6VXNlcjkwMDA4","avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"body":"I did not profile it.\r\n\r\nMaybe it is better to simply use `std::chrono`","created_at":"2018-12-29T21:45:19Z","updated_at":"2018-12-29T21:45:19Z","html_url":"https://github.com/pytorch/pytorch/pull/15615#discussion_r244512683","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15615","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/244512683"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15615#discussion_r244512683"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15615"}},"in_reply_to_id":244511784},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/15615","id":241453820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDUzODIw","html_url":"https://github.com/pytorch/pytorch/pull/15615","diff_url":"https://github.com/pytorch/pytorch/pull/15615.diff","patch_url":"https://github.com/pytorch/pytorch/pull/15615.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/15615","number":15615,"state":"open","locked":false,"title":"Add a patch for OSX with SDK<10.12","user":{"login":"hmaarrfk","id":90008,"node_id":"MDQ6VXNlcjkwMDA4","avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/pytorch/pytorch/issues/15614\r\n\r\nBuild passing on SDK 10.9\r\nhttps://dev.azure.com/ramonaoptics/feedstock-builds/_build/results?buildId=13","created_at":"2018-12-29T16:18:59Z","updated_at":"2018-12-29T21:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9595ff66088a317c874ca502ba5cc20dd377427a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15615/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15615/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/15615/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/f2ea748a12d1035758981967ca4d716ffad2ce63","head":{"label":"hmaarrfk:osx_less_than_10_12","ref":"osx_less_than_10_12","sha":"f2ea748a12d1035758981967ca4d716ffad2ce63","user":{"login":"hmaarrfk","id":90008,"node_id":"MDQ6VXNlcjkwMDA4","avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"repo":{"id":163524244,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM1MjQyNDQ=","name":"pytorch","full_name":"hmaarrfk/pytorch","private":false,"owner":{"login":"hmaarrfk","id":90008,"node_id":"MDQ6VXNlcjkwMDA4","avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hmaarrfk/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/hmaarrfk/pytorch","forks_url":"https://api.github.com/repos/hmaarrfk/pytorch/forks","keys_url":"https://api.github.com/repos/hmaarrfk/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmaarrfk/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmaarrfk/pytorch/teams","hooks_url":"https://api.github.com/repos/hmaarrfk/pytorch/hooks","issue_events_url":"https://api.github.com/repos/hmaarrfk/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/hmaarrfk/pytorch/events","assignees_url":"https://api.github.com/repos/hmaarrfk/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/hmaarrfk/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/hmaarrfk/pytorch/tags","blobs_url":"https://api.github.com/repos/hmaarrfk/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmaarrfk/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmaarrfk/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmaarrfk/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmaarrfk/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/hmaarrfk/pytorch/languages","stargazers_url":"https://api.github.com/repos/hmaarrfk/pytorch/stargazers","contributors_url":"https://api.github.com/repos/hmaarrfk/pytorch/contributors","subscribers_url":"https://api.github.com/repos/hmaarrfk/pytorch/subscribers","subscription_url":"https://api.github.com/repos/hmaarrfk/pytorch/subscription","commits_url":"https://api.github.com/repos/hmaarrfk/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmaarrfk/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmaarrfk/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmaarrfk/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmaarrfk/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/hmaarrfk/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmaarrfk/pytorch/merges","archive_url":"https://api.github.com/repos/hmaarrfk/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmaarrfk/pytorch/downloads","issues_url":"https://api.github.com/repos/hmaarrfk/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/hmaarrfk/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/hmaarrfk/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/hmaarrfk/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmaarrfk/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/hmaarrfk/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/hmaarrfk/pytorch/deployments","created_at":"2018-12-29T16:16:13Z","updated_at":"2018-12-29T16:16:28Z","pushed_at":"2018-12-29T16:18:36Z","git_url":"git://github.com/hmaarrfk/pytorch.git","ssh_url":"git@github.com:hmaarrfk/pytorch.git","clone_url":"https://github.com/hmaarrfk/pytorch.git","svn_url":"https://github.com/hmaarrfk/pytorch","homepage":"https://pytorch.org","size":97787,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"d3e55402760c146dc75890374478abe63caf2ff2","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-12-29T21:24:28Z","pushed_at":"2018-12-29T21:04:41Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":97781,"stargazers_count":23260,"watchers_count":23260,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5498,"mirror_url":null,"archived":false,"open_issues_count":2379,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5498,"open_issues":2379,"watchers":23260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15615"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15615"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15615"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15615/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15615/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15615/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/f2ea748a12d1035758981967ca4d716ffad2ce63"}},"author_association":"NONE"}}
{"actor":{"display_login":"hmaarrfk"}}