{"action":"closed","number":357,"pull_request":{"url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357","id":213231187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjMxMTg3","html_url":"https://github.com/nginxinc/kubernetes-ingress/pull/357","diff_url":"https://github.com/nginxinc/kubernetes-ingress/pull/357.diff","patch_url":"https://github.com/nginxinc/kubernetes-ingress/pull/357.patch","issue_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/357","number":357,"state":"closed","locked":false,"title":"Improve Project Layout and Refactor Controller Package","user":{"login":"peterkellyonline","id":659713,"node_id":"MDQ6VXNlcjY1OTcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/659713?v=4","gravatar_id":"","url":"https://api.github.com/users/peterkellyonline","html_url":"https://github.com/peterkellyonline","followers_url":"https://api.github.com/users/peterkellyonline/followers","following_url":"https://api.github.com/users/peterkellyonline/following{/other_user}","gists_url":"https://api.github.com/users/peterkellyonline/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkellyonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkellyonline/subscriptions","organizations_url":"https://api.github.com/users/peterkellyonline/orgs","repos_url":"https://api.github.com/users/peterkellyonline/repos","events_url":"https://api.github.com/users/peterkellyonline/events{/privacy}","received_events_url":"https://api.github.com/users/peterkellyonline/received_events","type":"User","site_admin":false},"body":"### Proposed changes\r\nAfter the project restructure PR (this branch is branches from that one), this PR then pulls apart some of the complexity in the load balancer controller. Extracts handlers and builds them separately.\r\n\r\n### Checklist\r\nBefore creating a PR, run through this checklist and mark each as complete.\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/nginxinc/kubernetes-ingress/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have checked that all unit tests pass after adding my changes\r\n- [x] I have updated necessary documentation\r\n- [x] I have rebased my branch onto master\r\n- [x] I will ensure my PR is targeting the master branch and pulling from my branch from my own fork\r\n","created_at":"2018-09-05T09:43:49Z","updated_at":"2018-09-06T15:39:10Z","closed_at":"2018-09-06T15:39:10Z","merged_at":"2018-09-06T15:39:10Z","merge_commit_sha":"cca138907d88e41956ca0a25351723cb8f054dc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1029519941,"node_id":"MDU6TGFiZWwxMDI5NTE5OTQx","url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/labels/change","name":"change","color":"b60205","default":false},{"id":339158748,"node_id":"MDU6TGFiZWwzMzkxNTg3NDg=","url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357/commits","review_comments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357/comments","review_comment_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/357/comments","statuses_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/statuses/2f3931046773ffa75bdba024d7d4e5faf4f55a46","head":{"label":"nginxinc:controller-refactor","ref":"controller-refactor","sha":"2f3931046773ffa75bdba024d7d4e5faf4f55a46","user":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"repo":{"id":53553027,"node_id":"MDEwOlJlcG9zaXRvcnk1MzU1MzAyNw==","name":"kubernetes-ingress","full_name":"nginxinc/kubernetes-ingress","owner":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nginxinc/kubernetes-ingress","description":"NGINX and  NGINX Plus Ingress Controllers for Kubernetes","fork":false,"url":"https://api.github.com/repos/nginxinc/kubernetes-ingress","forks_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/forks","keys_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/teams","hooks_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/hooks","issue_events_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/events","assignees_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/tags","blobs_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/languages","stargazers_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/stargazers","contributors_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/contributors","subscribers_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/subscribers","subscription_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/subscription","commits_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/merges","archive_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/downloads","issues_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/labels{/name}","releases_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/deployments","created_at":"2016-03-10T03:45:12Z","updated_at":"2018-09-04T17:43:11Z","pushed_at":"2018-09-06T15:39:10Z","git_url":"git://github.com/nginxinc/kubernetes-ingress.git","ssh_url":"git@github.com:nginxinc/kubernetes-ingress.git","clone_url":"https://github.com/nginxinc/kubernetes-ingress.git","svn_url":"https://github.com/nginxinc/kubernetes-ingress","homepage":null,"size":22571,"stargazers_count":954,"watchers_count":954,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":364,"open_issues":27,"watchers":954,"default_branch":"master"}},"base":{"label":"nginxinc:master","ref":"master","sha":"9eb93252c90da84f6cd35759fa65aa8450bb4395","user":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"repo":{"id":53553027,"node_id":"MDEwOlJlcG9zaXRvcnk1MzU1MzAyNw==","name":"kubernetes-ingress","full_name":"nginxinc/kubernetes-ingress","owner":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nginxinc/kubernetes-ingress","description":"NGINX and  NGINX Plus Ingress Controllers for Kubernetes","fork":false,"url":"https://api.github.com/repos/nginxinc/kubernetes-ingress","forks_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/forks","keys_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/teams","hooks_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/hooks","issue_events_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/events","assignees_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/tags","blobs_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/languages","stargazers_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/stargazers","contributors_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/contributors","subscribers_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/subscribers","subscription_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/subscription","commits_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/merges","archive_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/downloads","issues_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/labels{/name}","releases_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/nginxinc/kubernetes-ingress/deployments","created_at":"2016-03-10T03:45:12Z","updated_at":"2018-09-04T17:43:11Z","pushed_at":"2018-09-06T15:39:10Z","git_url":"git://github.com/nginxinc/kubernetes-ingress.git","ssh_url":"git@github.com:nginxinc/kubernetes-ingress.git","clone_url":"https://github.com/nginxinc/kubernetes-ingress.git","svn_url":"https://github.com/nginxinc/kubernetes-ingress","homepage":null,"size":22571,"stargazers_count":954,"watchers_count":954,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":364,"open_issues":27,"watchers":954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357"},"html":{"href":"https://github.com/nginxinc/kubernetes-ingress/pull/357"},"issue":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/357"},"comments":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/nginxinc/kubernetes-ingress/statuses/2f3931046773ffa75bdba024d7d4e5faf4f55a46"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"peterkellyonline","id":659713,"node_id":"MDQ6VXNlcjY1OTcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/659713?v=4","gravatar_id":"","url":"https://api.github.com/users/peterkellyonline","html_url":"https://github.com/peterkellyonline","followers_url":"https://api.github.com/users/peterkellyonline/followers","following_url":"https://api.github.com/users/peterkellyonline/following{/other_user}","gists_url":"https://api.github.com/users/peterkellyonline/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkellyonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkellyonline/subscriptions","organizations_url":"https://api.github.com/users/peterkellyonline/orgs","repos_url":"https://api.github.com/users/peterkellyonline/repos","events_url":"https://api.github.com/users/peterkellyonline/events{/privacy}","received_events_url":"https://api.github.com/users/peterkellyonline/received_events","type":"User","site_admin":false},"comments":2,"review_comments":14,"maintainer_can_modify":false,"commits":10,"additions":1017,"deletions":812,"changed_files":79}}
{"actor":{"display_login":"peterkellyonline"}}