{"action":"closed","number":259,"pull_request":{"url":"https://api.github.com/repos/elastic/ecs/pulls/259","id":236980647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTgwNjQ3","html_url":"https://github.com/elastic/ecs/pull/259","diff_url":"https://github.com/elastic/ecs/pull/259.diff","patch_url":"https://github.com/elastic/ecs/pull/259.patch","issue_url":"https://api.github.com/repos/elastic/ecs/issues/259","number":259,"state":"closed","locked":false,"title":"Add `os.full`, to allow capturing full OS name string, including version","user":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"body":"I think having a field with the full OS name (including version) is a useful concept, in addition to the broken up `name` + `version` fields. It makes some types of analysis much simpler.\n\nI was inspired to add this when I realized that our user agent parser gives us such a string, and ECS doesn't have a home for it.","created_at":"2018-12-07T20:10:43Z","updated_at":"2018-12-11T15:47:08Z","closed_at":"2018-12-11T15:47:07Z","merged_at":"2018-12-11T15:47:07Z","merge_commit_sha":"e50891b57bb317deff0e275bc84bf8a36554929b","assignee":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"assignees":[{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/ecs/pulls/259/commits","review_comments_url":"https://api.github.com/repos/elastic/ecs/pulls/259/comments","review_comment_url":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/ecs/issues/259/comments","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/d14bb32c73edb9f7054f7feb31dc0de13474a5e5","head":{"label":"webmat:os-full-name","ref":"os-full-name","sha":"d14bb32c73edb9f7054f7feb31dc0de13474a5e5","user":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"repo":{"id":137914483,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MTQ0ODM=","name":"ecs","full_name":"webmat/ecs","private":false,"owner":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/webmat/ecs","description":"Elastic Common Schema","fork":true,"url":"https://api.github.com/repos/webmat/ecs","forks_url":"https://api.github.com/repos/webmat/ecs/forks","keys_url":"https://api.github.com/repos/webmat/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmat/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmat/ecs/teams","hooks_url":"https://api.github.com/repos/webmat/ecs/hooks","issue_events_url":"https://api.github.com/repos/webmat/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/webmat/ecs/events","assignees_url":"https://api.github.com/repos/webmat/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/webmat/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/webmat/ecs/tags","blobs_url":"https://api.github.com/repos/webmat/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmat/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmat/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmat/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmat/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/webmat/ecs/languages","stargazers_url":"https://api.github.com/repos/webmat/ecs/stargazers","contributors_url":"https://api.github.com/repos/webmat/ecs/contributors","subscribers_url":"https://api.github.com/repos/webmat/ecs/subscribers","subscription_url":"https://api.github.com/repos/webmat/ecs/subscription","commits_url":"https://api.github.com/repos/webmat/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmat/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmat/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmat/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmat/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/webmat/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmat/ecs/merges","archive_url":"https://api.github.com/repos/webmat/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmat/ecs/downloads","issues_url":"https://api.github.com/repos/webmat/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/webmat/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/webmat/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/webmat/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmat/ecs/labels{/name}","releases_url":"https://api.github.com/repos/webmat/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/webmat/ecs/deployments","created_at":"2018-06-19T16:00:57Z","updated_at":"2018-12-06T21:05:37Z","pushed_at":"2018-12-11T15:43:20Z","git_url":"git://github.com/webmat/ecs.git","ssh_url":"git@github.com:webmat/ecs.git","clone_url":"https://github.com/webmat/ecs.git","svn_url":"https://github.com/webmat/ecs","homepage":null,"size":529,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"5d62e2e9d5aca5e94b3d2213caaefb0d5fcf61ce","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":134683798,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2ODM3OTg=","name":"ecs","full_name":"elastic/ecs","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/ecs","description":"Elastic Common Schema","fork":false,"url":"https://api.github.com/repos/elastic/ecs","forks_url":"https://api.github.com/repos/elastic/ecs/forks","keys_url":"https://api.github.com/repos/elastic/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/ecs/teams","hooks_url":"https://api.github.com/repos/elastic/ecs/hooks","issue_events_url":"https://api.github.com/repos/elastic/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/ecs/events","assignees_url":"https://api.github.com/repos/elastic/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/ecs/tags","blobs_url":"https://api.github.com/repos/elastic/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/ecs/languages","stargazers_url":"https://api.github.com/repos/elastic/ecs/stargazers","contributors_url":"https://api.github.com/repos/elastic/ecs/contributors","subscribers_url":"https://api.github.com/repos/elastic/ecs/subscribers","subscription_url":"https://api.github.com/repos/elastic/ecs/subscription","commits_url":"https://api.github.com/repos/elastic/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/ecs/merges","archive_url":"https://api.github.com/repos/elastic/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/ecs/downloads","issues_url":"https://api.github.com/repos/elastic/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/ecs/labels{/name}","releases_url":"https://api.github.com/repos/elastic/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/ecs/deployments","created_at":"2018-05-24T08:16:29Z","updated_at":"2018-12-11T14:24:55Z","pushed_at":"2018-12-11T15:47:07Z","git_url":"git://github.com/elastic/ecs.git","ssh_url":"git@github.com:elastic/ecs.git","clone_url":"https://github.com/elastic/ecs.git","svn_url":"https://github.com/elastic/ecs","homepage":null,"size":432,"stargazers_count":135,"watchers_count":135,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":83,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/ecs/pulls/259"},"html":{"href":"https://github.com/elastic/ecs/pull/259"},"issue":{"href":"https://api.github.com/repos/elastic/ecs/issues/259"},"comments":{"href":"https://api.github.com/repos/elastic/ecs/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/ecs/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/ecs/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/ecs/statuses/d14bb32c73edb9f7054f7feb31dc0de13474a5e5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"maintainer_can_modify":false,"commits":6,"additions":28,"deletions":7,"changed_files":6}}
{"actor":{"display_login":"webmat"}}