{"action":"closed","number":1539,"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539","id":136255315,"node_id":"MDExOlB1bGxSZXF1ZXN0MTM2MjU1MzE1","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/1539","diff_url":"https://github.com/kubernetes-incubator/kubespray/pull/1539.diff","patch_url":"https://github.com/kubernetes-incubator/kubespray/pull/1539.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/1539","number":1539,"state":"closed","locked":false,"title":"Added default value for weave_mode_seed in weave role","user":{"login":"kidk","id":184273,"node_id":"MDQ6VXNlcjE4NDI3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/184273?v=4","gravatar_id":"","url":"https://api.github.com/users/kidk","html_url":"https://github.com/kidk","followers_url":"https://api.github.com/users/kidk/followers","following_url":"https://api.github.com/users/kidk/following{/other_user}","gists_url":"https://api.github.com/users/kidk/gists{/gist_id}","starred_url":"https://api.github.com/users/kidk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidk/subscriptions","organizations_url":"https://api.github.com/users/kidk/orgs","repos_url":"https://api.github.com/users/kidk/repos","events_url":"https://api.github.com/users/kidk/events{/privacy}","received_events_url":"https://api.github.com/users/kidk/received_events","type":"User","site_admin":false},"body":"When running the playbook with weave enabled the 'weave_mode_seed' is not defined which makes it default to seed mode for some reason. \r\n\r\n`roles/network_plugin/weave/tasks/main.yml` uses this variable, without setting weave_mode_seed it runs the `seed.yml` file. \r\n```\r\n- include: seed.yml\r\n  when: weave_mode_seed \r\n```\r\n\r\nI added the default to the role defaults file. I think this only happens when running the playbook through ansible, and not with kubespray-cli. ","created_at":"2017-08-17T13:21:28Z","updated_at":"2018-08-16T14:43:56Z","closed_at":"2018-08-16T14:43:56Z","merged_at":null,"merge_commit_sha":"9efb0f82d8b11363a24e43575f6afe8282f130e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485769464,"node_id":"MDU6TGFiZWw0ODU3Njk0NjQ=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":677476400,"node_id":"MDU6TGFiZWw2Nzc0NzY0MDA=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/size/XS","name":"size/XS","color":"ededed","default":false},{"id":1025230032,"node_id":"MDU6TGFiZWwxMDI1MjMwMDMy","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/stale","name":"stale","color":"efdd69","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/1539/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/aea605df826313c416eefd5fecd30e33e9d93180","head":{"label":"kidk:patch-1","ref":"patch-1","sha":"aea605df826313c416eefd5fecd30e33e9d93180","user":{"login":"kidk","id":184273,"node_id":"MDQ6VXNlcjE4NDI3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/184273?v=4","gravatar_id":"","url":"https://api.github.com/users/kidk","html_url":"https://github.com/kidk","followers_url":"https://api.github.com/users/kidk/followers","following_url":"https://api.github.com/users/kidk/following{/other_user}","gists_url":"https://api.github.com/users/kidk/gists{/gist_id}","starred_url":"https://api.github.com/users/kidk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidk/subscriptions","organizations_url":"https://api.github.com/users/kidk/orgs","repos_url":"https://api.github.com/users/kidk/repos","events_url":"https://api.github.com/users/kidk/events{/privacy}","received_events_url":"https://api.github.com/users/kidk/received_events","type":"User","site_admin":false},"repo":{"id":100605279,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDUyNzk=","name":"kubespray","full_name":"kidk/kubespray","owner":{"login":"kidk","id":184273,"node_id":"MDQ6VXNlcjE4NDI3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/184273?v=4","gravatar_id":"","url":"https://api.github.com/users/kidk","html_url":"https://github.com/kidk","followers_url":"https://api.github.com/users/kidk/followers","following_url":"https://api.github.com/users/kidk/following{/other_user}","gists_url":"https://api.github.com/users/kidk/gists{/gist_id}","starred_url":"https://api.github.com/users/kidk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidk/subscriptions","organizations_url":"https://api.github.com/users/kidk/orgs","repos_url":"https://api.github.com/users/kidk/repos","events_url":"https://api.github.com/users/kidk/events{/privacy}","received_events_url":"https://api.github.com/users/kidk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kidk/kubespray","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/kidk/kubespray","forks_url":"https://api.github.com/repos/kidk/kubespray/forks","keys_url":"https://api.github.com/repos/kidk/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kidk/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kidk/kubespray/teams","hooks_url":"https://api.github.com/repos/kidk/kubespray/hooks","issue_events_url":"https://api.github.com/repos/kidk/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/kidk/kubespray/events","assignees_url":"https://api.github.com/repos/kidk/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/kidk/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/kidk/kubespray/tags","blobs_url":"https://api.github.com/repos/kidk/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kidk/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kidk/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/kidk/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kidk/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/kidk/kubespray/languages","stargazers_url":"https://api.github.com/repos/kidk/kubespray/stargazers","contributors_url":"https://api.github.com/repos/kidk/kubespray/contributors","subscribers_url":"https://api.github.com/repos/kidk/kubespray/subscribers","subscription_url":"https://api.github.com/repos/kidk/kubespray/subscription","commits_url":"https://api.github.com/repos/kidk/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/kidk/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/kidk/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/kidk/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/kidk/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/kidk/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kidk/kubespray/merges","archive_url":"https://api.github.com/repos/kidk/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kidk/kubespray/downloads","issues_url":"https://api.github.com/repos/kidk/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/kidk/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/kidk/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/kidk/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kidk/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/kidk/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/kidk/kubespray/deployments","created_at":"2017-08-17T13:16:38Z","updated_at":"2017-08-17T13:16:40Z","pushed_at":"2018-06-06T12:17:38Z","git_url":"git://github.com/kidk/kubespray.git","ssh_url":"git@github.com:kidk/kubespray.git","clone_url":"https://github.com/kidk/kubespray.git","svn_url":"https://github.com/kidk/kubespray","homepage":"","size":7561,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"9a3c6f236d6c77c3e5c86f82286a80b55bbaee41","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"node_id":"MDEwOlJlcG9zaXRvcnk0MzYxMzQwNA==","name":"kubespray","full_name":"kubernetes-incubator/kubespray","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kubespray","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kubespray","forks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2018-08-16T14:17:19Z","pushed_at":"2018-08-16T14:17:02Z","git_url":"git://github.com/kubernetes-incubator/kubespray.git","ssh_url":"git@github.com:kubernetes-incubator/kubespray.git","clone_url":"https://github.com/kubernetes-incubator/kubespray.git","svn_url":"https://github.com/kubernetes-incubator/kubespray","homepage":"","size":8054,"stargazers_count":3643,"watchers_count":3643,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1438,"mirror_url":null,"archived":false,"open_issues_count":442,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1438,"open_issues":442,"watchers":3643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/1539"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/1539"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/1539/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/1539/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/aea605df826313c416eefd5fecd30e33e9d93180"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"kidk"}}