{"action":"created","comment":{"url":"https://api.github.com/repos/discourse/discourse/pulls/comments/203941120","pull_request_review_id":138932271,"id":203941120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzk0MTEyMA==","diff_hunk":"@@ -18,6 +19,9 @@ export default Ember.Component.extend(\n     buildBuffer(buffer) {\n       if (!this.get(\"executeAt\")) return;\n \n+      const topicClosed = this.get(\"topicClosed\");\n+      if (topicClosed != null && (topicClosed ? \"close\" : \"open\") === this.get(\"statusType\")) return;","path":"app/assets/javascripts/discourse/components/topic-timer-info.js.es6","position":13,"original_position":13,"commit_id":"3f52e9d319219131fedf540eb70fd62dcf155553","original_commit_id":"3f52e9d319219131fedf540eb70fd62dcf155553","user":{"login":"jjaffeux","id":339945,"node_id":"MDQ6VXNlcjMzOTk0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/339945?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaffeux","html_url":"https://github.com/jjaffeux","followers_url":"https://api.github.com/users/jjaffeux/followers","following_url":"https://api.github.com/users/jjaffeux/following{/other_user}","gists_url":"https://api.github.com/users/jjaffeux/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaffeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaffeux/subscriptions","organizations_url":"https://api.github.com/users/jjaffeux/orgs","repos_url":"https://api.github.com/users/jjaffeux/repos","events_url":"https://api.github.com/users/jjaffeux/events{/privacy}","received_events_url":"https://api.github.com/users/jjaffeux/received_events","type":"User","site_admin":false},"body":"`!=` is not valid should be `!=='\r\n\r\nBut in this case:\r\n\r\n```es6\r\nif (topicClosed && (topicClosed ? \"close\" : \"open\") === this.get(\"statusType\")) {\r\n  return;\r\n}\r\n```\r\n\r\nshould be enough","created_at":"2018-07-20T05:31:00Z","updated_at":"2018-07-20T05:31:00Z","html_url":"https://github.com/discourse/discourse/pull/6123#discussion_r203941120","pull_request_url":"https://api.github.com/repos/discourse/discourse/pulls/6123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments/203941120"},"html":{"href":"https://github.com/discourse/discourse/pull/6123#discussion_r203941120"},"pull_request":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6123"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/6123","id":202746963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzQ2OTYz","html_url":"https://github.com/discourse/discourse/pull/6123","diff_url":"https://github.com/discourse/discourse/pull/6123.diff","patch_url":"https://github.com/discourse/discourse/pull/6123.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/6123","number":6123,"state":"open","locked":false,"title":"UX: clear topic timer text when manually closing/opening","user":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"body":"> CONTEXT & DISCUSSION: https://meta.discourse.org/t/closing-a-topic-manually-doesnt-clear-the-topic-timers-automatic-closure/86203\r\n\r\nAs per title, a (hopefully) minor UX change. [Here](https://meta.discourse.org/t/closing-a-topic-manually-doesnt-clear-the-topic-timers-automatic-closure/86203/4?u=xrav3nz) is a demo of the changes.","created_at":"2018-07-20T04:59:50Z","updated_at":"2018-07-20T05:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"674ee92718609cd379e64c9285da78a6ddf4f333","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/6123/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/6123/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/6123/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/3f52e9d319219131fedf540eb70fd62dcf155553","head":{"label":"xrav3nz:ux/clear-topic-timer-when-closing","ref":"ux/clear-topic-timer-when-closing","sha":"3f52e9d319219131fedf540eb70fd62dcf155553","user":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"repo":{"id":99668064,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY2ODA2NA==","name":"discourse","full_name":"xrav3nz/discourse","owner":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xrav3nz/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/xrav3nz/discourse","forks_url":"https://api.github.com/repos/xrav3nz/discourse/forks","keys_url":"https://api.github.com/repos/xrav3nz/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xrav3nz/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xrav3nz/discourse/teams","hooks_url":"https://api.github.com/repos/xrav3nz/discourse/hooks","issue_events_url":"https://api.github.com/repos/xrav3nz/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/xrav3nz/discourse/events","assignees_url":"https://api.github.com/repos/xrav3nz/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/xrav3nz/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/xrav3nz/discourse/tags","blobs_url":"https://api.github.com/repos/xrav3nz/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xrav3nz/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xrav3nz/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/xrav3nz/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xrav3nz/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/xrav3nz/discourse/languages","stargazers_url":"https://api.github.com/repos/xrav3nz/discourse/stargazers","contributors_url":"https://api.github.com/repos/xrav3nz/discourse/contributors","subscribers_url":"https://api.github.com/repos/xrav3nz/discourse/subscribers","subscription_url":"https://api.github.com/repos/xrav3nz/discourse/subscription","commits_url":"https://api.github.com/repos/xrav3nz/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/xrav3nz/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/xrav3nz/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/xrav3nz/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/xrav3nz/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/xrav3nz/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xrav3nz/discourse/merges","archive_url":"https://api.github.com/repos/xrav3nz/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xrav3nz/discourse/downloads","issues_url":"https://api.github.com/repos/xrav3nz/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/xrav3nz/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/xrav3nz/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/xrav3nz/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xrav3nz/discourse/labels{/name}","releases_url":"https://api.github.com/repos/xrav3nz/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/xrav3nz/discourse/deployments","created_at":"2017-08-08T08:13:56Z","updated_at":"2018-07-17T21:16:45Z","pushed_at":"2018-07-20T04:52:05Z","git_url":"git://github.com/xrav3nz/discourse.git","ssh_url":"git@github.com:xrav3nz/discourse.git","clone_url":"https://github.com/xrav3nz/discourse.git","svn_url":"https://github.com/xrav3nz/discourse","homepage":"https://www.discourse.org","size":224565,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"d75d1f0b51e2dab3eb1d0e821f1a6b8090c856f0","user":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY5NTc4","name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2018-07-20T03:59:59Z","pushed_at":"2018-07-20T05:19:18Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":225369,"stargazers_count":25566,"watchers_count":25566,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6133,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6133,"open_issues":12,"watchers":25566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6123"},"html":{"href":"https://github.com/discourse/discourse/pull/6123"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/6123"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/6123/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6123/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6123/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/3f52e9d319219131fedf540eb70fd62dcf155553"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jjaffeux"}}