{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/243103296","pull_request_review_id":186784100,"id":243103296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzEwMzI5Ng==","diff_hunk":"@@ -0,0 +1,314 @@\n+@import \"../../patternfly-utilities\";\n+\n+.pf-c-select {\n+  @extend %pf-t-light; // force the container follow the light theme\n+\n+  // Toggle\n+  --pf-c-select__toggle--PaddingTop: var(--pf-global--spacer--form-element);\n+  --pf-c-select__toggle--PaddingRight: var(--pf-global--spacer--sm);\n+  --pf-c-select__toggle--PaddingBottom: var(--pf-global--spacer--form-element);\n+  --pf-c-select__toggle--PaddingLeft: var(--pf-global--spacer--sm);\n+  --pf-c-select__toggle--MinWidth: var(--pf-global--target-size--MinWidth);\n+  --pf-c-select__toggle--FontSize: var(--pf-global--FontSize--md);\n+  --pf-c-select__toggle--FontWeight: var(--pf-global--FontWeight--normal);\n+  --pf-c-select__toggle--LineHeight: var(--pf-global--LineHeight--md);\n+  --pf-c-select__toggle--BackgroundColor: var(--pf-global--BackgroundColor--light-100);\n+  --pf-c-select__toggle--BorderWidth: var(--pf-global--BorderWidth--sm);\n+  --pf-c-select__toggle--BorderTopColor: var(--pf-global--BorderColor--light-200);\n+  --pf-c-select__toggle--BorderRightColor: var(--pf-global--BorderColor--light-200);\n+  --pf-c-select__toggle--BorderBottomColor: var(--pf-global--BorderColor--dark);\n+  --pf-c-select__toggle--BorderLeftColor: var(--pf-global--BorderColor--light-200);\n+  --pf-c-select__toggle--Color: var(--pf-global--Color--100);\n+  --pf-c-select__toggle--hover--BorderBottomColor: var(--pf-global--active-color--100);\n+  --pf-c-select__toggle--expanded--BorderBottomWidth: var(--pf-global--BorderWidth--md);\n+  --pf-c-select__toggle--expanded--BorderBottomColor: var(--pf-global--active-color--100);\n+  --pf-c-select__toggle--m-plain--BorderColor: transparent;\n+\n+  // Space for the children of the toggle\n+  --pf-c-select-toggle__wrapper--not-last-child--MarginRight: var(--pf-global--spacer--xs);\n+\n+  // Max-width is needed for ellipsing the text. This leaves enough space for the toggle caret.\n+  // However, for cases where the clear icon button or a badge are added, the correct width will need to be calculated in script\n+  --pf-c-select-toggle__wrapper--MaxWidth: calc(100% - var(--pf-global--spacer--lg));\n+\n+  // The button inside a chip must be adjusted to reduce the padding, which is driving the height of the chip, so it fits within the toggle\n+  --pf-c-select-toggle__wrapper--c-chip--c-button--PaddingTop: var(--pf-global--spacer--xs);\n+  --pf-c-select-toggle__wrapper--c-chip--c-button--PaddingBottom: var(--pf-global--spacer--xs);\n+\n+  // Select input for typeahead\n+  --pf-c-select-toggle__typeahead--FlexBasis: 10em;\n+  --pf-c-select-toggle__typeahead--BackgroundColor: transparent;\n+  --pf-c-select-toggle__typeahead--BorderTop: none;\n+  --pf-c-select-toggle__typeahead--BorderRight: none;\n+  --pf-c-select-toggle__typeahead--BorderLeft: none;\n+\n+  // Select toggle clear button\n+  --pf-c-select-toggle__clear--PaddingRight: var(--pf-global--spacer--xs);\n+\n+  // Select toggle badge\n+  --pf-c-select-toggle__badge--PaddingLeft: var(--pf-global--spacer--md);\n+\n+  // Toggle Arrow\n+  --pf-c-select-toggle__arrow--MarginLeft: var(--pf-global--spacer--md);\n+  --pf-c-select-toggle__arrow--BorderWidth: var(--pf-global--BorderWidth--md);\n+\n+  // Menu\n+  --pf-c-select__menu--BackgroundColor: var(--pf-global--BackgroundColor--light-100);\n+  --pf-c-select__menu--BorderWidth: var(--pf-global--BorderWidth--sm);\n+  --pf-c-select__menu--BorderColor: var(--pf-global--BorderColor);\n+  --pf-c-select__menu--BoxShadow: var(--pf-global--BoxShadow--md);\n+  --pf-c-select__menu--PaddingTop: var(--pf-global--spacer--sm);\n+  --pf-c-select__menu--PaddingBottom: var(--pf-global--spacer--sm);\n+  --pf-c-select__menu--Top: calc(100% + var(--pf-global--spacer--xs)); // The top of the menu must be pushed down to create space between the toggle and menu\n+  --pf-c-select__menu--ZIndex: var(--pf-global--ZIndex--xs);\n+  --pf-c-select__menu--top--Transform: translateY(calc(-100% - var(--pf-global--spacer--xs))); // The \"dropup\" menu must be transformed up and this calculates how much to create space between the toggle and menu","path":"src/patternfly/components/Select/select.scss","position":64,"original_position":64,"commit_id":"479451db510b6f596301c951201f98b91d1d3186","original_commit_id":"479451db510b6f596301c951201f98b91d1d3186","user":{"login":"mcoker","id":35148959,"node_id":"MDQ6VXNlcjM1MTQ4OTU5","avatar_url":"https://avatars0.githubusercontent.com/u/35148959?v=4","gravatar_id":"","url":"https://api.github.com/users/mcoker","html_url":"https://github.com/mcoker","followers_url":"https://api.github.com/users/mcoker/followers","following_url":"https://api.github.com/users/mcoker/following{/other_user}","gists_url":"https://api.github.com/users/mcoker/gists{/gist_id}","starred_url":"https://api.github.com/users/mcoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcoker/subscriptions","organizations_url":"https://api.github.com/users/mcoker/orgs","repos_url":"https://api.github.com/users/mcoker/repos","events_url":"https://api.github.com/users/mcoker/events{/privacy}","received_events_url":"https://api.github.com/users/mcoker/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n  --pf-c-select__menu--m-top--Transform: translateY(calc(-100% - var(--pf-global--spacer--xs))); // The \"dropup\" menu must be transformed up and this calculates how much to create space between the toggle and menu\r\n```","created_at":"2018-12-19T22:48:33Z","updated_at":"2018-12-19T22:48:34Z","html_url":"https://github.com/patternfly/patternfly-next/pull/1096#discussion_r243103296","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/243103296"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/1096#discussion_r243103296"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096","id":237803080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODAzMDgw","html_url":"https://github.com/patternfly/patternfly-next/pull/1096","diff_url":"https://github.com/patternfly/patternfly-next/pull/1096.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/1096.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/1096","number":1096,"state":"open","locked":false,"title":"feat(select): Implements custom select variations","user":{"login":"srambach","id":19825616,"node_id":"MDQ6VXNlcjE5ODI1NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/19825616?v=4","gravatar_id":"","url":"https://api.github.com/users/srambach","html_url":"https://github.com/srambach","followers_url":"https://api.github.com/users/srambach/followers","following_url":"https://api.github.com/users/srambach/following{/other_user}","gists_url":"https://api.github.com/users/srambach/gists{/gist_id}","starred_url":"https://api.github.com/users/srambach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srambach/subscriptions","organizations_url":"https://api.github.com/users/srambach/orgs","repos_url":"https://api.github.com/users/srambach/repos","events_url":"https://api.github.com/users/srambach/events{/privacy}","received_events_url":"https://api.github.com/users/srambach/received_events","type":"User","site_admin":false},"body":"Implements 4 variations of the custom select: single select, single-select with typeahead, multi-select with typeahead, and checkbox select.\r\n\r\n[More details in the Integration document ](https://docs.google.com/document/d/1rrCdARutABI-Vpa_mdMWGl2xJJTtt2dPQ2bjFx2zwCM/edit?usp=sharing)\r\n\r\nNote: some text in the typeahead examples show a yellow highlight; this is leaking in from the workspace and there is an issue for it.\r\n\r\nAlso note: the a11y aria tags, etc. are to be refined as the React implementation solidifies the behavior.\r\n\r\nFixes #651 ","created_at":"2018-12-11T19:39:44Z","updated_at":"2018-12-19T22:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d61021eba891860530416d0108e6fa034ad646b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/1096/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/479451db510b6f596301c951201f98b91d1d3186","head":{"label":"srambach:custom-select","ref":"custom-select","sha":"479451db510b6f596301c951201f98b91d1d3186","user":{"login":"srambach","id":19825616,"node_id":"MDQ6VXNlcjE5ODI1NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/19825616?v=4","gravatar_id":"","url":"https://api.github.com/users/srambach","html_url":"https://github.com/srambach","followers_url":"https://api.github.com/users/srambach/followers","following_url":"https://api.github.com/users/srambach/following{/other_user}","gists_url":"https://api.github.com/users/srambach/gists{/gist_id}","starred_url":"https://api.github.com/users/srambach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srambach/subscriptions","organizations_url":"https://api.github.com/users/srambach/orgs","repos_url":"https://api.github.com/users/srambach/repos","events_url":"https://api.github.com/users/srambach/events{/privacy}","received_events_url":"https://api.github.com/users/srambach/received_events","type":"User","site_admin":false},"repo":{"id":126196181,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTYxODE=","name":"patternfly-next","full_name":"srambach/patternfly-next","private":false,"owner":{"login":"srambach","id":19825616,"node_id":"MDQ6VXNlcjE5ODI1NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/19825616?v=4","gravatar_id":"","url":"https://api.github.com/users/srambach","html_url":"https://github.com/srambach","followers_url":"https://api.github.com/users/srambach/followers","following_url":"https://api.github.com/users/srambach/following{/other_user}","gists_url":"https://api.github.com/users/srambach/gists{/gist_id}","starred_url":"https://api.github.com/users/srambach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srambach/subscriptions","organizations_url":"https://api.github.com/users/srambach/orgs","repos_url":"https://api.github.com/users/srambach/repos","events_url":"https://api.github.com/users/srambach/events{/privacy}","received_events_url":"https://api.github.com/users/srambach/received_events","type":"User","site_admin":false},"html_url":"https://github.com/srambach/patternfly-next","description":"Working repo for patternfly next","fork":true,"url":"https://api.github.com/repos/srambach/patternfly-next","forks_url":"https://api.github.com/repos/srambach/patternfly-next/forks","keys_url":"https://api.github.com/repos/srambach/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srambach/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srambach/patternfly-next/teams","hooks_url":"https://api.github.com/repos/srambach/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/srambach/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/srambach/patternfly-next/events","assignees_url":"https://api.github.com/repos/srambach/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/srambach/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/srambach/patternfly-next/tags","blobs_url":"https://api.github.com/repos/srambach/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srambach/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srambach/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/srambach/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srambach/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/srambach/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/srambach/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/srambach/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/srambach/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/srambach/patternfly-next/subscription","commits_url":"https://api.github.com/repos/srambach/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/srambach/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/srambach/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/srambach/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/srambach/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/srambach/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srambach/patternfly-next/merges","archive_url":"https://api.github.com/repos/srambach/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srambach/patternfly-next/downloads","issues_url":"https://api.github.com/repos/srambach/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/srambach/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/srambach/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/srambach/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srambach/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/srambach/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/srambach/patternfly-next/deployments","created_at":"2018-03-21T15:00:47Z","updated_at":"2018-11-19T15:17:21Z","pushed_at":"2018-12-13T15:35:03Z","git_url":"git://github.com/srambach/patternfly-next.git","ssh_url":"git@github.com:srambach/patternfly-next.git","clone_url":"https://github.com/srambach/patternfly-next.git","svn_url":"https://github.com/srambach/patternfly-next","homepage":null,"size":19007,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"53f5326dde4da83264c52e793d60dd57cf9d489f","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":122507459,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDc0NTk=","name":"patternfly-next","full_name":"patternfly/patternfly-next","private":false,"owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/patternfly/patternfly-next","description":"Working repo for PatternFly 4 https://pf-next.com/","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-next","forks_url":"https://api.github.com/repos/patternfly/patternfly-next/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-next/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-next/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-next/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-next/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-next/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-next/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-next/deployments","created_at":"2018-02-22T16:52:59Z","updated_at":"2018-12-19T15:29:58Z","pushed_at":"2018-12-19T21:52:19Z","git_url":"git://github.com/patternfly/patternfly-next.git","ssh_url":"git@github.com:patternfly/patternfly-next.git","clone_url":"https://github.com/patternfly/patternfly-next.git","svn_url":"https://github.com/patternfly/patternfly-next","homepage":"","size":77460,"stargazers_count":70,"watchers_count":70,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":289,"license":null,"forks":47,"open_issues":289,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/1096"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/1096"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/1096/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/1096/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-next/statuses/479451db510b6f596301c951201f98b91d1d3186"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcoker"}}