{"action":"created","issue":{"url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/176","repository_url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model","labels_url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/176/comments","events_url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/176/events","html_url":"https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/issues/176","id":316299459,"number":176,"title":"Create text file writer to encapsulate report file handle","user":{"login":"michaeltryby","id":6942309,"avatar_url":"https://avatars3.githubusercontent.com/u/6942309?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltryby","html_url":"https://github.com/michaeltryby","followers_url":"https://api.github.com/users/michaeltryby/followers","following_url":"https://api.github.com/users/michaeltryby/following{/other_user}","gists_url":"https://api.github.com/users/michaeltryby/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltryby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltryby/subscriptions","organizations_url":"https://api.github.com/users/michaeltryby/orgs","repos_url":"https://api.github.com/users/michaeltryby/repos","events_url":"https://api.github.com/users/michaeltryby/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltryby/received_events","type":"User","site_admin":false},"labels":[{"id":845134026,"url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/labels/Moderate","name":"Moderate","color":"99efdf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-20T14:52:59Z","updated_at":"2018-04-26T20:12:53Z","closed_at":null,"author_association":"COLLABORATOR","body":"The report file handle is hanging out in global memory space. Code for writing to it is sprinkled across the entire application. This is most evident when logging warnings and errors to the report file. Furthermore, the code for writing and the content to be written is munged together. \r\n\r\nI am currently wrapping global variables in a structure, but this is only perpetuating the problem. A better solution would be to create a text file writer that separates report content and centralizes the code for writing to a file.  \r\n\r\nA logger should also be created for handling errors and warnings. Right now they get dumped to the report file, but the logger should dump anyplace it is directed. Would also be great if the state were managed behind the scenes so file pointers aren't getting passed around all over the place. "},"comment":{"url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/comments/384774222","html_url":"https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/issues/176#issuecomment-384774222","issue_url":"https://api.github.com/repos/OpenWaterAnalytics/Stormwater-Management-Model/issues/176","id":384774222,"user":{"login":"bemcdonnell","id":6105134,"avatar_url":"https://avatars0.githubusercontent.com/u/6105134?v=4","gravatar_id":"","url":"https://api.github.com/users/bemcdonnell","html_url":"https://github.com/bemcdonnell","followers_url":"https://api.github.com/users/bemcdonnell/followers","following_url":"https://api.github.com/users/bemcdonnell/following{/other_user}","gists_url":"https://api.github.com/users/bemcdonnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bemcdonnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemcdonnell/subscriptions","organizations_url":"https://api.github.com/users/bemcdonnell/orgs","repos_url":"https://api.github.com/users/bemcdonnell/repos","events_url":"https://api.github.com/users/bemcdonnell/events{/privacy}","received_events_url":"https://api.github.com/users/bemcdonnell/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T20:12:53Z","updated_at":"2018-04-26T20:12:53Z","author_association":"MEMBER","body":"@dickinsonre, wait... warnings matter? 😄 "}}
{"actor":{"display_login":"bemcdonnell"}}