{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/190883511","pull_request_review_id":123358425,"id":190883511,"diff_hunk":"@@ -231,6 +243,43 @@ typedef struct {\n     spi_misopad_t miso_pad; /**< pad to use for MISO line */\n     spi_mosipad_t mosi_pad; /**< pad to use for MOSI and CLK line */\n } spi_conf_t;\n+/** @} */\n+\n+/**\n+ * @brief   Available SERCOM I2C flag selections\n+ */\n+typedef enum {\n+    I2C_FLAG_NONE            = 0x0,    /**< No flags set */\n+    I2C_FLAG_RUN_STANDBY     = 0x1,    /**< run SERCOM in standby mode */\n+} i2c_flag_t;\n+\n+/**\n+ * @brief   Override SPI clock speed values\n+ * @{","path":"cpu/sam0_common/include/periph_cpu_common.h","position":42,"original_position":42,"commit_id":"c47782a0013a4f3afc14161ebad917dc2b2afab2","original_commit_id":"c47782a0013a4f3afc14161ebad917dc2b2afab2","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"not needed","created_at":"2018-05-25T12:50:16Z","updated_at":"2018-05-25T12:52:59Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/9198#discussion_r190883511","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/190883511"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9198#discussion_r190883511"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198","id":190559348,"html_url":"https://github.com/RIOT-OS/RIOT/pull/9198","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9198.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9198.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9198","number":9198,"state":"open","locked":false,"title":"cpu/sam0: update I2C driver to new API","user":{"login":"dylad","id":22391368,"avatar_url":"https://avatars1.githubusercontent.com/u/22391368?v=4","gravatar_id":"","url":"https://api.github.com/users/dylad","html_url":"https://github.com/dylad","followers_url":"https://api.github.com/users/dylad/followers","following_url":"https://api.github.com/users/dylad/following{/other_user}","gists_url":"https://api.github.com/users/dylad/gists{/gist_id}","starred_url":"https://api.github.com/users/dylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylad/subscriptions","organizations_url":"https://api.github.com/users/dylad/orgs","repos_url":"https://api.github.com/users/dylad/repos","events_url":"https://api.github.com/users/dylad/events{/privacy}","received_events_url":"https://api.github.com/users/dylad/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\nThis PR updates the I2C driver from sam0 families CPU and also update their periph_conf.h file to fit the new driver.\r\ntested with #9193 #9195 and ADXL345\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n\r\n### Issues/PRs references\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2018-05-25T11:27:00Z","updated_at":"2018-05-25T12:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27b2ca76a0d81bff8bb98f4c7fbe17d4dbaa4e94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":941239592,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/I2C%20REWORK","name":"I2C REWORK","color":"174389","default":false},{"id":135467271,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9198/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/c47782a0013a4f3afc14161ebad917dc2b2afab2","head":{"label":"dylad:i2c_if_sam0","ref":"i2c_if_sam0","sha":"c47782a0013a4f3afc14161ebad917dc2b2afab2","user":{"login":"dylad","id":22391368,"avatar_url":"https://avatars1.githubusercontent.com/u/22391368?v=4","gravatar_id":"","url":"https://api.github.com/users/dylad","html_url":"https://github.com/dylad","followers_url":"https://api.github.com/users/dylad/followers","following_url":"https://api.github.com/users/dylad/following{/other_user}","gists_url":"https://api.github.com/users/dylad/gists{/gist_id}","starred_url":"https://api.github.com/users/dylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylad/subscriptions","organizations_url":"https://api.github.com/users/dylad/orgs","repos_url":"https://api.github.com/users/dylad/repos","events_url":"https://api.github.com/users/dylad/events{/privacy}","received_events_url":"https://api.github.com/users/dylad/received_events","type":"User","site_admin":false},"repo":{"id":71486649,"name":"RIOT","full_name":"dylad/RIOT","owner":{"login":"dylad","id":22391368,"avatar_url":"https://avatars1.githubusercontent.com/u/22391368?v=4","gravatar_id":"","url":"https://api.github.com/users/dylad","html_url":"https://github.com/dylad","followers_url":"https://api.github.com/users/dylad/followers","following_url":"https://api.github.com/users/dylad/following{/other_user}","gists_url":"https://api.github.com/users/dylad/gists{/gist_id}","starred_url":"https://api.github.com/users/dylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylad/subscriptions","organizations_url":"https://api.github.com/users/dylad/orgs","repos_url":"https://api.github.com/users/dylad/repos","events_url":"https://api.github.com/users/dylad/events{/privacy}","received_events_url":"https://api.github.com/users/dylad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dylad/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/dylad/RIOT","forks_url":"https://api.github.com/repos/dylad/RIOT/forks","keys_url":"https://api.github.com/repos/dylad/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dylad/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dylad/RIOT/teams","hooks_url":"https://api.github.com/repos/dylad/RIOT/hooks","issue_events_url":"https://api.github.com/repos/dylad/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/dylad/RIOT/events","assignees_url":"https://api.github.com/repos/dylad/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/dylad/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/dylad/RIOT/tags","blobs_url":"https://api.github.com/repos/dylad/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dylad/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dylad/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/dylad/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dylad/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/dylad/RIOT/languages","stargazers_url":"https://api.github.com/repos/dylad/RIOT/stargazers","contributors_url":"https://api.github.com/repos/dylad/RIOT/contributors","subscribers_url":"https://api.github.com/repos/dylad/RIOT/subscribers","subscription_url":"https://api.github.com/repos/dylad/RIOT/subscription","commits_url":"https://api.github.com/repos/dylad/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/dylad/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/dylad/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/dylad/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/dylad/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/dylad/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dylad/RIOT/merges","archive_url":"https://api.github.com/repos/dylad/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dylad/RIOT/downloads","issues_url":"https://api.github.com/repos/dylad/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/dylad/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/dylad/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/dylad/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dylad/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/dylad/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/dylad/RIOT/deployments","created_at":"2016-10-20T17:20:53Z","updated_at":"2016-10-20T17:21:14Z","pushed_at":"2018-05-25T11:38:13Z","git_url":"git://github.com/dylad/RIOT.git","ssh_url":"git@github.com:dylad/RIOT.git","clone_url":"https://github.com/dylad/RIOT.git","svn_url":"https://github.com/dylad/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":51942,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:new_i2c_if","ref":"new_i2c_if","sha":"c9d26e5da2c4caaf0e89b6ef146562e6744f8bcc","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-05-25T11:12:34Z","pushed_at":"2018-05-25T12:52:10Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":52359,"stargazers_count":1797,"watchers_count":1797,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1068,"mirror_url":null,"archived":false,"open_issues_count":763,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1068,"open_issues":763,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9198"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9198"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9198/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9198/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/c47782a0013a4f3afc14161ebad917dc2b2afab2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aabadie"}}