{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/comments/180020881","pull_request_review_id":110367180,"id":180020881,"diff_hunk":"@@ -678,6 +680,37 @@ func (c *Client) WaitAndGetCompletedPodPhase(namespace string, reader io.Reader,\n \treturn status, nil\n }\n \n+//GetPodLogs print the log of a pod to standard output\n+func (c *Client) GetPodLogs(namespace string, reader io.Reader, timeout time.Duration) error {\n+\tinfos, err := c.Build(namespace, reader)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tinfo := infos[0]","path":"pkg/kube/client.go","position":25,"original_position":25,"commit_id":"9e02d5e028e3c8b2be3ee34abced6d853f6dcbfc","original_commit_id":"4a56f6f0d7a80a7c1195d10cb57f7246b6729b73","user":{"login":"GaoLiping","id":11885607,"avatar_url":"https://avatars1.githubusercontent.com/u/11885607?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoLiping","html_url":"https://github.com/GaoLiping","followers_url":"https://api.github.com/users/GaoLiping/followers","following_url":"https://api.github.com/users/GaoLiping/following{/other_user}","gists_url":"https://api.github.com/users/GaoLiping/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoLiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoLiping/subscriptions","organizations_url":"https://api.github.com/users/GaoLiping/orgs","repos_url":"https://api.github.com/users/GaoLiping/repos","events_url":"https://api.github.com/users/GaoLiping/events{/privacy}","received_events_url":"https://api.github.com/users/GaoLiping/received_events","type":"User","site_admin":false},"body":"@sorenmat Because the Build method \r\n```\r\nBuild validates for Kubernetes objects and returns resource Infos from a io.Reader.\r\n```\r\nIn our case, there will be only one object which will be the first on in the returned objects.","created_at":"2018-04-09T08:30:41Z","updated_at":"2018-04-09T08:30:41Z","html_url":"https://github.com/kubernetes/helm/pull/3844#discussion_r180020881","pull_request_url":"https://api.github.com/repos/kubernetes/helm/pulls/3844","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments/180020881"},"html":{"href":"https://github.com/kubernetes/helm/pull/3844#discussion_r180020881"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3844"}},"in_reply_to_id":179753538},"pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/3844","id":179921402,"html_url":"https://github.com/kubernetes/helm/pull/3844","diff_url":"https://github.com/kubernetes/helm/pull/3844.diff","patch_url":"https://github.com/kubernetes/helm/pull/3844.patch","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/3844","number":3844,"state":"open","locked":false,"title":"[issue1957] print out log of failing test pod","user":{"login":"GaoLiping","id":11885607,"avatar_url":"https://avatars1.githubusercontent.com/u/11885607?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoLiping","html_url":"https://github.com/GaoLiping","followers_url":"https://api.github.com/users/GaoLiping/followers","following_url":"https://api.github.com/users/GaoLiping/following{/other_user}","gists_url":"https://api.github.com/users/GaoLiping/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoLiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoLiping/subscriptions","organizations_url":"https://api.github.com/users/GaoLiping/orgs","repos_url":"https://api.github.com/users/GaoLiping/repos","events_url":"https://api.github.com/users/GaoLiping/events{/privacy}","received_events_url":"https://api.github.com/users/GaoLiping/received_events","type":"User","site_admin":false},"body":"This is a fix to issue https://github.com/kubernetes/helm/issues/1957\r\nThe implementation is to print out the log of the test pod when it is fails\r\n","created_at":"2018-04-06T11:23:10Z","updated_at":"2018-04-09T08:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b3bf2721fd5d2216fe6ad25fa0062239c86859","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":335089574,"url":"https://api.github.com/repos/kubernetes/helm/labels/awaiting%20review","name":"awaiting review","color":"e11d21","default":false},{"id":484574947,"url":"https://api.github.com/repos/kubernetes/helm/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":562687520,"url":"https://api.github.com/repos/kubernetes/helm/labels/feature","name":"feature","color":"0052cc","default":false},{"id":678047234,"url":"https://api.github.com/repos/kubernetes/helm/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/helm/pulls/3844/commits","review_comments_url":"https://api.github.com/repos/kubernetes/helm/pulls/3844/comments","review_comment_url":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/3844/comments","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/9e02d5e028e3c8b2be3ee34abced6d853f6dcbfc","head":{"label":"GaoLiping:helm-test-patch","ref":"helm-test-patch","sha":"9e02d5e028e3c8b2be3ee34abced6d853f6dcbfc","user":{"login":"GaoLiping","id":11885607,"avatar_url":"https://avatars1.githubusercontent.com/u/11885607?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoLiping","html_url":"https://github.com/GaoLiping","followers_url":"https://api.github.com/users/GaoLiping/followers","following_url":"https://api.github.com/users/GaoLiping/following{/other_user}","gists_url":"https://api.github.com/users/GaoLiping/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoLiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoLiping/subscriptions","organizations_url":"https://api.github.com/users/GaoLiping/orgs","repos_url":"https://api.github.com/users/GaoLiping/repos","events_url":"https://api.github.com/users/GaoLiping/events{/privacy}","received_events_url":"https://api.github.com/users/GaoLiping/received_events","type":"User","site_admin":false},"repo":{"id":128207410,"name":"helm","full_name":"GaoLiping/helm","owner":{"login":"GaoLiping","id":11885607,"avatar_url":"https://avatars1.githubusercontent.com/u/11885607?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoLiping","html_url":"https://github.com/GaoLiping","followers_url":"https://api.github.com/users/GaoLiping/followers","following_url":"https://api.github.com/users/GaoLiping/following{/other_user}","gists_url":"https://api.github.com/users/GaoLiping/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoLiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoLiping/subscriptions","organizations_url":"https://api.github.com/users/GaoLiping/orgs","repos_url":"https://api.github.com/users/GaoLiping/repos","events_url":"https://api.github.com/users/GaoLiping/events{/privacy}","received_events_url":"https://api.github.com/users/GaoLiping/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaoLiping/helm","description":"The Kubernetes Package Manager","fork":true,"url":"https://api.github.com/repos/GaoLiping/helm","forks_url":"https://api.github.com/repos/GaoLiping/helm/forks","keys_url":"https://api.github.com/repos/GaoLiping/helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaoLiping/helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaoLiping/helm/teams","hooks_url":"https://api.github.com/repos/GaoLiping/helm/hooks","issue_events_url":"https://api.github.com/repos/GaoLiping/helm/issues/events{/number}","events_url":"https://api.github.com/repos/GaoLiping/helm/events","assignees_url":"https://api.github.com/repos/GaoLiping/helm/assignees{/user}","branches_url":"https://api.github.com/repos/GaoLiping/helm/branches{/branch}","tags_url":"https://api.github.com/repos/GaoLiping/helm/tags","blobs_url":"https://api.github.com/repos/GaoLiping/helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaoLiping/helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaoLiping/helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaoLiping/helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaoLiping/helm/statuses/{sha}","languages_url":"https://api.github.com/repos/GaoLiping/helm/languages","stargazers_url":"https://api.github.com/repos/GaoLiping/helm/stargazers","contributors_url":"https://api.github.com/repos/GaoLiping/helm/contributors","subscribers_url":"https://api.github.com/repos/GaoLiping/helm/subscribers","subscription_url":"https://api.github.com/repos/GaoLiping/helm/subscription","commits_url":"https://api.github.com/repos/GaoLiping/helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaoLiping/helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaoLiping/helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaoLiping/helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaoLiping/helm/contents/{+path}","compare_url":"https://api.github.com/repos/GaoLiping/helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaoLiping/helm/merges","archive_url":"https://api.github.com/repos/GaoLiping/helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaoLiping/helm/downloads","issues_url":"https://api.github.com/repos/GaoLiping/helm/issues{/number}","pulls_url":"https://api.github.com/repos/GaoLiping/helm/pulls{/number}","milestones_url":"https://api.github.com/repos/GaoLiping/helm/milestones{/number}","notifications_url":"https://api.github.com/repos/GaoLiping/helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaoLiping/helm/labels{/name}","releases_url":"https://api.github.com/repos/GaoLiping/helm/releases{/id}","deployments_url":"https://api.github.com/repos/GaoLiping/helm/deployments","created_at":"2018-04-05T13:05:22Z","updated_at":"2018-04-05T13:05:26Z","pushed_at":"2018-04-09T08:17:24Z","git_url":"git://github.com/GaoLiping/helm.git","ssh_url":"git@github.com:GaoLiping/helm.git","clone_url":"https://github.com/GaoLiping/helm.git","svn_url":"https://github.com/GaoLiping/helm","homepage":"","size":9106,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"50f6fddd998a2e91f776fa163a7600368f94aa2c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":43723161,"name":"helm","full_name":"kubernetes/helm","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/helm","description":"The Kubernetes Package Manager","fork":false,"url":"https://api.github.com/repos/kubernetes/helm","forks_url":"https://api.github.com/repos/kubernetes/helm/forks","keys_url":"https://api.github.com/repos/kubernetes/helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/helm/teams","hooks_url":"https://api.github.com/repos/kubernetes/helm/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/helm/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/helm/events","assignees_url":"https://api.github.com/repos/kubernetes/helm/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/helm/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/helm/tags","blobs_url":"https://api.github.com/repos/kubernetes/helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/helm/languages","stargazers_url":"https://api.github.com/repos/kubernetes/helm/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/helm/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/helm/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/helm/subscription","commits_url":"https://api.github.com/repos/kubernetes/helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/helm/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/helm/merges","archive_url":"https://api.github.com/repos/kubernetes/helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/helm/downloads","issues_url":"https://api.github.com/repos/kubernetes/helm/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/helm/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/helm/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/helm/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/helm/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/helm/deployments","created_at":"2015-10-06T01:07:32Z","updated_at":"2018-04-09T06:31:37Z","pushed_at":"2018-04-09T08:17:28Z","git_url":"git://github.com/kubernetes/helm.git","ssh_url":"git@github.com:kubernetes/helm.git","clone_url":"https://github.com/kubernetes/helm.git","svn_url":"https://github.com/kubernetes/helm","homepage":"","size":9585,"stargazers_count":4938,"watchers_count":4938,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1736,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1736,"open_issues":468,"watchers":4938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3844"},"html":{"href":"https://github.com/kubernetes/helm/pull/3844"},"issue":{"href":"https://api.github.com/repos/kubernetes/helm/issues/3844"},"comments":{"href":"https://api.github.com/repos/kubernetes/helm/issues/3844/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3844/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3844/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/helm/statuses/9e02d5e028e3c8b2be3ee34abced6d853f6dcbfc"}},"author_association":"NONE"}}
{"actor":{"display_login":"GaoLiping"}}