{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/222475964","pull_request_review_id":161372788,"id":222475964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ3NTk2NA==","diff_hunk":"@@ -94,51 +95,56 @@ public GroupByContainerCount(int containerCount) {\n       return group(tasks);\n     }\n \n-    TaskAssignmentManager taskAssignmentManager = localityManager.getTaskAssignmentManager();\n-    List<TaskGroup> containers = getPreviousContainers(taskAssignmentManager, tasks.size());\n-    if (containers == null || containers.size() == 1 || containerCount == 1) {\n-      log.info(\"Balancing does not apply. Invoking grouper.\");\n-      Set<ContainerModel> models = group(tasks);\n-      saveTaskAssignments(models, taskAssignmentManager);\n-      return models;\n-    }\n+    TaskAssignmentManager taskAssignmentManager =  new TaskAssignmentManager(localityManager.getConfig(), new MetricsRegistryMap());","path":"samza-core/src/main/java/org/apache/samza/container/grouper/task/GroupByContainerCount.java","position":20,"original_position":20,"commit_id":"ce097ff5479e4db85404b7e208721e81c22e69f7","original_commit_id":"ce097ff5479e4db85404b7e208721e81c22e69f7","user":{"login":"prateekm","id":1085859,"node_id":"MDQ6VXNlcjEwODU4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1085859?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekm","html_url":"https://github.com/prateekm","followers_url":"https://api.github.com/users/prateekm/followers","following_url":"https://api.github.com/users/prateekm/following{/other_user}","gists_url":"https://api.github.com/users/prateekm/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekm/subscriptions","organizations_url":"https://api.github.com/users/prateekm/orgs","repos_url":"https://api.github.com/users/prateekm/repos","events_url":"https://api.github.com/users/prateekm/events{/privacy}","received_events_url":"https://api.github.com/users/prateekm/received_events","type":"User","site_admin":false},"body":"Why pass a no-op metrics registry map? Either it creates useful metrics and we need to emit them, or it doesn't and we should remove this param.","created_at":"2018-10-03T21:35:58Z","updated_at":"2018-10-03T21:35:58Z","html_url":"https://github.com/apache/samza/pull/684#discussion_r222475964","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/222475964"},"html":{"href":"https://github.com/apache/samza/pull/684#discussion_r222475964"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/684","id":219845142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODQ1MTQy","html_url":"https://github.com/apache/samza/pull/684","diff_url":"https://github.com/apache/samza/pull/684.diff","patch_url":"https://github.com/apache/samza/pull/684.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/684","number":684,"state":"open","locked":false,"title":"SAMZA-1933: Fix NPE in LocalityManager. ","user":{"login":"shanthoosh","id":483745,"node_id":"MDQ6VXNlcjQ4Mzc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/483745?v=4","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T21:05:50Z","updated_at":"2018-10-03T21:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e6dbeba26e47f67dcb5a2bce5626803068b50f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/684/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/684/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/684/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/ce097ff5479e4db85404b7e208721e81c22e69f7","head":{"label":"shanthoosh:fix_NPE_in_task_assignment_manager","ref":"fix_NPE_in_task_assignment_manager","sha":"ce097ff5479e4db85404b7e208721e81c22e69f7","user":{"login":"shanthoosh","id":483745,"node_id":"MDQ6VXNlcjQ4Mzc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/483745?v=4","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"repo":{"id":69699342,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5OTM0Mg==","name":"samza","full_name":"shanthoosh/samza","private":false,"owner":{"login":"shanthoosh","id":483745,"node_id":"MDQ6VXNlcjQ4Mzc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/483745?v=4","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shanthoosh/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/shanthoosh/samza","forks_url":"https://api.github.com/repos/shanthoosh/samza/forks","keys_url":"https://api.github.com/repos/shanthoosh/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanthoosh/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanthoosh/samza/teams","hooks_url":"https://api.github.com/repos/shanthoosh/samza/hooks","issue_events_url":"https://api.github.com/repos/shanthoosh/samza/issues/events{/number}","events_url":"https://api.github.com/repos/shanthoosh/samza/events","assignees_url":"https://api.github.com/repos/shanthoosh/samza/assignees{/user}","branches_url":"https://api.github.com/repos/shanthoosh/samza/branches{/branch}","tags_url":"https://api.github.com/repos/shanthoosh/samza/tags","blobs_url":"https://api.github.com/repos/shanthoosh/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanthoosh/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanthoosh/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanthoosh/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanthoosh/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/shanthoosh/samza/languages","stargazers_url":"https://api.github.com/repos/shanthoosh/samza/stargazers","contributors_url":"https://api.github.com/repos/shanthoosh/samza/contributors","subscribers_url":"https://api.github.com/repos/shanthoosh/samza/subscribers","subscription_url":"https://api.github.com/repos/shanthoosh/samza/subscription","commits_url":"https://api.github.com/repos/shanthoosh/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanthoosh/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanthoosh/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanthoosh/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanthoosh/samza/contents/{+path}","compare_url":"https://api.github.com/repos/shanthoosh/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanthoosh/samza/merges","archive_url":"https://api.github.com/repos/shanthoosh/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanthoosh/samza/downloads","issues_url":"https://api.github.com/repos/shanthoosh/samza/issues{/number}","pulls_url":"https://api.github.com/repos/shanthoosh/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/shanthoosh/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/shanthoosh/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanthoosh/samza/labels{/name}","releases_url":"https://api.github.com/repos/shanthoosh/samza/releases{/id}","deployments_url":"https://api.github.com/repos/shanthoosh/samza/deployments","created_at":"2016-09-30T20:20:29Z","updated_at":"2018-10-02T20:28:59Z","pushed_at":"2018-10-03T01:15:09Z","git_url":"git://github.com/shanthoosh/samza.git","ssh_url":"git@github.com:shanthoosh/samza.git","clone_url":"https://github.com/shanthoosh/samza.git","svn_url":"https://github.com/shanthoosh/samza","homepage":null,"size":24950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4ae30f18d53cfa74d0b2db44ead235e45530f1b5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE5OTk4Mg==","name":"samza","full_name":"apache/samza","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2018-10-03T06:06:47Z","pushed_at":"2018-10-03T21:30:13Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":25731,"stargazers_count":457,"watchers_count":457,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":205,"open_issues":35,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/684"},"html":{"href":"https://github.com/apache/samza/pull/684"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/684"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/ce097ff5479e4db85404b7e208721e81c22e69f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"prateekm"}}