{"action":"created","comment":{"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/comments/173623125","pull_request_review_id":102851813,"id":173623125,"diff_hunk":"@@ -1,10 +1,10 @@\n-julia 0.5\n+julia 0.6","path":"REQUIRE","position":2,"original_position":2,"commit_id":"a10501bba0742801969de627648e657cc890156c","original_commit_id":"a10501bba0742801969de627648e657cc890156c","user":{"login":"bjarthur","id":1538268,"avatar_url":"https://avatars2.githubusercontent.com/u/1538268?v=4","gravatar_id":"","url":"https://api.github.com/users/bjarthur","html_url":"https://github.com/bjarthur","followers_url":"https://api.github.com/users/bjarthur/followers","following_url":"https://api.github.com/users/bjarthur/following{/other_user}","gists_url":"https://api.github.com/users/bjarthur/gists{/gist_id}","starred_url":"https://api.github.com/users/bjarthur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjarthur/subscriptions","organizations_url":"https://api.github.com/users/bjarthur/orgs","repos_url":"https://api.github.com/users/bjarthur/repos","events_url":"https://api.github.com/users/bjarthur/events{/privacy}","received_events_url":"https://api.github.com/users/bjarthur/received_events","type":"User","site_admin":false},"body":"should stop testing on 0.5 if Gadfly is dropping support for it, particularly since METADATA no longer supports it.","created_at":"2018-03-10T13:57:46Z","updated_at":"2018-03-10T13:57:46Z","html_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090#discussion_r173623125","pull_request_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/comments/173623125"},"html":{"href":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090#discussion_r173623125"},"pull_request":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090","id":164294125,"html_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090","diff_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090.diff","patch_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090.patch","issue_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090","number":1090,"state":"open","locked":false,"title":"DataFrames 0.11+ compat via IndirectArrays","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars3.githubusercontent.com/u/505001?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"body":"@tlnagy Here is my version of the DataFrame 0.11+ compatible version. This version passes locally (see caveat below) with [this version of IndirectArrays](https://github.com/JuliaArrays/IndirectArrays.jl/pull/12). I decided that the wrapping behavior of CategoricalArrays was too inconvenient to get working with the current setup because it is implicitly assumed in most functions that \"categorical\" arrays return the same kand of values as non-categorical arrays. Maybe by restructuring the code to rely more on dispatch to smaller specialized methods it might be possible to use CategoricalArrays internally, but I'm not sure it is worth it. Basically, I don't think it is useful to have the `pool` handy for the use cases here in Gadfly.\r\n\r\nAlthough the tests pass, it requires that Julia runs with `--compilecache=no`. Otherwise, it triggers what appears to be completely spurious ambiguity errors that we'd need @vtjnash or @JeffBezanson to comment on. It is hard for me to narrow down the issue but it could be related to `module`/`using`/`include`. E.g. I can trigger/detrigger the issue by including a file where all lines are commented. I've also been able to trigger/detrigger it with a `foo() = 1` definition in the middle of the `statistics.jl` file.","created_at":"2018-01-22T12:28:37Z","updated_at":"2018-03-10T13:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c8b24659b6f05ada8447e7b840ab354588e3334","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090/comments","statuses_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/statuses/a10501bba0742801969de627648e657cc890156c","head":{"label":"andreasnoack:anj/indirect","ref":"anj/indirect","sha":"a10501bba0742801969de627648e657cc890156c","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars3.githubusercontent.com/u/505001?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"repo":{"id":118187207,"name":"Gadfly.jl","full_name":"andreasnoack/Gadfly.jl","owner":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars3.githubusercontent.com/u/505001?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasnoack/Gadfly.jl","description":"Crafty statistical graphics for Julia.","fork":true,"url":"https://api.github.com/repos/andreasnoack/Gadfly.jl","forks_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/forks","keys_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/teams","hooks_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/hooks","issue_events_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/issues/events{/number}","events_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/events","assignees_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/assignees{/user}","branches_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/branches{/branch}","tags_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/tags","blobs_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/languages","stargazers_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/stargazers","contributors_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/contributors","subscribers_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/subscribers","subscription_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/subscription","commits_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/contents/{+path}","compare_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/merges","archive_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/downloads","issues_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/issues{/number}","pulls_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/labels{/name}","releases_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/releases{/id}","deployments_url":"https://api.github.com/repos/andreasnoack/Gadfly.jl/deployments","created_at":"2018-01-19T22:46:45Z","updated_at":"2018-01-19T22:46:47Z","pushed_at":"2018-02-12T10:45:46Z","git_url":"git://github.com/andreasnoack/Gadfly.jl.git","ssh_url":"git@github.com:andreasnoack/Gadfly.jl.git","clone_url":"https://github.com/andreasnoack/Gadfly.jl.git","svn_url":"https://github.com/andreasnoack/Gadfly.jl","homepage":"http://gadflyjl.org/stable/","size":12857,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GiovineItalia:master","ref":"master","sha":"1bf72254d9822e2afc8d1cbb520d905c48e5de47","user":{"login":"GiovineItalia","id":22759808,"avatar_url":"https://avatars1.githubusercontent.com/u/22759808?v=4","gravatar_id":"","url":"https://api.github.com/users/GiovineItalia","html_url":"https://github.com/GiovineItalia","followers_url":"https://api.github.com/users/GiovineItalia/followers","following_url":"https://api.github.com/users/GiovineItalia/following{/other_user}","gists_url":"https://api.github.com/users/GiovineItalia/gists{/gist_id}","starred_url":"https://api.github.com/users/GiovineItalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiovineItalia/subscriptions","organizations_url":"https://api.github.com/users/GiovineItalia/orgs","repos_url":"https://api.github.com/users/GiovineItalia/repos","events_url":"https://api.github.com/users/GiovineItalia/events{/privacy}","received_events_url":"https://api.github.com/users/GiovineItalia/received_events","type":"Organization","site_admin":false},"repo":{"id":5319457,"name":"Gadfly.jl","full_name":"GiovineItalia/Gadfly.jl","owner":{"login":"GiovineItalia","id":22759808,"avatar_url":"https://avatars1.githubusercontent.com/u/22759808?v=4","gravatar_id":"","url":"https://api.github.com/users/GiovineItalia","html_url":"https://github.com/GiovineItalia","followers_url":"https://api.github.com/users/GiovineItalia/followers","following_url":"https://api.github.com/users/GiovineItalia/following{/other_user}","gists_url":"https://api.github.com/users/GiovineItalia/gists{/gist_id}","starred_url":"https://api.github.com/users/GiovineItalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiovineItalia/subscriptions","organizations_url":"https://api.github.com/users/GiovineItalia/orgs","repos_url":"https://api.github.com/users/GiovineItalia/repos","events_url":"https://api.github.com/users/GiovineItalia/events{/privacy}","received_events_url":"https://api.github.com/users/GiovineItalia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GiovineItalia/Gadfly.jl","description":"Crafty statistical graphics for Julia.","fork":false,"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl","forks_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/forks","keys_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/teams","hooks_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/hooks","issue_events_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/events{/number}","events_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/events","assignees_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/assignees{/user}","branches_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/branches{/branch}","tags_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/tags","blobs_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/languages","stargazers_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/stargazers","contributors_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/contributors","subscribers_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/subscribers","subscription_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/subscription","commits_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/contents/{+path}","compare_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/merges","archive_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/downloads","issues_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues{/number}","pulls_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/labels{/name}","releases_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/releases{/id}","deployments_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/deployments","created_at":"2012-08-06T20:46:58Z","updated_at":"2018-03-10T00:50:18Z","pushed_at":"2018-02-27T12:46:23Z","git_url":"git://github.com/GiovineItalia/Gadfly.jl.git","ssh_url":"git@github.com:GiovineItalia/Gadfly.jl.git","clone_url":"https://github.com/GiovineItalia/Gadfly.jl.git","svn_url":"https://github.com/GiovineItalia/Gadfly.jl","homepage":"http://gadflyjl.org/stable/","size":13272,"stargazers_count":1133,"watchers_count":1133,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":195,"open_issues":197,"watchers":1133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090"},"html":{"href":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090"},"issue":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090"},"comments":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/statuses/a10501bba0742801969de627648e657cc890156c"}},"author_association":"NONE"}}
{"actor":{"display_login":"bjarthur"}}