{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/198351686","pull_request_review_id":132263218,"id":198351686,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODM1MTY4Ng==","diff_hunk":"@@ -940,21 +1027,12 @@ object LoadVCF {\n           }\n         }\n         rvb.endArray()\n-      }(lines, rowType, rg, contigRecoding, arrayElementsRequired, skipInvalidLoci),\n-      justVariants)\n+      }(lines, rvRowType, rg, contigRecoding, arrayElementsRequired, skipInvalidLoci))\n \n-    new MatrixTable(hc,\n-      matrixType,\n+    MatrixValue(matrixType,\n       BroadcastRow(Row.empty, matrixType.globalType, sc),\n-      BroadcastIndexedSeq(sampleIds.map(x => Annotation(x)), TArray(matrixType.globalType), sc),\n-      rdd)\n+      BroadcastIndexedSeq(localSampleIDs.map(x => Annotation(x)), TArray(matrixType.globalType), sc),","path":"src/main/scala/is/hail/io/vcf/LoadVCF.scala","position":280,"original_position":280,"commit_id":"0276fc2c48e0ce5861fd94175c7e1fd8d3f025ce","original_commit_id":"0276fc2c48e0ce5861fd94175c7e1fd8d3f025ce","user":{"login":"jbloom22","id":3201642,"node_id":"MDQ6VXNlcjMyMDE2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3201642?v=4","gravatar_id":"","url":"https://api.github.com/users/jbloom22","html_url":"https://github.com/jbloom22","followers_url":"https://api.github.com/users/jbloom22/followers","following_url":"https://api.github.com/users/jbloom22/following{/other_user}","gists_url":"https://api.github.com/users/jbloom22/gists{/gist_id}","starred_url":"https://api.github.com/users/jbloom22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbloom22/subscriptions","organizations_url":"https://api.github.com/users/jbloom22/orgs","repos_url":"https://api.github.com/users/jbloom22/repos","events_url":"https://api.github.com/users/jbloom22/events{/privacy}","received_events_url":"https://api.github.com/users/jbloom22/received_events","type":"User","site_admin":false},"body":"I think this should be `matrixType.colType`, may explain test failure","created_at":"2018-06-27T02:39:47Z","updated_at":"2018-06-27T02:46:49Z","html_url":"https://github.com/hail-is/hail/pull/3840#discussion_r198351686","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/3840","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/198351686"},"html":{"href":"https://github.com/hail-is/hail/pull/3840#discussion_r198351686"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3840"}},"in_reply_to_id":198351519},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/3840","id":197385175,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Mzg1MTc1","html_url":"https://github.com/hail-is/hail/pull/3840","diff_url":"https://github.com/hail-is/hail/pull/3840.diff","patch_url":"https://github.com/hail-is/hail/pull/3840.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/3840","number":3840,"state":"open","locked":false,"title":"Refactor LoadVCF to use MatrixRead","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-26T11:09:11Z","updated_at":"2018-06-27T02:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04b5d7078e86f29ab70ee4b98d17dcb7fa763070","assignee":{"login":"jbloom22","id":3201642,"node_id":"MDQ6VXNlcjMyMDE2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3201642?v=4","gravatar_id":"","url":"https://api.github.com/users/jbloom22","html_url":"https://github.com/jbloom22","followers_url":"https://api.github.com/users/jbloom22/followers","following_url":"https://api.github.com/users/jbloom22/following{/other_user}","gists_url":"https://api.github.com/users/jbloom22/gists{/gist_id}","starred_url":"https://api.github.com/users/jbloom22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbloom22/subscriptions","organizations_url":"https://api.github.com/users/jbloom22/orgs","repos_url":"https://api.github.com/users/jbloom22/repos","events_url":"https://api.github.com/users/jbloom22/events{/privacy}","received_events_url":"https://api.github.com/users/jbloom22/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbloom22","id":3201642,"node_id":"MDQ6VXNlcjMyMDE2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3201642?v=4","gravatar_id":"","url":"https://api.github.com/users/jbloom22","html_url":"https://github.com/jbloom22","followers_url":"https://api.github.com/users/jbloom22/followers","following_url":"https://api.github.com/users/jbloom22/following{/other_user}","gists_url":"https://api.github.com/users/jbloom22/gists{/gist_id}","starred_url":"https://api.github.com/users/jbloom22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbloom22/subscriptions","organizations_url":"https://api.github.com/users/jbloom22/orgs","repos_url":"https://api.github.com/users/jbloom22/repos","events_url":"https://api.github.com/users/jbloom22/events{/privacy}","received_events_url":"https://api.github.com/users/jbloom22/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/3840/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/3840/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/3840/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/0276fc2c48e0ce5861fd94175c7e1fd8d3f025ce","head":{"label":"tpoterba:loadvcf-matrixread","ref":"loadvcf-matrixread","sha":"0276fc2c48e0ce5861fd94175c7e1fd8d3f025ce","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"repo":{"id":64860564,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg2MDU2NA==","name":"hail","full_name":"tpoterba/hail","owner":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpoterba/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/tpoterba/hail","forks_url":"https://api.github.com/repos/tpoterba/hail/forks","keys_url":"https://api.github.com/repos/tpoterba/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpoterba/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpoterba/hail/teams","hooks_url":"https://api.github.com/repos/tpoterba/hail/hooks","issue_events_url":"https://api.github.com/repos/tpoterba/hail/issues/events{/number}","events_url":"https://api.github.com/repos/tpoterba/hail/events","assignees_url":"https://api.github.com/repos/tpoterba/hail/assignees{/user}","branches_url":"https://api.github.com/repos/tpoterba/hail/branches{/branch}","tags_url":"https://api.github.com/repos/tpoterba/hail/tags","blobs_url":"https://api.github.com/repos/tpoterba/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpoterba/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpoterba/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpoterba/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpoterba/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/tpoterba/hail/languages","stargazers_url":"https://api.github.com/repos/tpoterba/hail/stargazers","contributors_url":"https://api.github.com/repos/tpoterba/hail/contributors","subscribers_url":"https://api.github.com/repos/tpoterba/hail/subscribers","subscription_url":"https://api.github.com/repos/tpoterba/hail/subscription","commits_url":"https://api.github.com/repos/tpoterba/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpoterba/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpoterba/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpoterba/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpoterba/hail/contents/{+path}","compare_url":"https://api.github.com/repos/tpoterba/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpoterba/hail/merges","archive_url":"https://api.github.com/repos/tpoterba/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpoterba/hail/downloads","issues_url":"https://api.github.com/repos/tpoterba/hail/issues{/number}","pulls_url":"https://api.github.com/repos/tpoterba/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/tpoterba/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/tpoterba/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpoterba/hail/labels{/name}","releases_url":"https://api.github.com/repos/tpoterba/hail/releases{/id}","deployments_url":"https://api.github.com/repos/tpoterba/hail/deployments","created_at":"2016-08-03T16:15:03Z","updated_at":"2016-08-03T16:15:05Z","pushed_at":"2018-06-26T21:34:36Z","git_url":"git://github.com/tpoterba/hail.git","ssh_url":"git@github.com:tpoterba/hail.git","clone_url":"https://github.com/tpoterba/hail.git","svn_url":"https://github.com/tpoterba/hail","homepage":"","size":40253,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"f7499bc5a83fcf2e633622ee85c289345de2bacc","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-06-27T00:03:44Z","pushed_at":"2018-06-27T00:15:36Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":38576,"stargazers_count":338,"watchers_count":338,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":101,"open_issues":141,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3840"},"html":{"href":"https://github.com/hail-is/hail/pull/3840"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/3840"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/3840/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3840/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3840/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/0276fc2c48e0ce5861fd94175c7e1fd8d3f025ce"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jbloom22"}}