{"action":"closed","number":4561,"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561","id":163618332,"html_url":"https://github.com/WordPress/gutenberg/pull/4561","diff_url":"https://github.com/WordPress/gutenberg/pull/4561.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/4561.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4561","number":4561,"state":"closed","locked":false,"title":"Fix author select IE11 overflow with max-width","user":{"login":"laras126","id":445861,"avatar_url":"https://avatars3.githubusercontent.com/u/445861?v=4","gravatar_id":"","url":"https://api.github.com/users/laras126","html_url":"https://github.com/laras126","followers_url":"https://api.github.com/users/laras126/followers","following_url":"https://api.github.com/users/laras126/following{/other_user}","gists_url":"https://api.github.com/users/laras126/gists{/gist_id}","starred_url":"https://api.github.com/users/laras126/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laras126/subscriptions","organizations_url":"https://api.github.com/users/laras126/orgs","repos_url":"https://api.github.com/users/laras126/repos","events_url":"https://api.github.com/users/laras126/events{/privacy}","received_events_url":"https://api.github.com/users/laras126/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdd `max-width` to author select to prevent overflow on IE11 for long names. Fixes #3432. \r\n\r\n## How Has This Been Tested?\r\nTested in IE11 using Browserstack, as well as:\r\nChrome 63.0.3239.132 \r\nFireFox Quantum 57.0.4\r\nMost recent iOS Emulator\r\n\r\n## Screenshots (jpeg or gifs if applicable):\r\n<img width=\"502\" alt=\"screen shot 2018-01-17 at 8 26 27 pm\" src=\"https://user-images.githubusercontent.com/445861/35080905-70e13474-fbc5-11e7-96d9-d3db6bc7c754.png\">\r\n\r\n## Types of changes\r\nLine of CSS to add max-width to `.editor-post-author__select`. This is nicely scoped to the editor select only, though it is a hardcoded value. Since it is a _max_-width, the worst case would be a little extra space on the right in IE11 (IE11 does not acknowledge `justify-content: space-between`) if the \"Author\" label was changed to something shorter. \r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style.\r\n- [x] My code has proper inline documentation.\r\n","created_at":"2018-01-18T04:38:31Z","updated_at":"2018-05-10T21:02:23Z","closed_at":"2018-05-10T21:02:23Z","merged_at":null,"merge_commit_sha":"cc1658ad35c59bd32741ebb23d34c1c6c5a7cd5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4561/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/a05796faac98eae18f23cec4ea1745f10b3fad9e","head":{"label":"laras126:bugfix/author-select-ie11","ref":"bugfix/author-select-ie11","sha":"a05796faac98eae18f23cec4ea1745f10b3fad9e","user":{"login":"laras126","id":445861,"avatar_url":"https://avatars3.githubusercontent.com/u/445861?v=4","gravatar_id":"","url":"https://api.github.com/users/laras126","html_url":"https://github.com/laras126","followers_url":"https://api.github.com/users/laras126/followers","following_url":"https://api.github.com/users/laras126/following{/other_user}","gists_url":"https://api.github.com/users/laras126/gists{/gist_id}","starred_url":"https://api.github.com/users/laras126/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laras126/subscriptions","organizations_url":"https://api.github.com/users/laras126/orgs","repos_url":"https://api.github.com/users/laras126/repos","events_url":"https://api.github.com/users/laras126/events{/privacy}","received_events_url":"https://api.github.com/users/laras126/received_events","type":"User","site_admin":false},"repo":{"id":112961439,"name":"gutenberg","full_name":"laras126/gutenberg","owner":{"login":"laras126","id":445861,"avatar_url":"https://avatars3.githubusercontent.com/u/445861?v=4","gravatar_id":"","url":"https://api.github.com/users/laras126","html_url":"https://github.com/laras126","followers_url":"https://api.github.com/users/laras126/followers","following_url":"https://api.github.com/users/laras126/following{/other_user}","gists_url":"https://api.github.com/users/laras126/gists{/gist_id}","starred_url":"https://api.github.com/users/laras126/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laras126/subscriptions","organizations_url":"https://api.github.com/users/laras126/orgs","repos_url":"https://api.github.com/users/laras126/repos","events_url":"https://api.github.com/users/laras126/events{/privacy}","received_events_url":"https://api.github.com/users/laras126/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laras126/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":true,"url":"https://api.github.com/repos/laras126/gutenberg","forks_url":"https://api.github.com/repos/laras126/gutenberg/forks","keys_url":"https://api.github.com/repos/laras126/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laras126/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laras126/gutenberg/teams","hooks_url":"https://api.github.com/repos/laras126/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/laras126/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/laras126/gutenberg/events","assignees_url":"https://api.github.com/repos/laras126/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/laras126/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/laras126/gutenberg/tags","blobs_url":"https://api.github.com/repos/laras126/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laras126/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laras126/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/laras126/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laras126/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/laras126/gutenberg/languages","stargazers_url":"https://api.github.com/repos/laras126/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/laras126/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/laras126/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/laras126/gutenberg/subscription","commits_url":"https://api.github.com/repos/laras126/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/laras126/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/laras126/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/laras126/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/laras126/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/laras126/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laras126/gutenberg/merges","archive_url":"https://api.github.com/repos/laras126/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laras126/gutenberg/downloads","issues_url":"https://api.github.com/repos/laras126/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/laras126/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/laras126/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/laras126/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laras126/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/laras126/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/laras126/gutenberg/deployments","created_at":"2017-12-03T20:32:58Z","updated_at":"2017-12-03T20:33:01Z","pushed_at":"2018-01-18T04:20:56Z","git_url":"git://github.com/laras126/gutenberg.git","ssh_url":"git@github.com:laras126/gutenberg.git","clone_url":"https://github.com/laras126/gutenberg.git","svn_url":"https://github.com/laras126/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":8674,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"b8566d7413228effeec99f3dfd67cca8152323f3","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-05-10T20:12:18Z","pushed_at":"2018-05-10T20:12:46Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":13635,"stargazers_count":2440,"watchers_count":2440,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":605,"mirror_url":null,"archived":false,"open_issues_count":851,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":605,"open_issues":851,"watchers":2440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/4561"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/4561"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/4561/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/4561/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/a05796faac98eae18f23cec4ea1745f10b3fad9e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"karmatosed"}}