{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320","repository_url":"https://api.github.com/repos/spacetelescope/hstcal","labels_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/comments","events_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/events","html_url":"https://github.com/spacetelescope/hstcal/issues/320","id":334297685,"node_id":"MDU6SXNzdWUzMzQyOTc2ODU=","number":320,"title":"CTE related OS dependent runtime floating point precision differences ","user":{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"labels":[{"id":341367995,"node_id":"MDU6TGFiZWwzNDEzNjc5OTU=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/WFC3","name":"WFC3","color":"bfd4f2","default":false},{"id":726319573,"node_id":"MDU6TGFiZWw3MjYzMTk1NzM=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/build","name":"build","color":"e58e94","default":false},{"id":722555292,"node_id":"MDU6TGFiZWw3MjI1NTUyOTI=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/changes-data","name":"changes-data","color":"ea8aac","default":false},{"id":725008568,"node_id":"MDU6TGFiZWw3MjUwMDg1Njg=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/regression","name":"regression","color":"8055b2","default":false}],"state":"open","locked":false,"assignee":{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},{"login":"mdlpstsci","id":30087326,"node_id":"MDQ6VXNlcjMwMDg3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/30087326?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlpstsci","html_url":"https://github.com/mdlpstsci","followers_url":"https://api.github.com/users/mdlpstsci/followers","following_url":"https://api.github.com/users/mdlpstsci/following{/other_user}","gists_url":"https://api.github.com/users/mdlpstsci/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlpstsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlpstsci/subscriptions","organizations_url":"https://api.github.com/users/mdlpstsci/orgs","repos_url":"https://api.github.com/users/mdlpstsci/repos","events_url":"https://api.github.com/users/mdlpstsci/events{/privacy}","received_events_url":"https://api.github.com/users/mdlpstsci/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-06-21T00:47:53Z","updated_at":"2018-06-28T21:04:09Z","closed_at":null,"author_association":"MEMBER","body":"There exist 2 failing regression tests on Pandokia for WFC3. These only exist on the Linux box. @mdlpstsci checked the input files on both machines (OSX & Linux), they are identical.\r\n\r\n * ``wf3/onorbit/uvis/calwf3_uv_01.calwf3_uv_01``\r\n * ``wf3/onorbit/uvis/calwf3_uv_05.calwf3_uv_05``\r\n\r\nDiffs found only in CTE corrected output files, ``crc.fits`` & ``flc.fits`` where 56 - 97% pixels differ in the last 1-3 last sig. figs.\r\n\r\nThe failing tests date back to [3/29/18](https://ssb.stsci.edu/steuermann/s21.cgi?action=log&name=conda_tests_py3_2018-03-29-10:30:02/nott:conda_testing3/dev_tests) corresponding with #306 and its associated change in the HSTCAL conda build recipe https://github.com/astroconda/astroconda-dev/pull/122.\r\n\r\nLooking through the diffs the following might be the culprit:\r\n\r\n https://github.com/spacetelescope/hstcal/commit/fad902e4b3d7aeb80ee741e3b3755e5e48f2ce5f\r\n where ``rpath``s were added to all ``wscript`` build scripts, ``rpath=bld.env.LIBPATH_CFITSIO``.\r\n\r\nIn the astroconda recipe, the removal of the OS ``[osx]`` specifier for the ``libgcc`` build and runtime dependencies might also be the cause.\r\n\r\nThe related changes are contextually related to the removal of the ``cfitsio`` library src from being contained within the hstcal repo. Instead, hstcal is built against the astroconda distribution of ``cfitsio``. These fpp diffs may be related to this, however, since ``cfitsio`` is an IO ilb it should only be related to reading & writing files and therefore one would expect to see diffs across all output data and not just the CTE (unless the CTE code is calling something that nothing else does).\r\n\r\nMore to come...\r\n \r\n\r\n\r\n \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spacetelescope/hstcal/issues/comments/401172817","html_url":"https://github.com/spacetelescope/hstcal/issues/320#issuecomment-401172817","issue_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320","id":401172817,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTE3MjgxNw==","user":{"login":"mdlpstsci","id":30087326,"node_id":"MDQ6VXNlcjMwMDg3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/30087326?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlpstsci","html_url":"https://github.com/mdlpstsci","followers_url":"https://api.github.com/users/mdlpstsci/followers","following_url":"https://api.github.com/users/mdlpstsci/following{/other_user}","gists_url":"https://api.github.com/users/mdlpstsci/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlpstsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlpstsci/subscriptions","organizations_url":"https://api.github.com/users/mdlpstsci/orgs","repos_url":"https://api.github.com/users/mdlpstsci/repos","events_url":"https://api.github.com/users/mdlpstsci/events{/privacy}","received_events_url":"https://api.github.com/users/mdlpstsci/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T21:04:09Z","updated_at":"2018-06-28T21:04:09Z","author_association":"CONTRIBUTOR","body":"I created an hstcal-dev environment on Linux (Nott) with only the necessary dependencies from astroconda-dev.  I also had to install cfitsio and pkg-config.  As previously noted and for completeness, pulling in cfitsio-3.440 also forced some additional packages to be installed: \r\n * curl:            7.60.0-h84994c4_0\r\n * libcurl:         7.60.0-h1ad7b7a_0\r\n * libgcc-ng:       7.2.0-hdf63c60_3\r\n * libssh2:         1.8.0-h9cfc8f7_4\r\n * openssl:         1.0.2o-h20670df_0\r\n * zlib:            1.2.11-ha838bed_2\r\n\r\nI configured the hstcal package to be built without libgomp.  This was verified via \"ldd acscte.e\" (for example) and the fact the execution of the test took about 10x longer than usual.  In this configuration, the differences between the test output and the truth files persisted.  Boo hoo."}}
{"actor":{"display_login":"mdlpstsci"}}