{"action":"created","comment":{"url":"https://api.github.com/repos/spack/spack/pulls/comments/186597788","pull_request_review_id":118206451,"id":186597788,"diff_hunk":"@@ -54,6 +54,10 @@ class A(AutotoolsPackage):\n \n     depends_on('b', when='foobar=bar')\n \n+    @property","path":"var/spack/repos/builtin.mock/packages/a/package.py","position":4,"original_position":4,"commit_id":"f6bebeb3a3c336b73a2a93a86e9b9a55d576b33f","original_commit_id":"f6bebeb3a3c336b73a2a93a86e9b9a55d576b33f","user":{"login":"scheibelp","id":1659704,"avatar_url":"https://avatars2.githubusercontent.com/u/1659704?v=4","gravatar_id":"","url":"https://api.github.com/users/scheibelp","html_url":"https://github.com/scheibelp","followers_url":"https://api.github.com/users/scheibelp/followers","following_url":"https://api.github.com/users/scheibelp/following{/other_user}","gists_url":"https://api.github.com/users/scheibelp/gists{/gist_id}","starred_url":"https://api.github.com/users/scheibelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheibelp/subscriptions","organizations_url":"https://api.github.com/users/scheibelp/orgs","repos_url":"https://api.github.com/users/scheibelp/repos","events_url":"https://api.github.com/users/scheibelp/events{/privacy}","received_events_url":"https://api.github.com/users/scheibelp/received_events","type":"User","site_admin":false},"body":"@alalazo I really appreciate the addition of the unit test. In my opinion though it would be worthwhile to create a new mock package for testing. Although this creates some redundancy, I think it avoids potential issues with confusing the purpose of unit tests when multiple tests use the same mock package. If that seems sensible to you then I'll wait for this to be separated out; otherwise let me know and I'll check with other folks internally to see if there's a general consensus (if most folks disagree with me I'll accept this as is).","created_at":"2018-05-08T01:42:50Z","updated_at":"2018-05-08T01:42:50Z","html_url":"https://github.com/spack/spack/pull/7760#discussion_r186597788","pull_request_url":"https://api.github.com/repos/spack/spack/pulls/7760","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/comments/186597788"},"html":{"href":"https://github.com/spack/spack/pull/7760#discussion_r186597788"},"pull_request":{"href":"https://api.github.com/repos/spack/spack/pulls/7760"}}},"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/7760","id":181647388,"html_url":"https://github.com/spack/spack/pull/7760","diff_url":"https://github.com/spack/spack/pull/7760.diff","patch_url":"https://github.com/spack/spack/pull/7760.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/7760","number":7760,"state":"open","locked":false,"title":"Packages can tune the list of files to be archived at the end of install","user":{"login":"alalazo","id":4199709,"avatar_url":"https://avatars0.githubusercontent.com/u/4199709?v=4","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"body":"fixes #2781\r\n\r\nThis PR introduces a new attribute for packages that contains a list of glob expressions. Any file that matches will be archived in the `<prefix>/.spack/archived-files` directory.\r\n\r\n`AutotoolsPackage` and `CMakePackage` provide a sensible default override for this attribute.","created_at":"2018-04-14T13:19:35Z","updated_at":"2018-05-08T01:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a29ed5522365fedcf7727fb9ca4dac165304f82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":475441813,"url":"https://api.github.com/repos/spack/spack/labels/autotools","name":"autotools","color":"d93f0b","default":false},{"id":508566016,"url":"https://api.github.com/repos/spack/spack/labels/cmake","name":"cmake","color":"c2e0c6","default":false},{"id":73908756,"url":"https://api.github.com/repos/spack/spack/labels/feature","name":"feature","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/7760/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/7760/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/7760/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/f6bebeb3a3c336b73a2a93a86e9b9a55d576b33f","head":{"label":"epfl-scitas:features/copy_config_log_in_prefix","ref":"features/copy_config_log_in_prefix","sha":"f6bebeb3a3c336b73a2a93a86e9b9a55d576b33f","user":{"login":"epfl-scitas","id":14820957,"avatar_url":"https://avatars3.githubusercontent.com/u/14820957?v=4","gravatar_id":"","url":"https://api.github.com/users/epfl-scitas","html_url":"https://github.com/epfl-scitas","followers_url":"https://api.github.com/users/epfl-scitas/followers","following_url":"https://api.github.com/users/epfl-scitas/following{/other_user}","gists_url":"https://api.github.com/users/epfl-scitas/gists{/gist_id}","starred_url":"https://api.github.com/users/epfl-scitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epfl-scitas/subscriptions","organizations_url":"https://api.github.com/users/epfl-scitas/orgs","repos_url":"https://api.github.com/users/epfl-scitas/repos","events_url":"https://api.github.com/users/epfl-scitas/events{/privacy}","received_events_url":"https://api.github.com/users/epfl-scitas/received_events","type":"Organization","site_admin":false},"repo":{"id":43118298,"name":"spack","full_name":"epfl-scitas/spack","owner":{"login":"epfl-scitas","id":14820957,"avatar_url":"https://avatars3.githubusercontent.com/u/14820957?v=4","gravatar_id":"","url":"https://api.github.com/users/epfl-scitas","html_url":"https://github.com/epfl-scitas","followers_url":"https://api.github.com/users/epfl-scitas/followers","following_url":"https://api.github.com/users/epfl-scitas/following{/other_user}","gists_url":"https://api.github.com/users/epfl-scitas/gists{/gist_id}","starred_url":"https://api.github.com/users/epfl-scitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epfl-scitas/subscriptions","organizations_url":"https://api.github.com/users/epfl-scitas/orgs","repos_url":"https://api.github.com/users/epfl-scitas/repos","events_url":"https://api.github.com/users/epfl-scitas/events{/privacy}","received_events_url":"https://api.github.com/users/epfl-scitas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epfl-scitas/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/epfl-scitas/spack","forks_url":"https://api.github.com/repos/epfl-scitas/spack/forks","keys_url":"https://api.github.com/repos/epfl-scitas/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epfl-scitas/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epfl-scitas/spack/teams","hooks_url":"https://api.github.com/repos/epfl-scitas/spack/hooks","issue_events_url":"https://api.github.com/repos/epfl-scitas/spack/issues/events{/number}","events_url":"https://api.github.com/repos/epfl-scitas/spack/events","assignees_url":"https://api.github.com/repos/epfl-scitas/spack/assignees{/user}","branches_url":"https://api.github.com/repos/epfl-scitas/spack/branches{/branch}","tags_url":"https://api.github.com/repos/epfl-scitas/spack/tags","blobs_url":"https://api.github.com/repos/epfl-scitas/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epfl-scitas/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epfl-scitas/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/epfl-scitas/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epfl-scitas/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/epfl-scitas/spack/languages","stargazers_url":"https://api.github.com/repos/epfl-scitas/spack/stargazers","contributors_url":"https://api.github.com/repos/epfl-scitas/spack/contributors","subscribers_url":"https://api.github.com/repos/epfl-scitas/spack/subscribers","subscription_url":"https://api.github.com/repos/epfl-scitas/spack/subscription","commits_url":"https://api.github.com/repos/epfl-scitas/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/epfl-scitas/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/epfl-scitas/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/epfl-scitas/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/epfl-scitas/spack/contents/{+path}","compare_url":"https://api.github.com/repos/epfl-scitas/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epfl-scitas/spack/merges","archive_url":"https://api.github.com/repos/epfl-scitas/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epfl-scitas/spack/downloads","issues_url":"https://api.github.com/repos/epfl-scitas/spack/issues{/number}","pulls_url":"https://api.github.com/repos/epfl-scitas/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/epfl-scitas/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/epfl-scitas/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epfl-scitas/spack/labels{/name}","releases_url":"https://api.github.com/repos/epfl-scitas/spack/releases{/id}","deployments_url":"https://api.github.com/repos/epfl-scitas/spack/deployments","created_at":"2015-09-25T08:01:24Z","updated_at":"2018-04-18T09:28:02Z","pushed_at":"2018-05-07T15:47:17Z","git_url":"git://github.com/epfl-scitas/spack.git","ssh_url":"git@github.com:epfl-scitas/spack.git","clone_url":"https://github.com/epfl-scitas/spack.git","svn_url":"https://github.com/epfl-scitas/spack","homepage":"http://scalability-llnl.github.io/spack","size":38826,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":2,"watchers":2,"default_branch":"releases/cornalin"}},"base":{"label":"spack:develop","ref":"develop","sha":"dfe0752807783099d9bb7c5ae7d21a9b1ed155fc","user":{"login":"spack","id":25539161,"avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"spack/spack","owner":{"login":"spack","id":25539161,"avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2018-05-07T22:24:35Z","pushed_at":"2018-05-07T22:23:46Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":38834,"stargazers_count":545,"watchers_count":545,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":424,"mirror_url":null,"archived":false,"open_issues_count":895,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":424,"open_issues":895,"watchers":545,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/7760"},"html":{"href":"https://github.com/spack/spack/pull/7760"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/7760"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/7760/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/7760/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/7760/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/f6bebeb3a3c336b73a2a93a86e9b9a55d576b33f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scheibelp"}}