{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/comments/165549063","pull_request_review_id":93508619,"id":165549063,"diff_hunk":"@@ -0,0 +1,17 @@\n+FROM microsoft/dotnet-nightly:2.1.300-preview1-jessie","path":"2.1/jessie/amd64/sdk/Dockerfile","position":1,"original_position":1,"commit_id":"84f6e5c590bdbec3b33a4927d1627be9e029ef89","original_commit_id":"84f6e5c590bdbec3b33a4927d1627be9e029ef89","user":{"login":"MichaelSimons","id":8290530,"avatar_url":"https://avatars1.githubusercontent.com/u/8290530?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelSimons","html_url":"https://github.com/MichaelSimons","followers_url":"https://api.github.com/users/MichaelSimons/followers","following_url":"https://api.github.com/users/MichaelSimons/following{/other_user}","gists_url":"https://api.github.com/users/MichaelSimons/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelSimons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelSimons/subscriptions","organizations_url":"https://api.github.com/users/MichaelSimons/orgs","repos_url":"https://api.github.com/users/MichaelSimons/repos","events_url":"https://api.github.com/users/MichaelSimons/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelSimons/received_events","type":"User","site_admin":false},"body":"Base SDK tag used across platforms isn't consistent.  This particular usage isn't using the explicit SDK tag while others are.","created_at":"2018-02-02T03:04:40Z","updated_at":"2018-02-02T03:28:17Z","html_url":"https://github.com/aspnet/aspnet-docker/pull/361#discussion_r165549063","pull_request_url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/comments/165549063"},"html":{"href":"https://github.com/aspnet/aspnet-docker/pull/361#discussion_r165549063"},"pull_request":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361","id":166665767,"html_url":"https://github.com/aspnet/aspnet-docker/pull/361","diff_url":"https://github.com/aspnet/aspnet-docker/pull/361.diff","patch_url":"https://github.com/aspnet/aspnet-docker/pull/361.patch","issue_url":"https://api.github.com/repos/aspnet/aspnet-docker/issues/361","number":361,"state":"open","locked":false,"title":"[nightly] Build images for 2.1.0-preview1","user":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"Fixes #279 \r\n\r\nChanges:\r\n\r\n`microsoft/aspnetcore-nightly`\r\n - No longer install the ASP.NET Core package runtime store. This has been replaced by the ASP.NET Core shared runtime\r\n - Base image is now `microsoft/dotnet-nightly:2.0-runtime-deps` instead of `2.0-runtime`. ASP.NET Core installers include the Microsoft.NETCore.App shared runtime\r\n\r\n`microsoft/aspnetcore-build-nightly`\r\n - Remove bower and gulp \r\n - Install NodeJS 8.9.3 - #334 \r\n - Install Git 2.16.1 (NanoServer only)\r\n - Set `WORKDIR /root/code`. Helps with the common pitfall of trying to build the app in `/`, which fails b/c MSBuild tries to overwrite `/bin`.\r\n - Update base image to `microsoft/dotnet-nightly:2.1.300-preview1-sdk`\r\n - Don't run dotnet-restore when building the container. All packages should already exist in the NuGet fallback folder\r\n\r\n\r\nNote: CI is expected to fail until microsoft/dotnet-nightly:2.1.300-preview1-sdk images are available.\r\n\r\ncc @MichaelSimons @glennc ","created_at":"2018-02-01T22:09:49Z","updated_at":"2018-02-02T03:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ff5f7449f83eabd7061382d4fe2fe3f5fb2447c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"glennc","id":234688,"avatar_url":"https://avatars3.githubusercontent.com/u/234688?v=4","gravatar_id":"","url":"https://api.github.com/users/glennc","html_url":"https://github.com/glennc","followers_url":"https://api.github.com/users/glennc/followers","following_url":"https://api.github.com/users/glennc/following{/other_user}","gists_url":"https://api.github.com/users/glennc/gists{/gist_id}","starred_url":"https://api.github.com/users/glennc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennc/subscriptions","organizations_url":"https://api.github.com/users/glennc/orgs","repos_url":"https://api.github.com/users/glennc/repos","events_url":"https://api.github.com/users/glennc/events{/privacy}","received_events_url":"https://api.github.com/users/glennc/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361/commits","review_comments_url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361/comments","review_comment_url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/aspnet-docker/issues/361/comments","statuses_url":"https://api.github.com/repos/aspnet/aspnet-docker/statuses/84f6e5c590bdbec3b33a4927d1627be9e029ef89","head":{"label":"natemcmaster:shared-runtime","ref":"shared-runtime","sha":"84f6e5c590bdbec3b33a4927d1627be9e029ef89","user":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"repo":{"id":71511461,"name":"aspnet-docker","full_name":"natemcmaster/aspnet-docker","owner":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natemcmaster/aspnet-docker","description":"ASP.NET Core Docker","fork":true,"url":"https://api.github.com/repos/natemcmaster/aspnet-docker","forks_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/forks","keys_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/teams","hooks_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/hooks","issue_events_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/issues/events{/number}","events_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/events","assignees_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/assignees{/user}","branches_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/branches{/branch}","tags_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/tags","blobs_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/languages","stargazers_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/stargazers","contributors_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/contributors","subscribers_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/subscribers","subscription_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/subscription","commits_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/contents/{+path}","compare_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/merges","archive_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/downloads","issues_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/issues{/number}","pulls_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/labels{/name}","releases_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/releases{/id}","deployments_url":"https://api.github.com/repos/natemcmaster/aspnet-docker/deployments","created_at":"2016-10-20T23:07:18Z","updated_at":"2016-10-20T23:07:20Z","pushed_at":"2018-02-01T22:07:38Z","git_url":"git://github.com/natemcmaster/aspnet-docker.git","ssh_url":"git@github.com:natemcmaster/aspnet-docker.git","clone_url":"https://github.com/natemcmaster/aspnet-docker.git","svn_url":"https://github.com/natemcmaster/aspnet-docker","homepage":"","size":454,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"5c854c3cb3ec33f5b542e35d494bebd8961008a6","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26154750,"name":"aspnet-docker","full_name":"aspnet/aspnet-docker","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/aspnet-docker","description":"ASP.NET Core Docker","fork":false,"url":"https://api.github.com/repos/aspnet/aspnet-docker","forks_url":"https://api.github.com/repos/aspnet/aspnet-docker/forks","keys_url":"https://api.github.com/repos/aspnet/aspnet-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/aspnet-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/aspnet-docker/teams","hooks_url":"https://api.github.com/repos/aspnet/aspnet-docker/hooks","issue_events_url":"https://api.github.com/repos/aspnet/aspnet-docker/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/aspnet-docker/events","assignees_url":"https://api.github.com/repos/aspnet/aspnet-docker/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/aspnet-docker/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/aspnet-docker/tags","blobs_url":"https://api.github.com/repos/aspnet/aspnet-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/aspnet-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/aspnet-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/aspnet-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/aspnet-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/aspnet-docker/languages","stargazers_url":"https://api.github.com/repos/aspnet/aspnet-docker/stargazers","contributors_url":"https://api.github.com/repos/aspnet/aspnet-docker/contributors","subscribers_url":"https://api.github.com/repos/aspnet/aspnet-docker/subscribers","subscription_url":"https://api.github.com/repos/aspnet/aspnet-docker/subscription","commits_url":"https://api.github.com/repos/aspnet/aspnet-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/aspnet-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/aspnet-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/aspnet-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/aspnet-docker/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/aspnet-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/aspnet-docker/merges","archive_url":"https://api.github.com/repos/aspnet/aspnet-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/aspnet-docker/downloads","issues_url":"https://api.github.com/repos/aspnet/aspnet-docker/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/aspnet-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/aspnet-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/aspnet-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/aspnet-docker/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/aspnet-docker/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/aspnet-docker/deployments","created_at":"2014-11-04T05:43:26Z","updated_at":"2018-02-01T20:10:15Z","pushed_at":"2018-02-01T22:09:50Z","git_url":"git://github.com/aspnet/aspnet-docker.git","ssh_url":"git@github.com:aspnet/aspnet-docker.git","clone_url":"https://github.com/aspnet/aspnet-docker.git","svn_url":"https://github.com/aspnet/aspnet-docker","homepage":"","size":455,"stargazers_count":670,"watchers_count":670,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":169,"open_issues":14,"watchers":670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361"},"html":{"href":"https://github.com/aspnet/aspnet-docker/pull/361"},"issue":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/issues/361"},"comments":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/aspnet-docker/statuses/84f6e5c590bdbec3b33a4927d1627be9e029ef89"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MichaelSimons"}}