{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/194854629","pull_request_review_id":128106337,"id":194854629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDg1NDYyOQ==","diff_hunk":"@@ -224,6 +224,30 @@ test.concurrent('focus works correctly when focusing on a scoped package', (): P\n   });\n });\n \n+test.concurrent('focus work even when the workspace root also depends on other workspaces', (): Promise<void> => {\n+  return runInstall(\n+    {focus: true},\n+    {source: 'focus-root-dep', cwd: '/packages/example-yarn-workspace-1'},\n+    async (config, reporter) => {\n+      const existAndIsMaterialized = async moduleDir => {\n+        expect(await fs.exists(path.join(moduleDir, 'package.json'))).toBeTruthy();\n+        const stat = await fs.lstat(moduleDir);\n+        expect(stat.isSymbolicLink()).toEqual(false);\n+      };\n+\n+      // The one in the root must exist, and must be materialized (since we're focusing on example-yarn-workspace-1)\n+      await existAndIsMaterialized(path.join(config.cwd, '..', '..', 'node_modules', 'example-yarn-workspace-2'));\n+\n+      // If there's one in example-yarn-workspace-1, it also has to be materialized\n+      if (await fs.exists(path.join(config.cwd, 'node_modules', 'example-yarn-workspace-2'))) {","path":"__tests__/commands/install/focus.js","position":19,"original_position":19,"commit_id":"4e305f49b8fdc1b47af735c6ac646c65fe43ccb0","original_commit_id":"e551d1ede31b615e77cd3a8b0662528ce36731c0","user":{"login":"bdwain","id":3982094,"node_id":"MDQ6VXNlcjM5ODIwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3982094?v=4","gravatar_id":"","url":"https://api.github.com/users/bdwain","html_url":"https://github.com/bdwain","followers_url":"https://api.github.com/users/bdwain/followers","following_url":"https://api.github.com/users/bdwain/following{/other_user}","gists_url":"https://api.github.com/users/bdwain/gists{/gist_id}","starred_url":"https://api.github.com/users/bdwain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdwain/subscriptions","organizations_url":"https://api.github.com/users/bdwain/orgs","repos_url":"https://api.github.com/users/bdwain/repos","events_url":"https://api.github.com/users/bdwain/events{/privacy}","received_events_url":"https://api.github.com/users/bdwain/received_events","type":"User","site_admin":false},"body":"oh i see what you're trying to do. You want to allow the stuff in the root workspace to depend on the pre-built copy of example-yarn-workspace-2.\r\n\r\nMaking something like that work would be a much bigger change I think. Because focus was only intended to affect the workspace you focus on. So the root workspace was never really intended to be affected. Also I didn't realize the root workspace was a regular workspace that could be used but that's a separate thing. ","created_at":"2018-06-12T19:04:34Z","updated_at":"2018-06-12T19:04:35Z","html_url":"https://github.com/yarnpkg/yarn/pull/5967#discussion_r194854629","pull_request_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/194854629"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5967#discussion_r194854629"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967"}},"in_reply_to_id":194615779},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967","id":194002203,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDAyMjAz","html_url":"https://github.com/yarnpkg/yarn/pull/5967","diff_url":"https://github.com/yarnpkg/yarn/pull/5967.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5967.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5967","number":5967,"state":"open","locked":false,"title":"Adds a failing test for focused workspaces","user":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"body":"While working on making the workspace root implicitly depend on all of its child workspaces, I noticed a bug in the current implementation of the focused workspace feature. If the workspace root depend on a workspace, it won't get focused (symlinks will always be used instead).\r\n\r\nIt might also occur even for sibling workspaces, I just haven't checked yet. The workspace root is the one I'm the most interested in making it work for now.\r\n\r\nThis diff adds a test that reproduce the issue. @bdwain, do you have some bandwidth to give it a look? It would be super helpful 😃 \r\n","created_at":"2018-06-11T14:36:19Z","updated_at":"2018-06-12T19:04:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19df98771945f3b96311f664b791fee5c1a32732","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5967/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/4e305f49b8fdc1b47af735c6ac646c65fe43ccb0","head":{"label":"arcanis:focused-bug","ref":"focused-bug","sha":"4e305f49b8fdc1b47af735c6ac646c65fe43ccb0","user":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"repo":{"id":82685695,"node_id":"MDEwOlJlcG9zaXRvcnk4MjY4NTY5NQ==","name":"yarn","full_name":"arcanis/yarn","owner":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arcanis/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/arcanis/yarn","forks_url":"https://api.github.com/repos/arcanis/yarn/forks","keys_url":"https://api.github.com/repos/arcanis/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcanis/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcanis/yarn/teams","hooks_url":"https://api.github.com/repos/arcanis/yarn/hooks","issue_events_url":"https://api.github.com/repos/arcanis/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/arcanis/yarn/events","assignees_url":"https://api.github.com/repos/arcanis/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/arcanis/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/arcanis/yarn/tags","blobs_url":"https://api.github.com/repos/arcanis/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcanis/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcanis/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcanis/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcanis/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/arcanis/yarn/languages","stargazers_url":"https://api.github.com/repos/arcanis/yarn/stargazers","contributors_url":"https://api.github.com/repos/arcanis/yarn/contributors","subscribers_url":"https://api.github.com/repos/arcanis/yarn/subscribers","subscription_url":"https://api.github.com/repos/arcanis/yarn/subscription","commits_url":"https://api.github.com/repos/arcanis/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcanis/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcanis/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcanis/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/arcanis/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/arcanis/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcanis/yarn/merges","archive_url":"https://api.github.com/repos/arcanis/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcanis/yarn/downloads","issues_url":"https://api.github.com/repos/arcanis/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/arcanis/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/arcanis/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/arcanis/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcanis/yarn/labels{/name}","releases_url":"https://api.github.com/repos/arcanis/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/arcanis/yarn/deployments","created_at":"2017-02-21T13:56:57Z","updated_at":"2018-06-11T09:46:42Z","pushed_at":"2018-06-12T17:36:17Z","git_url":"git://github.com/arcanis/yarn.git","ssh_url":"git@github.com:arcanis/yarn.git","clone_url":"https://github.com/arcanis/yarn.git","svn_url":"https://github.com/arcanis/yarn","homepage":"https://yarnpkg.com","size":116218,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"9d678b9f996dbc3234295f8b0220f0f04fa23421","user":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDY0Mg==","name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-06-12T16:55:15Z","pushed_at":"2018-06-12T17:36:18Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":116832,"stargazers_count":31973,"watchers_count":31973,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1803,"mirror_url":null,"archived":false,"open_issues_count":1197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1803,"open_issues":1197,"watchers":31973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5967"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5967"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5967/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5967/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/4e305f49b8fdc1b47af735c6ac646c65fe43ccb0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bdwain"}}