{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/qpdf/qpdf/pulls/172","id":162877920,"html_url":"https://github.com/qpdf/qpdf/pull/172","diff_url":"https://github.com/qpdf/qpdf/pull/172.diff","patch_url":"https://github.com/qpdf/qpdf/pull/172.patch","issue_url":"https://api.github.com/repos/qpdf/qpdf/issues/172","number":172,"state":"closed","locked":false,"title":"Fix build with libc++","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"Fixes build failure\n```\nbash-3.2$ make -j1\n/bin/bash ./libtool --quiet --mode=compile clang++ -g -O2 -Wold-style-cast -Wall -MD -MF libqpdf/build/Pl_PNGFilter.tdep -MP -Iinclude -Ilibqpdf  -c libqpdf/Pl_PNGFilter.cc -o libqpdf/build/Pl_PNGFilter.o; sed -e 's/\\.o:/.lo:/' < libqpdf/build/Pl_PNGFilter.tdep > libqpdf/build/Pl_PNGFilter.dep\nlibqpdf/Pl_PNGFilter.cc:221:19: error: no member named 'abs' in namespace 'std'\n    int pa = std::abs(p - a);\n             ~~~~~^\nlibqpdf/Pl_PNGFilter.cc:222:19: error: no member named 'abs' in namespace 'std'\n    int pb = std::abs(p - b);\n             ~~~~~^\nlibqpdf/Pl_PNGFilter.cc:223:19: error: no member named 'abs' in namespace 'std'\n    int pc = std::abs(p - c);\n             ~~~~~^\n3 errors generated.\n/bin/bash ./libtool --mode=link clang++ -g -O2 -Wold-style-cast -Wall  -o libqpdf/build/libqpdf.la libqpdf/build/BitStream.lo libqpdf/build/BitWriter.lo libqpdf/build/Buffer.lo libqpdf/build/BufferInputSource.lo libqpdf/build/FileInputSource.lo libqpdf/build/InputSource.lo libqpdf/build/InsecureRandomDataProvider.lo libqpdf/build/MD5.lo libqpdf/build/OffsetInputSource.lo libqpdf/build/Pipeline.lo libqpdf/build/Pl_AES_PDF.lo libqpdf/build/Pl_ASCII85Decoder.lo libqpdf/build/Pl_ASCIIHexDecoder.lo libqpdf/build/Pl_Buffer.lo libqpdf/build/Pl_Concatenate.lo libqpdf/build/Pl_Count.lo libqpdf/build/Pl_DCT.lo libqpdf/build/Pl_Discard.lo libqpdf/build/Pl_Flate.lo libqpdf/build/Pl_LZWDecoder.lo libqpdf/build/Pl_MD5.lo libqpdf/build/Pl_PNGFilter.lo libqpdf/build/Pl_QPDFTokenizer.lo libqpdf/build/Pl_RC4.lo libqpdf/build/Pl_RunLength.lo libqpdf/build/Pl_SHA2.lo libqpdf/build/Pl_StdioFile.lo libqpdf/build/Pl_TIFFPredictor.lo libqpdf/build/QPDF.lo libqpdf/build/QPDFExc.lo libqpdf/build/QPDFObjGen.lo libqpdf/build/QPDFObject.lo libqpdf/build/QPDFObjectHandle.lo libqpdf/build/QPDFTokenizer.lo libqpdf/build/QPDFWriter.lo libqpdf/build/QPDFXRefEntry.lo libqpdf/build/QPDF_Array.lo libqpdf/build/QPDF_Bool.lo libqpdf/build/QPDF_Dictionary.lo libqpdf/build/QPDF_InlineImage.lo libqpdf/build/QPDF_Integer.lo libqpdf/build/QPDF_Name.lo libqpdf/build/QPDF_Null.lo libqpdf/build/QPDF_Operator.lo libqpdf/build/QPDF_Real.lo libqpdf/build/QPDF_Reserved.lo libqpdf/build/QPDF_Stream.lo libqpdf/build/QPDF_String.lo libqpdf/build/QPDF_encryption.lo libqpdf/build/QPDF_linearization.lo libqpdf/build/QPDF_optimization.lo libqpdf/build/QPDF_pages.lo libqpdf/build/QTC.lo libqpdf/build/QUtil.lo libqpdf/build/RC4.lo libqpdf/build/SecureRandomDataProvider.lo libqpdf/build/qpdf-c.lo libqpdf/build/rijndael.lo libqpdf/build/sha2.lo libqpdf/build/sha2big.lo -ljpeg -lz   -rpath /usr/local/Cellar/qpdf/7.1.0/lib -version-info 20:0:2 -no-undefined\nlibtool:   error: 'libqpdf/build/Pl_PNGFilter.lo' is not a valid libtool object\nmake: *** [libqpdf/build/libqpdf.la] Error 1\nbash-3.2$\n```","created_at":"2018-01-15T06:38:26Z","updated_at":"2018-02-04T19:20:00Z","closed_at":"2018-02-04T19:20:00Z","merged_at":null,"merge_commit_sha":"37d2df0271c95bc28c0d4a50e314ed5687e53312","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/qpdf/qpdf/pulls/172/commits","review_comments_url":"https://api.github.com/repos/qpdf/qpdf/pulls/172/comments","review_comment_url":"https://api.github.com/repos/qpdf/qpdf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qpdf/qpdf/issues/172/comments","statuses_url":"https://api.github.com/repos/qpdf/qpdf/statuses/3c0abfd170390613eae5ac970b3f0211e46fde30","head":{"label":"ilovezfs:libc++","ref":"libc++","sha":"3c0abfd170390613eae5ac970b3f0211e46fde30","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"repo":{"id":117506718,"name":"qpdf","full_name":"ilovezfs/qpdf","owner":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilovezfs/qpdf","description":"Primary QPDF source code and documentation","fork":true,"url":"https://api.github.com/repos/ilovezfs/qpdf","forks_url":"https://api.github.com/repos/ilovezfs/qpdf/forks","keys_url":"https://api.github.com/repos/ilovezfs/qpdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilovezfs/qpdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilovezfs/qpdf/teams","hooks_url":"https://api.github.com/repos/ilovezfs/qpdf/hooks","issue_events_url":"https://api.github.com/repos/ilovezfs/qpdf/issues/events{/number}","events_url":"https://api.github.com/repos/ilovezfs/qpdf/events","assignees_url":"https://api.github.com/repos/ilovezfs/qpdf/assignees{/user}","branches_url":"https://api.github.com/repos/ilovezfs/qpdf/branches{/branch}","tags_url":"https://api.github.com/repos/ilovezfs/qpdf/tags","blobs_url":"https://api.github.com/repos/ilovezfs/qpdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilovezfs/qpdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilovezfs/qpdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilovezfs/qpdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilovezfs/qpdf/statuses/{sha}","languages_url":"https://api.github.com/repos/ilovezfs/qpdf/languages","stargazers_url":"https://api.github.com/repos/ilovezfs/qpdf/stargazers","contributors_url":"https://api.github.com/repos/ilovezfs/qpdf/contributors","subscribers_url":"https://api.github.com/repos/ilovezfs/qpdf/subscribers","subscription_url":"https://api.github.com/repos/ilovezfs/qpdf/subscription","commits_url":"https://api.github.com/repos/ilovezfs/qpdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilovezfs/qpdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilovezfs/qpdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilovezfs/qpdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilovezfs/qpdf/contents/{+path}","compare_url":"https://api.github.com/repos/ilovezfs/qpdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilovezfs/qpdf/merges","archive_url":"https://api.github.com/repos/ilovezfs/qpdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilovezfs/qpdf/downloads","issues_url":"https://api.github.com/repos/ilovezfs/qpdf/issues{/number}","pulls_url":"https://api.github.com/repos/ilovezfs/qpdf/pulls{/number}","milestones_url":"https://api.github.com/repos/ilovezfs/qpdf/milestones{/number}","notifications_url":"https://api.github.com/repos/ilovezfs/qpdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilovezfs/qpdf/labels{/name}","releases_url":"https://api.github.com/repos/ilovezfs/qpdf/releases{/id}","deployments_url":"https://api.github.com/repos/ilovezfs/qpdf/deployments","created_at":"2018-01-15T06:35:19Z","updated_at":"2018-01-15T06:35:21Z","pushed_at":"2018-01-15T06:37:33Z","git_url":"git://github.com/ilovezfs/qpdf.git","ssh_url":"git@github.com:ilovezfs/qpdf.git","clone_url":"https://github.com/ilovezfs/qpdf.git","svn_url":"https://github.com/ilovezfs/qpdf","homepage":null,"size":14036,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qpdf:master","ref":"master","sha":"2e4ca7ecf465efda799907c2554870e4f9dc6679","user":{"login":"qpdf","id":1812112,"avatar_url":"https://avatars0.githubusercontent.com/u/1812112?v=4","gravatar_id":"","url":"https://api.github.com/users/qpdf","html_url":"https://github.com/qpdf","followers_url":"https://api.github.com/users/qpdf/followers","following_url":"https://api.github.com/users/qpdf/following{/other_user}","gists_url":"https://api.github.com/users/qpdf/gists{/gist_id}","starred_url":"https://api.github.com/users/qpdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qpdf/subscriptions","organizations_url":"https://api.github.com/users/qpdf/orgs","repos_url":"https://api.github.com/users/qpdf/repos","events_url":"https://api.github.com/users/qpdf/events{/privacy}","received_events_url":"https://api.github.com/users/qpdf/received_events","type":"Organization","site_admin":false},"repo":{"id":4539167,"name":"qpdf","full_name":"qpdf/qpdf","owner":{"login":"qpdf","id":1812112,"avatar_url":"https://avatars0.githubusercontent.com/u/1812112?v=4","gravatar_id":"","url":"https://api.github.com/users/qpdf","html_url":"https://github.com/qpdf","followers_url":"https://api.github.com/users/qpdf/followers","following_url":"https://api.github.com/users/qpdf/following{/other_user}","gists_url":"https://api.github.com/users/qpdf/gists{/gist_id}","starred_url":"https://api.github.com/users/qpdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qpdf/subscriptions","organizations_url":"https://api.github.com/users/qpdf/orgs","repos_url":"https://api.github.com/users/qpdf/repos","events_url":"https://api.github.com/users/qpdf/events{/privacy}","received_events_url":"https://api.github.com/users/qpdf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qpdf/qpdf","description":"Primary QPDF source code and documentation","fork":false,"url":"https://api.github.com/repos/qpdf/qpdf","forks_url":"https://api.github.com/repos/qpdf/qpdf/forks","keys_url":"https://api.github.com/repos/qpdf/qpdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qpdf/qpdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qpdf/qpdf/teams","hooks_url":"https://api.github.com/repos/qpdf/qpdf/hooks","issue_events_url":"https://api.github.com/repos/qpdf/qpdf/issues/events{/number}","events_url":"https://api.github.com/repos/qpdf/qpdf/events","assignees_url":"https://api.github.com/repos/qpdf/qpdf/assignees{/user}","branches_url":"https://api.github.com/repos/qpdf/qpdf/branches{/branch}","tags_url":"https://api.github.com/repos/qpdf/qpdf/tags","blobs_url":"https://api.github.com/repos/qpdf/qpdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qpdf/qpdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qpdf/qpdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/qpdf/qpdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qpdf/qpdf/statuses/{sha}","languages_url":"https://api.github.com/repos/qpdf/qpdf/languages","stargazers_url":"https://api.github.com/repos/qpdf/qpdf/stargazers","contributors_url":"https://api.github.com/repos/qpdf/qpdf/contributors","subscribers_url":"https://api.github.com/repos/qpdf/qpdf/subscribers","subscription_url":"https://api.github.com/repos/qpdf/qpdf/subscription","commits_url":"https://api.github.com/repos/qpdf/qpdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/qpdf/qpdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/qpdf/qpdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/qpdf/qpdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/qpdf/qpdf/contents/{+path}","compare_url":"https://api.github.com/repos/qpdf/qpdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qpdf/qpdf/merges","archive_url":"https://api.github.com/repos/qpdf/qpdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qpdf/qpdf/downloads","issues_url":"https://api.github.com/repos/qpdf/qpdf/issues{/number}","pulls_url":"https://api.github.com/repos/qpdf/qpdf/pulls{/number}","milestones_url":"https://api.github.com/repos/qpdf/qpdf/milestones{/number}","notifications_url":"https://api.github.com/repos/qpdf/qpdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qpdf/qpdf/labels{/name}","releases_url":"https://api.github.com/repos/qpdf/qpdf/releases{/id}","deployments_url":"https://api.github.com/repos/qpdf/qpdf/deployments","created_at":"2012-06-03T17:40:19Z","updated_at":"2018-02-01T20:11:52Z","pushed_at":"2018-02-04T19:20:00Z","git_url":"git://github.com/qpdf/qpdf.git","ssh_url":"git@github.com:qpdf/qpdf.git","clone_url":"https://github.com/qpdf/qpdf.git","svn_url":"https://github.com/qpdf/qpdf","homepage":null,"size":14046,"stargazers_count":355,"watchers_count":355,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":54,"open_issues":46,"watchers":355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qpdf/qpdf/pulls/172"},"html":{"href":"https://github.com/qpdf/qpdf/pull/172"},"issue":{"href":"https://api.github.com/repos/qpdf/qpdf/issues/172"},"comments":{"href":"https://api.github.com/repos/qpdf/qpdf/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/qpdf/qpdf/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/qpdf/qpdf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qpdf/qpdf/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/qpdf/qpdf/statuses/3c0abfd170390613eae5ac970b3f0211e46fde30"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jberkenbilt"}}