{"action":"created","comment":{"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments/183434364","pull_request_review_id":114411546,"id":183434364,"diff_hunk":"@@ -0,0 +1,70 @@\n+/**\n+ * Italia PagoPA Proxy\n+ * Cittadinanza Digitale PagoPA services\n+ *\n+ */\n+\n+import * as Mocked from \"../MockedData\";\n+\n+import { none, Option, some } from \"fp-ts/lib/Option\";\n+\n+import { CreditCard } from \"../types/CreditCard\";\n+import { PaymentMethod, PaymentMethodType } from \"../types/PaymentMethod\";\n+import { ITransaction } from \"../types/Transaction\";\n+import { IUser } from \"../types/User\";\n+\n+/**\n+ * User Controller\n+ */\n+export class UserController {\n+    constructor(public user: IUser) { }\n+\n+    public getWallet(): ReadonlyArray<PaymentMethod> {\n+        return Mocked.wallet;\n+    }\n+\n+    public getCreditCards(): ReadonlyArray<CreditCard> {\n+        return (\n+            Mocked.wallet","path":"src/controllers/UserController.ts","position":28,"original_position":28,"commit_id":"a9e880cfaa378ec0321e0c91c220888c0bd9e7bf","original_commit_id":"a9e880cfaa378ec0321e0c91c220888c0bd9e7bf","user":{"login":"gunzip","id":148224,"avatar_url":"https://avatars2.githubusercontent.com/u/148224?v=4","gravatar_id":"","url":"https://api.github.com/users/gunzip","html_url":"https://github.com/gunzip","followers_url":"https://api.github.com/users/gunzip/followers","following_url":"https://api.github.com/users/gunzip/following{/other_user}","gists_url":"https://api.github.com/users/gunzip/gists{/gist_id}","starred_url":"https://api.github.com/users/gunzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunzip/subscriptions","organizations_url":"https://api.github.com/users/gunzip/orgs","repos_url":"https://api.github.com/users/gunzip/repos","events_url":"https://api.github.com/users/gunzip/events{/privacy}","received_events_url":"https://api.github.com/users/gunzip/received_events","type":"User","site_admin":false},"body":"getCreditCards must take the wallet as an argument. make functions \"pure\", limit the use of global variables.","created_at":"2018-04-23T15:19:40Z","updated_at":"2018-04-23T15:32:48Z","html_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8#discussion_r183434364","pull_request_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments/183434364"},"html":{"href":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8#discussion_r183434364"},"pull_request":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8","id":183454378,"html_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8","diff_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8.diff","patch_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8.patch","issue_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/8","number":8,"state":"open","locked":false,"title":"156913899 skeleton","user":{"login":"fgiobergia","id":107715,"avatar_url":"https://avatars3.githubusercontent.com/u/107715?v=4","gravatar_id":"","url":"https://api.github.com/users/fgiobergia","html_url":"https://github.com/fgiobergia","followers_url":"https://api.github.com/users/fgiobergia/followers","following_url":"https://api.github.com/users/fgiobergia/following{/other_user}","gists_url":"https://api.github.com/users/fgiobergia/gists{/gist_id}","starred_url":"https://api.github.com/users/fgiobergia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgiobergia/subscriptions","organizations_url":"https://api.github.com/users/fgiobergia/orgs","repos_url":"https://api.github.com/users/fgiobergia/repos","events_url":"https://api.github.com/users/fgiobergia/events{/privacy}","received_events_url":"https://api.github.com/users/fgiobergia/received_events","type":"User","site_admin":false},"body":"First pull request, some feedback appreciated :) \r\n\r\nTODO:\r\n- add \"read\" API for transactions (+ tests)\r\n- get a better grip on `ts-io` (& improve code accordingly)\r\n- pretty much everything else (CRUD for cc and transactions when applicable, interfacing w/ PagoPA)","created_at":"2018-04-23T14:32:44Z","updated_at":"2018-04-23T15:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19ac125b88e80c4d280b82f4f1d63345ae9fbfa2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8/commits","review_comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8/comments","review_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/8/comments","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/a9e880cfaa378ec0321e0c91c220888c0bd9e7bf","head":{"label":"teamdigitale:156913899-skeleton","ref":"156913899-skeleton","sha":"a9e880cfaa378ec0321e0c91c220888c0bd9e7bf","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":127117664,"name":"italia-pagopa-proxy","full_name":"teamdigitale/italia-pagopa-proxy","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-pagopa-proxy","description":"A proxy for interacting with pagoPA backend","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy","forks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/deployments","created_at":"2018-03-28T09:35:14Z","updated_at":"2018-04-23T15:31:36Z","pushed_at":"2018-04-23T15:28:57Z","git_url":"git://github.com/teamdigitale/italia-pagopa-proxy.git","ssh_url":"git@github.com:teamdigitale/italia-pagopa-proxy.git","clone_url":"https://github.com/teamdigitale/italia-pagopa-proxy.git","svn_url":"https://github.com/teamdigitale/italia-pagopa-proxy","homepage":null,"size":203,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"teamdigitale:master","ref":"master","sha":"3a4092662579a6f48144bd8d59a754f9d09a6e3d","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":127117664,"name":"italia-pagopa-proxy","full_name":"teamdigitale/italia-pagopa-proxy","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-pagopa-proxy","description":"A proxy for interacting with pagoPA backend","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy","forks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/deployments","created_at":"2018-03-28T09:35:14Z","updated_at":"2018-04-23T15:31:36Z","pushed_at":"2018-04-23T15:28:57Z","git_url":"git://github.com/teamdigitale/italia-pagopa-proxy.git","ssh_url":"git@github.com:teamdigitale/italia-pagopa-proxy.git","clone_url":"https://github.com/teamdigitale/italia-pagopa-proxy.git","svn_url":"https://github.com/teamdigitale/italia-pagopa-proxy","homepage":null,"size":203,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8"},"html":{"href":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/8"},"issue":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/8"},"comments":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/a9e880cfaa378ec0321e0c91c220888c0bd9e7bf"}},"author_association":"NONE"}}
{"actor":{"display_login":"gunzip"}}