{"action":"created","issue":{"url":"https://api.github.com/repos/urbit/urbit/issues/962","repository_url":"https://api.github.com/repos/urbit/urbit","labels_url":"https://api.github.com/repos/urbit/urbit/issues/962/labels{/name}","comments_url":"https://api.github.com/repos/urbit/urbit/issues/962/comments","events_url":"https://api.github.com/repos/urbit/urbit/issues/962/events","html_url":"https://github.com/urbit/urbit/pull/962","id":313422580,"number":962,"title":"ignores AddressSanitizer errors in jets.c","user":{"login":"joemfb","id":702304,"avatar_url":"https://avatars2.githubusercontent.com/u/702304?v=4","gravatar_id":"","url":"https://api.github.com/users/joemfb","html_url":"https://github.com/joemfb","followers_url":"https://api.github.com/users/joemfb/followers","following_url":"https://api.github.com/users/joemfb/following{/other_user}","gists_url":"https://api.github.com/users/joemfb/gists{/gist_id}","starred_url":"https://api.github.com/users/joemfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemfb/subscriptions","organizations_url":"https://api.github.com/users/joemfb/orgs","repos_url":"https://api.github.com/users/joemfb/repos","events_url":"https://api.github.com/users/joemfb/events{/privacy}","received_events_url":"https://api.github.com/users/joemfb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-11T17:42:15Z","updated_at":"2018-04-11T18:14:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/urbit/urbit/pulls/962","html_url":"https://github.com/urbit/urbit/pull/962","diff_url":"https://github.com/urbit/urbit/pull/962.diff","patch_url":"https://github.com/urbit/urbit/pull/962.patch"},"body":"AddressSanitizer doesn't like the iterator/terminator pattern in `tree.c` and `jets.c`, and claims that it constitutes a global buffer overflow. I'm not qualified to adjudicate that claim, so I'm just excluding the relevant functions from AddressSanitizer.\r\n\r\nThis PR supersedes #915. The build changes are no longer necessary (`meson -Db_sanitize=address $BUILD_DIR`), and the CI integration should be discussed separately (ubuntu on travis is really old)."},"comment":{"url":"https://api.github.com/repos/urbit/urbit/issues/comments/380546822","html_url":"https://github.com/urbit/urbit/pull/962#issuecomment-380546822","issue_url":"https://api.github.com/repos/urbit/urbit/issues/962","id":380546822,"user":{"login":"ohAitch","id":1857414,"avatar_url":"https://avatars3.githubusercontent.com/u/1857414?v=4","gravatar_id":"","url":"https://api.github.com/users/ohAitch","html_url":"https://github.com/ohAitch","followers_url":"https://api.github.com/users/ohAitch/followers","following_url":"https://api.github.com/users/ohAitch/following{/other_user}","gists_url":"https://api.github.com/users/ohAitch/gists{/gist_id}","starred_url":"https://api.github.com/users/ohAitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohAitch/subscriptions","organizations_url":"https://api.github.com/users/ohAitch/orgs","repos_url":"https://api.github.com/users/ohAitch/repos","events_url":"https://api.github.com/users/ohAitch/events{/privacy}","received_events_url":"https://api.github.com/users/ohAitch/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T18:14:49Z","updated_at":"2018-04-11T18:14:49Z","author_association":"CONTRIBUTOR","body":"Sense, I think I'm still going to declare that \"subcedes\" or w/e insofar as this pr should be merged without closing #915"}}
{"actor":{"display_login":"ohAitch"}}