{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/202744486","pull_request_review_id":137501724,"id":202744486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc0NDQ4Ng==","diff_hunk":"@@ -41,6 +43,15 @@ def service_ready?\n       @service.dig(\"spec\", \"clusterIP\").present?\n     end\n \n+    def name\n+      return unless @instance_data.present?","path":"lib/kubernetes-deploy/kubernetes_resource/redis.rb","position":18,"original_position":18,"commit_id":"107f04ef6b6f5cef242ce17e4f2c8d0b2e06f3f4","original_commit_id":"107f04ef6b6f5cef242ce17e4f2c8d0b2e06f3f4","user":{"login":"KnVerey","id":4789493,"node_id":"MDQ6VXNlcjQ3ODk0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4789493?v=4","gravatar_id":"","url":"https://api.github.com/users/KnVerey","html_url":"https://github.com/KnVerey","followers_url":"https://api.github.com/users/KnVerey/followers","following_url":"https://api.github.com/users/KnVerey/following{/other_user}","gists_url":"https://api.github.com/users/KnVerey/gists{/gist_id}","starred_url":"https://api.github.com/users/KnVerey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnVerey/subscriptions","organizations_url":"https://api.github.com/users/KnVerey/orgs","repos_url":"https://api.github.com/users/KnVerey/repos","events_url":"https://api.github.com/users/KnVerey/events{/privacy}","received_events_url":"https://api.github.com/users/KnVerey/received_events","type":"User","site_admin":false},"body":"Since the name couldn't possibly have changed between the live copy (`@instance_data`) and the in-repo copy (`@definition`), I'd suggest using `@definition` for this instead.","created_at":"2018-07-16T16:20:39Z","updated_at":"2018-07-16T16:25:23Z","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/318#discussion_r202744486","pull_request_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/202744486"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/318#discussion_r202744486"},"pull_request":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318","id":201650679,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjUwNjc5","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/318","diff_url":"https://github.com/Shopify/kubernetes-deploy/pull/318.diff","patch_url":"https://github.com/Shopify/kubernetes-deploy/pull/318.patch","issue_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/318","number":318,"state":"open","locked":false,"title":"[Caching-Queuing] Rename redis resources","user":{"login":"tskorupa","id":318850,"node_id":"MDQ6VXNlcjMxODg1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/318850?v=4","gravatar_id":"","url":"https://api.github.com/users/tskorupa","html_url":"https://github.com/tskorupa","followers_url":"https://api.github.com/users/tskorupa/followers","following_url":"https://api.github.com/users/tskorupa/following{/other_user}","gists_url":"https://api.github.com/users/tskorupa/gists{/gist_id}","starred_url":"https://api.github.com/users/tskorupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tskorupa/subscriptions","organizations_url":"https://api.github.com/users/tskorupa/orgs","repos_url":"https://api.github.com/users/tskorupa/repos","events_url":"https://api.github.com/users/tskorupa/events{/privacy}","received_events_url":"https://api.github.com/users/tskorupa/received_events","type":"User","site_admin":false},"body":"This commit follows the work performed in https://github.com/Shopify/cloudbuddies/pull/1115.\r\n\r\nThe redis resources were renamed. The kubernetes deployment script specifically looked for a prefix 'redis-' in the name. Whereas we wish to name resources according to their given names.\r\n\r\nThe current commit first looks for resources using the new names, otherwise it default to the 'legacy' naming. Legacy naming can be deployed once we migrate all redis instances.\r\n\r\n@Shopify/caching-queuing ","created_at":"2018-07-16T14:12:29Z","updated_at":"2018-07-16T16:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ec51b6b6cd9cac4bc75020b6eb2b785deecc8b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318/commits","review_comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318/comments","review_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/318/comments","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/107f04ef6b6f5cef242ce17e4f2c8d0b2e06f3f4","head":{"label":"Shopify:caching-queuing/rename-redis-resources","ref":"caching-queuing/rename-redis-resources","sha":"107f04ef6b6f5cef242ce17e4f2c8d0b2e06f3f4","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-07-16T13:56:58Z","pushed_at":"2018-07-16T14:12:30Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6750,"stargazers_count":448,"watchers_count":448,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":47,"watchers":448,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"435b5453d051fc63313477574e1c632e9c36bd6d","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-07-16T13:56:58Z","pushed_at":"2018-07-16T14:12:30Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6750,"stargazers_count":448,"watchers_count":448,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":47,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/318"},"issue":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/318"},"comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/107f04ef6b6f5cef242ce17e4f2c8d0b2e06f3f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"KnVerey"}}