{"push_id":2911465936,"size":15,"distinct_size":1,"ref":"refs/heads/commitfest/19/1480","head":"d5aca015c5b5f50a7e02540fd226e97c063ef385","before":"4b96bc911c431fff38c00e8542c5d442e5b3455c","commits":[{"sha":"f535d5f0c13cb48d85565017e7d56f2075c59978","author":{"name":"Michael Paquier","email":"17b9e1c64588c7fa6419b4d29dc1f4426279ba01@paquier.xyz"},"message":"Add basic regression tests for default monitoring roles\n\nThe following default roles gain some coverage:\n- pg_read_all_stats\n- pg_read_all_settings\n\nAuthor: Alexandra Ryzhevich\nDiscussion: https://postgr.es/m/CAOt4E5S5WJmDc9YpS1BfyAMQ5C1NEmiYynD6nUz42qVxphqkpA@mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/f535d5f0c13cb48d85565017e7d56f2075c59978"},{"sha":"2e2a392de391a9f4ef4221fccbd00c43ba5c9b40","author":{"name":"Tomas Vondra","email":"07d6043e15c7eaaf8513ba9a264e5412dbd73bf7@postgresql.org"},"message":"Fix problems in handling the line data type\n\nAccording to the source history, the internal format of line data type\nhas changed, but various functions working with it did were not updated\nand thus were producing wrong results.\n\nThis patch addresses various such issues, in particular:\n\n* Reject invalid specification A=B=0 on receive\n* Reject same points on line_construct_pp()\n* Fix perpendicular operator when negative values are involved\n* Avoid division by zero on perpendicular operator\n* Fix intersection and distance operators when neither A nor B are 1\n* Return NULL for closest point when objects are parallel\n* Check whether closest point of line segments is the intersection point\n* Fix closest point of line segments being on the wrong segment\n\nAside from handling those issues, the patch also aims to make operators\nmore symmetric and less sen to precision loss.  The EPSILON interferes\nwith even minor changes, but the least we can do is applying it to both\nsides of the operators equally.\n\nAuthor: Emre Hasegeli\nReviewed-by: Tomas Vondra\n\nDiscussion: https://www.postgresql.org/message-id/CAE2gYzxF7-5djV6-cEvqQu-fNsnt%3DEqbOURx7ZDg%2BVv6ZMTWbg%40mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/2e2a392de391a9f4ef4221fccbd00c43ba5c9b40"},{"sha":"a3d2844852dc664718320b15cbc6d6bfa264e66e","author":{"name":"Tomas Vondra","email":"07d6043e15c7eaaf8513ba9a264e5412dbd73bf7@postgresql.org"},"message":"Improve test coverage of geometric types\n\nThis commit significantly increases test coverage of geo_ops.c, adding\ntests for various issues addressed by 2e2a392de3 (which went undetected\nfor a long time, at least partially due to not being covered).\n\nThis also removes alternative results expecting -0 on some platforms.\nInstead the functions are should return the same results everywhere,\ntransforming -0 to 0 if needed.\n\nThe tests are added to geometric.sql file, sorted by the left hand side\nof the operators. There are many cross datatype operators, so this seems\nlike the best solution.\n\nAuthor: Emre Hasegeli\nReviewed-by: Tomas Vondra\n\nDiscussion: https://www.postgresql.org/message-id/CAE2gYzxF7-5djV6-cEvqQu-fNsnt%3DEqbOURx7ZDg%2BVv6ZMTWbg%40mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/a3d2844852dc664718320b15cbc6d6bfa264e66e"},{"sha":"a49ceda6a044c2fc104b3d1397fe0bef8679d1aa","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"Update dummy CREATE ASSERTION grammar\n\nWhile we are probably still far away from fully implementing\nassertions, all patch proposals appear to take issue with the existing\ndummy grammar CREATE/DROP ASSERTION productions, so update those a\nlittle bit.  Rename the rule, use any_name instead of name, and remove\nsome unused code.  Also remove the production for DROP ASSERTION,\nsince that would most likely be handled via the generic DROP support.\n\nextracted from a patch by Joe Wildish","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/a49ceda6a044c2fc104b3d1397fe0bef8679d1aa"},{"sha":"26e9d4d4ef16b5e2be96319f89ea6ba7f63a4d73","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Convert elog.c's useful_strerror() into a globally-used strerror wrapper.\n\nelog.c has long had a private strerror wrapper that handles assorted\npossible failures or deficiencies of the platform's strerror.  On Windows,\nit also knows how to translate Winsock error codes, which the native\nstrerror does not.  Move all this code into src/port/strerror.c and\ndefine strerror() as a macro that invokes it, so that both our frontend\nand backend code will have all of this behavior.\n\nI believe this constitutes an actual bug fix on Windows, since AFAICS\nour frontend code did not report Winsock error codes properly before this.\nHowever, the main point is to lay the groundwork for implementing %m\nin src/port/snprintf.c: the behavior we want %m to have is this one,\nnot the native strerror's.\n\nNote that this throws away the prior use of src/port/strerror.c,\nwhich was to implement strerror() on platforms lacking it.  That's\nbeen dead code for nigh twenty years now, since strerror() was\nalready required by C89.\n\nWe should likewise cause strerror_r to use this behavior, but\nI'll tackle that separately.\n\nPatch by me, reviewed by Michael Paquier\n\nDiscussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/26e9d4d4ef16b5e2be96319f89ea6ba7f63a4d73"},{"sha":"758ce9b7794845f95473c569155d29fcf0e2751b","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Incorporate strerror_r() into src/port/snprintf.c, too.\n\nThis provides the features that used to exist in useful_strerror()\nfor users of strerror_r(), too.  Also, standardize on the GNU convention\nthat strerror_r returns a char pointer that may not be NULL.\n\nI notice that libpq's win32.c contains a variant version of strerror_r\nthat probably ought to be folded into strerror.c.  But lacking a\nWindows environment, I should leave that to somebody else.\n\nDiscussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/758ce9b7794845f95473c569155d29fcf0e2751b"},{"sha":"96bf88d52711ad3a0a4cc2d1d9cb0e2acab85e63","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Always use our own versions of *printf().\n\nWe've spent an awful lot of effort over the years in coping with\nplatform-specific vagaries of the *printf family of functions.  Let's just\nforget all that mess and standardize on always using src/port/snprintf.c.\nThis gets rid of a lot of configure logic, and it will allow a saner\napproach to dealing with %m (though actually changing that is left for\na follow-on patch).\n\nPreliminary performance testing suggests that as it stands, snprintf.c is\nfaster than the native printf functions for some tasks on some platforms,\nand slower for other cases.  A pending patch will improve that, though\ncases with floating-point conversions will doubtless remain slower unless\nwe want to put a *lot* of effort into that.  Still, we've not observed\nthat *printf is really a performance bottleneck for most workloads, so\nI doubt this matters much.\n\nPatch by me, reviewed by Michael Paquier\n\nDiscussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/96bf88d52711ad3a0a4cc2d1d9cb0e2acab85e63"},{"sha":"d6c55de1f99a9028540516316b95321a7b12a540","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.\n\nI started out with the idea that we needed to detect use of %m format specs\nin contexts other than elog/ereport calls, because we couldn't rely on that\nworking in *printf calls.  But a better answer is to fix things so that it\ndoes work.  Now that we're using snprintf.c all the time, we can implement\n%m in that and we've fixed the problem.\n\nThis requires also adjusting our various printf-wrapping functions so that\nthey ensure \"errno\" is preserved when they call snprintf.c.\n\nRemove elog.c's handmade implementation of %m, and let it rely on\nsnprintf to support the feature.  That should provide some performance\ngain, though I've not attempted to measure it.\n\nThere are a lot of places where we could now simplify 'printf(\"%s\",\nstrerror(errno))' into 'printf(\"%m\")', but I'm not in any big hurry\nto make that happen.\n\nPatch by me, reviewed by Michael Paquier\n\nDiscussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/d6c55de1f99a9028540516316b95321a7b12a540"},{"sha":"0320ddaf3c08ea17d616549d0e7f45239592fc76","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"Recurse to sequences on ownership change for all relkinds\n\nWhen a table ownership is changed, we must apply that also to any owned\nsequences.  (Otherwise, it would result in a situation that cannot be\nrestored, because linked sequences must have the same owner as the\ntable.)  But this was previously only applied to regular tables and\nmaterialized views.  But it should also apply to at least foreign\ntables.  This patch removes the relkind check altogether, because it\ndoesn't save very much and just introduces the possibility of similar\nomissions.\n\nBug: #15238\nReported-by: Christoph Berg <christoph.berg@credativ.de>","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/0320ddaf3c08ea17d616549d0e7f45239592fc76"},{"sha":"a6b88d682cbec73474a73c9782fb7096e9440a8b","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix link failures due to snprintf/strerror changes.\n\nsnprintf.c requires isnan(), which requires -lm on some platforms.\nlibpq never bothered with -lm before, but now it needs it.\n\nstrerror.c tries to translate a string or two, which requires -lintl.\nWe'd managed never to need that anywhere in ecpg/pgtypeslib/ before,\nbut now we do.\n\nPer buildfarm and a report from Peter Eisentraut.\n\nDiscussion: https://postgr.es/m/20180926190934.ea4xvzhkayuw7gkx@alap3.anarazel.de\nDiscussion: https://postgr.es/m/f67b5008-9f01-057f-2bff-558cb53af851@2ndquadrant.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/a6b88d682cbec73474a73c9782fb7096e9440a8b"},{"sha":"8b91d258844afa58e856ac354f9ba9745ff9ffb2","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Clean up *printf macros to avoid conflict with format archetypes.\n\nWe must define the macro \"printf\" with arguments, else it can mess\nup format archetype attributes in builds where PG_PRINTF_ATTRIBUTE\nis just \"printf\".  Fortunately, that's easy to do now that we're\nrequiring C99; we can use __VA_ARGS__.\n\nOn the other hand, it's better not to use __VA_ARGS__ for the rest\nof the *printf crew, so that one can take the addresses of those\nfunctions without surprises.\n\nI'd proposed doing this some time ago, but forgot to make it happen;\nbuildfarm failures subsequent to 96bf88d52 reminded me.\n\nDiscussion: https://postgr.es/m/22709.1535135640@sss.pgh.pa.us\nDiscussion: https://postgr.es/m/20180926190934.ea4xvzhkayuw7gkx@alap3.anarazel.de","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/8b91d258844afa58e856ac354f9ba9745ff9ffb2"},{"sha":"751f532b9766fb5d3c334758abea95b7bb085c5a","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Try another way to detect the result type of strerror_r().\n\nThe method we've traditionally used, of redeclaring strerror_r() to\nsee if the compiler complains of inconsistent declarations, turns out\nnot to work reliably because some compilers only report a warning,\nnot an error.  Amazingly, this has gone undetected for years, even\nthough it certainly breaks our detection of whether strerror_r\nsucceeded.\n\nLet's instead test whether the compiler will take the result of\nstrerror_r() as a switch() argument.  It's possible this won't\nwork universally either, but it's the best idea I could come up with\non the spur of the moment.\n\nWe should probably back-patch this once the dust settles, but\nfirst let's see what the buildfarm thinks of it.\n\nDiscussion: https://postgr.es/m/10877.1537993279@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/751f532b9766fb5d3c334758abea95b7bb085c5a"},{"sha":"ba16aade337b16028d1e9e156d83417097c13817","author":{"name":"Michael Paquier","email":"17b9e1c64588c7fa6419b4d29dc1f4426279ba01@paquier.xyz"},"message":"Switch flags tracking pending interrupts to sig_atomic_t\n\nThose previously used bool, which should be safe on any modern\nplatforms, however the C standard is clear that it is better to use\nsig_atomic_t for variables manipulated in signal handlers.  This commit\nadds at the same time PGDLLIMPORT to ClientConnectionLost.\n\nAuthor: Michael Paquier\nReviewed-by: Tom Lane, Chris Travers, Andres Freund\nDiscussion: https://postgr.es/m/20180925011311.GD1354@paquier.xyz","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/ba16aade337b16028d1e9e156d83417097c13817"},{"sha":"ce4887bd025b95c7b455fefd817a418844c6aad3","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix another portability issue from commit 758ce9b77.\n\nstrerror.c now requires strlcpy() in some cases, and a couple of the\necpg libraries did not have that at hand.  Pull it in from src/port/\nfollowing the usual recipe.  Per buildfarm.","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/ce4887bd025b95c7b455fefd817a418844c6aad3"},{"sha":"d5aca015c5b5f50a7e02540fd226e97c063ef385","author":{"name":"Commitfest Bot","email":"b9e638e07cc2e2abf56c9c0cad7954f2e3bc1641@cputube.org"},"message":"[CF 19/1480] Find additional connection service files in pg_service.conf.d directory\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread, and also periodically to check for bitrot caused by changes\non the master branch.\n\nCommitfest entry: https://commitfest.postgresql.org/19/1480\nPatch(es): https://www.postgresql.org/message-id/CAMv20O-0gicaYWz=3Gxm7pyAHqZAv8keDbB05-Gfk-3RxD72oQ@mail.gmail.com\nAuthor(s): Curt Tilmes","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/d5aca015c5b5f50a7e02540fd226e97c063ef385"}]}
{"actor":{"display_login":"postgresql-cfbot"}}