{"action":"created","comment":{"url":"https://api.github.com/repos/liferay/clay/pulls/comments/232958835","pull_request_review_id":174266467,"id":232958835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk1ODgzNQ==","diff_hunk":"@@ -6,11 +6,23 @@\n {template .render}\n \t{@param spritemap: string}\n \t{@param symbol: string}\n+\t{@param? ariaLabel: string}","path":"packages/clay-icon/src/ClayIcon.soy","position":4,"original_position":4,"commit_id":"641878a25a064235ee4ac36d9fd0a5ad0e35ea02","original_commit_id":"11a7a8a4b7bdc157db105181ad63765695591d39","user":{"login":"carloslancha","id":5803434,"node_id":"MDQ6VXNlcjU4MDM0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5803434?v=4","gravatar_id":"","url":"https://api.github.com/users/carloslancha","html_url":"https://github.com/carloslancha","followers_url":"https://api.github.com/users/carloslancha/followers","following_url":"https://api.github.com/users/carloslancha/following{/other_user}","gists_url":"https://api.github.com/users/carloslancha/gists{/gist_id}","starred_url":"https://api.github.com/users/carloslancha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloslancha/subscriptions","organizations_url":"https://api.github.com/users/carloslancha/orgs","repos_url":"https://api.github.com/users/carloslancha/repos","events_url":"https://api.github.com/users/carloslancha/events{/privacy}","received_events_url":"https://api.github.com/users/carloslancha/received_events","type":"User","site_admin":false},"body":"Why can't we use just title as the ariaLabel?","created_at":"2018-11-13T09:36:15Z","updated_at":"2018-11-13T09:45:47Z","html_url":"https://github.com/liferay/clay/pull/1296#discussion_r232958835","pull_request_url":"https://api.github.com/repos/liferay/clay/pulls/1296","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/liferay/clay/pulls/comments/232958835"},"html":{"href":"https://github.com/liferay/clay/pull/1296#discussion_r232958835"},"pull_request":{"href":"https://api.github.com/repos/liferay/clay/pulls/1296"}}},"pull_request":{"url":"https://api.github.com/repos/liferay/clay/pulls/1296","id":229847635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODQ3NjM1","html_url":"https://github.com/liferay/clay/pull/1296","diff_url":"https://github.com/liferay/clay/pull/1296.diff","patch_url":"https://github.com/liferay/clay/pull/1296.patch","issue_url":"https://api.github.com/repos/liferay/clay/issues/1296","number":1296,"state":"open","locked":false,"title":"Fixes #1242 - Use aria-label to announce icon name instead of title","user":{"login":"pat270","id":788266,"node_id":"MDQ6VXNlcjc4ODI2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788266?v=4","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"body":"Wrapped SVG Icons with a `span` tag and aria attributes so screen readers can announce icon names without the use of the `title` element inside the SVG (title actually didn't work in MacOS VoiceOver). This prevents the default browser tooltip from displaying in https://issues.liferay.com/browse/LPS-81456 while satisfying https://issues.liferay.com/browse/LPS-68726 and https://issues.liferay.com/browse/LPS-86160.","created_at":"2018-11-09T23:30:31Z","updated_at":"2018-11-13T09:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7d3ffdf0670a969946dc7dc42560069dd0ba9ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/liferay/clay/pulls/1296/commits","review_comments_url":"https://api.github.com/repos/liferay/clay/pulls/1296/comments","review_comment_url":"https://api.github.com/repos/liferay/clay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liferay/clay/issues/1296/comments","statuses_url":"https://api.github.com/repos/liferay/clay/statuses/641878a25a064235ee4ac36d9fd0a5ad0e35ea02","head":{"label":"pat270:clay-1242","ref":"clay-1242","sha":"641878a25a064235ee4ac36d9fd0a5ad0e35ea02","user":{"login":"pat270","id":788266,"node_id":"MDQ6VXNlcjc4ODI2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788266?v=4","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"repo":{"id":22701174,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcwMTE3NA==","name":"lexicon","full_name":"pat270/lexicon","private":false,"owner":{"login":"pat270","id":788266,"node_id":"MDQ6VXNlcjc4ODI2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788266?v=4","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pat270/lexicon","description":null,"fork":true,"url":"https://api.github.com/repos/pat270/lexicon","forks_url":"https://api.github.com/repos/pat270/lexicon/forks","keys_url":"https://api.github.com/repos/pat270/lexicon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pat270/lexicon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pat270/lexicon/teams","hooks_url":"https://api.github.com/repos/pat270/lexicon/hooks","issue_events_url":"https://api.github.com/repos/pat270/lexicon/issues/events{/number}","events_url":"https://api.github.com/repos/pat270/lexicon/events","assignees_url":"https://api.github.com/repos/pat270/lexicon/assignees{/user}","branches_url":"https://api.github.com/repos/pat270/lexicon/branches{/branch}","tags_url":"https://api.github.com/repos/pat270/lexicon/tags","blobs_url":"https://api.github.com/repos/pat270/lexicon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pat270/lexicon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pat270/lexicon/git/refs{/sha}","trees_url":"https://api.github.com/repos/pat270/lexicon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pat270/lexicon/statuses/{sha}","languages_url":"https://api.github.com/repos/pat270/lexicon/languages","stargazers_url":"https://api.github.com/repos/pat270/lexicon/stargazers","contributors_url":"https://api.github.com/repos/pat270/lexicon/contributors","subscribers_url":"https://api.github.com/repos/pat270/lexicon/subscribers","subscription_url":"https://api.github.com/repos/pat270/lexicon/subscription","commits_url":"https://api.github.com/repos/pat270/lexicon/commits{/sha}","git_commits_url":"https://api.github.com/repos/pat270/lexicon/git/commits{/sha}","comments_url":"https://api.github.com/repos/pat270/lexicon/comments{/number}","issue_comment_url":"https://api.github.com/repos/pat270/lexicon/issues/comments{/number}","contents_url":"https://api.github.com/repos/pat270/lexicon/contents/{+path}","compare_url":"https://api.github.com/repos/pat270/lexicon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pat270/lexicon/merges","archive_url":"https://api.github.com/repos/pat270/lexicon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pat270/lexicon/downloads","issues_url":"https://api.github.com/repos/pat270/lexicon/issues{/number}","pulls_url":"https://api.github.com/repos/pat270/lexicon/pulls{/number}","milestones_url":"https://api.github.com/repos/pat270/lexicon/milestones{/number}","notifications_url":"https://api.github.com/repos/pat270/lexicon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pat270/lexicon/labels{/name}","releases_url":"https://api.github.com/repos/pat270/lexicon/releases{/id}","deployments_url":"https://api.github.com/repos/pat270/lexicon/deployments","created_at":"2014-08-06T23:07:43Z","updated_at":"2016-11-17T01:28:15Z","pushed_at":"2018-11-12T19:04:10Z","git_url":"git://github.com/pat270/lexicon.git","ssh_url":"git@github.com:pat270/lexicon.git","clone_url":"https://github.com/pat270/lexicon.git","svn_url":"https://github.com/pat270/lexicon","homepage":null,"size":95044,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"liferay:develop","ref":"develop","sha":"d23af2b85cfb2232adef51b71b1578bf881b2057","user":{"login":"liferay","id":131436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"repo":{"id":22377139,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM3NzEzOQ==","name":"clay","full_name":"liferay/clay","private":false,"owner":{"login":"liferay","id":131436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/liferay/clay","description":"A web implementation of the Lexicon Experience Language","fork":false,"url":"https://api.github.com/repos/liferay/clay","forks_url":"https://api.github.com/repos/liferay/clay/forks","keys_url":"https://api.github.com/repos/liferay/clay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liferay/clay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liferay/clay/teams","hooks_url":"https://api.github.com/repos/liferay/clay/hooks","issue_events_url":"https://api.github.com/repos/liferay/clay/issues/events{/number}","events_url":"https://api.github.com/repos/liferay/clay/events","assignees_url":"https://api.github.com/repos/liferay/clay/assignees{/user}","branches_url":"https://api.github.com/repos/liferay/clay/branches{/branch}","tags_url":"https://api.github.com/repos/liferay/clay/tags","blobs_url":"https://api.github.com/repos/liferay/clay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liferay/clay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liferay/clay/git/refs{/sha}","trees_url":"https://api.github.com/repos/liferay/clay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liferay/clay/statuses/{sha}","languages_url":"https://api.github.com/repos/liferay/clay/languages","stargazers_url":"https://api.github.com/repos/liferay/clay/stargazers","contributors_url":"https://api.github.com/repos/liferay/clay/contributors","subscribers_url":"https://api.github.com/repos/liferay/clay/subscribers","subscription_url":"https://api.github.com/repos/liferay/clay/subscription","commits_url":"https://api.github.com/repos/liferay/clay/commits{/sha}","git_commits_url":"https://api.github.com/repos/liferay/clay/git/commits{/sha}","comments_url":"https://api.github.com/repos/liferay/clay/comments{/number}","issue_comment_url":"https://api.github.com/repos/liferay/clay/issues/comments{/number}","contents_url":"https://api.github.com/repos/liferay/clay/contents/{+path}","compare_url":"https://api.github.com/repos/liferay/clay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liferay/clay/merges","archive_url":"https://api.github.com/repos/liferay/clay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liferay/clay/downloads","issues_url":"https://api.github.com/repos/liferay/clay/issues{/number}","pulls_url":"https://api.github.com/repos/liferay/clay/pulls{/number}","milestones_url":"https://api.github.com/repos/liferay/clay/milestones{/number}","notifications_url":"https://api.github.com/repos/liferay/clay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liferay/clay/labels{/name}","releases_url":"https://api.github.com/repos/liferay/clay/releases{/id}","deployments_url":"https://api.github.com/repos/liferay/clay/deployments","created_at":"2014-07-29T11:07:36Z","updated_at":"2018-10-31T09:10:10Z","pushed_at":"2018-11-13T09:38:26Z","git_url":"git://github.com/liferay/clay.git","ssh_url":"git@github.com:liferay/clay.git","clone_url":"https://github.com/liferay/clay.git","svn_url":"https://github.com/liferay/clay","homepage":"http://clayui.com","size":119991,"stargazers_count":83,"watchers_count":83,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":104,"license":null,"forks":107,"open_issues":104,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liferay/clay/pulls/1296"},"html":{"href":"https://github.com/liferay/clay/pull/1296"},"issue":{"href":"https://api.github.com/repos/liferay/clay/issues/1296"},"comments":{"href":"https://api.github.com/repos/liferay/clay/issues/1296/comments"},"review_comments":{"href":"https://api.github.com/repos/liferay/clay/pulls/1296/comments"},"review_comment":{"href":"https://api.github.com/repos/liferay/clay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liferay/clay/pulls/1296/commits"},"statuses":{"href":"https://api.github.com/repos/liferay/clay/statuses/641878a25a064235ee4ac36d9fd0a5ad0e35ea02"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"carloslancha"}}