{"action":"created","comment":{"url":"https://api.github.com/repos/ananthakumaran/tide/pulls/comments/196342449","pull_request_review_id":129873486,"id":196342449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjM0MjQ0OQ==","diff_hunk":"@@ -307,13 +316,20 @@ ones and overrule settings in the other lists.\"\n         (setq rtn (plist-put rtn p v))))\n     rtn))\n \n-(defun tide-get-file-buffer (file)\n+(defun tide-get-file-buffer (file &optional new-file)\n   \"Returns a buffer associated with a file. This will return the\n   current buffer if it matches `file'. This way we can support\n   temporary and indirect buffers.\"\n-  (if (equal file (tide-buffer-file-name))\n-      (current-buffer)\n-    (find-file-noselect file)))\n+  (cond\n+   ((equal file (tide-buffer-file-name)) (current-buffer))\n+   ((file-exists-p file) (find-file-noselect file))\n+   (new-file (let ((buffer (create-file-buffer file)))\n+               (with-current-buffer buffer\n+                 (set-visited-file-name file)\n+                 (basic-save-buffer)\n+                 (display-buffer buffer t))\n+               buffer))\n+   (t (error \"Invalid file %S\" file))))","path":"tide.el","position":37,"original_position":37,"commit_id":"84af28104755b5c0f5010c3d0cdf3761d66c1b44","original_commit_id":"84af28104755b5c0f5010c3d0cdf3761d66c1b44","user":{"login":"josteink","id":411338,"node_id":"MDQ6VXNlcjQxMTMzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/411338?v=4","gravatar_id":"","url":"https://api.github.com/users/josteink","html_url":"https://github.com/josteink","followers_url":"https://api.github.com/users/josteink/followers","following_url":"https://api.github.com/users/josteink/following{/other_user}","gists_url":"https://api.github.com/users/josteink/gists{/gist_id}","starred_url":"https://api.github.com/users/josteink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josteink/subscriptions","organizations_url":"https://api.github.com/users/josteink/orgs","repos_url":"https://api.github.com/users/josteink/repos","events_url":"https://api.github.com/users/josteink/events{/privacy}","received_events_url":"https://api.github.com/users/josteink/received_events","type":"User","site_admin":false},"body":"OK. Then I'm fine with this. 👍 ","created_at":"2018-06-19T08:51:08Z","updated_at":"2018-06-19T08:51:08Z","html_url":"https://github.com/ananthakumaran/tide/pull/262#discussion_r196342449","pull_request_url":"https://api.github.com/repos/ananthakumaran/tide/pulls/262","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/comments/196342449"},"html":{"href":"https://github.com/ananthakumaran/tide/pull/262#discussion_r196342449"},"pull_request":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/262"}},"in_reply_to_id":196329024},"pull_request":{"url":"https://api.github.com/repos/ananthakumaran/tide/pulls/262","id":193660676,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjYwNjc2","html_url":"https://github.com/ananthakumaran/tide/pull/262","diff_url":"https://github.com/ananthakumaran/tide/pull/262.diff","patch_url":"https://github.com/ananthakumaran/tide/pull/262.patch","issue_url":"https://api.github.com/repos/ananthakumaran/tide/issues/262","number":262,"state":"open","locked":false,"title":"support move-to-file refactor","user":{"login":"ananthakumaran","id":149238,"node_id":"MDQ6VXNlcjE0OTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/149238?v=4","gravatar_id":"","url":"https://api.github.com/users/ananthakumaran","html_url":"https://github.com/ananthakumaran","followers_url":"https://api.github.com/users/ananthakumaran/followers","following_url":"https://api.github.com/users/ananthakumaran/following{/other_user}","gists_url":"https://api.github.com/users/ananthakumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ananthakumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananthakumaran/subscriptions","organizations_url":"https://api.github.com/users/ananthakumaran/orgs","repos_url":"https://api.github.com/users/ananthakumaran/repos","events_url":"https://api.github.com/users/ananthakumaran/events{/privacy}","received_events_url":"https://api.github.com/users/ananthakumaran/received_events","type":"User","site_admin":false},"body":"This [refactor](https://code.visualstudio.com/updates/v1_24#_move-to-new-file-refactoring) is only enabled if `allowTextChangesInNewFiles` flag is\r\nset on the configure request. Handle code edits for non existent file.","created_at":"2018-06-08T16:11:51Z","updated_at":"2018-06-19T08:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e776215a2630670267f20a7164577909dc02305","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ananthakumaran/tide/pulls/262/commits","review_comments_url":"https://api.github.com/repos/ananthakumaran/tide/pulls/262/comments","review_comment_url":"https://api.github.com/repos/ananthakumaran/tide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ananthakumaran/tide/issues/262/comments","statuses_url":"https://api.github.com/repos/ananthakumaran/tide/statuses/84af28104755b5c0f5010c3d0cdf3761d66c1b44","head":{"label":"ananthakumaran:move-to-file-refactor","ref":"move-to-file-refactor","sha":"84af28104755b5c0f5010c3d0cdf3761d66c1b44","user":{"login":"ananthakumaran","id":149238,"node_id":"MDQ6VXNlcjE0OTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/149238?v=4","gravatar_id":"","url":"https://api.github.com/users/ananthakumaran","html_url":"https://github.com/ananthakumaran","followers_url":"https://api.github.com/users/ananthakumaran/followers","following_url":"https://api.github.com/users/ananthakumaran/following{/other_user}","gists_url":"https://api.github.com/users/ananthakumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ananthakumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananthakumaran/subscriptions","organizations_url":"https://api.github.com/users/ananthakumaran/orgs","repos_url":"https://api.github.com/users/ananthakumaran/repos","events_url":"https://api.github.com/users/ananthakumaran/events{/privacy}","received_events_url":"https://api.github.com/users/ananthakumaran/received_events","type":"User","site_admin":false},"repo":{"id":35371728,"node_id":"MDEwOlJlcG9zaXRvcnkzNTM3MTcyOA==","name":"tide","full_name":"ananthakumaran/tide","owner":{"login":"ananthakumaran","id":149238,"node_id":"MDQ6VXNlcjE0OTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/149238?v=4","gravatar_id":"","url":"https://api.github.com/users/ananthakumaran","html_url":"https://github.com/ananthakumaran","followers_url":"https://api.github.com/users/ananthakumaran/followers","following_url":"https://api.github.com/users/ananthakumaran/following{/other_user}","gists_url":"https://api.github.com/users/ananthakumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ananthakumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananthakumaran/subscriptions","organizations_url":"https://api.github.com/users/ananthakumaran/orgs","repos_url":"https://api.github.com/users/ananthakumaran/repos","events_url":"https://api.github.com/users/ananthakumaran/events{/privacy}","received_events_url":"https://api.github.com/users/ananthakumaran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ananthakumaran/tide","description":"Tide - TypeScript Interactive Development Environment for Emacs","fork":false,"url":"https://api.github.com/repos/ananthakumaran/tide","forks_url":"https://api.github.com/repos/ananthakumaran/tide/forks","keys_url":"https://api.github.com/repos/ananthakumaran/tide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ananthakumaran/tide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ananthakumaran/tide/teams","hooks_url":"https://api.github.com/repos/ananthakumaran/tide/hooks","issue_events_url":"https://api.github.com/repos/ananthakumaran/tide/issues/events{/number}","events_url":"https://api.github.com/repos/ananthakumaran/tide/events","assignees_url":"https://api.github.com/repos/ananthakumaran/tide/assignees{/user}","branches_url":"https://api.github.com/repos/ananthakumaran/tide/branches{/branch}","tags_url":"https://api.github.com/repos/ananthakumaran/tide/tags","blobs_url":"https://api.github.com/repos/ananthakumaran/tide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ananthakumaran/tide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ananthakumaran/tide/git/refs{/sha}","trees_url":"https://api.github.com/repos/ananthakumaran/tide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ananthakumaran/tide/statuses/{sha}","languages_url":"https://api.github.com/repos/ananthakumaran/tide/languages","stargazers_url":"https://api.github.com/repos/ananthakumaran/tide/stargazers","contributors_url":"https://api.github.com/repos/ananthakumaran/tide/contributors","subscribers_url":"https://api.github.com/repos/ananthakumaran/tide/subscribers","subscription_url":"https://api.github.com/repos/ananthakumaran/tide/subscription","commits_url":"https://api.github.com/repos/ananthakumaran/tide/commits{/sha}","git_commits_url":"https://api.github.com/repos/ananthakumaran/tide/git/commits{/sha}","comments_url":"https://api.github.com/repos/ananthakumaran/tide/comments{/number}","issue_comment_url":"https://api.github.com/repos/ananthakumaran/tide/issues/comments{/number}","contents_url":"https://api.github.com/repos/ananthakumaran/tide/contents/{+path}","compare_url":"https://api.github.com/repos/ananthakumaran/tide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ananthakumaran/tide/merges","archive_url":"https://api.github.com/repos/ananthakumaran/tide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ananthakumaran/tide/downloads","issues_url":"https://api.github.com/repos/ananthakumaran/tide/issues{/number}","pulls_url":"https://api.github.com/repos/ananthakumaran/tide/pulls{/number}","milestones_url":"https://api.github.com/repos/ananthakumaran/tide/milestones{/number}","notifications_url":"https://api.github.com/repos/ananthakumaran/tide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ananthakumaran/tide/labels{/name}","releases_url":"https://api.github.com/repos/ananthakumaran/tide/releases{/id}","deployments_url":"https://api.github.com/repos/ananthakumaran/tide/deployments","created_at":"2015-05-10T13:18:18Z","updated_at":"2018-06-19T00:40:57Z","pushed_at":"2018-06-10T05:42:21Z","git_url":"git://github.com/ananthakumaran/tide.git","ssh_url":"git@github.com:ananthakumaran/tide.git","clone_url":"https://github.com/ananthakumaran/tide.git","svn_url":"https://github.com/ananthakumaran/tide","homepage":"","size":15094,"stargazers_count":581,"watchers_count":581,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":58,"open_issues":20,"watchers":581,"default_branch":"master"}},"base":{"label":"ananthakumaran:master","ref":"master","sha":"9203c7d98a8676a8ee35d71d9f42e15a9d9293d9","user":{"login":"ananthakumaran","id":149238,"node_id":"MDQ6VXNlcjE0OTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/149238?v=4","gravatar_id":"","url":"https://api.github.com/users/ananthakumaran","html_url":"https://github.com/ananthakumaran","followers_url":"https://api.github.com/users/ananthakumaran/followers","following_url":"https://api.github.com/users/ananthakumaran/following{/other_user}","gists_url":"https://api.github.com/users/ananthakumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ananthakumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananthakumaran/subscriptions","organizations_url":"https://api.github.com/users/ananthakumaran/orgs","repos_url":"https://api.github.com/users/ananthakumaran/repos","events_url":"https://api.github.com/users/ananthakumaran/events{/privacy}","received_events_url":"https://api.github.com/users/ananthakumaran/received_events","type":"User","site_admin":false},"repo":{"id":35371728,"node_id":"MDEwOlJlcG9zaXRvcnkzNTM3MTcyOA==","name":"tide","full_name":"ananthakumaran/tide","owner":{"login":"ananthakumaran","id":149238,"node_id":"MDQ6VXNlcjE0OTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/149238?v=4","gravatar_id":"","url":"https://api.github.com/users/ananthakumaran","html_url":"https://github.com/ananthakumaran","followers_url":"https://api.github.com/users/ananthakumaran/followers","following_url":"https://api.github.com/users/ananthakumaran/following{/other_user}","gists_url":"https://api.github.com/users/ananthakumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ananthakumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananthakumaran/subscriptions","organizations_url":"https://api.github.com/users/ananthakumaran/orgs","repos_url":"https://api.github.com/users/ananthakumaran/repos","events_url":"https://api.github.com/users/ananthakumaran/events{/privacy}","received_events_url":"https://api.github.com/users/ananthakumaran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ananthakumaran/tide","description":"Tide - TypeScript Interactive Development Environment for Emacs","fork":false,"url":"https://api.github.com/repos/ananthakumaran/tide","forks_url":"https://api.github.com/repos/ananthakumaran/tide/forks","keys_url":"https://api.github.com/repos/ananthakumaran/tide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ananthakumaran/tide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ananthakumaran/tide/teams","hooks_url":"https://api.github.com/repos/ananthakumaran/tide/hooks","issue_events_url":"https://api.github.com/repos/ananthakumaran/tide/issues/events{/number}","events_url":"https://api.github.com/repos/ananthakumaran/tide/events","assignees_url":"https://api.github.com/repos/ananthakumaran/tide/assignees{/user}","branches_url":"https://api.github.com/repos/ananthakumaran/tide/branches{/branch}","tags_url":"https://api.github.com/repos/ananthakumaran/tide/tags","blobs_url":"https://api.github.com/repos/ananthakumaran/tide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ananthakumaran/tide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ananthakumaran/tide/git/refs{/sha}","trees_url":"https://api.github.com/repos/ananthakumaran/tide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ananthakumaran/tide/statuses/{sha}","languages_url":"https://api.github.com/repos/ananthakumaran/tide/languages","stargazers_url":"https://api.github.com/repos/ananthakumaran/tide/stargazers","contributors_url":"https://api.github.com/repos/ananthakumaran/tide/contributors","subscribers_url":"https://api.github.com/repos/ananthakumaran/tide/subscribers","subscription_url":"https://api.github.com/repos/ananthakumaran/tide/subscription","commits_url":"https://api.github.com/repos/ananthakumaran/tide/commits{/sha}","git_commits_url":"https://api.github.com/repos/ananthakumaran/tide/git/commits{/sha}","comments_url":"https://api.github.com/repos/ananthakumaran/tide/comments{/number}","issue_comment_url":"https://api.github.com/repos/ananthakumaran/tide/issues/comments{/number}","contents_url":"https://api.github.com/repos/ananthakumaran/tide/contents/{+path}","compare_url":"https://api.github.com/repos/ananthakumaran/tide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ananthakumaran/tide/merges","archive_url":"https://api.github.com/repos/ananthakumaran/tide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ananthakumaran/tide/downloads","issues_url":"https://api.github.com/repos/ananthakumaran/tide/issues{/number}","pulls_url":"https://api.github.com/repos/ananthakumaran/tide/pulls{/number}","milestones_url":"https://api.github.com/repos/ananthakumaran/tide/milestones{/number}","notifications_url":"https://api.github.com/repos/ananthakumaran/tide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ananthakumaran/tide/labels{/name}","releases_url":"https://api.github.com/repos/ananthakumaran/tide/releases{/id}","deployments_url":"https://api.github.com/repos/ananthakumaran/tide/deployments","created_at":"2015-05-10T13:18:18Z","updated_at":"2018-06-19T00:40:57Z","pushed_at":"2018-06-10T05:42:21Z","git_url":"git://github.com/ananthakumaran/tide.git","ssh_url":"git@github.com:ananthakumaran/tide.git","clone_url":"https://github.com/ananthakumaran/tide.git","svn_url":"https://github.com/ananthakumaran/tide","homepage":"","size":15094,"stargazers_count":581,"watchers_count":581,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":58,"open_issues":20,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/262"},"html":{"href":"https://github.com/ananthakumaran/tide/pull/262"},"issue":{"href":"https://api.github.com/repos/ananthakumaran/tide/issues/262"},"comments":{"href":"https://api.github.com/repos/ananthakumaran/tide/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ananthakumaran/tide/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/ananthakumaran/tide/statuses/84af28104755b5c0f5010c3d0cdf3761d66c1b44"}},"author_association":"OWNER"}}
{"actor":{"display_login":"josteink"}}