{"action":"created","issue":{"url":"https://api.github.com/repos/w0rp/ale/issues/1769","repository_url":"https://api.github.com/repos/w0rp/ale","labels_url":"https://api.github.com/repos/w0rp/ale/issues/1769/labels{/name}","comments_url":"https://api.github.com/repos/w0rp/ale/issues/1769/comments","events_url":"https://api.github.com/repos/w0rp/ale/issues/1769/events","html_url":"https://github.com/w0rp/ale/pull/1769","id":346322962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjE0ODY5","number":1769,"title":"Javascript prettier filetype detect fix","user":{"login":"paulreimer","id":2677,"node_id":"MDQ6VXNlcjI2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2677?v=4","gravatar_id":"","url":"https://api.github.com/users/paulreimer","html_url":"https://github.com/paulreimer","followers_url":"https://api.github.com/users/paulreimer/followers","following_url":"https://api.github.com/users/paulreimer/following{/other_user}","gists_url":"https://api.github.com/users/paulreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/paulreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulreimer/subscriptions","organizations_url":"https://api.github.com/users/paulreimer/orgs","repos_url":"https://api.github.com/users/paulreimer/repos","events_url":"https://api.github.com/users/paulreimer/events{/privacy}","received_events_url":"https://api.github.com/users/paulreimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-31T19:17:26Z","updated_at":"2018-07-31T20:27:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/w0rp/ale/pulls/1769","html_url":"https://github.com/w0rp/ale/pull/1769","diff_url":"https://github.com/w0rp/ale/pull/1769.diff","patch_url":"https://github.com/w0rp/ale/pull/1769.patch"},"body":"Noticed that javascript `prettier` fixer had some filetype->parser detection support, but I believe there was a bug in the logic in filetype detection, preventing it from being used (301e85f).\r\n\r\nAs well, it is simply good luck that the name of the parsers available in `prettier` match the vim filetype string, so that was converted to a dictionary to handle the case where they are different (9b11c84).\r\n\r\nFinally, `prettier` does support additional filetypes/parsers not yet added, so I added yaml in (41da5e4), and the experimental html parser support which is coming soon (!) in (9838e45). The name of that parser is `parse5`, thus it is the first case where the filetype will not match the parsing string, motivating the dictionary approach above."},"comment":{"url":"https://api.github.com/repos/w0rp/ale/issues/comments/409356704","html_url":"https://github.com/w0rp/ale/pull/1769#issuecomment-409356704","issue_url":"https://api.github.com/repos/w0rp/ale/issues/1769","id":409356704,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTM1NjcwNA==","user":{"login":"w0rp","id":3518142,"node_id":"MDQ6VXNlcjM1MTgxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T20:27:56Z","updated_at":"2018-07-31T20:27:56Z","author_association":"OWNER","body":"Put the code for only setting `--parser` if the file extension is set back in. The `--parser` option is there as a fallback option. Prettier will automatically detect which parser to use, but it can't do that when the file doesn't have an extension. When Vim knows what the filetype is, it can figure out which parser to use."}}
{"actor":{"display_login":"w0rp"}}