{"action":"created","issue":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/571","repository_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/571/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/571/comments","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/571/events","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/571","id":386378869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTM3ODcw","number":571,"title":"Always close HTTP responses in HttpSender","user":{"login":"mpetazzoni","id":879507,"node_id":"MDQ6VXNlcjg3OTUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/879507?v=4","gravatar_id":"","url":"https://api.github.com/users/mpetazzoni","html_url":"https://github.com/mpetazzoni","followers_url":"https://api.github.com/users/mpetazzoni/followers","following_url":"https://api.github.com/users/mpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/mpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/mpetazzoni/orgs","repos_url":"https://api.github.com/users/mpetazzoni/repos","events_url":"https://api.github.com/users/mpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/mpetazzoni/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-30T22:47:30Z","updated_at":"2018-12-14T14:32:26Z","closed_at":"2018-12-03T17:03:22Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/571","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/571","diff_url":"https://github.com/jaegertracing/jaeger-client-java/pull/571.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-java/pull/571.patch"},"body":"The Response object wasn't closed when the response is successful,\r\nleading to connection leaks. This was revealed by seeing messages like\r\nthis in logs:\r\n\r\n```\r\nWARNING: A connection to https://<redacted>/ was leaked. Did you forget to close a response body?\r\n```\r\n\r\nSigned-off-by: Maxime Petazzoni <max@signalfx.com>\r\n\r\n<!--\r\nWe appreciate your contribution to the Jaeger project! 👋🎉\r\n\r\nBefore creating a pull request, please make sure:\r\n- Your PR is solving one problem\r\n- You have read the guide for contributing\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md\r\n- You signed all your commits (otherwise we won't be able to merge the PR)\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#sign-your-work\r\n- You added unit tests for the new functionality\r\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\r\n-->\r\n\r\n## Which problem is this PR solving?\r\n- OkHttp3 reports connection leaks\r\n\r\n## Short description of the changes\r\n- This change makes sure that the Response object is always closed, even when the response is successful.\r\n"},"comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/comments/447342399","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/571#issuecomment-447342399","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/571","id":447342399,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzM0MjM5OQ==","user":{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T14:32:26Z","updated_at":"2018-12-14T14:32:26Z","author_association":"COLLABORATOR","body":"@mpetazzoni @jpkrohling I've started the process in #575 - just waiting for @pavolloffay (at kubecon) or another @jaegertracing/jaeger-maintainers to approve."}}
{"actor":{"display_login":"objectiser"}}