{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/235092849","pull_request_review_id":176840473,"id":235092849,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTA5Mjg0OQ==","diff_hunk":"@@ -2318,8 +2369,10 @@ class LorisFormFileElement extends LorisFormElement\n      *\n      * @return void\n      */\n-    function moveUploadedFile($destinationDir, $destinationFileName)\n-    {\n+    function moveUploadedFile(\n+        string $destinationDir,\n+        string $destinationFileName\n+    ): void {","path":"php/libraries/LorisForm.class.inc","position":772,"original_position":772,"commit_id":"e549cd6493c6e326d86f05b1b294697d5f593e54","original_commit_id":"e549cd6493c6e326d86f05b1b294697d5f593e54","user":{"login":"PapillonMcGill","id":34311645,"node_id":"MDQ6VXNlcjM0MzExNjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/34311645?v=4","gravatar_id":"","url":"https://api.github.com/users/PapillonMcGill","html_url":"https://github.com/PapillonMcGill","followers_url":"https://api.github.com/users/PapillonMcGill/followers","following_url":"https://api.github.com/users/PapillonMcGill/following{/other_user}","gists_url":"https://api.github.com/users/PapillonMcGill/gists{/gist_id}","starred_url":"https://api.github.com/users/PapillonMcGill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PapillonMcGill/subscriptions","organizations_url":"https://api.github.com/users/PapillonMcGill/orgs","repos_url":"https://api.github.com/users/PapillonMcGill/repos","events_url":"https://api.github.com/users/PapillonMcGill/events{/privacy}","received_events_url":"https://api.github.com/users/PapillonMcGill/received_events","type":"User","site_admin":false},"body":"skipped getValue() on line 2389","created_at":"2018-11-20T17:12:36Z","updated_at":"2018-11-20T17:13:00Z","html_url":"https://github.com/aces/Loris/pull/4122#discussion_r235092849","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/4122","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/235092849"},"html":{"href":"https://github.com/aces/Loris/pull/4122#discussion_r235092849"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/4122"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/4122","id":232101793,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTAxNzkz","html_url":"https://github.com/aces/Loris/pull/4122","diff_url":"https://github.com/aces/Loris/pull/4122.diff","patch_url":"https://github.com/aces/Loris/pull/4122.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/4122","number":4122,"state":"open","locked":false,"title":"[Core: LorisForm] Add type declarations to function signatures","user":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"body":"See #3878 for background.","created_at":"2018-11-19T20:27:11Z","updated_at":"2018-11-20T17:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4db4a32be863d13c933758085ba37d94b39967d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152314516,"node_id":"MDU6TGFiZWwxNTIzMTQ1MTY=","url":"https://api.github.com/repos/aces/Loris/labels/Cleanup","name":"Cleanup","color":"006b75","default":false},{"id":708896092,"node_id":"MDU6TGFiZWw3MDg4OTYwOTI=","url":"https://api.github.com/repos/aces/Loris/labels/[branch]%20major","name":"[branch] major","color":"4d3319","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aces/Loris/pulls/4122/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/4122/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/4122/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/e549cd6493c6e326d86f05b1b294697d5f593e54","head":{"label":"johnsaigle:181119-TypesInLorisForm","ref":"181119-TypesInLorisForm","sha":"e549cd6493c6e326d86f05b1b294697d5f593e54","user":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"repo":{"id":49739900,"node_id":"MDEwOlJlcG9zaXRvcnk0OTczOTkwMA==","name":"Loris","full_name":"johnsaigle/Loris","private":false,"owner":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnsaigle/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/johnsaigle/Loris","forks_url":"https://api.github.com/repos/johnsaigle/Loris/forks","keys_url":"https://api.github.com/repos/johnsaigle/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnsaigle/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnsaigle/Loris/teams","hooks_url":"https://api.github.com/repos/johnsaigle/Loris/hooks","issue_events_url":"https://api.github.com/repos/johnsaigle/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/johnsaigle/Loris/events","assignees_url":"https://api.github.com/repos/johnsaigle/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/johnsaigle/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/johnsaigle/Loris/tags","blobs_url":"https://api.github.com/repos/johnsaigle/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnsaigle/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnsaigle/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnsaigle/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnsaigle/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/johnsaigle/Loris/languages","stargazers_url":"https://api.github.com/repos/johnsaigle/Loris/stargazers","contributors_url":"https://api.github.com/repos/johnsaigle/Loris/contributors","subscribers_url":"https://api.github.com/repos/johnsaigle/Loris/subscribers","subscription_url":"https://api.github.com/repos/johnsaigle/Loris/subscription","commits_url":"https://api.github.com/repos/johnsaigle/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnsaigle/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnsaigle/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnsaigle/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnsaigle/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/johnsaigle/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnsaigle/Loris/merges","archive_url":"https://api.github.com/repos/johnsaigle/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnsaigle/Loris/downloads","issues_url":"https://api.github.com/repos/johnsaigle/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/johnsaigle/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/johnsaigle/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/johnsaigle/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnsaigle/Loris/labels{/name}","releases_url":"https://api.github.com/repos/johnsaigle/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/johnsaigle/Loris/deployments","created_at":"2016-01-15T19:21:06Z","updated_at":"2018-08-13T16:21:32Z","pushed_at":"2018-11-20T16:51:57Z","git_url":"git://github.com/johnsaigle/Loris.git","ssh_url":"git@github.com:johnsaigle/Loris.git","clone_url":"https://github.com/johnsaigle/Loris.git","svn_url":"https://github.com/johnsaigle/Loris","homepage":"","size":77662,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"20.0-release"}},"base":{"label":"aces:major","ref":"major","sha":"ddd94707540ffbd2150a38ade605f3fe9aa77485","user":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1NjMw","name":"Loris","full_name":"aces/Loris","private":false,"owner":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2018-11-19T14:59:49Z","pushed_at":"2018-11-20T16:51:59Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":77331,"stargazers_count":68,"watchers_count":68,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":100,"open_issues":132,"watchers":68,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/4122"},"html":{"href":"https://github.com/aces/Loris/pull/4122"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/4122"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/4122/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/4122/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/4122/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/e549cd6493c6e326d86f05b1b294697d5f593e54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PapillonMcGill"}}