{"action":"created","comment":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/comments/232337918","pull_request_review_id":173520209,"id":232337918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMzNzkxOA==","diff_hunk":"@@ -145,7 +143,7 @@ export function generateAuthSalt(): Uint8Array {\n  * Hashes auth public key. Uses personalized hash.\n  * @returns 32 bytes personalized hash\n  */\n-export function getAuthKeyHash(key): Uint8Array {\n+export function getAuthKeyHash(key: ByteArray): Uint8Array {","path":"src/crypto/keys.ts","position":29,"original_position":29,"commit_id":"b3a7fd1d17dd59df90b6cb6a71744a8084c9212a","original_commit_id":"b3a7fd1d17dd59df90b6cb6a71744a8084c9212a","user":{"login":"anri-asaturov","id":1479005,"node_id":"MDQ6VXNlcjE0NzkwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1479005?v=4","gravatar_id":"","url":"https://api.github.com/users/anri-asaturov","html_url":"https://github.com/anri-asaturov","followers_url":"https://api.github.com/users/anri-asaturov/followers","following_url":"https://api.github.com/users/anri-asaturov/following{/other_user}","gists_url":"https://api.github.com/users/anri-asaturov/gists{/gist_id}","starred_url":"https://api.github.com/users/anri-asaturov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anri-asaturov/subscriptions","organizations_url":"https://api.github.com/users/anri-asaturov/orgs","repos_url":"https://api.github.com/users/anri-asaturov/repos","events_url":"https://api.github.com/users/anri-asaturov/events{/privacy}","received_events_url":"https://api.github.com/users/anri-asaturov/received_events","type":"User","site_admin":false},"body":"`getAuthKeyHash` is actually called with Uint8Array argument, not sure why blake2s-js defines its own ByteArray","created_at":"2018-11-09T17:49:23Z","updated_at":"2018-11-09T17:49:23Z","html_url":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354#discussion_r232337918","pull_request_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/comments/232337918"},"html":{"href":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354#discussion_r232337918"},"pull_request":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354","id":229766010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzY2MDEw","html_url":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354","diff_url":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354.diff","patch_url":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354.patch","issue_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/354","number":354,"state":"open","locked":false,"title":"chore: small type fixes from quick audit","user":{"login":"lostfictions","id":567041,"node_id":"MDQ6VXNlcjU2NzA0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/567041?v=4","gravatar_id":"","url":"https://api.github.com/users/lostfictions","html_url":"https://github.com/lostfictions","followers_url":"https://api.github.com/users/lostfictions/followers","following_url":"https://api.github.com/users/lostfictions/following{/other_user}","gists_url":"https://api.github.com/users/lostfictions/gists{/gist_id}","starred_url":"https://api.github.com/users/lostfictions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostfictions/subscriptions","organizations_url":"https://api.github.com/users/lostfictions/orgs","repos_url":"https://api.github.com/users/lostfictions/repos","events_url":"https://api.github.com/users/lostfictions/events{/privacy}","received_events_url":"https://api.github.com/users/lostfictions/received_events","type":"User","site_admin":false},"body":"#### Relevant info and issue/PR links \r\n \r\n#### Testing instructions  \r\n\r\n\r\n----\r\n### Repository owner\r\n\r\n- [ ] Was tested and can be merged.\r\n- [ ] PR name follows conventional changelog format.\r\n\r\n[PR guideline](https://github.com/PeerioTechnologies/peerio-icebear/blob/dev/docs/CONTRIBUTING.md)\r\n","created_at":"2018-11-09T17:30:53Z","updated_at":"2018-11-09T17:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"275effdc34e92e12672c350bb1e0cb4b8ba2fc19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354/commits","review_comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354/comments","review_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/354/comments","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/statuses/b3a7fd1d17dd59df90b6cb6a71744a8084c9212a","head":{"label":"PeerioTechnologies:quick-type-fixes","ref":"quick-type-fixes","sha":"b3a7fd1d17dd59df90b6cb6a71744a8084c9212a","user":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":63130290,"node_id":"MDEwOlJlcG9zaXRvcnk2MzEzMDI5MA==","name":"peerio-icebear","full_name":"PeerioTechnologies/peerio-icebear","private":false,"owner":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PeerioTechnologies/peerio-icebear","description":"Peerio Icebear SDK is a client library supporting Peerio apps","fork":false,"url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear","forks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/forks","keys_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/teams","hooks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/hooks","issue_events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/events{/number}","events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/events","assignees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/assignees{/user}","branches_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/branches{/branch}","tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/tags","blobs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/statuses/{sha}","languages_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/languages","stargazers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/stargazers","contributors_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/contributors","subscribers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/subscribers","subscription_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/subscription","commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/contents/{+path}","compare_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/merges","archive_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/downloads","issues_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues{/number}","pulls_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls{/number}","milestones_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/milestones{/number}","notifications_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/labels{/name}","releases_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/releases{/id}","deployments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/deployments","created_at":"2016-07-12T05:52:13Z","updated_at":"2018-11-09T16:57:23Z","pushed_at":"2018-11-09T17:31:54Z","git_url":"git://github.com/PeerioTechnologies/peerio-icebear.git","ssh_url":"git@github.com:PeerioTechnologies/peerio-icebear.git","clone_url":"https://github.com/PeerioTechnologies/peerio-icebear.git","svn_url":"https://github.com/PeerioTechnologies/peerio-icebear","homepage":"https://peerio.com","size":18454,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":4,"watchers":3,"default_branch":"dev"}},"base":{"label":"PeerioTechnologies:dev","ref":"dev","sha":"9fb9c410bb932370c6e76c060e815c7393af5e9e","user":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":63130290,"node_id":"MDEwOlJlcG9zaXRvcnk2MzEzMDI5MA==","name":"peerio-icebear","full_name":"PeerioTechnologies/peerio-icebear","private":false,"owner":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PeerioTechnologies/peerio-icebear","description":"Peerio Icebear SDK is a client library supporting Peerio apps","fork":false,"url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear","forks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/forks","keys_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/teams","hooks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/hooks","issue_events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/events{/number}","events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/events","assignees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/assignees{/user}","branches_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/branches{/branch}","tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/tags","blobs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/statuses/{sha}","languages_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/languages","stargazers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/stargazers","contributors_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/contributors","subscribers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/subscribers","subscription_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/subscription","commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/contents/{+path}","compare_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/merges","archive_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/downloads","issues_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues{/number}","pulls_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls{/number}","milestones_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/milestones{/number}","notifications_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/labels{/name}","releases_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/releases{/id}","deployments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/deployments","created_at":"2016-07-12T05:52:13Z","updated_at":"2018-11-09T16:57:23Z","pushed_at":"2018-11-09T17:31:54Z","git_url":"git://github.com/PeerioTechnologies/peerio-icebear.git","ssh_url":"git@github.com:PeerioTechnologies/peerio-icebear.git","clone_url":"https://github.com/PeerioTechnologies/peerio-icebear.git","svn_url":"https://github.com/PeerioTechnologies/peerio-icebear","homepage":"https://peerio.com","size":18454,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":4,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354"},"html":{"href":"https://github.com/PeerioTechnologies/peerio-icebear/pull/354"},"issue":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/354"},"comments":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-icebear/statuses/b3a7fd1d17dd59df90b6cb6a71744a8084c9212a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anri-asaturov"}}