{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/205594836","pull_request_review_id":140899640,"id":205594836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTU5NDgzNg==","diff_hunk":"@@ -59,7 +59,7 @@ void RecordingScriptingInterface::playClip(NetworkClipLoaderPointer clipLoader,\n \n     if (callback.isFunction()) {\n         QScriptValueList args { true, url };\n-        callback.call(_scriptEngine->globalObject(), args);\n+        callback.call(QScriptValue(), args);","path":"libraries/script-engine/src/RecordingScriptingInterface.cpp","position":5,"original_position":5,"commit_id":"b750a005cf8b5a2da6a829c6d27a7f9e83ee3fd9","original_commit_id":"b750a005cf8b5a2da6a829c6d27a7f9e83ee3fd9","user":{"login":"huffman","id":167747,"node_id":"MDQ6VXNlcjE2Nzc0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/167747?v=4","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"I stand corrected, the docs actually say if the argument is not an object, it will use the global object. So this should have the same behavior as before.","created_at":"2018-07-26T20:38:34Z","updated_at":"2018-07-26T20:38:35Z","html_url":"https://github.com/highfidelity/hifi/pull/13687#discussion_r205594836","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13687","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/205594836"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13687#discussion_r205594836"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13687"}},"in_reply_to_id":204954029},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13687","id":203683206,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjgzMjA2","html_url":"https://github.com/highfidelity/hifi/pull/13687","diff_url":"https://github.com/highfidelity/hifi/pull/13687.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13687.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13687","number":13687,"state":"open","locked":false,"title":"Fix ScriptEngine begin held onto after script stopped runnning","user":{"login":"danteruiz","id":9288551,"node_id":"MDQ6VXNlcjkyODg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9288551?v=4","gravatar_id":"","url":"https://api.github.com/users/danteruiz","html_url":"https://github.com/danteruiz","followers_url":"https://api.github.com/users/danteruiz/followers","following_url":"https://api.github.com/users/danteruiz/following{/other_user}","gists_url":"https://api.github.com/users/danteruiz/gists{/gist_id}","starred_url":"https://api.github.com/users/danteruiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danteruiz/subscriptions","organizations_url":"https://api.github.com/users/danteruiz/orgs","repos_url":"https://api.github.com/users/danteruiz/repos","events_url":"https://api.github.com/users/danteruiz/events{/privacy}","received_events_url":"https://api.github.com/users/danteruiz/received_events","type":"User","site_admin":false},"body":"Fixed the issue of the ScriptEngine not being released when stopping a script because the RecordingScriptingInterface still had a reference to the shared pointer.\r\n\r\nticket - https://highfidelity.fogbugz.com/f/cases/15944/Script-memory-sometimes-not-immediately-released-when-script-stopped","created_at":"2018-07-24T23:35:03Z","updated_at":"2018-07-26T20:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8c3b831ad11c06e7348972b6427696f0c0718d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":743411186,"node_id":"MDU6TGFiZWw3NDM0MTExODY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/31","html_url":"https://github.com/highfidelity/hifi/milestone/31","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/31/labels","id":3290830,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzMA==","number":31,"title":"RC71","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":69,"state":"open","created_at":"2018-04-23T19:27:05Z","updated_at":"2018-07-26T18:51:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13687/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13687/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13687/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/b750a005cf8b5a2da6a829c6d27a7f9e83ee3fd9","head":{"label":"danteruiz:fix-script-memory-issue","ref":"fix-script-memory-issue","sha":"b750a005cf8b5a2da6a829c6d27a7f9e83ee3fd9","user":{"login":"danteruiz","id":9288551,"node_id":"MDQ6VXNlcjkyODg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9288551?v=4","gravatar_id":"","url":"https://api.github.com/users/danteruiz","html_url":"https://github.com/danteruiz","followers_url":"https://api.github.com/users/danteruiz/followers","following_url":"https://api.github.com/users/danteruiz/following{/other_user}","gists_url":"https://api.github.com/users/danteruiz/gists{/gist_id}","starred_url":"https://api.github.com/users/danteruiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danteruiz/subscriptions","organizations_url":"https://api.github.com/users/danteruiz/orgs","repos_url":"https://api.github.com/users/danteruiz/repos","events_url":"https://api.github.com/users/danteruiz/events{/privacy}","received_events_url":"https://api.github.com/users/danteruiz/received_events","type":"User","site_admin":false},"repo":{"id":72025746,"node_id":"MDEwOlJlcG9zaXRvcnk3MjAyNTc0Ng==","name":"hifi","full_name":"danteruiz/hifi","owner":{"login":"danteruiz","id":9288551,"node_id":"MDQ6VXNlcjkyODg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9288551?v=4","gravatar_id":"","url":"https://api.github.com/users/danteruiz","html_url":"https://github.com/danteruiz","followers_url":"https://api.github.com/users/danteruiz/followers","following_url":"https://api.github.com/users/danteruiz/following{/other_user}","gists_url":"https://api.github.com/users/danteruiz/gists{/gist_id}","starred_url":"https://api.github.com/users/danteruiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danteruiz/subscriptions","organizations_url":"https://api.github.com/users/danteruiz/orgs","repos_url":"https://api.github.com/users/danteruiz/repos","events_url":"https://api.github.com/users/danteruiz/events{/privacy}","received_events_url":"https://api.github.com/users/danteruiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danteruiz/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/danteruiz/hifi","forks_url":"https://api.github.com/repos/danteruiz/hifi/forks","keys_url":"https://api.github.com/repos/danteruiz/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danteruiz/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danteruiz/hifi/teams","hooks_url":"https://api.github.com/repos/danteruiz/hifi/hooks","issue_events_url":"https://api.github.com/repos/danteruiz/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/danteruiz/hifi/events","assignees_url":"https://api.github.com/repos/danteruiz/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/danteruiz/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/danteruiz/hifi/tags","blobs_url":"https://api.github.com/repos/danteruiz/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danteruiz/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danteruiz/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/danteruiz/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danteruiz/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/danteruiz/hifi/languages","stargazers_url":"https://api.github.com/repos/danteruiz/hifi/stargazers","contributors_url":"https://api.github.com/repos/danteruiz/hifi/contributors","subscribers_url":"https://api.github.com/repos/danteruiz/hifi/subscribers","subscription_url":"https://api.github.com/repos/danteruiz/hifi/subscription","commits_url":"https://api.github.com/repos/danteruiz/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/danteruiz/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/danteruiz/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/danteruiz/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/danteruiz/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/danteruiz/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danteruiz/hifi/merges","archive_url":"https://api.github.com/repos/danteruiz/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danteruiz/hifi/downloads","issues_url":"https://api.github.com/repos/danteruiz/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/danteruiz/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/danteruiz/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/danteruiz/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danteruiz/hifi/labels{/name}","releases_url":"https://api.github.com/repos/danteruiz/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/danteruiz/hifi/deployments","created_at":"2016-10-26T17:09:55Z","updated_at":"2018-05-02T21:24:56Z","pushed_at":"2018-07-25T15:44:48Z","git_url":"git://github.com/danteruiz/hifi.git","ssh_url":"git@github.com:danteruiz/hifi.git","clone_url":"https://github.com/danteruiz/hifi.git","svn_url":"https://github.com/danteruiz/hifi","homepage":"","size":545215,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"0cd5a242337176b297ff1348c2acac7e29256f64","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-07-26T18:51:52Z","pushed_at":"2018-07-26T20:20:02Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":544287,"stargazers_count":637,"watchers_count":637,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":406,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":406,"open_issues":181,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13687"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13687"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13687"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13687/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13687/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13687/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/b750a005cf8b5a2da6a829c6d27a7f9e83ee3fd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"huffman"}}