{"action":"opened","number":47,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47","id":171704663,"html_url":"https://github.com/apache/incubator-daffodil/pull/47","diff_url":"https://github.com/apache/incubator-daffodil/pull/47.diff","patch_url":"https://github.com/apache/incubator-daffodil/pull/47.patch","issue_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/47","number":47,"state":"open","locked":false,"title":"Correctly check if an element is required","user":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"body":"When determining what elements could appear after an element in an\r\ninfoset for unparsing we need to determine if an element is optional of\r\nnot to know if it's sibling could also appear next. We use a mixture of\r\nisOptional (for scalars) and isRequiredArrayElment (for arrays) to\r\ndetermine if an element was optional. This logic was actually not\r\ncorrect and has some edge cases it misses. Instead, we should just use\r\nthe isRequired function, which has the correct logic for determine if an\r\nelement could exist or not.\r\n\r\nDAFFODIL-1910","created_at":"2018-02-27T15:55:23Z","updated_at":"2018-02-27T15:55:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/47/comments","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/cbb759a0a839a4212f245ecbaac191ac8603729f","head":{"label":"stevedlawrence:daffodil-1910-required-array","ref":"daffodil-1910-required-array","sha":"cbb759a0a839a4212f245ecbaac191ac8603729f","user":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"repo":{"id":108402545,"name":"incubator-daffodil","full_name":"stevedlawrence/incubator-daffodil","owner":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevedlawrence/incubator-daffodil","description":"Mirror of Apache daffodil (Incubating)","fork":true,"url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil","forks_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/deployments","created_at":"2017-10-26T11:30:02Z","updated_at":"2017-10-26T11:30:17Z","pushed_at":"2018-02-27T15:54:50Z","git_url":"git://github.com/stevedlawrence/incubator-daffodil.git","ssh_url":"git@github.com:stevedlawrence/incubator-daffodil.git","clone_url":"https://github.com/stevedlawrence/incubator-daffodil.git","svn_url":"https://github.com/stevedlawrence/incubator-daffodil","homepage":null,"size":169144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"62eea54b75392c3fffcb36060d5bb078dfed3910","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":101730006,"name":"incubator-daffodil","full_name":"apache/incubator-daffodil","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-daffodil","forks_url":"https://api.github.com/repos/apache/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/apache/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/apache/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/apache/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/apache/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/apache/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/apache/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-daffodil/deployments","created_at":"2017-08-29T07:00:10Z","updated_at":"2018-01-09T19:13:54Z","pushed_at":"2018-02-20T16:00:31Z","git_url":"git://github.com/apache/incubator-daffodil.git","ssh_url":"git@github.com:apache/incubator-daffodil.git","clone_url":"https://github.com/apache/incubator-daffodil.git","svn_url":"https://github.com/apache/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":169148,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/47"},"issue":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/47"},"comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-daffodil/statuses/cbb759a0a839a4212f245ecbaac191ac8603729f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":98,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"stevedlawrence"}}