{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/4382","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4382/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4382/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4382/events","html_url":"https://github.com/envoyproxy/envoy/pull/4382","id":358598567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Mjk1MjM4","number":4382,"title":"network: delayed conn close","user":{"login":"AndresGuedez","id":34292400,"node_id":"MDQ6VXNlcjM0MjkyNDAw","avatar_url":"https://avatars2.githubusercontent.com/u/34292400?v=4","gravatar_id":"","url":"https://api.github.com/users/AndresGuedez","html_url":"https://github.com/AndresGuedez","followers_url":"https://api.github.com/users/AndresGuedez/followers","following_url":"https://api.github.com/users/AndresGuedez/following{/other_user}","gists_url":"https://api.github.com/users/AndresGuedez/gists{/gist_id}","starred_url":"https://api.github.com/users/AndresGuedez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndresGuedez/subscriptions","organizations_url":"https://api.github.com/users/AndresGuedez/orgs","repos_url":"https://api.github.com/users/AndresGuedez/repos","events_url":"https://api.github.com/users/AndresGuedez/events{/privacy}","received_events_url":"https://api.github.com/users/AndresGuedez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"zuercher","id":53179,"node_id":"MDQ6VXNlcjUzMTc5","avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"node_id":"MDQ6VXNlcjUzMTc5","avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},{"login":"dnoe","id":1183641,"node_id":"MDQ6VXNlcjExODM2NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1183641?v=4","gravatar_id":"","url":"https://api.github.com/users/dnoe","html_url":"https://github.com/dnoe","followers_url":"https://api.github.com/users/dnoe/followers","following_url":"https://api.github.com/users/dnoe/following{/other_user}","gists_url":"https://api.github.com/users/dnoe/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoe/subscriptions","organizations_url":"https://api.github.com/users/dnoe/orgs","repos_url":"https://api.github.com/users/dnoe/repos","events_url":"https://api.github.com/users/dnoe/events{/privacy}","received_events_url":"https://api.github.com/users/dnoe/received_events","type":"User","site_admin":false},{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},{"login":"ggreenway","id":8603643,"node_id":"MDQ6VXNlcjg2MDM2NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-10T12:22:03Z","updated_at":"2018-09-25T12:50:20Z","closed_at":"2018-09-24T23:07:32Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4382","html_url":"https://github.com/envoyproxy/envoy/pull/4382","diff_url":"https://github.com/envoyproxy/envoy/pull/4382.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4382.patch"},"body":"network: Support delayed close of downstream conns (#2929)\r\n\r\nMitigate client read/close race issues on downstream HTTP connections by adding a new connection\r\nclose type 'FlushWriteAndDelay'. This new close type flushes the write buffer on a connection but\r\ndoes not immediately close after emptying the buffer (unlike ConnectionCloseType::FlushWrite).\r\n\r\nA timer has been added to track delayed closes for both 'FlushWrite' and 'FlushWriteAndDelay'. Upon\r\ntriggering, the socket will be closed and the connection will be cleaned up.\r\n\r\nDelayed close processing can be disabled by setting the newly added HCM 'delayed_close_timeout'\r\nconfig option to 0.\r\n\r\nRisk Level: Medium (changes common case behavior for closing of downstream HTTP connections)\r\nTesting: Unit tests and integration tests added.\r\nFixes #2929.\r\n\r\nSigned-off-by: Andres Guedez <aguedez@google.com>"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/424329902","html_url":"https://github.com/envoyproxy/envoy/pull/4382#issuecomment-424329902","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4382","id":424329902,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDMyOTkwMg==","user":{"login":"AndresGuedez","id":34292400,"node_id":"MDQ6VXNlcjM0MjkyNDAw","avatar_url":"https://avatars2.githubusercontent.com/u/34292400?v=4","gravatar_id":"","url":"https://api.github.com/users/AndresGuedez","html_url":"https://github.com/AndresGuedez","followers_url":"https://api.github.com/users/AndresGuedez/followers","following_url":"https://api.github.com/users/AndresGuedez/following{/other_user}","gists_url":"https://api.github.com/users/AndresGuedez/gists{/gist_id}","starred_url":"https://api.github.com/users/AndresGuedez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndresGuedez/subscriptions","organizations_url":"https://api.github.com/users/AndresGuedez/orgs","repos_url":"https://api.github.com/users/AndresGuedez/repos","events_url":"https://api.github.com/users/AndresGuedez/events{/privacy}","received_events_url":"https://api.github.com/users/AndresGuedez/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T12:50:20Z","updated_at":"2018-09-25T12:50:20Z","author_association":"CONTRIBUTOR","body":"@mattklein123 Thanks for the review!"}}
{"actor":{"display_login":"AndresGuedez"}}