{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/180041591","pull_request_review_id":110391347,"id":180041591,"diff_hunk":"@@ -0,0 +1,23 @@\n+--- a/unix/Make-config\t2015-01-08 20:45:17.968890865 +0100\n++++ b/unix/Make-config\t2015-01-08 20:46:16.223075085 +0100\n+@@ -108,14 +108,14 @@\n+ #   http://www.ijg.org/files/\n+ ##########################################################################\n+ # Uncomment the following lines to disable JPEG support\n+-USEJPEG=\n+-JPEGINC=\n+-JPEGLIB=\n++#USEJPEG=\n++#JPEGINC=\n++#JPEGLIB=\n+ \n+ # Uncomment the following lines to enable JPEG support\n+-#USEJPEG= -DUSEJPEG\n+-#JPEGINC= -I/usr/local/include\n+-#JPEGLIB= -L/usr/local/lib -ljpeg\n++USEJPEG= -DUSEJPEG\n++JPEGINC= -I/usr/include\n++JPEGLIB= -L/usr/lib -ljpeg","path":"pkgs/development/libraries/tachyon/enable-jpeg.patch","position":null,"original_position":20,"commit_id":"a6e608a716ab139eb4f54c04df848d31e61e0d42","original_commit_id":"21f91b3d0ac4cafe6af74a412018d23d91c710d0","user":{"login":"timokau","id":3799330,"avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"body":"I replaced that by setting environment variables in `preBuild`, which is easier to do conditionally and only requires a single patch.","created_at":"2018-04-09T09:49:36Z","updated_at":"2018-04-09T09:49:36Z","html_url":"https://github.com/NixOS/nixpkgs/pull/38119#discussion_r180041591","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/180041591"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/38119#discussion_r180041591"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119"}},"in_reply_to_id":179996303},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119","id":178551521,"html_url":"https://github.com/NixOS/nixpkgs/pull/38119","diff_url":"https://github.com/NixOS/nixpkgs/pull/38119.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/38119.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38119","number":38119,"state":"open","locked":false,"title":"tachyon: Add support for jpeg, png, more platforms","user":{"login":"timokau","id":3799330,"avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nTachyon supports jpeg and png, but those need to be enabled at build time.\r\n\r\nI also added some new platforms, I *did not* test on any platform besides 64 bit linux though. However, since it is supported upstream and I lifted the platform definitions from the (presumably well-tested) sage spkg, there is good reason to believe that they will work.\r\n\r\nPinging maintainer @7c6f434c.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [x] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-03-30T12:27:52Z","updated_at":"2018-04-09T09:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb9f681ddd077d42d330ede124e24a14ae7c91d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38119/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a6e608a716ab139eb4f54c04df848d31e61e0d42","head":{"label":"timokau:tachyon-improvements","ref":"tachyon-improvements","sha":"a6e608a716ab139eb4f54c04df848d31e61e0d42","user":{"login":"timokau","id":3799330,"avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"repo":{"id":105080039,"name":"nixpkgs","full_name":"timokau/nixpkgs","owner":{"login":"timokau","id":3799330,"avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timokau/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/timokau/nixpkgs","forks_url":"https://api.github.com/repos/timokau/nixpkgs/forks","keys_url":"https://api.github.com/repos/timokau/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timokau/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timokau/nixpkgs/teams","hooks_url":"https://api.github.com/repos/timokau/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/timokau/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/timokau/nixpkgs/events","assignees_url":"https://api.github.com/repos/timokau/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/timokau/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/timokau/nixpkgs/tags","blobs_url":"https://api.github.com/repos/timokau/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timokau/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timokau/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/timokau/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timokau/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/timokau/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/timokau/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/timokau/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/timokau/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/timokau/nixpkgs/subscription","commits_url":"https://api.github.com/repos/timokau/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/timokau/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/timokau/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/timokau/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/timokau/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/timokau/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timokau/nixpkgs/merges","archive_url":"https://api.github.com/repos/timokau/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timokau/nixpkgs/downloads","issues_url":"https://api.github.com/repos/timokau/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/timokau/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/timokau/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/timokau/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timokau/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/timokau/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/timokau/nixpkgs/deployments","created_at":"2017-09-27T23:33:42Z","updated_at":"2017-09-27T23:34:09Z","pushed_at":"2018-04-09T09:06:28Z","git_url":"git://github.com/timokau/nixpkgs.git","ssh_url":"git@github.com:timokau/nixpkgs.git","clone_url":"https://github.com/timokau/nixpkgs.git","svn_url":"https://github.com/timokau/nixpkgs","homepage":null,"size":696521,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"9392b10d4afdc606e7b71767475974bb69f9c1ca","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-04-09T09:48:02Z","pushed_at":"2018-04-09T09:43:57Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":771715,"stargazers_count":2352,"watchers_count":2352,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2692,"mirror_url":null,"archived":false,"open_issues_count":3108,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2692,"open_issues":3108,"watchers":2352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/38119"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/38119"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/38119/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38119/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a6e608a716ab139eb4f54c04df848d31e61e0d42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timokau"}}