{"action":"created","comment":{"url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/comments/190229726","pull_request_review_id":122562537,"id":190229726,"diff_hunk":"@@ -571,7 +574,7 @@ def test_p2p(nr_of_flows, packet_sizes):\n         if config.warm_up:\n             lprint(\"  * Doing flow table warm-up...\")\n             tester.start_traffic(config.tester_interface)\n-            warm_up_verify(nr_of_flows, DEFAULT_WARM_UP_TIMEOUT)\n+            warm_up_verify(nr_of_flows, config.warm_up_timeout)","path":"ovs_performance.py","position":36,"original_position":45,"commit_id":"f7344111fe9d9c67e63b9c0dc24b41a67378fb4d","original_commit_id":"f7344111fe9d9c67e63b9c0dc24b41a67378fb4d","user":{"login":"chaudron","id":18258026,"avatar_url":"https://avatars2.githubusercontent.com/u/18258026?v=4","gravatar_id":"","url":"https://api.github.com/users/chaudron","html_url":"https://github.com/chaudron","followers_url":"https://api.github.com/users/chaudron/followers","following_url":"https://api.github.com/users/chaudron/following{/other_user}","gists_url":"https://api.github.com/users/chaudron/gists{/gist_id}","starred_url":"https://api.github.com/users/chaudron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaudron/subscriptions","organizations_url":"https://api.github.com/users/chaudron/orgs","repos_url":"https://api.github.com/users/chaudron/repos","events_url":"https://api.github.com/users/chaudron/events{/privacy}","received_events_url":"https://api.github.com/users/chaudron/received_events","type":"User","site_admin":false},"body":"This is an example why your change does not work. If it would fail here, there is no VM running.","created_at":"2018-05-23T12:40:50Z","updated_at":"2018-05-23T12:41:09Z","html_url":"https://github.com/chaudron/ovs_perf/pull/22#discussion_r190229726","pull_request_url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/comments/190229726"},"html":{"href":"https://github.com/chaudron/ovs_perf/pull/22#discussion_r190229726"},"pull_request":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22","id":187925939,"html_url":"https://github.com/chaudron/ovs_perf/pull/22","diff_url":"https://github.com/chaudron/ovs_perf/pull/22.diff","patch_url":"https://github.com/chaudron/ovs_perf/pull/22.patch","issue_url":"https://api.github.com/repos/chaudron/ovs_perf/issues/22","number":22,"state":"open","locked":false,"title":"Added couple of new options and changed the command to fetch number of flows","user":{"login":"mawasthi12","id":39228774,"avatar_url":"https://avatars1.githubusercontent.com/u/39228774?v=4","gravatar_id":"","url":"https://api.github.com/users/mawasthi12","html_url":"https://github.com/mawasthi12","followers_url":"https://api.github.com/users/mawasthi12/followers","following_url":"https://api.github.com/users/mawasthi12/following{/other_user}","gists_url":"https://api.github.com/users/mawasthi12/gists{/gist_id}","starred_url":"https://api.github.com/users/mawasthi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawasthi12/subscriptions","organizations_url":"https://api.github.com/users/mawasthi12/orgs","repos_url":"https://api.github.com/users/mawasthi12/repos","events_url":"https://api.github.com/users/mawasthi12/events{/privacy}","received_events_url":"https://api.github.com/users/mawasthi12/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI have added two new options to the script.\r\n1. --warm-up-no-fail: It is possible that a millions of flows cannot stay together in the system so there are chances of warm up failure. To deal with such situations I added this new option. If the warm up fails and this option is set then the script will wait for all the flows to flush but will continue with the test.\r\n2. --warm-up-timeout: Option to bail out of warm up early. Default 360 seconds looks too large.\r\n\r\nAlso, ovs-appctl dpctl/dump-flows can take a lot of time when large number of flows. Instead using ovs-appctl dpctl/show to fetch current number of flows.","created_at":"2018-05-14T19:24:22Z","updated_at":"2018-05-23T12:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"082792d04fd7e37324d12cf1b81c6d9592e45f2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22/commits","review_comments_url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22/comments","review_comment_url":"https://api.github.com/repos/chaudron/ovs_perf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaudron/ovs_perf/issues/22/comments","statuses_url":"https://api.github.com/repos/chaudron/ovs_perf/statuses/f7344111fe9d9c67e63b9c0dc24b41a67378fb4d","head":{"label":"mawasthi12:master","ref":"master","sha":"f7344111fe9d9c67e63b9c0dc24b41a67378fb4d","user":{"login":"mawasthi12","id":39228774,"avatar_url":"https://avatars1.githubusercontent.com/u/39228774?v=4","gravatar_id":"","url":"https://api.github.com/users/mawasthi12","html_url":"https://github.com/mawasthi12","followers_url":"https://api.github.com/users/mawasthi12/followers","following_url":"https://api.github.com/users/mawasthi12/following{/other_user}","gists_url":"https://api.github.com/users/mawasthi12/gists{/gist_id}","starred_url":"https://api.github.com/users/mawasthi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawasthi12/subscriptions","organizations_url":"https://api.github.com/users/mawasthi12/orgs","repos_url":"https://api.github.com/users/mawasthi12/repos","events_url":"https://api.github.com/users/mawasthi12/events{/privacy}","received_events_url":"https://api.github.com/users/mawasthi12/received_events","type":"User","site_admin":false},"repo":{"id":133407874,"name":"ovs_perf","full_name":"mawasthi12/ovs_perf","owner":{"login":"mawasthi12","id":39228774,"avatar_url":"https://avatars1.githubusercontent.com/u/39228774?v=4","gravatar_id":"","url":"https://api.github.com/users/mawasthi12","html_url":"https://github.com/mawasthi12","followers_url":"https://api.github.com/users/mawasthi12/followers","following_url":"https://api.github.com/users/mawasthi12/following{/other_user}","gists_url":"https://api.github.com/users/mawasthi12/gists{/gist_id}","starred_url":"https://api.github.com/users/mawasthi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawasthi12/subscriptions","organizations_url":"https://api.github.com/users/mawasthi12/orgs","repos_url":"https://api.github.com/users/mawasthi12/repos","events_url":"https://api.github.com/users/mawasthi12/events{/privacy}","received_events_url":"https://api.github.com/users/mawasthi12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mawasthi12/ovs_perf","description":"Automated Open vSwitch, Physical to Virtual to Physical test script","fork":true,"url":"https://api.github.com/repos/mawasthi12/ovs_perf","forks_url":"https://api.github.com/repos/mawasthi12/ovs_perf/forks","keys_url":"https://api.github.com/repos/mawasthi12/ovs_perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mawasthi12/ovs_perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mawasthi12/ovs_perf/teams","hooks_url":"https://api.github.com/repos/mawasthi12/ovs_perf/hooks","issue_events_url":"https://api.github.com/repos/mawasthi12/ovs_perf/issues/events{/number}","events_url":"https://api.github.com/repos/mawasthi12/ovs_perf/events","assignees_url":"https://api.github.com/repos/mawasthi12/ovs_perf/assignees{/user}","branches_url":"https://api.github.com/repos/mawasthi12/ovs_perf/branches{/branch}","tags_url":"https://api.github.com/repos/mawasthi12/ovs_perf/tags","blobs_url":"https://api.github.com/repos/mawasthi12/ovs_perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mawasthi12/ovs_perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mawasthi12/ovs_perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mawasthi12/ovs_perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mawasthi12/ovs_perf/statuses/{sha}","languages_url":"https://api.github.com/repos/mawasthi12/ovs_perf/languages","stargazers_url":"https://api.github.com/repos/mawasthi12/ovs_perf/stargazers","contributors_url":"https://api.github.com/repos/mawasthi12/ovs_perf/contributors","subscribers_url":"https://api.github.com/repos/mawasthi12/ovs_perf/subscribers","subscription_url":"https://api.github.com/repos/mawasthi12/ovs_perf/subscription","commits_url":"https://api.github.com/repos/mawasthi12/ovs_perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mawasthi12/ovs_perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mawasthi12/ovs_perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mawasthi12/ovs_perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mawasthi12/ovs_perf/contents/{+path}","compare_url":"https://api.github.com/repos/mawasthi12/ovs_perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mawasthi12/ovs_perf/merges","archive_url":"https://api.github.com/repos/mawasthi12/ovs_perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mawasthi12/ovs_perf/downloads","issues_url":"https://api.github.com/repos/mawasthi12/ovs_perf/issues{/number}","pulls_url":"https://api.github.com/repos/mawasthi12/ovs_perf/pulls{/number}","milestones_url":"https://api.github.com/repos/mawasthi12/ovs_perf/milestones{/number}","notifications_url":"https://api.github.com/repos/mawasthi12/ovs_perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mawasthi12/ovs_perf/labels{/name}","releases_url":"https://api.github.com/repos/mawasthi12/ovs_perf/releases{/id}","deployments_url":"https://api.github.com/repos/mawasthi12/ovs_perf/deployments","created_at":"2018-05-14T18:55:55Z","updated_at":"2018-05-14T19:17:04Z","pushed_at":"2018-05-14T19:17:03Z","git_url":"git://github.com/mawasthi12/ovs_perf.git","ssh_url":"git@github.com:mawasthi12/ovs_perf.git","clone_url":"https://github.com/mawasthi12/ovs_perf.git","svn_url":"https://github.com/mawasthi12/ovs_perf","homepage":null,"size":573,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaudron:master","ref":"master","sha":"67f645d9af17560a5b6a0034667e7e0689d6d655","user":{"login":"chaudron","id":18258026,"avatar_url":"https://avatars2.githubusercontent.com/u/18258026?v=4","gravatar_id":"","url":"https://api.github.com/users/chaudron","html_url":"https://github.com/chaudron","followers_url":"https://api.github.com/users/chaudron/followers","following_url":"https://api.github.com/users/chaudron/following{/other_user}","gists_url":"https://api.github.com/users/chaudron/gists{/gist_id}","starred_url":"https://api.github.com/users/chaudron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaudron/subscriptions","organizations_url":"https://api.github.com/users/chaudron/orgs","repos_url":"https://api.github.com/users/chaudron/repos","events_url":"https://api.github.com/users/chaudron/events{/privacy}","received_events_url":"https://api.github.com/users/chaudron/received_events","type":"User","site_admin":false},"repo":{"id":102603867,"name":"ovs_perf","full_name":"chaudron/ovs_perf","owner":{"login":"chaudron","id":18258026,"avatar_url":"https://avatars2.githubusercontent.com/u/18258026?v=4","gravatar_id":"","url":"https://api.github.com/users/chaudron","html_url":"https://github.com/chaudron","followers_url":"https://api.github.com/users/chaudron/followers","following_url":"https://api.github.com/users/chaudron/following{/other_user}","gists_url":"https://api.github.com/users/chaudron/gists{/gist_id}","starred_url":"https://api.github.com/users/chaudron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaudron/subscriptions","organizations_url":"https://api.github.com/users/chaudron/orgs","repos_url":"https://api.github.com/users/chaudron/repos","events_url":"https://api.github.com/users/chaudron/events{/privacy}","received_events_url":"https://api.github.com/users/chaudron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaudron/ovs_perf","description":"Automated Open vSwitch, Physical to Virtual to Physical test script","fork":false,"url":"https://api.github.com/repos/chaudron/ovs_perf","forks_url":"https://api.github.com/repos/chaudron/ovs_perf/forks","keys_url":"https://api.github.com/repos/chaudron/ovs_perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaudron/ovs_perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaudron/ovs_perf/teams","hooks_url":"https://api.github.com/repos/chaudron/ovs_perf/hooks","issue_events_url":"https://api.github.com/repos/chaudron/ovs_perf/issues/events{/number}","events_url":"https://api.github.com/repos/chaudron/ovs_perf/events","assignees_url":"https://api.github.com/repos/chaudron/ovs_perf/assignees{/user}","branches_url":"https://api.github.com/repos/chaudron/ovs_perf/branches{/branch}","tags_url":"https://api.github.com/repos/chaudron/ovs_perf/tags","blobs_url":"https://api.github.com/repos/chaudron/ovs_perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaudron/ovs_perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaudron/ovs_perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaudron/ovs_perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaudron/ovs_perf/statuses/{sha}","languages_url":"https://api.github.com/repos/chaudron/ovs_perf/languages","stargazers_url":"https://api.github.com/repos/chaudron/ovs_perf/stargazers","contributors_url":"https://api.github.com/repos/chaudron/ovs_perf/contributors","subscribers_url":"https://api.github.com/repos/chaudron/ovs_perf/subscribers","subscription_url":"https://api.github.com/repos/chaudron/ovs_perf/subscription","commits_url":"https://api.github.com/repos/chaudron/ovs_perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaudron/ovs_perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaudron/ovs_perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaudron/ovs_perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaudron/ovs_perf/contents/{+path}","compare_url":"https://api.github.com/repos/chaudron/ovs_perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaudron/ovs_perf/merges","archive_url":"https://api.github.com/repos/chaudron/ovs_perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaudron/ovs_perf/downloads","issues_url":"https://api.github.com/repos/chaudron/ovs_perf/issues{/number}","pulls_url":"https://api.github.com/repos/chaudron/ovs_perf/pulls{/number}","milestones_url":"https://api.github.com/repos/chaudron/ovs_perf/milestones{/number}","notifications_url":"https://api.github.com/repos/chaudron/ovs_perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaudron/ovs_perf/labels{/name}","releases_url":"https://api.github.com/repos/chaudron/ovs_perf/releases{/id}","deployments_url":"https://api.github.com/repos/chaudron/ovs_perf/deployments","created_at":"2017-09-06T12:07:29Z","updated_at":"2018-05-08T15:31:43Z","pushed_at":"2018-05-14T19:24:23Z","git_url":"git://github.com/chaudron/ovs_perf.git","ssh_url":"git@github.com:chaudron/ovs_perf.git","clone_url":"https://github.com/chaudron/ovs_perf.git","svn_url":"https://github.com/chaudron/ovs_perf","homepage":null,"size":607,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22"},"html":{"href":"https://github.com/chaudron/ovs_perf/pull/22"},"issue":{"href":"https://api.github.com/repos/chaudron/ovs_perf/issues/22"},"comments":{"href":"https://api.github.com/repos/chaudron/ovs_perf/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaudron/ovs_perf/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/chaudron/ovs_perf/statuses/f7344111fe9d9c67e63b9c0dc24b41a67378fb4d"}},"author_association":"NONE"}}
{"actor":{"display_login":"chaudron"}}