{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/charticulator/issues/44","repository_url":"https://api.github.com/repos/Microsoft/charticulator","labels_url":"https://api.github.com/repos/Microsoft/charticulator/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/charticulator/issues/44/comments","events_url":"https://api.github.com/repos/Microsoft/charticulator/issues/44/events","html_url":"https://github.com/Microsoft/charticulator/pull/44","id":358482231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjA4MDg5","number":44,"title":"Support small multiples; fix template export and chart container","user":{"login":"donghaoren","id":1595237,"node_id":"MDQ6VXNlcjE1OTUyMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1595237?v=4","gravatar_id":"","url":"https://api.github.com/users/donghaoren","html_url":"https://github.com/donghaoren","followers_url":"https://api.github.com/users/donghaoren/followers","following_url":"https://api.github.com/users/donghaoren/following{/other_user}","gists_url":"https://api.github.com/users/donghaoren/gists{/gist_id}","starred_url":"https://api.github.com/users/donghaoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donghaoren/subscriptions","organizations_url":"https://api.github.com/users/donghaoren/orgs","repos_url":"https://api.github.com/users/donghaoren/repos","events_url":"https://api.github.com/users/donghaoren/events{/privacy}","received_events_url":"https://api.github.com/users/donghaoren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-10T06:17:39Z","updated_at":"2018-09-10T16:36:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/charticulator/pulls/44","html_url":"https://github.com/Microsoft/charticulator/pull/44","diff_url":"https://github.com/Microsoft/charticulator/pull/44.diff","patch_url":"https://github.com/Microsoft/charticulator/pull/44.patch"},"body":"Support small multiples:\r\n- Add a nested chart component\r\n- Show Charticulator in a popup window to edit small multiples\r\n\r\nFix template export and container:\r\n- Refactored template code to match the newly added group by feature\r\n- Refactored container code so part of it can be used to display small multiples\r\n- Fix template container, basic charts should work\r\n- Add property for axis and scale domain/range setup in exported template\r\n\r\nOther improvements:\r\n- Render each mark in a separate layer (previously each glyph was in a layer)\r\n- Add reverse and sort button to categorical axis ordering\r\n- Fix scale inference when values are the same\r\n- Fix React incorrect nesting warning\r\n\r\nMinor:\r\n- Renamed a few files to match the current naming style\r\n- Removed some dead code\r\n- Add doc for adding sample datasets in config.yml (in addition to datasets/files.json)\r\n- Add more error boundary; add version to help menu\r\n- Use 2 spaces indentation for HTML files\r\n- Upgrade modules and build script:\r\n   - Typescript to 3.0.3\r\n   - multirun to 3.0.2\r\n   - Remove cross-env, replace with a command line flag in build.js"},"comment":{"url":"https://api.github.com/repos/Microsoft/charticulator/issues/comments/419978143","html_url":"https://github.com/Microsoft/charticulator/pull/44#issuecomment-419978143","issue_url":"https://api.github.com/repos/Microsoft/charticulator/issues/44","id":419978143,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTk3ODE0Mw==","user":{"login":"stopyoukid","id":2513737,"node_id":"MDQ6VXNlcjI1MTM3Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2513737?v=4","gravatar_id":"","url":"https://api.github.com/users/stopyoukid","html_url":"https://github.com/stopyoukid","followers_url":"https://api.github.com/users/stopyoukid/followers","following_url":"https://api.github.com/users/stopyoukid/following{/other_user}","gists_url":"https://api.github.com/users/stopyoukid/gists{/gist_id}","starred_url":"https://api.github.com/users/stopyoukid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stopyoukid/subscriptions","organizations_url":"https://api.github.com/users/stopyoukid/orgs","repos_url":"https://api.github.com/users/stopyoukid/repos","events_url":"https://api.github.com/users/stopyoukid/events{/privacy}","received_events_url":"https://api.github.com/users/stopyoukid/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T16:36:51Z","updated_at":"2018-09-10T16:36:51Z","author_association":"MEMBER","body":"Similar to the one above, if I am editing the nested chart, add a rectangle mark, click the mark in the chart editor and hit `delete`, then finally click on the `rectangle` mark, I get this issue\r\n\r\n![nested chart issue 2](https://user-images.githubusercontent.com/2513737/45311086-ef931a00-b4dc-11e8-8f71-99d179ceb78d.gif)\r\n"}}
{"actor":{"display_login":"stopyoukid"}}