{"action":"created","issue":{"url":"https://api.github.com/repos/diwg/cf2/issues/9","repository_url":"https://api.github.com/repos/diwg/cf2","labels_url":"https://api.github.com/repos/diwg/cf2/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/diwg/cf2/issues/9/comments","events_url":"https://api.github.com/repos/diwg/cf2/issues/9/events","html_url":"https://github.com/diwg/cf2/issues/9","id":321765106,"number":9,"title":"Suggestions for Types proposal","user":{"login":"czender","id":5597049,"avatar_url":"https://avatars0.githubusercontent.com/u/5597049?v=4","gravatar_id":"","url":"https://api.github.com/users/czender","html_url":"https://github.com/czender","followers_url":"https://api.github.com/users/czender/followers","following_url":"https://api.github.com/users/czender/following{/other_user}","gists_url":"https://api.github.com/users/czender/gists{/gist_id}","starred_url":"https://api.github.com/users/czender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czender/subscriptions","organizations_url":"https://api.github.com/users/czender/orgs","repos_url":"https://api.github.com/users/czender/repos","events_url":"https://api.github.com/users/czender/events{/privacy}","received_events_url":"https://api.github.com/users/czender/received_events","type":"User","site_admin":false},"labels":[{"id":912902467,"url":"https://api.github.com/repos/diwg/cf2/labels/Medium%20Priority","name":"Medium Priority","color":"0e8a16","default":false},{"id":928256411,"url":"https://api.github.com/repos/diwg/cf2/labels/Types","name":"Types","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"erget","id":1914151,"avatar_url":"https://avatars3.githubusercontent.com/u/1914151?v=4","gravatar_id":"","url":"https://api.github.com/users/erget","html_url":"https://github.com/erget","followers_url":"https://api.github.com/users/erget/followers","following_url":"https://api.github.com/users/erget/following{/other_user}","gists_url":"https://api.github.com/users/erget/gists{/gist_id}","starred_url":"https://api.github.com/users/erget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erget/subscriptions","organizations_url":"https://api.github.com/users/erget/orgs","repos_url":"https://api.github.com/users/erget/repos","events_url":"https://api.github.com/users/erget/events{/privacy}","received_events_url":"https://api.github.com/users/erget/received_events","type":"User","site_admin":false},"assignees":[{"login":"erget","id":1914151,"avatar_url":"https://avatars3.githubusercontent.com/u/1914151?v=4","gravatar_id":"","url":"https://api.github.com/users/erget","html_url":"https://github.com/erget","followers_url":"https://api.github.com/users/erget/followers","following_url":"https://api.github.com/users/erget/following{/other_user}","gists_url":"https://api.github.com/users/erget/gists{/gist_id}","starred_url":"https://api.github.com/users/erget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erget/subscriptions","organizations_url":"https://api.github.com/users/erget/orgs","repos_url":"https://api.github.com/users/erget/repos","events_url":"https://api.github.com/users/erget/events{/privacy}","received_events_url":"https://api.github.com/users/erget/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-05-09T23:59:14Z","updated_at":"2018-05-11T09:50:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Daniel,\r\nHere are my initial suggestions for the Types proposal. If you find they have merit, please craft the replacement language yourself as I am short on time this week:\r\n1. List NC_UBYTE among the new atomic types\r\n2. This statement\r\n\r\n> enum types may be used, but only if they resolve to an atomic external type at the end.\r\n\r\nneeds elaboration. I think that netCDF4 library ensures that the base type of an enum must be an integer. If so, then the statement is redundant, since all integer types are valid base types. What does \"at the end\" add to the sentence? Since the base type must be an integer, there can be no recursive ENUM variables (yes?).\r\n3. It's unclear why you narrow the proposal down to just adding ENUM, not VLEN, COMPOUND, or OPAQUE. This means the Types proposal  is in effect a proposal to allow ENUM and STRING types (so should the name be changed?), because the integer types are covered by my CF1 proposal which languishes in limbo but will probably be adopted eventually (and does anyone recall another CF1 proposal to allow STRING?) . Please add rationale and/or explanation why the proposal is narrow, since adoptees will likely want to understand this proposal in the context of previous and potential future proposals related to types."},"comment":{"url":"https://api.github.com/repos/diwg/cf2/issues/comments/388317274","html_url":"https://github.com/diwg/cf2/issues/9#issuecomment-388317274","issue_url":"https://api.github.com/repos/diwg/cf2/issues/9","id":388317274,"user":{"login":"erget","id":1914151,"avatar_url":"https://avatars3.githubusercontent.com/u/1914151?v=4","gravatar_id":"","url":"https://api.github.com/users/erget","html_url":"https://github.com/erget","followers_url":"https://api.github.com/users/erget/followers","following_url":"https://api.github.com/users/erget/following{/other_user}","gists_url":"https://api.github.com/users/erget/gists{/gist_id}","starred_url":"https://api.github.com/users/erget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erget/subscriptions","organizations_url":"https://api.github.com/users/erget/orgs","repos_url":"https://api.github.com/users/erget/repos","events_url":"https://api.github.com/users/erget/events{/privacy}","received_events_url":"https://api.github.com/users/erget/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T09:50:06Z","updated_at":"2018-05-11T09:50:06Z","author_association":"CONTRIBUTOR","body":"Responding to @czender 's comments:\r\n\r\n1. Of course, this one slipped past me.\r\n1. I think I was just in \"overly-restrictive\" mode when I was writing this - you're right, netCDF enforces this by itself so there's no need to go over the top. I also have no problem with non-ASCII member labels. IIRC there was a bit of discussion last year at the netCDF-CF workshop after Ethan's presentation on strings that made me a bit nervous about going beyond ASCII, but we can see if discussion about that comes back.\r\n1. I'll add a bit of background in the next commit. Basically, my intent with this proposal is to get something passed through that's as noncontroversial as possible, because EUMETSAT definitely intends on using these data types. IMHO VLEN, COMPOUND and OPAQUE are all interesting but a whole different can of worms.\r\n\r\nAnother alternative would be to try to revive @czender 's [proposal](https://cf-trac.llnl.gov/trac/ticket/166) in CF1 and make a whole different one to address user-defined data types. I could get on board with that. Since I know that EUMETSAT will be producing data \"soon\" (2021) using `enum` and the other atomic external types, I'd like to maximize the chances that we can do so in a CF-compliant fashion beforehand."}}
{"actor":{"display_login":"erget"}}