{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/190450340","pull_request_review_id":122824759,"id":190450340,"diff_hunk":"@@ -114,7 +115,9 @@ func (s *testTimeSuite) TestTimestamp(c *C) {\n \t}\n \n \tfor _, test := range table {\n-\t\tt, err := types.ParseTimestamp(nil, test.Input)\n+\t\tt, err := types.ParseTimestamp(&stmtctx.StatementContext{\n+\t\t\tTimeZone: time.Local,","path":"types/time_test.go","position":14,"original_position":14,"commit_id":"40881a80ccb11d2e46627897b746aa8cf0be00c0","original_commit_id":"40881a80ccb11d2e46627897b746aa8cf0be00c0","user":{"login":"tiancaiamao","id":1420062,"avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"body":"time.Local would make CI unstable easily","created_at":"2018-05-24T02:28:27Z","updated_at":"2018-05-24T02:28:55Z","html_url":"https://github.com/pingcap/tidb/pull/6581#discussion_r190450340","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/6581","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/190450340"},"html":{"href":"https://github.com/pingcap/tidb/pull/6581#discussion_r190450340"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6581"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/6581","id":189105382,"html_url":"https://github.com/pingcap/tidb/pull/6581","diff_url":"https://github.com/pingcap/tidb/pull/6581.diff","patch_url":"https://github.com/pingcap/tidb/pull/6581.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/6581","number":6581,"state":"open","locked":false,"title":"*:check max/min timestamp bound with timezone aware","user":{"login":"lysu","id":528332,"avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"body":"- mytime: max/min configure with UTC tz, convert to local tz during process starting, convert it to session tz before checking bound.\r\n- time: so `check()`/`add()` need force pass `StatementContext` parameter.\r\n- builtin_time: pass `StatementContext` from `b.ctx.sessionVars` into check/add.\r\n- dump: also set timezone for StatementContext with UTC.\r\n- *_test/mock: fix test case, make mock context with stmt TimeZone.\r\n- add testcase for checkTimestamp and mytime convert timezone.","created_at":"2018-05-18T18:44:49Z","updated_at":"2018-05-24T02:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2805b7e9348392e7fa1108e4bbd5b54db95f5884","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lamxTyler","id":16222711,"avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":564574080,"url":"https://api.github.com/repos/pingcap/tidb/labels/LGT1","name":"LGT1","color":"d4c5f9","default":false},{"id":770872605,"url":"https://api.github.com/repos/pingcap/tidb/labels/all-tests-passed","name":"all-tests-passed","color":"2cbe4e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/6581/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/6581/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/6581/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/40881a80ccb11d2e46627897b746aa8cf0be00c0","head":{"label":"lysu:dev/time-compare-tz-aware","ref":"dev/time-compare-tz-aware","sha":"40881a80ccb11d2e46627897b746aa8cf0be00c0","user":{"login":"lysu","id":528332,"avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"repo":{"id":133315666,"name":"tidb","full_name":"lysu/tidb","owner":{"login":"lysu","id":528332,"avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lysu/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":true,"url":"https://api.github.com/repos/lysu/tidb","forks_url":"https://api.github.com/repos/lysu/tidb/forks","keys_url":"https://api.github.com/repos/lysu/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lysu/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lysu/tidb/teams","hooks_url":"https://api.github.com/repos/lysu/tidb/hooks","issue_events_url":"https://api.github.com/repos/lysu/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/lysu/tidb/events","assignees_url":"https://api.github.com/repos/lysu/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/lysu/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/lysu/tidb/tags","blobs_url":"https://api.github.com/repos/lysu/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lysu/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lysu/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lysu/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lysu/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/lysu/tidb/languages","stargazers_url":"https://api.github.com/repos/lysu/tidb/stargazers","contributors_url":"https://api.github.com/repos/lysu/tidb/contributors","subscribers_url":"https://api.github.com/repos/lysu/tidb/subscribers","subscription_url":"https://api.github.com/repos/lysu/tidb/subscription","commits_url":"https://api.github.com/repos/lysu/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lysu/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lysu/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lysu/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lysu/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/lysu/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lysu/tidb/merges","archive_url":"https://api.github.com/repos/lysu/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lysu/tidb/downloads","issues_url":"https://api.github.com/repos/lysu/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/lysu/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/lysu/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/lysu/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lysu/tidb/labels{/name}","releases_url":"https://api.github.com/repos/lysu/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/lysu/tidb/deployments","created_at":"2018-05-14T06:37:16Z","updated_at":"2018-05-23T09:21:21Z","pushed_at":"2018-05-24T02:21:13Z","git_url":"git://github.com/lysu/tidb.git","ssh_url":"git@github.com:lysu/tidb.git","clone_url":"https://github.com/lysu/tidb.git","svn_url":"https://github.com/lysu/tidb","homepage":"https://pingcap.com","size":48456,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"e705c18d19c4d10e0019f73ad55e33f2ff279d01","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-05-24T02:13:17Z","pushed_at":"2018-05-24T02:22:11Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":73663,"stargazers_count":13389,"watchers_count":13389,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1808,"mirror_url":null,"archived":false,"open_issues_count":413,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1808,"open_issues":413,"watchers":13389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6581"},"html":{"href":"https://github.com/pingcap/tidb/pull/6581"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6581"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6581/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6581/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6581/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/40881a80ccb11d2e46627897b746aa8cf0be00c0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tiancaiamao"}}