{"action":"closed","number":2735,"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2735","id":211539138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTM5MTM4","html_url":"https://github.com/eclipse/openj9/pull/2735","diff_url":"https://github.com/eclipse/openj9/pull/2735.diff","patch_url":"https://github.com/eclipse/openj9/pull/2735.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2735","number":2735,"state":"closed","locked":false,"title":"Address diagnostics from gcc 8","user":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"body":"* avoid possible bounds violations by using j9str_printf instead of sprintf\r\n\r\n* Fix 'error=class-memaccess' diagnostics of the form:\r\n```\r\nerror: 'void* memset(void*, int, size_t)' clearing an object with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]\r\n```\r\n\r\n* clean up: add missing 'static' modifiers; fix formatting\r\n\r\n* correct lengths of predefined trace options","created_at":"2018-08-28T19:56:09Z","updated_at":"2018-08-29T17:17:10Z","closed_at":"2018-08-29T17:17:10Z","merged_at":"2018-08-29T17:17:10Z","merge_commit_sha":"e9ee8c13abd87cae0812faa44595bc28f37ffe3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2735/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2735/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2735/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/c6e0ef4c9ac1de6e148306994fc14b928363869b","head":{"label":"keithc-ca:gcc-8","ref":"gcc-8","sha":"c6e0ef4c9ac1de6e148306994fc14b928363869b","user":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"repo":{"id":103323536,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMzMjM1MzY=","name":"openj9","full_name":"keithc-ca/openj9","owner":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keithc-ca/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/keithc-ca/openj9","forks_url":"https://api.github.com/repos/keithc-ca/openj9/forks","keys_url":"https://api.github.com/repos/keithc-ca/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keithc-ca/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keithc-ca/openj9/teams","hooks_url":"https://api.github.com/repos/keithc-ca/openj9/hooks","issue_events_url":"https://api.github.com/repos/keithc-ca/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/keithc-ca/openj9/events","assignees_url":"https://api.github.com/repos/keithc-ca/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/keithc-ca/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/keithc-ca/openj9/tags","blobs_url":"https://api.github.com/repos/keithc-ca/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keithc-ca/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keithc-ca/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/keithc-ca/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keithc-ca/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/keithc-ca/openj9/languages","stargazers_url":"https://api.github.com/repos/keithc-ca/openj9/stargazers","contributors_url":"https://api.github.com/repos/keithc-ca/openj9/contributors","subscribers_url":"https://api.github.com/repos/keithc-ca/openj9/subscribers","subscription_url":"https://api.github.com/repos/keithc-ca/openj9/subscription","commits_url":"https://api.github.com/repos/keithc-ca/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/keithc-ca/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/keithc-ca/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/keithc-ca/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/keithc-ca/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/keithc-ca/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keithc-ca/openj9/merges","archive_url":"https://api.github.com/repos/keithc-ca/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keithc-ca/openj9/downloads","issues_url":"https://api.github.com/repos/keithc-ca/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/keithc-ca/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/keithc-ca/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/keithc-ca/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keithc-ca/openj9/labels{/name}","releases_url":"https://api.github.com/repos/keithc-ca/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/keithc-ca/openj9/deployments","created_at":"2017-09-12T21:45:46Z","updated_at":"2018-08-29T15:04:15Z","pushed_at":"2018-08-29T15:04:12Z","git_url":"git://github.com/keithc-ca/openj9.git","ssh_url":"git@github.com:keithc-ca/openj9.git","clone_url":"https://github.com/keithc-ca/openj9.git","svn_url":"https://github.com/keithc-ca/openj9","homepage":null,"size":33667,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"ab59673708261689ea56cedae2dc3f78bdb2f72c","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-08-29T15:43:50Z","pushed_at":"2018-08-29T17:17:10Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":33667,"stargazers_count":1392,"watchers_count":1392,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":445,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":272,"open_issues":445,"watchers":1392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2735"},"html":{"href":"https://github.com/eclipse/openj9/pull/2735"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2735"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2735/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2735/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2735/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/c6e0ef4c9ac1de6e148306994fc14b928363869b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"comments":4,"review_comments":14,"maintainer_can_modify":false,"commits":5,"additions":236,"deletions":250,"changed_files":11}}
{"actor":{"display_login":"gacholio"}}