{"action":"closed","number":4207,"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207","id":209671626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjcxNjI2","html_url":"https://github.com/envoyproxy/envoy/pull/4207","diff_url":"https://github.com/envoyproxy/envoy/pull/4207.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4207.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4207","number":4207,"state":"closed","locked":false,"title":"[api] Move HeaderMatcher from api.v2.route to type.matcher package","user":{"login":"brirams","id":1807482,"node_id":"MDQ6VXNlcjE4MDc0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1807482?v=4","gravatar_id":"","url":"https://api.github.com/users/brirams","html_url":"https://github.com/brirams","followers_url":"https://api.github.com/users/brirams/followers","following_url":"https://api.github.com/users/brirams/following{/other_user}","gists_url":"https://api.github.com/users/brirams/gists{/gist_id}","starred_url":"https://api.github.com/users/brirams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brirams/subscriptions","organizations_url":"https://api.github.com/users/brirams/orgs","repos_url":"https://api.github.com/users/brirams/repos","events_url":"https://api.github.com/users/brirams/events{/privacy}","received_events_url":"https://api.github.com/users/brirams/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nSince the `HeaderMatcher` struct is used in a variety of places, it made sense to move it into a common package(as discussed in [slack](https://envoyproxy.slack.com/archives/C78HA81DH/p1534290035000200). In doing so, also brought the `HeaderUtility` class along for the ride by colocating it with `common/common/matchers.[cc|h]`. Also updated doc references to new location.\r\n\r\n*Risk Level*: Low\r\n*Testing*: Tests, new and old, pass.\r\n*Docs Changes*:\r\n- updated `version_history.rst` to document move\r\n- updated references to struct accordingly.","created_at":"2018-08-20T23:38:33Z","updated_at":"2018-09-07T22:16:31Z","closed_at":"2018-09-07T22:16:31Z","merged_at":null,"merge_commit_sha":"f6396267e0a6858b21e300ceac54d59dc639a5aa","assignee":{"login":"ccaraman","id":19931185,"node_id":"MDQ6VXNlcjE5OTMxMTg1","avatar_url":"https://avatars2.githubusercontent.com/u/19931185?v=4","gravatar_id":"","url":"https://api.github.com/users/ccaraman","html_url":"https://github.com/ccaraman","followers_url":"https://api.github.com/users/ccaraman/followers","following_url":"https://api.github.com/users/ccaraman/following{/other_user}","gists_url":"https://api.github.com/users/ccaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaraman/subscriptions","organizations_url":"https://api.github.com/users/ccaraman/orgs","repos_url":"https://api.github.com/users/ccaraman/repos","events_url":"https://api.github.com/users/ccaraman/events{/privacy}","received_events_url":"https://api.github.com/users/ccaraman/received_events","type":"User","site_admin":false},"assignees":[{"login":"ccaraman","id":19931185,"node_id":"MDQ6VXNlcjE5OTMxMTg1","avatar_url":"https://avatars2.githubusercontent.com/u/19931185?v=4","gravatar_id":"","url":"https://api.github.com/users/ccaraman","html_url":"https://github.com/ccaraman","followers_url":"https://api.github.com/users/ccaraman/followers","following_url":"https://api.github.com/users/ccaraman/following{/other_user}","gists_url":"https://api.github.com/users/ccaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaraman/subscriptions","organizations_url":"https://api.github.com/users/ccaraman/orgs","repos_url":"https://api.github.com/users/ccaraman/repos","events_url":"https://api.github.com/users/ccaraman/events{/privacy}","received_events_url":"https://api.github.com/users/ccaraman/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":867150379,"node_id":"MDU6TGFiZWw4NjcxNTAzNzk=","url":"https://api.github.com/repos/envoyproxy/envoy/labels/stale","name":"stale","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4207/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/04f2729c801da318d4a543cf4c3f00eda6f6a007","head":{"label":"turbinelabs:brirams/#5555/thrift_proxy/move_http_header_matcher","ref":"brirams/#5555/thrift_proxy/move_http_header_matcher","sha":"04f2729c801da318d4a543cf4c3f00eda6f6a007","user":{"login":"turbinelabs","id":12767820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY3ODIw","avatar_url":"https://avatars0.githubusercontent.com/u/12767820?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinelabs","html_url":"https://github.com/turbinelabs","followers_url":"https://api.github.com/users/turbinelabs/followers","following_url":"https://api.github.com/users/turbinelabs/following{/other_user}","gists_url":"https://api.github.com/users/turbinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinelabs/subscriptions","organizations_url":"https://api.github.com/users/turbinelabs/orgs","repos_url":"https://api.github.com/users/turbinelabs/repos","events_url":"https://api.github.com/users/turbinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/turbinelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":97758644,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc1ODY0NA==","name":"envoy","full_name":"turbinelabs/envoy","owner":{"login":"turbinelabs","id":12767820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY3ODIw","avatar_url":"https://avatars0.githubusercontent.com/u/12767820?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinelabs","html_url":"https://github.com/turbinelabs","followers_url":"https://api.github.com/users/turbinelabs/followers","following_url":"https://api.github.com/users/turbinelabs/following{/other_user}","gists_url":"https://api.github.com/users/turbinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinelabs/subscriptions","organizations_url":"https://api.github.com/users/turbinelabs/orgs","repos_url":"https://api.github.com/users/turbinelabs/repos","events_url":"https://api.github.com/users/turbinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/turbinelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/turbinelabs/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/turbinelabs/envoy","forks_url":"https://api.github.com/repos/turbinelabs/envoy/forks","keys_url":"https://api.github.com/repos/turbinelabs/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turbinelabs/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turbinelabs/envoy/teams","hooks_url":"https://api.github.com/repos/turbinelabs/envoy/hooks","issue_events_url":"https://api.github.com/repos/turbinelabs/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/turbinelabs/envoy/events","assignees_url":"https://api.github.com/repos/turbinelabs/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/turbinelabs/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/turbinelabs/envoy/tags","blobs_url":"https://api.github.com/repos/turbinelabs/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turbinelabs/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turbinelabs/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/turbinelabs/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turbinelabs/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/turbinelabs/envoy/languages","stargazers_url":"https://api.github.com/repos/turbinelabs/envoy/stargazers","contributors_url":"https://api.github.com/repos/turbinelabs/envoy/contributors","subscribers_url":"https://api.github.com/repos/turbinelabs/envoy/subscribers","subscription_url":"https://api.github.com/repos/turbinelabs/envoy/subscription","commits_url":"https://api.github.com/repos/turbinelabs/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/turbinelabs/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/turbinelabs/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/turbinelabs/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/turbinelabs/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/turbinelabs/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turbinelabs/envoy/merges","archive_url":"https://api.github.com/repos/turbinelabs/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turbinelabs/envoy/downloads","issues_url":"https://api.github.com/repos/turbinelabs/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/turbinelabs/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/turbinelabs/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/turbinelabs/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turbinelabs/envoy/labels{/name}","releases_url":"https://api.github.com/repos/turbinelabs/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/turbinelabs/envoy/deployments","created_at":"2017-07-19T20:32:31Z","updated_at":"2018-08-07T17:13:44Z","pushed_at":"2018-09-07T19:14:24Z","git_url":"git://github.com/turbinelabs/envoy.git","ssh_url":"git@github.com:turbinelabs/envoy.git","clone_url":"https://github.com/turbinelabs/envoy.git","svn_url":"https://github.com/turbinelabs/envoy","homepage":"https://www.envoyproxy.io","size":45584,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"f379ad1f0382ecb4b40f0c3550237574c8b9f930","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-09-07T20:55:14Z","pushed_at":"2018-09-07T22:10:28Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":20269,"stargazers_count":6456,"watchers_count":6456,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":863,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":863,"open_issues":321,"watchers":6456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4207"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4207"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4207/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4207/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/04f2729c801da318d4a543cf4c3f00eda6f6a007"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":5,"maintainer_can_modify":false,"commits":4,"additions":448,"deletions":446,"changed_files":53}}
{"actor":{"display_login":"brirams"}}