{"action":"created","issue":{"url":"https://api.github.com/repos/propelorm/Propel/issues/1054","repository_url":"https://api.github.com/repos/propelorm/Propel","labels_url":"https://api.github.com/repos/propelorm/Propel/issues/1054/labels{/name}","comments_url":"https://api.github.com/repos/propelorm/Propel/issues/1054/comments","events_url":"https://api.github.com/repos/propelorm/Propel/issues/1054/events","html_url":"https://github.com/propelorm/Propel/pull/1054","id":298042095,"number":1054,"title":"SQL injection fix: Coerce offset and limit values to integers","user":{"login":"mpetrovich","id":1235062,"avatar_url":"https://avatars2.githubusercontent.com/u/1235062?v=4","gravatar_id":"","url":"https://api.github.com/users/mpetrovich","html_url":"https://github.com/mpetrovich","followers_url":"https://api.github.com/users/mpetrovich/followers","following_url":"https://api.github.com/users/mpetrovich/following{/other_user}","gists_url":"https://api.github.com/users/mpetrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetrovich/subscriptions","organizations_url":"https://api.github.com/users/mpetrovich/orgs","repos_url":"https://api.github.com/users/mpetrovich/repos","events_url":"https://api.github.com/users/mpetrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mpetrovich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-17T22:33:33Z","updated_at":"2018-03-29T22:58:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/propelorm/Propel/pulls/1054","html_url":"https://github.com/propelorm/Propel/pull/1054","diff_url":"https://github.com/propelorm/Propel/pull/1054.diff","patch_url":"https://github.com/propelorm/Propel/pull/1054.patch"},"body":"SQL injection\r\n---\r\nWhen constructing a MySQL LIMIT clause, values for the offset and limit are coerced to integers. This prevents arbitrary SQL from being injected via a query limit. Example:\r\n```php\r\nUserQuery::create()->limit('1;DROP TABLE users')->find();\r\n```\r\nPreviously, this would have injected `DROP TABLE users` into the generated SQL. Now, the limit value would be coerced to the integer `1`.\r\n\r\nThis is similar to the [fix for Propel2](https://github.com/propelorm/Propel2/pull/1464).\r\n\r\nFixes #1052\r\n\r\nBuild fixes\r\n---\r\nThese changes also fix errors that occurred during build/test, and also add PHPUnit as a dev dependency instead of forcing contributors to download it separately.\r\n\r\nRelated documentation changes: https://github.com/propelorm/Propel/pull/1055"},"comment":{"url":"https://api.github.com/repos/propelorm/Propel/issues/comments/377397557","html_url":"https://github.com/propelorm/Propel/pull/1054#issuecomment-377397557","issue_url":"https://api.github.com/repos/propelorm/Propel/issues/1054","id":377397557,"user":{"login":"mpetrovich","id":1235062,"avatar_url":"https://avatars2.githubusercontent.com/u/1235062?v=4","gravatar_id":"","url":"https://api.github.com/users/mpetrovich","html_url":"https://github.com/mpetrovich","followers_url":"https://api.github.com/users/mpetrovich/followers","following_url":"https://api.github.com/users/mpetrovich/following{/other_user}","gists_url":"https://api.github.com/users/mpetrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetrovich/subscriptions","organizations_url":"https://api.github.com/users/mpetrovich/orgs","repos_url":"https://api.github.com/users/mpetrovich/repos","events_url":"https://api.github.com/users/mpetrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mpetrovich/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T22:58:15Z","updated_at":"2018-03-29T22:58:15Z","author_association":"NONE","body":"I could use help from the maintainers on figuring out why that unrelated test is failing. Not sure if it's a red herring or a legit failure."}}
{"actor":{"display_login":"mpetrovich"}}