{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/175308234","pull_request_review_id":104815502,"id":175308234,"diff_hunk":"@@ -206,7 +214,14 @@ suite('gearvr-controls', function () {\n       var trackedControls = el.components['tracked-controls'];\n       var applyArmModelSpy = this.sinon.spy(trackedControls, 'applyArmModel');\n       trackedControls.tick();\n-      assert.notOk(applyArmModelSpy.called);\n+\n+      // Verify that the function which applies arm model is not called when disabled.\n+      this.sinon.assert.notCalled(applyArmModelSpy);\n+\n+      // Additionally verify that no other offets have been applied.\n+      assert.strictEqual(el.object3D.position.x, 0);","path":"tests/components/gearvr-controls.test.js","position":164,"original_position":164,"commit_id":"dd092ca08244033e16e50f54591a924823e2701a","original_commit_id":"dd092ca08244033e16e50f54591a924823e2701a","user":{"login":"DigiTec","id":1650078,"avatar_url":"https://avatars2.githubusercontent.com/u/1650078?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiTec","html_url":"https://github.com/DigiTec","followers_url":"https://api.github.com/users/DigiTec/followers","following_url":"https://api.github.com/users/DigiTec/following{/other_user}","gists_url":"https://api.github.com/users/DigiTec/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiTec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiTec/subscriptions","organizations_url":"https://api.github.com/users/DigiTec/orgs","repos_url":"https://api.github.com/users/DigiTec/repos","events_url":"https://api.github.com/users/DigiTec/events{/privacy}","received_events_url":"https://api.github.com/users/DigiTec/received_events","type":"User","site_admin":false},"body":"Added additional verification for the arm model applying.","created_at":"2018-03-18T23:02:05Z","updated_at":"2018-03-18T23:02:05Z","html_url":"https://github.com/aframevr/aframe/pull/3472#discussion_r175308234","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/3472","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/175308234"},"html":{"href":"https://github.com/aframevr/aframe/pull/3472#discussion_r175308234"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3472"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/3472","id":175778809,"html_url":"https://github.com/aframevr/aframe/pull/3472","diff_url":"https://github.com/aframevr/aframe/pull/3472.diff","patch_url":"https://github.com/aframevr/aframe/pull/3472.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/3472","number":3472,"state":"open","locked":false,"title":"Fix for consistent firing of buttonup/down/touchstart/end/buttonchanged","user":{"login":"DigiTec","id":1650078,"avatar_url":"https://avatars2.githubusercontent.com/u/1650078?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiTec","html_url":"https://github.com/DigiTec","followers_url":"https://api.github.com/users/DigiTec/followers","following_url":"https://api.github.com/users/DigiTec/following{/other_user}","gists_url":"https://api.github.com/users/DigiTec/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiTec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiTec/subscriptions","organizations_url":"https://api.github.com/users/DigiTec/orgs","repos_url":"https://api.github.com/users/DigiTec/repos","events_url":"https://api.github.com/users/DigiTec/events{/privacy}","received_events_url":"https://api.github.com/users/DigiTec/received_events","type":"User","site_admin":false},"body":"This change delinks these event streams so that they can fire independenty of one another. I've also added a sufficiently complete number of tests for the new behaior to make sure all events that should be firing are, looking for negative events (ensuring some events don't fire when they should not) and that the values all come through as expected.\r\n\r\nAs part of the fix I've supplied some helpers that are now consistently used in tracked-controls.test.js for verifying individual events and streams of events in a more concise way to avoid duplicating a lot of code.\r\n\r\nI've also made consistent the use of sinon's spy asserts, which were previously using the \".called\" property which reaches into the abstraction further than it should. This also allows us to upgrade certain spy verification's to look for a specific number of calls (calledOnce) which is an overall improvement.\r\n\r\nThis change cascaded into the oculus-touch-controls.test.js and gearvr-controls.test.js as well. For the oculus-touch-controls, this is mostly assert fixups, but also does some additional deep object verification.\r\n\r\nFor the gearvr-controls.test.js this included some bug fixes (using wrong event names) when I was trying to make the test fail and could not, only to realize it wasn't sniffing for the right event names. This is in preparation for creation of the oculus-go-controls component and test suite.\r\n\r\n**Description:**\r\n\r\n**Changes proposed:**\r\n-\r\n-\r\n-\r\n","created_at":"2018-03-18T22:58:58Z","updated_at":"2018-03-18T23:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abdda6409d537e81ab76dd5e7af62ff98da05cce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/3472/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/3472/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/3472/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/dd092ca08244033e16e50f54591a924823e2701a","head":{"label":"DigiTec:tracked-controls-eventstream","ref":"tracked-controls-eventstream","sha":"dd092ca08244033e16e50f54591a924823e2701a","user":{"login":"DigiTec","id":1650078,"avatar_url":"https://avatars2.githubusercontent.com/u/1650078?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiTec","html_url":"https://github.com/DigiTec","followers_url":"https://api.github.com/users/DigiTec/followers","following_url":"https://api.github.com/users/DigiTec/following{/other_user}","gists_url":"https://api.github.com/users/DigiTec/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiTec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiTec/subscriptions","organizations_url":"https://api.github.com/users/DigiTec/orgs","repos_url":"https://api.github.com/users/DigiTec/repos","events_url":"https://api.github.com/users/DigiTec/events{/privacy}","received_events_url":"https://api.github.com/users/DigiTec/received_events","type":"User","site_admin":false},"repo":{"id":125436548,"name":"aframe","full_name":"DigiTec/aframe","owner":{"login":"DigiTec","id":1650078,"avatar_url":"https://avatars2.githubusercontent.com/u/1650078?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiTec","html_url":"https://github.com/DigiTec","followers_url":"https://api.github.com/users/DigiTec/followers","following_url":"https://api.github.com/users/DigiTec/following{/other_user}","gists_url":"https://api.github.com/users/DigiTec/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiTec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiTec/subscriptions","organizations_url":"https://api.github.com/users/DigiTec/orgs","repos_url":"https://api.github.com/users/DigiTec/repos","events_url":"https://api.github.com/users/DigiTec/events{/privacy}","received_events_url":"https://api.github.com/users/DigiTec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DigiTec/aframe","description":":a: web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/DigiTec/aframe","forks_url":"https://api.github.com/repos/DigiTec/aframe/forks","keys_url":"https://api.github.com/repos/DigiTec/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigiTec/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigiTec/aframe/teams","hooks_url":"https://api.github.com/repos/DigiTec/aframe/hooks","issue_events_url":"https://api.github.com/repos/DigiTec/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/DigiTec/aframe/events","assignees_url":"https://api.github.com/repos/DigiTec/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/DigiTec/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/DigiTec/aframe/tags","blobs_url":"https://api.github.com/repos/DigiTec/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigiTec/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigiTec/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigiTec/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigiTec/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/DigiTec/aframe/languages","stargazers_url":"https://api.github.com/repos/DigiTec/aframe/stargazers","contributors_url":"https://api.github.com/repos/DigiTec/aframe/contributors","subscribers_url":"https://api.github.com/repos/DigiTec/aframe/subscribers","subscription_url":"https://api.github.com/repos/DigiTec/aframe/subscription","commits_url":"https://api.github.com/repos/DigiTec/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigiTec/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigiTec/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigiTec/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigiTec/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/DigiTec/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigiTec/aframe/merges","archive_url":"https://api.github.com/repos/DigiTec/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigiTec/aframe/downloads","issues_url":"https://api.github.com/repos/DigiTec/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/DigiTec/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/DigiTec/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/DigiTec/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigiTec/aframe/labels{/name}","releases_url":"https://api.github.com/repos/DigiTec/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/DigiTec/aframe/deployments","created_at":"2018-03-15T23:09:44Z","updated_at":"2018-03-15T23:09:47Z","pushed_at":"2018-03-18T22:57:37Z","git_url":"git://github.com/DigiTec/aframe.git","ssh_url":"git@github.com:DigiTec/aframe.git","clone_url":"https://github.com/DigiTec/aframe.git","svn_url":"https://github.com/DigiTec/aframe","homepage":"https://aframe.io/","size":211160,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"f01be24ca771f03221f45548713b1fb78029a2e2","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":":a: web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2018-03-18T20:46:10Z","pushed_at":"2018-03-18T22:58:59Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":216319,"stargazers_count":7766,"watchers_count":7766,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1796,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1796,"open_issues":254,"watchers":7766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3472"},"html":{"href":"https://github.com/aframevr/aframe/pull/3472"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3472"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3472/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3472/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3472/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/dd092ca08244033e16e50f54591a924823e2701a"}},"author_association":"NONE"}}
{"actor":{"display_login":"DigiTec"}}