{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/4461","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/4461/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/4461/comments","events_url":"https://api.github.com/repos/istio/istio/issues/4461/events","html_url":"https://github.com/istio/istio/pull/4461","id":307638488,"number":4461,"title":"Add multicluster flag enablement to Helm charts","user":{"login":"sdake","id":755849,"avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"assignees":[{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"linsun","id":1588319,"avatar_url":"https://avatars3.githubusercontent.com/u/1588319?v=4","gravatar_id":"","url":"https://api.github.com/users/linsun","html_url":"https://github.com/linsun","followers_url":"https://api.github.com/users/linsun/followers","following_url":"https://api.github.com/users/linsun/following{/other_user}","gists_url":"https://api.github.com/users/linsun/gists{/gist_id}","starred_url":"https://api.github.com/users/linsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linsun/subscriptions","organizations_url":"https://api.github.com/users/linsun/orgs","repos_url":"https://api.github.com/users/linsun/repos","events_url":"https://api.github.com/users/linsun/events{/privacy}","received_events_url":"https://api.github.com/users/linsun/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-03-22T13:17:00Z","updated_at":"2018-03-27T20:14:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4461","html_url":"https://github.com/istio/istio/pull/4461","diff_url":"https://github.com/istio/istio/pull/4461.diff","patch_url":"https://github.com/istio/istio/pull/4461.patch"},"body":"Add a multicluster.enabled flag to values.yaml and the associated\r\nimplementation to the pilot deployment template in the Helm\r\ntemplates.\r\n\r\nI have tested helm template with and without the flag enabled.\r\nWithout the flag set to true, there is no delta between the\r\ntemplates.  With the flag, the appropriate config options are set\r\nin pilot's deployment.\r\n\r\nI didn't bother with the legacy templates as those are going away,\r\nand would need to add a new flag to updateVersion.sh to enable\r\nmulticluster.  Seemed simpler to just let that go away naturally\r\nwith the changes @mandarjog is working on."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/376659600","html_url":"https://github.com/istio/istio/pull/4461#issuecomment-376659600","issue_url":"https://api.github.com/repos/istio/istio/issues/4461","id":376659600,"user":{"login":"istio-merge-robot","id":30445278,"avatar_url":"https://avatars2.githubusercontent.com/u/30445278?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-merge-robot","html_url":"https://github.com/istio-merge-robot","followers_url":"https://api.github.com/users/istio-merge-robot/followers","following_url":"https://api.github.com/users/istio-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/istio-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/istio-merge-robot/orgs","repos_url":"https://api.github.com/users/istio-merge-robot/repos","events_url":"https://api.github.com/users/istio-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/istio-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T20:14:10Z","updated_at":"2018-03-27T20:14:10Z","author_association":"COLLABORATOR","body":"Automatic merge from submit-queue."}}
{"actor":{"display_login":"istio-merge-robot"}}