{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/16434","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/16434/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/16434/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/16434/events","html_url":"https://github.com/dotnet/coreclr/pull/16434","id":298048743,"number":16434,"title":"Inlinable String.Equals for ref equality","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-18T00:39:44Z","updated_at":"2018-02-19T20:19:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/16434","html_url":"https://github.com/dotnet/coreclr/pull/16434","diff_url":"https://github.com/dotnet/coreclr/pull/16434.diff","patch_url":"https://github.com/dotnet/coreclr/pull/16434.patch"},"body":"Allows String.Equals (of all forms) to inline for the null and ref equality parts.\r\n\r\nRemove `case default` inline throw as `StringSpanHelpers.CheckStringComparison` already deals with out of range\r\n\r\nDeduplicate calls to `StringSpanHelpers.CheckStringComparison` and always use it, rather than in some if branches (so the `case default` can be removed)\r\n\r\nAdd `GetCaseCompareOfComparisonCulture` that converts `StringComparison` to `CompareOptions` with a single `&` when comparison is a culture.\r\n\r\nDedupe the calls using it.\r\n\r\nRemove the now other duplicated code (for equals)\r\n\r\nResolves #14320 \r\n\"Consider removing String.IsAscii() fast paths\" as `CompareOrdinalIgnoreCase(ReadOnlySpan<char>,ReadOnlySpan<char>)` has an ascii fast-path in it\r\n\r\nResolves #10293 \"Differences between String.CompareOrdinalIgnoreCaseHelper and CompareInfo.CompareOrdinalIgnoreCase\" by removing the `string` version in consolidation"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/366793777","html_url":"https://github.com/dotnet/coreclr/pull/16434#issuecomment-366793777","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/16434","id":366793777,"user":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T20:19:04Z","updated_at":"2018-02-19T20:19:04Z","author_association":"MEMBER","body":"@dotnet-bot test Windows_NT arm Cross Checked corefx_baseline Build and Test\r\n@dotnet-bot test Windows_NT x64_arm64_altjit Checked corefx_baseline\r\n@dotnet-bot test Ubuntu x64 Checked corefx_baseline\r\n@dotnet-bot test Windows_NT x64 Checked corefx_baseline\r\n@dotnet-bot test Windows_NT x86_arm_altjit Checked corefx_baseline\r\n@dotnet-bot test Windows_NT x86 Checked corefx_baseline"}}
{"actor":{"display_login":"ahsonkhan"}}