{"action":"created","issue":{"url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/137","repository_url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script","labels_url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/137/comments","events_url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/137/events","html_url":"https://github.com/Disassembler0/Win10-Initial-Setup-Script/pull/137","id":365061789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTAxMTgy","number":137,"title":"[Update] Hibernation and Task Manager tweaks","user":{"login":"r3incarnat0r","id":38186974,"node_id":"MDQ6VXNlcjM4MTg2OTc0","avatar_url":"https://avatars3.githubusercontent.com/u/38186974?v=4","gravatar_id":"","url":"https://api.github.com/users/r3incarnat0r","html_url":"https://github.com/r3incarnat0r","followers_url":"https://api.github.com/users/r3incarnat0r/followers","following_url":"https://api.github.com/users/r3incarnat0r/following{/other_user}","gists_url":"https://api.github.com/users/r3incarnat0r/gists{/gist_id}","starred_url":"https://api.github.com/users/r3incarnat0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r3incarnat0r/subscriptions","organizations_url":"https://api.github.com/users/r3incarnat0r/orgs","repos_url":"https://api.github.com/users/r3incarnat0r/repos","events_url":"https://api.github.com/users/r3incarnat0r/events{/privacy}","received_events_url":"https://api.github.com/users/r3incarnat0r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T22:34:05Z","updated_at":"2018-09-29T05:38:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/pulls/137","html_url":"https://github.com/Disassembler0/Win10-Initial-Setup-Script/pull/137","diff_url":"https://github.com/Disassembler0/Win10-Initial-Setup-Script/pull/137.diff","patch_url":"https://github.com/Disassembler0/Win10-Initial-Setup-Script/pull/137.patch"},"body":"DisableHibernation did not work for me, I still had hibernation options in control panel. Proper setup should be imho done by command, which I added to original tweak code. This instantly deletes/creates hiberfil.sys file, too. Also after using command for disabling, the EnableHibernation tweak was not able to reenable it. So I updated both counterparts.\r\n\r\nShowTaskManagerDetails should have some time limit to run (I picked 30 sec.). It happened to me that I was servicing a laptop and the script suddenly stuck on this tweak forever. I couldn't test the update on it as I don't have that particular laptop anymore, but I suspect the loop was waiting for the registry value which was never created. The taskmanager issue was fixed by upgrading Win10 to a new build, but still since then, I can't rely on the loop as there's still potential to stuck in case something goes wrong. So I tried to make this workaround for giving up after specified time."},"comment":{"url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/comments/425617880","html_url":"https://github.com/Disassembler0/Win10-Initial-Setup-Script/pull/137#issuecomment-425617880","issue_url":"https://api.github.com/repos/Disassembler0/Win10-Initial-Setup-Script/issues/137","id":425617880,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTYxNzg4MA==","user":{"login":"Disassembler0","id":5568046,"node_id":"MDQ6VXNlcjU1NjgwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5568046?v=4","gravatar_id":"","url":"https://api.github.com/users/Disassembler0","html_url":"https://github.com/Disassembler0","followers_url":"https://api.github.com/users/Disassembler0/followers","following_url":"https://api.github.com/users/Disassembler0/following{/other_user}","gists_url":"https://api.github.com/users/Disassembler0/gists{/gist_id}","starred_url":"https://api.github.com/users/Disassembler0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Disassembler0/subscriptions","organizations_url":"https://api.github.com/users/Disassembler0/orgs","repos_url":"https://api.github.com/users/Disassembler0/repos","events_url":"https://api.github.com/users/Disassembler0/events{/privacy}","received_events_url":"https://api.github.com/users/Disassembler0/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T05:38:14Z","updated_at":"2018-09-29T05:38:14Z","author_association":"OWNER","body":"`ShowTaskManagerDetails` gets stuck on on 1507 and 1511, because the registry value which the tweak modifies is created only after clean exit of the main window. I didn't want to drag in any P/Invoke magic, so I've just slap there a comment and called it a day. The solution with timeout, although still not clean, is definitely better."}}
{"actor":{"display_login":"Disassembler0"}}