{"action":"created","comment":{"url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/comments/230722999","pull_request_review_id":171520754,"id":230722999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcyMjk5OQ==","diff_hunk":"@@ -38,9 +37,10 @@ export default Ember.Controller.extend({\n   }),\n \n   hasDraftOrder: Ember.computed.alias(\"session.draftOrder\"),\n-  isOrderFulfilmentUser: Ember.computed(function() {\n+  isOrderFulfilmentUser: Ember.computed('session.authToken', function() {\n     let user = this.get('session.currentUser');\n-    return user.hasRole('Order fulfilment');\n+    let isLoggedIn = this.get('session.isLoggedIn');\n+    return user && isLoggedIn ? user.hasRole('Order fulfilment') : false;","path":"app/controllers/item.js","position":17,"original_position":17,"commit_id":"5838602706b31ef4cc38d7b860993622b1e2a5a6","original_commit_id":"5838602706b31ef4cc38d7b860993622b1e2a5a6","user":{"login":"Darshan-Chauhan","id":18572215,"node_id":"MDQ6VXNlcjE4NTcyMjE1","avatar_url":"https://avatars2.githubusercontent.com/u/18572215?v=4","gravatar_id":"","url":"https://api.github.com/users/Darshan-Chauhan","html_url":"https://github.com/Darshan-Chauhan","followers_url":"https://api.github.com/users/Darshan-Chauhan/followers","following_url":"https://api.github.com/users/Darshan-Chauhan/following{/other_user}","gists_url":"https://api.github.com/users/Darshan-Chauhan/gists{/gist_id}","starred_url":"https://api.github.com/users/Darshan-Chauhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darshan-Chauhan/subscriptions","organizations_url":"https://api.github.com/users/Darshan-Chauhan/orgs","repos_url":"https://api.github.com/users/Darshan-Chauhan/repos","events_url":"https://api.github.com/users/Darshan-Chauhan/events{/privacy}","received_events_url":"https://api.github.com/users/Darshan-Chauhan/received_events","type":"User","site_admin":false},"body":"I think we can improve the condition a bit.\r\nUser can't exist without logging in. So if User object is there that means he/she is logged in or is isLoggedIn is true that means User exists.","created_at":"2018-11-05T11:51:09Z","updated_at":"2018-11-05T11:51:10Z","html_url":"https://github.com/crossroads/browse.goodcity/pull/223#discussion_r230722999","pull_request_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/comments/230722999"},"html":{"href":"https://github.com/crossroads/browse.goodcity/pull/223#discussion_r230722999"},"pull_request":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223","id":228302787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzAyNzg3","html_url":"https://github.com/crossroads/browse.goodcity/pull/223","diff_url":"https://github.com/crossroads/browse.goodcity/pull/223.diff","patch_url":"https://github.com/crossroads/browse.goodcity/pull/223.patch","issue_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/223","number":223,"state":"open","locked":false,"title":"Fixed: Inventory Number display issue on Logged out state.","user":{"login":"abulsayyad123","id":37627094,"node_id":"MDQ6VXNlcjM3NjI3MDk0","avatar_url":"https://avatars3.githubusercontent.com/u/37627094?v=4","gravatar_id":"","url":"https://api.github.com/users/abulsayyad123","html_url":"https://github.com/abulsayyad123","followers_url":"https://api.github.com/users/abulsayyad123/followers","following_url":"https://api.github.com/users/abulsayyad123/following{/other_user}","gists_url":"https://api.github.com/users/abulsayyad123/gists{/gist_id}","starred_url":"https://api.github.com/users/abulsayyad123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abulsayyad123/subscriptions","organizations_url":"https://api.github.com/users/abulsayyad123/orgs","repos_url":"https://api.github.com/users/abulsayyad123/repos","events_url":"https://api.github.com/users/abulsayyad123/events{/privacy}","received_events_url":"https://api.github.com/users/abulsayyad123/received_events","type":"User","site_admin":false},"body":"Hi Team,\r\nThis is Fix for the Inventory number display issue in logged out state.\r\nhttps://jira.crossroads.org.hk/browse/GCW-2153?focusedCommentId=31806&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-31806.\r\n\r\nPlease review the PR and let me know if any change is required.\r\nThanks.","created_at":"2018-11-05T10:22:54Z","updated_at":"2018-11-05T11:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a43b21da41f7dc666f296ba9dafe63bf809159ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223/commits","review_comments_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223/comments","review_comment_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/223/comments","statuses_url":"https://api.github.com/repos/crossroads/browse.goodcity/statuses/5838602706b31ef4cc38d7b860993622b1e2a5a6","head":{"label":"crossroads:GCW-2153-inventory-number-bug","ref":"GCW-2153-inventory-number-bug","sha":"5838602706b31ef4cc38d7b860993622b1e2a5a6","user":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":38884704,"node_id":"MDEwOlJlcG9zaXRvcnkzODg4NDcwNA==","name":"browse.goodcity","full_name":"crossroads/browse.goodcity","private":false,"owner":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crossroads/browse.goodcity","description":"GoodCity Web Interface ","fork":false,"url":"https://api.github.com/repos/crossroads/browse.goodcity","forks_url":"https://api.github.com/repos/crossroads/browse.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/browse.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/browse.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/browse.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/browse.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/browse.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/browse.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/browse.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/browse.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/browse.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/browse.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/browse.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/browse.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/browse.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/browse.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/browse.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/browse.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/browse.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/browse.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/browse.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/browse.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/browse.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/browse.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/browse.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/browse.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/browse.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/browse.goodcity/deployments","created_at":"2015-07-10T14:32:07Z","updated_at":"2018-11-05T07:15:08Z","pushed_at":"2018-11-05T10:42:12Z","git_url":"git://github.com/crossroads/browse.goodcity.git","ssh_url":"git@github.com:crossroads/browse.goodcity.git","clone_url":"https://github.com/crossroads/browse.goodcity.git","svn_url":"https://github.com/crossroads/browse.goodcity","homepage":null,"size":5481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"crossroads:master","ref":"master","sha":"78802f522de080cc2f1532416301ae7a9f7d42cd","user":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":38884704,"node_id":"MDEwOlJlcG9zaXRvcnkzODg4NDcwNA==","name":"browse.goodcity","full_name":"crossroads/browse.goodcity","private":false,"owner":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crossroads/browse.goodcity","description":"GoodCity Web Interface ","fork":false,"url":"https://api.github.com/repos/crossroads/browse.goodcity","forks_url":"https://api.github.com/repos/crossroads/browse.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/browse.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/browse.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/browse.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/browse.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/browse.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/browse.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/browse.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/browse.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/browse.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/browse.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/browse.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/browse.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/browse.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/browse.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/browse.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/browse.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/browse.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/browse.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/browse.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/browse.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/browse.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/browse.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/browse.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/browse.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/browse.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/browse.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/browse.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/browse.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/browse.goodcity/deployments","created_at":"2015-07-10T14:32:07Z","updated_at":"2018-11-05T07:15:08Z","pushed_at":"2018-11-05T10:42:12Z","git_url":"git://github.com/crossroads/browse.goodcity.git","ssh_url":"git@github.com:crossroads/browse.goodcity.git","clone_url":"https://github.com/crossroads/browse.goodcity.git","svn_url":"https://github.com/crossroads/browse.goodcity","homepage":null,"size":5481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223"},"html":{"href":"https://github.com/crossroads/browse.goodcity/pull/223"},"issue":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/issues/223"},"comments":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/crossroads/browse.goodcity/statuses/5838602706b31ef4cc38d7b860993622b1e2a5a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Darshan-Chauhan"}}