{"action":"created","comment":{"url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments/178836222","pull_request_review_id":108962437,"id":178836222,"diff_hunk":"@@ -3,27 +3,9 @@ defmodule Mix.Tasks.Preflight do\n \n   @shortdoc \"Checks for necessary ENVARS\"\n   def run(_) do\n-    check_envars()","path":"lib/tasks/preflight.ex","position":4,"original_position":4,"commit_id":"056e2830e9ccd749101a83721530fa9354afb6a0","original_commit_id":"056e2830e9ccd749101a83721530fa9354afb6a0","user":{"login":"vanderhoop","id":4386645,"avatar_url":"https://avatars1.githubusercontent.com/u/4386645?v=4","gravatar_id":"","url":"https://api.github.com/users/vanderhoop","html_url":"https://github.com/vanderhoop","followers_url":"https://api.github.com/users/vanderhoop/followers","following_url":"https://api.github.com/users/vanderhoop/following{/other_user}","gists_url":"https://api.github.com/users/vanderhoop/gists{/gist_id}","starred_url":"https://api.github.com/users/vanderhoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanderhoop/subscriptions","organizations_url":"https://api.github.com/users/vanderhoop/orgs","repos_url":"https://api.github.com/users/vanderhoop/repos","events_url":"https://api.github.com/users/vanderhoop/events{/privacy}","received_events_url":"https://api.github.com/users/vanderhoop/received_events","type":"User","site_admin":false},"body":"I'm not sure about the evaluation order of mix tasks, but it could be that we can switch this to check for the Mix config defining non-empty values, rather than deleting the check outright. Can you check on this to see if it's a viable approach?","created_at":"2018-04-03T14:08:12Z","updated_at":"2018-04-03T14:08:12Z","html_url":"https://github.com/stride-nyc/remote_retro/pull/382#discussion_r178836222","pull_request_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments/178836222"},"html":{"href":"https://github.com/stride-nyc/remote_retro/pull/382#discussion_r178836222"},"pull_request":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382"}}},"pull_request":{"url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382","id":169495527,"html_url":"https://github.com/stride-nyc/remote_retro/pull/382","diff_url":"https://github.com/stride-nyc/remote_retro/pull/382.diff","patch_url":"https://github.com/stride-nyc/remote_retro/pull/382.patch","issue_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/382","number":382,"state":"closed","locked":false,"title":"Update App to use Secrets insted of Env Vars","user":{"login":"nicholalexander","id":212288,"avatar_url":"https://avatars1.githubusercontent.com/u/212288?v=4","gravatar_id":"","url":"https://api.github.com/users/nicholalexander","html_url":"https://github.com/nicholalexander","followers_url":"https://api.github.com/users/nicholalexander/followers","following_url":"https://api.github.com/users/nicholalexander/following{/other_user}","gists_url":"https://api.github.com/users/nicholalexander/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholalexander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholalexander/subscriptions","organizations_url":"https://api.github.com/users/nicholalexander/orgs","repos_url":"https://api.github.com/users/nicholalexander/repos","events_url":"https://api.github.com/users/nicholalexander/events{/privacy}","received_events_url":"https://api.github.com/users/nicholalexander/received_events","type":"User","site_admin":false},"body":"__Description of Change(s) Introduced:__ \r\n\r\nThis seems to fit the recommended pattern for secrets for Phoenix based on this documentation: https://hexdocs.pm/phoenix/deployment.html.\r\n\r\nUpdate the way secrets are loaded in dev to use dev.secrets.exs.  This is imported in the config/dev.exs file.  \r\n\r\nAdd dev.secret.exs.example for easy copying.\r\n\r\nAdd dev.secret.exs to .gitignore.\r\n\r\nUpdate readme to reflect new changes.\r\n\r\n*Removed check_env_vars from Preflight*\r\nThis was no longer necessary, but we might want to have a preflight check in development that screens for the existence of the dev.secret.exs file and gives a similar helpful warning as was in the env var check method.\r\n\r\n## Important:\r\n*Change google client to use Application env instead of System Env.*\r\nThis would probably break production deployments as it is because any production deployments would have already set up the vars in the environment and not in the application.  If we want to make this change, we should consider how to address this!\r\n\r\nThanks!\r\nnichol & laura\r\n\r\ntagging: @laumontemayor\r\n","created_at":"2018-02-15T21:54:07Z","updated_at":"2018-04-03T14:08:12Z","closed_at":"2018-02-17T18:05:14Z","merged_at":null,"merge_commit_sha":"78cd05aa6d39d8ea1ffe26e9790852fd8848b6e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382/commits","review_comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382/comments","review_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/382/comments","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/056e2830e9ccd749101a83721530fa9354afb6a0","head":{"label":"stride-nyc:secrets","ref":"secrets","sha":"056e2830e9ccd749101a83721530fa9354afb6a0","user":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"repo":{"id":76188623,"name":"remote_retro","full_name":"stride-nyc/remote_retro","owner":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stride-nyc/remote_retro","description":"A real-time application for conducting Agile retrospectives with distributed teams","fork":false,"url":"https://api.github.com/repos/stride-nyc/remote_retro","forks_url":"https://api.github.com/repos/stride-nyc/remote_retro/forks","keys_url":"https://api.github.com/repos/stride-nyc/remote_retro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stride-nyc/remote_retro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stride-nyc/remote_retro/teams","hooks_url":"https://api.github.com/repos/stride-nyc/remote_retro/hooks","issue_events_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/events{/number}","events_url":"https://api.github.com/repos/stride-nyc/remote_retro/events","assignees_url":"https://api.github.com/repos/stride-nyc/remote_retro/assignees{/user}","branches_url":"https://api.github.com/repos/stride-nyc/remote_retro/branches{/branch}","tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/tags","blobs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/refs{/sha}","trees_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/{sha}","languages_url":"https://api.github.com/repos/stride-nyc/remote_retro/languages","stargazers_url":"https://api.github.com/repos/stride-nyc/remote_retro/stargazers","contributors_url":"https://api.github.com/repos/stride-nyc/remote_retro/contributors","subscribers_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscribers","subscription_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscription","commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/commits{/sha}","git_commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/commits{/sha}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/comments{/number}","issue_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/comments{/number}","contents_url":"https://api.github.com/repos/stride-nyc/remote_retro/contents/{+path}","compare_url":"https://api.github.com/repos/stride-nyc/remote_retro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stride-nyc/remote_retro/merges","archive_url":"https://api.github.com/repos/stride-nyc/remote_retro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stride-nyc/remote_retro/downloads","issues_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues{/number}","pulls_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls{/number}","milestones_url":"https://api.github.com/repos/stride-nyc/remote_retro/milestones{/number}","notifications_url":"https://api.github.com/repos/stride-nyc/remote_retro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stride-nyc/remote_retro/labels{/name}","releases_url":"https://api.github.com/repos/stride-nyc/remote_retro/releases{/id}","deployments_url":"https://api.github.com/repos/stride-nyc/remote_retro/deployments","created_at":"2016-12-11T17:21:02Z","updated_at":"2018-04-02T15:37:37Z","pushed_at":"2018-04-02T21:50:44Z","git_url":"git://github.com/stride-nyc/remote_retro.git","ssh_url":"git@github.com:stride-nyc/remote_retro.git","clone_url":"https://github.com/stride-nyc/remote_retro.git","svn_url":"https://github.com/stride-nyc/remote_retro","homepage":"https://remoteretro.org/","size":3222,"stargazers_count":178,"watchers_count":178,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":35,"watchers":178,"default_branch":"master"}},"base":{"label":"stride-nyc:master","ref":"master","sha":"68ccd44cf11eac2d0776b333f8f1f7fc380342b9","user":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"repo":{"id":76188623,"name":"remote_retro","full_name":"stride-nyc/remote_retro","owner":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stride-nyc/remote_retro","description":"A real-time application for conducting Agile retrospectives with distributed teams","fork":false,"url":"https://api.github.com/repos/stride-nyc/remote_retro","forks_url":"https://api.github.com/repos/stride-nyc/remote_retro/forks","keys_url":"https://api.github.com/repos/stride-nyc/remote_retro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stride-nyc/remote_retro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stride-nyc/remote_retro/teams","hooks_url":"https://api.github.com/repos/stride-nyc/remote_retro/hooks","issue_events_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/events{/number}","events_url":"https://api.github.com/repos/stride-nyc/remote_retro/events","assignees_url":"https://api.github.com/repos/stride-nyc/remote_retro/assignees{/user}","branches_url":"https://api.github.com/repos/stride-nyc/remote_retro/branches{/branch}","tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/tags","blobs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/refs{/sha}","trees_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/{sha}","languages_url":"https://api.github.com/repos/stride-nyc/remote_retro/languages","stargazers_url":"https://api.github.com/repos/stride-nyc/remote_retro/stargazers","contributors_url":"https://api.github.com/repos/stride-nyc/remote_retro/contributors","subscribers_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscribers","subscription_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscription","commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/commits{/sha}","git_commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/commits{/sha}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/comments{/number}","issue_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/comments{/number}","contents_url":"https://api.github.com/repos/stride-nyc/remote_retro/contents/{+path}","compare_url":"https://api.github.com/repos/stride-nyc/remote_retro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stride-nyc/remote_retro/merges","archive_url":"https://api.github.com/repos/stride-nyc/remote_retro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stride-nyc/remote_retro/downloads","issues_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues{/number}","pulls_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls{/number}","milestones_url":"https://api.github.com/repos/stride-nyc/remote_retro/milestones{/number}","notifications_url":"https://api.github.com/repos/stride-nyc/remote_retro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stride-nyc/remote_retro/labels{/name}","releases_url":"https://api.github.com/repos/stride-nyc/remote_retro/releases{/id}","deployments_url":"https://api.github.com/repos/stride-nyc/remote_retro/deployments","created_at":"2016-12-11T17:21:02Z","updated_at":"2018-04-02T15:37:37Z","pushed_at":"2018-04-02T21:50:44Z","git_url":"git://github.com/stride-nyc/remote_retro.git","ssh_url":"git@github.com:stride-nyc/remote_retro.git","clone_url":"https://github.com/stride-nyc/remote_retro.git","svn_url":"https://github.com/stride-nyc/remote_retro","homepage":"https://remoteretro.org/","size":3222,"stargazers_count":178,"watchers_count":178,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":35,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382"},"html":{"href":"https://github.com/stride-nyc/remote_retro/pull/382"},"issue":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/issues/382"},"comments":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/056e2830e9ccd749101a83721530fa9354afb6a0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"vanderhoop"}}