{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/graphing-lines/issues/101","repository_url":"https://api.github.com/repos/phetsims/graphing-lines","labels_url":"https://api.github.com/repos/phetsims/graphing-lines/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/graphing-lines/issues/101/comments","events_url":"https://api.github.com/repos/phetsims/graphing-lines/issues/101/events","html_url":"https://github.com/phetsims/graphing-lines/issues/101","id":376997379,"node_id":"MDU6SXNzdWUzNzY5OTczNzk=","number":101,"title":"simplify equation Nodes","user":{"login":"pixelzoom","id":3046552,"node_id":"MDQ6VXNlcjMwNDY1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"pixelzoom","id":3046552,"node_id":"MDQ6VXNlcjMwNDY1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"assignees":[{"login":"pixelzoom","id":3046552,"node_id":"MDQ6VXNlcjMwNDY1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-02T23:26:20Z","updated_at":"2018-11-02T23:43:04Z","closed_at":"2018-11-02T23:43:04Z","author_association":"CONTRIBUTOR","body":"There are currently 3 types that display equations: \r\n\r\n* `SlopeEquationNode` - slope form\r\n* `SlopeInterceptEquationNode` - slope-intercept form\r\n* `PointSlopeEquationNode` - point-slope form\r\n\r\nEach of those types is responsible for displaying 3 variations of it's equation form:\r\n\r\n* general form (at the top of the accordion box)\r\n* interactive form (which includes pickers)\r\n* simplified form (used to label lines on the graph)\r\n\r\nAll 3 variations are handled in one very complicated constructor.   And that makes changes like #97 costly.\r\n\r\nThe code would be simpler and more maintainable if we changed to the approach used in Graphing Quadratics, where the 3 variations are handled by separate types. \r\n\r\nFor example, in Graphing Quadratic's, the 3 variations of vertex form are handled by:\r\n\r\n* general form: `VertexFormEquationNode`\r\n* interactive form: `VertexFormInteractiveEquationNode`\r\n* simplified form: `GQEquationFactory.createVertexForm`\r\n\r\nThis would essentially be a rewrite, and would probably take 4-6 hours."},"comment":{"url":"https://api.github.com/repos/phetsims/graphing-lines/issues/comments/435539960","html_url":"https://github.com/phetsims/graphing-lines/issues/101#issuecomment-435539960","issue_url":"https://api.github.com/repos/phetsims/graphing-lines/issues/101","id":435539960,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTUzOTk2MA==","user":{"login":"pixelzoom","id":3046552,"node_id":"MDQ6VXNlcjMwNDY1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T23:43:04Z","updated_at":"2018-11-02T23:43:04Z","author_association":"CONTRIBUTOR","body":"Ah... Equation instances on lines are dynamically updated in Graphing Lines, while new instances are created in Graphing Quadratics.  That and the game requirements i cause for reconsideration.  I think I'll put the lid back on this can of worms.  Closing."}}
{"actor":{"display_login":"pixelzoom"}}