{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/154","repository_url":"https://api.github.com/repos/OCA/l10n-netherlands","labels_url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/154/comments","events_url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/154/events","html_url":"https://github.com/OCA/l10n-netherlands/pull/154","id":302601174,"number":154,"title":"[FIX] l10n_nl_xaf_auditfile_export: fix rounding issues","user":{"login":"Yenthe666","id":6352350,"avatar_url":"https://avatars3.githubusercontent.com/u/6352350?v=4","gravatar_id":"","url":"https://api.github.com/users/Yenthe666","html_url":"https://github.com/Yenthe666","followers_url":"https://api.github.com/users/Yenthe666/followers","following_url":"https://api.github.com/users/Yenthe666/following{/other_user}","gists_url":"https://api.github.com/users/Yenthe666/gists{/gist_id}","starred_url":"https://api.github.com/users/Yenthe666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yenthe666/subscriptions","organizations_url":"https://api.github.com/users/Yenthe666/orgs","repos_url":"https://api.github.com/users/Yenthe666/repos","events_url":"https://api.github.com/users/Yenthe666/events{/privacy}","received_events_url":"https://api.github.com/users/Yenthe666/received_events","type":"User","site_admin":false},"labels":[{"id":153054212,"url":"https://api.github.com/repos/OCA/l10n-netherlands/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OCA/l10n-netherlands/milestones/5","html_url":"https://github.com/OCA/l10n-netherlands/milestone/5","labels_url":"https://api.github.com/repos/OCA/l10n-netherlands/milestones/5/labels","id":2810667,"number":5,"title":"11.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":6,"state":"open","created_at":"2017-10-03T14:42:58Z","updated_at":"2018-03-07T14:18:42Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-03-06T08:09:35Z","updated_at":"2018-03-07T18:55:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OCA/l10n-netherlands/pulls/154","html_url":"https://github.com/OCA/l10n-netherlands/pull/154","diff_url":"https://github.com/OCA/l10n-netherlands/pull/154.diff","patch_url":"https://github.com/OCA/l10n-netherlands/pull/154.patch"},"body":"Before this fix you will get both an error on the `totalCredit` and `totalDebit` when the result of one of those two has a bigger decimal precision than 2. For an example customer we would get this traceback:\r\n```\r\n:18296:0:ERROR:SCHEMASV:SCHEMAV_CVC_FRACTIONDIGITS_VALID: Element '{http://www.auditfiles.nl/XAF/3.2}totalCredit': [facet 'fractionDigits'] The value '1207618.6192' has more fractional digits than are allowed ('2').\r\n\r\n:18296:0:ERROR:SCHEMASV:SCHEMAV_CVC_DATATYPE_VALID_1_2_1: Element '{http://www.auditfiles.nl/XAF/3.2}totalCredit': '1207618.6192' is not a valid value of the atomic type '{http://www.auditfiles.nl/XAF/3.2}Amount2decimals'. \r\n```\r\n\r\nBy rounding the returned SQL values we're always sure the precision is 2 and not something like 4.\r\nThis fixes two issues at once. I'm just not sure if we should do it with a round and precision 2 on the return or with a round in the SQL query."},"comment":{"url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/comments/371245037","html_url":"https://github.com/OCA/l10n-netherlands/pull/154#issuecomment-371245037","issue_url":"https://api.github.com/repos/OCA/l10n-netherlands/issues/154","id":371245037,"user":{"login":"Yenthe666","id":6352350,"avatar_url":"https://avatars3.githubusercontent.com/u/6352350?v=4","gravatar_id":"","url":"https://api.github.com/users/Yenthe666","html_url":"https://github.com/Yenthe666","followers_url":"https://api.github.com/users/Yenthe666/followers","following_url":"https://api.github.com/users/Yenthe666/following{/other_user}","gists_url":"https://api.github.com/users/Yenthe666/gists{/gist_id}","starred_url":"https://api.github.com/users/Yenthe666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yenthe666/subscriptions","organizations_url":"https://api.github.com/users/Yenthe666/orgs","repos_url":"https://api.github.com/users/Yenthe666/repos","events_url":"https://api.github.com/users/Yenthe666/events{/privacy}","received_events_url":"https://api.github.com/users/Yenthe666/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T18:55:51Z","updated_at":"2018-03-07T18:55:51Z","author_association":"NONE","body":"Yep, agreed. So what more do I need to get this merged guys? Or should I still change it to the currency_id round? "}}
{"actor":{"display_login":"Yenthe666"}}