{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/216480494","pull_request_review_id":153972481,"id":216480494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ4MDQ5NA==","diff_hunk":"@@ -2686,6 +2686,7 @@ bool CChainState::ActivateBestChain(CValidationState &state, const CChainParams&\n \n         {\n             LOCK(cs_main);\n+            LOCK(::mempool.cs);","path":"src/validation.cpp","position":31,"original_position":31,"commit_id":"fa3e0471a81252e333886b97d8d33bb275061d42","original_commit_id":"fa3e0471a81252e333886b97d8d33bb275061d42","user":{"login":"practicalswift","id":7826565,"node_id":"MDQ6VXNlcjc4MjY1NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7826565?v=4","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"body":"Nit: `LOCK2(cs_main, ::mempool.cs);`","created_at":"2018-09-10T21:34:05Z","updated_at":"2018-09-10T21:34:05Z","html_url":"https://github.com/bitcoin/bitcoin/pull/14193#discussion_r216480494","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/216480494"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14193#discussion_r216480494"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193","id":214446561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDQ2NTYx","html_url":"https://github.com/bitcoin/bitcoin/pull/14193","diff_url":"https://github.com/bitcoin/bitcoin/pull/14193.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14193.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14193","number":14193,"state":"open","locked":false,"title":"validation: Add missing mempool locks","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"Take the mempool read lock during reorgs, so that we don't accidentally read an inconsistent mempool.","created_at":"2018-09-10T21:15:43Z","updated_at":"2018-09-10T21:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0665b0591e1327824cbf4d4793fd04f4fe7f3f49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118379652,"node_id":"MDU6TGFiZWwxMTgzNzk2NTI=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14193/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa3e0471a81252e333886b97d8d33bb275061d42","head":{"label":"MarcoFalke:Mf1809-valLocksMempool","ref":"Mf1809-valLocksMempool","sha":"fa3e0471a81252e333886b97d8d33bb275061d42","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"repo":{"id":40046254,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA0NjI1NA==","name":"bitcoin","full_name":"MarcoFalke/bitcoin","owner":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoFalke/bitcoin","description":"Development fork of https://github.com/bitcoin/bitcoin","fork":true,"url":"https://api.github.com/repos/MarcoFalke/bitcoin","forks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/forks","keys_url":"https://api.github.com/repos/MarcoFalke/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoFalke/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoFalke/bitcoin/teams","hooks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/events","assignees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoFalke/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/tags","blobs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoFalke/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoFalke/bitcoin/languages","stargazers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscription","commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoFalke/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoFalke/bitcoin/merges","archive_url":"https://api.github.com/repos/MarcoFalke/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoFalke/bitcoin/downloads","issues_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoFalke/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoFalke/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoFalke/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoFalke/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MarcoFalke/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/deployments","created_at":"2015-08-01T12:42:47Z","updated_at":"2018-09-10T18:05:31Z","pushed_at":"2018-09-10T21:07:20Z","git_url":"git://github.com/MarcoFalke/bitcoin.git","ssh_url":"git@github.com:MarcoFalke/bitcoin.git","clone_url":"https://github.com/MarcoFalke/bitcoin.git","svn_url":"https://github.com/MarcoFalke/bitcoin","homepage":"","size":103453,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"eb2f1bd276108e70aff0f582a407e9b702eb4dd1","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-09-10T21:22:25Z","pushed_at":"2018-09-10T21:29:04Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":113528,"stargazers_count":34600,"watchers_count":34600,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20940,"mirror_url":null,"archived":false,"open_issues_count":834,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20940,"open_issues":834,"watchers":34600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14193"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14193"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14193/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14193/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa3e0471a81252e333886b97d8d33bb275061d42"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"practicalswift"}}