{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/195517891","pull_request_review_id":128903821,"id":195517891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUxNzg5MQ==","diff_hunk":"@@ -228,7 +229,14 @@ public T removeExtendedAcl() {\n    */\n   public T removeAcl(List<AclEntry> entries) throws IOException {\n     for (AclEntry entry : entries) {\n-      mAcl.removeEntry(entry);\n+      if (entry.isDefault()) {\n+        AccessControlList defaultAcl = getDefaultACL();\n+        if (defaultAcl != null) {","path":"core/server/master/src/main/java/alluxio/master/file/meta/Inode.java","position":15,"original_position":15,"commit_id":"ffe0230c17be46c1c92f8703289da927b0c9eb4d","original_commit_id":"ffe0230c17be46c1c92f8703289da927b0c9eb4d","user":{"login":"yuzhu","id":736171,"node_id":"MDQ6VXNlcjczNjE3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/736171?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzhu","html_url":"https://github.com/yuzhu","followers_url":"https://api.github.com/users/yuzhu/followers","following_url":"https://api.github.com/users/yuzhu/following{/other_user}","gists_url":"https://api.github.com/users/yuzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzhu/subscriptions","organizations_url":"https://api.github.com/users/yuzhu/orgs","repos_url":"https://api.github.com/users/yuzhu/repos","events_url":"https://api.github.com/users/yuzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzhu/received_events","type":"User","site_admin":false},"body":"not any more, deleted.","created_at":"2018-06-14T18:01:18Z","updated_at":"2018-06-14T18:01:18Z","html_url":"https://github.com/Alluxio/alluxio/pull/7382#discussion_r195517891","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/195517891"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7382#discussion_r195517891"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382"}},"in_reply_to_id":195439985},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382","id":194183056,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTgzMDU2","html_url":"https://github.com/Alluxio/alluxio/pull/7382","diff_url":"https://github.com/Alluxio/alluxio/pull/7382.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7382.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7382","number":7382,"state":"open","locked":false,"title":"[WIP] default facl implementation","user":{"login":"yuzhu","id":736171,"node_id":"MDQ6VXNlcjczNjE3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/736171?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzhu","html_url":"https://github.com/yuzhu","followers_url":"https://api.github.com/users/yuzhu/followers","following_url":"https://api.github.com/users/yuzhu/following{/other_user}","gists_url":"https://api.github.com/users/yuzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzhu/subscriptions","organizations_url":"https://api.github.com/users/yuzhu/orgs","repos_url":"https://api.github.com/users/yuzhu/repos","events_url":"https://api.github.com/users/yuzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzhu/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-12T06:58:58Z","updated_at":"2018-06-14T18:01:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fdd18e82ef02e17cab96472b8da624960cef71e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7382/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/ffe0230c17be46c1c92f8703289da927b0c9eb4d","head":{"label":"yuzhu:defaultfacl","ref":"defaultfacl","sha":"ffe0230c17be46c1c92f8703289da927b0c9eb4d","user":{"login":"yuzhu","id":736171,"node_id":"MDQ6VXNlcjczNjE3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/736171?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzhu","html_url":"https://github.com/yuzhu","followers_url":"https://api.github.com/users/yuzhu/followers","following_url":"https://api.github.com/users/yuzhu/following{/other_user}","gists_url":"https://api.github.com/users/yuzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzhu/subscriptions","organizations_url":"https://api.github.com/users/yuzhu/orgs","repos_url":"https://api.github.com/users/yuzhu/repos","events_url":"https://api.github.com/users/yuzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzhu/received_events","type":"User","site_admin":false},"repo":{"id":127950526,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NTA1MjY=","name":"alluxio","full_name":"yuzhu/alluxio","owner":{"login":"yuzhu","id":736171,"node_id":"MDQ6VXNlcjczNjE3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/736171?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzhu","html_url":"https://github.com/yuzhu","followers_url":"https://api.github.com/users/yuzhu/followers","following_url":"https://api.github.com/users/yuzhu/following{/other_user}","gists_url":"https://api.github.com/users/yuzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzhu/subscriptions","organizations_url":"https://api.github.com/users/yuzhu/orgs","repos_url":"https://api.github.com/users/yuzhu/repos","events_url":"https://api.github.com/users/yuzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuzhu/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/yuzhu/alluxio","forks_url":"https://api.github.com/repos/yuzhu/alluxio/forks","keys_url":"https://api.github.com/repos/yuzhu/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzhu/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzhu/alluxio/teams","hooks_url":"https://api.github.com/repos/yuzhu/alluxio/hooks","issue_events_url":"https://api.github.com/repos/yuzhu/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/yuzhu/alluxio/events","assignees_url":"https://api.github.com/repos/yuzhu/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/yuzhu/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/yuzhu/alluxio/tags","blobs_url":"https://api.github.com/repos/yuzhu/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzhu/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzhu/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzhu/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzhu/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzhu/alluxio/languages","stargazers_url":"https://api.github.com/repos/yuzhu/alluxio/stargazers","contributors_url":"https://api.github.com/repos/yuzhu/alluxio/contributors","subscribers_url":"https://api.github.com/repos/yuzhu/alluxio/subscribers","subscription_url":"https://api.github.com/repos/yuzhu/alluxio/subscription","commits_url":"https://api.github.com/repos/yuzhu/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzhu/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzhu/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzhu/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzhu/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/yuzhu/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzhu/alluxio/merges","archive_url":"https://api.github.com/repos/yuzhu/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzhu/alluxio/downloads","issues_url":"https://api.github.com/repos/yuzhu/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/yuzhu/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzhu/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzhu/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzhu/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/yuzhu/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/yuzhu/alluxio/deployments","created_at":"2018-04-03T18:21:37Z","updated_at":"2018-04-03T18:21:45Z","pushed_at":"2018-06-14T00:12:21Z","git_url":"git://github.com/yuzhu/alluxio.git","ssh_url":"git@github.com:yuzhu/alluxio.git","clone_url":"https://github.com/yuzhu/alluxio.git","svn_url":"https://github.com/yuzhu/alluxio","homepage":"http://www.alluxio.org/","size":89155,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:facl","ref":"facl","sha":"b0b5ecb2777edd40038d44b8e65491ce5f772985","user":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2OTU0","name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-06-14T17:03:18Z","pushed_at":"2018-06-14T17:03:12Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":89385,"stargazers_count":3526,"watchers_count":3526,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1908,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1908,"open_issues":23,"watchers":3526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7382"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7382"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7382/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7382/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/ffe0230c17be46c1c92f8703289da927b0c9eb4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yuzhu"}}