{"action":"created","issue":{"url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/31","repository_url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler","labels_url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/31/comments","events_url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/31/events","html_url":"https://github.com/07th-mod/higurashi-patch-compiler/issues/31","id":295012294,"number":31,"title":"Current status and the future","user":{"login":"enumag","id":539462,"avatar_url":"https://avatars3.githubusercontent.com/u/539462?v=4","gravatar_id":"","url":"https://api.github.com/users/enumag","html_url":"https://github.com/enumag","followers_url":"https://api.github.com/users/enumag/followers","following_url":"https://api.github.com/users/enumag/following{/other_user}","gists_url":"https://api.github.com/users/enumag/gists{/gist_id}","starred_url":"https://api.github.com/users/enumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enumag/subscriptions","organizations_url":"https://api.github.com/users/enumag/orgs","repos_url":"https://api.github.com/users/enumag/repos","events_url":"https://api.github.com/users/enumag/events{/privacy}","received_events_url":"https://api.github.com/users/enumag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-02-07T05:33:21Z","updated_at":"2018-02-07T14:08:14Z","closed_at":null,"author_association":"OWNER","body":"cc @ItaloKnox @DoctorDiablo @Grelo @jwgrlrrajn @irlPM @InochiPM @Nozoki17\r\n\r\nSo as you might have noticed, [P-Chang left us](https://github.com/07th-mod/higurashi-patch-compiler/issues/30). He left suddenly without giving us guidelines how to so the things he did for us until now while also thoroughly deleting all resources he made in the past. I'm creating this issue to summarize what he was doing and the consequences of him leaving us.\r\n\r\nFirst of all with the efforts of some of our members, things are already moving very fast now. Keep in mind that some of the problems I'm posting here might already be solved by the time I finish writing this or a few hours later.\r\n\r\n# Current status\r\n\r\n## DLL hacking\r\n\r\nSo the main thing P-Chang was doing for us was DLL hacking. Over time he made many changes in the DLL which I'll try to summarize here.\r\n\r\n1. Global flags `GADVMode` and `GLinemodeSp` for NVL/ADV mode. This fixed several ADV-mode issues we had in our old releases.\r\n2. A hotkey (`F1`) to switch between NVL/ADV mode.\r\n3. Fixes to `Line_*` modifiers in the scripts in order to fix voice sync. This allowed the game to be playable in auto-mode without continuing while a voice was playing and also fixed other issues we had.\r\n4. `ModEnableNVLModeInADVMode()` function to force a part of a game to be in NVL mode even for ADV mode users. Used in Tatarigoroshi epilogue.\r\n5. Fixed save screen.\r\n6. Fixed position of buttons.\r\n7. Global flag `GCensor` for content censoring level along with hotkey.\r\n8. Hotkeys for Quick Save / Quick Load.\r\n9. Hotkeys to increase / decrease voice volume.\r\n10. In game help of available flags and hotkeys.\r\n11. Fixed the `<i>` tag so that we can use italics in the game without them looking awful.\r\n12. Many other flags, hotkeys and changes. Most of them were just his ideas and we never actually used them. An incomplete list is available [here](https://github.com/07th-mod/higurashi-patch-compiler/wiki/Notes).\r\n13. And finally of course the LipSync which is available in out Onikakushi 5.0 pre-release.\r\n\r\nSo yeah that's a really big list of important features and bugfixes. And it's not even a complete list. I'm pretty sure I forgot something important here. **All of these features are lost for future chapters unless we figure out how to decompile, edit and recompile the DLLs.** Italo is already busy trying to achieve that, I'm sure he will post his findings soon. The latest news I have now is that he was able to decompile the DLL so we should be able to make diff between vanilla DLL and the last hacked DLL.\r\n\r\nNote: I believe P-Chang was using [this decomiler](https://www.telerik.com/products/decompiler.aspx).\r\n\r\nEDIT: And apparently he also used [this tool](https://github.com/0xd4d/dnSpy).\r\n\r\n## LipSync\r\n\r\nLipSync was not even implemented for other chapters than Onikakushi yet and in Onikakushi it was experimental. Also the LipSync involved spectrum files which made the LipSync truly awesome - it basically stopped the mouth movement when the voice paused for a moment. It works really good in the game. ~~Sadly we have lost the spectrum files for PS3 voices. We still have spectrum files for PS2 voices available which should mostly be the same as PS3 but we're not yet sure what kind of effect this will have on the LipSync feature and we're missing the spectrum files for all PS3-specific voices.~~ **EDIT: PS3 spectrum files were saved thanks to @EliEron.** We have no idea whatsoever how the spectrum files were made either - P-Chang wrote some analyzer for that but never shared it with us. Anyway this is all irrelevant unless we figure out how to decompile the LipSync feature from his last DLL and put it into the other chapters.\r\n\r\n## New UI\r\n\r\nAnother thing is that we don't know is how to unpack and repack the assets files that contain the UI images. I have no idea what he used to do this. Any takers?\r\n\r\nEDIT: Apparently P-Chang was using [this editor](https://7daystodie.com/forums/showthread.php?22675-Unity-Assets-Bundle-Extractor). thx @InochiPM\r\n\r\n## New graphics patches\r\n\r\nMost of P-Chang's work on renaming the backgrounds and sprites for the new graphics patches has been lost as well. I don't remember which chapters he worked on but we'll find that out soon. Anyway this should be easy to remake even although a bit time consuming. Italo has some program to do it quickly though.\r\n\r\n## Advanced script changes\r\n\r\nP-Chang was also able to do some advanced changed in the game scripts like moving backgrounds. These changes required deeper knowledge of the available functions. It should be doable with the decompiled DLL but still it won't be easy for us.\r\n\r\n# New policy\r\n\r\nAll the features we were working on are hereby postponed until we solve this. Feel free to post your ideas and WIP files here on GitHub but be careful to make a separate issue for everything. I promise we'll get back to it after we sort this out but we might easily skip anything that isn't in a separate issue.\r\n\r\nSome of you might remember that I mentioned somewhere here on GitHub that I want us to document everything we're doing. It was exactly because I was paranoid enough to expect something like this to happen sooner or later. Well apparently I failed to execute this initiative in time - I prioritized LipSync and new graphics patches instead and this is the result. The plan was to document everything while developing Tsumihoroboshi patch. In a way P-Chang left us at the worst time possible - right before we could put this initiative into motion.\r\n\r\nOf course this initiative to make the project future proof and independent on any individual (myself and Italo included) is now more important than ever. Obviously this has start with Italo and myself - we need to write down everything we know about making these patches - voice insertion, installers, all the scripts I have in this repo etc. These guides will be further improved while we work on Tsumihoroboshi (note that Tsumi patch might also be delayed too because of this depending on when it will be released).\r\n\r\n**This also means some changes to our policy with accepting ideas and changes. The proposal is to only accept changes that can be reproduced later without the original author. Anyone can still come up with and suggest anything they want of course but from now on I think we should only accept changes with all the PSD files, photoshop filters, fonts, scripts and any other resources used to achieve the changes. In more complicated cases a written guide how to use those resources could be needed as well. There should be no exceptions to the new policy, not even for Italo or myself.**\r\n\r\n**Please give us your feedback and ideas about this proposed new policy and how strict we should be with the rules in your opinion.** The goal is for anyone to be able to continue our work in case we're unwilling or unable to continue for whatever reason.\r\n\r\n**We also want to ask you to send us any files related to your previous contributions that you have on your harddrives and share your notes how to use them.**\r\n\r\n# Future\r\n\r\nAside from documenting everything the top priority now is to recreate what P-Chang was doing until now, mainly all the important DLL hacks. The goal is to have decompiled source code with documentation about all the hacks as well as a written guide on hot to decompile and recompile the dlls. **If you think you can help with this task or know someone who could teach us how to decompile and recompile the C# library, please let us know.**\r\n\r\n**Another thing I want to make is that I think we should write down a full list of features our patch provides compared to the vanilla version (by now it will be quite long). This list should include credits to people who contributed or later improved the change and link to guide how to make the change.**\r\n\r\nPlease give us your feedback on this and your support. We need all the motivation we can get from your support and all the help you can give us. Many thanks to all contributors, we're looking forward to working with all of you in the future. We believe that together we can overcome this and make our patches better than ever.\r\n\r\nThanks for reading.\r\n"},"comment":{"url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/comments/363779435","html_url":"https://github.com/07th-mod/higurashi-patch-compiler/issues/31#issuecomment-363779435","issue_url":"https://api.github.com/repos/07th-mod/higurashi-patch-compiler/issues/31","id":363779435,"user":{"login":"Grelo","id":22790067,"avatar_url":"https://avatars1.githubusercontent.com/u/22790067?v=4","gravatar_id":"","url":"https://api.github.com/users/Grelo","html_url":"https://github.com/Grelo","followers_url":"https://api.github.com/users/Grelo/followers","following_url":"https://api.github.com/users/Grelo/following{/other_user}","gists_url":"https://api.github.com/users/Grelo/gists{/gist_id}","starred_url":"https://api.github.com/users/Grelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grelo/subscriptions","organizations_url":"https://api.github.com/users/Grelo/orgs","repos_url":"https://api.github.com/users/Grelo/repos","events_url":"https://api.github.com/users/Grelo/events{/privacy}","received_events_url":"https://api.github.com/users/Grelo/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T14:08:13Z","updated_at":"2018-02-07T14:08:13Z","author_association":"NONE","body":"@enumag  The other problem is graphic patch for Tsumihoroboshi chapter once it is released.\r\nI could do it like with previous chapters but the problem is with so many changes you did with P-Chang to the script i think i would only make your future polish on it difficult. So what now...."}}
{"actor":{"display_login":"Grelo"}}