{"action":"opened","number":487,"pull_request":{"url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487","id":212828687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODI4Njg3","html_url":"https://github.com/UCLALibrary/libraryweb-site/pull/487","diff_url":"https://github.com/UCLALibrary/libraryweb-site/pull/487.diff","patch_url":"https://github.com/UCLALibrary/libraryweb-site/pull/487.patch","issue_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/487","number":487,"state":"open","locked":false,"title":"DRUP-1084: views more links","user":{"login":"jameswilson","id":243532,"node_id":"MDQ6VXNlcjI0MzUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/243532?v=4","gravatar_id":"","url":"https://api.github.com/users/jameswilson","html_url":"https://github.com/jameswilson","followers_url":"https://api.github.com/users/jameswilson/followers","following_url":"https://api.github.com/users/jameswilson/following{/other_user}","gists_url":"https://api.github.com/users/jameswilson/gists{/gist_id}","starred_url":"https://api.github.com/users/jameswilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameswilson/subscriptions","organizations_url":"https://api.github.com/users/jameswilson/orgs","repos_url":"https://api.github.com/users/jameswilson/repos","events_url":"https://api.github.com/users/jameswilson/events{/privacy}","received_events_url":"https://api.github.com/users/jameswilson/received_events","type":"User","site_admin":false},"body":"This PR fixes the broken \"more\" links on the News tab on Destinations and Locations:\r\n\r\nSteps to review:\r\n\r\n1) Visit a Location page, Eg. https://drup-1084-views-more-42glrty-sopc3ixpdigl4.us-2.platformsh.site/sel\r\n2) Scroll down to the News block and click \"More\"\r\n3) Ensure you're redirected to the /news page with the correct pre-filtered Location in the sidebar facets.\r\n\r\n\r\n1) Visit a Destination page Eg https://drup-1084-views-more-42glrty-sopc3ixpdigl4.us-2.platformsh.site/destination/research-commons\r\n2) Scroll down to the News block and click \"More\"\r\n3) Ensure you're redirected to the /news page with the correct pre-filtered Location based on the destination in the sidebar facets.\r\n\r\n\r\nOther things that were changed in this feature:\r\n\r\n* The solution moves the more link out of the footer, from the views configuration screen, into a custom code solution in a preprocess function.\r\n* This change caused a small issue with the theme's sass styles pulling in too many styles due to a poorly coded sass `@extends`, so I've refactored it to use a sass `%more-link` placeholder, instead of a normal classname. \r\n* The theme was also missing a `package-lock.json` file which was introduced a few years ago in npm version 5 (version 6 is out now).  This file lets us ensure everyone has the same npm package dependencies installed on their local machines.\r\n","created_at":"2018-09-03T23:45:39Z","updated_at":"2018-09-03T23:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487/commits","review_comments_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487/comments","review_comment_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/487/comments","statuses_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/statuses/bace47523f7a3e4d60ce730ebeb1f1f244b4801d","head":{"label":"BluesparkLabs:DRUP-1084-views-more-links","ref":"DRUP-1084-views-more-links","sha":"bace47523f7a3e4d60ce730ebeb1f1f244b4801d","user":{"login":"BluesparkLabs","id":1517894,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTc4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1517894?v=4","gravatar_id":"","url":"https://api.github.com/users/BluesparkLabs","html_url":"https://github.com/BluesparkLabs","followers_url":"https://api.github.com/users/BluesparkLabs/followers","following_url":"https://api.github.com/users/BluesparkLabs/following{/other_user}","gists_url":"https://api.github.com/users/BluesparkLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BluesparkLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BluesparkLabs/subscriptions","organizations_url":"https://api.github.com/users/BluesparkLabs/orgs","repos_url":"https://api.github.com/users/BluesparkLabs/repos","events_url":"https://api.github.com/users/BluesparkLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BluesparkLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66035616,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAzNTYxNg==","name":"libraryweb-site","full_name":"BluesparkLabs/libraryweb-site","owner":{"login":"BluesparkLabs","id":1517894,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTc4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1517894?v=4","gravatar_id":"","url":"https://api.github.com/users/BluesparkLabs","html_url":"https://github.com/BluesparkLabs","followers_url":"https://api.github.com/users/BluesparkLabs/followers","following_url":"https://api.github.com/users/BluesparkLabs/following{/other_user}","gists_url":"https://api.github.com/users/BluesparkLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BluesparkLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BluesparkLabs/subscriptions","organizations_url":"https://api.github.com/users/BluesparkLabs/orgs","repos_url":"https://api.github.com/users/BluesparkLabs/repos","events_url":"https://api.github.com/users/BluesparkLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BluesparkLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BluesparkLabs/libraryweb-site","description":"UCLA Library site rebuild","fork":true,"url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site","forks_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/forks","keys_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/teams","hooks_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/hooks","issue_events_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/issues/events{/number}","events_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/events","assignees_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/assignees{/user}","branches_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/branches{/branch}","tags_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/tags","blobs_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/statuses/{sha}","languages_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/languages","stargazers_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/stargazers","contributors_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/contributors","subscribers_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/subscribers","subscription_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/subscription","commits_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/contents/{+path}","compare_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/merges","archive_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/downloads","issues_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/issues{/number}","pulls_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/pulls{/number}","milestones_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/milestones{/number}","notifications_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/labels{/name}","releases_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/releases{/id}","deployments_url":"https://api.github.com/repos/BluesparkLabs/libraryweb-site/deployments","created_at":"2016-08-18T22:46:22Z","updated_at":"2018-08-30T14:19:58Z","pushed_at":"2018-09-03T23:35:28Z","git_url":"git://github.com/BluesparkLabs/libraryweb-site.git","ssh_url":"git@github.com:BluesparkLabs/libraryweb-site.git","clone_url":"https://github.com/BluesparkLabs/libraryweb-site.git","svn_url":"https://github.com/BluesparkLabs/libraryweb-site","homepage":null,"size":209109,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"mobile-responsive"}},"base":{"label":"UCLALibrary:master","ref":"master","sha":"5fafd8da0234d9c9dc286e06a7189088be146a1f","user":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":16549464,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0OTQ2NA==","name":"libraryweb-site","full_name":"UCLALibrary/libraryweb-site","owner":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCLALibrary/libraryweb-site","description":"UCLA Library","fork":false,"url":"https://api.github.com/repos/UCLALibrary/libraryweb-site","forks_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/forks","keys_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/teams","hooks_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/hooks","issue_events_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/events{/number}","events_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/events","assignees_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/assignees{/user}","branches_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/branches{/branch}","tags_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/tags","blobs_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/statuses/{sha}","languages_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/languages","stargazers_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/stargazers","contributors_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/contributors","subscribers_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/subscribers","subscription_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/subscription","commits_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/contents/{+path}","compare_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/merges","archive_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/downloads","issues_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues{/number}","pulls_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls{/number}","milestones_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/milestones{/number}","notifications_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/labels{/name}","releases_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/releases{/id}","deployments_url":"https://api.github.com/repos/UCLALibrary/libraryweb-site/deployments","created_at":"2014-02-05T15:57:15Z","updated_at":"2018-08-31T18:54:11Z","pushed_at":"2018-08-31T18:54:09Z","git_url":"git://github.com/UCLALibrary/libraryweb-site.git","ssh_url":"git@github.com:UCLALibrary/libraryweb-site.git","clone_url":"https://github.com/UCLALibrary/libraryweb-site.git","svn_url":"https://github.com/UCLALibrary/libraryweb-site","homepage":"http://www.library.ucla.edu","size":208753,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487"},"html":{"href":"https://github.com/UCLALibrary/libraryweb-site/pull/487"},"issue":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/487"},"comments":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/UCLALibrary/libraryweb-site/statuses/bace47523f7a3e4d60ce730ebeb1f1f244b4801d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":6,"additions":665,"deletions":51,"changed_files":14}}
{"actor":{"display_login":"jameswilson"}}