{"action":"closed","number":1024,"pull_request":{"url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024","id":177451389,"html_url":"https://github.com/drwetter/testssl.sh/pull/1024","diff_url":"https://github.com/drwetter/testssl.sh/pull/1024.diff","patch_url":"https://github.com/drwetter/testssl.sh/pull/1024.patch","issue_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1024","number":1024,"state":"closed","locked":false,"title":"Fix client simulations","user":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars3.githubusercontent.com/u/16493199?v=4","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"body":"`parse_tls_serverhello()` checks `$TLS_CLIENT_HELLO` for a supported_versions extension, and if it contains one, checks that the negotiated version is listed in that extension. However, while `$TLS_CLIENT_HELLO` is always set in `socksend_tls_clienthello()` it is not set by `client_simulation_sockets()` (or any of the functions that `client_simulation_sockets()` calls). As a result, when the server's response to a client simulation is parsed, `parse_tls_serverhello()` may compare the negotiated version against the supported_versions extension from a ClientHello message from a previous test.\r\n\r\nThis PR fixes the problem by having `client_simulation_sockets()` set `$TLS_CLIENT_HELLO`.","created_at":"2018-03-26T13:46:24Z","updated_at":"2018-03-27T07:10:56Z","closed_at":"2018-03-27T07:10:56Z","merged_at":"2018-03-27T07:10:56Z","merge_commit_sha":"653827cfe18704afe5404eec9910b69f1b12007c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1024/comments","statuses_url":"https://api.github.com/repos/drwetter/testssl.sh/statuses/72e7259ab256d74f9333e904fb3e4ba7b20821e0","head":{"label":"dcooper16:fix_client_simulation","ref":"fix_client_simulation","sha":"72e7259ab256d74f9333e904fb3e4ba7b20821e0","user":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars3.githubusercontent.com/u/16493199?v=4","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"repo":{"id":50522989,"name":"testssl.sh","full_name":"dcooper16/testssl.sh","owner":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars3.githubusercontent.com/u/16493199?v=4","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcooper16/testssl.sh","description":"Testing TLS/SSL encryption","fork":true,"url":"https://api.github.com/repos/dcooper16/testssl.sh","forks_url":"https://api.github.com/repos/dcooper16/testssl.sh/forks","keys_url":"https://api.github.com/repos/dcooper16/testssl.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcooper16/testssl.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcooper16/testssl.sh/teams","hooks_url":"https://api.github.com/repos/dcooper16/testssl.sh/hooks","issue_events_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues/events{/number}","events_url":"https://api.github.com/repos/dcooper16/testssl.sh/events","assignees_url":"https://api.github.com/repos/dcooper16/testssl.sh/assignees{/user}","branches_url":"https://api.github.com/repos/dcooper16/testssl.sh/branches{/branch}","tags_url":"https://api.github.com/repos/dcooper16/testssl.sh/tags","blobs_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcooper16/testssl.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/dcooper16/testssl.sh/languages","stargazers_url":"https://api.github.com/repos/dcooper16/testssl.sh/stargazers","contributors_url":"https://api.github.com/repos/dcooper16/testssl.sh/contributors","subscribers_url":"https://api.github.com/repos/dcooper16/testssl.sh/subscribers","subscription_url":"https://api.github.com/repos/dcooper16/testssl.sh/subscription","commits_url":"https://api.github.com/repos/dcooper16/testssl.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcooper16/testssl.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcooper16/testssl.sh/contents/{+path}","compare_url":"https://api.github.com/repos/dcooper16/testssl.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcooper16/testssl.sh/merges","archive_url":"https://api.github.com/repos/dcooper16/testssl.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcooper16/testssl.sh/downloads","issues_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues{/number}","pulls_url":"https://api.github.com/repos/dcooper16/testssl.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/dcooper16/testssl.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/dcooper16/testssl.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcooper16/testssl.sh/labels{/name}","releases_url":"https://api.github.com/repos/dcooper16/testssl.sh/releases{/id}","deployments_url":"https://api.github.com/repos/dcooper16/testssl.sh/deployments","created_at":"2016-01-27T17:02:00Z","updated_at":"2018-03-26T12:56:13Z","pushed_at":"2018-03-26T13:43:52Z","git_url":"git://github.com/dcooper16/testssl.sh.git","ssh_url":"git@github.com:dcooper16/testssl.sh.git","clone_url":"https://github.com/dcooper16/testssl.sh.git","svn_url":"https://github.com/dcooper16/testssl.sh","homepage":null,"size":62622,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.9dev"}},"base":{"label":"drwetter:2.9dev","ref":"2.9dev","sha":"224d851f7ba178a680977ac6722d0cc7c1a169d1","user":{"login":"drwetter","id":8036727,"avatar_url":"https://avatars1.githubusercontent.com/u/8036727?v=4","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"repo":{"id":21385916,"name":"testssl.sh","full_name":"drwetter/testssl.sh","owner":{"login":"drwetter","id":8036727,"avatar_url":"https://avatars1.githubusercontent.com/u/8036727?v=4","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drwetter/testssl.sh","description":"Testing TLS/SSL encryption anywhere on any port ","fork":false,"url":"https://api.github.com/repos/drwetter/testssl.sh","forks_url":"https://api.github.com/repos/drwetter/testssl.sh/forks","keys_url":"https://api.github.com/repos/drwetter/testssl.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drwetter/testssl.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drwetter/testssl.sh/teams","hooks_url":"https://api.github.com/repos/drwetter/testssl.sh/hooks","issue_events_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/events{/number}","events_url":"https://api.github.com/repos/drwetter/testssl.sh/events","assignees_url":"https://api.github.com/repos/drwetter/testssl.sh/assignees{/user}","branches_url":"https://api.github.com/repos/drwetter/testssl.sh/branches{/branch}","tags_url":"https://api.github.com/repos/drwetter/testssl.sh/tags","blobs_url":"https://api.github.com/repos/drwetter/testssl.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drwetter/testssl.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drwetter/testssl.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/drwetter/testssl.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drwetter/testssl.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/drwetter/testssl.sh/languages","stargazers_url":"https://api.github.com/repos/drwetter/testssl.sh/stargazers","contributors_url":"https://api.github.com/repos/drwetter/testssl.sh/contributors","subscribers_url":"https://api.github.com/repos/drwetter/testssl.sh/subscribers","subscription_url":"https://api.github.com/repos/drwetter/testssl.sh/subscription","commits_url":"https://api.github.com/repos/drwetter/testssl.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/drwetter/testssl.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/drwetter/testssl.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/drwetter/testssl.sh/contents/{+path}","compare_url":"https://api.github.com/repos/drwetter/testssl.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drwetter/testssl.sh/merges","archive_url":"https://api.github.com/repos/drwetter/testssl.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drwetter/testssl.sh/downloads","issues_url":"https://api.github.com/repos/drwetter/testssl.sh/issues{/number}","pulls_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/drwetter/testssl.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/drwetter/testssl.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drwetter/testssl.sh/labels{/name}","releases_url":"https://api.github.com/repos/drwetter/testssl.sh/releases{/id}","deployments_url":"https://api.github.com/repos/drwetter/testssl.sh/deployments","created_at":"2014-07-01T11:55:26Z","updated_at":"2018-03-26T10:46:49Z","pushed_at":"2018-03-27T07:10:56Z","git_url":"git://github.com/drwetter/testssl.sh.git","ssh_url":"git@github.com:drwetter/testssl.sh.git","clone_url":"https://github.com/drwetter/testssl.sh.git","svn_url":"https://github.com/drwetter/testssl.sh","homepage":"https://testssl.sh","size":62408,"stargazers_count":2017,"watchers_count":2017,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":295,"open_issues":134,"watchers":2017,"default_branch":"2.9dev"}},"_links":{"self":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024"},"html":{"href":"https://github.com/drwetter/testssl.sh/pull/1024"},"issue":{"href":"https://api.github.com/repos/drwetter/testssl.sh/issues/1024"},"comments":{"href":"https://api.github.com/repos/drwetter/testssl.sh/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/drwetter/testssl.sh/statuses/72e7259ab256d74f9333e904fb3e4ba7b20821e0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"drwetter","id":8036727,"avatar_url":"https://avatars1.githubusercontent.com/u/8036727?v=4","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"drwetter"}}