{"action":"created","comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/237097640","pull_request_review_id":179312843,"id":237097640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA5NzY0MA==","diff_hunk":"@@ -1,6 +1,6 @@\n import {Key} from 'protractor';\n import {DatepickerAutoClosePage} from './datepicker-autoclose.po';\n-import {openUrl, sendKey} from '../tools';\n+import {openUrl, sendKey} from '../../tools.po';","path":"e2e-app/src/app/datepicker/autoclose/datepicker-autoclose.e2e-spec.ts","position":4,"original_position":4,"commit_id":"46540b46a5a33cf15e5943280a078fc551f862d5","original_commit_id":"46540b46a5a33cf15e5943280a078fc551f862d5","user":{"login":"maxokorokov","id":8074436,"node_id":"MDQ6VXNlcjgwNzQ0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8074436?v=4","gravatar_id":"","url":"https://api.github.com/users/maxokorokov","html_url":"https://github.com/maxokorokov","followers_url":"https://api.github.com/users/maxokorokov/followers","following_url":"https://api.github.com/users/maxokorokov/following{/other_user}","gists_url":"https://api.github.com/users/maxokorokov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxokorokov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxokorokov/subscriptions","organizations_url":"https://api.github.com/users/maxokorokov/orgs","repos_url":"https://api.github.com/users/maxokorokov/repos","events_url":"https://api.github.com/users/maxokorokov/events{/privacy}","received_events_url":"https://api.github.com/users/maxokorokov/received_events","type":"User","site_admin":false},"body":"didn't get why you renamed `tools.ts` → `tools.po.ts` as its just helper functions and not a page object. ex `openUrl`?","created_at":"2018-11-28T14:09:33Z","updated_at":"2018-11-28T14:18:45Z","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882#discussion_r237097640","pull_request_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/237097640"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882#discussion_r237097640"},"pull_request":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882"}}},"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882","id":232690292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjkwMjky","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2882","number":2882,"state":"open","locked":false,"title":"chore(test): move e2e specs to their corresponding e2e-app folders","user":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"body":"The purpose of this PR is to discuss about the e2e specs location. \r\n\r\nAt the moment, the e2e-app and the e2e-specs are in two separated structures. It seems to be more intuitive to have them merged, the same way the unit tests are located in their corresponding widget folders.","created_at":"2018-11-21T14:48:25Z","updated_at":"2018-11-28T14:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0228373e3be2159f7d75f37c8316696854bc1cf3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":260884548,"node_id":"MDU6TGFiZWwyNjA4ODQ1NDg=","url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7","default":false},{"id":260891359,"node_id":"MDU6TGFiZWwyNjA4OTEzNTk=","url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/type:%20tests","name":"type: tests","color":"0b02e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2882/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/46540b46a5a33cf15e5943280a078fc551f862d5","head":{"label":"fbasso:tests_move","ref":"tests_move","sha":"46540b46a5a33cf15e5943280a078fc551f862d5","user":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"repo":{"id":70463623,"node_id":"MDEwOlJlcG9zaXRvcnk3MDQ2MzYyMw==","name":"ng-bootstrap","full_name":"fbasso/ng-bootstrap","private":false,"owner":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fbasso/ng-bootstrap","description":"Angular 2 powered Bootstrap","fork":true,"url":"https://api.github.com/repos/fbasso/ng-bootstrap","forks_url":"https://api.github.com/repos/fbasso/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/fbasso/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbasso/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbasso/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/fbasso/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/fbasso/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/fbasso/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/fbasso/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/fbasso/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbasso/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/fbasso/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/fbasso/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/fbasso/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/fbasso/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/fbasso/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/fbasso/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbasso/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbasso/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/fbasso/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbasso/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/fbasso/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbasso/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/fbasso/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/fbasso/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/fbasso/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbasso/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/fbasso/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/fbasso/ng-bootstrap/deployments","created_at":"2016-10-10T07:39:10Z","updated_at":"2018-11-28T14:18:04Z","pushed_at":"2018-11-28T14:18:01Z","git_url":"git://github.com/fbasso/ng-bootstrap.git","ssh_url":"git@github.com:fbasso/ng-bootstrap.git","clone_url":"https://github.com/fbasso/ng-bootstrap.git","svn_url":"https://github.com/fbasso/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":3355,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"b20355ed7d8e5e8faabfe15e690b6416df0da3c6","user":{"login":"ng-bootstrap","id":14283866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjgzODY2","avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ4MTY2NA==","name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","private":false,"owner":{"login":"ng-bootstrap","id":14283866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjgzODY2","avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2018-11-28T14:16:35Z","pushed_at":"2018-11-28T11:11:55Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"git@github.com:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":3174,"stargazers_count":6303,"watchers_count":6303,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1044,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1044,"open_issues":195,"watchers":6303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2882"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2882"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2882/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2882/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/46540b46a5a33cf15e5943280a078fc551f862d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maxokorokov"}}