{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/195385509","pull_request_review_id":128742924,"id":195385509,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTM4NTUwOQ==","diff_hunk":"@@ -8,6 +8,7 @@ import (\n \t\"github.com/stretchr/testify/require\"\n )\n \n+// nolint: deadcode","path":"cmd/statusd/flags_test.go","position":4,"original_position":4,"commit_id":"65813479dc28b02befdd6ee272cf3d50f82fbace","original_commit_id":"6722367e88f7a39103246ae83b6a2cb33e7d8662","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"body":"yeah, it's weird, as it's not obvious what makes this special compared to other tests.","created_at":"2018-06-14T11:18:40Z","updated_at":"2018-06-14T11:18:40Z","html_url":"https://github.com/status-im/status-go/pull/1029#discussion_r195385509","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/1029","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/195385509"},"html":{"href":"https://github.com/status-im/status-go/pull/1029#discussion_r195385509"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1029"}},"in_reply_to_id":195351911},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/1029","id":194555953,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTU1OTUz","html_url":"https://github.com/status-im/status-go/pull/1029","diff_url":"https://github.com/status-im/status-go/pull/1029.diff","patch_url":"https://github.com/status-im/status-go/pull/1029.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/1029","number":1029,"state":"open","locked":false,"title":"Replace gometalinter with golangci-lint (4.5x faster). Closes #1017","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"body":"This PR updates `make lint-install` and `make lint` to replace gometalinter with a combination of [golangci-lint](https://github.com/golangci/golangci-lint#golangci-lint) and barebones misspell linter (which is not yet supported by golangci-lint). I've made the fixes to the issues reported by the linter in a separate commit to facilitate the review. Happy to get suggestions in case you don't agree with the way any of them was fixed.\r\n\r\nThis should shave off 1 minute for every build in Travis CI/Jenkins.\r\n\r\nThis log shows the results of the linting before the fix commit, so you can see what the error report looked like: [lint.log](https://github.com/status-im/status-go/files/2097896/lint.log)\r\n\r\nCloses #1017\r\n","created_at":"2018-06-13T11:33:46Z","updated_at":"2018-06-14T11:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4344a2d11d4ba8d3ba07bc3ef70eaf92095ef667","assignee":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"assignees":[{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/1029/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/1029/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/1029/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/65813479dc28b02befdd6ee272cf3d50f82fbace","head":{"label":"status-im:feature/golangci-lint","ref":"feature/golangci-lint","sha":"65813479dc28b02befdd6ee272cf3d50f82fbace","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-06-14T09:00:18Z","pushed_at":"2018-06-14T11:15:29Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":38807,"stargazers_count":419,"watchers_count":419,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":132,"open_issues":67,"watchers":419,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"e81ef9e9d57af96448a7fa5cfd5a78213b198c2a","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-06-14T09:00:18Z","pushed_at":"2018-06-14T11:15:29Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":38807,"stargazers_count":419,"watchers_count":419,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":132,"open_issues":67,"watchers":419,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1029"},"html":{"href":"https://github.com/status-im/status-go/pull/1029"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/1029"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/1029/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1029/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1029/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/65813479dc28b02befdd6ee272cf3d50f82fbace"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"PombeirP"}}