{"action":"closed","number":61,"pull_request":{"url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61","id":240205835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjA1ODM1","html_url":"https://github.com/snyk/nodejs-runtime-agent/pull/61","diff_url":"https://github.com/snyk/nodejs-runtime-agent/pull/61.diff","patch_url":"https://github.com/snyk/nodejs-runtime-agent/pull/61.patch","issue_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/61","number":61,"state":"closed","locked":false,"title":"Correctly identify short methods","user":{"login":"FauxFaux","id":328180,"node_id":"MDQ6VXNlcjMyODE4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/328180?v=4","gravatar_id":"","url":"https://api.github.com/users/FauxFaux","html_url":"https://github.com/FauxFaux","followers_url":"https://api.github.com/users/FauxFaux/followers","following_url":"https://api.github.com/users/FauxFaux/following{/other_user}","gists_url":"https://api.github.com/users/FauxFaux/gists{/gist_id}","starred_url":"https://api.github.com/users/FauxFaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FauxFaux/subscriptions","organizations_url":"https://api.github.com/users/FauxFaux/orgs","repos_url":"https://api.github.com/users/FauxFaux/repos","events_url":"https://api.github.com/users/FauxFaux/events{/privacy}","received_events_url":"https://api.github.com/users/FauxFaux/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nEnable us to see short methods, like:\r\n\r\n```js\r\nfunction foo() { return 5; }\r\n```\r\n\r\nThis also fixes us not seeing:\r\n```js\r\nfunction foo(bar) {\r\n  validate(bar);\r\n  bar.baz();\r\n}\r\n```\r\n\r\n... in cases where the validation fails.\r\n\r\nPreviously, we were picking some point on the first line of the method, which was not useful.\r\n\r\n#### Where should the reviewer start?\r\n\r\nThe use of that `noop` inside `graceful-fs` isn't super elegant, but I was hard pressed to find a one-line function inside the demo's `node_modules`...\r\n\r\n","created_at":"2018-12-20T15:20:01Z","updated_at":"2018-12-25T09:01:38Z","closed_at":"2018-12-25T09:01:38Z","merged_at":null,"merge_commit_sha":"1c6f721b7449ae6cb735a4fa351b1ee8190819a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61/commits","review_comments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61/comments","review_comment_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/61/comments","statuses_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/statuses/f6edfba79dc3268364cc9f173484992ba4810655","head":{"label":"snyk:feat/off-by-one","ref":"feat/off-by-one","sha":"f6edfba79dc3268364cc9f173484992ba4810655","user":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":143638084,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MzgwODQ=","name":"nodejs-runtime-agent","full_name":"snyk/nodejs-runtime-agent","private":false,"owner":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snyk/nodejs-runtime-agent","description":"Snyk Node Runtime Agent ","fork":false,"url":"https://api.github.com/repos/snyk/nodejs-runtime-agent","forks_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/forks","keys_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/teams","hooks_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/hooks","issue_events_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/events{/number}","events_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/events","assignees_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/assignees{/user}","branches_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/branches{/branch}","tags_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/tags","blobs_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/languages","stargazers_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/stargazers","contributors_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/contributors","subscribers_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/subscribers","subscription_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/subscription","commits_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/contents/{+path}","compare_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/merges","archive_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/downloads","issues_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues{/number}","pulls_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/labels{/name}","releases_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/releases{/id}","deployments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/deployments","created_at":"2018-08-05T18:31:48Z","updated_at":"2018-12-24T11:43:36Z","pushed_at":"2018-12-25T08:33:35Z","git_url":"git://github.com/snyk/nodejs-runtime-agent.git","ssh_url":"git@github.com:snyk/nodejs-runtime-agent.git","clone_url":"https://github.com/snyk/nodejs-runtime-agent.git","svn_url":"https://github.com/snyk/nodejs-runtime-agent","homepage":null,"size":298,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"snyk:master","ref":"master","sha":"3f5efe1e09dbdcc697cf573c94e95ff9bd434b4d","user":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":143638084,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MzgwODQ=","name":"nodejs-runtime-agent","full_name":"snyk/nodejs-runtime-agent","private":false,"owner":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snyk/nodejs-runtime-agent","description":"Snyk Node Runtime Agent ","fork":false,"url":"https://api.github.com/repos/snyk/nodejs-runtime-agent","forks_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/forks","keys_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/teams","hooks_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/hooks","issue_events_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/events{/number}","events_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/events","assignees_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/assignees{/user}","branches_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/branches{/branch}","tags_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/tags","blobs_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/languages","stargazers_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/stargazers","contributors_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/contributors","subscribers_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/subscribers","subscription_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/subscription","commits_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/contents/{+path}","compare_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/merges","archive_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/downloads","issues_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues{/number}","pulls_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/labels{/name}","releases_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/releases{/id}","deployments_url":"https://api.github.com/repos/snyk/nodejs-runtime-agent/deployments","created_at":"2018-08-05T18:31:48Z","updated_at":"2018-12-24T11:43:36Z","pushed_at":"2018-12-25T08:33:35Z","git_url":"git://github.com/snyk/nodejs-runtime-agent.git","ssh_url":"git@github.com:snyk/nodejs-runtime-agent.git","clone_url":"https://github.com/snyk/nodejs-runtime-agent.git","svn_url":"https://github.com/snyk/nodejs-runtime-agent","homepage":null,"size":298,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61"},"html":{"href":"https://github.com/snyk/nodejs-runtime-agent/pull/61"},"issue":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/61"},"comments":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/snyk/nodejs-runtime-agent/statuses/f6edfba79dc3268364cc9f173484992ba4810655"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":65,"deletions":20,"changed_files":8}}
{"actor":{"display_login":"Shesekino"}}