{"action":"closed","number":1436,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436","id":174185294,"html_url":"https://github.com/ARMmbed/mbedtls/pull/1436","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1436.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1436.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1436","number":1436,"state":"closed","locked":false,"title":"Fix 'may be used unitialized' warning","user":{"login":"d3zd3z","id":90349,"avatar_url":"https://avatars3.githubusercontent.com/u/90349?v=4","gravatar_id":"","url":"https://api.github.com/users/d3zd3z","html_url":"https://github.com/d3zd3z","followers_url":"https://api.github.com/users/d3zd3z/followers","following_url":"https://api.github.com/users/d3zd3z/following{/other_user}","gists_url":"https://api.github.com/users/d3zd3z/gists{/gist_id}","starred_url":"https://api.github.com/users/d3zd3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3zd3z/subscriptions","organizations_url":"https://api.github.com/users/d3zd3z/orgs","repos_url":"https://api.github.com/users/d3zd3z/repos","events_url":"https://api.github.com/users/d3zd3z/events{/privacy}","received_events_url":"https://api.github.com/users/d3zd3z/received_events","type":"User","site_admin":false},"body":"Gcc isn't quite smart enough to realize that these functions are always\r\ncalled with a >0 `num_tests` value, which restults in warnings like:\r\n\r\n    .../mbedtls/library/cmac.c: In function ‘cmac_test_subkeys’:\r\n    .../mbedtls/library/cmac.c:768:12: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\r\n         int i, ret;\r\n                ^~~\r\n    .../mbedtls/library/cmac.c: In function ‘cmac_test_wth_cipher’:\r\n    .../mbedtls/library/cmac.c:886:11: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\r\n         return( ret );\r\n               ^\r\n\r\nAs seen in https://github.com/zephyrproject-rtos/zephyr/issues/3770 for\r\nexample.\r\n\r\nFix this by giving `ret` a successful return value to use in the case if\r\n`num_tests` were zero.\r\n\r\nNotes:\r\n* Pull requests cannot be accepted until:\r\n-  The submitter has [accepted the online agreement here with a click through](https://developer.mbed.org/contributor_agreement/) \r\n   or for companies or those that do not wish to create an mbed account, a slightly different agreement can be found [here](https://www.mbed.com/en/about-mbed/contributor-license-agreements/)\r\n- The PR follows the [mbed TLS coding standards](https://tls.mbed.org/kb/development/mbedtls-coding-standards)\r\n* This is just a template, so feel free to use/remove the unnecessary things\r\n## Description\r\nA few sentences describing the overall goals of the pull request's commits.\r\n\r\n\r\n## Status\r\n**READY/IN DEVELOPMENT/HOLD**\r\n\r\n## Requires Backporting\r\nWhen there is a bug fix, it should be backported to all maintained and supported branches.\r\nChanges do not have to be backported if:\r\n- This PR is a new feature\\enhancement\r\n- This PR contains changes in the API. If this is true, and there is a need for the fix to be backported, the fix should be handled differently in the legacy branch\r\n\r\nYes | NO  \r\nWhich branch?\r\n\r\n## Migrations\r\nIf there is any API change, what's the incentive and logic for it.\r\n\r\nYES | NO\r\n\r\n## Additional comments\r\nAny additional information that could be of interest\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Changelog updated\r\n- [ ] Backported\r\n\r\n\r\n## Steps to test or reproduce\r\nOutline the steps to test or reproduce the PR here.\r\n","created_at":"2018-03-10T19:23:13Z","updated_at":"2018-03-21T12:42:54Z","closed_at":"2018-03-21T12:42:54Z","merged_at":null,"merge_commit_sha":"fa53dc44b50be7b37a71d64d17df0d8417c71b6b","assignee":{"login":"k-stachowiak","id":2103379,"avatar_url":"https://avatars3.githubusercontent.com/u/2103379?v=4","gravatar_id":"","url":"https://api.github.com/users/k-stachowiak","html_url":"https://github.com/k-stachowiak","followers_url":"https://api.github.com/users/k-stachowiak/followers","following_url":"https://api.github.com/users/k-stachowiak/following{/other_user}","gists_url":"https://api.github.com/users/k-stachowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/k-stachowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-stachowiak/subscriptions","organizations_url":"https://api.github.com/users/k-stachowiak/orgs","repos_url":"https://api.github.com/users/k-stachowiak/repos","events_url":"https://api.github.com/users/k-stachowiak/events{/privacy}","received_events_url":"https://api.github.com/users/k-stachowiak/received_events","type":"User","site_admin":false},"assignees":[{"login":"k-stachowiak","id":2103379,"avatar_url":"https://avatars3.githubusercontent.com/u/2103379?v=4","gravatar_id":"","url":"https://api.github.com/users/k-stachowiak","html_url":"https://github.com/k-stachowiak","followers_url":"https://api.github.com/users/k-stachowiak/followers","following_url":"https://api.github.com/users/k-stachowiak/following{/other_user}","gists_url":"https://api.github.com/users/k-stachowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/k-stachowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-stachowiak/subscriptions","organizations_url":"https://api.github.com/users/k-stachowiak/orgs","repos_url":"https://api.github.com/users/k-stachowiak/repos","events_url":"https://api.github.com/users/k-stachowiak/events{/privacy}","received_events_url":"https://api.github.com/users/k-stachowiak/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Patater","id":410816,"avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":278176777,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/CLA%20valid","name":"CLA valid","color":"bfdadc","default":false},{"id":19280384,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/bug","name":"bug","color":"d93f0b","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1436/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/5d191614246bc500c55699eedc6ed6d7499220f4","head":{"label":"d3zd3z:pr/cmac-warn","ref":"pr/cmac-warn","sha":"5d191614246bc500c55699eedc6ed6d7499220f4","user":{"login":"d3zd3z","id":90349,"avatar_url":"https://avatars3.githubusercontent.com/u/90349?v=4","gravatar_id":"","url":"https://api.github.com/users/d3zd3z","html_url":"https://github.com/d3zd3z","followers_url":"https://api.github.com/users/d3zd3z/followers","following_url":"https://api.github.com/users/d3zd3z/following{/other_user}","gists_url":"https://api.github.com/users/d3zd3z/gists{/gist_id}","starred_url":"https://api.github.com/users/d3zd3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3zd3z/subscriptions","organizations_url":"https://api.github.com/users/d3zd3z/orgs","repos_url":"https://api.github.com/users/d3zd3z/repos","events_url":"https://api.github.com/users/d3zd3z/events{/privacy}","received_events_url":"https://api.github.com/users/d3zd3z/received_events","type":"User","site_admin":false},"repo":{"id":124691095,"name":"mbedtls","full_name":"d3zd3z/mbedtls","owner":{"login":"d3zd3z","id":90349,"avatar_url":"https://avatars3.githubusercontent.com/u/90349?v=4","gravatar_id":"","url":"https://api.github.com/users/d3zd3z","html_url":"https://github.com/d3zd3z","followers_url":"https://api.github.com/users/d3zd3z/followers","following_url":"https://api.github.com/users/d3zd3z/following{/other_user}","gists_url":"https://api.github.com/users/d3zd3z/gists{/gist_id}","starred_url":"https://api.github.com/users/d3zd3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3zd3z/subscriptions","organizations_url":"https://api.github.com/users/d3zd3z/orgs","repos_url":"https://api.github.com/users/d3zd3z/repos","events_url":"https://api.github.com/users/d3zd3z/events{/privacy}","received_events_url":"https://api.github.com/users/d3zd3z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3zd3z/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/d3zd3z/mbedtls","forks_url":"https://api.github.com/repos/d3zd3z/mbedtls/forks","keys_url":"https://api.github.com/repos/d3zd3z/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3zd3z/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3zd3z/mbedtls/teams","hooks_url":"https://api.github.com/repos/d3zd3z/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/d3zd3z/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/d3zd3z/mbedtls/events","assignees_url":"https://api.github.com/repos/d3zd3z/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/d3zd3z/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/d3zd3z/mbedtls/tags","blobs_url":"https://api.github.com/repos/d3zd3z/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3zd3z/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3zd3z/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3zd3z/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3zd3z/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/d3zd3z/mbedtls/languages","stargazers_url":"https://api.github.com/repos/d3zd3z/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/d3zd3z/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/d3zd3z/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/d3zd3z/mbedtls/subscription","commits_url":"https://api.github.com/repos/d3zd3z/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3zd3z/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3zd3z/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3zd3z/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3zd3z/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/d3zd3z/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3zd3z/mbedtls/merges","archive_url":"https://api.github.com/repos/d3zd3z/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3zd3z/mbedtls/downloads","issues_url":"https://api.github.com/repos/d3zd3z/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/d3zd3z/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/d3zd3z/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/d3zd3z/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3zd3z/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/d3zd3z/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/d3zd3z/mbedtls/deployments","created_at":"2018-03-10T19:22:07Z","updated_at":"2018-03-10T19:22:12Z","pushed_at":"2018-03-10T19:22:41Z","git_url":"git://github.com/d3zd3z/mbedtls.git","ssh_url":"git@github.com:d3zd3z/mbedtls.git","clone_url":"https://github.com/d3zd3z/mbedtls.git","svn_url":"https://github.com/d3zd3z/mbedtls","homepage":"https://tls.mbed.org","size":24923,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"1bf6123fca97a9a35c2f403ab0c96495f9580db6","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-03-19T17:40:00Z","pushed_at":"2018-03-21T11:49:15Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":25254,"stargazers_count":1308,"watchers_count":1308,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":807,"open_issues":441,"watchers":1308,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1436"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1436"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/5d191614246bc500c55699eedc6ed6d7499220f4"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"gilles-peskine-arm"}}