{"action":"created","comment":{"url":"https://api.github.com/repos/keon/algorithms/pulls/comments/175559958","pull_request_review_id":105109232,"id":175559958,"diff_hunk":"@@ -104,7 +108,8 @@ def evaluate(expression):\n     \"\"\"\r\n     op_stack  = deque() # operator stack\r\n     out_stack = deque() # output stack (values)\r\n-    for token in parse(expression):\r\n+    tokens = parse(expression) # calls the function only once!\r\n+    for token in tokens:\r","path":"calculator/math_parser.py","position":27,"original_position":27,"commit_id":"24357bd7776a230448198a2dd50b3a3def0aafd0","original_commit_id":"24357bd7776a230448198a2dd50b3a3def0aafd0","user":{"login":"christianbender","id":23243382,"avatar_url":"https://avatars0.githubusercontent.com/u/23243382?v=4","gravatar_id":"","url":"https://api.github.com/users/christianbender","html_url":"https://github.com/christianbender","followers_url":"https://api.github.com/users/christianbender/followers","following_url":"https://api.github.com/users/christianbender/following{/other_user}","gists_url":"https://api.github.com/users/christianbender/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbender/subscriptions","organizations_url":"https://api.github.com/users/christianbender/orgs","repos_url":"https://api.github.com/users/christianbender/repos","events_url":"https://api.github.com/users/christianbender/events{/privacy}","received_events_url":"https://api.github.com/users/christianbender/received_events","type":"User","site_admin":false},"body":"Ok, I understand.","created_at":"2018-03-19T19:38:06Z","updated_at":"2018-03-19T19:38:06Z","html_url":"https://github.com/keon/algorithms/pull/152#discussion_r175559958","pull_request_url":"https://api.github.com/repos/keon/algorithms/pulls/152","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/keon/algorithms/pulls/comments/175559958"},"html":{"href":"https://github.com/keon/algorithms/pull/152#discussion_r175559958"},"pull_request":{"href":"https://api.github.com/repos/keon/algorithms/pulls/152"}},"in_reply_to_id":175529058},"pull_request":{"url":"https://api.github.com/repos/keon/algorithms/pulls/152","id":175932714,"html_url":"https://github.com/keon/algorithms/pull/152","diff_url":"https://github.com/keon/algorithms/pull/152.diff","patch_url":"https://github.com/keon/algorithms/pull/152.patch","issue_url":"https://api.github.com/repos/keon/algorithms/issues/152","number":152,"state":"open","locked":false,"title":"calculator: improved the code and added a simple user interface","user":{"login":"christianbender","id":23243382,"avatar_url":"https://avatars0.githubusercontent.com/u/23243382?v=4","gravatar_id":"","url":"https://api.github.com/users/christianbender","html_url":"https://github.com/christianbender","followers_url":"https://api.github.com/users/christianbender/followers","following_url":"https://api.github.com/users/christianbender/following{/other_user}","gists_url":"https://api.github.com/users/christianbender/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbender/subscriptions","organizations_url":"https://api.github.com/users/christianbender/orgs","repos_url":"https://api.github.com/users/christianbender/repos","events_url":"https://api.github.com/users/christianbender/events{/privacy}","received_events_url":"https://api.github.com/users/christianbender/received_events","type":"User","site_admin":false},"body":"I improved the code:  \r\n- more efficient  in the ```evaluate(...)```  \r\n- added a error management in the ```parser(...)``` and in the UI.  \r\n\r\nAnd I added a simple user interface (command-line)","created_at":"2018-03-19T15:18:43Z","updated_at":"2018-03-19T19:38:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f535a6c52b20b10f6e30f006f217dac876a7cbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keon/algorithms/pulls/152/commits","review_comments_url":"https://api.github.com/repos/keon/algorithms/pulls/152/comments","review_comment_url":"https://api.github.com/repos/keon/algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keon/algorithms/issues/152/comments","statuses_url":"https://api.github.com/repos/keon/algorithms/statuses/24357bd7776a230448198a2dd50b3a3def0aafd0","head":{"label":"christianbender:changed_calculator","ref":"changed_calculator","sha":"24357bd7776a230448198a2dd50b3a3def0aafd0","user":{"login":"christianbender","id":23243382,"avatar_url":"https://avatars0.githubusercontent.com/u/23243382?v=4","gravatar_id":"","url":"https://api.github.com/users/christianbender","html_url":"https://github.com/christianbender","followers_url":"https://api.github.com/users/christianbender/followers","following_url":"https://api.github.com/users/christianbender/following{/other_user}","gists_url":"https://api.github.com/users/christianbender/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbender/subscriptions","organizations_url":"https://api.github.com/users/christianbender/orgs","repos_url":"https://api.github.com/users/christianbender/repos","events_url":"https://api.github.com/users/christianbender/events{/privacy}","received_events_url":"https://api.github.com/users/christianbender/received_events","type":"User","site_admin":false},"repo":{"id":125775061,"name":"algorithms","full_name":"christianbender/algorithms","owner":{"login":"christianbender","id":23243382,"avatar_url":"https://avatars0.githubusercontent.com/u/23243382?v=4","gravatar_id":"","url":"https://api.github.com/users/christianbender","html_url":"https://github.com/christianbender","followers_url":"https://api.github.com/users/christianbender/followers","following_url":"https://api.github.com/users/christianbender/following{/other_user}","gists_url":"https://api.github.com/users/christianbender/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbender/subscriptions","organizations_url":"https://api.github.com/users/christianbender/orgs","repos_url":"https://api.github.com/users/christianbender/repos","events_url":"https://api.github.com/users/christianbender/events{/privacy}","received_events_url":"https://api.github.com/users/christianbender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christianbender/algorithms","description":"Minimal examples of data structures and algorithms in Python","fork":true,"url":"https://api.github.com/repos/christianbender/algorithms","forks_url":"https://api.github.com/repos/christianbender/algorithms/forks","keys_url":"https://api.github.com/repos/christianbender/algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christianbender/algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christianbender/algorithms/teams","hooks_url":"https://api.github.com/repos/christianbender/algorithms/hooks","issue_events_url":"https://api.github.com/repos/christianbender/algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/christianbender/algorithms/events","assignees_url":"https://api.github.com/repos/christianbender/algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/christianbender/algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/christianbender/algorithms/tags","blobs_url":"https://api.github.com/repos/christianbender/algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christianbender/algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christianbender/algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/christianbender/algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christianbender/algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/christianbender/algorithms/languages","stargazers_url":"https://api.github.com/repos/christianbender/algorithms/stargazers","contributors_url":"https://api.github.com/repos/christianbender/algorithms/contributors","subscribers_url":"https://api.github.com/repos/christianbender/algorithms/subscribers","subscription_url":"https://api.github.com/repos/christianbender/algorithms/subscription","commits_url":"https://api.github.com/repos/christianbender/algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/christianbender/algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/christianbender/algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/christianbender/algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/christianbender/algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/christianbender/algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christianbender/algorithms/merges","archive_url":"https://api.github.com/repos/christianbender/algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christianbender/algorithms/downloads","issues_url":"https://api.github.com/repos/christianbender/algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/christianbender/algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/christianbender/algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/christianbender/algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christianbender/algorithms/labels{/name}","releases_url":"https://api.github.com/repos/christianbender/algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/christianbender/algorithms/deployments","created_at":"2018-03-18T22:54:14Z","updated_at":"2018-03-18T22:54:16Z","pushed_at":"2018-03-19T15:15:47Z","git_url":"git://github.com/christianbender/algorithms.git","ssh_url":"git@github.com:christianbender/algorithms.git","clone_url":"https://github.com/christianbender/algorithms.git","svn_url":"https://github.com/christianbender/algorithms","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keon:master","ref":"master","sha":"bc79fea47a6f440d697874385b07d2283f2d0b26","user":{"login":"keon","id":10793962,"avatar_url":"https://avatars0.githubusercontent.com/u/10793962?v=4","gravatar_id":"","url":"https://api.github.com/users/keon","html_url":"https://github.com/keon","followers_url":"https://api.github.com/users/keon/followers","following_url":"https://api.github.com/users/keon/following{/other_user}","gists_url":"https://api.github.com/users/keon/gists{/gist_id}","starred_url":"https://api.github.com/users/keon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keon/subscriptions","organizations_url":"https://api.github.com/users/keon/orgs","repos_url":"https://api.github.com/users/keon/repos","events_url":"https://api.github.com/users/keon/events{/privacy}","received_events_url":"https://api.github.com/users/keon/received_events","type":"User","site_admin":false},"repo":{"id":74073233,"name":"algorithms","full_name":"keon/algorithms","owner":{"login":"keon","id":10793962,"avatar_url":"https://avatars0.githubusercontent.com/u/10793962?v=4","gravatar_id":"","url":"https://api.github.com/users/keon","html_url":"https://github.com/keon","followers_url":"https://api.github.com/users/keon/followers","following_url":"https://api.github.com/users/keon/following{/other_user}","gists_url":"https://api.github.com/users/keon/gists{/gist_id}","starred_url":"https://api.github.com/users/keon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keon/subscriptions","organizations_url":"https://api.github.com/users/keon/orgs","repos_url":"https://api.github.com/users/keon/repos","events_url":"https://api.github.com/users/keon/events{/privacy}","received_events_url":"https://api.github.com/users/keon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keon/algorithms","description":"Minimal examples of data structures and algorithms in Python","fork":false,"url":"https://api.github.com/repos/keon/algorithms","forks_url":"https://api.github.com/repos/keon/algorithms/forks","keys_url":"https://api.github.com/repos/keon/algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keon/algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keon/algorithms/teams","hooks_url":"https://api.github.com/repos/keon/algorithms/hooks","issue_events_url":"https://api.github.com/repos/keon/algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/keon/algorithms/events","assignees_url":"https://api.github.com/repos/keon/algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/keon/algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/keon/algorithms/tags","blobs_url":"https://api.github.com/repos/keon/algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keon/algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keon/algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/keon/algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keon/algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/keon/algorithms/languages","stargazers_url":"https://api.github.com/repos/keon/algorithms/stargazers","contributors_url":"https://api.github.com/repos/keon/algorithms/contributors","subscribers_url":"https://api.github.com/repos/keon/algorithms/subscribers","subscription_url":"https://api.github.com/repos/keon/algorithms/subscription","commits_url":"https://api.github.com/repos/keon/algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/keon/algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/keon/algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/keon/algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/keon/algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/keon/algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keon/algorithms/merges","archive_url":"https://api.github.com/repos/keon/algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keon/algorithms/downloads","issues_url":"https://api.github.com/repos/keon/algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/keon/algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/keon/algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/keon/algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keon/algorithms/labels{/name}","releases_url":"https://api.github.com/repos/keon/algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/keon/algorithms/deployments","created_at":"2016-11-17T22:32:08Z","updated_at":"2018-03-19T18:09:14Z","pushed_at":"2018-03-19T15:18:44Z","git_url":"git://github.com/keon/algorithms.git","ssh_url":"git@github.com:keon/algorithms.git","clone_url":"https://github.com/keon/algorithms.git","svn_url":"https://github.com/keon/algorithms","homepage":"","size":350,"stargazers_count":10804,"watchers_count":10804,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1641,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1641,"open_issues":12,"watchers":10804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keon/algorithms/pulls/152"},"html":{"href":"https://github.com/keon/algorithms/pull/152"},"issue":{"href":"https://api.github.com/repos/keon/algorithms/issues/152"},"comments":{"href":"https://api.github.com/repos/keon/algorithms/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/keon/algorithms/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/keon/algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keon/algorithms/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/keon/algorithms/statuses/24357bd7776a230448198a2dd50b3a3def0aafd0"}},"author_association":"NONE"}}
{"actor":{"display_login":"christianbender"}}