{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/219671057","pull_request_review_id":157909376,"id":219671057,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY3MTA1Nw==","diff_hunk":"@@ -0,0 +1,119 @@\n+import re\n+import hmac\n+import logging\n+import hashlib\n+import requests\n+from bs4 import BeautifulSoup\n+\n+from homeassistant.components.device_tracker import (\n+    DOMAIN, PLATFORM_SCHEMA, DeviceScanner)\n+from homeassistant.const import (\n+    CONF_HOST, CONF_PASSWORD, CONF_USERNAME, HTTP_HEADER_X_REQUESTED_WITH)\n+import homeassistant.helpers.config_validation as cv\n+\n+import voluptuous as vol\n+\n+REQUIREMENTS = ['beautifulsoup4']\n+\n+_LOGGER = logging.getLogger(__name__)\n+\n+HTTP_HEADER_NO_CACHE = 'no-cache'\n+\n+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({\n+    vol.Required(CONF_HOST): cv.string,\n+    vol.Required(CONF_PASSWORD): cv.string,\n+    vol.Required(CONF_USERNAME): cv.string\n+})\n+\n+def get_scanner(hass, config):\n+    \"\"\"Validate the configuration and return a Tilgin Device Scanner.\"\"\"\n+\n+    models = [ TilginHG238xDeviceScanner ]\n+    for model_family in models:\n+        scanner = model_family(config[DOMAIN])\n+        if scanner.success_init:\n+            return scanner\n+\n+    return None\n+\n+class TilginHG238xDeviceScanner(DeviceScanner):\n+    \"\"\"Queries the router for connected devices.\"\"\"\n+\n+    def __init__(self, config):\n+        \"\"\"Initialize the scanner.\"\"\"\n+        self.url = 'http://{}'.format(config[CONF_HOST])\n+        self.username = config[CONF_USERNAME]\n+        self.password = config[CONF_PASSWORD]\n+        self.session = requests.Session()\n+\n+        self.last_results = {}\n+        self.success_init = False\n+\n+        try:\n+            _LOGGER.debug(\"Initialising Tilgin HG238x Device\")\n+            self.success_init = self._check_auth()\n+        except:","path":"homeassistant/components/device_tracker/tilgin.py","position":55,"original_position":55,"commit_id":"6e14c783c66cf1b706eca36b51fa64f55b61abb1","original_commit_id":"6e14c783c66cf1b706eca36b51fa64f55b61abb1","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"do not use bare except'","created_at":"2018-09-22T13:03:53Z","updated_at":"2018-09-22T13:03:54Z","html_url":"https://github.com/home-assistant/home-assistant/pull/16791#discussion_r219671057","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/219671057"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/16791#discussion_r219671057"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791","id":217456459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDU2NDU5","html_url":"https://github.com/home-assistant/home-assistant/pull/16791","diff_url":"https://github.com/home-assistant/home-assistant/pull/16791.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/16791.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16791","number":16791,"state":"open","locked":false,"title":"Add Tilgin device_tracker support","user":{"login":"pemontto","id":939704,"node_id":"MDQ6VXNlcjkzOTcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/939704?v=4","gravatar_id":"","url":"https://api.github.com/users/pemontto","html_url":"https://github.com/pemontto","followers_url":"https://api.github.com/users/pemontto/followers","following_url":"https://api.github.com/users/pemontto/following{/other_user}","gists_url":"https://api.github.com/users/pemontto/gists{/gist_id}","starred_url":"https://api.github.com/users/pemontto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pemontto/subscriptions","organizations_url":"https://api.github.com/users/pemontto/orgs","repos_url":"https://api.github.com/users/pemontto/repos","events_url":"https://api.github.com/users/pemontto/events{/privacy}","received_events_url":"https://api.github.com/users/pemontto/received_events","type":"User","site_admin":false},"body":"## Description:\r\nMy first PR here to add device_tracker support for Tilgin HG238x devices which my ISP Hyperoptic use. The device doesn't provide SSH or Telnet so you can only pull clients by logging in and scraping the status page.\r\n\r\nI've put this together taking inspiration from other device_trackers. Looking for feedback an guidance here.\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\ndevice_tracker:\r\n  - platform: tilgin\r\n    host: 192.168.1.1\r\n    username: admin\r\n    password: MrN00dles\r\n```\r\n\r\n## Checklist:\r\n  - [X] The code change is tested and works locally.\r\n  - [X] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [X] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [X] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [X] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [X] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-09-22T13:03:43Z","updated_at":"2018-09-22T13:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5d97eda248e545f007381ee3702eb224b80d643","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527909495,"node_id":"MDU6TGFiZWw1Mjc5MDk0OTU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-needed","name":"cla-needed","color":"ffff00","default":false},{"id":540056046,"node_id":"MDU6TGFiZWw1NDAwNTYwNDY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20device_tracker","name":"component: device_tracker","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":526146744,"node_id":"MDU6TGFiZWw1MjYxNDY3NDQ=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16791/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/6e14c783c66cf1b706eca36b51fa64f55b61abb1","head":{"label":"pemontto:dev","ref":"dev","sha":"6e14c783c66cf1b706eca36b51fa64f55b61abb1","user":{"login":"pemontto","id":939704,"node_id":"MDQ6VXNlcjkzOTcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/939704?v=4","gravatar_id":"","url":"https://api.github.com/users/pemontto","html_url":"https://github.com/pemontto","followers_url":"https://api.github.com/users/pemontto/followers","following_url":"https://api.github.com/users/pemontto/following{/other_user}","gists_url":"https://api.github.com/users/pemontto/gists{/gist_id}","starred_url":"https://api.github.com/users/pemontto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pemontto/subscriptions","organizations_url":"https://api.github.com/users/pemontto/orgs","repos_url":"https://api.github.com/users/pemontto/repos","events_url":"https://api.github.com/users/pemontto/events{/privacy}","received_events_url":"https://api.github.com/users/pemontto/received_events","type":"User","site_admin":false},"repo":{"id":149869953,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4Njk5NTM=","name":"home-assistant","full_name":"pemontto/home-assistant","private":false,"owner":{"login":"pemontto","id":939704,"node_id":"MDQ6VXNlcjkzOTcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/939704?v=4","gravatar_id":"","url":"https://api.github.com/users/pemontto","html_url":"https://github.com/pemontto","followers_url":"https://api.github.com/users/pemontto/followers","following_url":"https://api.github.com/users/pemontto/following{/other_user}","gists_url":"https://api.github.com/users/pemontto/gists{/gist_id}","starred_url":"https://api.github.com/users/pemontto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pemontto/subscriptions","organizations_url":"https://api.github.com/users/pemontto/orgs","repos_url":"https://api.github.com/users/pemontto/repos","events_url":"https://api.github.com/users/pemontto/events{/privacy}","received_events_url":"https://api.github.com/users/pemontto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pemontto/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":true,"url":"https://api.github.com/repos/pemontto/home-assistant","forks_url":"https://api.github.com/repos/pemontto/home-assistant/forks","keys_url":"https://api.github.com/repos/pemontto/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pemontto/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pemontto/home-assistant/teams","hooks_url":"https://api.github.com/repos/pemontto/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/pemontto/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/pemontto/home-assistant/events","assignees_url":"https://api.github.com/repos/pemontto/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/pemontto/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/pemontto/home-assistant/tags","blobs_url":"https://api.github.com/repos/pemontto/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pemontto/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pemontto/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/pemontto/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pemontto/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/pemontto/home-assistant/languages","stargazers_url":"https://api.github.com/repos/pemontto/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/pemontto/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/pemontto/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/pemontto/home-assistant/subscription","commits_url":"https://api.github.com/repos/pemontto/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/pemontto/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/pemontto/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/pemontto/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/pemontto/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/pemontto/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pemontto/home-assistant/merges","archive_url":"https://api.github.com/repos/pemontto/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pemontto/home-assistant/downloads","issues_url":"https://api.github.com/repos/pemontto/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/pemontto/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/pemontto/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/pemontto/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pemontto/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/pemontto/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/pemontto/home-assistant/deployments","created_at":"2018-09-22T11:17:16Z","updated_at":"2018-09-22T12:32:30Z","pushed_at":"2018-09-22T12:32:25Z","git_url":"git://github.com/pemontto/home-assistant.git","ssh_url":"git@github.com:pemontto/home-assistant.git","clone_url":"https://github.com/pemontto/home-assistant.git","svn_url":"https://github.com/pemontto/home-assistant","homepage":"https://www.home-assistant.io","size":89648,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"eec6722cf4c13c178f89032fcac0a4895641f5f1","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-09-22T12:54:14Z","pushed_at":"2018-09-22T13:03:44Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":89648,"stargazers_count":16882,"watchers_count":16882,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4964,"mirror_url":null,"archived":false,"open_issues_count":872,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4964,"open_issues":872,"watchers":16882,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/16791"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16791"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16791/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16791/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/6e14c783c66cf1b706eca36b51fa64f55b61abb1"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}