{"action":"created","issue":{"url":"https://api.github.com/repos/Level/abstract-leveldown/issues/285","repository_url":"https://api.github.com/repos/Level/abstract-leveldown","labels_url":"https://api.github.com/repos/Level/abstract-leveldown/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/Level/abstract-leveldown/issues/285/comments","events_url":"https://api.github.com/repos/Level/abstract-leveldown/issues/285/events","html_url":"https://github.com/Level/abstract-leveldown/issues/285","id":341235799,"node_id":"MDU6SXNzdWUzNDEyMzU3OTk=","number":285,"title":".sync() not called from .all() in put-test.js","user":{"login":"ralphtheninja","id":308049,"node_id":"MDQ6VXNlcjMwODA0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/308049?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphtheninja","html_url":"https://github.com/ralphtheninja","followers_url":"https://api.github.com/users/ralphtheninja/followers","following_url":"https://api.github.com/users/ralphtheninja/following{/other_user}","gists_url":"https://api.github.com/users/ralphtheninja/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphtheninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphtheninja/subscriptions","organizations_url":"https://api.github.com/users/ralphtheninja/orgs","repos_url":"https://api.github.com/users/ralphtheninja/repos","events_url":"https://api.github.com/users/ralphtheninja/events{/privacy}","received_events_url":"https://api.github.com/users/ralphtheninja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Level/abstract-leveldown/milestones/2","html_url":"https://github.com/Level/abstract-leveldown/milestone/2","labels_url":"https://api.github.com/repos/Level/abstract-leveldown/milestones/2/labels","id":3480186,"node_id":"MDk6TWlsZXN0b25lMzQ4MDE4Ng==","number":2,"title":"v6","description":"","creator":{"login":"vweevers","id":3055345,"node_id":"MDQ6VXNlcjMwNTUzNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3055345?v=4","gravatar_id":"","url":"https://api.github.com/users/vweevers","html_url":"https://github.com/vweevers","followers_url":"https://api.github.com/users/vweevers/followers","following_url":"https://api.github.com/users/vweevers/following{/other_user}","gists_url":"https://api.github.com/users/vweevers/gists{/gist_id}","starred_url":"https://api.github.com/users/vweevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vweevers/subscriptions","organizations_url":"https://api.github.com/users/vweevers/orgs","repos_url":"https://api.github.com/users/vweevers/repos","events_url":"https://api.github.com/users/vweevers/events{/privacy}","received_events_url":"https://api.github.com/users/vweevers/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":19,"state":"open","created_at":"2018-07-07T13:22:26Z","updated_at":"2018-07-14T13:55:43Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-07-14T13:15:26Z","updated_at":"2018-07-14T14:36:43Z","closed_at":null,"author_association":"MEMBER","body":"https://github.com/Level/abstract-leveldown/blob/48484ce12e8e59c0665b50b4bc085809bd662cf4/test/put-test.js#L97-L117\r\n\r\nDoes this have any implications? Should it be moved to `leveldown`?"},"comment":{"url":"https://api.github.com/repos/Level/abstract-leveldown/issues/comments/405027506","html_url":"https://github.com/Level/abstract-leveldown/issues/285#issuecomment-405027506","issue_url":"https://api.github.com/repos/Level/abstract-leveldown/issues/285","id":405027506,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTAyNzUwNg==","user":{"login":"vweevers","id":3055345,"node_id":"MDQ6VXNlcjMwNTUzNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3055345?v=4","gravatar_id":"","url":"https://api.github.com/users/vweevers","html_url":"https://github.com/vweevers","followers_url":"https://api.github.com/users/vweevers/followers","following_url":"https://api.github.com/users/vweevers/following{/other_user}","gists_url":"https://api.github.com/users/vweevers/gists{/gist_id}","starred_url":"https://api.github.com/users/vweevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vweevers/subscriptions","organizations_url":"https://api.github.com/users/vweevers/orgs","repos_url":"https://api.github.com/users/vweevers/repos","events_url":"https://api.github.com/users/vweevers/events{/privacy}","received_events_url":"https://api.github.com/users/vweevers/received_events","type":"User","site_admin":false},"created_at":"2018-07-14T14:36:43Z","updated_at":"2018-07-14T14:36:43Z","author_association":"MEMBER","body":"While we're at it, I don't understand what this `sync` test actually tests. It does two tests. The first is just a `put()` with a `sync` option, but the result would be the same if you leave out `sync`. Might be better to test that the `sync` option is passed on to `_put()`. The second test seems to assume that `sync` means synchronous, but it isn't (in Node.js)."}}
{"actor":{"display_login":"vweevers"}}