{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/6958","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/6958/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/6958/comments","events_url":"https://api.github.com/repos/minio/minio/issues/6958/events","html_url":"https://github.com/minio/minio/pull/6958","id":390464315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjI1Njk1","number":6958,"title":"CopyObject: Set Content-Type to application/octet-stream if it is not set","user":{"login":"kannappanr","id":30541348,"node_id":"MDQ6VXNlcjMwNTQxMzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-13T00:15:09Z","updated_at":"2018-12-13T00:43:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6958","html_url":"https://github.com/minio/minio/pull/6958","diff_url":"https://github.com/minio/minio/pull/6958.diff","patch_url":"https://github.com/minio/minio/pull/6958.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nSet Content-Type by default to application/octet-stream, if the client does not set it.\r\n## Motivation and Context\r\nIn the case of Gateway, Azure and GCS set default content-type to '' and AWS sets it to `binary/octet-stream`. \r\nThere will be a consistent default content-type.\r\n\r\n## Regression\r\nNot sure\r\n\r\n## How Has This Been Tested?\r\nRun this fix in `Gateway S3` mode with `mint` and `minio-py`\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/446799780","html_url":"https://github.com/minio/minio/pull/6958#issuecomment-446799780","issue_url":"https://api.github.com/repos/minio/minio/issues/6958","id":446799780,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njc5OTc4MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-13T00:43:22Z","updated_at":"2018-12-13T00:43:22Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=h1) Report\n> Merging [#6958](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=desc) into [master](https://codecov.io/gh/minio/minio/commit/6f7c99a33325bb11431dd56a1d261a18e5293de3?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/minio/minio/pull/6958/graphs/tree.svg?width=650&token=4wG3Jysopw&height=150&src=pr)](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #6958      +/-   ##\n==========================================\n- Coverage   52.22%   52.19%   -0.03%     \n==========================================\n  Files         271      271              \n  Lines       42729    42732       +3     \n==========================================\n- Hits        22316    22306      -10     \n- Misses      18437    18449      +12     \n- Partials     1976     1977       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cmd/object-handlers.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-Y21kL29iamVjdC1oYW5kbGVycy5nbw==) | `54.05% <100%> (+0.07%)` | :arrow_up: |\n| [cmd/posix-list-dir\\_windows.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-Y21kL3Bvc2l4LWxpc3QtZGlyX3dpbmRvd3MuZ28=) | `60.29% <0%> (-4.42%)` | :arrow_down: |\n| [cmd/fs-v1-rwpool.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-Y21kL2ZzLXYxLXJ3cG9vbC5nbw==) | `70.68% <0%> (-1.73%)` | :arrow_down: |\n| [cmd/xl-sets.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-Y21kL3hsLXNldHMuZ28=) | `55.73% <0%> (-1.18%)` | :arrow_down: |\n| [cmd/fs-v1.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-Y21kL2ZzLXYxLmdv) | `63.37% <0%> (-0.12%)` | :arrow_down: |\n| [pkg/certs/certs.go](https://codecov.io/gh/minio/minio/pull/6958/diff?src=pr&el=tree#diff-cGtnL2NlcnRzL2NlcnRzLmdv) | `58.76% <0%> (+4.12%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=footer). Last update [6f7c99a...d366ec5](https://codecov.io/gh/minio/minio/pull/6958?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}