{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Options/pulls/comments/218919346","pull_request_review_id":156966182,"id":218919346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODkxOTM0Ng==","diff_hunk":"@@ -387,15 +387,29 @@ public ValidateOptionsResult Validate(string name, ComplexOptions options)\n             }\n         }\n \n-        private void ValidateFailure<TOptions>(OptionsValidationException e, string name = \"\", params string[] errors)\n+        private void ValidateFailure<TOptions>(OptionsValidationException e, string name = \"\", int count = 1, params string[] errorsToMatch)\n         {\n             Assert.Equal(typeof(TOptions), e.OptionsType);\n             Assert.Equal(name, e.OptionsName);\n-            if (errors.Length == 0)\n+            if (errorsToMatch.Length == 0)\n             {\n-                errors = new string[] { \"A validation error has occured.\" };\n+                errorsToMatch = new string[] { \"A validation error has occured.\" };\n+            }\n+            Assert.Equal(count, e.Failures.Count());\n+            // Check for the error in any of the failures\n+            foreach (var error in errorsToMatch)\n+            {\n+                var found = false;","path":"test/Microsoft.Extensions.Options.Test/OptionsBuilderTest.cs","position":null,"original_position":62,"commit_id":"75b3728541b396f05f6dafc735bd8970aede4f6c","original_commit_id":"929b91b213d19ad3c2ce59b694e7b4e4007a0084","user":{"login":"HaoK","id":6537861,"node_id":"MDQ6VXNlcjY1Mzc4NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6537861?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"Yeah good call, much more compact","created_at":"2018-09-19T18:40:07Z","updated_at":"2018-09-19T18:40:08Z","html_url":"https://github.com/aspnet/Options/pull/275#discussion_r218919346","pull_request_url":"https://api.github.com/repos/aspnet/Options/pulls/275","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Options/pulls/comments/218919346"},"html":{"href":"https://github.com/aspnet/Options/pull/275#discussion_r218919346"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Options/pulls/275"}},"in_reply_to_id":218631873},"pull_request":{"url":"https://api.github.com/repos/aspnet/Options/pulls/275","id":216421462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDIxNDYy","html_url":"https://github.com/aspnet/Options/pull/275","diff_url":"https://github.com/aspnet/Options/pull/275.diff","patch_url":"https://github.com/aspnet/Options/pull/275.patch","issue_url":"https://api.github.com/repos/aspnet/Options/issues/275","number":275,"state":"open","locked":false,"title":"Search for errors instead of expecting strict match","user":{"login":"HaoK","id":6537861,"node_id":"MDQ6VXNlcjY1Mzc4NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6537861?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"Print out actual errors so we can see why this test fails in the future, for https://github.com/aspnet/Home/issues/3506\r\n\r\n@Eilon @ajcvickers ","created_at":"2018-09-18T19:42:08Z","updated_at":"2018-09-19T18:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c00bc869653caaac0e50a0ea268c521a5a6ecd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Options/pulls/275/commits","review_comments_url":"https://api.github.com/repos/aspnet/Options/pulls/275/comments","review_comment_url":"https://api.github.com/repos/aspnet/Options/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Options/issues/275/comments","statuses_url":"https://api.github.com/repos/aspnet/Options/statuses/75b3728541b396f05f6dafc735bd8970aede4f6c","head":{"label":"aspnet:haok/flak","ref":"haok/flak","sha":"75b3728541b396f05f6dafc735bd8970aede4f6c","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20275431,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3NTQzMQ==","name":"Options","full_name":"aspnet/Options","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/Options","description":"A framework for accessing and configuring POCO settings.","fork":false,"url":"https://api.github.com/repos/aspnet/Options","forks_url":"https://api.github.com/repos/aspnet/Options/forks","keys_url":"https://api.github.com/repos/aspnet/Options/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Options/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Options/teams","hooks_url":"https://api.github.com/repos/aspnet/Options/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Options/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Options/events","assignees_url":"https://api.github.com/repos/aspnet/Options/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Options/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Options/tags","blobs_url":"https://api.github.com/repos/aspnet/Options/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Options/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Options/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Options/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Options/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Options/languages","stargazers_url":"https://api.github.com/repos/aspnet/Options/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Options/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Options/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Options/subscription","commits_url":"https://api.github.com/repos/aspnet/Options/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Options/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Options/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Options/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Options/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Options/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Options/merges","archive_url":"https://api.github.com/repos/aspnet/Options/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Options/downloads","issues_url":"https://api.github.com/repos/aspnet/Options/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Options/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Options/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Options/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Options/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Options/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Options/deployments","created_at":"2014-05-28T23:13:36Z","updated_at":"2018-09-16T19:26:27Z","pushed_at":"2018-09-19T18:39:48Z","git_url":"git://github.com/aspnet/Options.git","ssh_url":"git@github.com:aspnet/Options.git","clone_url":"https://github.com/aspnet/Options.git","svn_url":"https://github.com/aspnet/Options","homepage":"","size":562,"stargazers_count":133,"watchers_count":133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":4,"watchers":133,"default_branch":"master"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"6127812e29dbb9041e7e9ac8375cf8f29ea01a60","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20275431,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3NTQzMQ==","name":"Options","full_name":"aspnet/Options","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/Options","description":"A framework for accessing and configuring POCO settings.","fork":false,"url":"https://api.github.com/repos/aspnet/Options","forks_url":"https://api.github.com/repos/aspnet/Options/forks","keys_url":"https://api.github.com/repos/aspnet/Options/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Options/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Options/teams","hooks_url":"https://api.github.com/repos/aspnet/Options/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Options/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Options/events","assignees_url":"https://api.github.com/repos/aspnet/Options/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Options/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Options/tags","blobs_url":"https://api.github.com/repos/aspnet/Options/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Options/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Options/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Options/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Options/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Options/languages","stargazers_url":"https://api.github.com/repos/aspnet/Options/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Options/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Options/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Options/subscription","commits_url":"https://api.github.com/repos/aspnet/Options/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Options/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Options/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Options/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Options/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Options/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Options/merges","archive_url":"https://api.github.com/repos/aspnet/Options/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Options/downloads","issues_url":"https://api.github.com/repos/aspnet/Options/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Options/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Options/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Options/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Options/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Options/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Options/deployments","created_at":"2014-05-28T23:13:36Z","updated_at":"2018-09-16T19:26:27Z","pushed_at":"2018-09-19T18:39:48Z","git_url":"git://github.com/aspnet/Options.git","ssh_url":"git@github.com:aspnet/Options.git","clone_url":"https://github.com/aspnet/Options.git","svn_url":"https://github.com/aspnet/Options","homepage":"","size":562,"stargazers_count":133,"watchers_count":133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":4,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Options/pulls/275"},"html":{"href":"https://github.com/aspnet/Options/pull/275"},"issue":{"href":"https://api.github.com/repos/aspnet/Options/issues/275"},"comments":{"href":"https://api.github.com/repos/aspnet/Options/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Options/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Options/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Options/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Options/statuses/75b3728541b396f05f6dafc735bd8970aede4f6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HaoK"}}