{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/385","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/385/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/385/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/385/events","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/385","id":371622768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDI5MjE4","number":385,"title":"[WIP] Adds full specs for restoring pg_dump and pg_basebackup backups","user":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"labels":[{"id":534047521,"node_id":"MDU6TGFiZWw1MzQwNDc1MjE=","url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"assignees":[{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-18T16:57:44Z","updated_at":"2018-10-23T22:56:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/385","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/385","diff_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/385.diff","patch_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/385.patch"},"body":"This lays the ground work for some further refactoring changes to the restore tasks in `PostgresAdmin` by adding specs to confirm existing functionality.\n\nThere is a bunch of additional information in the commit messages, so please read those for further information for now.  I will probably update this description to it's normal \"book length\" size you are used to in the future."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/comments/432450853","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/385#issuecomment-432450853","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/385","id":432450853,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ1MDg1Mw==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T22:56:19Z","updated_at":"2018-10-23T22:56:19Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/NickLaMuro/manageiq-gems-pending/compare/be8c12a3d731abc2480f1b22d70f686388afd304~...562ac9c46b3a4ef62b1ea041e2785a06c2f4780a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n8 files checked, 9 offenses detected\n\n**lib/gems/pending/util/postgres_admin.rb**\n- [ ] :exclamation: - [Line 122](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L122), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n- [ ] :exclamation: - [Line 124](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L124), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n- [ ] :exclamation: - [Line 79](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L79), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n- [ ] :exclamation: - [Line 81](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L81), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n- [ ] :exclamation: - [Line 83](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L83), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n- [ ] :exclamation: - [Line 85](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/lib/gems/pending/util/postgres_admin.rb#L85), Col 5 - [Rails/Output](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Rails/Output) - Do not write to stdout. Use Rails's logger if you want to log.\n\n**spec/support/contexts/db_restore.rb**\n- [ ] :exclamation: - [Line 64](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/spec/support/contexts/db_restore.rb#L64), Col 17 - [Style/MethodDefParentheses](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/MethodDefParentheses) - Use def with parentheses when there are parameters.\n- [ ] :exclamation: - [Line 66](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/spec/support/contexts/db_restore.rb#L66), Col 3 - [Style/RescueStandardError](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/RescueStandardError) - Avoid rescuing without specifying an error class.\n\n**spec/support/mixins/pg_root_role_creator.rb**\n- [ ] :exclamation: - [Line 47](https://github.com/NickLaMuro/manageiq-gems-pending/blob/562ac9c46b3a4ef62b1ea041e2785a06c2f4780a/spec/support/mixins/pg_root_role_creator.rb#L47), Col 44 - [Layout/SpaceInsideParens](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/SpaceInsideParens) - Space inside parentheses detected.\n"}}
{"actor":{"display_login":"miq-bot"}}