{"action":"created","comment":{"url":"https://api.github.com/repos/uber-web/baseui/pulls/comments/224295895","pull_request_review_id":163627173,"id":224295895,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI5NTg5NQ==","diff_hunk":"@@ -25,5 +35,5 @@ export default function deepMerge(\n }\n \n function isCloneable(obj: mixed) {\n-  return Array.isArray(obj) || {}.toString.call(obj) == '[object Object]';\n+  return typeof obj === 'object' || typeof obj === 'function';","path":"src/utils/deep-merge.js","position":41,"original_position":41,"commit_id":"7859e058c90622b4eac41243142c090cba255e49","original_commit_id":"7859e058c90622b4eac41243142c090cba255e49","user":{"login":"nadiia","id":1920399,"node_id":"MDQ6VXNlcjE5MjAzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1920399?v=4","gravatar_id":"","url":"https://api.github.com/users/nadiia","html_url":"https://github.com/nadiia","followers_url":"https://api.github.com/users/nadiia/followers","following_url":"https://api.github.com/users/nadiia/following{/other_user}","gists_url":"https://api.github.com/users/nadiia/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiia/subscriptions","organizations_url":"https://api.github.com/users/nadiia/orgs","repos_url":"https://api.github.com/users/nadiia/repos","events_url":"https://api.github.com/users/nadiia/events{/privacy}","received_events_url":"https://api.github.com/users/nadiia/received_events","type":"User","site_admin":false},"body":"Why do you consider functions and `null` cloneable?","created_at":"2018-10-11T02:14:23Z","updated_at":"2018-10-11T02:14:33Z","html_url":"https://github.com/uber-web/baseui/pull/376#discussion_r224295895","pull_request_url":"https://api.github.com/repos/uber-web/baseui/pulls/376","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/comments/224295895"},"html":{"href":"https://github.com/uber-web/baseui/pull/376#discussion_r224295895"},"pull_request":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/uber-web/baseui/pulls/376","id":221972908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTcyOTA4","html_url":"https://github.com/uber-web/baseui/pull/376","diff_url":"https://github.com/uber-web/baseui/pull/376.diff","patch_url":"https://github.com/uber-web/baseui/pull/376.patch","issue_url":"https://api.github.com/repos/uber-web/baseui/issues/376","number":376,"state":"open","locked":false,"title":"feat: improve deep merge function","user":{"login":"blackswanny","id":1851469,"node_id":"MDQ6VXNlcjE4NTE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1851469?v=4","gravatar_id":"","url":"https://api.github.com/users/blackswanny","html_url":"https://github.com/blackswanny","followers_url":"https://api.github.com/users/blackswanny/followers","following_url":"https://api.github.com/users/blackswanny/following{/other_user}","gists_url":"https://api.github.com/users/blackswanny/gists{/gist_id}","starred_url":"https://api.github.com/users/blackswanny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackswanny/subscriptions","organizations_url":"https://api.github.com/users/blackswanny/orgs","repos_url":"https://api.github.com/users/blackswanny/repos","events_url":"https://api.github.com/users/blackswanny/events{/privacy}","received_events_url":"https://api.github.com/users/blackswanny/received_events","type":"User","site_admin":false},"body":"improve deep merge function  to avoid stack overflow and possible circular dependency","created_at":"2018-10-11T00:32:55Z","updated_at":"2018-10-11T02:14:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"837cd08756ac7e4c66807b0cb51d6a07e28f956b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":861027218,"node_id":"MDU6TGFiZWw4NjEwMjcyMTg=","url":"https://api.github.com/repos/uber-web/baseui/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1053349575,"node_id":"MDU6TGFiZWwxMDUzMzQ5NTc1","url":"https://api.github.com/repos/uber-web/baseui/labels/feature","name":"feature","color":"46f262","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uber-web/baseui/pulls/376/commits","review_comments_url":"https://api.github.com/repos/uber-web/baseui/pulls/376/comments","review_comment_url":"https://api.github.com/repos/uber-web/baseui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-web/baseui/issues/376/comments","statuses_url":"https://api.github.com/repos/uber-web/baseui/statuses/7859e058c90622b4eac41243142c090cba255e49","head":{"label":"uber-web:deep-merge-improve","ref":"deep-merge-improve","sha":"7859e058c90622b4eac41243142c090cba255e49","user":{"login":"uber-web","id":20204342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjA0MzQy","avatar_url":"https://avatars3.githubusercontent.com/u/20204342?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-web","html_url":"https://github.com/uber-web","followers_url":"https://api.github.com/users/uber-web/followers","following_url":"https://api.github.com/users/uber-web/following{/other_user}","gists_url":"https://api.github.com/users/uber-web/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-web/subscriptions","organizations_url":"https://api.github.com/users/uber-web/orgs","repos_url":"https://api.github.com/users/uber-web/repos","events_url":"https://api.github.com/users/uber-web/events{/privacy}","received_events_url":"https://api.github.com/users/uber-web/received_events","type":"Organization","site_admin":false},"repo":{"id":124470321,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0NzAzMjE=","name":"baseui","full_name":"uber-web/baseui","private":false,"owner":{"login":"uber-web","id":20204342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjA0MzQy","avatar_url":"https://avatars3.githubusercontent.com/u/20204342?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-web","html_url":"https://github.com/uber-web","followers_url":"https://api.github.com/users/uber-web/followers","following_url":"https://api.github.com/users/uber-web/following{/other_user}","gists_url":"https://api.github.com/users/uber-web/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-web/subscriptions","organizations_url":"https://api.github.com/users/uber-web/orgs","repos_url":"https://api.github.com/users/uber-web/repos","events_url":"https://api.github.com/users/uber-web/events{/privacy}","received_events_url":"https://api.github.com/users/uber-web/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber-web/baseui","description":"A React Component library implementing the Base UI design","fork":false,"url":"https://api.github.com/repos/uber-web/baseui","forks_url":"https://api.github.com/repos/uber-web/baseui/forks","keys_url":"https://api.github.com/repos/uber-web/baseui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-web/baseui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-web/baseui/teams","hooks_url":"https://api.github.com/repos/uber-web/baseui/hooks","issue_events_url":"https://api.github.com/repos/uber-web/baseui/issues/events{/number}","events_url":"https://api.github.com/repos/uber-web/baseui/events","assignees_url":"https://api.github.com/repos/uber-web/baseui/assignees{/user}","branches_url":"https://api.github.com/repos/uber-web/baseui/branches{/branch}","tags_url":"https://api.github.com/repos/uber-web/baseui/tags","blobs_url":"https://api.github.com/repos/uber-web/baseui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-web/baseui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-web/baseui/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-web/baseui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-web/baseui/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-web/baseui/languages","stargazers_url":"https://api.github.com/repos/uber-web/baseui/stargazers","contributors_url":"https://api.github.com/repos/uber-web/baseui/contributors","subscribers_url":"https://api.github.com/repos/uber-web/baseui/subscribers","subscription_url":"https://api.github.com/repos/uber-web/baseui/subscription","commits_url":"https://api.github.com/repos/uber-web/baseui/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-web/baseui/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-web/baseui/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-web/baseui/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-web/baseui/contents/{+path}","compare_url":"https://api.github.com/repos/uber-web/baseui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-web/baseui/merges","archive_url":"https://api.github.com/repos/uber-web/baseui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-web/baseui/downloads","issues_url":"https://api.github.com/repos/uber-web/baseui/issues{/number}","pulls_url":"https://api.github.com/repos/uber-web/baseui/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-web/baseui/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-web/baseui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-web/baseui/labels{/name}","releases_url":"https://api.github.com/repos/uber-web/baseui/releases{/id}","deployments_url":"https://api.github.com/repos/uber-web/baseui/deployments","created_at":"2018-03-09T01:32:10Z","updated_at":"2018-10-10T17:49:59Z","pushed_at":"2018-10-11T00:32:56Z","git_url":"git://github.com/uber-web/baseui.git","ssh_url":"git@github.com:uber-web/baseui.git","clone_url":"https://github.com/uber-web/baseui.git","svn_url":"https://github.com/uber-web/baseui","homepage":"https://baseui.netlify.com","size":3719,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":32,"watchers":131,"default_branch":"master"}},"base":{"label":"uber-web:master","ref":"master","sha":"344344fe8527406a34370a8d7633dd6859243f15","user":{"login":"uber-web","id":20204342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjA0MzQy","avatar_url":"https://avatars3.githubusercontent.com/u/20204342?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-web","html_url":"https://github.com/uber-web","followers_url":"https://api.github.com/users/uber-web/followers","following_url":"https://api.github.com/users/uber-web/following{/other_user}","gists_url":"https://api.github.com/users/uber-web/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-web/subscriptions","organizations_url":"https://api.github.com/users/uber-web/orgs","repos_url":"https://api.github.com/users/uber-web/repos","events_url":"https://api.github.com/users/uber-web/events{/privacy}","received_events_url":"https://api.github.com/users/uber-web/received_events","type":"Organization","site_admin":false},"repo":{"id":124470321,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0NzAzMjE=","name":"baseui","full_name":"uber-web/baseui","private":false,"owner":{"login":"uber-web","id":20204342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjA0MzQy","avatar_url":"https://avatars3.githubusercontent.com/u/20204342?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-web","html_url":"https://github.com/uber-web","followers_url":"https://api.github.com/users/uber-web/followers","following_url":"https://api.github.com/users/uber-web/following{/other_user}","gists_url":"https://api.github.com/users/uber-web/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-web/subscriptions","organizations_url":"https://api.github.com/users/uber-web/orgs","repos_url":"https://api.github.com/users/uber-web/repos","events_url":"https://api.github.com/users/uber-web/events{/privacy}","received_events_url":"https://api.github.com/users/uber-web/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber-web/baseui","description":"A React Component library implementing the Base UI design","fork":false,"url":"https://api.github.com/repos/uber-web/baseui","forks_url":"https://api.github.com/repos/uber-web/baseui/forks","keys_url":"https://api.github.com/repos/uber-web/baseui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-web/baseui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-web/baseui/teams","hooks_url":"https://api.github.com/repos/uber-web/baseui/hooks","issue_events_url":"https://api.github.com/repos/uber-web/baseui/issues/events{/number}","events_url":"https://api.github.com/repos/uber-web/baseui/events","assignees_url":"https://api.github.com/repos/uber-web/baseui/assignees{/user}","branches_url":"https://api.github.com/repos/uber-web/baseui/branches{/branch}","tags_url":"https://api.github.com/repos/uber-web/baseui/tags","blobs_url":"https://api.github.com/repos/uber-web/baseui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-web/baseui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-web/baseui/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-web/baseui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-web/baseui/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-web/baseui/languages","stargazers_url":"https://api.github.com/repos/uber-web/baseui/stargazers","contributors_url":"https://api.github.com/repos/uber-web/baseui/contributors","subscribers_url":"https://api.github.com/repos/uber-web/baseui/subscribers","subscription_url":"https://api.github.com/repos/uber-web/baseui/subscription","commits_url":"https://api.github.com/repos/uber-web/baseui/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-web/baseui/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-web/baseui/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-web/baseui/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-web/baseui/contents/{+path}","compare_url":"https://api.github.com/repos/uber-web/baseui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-web/baseui/merges","archive_url":"https://api.github.com/repos/uber-web/baseui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-web/baseui/downloads","issues_url":"https://api.github.com/repos/uber-web/baseui/issues{/number}","pulls_url":"https://api.github.com/repos/uber-web/baseui/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-web/baseui/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-web/baseui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-web/baseui/labels{/name}","releases_url":"https://api.github.com/repos/uber-web/baseui/releases{/id}","deployments_url":"https://api.github.com/repos/uber-web/baseui/deployments","created_at":"2018-03-09T01:32:10Z","updated_at":"2018-10-10T17:49:59Z","pushed_at":"2018-10-11T00:32:56Z","git_url":"git://github.com/uber-web/baseui.git","ssh_url":"git@github.com:uber-web/baseui.git","clone_url":"https://github.com/uber-web/baseui.git","svn_url":"https://github.com/uber-web/baseui","homepage":"https://baseui.netlify.com","size":3719,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":32,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/376"},"html":{"href":"https://github.com/uber-web/baseui/pull/376"},"issue":{"href":"https://api.github.com/repos/uber-web/baseui/issues/376"},"comments":{"href":"https://api.github.com/repos/uber-web/baseui/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-web/baseui/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/uber-web/baseui/statuses/7859e058c90622b4eac41243142c090cba255e49"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nadiia"}}