{"action":"created","issue":{"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/97","repository_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer","labels_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/97/comments","events_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/97/events","html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/97","id":366252186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTcyMzIx","number":97,"title":"fix_potential_errors_of_video_and_audio_streams_ffmpegvideo","user":{"login":"onon765trb","id":24803846,"node_id":"MDQ6VXNlcjI0ODAzODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/24803846?v=4","gravatar_id":"","url":"https://api.github.com/users/onon765trb","html_url":"https://github.com/onon765trb","followers_url":"https://api.github.com/users/onon765trb/followers","following_url":"https://api.github.com/users/onon765trb/following{/other_user}","gists_url":"https://api.github.com/users/onon765trb/gists{/gist_id}","starred_url":"https://api.github.com/users/onon765trb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onon765trb/subscriptions","organizations_url":"https://api.github.com/users/onon765trb/orgs","repos_url":"https://api.github.com/users/onon765trb/repos","events_url":"https://api.github.com/users/onon765trb/events{/privacy}","received_events_url":"https://api.github.com/users/onon765trb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-03T09:37:26Z","updated_at":"2018-10-08T09:51:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/97","html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/97","diff_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/97.diff","patch_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/97.patch"},"body":"Fix  potential_errors\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/digitalmediaserver/digitalmediaserver/97)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/comments/427777498","html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/97#issuecomment-427777498","issue_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/97","id":427777498,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzc3NzQ5OA==","user":{"login":"onon765trb","id":24803846,"node_id":"MDQ6VXNlcjI0ODAzODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/24803846?v=4","gravatar_id":"","url":"https://api.github.com/users/onon765trb","html_url":"https://github.com/onon765trb","followers_url":"https://api.github.com/users/onon765trb/followers","following_url":"https://api.github.com/users/onon765trb/following{/other_user}","gists_url":"https://api.github.com/users/onon765trb/gists{/gist_id}","starred_url":"https://api.github.com/users/onon765trb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onon765trb/subscriptions","organizations_url":"https://api.github.com/users/onon765trb/orgs","repos_url":"https://api.github.com/users/onon765trb/repos","events_url":"https://api.github.com/users/onon765trb/events{/privacy}","received_events_url":"https://api.github.com/users/onon765trb/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T09:51:50Z","updated_at":"2018-10-08T09:51:50Z","author_association":"NONE","body":" > I assume that there can be any number of other arguments betwwen `x264opts`/`264.params` and the `cfr`/`bitrate` etc part? \r\n\r\nYou are right. At first, I tried\r\n`if (!customFFmpegOptions.matches(\".*-(crf|b|b:v|q|q:v|(x264opts|x264-params) +([^ =]+=)*(crf|bitrate|B|q|qp)=).*\"))`\r\nThis should be corrected as follows\r\n`if (!customFFmpegOptions.matches(\".*-(crf|b|b:v|(x264opts|x264-params) +([^ =]+=:)*(crf|bitrate|B|q|qp)=).*\"))`\r\n\r\nI though using `.*` is sure \r\n\r\n> In general there's no reason to use capturing groups when you don't need the results of the capture.\r\nDoes it mean that there a way to avoid duplicate options."}}
{"actor":{"display_login":"onon765trb"}}