{"action":"created","comment":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/243277611","pull_request_review_id":187003755,"id":243277611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI3NzYxMQ==","diff_hunk":"@@ -98,8 +110,16 @@ class ValueSegmentIterable : public PointAccessibleSegmentIterable<ValueSegmentI\n       ++_chunk_offset;\n     }\n \n+    void advance(std::ptrdiff_t n) {","path":"src/lib/storage/value_segment/value_segment_iterable.hpp","position":39,"original_position":39,"commit_id":"2266076ceab419e9faaf7f53f6dd1fe1665eece4","original_commit_id":"e3b10e7bbb9cd9b73ef78da7f08d6dcd7ec90ecf","user":{"login":"mrzzzrm","id":2679018,"node_id":"MDQ6VXNlcjI2NzkwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2679018?v=4","gravatar_id":"","url":"https://api.github.com/users/mrzzzrm","html_url":"https://github.com/mrzzzrm","followers_url":"https://api.github.com/users/mrzzzrm/followers","following_url":"https://api.github.com/users/mrzzzrm/following{/other_user}","gists_url":"https://api.github.com/users/mrzzzrm/gists{/gist_id}","starred_url":"https://api.github.com/users/mrzzzrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrzzzrm/subscriptions","organizations_url":"https://api.github.com/users/mrzzzrm/orgs","repos_url":"https://api.github.com/users/mrzzzrm/repos","events_url":"https://api.github.com/users/mrzzzrm/events{/privacy}","received_events_url":"https://api.github.com/users/mrzzzrm/received_events","type":"User","site_admin":false},"body":"If this is definitely going to be used by an impending PR, keep it in, otherwise it's obsolete code and should be removed.","created_at":"2018-12-20T13:50:55Z","updated_at":"2018-12-20T13:50:55Z","html_url":"https://github.com/hyrise/hyrise/pull/1377#discussion_r243277611","pull_request_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1377","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/243277611"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1377#discussion_r243277611"},"pull_request":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1377"}},"in_reply_to_id":243214563},"pull_request":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/1377","id":239519356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTE5MzU2","html_url":"https://github.com/hyrise/hyrise/pull/1377","diff_url":"https://github.com/hyrise/hyrise/pull/1377.diff","patch_url":"https://github.com/hyrise/hyrise/pull/1377.patch","issue_url":"https://api.github.com/repos/hyrise/hyrise/issues/1377","number":1377,"state":"open","locked":false,"title":"SIMD support, Take 2","user":{"login":"mrks","id":575106,"node_id":"MDQ6VXNlcjU3NTEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/575106?v=4","gravatar_id":"","url":"https://api.github.com/users/mrks","html_url":"https://github.com/mrks","followers_url":"https://api.github.com/users/mrks/followers","following_url":"https://api.github.com/users/mrks/following{/other_user}","gists_url":"https://api.github.com/users/mrks/gists{/gist_id}","starred_url":"https://api.github.com/users/mrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrks/subscriptions","organizations_url":"https://api.github.com/users/mrks/orgs","repos_url":"https://api.github.com/users/mrks/repos","events_url":"https://api.github.com/users/mrks/events{/privacy}","received_events_url":"https://api.github.com/users/mrks/received_events","type":"User","site_admin":false},"body":"*The original PR was not maintained for too long. I rebased all changes on top of the current master. All previous comments were already addressed and nothing should be lost.*\r\n\r\n*What is missing is an analysis of the occasional performance degradation. Also, we want to test the SIMD code directly (so that it is used even on a non-AVX-512 machine)*\r\n\r\nThis adds SIMD support to the table scan. As there are very few TPC-H queries where the scan is the main bottleneck, real benefits can only be seen for TPC-H 6.\r\n\r\nIn a couple of cases, the performance degrades slightly, especially when the selectivity is high. In total, however, the benefits outweigh.\r\n\r\nRoughly a third of the new lines are comments. I hope that it is somewhat helpful in understanding what I'm trying to do here.\r\n\r\n```\r\n+-----------+---------------+-------+---------------+-------+--------+---------------------------------+\r\n| Benchmark | prev. iter/s  | runs  | new iter/s    | runs  | change | p-value (significant if <0.001) |\r\n+-----------+---------------+-------+---------------+-------+--------+---------------------------------+\r\n| TPC-H 1   | 6.09232711792 | 366   | 6.23757696152 | 375   | +2%    |                          0.0000 |\r\n| TPC-H 2   | 111.50969696  | 6691  | 114.364372253 | 6862  | +3%    |     (run time too short) 0.0000 |\r\n| TPC-H 3   | 65.4121017456 | 3925  | 68.7526931763 | 4126  | +5%    |     (run time too short) 0.0000 |\r\n| TPC-H 4   | 24.0771007538 | 1445  | 23.4047050476 | 1405  | -3%    |     (run time too short) 0.0000 |\r\n| TPC-H 5   | 50.1611557007 | 3010  | 50.9984817505 | 3060  | +2%    |     (run time too short) 0.0000 |\r\n| TPC-H 6   | 193.462768555 | 10000 | 306.872833252 | 10000 | +59%   |     (run time too short) 0.0000 |\r\n| TPC-H 7   | 13.5323467255 | 812   | 13.2980260849 | 798   | -2%    |     (run time too short) 0.0000 |\r\n| TPC-H 8   | 86.0127792358 | 5161  | 87.9125900269 | 5275  | +2%    |     (run time too short) 0.0000 |\r\n| TPC-H 9   | 25.6442375183 | 1539  | 25.8123989105 | 1549  | +1%    |     (run time too short) 0.0000 |\r\n| TPC-H 10  | 34.4375534058 | 2067  | 34.5596008301 | 2074  | +0%    |     (run time too short) 0.0001 |\r\n| TPC-H 11  | 204.567932129 | 10000 | 206.614334106 | 10000 | +1%    |     (run time too short) 0.0000 |\r\n| TPC-H 12  | 63.5623054504 | 3814  | 61.3778076172 | 3683  | -3%    |     (run time too short) 0.0000 |\r\n| TPC-H 13  | 28.2691440582 | 1697  | 27.8599376678 | 1672  | -1%    |     (run time too short) 0.0000 |\r\n| TPC-H 14  | 192.171905518 | 10000 | 173.396286011 | 10000 | -10%   |     (run time too short) 0.0000 |\r\n| TPC-H 15  | 84.8957443237 | 5094  | 79.0128479004 | 4741  | -7%    |     (run time too short) 0.0000 |\r\n| TPC-H 16  | 55.2836685181 | 3318  | 53.3710365295 | 3203  | -3%    |     (run time too short) 0.0000 |\r\n| TPC-H 17  | 4.18775415421 | 252   | 4.50902414322 | 271   | +8%    |                          0.0000 |\r\n| TPC-H 18  | 17.0456829071 | 1023  | 16.8574485779 | 1012  | -1%    |     (run time too short) 0.0000 |\r\n| TPC-H 19  | 26.126083374  | 1568  | 26.7594051361 | 1606  | +2%    |     (run time too short) 0.0000 |\r\n| TPC-H 20  | 2.58466124535 | 156   | 2.67525339127 | 161   | +4%    |                          0.0000 |\r\n| TPC-H 21  | 1.3510119915  | 82    | 1.34058332443 | 81    | -1%    |                          0.2109 |\r\n| TPC-H 22  | 108.048973083 | 6483  | 106.559616089 | 6394  | -1%    |     (run time too short) 0.0000 |\r\n| average   |               |       |               |       | +3%    |                                 |\r\n+-----------+---------------+-------+---------------+-------+--------+---------------------------------+\r\n```","created_at":"2018-12-18T14:59:13Z","updated_at":"2018-12-20T13:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca7f27df1984ccd3948b70fb1163a7fa0b932b9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1377/commits","review_comments_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1377/comments","review_comment_url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyrise/hyrise/issues/1377/comments","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/2266076ceab419e9faaf7f53f6dd1fe1665eece4","head":{"label":"hyrise:mrks/simd-rebase-rebased","ref":"mrks/simd-rebase-rebased","sha":"2266076ceab419e9faaf7f53f6dd1fe1665eece4","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-12-20T03:59:55Z","pushed_at":"2018-12-20T13:35:17Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":20449,"stargazers_count":152,"watchers_count":152,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":77,"watchers":152,"default_branch":"master"}},"base":{"label":"hyrise:master","ref":"master","sha":"0bc175be957c488f4a82d34544ed92cf77e2f7f2","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-12-20T03:59:55Z","pushed_at":"2018-12-20T13:35:17Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":20449,"stargazers_count":152,"watchers_count":152,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":77,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1377"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1377"},"issue":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1377"},"comments":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1377/comments"},"review_comments":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1377/comments"},"review_comment":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1377/commits"},"statuses":{"href":"https://api.github.com/repos/hyrise/hyrise/statuses/2266076ceab419e9faaf7f53f6dd1fe1665eece4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mrzzzrm"}}