{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments/245140669","pull_request_review_id":188863881,"id":245140669,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTE0MDY2OQ==","diff_hunk":"@@ -809,10 +867,36 @@ func TestUpdateExistingServiceWithDesiredCountOverOne(t *testing.T) {\n \t// define expected client input given the above info\n \texpectedInput := getDefaultUpdateInput()\n \texpectedInput.serviceName = serviceName\n-\texpectedInput.count = *aws.Int64(int64(existingDesiredCount))\n+\texpectedInput.count = aws.Int64(int64(existingDesiredCount))\n+\n+\t// call tests\n+\tupdateServiceTest(t, flagSet, &config.CommandConfig{}, &utils.ECSParams{}, expectedInput, existingService)\n+}\n+\n+func TestUpdateExistingServiceWithDaemonSchedulingStrategy(t *testing.T) {","path":"ecs-cli/modules/cli/compose/entity/service/service_test.go","position":85,"original_position":85,"commit_id":"563e289ac820baf971954d125f186fcdba0593dc","original_commit_id":"563e289ac820baf971954d125f186fcdba0593dc","user":{"login":"allisaurus","id":34254888,"node_id":"MDQ6VXNlcjM0MjU0ODg4","avatar_url":"https://avatars1.githubusercontent.com/u/34254888?v=4","gravatar_id":"","url":"https://api.github.com/users/allisaurus","html_url":"https://github.com/allisaurus","followers_url":"https://api.github.com/users/allisaurus/followers","following_url":"https://api.github.com/users/allisaurus/following{/other_user}","gists_url":"https://api.github.com/users/allisaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/allisaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allisaurus/subscriptions","organizations_url":"https://api.github.com/users/allisaurus/orgs","repos_url":"https://api.github.com/users/allisaurus/repos","events_url":"https://api.github.com/users/allisaurus/events{/privacy}","received_events_url":"https://api.github.com/users/allisaurus/received_events","type":"User","site_admin":false},"body":"can you add a test that asserts an error is thrown if `updateService` is attempted with the `--scheduling-strategy` flag set?","created_at":"2019-01-03T21:35:33Z","updated_at":"2019-01-03T21:39:08Z","html_url":"https://github.com/aws/amazon-ecs-cli/pull/685#discussion_r245140669","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments/245140669"},"html":{"href":"https://github.com/aws/amazon-ecs-cli/pull/685#discussion_r245140669"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685","id":238785870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Nzg1ODcw","html_url":"https://github.com/aws/amazon-ecs-cli/pull/685","diff_url":"https://github.com/aws/amazon-ecs-cli/pull/685.diff","patch_url":"https://github.com/aws/amazon-ecs-cli/pull/685.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/685","number":685,"state":"open","locked":false,"title":"Adding --scheduling-strategy (REPLICA or DAEMON) option","user":{"login":"psharkey","id":8724209,"node_id":"MDQ6VXNlcjg3MjQyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8724209?v=4","gravatar_id":"","url":"https://api.github.com/users/psharkey","html_url":"https://github.com/psharkey","followers_url":"https://api.github.com/users/psharkey/followers","following_url":"https://api.github.com/users/psharkey/following{/other_user}","gists_url":"https://api.github.com/users/psharkey/gists{/gist_id}","starred_url":"https://api.github.com/users/psharkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psharkey/subscriptions","organizations_url":"https://api.github.com/users/psharkey/orgs","repos_url":"https://api.github.com/users/psharkey/repos","events_url":"https://api.github.com/users/psharkey/events{/privacy}","received_events_url":"https://api.github.com/users/psharkey/received_events","type":"User","site_admin":false},"body":"This partially addresses #540 \r\n\r\nAdding optional `--scheduling-strategy` flag  on `ecs-cli compose service create` and `ecs-cli compose service up` commands:\r\n\r\n`--scheduling-strategy value                          [Optional] Specifies the scheduling strategy type. Options: REPLICA (default) or DAEMON.` \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-12-14T17:07:16Z","updated_at":"2019-01-03T21:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b60578004b6db37db04047576ff8caa8b5555d99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/685/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/563e289ac820baf971954d125f186fcdba0593dc","head":{"label":"psharkey:scheduling-stagtegy","ref":"scheduling-stagtegy","sha":"563e289ac820baf971954d125f186fcdba0593dc","user":{"login":"psharkey","id":8724209,"node_id":"MDQ6VXNlcjg3MjQyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8724209?v=4","gravatar_id":"","url":"https://api.github.com/users/psharkey","html_url":"https://github.com/psharkey","followers_url":"https://api.github.com/users/psharkey/followers","following_url":"https://api.github.com/users/psharkey/following{/other_user}","gists_url":"https://api.github.com/users/psharkey/gists{/gist_id}","starred_url":"https://api.github.com/users/psharkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psharkey/subscriptions","organizations_url":"https://api.github.com/users/psharkey/orgs","repos_url":"https://api.github.com/users/psharkey/repos","events_url":"https://api.github.com/users/psharkey/events{/privacy}","received_events_url":"https://api.github.com/users/psharkey/received_events","type":"User","site_admin":false},"repo":{"id":161698344,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2OTgzNDQ=","name":"amazon-ecs-cli","full_name":"psharkey/amazon-ecs-cli","private":false,"owner":{"login":"psharkey","id":8724209,"node_id":"MDQ6VXNlcjg3MjQyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8724209?v=4","gravatar_id":"","url":"https://api.github.com/users/psharkey","html_url":"https://github.com/psharkey","followers_url":"https://api.github.com/users/psharkey/followers","following_url":"https://api.github.com/users/psharkey/following{/other_user}","gists_url":"https://api.github.com/users/psharkey/gists{/gist_id}","starred_url":"https://api.github.com/users/psharkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psharkey/subscriptions","organizations_url":"https://api.github.com/users/psharkey/orgs","repos_url":"https://api.github.com/users/psharkey/repos","events_url":"https://api.github.com/users/psharkey/events{/privacy}","received_events_url":"https://api.github.com/users/psharkey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/psharkey/amazon-ecs-cli","description":"The Amazon ECS CLI enables users to run their applications on ECS/Fargate using the Docker Compose file format, quickly provision resources, push/pull images in ECR, and monitor running applications on ECS/Fargate.","fork":true,"url":"https://api.github.com/repos/psharkey/amazon-ecs-cli","forks_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/forks","keys_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/teams","hooks_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/hooks","issue_events_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/events","assignees_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/tags","blobs_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/languages","stargazers_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/stargazers","contributors_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/contributors","subscribers_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/subscribers","subscription_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/subscription","commits_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/merges","archive_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/downloads","issues_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/labels{/name}","releases_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/releases{/id}","deployments_url":"https://api.github.com/repos/psharkey/amazon-ecs-cli/deployments","created_at":"2018-12-13T21:45:38Z","updated_at":"2018-12-13T21:45:41Z","pushed_at":"2019-01-03T00:44:31Z","git_url":"git://github.com/psharkey/amazon-ecs-cli.git","ssh_url":"git@github.com:psharkey/amazon-ecs-cli.git","clone_url":"https://github.com/psharkey/amazon-ecs-cli.git","svn_url":"https://github.com/psharkey/amazon-ecs-cli","homepage":"https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html","size":11811,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"e70f1b1ae0a638d3a29d08f8cbed0bcb245968e5","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":43446846,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ0Njg0Ng==","name":"amazon-ecs-cli","full_name":"aws/amazon-ecs-cli","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/amazon-ecs-cli","description":"The Amazon ECS CLI enables users to run their applications on ECS/Fargate using the Docker Compose file format, quickly provision resources, push/pull images in ECR, and monitor running applications on ECS/Fargate.","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-cli","forks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-cli/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-cli/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-cli/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-cli/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-cli/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-cli/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/deployments","created_at":"2015-09-30T17:11:40Z","updated_at":"2019-01-02T15:45:26Z","pushed_at":"2019-01-03T02:48:04Z","git_url":"git://github.com/aws/amazon-ecs-cli.git","ssh_url":"git@github.com:aws/amazon-ecs-cli.git","clone_url":"https://github.com/aws/amazon-ecs-cli.git","svn_url":"https://github.com/aws/amazon-ecs-cli","homepage":"https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html","size":11764,"stargazers_count":1058,"watchers_count":1058,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":181,"open_issues":60,"watchers":1058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685"},"html":{"href":"https://github.com/aws/amazon-ecs-cli/pull/685"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/685"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/685/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/685/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/563e289ac820baf971954d125f186fcdba0593dc"}},"author_association":"NONE"}}
{"actor":{"display_login":"allisaurus"}}