{"action":"opened","issue":{"url":"https://api.github.com/repos/alexrainman/CarouselView/issues/350","repository_url":"https://api.github.com/repos/alexrainman/CarouselView","labels_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/350/comments","events_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/350/events","html_url":"https://github.com/alexrainman/CarouselView/issues/350","id":295498785,"number":350,"title":"[Android] Master-Detail-Page","user":{"login":"kulbe-redlogix","id":36266111,"avatar_url":"https://avatars2.githubusercontent.com/u/36266111?v=4","gravatar_id":"","url":"https://api.github.com/users/kulbe-redlogix","html_url":"https://github.com/kulbe-redlogix","followers_url":"https://api.github.com/users/kulbe-redlogix/followers","following_url":"https://api.github.com/users/kulbe-redlogix/following{/other_user}","gists_url":"https://api.github.com/users/kulbe-redlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/kulbe-redlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kulbe-redlogix/subscriptions","organizations_url":"https://api.github.com/users/kulbe-redlogix/orgs","repos_url":"https://api.github.com/users/kulbe-redlogix/repos","events_url":"https://api.github.com/users/kulbe-redlogix/events{/privacy}","received_events_url":"https://api.github.com/users/kulbe-redlogix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-08T12:45:14Z","updated_at":"2018-02-08T12:45:14Z","closed_at":null,"author_association":"NONE","body":"We are using the CarouselView with a Master-Detail-Page Navigation. The problem is if you change the view from the NavigationPage with the CarouselView to another Page and then back to the Carousel Page again, the CarouselView will not be visible.\r\n\r\nWe found the problem in Element_SizeChanged, the variable canSetLayout is false and therefore the view will not be rendered again. The check for the layout was made because of Issue #136 that the page is recreated multiple times. We deleted the check and the Renderer is working as intended.\r\n\r\nI debugged the code with a Master-Detail-Page Navigation.\r\nAt the first time the method Element_SizeChanged is called three times:\r\n1. OnAttachedWindow (canSetLayout: false)\r\n- MainPageSizeChanged will be set canSetLayout back to false\r\n2. ElementSizeChanged (canSetLayout: false)\r\n3. ElementSizeChanged (canSetLayout: true) --> here the View is rendered initially\r\nIf the Master-Detail-Page is changing to another View the CarouselViewRenderer will be disposed. After switching back to the CarouselView again, a new CarouselViewRenderer will be created and the ElementSizeChanged is called only once (canSetLayout false).\r\n"}}
{"actor":{"display_login":"kulbe-redlogix"}}