{"action":"closed","number":1722,"pull_request":{"url":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722","id":201319141,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzE5MTQx","html_url":"https://github.com/travis-ci/travis-web/pull/1722","diff_url":"https://github.com/travis-ci/travis-web/pull/1722.diff","patch_url":"https://github.com/travis-ci/travis-web/pull/1722.patch","issue_url":"https://api.github.com/repos/travis-ci/travis-web/issues/1722","number":1722,"state":"closed","locked":false,"title":"[Port to master] Fix issue of localStorage getting cleared too often for the Enterprise License Banner\" ","user":{"login":"bnferguson","id":47749,"node_id":"MDQ6VXNlcjQ3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/47749?v=4","gravatar_id":"","url":"https://api.github.com/users/bnferguson","html_url":"https://github.com/bnferguson","followers_url":"https://api.github.com/users/bnferguson/followers","following_url":"https://api.github.com/users/bnferguson/following{/other_user}","gists_url":"https://api.github.com/users/bnferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/bnferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnferguson/subscriptions","organizations_url":"https://api.github.com/users/bnferguson/orgs","repos_url":"https://api.github.com/users/bnferguson/repos","events_url":"https://api.github.com/users/bnferguson/events{/privacy}","received_events_url":"https://api.github.com/users/bnferguson/received_events","type":"User","site_admin":false},"body":"This is port of the changes in https://github.com/travis-ci/travis-web/pull/1671 to `master`\r\n\r\nA while back we needed to do a quick fix in `enterprise-2.2` where we made it so banners would be sticky when you closed them. We didn't do this in `master` because ideally we'd rework this to not have some of the timing issues (can see more of the details in the original ticket). \r\n\r\nUnfortunately we don't have the time or manpower to do that at the moment and want to make sure when the next version of Travis CI Enterprise comes out, we don't have a regression of this bug, therefore, I'm porting it to master. :D \r\n\r\nThis should not affect hosted what so ever, and is already in production in Enterprise 2.2.1. ","created_at":"2018-07-13T15:06:59Z","updated_at":"2018-07-20T13:24:04Z","closed_at":"2018-07-20T13:24:04Z","merged_at":"2018-07-20T13:24:04Z","merge_commit_sha":"9ad8dd58e7a4aece8e89256313a4facbf15b4c04","assignee":{"login":"bnferguson","id":47749,"node_id":"MDQ6VXNlcjQ3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/47749?v=4","gravatar_id":"","url":"https://api.github.com/users/bnferguson","html_url":"https://github.com/bnferguson","followers_url":"https://api.github.com/users/bnferguson/followers","following_url":"https://api.github.com/users/bnferguson/following{/other_user}","gists_url":"https://api.github.com/users/bnferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/bnferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnferguson/subscriptions","organizations_url":"https://api.github.com/users/bnferguson/orgs","repos_url":"https://api.github.com/users/bnferguson/repos","events_url":"https://api.github.com/users/bnferguson/events{/privacy}","received_events_url":"https://api.github.com/users/bnferguson/received_events","type":"User","site_admin":false},"assignees":[{"login":"bnferguson","id":47749,"node_id":"MDQ6VXNlcjQ3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/47749?v=4","gravatar_id":"","url":"https://api.github.com/users/bnferguson","html_url":"https://github.com/bnferguson","followers_url":"https://api.github.com/users/bnferguson/followers","following_url":"https://api.github.com/users/bnferguson/following{/other_user}","gists_url":"https://api.github.com/users/bnferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/bnferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnferguson/subscriptions","organizations_url":"https://api.github.com/users/bnferguson/orgs","repos_url":"https://api.github.com/users/bnferguson/repos","events_url":"https://api.github.com/users/bnferguson/events{/privacy}","received_events_url":"https://api.github.com/users/bnferguson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722/commits","review_comments_url":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722/comments","review_comment_url":"https://api.github.com/repos/travis-ci/travis-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travis-ci/travis-web/issues/1722/comments","statuses_url":"https://api.github.com/repos/travis-ci/travis-web/statuses/4ea9296f1525385efeb468589fb99b163fe9387a","head":{"label":"travis-ci:bf-bring-banner-fix-to-master","ref":"bf-bring-banner-fix-to-master","sha":"4ea9296f1525385efeb468589fb99b163fe9387a","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":4693087,"node_id":"MDEwOlJlcG9zaXRvcnk0NjkzMDg3","name":"travis-web","full_name":"travis-ci/travis-web","owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/travis-web","description":"The Ember web client for Travis CI","fork":false,"url":"https://api.github.com/repos/travis-ci/travis-web","forks_url":"https://api.github.com/repos/travis-ci/travis-web/forks","keys_url":"https://api.github.com/repos/travis-ci/travis-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/travis-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/travis-web/teams","hooks_url":"https://api.github.com/repos/travis-ci/travis-web/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/travis-web/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/travis-web/events","assignees_url":"https://api.github.com/repos/travis-ci/travis-web/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/travis-web/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/travis-web/tags","blobs_url":"https://api.github.com/repos/travis-ci/travis-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/travis-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/travis-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/travis-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/travis-web/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/travis-web/languages","stargazers_url":"https://api.github.com/repos/travis-ci/travis-web/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/travis-web/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/travis-web/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/travis-web/subscription","commits_url":"https://api.github.com/repos/travis-ci/travis-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/travis-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/travis-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/travis-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/travis-web/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/travis-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/travis-web/merges","archive_url":"https://api.github.com/repos/travis-ci/travis-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/travis-web/downloads","issues_url":"https://api.github.com/repos/travis-ci/travis-web/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/travis-web/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/travis-web/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/travis-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/travis-web/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/travis-web/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/travis-web/deployments","created_at":"2012-06-17T16:30:56Z","updated_at":"2018-07-19T11:42:38Z","pushed_at":"2018-07-20T13:24:04Z","git_url":"git://github.com/travis-ci/travis-web.git","ssh_url":"git@github.com:travis-ci/travis-web.git","clone_url":"https://github.com/travis-ci/travis-web.git","svn_url":"https://github.com/travis-ci/travis-web","homepage":"https://travis-ci.org/","size":95351,"stargazers_count":527,"watchers_count":527,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":273,"open_issues":27,"watchers":527,"default_branch":"master"}},"base":{"label":"travis-ci:master","ref":"master","sha":"655c3c7cf35cd11f92b399ac0b9ec34628f5f45b","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":4693087,"node_id":"MDEwOlJlcG9zaXRvcnk0NjkzMDg3","name":"travis-web","full_name":"travis-ci/travis-web","owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/travis-web","description":"The Ember web client for Travis CI","fork":false,"url":"https://api.github.com/repos/travis-ci/travis-web","forks_url":"https://api.github.com/repos/travis-ci/travis-web/forks","keys_url":"https://api.github.com/repos/travis-ci/travis-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/travis-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/travis-web/teams","hooks_url":"https://api.github.com/repos/travis-ci/travis-web/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/travis-web/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/travis-web/events","assignees_url":"https://api.github.com/repos/travis-ci/travis-web/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/travis-web/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/travis-web/tags","blobs_url":"https://api.github.com/repos/travis-ci/travis-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/travis-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/travis-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/travis-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/travis-web/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/travis-web/languages","stargazers_url":"https://api.github.com/repos/travis-ci/travis-web/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/travis-web/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/travis-web/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/travis-web/subscription","commits_url":"https://api.github.com/repos/travis-ci/travis-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/travis-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/travis-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/travis-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/travis-web/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/travis-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/travis-web/merges","archive_url":"https://api.github.com/repos/travis-ci/travis-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/travis-web/downloads","issues_url":"https://api.github.com/repos/travis-ci/travis-web/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/travis-web/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/travis-web/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/travis-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/travis-web/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/travis-web/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/travis-web/deployments","created_at":"2012-06-17T16:30:56Z","updated_at":"2018-07-19T11:42:38Z","pushed_at":"2018-07-20T13:24:04Z","git_url":"git://github.com/travis-ci/travis-web.git","ssh_url":"git@github.com:travis-ci/travis-web.git","clone_url":"https://github.com/travis-ci/travis-web.git","svn_url":"https://github.com/travis-ci/travis-web","homepage":"https://travis-ci.org/","size":95351,"stargazers_count":527,"watchers_count":527,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":273,"open_issues":27,"watchers":527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722"},"html":{"href":"https://github.com/travis-ci/travis-web/pull/1722"},"issue":{"href":"https://api.github.com/repos/travis-ci/travis-web/issues/1722"},"comments":{"href":"https://api.github.com/repos/travis-ci/travis-web/issues/1722/comments"},"review_comments":{"href":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722/comments"},"review_comment":{"href":"https://api.github.com/repos/travis-ci/travis-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travis-ci/travis-web/pulls/1722/commits"},"statuses":{"href":"https://api.github.com/repos/travis-ci/travis-web/statuses/4ea9296f1525385efeb468589fb99b163fe9387a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bnferguson","id":47749,"node_id":"MDQ6VXNlcjQ3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/47749?v=4","gravatar_id":"","url":"https://api.github.com/users/bnferguson","html_url":"https://github.com/bnferguson","followers_url":"https://api.github.com/users/bnferguson/followers","following_url":"https://api.github.com/users/bnferguson/following{/other_user}","gists_url":"https://api.github.com/users/bnferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/bnferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnferguson/subscriptions","organizations_url":"https://api.github.com/users/bnferguson/orgs","repos_url":"https://api.github.com/users/bnferguson/repos","events_url":"https://api.github.com/users/bnferguson/events{/privacy}","received_events_url":"https://api.github.com/users/bnferguson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"bnferguson"}}