{"action":"opened","number":1705,"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/1705","id":166789336,"html_url":"https://github.com/erlang/otp/pull/1705","diff_url":"https://github.com/erlang/otp/pull/1705.diff","patch_url":"https://github.com/erlang/otp/pull/1705.patch","issue_url":"https://api.github.com/repos/erlang/otp/issues/1705","number":1705,"state":"open","locked":false,"title":"kernel: in the group added processing of 'EXIT' signal from shell","user":{"login":"anton-ryabkov","id":5936459,"avatar_url":"https://avatars0.githubusercontent.com/u/5936459?v=4","gravatar_id":"","url":"https://api.github.com/users/anton-ryabkov","html_url":"https://github.com/anton-ryabkov","followers_url":"https://api.github.com/users/anton-ryabkov/followers","following_url":"https://api.github.com/users/anton-ryabkov/following{/other_user}","gists_url":"https://api.github.com/users/anton-ryabkov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-ryabkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-ryabkov/subscriptions","organizations_url":"https://api.github.com/users/anton-ryabkov/orgs","repos_url":"https://api.github.com/users/anton-ryabkov/repos","events_url":"https://api.github.com/users/anton-ryabkov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-ryabkov/received_events","type":"User","site_admin":false},"body":"For out system we have made configuration console over ssh by erlang. The configuration system have next process' tree: \r\n`ssh_channel_sup -> ssh_cli -> group -> our_shell`\r\n\r\n_our_shell_ receive message from ssh by `io:get_line(\"\")` and by programming logic should stop after some timeout. We kill _our_shell_ process to stop after timeout, but _group_ doesn't receive 'EXIT' signal, _ssh_cli_ continue wait data from SSH. The SSH connection continue alive indefinitely.\r\n\r\nCurrent fix is allow to handle 'EXIT' siglan on from _out_shell_ in _group_ and stop group correctry (after _group_ stopped, _ssh_cli_ stopped by monitor and SSH connection closed succsssfully).","created_at":"2018-02-02T12:21:39Z","updated_at":"2018-02-02T12:21:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/erlang/otp/pulls/1705/commits","review_comments_url":"https://api.github.com/repos/erlang/otp/pulls/1705/comments","review_comment_url":"https://api.github.com/repos/erlang/otp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erlang/otp/issues/1705/comments","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/1bba488c2fe51c3d3dae1e33c2ce4c1097fe9106","head":{"label":"eltex-ecss:group_exit_signal","ref":"group_exit_signal","sha":"1bba488c2fe51c3d3dae1e33c2ce4c1097fe9106","user":{"login":"eltex-ecss","id":15048315,"avatar_url":"https://avatars0.githubusercontent.com/u/15048315?v=4","gravatar_id":"","url":"https://api.github.com/users/eltex-ecss","html_url":"https://github.com/eltex-ecss","followers_url":"https://api.github.com/users/eltex-ecss/followers","following_url":"https://api.github.com/users/eltex-ecss/following{/other_user}","gists_url":"https://api.github.com/users/eltex-ecss/gists{/gist_id}","starred_url":"https://api.github.com/users/eltex-ecss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eltex-ecss/subscriptions","organizations_url":"https://api.github.com/users/eltex-ecss/orgs","repos_url":"https://api.github.com/users/eltex-ecss/repos","events_url":"https://api.github.com/users/eltex-ecss/events{/privacy}","received_events_url":"https://api.github.com/users/eltex-ecss/received_events","type":"Organization","site_admin":false},"repo":{"id":66906916,"name":"otp","full_name":"eltex-ecss/otp","owner":{"login":"eltex-ecss","id":15048315,"avatar_url":"https://avatars0.githubusercontent.com/u/15048315?v=4","gravatar_id":"","url":"https://api.github.com/users/eltex-ecss","html_url":"https://github.com/eltex-ecss","followers_url":"https://api.github.com/users/eltex-ecss/followers","following_url":"https://api.github.com/users/eltex-ecss/following{/other_user}","gists_url":"https://api.github.com/users/eltex-ecss/gists{/gist_id}","starred_url":"https://api.github.com/users/eltex-ecss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eltex-ecss/subscriptions","organizations_url":"https://api.github.com/users/eltex-ecss/orgs","repos_url":"https://api.github.com/users/eltex-ecss/repos","events_url":"https://api.github.com/users/eltex-ecss/events{/privacy}","received_events_url":"https://api.github.com/users/eltex-ecss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eltex-ecss/otp","description":"Erlang/OTP","fork":true,"url":"https://api.github.com/repos/eltex-ecss/otp","forks_url":"https://api.github.com/repos/eltex-ecss/otp/forks","keys_url":"https://api.github.com/repos/eltex-ecss/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eltex-ecss/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eltex-ecss/otp/teams","hooks_url":"https://api.github.com/repos/eltex-ecss/otp/hooks","issue_events_url":"https://api.github.com/repos/eltex-ecss/otp/issues/events{/number}","events_url":"https://api.github.com/repos/eltex-ecss/otp/events","assignees_url":"https://api.github.com/repos/eltex-ecss/otp/assignees{/user}","branches_url":"https://api.github.com/repos/eltex-ecss/otp/branches{/branch}","tags_url":"https://api.github.com/repos/eltex-ecss/otp/tags","blobs_url":"https://api.github.com/repos/eltex-ecss/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eltex-ecss/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eltex-ecss/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/eltex-ecss/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eltex-ecss/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/eltex-ecss/otp/languages","stargazers_url":"https://api.github.com/repos/eltex-ecss/otp/stargazers","contributors_url":"https://api.github.com/repos/eltex-ecss/otp/contributors","subscribers_url":"https://api.github.com/repos/eltex-ecss/otp/subscribers","subscription_url":"https://api.github.com/repos/eltex-ecss/otp/subscription","commits_url":"https://api.github.com/repos/eltex-ecss/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/eltex-ecss/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/eltex-ecss/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/eltex-ecss/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/eltex-ecss/otp/contents/{+path}","compare_url":"https://api.github.com/repos/eltex-ecss/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eltex-ecss/otp/merges","archive_url":"https://api.github.com/repos/eltex-ecss/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eltex-ecss/otp/downloads","issues_url":"https://api.github.com/repos/eltex-ecss/otp/issues{/number}","pulls_url":"https://api.github.com/repos/eltex-ecss/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/eltex-ecss/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/eltex-ecss/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eltex-ecss/otp/labels{/name}","releases_url":"https://api.github.com/repos/eltex-ecss/otp/releases{/id}","deployments_url":"https://api.github.com/repos/eltex-ecss/otp/deployments","created_at":"2016-08-30T04:37:24Z","updated_at":"2016-10-21T05:37:33Z","pushed_at":"2018-02-02T11:37:47Z","git_url":"git://github.com/eltex-ecss/otp.git","ssh_url":"git@github.com:eltex-ecss/otp.git","clone_url":"https://github.com/eltex-ecss/otp.git","svn_url":"https://github.com/eltex-ecss/otp","homepage":"http://erlang.org","size":232041,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"maint"}},"base":{"label":"erlang:master","ref":"master","sha":"18d9afbd5c62bb7b7237fe0d580fc05737a096c1","user":{"login":"erlang","id":153393,"avatar_url":"https://avatars0.githubusercontent.com/u/153393?v=4","gravatar_id":"","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"repo":{"id":374927,"name":"otp","full_name":"erlang/otp","owner":{"login":"erlang","id":153393,"avatar_url":"https://avatars0.githubusercontent.com/u/153393?v=4","gravatar_id":"","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/erlang/otp","description":"Erlang/OTP","fork":false,"url":"https://api.github.com/repos/erlang/otp","forks_url":"https://api.github.com/repos/erlang/otp/forks","keys_url":"https://api.github.com/repos/erlang/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erlang/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erlang/otp/teams","hooks_url":"https://api.github.com/repos/erlang/otp/hooks","issue_events_url":"https://api.github.com/repos/erlang/otp/issues/events{/number}","events_url":"https://api.github.com/repos/erlang/otp/events","assignees_url":"https://api.github.com/repos/erlang/otp/assignees{/user}","branches_url":"https://api.github.com/repos/erlang/otp/branches{/branch}","tags_url":"https://api.github.com/repos/erlang/otp/tags","blobs_url":"https://api.github.com/repos/erlang/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erlang/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erlang/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/erlang/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/erlang/otp/languages","stargazers_url":"https://api.github.com/repos/erlang/otp/stargazers","contributors_url":"https://api.github.com/repos/erlang/otp/contributors","subscribers_url":"https://api.github.com/repos/erlang/otp/subscribers","subscription_url":"https://api.github.com/repos/erlang/otp/subscription","commits_url":"https://api.github.com/repos/erlang/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/erlang/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/erlang/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/erlang/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/erlang/otp/contents/{+path}","compare_url":"https://api.github.com/repos/erlang/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erlang/otp/merges","archive_url":"https://api.github.com/repos/erlang/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erlang/otp/downloads","issues_url":"https://api.github.com/repos/erlang/otp/issues{/number}","pulls_url":"https://api.github.com/repos/erlang/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/erlang/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/erlang/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erlang/otp/labels{/name}","releases_url":"https://api.github.com/repos/erlang/otp/releases{/id}","deployments_url":"https://api.github.com/repos/erlang/otp/deployments","created_at":"2009-11-16T17:17:57Z","updated_at":"2018-02-02T12:15:18Z","pushed_at":"2018-02-02T08:02:37Z","git_url":"git://github.com/erlang/otp.git","ssh_url":"git@github.com:erlang/otp.git","clone_url":"https://github.com/erlang/otp.git","svn_url":"https://github.com/erlang/otp","homepage":"http://erlang.org","size":232047,"stargazers_count":6366,"watchers_count":6366,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1708,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1708,"open_issues":28,"watchers":6366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erlang/otp/pulls/1705"},"html":{"href":"https://github.com/erlang/otp/pull/1705"},"issue":{"href":"https://api.github.com/repos/erlang/otp/issues/1705"},"comments":{"href":"https://api.github.com/repos/erlang/otp/issues/1705/comments"},"review_comments":{"href":"https://api.github.com/repos/erlang/otp/pulls/1705/comments"},"review_comment":{"href":"https://api.github.com/repos/erlang/otp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erlang/otp/pulls/1705/commits"},"statuses":{"href":"https://api.github.com/repos/erlang/otp/statuses/1bba488c2fe51c3d3dae1e33c2ce4c1097fe9106"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":130,"deletions":120,"changed_files":1}}
{"actor":{"display_login":"anton-ryabkov"}}