{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/13382","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/13382/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13382/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/13382/events","html_url":"https://github.com/highfidelity/hifi/pull/13382","id":332610714,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDUzMTk4","number":13382,"title":"Fix Particle Entities","user":{"login":"SamGondelman","id":7650116,"node_id":"MDQ6VXNlcjc2NTAxMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"labels":[{"id":278736632,"node_id":"MDU6TGFiZWwyNzg3MzY2MzI=","url":"https://api.github.com/repos/highfidelity/hifi/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"e11d21","default":false},{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false},{"id":374042454,"node_id":"MDU6TGFiZWwzNzQwNDI0NTQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Packet%20Version%20Change","name":"Packet Version Change","color":"1d76db","default":false},{"id":751529405,"node_id":"MDU6TGFiZWw3NTE1Mjk0MDU=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Scripting%20API%20change","name":"Scripting API change","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/30","html_url":"https://github.com/highfidelity/hifi/milestone/30","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/30/labels","id":3290828,"node_id":"MDk6TWlsZXN0b25lMzI5MDgyOA==","number":30,"title":"RC70","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":24,"state":"open","created_at":"2018-04-23T19:27:01Z","updated_at":"2018-06-19T19:15:04Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-06-15T00:46:44Z","updated_at":"2018-06-19T20:00:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13382","html_url":"https://github.com/highfidelity/hifi/pull/13382","diff_url":"https://github.com/highfidelity/hifi/pull/13382.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13382.patch"},"body":"Fix a variety of particle entity bugs: https://highfidelity.fogbugz.com/f/cases/15583/Clean-Up-Particles\r\n\r\nTest plan (for each bug, I'll provide the ticket an a test case to confirm that it's fixed):\r\n- https://highfidelity.fogbugz.com/f/cases/9126/Particle-start-and-finish-properties-can-change-after-server-restart: Run test plan from ticket.  Confirm that all 6 start/finish properties persist on server restart.\r\n- https://highfidelity.fogbugz.com/f/cases/10831/Particle-System-Changing-Acceleration-Spread-to-0-vector-Removes-Particle-Entity: Run test plan from the ticket.\r\n- https://highfidelity.fogbugz.com/f/cases/11377/Particle-properties-incorrect-and-incomplete-on-export: Run the test plan from the ticket.  In particular, check the 6 start/finish properties, emitterShouldTrail, and all the color values.\r\n- https://highfidelity.fogbugz.com/f/cases/11413/Importing-a-particle-entity-from-a-JSON-does-not-import-all-particle-properties: Run test plan from ticket (similar to previous one, but importing instead of exporting)\r\n- https://highfidelity.fogbugz.com/f/cases/12250/ParticleEffect-s-speedSpread-incorrectly-applied-for-simple-particle-system: Run test script from ticket.\r\n- https://highfidelity.fogbugz.com/f/cases/12253/Particles-with-near-zero-speeds-are-not-rendered: Run test script from ticket\r\n- https://highfidelity.fogbugz.com/f/cases/12263/ParticleEffect-s-radius-color-and-alpha-spreads-aren-t-used: Run test script from ticket\r\n- https://highfidelity.fogbugz.com/f/cases/15808/Polar-Start-End-Properties-do-not-apply-when-adding-particle-effect-from-JS: I could not reproduce this bug.  Confirm that you can create a Particle Entity with a polarStart and polarFinish and in the UI, the values are represented.  Values are also clamped between 0 and PI, so entering anything greater than PI will lead to the UI showing 180.  Confirm that if you \"Show Properties,\" the polarStart and polarEnd are shown in radians.\r\n- https://highfidelity.fogbugz.com/f/cases/15868/Particle-Effects-with-alpha-0-0-render-for-you-but-not-others: The example in the ticket isn't accurate.  Run this from the terminal:\r\n```\r\nvar properties = { \r\ntype: 'ParticleEffect',\r\nposition: MyAvatar.position,\r\nisEmitting:true,\r\nemitAcceleration: Vec3.ZERO,\r\nparticleRadius: 0.03,\r\nlifespan:10,\r\nmaxParticles:500,\r\ntextures:'http://hifi-content.s3.amazonaws.com/alan/dev/Particles/heart-2.png',\r\nemitRate:100,\r\nemitSpeed:1,\r\nspeedSpread: 0,\r\nalpha:0.0\r\n};\r\nvar entity = Entities.addEntity(properties, true);\r\n```\r\n- If you open Create, you should see a particle entity, but it should be invisible to you and onlookers.  Try it again with `Entities.addEntity(properties);` as the last line.  The resulting entity should still be invisible to you and onlookers.  Try both again with `alpha: 0.5` in the properties.  Both should be visible to you and onlookers."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/398525999","html_url":"https://github.com/highfidelity/hifi/pull/13382#issuecomment-398525999","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13382","id":398525999,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUyNTk5OQ==","user":{"login":"hifi-gustavo","id":4554450,"node_id":"MDQ6VXNlcjQ1NTQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T20:00:10Z","updated_at":"2018-06-19T20:00:10Z","author_association":"NONE","body":"Android build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dandroid/10719/HighFidelity-Beta-PR13382-12a5d8b.apk"}}
{"actor":{"display_login":"hifi-gustavo"}}