{"action":"created","issue":{"url":"https://api.github.com/repos/libp2p/go-libp2p/issues/380","repository_url":"https://api.github.com/repos/libp2p/go-libp2p","labels_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/380/comments","events_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/380/events","html_url":"https://github.com/libp2p/go-libp2p/pull/380","id":345314090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDk5MjA0","number":380,"title":"always reset ping streams when done","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"labels":[{"id":419430610,"node_id":"MDU6TGFiZWw0MTk0MzA2MTA=","url":"https://api.github.com/repos/libp2p/go-libp2p/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"assignees":[{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-27T17:55:30Z","updated_at":"2018-08-09T03:41:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/libp2p/go-libp2p/pulls/380","html_url":"https://github.com/libp2p/go-libp2p/pull/380","diff_url":"https://github.com/libp2p/go-libp2p/pull/380.diff","patch_url":"https://github.com/libp2p/go-libp2p/pull/380.patch"},"body":"Currently, we leak a stream. We could use FullClose but, IMO, it's not worth it. We might as well just reset and walk away."},"comment":{"url":"https://api.github.com/repos/libp2p/go-libp2p/issues/comments/411626974","html_url":"https://github.com/libp2p/go-libp2p/pull/380#issuecomment-411626974","issue_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/380","id":411626974,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYyNjk3NA==","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T03:41:43Z","updated_at":"2018-08-09T03:41:43Z","author_association":"CONTRIBUTOR","body":"> Ok, that means that in Ping we have to close the stream on ctx.Done(), and reset under all other conditions.\r\n\r\nWell, the context can still be canceled at any time. I guess we could close nicely if the context is canceled between pings but I don't really see any reason not to reset then. The reason *to* reset is that:\r\n\r\n1. That way, we don't have to wait around for an EOF.\r\n2. The other side doesn't care either way."}}
{"actor":{"display_login":"Stebalien"}}