{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22515","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22515/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22515/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22515/events","html_url":"https://github.com/cockroachdb/cockroach/pull/22515","id":295623280,"number":22515,"title":"nightly: add cluster object","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-02-08T18:44:03Z","updated_at":"2018-02-09T18:31:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/22515","html_url":"https://github.com/cockroachdb/cockroach/pull/22515","diff_url":"https://github.com/cockroachdb/cockroach/pull/22515.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/22515.patch"},"body":"Add `cluster` object which makes creating and running commands on a\ncluster somewhat more concise.\n\nAdd support for running \"local\" clusters via a `--local` flag.\n\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/364518158","html_url":"https://github.com/cockroachdb/cockroach/pull/22515#issuecomment-364518158","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22515","id":364518158,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T18:31:10Z","updated_at":"2018-02-09T18:31:10Z","author_association":"CONTRIBUTOR","body":"> But it seems pretty clear to me that we should make roachprod a library soon.\n\nYeah, some of the stuff in `cluster` (such as the monitoring) would be simplified, but it isn't too bad exec'ing `roachprod` and gives us discipline in how we extend `roachprod`.\n\n---\n\nReview status: all files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.\n\n---\n\n*[pkg/nightly/cluster_test.go, line 219 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/22515#-L4vRLeGc4DGBDBbWiNQ:-L4vorSqYeKZFOqGbR4p:b-1dj99l) ([raw file](https://github.com/cockroachdb/cockroach/blob/cb3d56f29f9ca0d7b74a111cf0a3f86ecb9d9e89/pkg/nightly/cluster_test.go#L219)):*\n<details><summary><i>Previously, danhhz (Daniel Harrison) wrote…</i></summary><blockquote>\n\nmy version made a sublogger, which was nice because these stood out in the logs\n</blockquote></details>\n\nYeah, I didn't do that because `stdLogger` doesn't work nicely with sub-loggers  (i.e. it creates a file like `std_MONITOR`). Let me add some TODOs. \n\n---\n\n*[pkg/nightly/nightly_test.go, line 221 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/22515#-L4vQm5nrkiq1rVHtsmp:-L4voBUSpdV9B2BvgFo9:b-qu6n94) ([raw file](https://github.com/cockroachdb/cockroach/blob/cb3d56f29f9ca0d7b74a111cf0a3f86ecb9d9e89/pkg/nightly/nightly_test.go#L221)):*\n<details><summary><i>Previously, danhhz (Daniel Harrison) wrote…</i></summary><blockquote>\n\nprobably better to use errgroup.WithContext. the zero value of errgroup.Group doesn't cancel the other goroutines when one of them fails. not relevant here, but if this gets cargo culted (say for TestPartitioning), it won't do the right thing\n</blockquote></details>\n\nGood point. Done.\n\n---\n\n*[pkg/nightly/nightly_test.go, line 276 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/22515#-L4vRwZVqA1n6N_2eIs9:-L4voIs0kLA-5PcVj4yq:b-aqccc0) ([raw file](https://github.com/cockroachdb/cockroach/blob/cb3d56f29f9ca0d7b74a111cf0a3f86ecb9d9e89/pkg/nightly/nightly_test.go#L276)):*\n<details><summary><i>Previously, danhhz (Daniel Harrison) wrote…</i></summary><blockquote>\n\ndon't forget to port this one to the new thing and delete the old thing\n</blockquote></details>\n\nI was leaving this alone assuming you guys have outstanding changes to it. Do you? Mind if I address in a follow-on PR?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/22515#-:-L4voVnaUZQsVQySGgwi:b8r2t8u)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}