{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/comments/173483275","pull_request_review_id":102687140,"id":173483275,"diff_hunk":"@@ -0,0 +1,143 @@\n+/*******************************************************************************\n+ * Copyright (c) 2013-2018 Sierra Wireless and others.\n+ * \n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * and Eclipse Distribution License v1.0 which accompany this distribution.\n+ * \n+ * The Eclipse Public License is available at\n+ *    http://www.eclipse.org/legal/epl-v10.html\n+ * and the Eclipse Distribution License is available at\n+ *    http://www.eclipse.org/org/documents/edl-v10.html.\n+ * \n+ * Contributors:\n+ *     Sierra Wireless - initial API and implementation\n+ *     Daniel Persson (Husqvarna Group) - Attribute support\n+ *******************************************************************************/\n+package org.eclipse.leshan.core.attributes;\n+\n+import java.util.ArrayList;\n+import java.util.LinkedHashMap;\n+import java.util.LinkedList;\n+import java.util.List;\n+import java.util.Map;\n+\n+import org.eclipse.leshan.util.Validate;\n+\n+/**\n+ * A collection of {@link Attribute} instances that are handled as a collection\n+ * that must adhere to rules that are specified in LwM2m, e.g. that the 'pmin' attribute\n+ * must be less than the 'pmax' attribute, if they're both part of the same AttributeSet.\n+ */\n+public class AttributeSet {","path":"leshan-core/src/main/java/org/eclipse/leshan/core/attributes/AttributeSet.java","position":35,"original_position":32,"commit_id":"cc8dca46d1b05e13eaddacb99146ceef0a0447fa","original_commit_id":"2d1602c00ba230bd27a6dbe3d518f7aa223fb9b6","user":{"login":"danielhqv","id":32630811,"avatar_url":"https://avatars1.githubusercontent.com/u/32630811?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhqv","html_url":"https://github.com/danielhqv","followers_url":"https://api.github.com/users/danielhqv/followers","following_url":"https://api.github.com/users/danielhqv/following{/other_user}","gists_url":"https://api.github.com/users/danielhqv/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhqv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhqv/subscriptions","organizations_url":"https://api.github.com/users/danielhqv/orgs","repos_url":"https://api.github.com/users/danielhqv/repos","events_url":"https://api.github.com/users/danielhqv/events{/privacy}","received_events_url":"https://api.github.com/users/danielhqv/received_events","type":"User","site_admin":false},"body":"I've made a new merge earlier, so it's included now.","created_at":"2018-03-09T15:36:56Z","updated_at":"2018-03-09T15:36:57Z","html_url":"https://github.com/eclipse/leshan/pull/484#discussion_r173483275","pull_request_url":"https://api.github.com/repos/eclipse/leshan/pulls/484","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments/173483275"},"html":{"href":"https://github.com/eclipse/leshan/pull/484#discussion_r173483275"},"pull_request":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/484"}},"in_reply_to_id":172863314},"pull_request":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/484","id":173454886,"html_url":"https://github.com/eclipse/leshan/pull/484","diff_url":"https://github.com/eclipse/leshan/pull/484.diff","patch_url":"https://github.com/eclipse/leshan/pull/484.patch","issue_url":"https://api.github.com/repos/eclipse/leshan/issues/484","number":484,"state":"open","locked":false,"title":"discover and tests","user":{"login":"danielhqv","id":32630811,"avatar_url":"https://avatars1.githubusercontent.com/u/32630811?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhqv","html_url":"https://github.com/danielhqv","followers_url":"https://api.github.com/users/danielhqv/followers","following_url":"https://api.github.com/users/danielhqv/following{/other_user}","gists_url":"https://api.github.com/users/danielhqv/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhqv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhqv/subscriptions","organizations_url":"https://api.github.com/users/danielhqv/orgs","repos_url":"https://api.github.com/users/danielhqv/repos","events_url":"https://api.github.com/users/danielhqv/events{/privacy}","received_events_url":"https://api.github.com/users/danielhqv/received_events","type":"User","site_admin":false},"body":"To be able to get feedback on this, I submit this pull request before the \"added Attribute\" pull request have been merged, so the contents of that pull request is also present here for now.\r\n\r\nThis adds discover capability and attribute support to existing interfaces and base classes. The contents of the \"added Attribute\" pull request is included here.\r\n\r\nIt's a rather large pull request, but I think it might be hard to find any suitable fragments to break it up into.\r\n\r\nSigned-off-by: Daniel Persson <daniel.p.persson@husqvarnagroup.com>","created_at":"2018-03-07T13:41:51Z","updated_at":"2018-03-09T15:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc03ea0b207de3b0813fb7f9fc80b388c94af2ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/leshan/pulls/484/commits","review_comments_url":"https://api.github.com/repos/eclipse/leshan/pulls/484/comments","review_comment_url":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/leshan/issues/484/comments","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/cc8dca46d1b05e13eaddacb99146ceef0a0447fa","head":{"label":"husqvarnagroup:client_discover","ref":"client_discover","sha":"cc8dca46d1b05e13eaddacb99146ceef0a0447fa","user":{"login":"husqvarnagroup","id":17142631,"avatar_url":"https://avatars3.githubusercontent.com/u/17142631?v=4","gravatar_id":"","url":"https://api.github.com/users/husqvarnagroup","html_url":"https://github.com/husqvarnagroup","followers_url":"https://api.github.com/users/husqvarnagroup/followers","following_url":"https://api.github.com/users/husqvarnagroup/following{/other_user}","gists_url":"https://api.github.com/users/husqvarnagroup/gists{/gist_id}","starred_url":"https://api.github.com/users/husqvarnagroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husqvarnagroup/subscriptions","organizations_url":"https://api.github.com/users/husqvarnagroup/orgs","repos_url":"https://api.github.com/users/husqvarnagroup/repos","events_url":"https://api.github.com/users/husqvarnagroup/events{/privacy}","received_events_url":"https://api.github.com/users/husqvarnagroup/received_events","type":"Organization","site_admin":false},"repo":{"id":106245751,"name":"leshan","full_name":"husqvarnagroup/leshan","owner":{"login":"husqvarnagroup","id":17142631,"avatar_url":"https://avatars3.githubusercontent.com/u/17142631?v=4","gravatar_id":"","url":"https://api.github.com/users/husqvarnagroup","html_url":"https://github.com/husqvarnagroup","followers_url":"https://api.github.com/users/husqvarnagroup/followers","following_url":"https://api.github.com/users/husqvarnagroup/following{/other_user}","gists_url":"https://api.github.com/users/husqvarnagroup/gists{/gist_id}","starred_url":"https://api.github.com/users/husqvarnagroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husqvarnagroup/subscriptions","organizations_url":"https://api.github.com/users/husqvarnagroup/orgs","repos_url":"https://api.github.com/users/husqvarnagroup/repos","events_url":"https://api.github.com/users/husqvarnagroup/events{/privacy}","received_events_url":"https://api.github.com/users/husqvarnagroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/husqvarnagroup/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":true,"url":"https://api.github.com/repos/husqvarnagroup/leshan","forks_url":"https://api.github.com/repos/husqvarnagroup/leshan/forks","keys_url":"https://api.github.com/repos/husqvarnagroup/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/husqvarnagroup/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/husqvarnagroup/leshan/teams","hooks_url":"https://api.github.com/repos/husqvarnagroup/leshan/hooks","issue_events_url":"https://api.github.com/repos/husqvarnagroup/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/husqvarnagroup/leshan/events","assignees_url":"https://api.github.com/repos/husqvarnagroup/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/husqvarnagroup/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/husqvarnagroup/leshan/tags","blobs_url":"https://api.github.com/repos/husqvarnagroup/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/husqvarnagroup/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/husqvarnagroup/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/husqvarnagroup/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/husqvarnagroup/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/husqvarnagroup/leshan/languages","stargazers_url":"https://api.github.com/repos/husqvarnagroup/leshan/stargazers","contributors_url":"https://api.github.com/repos/husqvarnagroup/leshan/contributors","subscribers_url":"https://api.github.com/repos/husqvarnagroup/leshan/subscribers","subscription_url":"https://api.github.com/repos/husqvarnagroup/leshan/subscription","commits_url":"https://api.github.com/repos/husqvarnagroup/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/husqvarnagroup/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/husqvarnagroup/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/husqvarnagroup/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/husqvarnagroup/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/husqvarnagroup/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/husqvarnagroup/leshan/merges","archive_url":"https://api.github.com/repos/husqvarnagroup/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/husqvarnagroup/leshan/downloads","issues_url":"https://api.github.com/repos/husqvarnagroup/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/husqvarnagroup/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/husqvarnagroup/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/husqvarnagroup/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/husqvarnagroup/leshan/labels{/name}","releases_url":"https://api.github.com/repos/husqvarnagroup/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/husqvarnagroup/leshan/deployments","created_at":"2017-10-09T06:41:17Z","updated_at":"2017-10-09T06:41:21Z","pushed_at":"2018-03-09T15:08:27Z","git_url":"git://github.com/husqvarnagroup/leshan.git","ssh_url":"git@github.com:husqvarnagroup/leshan.git","clone_url":"https://github.com/husqvarnagroup/leshan.git","svn_url":"https://github.com/husqvarnagroup/leshan","homepage":"","size":3806,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"790fe5790e77c27f37dad3c5a996ae2e83a2cfa4","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":30419413,"name":"leshan","full_name":"eclipse/leshan","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":false,"url":"https://api.github.com/repos/eclipse/leshan","forks_url":"https://api.github.com/repos/eclipse/leshan/forks","keys_url":"https://api.github.com/repos/eclipse/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/leshan/teams","hooks_url":"https://api.github.com/repos/eclipse/leshan/hooks","issue_events_url":"https://api.github.com/repos/eclipse/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/leshan/events","assignees_url":"https://api.github.com/repos/eclipse/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/leshan/tags","blobs_url":"https://api.github.com/repos/eclipse/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/leshan/languages","stargazers_url":"https://api.github.com/repos/eclipse/leshan/stargazers","contributors_url":"https://api.github.com/repos/eclipse/leshan/contributors","subscribers_url":"https://api.github.com/repos/eclipse/leshan/subscribers","subscription_url":"https://api.github.com/repos/eclipse/leshan/subscription","commits_url":"https://api.github.com/repos/eclipse/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/leshan/merges","archive_url":"https://api.github.com/repos/eclipse/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/leshan/downloads","issues_url":"https://api.github.com/repos/eclipse/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/leshan/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/leshan/deployments","created_at":"2015-02-06T15:44:24Z","updated_at":"2018-02-28T08:47:36Z","pushed_at":"2018-03-09T15:08:28Z","git_url":"git://github.com/eclipse/leshan.git","ssh_url":"git@github.com:eclipse/leshan.git","clone_url":"https://github.com/eclipse/leshan.git","svn_url":"https://github.com/eclipse/leshan","homepage":"","size":3833,"stargazers_count":202,"watchers_count":202,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":167,"open_issues":44,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/484"},"html":{"href":"https://github.com/eclipse/leshan/pull/484"},"issue":{"href":"https://api.github.com/repos/eclipse/leshan/issues/484"},"comments":{"href":"https://api.github.com/repos/eclipse/leshan/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/leshan/statuses/cc8dca46d1b05e13eaddacb99146ceef0a0447fa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielhqv"}}