{"action":"created","comment":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments/196793220","pull_request_review_id":130411989,"id":196793220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njc5MzIyMA==","diff_hunk":"@@ -87,32 +76,46 @@ const ContainerLink = styled(\"a\")(containerStyles)\n const Content = styled(\"div\")(\n   ({\n     theme,\n-    isActive,\n+    isCondensed,\n   }: {\n     theme?: OperationalStyleConstants & {\n       deprecated: Theme\n     }\n-    isActive: boolean\n+    isCondensed: boolean\n   }): CssStatic => ({\n     textDecoration: \"none\",\n     cursor: \"pointer\",\n     position: \"relative\",\n     display: \"flex\",\n-    alignItems: \"center\",\n-    justifyContent: \"flex-start\",\n+    flexDirection: \"column\",\n+    alignItems: \"flex-start\",\n+    justifyContent: \"center\",\n+    height: isCondensed ? 60 : 73,\n     overflow: \"hidden\",\n+    padding: `0 ${theme.space.content}px`,\n     width: \"100%\",\n-    height: theme.deprecated.box,\n-    padding: `0 ${theme.deprecated.spacing}px`,\n-    color: \"#333333\",\n-    fontWeight: 500,\n-    letterSpacing: 0.25,\n-    fontSize: 14,\n-    textTransform: \"uppercase\",\n-    whiteSpace: \"nowrap\",\n   }),\n )\n \n+const LabelText = styled(\"p\")`\n+  position: relative;\n+  color: #333333;\n+  font-weight: 500;\n+  letter-spacing: 0.25;\n+  font-size: 14;\n+  text-transform: uppercase;\n+  white-space: nowrap;\n+  margin: 0;\n+  ${({ isActive }: { isActive: boolean }) =>\n+    isActive\n+      ? `\n+    top: -5px;","path":"packages/components/src/SidenavHeader/SidenavHeader.tsx","position":93,"original_position":93,"commit_id":"476303dbbaca1c91887536b80f61edc51305c767","original_commit_id":"476303dbbaca1c91887536b80f61edc51305c767","user":{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false},"body":"Why `margin-top` in one case and `top` in another?","created_at":"2018-06-20T14:08:14Z","updated_at":"2018-06-20T14:12:15Z","html_url":"https://github.com/contiamo/operational-ui/pull/514#discussion_r196793220","pull_request_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/514","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments/196793220"},"html":{"href":"https://github.com/contiamo/operational-ui/pull/514#discussion_r196793220"},"pull_request":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/514"}}},"pull_request":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/514","id":196128228,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTI4MjI4","html_url":"https://github.com/contiamo/operational-ui/pull/514","diff_url":"https://github.com/contiamo/operational-ui/pull/514.diff","patch_url":"https://github.com/contiamo/operational-ui/pull/514.patch","issue_url":"https://api.github.com/repos/contiamo/operational-ui/issues/514","number":514,"state":"open","locked":false,"title":"Enhance sidenav","user":{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},"body":"Adds missing features to the side nav:\r\n* [x] truncated summary items in `SidenavHeader`\r\n* [x] `SidenavHeader` icon\r\n* [x] condensed `SidenavHeader`\r\n* [ ] polish + adjust spacing to exactly match designs\r\n\r\n<img width=\"241\" alt=\"screen shot 2018-06-20 at 4 03 21 pm\" src=\"https://user-images.githubusercontent.com/6738398/41663564-07b605f8-74a4-11e8-89fd-14bff1fbc1f1.png\">","created_at":"2018-06-20T12:54:23Z","updated_at":"2018-06-20T14:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eafe88e64a22f6e8e20204eab3f54095463b68df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":728468591,"node_id":"MDU6TGFiZWw3Mjg0Njg1OTE=","url":"https://api.github.com/repos/contiamo/operational-ui/labels/Work%20in%20Progress","name":"Work in Progress","color":"ff0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/514/commits","review_comments_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/514/comments","review_comment_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/issues/514/comments","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/476303dbbaca1c91887536b80f61edc51305c767","head":{"label":"contiamo:enhance/sidenav","ref":"enhance/sidenav","sha":"476303dbbaca1c91887536b80f61edc51305c767","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-06-20T13:53:19Z","pushed_at":"2018-06-20T14:05:21Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org/","size":40579,"stargazers_count":28,"watchers_count":28,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":17,"watchers":28,"default_branch":"master"}},"base":{"label":"contiamo:master","ref":"master","sha":"be0e90cc5e6fcff1805f0524e6d821c2fc31da37","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-06-20T13:53:19Z","pushed_at":"2018-06-20T14:05:21Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org/","size":40579,"stargazers_count":28,"watchers_count":28,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":17,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/514"},"html":{"href":"https://github.com/contiamo/operational-ui/pull/514"},"issue":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/514"},"comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/contiamo/operational-ui/statuses/476303dbbaca1c91887536b80f61edc51305c767"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TejasQ"}}