{"action":"created","issue":{"url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/14","repository_url":"https://api.github.com/repos/fatihi/fiveringsdb","labels_url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/14/comments","events_url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/14/events","html_url":"https://github.com/fatihi/fiveringsdb/pull/14","id":386614623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mjk1MTA1","number":14,"title":"Adds entities for cards.","user":{"login":"degoeym","id":4965901,"node_id":"MDQ6VXNlcjQ5NjU5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4965901?v=4","gravatar_id":"","url":"https://api.github.com/users/degoeym","html_url":"https://github.com/degoeym","followers_url":"https://api.github.com/users/degoeym/followers","following_url":"https://api.github.com/users/degoeym/following{/other_user}","gists_url":"https://api.github.com/users/degoeym/gists{/gist_id}","starred_url":"https://api.github.com/users/degoeym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degoeym/subscriptions","organizations_url":"https://api.github.com/users/degoeym/orgs","repos_url":"https://api.github.com/users/degoeym/repos","events_url":"https://api.github.com/users/degoeym/events{/privacy}","received_events_url":"https://api.github.com/users/degoeym/received_events","type":"User","site_admin":false},"labels":[{"id":1122565314,"node_id":"MDU6TGFiZWwxMTIyNTY1MzE0","url":"https://api.github.com/repos/fatihi/fiveringsdb/labels/in%20progress","name":"in progress","color":"6cd8b8","default":false},{"id":1111949831,"node_id":"MDU6TGFiZWwxMTExOTQ5ODMx","url":"https://api.github.com/repos/fatihi/fiveringsdb/labels/question","name":"question","color":"d876e3","default":true}],"state":"open","locked":false,"assignee":{"login":"degoeym","id":4965901,"node_id":"MDQ6VXNlcjQ5NjU5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4965901?v=4","gravatar_id":"","url":"https://api.github.com/users/degoeym","html_url":"https://github.com/degoeym","followers_url":"https://api.github.com/users/degoeym/followers","following_url":"https://api.github.com/users/degoeym/following{/other_user}","gists_url":"https://api.github.com/users/degoeym/gists{/gist_id}","starred_url":"https://api.github.com/users/degoeym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degoeym/subscriptions","organizations_url":"https://api.github.com/users/degoeym/orgs","repos_url":"https://api.github.com/users/degoeym/repos","events_url":"https://api.github.com/users/degoeym/events{/privacy}","received_events_url":"https://api.github.com/users/degoeym/received_events","type":"User","site_admin":false},"assignees":[{"login":"degoeym","id":4965901,"node_id":"MDQ6VXNlcjQ5NjU5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4965901?v=4","gravatar_id":"","url":"https://api.github.com/users/degoeym","html_url":"https://github.com/degoeym","followers_url":"https://api.github.com/users/degoeym/followers","following_url":"https://api.github.com/users/degoeym/following{/other_user}","gists_url":"https://api.github.com/users/degoeym/gists{/gist_id}","starred_url":"https://api.github.com/users/degoeym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degoeym/subscriptions","organizations_url":"https://api.github.com/users/degoeym/orgs","repos_url":"https://api.github.com/users/degoeym/repos","events_url":"https://api.github.com/users/degoeym/events{/privacy}","received_events_url":"https://api.github.com/users/degoeym/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-02T23:43:23Z","updated_at":"2018-12-03T07:57:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fatihi/fiveringsdb/pulls/14","html_url":"https://github.com/fatihi/fiveringsdb/pull/14","diff_url":"https://github.com/fatihi/fiveringsdb/pull/14.diff","patch_url":"https://github.com/fatihi/fiveringsdb/pull/14.patch"},"body":"As the title says, this lays down some groundwork for the entities related to cards. Some of the items are enums to add hard values for things like clan and set names. Need to add ones for traits, key words, elements, and likely others. I also feel we should have a Role card, but my question is if that should be its on card type that doesn't inherit from the abstract `Card` class? The final step would be to add the needed attributes for these to be used as part of a code first approach to creating the database."},"comment":{"url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/comments/443620296","html_url":"https://github.com/fatihi/fiveringsdb/pull/14#issuecomment-443620296","issue_url":"https://api.github.com/repos/fatihi/fiveringsdb/issues/14","id":443620296,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzYyMDI5Ng==","user":{"login":"programming-wolf","id":30000147,"node_id":"MDQ6VXNlcjMwMDAwMTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/30000147?v=4","gravatar_id":"","url":"https://api.github.com/users/programming-wolf","html_url":"https://github.com/programming-wolf","followers_url":"https://api.github.com/users/programming-wolf/followers","following_url":"https://api.github.com/users/programming-wolf/following{/other_user}","gists_url":"https://api.github.com/users/programming-wolf/gists{/gist_id}","starred_url":"https://api.github.com/users/programming-wolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programming-wolf/subscriptions","organizations_url":"https://api.github.com/users/programming-wolf/orgs","repos_url":"https://api.github.com/users/programming-wolf/repos","events_url":"https://api.github.com/users/programming-wolf/events{/privacy}","received_events_url":"https://api.github.com/users/programming-wolf/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T07:57:59Z","updated_at":"2018-12-03T07:57:59Z","author_association":"NONE","body":"I should have read your comment properly before starting to review the code, @degoeym . 😬 \r\nI agree with all the enums. I also agree with the Role, they are technically not a card (even though we do get cards to show which role we're using), so they should be their own entity. \r\n\r\nI am not sure about the deck. Just having a list of cards does not work if role isn't a `Card` type anymore. I like the idea of having an object that has lists of conflict cards, dynasty cards, a stronghold, provinces and a role (which limits the influence for the conflict cards). "}}
{"actor":{"display_login":"programming-wolf"}}