{"action":"created","comment":{"url":"https://api.github.com/repos/pymedusa/Medusa/pulls/comments/204980520","pull_request_review_id":140159830,"id":204980520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk4MDUyMA==","diff_hunk":"@@ -61,7 +61,7 @@\n \n             <app-header></app-header>\n             % if submenu:\n-            <%include file=\"/partials/submenu.mako\"/>\n+            <submenu></submenu>","path":"themes-default/slim/views/layouts/main.mako","position":5,"original_position":5,"commit_id":"8a3a354e34e0f56898d57a02c51428dd2853b093","original_commit_id":"8a3a354e34e0f56898d57a02c51428dd2853b093","user":{"login":"OmgImAlexis","id":6525926,"node_id":"MDQ6VXNlcjY1MjU5MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/6525926?v=4","gravatar_id":"","url":"https://api.github.com/users/OmgImAlexis","html_url":"https://github.com/OmgImAlexis","followers_url":"https://api.github.com/users/OmgImAlexis/followers","following_url":"https://api.github.com/users/OmgImAlexis/following{/other_user}","gists_url":"https://api.github.com/users/OmgImAlexis/gists{/gist_id}","starred_url":"https://api.github.com/users/OmgImAlexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmgImAlexis/subscriptions","organizations_url":"https://api.github.com/users/OmgImAlexis/orgs","repos_url":"https://api.github.com/users/OmgImAlexis/repos","events_url":"https://api.github.com/users/OmgImAlexis/events{/privacy}","received_events_url":"https://api.github.com/users/OmgImAlexis/received_events","type":"User","site_admin":false},"body":"All non page/root components should use a 2 section name like `sub-menu`, `app-header`, etc.","created_at":"2018-07-25T04:51:44Z","updated_at":"2018-07-25T04:51:44Z","html_url":"https://github.com/pymedusa/Medusa/pull/4739#discussion_r204980520","pull_request_url":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/comments/204980520"},"html":{"href":"https://github.com/pymedusa/Medusa/pull/4739#discussion_r204980520"},"pull_request":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739"}}},"pull_request":{"url":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739","id":203412976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDEyOTc2","html_url":"https://github.com/pymedusa/Medusa/pull/4739","diff_url":"https://github.com/pymedusa/Medusa/pull/4739.diff","patch_url":"https://github.com/pymedusa/Medusa/pull/4739.patch","issue_url":"https://api.github.com/repos/pymedusa/Medusa/issues/4739","number":4739,"state":"open","locked":false,"title":"Convert submenu to Vue","user":{"login":"sharkykh","id":10238474,"node_id":"MDQ6VXNlcjEwMjM4NDc0","avatar_url":"https://avatars1.githubusercontent.com/u/10238474?v=4","gravatar_id":"","url":"https://api.github.com/users/sharkykh","html_url":"https://github.com/sharkykh","followers_url":"https://api.github.com/users/sharkykh/followers","following_url":"https://api.github.com/users/sharkykh/following{/other_user}","gists_url":"https://api.github.com/users/sharkykh/gists{/gist_id}","starred_url":"https://api.github.com/users/sharkykh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharkykh/subscriptions","organizations_url":"https://api.github.com/users/sharkykh/orgs","repos_url":"https://api.github.com/users/sharkykh/repos","events_url":"https://api.github.com/users/sharkykh/events{/privacy}","received_events_url":"https://api.github.com/users/sharkykh/received_events","type":"User","site_admin":false},"body":"This is set for v0.2.7 because it fixes the bug with the confirmation dialogs for removing shows, clearing history, etc.\r\n\r\n## To do:\r\n- [x] Remove the check for `controller !== 'schedule' && action !== 'previewRename'`.\r\n\t\tFor `previewRename` - either remove the submenu argument from [the handler](https://github.com/pymedusa/Medusa/blob/c304860c5360b2e9fa118717a639c28578e5a27e/medusa/server/web/home/handler.py#L2084-L2090),\r\n\t\tor keep it - if we want it. Make sure removing that submenu has no effect.\r\n- [x] Show selector - check `location.pathname` has `displayShow`?\r\n- [x] Show selector - get current show slug from the url?\r\n- [x] Cherry-picked from #4663 - VueRouter: Disable `not-found` redirection for now","created_at":"2018-07-24T05:23:33Z","updated_at":"2018-07-25T04:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8061771c0426dcd43335aac3d07c8d50cbd9ca13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":330483526,"node_id":"MDU6TGFiZWwzMzA0ODM1MjY=","url":"https://api.github.com/repos/pymedusa/Medusa/labels/Bug","name":"Bug","color":"d93f0b","default":false},{"id":330714262,"node_id":"MDU6TGFiZWwzMzA3MTQyNjI=","url":"https://api.github.com/repos/pymedusa/Medusa/labels/Concluded","name":"Concluded","color":"207de5","default":false},{"id":371496022,"node_id":"MDU6TGFiZWwzNzE0OTYwMjI=","url":"https://api.github.com/repos/pymedusa/Medusa/labels/Needs%20review","name":"Needs review","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/pymedusa/Medusa/milestones/40","html_url":"https://github.com/pymedusa/Medusa/milestone/40","labels_url":"https://api.github.com/repos/pymedusa/Medusa/milestones/40/labels","id":3420585,"node_id":"MDk6TWlsZXN0b25lMzQyMDU4NQ==","number":40,"title":"0.2.7","description":"","creator":{"login":"OmgImAlexis","id":6525926,"node_id":"MDQ6VXNlcjY1MjU5MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/6525926?v=4","gravatar_id":"","url":"https://api.github.com/users/OmgImAlexis","html_url":"https://github.com/OmgImAlexis","followers_url":"https://api.github.com/users/OmgImAlexis/followers","following_url":"https://api.github.com/users/OmgImAlexis/following{/other_user}","gists_url":"https://api.github.com/users/OmgImAlexis/gists{/gist_id}","starred_url":"https://api.github.com/users/OmgImAlexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmgImAlexis/subscriptions","organizations_url":"https://api.github.com/users/OmgImAlexis/orgs","repos_url":"https://api.github.com/users/OmgImAlexis/repos","events_url":"https://api.github.com/users/OmgImAlexis/events{/privacy}","received_events_url":"https://api.github.com/users/OmgImAlexis/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":116,"state":"open","created_at":"2018-06-13T02:48:14Z","updated_at":"2018-07-24T17:24:23Z","due_on":"2018-07-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739/commits","review_comments_url":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739/comments","review_comment_url":"https://api.github.com/repos/pymedusa/Medusa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pymedusa/Medusa/issues/4739/comments","statuses_url":"https://api.github.com/repos/pymedusa/Medusa/statuses/8a3a354e34e0f56898d57a02c51428dd2853b093","head":{"label":"pymedusa:vueify/submenu","ref":"vueify/submenu","sha":"8a3a354e34e0f56898d57a02c51428dd2853b093","user":{"login":"pymedusa","id":16712498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzEyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/16712498?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"repo":{"id":52334681,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMzNDY4MQ==","name":"Medusa","full_name":"pymedusa/Medusa","owner":{"login":"pymedusa","id":16712498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzEyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/16712498?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pymedusa/Medusa","description":"Now with the most wanted feature: **Manual Search**. You can choose what to download! IRC: #pymedusa","fork":false,"url":"https://api.github.com/repos/pymedusa/Medusa","forks_url":"https://api.github.com/repos/pymedusa/Medusa/forks","keys_url":"https://api.github.com/repos/pymedusa/Medusa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedusa/Medusa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedusa/Medusa/teams","hooks_url":"https://api.github.com/repos/pymedusa/Medusa/hooks","issue_events_url":"https://api.github.com/repos/pymedusa/Medusa/issues/events{/number}","events_url":"https://api.github.com/repos/pymedusa/Medusa/events","assignees_url":"https://api.github.com/repos/pymedusa/Medusa/assignees{/user}","branches_url":"https://api.github.com/repos/pymedusa/Medusa/branches{/branch}","tags_url":"https://api.github.com/repos/pymedusa/Medusa/tags","blobs_url":"https://api.github.com/repos/pymedusa/Medusa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedusa/Medusa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedusa/Medusa/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedusa/Medusa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedusa/Medusa/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedusa/Medusa/languages","stargazers_url":"https://api.github.com/repos/pymedusa/Medusa/stargazers","contributors_url":"https://api.github.com/repos/pymedusa/Medusa/contributors","subscribers_url":"https://api.github.com/repos/pymedusa/Medusa/subscribers","subscription_url":"https://api.github.com/repos/pymedusa/Medusa/subscription","commits_url":"https://api.github.com/repos/pymedusa/Medusa/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedusa/Medusa/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedusa/Medusa/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedusa/Medusa/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedusa/Medusa/contents/{+path}","compare_url":"https://api.github.com/repos/pymedusa/Medusa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedusa/Medusa/merges","archive_url":"https://api.github.com/repos/pymedusa/Medusa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedusa/Medusa/downloads","issues_url":"https://api.github.com/repos/pymedusa/Medusa/issues{/number}","pulls_url":"https://api.github.com/repos/pymedusa/Medusa/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedusa/Medusa/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedusa/Medusa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedusa/Medusa/labels{/name}","releases_url":"https://api.github.com/repos/pymedusa/Medusa/releases{/id}","deployments_url":"https://api.github.com/repos/pymedusa/Medusa/deployments","created_at":"2016-02-23T06:02:11Z","updated_at":"2018-07-24T22:12:06Z","pushed_at":"2018-07-24T22:05:44Z","git_url":"git://github.com/pymedusa/Medusa.git","ssh_url":"git@github.com:pymedusa/Medusa.git","clone_url":"https://github.com/pymedusa/Medusa.git","svn_url":"https://github.com/pymedusa/Medusa","homepage":"","size":92749,"stargazers_count":373,"watchers_count":373,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":84,"open_issues":222,"watchers":373,"default_branch":"master"}},"base":{"label":"pymedusa:develop","ref":"develop","sha":"998f309861beaf0631fda4005d6ec1b395226995","user":{"login":"pymedusa","id":16712498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzEyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/16712498?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"repo":{"id":52334681,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMzNDY4MQ==","name":"Medusa","full_name":"pymedusa/Medusa","owner":{"login":"pymedusa","id":16712498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzEyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/16712498?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pymedusa/Medusa","description":"Now with the most wanted feature: **Manual Search**. You can choose what to download! IRC: #pymedusa","fork":false,"url":"https://api.github.com/repos/pymedusa/Medusa","forks_url":"https://api.github.com/repos/pymedusa/Medusa/forks","keys_url":"https://api.github.com/repos/pymedusa/Medusa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedusa/Medusa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedusa/Medusa/teams","hooks_url":"https://api.github.com/repos/pymedusa/Medusa/hooks","issue_events_url":"https://api.github.com/repos/pymedusa/Medusa/issues/events{/number}","events_url":"https://api.github.com/repos/pymedusa/Medusa/events","assignees_url":"https://api.github.com/repos/pymedusa/Medusa/assignees{/user}","branches_url":"https://api.github.com/repos/pymedusa/Medusa/branches{/branch}","tags_url":"https://api.github.com/repos/pymedusa/Medusa/tags","blobs_url":"https://api.github.com/repos/pymedusa/Medusa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedusa/Medusa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedusa/Medusa/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedusa/Medusa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedusa/Medusa/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedusa/Medusa/languages","stargazers_url":"https://api.github.com/repos/pymedusa/Medusa/stargazers","contributors_url":"https://api.github.com/repos/pymedusa/Medusa/contributors","subscribers_url":"https://api.github.com/repos/pymedusa/Medusa/subscribers","subscription_url":"https://api.github.com/repos/pymedusa/Medusa/subscription","commits_url":"https://api.github.com/repos/pymedusa/Medusa/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedusa/Medusa/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedusa/Medusa/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedusa/Medusa/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedusa/Medusa/contents/{+path}","compare_url":"https://api.github.com/repos/pymedusa/Medusa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedusa/Medusa/merges","archive_url":"https://api.github.com/repos/pymedusa/Medusa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedusa/Medusa/downloads","issues_url":"https://api.github.com/repos/pymedusa/Medusa/issues{/number}","pulls_url":"https://api.github.com/repos/pymedusa/Medusa/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedusa/Medusa/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedusa/Medusa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedusa/Medusa/labels{/name}","releases_url":"https://api.github.com/repos/pymedusa/Medusa/releases{/id}","deployments_url":"https://api.github.com/repos/pymedusa/Medusa/deployments","created_at":"2016-02-23T06:02:11Z","updated_at":"2018-07-24T22:12:06Z","pushed_at":"2018-07-24T22:05:44Z","git_url":"git://github.com/pymedusa/Medusa.git","ssh_url":"git@github.com:pymedusa/Medusa.git","clone_url":"https://github.com/pymedusa/Medusa.git","svn_url":"https://github.com/pymedusa/Medusa","homepage":"","size":92749,"stargazers_count":373,"watchers_count":373,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":84,"open_issues":222,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739"},"html":{"href":"https://github.com/pymedusa/Medusa/pull/4739"},"issue":{"href":"https://api.github.com/repos/pymedusa/Medusa/issues/4739"},"comments":{"href":"https://api.github.com/repos/pymedusa/Medusa/issues/4739/comments"},"review_comments":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739/comments"},"review_comment":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pymedusa/Medusa/pulls/4739/commits"},"statuses":{"href":"https://api.github.com/repos/pymedusa/Medusa/statuses/8a3a354e34e0f56898d57a02c51428dd2853b093"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OmgImAlexis"}}