{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/226560298","pull_request_review_id":166411888,"id":226560298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU2MDI5OA==","diff_hunk":"@@ -42,7 +42,13 @@ export class WorkspaceFrontendContribution implements CommandContribution, Keybi\n     registerCommands(commands: CommandRegistry): void {\n         commands.registerCommand(WorkspaceCommands.OPEN, {\n             isEnabled: () => true,\n-            execute: () => this.doOpen()\n+            execute: (args: any[]) => {\n+                if (args) {\n+                    const [fileURI] = args;\n+                    return this.workspaceService.open(fileURI);","path":"packages/workspace/src/browser/workspace-frontend-contribution.ts","position":8,"original_position":8,"commit_id":"dee351b7e305d1b0888a945a82d0b917c243c24f","original_commit_id":"dee351b7e305d1b0888a945a82d0b917c243c24f","user":{"login":"sunix","id":650571,"node_id":"MDQ6VXNlcjY1MDU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/650571?v=4","gravatar_id":"","url":"https://api.github.com/users/sunix","html_url":"https://github.com/sunix","followers_url":"https://api.github.com/users/sunix/followers","following_url":"https://api.github.com/users/sunix/following{/other_user}","gists_url":"https://api.github.com/users/sunix/gists{/gist_id}","starred_url":"https://api.github.com/users/sunix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunix/subscriptions","organizations_url":"https://api.github.com/users/sunix/orgs","repos_url":"https://api.github.com/users/sunix/repos","events_url":"https://api.github.com/users/sunix/events{/privacy}","received_events_url":"https://api.github.com/users/sunix/received_events","type":"User","site_admin":false},"body":"In general I think we should rethink the way commands are written. Quick open stuffs should only provide the UI interactions, and when writting a command we should pass the function to be executed by a quick open.\r\nI would like that we have a proper test framework like what I suggest here: https://github.com/theia-ide/theia/issues/3160 before we start such a refactoring.\r\n","created_at":"2018-10-19T07:52:56Z","updated_at":"2018-10-19T07:52:56Z","html_url":"https://github.com/theia-ide/theia/pull/3190#discussion_r226560298","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/3190","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/226560298"},"html":{"href":"https://github.com/theia-ide/theia/pull/3190#discussion_r226560298"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3190"}},"in_reply_to_id":226541544},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/3190","id":223226262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjI2MjYy","html_url":"https://github.com/theia-ide/theia/pull/3190","diff_url":"https://github.com/theia-ide/theia/pull/3190.diff","patch_url":"https://github.com/theia-ide/theia/pull/3190.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/3190","number":3190,"state":"closed","locked":false,"title":"Adding the ability to pass arguments to task:run and openFile commands","user":{"login":"sunix","id":650571,"node_id":"MDQ6VXNlcjY1MDU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/650571?v=4","gravatar_id":"","url":"https://api.github.com/users/sunix","html_url":"https://github.com/sunix","followers_url":"https://api.github.com/users/sunix/followers","following_url":"https://api.github.com/users/sunix/following{/other_user}","gists_url":"https://api.github.com/users/sunix/gists{/gist_id}","starred_url":"https://api.github.com/users/sunix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunix/subscriptions","organizations_url":"https://api.github.com/users/sunix/orgs","repos_url":"https://api.github.com/users/sunix/repos","events_url":"https://api.github.com/users/sunix/events{/privacy}","received_events_url":"https://api.github.com/users/sunix/received_events","type":"User","site_admin":false},"body":"Adding the ability to pass arguments to task:run and openFile commands so they could be used from the command API without UI.","created_at":"2018-10-16T12:14:47Z","updated_at":"2018-10-19T07:52:56Z","closed_at":"2018-10-17T12:50:40Z","merged_at":"2018-10-17T12:50:40Z","merge_commit_sha":"e59f491407ad068b466a773d81f85f63f22d6dad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016153478,"node_id":"MDU6TGFiZWwxMDE2MTUzNDc4","url":"https://api.github.com/repos/theia-ide/theia/labels/commands","name":"commands","color":"2cb1cc","default":false},{"id":812699194,"node_id":"MDU6TGFiZWw4MTI2OTkxOTQ=","url":"https://api.github.com/repos/theia-ide/theia/labels/tasks","name":"tasks","color":"d54ff9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/3190/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/3190/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/3190/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/dee351b7e305d1b0888a945a82d0b917c243c24f","head":{"label":"sunix:command-args","ref":"command-args","sha":"dee351b7e305d1b0888a945a82d0b917c243c24f","user":{"login":"sunix","id":650571,"node_id":"MDQ6VXNlcjY1MDU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/650571?v=4","gravatar_id":"","url":"https://api.github.com/users/sunix","html_url":"https://github.com/sunix","followers_url":"https://api.github.com/users/sunix/followers","following_url":"https://api.github.com/users/sunix/following{/other_user}","gists_url":"https://api.github.com/users/sunix/gists{/gist_id}","starred_url":"https://api.github.com/users/sunix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunix/subscriptions","organizations_url":"https://api.github.com/users/sunix/orgs","repos_url":"https://api.github.com/users/sunix/repos","events_url":"https://api.github.com/users/sunix/events{/privacy}","received_events_url":"https://api.github.com/users/sunix/received_events","type":"User","site_admin":false},"repo":{"id":151714078,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MTQwNzg=","name":"theia","full_name":"sunix/theia","private":false,"owner":{"login":"sunix","id":650571,"node_id":"MDQ6VXNlcjY1MDU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/650571?v=4","gravatar_id":"","url":"https://api.github.com/users/sunix","html_url":"https://github.com/sunix","followers_url":"https://api.github.com/users/sunix/followers","following_url":"https://api.github.com/users/sunix/following{/other_user}","gists_url":"https://api.github.com/users/sunix/gists{/gist_id}","starred_url":"https://api.github.com/users/sunix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunix/subscriptions","organizations_url":"https://api.github.com/users/sunix/orgs","repos_url":"https://api.github.com/users/sunix/repos","events_url":"https://api.github.com/users/sunix/events{/privacy}","received_events_url":"https://api.github.com/users/sunix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sunix/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/sunix/theia","forks_url":"https://api.github.com/repos/sunix/theia/forks","keys_url":"https://api.github.com/repos/sunix/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunix/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunix/theia/teams","hooks_url":"https://api.github.com/repos/sunix/theia/hooks","issue_events_url":"https://api.github.com/repos/sunix/theia/issues/events{/number}","events_url":"https://api.github.com/repos/sunix/theia/events","assignees_url":"https://api.github.com/repos/sunix/theia/assignees{/user}","branches_url":"https://api.github.com/repos/sunix/theia/branches{/branch}","tags_url":"https://api.github.com/repos/sunix/theia/tags","blobs_url":"https://api.github.com/repos/sunix/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunix/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunix/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunix/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunix/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/sunix/theia/languages","stargazers_url":"https://api.github.com/repos/sunix/theia/stargazers","contributors_url":"https://api.github.com/repos/sunix/theia/contributors","subscribers_url":"https://api.github.com/repos/sunix/theia/subscribers","subscription_url":"https://api.github.com/repos/sunix/theia/subscription","commits_url":"https://api.github.com/repos/sunix/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunix/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunix/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunix/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunix/theia/contents/{+path}","compare_url":"https://api.github.com/repos/sunix/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunix/theia/merges","archive_url":"https://api.github.com/repos/sunix/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunix/theia/downloads","issues_url":"https://api.github.com/repos/sunix/theia/issues{/number}","pulls_url":"https://api.github.com/repos/sunix/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/sunix/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/sunix/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunix/theia/labels{/name}","releases_url":"https://api.github.com/repos/sunix/theia/releases{/id}","deployments_url":"https://api.github.com/repos/sunix/theia/deployments","created_at":"2018-10-05T11:58:17Z","updated_at":"2018-10-05T11:58:22Z","pushed_at":"2018-10-17T21:15:29Z","git_url":"git://github.com/sunix/theia.git","ssh_url":"git@github.com:sunix/theia.git","clone_url":"https://github.com/sunix/theia.git","svn_url":"https://github.com/sunix/theia","homepage":"http://theia-ide.org","size":110911,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"799e1942d899276087107da9e8b2c54e0f570182","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-10-19T02:44:43Z","pushed_at":"2018-10-19T06:50:53Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":111249,"stargazers_count":1700,"watchers_count":1700,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":689,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":243,"open_issues":689,"watchers":1700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3190"},"html":{"href":"https://github.com/theia-ide/theia/pull/3190"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3190"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3190/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3190/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3190/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/dee351b7e305d1b0888a945a82d0b917c243c24f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sunix"}}