{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/242473474","pull_request_review_id":185983017,"id":242473474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ3MzQ3NA==","diff_hunk":"@@ -0,0 +1,129 @@\n+package realrp\n+\n+import (\n+\t\"context\"\n+\t\"errors\"\n+\t\"os\"\n+\t\"time\"\n+\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+\n+\t\"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2018-06-01/network\"\n+\t\"github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2018-05-01/resources\"\n+\t\"github.com/sirupsen/logrus\"\n+\n+\t\"github.com/openshift/openshift-azure/pkg/api/2018-09-30-preview/api\"\n+\t\"github.com/openshift/openshift-azure/pkg/fakerp/client\"\n+\t\"github.com/openshift/openshift-azure/test/clients/azure\"\n+)\n+\n+var _ = Describe(\"Peer Vnet tests [Vnet]\", func() {\n+\tvar (\n+\t\tctx          = context.Background()\n+\t\tcli          *azure.Client\n+\t\trg           = os.Getenv(\"RESOURCEGROUP\")\n+\t\tvnetPeerName = \"vnetPeer\"\n+\t\tregion       = os.Getenv(\"AZURE_REGION\")\n+\t\tclientID     = os.Getenv(\"AZURE_CLIENT_ID\")\n+\t\tclientSecret = os.Getenv(\"AZURE_CLIENT_SECRET\")\n+\t)\n+\n+\tBeforeEach(func() {\n+\t\tvar err error\n+\t\tcli, err = azure.NewClientFromEnvironment(false)\n+\t\tExpect(err).ToNot(HaveOccurred())\n+\t\tif os.Getenv(\"AZURE_REGION\") == \"\" {\n+\t\t\tExpect(errors.New(\"AZURE_REGION is not set\")).ToNot(HaveOccurred())\n+\t\t}\n+\t\tif os.Getenv(\"RESOURCEGROUP\") == \"\" {\n+\t\t\tExpect(errors.New(\"RESOURCEGROUP is not set\")).ToNot(HaveOccurred())\n+\t\t}\n+\t})\n+\n+\tAfterEach(func() {\n+\t\tresult, _ := cli.Groups.Delete(ctx, rg)\n+\t\t_ = result.WaitForCompletionRef(ctx, cli.Groups.Client())\n+\t})\n+\n+\tIt(\"should create the vnet and cluster and verify peering\", func() {\n+\t\tlogrus.SetLevel(logrus.DebugLevel)\n+\t\tlogrus.SetFormatter(&logrus.TextFormatter{FullTimestamp: true})\n+\t\tlogrus.SetOutput(GinkgoWriter)\n+\t\tlog := logrus.NewEntry(logrus.StandardLogger())\n+\n+\t\t// create a resource group and a vnet\n+\t\texists, err := cli.Groups.CheckExistence(ctx, rg)\n+\t\tExpect(err).ToNot(HaveOccurred())\n+\t\tif !exists {\n+\t\t\tnow := time.Now().String()\n+\t\t\tttl := \"4h\"\n+\t\t\t_, err := cli.Groups.CreateOrUpdate(ctx, rg, resources.Group{\n+\t\t\t\tName:     &rg,\n+\t\t\t\tLocation: &region,\n+\t\t\t\tTags: map[string]*string{\n+\t\t\t\t\t\"now\": &now,\n+\t\t\t\t\t\"ttl\": &ttl,\n+\t\t\t\t},\n+\t\t\t})\n+\t\t\tExpect(err).ToNot(HaveOccurred())\n+\t\t}\n+\t\tsubnetName := \"vnetPeerSubnet\"\n+\t\tsubnetAddressPrefix := \"192.168.0.0/24\"\n+\t\tfuture, err := cli.VirtualNetworks.CreateOrUpdate(ctx, rg, vnetPeerName, network.VirtualNetwork{\n+\t\t\tVirtualNetworkPropertiesFormat: &network.VirtualNetworkPropertiesFormat{\n+\t\t\t\tAddressSpace: &network.AddressSpace{\n+\t\t\t\t\tAddressPrefixes: &[]string{\n+\t\t\t\t\t\t\"192.168.0.0/24\",\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t\tSubnets: &[]network.Subnet{\n+\t\t\t\t\t{\n+\t\t\t\t\t\tName: &subnetName,\n+\t\t\t\t\t\tSubnetPropertiesFormat: &network.SubnetPropertiesFormat{\n+\t\t\t\t\t\t\tAddressPrefix: &subnetAddressPrefix,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t},\n+\t\t\tLocation: &region,\n+\t\t})\n+\t\tExpect(err).ToNot(HaveOccurred())\n+\t\terr = future.WaitForCompletionRef(ctx, cli.VirtualNetworks.Client())\n+\t\tExpect(err).ToNot(HaveOccurred())\n+\n+\t\tvnet, err := cli.VirtualNetworks.Get(ctx, rg, vnetPeerName, \"\")\n+\t\tExpect(err).ToNot(HaveOccurred())\n+\t\tExpect(len(*vnet.VirtualNetworkPeerings)).To(BeEquivalentTo(0))","path":"test/e2e/specs/realrp/vnetpeering.go","position":97,"original_position":97,"commit_id":"4b2783adb99b72cd680a78d4fc72e6ee3a924d97","original_commit_id":"4b2783adb99b72cd680a78d4fc72e6ee3a924d97","user":{"login":"charlesakalugwu","id":5978370,"node_id":"MDQ6VXNlcjU5NzgzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5978370?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesakalugwu","html_url":"https://github.com/charlesakalugwu","followers_url":"https://api.github.com/users/charlesakalugwu/followers","following_url":"https://api.github.com/users/charlesakalugwu/following{/other_user}","gists_url":"https://api.github.com/users/charlesakalugwu/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesakalugwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesakalugwu/subscriptions","organizations_url":"https://api.github.com/users/charlesakalugwu/orgs","repos_url":"https://api.github.com/users/charlesakalugwu/repos","events_url":"https://api.github.com/users/charlesakalugwu/events{/privacy}","received_events_url":"https://api.github.com/users/charlesakalugwu/received_events","type":"User","site_admin":false},"body":"or `To(Equal(0))`","created_at":"2018-12-18T10:05:11Z","updated_at":"2018-12-18T10:10:32Z","html_url":"https://github.com/openshift/openshift-azure/pull/886#discussion_r242473474","pull_request_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/886","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/242473474"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/886#discussion_r242473474"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/886"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/886","id":237467937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDY3OTM3","html_url":"https://github.com/openshift/openshift-azure/pull/886","diff_url":"https://github.com/openshift/openshift-azure/pull/886.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/886.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/886","number":886,"state":"open","locked":false,"title":"Add support for vnet testing","user":{"login":"kwoodson","id":1385770,"node_id":"MDQ6VXNlcjEzODU3NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"Adding ability to precreate the vnet for vnet testing purposes.","created_at":"2018-12-10T21:13:08Z","updated_at":"2018-12-18T10:10:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e76b47b8f39c336a1d4efeebae0feb734ed2eea2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1006517260,"node_id":"MDU6TGFiZWwxMDA2NTE3MjYw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/886/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/886/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/886/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/4b2783adb99b72cd680a78d4fc72e6ee3a924d97","head":{"label":"kwoodson:vnettest","ref":"vnettest","sha":"4b2783adb99b72cd680a78d4fc72e6ee3a924d97","user":{"login":"kwoodson","id":1385770,"node_id":"MDQ6VXNlcjEzODU3NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"repo":{"id":141175897,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExNzU4OTc=","name":"azure-helm","full_name":"kwoodson/azure-helm","private":false,"owner":{"login":"kwoodson","id":1385770,"node_id":"MDQ6VXNlcjEzODU3NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kwoodson/azure-helm","description":null,"fork":true,"url":"https://api.github.com/repos/kwoodson/azure-helm","forks_url":"https://api.github.com/repos/kwoodson/azure-helm/forks","keys_url":"https://api.github.com/repos/kwoodson/azure-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwoodson/azure-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwoodson/azure-helm/teams","hooks_url":"https://api.github.com/repos/kwoodson/azure-helm/hooks","issue_events_url":"https://api.github.com/repos/kwoodson/azure-helm/issues/events{/number}","events_url":"https://api.github.com/repos/kwoodson/azure-helm/events","assignees_url":"https://api.github.com/repos/kwoodson/azure-helm/assignees{/user}","branches_url":"https://api.github.com/repos/kwoodson/azure-helm/branches{/branch}","tags_url":"https://api.github.com/repos/kwoodson/azure-helm/tags","blobs_url":"https://api.github.com/repos/kwoodson/azure-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwoodson/azure-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwoodson/azure-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwoodson/azure-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwoodson/azure-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/kwoodson/azure-helm/languages","stargazers_url":"https://api.github.com/repos/kwoodson/azure-helm/stargazers","contributors_url":"https://api.github.com/repos/kwoodson/azure-helm/contributors","subscribers_url":"https://api.github.com/repos/kwoodson/azure-helm/subscribers","subscription_url":"https://api.github.com/repos/kwoodson/azure-helm/subscription","commits_url":"https://api.github.com/repos/kwoodson/azure-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwoodson/azure-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwoodson/azure-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwoodson/azure-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwoodson/azure-helm/contents/{+path}","compare_url":"https://api.github.com/repos/kwoodson/azure-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwoodson/azure-helm/merges","archive_url":"https://api.github.com/repos/kwoodson/azure-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwoodson/azure-helm/downloads","issues_url":"https://api.github.com/repos/kwoodson/azure-helm/issues{/number}","pulls_url":"https://api.github.com/repos/kwoodson/azure-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/kwoodson/azure-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/kwoodson/azure-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwoodson/azure-helm/labels{/name}","releases_url":"https://api.github.com/repos/kwoodson/azure-helm/releases{/id}","deployments_url":"https://api.github.com/repos/kwoodson/azure-helm/deployments","created_at":"2018-07-16T18:14:07Z","updated_at":"2018-12-17T20:11:46Z","pushed_at":"2018-12-17T21:35:51Z","git_url":"git://github.com/kwoodson/azure-helm.git","ssh_url":"git@github.com:kwoodson/azure-helm.git","clone_url":"https://github.com/kwoodson/azure-helm.git","svn_url":"https://github.com/kwoodson/azure-helm","homepage":null,"size":38834,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"685243b24c771fe5f4c0f7ac00fddead90a4d51a","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-12-18T09:09:31Z","pushed_at":"2018-12-18T09:52:23Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":38726,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":82,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/886"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/886"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/886"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/886/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/886/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/886/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/4b2783adb99b72cd680a78d4fc72e6ee3a924d97"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"charlesakalugwu"}}