{"action":"closed","number":110,"pull_request":{"url":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110","id":181864294,"html_url":"https://github.com/jhthorsen/json-validator/pull/110","diff_url":"https://github.com/jhthorsen/json-validator/pull/110.diff","patch_url":"https://github.com/jhthorsen/json-validator/pull/110.patch","issue_url":"https://api.github.com/repos/jhthorsen/json-validator/issues/110","number":110,"state":"closed","locked":false,"title":"Fix strict for object issues","user":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"body":"In Validator.pm line 763, you check if \"additionalProperties\" exists in $schema but in Joi.pm you create a \"additionalItems\" key when \"strict\" is used.\r\nAs the additionalProperties key is never created, the strict option never works.","created_at":"2018-04-16T13:40:39Z","updated_at":"2018-04-18T07:51:30Z","closed_at":"2018-04-18T07:51:30Z","merged_at":"2018-04-18T07:51:30Z","merge_commit_sha":"6bec330201443a9070bcec9c87459010cc79cfc3","assignee":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"assignees":[{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":251297971,"url":"https://api.github.com/repos/jhthorsen/json-validator/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110/commits","review_comments_url":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110/comments","review_comment_url":"https://api.github.com/repos/jhthorsen/json-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhthorsen/json-validator/issues/110/comments","statuses_url":"https://api.github.com/repos/jhthorsen/json-validator/statuses/3e9bbed98b6fd3fd9e7aeb6221543f9d3fb2a979","head":{"label":"pamasse:patch-1","ref":"patch-1","sha":"3e9bbed98b6fd3fd9e7aeb6221543f9d3fb2a979","user":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"repo":{"id":129749033,"name":"json-validator","full_name":"pamasse/json-validator","owner":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pamasse/json-validator","description":"Validate data against a JSON schema","fork":true,"url":"https://api.github.com/repos/pamasse/json-validator","forks_url":"https://api.github.com/repos/pamasse/json-validator/forks","keys_url":"https://api.github.com/repos/pamasse/json-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pamasse/json-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pamasse/json-validator/teams","hooks_url":"https://api.github.com/repos/pamasse/json-validator/hooks","issue_events_url":"https://api.github.com/repos/pamasse/json-validator/issues/events{/number}","events_url":"https://api.github.com/repos/pamasse/json-validator/events","assignees_url":"https://api.github.com/repos/pamasse/json-validator/assignees{/user}","branches_url":"https://api.github.com/repos/pamasse/json-validator/branches{/branch}","tags_url":"https://api.github.com/repos/pamasse/json-validator/tags","blobs_url":"https://api.github.com/repos/pamasse/json-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pamasse/json-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pamasse/json-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pamasse/json-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pamasse/json-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/pamasse/json-validator/languages","stargazers_url":"https://api.github.com/repos/pamasse/json-validator/stargazers","contributors_url":"https://api.github.com/repos/pamasse/json-validator/contributors","subscribers_url":"https://api.github.com/repos/pamasse/json-validator/subscribers","subscription_url":"https://api.github.com/repos/pamasse/json-validator/subscription","commits_url":"https://api.github.com/repos/pamasse/json-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pamasse/json-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pamasse/json-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pamasse/json-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pamasse/json-validator/contents/{+path}","compare_url":"https://api.github.com/repos/pamasse/json-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pamasse/json-validator/merges","archive_url":"https://api.github.com/repos/pamasse/json-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pamasse/json-validator/downloads","issues_url":"https://api.github.com/repos/pamasse/json-validator/issues{/number}","pulls_url":"https://api.github.com/repos/pamasse/json-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/pamasse/json-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/pamasse/json-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pamasse/json-validator/labels{/name}","releases_url":"https://api.github.com/repos/pamasse/json-validator/releases{/id}","deployments_url":"https://api.github.com/repos/pamasse/json-validator/deployments","created_at":"2018-04-16T13:36:58Z","updated_at":"2018-04-16T13:37:00Z","pushed_at":"2018-04-17T07:24:32Z","git_url":"git://github.com/pamasse/json-validator.git","ssh_url":"git@github.com:pamasse/json-validator.git","clone_url":"https://github.com/pamasse/json-validator.git","svn_url":"https://github.com/pamasse/json-validator","homepage":null,"size":558,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhthorsen:master","ref":"master","sha":"4781b1620e65ee46b406f6c2bd251d43658c8f85","user":{"login":"jhthorsen","id":45729,"avatar_url":"https://avatars2.githubusercontent.com/u/45729?v=4","gravatar_id":"","url":"https://api.github.com/users/jhthorsen","html_url":"https://github.com/jhthorsen","followers_url":"https://api.github.com/users/jhthorsen/followers","following_url":"https://api.github.com/users/jhthorsen/following{/other_user}","gists_url":"https://api.github.com/users/jhthorsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhthorsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhthorsen/subscriptions","organizations_url":"https://api.github.com/users/jhthorsen/orgs","repos_url":"https://api.github.com/users/jhthorsen/repos","events_url":"https://api.github.com/users/jhthorsen/events{/privacy}","received_events_url":"https://api.github.com/users/jhthorsen/received_events","type":"User","site_admin":false},"repo":{"id":41203442,"name":"json-validator","full_name":"jhthorsen/json-validator","owner":{"login":"jhthorsen","id":45729,"avatar_url":"https://avatars2.githubusercontent.com/u/45729?v=4","gravatar_id":"","url":"https://api.github.com/users/jhthorsen","html_url":"https://github.com/jhthorsen","followers_url":"https://api.github.com/users/jhthorsen/followers","following_url":"https://api.github.com/users/jhthorsen/following{/other_user}","gists_url":"https://api.github.com/users/jhthorsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhthorsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhthorsen/subscriptions","organizations_url":"https://api.github.com/users/jhthorsen/orgs","repos_url":"https://api.github.com/users/jhthorsen/repos","events_url":"https://api.github.com/users/jhthorsen/events{/privacy}","received_events_url":"https://api.github.com/users/jhthorsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhthorsen/json-validator","description":"Validate data against a JSON schema","fork":false,"url":"https://api.github.com/repos/jhthorsen/json-validator","forks_url":"https://api.github.com/repos/jhthorsen/json-validator/forks","keys_url":"https://api.github.com/repos/jhthorsen/json-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhthorsen/json-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhthorsen/json-validator/teams","hooks_url":"https://api.github.com/repos/jhthorsen/json-validator/hooks","issue_events_url":"https://api.github.com/repos/jhthorsen/json-validator/issues/events{/number}","events_url":"https://api.github.com/repos/jhthorsen/json-validator/events","assignees_url":"https://api.github.com/repos/jhthorsen/json-validator/assignees{/user}","branches_url":"https://api.github.com/repos/jhthorsen/json-validator/branches{/branch}","tags_url":"https://api.github.com/repos/jhthorsen/json-validator/tags","blobs_url":"https://api.github.com/repos/jhthorsen/json-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhthorsen/json-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhthorsen/json-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhthorsen/json-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhthorsen/json-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/jhthorsen/json-validator/languages","stargazers_url":"https://api.github.com/repos/jhthorsen/json-validator/stargazers","contributors_url":"https://api.github.com/repos/jhthorsen/json-validator/contributors","subscribers_url":"https://api.github.com/repos/jhthorsen/json-validator/subscribers","subscription_url":"https://api.github.com/repos/jhthorsen/json-validator/subscription","commits_url":"https://api.github.com/repos/jhthorsen/json-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhthorsen/json-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhthorsen/json-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhthorsen/json-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhthorsen/json-validator/contents/{+path}","compare_url":"https://api.github.com/repos/jhthorsen/json-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhthorsen/json-validator/merges","archive_url":"https://api.github.com/repos/jhthorsen/json-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhthorsen/json-validator/downloads","issues_url":"https://api.github.com/repos/jhthorsen/json-validator/issues{/number}","pulls_url":"https://api.github.com/repos/jhthorsen/json-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/jhthorsen/json-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/jhthorsen/json-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhthorsen/json-validator/labels{/name}","releases_url":"https://api.github.com/repos/jhthorsen/json-validator/releases{/id}","deployments_url":"https://api.github.com/repos/jhthorsen/json-validator/deployments","created_at":"2015-08-22T11:01:53Z","updated_at":"2018-04-09T18:32:07Z","pushed_at":"2018-04-18T07:51:30Z","git_url":"git://github.com/jhthorsen/json-validator.git","ssh_url":"git@github.com:jhthorsen/json-validator.git","clone_url":"https://github.com/jhthorsen/json-validator.git","svn_url":"https://github.com/jhthorsen/json-validator","homepage":null,"size":551,"stargazers_count":23,"watchers_count":23,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":24,"open_issues":6,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110"},"html":{"href":"https://github.com/jhthorsen/json-validator/pull/110"},"issue":{"href":"https://api.github.com/repos/jhthorsen/json-validator/issues/110"},"comments":{"href":"https://api.github.com/repos/jhthorsen/json-validator/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/jhthorsen/json-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhthorsen/json-validator/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/jhthorsen/json-validator/statuses/3e9bbed98b6fd3fd9e7aeb6221543f9d3fb2a979"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jhthorsen","id":45729,"avatar_url":"https://avatars2.githubusercontent.com/u/45729?v=4","gravatar_id":"","url":"https://api.github.com/users/jhthorsen","html_url":"https://github.com/jhthorsen","followers_url":"https://api.github.com/users/jhthorsen/followers","following_url":"https://api.github.com/users/jhthorsen/following{/other_user}","gists_url":"https://api.github.com/users/jhthorsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhthorsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhthorsen/subscriptions","organizations_url":"https://api.github.com/users/jhthorsen/orgs","repos_url":"https://api.github.com/users/jhthorsen/repos","events_url":"https://api.github.com/users/jhthorsen/events{/privacy}","received_events_url":"https://api.github.com/users/jhthorsen/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"jhthorsen"}}