{"action":"created","comment":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/166112857","pull_request_review_id":94141855,"id":166112857,"diff_hunk":"@@ -415,8 +521,14 @@ void static inline calc_and_print_results(double total_t, int len,\n     PE_set_used_adjustments(&nPEs, &stride, &start_pe, metric_info);\n \n     if (total_t > 0 ) {\n+\n+#ifdef ENABLE_OPENMP\n+        bw = (len / 1e6 * metric_info.window_size * metric_info.trials *\n+                (double)metric_info.nthreads) / (total_t / 1e6);","path":"test/performance/shmem_perf_suite/bw_common.h","position":259,"original_position":259,"commit_id":"79e7ccea7f3921c99dae8178271ff8b00dc54363","original_commit_id":"79e7ccea7f3921c99dae8178271ff8b00dc54363","user":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"body":"I forget C type promotion rules, but I wonder if there could be loss of precision here since this will be evaluated left-to-right (i.e. `len/1e6` generating an integer result).  I would tend to err on the safe side and change those `1e6` literals to `1.0e6` or throw in an explicit type cast on the left-hand side of the expression.","created_at":"2018-02-05T21:11:16Z","updated_at":"2018-02-05T21:14:20Z","html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594#discussion_r166112857","pull_request_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/166112857"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594#discussion_r166112857"},"pull_request":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594","id":166104709,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594","diff_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594.diff","patch_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594.patch","issue_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/594","number":594,"state":"open","locked":false,"title":"Multi-threaded Throughput Benchmarks ","user":{"login":"wrrobin","id":4553345,"avatar_url":"https://avatars2.githubusercontent.com/u/4553345?v=4","gravatar_id":"","url":"https://api.github.com/users/wrrobin","html_url":"https://github.com/wrrobin","followers_url":"https://api.github.com/users/wrrobin/followers","following_url":"https://api.github.com/users/wrrobin/following{/other_user}","gists_url":"https://api.github.com/users/wrrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/wrrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrrobin/subscriptions","organizations_url":"https://api.github.com/users/wrrobin/orgs","repos_url":"https://api.github.com/users/wrrobin/repos","events_url":"https://api.github.com/users/wrrobin/events{/privacy}","received_events_url":"https://api.github.com/users/wrrobin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-30T21:39:44Z","updated_at":"2018-02-05T21:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5eb6635d96dc66d848ea4175ae8fb8ebc4e918","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594/commits","review_comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594/comments","review_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/594/comments","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/79e7ccea7f3921c99dae8178271ff8b00dc54363","head":{"label":"wrrobin:pr/threaded_tput_benchmarks","ref":"pr/threaded_tput_benchmarks","sha":"79e7ccea7f3921c99dae8178271ff8b00dc54363","user":{"login":"wrrobin","id":4553345,"avatar_url":"https://avatars2.githubusercontent.com/u/4553345?v=4","gravatar_id":"","url":"https://api.github.com/users/wrrobin","html_url":"https://github.com/wrrobin","followers_url":"https://api.github.com/users/wrrobin/followers","following_url":"https://api.github.com/users/wrrobin/following{/other_user}","gists_url":"https://api.github.com/users/wrrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/wrrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrrobin/subscriptions","organizations_url":"https://api.github.com/users/wrrobin/orgs","repos_url":"https://api.github.com/users/wrrobin/repos","events_url":"https://api.github.com/users/wrrobin/events{/privacy}","received_events_url":"https://api.github.com/users/wrrobin/received_events","type":"User","site_admin":false},"repo":{"id":88908775,"name":"SOS","full_name":"wrrobin/SOS","owner":{"login":"wrrobin","id":4553345,"avatar_url":"https://avatars2.githubusercontent.com/u/4553345?v=4","gravatar_id":"","url":"https://api.github.com/users/wrrobin","html_url":"https://github.com/wrrobin","followers_url":"https://api.github.com/users/wrrobin/followers","following_url":"https://api.github.com/users/wrrobin/following{/other_user}","gists_url":"https://api.github.com/users/wrrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/wrrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrrobin/subscriptions","organizations_url":"https://api.github.com/users/wrrobin/orgs","repos_url":"https://api.github.com/users/wrrobin/repos","events_url":"https://api.github.com/users/wrrobin/events{/privacy}","received_events_url":"https://api.github.com/users/wrrobin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wrrobin/SOS","description":"Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4 and the Open Fabric Interface (OFI).  Please click on the Wiki tab for help with building and using SOS.","fork":true,"url":"https://api.github.com/repos/wrrobin/SOS","forks_url":"https://api.github.com/repos/wrrobin/SOS/forks","keys_url":"https://api.github.com/repos/wrrobin/SOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wrrobin/SOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wrrobin/SOS/teams","hooks_url":"https://api.github.com/repos/wrrobin/SOS/hooks","issue_events_url":"https://api.github.com/repos/wrrobin/SOS/issues/events{/number}","events_url":"https://api.github.com/repos/wrrobin/SOS/events","assignees_url":"https://api.github.com/repos/wrrobin/SOS/assignees{/user}","branches_url":"https://api.github.com/repos/wrrobin/SOS/branches{/branch}","tags_url":"https://api.github.com/repos/wrrobin/SOS/tags","blobs_url":"https://api.github.com/repos/wrrobin/SOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wrrobin/SOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wrrobin/SOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wrrobin/SOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wrrobin/SOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wrrobin/SOS/languages","stargazers_url":"https://api.github.com/repos/wrrobin/SOS/stargazers","contributors_url":"https://api.github.com/repos/wrrobin/SOS/contributors","subscribers_url":"https://api.github.com/repos/wrrobin/SOS/subscribers","subscription_url":"https://api.github.com/repos/wrrobin/SOS/subscription","commits_url":"https://api.github.com/repos/wrrobin/SOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wrrobin/SOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wrrobin/SOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wrrobin/SOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wrrobin/SOS/contents/{+path}","compare_url":"https://api.github.com/repos/wrrobin/SOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wrrobin/SOS/merges","archive_url":"https://api.github.com/repos/wrrobin/SOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wrrobin/SOS/downloads","issues_url":"https://api.github.com/repos/wrrobin/SOS/issues{/number}","pulls_url":"https://api.github.com/repos/wrrobin/SOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wrrobin/SOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wrrobin/SOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wrrobin/SOS/labels{/name}","releases_url":"https://api.github.com/repos/wrrobin/SOS/releases{/id}","deployments_url":"https://api.github.com/repos/wrrobin/SOS/deployments","created_at":"2017-04-20T20:42:29Z","updated_at":"2017-04-20T20:42:31Z","pushed_at":"2018-02-01T21:55:14Z","git_url":"git://github.com/wrrobin/SOS.git","ssh_url":"git@github.com:wrrobin/SOS.git","clone_url":"https://github.com/wrrobin/SOS.git","svn_url":"https://github.com/wrrobin/SOS","homepage":"","size":3130,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sandia-OpenSHMEM:master","ref":"master","sha":"f585e5e64ec13ef97868a435a228e9f716bb8db9","user":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars0.githubusercontent.com/u/16339082?v=4","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"repo":{"id":42528680,"name":"SOS","full_name":"Sandia-OpenSHMEM/SOS","owner":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars0.githubusercontent.com/u/16339082?v=4","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS","description":"Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4 and the Open Fabric Interface (OFI).  Please click on the Wiki tab for help with building and using SOS.","fork":false,"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS","forks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/forks","keys_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/teams","hooks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/hooks","issue_events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/events{/number}","events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/events","assignees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/assignees{/user}","branches_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/branches{/branch}","tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/tags","blobs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/languages","stargazers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/stargazers","contributors_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contributors","subscribers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscribers","subscription_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscription","commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contents/{+path}","compare_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/merges","archive_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/downloads","issues_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues{/number}","pulls_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/labels{/name}","releases_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/releases{/id}","deployments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/deployments","created_at":"2015-09-15T15:34:37Z","updated_at":"2018-01-27T23:08:05Z","pushed_at":"2018-02-05T18:39:36Z","git_url":"git://github.com/Sandia-OpenSHMEM/SOS.git","ssh_url":"git@github.com:Sandia-OpenSHMEM/SOS.git","clone_url":"https://github.com/Sandia-OpenSHMEM/SOS.git","svn_url":"https://github.com/Sandia-OpenSHMEM/SOS","homepage":"","size":3203,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":27,"open_issues":49,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/594"},"issue":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/594"},"comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/79e7ccea7f3921c99dae8178271ff8b00dc54363"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jdinan"}}