{"action":"created","issue":{"url":"https://api.github.com/repos/sahlberg/libnfs/issues/260","repository_url":"https://api.github.com/repos/sahlberg/libnfs","labels_url":"https://api.github.com/repos/sahlberg/libnfs/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/sahlberg/libnfs/issues/260/comments","events_url":"https://api.github.com/repos/sahlberg/libnfs/issues/260/events","html_url":"https://github.com/sahlberg/libnfs/pull/260","id":337692909,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODExNTAy","number":260,"title":"Wrap use of SOCK_CLOEXEC with __linux__","user":{"login":"pingerino","id":5257452,"node_id":"MDQ6VXNlcjUyNTc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5257452?v=4","gravatar_id":"","url":"https://api.github.com/users/pingerino","html_url":"https://github.com/pingerino","followers_url":"https://api.github.com/users/pingerino/followers","following_url":"https://api.github.com/users/pingerino/following{/other_user}","gists_url":"https://api.github.com/users/pingerino/gists{/gist_id}","starred_url":"https://api.github.com/users/pingerino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingerino/subscriptions","organizations_url":"https://api.github.com/users/pingerino/orgs","repos_url":"https://api.github.com/users/pingerino/repos","events_url":"https://api.github.com/users/pingerino/events{/privacy}","received_events_url":"https://api.github.com/users/pingerino/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-02T23:11:05Z","updated_at":"2018-07-03T08:40:33Z","closed_at":"2018-07-03T08:38:44Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sahlberg/libnfs/pulls/260","html_url":"https://github.com/sahlberg/libnfs/pull/260","diff_url":"https://github.com/sahlberg/libnfs/pull/260.diff","patch_url":"https://github.com/sahlberg/libnfs/pull/260.patch"},"body":"This guards against the case where your clibrary defines SOCK_CLOEXEC\r\nbut the underlying network library does not support it.\r\n\r\nI'm not sure this is the ideal solution, for context: I'm trying to use libnfs in an embedded context with musl libc and picotcp. Musl libc defines SOCK_CLOEXEC, but picotcp does not support the option. "},"comment":{"url":"https://api.github.com/repos/sahlberg/libnfs/issues/comments/402059546","html_url":"https://github.com/sahlberg/libnfs/pull/260#issuecomment-402059546","issue_url":"https://api.github.com/repos/sahlberg/libnfs/issues/260","id":402059546,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjA1OTU0Ng==","user":{"login":"sahlberg","id":494992,"node_id":"MDQ6VXNlcjQ5NDk5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/494992?v=4","gravatar_id":"","url":"https://api.github.com/users/sahlberg","html_url":"https://github.com/sahlberg","followers_url":"https://api.github.com/users/sahlberg/followers","following_url":"https://api.github.com/users/sahlberg/following{/other_user}","gists_url":"https://api.github.com/users/sahlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/sahlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahlberg/subscriptions","organizations_url":"https://api.github.com/users/sahlberg/orgs","repos_url":"https://api.github.com/users/sahlberg/repos","events_url":"https://api.github.com/users/sahlberg/events{/privacy}","received_events_url":"https://api.github.com/users/sahlberg/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T08:40:33Z","updated_at":"2018-07-03T08:40:33Z","author_association":"OWNER","body":"Might be better with a single #if defined...   defined\r\nthan two nested ifdefs, but this is good enough.\r\n\r\n\r\nThanks for your contribution.  Is it worth adding something about your platform to README?\r\nSecond, please have a look at libsmb2 too. If you want to use nfs from userspace, chances are good you might want to use smb2 too :-)\r\n\r\n"}}
{"actor":{"display_login":"sahlberg"}}