{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/4342","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4342/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4342/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4342/events","html_url":"https://github.com/apache/incubator-airflow/pull/4342","id":392282218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTg5Mzcw","number":4342,"title":"[AIRFLOW-3506] use match_phrase to query log_id in elasticsearch","user":{"login":"pingzh","id":8662365,"node_id":"MDQ6VXNlcjg2NjIzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8662365?v=4","gravatar_id":"","url":"https://api.github.com/users/pingzh","html_url":"https://github.com/pingzh","followers_url":"https://api.github.com/users/pingzh/followers","following_url":"https://api.github.com/users/pingzh/following{/other_user}","gists_url":"https://api.github.com/users/pingzh/gists{/gist_id}","starred_url":"https://api.github.com/users/pingzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingzh/subscriptions","organizations_url":"https://api.github.com/users/pingzh/orgs","repos_url":"https://api.github.com/users/pingzh/repos","events_url":"https://api.github.com/users/pingzh/events{/privacy}","received_events_url":"https://api.github.com/users/pingzh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-18T18:33:53Z","updated_at":"2018-12-18T22:50:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4342","html_url":"https://github.com/apache/incubator-airflow/pull/4342","diff_url":"https://github.com/apache/incubator-airflow/pull/4342.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/4342.patch"},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-3506\r\n  - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nWe have noticed that the elasticsearch_logging_backend use match to query the log_id from elasticsearch, which ends up getting more results from elasticsearch. It should use match_phrase to query the log_id as a phrase since log_id is a phrase.\r\n\r\n![image](https://user-images.githubusercontent.com/8662365/50174807-fc7b9280-02af-11e9-9033-d0fe91aceba4.png)\r\n\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n  - All the public functions and the classes in the PR contain docstrings that explain what it does\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `flake8`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/448401397","html_url":"https://github.com/apache/incubator-airflow/pull/4342#issuecomment-448401397","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4342","id":448401397,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQwMTM5Nw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T22:50:15Z","updated_at":"2018-12-18T22:50:15Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=h1) Report\n> Merging [#4342](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/3bd85953f98ebd8dec9db38ea84b21d5b1e20edf?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/4342/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #4342      +/-   ##\n==========================================\n- Coverage    78.1%   78.09%   -0.01%     \n==========================================\n  Files         201      201              \n  Lines       16471    16471              \n==========================================\n- Hits        12864    12863       -1     \n- Misses       3607     3608       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [airflow/utils/log/es\\_task\\_handler.py](https://codecov.io/gh/apache/incubator-airflow/pull/4342/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `100% <ø> (ø)` | :arrow_up: |\n| [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/4342/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=) | `92.31% <0%> (-0.05%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=footer). Last update [3bd8595...e188e1d](https://codecov.io/gh/apache/incubator-airflow/pull/4342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}