{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/231780288","pull_request_review_id":172824042,"id":231780288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTc4MDI4OA==","diff_hunk":"@@ -671,6 +679,11 @@ void MediaRecorderImpl::notifyObserver(recorder_observer_command_t cmd, ...)\n \t\t\tstd::shared_ptr<unsigned char> autodata(data, [](unsigned char *p){ delete[] p; });\n \t\t\trow.enQueue(&MediaRecorderObserverInterface::onRecordBufferDataReached, mRecorderObserver, mRecorder, autodata, size);\n \t\t} break;\n+\t\tcase RECORDER_OBSERVER_COMMAND_FLUSH: {\n+\t\t\tmedvdbg(\"RECORDER_OBSERVER_COMMAND_FLUSH\\n\");","path":"framework/src/media/MediaRecorderImpl.cpp","position":34,"original_position":34,"commit_id":"09aceffac1bfbb1ccfc491111f4425f78bc07c4b","original_commit_id":"09aceffac1bfbb1ccfc491111f4425f78bc07c4b","user":{"login":"junmin-kim","id":25811851,"node_id":"MDQ6VXNlcjI1ODExODUx","avatar_url":"https://avatars0.githubusercontent.com/u/25811851?v=4","gravatar_id":"","url":"https://api.github.com/users/junmin-kim","html_url":"https://github.com/junmin-kim","followers_url":"https://api.github.com/users/junmin-kim/followers","following_url":"https://api.github.com/users/junmin-kim/following{/other_user}","gists_url":"https://api.github.com/users/junmin-kim/gists{/gist_id}","starred_url":"https://api.github.com/users/junmin-kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmin-kim/subscriptions","organizations_url":"https://api.github.com/users/junmin-kim/orgs","repos_url":"https://api.github.com/users/junmin-kim/repos","events_url":"https://api.github.com/users/junmin-kim/events{/privacy}","received_events_url":"https://api.github.com/users/junmin-kim/received_events","type":"User","site_admin":false},"body":"Yes. mObMtx is needed only this case, isn't it?","created_at":"2018-11-08T06:57:26Z","updated_at":"2018-11-08T06:57:26Z","html_url":"https://github.com/Samsung/TizenRT/pull/2434#discussion_r231780288","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/231780288"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2434#discussion_r231780288"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434"}},"in_reply_to_id":231777341},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434","id":229263194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjYzMTk0","html_url":"https://github.com/Samsung/TizenRT/pull/2434","diff_url":"https://github.com/Samsung/TizenRT/pull/2434.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/2434.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2434","number":2434,"state":"open","locked":false,"title":"media: add handling logic for observer flush","user":{"login":"jsdosa","id":26373286,"node_id":"MDQ6VXNlcjI2MzczMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/26373286?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdosa","html_url":"https://github.com/jsdosa","followers_url":"https://api.github.com/users/jsdosa/followers","following_url":"https://api.github.com/users/jsdosa/following{/other_user}","gists_url":"https://api.github.com/users/jsdosa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdosa/subscriptions","organizations_url":"https://api.github.com/users/jsdosa/orgs","repos_url":"https://api.github.com/users/jsdosa/repos","events_url":"https://api.github.com/users/jsdosa/events{/privacy}","received_events_url":"https://api.github.com/users/jsdosa/received_events","type":"User","site_admin":false},"body":"Change the logic so that recordfinished is\r\ncalled after buffer data is passed to the user at recorder stop\r\n\r\nSigned-off-by: jaesick.shin <jaesick.shin@samsung.com>","created_at":"2018-11-08T06:32:30Z","updated_at":"2018-11-08T06:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bfba4cf9178cc36505306b78193f165f790909a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2434/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/09aceffac1bfbb1ccfc491111f4425f78bc07c4b","head":{"label":"jsdosa:observer_flush","ref":"observer_flush","sha":"09aceffac1bfbb1ccfc491111f4425f78bc07c4b","user":{"login":"jsdosa","id":26373286,"node_id":"MDQ6VXNlcjI2MzczMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/26373286?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdosa","html_url":"https://github.com/jsdosa","followers_url":"https://api.github.com/users/jsdosa/followers","following_url":"https://api.github.com/users/jsdosa/following{/other_user}","gists_url":"https://api.github.com/users/jsdosa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdosa/subscriptions","organizations_url":"https://api.github.com/users/jsdosa/orgs","repos_url":"https://api.github.com/users/jsdosa/repos","events_url":"https://api.github.com/users/jsdosa/events{/privacy}","received_events_url":"https://api.github.com/users/jsdosa/received_events","type":"User","site_admin":false},"repo":{"id":129748293,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NDgyOTM=","name":"TizenRT","full_name":"jsdosa/TizenRT","private":false,"owner":{"login":"jsdosa","id":26373286,"node_id":"MDQ6VXNlcjI2MzczMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/26373286?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdosa","html_url":"https://github.com/jsdosa","followers_url":"https://api.github.com/users/jsdosa/followers","following_url":"https://api.github.com/users/jsdosa/following{/other_user}","gists_url":"https://api.github.com/users/jsdosa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdosa/subscriptions","organizations_url":"https://api.github.com/users/jsdosa/orgs","repos_url":"https://api.github.com/users/jsdosa/repos","events_url":"https://api.github.com/users/jsdosa/events{/privacy}","received_events_url":"https://api.github.com/users/jsdosa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jsdosa/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/jsdosa/TizenRT","forks_url":"https://api.github.com/repos/jsdosa/TizenRT/forks","keys_url":"https://api.github.com/repos/jsdosa/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsdosa/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsdosa/TizenRT/teams","hooks_url":"https://api.github.com/repos/jsdosa/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/jsdosa/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/jsdosa/TizenRT/events","assignees_url":"https://api.github.com/repos/jsdosa/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/jsdosa/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/jsdosa/TizenRT/tags","blobs_url":"https://api.github.com/repos/jsdosa/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsdosa/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsdosa/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsdosa/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsdosa/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/jsdosa/TizenRT/languages","stargazers_url":"https://api.github.com/repos/jsdosa/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/jsdosa/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/jsdosa/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/jsdosa/TizenRT/subscription","commits_url":"https://api.github.com/repos/jsdosa/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsdosa/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsdosa/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsdosa/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsdosa/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/jsdosa/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsdosa/TizenRT/merges","archive_url":"https://api.github.com/repos/jsdosa/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsdosa/TizenRT/downloads","issues_url":"https://api.github.com/repos/jsdosa/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/jsdosa/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/jsdosa/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/jsdosa/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsdosa/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/jsdosa/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/jsdosa/TizenRT/deployments","created_at":"2018-04-16T13:31:29Z","updated_at":"2018-09-10T10:26:53Z","pushed_at":"2018-11-08T06:32:05Z","git_url":"git://github.com/jsdosa/TizenRT.git","ssh_url":"git@github.com:jsdosa/TizenRT.git","clone_url":"https://github.com/jsdosa/TizenRT.git","svn_url":"https://github.com/jsdosa/TizenRT","homepage":"","size":106532,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"1a723764920b413baca4eb2abb6fb87d4db3817a","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"node_id":"MDEwOlJlcG9zaXRvcnk4MjUxNzI1Mg==","name":"TizenRT","full_name":"Samsung/TizenRT","private":false,"owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-11-08T05:37:22Z","pushed_at":"2018-11-08T06:32:30Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":106809,"stargazers_count":204,"watchers_count":204,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":293,"open_issues":62,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2434"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2434"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2434/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2434/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/09aceffac1bfbb1ccfc491111f4425f78bc07c4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"junmin-kim"}}