{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/236968562","pull_request_review_id":179155380,"id":236968562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk2ODU2Mg==","diff_hunk":"@@ -194,7 +195,7 @@ class ExperimentDetails extends Page<{}, ExperimentDetailsState> {\n                   <div className={classes(css.cardContent, !!activeRecurringRunsCount && css.recurringRunsActive)}>\n                     {activeRecurringRunsCount + ' active'}\n                   </div>\n-                  <Button className={css.cardBtn} disableRipple={true}\n+                  <Button className={css.cardBtn} id='manageExperimentRecurringRunsBtn' disableRipple={true}","path":"frontend/src/pages/ExperimentDetails.tsx","position":22,"original_position":31,"commit_id":"f21322b4bc755eb78580a7d82bb19b677a6cecb6","original_commit_id":"cf39fcd6b7470ebe2ff47988ca8574d8ee0cf0ad","user":{"login":"yebrahim","id":1424661,"node_id":"MDQ6VXNlcjE0MjQ2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1424661?v=4","gravatar_id":"","url":"https://api.github.com/users/yebrahim","html_url":"https://github.com/yebrahim","followers_url":"https://api.github.com/users/yebrahim/followers","following_url":"https://api.github.com/users/yebrahim/following{/other_user}","gists_url":"https://api.github.com/users/yebrahim/gists{/gist_id}","starred_url":"https://api.github.com/users/yebrahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebrahim/subscriptions","organizations_url":"https://api.github.com/users/yebrahim/orgs","repos_url":"https://api.github.com/users/yebrahim/repos","events_url":"https://api.github.com/users/yebrahim/events{/privacy}","received_events_url":"https://api.github.com/users/yebrahim/received_events","type":"User","site_admin":false},"body":"SG then.","created_at":"2018-11-28T07:41:25Z","updated_at":"2018-11-28T07:41:25Z","html_url":"https://github.com/kubeflow/pipelines/pull/404#discussion_r236968562","pull_request_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/404","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/236968562"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/404#discussion_r236968562"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/404"}},"in_reply_to_id":236951300},"pull_request":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/404","id":234150781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTUwNzgx","html_url":"https://github.com/kubeflow/pipelines/pull/404","diff_url":"https://github.com/kubeflow/pipelines/pull/404.diff","patch_url":"https://github.com/kubeflow/pipelines/pull/404.patch","issue_url":"https://api.github.com/repos/kubeflow/pipelines/issues/404","number":404,"state":"open","locked":false,"title":"Adds tests for the ExperimentDetails page","user":{"login":"rileyjbauer","id":34456002,"node_id":"MDQ6VXNlcjM0NDU2MDAy","avatar_url":"https://avatars0.githubusercontent.com/u/34456002?v=4","gravatar_id":"","url":"https://api.github.com/users/rileyjbauer","html_url":"https://github.com/rileyjbauer","followers_url":"https://api.github.com/users/rileyjbauer/followers","following_url":"https://api.github.com/users/rileyjbauer/following{/other_user}","gists_url":"https://api.github.com/users/rileyjbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/rileyjbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rileyjbauer/subscriptions","organizations_url":"https://api.github.com/users/rileyjbauer/orgs","repos_url":"https://api.github.com/users/rileyjbauer/repos","events_url":"https://api.github.com/users/rileyjbauer/events{/privacy}","received_events_url":"https://api.github.com/users/rileyjbauer/received_events","type":"User","site_admin":false},"body":"The only real functional changes are adding more granularity to the try/catch in `ExperimentDetails` and calling `refresh` on the `runlistRef` as part of `load()` rather than as a callback for `setState` since it doesn't depend on state.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/pipelines/404)\n<!-- Reviewable:end -->\n","created_at":"2018-11-28T05:15:43Z","updated_at":"2018-11-28T07:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9996b3e137c7f9b462e40d245bf51879ba1e8d72","assignee":null,"assignees":[],"requested_reviewers":[{"login":"IronPan","id":2348602,"node_id":"MDQ6VXNlcjIzNDg2MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2348602?v=4","gravatar_id":"","url":"https://api.github.com/users/IronPan","html_url":"https://github.com/IronPan","followers_url":"https://api.github.com/users/IronPan/followers","following_url":"https://api.github.com/users/IronPan/following{/other_user}","gists_url":"https://api.github.com/users/IronPan/gists{/gist_id}","starred_url":"https://api.github.com/users/IronPan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronPan/subscriptions","organizations_url":"https://api.github.com/users/IronPan/orgs","repos_url":"https://api.github.com/users/IronPan/repos","events_url":"https://api.github.com/users/IronPan/events{/privacy}","received_events_url":"https://api.github.com/users/IronPan/received_events","type":"User","site_admin":false},{"login":"qimingj","id":13439553,"node_id":"MDQ6VXNlcjEzNDM5NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13439553?v=4","gravatar_id":"","url":"https://api.github.com/users/qimingj","html_url":"https://github.com/qimingj","followers_url":"https://api.github.com/users/qimingj/followers","following_url":"https://api.github.com/users/qimingj/following{/other_user}","gists_url":"https://api.github.com/users/qimingj/gists{/gist_id}","starred_url":"https://api.github.com/users/qimingj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qimingj/subscriptions","organizations_url":"https://api.github.com/users/qimingj/orgs","repos_url":"https://api.github.com/users/qimingj/repos","events_url":"https://api.github.com/users/qimingj/events{/privacy}","received_events_url":"https://api.github.com/users/qimingj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":930619516,"node_id":"MDU6TGFiZWw5MzA2MTk1MTY=","url":"https://api.github.com/repos/kubeflow/pipelines/labels/area/front-end","name":"area/front-end","color":"d2b48c","default":false},{"id":930619528,"node_id":"MDU6TGFiZWw5MzA2MTk1Mjg=","url":"https://api.github.com/repos/kubeflow/pipelines/labels/area/testing","name":"area/testing","color":"00daff","default":false},{"id":942897534,"node_id":"MDU6TGFiZWw5NDI4OTc1MzQ=","url":"https://api.github.com/repos/kubeflow/pipelines/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/404/commits","review_comments_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/404/comments","review_comment_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/issues/404/comments","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/f21322b4bc755eb78580a7d82bb19b677a6cecb6","head":{"label":"kubeflow:experiment-details-tests","ref":"experiment-details-tests","sha":"f21322b4bc755eb78580a7d82bb19b677a6cecb6","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":133100880,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMDA4ODA=","name":"pipelines","full_name":"kubeflow/pipelines","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":false,"url":"https://api.github.com/repos/kubeflow/pipelines","forks_url":"https://api.github.com/repos/kubeflow/pipelines/forks","keys_url":"https://api.github.com/repos/kubeflow/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/pipelines/teams","hooks_url":"https://api.github.com/repos/kubeflow/pipelines/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/pipelines/events","assignees_url":"https://api.github.com/repos/kubeflow/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/pipelines/tags","blobs_url":"https://api.github.com/repos/kubeflow/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/pipelines/languages","stargazers_url":"https://api.github.com/repos/kubeflow/pipelines/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/pipelines/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/pipelines/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/pipelines/subscription","commits_url":"https://api.github.com/repos/kubeflow/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/pipelines/merges","archive_url":"https://api.github.com/repos/kubeflow/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/pipelines/downloads","issues_url":"https://api.github.com/repos/kubeflow/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/pipelines/deployments","created_at":"2018-05-12T00:31:47Z","updated_at":"2018-11-28T07:31:25Z","pushed_at":"2018-11-28T07:31:20Z","git_url":"git://github.com/kubeflow/pipelines.git","ssh_url":"git@github.com:kubeflow/pipelines.git","clone_url":"https://github.com/kubeflow/pipelines.git","svn_url":"https://github.com/kubeflow/pipelines","homepage":"","size":12029,"stargazers_count":476,"watchers_count":476,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":143,"watchers":476,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"42ccde1dc25c17e7de6d0796daae8e018233c35e","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":133100880,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMDA4ODA=","name":"pipelines","full_name":"kubeflow/pipelines","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":false,"url":"https://api.github.com/repos/kubeflow/pipelines","forks_url":"https://api.github.com/repos/kubeflow/pipelines/forks","keys_url":"https://api.github.com/repos/kubeflow/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/pipelines/teams","hooks_url":"https://api.github.com/repos/kubeflow/pipelines/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/pipelines/events","assignees_url":"https://api.github.com/repos/kubeflow/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/pipelines/tags","blobs_url":"https://api.github.com/repos/kubeflow/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/pipelines/languages","stargazers_url":"https://api.github.com/repos/kubeflow/pipelines/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/pipelines/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/pipelines/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/pipelines/subscription","commits_url":"https://api.github.com/repos/kubeflow/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/pipelines/merges","archive_url":"https://api.github.com/repos/kubeflow/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/pipelines/downloads","issues_url":"https://api.github.com/repos/kubeflow/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/pipelines/deployments","created_at":"2018-05-12T00:31:47Z","updated_at":"2018-11-28T07:31:25Z","pushed_at":"2018-11-28T07:31:20Z","git_url":"git://github.com/kubeflow/pipelines.git","ssh_url":"git@github.com:kubeflow/pipelines.git","clone_url":"https://github.com/kubeflow/pipelines.git","svn_url":"https://github.com/kubeflow/pipelines","homepage":"","size":12029,"stargazers_count":476,"watchers_count":476,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":143,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/404"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/404"},"issue":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/404"},"comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/pipelines/statuses/f21322b4bc755eb78580a7d82bb19b677a6cecb6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yebrahim"}}