{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/211113250","pull_request_review_id":147468963,"id":211113250,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTExMzI1MA==","diff_hunk":"@@ -285,10 +361,19 @@ def get_font_filepaths(dependency_bundle, dependency_dir):\n         list(str). List of paths to font files that need to be copied.\n     \"\"\"\n     if 'fontsPath' not in dependency_bundle:\n+        # Skipping dependency bundle in manifest.json that does not have","path":"scripts/build.py","position":null,"original_position":298,"commit_id":"92e181fee66847cb9aa88dfcf4f6c3cf02180c94","original_commit_id":"504094d617345f98899efbec5f0dd27f6ee5f43e","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"body":"Fixed grammar inconsistency. Thanks!","created_at":"2018-08-19T19:53:14Z","updated_at":"2018-08-19T19:53:14Z","html_url":"https://github.com/oppia/oppia/pull/5514#discussion_r211113250","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5514","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/211113250"},"html":{"href":"https://github.com/oppia/oppia/pull/5514#discussion_r211113250"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5514"}},"in_reply_to_id":211086990},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5514","id":208119044,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTE5MDQ0","html_url":"https://github.com/oppia/oppia/pull/5514","diff_url":"https://github.com/oppia/oppia/pull/5514.diff","patch_url":"https://github.com/oppia/oppia/pull/5514.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5514","number":5514,"state":"open","locked":false,"title":"Fix #5502: Increasing unit test coverage for build.py and multi-threading capability","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\nFix #5502 \r\nThis PR sets out to increase coverage of build.py to :100:%.\r\n![screen shot 2018-08-13 at 6 15 06 pm](https://user-images.githubusercontent.com/11153258/44061115-09577710-9f25-11e8-90ff-c72cbfda2920.png)\r\n\r\nA few functions I am excluding from test coverage are:\r\n`write_to_file_stream()`: this function is one-liner of file.write(), which should already be tested with io lib.\r\n`build_minified_third_party_libs()` : this function is simply a wrapper to a few functions that are already tested.\r\n`build_third_party_libs()` : same as above\r\n`build()` : this is the main function.\r\n`generate_build_directory()`: this function is the main function for production build. I have added a few tests right after building process is finished for basic error cases.\r\n`get_dependecies_filepath()` : this function is tested immediately after finishing computation with various `_ensure...` utility function.\r\n`build_directory()`: this function should also be covered using the tests at the end of `generate_build_directory()`:\r\nThis PR also increases multithreading compatibility to most build tasks, except building minified third party libs(`build_minified_third_party_libs`), which needs to be done in sequence, and copy tasks.\r\n","created_at":"2018-08-13T22:14:51Z","updated_at":"2018-08-19T19:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"966fc9ea3e90e7009a7edd5e76f262c44c204815","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LanJosh","id":7851950,"node_id":"MDQ6VXNlcjc4NTE5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7851950?v=4","gravatar_id":"","url":"https://api.github.com/users/LanJosh","html_url":"https://github.com/LanJosh","followers_url":"https://api.github.com/users/LanJosh/followers","following_url":"https://api.github.com/users/LanJosh/following{/other_user}","gists_url":"https://api.github.com/users/LanJosh/gists{/gist_id}","starred_url":"https://api.github.com/users/LanJosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanJosh/subscriptions","organizations_url":"https://api.github.com/users/LanJosh/orgs","repos_url":"https://api.github.com/users/LanJosh/repos","events_url":"https://api.github.com/users/LanJosh/events{/privacy}","received_events_url":"https://api.github.com/users/LanJosh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5514/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5514/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5514/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/92e181fee66847cb9aa88dfcf4f6c3cf02180c94","head":{"label":"hoangviet1993:buildTest","ref":"buildTest","sha":"92e181fee66847cb9aa88dfcf4f6c3cf02180c94","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"repo":{"id":136071092,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNzEwOTI=","name":"oppia","full_name":"hoangviet1993/oppia","owner":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoangviet1993/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/hoangviet1993/oppia","forks_url":"https://api.github.com/repos/hoangviet1993/oppia/forks","keys_url":"https://api.github.com/repos/hoangviet1993/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoangviet1993/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoangviet1993/oppia/teams","hooks_url":"https://api.github.com/repos/hoangviet1993/oppia/hooks","issue_events_url":"https://api.github.com/repos/hoangviet1993/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/hoangviet1993/oppia/events","assignees_url":"https://api.github.com/repos/hoangviet1993/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/hoangviet1993/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/hoangviet1993/oppia/tags","blobs_url":"https://api.github.com/repos/hoangviet1993/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoangviet1993/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoangviet1993/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoangviet1993/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoangviet1993/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/hoangviet1993/oppia/languages","stargazers_url":"https://api.github.com/repos/hoangviet1993/oppia/stargazers","contributors_url":"https://api.github.com/repos/hoangviet1993/oppia/contributors","subscribers_url":"https://api.github.com/repos/hoangviet1993/oppia/subscribers","subscription_url":"https://api.github.com/repos/hoangviet1993/oppia/subscription","commits_url":"https://api.github.com/repos/hoangviet1993/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoangviet1993/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoangviet1993/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoangviet1993/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoangviet1993/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/hoangviet1993/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoangviet1993/oppia/merges","archive_url":"https://api.github.com/repos/hoangviet1993/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoangviet1993/oppia/downloads","issues_url":"https://api.github.com/repos/hoangviet1993/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/hoangviet1993/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/hoangviet1993/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/hoangviet1993/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoangviet1993/oppia/labels{/name}","releases_url":"https://api.github.com/repos/hoangviet1993/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/hoangviet1993/oppia/deployments","created_at":"2018-06-04T19:09:54Z","updated_at":"2018-08-15T22:06:43Z","pushed_at":"2018-08-19T19:35:11Z","git_url":"git://github.com/hoangviet1993/oppia.git","ssh_url":"git@github.com:hoangviet1993/oppia.git","clone_url":"https://github.com/hoangviet1993/oppia.git","svn_url":"https://github.com/hoangviet1993/oppia","homepage":"https://www.oppia.org","size":106775,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"1561b49b407014fc60d47f840529ad91b9b06715","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-08-19T18:05:12Z","pushed_at":"2018-08-19T19:35:13Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":106874,"stargazers_count":716,"watchers_count":716,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":678,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":678,"open_issues":355,"watchers":716,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5514"},"html":{"href":"https://github.com/oppia/oppia/pull/5514"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5514"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5514/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5514/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5514/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/92e181fee66847cb9aa88dfcf4f6c3cf02180c94"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hoangviet1993"}}