{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/comments/230268802","pull_request_review_id":170968825,"id":230268802,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDI2ODgwMg==","diff_hunk":"@@ -130,10 +130,11 @@ def create_vm(agent_id, stemcell_cid, cloud_properties, networks, disk_cids = ni\n       with_thread_name(\"create_vm(#{agent_id}, ...)\") do\n         bosh_vm_meta = Bosh::AzureCloud::BoshVMMeta.new(agent_id, stemcell_cid)\n         vm_props = @props_factory.parse_vm_props(cloud_properties)\n-        # TODO: move the validation into the factory's methods\n-        cloud_error(\"missing required cloud property 'instance_type'.\") if vm_props.instance_type.nil?\n-        cloud_error('Virtual Machines deployed to an Availability Zone must use managed disks') if !@use_managed_disks && !vm_props.availability_zone.nil?\n-        extras = { 'instance_type' => vm_props.instance_type.nil? ? 'unknown_instance_type' : vm_props.instance_type }\n+        if vm_props.instance_type.nil?","path":"src/bosh_azure_cpi/lib/cloud/azure/cloud.rb","position":8,"original_position":8,"commit_id":"a44c120b5c438fe74d6ac0494f0e386a50e6e13f","original_commit_id":"a44c120b5c438fe74d6ac0494f0e386a50e6e13f","user":{"login":"bingosummer","id":4787647,"node_id":"MDQ6VXNlcjQ3ODc2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4787647?v=4","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"body":"The pre-check has been added in vm_cloud_props.rb","created_at":"2018-11-02T04:43:48Z","updated_at":"2018-11-02T04:43:48Z","html_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552#discussion_r230268802","pull_request_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/comments/230268802"},"html":{"href":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552#discussion_r230268802"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552"}},"in_reply_to_id":225423637},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552","id":221680141,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjgwMTQx","html_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552","diff_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552.diff","patch_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552.patch","issue_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/552","number":552,"state":"open","locked":false,"title":"Refine the scenario of vm_resources","user":{"login":"bingosummer","id":4787647,"node_id":"MDQ6VXNlcjQ3ODc2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4787647?v=4","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"body":"The CPI method 'calculate_vm_cloud_properties' returns a list of instance types.\r\n  1. The instance types are available in the location, which is specified in CPI global configuration.\r\n  2. The instance types meet the requested 'vm_resources'.\r\n  3. The instance types which support Premium storage are recommended.\r\n\r\nWhen creating VMs, CPI will:\r\n  1. Check whether the disks are persistent disks. If so, use the instance types which support premium storage.\r\n  2. Use the instance types which are available in the available sets.","created_at":"2018-10-10T07:11:40Z","updated_at":"2018-11-02T04:43:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"350cc0df2c4a65ed1b9bbb670b805527c483f2ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/552/comments","statuses_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/statuses/a44c120b5c438fe74d6ac0494f0e386a50e6e13f","head":{"label":"bingosummer:calculate-vm-cloud-properties","ref":"calculate-vm-cloud-properties","sha":"a44c120b5c438fe74d6ac0494f0e386a50e6e13f","user":{"login":"bingosummer","id":4787647,"node_id":"MDQ6VXNlcjQ3ODc2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4787647?v=4","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"repo":{"id":45893426,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg5MzQyNg==","name":"bosh-azure-cpi-release","full_name":"bingosummer/bosh-azure-cpi-release","private":false,"owner":{"login":"bingosummer","id":4787647,"node_id":"MDQ6VXNlcjQ3ODc2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4787647?v=4","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bingosummer/bosh-azure-cpi-release","description":"BOSH Azure CPI","fork":true,"url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release","forks_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/forks","keys_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/teams","hooks_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/hooks","issue_events_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/issues/events{/number}","events_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/events","assignees_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/assignees{/user}","branches_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/branches{/branch}","tags_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/tags","blobs_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/statuses/{sha}","languages_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/languages","stargazers_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/stargazers","contributors_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/contributors","subscribers_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/subscribers","subscription_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/subscription","commits_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/contents/{+path}","compare_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/merges","archive_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/downloads","issues_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/issues{/number}","pulls_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/pulls{/number}","milestones_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/milestones{/number}","notifications_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/labels{/name}","releases_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/releases{/id}","deployments_url":"https://api.github.com/repos/bingosummer/bosh-azure-cpi-release/deployments","created_at":"2015-11-10T06:52:37Z","updated_at":"2018-10-01T19:40:04Z","pushed_at":"2018-11-02T02:17:21Z","git_url":"git://github.com/bingosummer/bosh-azure-cpi-release.git","ssh_url":"git@github.com:bingosummer/bosh-azure-cpi-release.git","clone_url":"https://github.com/bingosummer/bosh-azure-cpi-release.git","svn_url":"https://github.com/bingosummer/bosh-azure-cpi-release","homepage":"","size":98553,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"cloudfoundry:master","ref":"master","sha":"d4f3462cacbe49ee79f0c47c58620107cb9715fd","user":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":39185853,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE4NTg1Mw==","name":"bosh-azure-cpi-release","full_name":"cloudfoundry/bosh-azure-cpi-release","private":false,"owner":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release","description":"BOSH Azure CPI","fork":false,"url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release","forks_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/forks","keys_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/events","assignees_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/merges","archive_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/deployments","created_at":"2015-07-16T08:33:09Z","updated_at":"2018-11-01T15:17:51Z","pushed_at":"2018-11-01T15:17:49Z","git_url":"git://github.com/cloudfoundry/bosh-azure-cpi-release.git","ssh_url":"git@github.com:cloudfoundry/bosh-azure-cpi-release.git","clone_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release.git","svn_url":"https://github.com/cloudfoundry/bosh-azure-cpi-release","homepage":"","size":97999,"stargazers_count":53,"watchers_count":53,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":55,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552"},"html":{"href":"https://github.com/cloudfoundry/bosh-azure-cpi-release/pull/552"},"issue":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/552"},"comments":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry/bosh-azure-cpi-release/statuses/a44c120b5c438fe74d6ac0494f0e386a50e6e13f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bingosummer"}}