{"action":"opened","number":158,"pull_request":{"url":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158","id":185400328,"html_url":"https://github.com/CityOfZion/neo-scan/pull/158","diff_url":"https://github.com/CityOfZion/neo-scan/pull/158.diff","patch_url":"https://github.com/CityOfZion/neo-scan/pull/158.patch","issue_url":"https://api.github.com/repos/CityOfZion/neo-scan/issues/158","number":158,"state":"open","locked":false,"title":"Improve unit test 3","user":{"login":"adrienmo","id":3918750,"avatar_url":"https://avatars3.githubusercontent.com/u/3918750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienmo","html_url":"https://github.com/adrienmo","followers_url":"https://api.github.com/users/adrienmo/followers","following_url":"https://api.github.com/users/adrienmo/following{/other_user}","gists_url":"https://api.github.com/users/adrienmo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienmo/subscriptions","organizations_url":"https://api.github.com/users/adrienmo/orgs","repos_url":"https://api.github.com/users/adrienmo/repos","events_url":"https://api.github.com/users/adrienmo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienmo/received_events","type":"User","site_admin":false},"body":"### tests\r\n- added 37 tests for neoscan\r\n- add tests for chain_assets, blocks, balance_histories, helpers\r\n- coverage from 31.4% to 43.5%\r\n\r\n### refactoring\r\n- delete useless/buggy? `Blocks.change_block/1`\r\n- fix return value of `Blocks.delete_blocks/1`\r\n- simplify `Assets.get_token_by_contract/1` (Enum.each always return :ok)\r\n- simplify `Assets.get_asset_name_by_hash/1` (cond do should not be used if only true or false)\r\n- simplify `Assets.get_asset_precision_by_hash/1` (cond do should not be used if only true or false)\r\n- simplify `Assets.filter_name/1`\r\n- simplify `Helpers.contract?/1`\r\n","created_at":"2018-05-02T10:44:50Z","updated_at":"2018-05-02T10:44:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158/commits","review_comments_url":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158/comments","review_comment_url":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CityOfZion/neo-scan/issues/158/comments","statuses_url":"https://api.github.com/repos/CityOfZion/neo-scan/statuses/56303594ee78fc78f0297f4bb14c5f2c921033d6","head":{"label":"adrienmo:improve_unit_test_3","ref":"improve_unit_test_3","sha":"56303594ee78fc78f0297f4bb14c5f2c921033d6","user":{"login":"adrienmo","id":3918750,"avatar_url":"https://avatars3.githubusercontent.com/u/3918750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienmo","html_url":"https://github.com/adrienmo","followers_url":"https://api.github.com/users/adrienmo/followers","following_url":"https://api.github.com/users/adrienmo/following{/other_user}","gists_url":"https://api.github.com/users/adrienmo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienmo/subscriptions","organizations_url":"https://api.github.com/users/adrienmo/orgs","repos_url":"https://api.github.com/users/adrienmo/repos","events_url":"https://api.github.com/users/adrienmo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienmo/received_events","type":"User","site_admin":false},"repo":{"id":130958385,"name":"neo-scan","full_name":"adrienmo/neo-scan","owner":{"login":"adrienmo","id":3918750,"avatar_url":"https://avatars3.githubusercontent.com/u/3918750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienmo","html_url":"https://github.com/adrienmo","followers_url":"https://api.github.com/users/adrienmo/followers","following_url":"https://api.github.com/users/adrienmo/following{/other_user}","gists_url":"https://api.github.com/users/adrienmo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienmo/subscriptions","organizations_url":"https://api.github.com/users/adrienmo/orgs","repos_url":"https://api.github.com/users/adrienmo/repos","events_url":"https://api.github.com/users/adrienmo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienmo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrienmo/neo-scan","description":"Blockchain explorer for NEO","fork":true,"url":"https://api.github.com/repos/adrienmo/neo-scan","forks_url":"https://api.github.com/repos/adrienmo/neo-scan/forks","keys_url":"https://api.github.com/repos/adrienmo/neo-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrienmo/neo-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrienmo/neo-scan/teams","hooks_url":"https://api.github.com/repos/adrienmo/neo-scan/hooks","issue_events_url":"https://api.github.com/repos/adrienmo/neo-scan/issues/events{/number}","events_url":"https://api.github.com/repos/adrienmo/neo-scan/events","assignees_url":"https://api.github.com/repos/adrienmo/neo-scan/assignees{/user}","branches_url":"https://api.github.com/repos/adrienmo/neo-scan/branches{/branch}","tags_url":"https://api.github.com/repos/adrienmo/neo-scan/tags","blobs_url":"https://api.github.com/repos/adrienmo/neo-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrienmo/neo-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrienmo/neo-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrienmo/neo-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrienmo/neo-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/adrienmo/neo-scan/languages","stargazers_url":"https://api.github.com/repos/adrienmo/neo-scan/stargazers","contributors_url":"https://api.github.com/repos/adrienmo/neo-scan/contributors","subscribers_url":"https://api.github.com/repos/adrienmo/neo-scan/subscribers","subscription_url":"https://api.github.com/repos/adrienmo/neo-scan/subscription","commits_url":"https://api.github.com/repos/adrienmo/neo-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrienmo/neo-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrienmo/neo-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrienmo/neo-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrienmo/neo-scan/contents/{+path}","compare_url":"https://api.github.com/repos/adrienmo/neo-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrienmo/neo-scan/merges","archive_url":"https://api.github.com/repos/adrienmo/neo-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrienmo/neo-scan/downloads","issues_url":"https://api.github.com/repos/adrienmo/neo-scan/issues{/number}","pulls_url":"https://api.github.com/repos/adrienmo/neo-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/adrienmo/neo-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/adrienmo/neo-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrienmo/neo-scan/labels{/name}","releases_url":"https://api.github.com/repos/adrienmo/neo-scan/releases{/id}","deployments_url":"https://api.github.com/repos/adrienmo/neo-scan/deployments","created_at":"2018-04-25T06:05:49Z","updated_at":"2018-05-02T04:14:42Z","pushed_at":"2018-05-02T10:37:12Z","git_url":"git://github.com/adrienmo/neo-scan.git","ssh_url":"git@github.com:adrienmo/neo-scan.git","clone_url":"https://github.com/adrienmo/neo-scan.git","svn_url":"https://github.com/adrienmo/neo-scan","homepage":"https://neoscan.io","size":4185,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CityOfZion:master","ref":"master","sha":"d22385cd453829d71afe76aa334f5515214872f9","user":{"login":"CityOfZion","id":29782569,"avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"repo":{"id":96624771,"name":"neo-scan","full_name":"CityOfZion/neo-scan","owner":{"login":"CityOfZion","id":29782569,"avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CityOfZion/neo-scan","description":"Blockchain explorer for NEO","fork":false,"url":"https://api.github.com/repos/CityOfZion/neo-scan","forks_url":"https://api.github.com/repos/CityOfZion/neo-scan/forks","keys_url":"https://api.github.com/repos/CityOfZion/neo-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CityOfZion/neo-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CityOfZion/neo-scan/teams","hooks_url":"https://api.github.com/repos/CityOfZion/neo-scan/hooks","issue_events_url":"https://api.github.com/repos/CityOfZion/neo-scan/issues/events{/number}","events_url":"https://api.github.com/repos/CityOfZion/neo-scan/events","assignees_url":"https://api.github.com/repos/CityOfZion/neo-scan/assignees{/user}","branches_url":"https://api.github.com/repos/CityOfZion/neo-scan/branches{/branch}","tags_url":"https://api.github.com/repos/CityOfZion/neo-scan/tags","blobs_url":"https://api.github.com/repos/CityOfZion/neo-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CityOfZion/neo-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CityOfZion/neo-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/CityOfZion/neo-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CityOfZion/neo-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/CityOfZion/neo-scan/languages","stargazers_url":"https://api.github.com/repos/CityOfZion/neo-scan/stargazers","contributors_url":"https://api.github.com/repos/CityOfZion/neo-scan/contributors","subscribers_url":"https://api.github.com/repos/CityOfZion/neo-scan/subscribers","subscription_url":"https://api.github.com/repos/CityOfZion/neo-scan/subscription","commits_url":"https://api.github.com/repos/CityOfZion/neo-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/CityOfZion/neo-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/CityOfZion/neo-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/CityOfZion/neo-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/CityOfZion/neo-scan/contents/{+path}","compare_url":"https://api.github.com/repos/CityOfZion/neo-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CityOfZion/neo-scan/merges","archive_url":"https://api.github.com/repos/CityOfZion/neo-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CityOfZion/neo-scan/downloads","issues_url":"https://api.github.com/repos/CityOfZion/neo-scan/issues{/number}","pulls_url":"https://api.github.com/repos/CityOfZion/neo-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/CityOfZion/neo-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/CityOfZion/neo-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CityOfZion/neo-scan/labels{/name}","releases_url":"https://api.github.com/repos/CityOfZion/neo-scan/releases{/id}","deployments_url":"https://api.github.com/repos/CityOfZion/neo-scan/deployments","created_at":"2017-07-08T14:44:39Z","updated_at":"2018-04-30T10:03:59Z","pushed_at":"2018-05-02T06:38:41Z","git_url":"git://github.com/CityOfZion/neo-scan.git","ssh_url":"git@github.com:CityOfZion/neo-scan.git","clone_url":"https://github.com/CityOfZion/neo-scan.git","svn_url":"https://github.com/CityOfZion/neo-scan","homepage":"https://neoscan.io","size":4176,"stargazers_count":40,"watchers_count":40,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":39,"open_issues":17,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158"},"html":{"href":"https://github.com/CityOfZion/neo-scan/pull/158"},"issue":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/issues/158"},"comments":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/CityOfZion/neo-scan/statuses/56303594ee78fc78f0297f4bb14c5f2c921033d6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":463,"deletions":95,"changed_files":9}}
{"actor":{"display_login":"adrienmo"}}