{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/22698","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/22698/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/22698/comments","events_url":"https://api.github.com/repos/apache/spark/issues/22698/events","html_url":"https://github.com/apache/spark/pull/22698","id":369162784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTcxMDUx","number":22698,"title":"[SPARK-25710][SQL] range should report metrics correctly","user":{"login":"cloud-fan","id":3182036,"node_id":"MDQ6VXNlcjMxODIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3182036?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-11T14:57:43Z","updated_at":"2018-10-11T18:40:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22698","html_url":"https://github.com/apache/spark/pull/22698","diff_url":"https://github.com/apache/spark/pull/22698.diff","patch_url":"https://github.com/apache/spark/pull/22698.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently `Range` reports metrics in batch granularity. This is acceptable, but it's better if we can make it row granularity without performance penalty.\r\n\r\nBefore this PR,  the metrics are updated when preparing the batch, which is before we actually consume data. In this PR, the metrics are updated after the data are consumed. There are 2 different cases:\r\n1. The data processing loop has a stop check. The metrics are updated when we need to stop.\r\n2. no stop check. The metrics are updated after the loop.\r\n\r\n## How was this patch tested?\r\n\r\nexisting tests and a new benchmark"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/429073050","html_url":"https://github.com/apache/spark/pull/22698#issuecomment-429073050","issue_url":"https://api.github.com/repos/apache/spark/issues/22698","id":429073050,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTA3MzA1MA==","user":{"login":"SparkQA","id":8108735,"node_id":"MDQ6VXNlcjgxMDg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T18:40:15Z","updated_at":"2018-10-11T18:40:15Z","author_association":"NONE","body":"**[Test build #97264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97264/testReport)** for PR 22698 at commit [`1071c14`](https://github.com/apache/spark/commit/1071c14a1fac551a3dc8025f7b7da1a89892d05a).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}