{"action":"created","comment":{"url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/comments/233046401","pull_request_review_id":174373251,"id":233046401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzA0NjQwMQ==","diff_hunk":"@@ -0,0 +1,146 @@\n+package uk.ac.ebi.eva.accession.release.configuration;\n+\n+import com.lordofthejars.nosqlunit.annotation.UsingDataSet;\n+import com.lordofthejars.nosqlunit.core.LoadStrategyEnum;\n+import com.lordofthejars.nosqlunit.mongodb.MongoDbConfigurationBuilder;\n+import com.lordofthejars.nosqlunit.mongodb.MongoDbRule;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.springframework.batch.core.BatchStatus;\n+import org.springframework.batch.core.JobExecution;\n+import org.springframework.batch.test.JobLauncherTestUtils;\n+import org.springframework.beans.factory.annotation.Autowired;\n+import org.springframework.context.ApplicationContext;\n+import org.springframework.data.mongodb.core.MongoTemplate;\n+import org.springframework.test.context.ContextConfiguration;\n+import org.springframework.test.context.TestPropertySource;\n+import org.springframework.test.context.junit4.SpringRunner;\n+\n+import uk.ac.ebi.eva.accession.release.parameters.InputParameters;\n+import uk.ac.ebi.eva.accession.release.test.configuration.BatchTestConfiguration;\n+import uk.ac.ebi.eva.accession.release.test.configuration.MongoTestConfiguration;\n+import uk.ac.ebi.eva.accession.release.test.rule.FixSpringMongoDbRule;\n+import uk.ac.ebi.eva.commons.core.utils.FileUtils;\n+\n+import java.io.BufferedReader;\n+import java.io.File;\n+import java.io.FileInputStream;\n+import java.io.IOException;\n+import java.io.InputStreamReader;\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+import static org.junit.Assert.assertEquals;\n+import static uk.ac.ebi.eva.accession.release.configuration.BeanNames.CREATE_RELEASE_STEP;\n+\n+@RunWith(SpringRunner.class)\n+@ContextConfiguration(classes = {BatchTestConfiguration.class, MongoTestConfiguration.class})\n+@UsingDataSet(locations = {\n+        \"/test-data/dbsnpClusteredVariantEntity.json\",\n+        \"/test-data/dbsnpSubmittedVariantEntity.json\"})\n+@TestPropertySource(\"classpath:application.properties\")\n+public class CreateReleaseStepConfigurationTest {\n+\n+    private static final String TEST_DB = \"test-db\";\n+\n+    private static final long EXPECTED_LINES = 3;\n+\n+    @Autowired\n+    private JobLauncherTestUtils jobLauncherTestUtils;\n+\n+    @Autowired\n+    private InputParameters inputParameters;\n+\n+    //Required by nosql-unit\n+    @Autowired\n+    private ApplicationContext applicationContext;\n+\n+    @Rule\n+    public MongoDbRule mongoDbRule = new FixSpringMongoDbRule(\n+            MongoDbConfigurationBuilder.mongoDb().databaseName(TEST_DB).build());\n+\n+    @Test\n+    public void contextLoads() {\n+\n+    }\n+\n+    @Test\n+    public void basicJobCompletion() throws Exception {\n+        JobExecution jobExecution = jobLauncherTestUtils.launchStep(CREATE_RELEASE_STEP);\n+        assertEquals(BatchStatus.COMPLETED, jobExecution.getStatus());\n+    }\n+\n+    @Test\n+    public void variantsWritten() throws Exception {\n+        JobExecution jobExecution = jobLauncherTestUtils.launchStep(CREATE_RELEASE_STEP);\n+        assertEquals(BatchStatus.COMPLETED, jobExecution.getStatus());","path":"eva-accession-release/src/test/java/uk/ac/ebi/eva/accession/release/configuration/CreateReleaseStepConfigurationTest.java","position":77,"original_position":77,"commit_id":"05e9acd41565a0bdad6b1d961e63896e7b3899a8","original_commit_id":"05e9acd41565a0bdad6b1d961e63896e7b3899a8","user":{"login":"sundarvenkata-EBI","id":25152678,"node_id":"MDQ6VXNlcjI1MTUyNjc4","avatar_url":"https://avatars2.githubusercontent.com/u/25152678?v=4","gravatar_id":"","url":"https://api.github.com/users/sundarvenkata-EBI","html_url":"https://github.com/sundarvenkata-EBI","followers_url":"https://api.github.com/users/sundarvenkata-EBI/followers","following_url":"https://api.github.com/users/sundarvenkata-EBI/following{/other_user}","gists_url":"https://api.github.com/users/sundarvenkata-EBI/gists{/gist_id}","starred_url":"https://api.github.com/users/sundarvenkata-EBI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundarvenkata-EBI/subscriptions","organizations_url":"https://api.github.com/users/sundarvenkata-EBI/orgs","repos_url":"https://api.github.com/users/sundarvenkata-EBI/repos","events_url":"https://api.github.com/users/sundarvenkata-EBI/events{/privacy}","received_events_url":"https://api.github.com/users/sundarvenkata-EBI/received_events","type":"User","site_admin":false},"body":"Extract these two statements to share with basicJobCompletion()?","created_at":"2018-11-13T13:56:40Z","updated_at":"2018-11-13T13:56:40Z","html_url":"https://github.com/EBIvariation/eva-accession/pull/85#discussion_r233046401","pull_request_url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/comments/233046401"},"html":{"href":"https://github.com/EBIvariation/eva-accession/pull/85#discussion_r233046401"},"pull_request":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85","id":230430316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDMwMzE2","html_url":"https://github.com/EBIvariation/eva-accession/pull/85","diff_url":"https://github.com/EBIvariation/eva-accession/pull/85.diff","patch_url":"https://github.com/EBIvariation/eva-accession/pull/85.patch","issue_url":"https://api.github.com/repos/EBIvariation/eva-accession/issues/85","number":85,"state":"open","locked":false,"title":"EVA-1385 Step and job setup","user":{"login":"jmmut","id":4750555,"node_id":"MDQ6VXNlcjQ3NTA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4750555?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-13T10:55:06Z","updated_at":"2018-11-13T13:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0cb16f8517ff3e47e558d3a7f9d7b8f992a6bcc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85/commits","review_comments_url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85/comments","review_comment_url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EBIvariation/eva-accession/issues/85/comments","statuses_url":"https://api.github.com/repos/EBIvariation/eva-accession/statuses/05e9acd41565a0bdad6b1d961e63896e7b3899a8","head":{"label":"jmmut:feature/release-job","ref":"feature/release-job","sha":"05e9acd41565a0bdad6b1d961e63896e7b3899a8","user":{"login":"jmmut","id":4750555,"node_id":"MDQ6VXNlcjQ3NTA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4750555?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"repo":{"id":126814091,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4MTQwOTE=","name":"eva-accession","full_name":"jmmut/eva-accession","private":false,"owner":{"login":"jmmut","id":4750555,"node_id":"MDQ6VXNlcjQ3NTA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4750555?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmmut/eva-accession","description":"EVA non-human variant accessioning service","fork":true,"url":"https://api.github.com/repos/jmmut/eva-accession","forks_url":"https://api.github.com/repos/jmmut/eva-accession/forks","keys_url":"https://api.github.com/repos/jmmut/eva-accession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmut/eva-accession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmut/eva-accession/teams","hooks_url":"https://api.github.com/repos/jmmut/eva-accession/hooks","issue_events_url":"https://api.github.com/repos/jmmut/eva-accession/issues/events{/number}","events_url":"https://api.github.com/repos/jmmut/eva-accession/events","assignees_url":"https://api.github.com/repos/jmmut/eva-accession/assignees{/user}","branches_url":"https://api.github.com/repos/jmmut/eva-accession/branches{/branch}","tags_url":"https://api.github.com/repos/jmmut/eva-accession/tags","blobs_url":"https://api.github.com/repos/jmmut/eva-accession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmut/eva-accession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmut/eva-accession/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmut/eva-accession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmut/eva-accession/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmut/eva-accession/languages","stargazers_url":"https://api.github.com/repos/jmmut/eva-accession/stargazers","contributors_url":"https://api.github.com/repos/jmmut/eva-accession/contributors","subscribers_url":"https://api.github.com/repos/jmmut/eva-accession/subscribers","subscription_url":"https://api.github.com/repos/jmmut/eva-accession/subscription","commits_url":"https://api.github.com/repos/jmmut/eva-accession/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmut/eva-accession/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmut/eva-accession/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmut/eva-accession/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmut/eva-accession/contents/{+path}","compare_url":"https://api.github.com/repos/jmmut/eva-accession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmut/eva-accession/merges","archive_url":"https://api.github.com/repos/jmmut/eva-accession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmut/eva-accession/downloads","issues_url":"https://api.github.com/repos/jmmut/eva-accession/issues{/number}","pulls_url":"https://api.github.com/repos/jmmut/eva-accession/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmut/eva-accession/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmut/eva-accession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmut/eva-accession/labels{/name}","releases_url":"https://api.github.com/repos/jmmut/eva-accession/releases{/id}","deployments_url":"https://api.github.com/repos/jmmut/eva-accession/deployments","created_at":"2018-03-26T10:44:40Z","updated_at":"2018-07-02T15:55:36Z","pushed_at":"2018-11-13T10:53:39Z","git_url":"git://github.com/jmmut/eva-accession.git","ssh_url":"git@github.com:jmmut/eva-accession.git","clone_url":"https://github.com/jmmut/eva-accession.git","svn_url":"https://github.com/jmmut/eva-accession","homepage":null,"size":3529,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EBIvariation:master","ref":"master","sha":"4887229c5710919d6a56d8d6a175072d64f69273","user":{"login":"EBIvariation","id":6419333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTkzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6419333?v=4","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"repo":{"id":123308623,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMDg2MjM=","name":"eva-accession","full_name":"EBIvariation/eva-accession","private":false,"owner":{"login":"EBIvariation","id":6419333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTkzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6419333?v=4","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EBIvariation/eva-accession","description":"EVA non-human variant accessioning service","fork":false,"url":"https://api.github.com/repos/EBIvariation/eva-accession","forks_url":"https://api.github.com/repos/EBIvariation/eva-accession/forks","keys_url":"https://api.github.com/repos/EBIvariation/eva-accession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EBIvariation/eva-accession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EBIvariation/eva-accession/teams","hooks_url":"https://api.github.com/repos/EBIvariation/eva-accession/hooks","issue_events_url":"https://api.github.com/repos/EBIvariation/eva-accession/issues/events{/number}","events_url":"https://api.github.com/repos/EBIvariation/eva-accession/events","assignees_url":"https://api.github.com/repos/EBIvariation/eva-accession/assignees{/user}","branches_url":"https://api.github.com/repos/EBIvariation/eva-accession/branches{/branch}","tags_url":"https://api.github.com/repos/EBIvariation/eva-accession/tags","blobs_url":"https://api.github.com/repos/EBIvariation/eva-accession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EBIvariation/eva-accession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EBIvariation/eva-accession/git/refs{/sha}","trees_url":"https://api.github.com/repos/EBIvariation/eva-accession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EBIvariation/eva-accession/statuses/{sha}","languages_url":"https://api.github.com/repos/EBIvariation/eva-accession/languages","stargazers_url":"https://api.github.com/repos/EBIvariation/eva-accession/stargazers","contributors_url":"https://api.github.com/repos/EBIvariation/eva-accession/contributors","subscribers_url":"https://api.github.com/repos/EBIvariation/eva-accession/subscribers","subscription_url":"https://api.github.com/repos/EBIvariation/eva-accession/subscription","commits_url":"https://api.github.com/repos/EBIvariation/eva-accession/commits{/sha}","git_commits_url":"https://api.github.com/repos/EBIvariation/eva-accession/git/commits{/sha}","comments_url":"https://api.github.com/repos/EBIvariation/eva-accession/comments{/number}","issue_comment_url":"https://api.github.com/repos/EBIvariation/eva-accession/issues/comments{/number}","contents_url":"https://api.github.com/repos/EBIvariation/eva-accession/contents/{+path}","compare_url":"https://api.github.com/repos/EBIvariation/eva-accession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EBIvariation/eva-accession/merges","archive_url":"https://api.github.com/repos/EBIvariation/eva-accession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EBIvariation/eva-accession/downloads","issues_url":"https://api.github.com/repos/EBIvariation/eva-accession/issues{/number}","pulls_url":"https://api.github.com/repos/EBIvariation/eva-accession/pulls{/number}","milestones_url":"https://api.github.com/repos/EBIvariation/eva-accession/milestones{/number}","notifications_url":"https://api.github.com/repos/EBIvariation/eva-accession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EBIvariation/eva-accession/labels{/name}","releases_url":"https://api.github.com/repos/EBIvariation/eva-accession/releases{/id}","deployments_url":"https://api.github.com/repos/EBIvariation/eva-accession/deployments","created_at":"2018-02-28T16:05:21Z","updated_at":"2018-11-13T10:14:50Z","pushed_at":"2018-11-13T10:55:06Z","git_url":"git://github.com/EBIvariation/eva-accession.git","ssh_url":"git@github.com:EBIvariation/eva-accession.git","clone_url":"https://github.com/EBIvariation/eva-accession.git","svn_url":"https://github.com/EBIvariation/eva-accession","homepage":null,"size":3424,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85"},"html":{"href":"https://github.com/EBIvariation/eva-accession/pull/85"},"issue":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/issues/85"},"comments":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/EBIvariation/eva-accession/statuses/05e9acd41565a0bdad6b1d961e63896e7b3899a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sundarvenkata-EBI"}}