{"action":"created","comment":{"url":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments/240055265","pull_request_review_id":182996998,"id":240055265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDA1NTI2NQ==","diff_hunk":"@@ -756,6 +764,30 @@ static void init_window(lua::state &l __attribute__((unused)), bool own) {\n       wmHint.flags = InputHint | StateHint;\n       /* allow decorated windows to be given input focus by WM */\n       wmHint.input = TEST_HINT(hints, HINT_UNDECORATED) ? False : True;\n+#ifdef BUILD_XSHAPE\n+      if (!wmHint.input) {\n+        /* allow only decorated windows to be given mouse input */\n+        int major_version, minor_version;\n+        if (XShapeQueryVersion(display, &major_version, &minor_version) == 0) {\n+          NORM_ERR(\"Input shapes are not supported\");\n+        } else {\n+          if (own_window.get(*state) &&\n+              (own_window_type.get(*state) != TYPE_NORMAL ||\n+               ((TEST_HINT(own_window_hints.get(*state), HINT_UNDECORATED)) !=\n+                0))) {\n+            /*  if (own_window_type.get(*state) == TYPE_DESKTOP) {","path":"src/x11.cc","position":54,"original_position":54,"commit_id":"ab8d16160c380bae0128e88e9ba83614e4a84b5f","original_commit_id":"ab8d16160c380bae0128e88e9ba83614e4a84b5f","user":{"login":"conky-ci","id":39227759,"node_id":"MDQ6VXNlcjM5MjI3NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/39227759?v=4","gravatar_id":"","url":"https://api.github.com/users/conky-ci","html_url":"https://github.com/conky-ci","followers_url":"https://api.github.com/users/conky-ci/followers","following_url":"https://api.github.com/users/conky-ci/following{/other_user}","gists_url":"https://api.github.com/users/conky-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/conky-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conky-ci/subscriptions","organizations_url":"https://api.github.com/users/conky-ci/orgs","repos_url":"https://api.github.com/users/conky-ci/repos","events_url":"https://api.github.com/users/conky-ci/events{/privacy}","received_events_url":"https://api.github.com/users/conky-ci/received_events","type":"User","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Remove the commented out code. ([cpp:CommentedCode](https://sonarcloud.io/organizations/brndnmtthws-github/rules#rule_key=cpp%3ACommentedCode))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=conky&pullRequest=698&issues=AWeU-1e18YaV-M4wU2tr&open=AWeU-1e18YaV-M4wU2tr)\n\n[ISSUE_KEY]: AWeU-1e18YaV-M4wU2tr","created_at":"2018-12-09T21:59:21Z","updated_at":"2018-12-09T21:59:21Z","html_url":"https://github.com/brndnmtthws/conky/pull/698#discussion_r240055265","pull_request_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/698","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments/240055265"},"html":{"href":"https://github.com/brndnmtthws/conky/pull/698#discussion_r240055265"},"pull_request":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/brndnmtthws/conky/pulls/698","id":237159813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTU5ODEz","html_url":"https://github.com/brndnmtthws/conky/pull/698","diff_url":"https://github.com/brndnmtthws/conky/pull/698.diff","patch_url":"https://github.com/brndnmtthws/conky/pull/698.patch","issue_url":"https://api.github.com/repos/brndnmtthws/conky/issues/698","number":698,"state":"open","locked":false,"title":"Fix nvidia crash (resolves #520).","user":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"body":"* Fix XShape handling.\r\n* Fix crash when XDamage is disabled.\r\n* Make sure the nvidia COOLER target is available before trying to pull\r\n     attribute values.","created_at":"2018-12-09T21:51:35Z","updated_at":"2018-12-09T21:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"553361e62aba2260eb987ea4b84dd9ed223c668c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/698/commits","review_comments_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/698/comments","review_comment_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/issues/698/comments","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/ab8d16160c380bae0128e88e9ba83614e4a84b5f","head":{"label":"brndnmtthws:fix-nvidia-crash","ref":"fix-nvidia-crash","sha":"ab8d16160c380bae0128e88e9ba83614e4a84b5f","user":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"repo":{"id":7331227,"node_id":"MDEwOlJlcG9zaXRvcnk3MzMxMjI3","name":"conky","full_name":"brndnmtthws/conky","private":false,"owner":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brndnmtthws/conky","description":"Light-weight system monitor for X.","fork":false,"url":"https://api.github.com/repos/brndnmtthws/conky","forks_url":"https://api.github.com/repos/brndnmtthws/conky/forks","keys_url":"https://api.github.com/repos/brndnmtthws/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndnmtthws/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndnmtthws/conky/teams","hooks_url":"https://api.github.com/repos/brndnmtthws/conky/hooks","issue_events_url":"https://api.github.com/repos/brndnmtthws/conky/issues/events{/number}","events_url":"https://api.github.com/repos/brndnmtthws/conky/events","assignees_url":"https://api.github.com/repos/brndnmtthws/conky/assignees{/user}","branches_url":"https://api.github.com/repos/brndnmtthws/conky/branches{/branch}","tags_url":"https://api.github.com/repos/brndnmtthws/conky/tags","blobs_url":"https://api.github.com/repos/brndnmtthws/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndnmtthws/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndnmtthws/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndnmtthws/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/brndnmtthws/conky/languages","stargazers_url":"https://api.github.com/repos/brndnmtthws/conky/stargazers","contributors_url":"https://api.github.com/repos/brndnmtthws/conky/contributors","subscribers_url":"https://api.github.com/repos/brndnmtthws/conky/subscribers","subscription_url":"https://api.github.com/repos/brndnmtthws/conky/subscription","commits_url":"https://api.github.com/repos/brndnmtthws/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndnmtthws/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndnmtthws/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndnmtthws/conky/contents/{+path}","compare_url":"https://api.github.com/repos/brndnmtthws/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndnmtthws/conky/merges","archive_url":"https://api.github.com/repos/brndnmtthws/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndnmtthws/conky/downloads","issues_url":"https://api.github.com/repos/brndnmtthws/conky/issues{/number}","pulls_url":"https://api.github.com/repos/brndnmtthws/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/brndnmtthws/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/brndnmtthws/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndnmtthws/conky/labels{/name}","releases_url":"https://api.github.com/repos/brndnmtthws/conky/releases{/id}","deployments_url":"https://api.github.com/repos/brndnmtthws/conky/deployments","created_at":"2012-12-26T19:50:17Z","updated_at":"2018-12-09T16:24:05Z","pushed_at":"2018-12-09T21:55:34Z","git_url":"git://github.com/brndnmtthws/conky.git","ssh_url":"git@github.com:brndnmtthws/conky.git","clone_url":"https://github.com/brndnmtthws/conky.git","svn_url":"https://github.com/brndnmtthws/conky","homepage":null,"size":16065,"stargazers_count":2594,"watchers_count":2594,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":333,"open_issues":80,"watchers":2594,"default_branch":"master"}},"base":{"label":"brndnmtthws:master","ref":"master","sha":"3600570667578406395748f6447cb0b443c00d3d","user":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"repo":{"id":7331227,"node_id":"MDEwOlJlcG9zaXRvcnk3MzMxMjI3","name":"conky","full_name":"brndnmtthws/conky","private":false,"owner":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brndnmtthws/conky","description":"Light-weight system monitor for X.","fork":false,"url":"https://api.github.com/repos/brndnmtthws/conky","forks_url":"https://api.github.com/repos/brndnmtthws/conky/forks","keys_url":"https://api.github.com/repos/brndnmtthws/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndnmtthws/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndnmtthws/conky/teams","hooks_url":"https://api.github.com/repos/brndnmtthws/conky/hooks","issue_events_url":"https://api.github.com/repos/brndnmtthws/conky/issues/events{/number}","events_url":"https://api.github.com/repos/brndnmtthws/conky/events","assignees_url":"https://api.github.com/repos/brndnmtthws/conky/assignees{/user}","branches_url":"https://api.github.com/repos/brndnmtthws/conky/branches{/branch}","tags_url":"https://api.github.com/repos/brndnmtthws/conky/tags","blobs_url":"https://api.github.com/repos/brndnmtthws/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndnmtthws/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndnmtthws/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndnmtthws/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/brndnmtthws/conky/languages","stargazers_url":"https://api.github.com/repos/brndnmtthws/conky/stargazers","contributors_url":"https://api.github.com/repos/brndnmtthws/conky/contributors","subscribers_url":"https://api.github.com/repos/brndnmtthws/conky/subscribers","subscription_url":"https://api.github.com/repos/brndnmtthws/conky/subscription","commits_url":"https://api.github.com/repos/brndnmtthws/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndnmtthws/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndnmtthws/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndnmtthws/conky/contents/{+path}","compare_url":"https://api.github.com/repos/brndnmtthws/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndnmtthws/conky/merges","archive_url":"https://api.github.com/repos/brndnmtthws/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndnmtthws/conky/downloads","issues_url":"https://api.github.com/repos/brndnmtthws/conky/issues{/number}","pulls_url":"https://api.github.com/repos/brndnmtthws/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/brndnmtthws/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/brndnmtthws/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndnmtthws/conky/labels{/name}","releases_url":"https://api.github.com/repos/brndnmtthws/conky/releases{/id}","deployments_url":"https://api.github.com/repos/brndnmtthws/conky/deployments","created_at":"2012-12-26T19:50:17Z","updated_at":"2018-12-09T16:24:05Z","pushed_at":"2018-12-09T21:55:34Z","git_url":"git://github.com/brndnmtthws/conky.git","ssh_url":"git@github.com:brndnmtthws/conky.git","clone_url":"https://github.com/brndnmtthws/conky.git","svn_url":"https://github.com/brndnmtthws/conky","homepage":null,"size":16065,"stargazers_count":2594,"watchers_count":2594,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":333,"open_issues":80,"watchers":2594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/698"},"html":{"href":"https://github.com/brndnmtthws/conky/pull/698"},"issue":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/698"},"comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/brndnmtthws/conky/statuses/ab8d16160c380bae0128e88e9ba83614e4a84b5f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"conky-ci"}}