{"action":"created","issue":{"url":"https://api.github.com/repos/private-octopus/picoquic/issues/463","repository_url":"https://api.github.com/repos/private-octopus/picoquic","labels_url":"https://api.github.com/repos/private-octopus/picoquic/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/private-octopus/picoquic/issues/463/comments","events_url":"https://api.github.com/repos/private-octopus/picoquic/issues/463/events","html_url":"https://github.com/private-octopus/picoquic/issues/463","id":394720431,"node_id":"MDU6SXNzdWUzOTQ3MjA0MzE=","number":463,"title":"Call `picoquic_prepare_packet` in a loop","user":{"login":"bkchr","id":5718007,"node_id":"MDQ6VXNlcjU3MTgwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5718007?v=4","gravatar_id":"","url":"https://api.github.com/users/bkchr","html_url":"https://github.com/bkchr","followers_url":"https://api.github.com/users/bkchr/followers","following_url":"https://api.github.com/users/bkchr/following{/other_user}","gists_url":"https://api.github.com/users/bkchr/gists{/gist_id}","starred_url":"https://api.github.com/users/bkchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkchr/subscriptions","organizations_url":"https://api.github.com/users/bkchr/orgs","repos_url":"https://api.github.com/users/bkchr/repos","events_url":"https://api.github.com/users/bkchr/events{/privacy}","received_events_url":"https://api.github.com/users/bkchr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-12-28T21:12:08Z","updated_at":"2018-12-29T21:06:52Z","closed_at":null,"author_association":"COLLABORATOR","body":"I think we need to update the demo [here](https://github.com/private-octopus/picoquic/blob/f9798134f3e98ee4ad39d120e9f451b7edd9856b/picoquicfirst/picoquicdemo.c#L532).\r\nWe should call `picoquic_prepare_packet` in a loop until all packets for a connection are send. I think that this is one of the main issues, I have seen for connections with multiple streams. The main stream was generating a lot of data and the other streams did not get any real change to send something.\r\nI built the rust bindings, based on your demo. So, I imported this problem upstream^^\r\n"},"comment":{"url":"https://api.github.com/repos/private-octopus/picoquic/issues/comments/450520134","html_url":"https://github.com/private-octopus/picoquic/issues/463#issuecomment-450520134","issue_url":"https://api.github.com/repos/private-octopus/picoquic/issues/463","id":450520134,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUyMDEzNA==","user":{"login":"bkchr","id":5718007,"node_id":"MDQ6VXNlcjU3MTgwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5718007?v=4","gravatar_id":"","url":"https://api.github.com/users/bkchr","html_url":"https://github.com/bkchr","followers_url":"https://api.github.com/users/bkchr/followers","following_url":"https://api.github.com/users/bkchr/following{/other_user}","gists_url":"https://api.github.com/users/bkchr/gists{/gist_id}","starred_url":"https://api.github.com/users/bkchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkchr/subscriptions","organizations_url":"https://api.github.com/users/bkchr/orgs","repos_url":"https://api.github.com/users/bkchr/repos","events_url":"https://api.github.com/users/bkchr/events{/privacy}","received_events_url":"https://api.github.com/users/bkchr/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T21:06:52Z","updated_at":"2018-12-29T21:06:52Z","author_association":"COLLABORATOR","body":"I would just have added a second list `active_streams` or `streams_want_to_send`. That just contains the streams that want to send data in the order they need to be fetched. If a stream wants to send data and is not on the list, it is added to the end of the list. If a stream is able to send data (first of the list) and there is still data to send, it is added to the end again.\nSo you can just keep the normal list. Like we have for the connections. "}}
{"actor":{"display_login":"bkchr"}}