{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/comments/189841668","pull_request_review_id":122090567,"id":189841668,"diff_hunk":"@@ -294,23 +295,20 @@ public static void clearThumbnailsCache(Context applicationContext) {\n     }\n \n     /**\n-     * Convert matrix url into http one.\n+     * Resolve a Matrix media content URI (in the form of \"mxc://...\") into an HTTP URL.\n      *\n-     * @param url    the matrix url\n+     * @param url    the matrix url, must not be null.","path":"matrix-sdk/src/main/java/org/matrix/androidsdk/db/MXMediasCache.java","position":16,"original_position":16,"commit_id":"8dcac66e697d2d7aaba26b9aab673642b840e993","original_commit_id":"8dcac66e697d2d7aaba26b9aab673642b840e993","user":{"login":"bmarty","id":3940906,"avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false},"body":"`url` parameter should be renamed to `mxcUrl` or `matrixUrl` for clarity (but it can be applied to all other methods...)","created_at":"2018-05-22T09:53:04Z","updated_at":"2018-05-22T10:00:28Z","html_url":"https://github.com/matrix-org/matrix-android-sdk/pull/268#discussion_r189841668","pull_request_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/comments/189841668"},"html":{"href":"https://github.com/matrix-org/matrix-android-sdk/pull/268#discussion_r189841668"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268","id":188522780,"html_url":"https://github.com/matrix-org/matrix-android-sdk/pull/268","diff_url":"https://github.com/matrix-org/matrix-android-sdk/pull/268.diff","patch_url":"https://github.com/matrix-org/matrix-android-sdk/pull/268.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/268","number":268,"state":"open","locked":false,"title":"Bug Fix: do not allow non-mxc content URLs.","user":{"login":"giomfo","id":8969772,"avatar_url":"https://avatars3.githubusercontent.com/u/8969772?v=4","gravatar_id":"","url":"https://api.github.com/users/giomfo","html_url":"https://github.com/giomfo","followers_url":"https://api.github.com/users/giomfo/followers","following_url":"https://api.github.com/users/giomfo/following{/other_user}","gists_url":"https://api.github.com/users/giomfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giomfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giomfo/subscriptions","organizations_url":"https://api.github.com/users/giomfo/orgs","repos_url":"https://api.github.com/users/giomfo/repos","events_url":"https://api.github.com/users/giomfo/events{/privacy}","received_events_url":"https://api.github.com/users/giomfo/received_events","type":"User","site_admin":false},"body":"we should not be making requests out to whatever http urls people send us.","created_at":"2018-05-16T18:35:27Z","updated_at":"2018-05-22T10:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e29c4877e8e8fcef78a8316451200f58612f1ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/268/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/statuses/8dcac66e697d2d7aaba26b9aab673642b840e993","head":{"label":"matrix-org:reject_non_mxc_content","ref":"reject_non_mxc_content","sha":"8dcac66e697d2d7aaba26b9aab673642b840e993","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24635052,"name":"matrix-android-sdk","full_name":"matrix-org/matrix-android-sdk","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-android-sdk","description":"The Matrix SDK for Android","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-android-sdk","forks_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/deployments","created_at":"2014-09-30T11:09:12Z","updated_at":"2018-05-21T09:56:02Z","pushed_at":"2018-05-18T14:43:13Z","git_url":"git://github.com/matrix-org/matrix-android-sdk.git","ssh_url":"git@github.com:matrix-org/matrix-android-sdk.git","clone_url":"https://github.com/matrix-org/matrix-android-sdk.git","svn_url":"https://github.com/matrix-org/matrix-android-sdk","homepage":null,"size":48120,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":63,"open_issues":16,"watchers":109,"default_branch":"develop"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"7f9dc79e4afb3d33b4f5453fcd9ac0c07d15ceb4","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24635052,"name":"matrix-android-sdk","full_name":"matrix-org/matrix-android-sdk","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-android-sdk","description":"The Matrix SDK for Android","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-android-sdk","forks_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-android-sdk/deployments","created_at":"2014-09-30T11:09:12Z","updated_at":"2018-05-21T09:56:02Z","pushed_at":"2018-05-18T14:43:13Z","git_url":"git://github.com/matrix-org/matrix-android-sdk.git","ssh_url":"git@github.com:matrix-org/matrix-android-sdk.git","clone_url":"https://github.com/matrix-org/matrix-android-sdk.git","svn_url":"https://github.com/matrix-org/matrix-android-sdk","homepage":null,"size":48120,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":63,"open_issues":16,"watchers":109,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268"},"html":{"href":"https://github.com/matrix-org/matrix-android-sdk/pull/268"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/268"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-android-sdk/statuses/8dcac66e697d2d7aaba26b9aab673642b840e993"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmarty"}}