{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22146","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22146/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22146/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22146/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22146","id":339789074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzU0NzA2","number":22146,"title":"3.3.5-Locale Template Optimizer","user":{"login":"Langerz82","id":9509069,"node_id":"MDQ6VXNlcjk1MDkwNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/9509069?v=4","gravatar_id":"","url":"https://api.github.com/users/Langerz82","html_url":"https://github.com/Langerz82","followers_url":"https://api.github.com/users/Langerz82/followers","following_url":"https://api.github.com/users/Langerz82/following{/other_user}","gists_url":"https://api.github.com/users/Langerz82/gists{/gist_id}","starred_url":"https://api.github.com/users/Langerz82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Langerz82/subscriptions","organizations_url":"https://api.github.com/users/Langerz82/orgs","repos_url":"https://api.github.com/users/Langerz82/repos","events_url":"https://api.github.com/users/Langerz82/events{/privacy}","received_events_url":"https://api.github.com/users/Langerz82/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-10T10:45:50Z","updated_at":"2018-07-10T21:19:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22146","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22146","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/22146.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/22146.patch"},"body":"<!--- (**********************************)\r\n      (** Fill in the following fields **)\r\n      (**********************************) --->\r\n\r\n**Changes proposed:**\r\nWhat if we created the users default locale QueryData, and created the others as requested during run-time? Just an idea, I think it could work with some changes to my code I made.\r\nThat way caching would work and it would have fast-loading times still, and a smaller memory footprint unless of course u have many locales playing during run-time.\r\nref:\r\nhttps://github.com/TrinityCore/TrinityCore/issues/22126  \r\n\r\n**Target branch(es):** 3.3.5/master\r\n\r\n- [x] 3.3.5\r\n\r\n**Issues addressed:** Closes #  (insert issue tracker number)\r\nhttps://github.com/TrinityCore/TrinityCore/issues/22126\r\n\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\nTested in-game with a enGB client.\r\n\r\n**Known issues and TODO list:** (add/remove lines as needed)\r\n- Needs to be tested on non-US clients and make sure Locales are still working fine for Items, Quests, Points of interest, Creature Names, and GameObjects.\r\n\r\n<!--- Notes\r\n- Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request.\r\n- If this PR only contains SQL files, open a new issue instead and post or link the SQL in the issue.\r\n- When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.\r\n--->\r\n"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/403969529","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22146#issuecomment-403969529","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22146","id":403969529,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzk2OTUyOQ==","user":{"login":"illfated","id":38162891,"node_id":"MDQ6VXNlcjM4MTYyODkx","avatar_url":"https://avatars3.githubusercontent.com/u/38162891?v=4","gravatar_id":"","url":"https://api.github.com/users/illfated","html_url":"https://github.com/illfated","followers_url":"https://api.github.com/users/illfated/followers","following_url":"https://api.github.com/users/illfated/following{/other_user}","gists_url":"https://api.github.com/users/illfated/gists{/gist_id}","starred_url":"https://api.github.com/users/illfated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illfated/subscriptions","organizations_url":"https://api.github.com/users/illfated/orgs","repos_url":"https://api.github.com/users/illfated/repos","events_url":"https://api.github.com/users/illfated/events{/privacy}","received_events_url":"https://api.github.com/users/illfated/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T21:19:42Z","updated_at":"2018-07-10T21:19:42Z","author_association":"NONE","body":"Title suggestion: **[3.3.5] Core/Entities: Template Optimizer for Locales**"}}
{"actor":{"display_login":"illfated"}}