{"action":"created","issue":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/992","repository_url":"https://api.github.com/repos/WPO-Foundation/webpagetest","labels_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/992/labels{/name}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/992/comments","events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/992/events","html_url":"https://github.com/WPO-Foundation/webpagetest/issues/992","id":275110301,"number":992,"title":"Windows agents make requests that should be blocked","user":{"login":"wildlyinaccurate","id":794263,"avatar_url":"https://avatars3.githubusercontent.com/u/794263?v=4","gravatar_id":"","url":"https://api.github.com/users/wildlyinaccurate","html_url":"https://github.com/wildlyinaccurate","followers_url":"https://api.github.com/users/wildlyinaccurate/followers","following_url":"https://api.github.com/users/wildlyinaccurate/following{/other_user}","gists_url":"https://api.github.com/users/wildlyinaccurate/gists{/gist_id}","starred_url":"https://api.github.com/users/wildlyinaccurate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildlyinaccurate/subscriptions","organizations_url":"https://api.github.com/users/wildlyinaccurate/orgs","repos_url":"https://api.github.com/users/wildlyinaccurate/repos","events_url":"https://api.github.com/users/wildlyinaccurate/events{/privacy}","received_events_url":"https://api.github.com/users/wildlyinaccurate/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-18T21:12:43Z","updated_at":"2018-02-15T18:06:51Z","closed_at":"2018-02-15T18:06:51Z","author_association":"NONE","body":"I've noticed that the Windows WPT agents don't block all requests that match the `block`, `blockDomains`, and `blockDomainsExcept` script directives.\r\n\r\nHere's a test on a Dulles Windows agent which makes a request to www.google.com when it shouldn't: https://www.webpagetest.org/result/171118_A1_3e6dfa8f0f89dc3d65984a67a44e9180/1/details/\r\n\r\nAnd here's the same test on a EC2 Linux agent which correctly blocks the request: https://www.webpagetest.org/result/171118_T8_e462e2d458725768219d93bd282b4e71/1/details/\r\n\r\nI've tried various combinations of the `block` directives but the Windows agents always seem to make the request."},"comment":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/comments/366012240","html_url":"https://github.com/WPO-Foundation/webpagetest/issues/992#issuecomment-366012240","issue_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/992","id":366012240,"user":{"login":"pmeenan","id":444165,"avatar_url":"https://avatars2.githubusercontent.com/u/444165?v=4","gravatar_id":"","url":"https://api.github.com/users/pmeenan","html_url":"https://github.com/pmeenan","followers_url":"https://api.github.com/users/pmeenan/followers","following_url":"https://api.github.com/users/pmeenan/following{/other_user}","gists_url":"https://api.github.com/users/pmeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeenan/subscriptions","organizations_url":"https://api.github.com/users/pmeenan/orgs","repos_url":"https://api.github.com/users/pmeenan/repos","events_url":"https://api.github.com/users/pmeenan/events{/privacy}","received_events_url":"https://api.github.com/users/pmeenan/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T18:06:51Z","updated_at":"2018-02-15T18:06:51Z","author_association":"CONTRIBUTOR","body":"All of the agents have been migrated to the new codebase (wptagent) and the blocking is now consistently supported across Windows and Linux (and across browsers except for iOS)."}}
{"actor":{"display_login":"pmeenan"}}