{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/agent/pulls/comments/215341705","pull_request_review_id":152584228,"id":215341705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM0MTcwNQ==","diff_hunk":"@@ -209,7 +210,13 @@ func (c *serialChannel) listen() (net.Listener, error) {\n func (c *serialChannel) teardown() error {\n \t// wait for the session to be fully shutdown first\n \tif c.waitCh != nil {\n-\t\t<-c.waitCh\n+\t\tt := time.NewTimer(channelCloseTimeout)\n+\t\tselect {\n+\t\tcase <-c.waitCh:\n+\t\t\tt.Stop()","path":"channel.go","position":16,"original_position":16,"commit_id":"1d559a7cf00a95b93ab4f55950f8a7cc3538d3c0","original_commit_id":"1d559a7cf00a95b93ab4f55950f8a7cc3538d3c0","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"body":"No, that's not necessary. That comment is to prevent accidental read from the timer channel but in our case the function returns and nothing is reading that channel. ","created_at":"2018-09-05T16:32:54Z","updated_at":"2018-09-05T16:32:54Z","html_url":"https://github.com/kata-containers/agent/pull/360#discussion_r215341705","pull_request_url":"https://api.github.com/repos/kata-containers/agent/pulls/360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/comments/215341705"},"html":{"href":"https://github.com/kata-containers/agent/pull/360#discussion_r215341705"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/360"}},"in_reply_to_id":215326006},"pull_request":{"url":"https://api.github.com/repos/kata-containers/agent/pulls/360","id":213325338,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzI1MzM4","html_url":"https://github.com/kata-containers/agent/pull/360","diff_url":"https://github.com/kata-containers/agent/pull/360.diff","patch_url":"https://github.com/kata-containers/agent/pull/360.patch","issue_url":"https://api.github.com/repos/kata-containers/agent/issues/360","number":360,"state":"open","locked":false,"title":"channel: add serial yamux channel close timeout","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"body":"So that if serial yamux session fails to close somehow,\r\nwe can catch it.\r\n\r\nFixes: #359","created_at":"2018-09-05T14:56:44Z","updated_at":"2018-09-05T16:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f15cd5e041591481fc2a538417ee9675f9ad22b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":834186873,"node_id":"MDU6TGFiZWw4MzQxODY4NzM=","url":"https://api.github.com/repos/kata-containers/agent/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/agent/pulls/360/commits","review_comments_url":"https://api.github.com/repos/kata-containers/agent/pulls/360/comments","review_comment_url":"https://api.github.com/repos/kata-containers/agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/agent/issues/360/comments","statuses_url":"https://api.github.com/repos/kata-containers/agent/statuses/1d559a7cf00a95b93ab4f55950f8a7cc3538d3c0","head":{"label":"bergwolf:timeout","ref":"timeout","sha":"1d559a7cf00a95b93ab4f55950f8a7cc3538d3c0","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"repo":{"id":111868063,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjgwNjM=","name":"kata-agent","full_name":"bergwolf/kata-agent","owner":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bergwolf/kata-agent","description":"Virtual Machine agent for hardware virtualized containers","fork":true,"url":"https://api.github.com/repos/bergwolf/kata-agent","forks_url":"https://api.github.com/repos/bergwolf/kata-agent/forks","keys_url":"https://api.github.com/repos/bergwolf/kata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bergwolf/kata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bergwolf/kata-agent/teams","hooks_url":"https://api.github.com/repos/bergwolf/kata-agent/hooks","issue_events_url":"https://api.github.com/repos/bergwolf/kata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/bergwolf/kata-agent/events","assignees_url":"https://api.github.com/repos/bergwolf/kata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/bergwolf/kata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/bergwolf/kata-agent/tags","blobs_url":"https://api.github.com/repos/bergwolf/kata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bergwolf/kata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bergwolf/kata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/bergwolf/kata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bergwolf/kata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/bergwolf/kata-agent/languages","stargazers_url":"https://api.github.com/repos/bergwolf/kata-agent/stargazers","contributors_url":"https://api.github.com/repos/bergwolf/kata-agent/contributors","subscribers_url":"https://api.github.com/repos/bergwolf/kata-agent/subscribers","subscription_url":"https://api.github.com/repos/bergwolf/kata-agent/subscription","commits_url":"https://api.github.com/repos/bergwolf/kata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/bergwolf/kata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/bergwolf/kata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/bergwolf/kata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/bergwolf/kata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/bergwolf/kata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bergwolf/kata-agent/merges","archive_url":"https://api.github.com/repos/bergwolf/kata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bergwolf/kata-agent/downloads","issues_url":"https://api.github.com/repos/bergwolf/kata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/bergwolf/kata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/bergwolf/kata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/bergwolf/kata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bergwolf/kata-agent/labels{/name}","releases_url":"https://api.github.com/repos/bergwolf/kata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/bergwolf/kata-agent/deployments","created_at":"2017-11-24T02:35:03Z","updated_at":"2018-04-20T07:21:02Z","pushed_at":"2018-09-05T14:53:51Z","git_url":"git://github.com/bergwolf/kata-agent.git","ssh_url":"git@github.com:bergwolf/kata-agent.git","clone_url":"https://github.com/bergwolf/kata-agent.git","svn_url":"https://github.com/bergwolf/kata-agent","homepage":null,"size":5339,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"7c95a50ef97052bf7f5566dcca53d6611f7458ac","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110538699,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzg2OTk=","name":"agent","full_name":"kata-containers/agent","owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kata-containers/agent","description":"Virtual Machine agent for hardware virtualized containers","fork":false,"url":"https://api.github.com/repos/kata-containers/agent","forks_url":"https://api.github.com/repos/kata-containers/agent/forks","keys_url":"https://api.github.com/repos/kata-containers/agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/agent/teams","hooks_url":"https://api.github.com/repos/kata-containers/agent/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/agent/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/agent/events","assignees_url":"https://api.github.com/repos/kata-containers/agent/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/agent/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/agent/tags","blobs_url":"https://api.github.com/repos/kata-containers/agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/agent/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/agent/languages","stargazers_url":"https://api.github.com/repos/kata-containers/agent/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/agent/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/agent/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/agent/subscription","commits_url":"https://api.github.com/repos/kata-containers/agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/agent/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/agent/merges","archive_url":"https://api.github.com/repos/kata-containers/agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/agent/downloads","issues_url":"https://api.github.com/repos/kata-containers/agent/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/agent/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/agent/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/agent/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/agent/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/agent/deployments","created_at":"2017-11-13T11:15:36Z","updated_at":"2018-09-04T12:20:52Z","pushed_at":"2018-09-05T14:56:44Z","git_url":"git://github.com/kata-containers/agent.git","ssh_url":"git@github.com:kata-containers/agent.git","clone_url":"https://github.com/kata-containers/agent.git","svn_url":"https://github.com/kata-containers/agent","homepage":null,"size":5265,"stargazers_count":130,"watchers_count":130,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":47,"open_issues":40,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/360"},"html":{"href":"https://github.com/kata-containers/agent/pull/360"},"issue":{"href":"https://api.github.com/repos/kata-containers/agent/issues/360"},"comments":{"href":"https://api.github.com/repos/kata-containers/agent/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/agent/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/agent/statuses/1d559a7cf00a95b93ab4f55950f8a7cc3538d3c0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bergwolf"}}