{"action":"created","issue":{"url":"https://api.github.com/repos/boris-kz/CogAlg/issues/4","repository_url":"https://api.github.com/repos/boris-kz/CogAlg","labels_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/4/comments","events_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/4/events","html_url":"https://github.com/boris-kz/CogAlg/pull/4","id":294065918,"number":4,"title":"Explicitly suggesting that P in scan_P_ is a partial pattern, while P_ and _P_ are complete","user":{"login":"Twenkid","id":23367640,"avatar_url":"https://avatars2.githubusercontent.com/u/23367640?v=4","gravatar_id":"","url":"https://api.github.com/users/Twenkid","html_url":"https://github.com/Twenkid","followers_url":"https://api.github.com/users/Twenkid/followers","following_url":"https://api.github.com/users/Twenkid/following{/other_user}","gists_url":"https://api.github.com/users/Twenkid/gists{/gist_id}","starred_url":"https://api.github.com/users/Twenkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twenkid/subscriptions","organizations_url":"https://api.github.com/users/Twenkid/orgs","repos_url":"https://api.github.com/users/Twenkid/repos","events_url":"https://api.github.com/users/Twenkid/events{/privacy}","received_events_url":"https://api.github.com/users/Twenkid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-03T00:46:41Z","updated_at":"2018-02-04T04:16:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/boris-kz/CogAlg/pulls/4","html_url":"https://github.com/boris-kz/CogAlg/pull/4","diff_url":"https://github.com/boris-kz/CogAlg/pull/4.diff","patch_url":"https://github.com/boris-kz/CogAlg/pull/4.patch"},"body":"\r\nRegarding scan_P_:\r\n Todor: it's reasonable to mention that P, the input parameter, is a partial pattern, send by form_P:\r\n ```\r\nP = pri_s, I, D, Dy, M, My, G, alt_rdn, e_\r\n While the P taken from the P_ or _P_ are complete patterns, with a different sequence:\r\n P = s, ix, x, I, D, Dy, M, My, G, alt_rdn, e_, alt_ \r\n```\r\n That's confusing on first read, because by default the same name suggests a list of the same type,\r\n however then below `scan_P_ reads P[0][1]` with a comment as ix, i.e. a different type. \r\n Yes, it becomes clear when studying more and seeing that` P_ `is filled later etc., also by keeping in mind\r\n that the above P in form_P is commented as \"partial\". However, using the same name confuses and I think suggesting\r\n the difference more explicitly at least with a comment would speed up code understanding.\r\n Alternatively, mnemonically suggesting that partial patterns are such, for example pP, Pp or something in the input parameter of the function or in form_P also.\r\n"},"comment":{"url":"https://api.github.com/repos/boris-kz/CogAlg/issues/comments/362879553","html_url":"https://github.com/boris-kz/CogAlg/pull/4#issuecomment-362879553","issue_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/4","id":362879553,"user":{"login":"boris-kz","id":20977433,"avatar_url":"https://avatars0.githubusercontent.com/u/20977433?v=4","gravatar_id":"","url":"https://api.github.com/users/boris-kz","html_url":"https://github.com/boris-kz","followers_url":"https://api.github.com/users/boris-kz/followers","following_url":"https://api.github.com/users/boris-kz/following{/other_user}","gists_url":"https://api.github.com/users/boris-kz/gists{/gist_id}","starred_url":"https://api.github.com/users/boris-kz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boris-kz/subscriptions","organizations_url":"https://api.github.com/users/boris-kz/orgs","repos_url":"https://api.github.com/users/boris-kz/repos","events_url":"https://api.github.com/users/boris-kz/events{/privacy}","received_events_url":"https://api.github.com/users/boris-kz/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T04:16:47Z","updated_at":"2018-02-04T04:16:47Z","author_association":"OWNER","body":"> 1.) I noticed that differences branch of the gradient variables doesn't have a \"filter\" (initially - average).\r\n\r\ndP is defined by comparison to shorter-range feedback: prior input, \r\nvP is defined by comparison to higher (prior) - level feedback: filter. \r\nThese are are different orders of patterns  \r\n\r\n\r\n2.) The alt-value for alt_len is taken always from the dP branch of form_P.\r\n(First vP branch is called, then dP, they use the same ident \"alt\", so the value of the last one is used)\r\n\r\nThey both use the same local variable alt. It is the same because it's an overlap between the two.\r\nIt's a measure of redundancy to eventually increment filter A for the weaker of the two.\r\nBut smaller-scale differences in value are minor and probably don't justify the costs of adjusting filter. \r\nSo, alt_len is summed and buffered until 2D patterns terminate, and then the filter for the weaker one is adjusted. This is still tentative, part of that redundancy adjustment problem.\r\n\r\n> if alt_vG > alt_dG: # comp of alt_vG to alt_dG, == goes to alt_P or to vP: primary?\r\nvP[7] += alt_len # alt_len is added to redundant overlap of lesser-oG- vP or dP\r\nelse:\r\ndP[7] += alt_len\r\n> Both patterns are updated with the difference-pattern's alt_len.\r\n\r\nNo, only the weaker (redundant) of the two is updated by shared alt_len, see above.\r\n\r\n> 3.) Then comes:\r\ns = 1 if g > 0 else 0\r\nif s != pri_s and x > rng + 2: #\r\nThe sign s marks the first \"above/below\"-filter comparison. The gradient \"g\" is the \"positive match\" and it's combined (summed): the match to previous pixel on the left, and on top: vg = _m + fmy - ave # v gradient.\r\n> Again referring to 1. - the lack of \"ave\" filter for difference - the filter is 0?\r\n\r\nThe equivalent of filter for dP is prior input. It is defined by the sign of difference, not by the sign of value."}}
{"actor":{"display_login":"boris-kz"}}