{"action":"closed","issue":{"url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo/issues/11","repository_url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo","labels_url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo/issues/11/comments","events_url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo/issues/11/events","html_url":"https://github.com/duckietown/sim-duckiebot-lanefollowing-demo/issues/11","id":378526044,"node_id":"MDU6SXNzdWUzNzg1MjYwNDQ=","number":11,"title":"Overlaying workspace feedback","user":{"login":"breandan","id":175716,"node_id":"MDQ6VXNlcjE3NTcxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/175716?v=4","gravatar_id":"","url":"https://api.github.com/users/breandan","html_url":"https://github.com/breandan","followers_url":"https://api.github.com/users/breandan/followers","following_url":"https://api.github.com/users/breandan/following{/other_user}","gists_url":"https://api.github.com/users/breandan/gists{/gist_id}","starred_url":"https://api.github.com/users/breandan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breandan/subscriptions","organizations_url":"https://api.github.com/users/breandan/orgs","repos_url":"https://api.github.com/users/breandan/repos","events_url":"https://api.github.com/users/breandan/events{/privacy}","received_events_url":"https://api.github.com/users/breandan/received_events","type":"User","site_admin":false},"labels":[{"id":970584502,"node_id":"MDU6TGFiZWw5NzA1ODQ1MDI=","url":"https://api.github.com/repos/duckietown/sim-duckiebot-lanefollowing-demo/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"closed","locked":false,"assignee":{"login":"bhairavmehta95","id":10503729,"node_id":"MDQ6VXNlcjEwNTAzNzI5","avatar_url":"https://avatars0.githubusercontent.com/u/10503729?v=4","gravatar_id":"","url":"https://api.github.com/users/bhairavmehta95","html_url":"https://github.com/bhairavmehta95","followers_url":"https://api.github.com/users/bhairavmehta95/followers","following_url":"https://api.github.com/users/bhairavmehta95/following{/other_user}","gists_url":"https://api.github.com/users/bhairavmehta95/gists{/gist_id}","starred_url":"https://api.github.com/users/bhairavmehta95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhairavmehta95/subscriptions","organizations_url":"https://api.github.com/users/bhairavmehta95/orgs","repos_url":"https://api.github.com/users/bhairavmehta95/repos","events_url":"https://api.github.com/users/bhairavmehta95/events{/privacy}","received_events_url":"https://api.github.com/users/bhairavmehta95/received_events","type":"User","site_admin":false},"assignees":[{"login":"bhairavmehta95","id":10503729,"node_id":"MDQ6VXNlcjEwNTAzNzI5","avatar_url":"https://avatars0.githubusercontent.com/u/10503729?v=4","gravatar_id":"","url":"https://api.github.com/users/bhairavmehta95","html_url":"https://github.com/bhairavmehta95","followers_url":"https://api.github.com/users/bhairavmehta95/followers","following_url":"https://api.github.com/users/bhairavmehta95/following{/other_user}","gists_url":"https://api.github.com/users/bhairavmehta95/gists{/gist_id}","starred_url":"https://api.github.com/users/bhairavmehta95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhairavmehta95/subscriptions","organizations_url":"https://api.github.com/users/bhairavmehta95/orgs","repos_url":"https://api.github.com/users/bhairavmehta95/repos","events_url":"https://api.github.com/users/bhairavmehta95/events{/privacy}","received_events_url":"https://api.github.com/users/bhairavmehta95/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-11-08T00:21:18Z","updated_at":"2018-11-08T23:40:02Z","closed_at":"2018-11-08T23:40:02Z","author_association":"MEMBER","body":"Nice work on the workspace overlaying, this was a good idea. Some early feedback: after walking through the [new documentation](http://docs.duckietown.org/DT18/AIDO/out/ros_baseline.html#sub:autoid-DO-NOT-USE-THIS-VERY-UNSTABLE-LINK-28914b9a-39) with @maivincent, we encountered two issues. \r\n\r\n- [x] First, we needed to run `docker-compose -f docker-compose-lf.yml build` in order to rebuild the Dockerfiles - it would be helpful to mention this somewhere in the documentation.\r\n\r\n- [x] Second and more problematically, we were unable to add a node using the `roslaunch` [configuration method](http://wiki.ros.org/roslaunch/XML/node), i.e. by adding a `<node.../>` tag to the `lf_slim.launch` file (since the `lanefollow` container does not have access to the recompiled catkin artifacts, and thus cannot find the [`dt_dependent_node` referenced in `lf_slim.launch`](https://github.com/duckietown/sim-duckiebot-lanefollowing-demo/blob/bbc715d1aee305973abc93d8609e28919d48e772/lf_slim.launch#L81) file, even though we added the `dt_dependent_node` and its enclosing package to the project directory).\r\n\r\n- [x] While we were able to use the [`rosrun` command to start a node](https://github.com/duckietown/sim-duckiebot-lanefollowing-demo/blob/bbc715d1aee305973abc93d8609e28919d48e772/docker-compose-lf.yml#L70), after several variations of modifying the `docker-compose-lf.yml` file, we ran out of ideas for configuring the `roslaunch` file with the `dt_dependent_node` placeholder.\r\n\r\n- [x] We figured the documentation could use a few more cycles to make this workflow a bit clearer - as we discussed this afternoon, a guide on how to copy a package from the `duckietown/software` repository would be a helpful addition. Please let Vincent or I know if you need any help or further details. Thank you."}}
{"actor":{"display_login":"bhairavmehta95"}}