{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/237702117","pull_request_review_id":180068176,"id":237702117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzcwMjExNw==","diff_hunk":"@@ -379,6 +389,11 @@ class TR_J9ByteCodeIlGenerator : public TR_IlGenerator, public TR_J9ByteCodeIter\n    // JSR292\n    int32_t                           _argPlaceholderSlot;\n    int32_t                           _argPlaceholderSignatureOffset;\n+   TR::NodeChecklist                *_methodHandleInvokeNodes;\n+   TR::NodeChecklist                *_invokeHandleNodes;\n+   TR::NodeChecklist                *_invokeHandleGenericNodes;\n+   TR::NodeChecklist                *_invokeDynamicNodes;\n+   TR::NodeChecklist                *_ilGenMacroInvokeExactNodes;","path":"runtime/compiler/ilgen/J9ByteCodeIlGenerator.hpp","position":43,"original_position":43,"commit_id":"99d0cc90b1174a2fab535e26a760ddad146a7ddd","original_commit_id":"99d0cc90b1174a2fab535e26a760ddad146a7ddd","user":{"login":"jdmpapin","id":22403820,"node_id":"MDQ6VXNlcjIyNDAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/22403820?v=4","gravatar_id":"","url":"https://api.github.com/users/jdmpapin","html_url":"https://github.com/jdmpapin","followers_url":"https://api.github.com/users/jdmpapin/followers","following_url":"https://api.github.com/users/jdmpapin/following{/other_user}","gists_url":"https://api.github.com/users/jdmpapin/gists{/gist_id}","starred_url":"https://api.github.com/users/jdmpapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdmpapin/subscriptions","organizations_url":"https://api.github.com/users/jdmpapin/orgs","repos_url":"https://api.github.com/users/jdmpapin/repos","events_url":"https://api.github.com/users/jdmpapin/events{/privacy}","received_events_url":"https://api.github.com/users/jdmpapin/received_events","type":"User","site_admin":false},"body":"Using `NodeChecklist` for this will break if a node of interest is duplicated, e.g. because of a catch block catching multiple exception types. This happened before with `expandInvokeSpecialInterface()`, which is why `_invokeSpecialInterfaceCalls` identifies the calls by their bytecode indices.","created_at":"2018-11-29T23:45:48Z","updated_at":"2018-11-29T23:46:21Z","html_url":"https://github.com/eclipse/openj9/pull/3877#discussion_r237702117","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/3877","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/237702117"},"html":{"href":"https://github.com/eclipse/openj9/pull/3877#discussion_r237702117"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3877"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3877","id":234665512,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjY1NTEy","html_url":"https://github.com/eclipse/openj9/pull/3877","diff_url":"https://github.com/eclipse/openj9/pull/3877.diff","patch_url":"https://github.com/eclipse/openj9/pull/3877.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3877","number":3877,"state":"open","locked":false,"title":"Expand MethodHandle invoke calls after walker","user":{"login":"liqunl","id":19654275,"node_id":"MDQ6VXNlcjE5NjU0Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/19654275?v=4","gravatar_id":"","url":"https://api.github.com/users/liqunl","html_url":"https://github.com/liqunl","followers_url":"https://api.github.com/users/liqunl/followers","following_url":"https://api.github.com/users/liqunl/following{/other_user}","gists_url":"https://api.github.com/users/liqunl/gists{/gist_id}","starred_url":"https://api.github.com/users/liqunl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqunl/subscriptions","organizations_url":"https://api.github.com/users/liqunl/orgs","repos_url":"https://api.github.com/users/liqunl/repos","events_url":"https://api.github.com/users/liqunl/events{/privacy}","received_events_url":"https://api.github.com/users/liqunl/received_events","type":"User","site_admin":false},"body":"One or more extra calls are generated for MethodHandle invoke in walker,\r\nadding the difficulty to do OSR bookkeeping. This commit will move the\r\nextra call creations to post-walker.\r\n\r\nSigned-off-by: Liqun Liu <liqunl@ca.ibm.com>","created_at":"2018-11-29T14:49:53Z","updated_at":"2018-11-29T23:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bde5a1e89146953f6bf9aed954fd87e71f930b30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962585,"node_id":"MDU6TGFiZWw2OTc5NjI1ODU=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:jit","name":"comp:jit","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3877/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3877/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3877/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/99d0cc90b1174a2fab535e26a760ddad146a7ddd","head":{"label":"liqunl:mh","ref":"mh","sha":"99d0cc90b1174a2fab535e26a760ddad146a7ddd","user":{"login":"liqunl","id":19654275,"node_id":"MDQ6VXNlcjE5NjU0Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/19654275?v=4","gravatar_id":"","url":"https://api.github.com/users/liqunl","html_url":"https://github.com/liqunl","followers_url":"https://api.github.com/users/liqunl/followers","following_url":"https://api.github.com/users/liqunl/following{/other_user}","gists_url":"https://api.github.com/users/liqunl/gists{/gist_id}","starred_url":"https://api.github.com/users/liqunl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqunl/subscriptions","organizations_url":"https://api.github.com/users/liqunl/orgs","repos_url":"https://api.github.com/users/liqunl/repos","events_url":"https://api.github.com/users/liqunl/events{/privacy}","received_events_url":"https://api.github.com/users/liqunl/received_events","type":"User","site_admin":false},"repo":{"id":104359287,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzNTkyODc=","name":"openj9","full_name":"liqunl/openj9","private":false,"owner":{"login":"liqunl","id":19654275,"node_id":"MDQ6VXNlcjE5NjU0Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/19654275?v=4","gravatar_id":"","url":"https://api.github.com/users/liqunl","html_url":"https://github.com/liqunl","followers_url":"https://api.github.com/users/liqunl/followers","following_url":"https://api.github.com/users/liqunl/following{/other_user}","gists_url":"https://api.github.com/users/liqunl/gists{/gist_id}","starred_url":"https://api.github.com/users/liqunl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqunl/subscriptions","organizations_url":"https://api.github.com/users/liqunl/orgs","repos_url":"https://api.github.com/users/liqunl/repos","events_url":"https://api.github.com/users/liqunl/events{/privacy}","received_events_url":"https://api.github.com/users/liqunl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liqunl/openj9","description":"Eclipse OpenJ9","fork":true,"url":"https://api.github.com/repos/liqunl/openj9","forks_url":"https://api.github.com/repos/liqunl/openj9/forks","keys_url":"https://api.github.com/repos/liqunl/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqunl/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqunl/openj9/teams","hooks_url":"https://api.github.com/repos/liqunl/openj9/hooks","issue_events_url":"https://api.github.com/repos/liqunl/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/liqunl/openj9/events","assignees_url":"https://api.github.com/repos/liqunl/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/liqunl/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/liqunl/openj9/tags","blobs_url":"https://api.github.com/repos/liqunl/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqunl/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqunl/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqunl/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqunl/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/liqunl/openj9/languages","stargazers_url":"https://api.github.com/repos/liqunl/openj9/stargazers","contributors_url":"https://api.github.com/repos/liqunl/openj9/contributors","subscribers_url":"https://api.github.com/repos/liqunl/openj9/subscribers","subscription_url":"https://api.github.com/repos/liqunl/openj9/subscription","commits_url":"https://api.github.com/repos/liqunl/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqunl/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqunl/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqunl/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqunl/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/liqunl/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqunl/openj9/merges","archive_url":"https://api.github.com/repos/liqunl/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqunl/openj9/downloads","issues_url":"https://api.github.com/repos/liqunl/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/liqunl/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/liqunl/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/liqunl/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqunl/openj9/labels{/name}","releases_url":"https://api.github.com/repos/liqunl/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/liqunl/openj9/deployments","created_at":"2017-09-21T14:33:49Z","updated_at":"2018-06-06T13:43:29Z","pushed_at":"2018-11-29T22:21:21Z","git_url":"git://github.com/liqunl/openj9.git","ssh_url":"git@github.com:liqunl/openj9.git","clone_url":"https://github.com/liqunl/openj9.git","svn_url":"https://github.com/liqunl/openj9","homepage":"","size":37557,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"1aba67ab3c584b2cf11200955da532f1a70eaf2c","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-11-29T21:33:14Z","pushed_at":"2018-11-29T22:43:11Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":39332,"stargazers_count":1538,"watchers_count":1538,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":301,"mirror_url":null,"archived":false,"open_issues_count":630,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":301,"open_issues":630,"watchers":1538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3877"},"html":{"href":"https://github.com/eclipse/openj9/pull/3877"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3877"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3877/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3877/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3877/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/99d0cc90b1174a2fab535e26a760ddad146a7ddd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdmpapin"}}