{"action":"created","issue":{"url":"https://api.github.com/repos/BrightspaceUI/button/issues/139","repository_url":"https://api.github.com/repos/BrightspaceUI/button","labels_url":"https://api.github.com/repos/BrightspaceUI/button/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/BrightspaceUI/button/issues/139/comments","events_url":"https://api.github.com/repos/BrightspaceUI/button/issues/139/events","html_url":"https://github.com/BrightspaceUI/button/pull/139","id":369323525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjkzNzgz","number":139,"title":"prevent user tapping and triggering action when a button is disabled","user":{"login":"stevenao","id":3785788,"node_id":"MDQ6VXNlcjM3ODU3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3785788?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenao","html_url":"https://github.com/stevenao","followers_url":"https://api.github.com/users/stevenao/followers","following_url":"https://api.github.com/users/stevenao/following{/other_user}","gists_url":"https://api.github.com/users/stevenao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenao/subscriptions","organizations_url":"https://api.github.com/users/stevenao/orgs","repos_url":"https://api.github.com/users/stevenao/repos","events_url":"https://api.github.com/users/stevenao/events{/privacy}","received_events_url":"https://api.github.com/users/stevenao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T22:05:59Z","updated_at":"2018-10-12T03:32:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/BrightspaceUI/button/pulls/139","html_url":"https://github.com/BrightspaceUI/button/pull/139","diff_url":"https://github.com/BrightspaceUI/button/pull/139.diff","patch_url":"https://github.com/BrightspaceUI/button/pull/139.patch"},"body":"Background: Native html button prevents user from clicking when it is disabled. However, our custom buttons doesn't prevent user from clicking and actions associated with it still get triggered.\r\n\r\nThis pull request is to prevent user from clicking our custom buttons when they are disabled. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/BrightspaceUI/button/issues/comments/429193250","html_url":"https://github.com/BrightspaceUI/button/pull/139#issuecomment-429193250","issue_url":"https://api.github.com/repos/BrightspaceUI/button/issues/139","id":429193250,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE5MzI1MA==","user":{"login":"stevenao","id":3785788,"node_id":"MDQ6VXNlcjM3ODU3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3785788?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenao","html_url":"https://github.com/stevenao","followers_url":"https://api.github.com/users/stevenao/followers","following_url":"https://api.github.com/users/stevenao/following{/other_user}","gists_url":"https://api.github.com/users/stevenao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenao/subscriptions","organizations_url":"https://api.github.com/users/stevenao/orgs","repos_url":"https://api.github.com/users/stevenao/repos","events_url":"https://api.github.com/users/stevenao/events{/privacy}","received_events_url":"https://api.github.com/users/stevenao/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T03:32:05Z","updated_at":"2018-10-12T03:32:05Z","author_association":"NONE","body":"Before using `pointer-events`, I actually tried to handle it in the button behaviour listeners for tap event. That is effectively putting an on-tap event listener to handle the button disabled before other handlers that handle actual button action. However, in the button disable handler, both stop propagation and prevent default don't actually stop the even flow. I also tried `return false` there. \r\n\r\nI think stop propagation is just for stopping the event bubbling up the DOM. In the case, the event is happening within the same DOM element?"}}
{"actor":{"display_login":"stevenao"}}