{"action":"opened","number":131,"pull_request":{"url":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131","id":224865549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODY1NTQ5","html_url":"https://github.com/pact-foundation/pact-node/pull/131","diff_url":"https://github.com/pact-foundation/pact-node/pull/131.diff","patch_url":"https://github.com/pact-foundation/pact-node/pull/131.patch","issue_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/131","number":131,"state":"open","locked":false,"title":"build(deps): Fix GitHub warning by updating request from 2.83.0 to 2.87.0","user":{"login":"TimothyJones","id":914369,"node_id":"MDQ6VXNlcjkxNDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/914369?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyJones","html_url":"https://github.com/TimothyJones","followers_url":"https://api.github.com/users/TimothyJones/followers","following_url":"https://api.github.com/users/TimothyJones/following{/other_user}","gists_url":"https://api.github.com/users/TimothyJones/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyJones/subscriptions","organizations_url":"https://api.github.com/users/TimothyJones/orgs","repos_url":"https://api.github.com/users/TimothyJones/repos","events_url":"https://api.github.com/users/TimothyJones/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyJones/received_events","type":"User","site_admin":false},"body":"# The problem\r\n\r\nCurrently a repository including `pact-node` gets the following warnings in the GitHub gui:\r\n\r\n![screen shot 2018-10-23 at 12 27 12 pm](https://user-images.githubusercontent.com/914369/47329077-18ebbc00-d6bf-11e8-9761-da1622c478db.png)\r\n\r\n![screen shot 2018-10-23 at 12 26 50 pm](https://user-images.githubusercontent.com/914369/47329043-f35eb280-d6be-11e8-9ca9-ab07b15df0b5.png)\r\n\r\nFor `request@2.83.0`,  the problem library `cryptiles` was brought in by `hawk`:\r\n\r\n```\r\n$ npm ls cryptiles\r\n@pact-foundation/pact-node@6.19.11 /Users/work/office/pact/pact-node\r\n└─┬ request@2.83.0\r\n  └─┬ hawk@6.0.2\r\n    └── cryptiles@3.1.2\r\n```\r\n\r\n# The solution\r\n\r\nThis PR upgrades `request`. Since later versions of request no longer depend on `hawk` or `cryptiles`, this will remove the warning in future releases.\r\n\r\n```\r\n$ npm ls cryptiles\r\n@pact-foundation/pact-node@6.19.11 /Users/work/office/pact/pact-node\r\n└── (empty)\r\n```\r\n\r\n*Aside:* The latest version of `request` is actually `2.88.0` (as suggested by [this dependabot PR](https://github.com/pact-foundation/pact-node/pull/130)). However, the [travis build for 2.88.0](https://travis-ci.org/request/request/jobs/414594405) fails with lots of test errors, so I don't think we should use it. This is also further evidence that dependabot isn't very useful for us (at least in this configuration).","created_at":"2018-10-23T01:36:30Z","updated_at":"2018-10-23T01:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131/commits","review_comments_url":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131/comments","review_comment_url":"https://api.github.com/repos/pact-foundation/pact-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/131/comments","statuses_url":"https://api.github.com/repos/pact-foundation/pact-node/statuses/f3738ca6f94328a84fcff54ae4331b2baa42fbc1","head":{"label":"pact-foundation:upgrade-request","ref":"upgrade-request","sha":"f3738ca6f94328a84fcff54ae4331b2baa42fbc1","user":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":41724213,"node_id":"MDEwOlJlcG9zaXRvcnk0MTcyNDIxMw==","name":"pact-node","full_name":"pact-foundation/pact-node","private":false,"owner":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pact-foundation/pact-node","description":"Node version of Pact, a Contract Testing Framework","fork":false,"url":"https://api.github.com/repos/pact-foundation/pact-node","forks_url":"https://api.github.com/repos/pact-foundation/pact-node/forks","keys_url":"https://api.github.com/repos/pact-foundation/pact-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pact-foundation/pact-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pact-foundation/pact-node/teams","hooks_url":"https://api.github.com/repos/pact-foundation/pact-node/hooks","issue_events_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/events{/number}","events_url":"https://api.github.com/repos/pact-foundation/pact-node/events","assignees_url":"https://api.github.com/repos/pact-foundation/pact-node/assignees{/user}","branches_url":"https://api.github.com/repos/pact-foundation/pact-node/branches{/branch}","tags_url":"https://api.github.com/repos/pact-foundation/pact-node/tags","blobs_url":"https://api.github.com/repos/pact-foundation/pact-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pact-foundation/pact-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pact-foundation/pact-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/pact-foundation/pact-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pact-foundation/pact-node/statuses/{sha}","languages_url":"https://api.github.com/repos/pact-foundation/pact-node/languages","stargazers_url":"https://api.github.com/repos/pact-foundation/pact-node/stargazers","contributors_url":"https://api.github.com/repos/pact-foundation/pact-node/contributors","subscribers_url":"https://api.github.com/repos/pact-foundation/pact-node/subscribers","subscription_url":"https://api.github.com/repos/pact-foundation/pact-node/subscription","commits_url":"https://api.github.com/repos/pact-foundation/pact-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/pact-foundation/pact-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/pact-foundation/pact-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/pact-foundation/pact-node/contents/{+path}","compare_url":"https://api.github.com/repos/pact-foundation/pact-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pact-foundation/pact-node/merges","archive_url":"https://api.github.com/repos/pact-foundation/pact-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pact-foundation/pact-node/downloads","issues_url":"https://api.github.com/repos/pact-foundation/pact-node/issues{/number}","pulls_url":"https://api.github.com/repos/pact-foundation/pact-node/pulls{/number}","milestones_url":"https://api.github.com/repos/pact-foundation/pact-node/milestones{/number}","notifications_url":"https://api.github.com/repos/pact-foundation/pact-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pact-foundation/pact-node/labels{/name}","releases_url":"https://api.github.com/repos/pact-foundation/pact-node/releases{/id}","deployments_url":"https://api.github.com/repos/pact-foundation/pact-node/deployments","created_at":"2015-09-01T07:38:16Z","updated_at":"2018-10-15T08:50:13Z","pushed_at":"2018-10-23T01:25:48Z","git_url":"git://github.com/pact-foundation/pact-node.git","ssh_url":"git@github.com:pact-foundation/pact-node.git","clone_url":"https://github.com/pact-foundation/pact-node.git","svn_url":"https://github.com/pact-foundation/pact-node","homepage":"https://docs.pact.io","size":519,"stargazers_count":56,"watchers_count":56,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":26,"watchers":56,"default_branch":"master"}},"base":{"label":"pact-foundation:master","ref":"master","sha":"0b8793bce68094f8bbd98e101c1d140fe7726c28","user":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":41724213,"node_id":"MDEwOlJlcG9zaXRvcnk0MTcyNDIxMw==","name":"pact-node","full_name":"pact-foundation/pact-node","private":false,"owner":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pact-foundation/pact-node","description":"Node version of Pact, a Contract Testing Framework","fork":false,"url":"https://api.github.com/repos/pact-foundation/pact-node","forks_url":"https://api.github.com/repos/pact-foundation/pact-node/forks","keys_url":"https://api.github.com/repos/pact-foundation/pact-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pact-foundation/pact-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pact-foundation/pact-node/teams","hooks_url":"https://api.github.com/repos/pact-foundation/pact-node/hooks","issue_events_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/events{/number}","events_url":"https://api.github.com/repos/pact-foundation/pact-node/events","assignees_url":"https://api.github.com/repos/pact-foundation/pact-node/assignees{/user}","branches_url":"https://api.github.com/repos/pact-foundation/pact-node/branches{/branch}","tags_url":"https://api.github.com/repos/pact-foundation/pact-node/tags","blobs_url":"https://api.github.com/repos/pact-foundation/pact-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pact-foundation/pact-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pact-foundation/pact-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/pact-foundation/pact-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pact-foundation/pact-node/statuses/{sha}","languages_url":"https://api.github.com/repos/pact-foundation/pact-node/languages","stargazers_url":"https://api.github.com/repos/pact-foundation/pact-node/stargazers","contributors_url":"https://api.github.com/repos/pact-foundation/pact-node/contributors","subscribers_url":"https://api.github.com/repos/pact-foundation/pact-node/subscribers","subscription_url":"https://api.github.com/repos/pact-foundation/pact-node/subscription","commits_url":"https://api.github.com/repos/pact-foundation/pact-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/pact-foundation/pact-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/pact-foundation/pact-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/pact-foundation/pact-node/contents/{+path}","compare_url":"https://api.github.com/repos/pact-foundation/pact-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pact-foundation/pact-node/merges","archive_url":"https://api.github.com/repos/pact-foundation/pact-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pact-foundation/pact-node/downloads","issues_url":"https://api.github.com/repos/pact-foundation/pact-node/issues{/number}","pulls_url":"https://api.github.com/repos/pact-foundation/pact-node/pulls{/number}","milestones_url":"https://api.github.com/repos/pact-foundation/pact-node/milestones{/number}","notifications_url":"https://api.github.com/repos/pact-foundation/pact-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pact-foundation/pact-node/labels{/name}","releases_url":"https://api.github.com/repos/pact-foundation/pact-node/releases{/id}","deployments_url":"https://api.github.com/repos/pact-foundation/pact-node/deployments","created_at":"2015-09-01T07:38:16Z","updated_at":"2018-10-15T08:50:13Z","pushed_at":"2018-10-23T01:25:48Z","git_url":"git://github.com/pact-foundation/pact-node.git","ssh_url":"git@github.com:pact-foundation/pact-node.git","clone_url":"https://github.com/pact-foundation/pact-node.git","svn_url":"https://github.com/pact-foundation/pact-node","homepage":"https://docs.pact.io","size":519,"stargazers_count":56,"watchers_count":56,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":26,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131"},"html":{"href":"https://github.com/pact-foundation/pact-node/pull/131"},"issue":{"href":"https://api.github.com/repos/pact-foundation/pact-node/issues/131"},"comments":{"href":"https://api.github.com/repos/pact-foundation/pact-node/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/pact-foundation/pact-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pact-foundation/pact-node/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/pact-foundation/pact-node/statuses/f3738ca6f94328a84fcff54ae4331b2baa42fbc1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"TimothyJones"}}